blob: a0ed90951f7e058fb6f580725b1a55d4bbc79c88 [file] [log] [blame]
Andrew J. Schorr7f643eb2006-11-30 16:17:02 +000012006-11-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
2
3 * ospf_zebra.c: (ospf_router_id_update_zebra,
4 ospf_interface_address_add, ospf_interface_address_delete)
5 If (IS_DEBUG_OSPF (zebra, ZEBRA_INTERFACE)) is enabled, then
6 add a debug message about what Zebra is telling us.
7 (ospf_zebra_add_discard) Add a debug message matching the one
8 already in ospf_zebra_delete_discard.
9
Andrew J. Schorr43540882006-11-28 16:36:39 +0000102006-11-28 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
11
12 * ospf_vty.c: (ospf_passive_interface_default) Take additional
13 'newval' arg so we can update ospf->passive_interface_default inside
14 this function. More importantly, we now call ospf_if_set_multicast
15 on all ospf_interfaces.
16 (ospf_passive_interface, no_ospf_passive_interface) Fix bug:
17 for 'default' case, argv[0] is undefined, so we must test for
18 (argc == 0) before using argv[0]. And since
19 ospf_passive_interface_default now calls ospf_if_set_multicast as
20 needed, we can just return after calling
21 ospf_passive_interface_default.
22
Andrew J. Schorr8fb8a502006-10-24 19:04:26 +0000232006-10-24 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
24
25 * ospf_zebra.c: (ospf_redistribute_default_set) Fix bug where
26 a new value for ospf->default_originate was being ignored
27 if a previous 'default-information originate' command
28 had already been processed.
29
Paul Jakma7ffa8fa2006-10-22 20:07:53 +0000302006-10-22 Yar Tikhiy <yar@comp.chem.msu.su>
31
32 * (general) Add support for passive-interface default (with
33 minor edits by Paul Jakma).
34 * ospf_interface.h: Add OSPF_IF_PASSIVE_STATUS macro, looking
35 at configured value, or the global 'default' value, as
36 required.
37 * ospf_interface.c: (ospf_if_new_hook) Leave passive
38 unconfigured per default, allowing global 'default' to
39 take effect for unconfigured interfaces.
40 * ospf_packet.c: (various) use OSPF_IF_PASSIVE_STATUS
41 * ospf_vty.c: (ospf_passive_interface_default) new function,
42 unset passive from all interfaces if default is enabled, as
43 the per-iface settings become redundant.
44 (ospf_passive_interface_update) new func, update passive
45 setting taking global default into account.
46 ({no,}ospf_passive_interface_addr_cmd) Add support for
47 'default' variant of command.
48 (show_ip_ospf_interface_sub) Update to take global
49 default into account when printing passive status.
50 (ospf_config_write) ditto.
51 * ospfd.c: (ospf_new) set global passive-interface default.
52 * ospfd.h: (struct ospf) Add field for global
53 passive-interface.
54
Andrew J. Schorr08c83672006-09-25 13:26:14 +0000552006-09-25 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
56
57 * ospf_packet.c: (ospf_packet_dup, ospf_make_md5_digest)
58 Fix zlog_warn messages to eliminate compiler warnings.
59 (ospf_hello) Improve warning messages to show why we
60 are complaining.
61
Paul Jakmab5aeb442006-08-30 18:47:37 +0000622006-08-28 Andy Gay <andy@andynet.net>
63
64 * ospf_packet.c: (ospf_make_db_desc) Assert added with More-bit
65 fixes does not hold up with addition of Ogier DB-Exchange
66 optimisation, which can empty the db-summary list in between
67 sent DD packets. Remove assert, update More-bit always when
68 in Exchange.
69
Paul Jakma29b5a042006-08-27 08:01:20 +0000702006-08-27 J.J. Krabbendam <jkrabbendam@aimsys.nl>
71
72 * ospfd.c: (ospf_finish_final) default redistribute should be
73 unset too, fixes bug where reconfiguring ospfd completely
74 can no longer enable default redistribution.
75
Paul Jakma2518efd2006-08-27 06:49:29 +0000762006-08-25 Paul Jakma <paul.jakma@sun.com>
77
78 * (general) Bug #134. Be more robust to backward time changes,
79 use the newly added libzebra time functions.
80 In most cases: recent_time -> recent_relative_time()
81 gettimeofday -> quagga_gettime (QUAGGA_CLK_MONOTONIC, ..)
82 time -> quagga_time.
83 (ospf_make_md5_digest) time() call deliberately not changed.
84 (ospf_external_lsa_refresh) remove useless gettimeofday, LSA
85 tv_orig time was already set in ospf_lsa_new, called via
86 ospf_external_lsa_new.
87
Paul Jakmaba122e72006-08-27 06:24:34 +0000882006-08-04 Paul Jakma <paul.jakma@sun.com>
89
90 * ospf_lsdb.c: (ospf_lsdb_delete_entry) new function, consolidate
91 exact same functionality replicated in other functions.
92 (ospf_lsdb_add) Strip out code by using ospf_lsdb_delete_entry.
93 (ospf_lsdb_delete) ditto.
94 (ospf_lsdb_delete_all) ditto.
95
Paul Jakma8dd24ee2006-08-27 06:29:30 +0000962006-08-03 Paul Jakma <paul.jakma@sun.com>
97
98 * ospf_packet.c: (ospf_make_db_desc) Unset the DD More bit
99 after constructing the packet, if appropriate.
100 (ospf_db_desc_proc) Speed up Exchange, slave should raise
101 ExchangeDone earlier, as RFC mandates, by forming its reply
102 before deciding whether both sides are done, avoids a
103 needless round of empty DD packet exchanges at the end of
104 Exchange, hence speeding up ExchangeDone.
Paul Jakmaf0894cf2006-08-27 06:40:04 +0000105 Implement draft-ogier-ospf-dbex-opt DB-exchange optimisation.
Paul Jakma8dd24ee2006-08-27 06:29:30 +0000106 (ospf_db_desc) use UNSET_FLAG macro.
107
Andrew J. Schorr16700082006-07-27 22:29:06 +00001082006-07-27 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
109
110 * ospfd.c: (ospf_router_id_update) Fix and document the algorithm for
111 selecting the router ID: if there is not a statically configured ID,
112 then stick to the most recent value to avoid disruptive changes.
113 This should fix bug #288.
114
Paul Jakma1fe6ed32006-07-26 09:37:26 +00001152006-07-26 Paul Jakma <paul.jakma@sun.com>
116
117 * ospf_lsa.{c,h}: (ospf_lsa_unlock) Change to take a double pointer
118 to the LSA to be 'unlocked', so that, if the LSA is freed, the
119 callers pointer to the LSA can be NULLed out, allowing any further
120 use of that pointer to provoke a crash sooner rather than later.
121 * ospf_*.c: (general) Adjust callers of ospf_lsa_unlock to match
122 previous. Try annotate 'locking' somewhat to show which 'locks'
123 are protecting what LSA reference, if not obvious.
124 * ospf_opaque.c: (ospf_opaque_lsa_install) Trivial: remove useless
125 goto, replace with return.
126 * ospf_packet.c: (ospf_make_ls_ack) Trivial: merge two list loops,
127 the dual-loop predated the delete-safe list-loop macro.
128
Paul Jakma3fed4162006-07-25 20:44:12 +00001292006-07-25 Paul Jakma <paul.jakma@sun.com>
130
131 * ospf_neigbor.h: (struct ospf_neighbor) Add some additional
132 neighbour state statistics fields, timestamps for progressive
133 and regressive state changes, and pointer to event string
134 for the latter state change.
135 * ospf_nsm.c: (nsm_notice_state_change) Update new state changs
136 history as required.
137 * ospf_vty.c: (show_ip_ospf_neighbor_detail_sub) Print out above
138 new per-neighbour state change stats.
139
Paul Jakma539e1522006-07-11 17:49:22 +00001402006-07-10 Paul Jakma <paul.jakma@sun.com>
141
142 * ospf_nsm.c: (nsm_change_state) call nsm_clear_adj for all
143 adjacency losses, hence removing need for nsm_reset_nbr.
144 (nsm_reset_nbr) kill it, clear_adj in previous does fine.
145 (nsm_kill_nbr,nsm_start) remove nsm_reset_nbr call.
146 (ospf_nsm_event) Allow NSM function to be NULL, this along with
147 removal of nsm_reset_nbr, allows a bunch of now useless functiosn
148 to be removed.
149 Remove some useless variables.
150 (nsm_ignore) now useless, remove.
151 (nsm_bad_ls_req) ditto
152 (nsm_seq_number_mismatch) "
153 (nsm_oneway_received) "
154 (nsm_inactivity_timer) "
155 (nsm_ll_down) "
156 (NSM) replace removed action functions with NULL.
Paul Jakma3d63f382006-07-11 17:52:53 +0000157 (nsm_notice_state_changes) Move state change logging code to new
158 func to declutter nsm_change_state and ospf_nsm_event.
159 Log event with AdjChange, it's useful to know.
160 (nsm_change_state) move adjchange and snmp logging to previous.
161 (ospf_nsm_event) call nsm_notice_state_changes from here.
162 Move the debug message to entry of function, so it gets out
163 even if something goes wrong.
Paul Jakma90c33172006-07-11 17:57:25 +0000164 Record state change timestamp and event in nbr struct.
165 * ospf_neighbor.h: (struct ospf_neighbor) Add fields to record
166 timestamp of last NSM change and event.
167 * ospf_vty.c: (show_ip_ospf_neighbor_detail_sub) Print
168 last state change timestamp and event, if available.
Paul Jakma539e1522006-07-11 17:49:22 +0000169
Andrew J. Schorr13cd3dc2006-07-11 01:50:30 +00001702006-07-10 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
171
172 * ospf_packet.c: (ospf_hello) Improve NetworkMask mismatch warning
173 message to include interface name and conflicting prefix lengths.
174
Paul Jakma1f2c2742006-07-10 07:45:13 +00001752006-07-07 Paul Jakma <paul.jakma@sun.com>
176
177 * ospf_nsm.h: Add a NSM_Deleted neighbour state, to act as dummy
178 state indicating the neighbour is to be deleted.
179 * ospf_nsm.c: (general) Use the NSM_Deleted state to delete
180 neighbours, thus allowing code to be slightly more obvious
181 in its flow.
182 (nsm_timer_set) Add NSM_Deleted. Add another timer the code
183 missed.
184 (nsm_kill_nbr) No need for special case call to nsm_change_state
185 anymore.
186 Make the assert and error-handling for same case more readable
187 (Andrew Schorr)
188 Remove the call to ospf_nbr_delete, nsm_change_state can do
189 this generally now via NSM_Deleted.
190 (struct ... NSM) Add the dummy NSM_Deleted state, the 3 events
191 that can lead to nsm_kill_nbr all now transition the NBR to
192 NSM_Deleted and the general change_state function can be left
193 to do the work.
194 (ospf_nsm_event) Special casing of events and early-return can
195 be removed now.
196 On transition into Deleted, delete the nbr.
197 * ospf_dump.c: (ospf_nsm_state_msg) Add Deleted.
198
Paul Jakmaaa2737a2006-07-06 11:12:39 +00001992006-07-06 Paul Jakma <paul.jakma@sun.com>
200
201 * ospf_nsm.c: (ospf_nsm_event) LLDown event also results in nbr
202 being deleted, requires early-return too. Likely explains
203 some crash reports after interface events.
204
Paul Jakmaf7a76ab2006-07-04 13:57:49 +00002052006-07-04 Paul Jakma <paul.jakma@sun.com>
206
207 * ospf_nsm.c: (general) Various small cleanups from Andrew's
208 review of last set of patches.
209 (nsm_timer_set) Loading, Full and default can share
210 same code too.
211 (nsm_should_adj) Can just be one big OR.
212 (nsm_twoway_received) Collapse into return statement.
213
Paul Jakmad7b0fb62006-07-04 13:35:24 +00002142006-07-02 Paul Jakma <paul.jakma@sun.com>
215
216 * ospf_nsm.c: (nsm_should_adj) New function, just consolidate the
217 10.4 adjacency check from nsm_twoway_received/nsm_adj_ok.
218 (nsm_twoway_received/nsm_adj_ok) Use former.
Paul Jakmad1b1cd82006-07-04 13:50:44 +0000219 (nsm_clear_adj) clear adjacency related state for a
220 neighbour, needed for some state changes from > ExStart down
221 to ExStart or less, which need not go through nsm_reset_nbr.
222 (nsm_reset_nbr) move code to former. Should be static.
Paul Jakmaba0beb42006-07-04 13:44:19 +0000223 (ospf_nsm_event) Don't allow action functions to change
224 next_state if the NSM tables do not indicate next_state is
225 conditional, log warning if one tries - existing code
226 appears fine though.
Paul Jakmad1b1cd82006-07-04 13:50:44 +0000227 Remove long dead code.
228 Use nsm_clear_adj for state changes that take down
229 adjacencies to TwoWay/ExStart.
Paul Jakmae55dd532006-07-04 13:46:14 +0000230 (nsm_timer_set) ls_req timer should be OFF in early states.
231 Compact several identical sections.
232 Set inactivity timer to OFF for Down, for documentary
233 purposes.
Paul Jakmad1b1cd82006-07-04 13:50:44 +0000234 (nsm_kill_nbr) Oops, action function shouldn't try return
235 1 for error.
Paul Jakma5db95bc2006-07-04 13:52:29 +0000236 * ospf_lsa.c: (ospf_translated_nssa_refresh) CID #13.
Paul Jakmad7b0fb62006-07-04 13:35:24 +0000237
Andrew J. Schorr1c066bf2006-06-30 16:53:47 +00002382006-06-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
239
240 * ospf_vty.c: (show_ip_ospf_neighbor_id) Should show all instances
241 of that neighbor (since it may appear on multiple interfaces)
242 instead of bailing out after showing the first match.
243
Andrew J. Schorr76947872006-06-30 03:21:05 +00002442006-06-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
245
246 * ospf_nsm.c: (nsm_twoway_received) When deciding whether to
247 change from state Init to ExStart, the test for whether the
248 neighboring router is DR or BDR should be against the
249 local router's notion of DR/BDR, not the neighbor's view.
250
Andrew J. Schorrd7e60dd2006-06-29 20:20:52 +00002512006-06-28 Erik Muller <erikm@internap.com>
252
253 * ospfd.h: Define 2 new struct ospf config flags:
254 OSPF_LOG_ADJACENCY_CHANGES and OSPF_LOG_ADJACENCY_DETAIL
255 * ospf_nsm.c (nsm_change_state): Log adjacency changes if
256 requested.
257 * ospf_vty.c (ospf_log_adjacency_changes): New command function
258 to implement ospf subcommand "log-adjacency-changes [detail]".
259 (no_ospf_log_adjacency_changes) Turn off log-adjacency-changes.
260 (show_ip_ospf) Show whether adjacency changes are logged.
261 (ospf_config_write) Add "log-adjacency-changes [detail]" to config.
262 (ospf_vty_init) Add ospf_log_adjacency_changes and
263 no_ospf_log_adjacency_changes.
264
Paul Jakma9560fa82006-06-26 12:50:06 +00002652006-06-26 Paul Jakma <paul.jakma@sun.com>
266
267 * ospf_abr.c: (general) NSSA translate-candidate ABRs need to
268 be ASBRs, or other routers may rightfully refuse to install
269 translated type-5s LSAs. reported by dendroot@gmail.com.
270 (ospf_abr_nssa_check_status) Detect change in translator
271 state when ABR, and inc/dec redistribute count as when we
272 leave/enter the disabled state - so that translate-enabled
273 ABR properly sets ASBR bit on non-NSSA areas.
274 Run the resulting function through indent to clean it up.
275 * ospf_lsa.c: (router_lsa_flags) For purposes of ASBR bit,
276 NSSA area is same as stub area.
277
Andrew J. Schorr0ffb7092006-06-24 19:40:13 +00002782006-06-24 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
279
Andrew J. Schorr9aecfae2006-06-24 20:05:02 +0000280 * ospf_snmp.c: (ospfTrapNbrStateChange, ospfTrapIfStateChange) Improve
281 info log message to indicate why the trap is being sent.
282
2832006-06-24 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
284
Andrew J. Schorr0ffb7092006-06-24 19:40:13 +0000285 * ospf_dump.c: (config_write_debug) Fix typo to show debug ospf nsm
286 status properly (not ism status).
287
Andrew J. Schorr6e72cb62006-06-18 00:45:48 +00002882006-06-17 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
289
290 * ospf_vty.c: ({no_,}ospf_passive_interface) Replace if_lookup_by_name
291 with a call to if_get_by_name -- if the interface does not exist
292 already, it should be created. And remove the obsolete warning
293 message.
294
Paul Jakma429ac782006-06-15 18:40:49 +00002952006-06-15 Paul Jakma <paul.jakma@sun.com>
296
297 * ospf_interface.h: (struct ospf_if_info) Add reference counts
298 for multicast group memberships. Add various macros to help
299 manipulate/check membership state.
300 * ospf_interface.c: (ospf_if_set_multicast) Maintain the
301 ospf_if_info reference counts, and only actually drop
302 memberships if it hits 0, to avoid losing membership when
303 OSPF is disabled on an interface with multiple active OSPF
304 interfaces.
305 * ospf_packet.c: (ospf_{hello,read}) Use the new macros to
306 check/set
307 multicast membership.
308 * ospf_vty.c: (show_ip_ospf_interface_sub) ditto.
309
Paul Jakmaac904de2006-06-15 12:04:57 +00003102006-05-31 Paul Jakma <paul.jakma@sun.com>
311
312 * ospf_lsdb.c: (ospf_lsdb_delete) robustify against NULL arguments,
313 print warning.
314 * ospf_lsa.c: (ospf_discard_from_db) ditto.
315 (ospf_maxage_lsa_remover) Check lsa->lsdb for validity, possible
316 mitigation (but not solution) for bug #269.
317
Paul Jakma88871b12006-06-15 11:41:19 +00003182006-05-30 Paul Jakma <paul.jakma@sun.com>
319
320 * ospf_packet.c: (ospf_read) Debug message about packets
321 received on unenabled interfaces should be conditional on
322 debug being set.
323
Paul Jakmad1c65c22006-06-27 08:01:43 +00003242006-05-23 Paul Jakma <paul.jakma@sun.com>
325
326 * ospf_vty.c: (general) Replace in-place route redistribution
327 command and help strings with the new auto-generated defines
328 from lib/route_types.h
329
Paul Jakmaae128052006-05-12 23:15:30 +00003302006-05-13 Paul Jakma <paul.jakma@sun.com>
331
332 * ospf_lsa.c: (ospf_translated_nssa_refresh) fix the sanity
333 check to match the assert, small error in CID #13 fix.
334
Paul Jakma70461d72006-05-12 22:57:57 +00003352006-05-12 Paul Jakma <paul.jakma@sun.com>
336
337 * ospf_lsa.c: (ospf_lsa_action) Get rid of the ospf_lookup
338 call, which is not checked for NULL return, by stripping out
339 functionality which is never used, hence fixing Coverity CID
340 #29.
341 (struct lsa_action) remove unused member.
Paul Jakmae54e6e52006-05-12 23:11:14 +0000342 (ospf_translated_nssa_refresh) Add non-assert sanity check,
343 in case DEBUG isn't defined.
344 Debug message when no type7 exists should print the ID from
345 the type5, not the type7, fixes CID #13.
346 * ospf_interface.c: (ospf_if_exists) Fix missing NULL return
Paul Jakmae43be0e2006-05-12 23:00:06 +0000347 check on ospf_lookup, CID #27.
Paul Jakma6db3a6f2006-05-12 23:02:46 +0000348 * ospf_asbr.c: (ospf_redistribute_withdraw) remove ospf_lookup
349 call by taking the struct ospf * as argument, which the
350 caller has, fixing CID #28.
351 * ospf_asbr.h: (ospf_redistribute_withdraw) update declaration
352 * ospf_zebra.c: (ospf_redistribute_unset) update call to
353 ospf_redistribute_withdraw to match.
Paul Jakmabfd7c7d2006-05-12 23:04:45 +0000354 * ospf_ia.c: (ospf_update_router_route) ospf->backbone could be
355 NULL when passed to ospf_find_asbr_route_through_area,
356 check for NULL first, CID #14.
Paul Jakmadeb15612006-05-12 23:07:27 +0000357 * ospf_ism.c: (ism_change_state) NULL check on oi->area is
358 useless, it's always valid. Only possibility where it
359 couldn't be is if there is a race between abr_task and
360 cleaning up oi's, in which case a NULL check here isn't going
361 to do anything. Fixes CID #15.
Paul Jakma70461d72006-05-12 22:57:57 +0000362
Paul Jakmacac3b5c2006-05-11 13:31:11 +00003632006-05-11 Paul Jakma <paul.jakma@sun.com>
364
365 * ospf_vty.c: (general) Audit ospf_lookup calls in commands,
366 ensure check for NULL result, make vty messages consistent.
367 (show_ip_ospf_interface) Missing NULL check on ospf_lookup
368 result, fixes Coverity CID #70.
Paul Jakma1a8ec2b2006-05-11 13:34:08 +0000369 (no_ospf_area_filter_list) Check NULL result from
370 ospf_area_lookup_by_area_id, fixes Coverity CID #69
Paul Jakma894f8b62006-05-12 22:50:40 +0000371 * ospf_route.c: (ospf_route_delete_same_ext) Fix deref before
372 NULL check by moving into check-protected block, fix CID #49.
Paul Jakma214a4452006-05-12 22:51:49 +0000373 * ospf_abr.c: (ospf_area_range_cost_set) Shouldn't create a new
374 range, should just lookup to see if one exists, the new range
375 is just leaked. Fixes CID #46.
Paul Jakma4021b602006-05-12 22:55:41 +0000376 * ospf_lsa.c: (ospf_default_originate_timer) Let the thread
377 take (struct ospf *) as thread argument, rather than (struct
378 ospf *)->default_originate, thus avoiding having to call
379 ospf_lookup.
380 * ospf_zebra.c: (ospf_redistribute_default_set) change setup
381 of ospf_default_originate_timer thread to match.
382 * ospfd.c: (ospf_router_id_update) ditto.
Paul Jakmacac3b5c2006-05-11 13:31:11 +0000383
Paul Jakma9c27ef92006-05-04 07:32:57 +00003842006-04-24 Paul Jakma <paul.jakma@sun.com>
385
386 * (general) More Virtual-link fixes, again with much help in
387 testing / debug from Juergen Kammer. Primarily in SPF.
388 * ospf_spf.h: Add guard. ospf_interface.h will include this
389 header.
390 * ospf_interface.h: Modify ospf_vl_lookup definition to take
391 struct ospf as argument, so as to allow for NULL area
392 argument.
393 (struct ospf_vl_data) Remove out_oi, instead add a struct
394 vertex_nexthop, to use as initial nexthop for backbone paths
395 through a vlink.
396 * ospf_interface.c: (ospf_vl_lookup) Modified to allow
397 NULL area to be passed to indicate "any" (first) area.
398 Add extra debug.
399 (ospf_vl_set_params) vl_oi -> nexthop. Add extra debug.
400 (ospf_vl_up_check) Fix debug, inet_ntoa returns a static
401 buffer..
402 * ospf_route.c: (ospf_intra_add_router) Vlinks dont go through
403 backbone, don't bother checking.
404 * ospf_spf.c: (static struct list vertex_list) Record vertices
405 that will need to be freed.
406 (cmp) Order network before router vertices, as required,
407 wasn't implemented.
408 (vertex_nexthop_free) Mild additional robustness check.
409 (vertex_parent_free) Take void argument, as this function
410 is passed as list deconstructor for vertex parent list.
411 (ospf_vertex_new) More debug. Set deconstructor for parent
412 list. Track allocated vertices on the vertex_list.
413 (ospf_vertex_free) Get rid of the tricky recursive cleanup of
414 vertices. Now frees only the given vertex.
415 (ospf_vertex_add_parent) Fix assert.
416 (ospf_nexthop_calculation) Fix calculation of nexthop for
417 VLink vertices, lookup the vl_data and use its previously
418 recorded nexthop information.
419 (ospf_spf_calculate) Vertices are freed simply by deleting
420 vertex_list nodes and letting ospf_vertex_free as deconstructor
421 work per-node.
422 (ospf_spf_calculate_timer) Trivial optimisation, leave
423 backbone SPF calculation till last to reduce SPF churn on
424 VLink updates.
425 * ospf_vty.c: (ospf_find_vl_data) update call to ospf_vl_lookup
426 (no_ospf_area_vlink_cmd) ditto.
427 (show_ip_ospf_interface_sub) For Vlinks, the peer address is
428 more interesting than the output interface.
429
Paul Jakma478aab92006-04-03 21:25:32 +00004302006-04-03 Paul Jakma <paul.jakma@sun.com>
431
432 * (general) Fix issues with handling of Vlinks and entries
433 in the nbrs route-table which were highlighted by the
434 nsm/nbr_self fixes from bug #234. Many thanks to Juergen
435 Kammer for his help and efforts in testing out debug patches to
436 pinpoint the issue.
437 * ospf_interface.c: (ospf_vl_new) Add nbr_self for Vlink.
438 * ospf_neighbor.c: (ospf_nbr_key) new static function, helper
439 to create key in nbrs table for a given nbr.
440 (ospf_nbr_delete) Use ospf_nbr_key. Add an assert() to
441 document an expected state.
442 (ospf_nbr_add_self) Ditto.
443 (ospf_nbr_lookup_by_addr) Add an assert.
444 * ospf_nsm.c: (nsm_kill_nbr) Can never kill the nbr_self
445 psuedo-neighbour.
446
Paul Jakma075c2012006-03-30 14:34:31 +00004472006-03-27 Paul Jakma <paul.jakma@sun.com>
448
449 * ospf_lsa.c: (ospf_lsa_checksum) Add an explicit cast to avoid
450 the ambiguities of ANSI and C99 C with respect to type
451 conversion. Detailed problem report and test case with
452 example data supplied by Dmitry Ivanov <dimss@telecentrs.lv>.
453
Paul Jakma1a8ee0e2006-03-30 14:20:00 +00004542006-03-25 Paul Jakma <paul.jakma@sun.com>
455
456 * ospf_interface.c: (ospf_if_lookup_recv_if) Ignore loopbacks,
457 we can never ever receive packets on those. Should fix
458 case where CARP is run with address in same subnet as real
459 interface. Problem report and diagnosis thanks to:
460 Landon Fuller <landonf@opendarwin.org>.
461 However, ospf_read() still can't deal deterministically with
462 multiple interfaces in same subnet.
463
Paul Jakmac2b478d2006-03-30 14:16:11 +00004642006-03-23 Steve Lawson <steve.lawson@aheadcomusa.com>
465
466 * ospf_lsa.c: (ospf_lsa_install) Fix incorrect byte-order
467 conversion of OSPF_MAX_SEQUENCE_NUMBER
468
paule8e19462006-01-19 20:16:55 +00004692006-01-19 Paul Jakma <paul.jakma@sun.com>
470
471 * (general) various miscellaneous compiler warning fixes.
472 Remove redundant break statements from switch clauses
473 which return.
474 return from main, not exit, cause it annoys SOS.
475 Remove stray semi-colons which cause empty-statement
476 warnings.
477
paul779adb02006-01-18 15:07:38 +00004782006-01-18 Juergen Kammer <j.kammer@eurodata.de>
479
480 * ospf_lsa.c: (ospf_router_lsa_new) dont take reference to the
481 stream data until it is constructed, data reference is
482 volatile due to the potential resize in link_info_set
483
4842006-01-18 Paul Jakma <paul.jakma@sun.com>
485
486 * ospf_lsa.c: (link_info_set) Resize the stream if required and
487 possible. Return number of links added.
488 (lsa_link_*_set) use return value from previous.
489 * ospf_lsa.h: Add OSPF_ROUTER_LSA_LINK_SIZE define.
490
paulc6371712006-01-17 17:49:53 +00004912006-01-17 Paul Jakma <paul.jakma@sun.com>
492
493 * ospf_packet.c: (ospf_verify_header) print out the types
494 involved if there's a mismatch.
495 * ospf_zebra.c: (ospf_zebra_add) Adjust to new zserv format.
496
paul818e56c2006-01-10 23:27:05 +00004972006-01-10 Len Sorensen <lennartsorensen@ruggedcom.com>
498
499 * (general) Bug #234, see also [quagga-dev 3902].
500 Fix problem with nbr_self not being properly reinitialised
501 when an interface comes up, after having been down.
paul1a643f82006-01-11 01:08:19 +0000502 Some re-arrangement done by Paul Jakma, any bugs introduced
503 on top of Len's suggested changes are his.
paul818e56c2006-01-10 23:27:05 +0000504 * ospf_neighbor.c: (ospf_nbr_add_self) centralise
505 initialisation of nbr_self parameters here.
506 * ospf_interface.c: (ospf_if_new) deleting initialisation of
507 parameters of nbr_self, just rely on call to
508 ospf_nbr_add_self.
509 (ospf_if_cleanup) ditto.
510 * ospfd.c: (ospf_network_run) ditto.
511
paul98429f62006-01-10 22:11:54 +00005122006-01-10 Juris Kalnins <juris@mt.lv>
513
514 * ospf_zebra.c: (ospf_interface_address_delete) fix rare leak of
515 struct connected in an error case.
paul818e56c2006-01-10 23:27:05 +0000516 * ospf_packet.c: (ospf_make_md5_digest) fix odd, if not
517 undefined effect, assignment of an increment expression.
paul98429f62006-01-10 22:11:54 +0000518
paul86752842006-01-10 20:34:46 +00005192006-01-10 Paul Jakma <paul.jakma@sun.com>
520
521 * ospfd.c: (ospf_network_run) checking to see if router-id
522 is set should be on ospf->router_id, not router_id_static.
523 This was causing ospfd to not start if router-id had not
524 been configured statically.
525 (ospf_if_update) ditto.
paulc42c1772006-01-10 20:36:49 +0000526 * ospf_vty.c: (config_write_ospf_distribute) trim down
527 redundant strings.
paul86752842006-01-10 20:34:46 +0000528
paul00c290e2005-11-26 09:21:43 +00005292005-11-26 Paul Jakma <paul.jakma@sun.com>
530
531 * ospf_api.c: (struct opaque_lsa) change from gcc zero-length
532 array to C99 incomplete type array.
paulc9c93d52005-11-26 13:31:11 +0000533 * (general) s/graceful/deferred/ in all files, the former term
534 is confusing wrt OSPF Graceful-Restart.
535 * ospfd.c: (ospf_deferred_shutdown_check) dont return
536 a function which returns void. SOS complains about this.
537 (ospf_finish)
paul00c290e2005-11-26 09:21:43 +0000538
paulb29800a2005-11-20 14:50:45 +00005392005-11-20 Paul Jakma <paul.jakma@sun.com>
540
541 * ospfd.h: remove the OSPF_ROUTER_ID_UPDATE_DELAY define
542 (struct ospf) remove the router_id timer thread.
543 remove export of ospf_router_id_update_timer.
544 * ospfd.c: (ospf_router_id_update) call ospf_if_update to
545 poke interfaces into action after ID has been configured.
546 (ospf_router_id_update_timer) removed.
547 (ospf_finish_final) t_router_id_update timer is gone.
548 (ospf_network_run) router-id update timer gone.
549 call ospf_router_id_update directly if ID not configured.
550 In the per-iface loop, don't ospf_if_up interfaces if
551 ID is still not configured. The update function will call
552 ospf_if_update anyway.
553 (ospf_if_update) ID update timer is gone. Just return if no
554 ID is set.
555 * ospf_vty.c: (ospf_router_id) call ospf_router_id_update, no
556 timer needed.
557 * ospf_zebra.c: (ospf_router_id_update_zebra) call
558 ospf_router_id_update directly, not via timer.
paulc24d6022005-11-20 14:54:12 +0000559 * ospf_abr.c: (ospf_abr_announce_network_to_area) check
560 returned LSA of ospf_summary_lsa_refresh and print warning if
561 it failed.
562 (ospf_abr_announce_network_to_area) similar
563 (ospf_abr_announce_rtr_to_area) similar
564 * ospf_lsa.c: (ospf_router_lsa_new) check LSA returned is valid.
565 (ospf_router_lsa_originate) similar
566 (ospf_router_lsa_refresh, ospf_network_lsa_new) similar
567 (ospf_summary_lsa_new) Check ID is valid.
568 (ospf_summary_lsa_originate) ditto, and check returned LSA from
569 previous function is !NULL.
570 (ospf_summary_lsa_refresh) check ospf_summary_lsa_new return
571 is !NULL.
572 (ospf_summary_asbr_lsa_new) ID valid check.
573 (ospf_summary_asbr_lsa_originate) similar.
paulb29800a2005-11-20 14:50:45 +0000574
ajs70cd3472005-11-16 19:33:22 +00005752005-11-16 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
576
ajs649654a2005-11-16 20:17:52 +0000577 * ospf_dump.h: Define OSPF_TIME_DUMP_SIZE as appropriate buffer size
578 for use with ospf_timer_dump and ospf_timeval_dump.
579 * ospf_vty.c: Change all buffer sizes used with ospf_timer_dump and
580 ospf_timeval_dump to have size OSPF_TIME_DUMP_SIZE.
581 (show_ip_ospf_interface_sub) Fix possible buffer overflow in
582 call to ospf_timer_dump.
583
5842005-11-16 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
585
ajs70cd3472005-11-16 19:33:22 +0000586 * ospf_ism.h: (OSPF_ISM_TIMER_OFF) Improve macro syntax by enclosing
587 in 'do {...} while(0)'.
588
paul31a59762005-11-14 11:11:11 +00005892005-11-14 Paul Jakma <paul.jakma@sun.com>
590
591 * ospfd.c: (ospf_new) stub-shutdown should just default to
592 unconfigured, too strange otherwise.
593 (ospf_finish_final) t_opaque_lsa_self TIMER_OFF should be
594 preprocessor conditional on HAVE_OPAQUE_LSA.
595 * ospfd.h: (struct ospf) remove the SHUTDOWN_DEFAULT define.
596 no longer used, plus it wasn't in range that the command
597 accepted.
598 * ospf_zebra.h: Depends on vty.h, include it.
599
paul58e1bef2005-11-11 12:10:03 +00006002005-11-11 Paul Jakma <paul.jakma@sun.com>
601
602 * ospf_spf.c: (ospf_canonical_nexthops_free) Free only
603 the nexthops pointing to the root vertex. We may visit a
604 vertex twice or the vertex may have some inherited nexthops,
605 if we free other nexthops we could crash.
606
paulc8c15212005-11-04 12:31:39 +00006072005-11-04 Paul Jakma <paul.jakma@sun.com>
608
609 * ospf_{dump,spf,vty}.c: Oops, use the internal tv_sub
610 function rather than unportable timersub.
611
paul484315f2005-11-03 09:08:29 +00006122005-11-03 Paul Jakma <paul.jakma@sun.com>
613
614 * ospf_apiserver.c: (apiserver_sync_callback) stray semi-colon
615 * ospf_packet.c: include checksum.h, remove the in_cksum extern
616 * prototypes.
617 * ospf_te.h: Add braces, quell warning.
paul6d452762005-11-03 11:15:44 +0000618 * ospf_packet.c: Change level of some warnings to
619 informational.
paulc8c15212005-11-04 12:31:39 +0000620
paul88d6cf32005-10-29 12:50:09 +00006212005-10-29 Paul Jakma <paul.jakma@sun.com>
622
623 * (general) RFC3137 stub-router support
624 * ospfd.h: Add OSPF_OUTPUT_COST_INFINITE define.
625 (struct ospf_master) Add a OSPF_MASTER_SHUTDOWN flag for
626 options, to allow shutdown to distinguish between complete
627 shutdown and shutdown of a subset of ospf instances.
628 (struct ospf)
629 Add stub_router_{startup,shutdown_}time, configuration of startup
630 and shutdown time for stub-router.
631 Add t_graceful_shutdown struct thread, timer for graceful
632 shutdown, if needed.
633 (struct ospf_area) Add stub_router_state - run time state of
634 stub-router for an area. Add flags for ADMIN, IS and WAS
635 states.
636 Add t_stub_router, timer thread to resend router-lsa for an
637 area.
638 * ospf_lsa.c: (ospf_link_cost) new simple function to spit out
639 either the given lnks cost or infinite cost if stub-router is
640 in effect.
641 (lsa_link_{ptop,broadcast,virtuallink,ptomp}_set) use
642 previous function for transit-links.
643 (ospf_stub_router_timer) timer thread for end of startup stub
644 router. Change state as required for the area and setup
645 re-origination of router-lsa.
646 (ospf_stub_router_check) Check/do whether stub-router should be
647 enabled, and whether it requires timer to be setup.
648 (ospf_router_lsa_new) call previous function at top.
649 (ospf_router_lsa_originate) no external callers, made static.
650 * ospf_lsa.h: (ospf_router_lsa_originate) removed.
651 * ospf_main.c: (sigint) make static.
652 remove call to exit, as ospf_terminate now deals with
653 exiting.
654 * ospf_route.c: (ospf_terminate) removed, now in ospfd.c.
655 * ospf_vty.c: (show_ip_ospf_area) print out state of
656 stub-router, if active.
657 (show_ip_ospf) print out configuration of stub-router
658 support, and details of graceful-shutdown if the timer is
659 active.
660 ((no)?ospf_max_metric_router_lsa_{admin,startup,shutdown}) new
661 commands to (de-)?configure stub-router support.
662 (config_write_stub_router) write out config of stub-router.
663 (ospf_config_write) call previous.
664 (ospf_vty_init) install the new stub-router commands.
665 * ospfd.c: various functions made static.
666 (ospf_new) Set defaults for stub-router. Graceful shutdown
667 is made to default on, just to be adventerous.
668 (ospf_graceful_shutdown_finish) new function, final part of
669 shutdown.
670 (ospf_graceful_shutdown_timer) timer thread wrapper for
671 graceful-shutdown.
672 (ospf_graceful_shutdown_check) check whether to setup timer
673 for shutdown or proceed directly to final shutdown.
674 (ospf_terminate) moved here from ospf_route.c, call
675 ospf_finish for each instance.
676 (ospf_finish) renamed to ospf_finish_final and made static.
677 (ospf_finish) new function, exported wrapper around
678 ospf_graceful_shutdown_check.
679 (ospf_finish_final) complete shutdown of an instance.
680 Add missing TIMER_OFF's of two timer threads.
681 (ospf_area_free) opaque self lsa timer should be turned off.
682
paulb8ad39d2005-10-23 15:23:05 +00006832005-10-23 Paul Jakma <paul.jakma@sun.com>
684
paule029d442005-10-23 15:26:24 +0000685 * ospf_apiserver.c: (ospf_apiserver_term) This function should
686 not have side-effects (eg segv) if no apiserver instances are
687 active, ie be robust.
paulb8ad39d2005-10-23 15:23:05 +0000688 * ospf_vty.c: (show_ip_ospf) fix display of SPF timer if it
689 has not yet been run.
690
paulf9ad9372005-10-21 00:45:17 +00006912005-10-21 Paul Jakma <paul.jakma@sun.com>
692
paulea4ffc92005-10-21 20:04:41 +0000693 * ospf_dump.c: (ospf_timeval_dump) fix ms adjustment, thanks to
694 Andrew Schorr.
695 * ospf_vty.c: (ospf_config_write) fix write out of spf timers
696 configuration.
697
6982005-10-21 Paul Jakma <paul.jakma@sun.com>
699
pauld24f6e22005-10-21 09:23:12 +0000700 * (general) SPF millisecond resolution timer with adaptive,
701 linear back-off holdtime. Prettification of ospf_timer_dump.
702 * ospf_dump.c: (ospf_timeval_dump) new function. The guts of
703 ospf_timer_dump, but made to be more dynamic in printing out
704 the relative timeval, sliding the precision printed out
705 according to the value.
706 (ospf_timer_dump) guts moved to ospf_timeval_dump.
707 * ospf_dump.h: export ospf_timeval_dump.
708 * ospf_flood.c: (ospf_flood) remove gettimeofday, use
709 the libzebra exported recent_time instead, as it's not
710 terribly critical to have time exactly right - the dropped
711 LSA will be retransmited to us if we don't ACK it.
712 * ospf_packet.c: (ospf_ls_upd_timer) Ditto, but here we're
713 not transmitting, just putting LSA back on update transmit list.
714 * ospfd.h: delay and holdtimes should be unsigned.
715 Add spf_max_holdtime and spf_hold_multiplier.
716 Update default defines for delay and hold time to be in msec.
717 (struct ospf) change the SPF timestamp to a struct timeval.
718 Remove ospf_timers_spf_(un)?set.
719 * ospfd.c: (ospf_timers_spf_{set,unset}) removed.
720 (ospf_new) initialise spf_max_holdtime and spf_hold_multiplier
721 * ospf_spf.c: (ospf_spf_calculate) SPF timestamp is a timeval
722 now, update with gettimeofday.
723 (ospf_spf_calculate_schedule) Change SPF timers to millisecond
724 resolution.
725 Make the holdtime be adaptive, with a linear increase in
726 holdtime ever consecutive SPF run which occurs within holdtime
727 of previous SPF, bounded by spf_max_holdtime.
728 * ospf_vty.c: Update spf timers commands.
729 (ospf_timers_spf_set) trivial helper.
730 (ospf_timers_throttle_spf_cmd) new command to set SPF delay,
731 initial hold and max hold times with millisecond resolution.
732 (ospf_timers_spf_cmd) Deprecated. Accept the old values,
733 convert to msec, truncate to new limits.
734 (no_ospf_timers_throttle_spf_cmd) set timers to defaults.
735 (no_ospf_timers_spf_cmd) deprecated form, same as previous.
736 (show_ip_ospf_cmd) Display SPF parameters and times.
737 (show_ip_ospf_neighbour_header) Centralise the 'sh ip os ne'
738 header.
739 (show_ip_ospf_neighbor_sub) Fix the field widths. Get rid of
740 the multiple spaces which were making the lines even longer.
741 (show_ip_ospf_neighbor_cmd) Use show_ip_ospf_neighbour_header
742 (show_ip_ospf_neighbor_all_cmd) ditto and fix the field
743 widths for NBMA neighbours.
744 (show_ip_ospf_neighbor_int) Use header function.
745 (show_ip_ospf_nbr_nbma_detail_sub) use sizeof for timebuf,
746 local array - safer.
747 (show_ip_ospf_neighbor_detail_sub) ditto
748 (ospf_vty_init) install the new SPF throttle timer commands.
749
7502005-10-21 Paul Jakma <paul.jakma@sun.com>
751
paulf9ad9372005-10-21 00:45:17 +0000752 * (general) OSPF fast, sub-second hello and 1s dead-interval
753 support.
754 * ospf_dump.c: (ospf_timer_dump) Print out milliseconds too.
755 Callers typically specify a length of 9, so most see
756 millisecs unless they specify the additional length.
757 * ospf_interface.h: (struct ospf_interface) new interface param,
758 fast_hello.
759 * ospf_interface.c: (ospf_if_table_lookup) add brackets,
760 gcc warning fix.
761 (ospf_new_if_params) Initialise fast_hello param.
762 (ospf_free_if_params) Check whether fast_hello is configured.
763 (ospf_if_new_hook) set fast_hello to default.
764 * ospf_ism.h: Wrap OSPF_ISM_TIMER_ON inside do {} while (0) to
765 prevent funny side-effects from its if statement when this
766 macro is used conditionally by other macros.
767 (OSPF_ISM_TIMER_MSEC_ON) new macro, set in milliseconds.
768 (OSPF_HELLO_TIMER_ON) new macro to set hello timer according
769 to whether fast_hello is set.
770 * ospf_ism.c: Update all setting of the hello timer to use
771 either OSPF_ISM_TIMER_MSEC_ON or OSPF_HELLO_TIMER_ON. The
772 former is used when hello is to be sent immediately.
773 * ospf_nsm.c: ditto
774 * ospf_packet.c: (ospf_hello) hello-interval is not checked
775 for mismatch if fast_hello is set.
776 (ospf_read) Annoying nit, fix "no ospf_interface" to be debug
777 rather than a warning, as it can be perfectly normal to
778 receive packets when logical subnets are used.
779 (ospf_make_hello) Set hello-interval to 0 if fast-hellos are
780 configured.
781 * ospf_vty.c: (ospf_auto_cost_reference_bandwidth) annoying
782 nit, don't vty_out if this command is given, it gets tired
783 quick.
784 (show_ip_ospf_interface_sub) Print the hello-interval
785 according to whether fast-hello is set or not.
786 Print the extra 5 millisec characters from (ospf_timer_dump)
787 if fast-hello is configured.
788 (ospf_vty_dead_interval_set) new function, common to all
789 forms of dead-interval command, to set dead-interval and
790 fast-hello correctly. If a dead-interval is given, unset
791 fast-hello, else if a hello-multiplier is set, set
792 dead-interval to 1 and fast-hello to given multiplier.
793 (ip_ospf_dead_interval_addr_cmd) use
794 ospf_vty_dead_interval_set().
795 (ip_ospf_dead_interval_minimal_addr_cmd) ditto.
796 (no_ip_ospf_dead_interval) Unset fast-hello.
797 (no_ip_ospf_hello_interval) Bug-fix, unset of hello-interval
798 should set it to OSPF_HELLO_INTERVAL_DEFAULT, not
799 OSPF_ROUTER_DEAD_INTERVAL_DEFAULT.
800 (config_write_interface) Write out fast-hello.
801 (ospf_config_write) Write a comment about
802 "auto-cost reference-bandwidth" having to be equal on all
803 routers. Hopefully just as noticeable as old practice of
804 writing to vty, but less annoying.
805 (ospf_vty_if_init) install the two new dead-interval
806 commands.
807 * ospfd.h: Add defines for OSPF_ROUTER_DEAD_INTERVAL_MINIMAL
808 and OSPF_FAST_HELLO_DEFAULT.
809
pauleb3da6d2005-10-18 04:20:33 +00008102005-10-18 Paul Jakma <paul.jakma@sun.com>
811
812 * (general) SPF memory management cleanup and fix for rare
813 double-free bug.
814 * ospf_spf.h: (struct vertex_parent) New struct to hold parent
815 specific data, eg the backlink and the parent vertex pointer,
816 and point to the appropriate general struct vertex_nexthop.
817 (struct vertex_nexthop) remove parent vertex pointer, so
818 this struct can be shared across vertices.
819 (struct vertex) rename list child to list children. Remove
820 list of nexthops, replace with list of vertex_parents.
821 * ospf_spf.c: (update_stat) trivial, remove cast from void *.
822 (vertex_nexthop_new) remove init of parent - field is gone
823 from struct vertex_nexthop.
824 (ospf_canonical_nexthops_free) Remove the canonical
825 vertex_nexthop memory objects. These are the vertex_nexthops
826 attached to the first level of router vertices from the root.
827 (vertex_parent_new) new function, create a vertex_parent.
828 (vertex_parent_free) ditto, but free it.
829 (ospf_vertex_new) Update to match changes to struct vertex.
830 (ospf_vertex_free) Recursively free a struct vertex and its
831 children. The parent list is used as a reference count.
832 vertex_nexthops must be free seperately, if required.
833 (ospf_vertex_dump) update to match struct vertex changes.
834 Print out backlink of parents too.
835 (ospf_vertex_add_parent) ditto.
836 (ospf_lsa_has_link) update comment.
837 (ospf_nexthop_add_unique) removed, not needed anymore.
838 (ospf_nexthop_merge) ditto.
839 (ospf_spf_consider_nexthop) renamed to ospf_spf_add_parent.
840 Simplified to just create vertex_parent and add it.
841 (ospf_spf_flush_parents) new function, flush out the parent
842 list.
843 (ospf_nexthop_calculation) Take the relevant route_lsa_link
844 as an argument, which simplifies things and removes the need
845 for the hack in ospf_nexthop_add_unique - ospf_spf_next
846 already knew exactly which link the cost calculated was for.
847 Update to match struct vertex changes too.
848 (ospf_spf_next) Don't create a vertex for W unnecessarily, if
849 it's there's a vertex already created for W, use it, and
850 hence there's no need to free it either.
851 Update some manipulation/comparisons of distance to match.
852 Flush the parent list if a lower cost path is found.
853 (ospf_spf_route_free) unused, removed.
854 (ospf_spf_dump) match the struct vertex changes, and dump the
855 ifname if possible.
856 (ospf_spf_calculate) At end of SPF, free the canonical nexthops
857 and call ospf_vertex_free on the root vertex to free the
858 entire tree.
859 * ospf_interface.c: (ospf_vl_set_params) match struct vertex
860 changes.
861 * ospf_route.c: (ospf_intra_route_add) ditto
862 (ospf_route_copy_nexthops_from_vertex) ditto
863
paul36238142005-10-11 04:12:54 +00008642005-10-11 Paul Jakma <paul.jakma@sun.com>
865
866 * ospf_api.c: sign warnings.
867 * ospf_apiserver.c: sign warning and convert all the struct
868 in_addr initialisations so as not to make assumptions about
869 how this struct is organised, initialise the s_addr member
870 explicitely.
871 * ospf_packet.c: Add const qualifier to auth_key.
872
vincent77df1f72005-10-06 07:46:22 +00008732005-10-06 Alain Ritoux <alain.ritoux@6wind.com>
874
875 * ospf_snmp.c: Avoid mixing interface and ospf_interface objects
876 which now allows snmpwalk to work with ospfIfTable and
877 also with ospfIfMetricTable
878
ajsf52d13c2005-10-01 17:38:06 +00008792005-10-01 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
880
881 * ospf_dump.c: Remove local hard-coded table ospf_redistributed_proto.
882 (ospf_redist_string) New function implemented using new library
883 function zebra_route_string(). Note that there are a few differences
884 in the output that will result: the new function returns strings
885 that are lower-case, whereas the old table was mixed case. Also,
886 the old table mapped ZEBRA_ROUTE_OSPF6 to "OSPFv3", whereas the
887 new function returns "ospf6".
888 * ospfd.h: Remove extern struct message ospf_redistributed_proto[],
889 and add extern const char *ospf_redist_string(u_int route_type)
890 instead.
891 * ospf_asbr.c: (ospf_external_info_add) In two messages, use
892 ospf_redist_string instead of LOOKUP(ospf_redistributed_proto).
893 * ospf_vty.c: Remove local hard-coded table distribute_str.
894 (config_write_ospf_redistribute,config_write_ospf_distribute): Use
895 new library function zebra_route_string() instead of distribute_str[].
896 * ospf_zebra.c: (ospf_redistribute_set,ospf_redistribute_unset,
897 ospf_redistribute_default_set,ospf_redistribute_check)
898 In debug messages, use ospf_redist_string() instead of
899 LOOKUP(ospf_redistributed_proto).
900
jardin6638c1a2005-10-01 00:08:54 +00009012005-09-30 Vincent Jardin <vincent.jardin@6wind.com>
902
903 * ospf_dump.c, ospf_ia.c, ospf_spf.c, ospf_ase.c:
904 remove unused DEBUG
905
vincentba682532005-09-29 13:52:57 +00009062005-09-29 Alain Ritoux <alain.ritoux@6wind.com>
907
vincent5e4914c2005-09-29 16:34:30 +0000908 * ospf_ism.c: generate SNMP traps on Interface state change
909 * ospf_nsm.c: generate SNMP traps on Neighbour state change
910 * ospf_snmp.[ch]: support for SNMP traps for interface and neighbours.
911
9122005-09-29 Alain Ritoux <alain.ritoux@6wind.com>
913
vincentba682532005-09-29 13:52:57 +0000914 * ospf_vty.c: forece default route LSA to be re_issued whenever
915 cost is changed ( [no] ip ospf area XXX default-cost YYY)
916 Support ignore-mtu option
917 * ospfd.h: define OSPF_MTU_IGNORE_DEFAULT
918 * ospf_packet.c: support ignore-mtu option
919 * ospf_interface.h: field added for skipping MTU check
920 * ospf_interface.c: fix memory leak in ospf_crypt_key_delete()
921 Set mtu_ignore field to default value
922 * ospf_abr.[ch]: export ospf_abr_announce_network_to_area()
923 * ospf_ism.h: add MACRO to convert internal ISM status into SNMP
924 correct values
925 * ospf_snmp.c: add sanity check on LSA type in lsdb_lookup_next()
926 convert OSPFIFSTATE internal status into SNMP values
927
vincentc1a03d42005-09-28 15:47:44 +00009282005-09-28 Alain Ritoux <alain.ritoux@6wind.com>
929
930 * ospf_packet.c: use new md5 API
931
ajs5339cfd2005-09-19 13:28:05 +00009322005-09-19 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
933
934 * ospf_lsa.h: (ospf_external_lsa_flush) Comment out the 5th argument
935 (nexthop) since it is not used in the function (except inside
936 some commented-out code).
937 * ospf_lsa.c: (ospf_external_lsa_flush,ospf_external_lsa_refresh)
938 Comment out the 5th argument to ospf_external_lsa_flush.
939 * ospf_asbr.c: (ospf_redistribute_withdraw) Comment out 5th arg
940 to ospf_external_lsa_flush.
941 * ospf_vty.c: (no_ospf_default_information_originate) Eliminate 5th
942 uninitialized nexthop arg to ospf_external_lsa_flush.
943 * ospf_zebra.c: (ospf_zebra_read_ipv4) Comment out 5th arg
944 to ospf_external_lsa_flush.
945 * ospfd.c: (ospf_network_set) Comment out 5th arg
946 to ospf_external_lsa_flush.
947
ajse6a0bf92005-09-17 18:53:38 +00009482005-09-17 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
949
950 * ospf_opaque.c:
951 (ospf_opaque_lsa_refresh_schedule,ospf_opaque_lsa_flush_schedule)
952 No need to call ospf_lookup(), just use lsa0->area->ospf instead.
953
hassobb5b7552005-08-21 20:01:15 +00009542005-08-21 Hasso Tepper <hasso at quagga.net>
955
956 * ospf_vty.c: Make "show ip ospf neighbor xxx" commands work.
957 Interface should be specified by name now.
958
hasso54bedb52005-08-17 13:31:47 +00009592005-08-17 Hasso Tepper <hasso at quagga.net>
960
961 * ospf_vty.c: Check carefully if interface exists before trying to
962 print info about it.
963
hasso01018ce2005-08-05 07:40:15 +00009642005-08-05 Hasso Tepper <hasso at quagga.net>
965
966 * ospf_zebra.c: Don't assert/stop before type == ZEBRA_ROUTE_MAX if
967 dealing with routemaps. There is ospf->route_map[ZEBRA_ROUTE_MAX]
968 for default-information.
969
paulc8987752005-07-26 06:07:22 +00009702005-07-26 Paul Jakma <paul.jakma@sun.com>
971
972 * ospf_abr.c: (ospf_abr_announce_network_to_area) SET_FLAG
973 should be on lsa not old, which may be freed for one thing,
974 obviously.
975
pauld57834f2005-07-12 20:04:22 +00009762005-07-12 Paul Jakma <paul.jakma@sun.com>
977
978 * ospfd.h: add OSPF_ABR_DEFAULT for convenience, make
979 OSPF_ABR_CISCO be the default ABR type.
980 * ospfd.c: (ospf_new) initialise abr_type to OSPF_ABR_DEFAULT
981 * ospf_vty.c: (no_ospf_abr_type_cmd) add standard as a negatable
982 abr_type. default abr_type should be OSPF_ABR_DEFAULT.
983 (ospf_config_write) test whether default abr_type against
984 OSPF_ABR_DEFAULT, rather than any specific ABR_TYPE.
985
hasso8469bd72005-06-20 20:50:10 +00009862005-06-20 Hasso Tepper <hasso at quagga.net>
hassof4833e92005-06-20 20:42:26 +0000987
988 * ospf_nsm.c: Make database exchange for NSSA database work.
989
paul7461d452005-06-13 13:57:16 +00009902005-06-13 Paul Jakma <paul.jakma@sun.com>
991
992 * ospf_spf.c: Try get more information on a SEGV under
993 ospf_spf_vertex_add_parent.
994 (ospf_vertex_free) NULL out the child and nexthop lists
995 (ospf_vertex_add_parent) nexthop and child can not be NULL
996 vertex_nexthop's parent->child list can not be NULL
997 (ospf_spf_next) w and cw are per-loop iteration variables, move
998 declarations into loop body.
999
hasso1ddd7292005-06-07 19:54:04 +000010002005-06-07 Hasso Tepper <hasso at quagga.net>
1001
1002 * ospf_apiserver.c: Fix obvious error in notifying clients about ISM
1003 changes - oi->ifp->status doesn't give to us info about ISM,
1004 oi->state does.
1005
paul7e440862005-06-01 11:20:51 +000010062005-06-01 Akihiro Mizutani <mizutani@net-chef.net>
1007
1008 * ospf_ism.c (ospf_elect_bdr/ospf_elect_dr): Fix DR election bug.
1009
paul500e4182005-05-26 17:11:13 +000010102005-05-26 Paul Jakma <paul.jakma@sun.com>
1011
1012 * ospf_abr.c: (ospf_abr_update_aggregate) Fix comment, cost bug itself
1013 had been fixed long ago by Sowmini.
1014
paula3387a42005-05-18 23:29:57 +000010152005-05-19 Paul Jakma <paul.jakma@sun.com>
1016
1017 * ospf_interface.c: (ospf_if_table_lookup) Fix a serious bug
1018 a less serious one.
1019 1: this function is supposed to lookup
1020 entries in the oifs ospf_interface route_table and return either
1021 an existing oi or NULL to indicate not found, its caller depends
1022 on this, yet this function uses route_node_get which /always/
1023 returns a route_node - one is created if none exists. Use
1024 route_node_lookup instead. This should fix root cause of the
1025 reports of the (ospf_add_to_if) assert being hit.
1026 2: oi's are inserted into this table with prefixlength set to
1027 /32 (indeed, it should be a hash table, not a route_table),
1028 however prefixlength to lookup was not changed, if no valid entry
1029 can be inserted other than /32, then nothng but /32 should be
1030 looked up. This possibly only worked by fluke..
1031 Fix confirmed by 2 reporters (one list, one IRC), definitely a
1032 backport candidate once it has been incubated in HEAD for a while.
1033 Thanks to Patrick Friedel and Ivan Warren for testing.
1034
paul69310a62005-05-11 18:09:59 +000010352005-05-11 Paul Jakma <paul.jakma@sun.com>
1036
1037 * (general) Fix memory leaks in opaque AS-scope LSAs, reported and
1038 with much debugging done by by scott collins <scollins@agile.tv>.
1039 * ospf_lsa.c: (ospf_discard_from_db) dont call
1040 ospf_ase_unregister_external_lsa for opaque-lsa's, opaques are
1041 never registered with ase in the first place.
1042 * ospf_packet.c: (general) Disabuse opaque related code of its
1043 tendency to try gather up things into temporary lists.
1044 (ospf_ls_upd) remove the temporary lists opaque uses, call
1045 opaque functions inline, just like all other types.
1046 (ospf_ls_ack) ditto.
1047 (ospf_recv_packet) fixup sign warning.
1048 * ospf_opaque.c: (general) fix the unneeded use of lists, and
1049 untwist some of the logic.
1050 (ospf_opaque_self_originated_lsa_received) take a single LSA
1051 as argument, not a list of them. Remove the list loop. Logic
1052 otherwise unchanged.
1053 (ospf_opaque_ls_ack_received) Mostly ditto. But untwist the logic,
1054 move the actions up into the switch block, remove the goto's and
1055 sanitise the logic near the end a bit.
1056 * ospf_opaque.h: Adjust definitions of aforementioned functions
1057 in ospf_opaque.c to match.
1058
paul42c98192005-05-07 02:22:51 +000010592005-05-07 Yar Tikhiy <yar@comp.chem.msu.su>
1060
1061 * ospf_network.c: Log ifindex on multicast membership leave/join
1062 events.
1063
paul4dadc292005-05-06 21:37:42 +000010642005-05-06 Paul Jakma <paul.jakma@sun.com>
1065
1066 * (general) extern and static qualifiers added.
1067 unspecified arguments in definitions fixed, typically they should
1068 be 'void'.
1069 function casts added for callbacks.
1070 Guards added to headers which lacked them.
1071 Proper headers included rather than relying on incomplete
1072 definitions.
1073 gcc noreturn function attribute where appropriate.
1074 * ospf_opaque.c: remove the private definition of ospf_lsa's
1075 ospf_lsa_refresh_delay.
1076 * ospf_lsa.h: export ospf_lsa_refresh_delay
1077 * ospf_packet.c: (ospf_make_md5_digest) make *auth_key const,
1078 correct thing to do - removes need for the casts later.
1079 * ospf_vty.c: Use vty.h's VTY_GET_INTEGER rather than ospf_vty's
1080 home-brewed versions, shuts up several warnings.
1081 * ospf_vty.h: remove VTY_GET_UINT32. VTY_GET_IPV4_ADDRESS and
1082 VTY_GET_IPV4_PREFIX moved to lib/vty.h.
1083 * ospf_zebra.c: (ospf_distribute_list_update_timer) hacky
1084 overloading of the THREAD_ARG pointer should at least use
1085 uintptr_t.
1086
paul9e67dc22005-04-15 12:10:17 +000010872005-04-15 Zhipeng Gong <zpgong@cdc.3upsystems.com>
1088
1089 * ospf_abr.c: (ospf_abr_announce_network_to_area) dont forget
1090 to approve LSAs for the case where metric has changed, lsa gets
1091 flushed otherwise. (backport candidate).
1092
ajs634f9ea2005-04-11 15:51:40 +000010932005-04-11 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1094
1095 * ospf_zebra.c (ospf_zebra_add): Call zclient_send_message instead
1096 of writen.
1097
ajsd2fc8892005-04-02 18:38:43 +000010982005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1099
ajse4319de2005-04-02 23:23:55 +00001100 * ospf_interface.h: (ospf_if_lookup_by_name) Remove declaration of a
1101 function that does not exist.
1102
11032005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1104
ajs21fefa92005-04-02 23:16:41 +00001105 * ospf_zebra.c: (zebra_interface_if_lookup) Must use
1106 if_lookup_by_name_len.
1107
11082005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1109
ajsa3491982005-04-02 22:50:38 +00001110 * ospf_interface.c: (ospf_vl_new) Use strnlen to fix call to if_create.
1111
11122005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1113
ajsd2fc8892005-04-02 18:38:43 +00001114 * ospf_vty.c: (show_ip_ospf_interface_sub) Show ifindex and interface
1115 flags to help with debugging.
1116 * ospf_zebra.c: (ospf_interface_delete) After deleting, set ifp->ifindex
1117 to IFINDEX_INTERNAL.
1118 (zebra_interface_if_lookup) Make function static. Tighten up code.
1119
ajsaca72fd2005-03-31 15:18:21 +000011202005-03-31 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1121
1122 * ospf_dump.c: (show_debugging_ospf) Show if ospf event debugging
1123 is turned on.
1124
ajsfd651fa2005-03-29 16:08:16 +000011252005-03-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1126
ajsa608bbf2005-03-29 17:03:49 +00001127 * ospf_zebra.c: (ospf_interface_state_up) If the MTU of an operative
1128 interface changes, print a debug message and call ospf_if_reset()
1129 to simulate down/up on the interface.
1130 * ospf_interface.h: Declare new function ospf_if_reset().
1131 * ospf_interface.c: (ospf_if_reset) New function to call ospf_if_down
1132 and ospf_if_up for all ospf interfaces attached to an interface.
1133
11342005-03-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1135
ajs5dcbdf82005-03-29 16:13:49 +00001136 * ospf_packet.c: (ospf_write_frags) Enhance error message to
1137 show MTU. Also make function static.
1138 (ospf_write) Enhance error message to show interface name and MTU.
1139 Also make function static.
1140
11412005-03-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1142
1143 * ospf_vty.c: (show_ip_ospf_interface_sub) Display interface MTU and
1144 bandwidth; this is useful for debugging problems. Also, the function
1145 should be static.
ajsfd651fa2005-03-29 16:08:16 +00001146
hasso1b639042005-03-27 13:32:25 +000011472005-03-27 Hasso Tepper <hasso at quagga.net>
1148
1149 * ospf_snmp.c: Don't crash in snmp query if ospf instance doesn't
1150 exist at all.
1151
hasso343f5cc2005-03-25 19:48:40 +000011522005-03-25 Hasso Tepper <hasso at quagga.net>
1153
1154 * ospfd.h: Include log.h, fixes compile with gcc-4.0.
1155
ajs9dbc7972005-03-13 19:27:22 +000011562005-03-13 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1157
1158 * ospf_lsa.c: (ospf_lsa_refresh_walker) If the system clock jumps
1159 backward, then current time may be less than
1160 ospf->lsa_refresher_started. This was causing invalid values
1161 for ospf->lsa_refresh_queue.index resulting in infinite loops.
1162 Problem fixed by casting the expression to unsigned before taking
1163 the modulus.
1164
ajs5c333492005-02-23 15:43:01 +000011652005-02-23 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1166
1167 * ospfd.h: Add new field struct stream *ibuf to struct ospf.
1168 * ospfd.c: (ospf_new) Check return code from ospf_sock_init.
1169 Allocate ibuf using stream_new(OSPF_MAX_PACKET_SIZE+1).
1170 (ospf_finish) Call stream_free(ospf->ibuf.
1171 * ospf_packet.c: (ospf_read) Call stream_reset(ospf->ibuf) and then
1172 pass it to ospf_recv_packet for use in receiving the packet
1173 (instead of allocating a new stream for each packet received).
1174 Eliminate all calls to stream_free(ibuf).
1175 (ospf_recv_packet) The struct stream *ibuf is now passed in as
1176 an argument. No need to use recvfrom to peek at the packet
1177 header (to see how big it is), just use ospf->ibuf which is
1178 always large enough (this eliminates a system call to recvfrom).
1179 Therefore, no need to allocate a stream just for this packet,
1180 and no need to free it when done.
1181
hasso462f20d2005-02-23 11:29:02 +000011822005-02-23 Vincenzo Eramo <eramo at infocom.ing.uniroma1.it>
1183
1184 * ospf_lsa.h: New flag to the LSA structure for the SPF calculation.
1185 * ospf_lsdb.h: Export ospf_lsdb_clean_stat() function.
1186 * ospf_spf.h: Add link to the LSA stat structure into vertex.
1187 * ospf_spf.c: New functions cmp() and update_stat() to manage
1188 candidates. Remove ospf_spf_has_vertex(), ospf_vertex_lookup(),
1189 ospf_install_candidate() and ospf_spf_register() functions not needed
1190 any more. Update ospf_vertex_new(), ospf_spf_next() and
1191 ospf_spf_calculate() functions to use pqueue instead of linked list.
1192
hassoe40dcce2005-02-21 14:58:42 +000011932005-02-21 Hasso Tepper <hasso at quagga.net>
1194
1195 * ospf_ase.c: Don't show messages related to the ase calculations if
1196 we are not debugging.
1197
hasso306541b2005-02-19 17:58:40 +000011982005-02-19 Hasso Tepper <hasso at quagga.net>
1199
1200 * ospf_api.h: char isn't always signed, but it has to be it here.
1201
paulfa81b712005-02-19 01:19:20 +000012022005-02-19 Paul Jakma <paul.jakma@sun.com>
1203
1204 * ospf_packet.c: (ospf_stream_copy) remove
1205 (ospf_packet_dup) use stream_copy instead of ospf_stream_copy
1206
ajs038163f2005-02-17 19:55:59 +000012072005-02-17 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1208
1209 * ospf_packet.c: (ospf_recv_packet) If there is somehow a runt
1210 packet in the queue, it must be discarded. Improve warning messages.
1211 Fix scope to static.
1212 (ospf_read) Fix bug: should reset the read thread in all cases
1213 to make sure we continue to get incoming messages.
1214
paul658b03a2005-02-15 10:10:55 +000012152005-02-15 Paul Jakma <paul.jakma@sun.com>
1216
1217 * ospf_packet.c: (ospf_recv_packet) Fix silly error wrt allocating
1218 ibuf. Thanks Andrew.
1219
paulbfdc44a2005-02-14 23:48:42 +000012202005-02-14 Paul Jakma <paul.jakma@sun.com>
1221
1222 * ospf_packet.c: (ospf_recv_packet) use stream_recvmsg.
1223
hasso082253f2005-02-11 08:31:54 +000012242005-02-11 Hasso Tepper <hasso at quagga.net>
1225
1226 * ospf_lsdb.c: Fix sum of checksums calculation.
1227
ajs083ee9d2005-02-09 15:35:50 +000012282005-02-09 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1229
1230 * ospf_packet.c: (ospf_write) If sendmsg fails, give more info in the
1231 error message.
1232
ajsba6454e2005-02-08 15:37:30 +000012332005-02-08 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1234
ajs8cfde372005-02-08 15:59:16 +00001235 * ospf_interface.h: Reduce structure padding by putting new u_char
1236 field multicast_memberships in a better spot (grouped with
1237 other u_char fields type and state).
1238
12392005-02-08 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1240
ajsba6454e2005-02-08 15:37:30 +00001241 * ospf_interface.h: Improve passive_interface comment. Add new
1242 multicast_memberships bitmask to struct ospf_interface to track
1243 active multicast subscriptions. Declare new function
1244 ospf_if_set_multicast.
1245 * ospf_interface.c: (ospf_if_set_multicast) New function to configure
1246 multicast memberships properly based on the current
1247 multicast_memberships status and the current values of the
1248 ospf_interface state, type, and passive_interface status.
1249 (ospf_if_up) Remove call to ospf_if_add_allspfrouters (this is
1250 now handled by ism_change_state's call to ospf_if_set_multicast).
1251 (ospf_if_down) Remove call to ospf_if_drop_allspfrouters (now
1252 handled by ism_change_state).
1253 * ospf_ism.c: (ospf_dr_election) Remove logic to join or leave
1254 the DRouters multicast group (now handled by ism_change_state's call
1255 to ospf_if_set_multicast).
1256 (ism_change_state) Add call to ospf_if_set_multicast to change
1257 multicast memberships as necessary to reflect the new interface state.
1258 * ospf_packet.c: (ospf_hello) When a Hello packet is received on a
1259 passive interface: 1. Increase the severity of the error message
1260 from LOG_INFO to LOG_WARNING; 2. Add more information to the error
1261 message (packet destination address and interface address);
1262 and 3. If the packet was sent to ospf-all-routers, then try
1263 to fix the multicast group memberships.
1264 (ospf_read) When a packet is received on an interface whose state
1265 is ISM_Down, enhance the warning message to show the packet
1266 destination address, and try to update/fix the multicast group
1267 memberships if the packet was sent to a multicast address.
1268 When a packet is received for ospf-designated-routers, but the
1269 current interface state is not DR or BDR, then increase the
1270 severity level of the error message from LOG_INFO to LOG_WARNING,
1271 and try to fix the multicast group memberships.
1272 * ospf_vty.c: (ospf_passive_interface) Call ospf_if_set_multicast for
1273 any ospf interface that may have changed from active to passive.
1274 (no_ospf_passive_interface) Call ospf_if_set_multicast for
1275 any ospf interface that may have changed from passive to active.
1276 (show_ip_ospf_interface_sub) Show multicast group memberships.
1277
paul3a9eb092005-02-08 11:29:41 +000012782005-02-08 Paul Jakma <paul@dishone.st>
1279
1280 * ospf_packet.c: (various) Remove unneeded stream_set_putp abuse.
1281
ajs847947f2005-02-02 18:38:48 +000012822005-02-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1283
1284 * ospf_packet.c: (ospf_read) Fix bug: must check for state ISM_Down,
1285 not for event ISM_InterfaceDown. And improve the message by
1286 adding the interface flags.
1287
ajs0b7d97d2005-01-30 17:24:02 +000012882005-01-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1289
1290 * ospf_network.c: (ospf_sock_init) Save errno before calling
1291 ospfd_privs.change.
1292
ajsc3eab872005-01-29 15:52:07 +000012932005-01-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1294
1295 * ospf_packet.c: (ospf_packet_add) If oi->obuf is NULL, print
1296 an error message and return.
1297 (ospf_read) If the interface state is ISM_InterfaceDown, issue
1298 a warning message and ignore the packet.
1299
gdt86f1fd92005-01-10 14:20:43 +000013002005-01-10 Greg Troxel <gdt@fnord.ir.bbn.com>
1301
1302 * ospf_packet.h: Remove commented out definition of
1303 OSPF_MAX_PACKET; neither it or the uncommented one are used any more.
1304
1305 * ospf_packet.c (ospf_make_ls_upd): Leave room for authentication
1306 when deciding if an update will fit.
1307 (ospf_packet_authspace): Factor out calculation of size required
1308 for authentication.
1309 (ospf_make_db_desc): Use ospf_max_packet, not OSPF_MAX_PACKET.
1310 Don't confuse readers that there is a macro.
1311
ajs3dc56b52004-12-30 15:11:19 +000013122004-12-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1313
1314 * ospf_network.c: Improve all setsockopt error messages to give detailed
1315 information on the arguments.
1316
ajsb87f7722004-12-29 20:41:26 +000013172004-12-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1318
ajs17eaa722004-12-29 21:04:48 +00001319 * ospf_packet.c: (ospf_db_desc) Reduce severity of "Negotiation done"
1320 messages from LOG_WARNING to LOG_INFO, since this seems to be
1321 normal.
1322
13232004-12-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1324
ajsb87f7722004-12-29 20:41:26 +00001325 * ospf_packet.c: (ospf_read) Always look up the interface if
1326 ospf_recv_packet returns NULL ifp, since some platforms such
1327 as Solaris 8 appear to support ifindex retrieval but don't.
1328
hasso1d806282004-12-22 09:43:20 +000013292004-12-22 Hasso Tepper <hasso at quagga.net>
1330
1331 * ospf_dump.c: Show debug configuration in vtysh.
hassoc6b87812004-12-22 13:09:59 +00001332 * ospf_vty.c: Fix "show ip ospf" output. Router can't be elected in
1333 any case if it's configured as "translate-never".
hassofe71a972004-12-22 16:16:02 +00001334 * ospf_lsdb.[ch]: New function to calculate sum of checksums.
1335 * ospf_vty.c: Bugfix to show really number of AS external LSAs, not
1336 number of all LSAs with AS scope, this includes opaque as LSAs as
1337 well, show this number separately. Show numbers and sums of
1338 checksums for each type of LSAs.
1339 * ospf_lsa.c: Calculate checksum before putting LSA into database.
hasso1d806282004-12-22 09:43:20 +00001340
ajsbc18d612004-12-15 15:07:19 +000013412004-12-15 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1342
1343 * ospf_interface.h: Declare new function ospf_default_iftype.
1344 * ospf_interface.c: (ospf_default_iftype) New function to centralize
1345 this logic in one place.
1346 * ospf_zebra.c: (ospf_interface_add) Use new function
1347 ospf_default_iftype.
1348 * ospf_vty.c: (no_ip_ospf_network,config_write_interface) Fix logic
1349 by using new function ospf_default_iftype.
1350
ajs3aa8d5f2004-12-11 18:00:06 +000013512004-12-11 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1352
1353 * ospf_packet.c: (ospf_db_desc) Should be static, not global.
1354 (ospf_hello,ospf_db_desc,ospf_ls_upd,ospf_ls_ack) Improve warning
1355 messages to include identifying information (e.g. router id).
1356 * ospf_nsm.c: (nsm_change_state) Improve info message to include
1357 router id and state names.
1358
gdt91f3e522004-12-09 14:51:03 +000013592004-12-09 Greg Troxel <gdt@fnord.ir.bbn.com>
1360
gdt3fb9de72004-12-09 16:30:04 +00001361 * ospf_apiserver.c (ospf_apiserver_term): Obtain struct
1362 ospf_apiserver * from listnode. Remove unused variables. Follows
1363 suggestion from Jay Fenlason.
gdt91f3e522004-12-09 14:51:03 +00001364
ajs9b0e25c2004-12-08 19:06:51 +000013652004-12-08 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1366
1367 * *.c: Change level of debug messages to LOG_DEBUG.
1368
ajs274a4a42004-12-07 15:39:31 +000013692004-12-07 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1370
1371 * ospf_main.c: (main) The 2nd argument to openzlog has been removed.
1372
ajs887c44a2004-12-03 16:36:46 +000013732004-12-03 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1374
ajs1210fa62004-12-03 16:43:24 +00001375 * ospf_packet.c: (ospf_db_desc) Reduce priority on a debug message
1376 from LOG_NOTICE to LOG_DEBUG.
1377
13782004-12-03 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1379
ajs887c44a2004-12-03 16:36:46 +00001380 * ospf_main.c: (sigint) Use zlog_notice for termination message.
1381 (main) Issue a startup announcement using zlog_notice.
1382
ajsbec595a2004-11-30 22:38:43 +000013832004-11-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1384
1385 * ospf_packet.c: (ospf_db_desc_proc) Fix spelling of packet in warning
1386 message and in comment.
1387 (ospf_db_desc) Warning message that a packet is being discarded
1388 should give the router id of the packet source. Fix spelling
1389 of packet in two warning messages.
1390 (ospf_ls_req) Warning message that a link state request is being
1391 discarded should give the router id of the neighbor that sent it.
1392
ajs5b85fac2004-11-26 19:36:42 +000013932004-11-26 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1394
1395 * ospf_main.c: Remove #include "debug.h" (was not being used, and
1396 lib/debug.h has now been deleted).
1397
hassoc0652302004-11-25 19:33:48 +000013982004-11-25 Hasso Tepper <hasso at quagga.net>
1399
1400 * ospf_main.c: Make group to run as configurable.
1401
gdt69e13252004-11-15 18:51:15 +000014022004-11-15 Greg Troxel <gdt@fnord.ir.bbn.com>
1403
1404 * ospf_packet.c (ospf_recv_packet): Assume CMSG_SPACE is present
1405 and works (lib/zebra.h provides if OS doesn't).
1406
paul788dab12004-11-15 11:48:37 +000014072004-11-15 Paul Jakma <paul@dishone.st>
1408
1409 * ospf_{apiserver,te}.c: ospf_lsa_free's should be ospf_lsa_unlock.
1410
paul05e85fa2004-11-12 10:52:19 +000014112004-11-12 Paul Jakma <paul@dishone.st>
1412
1413 * ospf_ia.c: (process_summary_lsa) Only an ABR has any reason to
1414 ignore stub area summary default. Even so it seems a strange
1415 check, add a comment to that effect.
1416
paulf3ae74c2004-11-04 20:35:31 +000014172004-11-04 Paul Jakma <paul@dishone.st>
1418
1419 * ospfd.c: (ospf_network_match_iface) revert to previous network
1420 statement match behaviour.
1421
paul62d8e962004-11-02 20:26:45 +000014222004-11-02 Paul Jakma <paul@dishone.st>
1423
1424 * ospf_packet.c: (ospf_write_frags) remove iov arg, msg already points
1425 to it. Add convenience pointer to msg->msg_iov[1], and use this,
1426 fixing the unfortunate borkenness introduced in moving of this code
1427 to a function.
1428 (ospf_write) remove iovp and fix up call to previous.
1429 (ospf_ls_upd_packet_new) cast size to long int - unfortunately
1430 glibc's size_t format modifier is not portable.
1431
paul37ccfa32004-10-31 11:24:51 +000014322004-10-31 Paul Jakma <paul@dishone.st>
1433
1434 * ospf_packet.c: (ospf_write_frags) Add debug output
1435 (ospf_write) set type early, so we can pass it to
1436 ospf_write_frags.
1437 (ospf_ls_upd_packet_new) print size in debug output when too large
1438 packet is encountered.
paul64511f32004-10-31 18:01:13 +00001439 * ospf_zebra.c: (ospf_distribute_list_update_timer) Ugly misuse of
1440 THREAD_ARG to store an integer, but it should at least use same
1441 same type to retrieve the value. Assert value is sane.
paul37ccfa32004-10-31 11:24:51 +00001442
paulac191232004-10-22 12:05:17 +000014432004-10-22 Paul Jakma <paul@dishone.st>
1444
1445 * ospf_network.c: (ospf_sock_init) call neutral setsock_ifindex()
1446 function.
1447 * ospf_packet.c: (ospf_read) manually look up ifindex
paul4ccb2c42004-10-22 22:52:33 +00001448 if system could not have returned one, eg openbsd, thanks to Rivo
1449 Nurges for highlighting problem and fix.
paul06f953f2004-10-22 17:00:38 +00001450 Change setsockopt_pktinfo to setsockopt_ifindex.
paulac191232004-10-22 12:05:17 +00001451
hasso3fb9cd62004-10-19 19:44:43 +000014522004-10-19 Andrew J. Schorr <aschorr@telemetry-investments.com>
1453
1454 * ospf_snmp.c: (ospf_snmp_if_update) Fix logic to handle PtP links
1455 with dedicated subnets properly.
1456 * ospf_lsa.c: (lsa_link_ptop_set) ditto.
1457 * ospfd.c: (ospf_network_match_iface) ditto.
1458 (ospf_network_run) ditto.
1459 * ospf_interface.c: (ospf_if_is_configured) ditto.
1460 (ospf_if_lookup_by_prefix) ditto.
1461 (ospf_if_lookup_recv_if) ditto.
1462 * ospf_vty.c: (show_ip_ospf_interface_sub) Display the peer or
1463 broadcast address if present.
1464
hassod68614d2004-10-13 09:32:48 +000014652004-10-13 Hasso Tepper <hasso at quagga.net>
1466
1467 * ospf_main.c: Unbreak compilation with ospfapi disabled.
hassoc75105a2004-10-13 10:33:26 +00001468 * ospf_snmp.c: Remove defaults used to initialize smux connection to
1469 snmpd. Connection is initialized only if smux peer is configured.
hassod68614d2004-10-13 09:32:48 +00001470
hassof4d58ce2004-10-12 06:13:54 +000014712004-10-12 Hasso Tepper <hasso at quagga.net>
1472
1473 * ospf_main.c, ospf_opaque.c: Unbreak ospfclient compilation - move
1474 static variable from ospf_main.c into ospf_opaque.c.
1475
hassoc3abdb72004-10-11 16:27:03 +000014762004-10-11 Hasso Tepper <hasso at quagga.net>
1477
1478 * ospf_main.c, ospf_opaque.c: Disable ospfapi init by default. New
1479 command line switch to enable it.
1480
paul6b333612004-10-11 10:11:25 +000014812004-10-11 Paul Jakma <paul@dishone.st>
1482
1483 * ospf_dump.c: (ospf_ip_header_dump) Assume header is in host order
1484 remove ntohs that should have dissappeared. Take struct ip
1485 as argument, caller has to know there's an IP header at start of
1486 stream anyway.
1487 * ospf_dump.h: update declaration of ospf_ip_header_dump.
1488 * ospf_packet.c: (ospf_write) correct call to
1489 sockopt_iphdrincl_swab_htosys which was munging the header.
1490 (ospf_recv_packet) ip_len is needed for old OpenBSD fixup.
1491 (ospf_read) sockopt_iphdrincl_swab_systoh ip header as soon as
1492 we have it.
paul6c835672004-10-11 11:00:30 +00001493 * (global) Const char update and signed/unsigned fixes.
1494 * (various headers) size defines should be unsigned.
1495 * ospf_interface.h: remove duplicated defines, include the
1496 authoritative header - though, these defines should probably
1497 be moved to a dedicated header, or ospfd.h.
1498 * ospf_lsa.h: (struct lsa) ls_seqnum should be unsigned.
1499 * ospf_packet.c: (ospf_write) cast result of shift to unsigned.
paul6b333612004-10-11 10:11:25 +00001500
hassoeb1ce602004-10-08 08:17:22 +000015012004-10-08 Hasso Tepper <hasso at quagga.net>
1502
1503 * *.[c|h]: Fix compiler warnings: make some strings const, signed ->
1504 unsigned, remove unused variables etc.
1505
gdt54ade992004-10-07 19:38:20 +000015062004-10-07 Greg Troxel <gdt@claude.ir.bbn.com>
1507
1508 * ospf_apiserver.c (ospf_apiserver_unregister_opaque_type): Don't
1509 use of variable names 'node' and 'nextnode' to avoid possible
1510 conflict with list macros. Move variable declaration inside for
1511 loop after a statement to top of function.
1512
paulaa20c6f2004-10-07 14:19:36 +000015132004-10-07 Paul Jakma <paul@dishone.st>
1514
1515 * ospf_snmp.c: Missed list typedef update
1516 * ospf_dump.c: Include sockopt.h for header swab functions.
1517
paul18b12c32004-10-05 14:38:29 +000015182004-10-05 Paul Jakma <paul@dishone.st>
1519
1520 * ospf_packet.c: replace ospf_swap_iph_to... with
1521 sockopt_iphdrincl_swab_...
1522
hasso18a6dce2004-10-03 18:18:34 +000015232004-10-03 James R. Leu <jleu at mindspring.com>
1524
1525 * ospf_zebra.c: Read router id related messages from zebra daemon.
1526 Schedule router-id update thread if it's changed.
1527 * ospfd.c: Remove own router-id selection function. Use router id from
1528 zebra daemon if it isn't manually overriden in configuration.
1529
paul68defd62004-09-27 07:27:13 +000015302004-09-27 Paul Jakma <paul@dishone.st>
1531
paul6a99f832004-09-27 12:56:30 +00001532 * ospf_dump.c: (ospf_ip_header_dump) Use HAVE_IP_HDRINCL_BSD_ORDER
1533 Apply to offset too. Print ip_cksum, lets not worry about
1534 possible 2.0.37 compile problems.
1535 * ospf_packet.c: (ospf_swap_iph_to{n,h}) Use
1536 HAVE_IP_HDRINCL_BSD_ORDER.
1537 (ospf_recv_packet) ditto.
1538 (ospf_write) Fixup iov argument to ospf_write_frags.
1539 (struct msghdr).msg_name is caddr_t on most platforms.
paul68defd62004-09-27 07:27:13 +00001540 (ospf_recv_packet) ditto. And msg_flags is not always there
1541 memset struct then set fields we care about rather than
1542 initialise all fields individually.
1543
hassoc9e52be2004-09-26 16:09:34 +000015442004-09-26 Hasso Tepper <hasso at quagga.net>
1545
1546 * ospf_abr.c, ospf_dump.c, ospf_lsa.c, ospf_packet.c, ospf_vty.c,
1547 ospf_zebra.c: Fix compiler warnings.
1548
paul87d6f872004-09-24 08:01:38 +000015492004-09-24 Paul Jakma <paul@dishone.st>
1550
1551 * ospf_apiserver.{c,h}: lists typedef removal cleanup.
1552 update some list loops to LIST_LOOP. some miscellaneous indent
1553 fixups.
1554 (ospf_apiserver_unregister_opaque_type) fix listnode_delete of
1555 referenced node in loop.
paul1603c062004-09-24 08:23:24 +00001556 (ospf_apiserver_term) loops calling ospf_apiserver_free, which
1557 deletes referenced nodes from apiserver_list, fixed.
paul87d6f872004-09-24 08:01:38 +00001558 * ospf_interface.h: lists typedef removal cleanup.
1559 * ospf_opaque.{c,h}: lists typedef removal cleanup. update some list
1560 loops to LIST_LOOP. miscellaneous style and indent fixups.
1561 * ospf_te.{c,h}: ditto
1562 * ospf_packet.c: lists typedef removal cleanup.
paula2570682004-09-24 08:09:57 +00001563 (ospf_write) ifdef fragmentation support. move actual
1564 fragmentation out to a new, similarly ifdefed, function.
1565 (ospf_write_frags) fragmented write support, moved from previous.
paul87d6f872004-09-24 08:01:38 +00001566
hasso52dc7ee2004-09-23 19:18:23 +000015672004-09-23 Hasso Tepper <hasso at quagga.net>
1568
1569 * *.[c|h]: list -> struct list *, listnode -> struct listnode *.
1570
paul68b73392004-09-12 14:21:37 +000015712004-09-12 Paul Jakma <paul@dishone.st>
1572
1573 * ospf_packet.c: Fix bugzilla #107
1574 (ospf_packet_max) get rid of the magic 88 constant
1575 (ospf_swab_iph_ton) new function. set ip header to network order,
1576 taking BSDisms into account.
1577 (ospf_swab_iph_toh) the inverse.
1578 (ospf_write) Add support for IP fragmentation, will only work on
1579 linux though, other kernels make it impossible. get rid of the
1580 magic 4 constant.
1581 (ospf_make_ls_upd) Bound check to end of stream, not to
1582 interface mtu.
1583 (ospf_ls_upd_packet_new) New function, allocate upd packet
1584 taking oversized LSAs into account.
1585 (ospf_ls_upd_queue_send) use ospf_ls_upd_packet_new to allocate,
1586 rather than statically allocating mtu sized packet buffer, which
1587 actually was wrong - it didnt take ip header into account, which
1588 should not be included in packet buffer.
1589 (ospf_ls_upd_send_queue_event) minor tweaks and remove
1590 TODO comment.
1591
gdt630e4802004-08-31 17:28:41 +000015922004-08-31 David Wiggins <dwiggins@bbn.com>
1593
1594 * ospf_spf.c (ospf_spf_calculate): Many more comments and debug
1595 print statements. New function ospf_vertex_dump used in debugging.
1596
15972004-08-31 David Wiggins <dwiggins@bbn.com>
1598
1599 * ospf_spf.h (struct vertex): Comments for flags and structure members.
1600
16012004-08-31 David Wiggins <dwiggins@bbn.com>
1602
1603 * ospf_route.c: When finding an alternate route, log cost as well.
1604
16052004-08-31 David Wiggins <dwiggins@bbn.com>
1606
1607 * ospf_interface.c (ospf_lookup_if_params): Initialize af in
1608 struct prefix allocated on stack.
1609
16102004-08-31 David Wiggins <dwiggins@bbn.com>
1611
1612 * ospf_packet.c (ospf_ls_ack_send_delayed): In p2mp mode, send
1613 acks to AllSPFRouters, rather than All-DR.
1614
hasso7b901432004-08-31 13:37:42 +000016152004-08-27 Hasso Tepper <hasso at quagga.net>
1616
1617 * ospf_vty.c: Don't print ospf network type under interface only
1618 if interface is in broadcast mode and interface type really is
1619 broadcast. Fixes Bugzilla #108.
1620
gdtd7d93992004-08-27 12:03:42 +000016212004-08-27 David Wiggins <dwiggins@bbn.com>
1622
1623 * ospf_spf.c (ospf_nexthop_calculation): Initialize address family
1624 in on-stack struct prefix_ipv4. Fixes point-to-multipoint SPF
1625 calculation.
1626
gdtd0deca62004-08-26 13:14:07 +000016272004-08-26 Greg Troxel <gdt@fnord.ir.bbn.com>
1628
1629 * ospf_packet.c (ospf_recv_packet): adjust size declaration of
gdtd7d93992004-08-27 12:03:42 +00001630 buffer used to get interface index so that it compiles on other
1631 than Linux and includes the required alignment space. Probably
1632 this was only working on sparc/sparc64 because most of
1633 sockaddr_dl was not being written.
gdtd0deca62004-08-26 13:14:07 +00001634
paul863082d2004-08-19 04:43:43 +000016352004-08-19 Paul Jakma <paul@dishone.st>
1636
1637 * ospf_packet.c: update to match sockopt renames.
1638
paul75ee0b82004-08-05 09:10:31 +000016392004-08-04 Paul Jakma <paul@dishone.st>
1640
1641 * ospf_spf.c: (ospf_spf_consider_nexthop) Add comment about issue.
1642 Compare only against list head - all nexthops must be same cost
1643 anyway, fixes a reference-listnode-after-delete bug noted by
1644 Kir Kostuchenko.
1645 (ospf_nexthop_calculation) Use ospf_spf_consider_nexthop for all
1646 candidates attached to root.
1647
paul36c64ef2004-07-27 11:19:11 +000016482004-07-27 Paul Jakma <paul@dishone.st>
1649
paul48fe13b2004-07-27 17:40:44 +00001650 * ospf_packet.c: (ospf_ls_upd_send_queue_event) fix thinko from
1651 last fix for ospfd wedging due to oversize LSAs: dont list loop on
1652 ospf_ls_upd_queue_send() - guaranteed segfault.
1653
16542004-07-27 Paul Jakma <paul@dishone.st>
1655
paul36c64ef2004-07-27 11:19:11 +00001656 * ospf_opaque.c: (ospf_opaque_lsa_flush_schedule) do not NULL out
1657 the LSA as then free_opaque_info_per_id() can never unlock (and
1658 free) the LSA. Reported by Gunnar Stigen.
1659
paul2dd8bb42004-07-23 15:13:48 +000016602004-07-23 Paul Jakma <paul@dishone.st>
1661
1662 * ospf_network.c: Replace PKTINFO/RECVIF with call to
1663 setsockopt_pktinfo
1664 * ospf_packet.c: Use getsockopt_pktinfo_ifindex and
1665 SOPT_SIZE_CMSG_PKTINFO_IPV4.
1666
paul59ea14c2004-07-14 20:50:36 +000016672004-07-14 Paul Jakma <paul@dishone.st>
1668
1669 * ospf_packet.c: (ospf_ls_upd_send_queue_event) Partial fix for
1670 problem reported by Peter Frost amongst others, where function
1671 will spin indefinitely if update list contains LSAs greater than
1672 MTU-headers or other condition leading to update list never being
1673 cleared. Problem of what to do with these LSAs remains.
1674 (ospf_make_ls_upd) add comment about large LSA problem,
1675 indentation cleanup.
1676
gdtb2c1b282004-07-01 12:35:36 +000016772004-07-01 Greg Troxel <gdt@fnord.ir.bbn.com>
1678
1679 * Makefile.am (lib_LTLIBRARIES): make libospf shared
1680
gdt87efd642004-06-30 17:36:11 +000016812004-06-30 Greg Troxel <gdt@poblano.ir.bbn.com>
1682
1683 * Makefile.am: Add shlib support.
1684
hassobeebba72004-06-20 21:00:27 +000016852004-06-10 Hasso Tepper <hasso@estpak.ee>
1686
1687 * *: Removed ifdefs HAVE_NSSA.
1688
paul553ff112004-06-06 09:41:00 +000016892004-06-06 Paul Jakma <paul@dishone.st>
1690
1691 * ospf_dump.c,ospf_lsa.c: Fix typos of merge of previous.
1692 ospf_flood.c: (ospf_process_self_originated_lsa) fix zlog format
1693
paul0c2be262004-05-31 14:16:54 +000016942004-05-31 Sagun Shakya <sagun.shakya@sun.com>
1695
1696 * ospf_dump.c: (ospf_lsa_header_dump) LOOKUP can return null if
1697 index is out of range.
1698 ospf_flood.c: endianness fix
1699 ospf_lsa.c: Missing ntohl's on (struct lsa *)->data->ls_seqnum
1700 in various places.
1701
hassodd669bb2004-05-10 07:43:59 +000017022004-05-10 Hasso Tepper <hasso@estpak.ee>
1703
1704 * ospf_zebra.c, ospfd.c: Move ospf_prefix_list_update() function
1705 to ospf_zebra.c from ospfd.c and add redistribution updates if
1706 route-map is used in redistribution.
1707 * ospf_main.c: Remove now useless call to ospf_init().
1708
paul0a589352004-05-08 11:48:26 +000017092004-05-08 Paul Jakma <paul@dishone.st>
1710
1711 * ospf_zebra.c: Sync with lib/zclient changes
1712
pauld3f0d622004-05-05 15:27:15 +000017132004-05-05 Paul Jakma <paul@dishone.st>
1714
paul5bd41892004-05-05 17:29:24 +00001715 * ospf_network.c: (ospf_sock_init) Check whether IP_HDRINCL is
1716 defined. Warn at compile and runtime. Use
1717 IPTOS_PREC_INTERNETCONTROL otherwise.
pauld3f0d622004-05-05 15:27:15 +00001718 * ospf_packet.c: (ospf_associate_packet_vl) cleanup, move
1719 some of the checks up to ospf_read, return either a
1720 virtual link oi, or NULL.
1721 (ospf_read) Cleanup, make it responsible for checks. Remove
1722 the nbr lookup - moved to ospf_neighbor. Adjust all nbr
1723 lookups to use new wrappers exported by ospf_neighbor.
1724 * ospf_neighbor.h: Add ospf_neigbour_get and ospf_nbr_lookup.
1725 * ospf_neighbor.c: (ospf_neigbour_get) Index ospf_interface
1726 neighbour table by router-id for virtual-link ospf_interfaces,
1727 not by peer_addr (which breaks for asymmetric vlinks)
1728 (ospf_nbr_lookup) add a wrapper for nbr lookups to deal with
1729 above.
paulcd59da62004-05-05 17:26:55 +00001730 * ospf_interface.c: (ospf_vl_set_params) Catch changes of interface
1731 address for either end of a virtual-link, and hence potential cost
1732 changes.
1733
hassoa0a39762004-04-23 08:51:10 +000017342004-04-22 Hasso Tepper <hasso@estpak.ee>
1735
1736 * ospf_zebra.c: Don't ignore reject/bh routes, it's the only way
1737 to "summarize" routes in ASBR at the moment.
1738
hasso8585d4e2004-04-20 17:25:12 +000017392004-04-20 Hasso Tepper <hasso@estpak.ee>
1740
1741 * ospfd.c: Unset NP flag if area is going to be normal or stub.
1742 Fixes UNH OSPF_NSSA.1.2a comment.
1743 * ospf_abr.c: Originate default into stub/nssa area even if
1744 summaries are disabled.
1745 * ospf_zebra.c: Don't attempt to redistribute 127.0.0.0/8.
1746
hassoc266ac72004-04-19 17:31:00 +000017472004-04-19 Hasso Tepper <hasso@estpak.ee>
1748
1749 * ospf_vty.c: Don't warn that export- and import-list can't be
1750 configured to backbone area if they are applied and are working
1751 fine.
1752
hasso128d31d2004-04-04 12:52:33 +000017532004-02-19 Sowmini Varadhan <sowmini.varadhan@sun.com>
1754
1755 * ospf_packet.c: Don't drop packets in Solaris x86.
1756 [quagga-dev 1005].
1757
hasso0d85b992004-03-18 19:18:33 +000017582004-03-18 Amir Guindehi <amir@datacore.ch>
1759
1760 * ospf_opaque.c: Attempt to correct the incorrect behavior of
1761 Quagga's ospfd in the special situation that a node's opaque
1762 capability has changed as "ON -> OFF -> ON". [quagga-dev 843].
1763
paul7f352b82004-02-19 19:37:47 +000017642004-02-19 Sowmini Varadhan <sowmini.varadhan@sun.com>
1765
1766 * ospf_abr.c: (ospf_abr_update_aggregate) UNH 3.12b,c, address range
1767 should be configured with the highest cost path within the range,
1768 not lowest.
1769
paul940b01a2004-02-17 20:07:30 +000017702004-02-17 Paul Jakma <paul@dishone.st>
1771
1772 * ospf_zebra.c: (ospf_interface_delete) Do not delete the interface
1773 params, nor the interface structure, if an interface delete
1774 message is received from zebra.
1775 * ospf_interface.c: (ospf_if_delete_hook) Delete the interface
1776 params and interface, ie that which was previously removed in
1777 (ospf_interface_delete) above.
1778
hasso2db3d052004-02-11 21:52:13 +000017792004-02-11 Hasso Tepper <hasso@estpak.ee>
1780 * ospf_interface.c, ospf_zebra.c: Don't attempt to read path->oi->ifp
1781 if oi doesn't exist any more.
1782
hassocb05eb22004-02-11 21:10:19 +000017832004-02-11 Vadim Suraev <vadim.suraev@terayon.com>
1784 * ospf_packet.c (ospf_ls_upd): Router should flush received network
1785 LSA if it was originated with older router-id ([zebra 14710] #6).
1786
17872003-12-08 Mattias Amnefelt <mattiasa@kth.se>
paul239aecc2003-12-08 10:34:54 +00001788
1789 * ospf_packet.c: (ospf_recv_packet) OpenBSD now leaves iph.ip_len
1790 network byte order.
1791
gdt8f40e892003-12-05 14:01:43 +000017922003-12-05 Greg Troxel <gdt@poblano.ir.bbn.com>
1793
1794 * ospfd.c (ospf_network_match_iface): Rewrite code for clarity
1795 while trying not to change semantics. Add ifdefed-out code to
1796 avoid matching ppp interfaces whose destination address does not
1797 also match the prefix under consideration, to help out people with
1798 problems due to as-yet-unfixed bugs with p2p interfaces coming and
1799 going.
1800
paul736d3442003-07-24 23:22:57 +000018012003-07-25 kamatchi soundaram <kamatchi@tdd.sj.nec.com>
1802
1803 * ospf_packet.c (ospf_ls_upd_send_queue_event): get next route
1804 node in body of the loop to avoid chance that route node
1805 is unlocked and deleted before the next iteration tries to
1806 get next route node.
1807
paul0a825c72003-05-24 13:48:16 +000018082003-05-24 Kenji Yabuuchi
1809
1810 * ospf_interface.c(ospf_if_lookup_recv_if): Use the most specific
1811 match for interface lookup.
1812
paul551a8972003-05-18 15:22:55 +000018132003-05-18 Hasso Tepper <hasso@estpak.ee>
paul445f1432003-05-16 19:00:31 +00001814
paul551a8972003-05-18 15:22:55 +00001815 * ospf_vty.c: Show NSSA LSA route info in "show ip ospf database"
1816 output
paul445f1432003-05-16 19:00:31 +00001817
pauld7480322003-05-16 17:31:51 +000018182003-05-16 Hasso Tepper <hasso@estpak.ee>
1819
1820 * ospf_lsa.c: Fix handling of NSSA
1821
paul551a8972003-05-18 15:22:55 +000018222003-04-23 Hasso Tepper <hasso@estpak.ee>
1823
1824 * ospf_vty.c: fix "router xxx" node commands in vtysh
1825
paul445f1432003-05-16 19:00:31 +000018262003-04-19 Hasso Tepper <hasso@estpak.ee>
1827
1828 * {ospf_abr,ospfd}.c: area id's DECIMAL -> ADDRESS
1829 * ospf_routemap.c: sync daemon's route-map commands to have same
1830 syntax.
1831
18322003-04-19 Sergey Vyshnevetskiy <serg@vostok.net>
1833
1834 * ospf_packet.c: Add missing param to zlog
1835 * ospf_flood.c: remove unused vars
1836
18372003-04-17 Denis Ovsienko <zebra@pilot.org.ua>
1838
1839 * ospf_interface.c: fix incorrect memset
1840
paul28a13842003-05-16 20:30:37 +000018412003-04-10 Amir Guindehi <amir@datacore.ch>
paul445f1432003-05-16 19:00:31 +00001842
1843 * ospf_lsa.[ch]: opaque LSA fix, use ospf_lookup.
1844
18452003-04-03 David Watson <dwatson@eecs.umich.edu>
1846
1847 * ospf_lsa.c: byte order fix
1848
paul07661cb2003-03-18 00:03:05 +000018492002-03-17 Amir Guindehi <amir@datacore.ch>
1850
1851 * ospf_apiserver.[ch]: Merge Ralph Keller's OSPFAPI support.
1852 * ospf_api.[ch]: Merge Ralph Keller's OSPFAPI support.
1853 * ospfclient: OSPFAPI demonstration client.
1854
18552003-01-23 Masahiko Endo <endo@suri.co.jp>
1856
1857 * ospf_ism.c: NSM event schedule bug fix.
1858
18592002-10-30 Greg Troxel <gdt@ir.bbn.com>
1860
1861 * ospf_packet.c (ospf_make_md5_digest): MD5 length fix.
1862
paul718e3742002-12-13 20:15:29 +000018632002-10-23 endo@suri.co.jp (Masahiko Endo)
1864
1865 * ospf_opaque.c: Update Opaque LSA patch.
1866
18672002-10-23 Ralph Keller <keller@tik.ee.ethz.ch>
1868
1869 * ospf_vty.c (show_ip_ospf_database): Fix CLI parse.
1870
18712002-10-23 Juris Kalnins <juris@mt.lv>
1872
1873 * ospf_interface.c (ospf_if_stream_unset): When write queue
1874 becomes empty stop write timer.
1875
18762002-10-10 Greg Troxel <gdt@ir.bbn.com>
1877
1878 * ospf_packet.c (ospf_check_md5_digest): Change >= to > to make it
1879 conform to RFC.
1880
18812002-07-07 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1882
1883 * zebra-0.93 released.
1884
18852002-06-19 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1886
1887 * ospf_spf.c (ospf_nexthop_calculation): Add NULL set to oi and
1888 check of l2. Reported by: Daniel Drown <dan-zebra@drown.org>
1889 (ospf_lsa_has_link): LSA Length calculation fix. Reported by:
1890 Paul Jakma <paulj@alphyra.ie>.
1891
1892 * ospfd.c (ospf_if_update): Fix nextnode reference bug. Reported
1893 by: juris@mt.lv.
1894
18952002-01-21 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1896
1897 * ospfd.c: Merge [zebra 11445] Masahiko ENDO's Opaque-LSA support.
1898
18992001-08-27 Kunihiro Ishiguro <kunihiro@zebra.org>
1900
1901 * ospf_interface.c (ospf_add_to_if): Use /32 address to register
1902 OSPF interface information.
1903 (ospf_delete_from_if): Likewise.
1904
1905 * ospf_zebra.c (ospf_interface_address_delete): Likewise.
1906
19072001-08-23 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1908
1909 * ospf_zebra.c (ospf_redistribute_unset): When redistribute type
1910 is OSPF, do not unset redistribute flag.
1911
19122001-08-19 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1913
1914 * zebra-0.92a released.
1915
19162001-08-15 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1917
1918 * zebra-0.92 released.
1919
19202001-08-12 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1921
1922 * ospfd.c (ospf_config_write): auto-cost reference-bandwidth
1923 configuration display.
1924
19252001-07-24 David Watson <dwatson@eecs.umich.edu>
1926
1927 * ospf_spf.c (ospf_spf_next): Modify ospf_vertex_add_parent to
1928 check for an existing link before connecting the parent and child.
1929 ospf_nexthop_calculation is also modified to check for duplicate
1930 entries when copying from the parent. Finally, ospf_spf_next
1931 removes duplicates when it merges two equal cost candidates.
1932
19332001-07-23 itojun@iijlab.net
1934
1935 * ospfd.c (show_ip_ospf_neighbor): Check ospf_top before use it
1936 [zebra 8549].
1937
19382001-07-23 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1939
1940 * ospf_packet.c (ospf_write): Remove defined(__OpenBSD__) to make
1941 it work on OpenBSD.
1942
19432001-06-26 Kunihiro Ishiguro <kunihiro@zebra.org>
1944
1945 * ospf_zebra.c (config_write_ospf_default_metric): Display
1946 default-metric configuration.
1947
19482001-06-18 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1949
1950 * ospf_ia.h (OSPF_EXAMINE_SUMMARIES_ALL): Remove old macros.
1951
19522001-05-28 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1953
1954 * ospf_snmp.c (ospfIfEntry): Fix interface lookup bug to avoid
1955 crush.
1956 (ospfIfMetricEntry): Likewise.
1957
19582001-03-18 Kunihiro Ishiguro <kunihiro@zebra.org>
1959
1960 * ospf_packet.c (ospf_read): Fix typo. Reported by: "Jen B
1961 Lin'Kova" <jen@stack.net>.
1962
19632001-03-15 Gleb Natapov <gleb@nbase.co.il>
1964
1965 * ospf_interface.c (ip_ospf_network): Set interface parameter.
1966 (interface_config_write): Add check for OSPF_IFTYPE_LOOPBACK.
1967
1968 * ospf_zebra.c (ospf_interface_add): Set interface parameter.
1969
19702001-02-21 Kunihiro Ishiguro <kunihiro@zebra.org>
1971
1972 * ospf_packet.c (ospf_recv_packet): Solaris also need to add
1973 (iph.ip_hl << 2) to iph.ip_len.
1974
19752001-02-09 Kunihiro Ishiguro <kunihiro@zebra.org>
1976
1977 * ospfd.h (OSPF_LS_REFRESH_TIME): Fix OSPF_LS_REFRESH_TIME value.
1978 Suggested by: David Watson <dwatson@eecs.umich.edu>.
1979
1980 * ospf_zebra.c (zebra_init): Remove zebra node.
1981
1982 * ospfd.c (ospf_area_range_set): Function name is changed from
1983 ospf_ara_range_cmd.
1984 (ospf_area_range_unset): New function which separated from DEFUN.
1985 New commands are added:
1986 "no area A.B.C.D range A.B.C.D/M advertise"
1987 "no area <0-4294967295> range A.B.C.D/M advertise"
1988 "no area A.B.C.D range A.B.C.D/M not-advertise"
1989 "no area <0-4294967295> range A.B.C.D/M not-advertise"
1990
1991 * ospf_lsa.c (ospf_lsa_more_recent): Fix previous change.
1992
19932001-02-08 Matthew Grant <grantma@anathoth.gen.nz>
1994
1995 * ospf_network.c (ospf_if_add_allspfrouters): Use
1996 setsockopt_multicast_ipv4.
1997 (ospf_if_drop_allspfrouters): Likewise.
1998
1999 * ospf_lsa.c (ospf_router_lsa_install): Add rt_recalc flag.
2000 (ospf_network_lsa_install): Likewise.
2001 (ospf_summary_lsa_install): Likewise.
2002 (ospf_summary_asbr_lsa_install): Likewise.
2003 (ospf_external_lsa_install): Likewise.
2004 (ospf_lsa_install): Call ospf_lsa_different to check this LSA is
2005 new one or not.
2006
20072001-02-08 Kunihiro Ishiguro <kunihiro@zebra.org>
2008
2009 * ospf_zebra.c (ospf_interface_delete): Do not free interface
2010 structure when ospfd receive interface delete message to support
2011 pseudo interface.
2012
20132001-02-01 Dick Glasspool <dick@ipinfusion.com>
2014
2015 * ospfd.c (area_range_notadvertise): Change area range "suppress"
2016 command to "not-advertise".
2017
2018 * ospfd.h (OSPF_LS_REFRESH_TIME): Change OSPF_LS_REFRESH_TIME from
2019 1800 to 60.
2020
2021 * ospf_abr.c (ospf_abr_update_aggregate): When update_aggregate is
2022 updating the area-range, the lowest cost is now saved.
2023
2024 * ospf_lsa.c (ospf_lsa_more_recent): Routing to compare sequence
2025 numbers rather than creating overflow during calculation.
2026
20272001-02-01 Kunihiro Ishiguro <kunihiro@zebra.org>
2028
2029 * zebra-0.91 is released.
2030
20312001-01-31 Kunihiro Ishiguro <kunihiro@zebra.org>
2032
2033 * ospf_packet.c (ospf_db_desc_proc): Do not continue process when
2034 NSM_SeqNumberMismatch is scheduled.
2035 (ospf_ls_req): Free ls_upd when return from this function.
2036 (ospf_ls_upd_timer): When update list is empty do not call
2037 ospf_ls_upd_send(). Suggested by: endo@suri.co.jp (Masahiko
2038 Endo).
2039
20402001-01-26 Kunihiro Ishiguro <kunihiro@zebra.org>
2041
2042 * ospf_lsa.c (ospf_maxage_flood): Flood LSA when it reaches
2043 MaxAge. RFC2328 Section 14.
2044 (ospf_maxage_lsa_remover): Call above function during removing
2045 MaxAge LSA.
2046
20472001-01-26 Dick Glasspool <dick@ipinfusion.com>
2048
2049 * ospf_flood.c (ospf_flood_through_as): Function is updated for
2050 NSSA Translations now done at ospf_abr.c with no change in P-bit.
2051
2052 * ospf_lsa.c (ospf_get_nssa_ip): Get 1st IP connection for Forward
2053 Addr.
2054 (ospf_install_flood_nssa): Leave Type-7 LSA at Lock Count = 2.
2055
2056 * ospf_ase.c (ospf_ase_calculate_route): Add debug codes.
2057
2058 * ospf_abr.c (ospf_abr_translate_nssa): Recalculate LSA checksum.
2059
2060 * ospf_packet.h (OSPF_SEND_PACKET_LOOP): Added for test packet.
2061
2062 * ospf_dump.c (ospf_lsa_type_msg): Add OSPF_GROUP_MEMBER_LSA and
2063 OSPF_AS_NSSA_LSA.
2064
2065 * ospfd.c (data_injection): Function to inject LSA. This is
2066 debugging command.
2067
20682001-01-11 Kunihiro Ishiguro <kunihiro@zebra.org>
2069
2070 * ospf_route.c (ospf_route_match_same): Remove function.
2071 (ospf_route_match_same_new): Renamed to ospf_route_match_same.
2072
2073 * ospf_zebra.c (ospf_interface_address_delete): Add check for
2074 oi->address. Suggested by Matthew Grant
2075 <grantma@anathoth.gen.nz>.
2076 (ospf_zebra_add): Remove function.
2077 (ospf_zebra_add_multipath): Rename to ospf_zebra_add.
2078
2079 * ospf_interface.c: Remove HAVE_IF_PSEUDO part.
2080
2081 * ospf_zebra.c: Likewise.
2082
20832001-01-10 Kunihiro Ishiguro <kunihiro@zebra.org>
2084
2085 * ospf_ase.c: Remove OLD_RIB part.
2086
2087 * ospf_route.c: Likewise.
2088
2089 * zebra-0.90 is released.
2090
2091 * ospf_packet.c (ospf_recv_packet): Use ip_len adjestment code to
2092 NetBSD.
2093
20942001-01-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2095
2096 * ospf_route.c (ospf_route_delete): Use
2097 ospf_zebra_delete_multipath.
2098
20992001-01-09 Matthew Grant <grantma@anathoth.gen.nz>
2100
2101 * ospf_interface.c (ospf_if_cleanup): Function name is renamed
2102 from ospf_if_free(). Rewrite whole procudure to support primary
2103 address deletion.
2104
2105 * ospf_zebra.c (ospf_interface_address_delete): Add primary
2106 address deletion process.
2107
21082001-01-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2109
2110 * ospf_packet.c (ospf_recv_packet): OpenBSD has same ip_len
2111 treatment like FreeBSD.
2112
21132001-01-09 endo@suri.co.jp (Masahiko Endo)
2114
2115 * ospf_packet.c (ospf_recv_packet): FreeBSD kernel network code
2116 strips IP header size from receiving IP Packet. So we adjust
2117 ip_len to whole IP packet size by adding IP header size.
2118
21192001-01-08 endo@suri.co.jp (Masahiko Endo)
2120
2121 * ospf_network.c (ospf_serv_sock): When socket() is failed return
2122 immediately.
2123 (ospf_serv_sock): Close socket when it is not used.
2124
2125 * ospf_packet.c (ospf_write): Set sin_len when HAVE_SIN_LEN is
2126 defined.
2127 (ospf_write): When bind is fined, close sock.
2128
21292001-01-07 Gleb Natapov <gleb@nbase.co.il>
2130
2131 * ospf_zebra.c (ospf_interface_state_up): Fixes coredump that
2132 appears when you try to configure bandwidth on the ppp interface
2133 that is not yet configured in ospfd.
2134
21352001-01-07 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2136
2137 * ospf_route.c (show_ip_ospf_route_external): "show ip ospf route"
2138 will print nexthops for AS-external routes.
2139
2140 * ospf_ase.c (ospf_ase_route_match_same): New function to compare
2141 ASE route under multipath environment.
2142 (ospf_ase_compare_tables): Likewise.
2143
21442001-01-01 Kunihiro Ishiguro <kunihiro@zebra.org>
2145
2146 * ospfd.h (OSPF_VTYSH_PATH): Change "/tmp/ospfd" to "/tmp/.ospfd".
2147
21482000-12-28 Kunihiro Ishiguro <kunihiro@zebra.org>
2149
2150 * ospf_route.c (ospf_route_install): Install multipath information
2151 to zebra daemon.
2152
2153 * ospf_zebra.c (ospf_zebra_add_multipath): Function for passing
2154 multipath information to zebra daemon.
2155
21562000-12-25 Dick Glasspool <dick@ipinfusion.com>
2157
2158 * ospf_packet.c (ospf_write): Call ospf_packet_delete when sendto
2159 fail.
2160 (DISCARD_LSA): Add argument N for logging point of DISCARD_LSA is
2161 called.
2162
2163 * ospf_lsa.c (ospf_external_lsa_refresh): NSSA install_flood will
2164 leave Type-7 LSA at Lock Count = 2.
2165
2166 * ospf_flood.c (ospf_flood_through): Flood_though_as updated for
2167 NSSA no P-bit off during Area flooding, but P-bit is turned off
2168 for mulitple NSSA AS flooding.
2169
2170 * ospf_ase.c (ospf_ase_calculate_timer): Added calculations for
2171 Type-7 LSDB.
2172
2173 * ospf_abr.c (ospf_abr_translate_nssa): Removed one unlock call.
2174 (ospf_abr_announce_nssa_defaults): Corrected Debug from EVENT to
2175 NSSA.
2176
21772000-12-25 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2178
2179 * ospf_zebra.c (ospf_zebra_read_ipv4): Checking the age of the
2180 found LSA and if the LSA is MAXAGE we should call refresh instead
2181 of originate.
2182
21832000-12-18 Dick Glasspool <dick@ipinfusion.com>
2184
2185 * ospf_abr.c: Removed redundant "...flood" in
2186 announce_network_to_area(). Repaired nssa Unlock by using
2187 discard.
2188
2189 * ospf_packet.c: Removed old NSSA translate during mk_ls_update.
2190
2191 * ospfd.c: Free up all data bases including NSSA.
2192
2193 * ospf_lsa.c: Now allow removal of XLATE LSA's Check in
2194 discard_callback. Added routine to get ip addr from within the
2195 ifp.
2196
2197 * ospf_flood.c: Now set Forward Address for outgoing Type-7.
2198
2199 * ospf_lsa.h: Added prototype for the below. struct in_addr
2200 ospf_get_ip_from_ifp (struct interface *ifp).
2201
22022000-12-14 Gleb Natapov <gleb@nbase.co.il>
2203
2204 * ospf_packet.c (ospf_recv_packet): New OSPF pakcet read method.
2205 Now maximum packet length may be 65535 bytes (maximum IP packet
2206 length).
2207
2208 * ospf_interface.c (ospf_if_stream_set): Don't make input buffer.
2209
2210 * ospfd.c (config_write_network_area): Remove unnecessary area
2211 lookup code.
2212
22132000-12-13 Kunihiro Ishiguro <kunihiro@zebra.org>
2214
2215 * ospf_packet.c (ospf_read): Accept packet bigger than MTU value.
2216
22172000-12-13 Gleb Natapov <gleb@nbase.co.il>
2218
2219 * ospfd.c (config_write_network_area): Fix bug in
2220 config_write_network_area function.
2221
22222000-12-12 Gleb Natapov <gleb@nbase.co.il>
2223
2224 * ospf_abr.c (ospf_abr_announce_network_to_area): Make Summary
2225 LSA's origination and refreshment as same as other type of LSA.
2226
2227 * ospf_lsa.c (ospf_summary_lsa_refresh): Return struct ospf_lsa *.
2228
2229 * ospf_lsa.c (ospf_summary_asbr_lsa_refresh): Likewise.
2230
22312000-12-08 Dick Glasspool <dick@ipinfusion.com>
2232
2233 The bulk of NSSA changes are contained herein; This version will
2234 require manual setting of "always" for NSSA Translator, and will
2235 not perform aggregation yet.
2236
2237 * ospf_dump.c: "debug ospf nssa" is added.
2238
2239 * ospf_dump.h: Likewise.
2240
2241 * ospf_packet.c (ospf_hello): Display router ID on Bad NSSA Hello.
2242
2243 * ospfd.c: Discard_LSA to stay away from LOCAL_XLT Process NSSA
2244 'never, candidate, always'. Change "suppress" to "not-advertise".
2245
2246 * ospfd.h: Add TranslatorRole to struct ospf_area. Add anyNSSA to
2247 struct ospf.
2248
2249 * ospf_ase.c (ospf_ase_calculate_route): External to stay away
2250 from LOCAL_XLT
2251
2252 * ospf_nsm.c (ospf_db_summary_add): External to stay away from
2253 LOCAL_XLT
2254
2255 * ospf_abr.c: Major logic added for abr_nssa_task(). If ABR, and
2256 NSSA translator, then do it. Approve the global list, and flush
2257 any unapproved.
2258
2259 * ospf_lsa.h: New LSA flag OSPF_LSA_LOCAL_XLT to indicate that the
2260 Type-5 resulted from a Local Type-7 translation; not used for
2261 flooding, but used for flushing.
2262
2263 * ospf_flood.c: New NSSA flooding.
2264
22652000-12-08 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2266
2267 * ospfd.c (ospf_find_vl_data): New function for looking up virtual
2268 link data.
2269 (ospf_vl_set_security): Virtual link configuration with
2270 authentication.
2271 (ospf_vl_set_timers): Set timers for virtual link.
2272
2273 * New commands are added.
2274 "area A.B.C.D virtual-link A.B.C.D"
2275 "area A.B.C.D virtual-link A.B.C.D hello-interval <1-65535> retransmit-interval <3-65535> transmit-delay <1-65535> dead-interval <1-65535>"
2276 "area A.B.C.D virtual-link A.B.C.D hello-interval <1-65535> retransmit-interval <3-65535> transmit-delay <1-65535> dead-interval <1-65535> authentication-key AUTH_KEY"
2277 "area A.B.C.D virtual-link A.B.C.D authentication-key AUTH_KEY"
2278 "area A.B.C.D virtual-link A.B.C.D hello-interval <1-65535> retransmit-interval <3-65535> transmit-delay <1-65535> dead-interval <1-65535> message-digest-key <1-255> md5 KEY"
2279 "area A.B.C.D virtual-link A.B.C.D message-digest-key <1-255> md5 KEY"
2280
2281 * ospf_packet.c (ospf_check_md5_digest): Add neighbor's
2282 cryptographic sequence number treatment.
2283 (ospf_check_auth): OSPF input buffer is added to argument.
2284 (ospf_read): Save neighbor's cryptographic sequence number.
2285
2286 * ospf_nsm.c (nsm_change_status): Clear cryptographic sequence
2287 number when neighbor status is changed to NSM down.
2288
2289 * ospf_neighbor.c (ospf_nbr_new): Set zero to crypt_seqnum.
2290
2291 * ospf_neighbor.h (struct ospf_neighbor): Add cryptographic
2292 sequence number to neighbor structure.
2293
22942000-11-29 Kunihiro Ishiguro <kunihiro@zebra.org>
2295
2296 * ospf_snmp.c (ospfIfLookup): OSPF MIB updates.
2297 (ospfExtLsdbEntry): Add OspfExtLsdbTable treatment.
2298
22992000-11-28 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2300
2301 * ospfd.c (ospf_interface_down): Clear a ls_upd_queue queue of the
2302 interface.
2303 (ospf_ls_upd_queue_empty): New function to empty ls update queue
2304 of the OSPF interface.
2305 (no_router_ospf): 'no router ospf' unregister redistribution
2306 requests from zebra.
2307
23082000-11-28 Kunihiro Ishiguro <kunihiro@zebra.org>
2309
2310 * ospf_ism.c (ism_change_status): Increment status change number.
2311
2312 * ospf_interface.h (struct ospf_interface): Add new member for
2313 status change statistics.
2314
2315 * Makefile.am: Update dependencies.
2316
2317 * ospf_zebra.c (ospf_interface_add): OSPF SNMP interface update.
2318 (ospf_interface_delete): OSPF SNMP interface delete.
2319
2320 * ospf_snmp.h: New file is added.
2321
23222000-11-23 Dick Glasspool <dick@ipinfusion.com>
2323
2324 * ospfd.h: Add new ospf_area structure member for
2325 NSSATranslatorRole and NSSATranslator state.
2326
2327 * ospfd.c: Provided for eventual commands to specify NSSA
2328 elections for "translator- ALWAYS/NEVER/CANDIDATE". Provided for
2329 decimal integer version of area-suppress.
2330
2331 * ospf_flood.c: Flood Type-7's only into NSSA (not AS).
2332
2333 * ospf_lsa.c: Undo some previous changes for NSSA. If NSSA
2334 translator, advertise Nt bit.
2335
2336 * ospf_route.c: 1st version of "sh ip os border-routers".
2337
23382000-11-23 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2339
2340 * ospfd.c (area_vlink): Virtual link can not configured in stub
2341 area.
2342
23432000-11-23 Gleb Natapov <gleb@nbase.co.il>
2344
2345 * ospf_packet.c (ospf_db_desc): In states Loading and Full the
2346 slave must resend its last Database Description packet in response
2347 to duplicate Database Description packets received from the
2348 master. For this reason the slave must wait RouterDeadInterval
2349 seconds before freeing the last Database Description packet.
2350 Reception of a Database Description packet from the master after
2351 this interval will generate a SeqNumberMismatch neighbor
2352 event. RFC2328 Section 10.8
2353 (ospf_make_db_desc): DD Master flag treatment.
2354
2355 * ospf_nsm.c (nsm_twoway_received): Move DD related procedure to
2356 nsm_change_status().
2357 (nsm_bad_ls_req): Likewise.
2358 (nsm_adj_ok): Likewise.
2359 (nsm_seq_number_mismatch): Likewise.
2360 (nsm_oneway_received): Likewise.
2361
2362 * ospf_neighbor.h (struct ospf_neighbor): New structure member
2363 last_send_ts for timestemp when last Database Description packet
2364 was sent.
2365
2366 * ospf_nsm.c (ospf_db_desc_timer): Make it sure nbr->last_send is
2367 there. Call ospf_db_desc_resend() in any case.
2368
23692000-11-16 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2370
2371 * ospf_lsa.c (lsa_link_broadcast_set): When there is no DR on
2372 network (suppose you have only one router with interface priority
2373 0). It's router LSA does not contain the link information about
2374 this network.
2375
2376 * ospf_nsm.c (nsm_timer_set): When you change a priority of
2377 interface from/to 0 ISM_NeighborChange event should be scheduled
2378 in order to elect new DR/BDR on the network.
2379
2380 * ospf_interface.c (ip_ospf_priority): Likewise.
2381
2382 * ospf_flood.c (ospf_ls_retransmit_add): When we add some LSA into
2383 retransmit list we need to check whether the present old LSA in
2384 retransmit list is not more recent than the new
2385 one.
2386
23872000-11-09 Dick Glasspool <dick@ipinfusion.com>
2388
2389 * ospf_packet.c: Allows for NSSA Type-7 LSA's throughout the NSSA
2390 area. Any that exit the NSSA area are translated to type-5 LSA's.
2391 The instantiated image is restored after translation.
2392 (ospf_ls_upd_send_list): Renamed to ospf_ls_upd_queu_send().
2393 (ospf_ls_upd_send): Old function which enclosed by #ifdef 0 is
2394 removed.
2395 (ospf_ls_ack_send): Likewise.
2396
2397 * ospf_flood.c: NSSA-LSA's without P-bit will be restricted to
2398 local area. Otherwise they are allowed out the area to be
2399 translated by ospf_packet.c.
2400
2401 * ospf_lsa.c: Undo some previous changes for NSSA.
2402
2403 * ospf_lsdb.h: New access for type 7.
2404
24052000-11-07 Kunihiro Ishiguro <kunihiro@zebra.org>
2406
2407 * ospf_route.c (ospf_path_exist): New function to check nexthop
2408 and interface are in current OSPF path or not.
2409 (ospf_route_copy_nexthops_from_vertex): Add nexthop to OSPF path
2410 when it is not there. Reported by Michael Rozhavsky
2411 <mrozhavsky@opticalaccess.com>
2412
24132000-11-06 Kunihiro Ishiguro <kunihiro@zebra.org>
2414
2415 * ospf_dump.c (config_write_debug): Add seventh string "detail" is
2416 added for flag is OSPF_DEBUG_SEND | OSPF_DEBUG_RECV |
2417 OSPF_DEBUG_DETAIL.
2418
24192000-11-06 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2420
2421 * ospf_lsa.c (router_lsa_flags): ASBR can't exit in stub area.
2422
24232000-11-06 Kunihiro Ishiguro <kunihiro@zebra.org>
2424
2425 * ospf_lsa.c (ospf_router_lsa_originate): Reduce unconditional
2426 logging.
2427
24282000-11-06 Dick Glasspool <dick@ipinfusion.com>
2429
2430 * ospfd.h: Add ait_ntoa function prototype.
2431
2432 * ospfd.c (ait_ntoa): New function for displaying area ID and
2433 Stub/NSSA status.
2434 (show_ip_ospf_interface_sub): Use ait_ntoa.
2435 (show_ip_ospf_nbr_static_detail_sub): Likewise.
2436 (show_ip_ospf_neighbor_detail_sub): Likewise.
2437
2438 * ospf_route.c (ospf_intra_route_add): Set external routing type
2439 to ospf route.
2440 (ospf_intra_add_router): Likewise.
2441 (ospf_intra_add_transit): Likewise.
2442 (ospf_intra_add_stub): Likewise.
2443 (ospf_add_discard_route): Likewise.
2444 (show_ip_ospf_route_network): Use ait_ntoa.
2445 (show_ip_ospf_route_network): Likewise.
2446 (show_ip_ospf_route_router): Likewise.
2447
2448 * ospf_lsa.c (show_lsa_detail): Use ait_ntoa.
2449 (show_lsa_detail_adv_router): Likewise.
2450 (show_ip_ospf_database_summary): Likewise.
2451
2452 * ospf_route.h (struct route_standard): Add new member
2453 external_routing.
2454
2455 * ospf_ia.c (process_summary_lsa): Set external routing tyep to ospf
2456 route.
2457 (ospf_update_network_route): Likewise.
2458 (ospf_update_router_route): Likewise.
2459
24602000-11-04 Kunihiro Ishiguro <kunihiro@zebra.org>
2461
2462 * ospf_flood.c (ospf_process_self_originated_lsa): Enclose
2463 OSPF_AS_NSSA_LSA treatment with #ifdef HAVE_NSSA.
2464
24652000-11-03 Kunihiro Ishiguro <kunihiro@zebra.org>
2466
2467 * Unconditional logging is enclosed with if (IS_DEBUG_OSPF_EVENT).
2468 Please specify "debug ospf event" for enable logging.
2469
2470 * ospf_ism.c: Do not extern debug flag varible. It is done by
2471 ospf_debug.h
2472 * ospf_asbr.c: Likewise.
2473 * ospf_lsa.c: Likewise.
2474 * ospf_nsm.c: Likewise.
2475 * ospf_zebra.c: Likewise.
2476
2477 * ospf_dump.c (debug_ospf_event): New command "debug ospf event"
2478 is added.
2479
2480 * ospfd.c (router_ospf): Change logging from vty_out() to
2481 zlog_info().
2482 (ospf_area_stub_cmd): Likewise.
2483
2484 * ospf_dump.h: Extern term_debug flags.
2485 (OSPF_DEBUG_EVENT): Add new flag.
2486 (IS_DEBUG_OSPF_EVENT): Add new macro.
2487
24882000-11-03 Dick Glasspool <dick@ipinfusion.com>
2489
2490 * ospf_flood.c (ospf_process_self_originated_lsa):
2491 OSPF_AS_NSSA_LSA is treated as same as OSPF_AS_EXTERNAL_LSA.
2492 (ospf_flood): Type-5's have no change. Type-7's can be received,
2493 and will Flood the AS as Type-5's They will also flood the local
2494 NSSA Area as Type-7's. The LSDB will be updated as Type-5's, and
2495 during re-fresh will be converted back to Type-7's (if within an
2496 NSSA).
2497 (ospf_flood_through): Incoming Type-7's were allowed here if our
2498 neighbor was an NSSA. So Flood our area with the Type-7 and also
2499 if we are an ABR, flood thru AS as Type-5.
2500
2501 * ospf_lsa.c (ospf_external_lsa_refresh): Flood NSSA both NSSA
2502 area and other area.
2503
2504 * ospf_packet.c (ospf_db_desc_proc): When AS External LSA is
2505 exists in DD packet, make it sure that this area is not stub.
2506 (ospf_ls_upd_list_lsa): When LSA type is NSSA then set lsa's area
2507 to NULL.
2508 (ospf_ls_upd): If the LSA is AS External LSA and the area is stub
2509 then discard the lsa. If the LSA is NSSA LSA and the area is not
2510 NSSA then discard the lsa.
2511
25122000-11-03 Kunihiro Ishiguro <kunihiro@zebra.org>
2513
2514 * ospfd.c (ospf_interface_run): Fix bug of Hello packet's option
2515 is not properly set when interface comes up.
2516
25172000-11-02 Kunihiro Ishiguro <kunihiro@zebra.org>
2518
2519 * ospfd.h (OSPF_OPTION_O): Add new hello header option.
2520
25212000-11-01 Dick Glasspool <dick@ipinfusion.com>
2522
2523 * ospf_lsa.h: Define OSPF_MAX_LSA to 8 when HAVE_NSSA is enabled.
2524 (OSPF_GROUP_MEMBER_LSA): Define OSPF_GROUP_MEMBER_LSA.
2525
2526 * ospf_lsa.c (show_database_desc): Add "Group Membership LSA"
2527 string.
2528
25292000-10-31 Dick Glasspool <dick@ipinfusion.com>
2530
2531 * ospf_lsa.h (OSPF_AS_NSSA_LSA): Define OSPF_AS_NSSA_LSA.
2532
2533 * ospf_lsa.c (show_ip_ospf_database): NSSA database display
2534 function is added. ALIASES which have "show ip ospf database
2535 nssa-external" is added.
2536 (show_ip_ospf_border_routers): New command "show ip ospf
2537 border-routers" is added.
2538
25392000-10-30 Dick Glasspool <dick@ipinfusion.com>
2540
2541 * ospfd.c (router_ospf): NSSA Enabled message is added for
2542 testing.
2543 (ospf_area_type_set): Are type set for NSSA area.
2544 (ospf_area_stub_cmd): Special translation of no_summary into NSSA
2545 and summary information. If NSSA is enabled pass the information
2546 to ospf_area_type_set().
2547 (area_nssa): New commands are added:
2548 "area A.B.C.D nssa"
2549 "area <0-4294967295> nssa"
2550 "area A.B.C.D nssa no-summary"
2551 "area <0-4294967295> nssa no-summary"
2552 (ospf_no_area_stub_cmd): Special translation of no_summary into
2553 NSSA and summary information. If external_routing is
2554 OSPF_AREA_NSSA unset area with ospf_area_type_set (area,
2555 OSPF_AREA_DEFAULT).
2556 (show_ip_ospf_area): Display NSSA status.
2557 (config_write_ospf_area): Show NSSA configuration.
2558
2559 * ospf_packet.c (ospf_hello): For NSSA support, ensure that NP is
2560 on and E is off.
2561
25622000-10-26 Gleb Natapov <gleb@nbase.co.il>
2563
2564 * ospf_lsa.c (ospf_network_lsa_body_set): The network-LSA lists
2565 those routers that are fully adjacent to the Designated Router;
2566 each fully adjacent router is identified by its OSPF Router ID.
2567 The Designated Router includes itself in this list. RFC2328,
2568 Section 12.4.2.
2569
25702000-10-23 Jochen Friedrich <jochen@scram.de>
2571
2572 * ospf_snmp.c: ospf_oid and ospfd_oid are used in smux_open after
2573 it is registered. So those variables must be static.
2574
25752000-10-18 K N Sridhar <sridhar@euler.ece.iisc.ernet.in>
2576
2577 * ospfd.c: Add area_default_cost_decimal_cmd and
2578 no_area_default_cost_decimal_cmd alias.
2579
25802000-10-05 Gleb Natapov <gleb@nbase.co.il>
2581
2582 * ospfd.c (ospf_network_new): Fix setting area format.
2583 (no_router_ospf): Check area existance when calling
2584 ospf_interface_down().
2585
2586 * ospf_flood.c (ospf_external_info_check): Fix bug of refreshing
2587 default route.
2588
25892000-10-02 Kunihiro Ishiguro <kunihiro@zebra.org>
2590
2591 * zebra-0.89 is released.
2592
25932000-09-29 Kunihiro Ishiguro <kunihiro@zebra.org>
2594
2595 * ospf_snmp.c (ospfHostEntry): OSPF Host MIB is implemented.
2596
2597 * ospfd.c (ospf_nbr_static_cmp): OSPF neighbor is sorted by it's
2598 address.
2599
26002000-09-28 Michael Rozhavsky <mike@nbase.co.il>
2601
2602 * ospf_interface.c (ospf_if_free): Fix deleting self neighbor twice.
2603
26042000-09-27 Kunihiro Ishiguro <kunihiro@zebra.org>
2605
2606 * ospf_packet.c (ospf_read): Solaris on x86 has ip_len with host
2607 byte order.
2608
26092000-09-25 Toshiaki Takada <takada@zebra.org>
2610
2611 * ospfd.c (ospf_compatible_rfc1583), (no_ospf_compatible_rfc1583):
2612 Add CISCO compatible command.
2613
26142000-09-25 Kunihiro Ishiguro <kunihiro@zebra.org>
2615
2616 * ospf_abr.c (ospf_area_range_lookup): New function is added for
2617 area range lookup in OSPF-MIB.
2618 (ospf_area_range_lookup_next): Likewise.
2619
26202000-09-22 Kunihiro Ishiguro <kunihiro@zebra.org>
2621
2622 * ospfd.c (no_router_ospf): Delete virtual link before deleting
2623 area structure.
2624
2625 * ospf_lsa.c (ospf_external_lsa_refresh_type): Check
2626 EXTERNAL_INFO(type).
2627
2628 * ospfd.c (no_router_ospf): Call ospf_vl_delete() instead of
2629 ospf_vl_data_free().
2630
2631 * ospf_interface.c (ospf_vl_shutdown): Execute ISM_InterfaceDown
2632 when ospf_vl_shutdown is called.
2633 (ospf_vl_delete): Call ospf_vl_shutdown() to delete virtual link
2634 interface's thread.
2635
26362000-09-21 Gleb Natapov <gleb@nbase.co.il>
2637
2638 * ospf_lsa.c: New implementation of OSPF refresh.
2639
26402000-09-20 Kunihiro Ishiguro <kunihiro@zebra.org>
2641
2642 * ospf_snmp.c (ospfLsdbLookup): Add LSDB MIB implementation.
2643
26442000-09-18 Kunihiro Ishiguro <kunihiro@zebra.org>
2645
2646 * ospf_snmp.c (ospfStubAreaEntry): Add OSPF stub area MIB.
2647
26482000-09-18 Gleb Natapov <gleb@nbase.co.il>
2649
2650 * ospf_route.h (route_standard): Change member from `struct area'
2651 to area_id.
2652
2653 * ospf_abr.c (ospf_abr_announce_network), (ospf_abr_should_announce),
2654 (ospf_abr_process_network_rt), (ospf_abr_announce_rtr),
2655 (ospf_abr_process_router_rt):
2656 * ospf_ase.c (ospf_find_asbr_route),
2657 (ospf_find_asbr_router_through_area),
2658 * ospf_ia.c (ospf_find_abr_route), (ospf_ia_router_route),
2659 (process_summary_lsa), (ospf_update_network_route),
2660 (ospf_update_router_route):
2661 * ospf_route.c (ospf_intra_route_add), (ospf_intra_add_router),
2662 (ospf_intra_add_transit), (ospf_intra_add_stub),
2663 (ospf_route_table_dump), (show_ip_ospf_route_network),
2664 (show_ip_ospf_route_router), (ospf_asbr_route_cmp),
2665 (ospf_prune_unreachable_routers):
2666 * ospf_spf.c (ospf_rtrs_print):
2667 * ospfd.c (ospf_rtrs_free): Fix the struct change above.
2668
26692000-09-14 Kunihiro Ishiguro <kunihiro@zebra.org>
2670
2671 * ospf_network.c (ospf_serv_sock_init): Enclose SO_BINDTODEVICE
2672 with ifdef.
2673
26742000-09-13 Gleb Natapov <gleb@nbase.co.il>
2675
2676 * ospf_ism.c (ospf_elect_dr), (ospf_elect_bdr): Fix DR election.
2677
2678 * ospf_network.c (ospf_serv_sock_init): Add socket option
2679 SO_BINDTODEVICE on read socket.
2680
2681 * ospf_packet.c (ospf_hello): Ignore Hello packet if E-bit does
2682 not match.
2683
2684 * ospfd.c (ospf_area_check_free), (ospf_area_get),
2685 (ospf_area_add_if): New function added.
2686
26872000-09-13 Kunihiro Ishiguro <kunihiro@zebra.org>
2688
2689 * ospf_route.c (ospf_intra_add_router): Update ABR and ASBR router
2690 count.
2691
2692 * ospf_spf.c (ospf_spf_init): Rest ABR and ASBR router count
2693 starting SPF calculation.
2694
2695 * ospfd.h (struct ospf_area): Add ABR and ASBR router count.
2696
26972000-09-12 Kunihiro Ishiguro <kunihiro@zebra.org>
2698
2699 * ospfd.c (ospf_area_id_cmp): New area structure is sorted by area
2700 ID.
2701
2702 * ospf_lsa.c (ospf_router_lsa_originate): For OSPF MIB update
2703 lsa_originate_count.
2704 (ospf_network_lsa_originate): Likewise.
2705 (ospf_summary_lsa_originate): Likewise.
2706 (ospf_summary_asbr_lsa_originate): Likewise.
2707 (ospf_external_lsa_originate): Likewise.
2708
27092000-09-11 Kunihiro Ishiguro <kunihiro@zebra.org>
2710
2711 * ospf_snmp.c (ospf_variables): ospfRouterID's type RouterID
2712 syntax is IpAddress.
2713 (ospf_admin_stat): New function for OSPF administrative status
2714 check.
2715
27162000-09-10 Jochen Friedrich <jochen@scram.de>
2717
2718 * ospf_snmp.c: Implement OSPF MIB skeleton.
2719
27202000-09-08 Kunihiro Ishiguro <kunihiro@zebra.org>
2721
2722 * ospf_snmp.c: New file is added.
2723
27242000-09-07 David Lipovkov <davidl@nbase.co.il>
2725
2726 * ospf_zebra.c (ospf_interface_delete): Add pseudo interface
2727 treatment.
2728
2729 * ospf_interface.c (interface_config_write): Likewise.
2730
27312000-08-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2732
2733 * zebra-0.88 is released.
2734
27352000-08-17 Michael Rozhavsky <mike@nbase.co.il>
2736
2737 * ospfd.c (ospf_area_free): Remove virtual link configuration only
2738 when Area is removed.
2739
27402000-08-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2741
2742 * ospfd.c (network_area): Revert check for EXTERNAL_INFO
2743 (ZEBRA_ROUTE_CONNECT).
2744 (no_network_area): Likewise.
2745
27462000-08-16 Kunihiro Ishiguro <kunihiro@zebra.org>
2747
2748 * ospfd.h (struct ospf): Add distance_table and
2749 distance_{all,intra,inter,external}.
2750
2751 * ospf_zebra.c: Add OSPF distance related functions.
2752
27532000-08-15 Gleb Natapov <gleb@nbase.co.il>
2754
2755 * ospf_asbr.c (ospf_external_info_find_lsa): New function added.
2756
2757 * ospf_lsa.c (ospf_default_external_info),
2758 (ospf_default_originate_timer), (ospf_external_lsa_refresh_default):
2759 New function added.
2760
2761 * ospf_zebra.c
2762 (ospf_default_information_originate_metric_type_routemap),
2763 (ospf_default_information_originate_always_metric_type_routemap):
2764 Change name and add route-map function.
2765 (ospf_default_information_originate_metric_routemap),
2766 (ospf_default_information_originate_routemap),
2767 (ospf_default_information_originate_type_metric_routemap):
2768 New DEFUN added.
2769
27702000-08-14 Kunihiro Ishiguro <kunihiro@zebra.org>
2771
2772 * ospf_zebra.c (zebra_interface_if_set_value): Change ifindex
2773 restore size from two octet to four.
2774
27752000-08-14 Michael Rozhavsky <mike@nbase.co.il>
2776
2777 * ospf_ase.c (ospf_ase_incremental_update): Implement incremental
2778 AS-external-LSA in 16.6 of RFC2328.
2779
27802000-08-14 Matthew Grant <grantma@anathoth.gen.nz>
2781
2782 * ospf_interface.c (ospf_if_get_output_cost): Change cost
2783 calculation algorithm.
2784
2785 * ospf_packet (ospf_ls_upd): Fix problem of LSA retransmitting.
2786
27872000-08-11 Michael Rozhavsky <mike@nbase.co.il>
2788
2789 * ospf_lsa.c (ospf_maxage_lsa_remover): Fix maxage remover for
2790 AS-external-LSAs.
2791
27922000-08-10 Toshiaki Takada <takada@zebra.org>
2793
2794 * ospfd.c (auto_cost_reference_bandwidth): New DEFUN added.
2795 `auto-cost reference-bandwidth' OSPF router command added.
2796
27972000-08-08 Gleb Natapov <gleb@nbase.co.il>
2798
2799 * ospf_routemap.c (ospf_route_map_update): New function added.
2800 Add route-map event hook.
2801
28022000-08-08 Toshiaki Takada <takada@zebra.org>
2803
2804 * ospf_zebra.c (ospf_distribute_check_connected): If redistribute
2805 prefix is connected route on OSPF enabled interface, suppress to
2806 announce it.
2807
28082000-08-08 Matthew Grant <grantma@anathoth.gen.nz>
2809
2810 * ospf_interface.c (ospf_if_get_output_cost):
2811 New function added. Handle bandwidth parameter for cost
2812 calculation.
2813
28142000-08-08 Michael Rozhavsky <mike@nbase.co.il>
2815
2816 * ospf_interface.c (interface_config_write): Show interface
2817 configuration regardless interface is down.
2818
2819 * ospf_ase.c (ospf_ase_caocluate_route): Whole rewritten external
2820 route calculate function.
2821
28222000-08-08 Gleb Natapov <gleb@nbase.co.il>
2823
2824 * ospf_routemap.c: New file added.
2825
2826 * ospf_asbr.c (ospf_reset_route_map_set_values),
2827 (ospf_route_map_set_compare): New function added.
2828
2829 * ospf_lsa.c (ospf_external_lsa_body_set): Set routemap metric
2830 with AS-external-LSA.
2831
28322000-08-05 Kunihiro Ishiguro <kunihiro@zebra.org>
2833
2834 * ospf_ase.c (ospf_ase_calculate_route_add): Pass new->cost to
2835 ospf_zebra_add as metric.
2836 (ospf_ase_calculate_route_add): Likewise.
2837
2838 * ospf_route.c (ospf_route_install): Pass or->cost to
2839 ospf_zebra_add as metric.
2840
2841 * ospf_zebra.c (ospf_zebra_add): Add metric arguemnt.
2842 (ospf_zebra_delete): Likewise.
2843
28442000-08-03 Matthew Grant <grantma@anathoth.gen.nz>
2845
2846 * ospf_flood.c (ospf_flood_delayed_lsa_ack): New function added.
2847 Dispatch delayed-ACK with flooding AS-external-LSA across virtual
2848 link.
2849
28502000-07-31 Matthew Grant <grantma@anathoth.gen.nz>
2851
2852 * ospfd.c (show_ip_ospf_area): Fix lack of VTY_NEWLINE when
2853 `show ip ospf'.
2854
2855 * ospf_interface.c (ospf_if_free): Fix bug of crash with
2856 Point-to-Point interface.
2857
28582000-07-27 Michael Rozhavsky <mike@nbase.co.il>
2859
2860 * ospf_flood.c (ospf_process_self_originated_lsa):
2861 Make sure to clear LSA->param (redistributed external information)
2862 before refreshment.
2863
28642000-07-27 Gleb Natapov <gleb@nbase.co.il>
2865
2866 * ospfd.c (refresh_group_limit), (refresh_per_slice),
2867 (refresh_age_diff): New defun added. Refresher related parameter
2868 can be configurable.
2869
28702000-07-27 Akihiro Mizutani <mizutani@dml.com>
2871
2872 * ospf_interface.c (interface_config_write): Print `description'
2873 config directive to work.
2874
28752000-07-24 Akihiro Mizutani <mizutani@dml.com>
2876
2877 * ospf_interface.c (ospf_if_init): Use install_default for
2878 INTERFACE_NODE.
2879
28802000-07-24 Gleb Natapov <gleb@nbase.co.il>
2881
2882 * ospf_packet.c (ospf_ls_upd_send_list), (ospf_ls_upd_send_event),
2883 (ospf_ls_ack_send_list), (ospf_ls_ack_send_event): New function added.
2884 This make sending always as many LS update/Ack combined in one ospf
2885 packet.
2886
28872000-07-24 Gleb Natapov <gleb@nbase.co.il>
2888
2889 * ospf_packet.c (ospf_ls_upd_list_lsa): Set NULL to lsa->area if
2890 LSA is AS-external-LSA.
2891
2892 * ospf_nsm.c (nsm_reset_nbr): Do not cancel Inactivity timer.
2893
28942000-07-21 Toshiaki Takada <takada@zebra.org>
2895
2896 * ospf_zebra.c (ospf_default_originate_timer): Set timer for
2897 `default-information originate'. Fix some default originate
2898 related functions.
2899
29002000-07-12 Toshiaki Takada <takada@zebra.org>
2901
2902 * ospf_lsa.c (stream_put_ospf_metric): New function added.
2903
29042000-07-12 Toshiaki Takada <takada@zebra.org>
2905
2906 * ospf_lsa.c (show_ip_ospf_database_router),
2907 (show_ip_ospf_database_network), (show_ip_ospf_database_summary),
2908 (show_ip_ospf_database_summary_asbr), (show_ip_ospf_database_externel),
2909 (show_router_lsa), (show_any_lsa), (show_router_lsa_self),
2910 (show_any_lsa_self): Functions removed.
2911
2912 (show_lsa_prefix_set), (show_lsa_detail_proc), (show_lsa_detail),
2913 (show_lsa_detail_adv_router_proc), (show_lsa_detail_adv_router):
2914 New functions added. Replace above functions.
2915
2916 (show_ip_ospf_database_all), (show_ip_ospf_database_self_originated):
2917 Functions removed.
2918 (show_ip_ospf_database_summary): New functions added. Replace
2919 above functions.
2920
2921 (show_ip_ospf_database_cmd): DEFUN rearranged.
2922 (show_ip_ospf_database_type_id_cmd),
2923 (show_ip_ospf_database_type_id_adv_router_cmd),
2924 (show_ip_ospf_database_type_is_self_cmd): New ALIASes added.
2925 (show_ip_ospf_database_type_adv_rotuer_cmd): New DEFUN added.
2926 (show_ip_ospf_database_type_self_cmd): New ALIAS added.
2927
29282000-07-11 Toshiaki Takada <takada@zebra.org>
2929
2930 * ospf_asbr.c (ospf_external_info_new),
2931 (ospf_external_info_free): New functions added.
2932
2933 * ospf_lsa.h (ospf_lsa): Add new member `void *param' to set
2934 origination parameter for external-LSA.
2935 Remove member `redistribute'.
2936
2937 * ospf_zebra.c (ospf_redistirbute_set): When `redistribute'
2938 command executed, metric and metric-type values are overridden.
2939 If one of those is changed refresh AS-external-LSAs for appropriate
2940 type.
2941
29422000-07-11 Michael Rozhavsky <mike@nbase.co.il>
2943
2944 * ospf_lsa.c (ospf_summary_lsa_refresh),
2945 (ospf_summary_asbr_lsa_refresh): Make sure to refresh summary-LSAs.
2946
2947 * ospf_abr.c (set_metric): New function added.
2948
29492000-07-07 Toshiaki Takada <takada@zebra.org>
2950
2951 * ospf_zebra.c (ospf_default_information_originate_metric_type),
2952 (ospf_default_information_originate_type_metric): New defun added.
2953 Metic and Metric type can be set to default route.
2954 (ospf_default_information_originate_always_metric_type):
2955 (ospf_default_information_originate_always_type_metric):
2956 New defun added. Metric and Metric type can be set to default
2957 always route.
2958
2959 * ospf_zebra.c (ospf_default_metric), (no_ospf_default_metric):
2960 New defun added.
2961
29622000-07-06 Gleb Natapov <gleb@nbase.co.il>
2963
2964 * ospf_flood.c (ospf_flood_through_area): Fix bug of considering
2965 on the same interface the LSA was received from.
2966
29672000-07-06 Michael Rozhavsky <mike@nbase.co.il>
2968
2969 * ospfd.c (ospf_config_write): Fix bug of printing `area stub'
2970 command with `write mem'.
2971
2972 * ospfd.c (no_router_ospf): Remove installed routes from zebra.
2973
2974 * ospf_zebra.c (ospf_interface_delete): Fix function to handle
2975 zebra interface delete event.
2976
29772000-07-06 Toshiaki Takada <takada@zebra.org>
2978
2979 * ospf_zebra.c (ospf_default_information_originate),
2980 (ospf_default_information_originate_always): New DEFUN added.
2981
29822000-07-05 Michael Rozhavsky <mike@nbase.co.il>
2983
2984 * ospf_route.c (ospf_terminate): Make sure to remove external route
2985 when SIGINT received.
2986
29872000-07-03 Gleb Natapov <gleb@nbase.co.il>
2988
2989 * ospf_flood.c, ospf_ism.c, ospf_lsa,c, ospfd.c: Make sure to free
2990 many structure with `no router ospf'.
2991
29922000-06-30 Gleb Natapov <gleb@nbase.co.il>
2993
2994 * ospf_neighbor.c (ospf_nbr_new),
2995 ospf_nsm.c (nsm_timer_set): Start LS update timer only
2996 when neighbor enters Exchange state.
2997
29982000-06-29 Gleb Natapov <gleb@nbase.co.il>
2999
3000 * ospf_nsm.c (nsm_timer_set), (nsm_exchange_done),
3001 ospf_packet.c (ospf_db_desc_proc):
3002 Do not cancel DD retransmit timer when Master.
3003
30042000-06-29 Gleb Natapov <gleb@nbase.co.il>
3005
3006 * ospf_abr.c (ospf_abr_announce_network_to_area),
3007 (ospf_abr_announce_rtr_to_area)
3008 ospf_ase.c (ospf_ase_rtrs_register_lsa),
3009 ospf_flood.c (ospf_process_self_originated_lsa),
3010 (ospf_flood_through_area), (ospf_ls_request_delete),
3011 ospf_interface.c (ospf_if_free),
3012 ospf_ism.c (ism_change_status),
3013 ospf_lsa.c (ospf_router_lsa_update_timer),
3014 (ospf_router_lsa_install), (ospf_network_lsa_install),
3015 (ospf_lsa_maxage_delete), (ospf_lsa_action),
3016 (ospf_schedule_lsa_flood_area),
3017 ospf_nsm.c (nsm_change_status),
3018 ospf_packet.c (ospf_make_ls_req_func), (ospf_make_ls_ack):
3019 Use ospf_lsa_{lock,unlock} for all looking-up of LSA.
3020
3021 * ospf_flood.c (ospf_ls_request_free): Function deleted.
3022
3023 * ospf_lsa.c (ospf_discard_from_db): New function added.
3024
30252000-06-26 Toshiaki Takada <takada@zebra.org>
3026
3027 * ospfd.h (ospf): struct member `external_lsa' name changed to
3028 `lsdb'.
3029
30302000-06-26 Toshiaki Takada <takada@zebra.org>
3031
3032 * ospf_lsa.c (ospf_lsa_install), (ospf_router_lsa_install),
3033 (ospf_network_lsa_install), (ospf_summary_lsa_install),
3034 (ospf_summary_asbr_lsa_install), (ospf_external_lsa_install):
3035 Functions re-arranged.
3036
3037 * ospf_lsa.c (IS_LSA_MAXAGE), (IS_LSA_SELF): Macro added.
3038
30392000-06-20 Michael Rozhavsky <mike@nbase.co.il>
3040
3041 * ospf_packet.c (ospf_ls_req), (ospf_ls_upd), (ospf_ls_ack): Add
3042 verification of LS type.
3043
30442000-06-20 Gleb Natapov <gleb@nbase.co.il>
3045
3046 * ospf_ase.c (ospf_ase_calculate_timer): Add more sanity check
3047 whether rn->info is NULL.
3048
30492000-06-20 Toshiaki Takada <takada@zebra.org>
3050
3051 * ospfd.c (show_ip_ospf_interface_sub): Show Router-ID of both
3052 DR and Backup correctly with `show ip ospf interface' command.
3053
30542000-06-20 Toshiaki Takada <takada@zebra.org>
3055
3056 * ospf_lsa.c (ospf_lsa_lock), (ospf_lsa_unlock),
3057 (ospf_lsa_discard): These functions are used for avoiding
3058 unexpected reference to freed LSAs.
3059
30602000-06-13 Kunihiro Ishiguro <kunihiro@zebra.org>
3061
3062 * ospf_packet.c (ospf_ls_upd): Initialize lsa by NULL to avoid
3063 warning.
3064
30652000-06-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3066
3067 * ospf_ase.h (ospf_ase_rtrs_register_lsa): Add prototype.
3068
30692000-06-12 Toshiaki Takada <takada@zebra.org>
3070
3071 * ospf_lsa.c (ospf_external_lsa_install): Make sure to register
3072 LSA to rtrs_external when replacing AS-external-LSAs in LSDB.
3073 Fix core dump.
3074
30752000-06-10 Toshiaki Takada <takada@zebra.org>
3076
3077 * ospf_lsdb.c (id_to_prefix), (ospf_lsdb_hash_key),
3078 (ospf_lsdb_hash_cmp), (ospf_lsdb_new), (ospf_lsdb_iterator),
3079 (lsdb_free), (ospf_lsdb_free), (ospf_lsdb_add), (ospf_lsdb_delete),
3080 (find_lsa), (ospf_lsdb_lookup), (find_by_id),
3081 (ospf_lsdb_lookup_by_id), (ospf_lsdb_lookup_by_header): Functinos
3082 removed for migration to new_lsdb.
3083
3084 * ospf_lsa.c (ospf_summary_lsa_install),
3085 (ospf_summary_asbr_lsa_install), (ospf_maxage_lsa_remover),
3086 (ospf_lsa_maxage_walker), (ospf_lsa_lookup),
3087 (ospf_lsa_lookup_by_id): Use new_lsdb instead of ospf_lsdb.
3088 (count_lsa), (ospf_lsa_count_table), (ospf_lsa_count),
3089 (ospf_get_free_id_for_prefix): Funcitions removed.
3090
30912000-06-09 Gleb Natapov <gleb@nbase.co.il>
3092
3093 * ospf_ism.c (ism_interface_down): Prevent some unneeded DR changes.
3094
3095 * ospf_packet.c (ospf_db_desc_proc): Fix memory leak.
3096 (ospf_hello): Always copy router-ID when hello is received.
3097
30982000-06-08 Gleb Natapov <gleb@nbase.co.il>
3099
3100 * ospf_lsa.h (struct ospf_lsa): Add member of pointer to struct
3101 ospf_area.
3102
31032000-06-08 Michael Rozhavsky <mike@nbase.co.il>
3104
3105 * ospf_ase.c (ospf_asbr_route_same): New function added.
3106 This function makes sure external route calculation more
3107 precisely.
3108
31092000-06-07 Michael Rozhavsky <mike@nbase.co.il>
3110
3111 * ospf_ism.c (ism_change_status): Use ospf_lsa_flush_area for
3112 network-LSA deletion instead of using ospf_lsdb_delete.
3113 Also cancel network-LSA origination timer.
3114
31152000-06-07 Levi Harper <lharper@kennedytech.com>
3116
3117 * ospf_interface.c (ospf_if_down): Close read fd when an interface
3118 goes down.
3119
31202000-06-05 Kunihiro Ishiguro <kunihiro@zebra.org>
3121
3122 * ospf_asbr.c (ospf_external_info_lookup): Add explicit brace for
3123 avoid ambiguous else.
3124
3125 * ospf_flood.c (ospf_external_info_check): Likewise.
3126
31272000-06-05 Toshiaki Takada <takada@zebra.org>
3128
3129 * ospf_nsm.c (nsm_adj_ok): Fix bug of DR election.
3130
31312000-06-04 Toshiaki Takada <takada@zebra.org>
3132
3133 * ospf_zebra.c (ospf_default_information_originate),
3134 (no_ospf_default_information_originate): New DEFUN added.
3135
31362000-06-03 Toshiaki Takada <takada@zebra.org>
3137
3138 * ospf_lsa.h, ospf_asbr.h (external_info): Struct moved from
3139 ospf_lsa.h to ospf_asbr.h.
3140
3141 * ospf_lsa.c, ospf_asbr.c (ospf_external_info_add),
3142 (ospf_external_info_delete): Function moved from ospf_lsa.c
3143 to ospf_asbr.c.
3144
31452000-06-03 Toshiaki Takada <takada@zebra.org>
3146
3147 * ospf_flood.c (ospf_external_info_check): New function added.
3148 (ospf_process_self_orignated_lsa): Make sure to flush
3149 self-originated AS-external-LSA, when router reboot and no longer
3150 originate those AS-external-LSA.
3151
31522000-06-02 Toshiaki Takada <takada@zebra.org>
3153
3154 * ospf_network.c (ospf_serv_sock): Remove SO_DONTROUTE
3155 socket option.
3156
3157 * ospf_packet.c (ospf_write): Set MSG_DONTROUTE flag for
3158 unicast destination packets.
3159
31602000-06-02 Toshiaki Takada <takada@zebra.org>
3161
3162 * ospf_lsdb.c (new_lsdb_delete): Delete entry from LSDB only when
3163 specified LSA matches.
3164
31652000-06-02 Gleb Natapov <gleb@nbase.co.il>
3166
3167 * ospf_network.c (ospf_serv_sock): Set SO_DONTROUTE
3168 socket option.
3169
31702000-06-01 Akihiro Mizutani <mizutani@dml.com>
3171
3172 * ospf_dump.c: Replace string `Debugging functions\n' with DEBUG_STR.
3173 Replace string `OSPF information\n' with OSPF_STR.
3174
31752000-06-01 Toshiaki Takada <takada@zebra.org>
3176
3177 * ospf_lsdb.[ch]: Use new_lsdb struct for network-LSA instead of
3178 ospf_lsdb.
3179
31802000-06-01 Toshiaki Takada <takada@zebra.org>
3181
3182 * ospf_dump.c (config_debug_ospf_packet), (config_debug_ospf_event),
3183 (config_debug_ospf_ism), (config_debug_ospf_nsm),
3184 (config_debug_ospf_lsa), (config_debug_ospf_zebra),
3185 (term_debug_ospf_packet), (term_debug_ospf_event),
3186 (term_debug_ospf_ism), (term_debug_ospf_nsm),
3187 (term_debug_ospf_lsa), (term_debug_ospf_zebra): Repalce debug_ospf_*
3188 variable to use for debug option flags.
3189
3190 (debug_ospf_packet), (debug_ospf_ism), (debug_ospf_nsm),
3191 (debug_ospf_lsa), (debug_ospf_zebra): Set {config,term}_debug_*
3192 flags when vty->node is CONFIG_NODE, otherwise set only term_debug_*
3193 flags.
3194
3195 * ospf_dump.h (CONF_DEBUG_PACKET_ON), (CONF_DEBUG_PACKET_OFF),
3196 (TERM_DEBUG_PACKET_ON), (TERM_DEBUG_PACKET_OFF),
3197 (CONF_DEBUG_ON), (CONF_DEBUG_OFF), (IS_CONF_DEBUG_OSPF_PACKET),
3198 (IS_CONF_DEBUG_OSPF): New Macro added.
3199
32002000-05-31 Toshiaki Takada <takada@zebra.org>
3201
3202 * ospfd.c (clear_ip_ospf_neighbor): New DEFUN added.
3203 Currently this command is used for only debugging.
3204
3205 * ospf_nsm.c (nsm_change_status): Make sure thread cancellation
3206 for network-LSA when DR has no full neighbors.
3207
3208 * ospf_nsm.c (ospf_db_summary_clear): New function added.
3209
32102000-05-30 Toshiaki Takada <takada@zebra.org>
3211
3212 * ospf_lsdb.c (new_lsdb_insert): LSAs are always freed by
3213 maxage_lsa_remover when LSA is replaced.
3214
32152000-05-25 Gleb Natapov <gleb@nbase.co.il>
3216
3217 * ospf_flood.c (ospf_ls_retransmit_delete_nbr_all): Add argument
3218 `struct ospf_area' to remove LSA from Link State retransmission list
3219 of neighbor from only one Area.
3220
32212000-05-24 Michael Rozhavsky <mike@nbase.co.il>
3222
3223 * ospf_lsdb.c (ospf_lsdb_add): Preserve flags field when
3224 overriting old LSA with new LSA.
3225
32262000-05-24 Gleb Natapov <gleb@nbase.co.il>
3227
3228 * ospf_lsa.c (ospf_router_lsa_body_set): Fix bug of router-LSA
3229 size calculation.
3230
32312000-05-22 Michael Rozhavsky <mike@nbase.co.il>
3232
3233 * ospf_route.c (ospf_intra_add_stub):
3234 * ospf_spf.h (struct vertex): Use u_int32_t for distance (cost)
3235 value instead of u_int16_t.
3236
32372000-05-22 Axel Gerlach <agerlach@datus.datus.com>
3238
3239 * ospf_ia.c (ospf_ia_network_route): Fix bug of Inter-area route
3240 equal cost path calculation.
3241
32422000-05-21 Toshiaki Takada <takada@zebra.org>
3243
3244 * ospf_ase.c (ospf_ase_calculate_route_delete): New function added.
3245 Make sure, when rotuer route is deleted, related external routes
3246 are also deleted.
3247
32482000-05-20 Toshiaki Takada <takada@zebra.org>
3249
3250 * ospfd.c (ospf_interface_down): Make sure interface flag is disable
3251 and set fd to -1.
3252
32532000-05-16 Toshiaki Takada <takada@zebra.org>
3254
3255 * ospf_asbr.c (ospf_asbr_should_announce), (ospf_asbr_route_remove):
3256 Functions removed.
3257
3258 * ospfd.h (EXTERNAL_INFO): Macro added.
3259 Substitute `ospf_top->external_info[type]' with it.
3260
32612000-05-16 Toshiaki Takada <takada@zebra.org>
3262
3263 * ospf_lsa.c (ospf_rtrs_external_remove): New function added.
3264
32652000-05-14 Gleb Natapov <gleb@nbase.co.il>
3266
3267 * ospf_flood.c (ospf_ls_retransmit_delete_nbr_all)
3268 * ospf_lsdb.c (new_lsdb_insert)
3269 * ospf_packet.c (ospf_ls_ack): Fix database synchonization problem.
3270
32712000-05-14 Gleb Natapov <gleb@nbase.co.il>
3272
3273 * ospf_lsa.h (tv_adjust), (tv_ceil), (tv_floor), (int2tv),
3274 (tv_add), (tv_sub), (tv_cmp): Prototype definition added.
3275
3276 * ospf_nsm.h (ospf_db_summary_delete_all): Prototype definition added.
3277
32782000-05-13 Toshiaki Takada <takada@zebra.org>
3279
3280 * ospf_lsa.[ch] (ospf_lsa): struct timestamp type is changed from
3281 time_t to struct timeval.
3282 (tv_adjust), (tv_ceil), (tv_floor), (int2tv), (tv_add),
3283 (tv_sub), (tv_cmp): timeval utillity functions added.
3284
32852000-05-12 Toshiaki Takada <takada@zebra.org>
3286
3287 * ospf_lsa.[ch] (ospf_schedule_update_router_lsas): Delete function.
3288 Change to use macro OSPF_LSA_UPDATE_TIMER instead of using
3289 this function.
3290 router-LSA refresh timer related stuff is re-organized.
3291
32922000-05-10 Gleb Natapov <gleb@nbase.co.il>
3293
3294 * ospf_interface.c (ospf_vl_set_params):
3295 * ospf_packet.c (ospf_check_network_mask):
3296 * ospf_spf.[ch] (ospf_spf_next):
3297 Remove field address from `struct vertex', and search for peer
3298 address of virtual link in function `ospf_vl_set_params' instead.
3299
33002000-05-10 Gleb Natapov <gleb@nbase.co.il>
3301
3302 * ospf_packet.c (ospf_ls_upd): Fix some memory leak related LSA.
3303
33042000-05-08 Thomas Molkenbur <tmo@datus.com>
3305
3306 * ospf_packet.c (ospf_packet_dup): Replace ospf_steram_copy()
3307 with ospf_stream_dup() to fix memory leak.
3308
33092000-05-08 Michael Rozhavsky <mike@nbase.co.il>
3310
3311 * ospf_flood.c (ospf_flood_through_area): Fix the problem of
3312 LSA update without DROther.
3313
33142000-05-04 Gleb Natapov <gleb@nbase.co.il>
3315
3316 * ospf_spf.c (ospf_vertex_free): Fix memory leak of SPF calculation.
3317
33182000-05-03 Toshiaki Takada <takada@zebra.org>
3319
3320 * ospf_neighbor.c (ospf_db_summary_add): Use new_lsdb struct
3321 instead linked-list.
3322 (ospf_db_summary_count), (ospf_db_summary_isempty):
3323 New function added.
3324
3325 * ospf_lsa.c (ospf_rotuer_lsa): Re-arrange and divide functions.
3326
33272000-05-02 Gleb Natapov <gleb@nbase.co.il>
3328
3329 * ospf_lsdb.c (new_lsdb_cleanup): Fix memory leak. When LSDB are
3330 not needed any more, then free them.
3331
33322000-05-02 Toshiaki Takada <takada@zebra.org>
3333
3334 * ospfd.c (timers_spf), (no_timers_spf): New defun added.
3335 SPF calculation timers related stuff is rearranged.
3336
3337 * ospf_spf.c (ospf_spf_calculate_timer_add): Function removed.
3338 SPF timer is scheduled by SPF calculation delay and holdtime
3339 configuration variable.
3340
3341 * ospf_lsa.c (ospf_external_lsa_nexthop_get): Set AS-external-LSA's
3342 forwarding address when nexthop learned by other protocols is
3343 in the OSPF domain.
3344
3345 * ospf_zebra.c (ospf_redistribute_source_metric_type),
3346 (ospf_redistribute_source_type_metric): Re-arrange DEFUNs and
3347 ALIASes.
3348
33492000-05-01 Toshiaki Takada <takada@zebra.org>
3350
3351 * ospf_flood.c (ospf_ls_retransmit_count),
3352 (ospf_ls_retransmit_isempty): New function added.
3353
3354 (ospf_ls_retransmit_add), (ospf_ls_retransmit_delete),
3355 (ospf_ls_retransmit_clear), (ospf_ls_retransmit_lookup),
3356 (ospf_ls_retransmit_delete_all), (ospf_ls_retransmit_delete_nbr_all),
3357 (ospf_ls_retransmit_add_nbr_all): Replace these functions to use
3358 new_lsdb.
3359
33602000-04-29 Toshiaki Takada <takada@zebra.org>
3361
3362 * ospfd.c (no_network_area): Add check Area-ID whether specified
3363 Area-ID with prefix matches config.
3364
33652000-04-27 Toshiaki Takada <takada@zebra.org>
3366
3367 * ospf_lsa.c (ospf_maxage_lsa_remover): Fix problem of
3368 remaining withdrawn routes on zebra.
3369
33702000-04-25 Michael Rozhavsky <mike@nbase.co.il>
3371
3372 * ospf_nsm.c (nsm_kill_nbr), (nsm_ll_down), (nsm_change_status),
3373 (ospf_nsm_event): Fix network-LSA re-origination problem.
3374
33752000-04-24 Toshiaki Takada <takada@zebra.org>
3376
3377 * ospf_nsm.c (ospf_db_desc_timer): Fix bug of segmentation fault
3378 with DD retransmission.
3379
3380 * ospf_nsm.c (nsm_kill_nbr): Fix bug of re-origination when
3381 a neighbor disappears.
3382
33832000-04-23 Michael Rozhavsky <mike@nbase.co.il>
3384
3385 * ospf_abr.c (ospf_abr_announce_network_to_area): Fix bug of
3386 summary-LSAs reorigination. Correctly copy OSPF_LSA_APPROVED
3387 flag to new LSA. when summary-LSA is reoriginatd.
3388
3389 * ospf_flood.c (ospf_flood_through_area): Fix bug of flooding
3390 procedure. Change the condition of interface selection.
3391
33922000-04-21 Toshiaki Takada <takada@zebra.org>
3393
3394 * ospf_lsa.c (ospf_refresher_register_lsa): Fix bug of refresh never
3395 occurs.
3396
3397 * ospfd.c (show_ip_ospf_neighbor_id): New defun added.
3398 `show ip ospf neighbor' related commands are re-arranged.
3399
34002000-04-20 Toshiaki Takada <takada@zebra.org>
3401
3402 * ospf_dump.c (debug_ospf_zebra): New defun added.
3403 Suppress zebra related debug information.
3404
34052000-04-19 Toshiaki Takada <takada@zebra.org>
3406
3407 * ospf_zebra.c (ospf_distribute_list_update_timer),
3408 (ospf_distribute_list_update), (ospf_filter_update):
3409 New function added. Re-organize `distribute-list' router ospf
3410 command.
3411
34122000-04-13 Michael Rozhavsky <mike@nbase.co.il>
3413
3414 * ospf_packet.c (ospf_make_ls_upd): Add check for MAX_AGE.
3415
34162000-04-14 Michael Rozhavsky <mike@nbase.co.il>
3417
3418 * ospf_packet.c (ospf_make_ls_upd): Increment LS age by configured
3419 interface transmit_delay.
3420
34212000-04-14 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3422
3423 * ospf_interface.c (ip_ospf_cost), (no_ip_ospf_cost):
3424 Add to schedule router_lsa origination when the interface cost changes.
3425
34262000-04-12 Toshiaki Takada <takada@zebra.org>
3427
3428 * ospf_lsa.c (ospf_refresher_register_lsa),
3429 (ospf_refresher_unregister_lsa): Fix bug of core dumped.
3430
3431 * ospfd.c (no_router_ospf): Fix bug of core dumped.
3432
34332000-03-29 Toshiaki Takada <takada@zebra.org>
3434
3435 * ospf_nsm.c (nsm_oneway_received): Fix bug of MS flag unset.
3436
34372000-03-29 Michael Rozhavsky <mike@nbase.co.il>
3438
3439 * ospf_lsa.c (ospf_network_lsa):
3440 * ospf_nsm.c (ospf_nsm_event): Fix bug of Network-LSA originated
3441 in stub network.
3442
34432000-03-28 Toshiaki Takada <takada@zebra.org>
3444
3445 * ospf_nsm.c (nsm_bad_ls_req), (nsm_seq_number_mismatch),
3446 (nsm_oneway_received): Fix bug of NSM state flapping between
3447 ExStart and Exchange.
3448
34492000-03-28 Toshiaki Takada <takada@zebra.org>
3450
3451 * ospf_packet.h (strcut ospf_header): Fix the size of ospf_header,
3452 change u_int8_t to u_char.
3453
34542000-03-27 Toshiaki Takada <takada@zebra.org>
3455
3456 * ospf_lsa.c (ospf_lsa_checksum): Take care of BIGENDIAN architecture.
3457
34582000-03-27 Toshiaki Takada <takada@zebra.org>
3459
3460 * ospfd.c (ospf_interface_run): Make sure Address family matches.
3461
34622000-03-26 Love <lha@s3.kth.se>
3463
3464 * ospf_packet.c (ospf_write): Chack result of sendto().
3465
34662000-03-26 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3467
3468 * ospf_nsm.c (nsm_oneway_received): Fix bug of 1-WayReceived in NSM.
3469
34702000-03-23 Libor Pechacek <farco@clnet.cz>
3471
3472 * ospf_lsa.c (ospf_network_lsa)
3473 * ospf_lsdb.c (new_lsdb_insert): Fix bug of accessing to
3474 unallocated memory.
3475
34762000-03-23 Toshiaki Takada <takada@zebra.org>
3477
3478 * ospfd.c (ospf_config_write): Fix bug of duplicate line for
3479 `area A.B.C.D authentication'.
3480
34812000-03-22 Toshiaki Takada <takada@zebra.org>
3482
3483 * ospf_debug.c (debug_ospf_lsa), (no_debug_ospf_lsa): Defun added.
3484 Suppress all zlog related to LSAs with this config option.
3485
34862000-03-21 Kunihiro Ishiguro <kunihiro@zebra.org>
3487
3488 * ospf_nsm.c (ospf_nsm_event): Add check for NSM_InactivityTimer.
3489
34902000-03-21 Toshiaki Takada <takada@zebra.org>
3491
3492 * ospf_packet.c (ospf_ls_upd_timer), (ospf_ls_req):
3493 Fix bug of memory leak about linklist.
3494
3495 * ospf_flood.c (ospf_flood_through_area): Likewise.
3496
34972000-03-18 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3498
3499 * ospf_flood.c (ospf_ls_retransmit_lookup): Add checksum comparison
3500 to identify LSA uniquely. This fix routes lost.
3501
35022000-03-18 Toshiaki Takada <takada@zebra.org>
3503
3504 * ospf_ase.c (ospf_find_asbr_route): Add sanity check with router
3505 routing table.
3506
35072000-03-17 Alex Zinin <zinin@amt.ru>
3508
3509 * ospf_spf.[ch]: Bug fix.
3510 The 2nd stage of Dijkstra could consider one vertex
3511 more than once if there is more than one link
3512 between the routers, thus adding extra CPU overhead
3513 and extra next-hops.
3514 Fixed.
3515
35162000-03-15 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3517
3518 * ospf_nsm.c (nsm_inactivity_timer): Changed to call nsm_kill_nbr().
3519
35202000-03-14 Toshiaki Takada <takada@zebra.org>
3521
3522 * ospf_route.c (ospf_route_copy_nexthops): Fix bug of memory leak of
3523 ospf_path. Actually ignore merging ospf_route with completely same
3524 paths.
3525
35262000-03-12 Toshiaki Takada <takada@zebra.org>
3527
3528 * ospf_lsa.c (show_as_external_lsa_detail): fix bug of
3529 external route tag byte order.
3530
35312000-03-11 Toshiaki Takada <takada@zebra.org>
3532
3533 * ospf_lsdb.c (ospf_lsdb_insert): New function added.
3534
35352000-03-09 Toshiaki Takada <takada@zebra.org>
3536
3537 * ospf_lsa.c (ospf_external_lsa_install),
3538 (ospf_lsa_lookup), (show_ip_ospf_database_all),
3539 (show_ip_ospf_database_self_originate): Use struct new_lsdb for
3540 LSDB of AS-external-LSAs instead of ospf_lsdb.
3541
3542 * ospf_lsa.c (ospf_lsa_unique_id): New function added.
3543 Use for assigning Unique Link State ID instead of
3544 ospf_get_free_id_for_prefix().
3545
35462000-03-09 Toshiaki Takada <takada@zebra.org>
3547
3548 * ospf_ase.c (ospf_ase_calculate_timer): Fix bug of segmentation
3549 fault reported by George Bonser <george@siteROCK.com>.
3550
35512000-03-07 Libor Pechacek <farco@clnet.cz>
3552
3553 * ospfd.c (ospf_interface_down): Fix bug of segmentation fault.
3554
35552000-03-06 Toshiaki Takada <takada@zebra.org>
3556
3557 * ospf_route.c (ospf_route_cmp): Change meaning of return values.
3558
35592000-03-02 Alex Zinin <zinin@amt.ru>
3560 * ospfd.h, ospf_ia.h
3561 New Shortcut ABR code. Now area's flag can be configured
3562 with Default, Enable, and Disable values.
3563 More info will be in the new ver of I-D soon (see IETF web).
3564
35652000-02-25 Toshiaki Takada <takada@zebra.org>
3566
3567 * ospf_lsa.c (ospf_lsa_header_set), (ospf_external_lsa_body_set),
3568 (osfp_external_lsa_originate), (ospf_external_lsa_queue),
3569 (ospf_external_lsa_originate_from_queue): New function added.
3570 (ospf_external_lsa): Function removed.
3571
3572 * ospf_zebra.c (ospf_zebra_read_ipv4): Originate AS-external-LSA
3573 when listen a route from Zebra, instead creating external route.
3574
3575 * ospf_asbr.c (ospf_asbr_route_add_flood_lsa),
3576 (ospf_asbr_route_add_queue_lsa),
3577 (ospf_asbr_route_install_lsa), (ospf_asbr_route_add):
3578 Functions removed.
3579
3580 * ospf_ase.c (process_ase_lsa): Function will not be used.
3581 (ospf_ase_calculate), (ospf_ase_calculate_route_add),
3582 (ospf_ase_calculate_new_route), (ospf_ase_caluculate_asbr_route):
3583 process_ase_lsa () is separated to these functions.
3584
3585 OSPF AS-external-LSA origination is whole re-organized.
3586
35872000-02-18 Toshiaki Takada <takada@zebra.org>
3588
3589 * ospf_packet.c (ospf_ls_upd): Fix bug of OSPF LSA memory leak.
3590
3591 * ospf_asbr.c (ospf_asbr_route_add_flood_lsa),
3592 (ospf_asbr_route_add_queue_lsa): Fix bug of OSPF external route
3593 memory leak.
3594
35952000-02-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3596
3597 * ospf_asbr.c (ospf_asbr_route_install_lsa): Re-calculate LSA
3598 checksum after change Advertised Router field.
3599
36002000-02-09 Toshiaki Takada <takada@zebra.org>
3601
3602 * ospf_asbr.c (ospf_external_route_lookup): Add new function.
3603
36042000-02-08 Toshiaki Takada <takada@zebra.org>
3605
3606 * ospfd.c (ospf_router_id_get), (ospf_router_id_update),
3607 (ospf_router_id_update_timer): Router ID decision algorithm is changed.
3608 Router ID is chosen from all of eligible interface addresses even if
3609 it is not enable to OSPF.
3610
36112000-02-08 Toshiaki Takada <takada@zebra.org>
3612
3613 * ospf_asbr.c (ospf_asbr_route_add): Function divided to
3614 ospf_asbr_route_add_flood_lsa, ospf_asbr_route_add_queue_lsa and
3615 ospf_asbr_route_install_lsa. If Router-ID is not set, then LSA is
3616 waited to install to LSDB.
3617 `0.0.0.0 adv_router' AS-external-LSA origination bug was fixed.
3618
36192000-02-01 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3620
3621 * ospf_flood.c (ospf_ls_retransmit_lookup): Compare LS seqnum
3622 in the ACK before deleting.
3623
3624 * ospf_packet.c (ospf_hello): Reset the flags after a shutdown
3625 and no shutdown of the interface.
3626
36272000-01-31 Toshiaki Takada <takada@zebra.org>
3628
3629 * ospf_packet.c (ospf_ls_req): Send multiple Link State Update
3630 packets respond to a Link State Request packet.
3631
3632 * ospfd.c (show_ip_ospf_neighbor_detail_sub): Show thread state.
3633
3634 * ospf_interface.c (ospf_vl_new): Crash when backbone area
3635 is not configured and set virtual-link to no-backbone area,
3636 bug fixed.
3637
36382000-01-30 Kunihiro Ishiguro <kunihiro@zebra.org>
3639
3640 * ospf_neighbor.h (struct ospf_neighbor): Add pointer to last send
3641 LS Request LSA.
3642
3643 * ospf_packet.c (ospf_ls_upd): Comment out LS request list
3644 treatment. That should be done in OSPF flooding procedure.
3645
3646 * ospf_flood.c (ospf_flood_through_area): Enclose
3647 ospf_check_nbr_loding inside if-else close.
3648
36492000-01-31 Toshiaki Takada <takada@zebra.org>
3650
3651 * ospf_packet.c (ospf_make_ls_upd): Fix bug of #LSAs counting.
3652
36532000-01-29 Toshiaki Takada <takada@zebra.org>
3654
3655 * ospf_packet.c (ospf_make_md5_digest): Fix bug of md5 authentication.
3656
36572000-01-28 Toshiaki Takada <takada@zebra.org>
3658
3659 * ospfd.c (show_ip_ospf): Show Number of ASE-LSAs.
3660
36612000-01-27 Kunihiro Ishiguro <kunihiro@zebra.org>
3662
3663 * ospf_packet.c (ospf_make_db_desc): Don't use rm_list for
3664 removing LSA from nbr->db_summary.
3665
36662000-01-27 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3667
3668 * ospf_packet.c (ospf_ls_upd_send): Set AllSPFRouters to
3669 destination when the link is point-to-point.
3670 (ospf_ls_ack_send_delayed): Likewise.
3671
36722000-01-27 Kunihiro Ishiguro <kunihiro@zebra.org>
3673
3674 * ospf_flood.c (ospf_ls_request_delete_all): Fix bug of next
3675 pointer lookup after the node is freed.
3676
36772000-01-26 Kunihiro Ishiguro <kunihiro@zebra.org>
3678
3679 * ospf_asbr.c (ospf_asbr_route_add): Instead of scanning all AS
3680 external route, use ospf_top->external_self.
3681
36822000-01-27 Toshiaki Takada <takada@zebra.org>
3683
3684 * ospf_lsa.c (ospf_forward_address_get): New function added.
3685
3686 * ospf_asbr.c (ospf_asbr_check_lsas): Originate AS-external-LSA
3687 only when it should be replaced.
3688
36892000-01-25 Kunihiro Ishiguro <kunihiro@zebra.org>
3690
3691 * ospf_flood.c (ospf_ls_retransmit_clear): Delete list node.
3692
3693 * ospf_lsa.c (ospf_lsa_free): Reduce logging message using
3694 ospf_zlog value.
3695
3696 * ospf_ism.c (ism_change_status): Fix bug of DR -> non DR status
3697 change. Self originated LSA is freed but not deleted from lsdb.
3698
36992000-01-24 Kunihiro Ishiguro <kunihiro@zebra.org>
3700
3701 * ospf_ism.c (ism_interface_down): Don't use router_id for
3702 detecting self neighbor structure. Instead of that compare
3703 pointer itself.
3704
3705 * ospf_neighbor.c (ospf_nbr_free): Cancel all timer when neighbor
3706 is deleted.
3707 (ospf_nbr_free): Free last send packet.
3708
3709 * ospf_neighbor.h (struct ospf_neighbor): Remove host strucutre.
3710 Instead of that src is introduced.
3711
3712 * ospf_nsm.h: Enclose macro defenition with do {} while (0).
3713
37142000-01-17 Kunihiro Ishiguro <kunihiro@zebra.org>
3715
3716 * ospfd.c: Change part of passive interface implementation. For
3717 passive interface just disabling sending/receiving Hello on the
3718 interface.
3719
37202000-01-16 Kai Bankett <kai.bankett@vew-telnet.net>
3721
3722 * ospf_interface.h (OSPF_IF_PASSIVE): Add passive flag.
3723 * ospf_interface.c (ospf_if_lookup_by_name): Add new function.
3724 * ospf_lsa.c (ospf_router_lsa): Skip passive interface.
3725 * ospfd.c (passive_interface): New command passive-interface is
3726 added.
3727 (ospf_config_write): Print passive interface.
3728
37292000-01-15 Toshiaki Takada <takada@zebra.org>
3730
3731 * ospf_interface.h (crypt_key): New struct added to store
3732 multiple cryptographic autheitication keys.
3733 (ospf_interface): struct changed.
3734
3735 * ospf_interface.c: ospf_crypt_key_new, ospf_crypt_key_add,
3736 ospf_crypt_key_lookup, ospf_crypt_key_delete: new functions added.
3737
3738 * ospf_packet.c (ip_ospf_message_digest_key): Changed to store
3739 multiple cryptographic authentication keys.
3740
37412000-01-14 Toshiaki Takada <takada@zebra.org>
3742
3743 * ospf_interface.c: DEFUN (if_ospf_*) commands changed name to
3744 ip_ospf_* ().
3745 Old notation `ospf *' still remains backward compatibility.
3746
37471999-12-29 Alex Zinin <zinin@amt.ru>
3748 * ospf_lsa.c: ospf_lsa_more_recent() bug fix
3749 * ospf_nsm.c, ospf_packet.c: remove nbr data struct when
3750 int goes down, also check DD flags correctly (bug fix)
3751
37521999-12-28 Alex Zinin <zinin@amt.ru>
3753 * "redistribute <source> metric-type (1|2) metric <XXX>" added
3754
37551999-12-23 Alex Zinin <zinin@amt.ru>
3756 * added RFC1583Compatibility flag
3757 * added dynamic interface up/down functionality
3758
37591999-11-19 Toshiaki Takada <takada@zebra.org>
3760
3761 * ospf_neighbor.h (struct ospf_neighbor): Add member state_change
3762 for NSM state change statistics.
3763
37641999-11-19 Toshiaki Takada <takada@zebra.org>
3765
3766 * ospfd.c (show_ip_ospf_neighbor_detail),
3767 (show_ip_ospf_neighbor_int_detail): DEFUN Added.
3768
37691999-11-14 Kunihiro Ishiguro <kunihiro@zebra.org>
3770
3771 * ospf_asbr.c (ospf_asbr_check_lsas): Add check of
3772 lsa->refresh_list.
3773
37741999-11-11 Toshiaki Takada <takada@zebra.org>
3775
3776 * ospf_ia.[ch] (OSPF_EXAMINE_SUMMARIES_ALL): Macro added.
3777 This macro is expanded to ospf_examine_summaries ()
3778 for SUMMARY_LSA and SUMMARY_LSA_ASBR.
3779 (OSPF_EXAMINE_TRANSIT_SUMMARIES_ALL): Macro added.
3780 This macro is expanded to ospf_examine_transit_summaries ()
3781 for SUMMARY_LSA and SUMMARY_LSA_ASBR.
3782
37831999-11-11 Toshiaki Takada <takada@zebra.org>
3784
3785 * ospf_lsa.[ch] (ospf_find_self_summary_lsa_by_prefix): Changed to
3786 macro OSPF_SUMMARY_LSA_SELF_FIND_BY_PREFIX.
3787 (ospf_find_self_summary_asbr_lsa_by_prefix): Changed to
3788 macro OSPF_SUMMARY_ASBR_LSA_SELF_FIND_BY_PREFIX.
3789 (ospf_find_self_external_lsa_by_prefix): Changed to
3790 macro OSPF_EXTERNAL_LSA_SELF_FIND_BY_PREFIX.
3791
37921999-11-11 Toshiaki Takada <takada@zebra.org>
3793
3794 * ospfd.c (ospf_abr_type): ospf_abr_type_cisco, ospf_abr_type_ibm,
3795 ospf_abr_type_shortcut and ospf_abr_type_standard DEFUNs are
3796 combined.
3797 * ospfd.c (no_ospf_abr_type): no_ospf_abr_type_cisco,
3798 no_ospf_abr_type_ibm and no_ospf_abr_type_shortcut DEFUNS are
3799 combined.
3800
38011999-11-10 Toshiaki Takada <takada@zebra.org>
3802
3803 * ospf_route.c (ospf_lookup_int_by_prefix): Move function to
3804 ospf_interface.c and change name to ospf_if_lookup_by_prefix ().
3805
38061999-11-01 Alex Zinin <zinin@amt.ru>
3807 * ospf_packet.c
3808 some correction to LSU processing
3809
3810 * ospf_lsa.c ospfd.h
3811 randomize initial LSA refreshment interval
3812 and limit the size of LSA-group to 10
3813 to let randomization work more effectively.
3814
38151999-10-31 Alex Zinin <zinin@amt.ru>
3816 * ospf_interface.c
3817 cancel t_network_lsa_self
3818 when freeing int structure
3819
3820 * ospf_abr.c ospf_asbr.c ospf_flood.c ospf_lsa.c
3821 ospf_lsa.h ospf_lsdb.h ospfd.c ospfd.h
3822
3823 Summary and ASE LSA refreshment functions
3824 added---LSA refreshment is paced to 70 LSAs
3825 per sec to avoid link overflow. Refreshment events
3826 are further randomized within a 10 sec interval
3827 to avoid syncing.
3828
3829 Also the sigfault of memcmp() in ospf_lsa_is_different()
3830 is fixed.
3831
38321999-10-30 Alex Zinin <zinin@amt.ru>
3833 * ospf_nsm.c
3834 Fix the bug where MAX_AGE LSAs
3835 are included into the DB summary.
3836
3837 * ospf_interface.c
3838 allocate 2*MTU input buffer instead of just MTU
3839 for the cases when the other router mistakenly
3840 sends larger packets thus causing fragmentation, etc.
3841
3842 * ospf_nsm.c
3843 in nsm_reset_nbr() lists should be freed
3844 not when they are empty.
3845
38461999-10-29 Kunihiro Ishiguro <kunihiro@zebra.org>
3847
3848 * ospf_zebra.c (ospf_acl_hook): Move OSPF_IS_ASBR and OSPF_IS_ABR
3849 check inside of if (ospf_top).
3850
38511999-10-29 Alex Zinin <zinin@amt.ru>
3852 * ospf_lsa.c ospf_lsdb.c :
3853 add assertion in lsa and lsa->data alloc functions,
3854 as well as in lsdb_add for new->data
3855
3856 * ospf_lsdb.c: free hash table correctly
3857
38581999-10-28 John Capo <jc@irbs.com>
3859
3860 * ospf_packet.h (OSPF_PACKET_MAX): Correct MAX packet length
3861 calculation
3862
38631999-10-27 Kunihiro Ishiguro <kunihiro@zebra.org>
3864
3865 * OSPF-TRAP-MIB.txt: New file added. Edited version of RFC1850.
3866
3867 * OSPF-MIB.txt: New file added. Edited version of RFC1850.
3868
38691999-10-27 Alex Zinin <zinin@amt.ru>
3870 * ospfd, ospf_zebra, ospf_abr
3871 "area import-list" command is added.
3872 This command allows to filter the inter-area routes
3873 injected into an area. Access list hook function
3874 extended to invalidate area exp/imp lists.
3875
38761999-10-25 Yoshinobu Inoue <shin@nd.net.fujitsu.co.jp>
3877
3878 * ospfd.c (ospf_interface_run): Enable to detect P2P network
3879 on an OSPF interface.
3880
38811999-10-19 Jordan Mendelson <jordy@wserv.com>
3882
3883 * ospf_lsdb.c (ospf_lsdb_add): Fix bug of crash
3884 in ospf_ls_retransmit_lookup ().
3885
38861999-10-19 Vladimir B. Grebenschikov <vova@express.ru>
3887
3888 * ospf_route.c: Workaround about installation of OSPF routes into
3889 the zebra daemon. Add checking of existance routes. Free
3890 ospf_top->old_table if it exists.
3891
38921999-10-15 Jordan Mendelson <jordy@wserv.com>
3893
3894 * Add support for MD5 authentication.
3895
38961999-10-12 Alex Zinin <zinin@amt.ru>
3897 * ospfd.c, ospfd.h, ospf_abr.c:
3898 a new command "area export-list" was added, it allows
3899 the admin. to control which intra-area routes are
3900 announced to other areas by the ABR
3901
39021999-10-12 Alex Zinin <zinin@amt.ru>
3903 * ospf_asbr.c (ospf_asbr_check_lsas): Fix bug of coredump
3904 when "no redistribute" is used after a distribute list
3905 denying some networks was used
3906
39071999-10-05 Toshiaki Takada <takada@zebra.org>
3908
3909 * ospf_route.c (ospf_path_dup): New function added.
3910
39111999-10-05 Toshiaki Takada <takada@zebra.org>
3912
3913 * ospf_interface.[ch]: Some of VL related funciton name changed.
3914
39151999-09-27 Alex Zinin <zinin@amt.ru>
3916
3917 * ospf_zebra.c: Distribute-list functionality added
3918
39191999-09-27 Toshiaki Takada <takada@zebra.org>
3920
3921 * ospfd.c (show_ip_ospf): Fix bug of segmentation fault when no ospf
3922 instance exists.
3923
39241999-09-25 Kunihiro Ishiguro <kunihiro@zebra.org>
3925
3926 * ospfd.c (ospf_interface_down): Fix bug of misusing nextnode()
3927 instead of node->next. Reported by Hiroki Ishibashi
3928 <ishibasi@dcd.abk.nec.co.jp>.
3929
3930 * ospf_route.c (show_ip_ospf_route): Add check for ospf is enabled
3931 or not.
3932
39331999-09-23 Alex Zinin <zinin@amt.ru>
3934
3935 * stub area support added
3936
39371999-09-23 Alex Zinin <zinin@amt.ru>
3938
3939 * fwd_addr in ASE-LSAs is now set correctly
3940 * ASE routing changed to check the fwd_addr
3941 and skip the route if the addr points to one
3942 of our interfaces to avoid loops.
3943
39441999-09-22 Alex Zinin <zinin@amt.ru>
3945
3946 * ospf_interface:
3947 ospf_vls_in_area() added, it returns
3948 the number of VLs configured through the area
3949
3950 * ospf_interface.c ospf_lsa.c ospf_lsdb.c ospfd.c
3951 honor correct mem alloc
3952
39531999-09-22 Alex Zinin <zinin@amt.ru>
3954
3955 * memory.[ch]:
3956 Some OSPF mem types added,
3957 plus more info in "show mem"
3958
39591999-09-21 Alex Zinin <zinin@amt.ru>
3960
3961 * ospfd.c:
3962 "area range substitute" added.
3963 It can be used on NAT-enabled (IP-masquarade)
3964 routers to announce private networks
3965 from an area as public ones into the outside
3966 world (not in the RFC, btw :)
3967
39681999-09-21 Alex Zinin <zinin@amt.ru>
3969
3970 * ospfd.c:
3971 "area range suppress" added.
3972 This command allows to instruct the router
3973 to be silent about specific ranges, i.e.,
3974 it is a method of route filtering on area
3975 borders
3976
39771999-09-21 Alex Zinin <zinin@amt.ru>
3978
3979 * ospfd.c VLs removed when "no network area" executed
3980
39811999-09-20 Alex Zinin <zinin@amt.ru>
3982
3983 * ospf_ase.c bug fix for not-zero fwd_addr
3984 and directly connected routes.
3985
39861999-09-20 Yon Uriarte <yon@plannet.de>
3987
3988 * ospf_packet.c (ospf_make_ls_req): Introduce delta value for
3989 checking the length of OSPF packet exceeds MTU or not.
3990
3991 * ospf_lsa.c (ospf_lsa_different): Apply ntohs for checking
3992 l1->data->length.
3993
39941999-09-18 Alex Zinin <zinin@amt.ru>
3995
3996 * ospf_lsa.c bug fix for ospf_network_lsa() to
3997 include itself into the RID list
3998
39991999-09-10 Alex Zinin <zinin@amt.ru>
4000
4001 * Alternative ABR behaviors IBM/Cisco/Shortcut
4002 implemented
4003
40041999-09-10 Alex Zinin <zinin@amt.ru>
4005
4006 * router and network-LSA origination
4007 changed to honor MinLSInterval
4008
40091999-09-08 Alex Zinin <zinin@amt.ru>
4010
4011 * modified ABR behavior to honor VLs and transit
4012 areas
4013
40141999-09-07 Alex Zinin <zinin@amt.ru>
4015
4016 * completed VL functionality
4017
40181999-09-06 Kunihiro Ishiguro <kunihiro@zebra.org>
4019
4020 * ospf_asbr.c: New file.
4021 ospf_asbr.h: New file.
4022
4023 * ospf_zebra.c (ospf_redistribute_connected): Add redistribute
4024 related stuff.
4025
40261999-09-05 Kunihiro Ishiguro <kunihiro@zebra.org>
4027
4028 * ospfd.h (OSPF_FLAG_VIRTUAL_LINK): Change OSPF_FLAG_VEND to
4029 OSPF_FLAG_VIRTUAL_LINK for comprehensiveness.
4030
40311999-09-03 Kunihiro Ishiguro <kunihiro@zebra.org>
4032
4033 * ospf_spf.c (ospf_spf_register): Change name from
4034 ospf_spf_route_add() to ospf_spf_register().
4035 Include "ospfd/ospf_abr.h" for ospf_abr_task() prototype.
4036
40371999-09-02 Kunihiro Ishiguro <kunihiro@zebra.org>
4038
4039 * ospf_lsa.c (ospf_external_lsa_install): Change to update
4040 lsa->data rather than install new one, when same id lsa is already
4041 installed.
4042
40431999-09-01 Kunihiro Ishiguro <kunihiro@zebra.org>
4044
4045 * ospf_lsa.c (ospf_router_lsa_install): Return lsa value.
4046 (ospf_network_lsa_install): Likewise.
4047 (ospf_summary_lsa_install): Likewise.
4048 (ospf_summary_asbr_lsa_install): Likewise.
4049 (ospf_external_lsa_install): Likewise.
4050
4051 * ospf_spf.c (ospf_spf_calculate): Comment out debug function
4052 ospf_rtrs_print().
4053
40541999-08-31 Kunihiro Ishiguro <kunihiro@zebra.org>
4055
4056 * ospf_spf.c (ospf_rtrs_free): Add ospf_spf_calculate() for
4057 freeing rtrs.
4058
40591999-08-31 Toshiaki Takada <takada@zebra.org>
4060
4061 * ospf_lsa.c (show_ip_ospf_database_summary),
4062 (show_ip_ospf_database_summary_asbr),
4063 (show_ip_ospf_database_external): New function added.
4064 `show ip ospf database summary',
4065 `show ip ospf database asbr-summary'
4066 `show ip ospf database external' command can be used.
4067
4068 * ospf_lsa.c (ospf_lsa_count_table): New function added.
4069 (show_ip_ospf_database_all): show nothing if a type of LSA
4070 does not exist.
4071
40721999-08-31 Kunihiro Ishiguro <kunihiro@zebra.org>
4073
4074 * ospf_lsa.c (ospf_maxage_lsa_remover): Preserve next pointer when
4075 the node is deleted.
4076
40771999-08-31 Toshiaki Takada <takada@zebra.org>
4078
4079 * ospf_flood.c (ospf_ls_retransmit_lookup): change to return
4080 struct ospf_lsa *.
4081 (ospf_ls_request_new), (ospf_ls_request_free),
4082 (ospf_ls_request_add), (ospf_ls_request_delete),
4083 (ospf_ls_request_delete_all), (ospf_ls_request_lookup):
4084 New function added.
4085
4086 * ospf_packet.c (ospf_ls_upd_send_lsa): New function added.
4087
4088 * ospf_lsa.h (LS_AGE): Slightly change macro definition.
4089
4090 * ospf_lsa.c (ospf_lsa_more_recent), (ospf_lsa_diffrent):
4091 Use LS_AGE macro.
4092
40931999-08-30 Alex Zinin <zinin@amt.ru>
4094
4095 * ospfd.c
4096 fix a bug with area range config write
4097 added "show ip ospf" command, it will be enhanced later on
4098
40991999-08-30 Alex Zinin <zinin@amt.ru>
4100
4101 * ospf_lsa.c
4102 updated ospf_router_lsa() to honor flags (B-bit)
4103
41041999-08-30 Alex Zinin <zinin@amt.ru>
4105
4106 * ospf_abr.c
4107 wrote major functions implementing ABR activity
4108
41091999-08-30 Alex Zinin <zinin@amt.ru>
4110
4111 * ospf_ia.c ospf_route.c ospf_route.h
4112 fixed the bug with ospf_route.origin field.
4113 Now it holds pointer to lsa_header
4114
41151999-08-30 Alex Zinin <zinin@amt.ru>
4116
4117 * ospf_flood.c ospf_flood.h:
4118 transformed ospf_flood_if_select into ospf_flood_through_area()
4119 added new ospf_flood_if_select() and ospf_flood_through_as()
4120
41211999-08-30 Toshiaki Takada <takada@zebra.org>
4122
4123 * ospf_flood.[ch]: New file added.
4124
4125 * ospf_packet.c (ospf_lsa_flooding),
4126 (ospf_lsa_flooding_select_if): functions move to ospf_flood.c
4127
4128 * ospf_neighbor.c (ospf_put_lsa_on_retransm_list),
4129 (ospf_remove_lsa_from_retransm_list),
4130 (ospf_nbr_remove_all_lsas_from_retransm_list),
4131 (ospf_lsa_remove_from_ls_retransmit):
4132 (ospf_lsa_retransmit): functions move to
4133 ospf_flood.c, and change function's name:
4134
4135 ospf_put_lsa_on_retransm_list ()
4136 -> ospf_ls_retransmit_add ()
4137 ospf_remove_lsa_from_retransm_list ()
4138 -> ospf_ls_retransmit_delete ()
4139 ospf_nbr_remove_all_lsas_from_retransm_list ()
4140 -> ospf_ls_retransmit_clear ()
4141 ospf_lsa_remove_from_ls_retransmit ()
4142 -> ospf_ls_retransmit_delete_nbr_all ()
4143 ospf_lsa_retransmit ()
4144 -> ospf_ls_retransmit_add_nbr_all ()
4145
4146 * ospf_lsa.c (ospf_lsa_lookup_from_list): function move to
4147 ospf_flood.c, and change name to ospf_ls_retransmit_lookup ().
4148
41491999-08-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4150
4151 * ospf_neighbor.c (ospf_nbr_lookup_by_addr): Use
4152 route_node_lookup() instead of route_node_get().
4153
4154 * ospf_packet.c (ospf_ls_upd): Temporary comment out (6) check.
4155
41561999-08-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4157
4158 * ospf_route.c (ospf_lookup_int_by_prefix): Add check of
4159 oi->address.
4160
41611999-08-29 Alex Zinin <zinin@amt.ru>
4162 * ospf_lsa.c
4163 MaxAge LSA deletion functions added.
4164
41651999-08-29 Alex Zinin <zinin@amt.ru>
4166 * ospf_neighbor.c
4167 ospf_nbr_lookup_by_addr(): added route_unlock_node()
4168 when function returns NULL if (rn->info == NULL)
4169
41701999-08-29 Alex Zinin <zinin@amt.ru>
4171 * ospfd.c
4172 added a hack for area range deletion
4173
41741999-08-29 Alex Zinin <zinin@amt.ru>
4175 * ospf_lsa.h
4176 included lsdb field into struct ospf_lsa, to find
4177 LSDB easier when removing MaxAge LSAs.
4178
41791999-08-29 Alex Zinin <zinin@amt.ru>
4180 * ospf_lsa.c ospf_neighbor.c ospf_nsm.c
4181 ospf_packet.c changed to honor new retransmit list
4182 management functions
4183
41841999-08-29 Alex Zinin <zinin@amt.ru>
4185 * ospf_neighbor.c , .h added new retransmit list functions.
4186
41871999-08-29 Alex Zinin <zinin@amt.ru>
4188 * Makefile.in
4189 added ospf_ase, ospf_abr, ospf_ia
4190
41911999-08-29 Alex Zinin <zinin@amt.ru>
4192 * ospf_spf.c:
4193 - changed ospf_next_hop_calculation() to include interface
4194 and nexthop addr for directly connected routers---more informative
4195 and solves problem with route installation into the kernel
4196 - changed ospf_nexthop_out_if_addr() to support routers, not only
4197 transit networks
4198 - added ospf_process_stubs();
4199
42001999-08-29 Alex Zinin <zinin@amt.ru>
4201 * ospf_lsa.c:
4202 - changed ospf_router_lsa() to provide correct links
4203 for p-t-p interfaces;
4204 - changed ospf_summary_lsa_install() to support table
4205 of self-originated summary-LSAs;
4206 - added ospf_summary_asbr_lsa_install() and ospf_external_lsa_install()
4207 - changed ospf_lsa_install() accordingly
4208 - changed show_ip_ospf_database_router_links() to support p-t-p
4209
42101999-08-29 Kunihiro Ishiguro <kunihiro@zebra.org>
4211
4212 * ospf_packet.c (ospf_make_db_desc): Only master can clear more
4213 flag.
4214
42151999-08-29 Kunihiro Ishiguro <kunihiro@zebra.org>
4216
4217 * ospf_packet.c (ospf_read): Add check of IP src address.
4218
42191999-08-28 Alex Zinin <zinin@amt.ru>
4220 * ospf_neighbor.h
4221 added ospf_nbr_lookup_by_routerid()
4222
42231999-08-28 Alex Zinin <zinin@amt.ru>
4224 * ospfd.h
4225 added ABR/ASBR flag definitions and fields;
4226 added iflist field to area structure;
4227 summary_lsa_self and summary_lsa_asbr_self are changed
4228 to be route tables;
4229 added ranges field---configured area ranges;
4230 A separate Routers RT added;
4231 area range config commands and config write added
4232
4233
42341999-08-28 Alex Zinin <zinin@amt.ru>
4235 * ospf_route.c :
4236 ospf_route_free()--added code to free the list of paths;
4237 The following functions added:
4238 ospf_intra_add_router();
4239 ospf_intra_add_transit();
4240 ospf_intra_add_stub();
4241 the last function uses new ospf_int_lookup_by_prefix();
4242 show_ip_ospf_route_cmd()--changed to support new RT structure;
4243 added ospf_cmp_routes()--general route comparision function;
4244 added ospf_route_copy_nexthops() and ospf_route_copy_nexthops_from_vertex()
4245 they are used in ASE and IA routing;
4246 added ospf_subst_route() and ospf_add_route();
4247
42481999-08-28 Alex Zinin <zinin@amt.ru>
4249 * ospf_route.h :
4250 changed struct ospf_path to include output interface,
4251 changed struct ospf_route to support IA and ASE routing.
4252 added prototypes of the function used in IA and ASE modules.
4253
42541999-08-28 Alex Zinin <zinin@amt.ru>
4255 * ospf_lsa.h ospf_lsa.c :
4256 added ospf_my_lsa(), an interface independent version of
4257 ospf_lsa_is_self_originated(), it will be used in ASE and IA-routing.
4258
42591999-08-27 Kunihiro Ishiguro <kunihiro@zebra.org>
4260
4261 * ospf_interface.c (interface_config_write): Add check for
4262 oi->nbr_self.
4263
42641999-08-25 Toshiaki Takada <takada@zebra.org>
4265
4266 * ospf_lsa.c (ospf_lsa_dup): New function added.
4267
4268 * ospf_packet.c (ospf_write), (ospf_read): Print send/recv
4269 interface in debug message.
4270
42711999-08-25 Toshiaki Takada <takada@zebra.org>
4272
4273 * ospf_packet.c (ospf_ls_ack_send): The name is changed from
4274 `ospf_ls_ack_send'.
4275 (ospf_ls_ack_send_delayed) (ospf_ls_ack_timer): New function added.
4276 Delayed Link State Acknowledgment is scheduled by timer.
4277
42781999-08-25 Alex Zinin <zinin@amt.ru>
4279
4280 * ospf_lsa.c (ospf_router_lsa): Incorrectly included link to
4281 a stub network instead of link to a transit network into
4282 originated router-LSA, bug fixed.
4283
42841999-08-24 Toshiaki Takada <takada@zebra.org>
4285
4286 * ospfd.c (ospf_update_router_id): New function added.
4287
4288 * ospf_network.c (ospf_write): Create new socket per transmission.
4289 And select outgoing interface whether dst is unicast or multicast.
4290
4291 * ospf_packet.c: LSA flooding will work.
4292
42931999-08-24 VOP <vop@unity.net>
4294
4295 * ospf_route.c: Include "sockunion.h"
4296
42971999-08-24 Kunihiro Ishiguro <kunihiro@zebra.org>
4298
4299 * ospf_network.c (ospf_serv_sock_init): Enclose
4300 IPTOS_PREC_INTERNETCONTROL setting with #ifdef for OS which does
4301 not have the definition.
4302
43031999-08-23 Toshiaki Takada <takada@zebra.org>
4304
4305 * ospf_packet.c: Fix bug of DD processing.
4306
43071999-08-18 Toshiaki Takada <takada@zebra.org>
4308
4309 * ospf_lsa.c (show_ip_ospf_database): Show actual `LS age'.
4310
43111999-08-17 Toshiaki Takada <takada@zebra.org>
4312
4313 * ospf_lsa.h (OSPF_MAX_LSA): The value of OSPF_MAX_LSA is
4314 corrected. The bug of `mes_lookup' is fixed.
4315 This had been reported by Poul-Henning Kamp <phk@freebsd.org>.
4316
4317 * ospf_lsa.c (ospf_router_lsa_install): The name is changed from
4318 `ospf_add_router_lsa'.
4319 (ospf_network_lsa_install): The name is changed from
4320 `ospf_add_network_lsa'.
4321
4322 * ospf_interface.h (ospf_interface): Add member `nbr_self'.
4323
4324 * ospf_interface.c (ospf_if_is_enable): New function added.
4325
43261999-08-16 Toshiaki Takada <takada@zebra.org>
4327
4328 * ospf_lsa.h (struct lsa_header): The name is changed from
4329 `struct ospf_lsa'.
4330 (struct ospf_lsa): New struct added to control each LSA's aging
4331 and timers.
4332
4333 * ospf_lsa.c (ospf_lsa_data_free): The name is change from
4334 `ospf_lsa_free'.
4335 (ospf_lsa_data_new), (ospf_lsa_new), (ospf_lsa_free),
4336 (ospf_lsa_different), (ospf_lsa_install): New function added.
4337
4338 * ospf_packet.c (ospf_ls_upd_list_lsa): New function added.
4339
43401999-08-12 Toshiaki Takada <takada@zebra.org>
4341
4342 * ospf_nsm.c (nsm_reset_nbr): New function added.
4343 KillNbr and LLDown neighbor event call this function.
4344
43451999-08-10 Toshiaki Takada <takada@zebra.org>
4346
4347 * ospf_packet.c (ospf_ls_retransmit)
4348 (ospf_ls_upd_timer): New function added.
4349 Set retransmission timer for Link State Update.
4350
43511999-07-29 Toshiaki Takada <takada@zebra.org>
4352
4353 * ospf_ism.c (ospf_dr_election): Fix bug of DR election.
4354
43551999-07-28 Toshiaki Takada <takada@zebra.org>
4356
4357 * ospf_network.c (ospf_serv_sock_init): Set IP precedence field
4358 with IPTOS_PREC_INTERNET_CONTROL.
4359
4360 * ospf_nsm.c (nsm_change_status): Schedule NeighborChange event
4361 if NSM status change.
4362
4363 * ospf_packet.c (ospf_make_hello): Never include a neighbor in
4364 Hello packet, when the neighbor goes down.
4365
43661999-07-26 Kunihiro Ishiguro <kunihiro@zebra.org>
4367
4368 * Makefile.am (noinst_HEADERS): Add ospf_route.h.
4369
4370 * ospf_route.c (show_ip_ospf_route): Add `show ip ospf route'
4371 command.
4372
43731999-07-25 Toshiaki Takada <takada@zebra.org>
4374
4375 * ospf_lsa.c (ospf_router_lsa): Fix bug of LS sequence number
4376 assignement.
4377
43781999-07-25 Kunihiro Ishiguro <kunihiro@zebra.org>
4379
4380 * ospf_route.c (ospf_route_table_free): New function added.
4381
4382 * ospf_spf.c (ospf_spf_next): Free vertex w when cw's and w's
4383 distance is same.
4384
4385 * ospfd.h (struct ospf): Add old_table.
4386
4387 * ospf_main.c (sighup): Call of log_rotate () removed.
4388
4389 * ospf_lsa.c (ospf_lsa_is_self_originated): Fix bug of checking
4390 area->lsa as self LSA. This should be area->lsa_self.
4391
43921999-07-24 Kunihiro Ishiguro <kunihiro@zebra.org>
4393
4394 * ospf_zebra.c (ospf_zebra_add): ospf_zebra_add
4395 (),ospf_zebra_delete () added.
4396
4397 * ospf_spf.c (ospf_spf_calculate): Call ospf_intra_route_add ().
4398
43991999-07-24 Toshiaki Takada <takada@zebra.org>
4400
4401 * ospf_lsa.c: Change LS sequence number treatment.
4402 (ospf_lsa_is_self_originated): New function added.
4403 (show_ip_ospf_database_self_originated): New DEFUN added.
4404
44051999-07-23 Kunihiro Ishiguro <kunihiro@zebra.org>
4406
4407 * ospf_interface.c (ospf_if_lookup_by_addr): Add loopback check.
4408
44091999-07-22 Toshiaki Takada <takada@zebra.org>
4410
4411 * ospf_spf.c (ospf_nexthop_new), (ospf_nexthop_free),
4412 (ospf_nexthop_dup): function added.
4413 (ospf_nexthop_calculation): function changed.
4414
4415 * ospf_interface.c (ospf_if_lookup_by_addr): function added.
4416
44171999-07-21 Toshiaki Takada <takada@zebra.org>
4418
4419 * ospf_spf.c (ospf_spf_closest_vertex): function removed.
4420
44211999-07-21 Kunihiro Ishiguro <kunihiro@zebra.org>
4422
4423 * ospf_spf.c (ospf_spf_next): Apply ntohs for fetching metric.
4424
44251999-07-21 Toshiaki Takada <takada@zebra.org>
4426
4427 * ospf_neighbor.c (ospf_nbr_lookup_by_router_id): fundtion removed.
4428
4429 * ospf_lsa.c (show_ip_ospf_database_router): describe each
4430 connected link.
4431
44321999-07-21 Kunihiro Ishiguro <kunihiro@zebra.org>
4433
4434 * ospf_spf.c (ospf_spf_next): V is router LSA or network LSA so
4435 change behavior according to LSA type.
4436 (ospf_lsa_has_link): Link check function is added.
4437
44381999-07-20 Kunihiro Ishiguro <kunihiro@zebra.org>
4439
4440 * ospf_spf.c (ospf_spf_calculate_schedule): Add new function for
4441 SPF calcultion schedule addtition.
4442 (ospf_spf_calculate_timer_add): Rough 30 sec interval SPF calc
4443 timer is added.
4444 (ospf_spf_next_router): Delete ospf_spf_next_network ().
4445
4446 * ospf_lsa.c (show_ip_ospf_database_all): Network-LSA display
4447 header typo correction. Display of router LSA's #link added.
4448
44491999-07-19 Toshiaki Takada <takada@zebra.org>
4450
4451 * ospf_packet.c (ospf_check_network_mask): Added new function for
4452 receiving Raw IP packet on an appropriate interface.
4453
44541999-07-16 Toshiaki Takada <takada@zebra.org>
4455
4456 * ospfd.c (ospf_router_id): new DEFUN added.
4457
44581999-07-15 Toshiaki Takada <takada@zebra.org>
4459
4460 * ospf_spf.c (ospf_spf_init), (ospf_spf_free),
4461 (ospf_spf_has_vertex), (ospf_vertex_lookup),
4462 (ospf_spf_next_router), (ospf_spf_next_network),
4463 (ospf_spf_closest_vertex), (ospf_spf_calculate):
4464 function added.
4465
44661999-07-13 Toshiaki Takada <takada@zebra.org>
4467
4468 * ospf_ism.c: fix bug of DR Election.
4469
4470 * ospf_nsm.c: fix bug of adjacency forming.
4471
44721999-07-05 Kunihiro Ishiguro <kunihiro@zebra.org>
4473
4474 * ospfd.c (ospf_init): Change to use install_default.
4475
44761999-07-01 Rick Payne <rickp@rossfell.co.uk>
4477
4478 * ospf_zebra.c (zebra_init): Install standard commands to
4479 ZEBRA_NODE.
4480
44811999-06-30 Toshiaki Takada <takada@zebra.org>
4482
4483 * ospf_dump.c: Whole debug command is improved.
4484 (ISM|NSM) (events|status|timers) debug option added.
4485 (show_debugging_ospf): new DEFUN added.
4486
44871999-06-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4488
4489 * ospf_lsa.c (ospf_lsa_lookup_from_list): Change !IPV4_ADDR_CMP to
4490 IPV4_ADDR_SAME.
4491
44921999-06-29 Toshiaki Takada <takada@zebra.org>
4493
4494 * ospf_dump.c (ospf_summary_lsa_dump): Add summary-LSA dump routine.
4495 (ospf_as_external_lsa_dump): Add AS-external-LSA dump routine.
4496
4497 * ospf_nsm.c (nsm_twoway_received): fix condtion of adjacnet.
4498
4499 * ospf_ism.c (ospf_dr_election): fix DR Election.
4500
4501 * ospf_dump.c (ospf_nbr_state_message): fix `show ip ospf neighbor'
4502 command's state.
4503
45041999-06-29 Kunihiro Ishiguro <kunihiro@zebra.org>
4505
4506 * ospf_dump.c (ospf_router_lsa_dump): Add router-LSA dump routine.
4507
45081999-06-28 Toshiaki Takada <takada@zebra.org>
4509
4510 * ospf_lsa.c (show_ip_ospf_database_network): fix bug of
4511 `show ip ospf database network' command output.
4512
4513 * ospf_nsm.c (nsm_inactivity_timer): Clear list of Link State
4514 Retransmission, Database Summary and Link State Request.
4515
4516 * ospf_packet.c (ospf_ls_req_timer): New function added.
4517 Set Link State Request retransmission timer.
4518
45191999-06-27 Kunihiro Ishiguro <kunihiro@zebra.org>
4520
4521 * ospf_main.c (main): Change default output from ZLOG_SYSLOG to
4522 ZLOG_STDOUT.
4523
4524 * ospfd.c (ospf_init): Register show_ip_ospf_interface_cmd and
4525 show_ip_ospf_neighbor_cmd to VIEW_NODE.
4526
4527 * ospf_lsa.c (ospf_lsa_init): Register show_ip_ospf_database_cmd
4528 and show_ip_ospf_database_type_cmd to VIEW_NODE.
4529
45301999-06-25 Toshiaki Takada <takada@zebra.org>
4531
4532 * ospf_packet.c: fix bug of DD making.
4533 fix bug of LS-Update reading.
4534
45351999-06-23 Toshiaki Takada <takada@zebra.org>
4536
4537 * ospf_packet.c: All type of packets are changed to use
4538 fifo queue structure.
4539 (ospf_fill_header) function added.
4540
45411999-06-22 Toshiaki Takada <takada@zebra.org>
4542
4543 * ospf_packet.c (ospf_packet_new): New function added to handle
4544 sending ospf packet by fifo queue structure.
4545 (ospf_packet_free), (ospf_fifo_new), (ospf_fifo_push),
4546 (ospf_fifo_pop), (ospf_fifo_head), (ospf_fifo_flush),
4547 (ospf_fifo_free): Likewise.
4548
45491999-06-21 Toshiaki Takada <takada@zebra.org>
4550
4551 * ospf_nsm.c (ospf_db_desc_timer): function added.
4552 (nsm_timer_set) function added.
4553 * ospf_dump.c (ospf_option_dump): function added.
4554 * ospf_packet.c (ospf_ls_req) (ospf_make_ls_req): function added.
4555
45561999-06-20 Toshiaki Takada <takada@zebra.org>
4557
4558 * ospf_lsa.c (ospf_lsa_more_recent): function added.
4559 * ospf_neighbor.h (struct ospf_neighbor): Change member ms_flag
4560 to dd_flags.
4561
45621999-06-19 Toshiaki Takada <takada@zebra.org>
4563
4564 * ospf_lsa.c: DEFUN (show_ip_ospf_database) Added.
4565 * ospf_interface.c (if_ospf_cost), (if_ospf_dead_interval),
4566 (if_ospf_hello_interval), (if_ospf_priority),
4567 (if_ospf_retransmit_interval), (if_ospf_transmit_delay)
4568 argument changed from NUMBER to <range>.
4569 DEFUN (if_ospf_network_broadcast),
4570 DEFUN (if_ospf_network_non_broadcast),
4571 DEFUN (if_ospf_network_point_to_multipoint),
4572 DEFUN (if_ospf_network_point_to_point) functions are combined to
4573 DEFUN (if_ospf_network).
4574
45751999-06-18 Toshiaki Takada <takada@zebra.org>
4576
4577 * ospf_lsa.c: ospf_add_router_lsa (), ospf_add_network_lsa (),
4578 ospf_lsa_lookup (), ospf_lsa_count () Added.
4579
45801999-06-15 Toshiaki Takada <takada@zebra.org>
4581
4582 * DEFUN (ospf_debug_ism), DEFUN (ospf_debug_nsm),
4583 DEFUN (no_ospf_debug_ism), DEFUN (no_ospf_debug_nsm) Added.
4584 `debug ospf ism' command shows debug message.
4585 `debuf ospf nsm' command shows debug message.
4586
45871999-06-14 Toshiaki Takada <takada@zebra.org>
4588
4589 * ospf_lsa.c: ospf_network_lsa () Added.
4590 ospf_lsa_checksum () Added.
4591 * DEFUN (ospf_debug_packet), DEFUN (no_ospf_debug_packet) Added.
4592 `debug ospf packet' command shows debug message.
4593
45941999-06-13 Toshiaki Takada <takada@zebra.org>
4595
4596 * ospf_packet.h: Remove struct ospf_ls_req {}, ospf_ls_upd {},
4597 ospf_ls_ack {}.
4598
45991999-06-11 Toshiaki Takada <takada@zebra.org>
4600
4601 * ospf_dump.c: fix IP packet length treatment.
4602
46031999-06-10 Toshiaki Takada <takada@zebra.org>
4604
4605 * ospf_ism.h: Add OSPF_ISM_EVENT_EXECUTE() Macro Added.
4606 * ospf_nsm.h: Add OSPF_NSM_EVENT_EXECUTE() Macro Added.
4607
4608 * ospf_packet.c: ospf_db_desc (), ospf_db_desc_send () Added.
4609 ospf_make_hello (), ospf_make_db_desc () Added.
4610 ospf_db_desc_proc () Added.n
4611
4612 * Database Description packet can be processed.
4613
46141999-06-08 Toshiaki Takada <takada@zebra.org>
4615
4616 * ospf_lsa.c: New file.
4617
46181999-06-07 Toshiaki Takada <takada@zebra.org>
4619
4620 * ospf_neighbor.c: ospf_fully_adjacent_count () Added.
4621
46221999-06-07 Kunihiro Ishiguro <kunihiro@zebra.org>
4623
4624 * ospf_spf.[ch]: New file.
4625
46261999-05-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4627
4628 * ospf_zebra.c: Changed to use lib/zclient.c routines.
4629
4630 * ospf_zebra.h (zebra_start): Remove struct zebra.
4631
46321999-05-29 Kunihiro Ishiguro <kunihiro@zebra.org>
4633
4634 * ospfd.c (ospf_config_write): Add cast (unsigned long int) to
4635 ntohl for sprintf warning.
4636
46371999-05-19 Toshiaki Takada <takada@zebra.org>
4638
4639 * ospf_ism.c (ospf_dr_election): Join AllDRouters Multicast group
4640 if interface state changes to DR or BDR.
4641
46421999-05-14 Stephen R. van den Berg <srb@cuci.nl>
4643
4644 * ospf_main.c (signal_init): SIGTERM call sigint.
4645 (sigint): Logging more better message.
4646
46471999-05-12 Toshiaki Takada <takada@zebra.org>
4648
4649 * ospfd.c: Fix bug of `no router ospf' statement, it will work.
4650
46511999-05-11 Toshiaki Takada <takada@zebra.org>
4652
4653 * ospf_neighbor.c: ospf_nbr_free () Added.
4654
46551999-05-10 Toshiaki Takada <takada@zebra.org>
4656
4657 * ospfd.h: struct ospf_area { }, struct ospf_network { } Changed.
4658 * Fix bug of `no network' statement, it will work.
4659
46601999-05-07 Toshiaki Takada <takada@zebra.org>
4661
4662 * ospf_interface.c, ospf_zebra.c: Fix bug of last interface is not
4663 updated by ospf_if_update ().
4664
46651999-04-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4666
4667 * Makefile.am (noinst_HEADERS): Add ospf_lsa.h for distribution.
4668
46691999-04-25 Toshiaki Takada <takada@zebra.org>
4670
4671 * ospf_interface.c: DEFUN (no_if_ospf_cost),
4672 DEFUN (no_if_ospf_dead_interval),
4673 DEFUN (no_if_ospf_hello_interval),
4674 DEFUN (no_if_ospf_priority),
4675 DEFUN (no_if_ospf_retransmit_interval),
4676 DEFUN (no_if_ospf_transmit_delay) Added.
4677
4678 interface_config_write () suppress showing interface
4679 default values.
4680
46811999-04-25 Kunihiro Ishiguro <kunihiro@zebra.org>
4682
4683 * ospf_dump.c (ospf_timer_dump): If thread is NULL return "inactive".
4684
4685 * ospfd.c (ospf_if_update): Fix bug of using ospf_area { } instead
4686 of ospf_network { }. So `router ospf' statement in ospfd.conf
4687 works again.
4688 (ospf_if_update): Call ospf_get_router_id for updating router ID.
4689
46901999-04-25 Toshiaki Takada <takada@zebra.org>
4691
4692 * ospf_interface.c: DEFUN (if_ospf_network) deleted.
4693 DEFUN (if_ospf_network_broadcast),
4694 DEFUN (if_ospf_network_non_broadcast),
4695 DEFUN (if_ospf_network_point_to_multipoint),
4696 DEFUN (if_ospf_network_point_to_point),
4697 DEFUN (no_if_ospf_network) Added.
4698
46991999-04-23 Toshiaki Takada <takada@zebra.org>
4700
4701 * ospfd.h: struct area { } changed to struct ospf_network { }.
4702 Add struct ospf_area { }.
4703 * ospfd.c: Add ospf_area_lookup_by_area_id (), ospf_network_new (),
4704 and ospf_network_free ().
4705 DEFUN (area_authentication), DEFUN (no_area_authentication) Added.
4706
47071999-04-22 Toshiaki Takada <takada@zebra.org>
4708
4709 * ospf_lsa.h: New file.
4710 * ospf_packet.h: LSA related struct definition are moved to
4711 ospf_lsa.h.
4712 * ospf_packet.c: ospf_verify_header () Added.
4713
47141999-04-21 Toshiaki Takada <takada@zebra.org>
4715
4716 * ospf_ism.c: ospf_elect_dr () and related function is changed.
4717 DR Election bug fixed.
4718 * ospf_dump.c: ospf_nbr_state_message (), ospf_timer_dump () Added.
4719 * ospfd.c: DEFUN (show_ip_ospf_neighbor) Added.
4720
47211999-04-19 Kunihiro Ishiguro <kunihiro@zebra.org>
4722
4723 * ospf_main.c (main): access_list_init () is added for vty
4724 connection filtering.
4725
47261999-04-16 Toshiaki Takada <takada@zebra.org>
4727
4728 * ospfd.c: DEFUN (show_ip_ospf_interface) Added.
4729 * ospf_neighbor.c: ospf_nbr_count () Added.
4730
47311999-04-15 Toshiaki Takada <takada@zebra.org>
4732
4733 * ospfd.h: struct ospf { } Changed.
4734 * ospfd.c: ospf_lookup_by_process_id () Deleted.
4735 * ospf_ism.c: ospf_wait_timer () Added. WaitTimer will work.
4736
47371999-04-14 Toshiaki Takada <takada@zebra.org>
4738
4739 * ospf_ism.c: ospf_elect_dr () Added.
4740 * ospf_network.c: ospf_if_ipmulticast () Added.
4741
47421999-04-11 Toshiaki Takada <takada@zebra.org>
4743
4744 * ospf_interface.c: interface_config_write (),
4745 DEFUN (if_ip_ospf_cost),
4746 DEFUN (if_ip_ospf_dead_interval),
4747 DEFUN (if_ip_ospf_hello_interval),
4748 DEFUN (if_ip_ospf_priority),
4749 DEFUN (if_ip_ospf_retransmit_interval) and
4750 DEFUN (if_ip_ospf_transmit_delay) Added.
4751
47521999-04-08 Toshiaki Takada <takada@zebra.org>
4753
4754 * ospf_dump.c: ospf_packet_db_desc_dump () Added.
4755 * ospf_neighbor.c: ospf_nbr_bidirectional () Added.
4756 * ospf_nsm.c: nsm_twoway_received () Added.
4757
47581999-04-02 Toshiaki Takada <takada@zebra.org>
4759
4760 * ospf_neighbor.c: New file.
4761 * ospf_neighbor.h: New file.
4762 * ospf_nsm.c: New file.
4763 * ospf_nsm.h: New file.
4764 * ospf_packet.c: Add ospf_make_header (), ospf_hello () and
4765 ospf_hello_send (). Now OSPFd can receive Hello and send Hello.
4766
47671999-03-27 Kunihiro Ishiguro <kunihiro@zebra.org>
4768
4769 * ospf_packet.c: Add ospf_recv_packet (). Now OSPF Hello can receive.
4770
47711999-03-19 Toshiaki Takada <takada@zebra.org>
4772
4773 * ospf_packet.c: New file.
4774 * ospf_packet.h: New file.
4775 * ospf_network.c: New file.
4776 * ospf_network.h: New file.
4777 * ospfd.h: move OSPF message structure has moved to ospf_packet.h.
4778
47791999-03-17 Kunihiro Ishiguro <kunihiro@zebra.org>
4780
4781 * ospf_zebra.c (ospf_zebra_get_interface): Fix for IPv6 interface
4782 address.
4783
4784 * Makefile.am (install-sysconfDATA): Overwrite install-sysconfDATA
4785 for install ospfd.conf.sample as owner read only file.
4786
4787 * ospf_main.c (usage): Change to use ZEBRA_BUG_ADDRESS.
4788
47891999-03-15 Toshiaki Takada <takada@zebra.org>
4790
4791 * ospf_ism.c: New file.
4792 * ospf_ism.h: New file.
4793 * ospf_dump.c: New file.
4794 * ospf_dump.h: New file.
4795
4796 * ospfd.h: Add (struct ospf), (struct config_network),
4797 (struct message) structure.
4798
4799 * ospf_interface.c: Add ospf_if_match_network ().
4800 * ospf_interface.h (struct ospf_interface): Change struct members.
4801
4802 * ospfd.c: ospf_lookup_by_process_id (), ospf_network_new (),
4803 DEFUN (network_area): Added.
4804
4805 * ospfd.conf.sample: Change sample configuration.
4806
48071999-03-05 Toshiaki Takada <takada@zebra.org>
4808
4809 * ospf_interface.c: New file.
4810 * ospf_interface.h: New file.
4811 * ospf_zebra.h: New file.
4812 * ospf_zebra.c: Add interface function for zebra daemon.
4813 * ospfd.c: New file.
4814
48151999-02-23 Kunihiro Ishiguro <kunihiro@zebra.org>
4816
4817 * Move IPv6 codes and files to ospf6d directory.
4818
48191999-02-18 Peter Galbavy <Peter.Galbavy@knowledge.com>
4820
4821 * syslog support added
4822
48231998-12-22 Toshiaki Takada <takada@zebra.org>
4824
4825 * ospfd.h: New file.
4826 * ospf_lsa.h: New file.
4827
48281998-12-15 Kunihiro Ishiguro <kunihiro@zebra.org>
4829
4830 * Makefile.am: New file.
4831 * ospf_main.c: New file.
4832