blob: b2191d4836bdfcf99e2126da8e7f7d08f21f054c [file] [log] [blame]
Paul Jakmab2497022007-06-14 11:17:58 +000012007-05-25 Paul Jakma <paul.jakma@sun.com>
2
3 * bgp_route.c: (bgp_default_originate) Sanity check added
4 previously was broken and always failed, thus this function
5 never could run, bug #370.
6
Paul Jakmafb982c22007-05-04 20:15:47 +000072007-05-03 Paul Jakma <paul.jakma@sun.com>
Paul Jakma923de652007-04-29 18:25:17 +00008
Paul Jakmafb982c22007-05-04 20:15:47 +00009 * bgp_route.h: (struct info) Move less frequently used
10 fields to a lazily allocated struct info_extra.
11 Export bgp_info_extra_get
12 * bgp_route.c: (bgp_info_extra_new) allocate extra
13 (bgp_info_extra_free) Free damp info and the info_extra.
14 (bgp_info_extra_get) Retrieve the info_extra of a struct
15 info, allocating as required.
16 (generally) adjust to use info->extra
17 * bgp_damp.c: (generally) use bgp_info_extra_get to access
18 dampinfo
19 * bgp_attr.h: Move rarely allocated attributes from struct attr
20 to a struct attr_extra, for a substantial saving in size of
21 struct attr.
22 * bgp_attr.c: (bgp_attr_extra_{new,free}), new, self-explanatory.
23 (bgp_attr_extra_get) Get the attr_extra for a given struct
24 attr, allocating it if needs be.
25 (bgp_attr_dup) Shallow copy the struct attr and its attr_extra.
26 (generally) adjust to know about attr->extra.
27 * bgp_debug.c: (bgp_dump_attr) ditto
28 * bgp_vty.c: (show_bgp_memory) print attr and info extra sizes.
29 * bgp_nexthop.c: (generally) adjust to know about attr->extra
30 and info->extra.
31 * bgp_{packet,routemap,snmp,zebra}.c: ditto
32
332007-04-22 Sebastien Tandel <sebastien@tandel.be>
Paul Jakma923de652007-04-29 18:25:17 +000034 * bgp_advertise.c : (baa_hash_alloc, baa_hash_key, baa_hash_cmp)
35 conforms to quagga hash API. Defines _hash_[alloc|key|cmp] with
36 void * arguments as defined by the API.
37 * bgp_aspath.c,h : (aspath_key_make) conforms to quagga hash API.
38 Defines _hash_[alloc|key|cmp] with void * arguments as defined by
39 the API.
40 * bgp_attr.c,h : (cluster_hash_alloc, cluster_hash_key_make,
41 cluster_hash_cmp, transit_hash_alloc, transit_hash_key_make,
42 transit_hash_cmp, attrhash_key_make, attrhash_cmp,
43 bgp_attr_hash_alloc) conforms to quagga hash API. Defines
44 _hash_[alloc|key|cmp] with void * arguments as defined by the API.
Paul Jakma03e214c2007-04-29 18:31:07 +000045 * bgp_attr.h : Definition of BGP_ATTR_DEFAULT_WEIGHT.
46 * bgp_attr.c : (bgp_attr_default_intern) now uses
47 bgp_attr_default_set instead of duplicating the same code.
48 (general) Use of BGP_ATTR_DEFAULT_WEIGHT. Replace two 16 by
49 IPV6_MAX_BYTELEN.
Paul Jakma923de652007-04-29 18:25:17 +000050
Andrew J. Schorr93c17492007-04-15 19:17:24 +0000512007-04-15 Sebastien Tandel <sebastien@tandel.be>
52
53 * bgp_aspath.c: (aspath_as_add, aspath_segment_add) Minor performance
54 optimization: while loop should test one pointer instead of two.
55
Paul Jakma16d2e242007-04-10 19:32:10 +0000562007-04-08 Paul Jakma <paul.jakma@sun.com>
57
58 * bgp_route.c: (general) Same bug as fixed on 2006-11-28 by ajs for
59 bgp static routes, but for main BGP RIB: Quick 'flap' of routes
60 can cause bgpd to mistake a new route for a duplicate route,
61 due to presence of removed, but not yet processed BGP RIB entry.
62 (bgp_update_rsclient) Ignore REMOVED bgp_info for duplicate,
63 restore route instead.
64 (bgp_update_main) Ditto.
Paul Jakma6e4ab122007-04-10 19:36:48 +000065 * bgp_attr.c: (general) Bug #354: parsing of MP_REACH_NLRI and
66 MP_UNREACH_NLRI does not take sufficient care to ensure reads
67 from stream buffer stay in-bounds. Hence bgpd may attempt to read
68 beyond end of stream, if given a crafted packet. As it uses the
69 stream access methods to do so, this will typically result in
70 assert() being hit in stream.c. Where code is compiled without
71 assert() enabled, result is unknown.
72 (struct message attr_str) should be static.
73 (bgp_mp_reach_parse) Carefully check length remaining in stream
74 against amount desired to read from stream, prior to each read,
75 particularly where lengths are conditional on data obtained from
76 stream - using STREAM_READABLE.
77 Remove code to parse SNPA-number, it's a defunct field and changed
78 to a fixed size in latest BGP MP update RFC - log warning if
79 SNPA-number is not 0.
80 (bgp_mp_unreach_parse) Check withdraw_length carefully against
81 STREAM_READABLE.
82 (bgp_attr_parse) If attribute-parser function returns error, log
83 warning.
84 Log attribute type on mismatch.
Paul Jakma16d2e242007-04-10 19:32:10 +000085
Paul Jakma37a217a2007-04-10 19:20:29 +0000862007-04-07 Paul Jakma <paul.jakma@sun.com>
87
88 * bgpd.c: (general) Fix bug #352
89 (bgp_config_write_family_header) write ipv6/multicast
90 address family header.
91 (bgp_config_write) write out ipv6 multicast AF config.
92
Paul Jakmaf2c31ac2007-02-22 17:48:42 +0000932007-02-22 Paul Jakma <paul.jakma@sun.com>
94
95 * bgp_fsm.c: (bgp_fsm_change_status) Handle state change into
96 clearing or greater here. Simpler.
97 (bgp_event) Clearing state change work moved to previous
98 * bgp_route.c: (bgp_clear_route_node) Clearing adj-in here
99 is too late, as it leaves a race between a peer being deleted
100 and an identical peer being configured before clearing
101 completes, leading to a crash.
102 Simplest fix is to clean peers Adj-in up-front, rather than
103 queueing such work.
104 (bgp_clear_route_table) Clear peer's Adj-In and Adj-Out
105 up-front here, rather than queueing such work.
106 Extensive comment added on the various bits of indexed data
107 that exist and how they need to be dealt with.
108 (bgp_clear_route) Update comment.
109
Andrew J. Schorre4529632006-12-12 19:18:21 +00001102006-12-12 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
111
112 * bgp_nexthop.c: (bgp_connected_add, bgp_connected_delete)
113 Simplify logic by using new CONNECTED_PREFIX macro.
114
Paul Jakma95fdcd82006-12-08 00:31:22 +00001152006-12-07 Paul Jakma <paul.jakma@sun.com>
116
117 * bgp_fsm.c: Bug #302 fix, diagnosis, suggestions and testing
118 by Juergen Kammer <j.kammer@eurodata.de>. Fix follows from
119 his suggested fix, just made in a slightly different way.
120 (bgp_event) Transitions into Clearing always must call
121 bgp_clear_route_all().
122 (bgp_stop) No need to clear routes here, BGP FSM should do
123 it.
124
Andrew J. Schorra39275d2006-11-30 16:36:57 +00001252006-11-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
126
127 * bgp_debug.h: Declare new bgp_debug_zebra conf and term flags,
128 and define BGP_DEBUG_ZEBRA.
129 * bgp_debug.c: Declare conf_bgp_debug_zebra and term_bgp_debug_zebra.
130 (debug_bgp_zebra, no_debug_bgp_zebra, undebug_bgp_zebra) New
131 functions to enable/disable bgp zebra debugging.
132 (no_debug_bgp_all) Turn off zebra debugging.
133 (show_debugging_bgp) Show whether zebra debugging is on.
134 (bgp_config_write_debug) Add 'debug bgp zebra' if configured.
135 (bgp_debug_init) Add new zebra debugging commands.
136 * bgp_zebra.c: (bgp_router_id_update, bgp_interface_add,
137 bgp_interface_delete, bgp_interface_up, bgp_interface_down,
138 bgp_interface_address_add, bgp_interface_address_delete,
139 zebra_read_ipv4, zebra_read_ipv6, bgp_zebra_announce,
140 bgp_zebra_withdraw, bgp_redistribute_set, bgp_redistribute_unset)
141 If zebra debugging is enabled, log an appropriate debug message.
142
Andrew J. Schorr8d452102006-11-28 19:50:46 +00001432006-11-28 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
144
145 * bgp_route.c: (bgp_info_restore) New function that undoes
146 the effects of a previous call to bgp_info_delete. This is
147 used when a route is deleted and quickly re-added before the
148 deletion has been processed.
149 (bgp_static_update_rsclient, bgp_static_update_main,
150 bgp_redistribute_add) Check whether a pre-existing route
151 has the BGP_INFO_REMOVED set, and, if so, we need to call
152 bgp_info_restore to resurrect it.
153
Paul Jakma56395af2006-10-27 16:58:20 +00001542006-10-27 Paul Jakma <paul.jakma@sun.com>
155
156 * bgp_route.c: (bgp_table_stats) oops, u_intXX_t should be
157 uintXX_t
158
Paul Jakma6f585442006-10-22 19:13:07 +00001592006-10-19 Paul Jakma <paul.jakma@sun.com>
160
161 * bgpd.c: (peer_new) bgp element of peer absolutely must be
162 filled in, make peer_new() require it as argument and update
163 all callers. Fixes a crash reported by Jan 'yanek' Bortl and
164 Andrew Schorr where bgpd would crash in bgp_pcount_adjust
165 trying to dereference the bgp member of bgp->peer_self,
166 triggered through redistribution.
167 * bgp_route.c: (bgp_pcount_adjust) assert sanity of arguments.
168
Paul Jakma53d9f672006-10-15 23:41:16 +00001692006-10-15 Paul Jakma <paul.jakma@sun.com>
170
171 * bgp_route.c: (bgp_table_stats_walker) NULL deref if table is
172 empty, bgp_table_top may return NULL, Coverity CID#73.
Paul Jakmaed3ebfa2006-10-15 23:50:16 +0000173 * bgp_packet.c: (bgp_update_packet) adv->rn can not be NULL,
174 check is bogus - changed to assert(), CID#64.
175 binfo is checked for NULL, but then dereferenced
176 unconditionally, fix, CID #63.
177 (bgp_withdraw_packet) Assert adv->rn is valid, as with
178 bgp_update_packet().
Paul Jakma53d9f672006-10-15 23:41:16 +0000179
Paul Jakmadcdf3992006-10-15 23:39:59 +00001802006-10-14 Paul Jakma <paul.jakma@sun.com>
181
182 * bgp_fsm.h: Remove BGP_EVENT_FLUSH_ADD, dangerous and not
183 needed.
184 * bgp_fsm.c: (bgp_stop) Move BGP_EVENT_FLUSH to the top of the
185 of the function, otherwise it could flush a ClearingCompleted
186 event, bug #302.
187 * bgp_packet.c: Replace all BGP_EVENT_FLUSH_ADD with
188 BGP_EVENT_ADD, fixing bug #302.
189
Andrew J. Schorr0cd1c322006-09-19 18:51:53 +00001902006-09-19 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
191
192 * bgpd.c: (peer_uptime) Fix printf format/arg mismatch in
193 zlog_warn message (%ld/size_t -> %lu/u_long).
194
Paul Jakmaca058a32006-09-14 02:58:49 +00001952006-09-14 Paul Jakma <paul.jakma@sun.com>
196
Paul Jakma8383a9b2006-09-14 03:06:54 +0000197 * bgp_route.c: (bgp_table_stats_walker) Address space announced
198 should only count top-level unaggregateable prefixes, to
199 avoid falling afoul of anti-dodgy-accounting regulations
200 in various jurisdictions.. ;)
Paul Jakma09dd5612006-09-14 03:38:16 +0000201 (bgp_process_queue_init) process queue hold time too high,
202 adds extra memory load. Change to be much lower, until such
203 time as it's made configurable.
Paul Jakma8383a9b2006-09-14 03:06:54 +0000204
2052006-09-14 Paul Jakma <paul.jakma@sun.com>
206
Paul Jakma9fde6622006-09-14 03:02:02 +0000207 * (general) fix the peer refcount issue exposed by previous, by
208 just removing refcounting of peer threads, which is mostly
209 senseless as they're references leading from struct peer,
210 which peer_free cancels anyway. No need to muck around..
211 * bgp_fsm.h: Just remove the refcounting from the various
212 TIMER/READ/WRITE/EVENT ON/OFF/ADD macros.
213 * bgp_fsm.c: (bgp_stop) use BGP_EVENT_FLUSH, no refcounts attached
214 to events anymore.
215 (bgp_event) remove peer_unlock, events not refcounted.
216 * bgpd.c: (peer_free) flush events before free.
217
2182006-09-14 Paul Jakma <paul.jakma@sun.com>
219
Paul Jakmaca058a32006-09-14 02:58:49 +0000220 * (general) Fix some niggly issues around 'shutdown' and clearing
221 by adding a Clearing FSM wait-state and a hidden 'Deleted'
222 FSM state, to allow deleted peers to 'cool off' and hit 0
223 references. This introduces a slow memory leak of struct peer,
224 however that's more a testament to the fragility of the
225 reference counting than a bug in this patch, cleanup of
226 reference counting to fix this is to follow.
227 * bgpd.h: Add Clearing, Deleted states and Clearing_Completed
228 and event.
229 * bgp_debug.c: (bgp_status_msg[]) Add strings for Clearing and
230 Deleted.
231 * bgp_fsm.h: Don't allow timer/event threads to set anything
232 for Deleted peers.
233 * bgp_fsm.c: (bgp_timer_set) Add Clearing and Deleted. Deleted
234 needs to stop everything.
235 (bgp_stop) Remove explicit fsm_change_status call, the
236 general framework handles the transition.
237 (bgp_start) Log a warning if a start is attempted on a peer
238 that should stay down, trying to start a peer.
239 (struct .. FSM) Add Clearing_Completed
240 events, has little influence except when in state
241 Clearing to signal wait-state can end.
242 Add Clearing and Deleted states, former is a wait-state,
243 latter is a placeholder state to allow peers to disappear
244 quietly once refcounts settle.
245 (bgp_event) Try reduce verbosity of FSM state-change debug,
246 changes to same state are not interesting (Established->Established)
247 Allow NULL action functions in FSM.
248 * bgp_packet.c: (bgp_write) Use FSM events, rather than trying
249 to twiddle directly with FSM state behind the back of FSM.
250 (bgp_write_notify) ditto.
251 (bgp_read) Remove the vague ACCEPT_PEER peer_unlock, or else
252 this patch crashes, now it leaks instead.
253 * bgp_route.c: (bgp_clear_node_complete) Clearing_Completed
254 event, to end clearing.
255 (bgp_clear_route) See extensive comments.
256 * bgpd.c: (peer_free) should only be called while in Deleted,
257 peer refcounting controls when peer_free is called.
258 bgp_sync_delete should be here, not in peer_delete.
259 (peer_delete) Initiate delete.
260 Transition to Deleted state manually.
261 When removing peer from indices that provide visibility of it,
262 take great care to be idempotent wrt the reference counting
263 of struct peer through those indices.
264 Use bgp_timer_set, rather than replicating.
265 Call to bgp_sync_delete isn't appropriate here, sync can be
266 referenced while shutting down and finishing deletion.
267 (peer_group_bind) Take care to be idempotent wrt list references
268 indexing peers.
269
Paul Jakma2815e612006-09-14 02:56:07 +00002702006-09-13 Paul Jakma <paul.jakma@sun.com>
271
272 * bgp_aspath.c: (aspath_highest) new, return highest ASN in an
273 aspath.
274 * bgp_route.c: (bgp_peer_count_walker) new, do the walk done
275 in bgp_peer_counts as a thread.
276 (bgp_peer_counts) move walk to previous and call it via
277 thread_execute so this RIB walk shows up in thread stats.
278 (bgp_table_stats) New, gather some statistics for a given
279 RIB.
280 (bgp_table_stats_walker) New, RIB walker thread for former.
281 (bgp_table_stats_vty) Parsing front-end for 'show bgp ...',
282 useful model for future rationalisation of 'show ... bgp'.
283 (bgp_route_init) Add new RIB stats commands.
284
Paul Jakma1a392d42006-09-07 00:24:49 +00002852006-09-06 Paul Jakma <paul.jakma@sun.com>
286
287 * (general) Squash any and all prefix-count issues by
288 abstracting route flag changes, and maintaining count as and
289 when flags are modified (rather than relying on explicit
290 modifications of count being sprinkled in just the right
291 places throughout the code).
292 * bgp_route.c: (bgp_pcount_{dec,inc}rement) removed.
293 (bgp_pcount_adjust) new, update prefix count as
294 needed for a given route.
295 (bgp_info_{uns,s}et_flag) set/unset a BGP_INFO route status
296 flag, calling previous function when appropriate.
297 (general) Update all set/unsets of flags to use previous.
298 Remove pcount_{dec,inc}rement calls.
299 No need to unset BGP_INFO_VALID in places where
300 bgp_info_delete is called, it does that anyway.
301 * bgp_{damp,nexthop}.c: Update to use bgp_info_{un,}set_flag.
302 * bgp_route.h: Export bgp_info_{un,}set_flag.
303 Add a 'meta' BGP_INFO flag, BGP_INFO_UNUSEABLE.
304 Move BGP_INFO_HOLDDOWN macro to here from bgpd.h
305
Paul Jakmaff7924f2006-09-04 01:10:36 +00003062006-09-03 Paul Jakma <paul.jakma@sun.com>
307
308 * bgp_route.c: Add 'show ... bgp ... <neighbour> prefix-count'
309 commands, to provide detailed counts of prefixes for a peer.
310 Informative, and should help pin down to pfxcnt drift
311 problems.
312
Paul Jakma9f906c72006-08-27 06:57:47 +00003132006-08-27 Paul Jakma <paul.jakma@sun.com>
314
315 * bgp_advertise.c: (bgp_sync_delete) fix mtype in XFREE.
316 NULL out peer->hash after free, to be sure.
317
Paul Jakma1f742f22006-08-06 15:52:11 +00003182006-08-06 Paul Jakma <paul.jakma@sun.com>
319
320 * bgp_aspath.c: (aspath_loop_check) Fix the typo-bug which
321 essentially had disabled this check. Problem reported by
322 Bartek Kania <mrbk@gnarf.org> in [quagga-users 7388].
323
Paul Jakma18937402006-07-27 19:05:12 +00003242006-07-27 Paul Jakma <paul.jakma@sun.com>
325
326 * bgpd.c: (peer_delete) Ensure freed buffers can not be
327 accidently reused. A potential fix for bug #287.
328
Paul Jakma33d5ab92006-07-02 11:01:50 +00003292006-07-02 Paul Jakma <paul.jakma@sun.com>
330
331 * bgp_fsm.c: (bgp_{stop,start}) Move clear/free of certain
332 bits of state from stop to start, as they may be used via
333 peer references on clearing queues..
334
Paul Jakma369688c2006-05-23 22:27:55 +00003352006-05-23 Paul Jakma <paul.jakma@sun.com>
336
337 * bgp_vty.c: (neighbor_update_source_cmd) Expand tab completion
338 to make it clear it takes both address and ifname.
339
Paul Jakma34c3f812006-05-12 23:25:37 +00003402006-05-12 Paul Jakma <paul.jakma@sun.com>
341
342 * bgp_attr.c: (bgp_packet_attribute) Remove dead code, Coverity
343 CID #1
Paul Jakmab2518c12006-05-12 23:48:40 +0000344 * bgp_aspath.{c,h}: (aspath_print_vty) take a format string,
345 so as to reduce burden on callers, all in bgp_route.c
Paul Jakmadd8103a2006-05-12 23:27:30 +0000346 * bgp_route.c: (bgp_static_update_main) Remove useless NULL
347 check, code already assumes bgp_static can not be NULL,
348 fixes CID #7.
Paul Jakma06e110f2006-05-12 23:29:22 +0000349 (bgp_static_update_rsclient) ditto, CID #6
Paul Jakmab2518c12006-05-12 23:48:40 +0000350 (route_vty_out{,tmp}) Update to match aspath_print_vty,
351 simplifying checks needed to get spacing right. CID #4,#5.
352 ({damp,flap}_route_vty_out) Ditto, CID #9, #10
Paul Jakma34c3f812006-05-12 23:25:37 +0000353
Paul Jakma542bcb72006-05-08 14:25:09 +00003542006-05-08 Paul Jakma <paul.jakma@sun.com>
355
356 * bgp_community.c: (community_str2com) Coverity CID#62, fix
357 double-free, use-after-free.
Paul Jakmada5b30f2006-05-08 14:37:17 +0000358 * bgp_route.c: (bgp_afi_node_get) given table should never be
359 NULL, check/assert this.
360 (bgp_static_update) Bug #240. Rsclients should only be passed
361 the static update if they are configured for the afi,safi.
Paul Jakma542bcb72006-05-08 14:25:09 +0000362
Paul Jakmaa3b6ea52006-05-04 07:52:12 +00003632006-05-04 Paul Jakma <paul.jakma@sun.com>
364
365 * (general) VPNv4 fixes. Certain VPNv4 code was not enabled.
366 See bug #210.
367 * bgp_attr.{c,h}: (bgp_packet_{withdraw,attribute}) Tag should be
368 u_char really.
369 * bgp_packet.c: (bgp_{update,withdraw}_packet) Enable some
370 VPNv4 code which inexplicably was ifdef'd out. comments from
371 a tester on IRC suggest this fixes bug #210.
Paul Jakma65ca75e2006-05-04 08:08:15 +0000372 * bgp_route.c: (general) Fix logical bug in clearing, noted
373 by Chris Caputo in [quagga-users 6728] - clearing depended on
374 at least one route being added to workqueue, in order for
375 workqueue completion function to restart FSM. However, if no
376 routes are cleared, then the completion function never is
377 called, it needs to be called manually if the workqueue
378 didn't get scheduled.
379 Finally, clearing is per-peer-session, not per AFI/SAFI, so
380 the FSM synchronisation should be in bgp_clear_route_table.
381 (bgp_clear_route_table) Wrong place for FSM/clearing
382 synchronisation, move to..
383 (bgp_clear_route) FSM/clearing synchronisation should be
384 here.
385 If no routes were cleared, no workqueue scheduled, call
386 the completion func to ensure FSM kicks off again.
Paul Jakmaa3b6ea52006-05-04 07:52:12 +0000387
Paul Jakma15aa6a12006-03-30 14:39:35 +00003882006-03-30 Paul Jakma <paul.jakma@sun.com>
389
390 * bgp_community.c: (community_gettoken) Unknown token should
391 return NULL, to give a strong indication to callers that
392 the token no longer can be parsed, otherwise callers looping
393 on this function may have a hard time ending their loop.
394 (community_str2com) While loop around community_gettoken appears
395 to have been coded thinking that break statement would break
396 from the while{}, hence it could never exit for unknown token
397 case. Fix it to do..while, so it can use the NULL result from
398 community_gettoken easily.
399
Paul Jakmaa625ca32006-03-30 14:12:38 +00004002006-03-22 Paul Jakma <paul.jakma@sun.com>
401
402 * bgpd.c: (peer_free) release the per-peer workqueue when
403 freeing the peer.
404
Paul Jakma5304cb52006-03-30 14:01:14 +00004052006-03-19 Paul Jakma <paul.jakma@sun.com>
406
Paul Jakma4bf6a362006-03-30 14:05:23 +0000407 * bgpd/bgp_vty.c: Add includes to get several structs we want
408 to provide usage statistics on.
409 (show_bgp_memory_cmd) Show memory usage stats for various
410 notable fixed size objects. Using mtype_stats_alloc and
411 mtype_memstr recently added to memory.c.
412 (bgp_show_summary) Report some additional stats specific to
413 the given BGP instance and/or AFI/SAFI such as table counts,
414 peers, rsclients and peer-groups.
415 (bgp_vty_init) Install show_bgp_memory_cmd.
Paul Jakma5304cb52006-03-30 14:01:14 +0000416 * bgp_nexthop.h: Include if.h as a dependent header, for struct
417 connected.
Paul Jakmab51f1262006-03-30 14:09:38 +0000418 * bgp_advertise.c: Use a distinct memory type for struct
419 bgp_synchronize.
Paul Jakma5304cb52006-03-30 14:01:14 +0000420
Paul Jakmacbdfbaa2006-03-30 13:20:48 +00004212006-03-12 Paul Jakma <paul.jakma@sun.com>
422
423 * bgp_attr.h: (struct attr) rearrange fields to avoid
424 wasted padding between them as much as possible.
425 (attr_count,attr_unknown_count) export new functions to
426 return number of counts of cached attributes.
427 * bgp_attr.c: (attr_count,attr_unknown_count) new functions to
428 return number of counts of cached attributes.
429 * bgp_route.h: (struct bgp_info) rearrange fields to avoid
430 wasted padding.
431 * bgp_table.h: (struct bgp_table) Add a count field, of number
432 of nodes in the table.
433 (struct bgp_node) rearrange fields to avoid
434 wasted padding between them, though I don't think there
435 was any in this case.
436 * bgp_table.c: (bgp_node_{delete,get}) Maintain the table node count.
437 (bgp_table_count) new function to access the table count.
438
Paul Jakma3e0c78e2006-03-06 18:06:53 +00004392006-03-03 Paul Jakma <paul.jakma@sun.com>
440
441 * bgp_route.c: (bgp_clear_node_complete) Doh. When clearing
442 is complete we need to kick off FSM again.
443
Paul Jakma64e580a2006-02-21 01:09:01 +00004442006-02-21 Paul Jakma <paul.jakma@sun.com>
445
446 * bgpd.h: move the clear_node_queue to be peer specific.
447 Add a new peer status flag, PEER_STATUS_CLEARING.
448 * bgp_table.h: (struct bgp_table) Add fields to record afi,
449 safi of the table.
450 (bgp_table_init) Take afi and safi to create table for.
451 * bgp_table.c: (bgp_table_init) record the afi and safi.
452 * bgp_nexthop.c: Update all calls to bgp_table_init.
453 * bgp_vty.c: ditto.
454 * bgpd.c: ditto.
455 * bgp_fsm.c: (bgp_timer_set) dont bring up a session which is
456 clearing.
457 * bgp_route.c: (general) Update all bgp_table_init calls.
458 (bgp_process_{rsclient,main}) clear_node is serialised
459 via PEER_STATUS_CLEARING and fsm now.
460 (struct bgp_clear_node_queue) can be removed. struct bgp_node
461 can be the queue item data directly, as struct peer can be
462 kept in the new wq global user data and afi/safi can be
463 retrieved via bgp_node -> bgp_table.
464 (bgp_clear_route_node) fix to get peer via wq->spec.data,
465 afi/safi via bgp_node->bgp_table.
466 (bgp_clear_node_queue_del) no more item data to delete, only
467 unlock the bgp_node.
468 (bgp_clear_node_complete) only need to unset CLEARING flag
469 and unlock struct peer.
470 (bgp_clear_node_queue_init) queue attaches to struct peer
471 now. record peer name as queue name.
472 (bgp_clear_route_table) If queue transitions to active,
473 serialise clearing by setting PEER_STATUS_CLEARING rather
474 than plugging process queue, and lock peer while queue
475 active.
476 Update to pass only bgp_node as per-queue-item specific data.
Paul Jakma6a419732006-02-21 01:14:13 +0000477 * bgp_vty.c: (bgp_show_summary) Add a 'Clrng' sub-description
478 to state of peer while it's suppressed due to clearing.
Paul Jakma64e580a2006-02-21 01:09:01 +0000479
Paul Jakmaaa94ca82006-02-18 10:49:04 +00004802006-02-18 Paul Jakma <paul.jakma@sun.com>
481
482 * bgp_routemap.c: (route_set_community) Quick, very hacky, fix
483 for the set-community leak, bug #89. True fix will be to
484 detangle the web of *_intern caching and provide saner object
485 caching for Quagga, future work.
Paul Jakma7c7fa1b2006-02-18 10:52:09 +0000486 * bgp_route.c: (bgp_announce_check) trivial, move declaration
487 of two local variables into the only block where they are
488 used, to aid the reader.
Paul Jakmaaa94ca82006-02-18 10:49:04 +0000489
paul902212c2006-02-05 17:51:19 +00004902006-02-05 Paul Jakma <paul.jakma@sun.com>
491
492 * bgp_route.h: Add BGP_INFO_COUNTED to track whether
493 prefix has been counted or not.
494 * bgp_route.c: (bgp_pcount_{inc,dec}rement) new helpers, to
495 centralise inc/dec of prefix-count,
496 (bgp_rib_remove) Remove pcount decrement, use helper.
497 (bgp_rib_withdraw) ditto, additionally use previous function
498 too.
499 (bgp_update_main) Use pcount helpers.
500 (bgp_clear_route_node) ditto, aslo REMOVED routes don't need
501 clearing.
paul3fff6ff2006-02-05 17:55:35 +0000502 * bgp_aspath.c: (aspath_gettoken) fix gcc warning about
503 possible uninitialised usage.
paul902212c2006-02-05 17:51:19 +0000504
paul306d8892006-02-02 17:50:19 +00005052006-02-02 Paul Jakma <paul.jakma@sun.com>
506
507 * bgp_route.c: (bgp_{clear_node,process}_queue_init) delay
508 field is removed from workqueue spec.
509
paule8e19462006-01-19 20:16:55 +00005102006-01-19 Paul Jakma <paul.jakma@sun.com>
511
512 * (general) various miscellaneous compiler warning fixes.
513 Remove redundant break statements from switch clauses
514 which return.
515 return from main, not exit, cause it annoys SOS.
516 Remove stray semi-colons which cause empty-statement
517 warnings.
518
pauld3092e72006-01-17 17:33:46 +00005192006-01-17 Paul Jakma <paul.jakma@sun.com>
520
521 * bgp_nexthop.c: (zlookup_read*) convert to new Zserv format.
522 (zlookup_query_ipv6) ditto.
523 (bgp_import_check) ditto.
524
paul02335422006-01-16 11:13:27 +00005252006-01-16 Paul Jakma <paul.jakma@sun.com>
526
527 * bgp_aspath.c: (assegment_append_asns) XREALLOC can return
528 NULL theoretically, take care not to lose the allocated data.
529 (aspath_hash_alloc) aspath_dup already set the aspath
530 string - fix leak.
531 (aspath_parse) aspath_hash_alloc dupes the entire aspath,
532 including segments, but we forgot to free the temporary
533 assegment.
paul8fdc32a2006-01-16 12:01:29 +0000534 (aspath_snmp_pathseg) move the static stream pointer out to
535 file scope, so it can be freed.
536 (aspath_finish) new function, free aspath resources.
537 * bgp_aspath.h: (aspath_finish) export.
paul02335422006-01-16 11:13:27 +0000538
paul37c38302006-01-10 22:15:45 +00005392006-01-10 Juris Kalnins <juris@mt.lv>
540
541 * bgpd.h: (bgp_router_id_unset) ex-function, remove.
542
paulad727402005-11-23 02:47:02 +00005432005-11-23 Paul Jakma <paul.jakma@sun.com>
544
545 * bgp_aspath.c: (assegments_parse) should be static
546
5472005-11-23 Juergen Kammer <j.kammer@eurodata.de>
548
549 * bgp_aspath.c: (aspath_cmp_left_confed) fix SEGV for case
550 where one or both paths are empty.
551
paul0fb58d52005-11-14 14:31:49 +00005522005-11-14 Paul Jakma <paul.jakma@sun.com>
553
554 * bgp_route.c: (bgp_process_rsclient) convert to new workqueue
555 specs and shut up gcc, which complains about cast from void
556 via function parameters, for some dumb reason. Do the cast
557 inside the function instead.
558 (bgp_process_main,bgp_processq_del) ditto.
559 (bgp_clear_route_node) ditto.
560 (bgp_clear_node_queue_del) ditto.
561
paul41200852005-11-03 12:52:18 +00005622005-11-03 Paul Jakma <paul.jakma@sun.com>
563
564 * bgp_damp.c: (bgp_reuse_timer) struct bgp can be retrieved via
565 the struct bgp_damp_info, no need to guess by using
566 bgp_get_default().
567
ajsf52d13c2005-10-01 17:38:06 +00005682005-10-01 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
569
570 * bgp_vty.c: (bgp_config_write_redistribute) Use new library function
571 zebra_route_string instead of a local hard-coded table.
572
jardin2d74db52005-10-01 00:07:50 +00005732005-09-30 Vincent Jardin <vincent.jardin@6wind.com>
574
575 * bgp_packet.c: fix compilation when DEBUG is used.
576
paul1f8ae702005-09-09 23:49:49 +00005772005-09-10 Paul Jakma <paul.jakma@sun.com>
578
paulfe69a502005-09-10 16:55:02 +0000579 * Makefile.am: bgpd shouldn't list libgp's sources as its own.
580 Use LDADD.
581 * bgp_aspath.h:
582 (struct assegment) New struct, abstract representation of a
583 list of AS_PATH segments and the contained ASNs.
584 (struct aspath) Remove the raw-data related
585 fields, reference the abstract struct assegment instead.
586 Remove several other computed fields, it's just a
587 headache to maintain them and they're cheap to compute from
588 struct assegment.
589 (aspath_parse) parse a stream, not a pointer to raw data.
590 (aspath_count_{hops,confeds,size}) helpers to access
591 information formerly directly contained in struct aspath.
592 (aspath_snmp_pathseg) Helper for SNMP, BGP MIB wants
593 to be able to output hex representation of raw data.
594 * bgp_aspath.c: (general) partial-rewrite. Store aspath data
595 as an abstract singly-linked list of abstract segments,
596 rather than storing the raw data, and parsing it each and
597 every time. Remove several count/size fields which are cheap
598 to compute from the abstract segment structure.
599 (global) Include stream.h, needed for aspath_parse, and
600 others. Couple of helper macros added.
601 (struct assegment_header) Just the header, and only the
602 header.
603 (assegment_data_{new,free}) convenience functions for
604 AS_SEG_DATA allocation, the dynamic, per-segment array of
605 ASNs.
606 (assegment_{new,free,free_all,dup,dup_all}) convenience
607 functions for creating struct assegments. The _all forms will
608 follow the entire chain of segments from the given segment.
609 (assegment_prepend_asns) new function, prepend an ASN N times
610 to segment.
611 (assegment_append_asns) Append a list (array) of ASNs to
612 segment.
613 (int_cmp) convenience function for the aspath hash.
614 (assegment_normalise) new function. Normalise the given
615 segment chain to meet expectations of Quagga, and to
616 eliminate differing raw representations of the same paths.
617 Merge 'runs' of SEQUENCEs into one segment as our internal
618 segment is not limited by the protocol AS_PATH segment
619 length. Sort ASNs in SETs.
620 (aspath_new) Take void argument to quell warnings. Use the
621 assegment convenience functions.
622 (assegment_count_{asns,confeds,hops}) new functions to
623 compute at runtime values previously held in struct aspath.
624 (aspath_size) ditto.
625 (aspath_make_str_count) rewritten to stringify new
626 representation, and to be slightly easier to understand
627 hopefully.
628 (aspath_str_update) convenience function, update the aspath
629 str. Should investigate removing maintained string from
630 struct aspath, just run-time compute it, as per other fields.
631 It's just a maintenance headache, would save noticeable
632 amount of RAM with possibly not much extra run-time cost.
633 (aspath_dup) use the assegment dup functions.
634 (aspath_hash_alloc) Take void * argument to satisfy gcc. Use
635 the proper helper functions to dup data.
636 (assegments_parse) new function. parse raw AS_PATH data into
637 struct assegments. Normalise and return the head of the list.
638 (aspath_parse) Parse a stream, not pointer to raw data and
639 use assegments_parse to do it.
640 (assegment_data_put) Write out a single segment data in protocol
641 form to stream.
642 (assegment_header_put) ditto but for segment header.
643 (aspath_put) new function. As per previous but for an entire
644 struct aspath.
645 (aspath_snmp_pathseg) wrapper around aspath_put for
646 bgp_snmp.c. Uses a static buffer sadly.
647 (aspath_aggregate_as_set_add) rewritten to use assegments.
648 (aspath_aggregate) ditto
649 (aspath_{firstas,loop,private_as}_check) ditto
650 (aspath_{merge,prepend,add_one_as}) ditto
651 (aspath_cmp_left{_confed}) ditto
652 (aspath_delete_confed_seq) ditto, plus fixed to properly
653 delete all leading confed segments.
654 (aspath_as_add) Just use assegment_append_asns.
655 (aspath_segment_add) updated to use assegments.
656 (enum as_token) Add values for confeds
657 (aspath_gettoken) Add support for confeds
658 (aspath_str2aspath) ditto
659 (aspath_key_make) updated to use as_segments. Also, add
660 segment type into the hash value as appropriate.
661 (aspath_cmp) updated to use as_segments.
662 (aspath_print) don't segfault on NULL argument.
663 * bgp_attr.c: (bgp_attr_aspath) aspath_parse wants the stream
664 now. No need for manual forwarding of stream.
665 (bgp_packet_attribute) empty aspath is now denoted by NULL
666 segment field, length is gone.
667 Use aspath_size() to determine size.
668 (bgp_attr_init) Fix declaration, explicitely specify void
669 arg.
670 (bgp_dump_routes_attr) Use aspath_size() to determine size.
671 * bgp_route.c: (bgp_info_cmp) use the aspath_count_* functions.
672 (bgp_rib_withdraw) remove unused variable. Use
673 aspath_count_hops.
674 * bgp_snmp.c: (bgp4PathAttrTable) raw data is gone, use
675 aspath_snmp_pathseg to get the representation.
676
6772005-09-10 Paul Jakma <paul.jakma@sun.com>
678
paul1f8ae702005-09-09 23:49:49 +0000679 * bgp_vty.c: (bgp_vty_init) gcc 4 compile fix. static
680 function declarations shouldn't be inside functions.
681 * bgp_dump.c: (bgp_dump_interval_add) ditto.
682
hassob7395792005-08-26 12:58:38 +00006832005-08-26 Hasso Tepper <hasso at quagga.net>
684
685 * bgp_route.c: Third (?) attempt to fix best selection breakage
686 introduced long time ago with route server patch. Hopefully
687 it's last case to fix - route-server client not in peer group.
688
paul25ffbdc2005-08-22 22:42:08 +00006892005-08-22 Hugo Santos <hsantos@av.it.pt>
690
691 * bgp_vty.c: (general) Add support for BGP IPv6 Multicast SAFI
692 commands and BGP_IPV6M_NODE.
693
paulb40d9392005-08-22 22:34:41 +00006942005-08-22 Paul Jakma <paul.jakma@sun.com>
695
696 * bgp_route.h: (struct bgp_info) add a new flag, BGP_INFO_REMOVED.
697 BGP_INFO_VALID is already overloaded, don't care to do same thing
698 to STALE or HISTORY.
699 * bgpd.h: (BGP_INFO_HOLDDOWN) Add INFO_REMOVED to the macro, as a
700 route which should generally be ignored.
701 * bgp_route.c: (bgp_info_delete) Just set the REMOVE flag, rather
702 than doing actual work, so that bgp_process (called directly,
703 or indirectly via the scanner) can catch withdrawn routes.
704 (bgp_info_reap) Actually remove the route, what bgp_info_delete
705 used to do, only for use by bgp_process.
706 (bgp_best_selection) reap any REMOVED routes, other than the old
707 selected route.
708 (bgp_process_rsclient) reap the old-selected route, if appropriate
709 (bgp_process_main) ditto
710 (bgp_rib_withdraw, bgp_rib_remove) make them more consistent with
711 each other. Don't play games with the VALID flag, bgp_process
712 is async now, so it didn't make a difference anyway.
713 Remove the 'force' argument from bgp_rib_withdraw, withdraw+force
714 is equivalent to bgp_rib_remove. Update all its callers.
715 (bgp_update_rsclient) bgp_rib_withdraw and force set is same as
716 bgp_rib_remove.
717 (route_vty_short_status_out) new helper to print the leading
718 route-status string used in many command outputs. Consolidate.
719 (route_vty_out, route_vty_out_tag, damp_route_vty_out,
720 flap_route_vty_out) use route_vty_short_status_out rather than
721 duplicate.
722 (route_vty_out_detail) print state of REMOVED flag.
723 (BGP_SHOW_SCODE_HEADER) update for Removed flag.
724
hassoe279c7a2005-08-03 17:23:20 +00007252005-08-03 Hasso Tepper <hasso at quagga.net>
726
727 * bgp_routemap.c: Revert part of leaking communities fix commited in
728 2005-05-27. While ecommunity fix seems to be correct, community case
729 isn't.
730
paul94f2b392005-06-28 12:44:16 +00007312005-06-28 Paul Jakma <paul.jakma@sun.com>
732
733 * (global) The great bgpd extern and static'ification.
734 * bgp_routemap.c: remove unused ROUTE_MATCH_ASPATH_OLD code
735 (route_set_metric_compile) fix u_int32_t to ULONG_MAX comparison
736 warnings.
737 * bgp_route.h: (bgp_process, bgp_withdraw, bgp_update) export these
738 used by various files which had their own private declarations,
739 in the case of mplsvpn - incorrect.
740
paule210cf92005-06-15 19:15:35 +00007412005-06-15 Paul Jakma <paul.jakma@sun.com>
742
743 * bgpd.c: (bgp_terminate) workqueue's are lazy allocated and its
744 possible to terminate bgpd before workqueues were setup, causing
745 an abort/crash. Reported by Ashish Mehta of Sun.
746
paul200df112005-06-01 11:17:05 +00007472005-06-01 Paul Jakma <paul.jakma@sun.com>
748
749 * (general) refcount struct peer and bgp_info, hence allowing us
750 add work_queues for bgp_process.
751 * bgp_route.h: (struct bgp_info) Add 'lock' field for refcount.
752 Add bgp_info_{lock,unlock} helper functions.
753 Add bgp_info_{add,delete} helpers, to remove need for
754 users managing locking/freeing of bgp_info and bgp_node's.
755 * bgp_table.h: (struct bgp_node) Add a flags field, and
756 BGP_NODE_PROCESS_SCHEDULED to merge redundant processing of
757 nodes.
758 * bgp_fsm.h: Make the ON/OFF/ADD/REMOVE macros lock and unlock
759 peer reference as appropriate.
760 * bgp_damp.c: Remove its internal prototypes for
761 bgp_info_delete/free. Just use bgp_info_delete.
762 * bgpd.h: (struct bgp_master) Add work_queue pointers.
763 (struct peer) Add reference count 'lock'
764 (peer_lock,peer_unlock) New helpers to take/release reference
765 on struct peer.
766 * bgp_advertise.c: (general) Add peer and bgp_info refcounting
767 and balance how references are taken and released.
768 (bgp_advertise_free) release bgp_info reference, if appropriate
769 (bgp_adj_out_free) unlock peer
770 (bgp_advertise_clean) leave the adv references alone, or else
771 call bgp_advertise_free cant unlock them.
772 (bgp_adj_out_set) lock the peer on new adj's, leave the reference
773 alone otherwise. lock the new bgp_info reference.
774 (bgp_adj_in_set) lock the peer reference
775 (bgp_adj_in_remove) and unlock it here
776 (bgp_sync_delete) make hash_free on peer conditional, just in
777 case.
778 * bgp_fsm.c: (general) document that the timers depend on
779 bgp_event to release a peer reference.
780 (bgp_fsm_change_status) moved up the file, unchanged.
781 (bgp_stop) Decrement peer lock as many times as cancel_event
782 canceled - shouldnt be needed but just in case.
783 stream_fifo_clean of obuf made conditional, just in case.
784 (bgp_event) always unlock the peer, regardless of return value
785 of bgp_fsm_change_status.
786 * bgp_packet.c: (general) change several bgp_stop's to BGP_EVENT's.
787 (bgp_read) Add a mysterious extra peer_unlock for ACCEPT_PEERs
788 along with a comment on it.
789 * bgp_route.c: (general) Add refcounting of bgp_info, cleanup
790 some of the resource management around bgp_info. Refcount peer.
791 Add workqueues for bgp_process and clear_table.
792 (bgp_info_new) make static
793 (bgp_info_free) Ditto, and unlock the peer reference.
794 (bgp_info_lock,bgp_info_unlock) new exported functions
795 (bgp_info_add) Add a bgp_info to a bgp_node in correct fashion,
796 taking care of reference counts.
797 (bgp_info_delete) do the opposite of bgp_info_add.
798 (bgp_process_rsclient) Converted into a work_queue work function.
799 (bgp_process_main) ditto.
800 (bgp_processq_del) process work queue item deconstructor
801 (bgp_process_queue_init) process work queue init
802 (bgp_process) call init function if required, set up queue item
803 and add to queue, rather than calling process functions directly.
804 (bgp_rib_remove) let bgp_info_delete manage bgp_info refcounts
805 (bgp_rib_withdraw) ditto
806 (bgp_update_rsclient) let bgp_info_add manage refcounts
807 (bgp_update_main) ditto
808 (bgp_clear_route_node) clear_node_queue work function, does
809 per-node aspects of what bgp_clear_route_table did previously
810 (bgp_clear_node_queue_del) clear_node_queue item delete function
811 (bgp_clear_node_complete) clear_node_queue completion function,
812 it unplugs the process queues, which have to be blocked while
813 clear_node_queue is being processed to prevent a race.
814 (bgp_clear_node_queue_init) init function for clear_node_queue
815 work queues
816 (bgp_clear_route_table) Sets up items onto a workqueue now, rather
817 than clearing each node directly. Plugs both process queues to
818 avoid potential race.
819 (bgp_static_withdraw_rsclient) let bgp_info_{add,delete} manage
820 bgp_info refcounts.
821 (bgp_static_update_rsclient) ditto
822 (bgp_static_update_main) ditto
823 (bgp_static_update_vpnv4) ditto, remove unneeded cast.
824 (bgp_static_withdraw) see bgp_static_withdraw_rsclient
825 (bgp_static_withdraw_vpnv4) ditto
826 (bgp_aggregate_{route,add,delete}) ditto
827 (bgp_redistribute_{add,delete,withdraw}) ditto
828 * bgp_vty.c: (peer_rsclient_set_vty) lock rsclient list peer
829 reference
830 (peer_rsclient_unset_vty) ditto, but unlock same reference
831 * bgpd.c: (peer_free) handle frees of info to be kept for lifetime
832 of struct peer.
833 (peer_lock,peer_unlock) peer refcount helpers
834 (peer_new) add initial refcounts
835 (peer_create,peer_create_accept) lock peer as appropriate
836 (peer_delete) unlock as appropriate, move out some free's to
837 peer_free.
838 (peer_group_bind,peer_group_unbind) peer refcounting as
839 appropriate.
840 (bgp_create) check CALLOC return value.
841 (bgp_terminate) free workqueues too.
842
hasso033e8612005-05-28 04:50:54 +00008432005-05-28 Hasso Tepper <hasso at quagga.net>
844
845 * bgp_routemap.c: Sync set_metric_addsub_cmd with ripd.
846
hasso54a6ed32005-05-26 22:12:33 +00008472005-05-27 Hasso Tepper <hasso at quagga.net>
848
hasso70601e02005-05-27 03:26:57 +0000849 * bgp_routemap.c: Stop leaking communities.
850
8512005-05-27 Hasso Tepper <hasso at quagga.net>
852
hasso54a6ed32005-05-26 22:12:33 +0000853 * bgpd.c: Deleting bgp->rsclient list needs fix similar to pree-groups
854 deleting fix. Avoid leaking bgp->group, bgp->peer and bgp->rsclient
855 lists.
856
8572005-05-26 Hasso Tepper <hasso at quagga.net>
hassob6b7cff2005-05-26 08:29:07 +0000858
859 * bgpd.c: Don't crash while deleting list of peer-groups.
860
hassob5f29602005-05-25 21:00:28 +00008612005-05-25 Hasso Tepper <hasso at quagga.net>
862
863 * bgpd.c: Fix obvious (routeserver patch) merge error. This makes "no
864 neighbor x.x.x.x routemap [export|import] commands work again.
865
paula94feb32005-05-23 13:17:29 +00008662005-05-23 Paul Jakma <paul@dishone.st>
867
868 * bgp_routemap.c: add semi-colons to VTY_GET_* to match vty.h change
paul00d252c2005-05-23 14:19:54 +0000869 * bgp_fsm.h: Add extern qualifier to exported functions
870 * bgp_nexthop.c: add static to nexthop specific globals
871 * *.h: Add guard defines
paula94feb32005-05-23 13:17:29 +0000872
paul22db9de2005-05-19 01:50:11 +00008732005-05-19 Paul Jakma <paul@dishone.st>
874
875 * bgp_fsm.c: (bgp_stop) use sockunion_free, not XFREE..
876 * bgp_network.c: (bgp_getsockname) ditto
paule83e2082005-05-19 02:12:25 +0000877 (bgp_accept) use XSTRDUP
paul22db9de2005-05-19 01:50:11 +0000878 * bgp_routemap.c: (route_match_peer) ditto, als use a ret value and
879 remove one sockunion_free.
paule83e2082005-05-19 02:12:25 +0000880 * bgpd.c: (peer_delete) ditto.
881 XFREE the correct memtype, not free.
882 (peer_create) use XSTRDUP
883 * bgp_packet.c: (bgp_stream_dup) deleted, stream_dup should be used
884 (various) update -> s/bgp_stream_dup/stream_dup
885
paul22db9de2005-05-19 01:50:11 +0000886
ajs634f9ea2005-04-11 15:51:40 +00008872005-04-11 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
888
889 * bgp_zebra.c (bgp_redistribute_set, bgp_redistribute_unset):
890 The 2nd arg to zebra_redistribute_send is now zclient instead of
891 zclient->sock.
892
hassoa8a80d52005-04-09 13:07:47 +00008932005-04-09 Akihiro Mizutani <mizutani@net-chef.net>
894
895 * bgp_vty.c: Make "exit-address-family" work in IPv4 unicast address
896 family node.
897
hasso68118452005-04-08 15:40:36 +00008982005-04-08 Martin Ling <martin-quagga@earth.li>
899
900 * bgp_aspath.[ch], bgp_route.c, bgp_vty.c, bgpd.[ch]: Allow to enable
901 the length of confederation path segments to be included during the
902 as-path length check in the best path decision.
903
ajsd2fc8892005-04-02 18:38:43 +00009042005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
905
906 * bgp_zebra.c: (bgp_interface_delete) After deleting, set ifp->ifindex
907 to IFINDEX_INTERNAL.
908
hasso6cf159b2005-03-21 10:28:14 +00009092005-03-21 Hasso Tepper <hasso at quagga.net>
910
911 * bgp_route.c: Don't crash while clearing route tables if there is
912 no particular afi/safi configured.
913
hasso338b3422005-02-23 14:27:24 +00009142005-02-23 Hasso Tepper <hasso at quagga.net>
915
916 * bgp_route.c: Make reannouncing prefixes with changed attributes
917 work again.
918
hasso6ffd2072005-02-02 14:50:11 +00009192005-02-02 Akihiro Mizutani <mizutani@net-chef.net>
920
hassodd4c5932005-02-02 17:15:34 +0000921 * bgp_vty.c: Deprecate "neighbor transparent-as" and "neighbor
922 transparent-nexthop" commands.
923
9242005-02-02 Akihiro Mizutani <mizutani@net-chef.net>
925
hassoc1643bb2005-02-02 16:43:17 +0000926 * bgp_routemap.c: New route-map command - "match ip route-source".
927
9282005-02-02 Akihiro Mizutani <mizutani@net-chef.net>
929
hassofee6e4e2005-02-02 16:29:31 +0000930 * bgp_clist.[ch], bgp_route.c, bgp_routemap.c, bgp_vty.c:
931 community-list cleanup.
932
9332005-02-02 Akihiro Mizutani <mizutani@net-chef.net>
934
hasso6ffd2072005-02-02 14:50:11 +0000935 * bgp_route.c, bgp_vty.c, bgp_zebra.c, bgpd.[ch]: "enforce-multihop"
936 -> "disable-connected-check".
937
9382005-02-02 Akihiro Mizutani <mizutani@net-chef.net>
hasso93406d82005-02-02 14:40:33 +0000939
940 * bgp_fsm.c, bgp_open.c, bgp_packet.c, bgp_route.[ch], bgp_vty.c,
941 bgpd.[ch]: Add BGP_INFO_STALE flag and end-of-rib support. "bgp
942 graceful-restart" commands added. Show numbers of individual
943 messages in "show ip bgp neighbor" command. Final pieces of graceful
944 restart.
945
hassof4184462005-02-01 20:13:16 +00009462005-02-01 Akihiro Mizutani <mizutani@net-chef.net>
947
hassoc9502432005-02-01 22:01:48 +0000948 * bgp_open.c, bgp_packet.c, bgp_vty.c, bgpd.[ch]: Remove "no neighbor
949 capability route-refresh" commands. Route refresh capability is sent
950 anyway now. Preserve dummy deprecated commands.
951
9522005-02-01 Akihiro Mizutani <mizutani@net-chef.net>
953
hasso3d515fd2005-02-01 21:30:04 +0000954 * bgp_attr.c, bgp_snmp.c, bgp_vty.c, bgpd.[ch]: Remove support for old
955 draft - ie. "neighbor version 4-" commands. Preserve dummy "neighbor
956 version" command as deprecated.
957
9582005-02-01 Akihiro Mizutani <mizutani@net-chef.net>
959
hasso0a486e52005-02-01 20:57:17 +0000960 * bgpd.[ch], bgp_vty.c, bgp_route.c: "Restart session after
961 maximum-prefix limit" feature support.
962
9632005-02-01 Akihiro Mizutani <mizutani@net-chef.net>
964
hassof4184462005-02-01 20:13:16 +0000965 * bgp_nexthop.c: Improve debug.
966 * bgpd.[ch], bgp_nexthop.c, bgp_snmp.c: Remove useless bgp_get_master()
967 function.
968 * bgp_packet.c: MP AFI_IP update and withdraw parsing.
969 * bgp_fsm.c: Reset peer synctime in bgp_stop(). bgp_fsm_change_status()
970 is better place to log about peer status change than bgp_event().
971 Log in bgp_connect_success().
972 * bgp_vty.c: Fix typo in comment.
973 * bgp_attr.c: Better log about unknown attribute.
974
ajs3b8b1852005-01-29 18:19:13 +00009752005-01-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
976
977 * bgp_filter.c: (ip_as_path,no_ip_as_path) Use argv_concat instead
978 of buffer_getstr.
979 * bgp_route.c: (bgp_show_regexp) Fix memory leak: need to free string
980 returned by buffer_getstr.
981 (bgp_show_community) Must use XFREE instead of free on string
982 returned by buffer_getstr.
983 * bgp_routemap.c: (set_community) Must use XFREE instead of free
984 on string returned by buffer_getstr.
985 * bgp_vty.c: (neighbor_description) Use argv_concat instead of
986 buffer_getstr.
987
hasso6d694292005-01-24 09:29:42 +00009882005-01-24 Hasso Tepper <hasso at quagga.net>
989
990 * bgp_route.c: Fix showstopper bug. New route must be selected also
991 if old one is flaged as BGP_INFO_ATTR_CHANGED.
992
hassof1271652005-01-17 11:04:32 +00009932005-01-17 Hasso Tepper <hasso at quagga.net>
994
995 * bgp_route.c: Clear peer's routing table regardless whether it's
996 configured or not. Being not configured is even better reason to
997 do it.
998
paula24a7e12005-01-05 08:14:13 +00009992005-01-05 Paul Jakma <paul@dishone.st>
1000
1001 * bgp_packet.c: (bgp_write) set socket to nonblock while writing
1002 this should be generalised. See bugzilla #102. Fix supplied by
1003 wawa@yandex-team.ru (Vladimir Ivanov).
1004
ajsd2c1f162004-12-08 21:10:20 +000010052004-12-08 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1006
1007 * *.c: Change level of debug messages to LOG_DEBUG.
1008
ajs274a4a42004-12-07 15:39:31 +000010092004-12-07 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1010
1011 * bgp_main.c: (main) The 2nd argument to openzlog has been removed.
1012
ajs887c44a2004-12-03 16:36:46 +000010132004-12-03 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1014
1015 * bgp_main.c: (sigint) Use zlog_notice for termination message.
1016 (main) Use zlog_notice for startup announcement.
1017
hassoc0652302004-11-25 19:33:48 +000010182004-11-25 Hasso Tepper <hasso at quagga.net>
1019
1020 * bgp_main.c: Make group to run as configurable.
1021
paul59320202004-11-09 01:54:03 +000010222004-11-09 Paul Jakma <paul@dishone.st>
1023
1024 * bgp_nexthop.c: collapse bgp_connected_ipvX, bgp_nexthop_cache_ipvX
1025 and cache{1,2}.. into arrays of tables and hence collapse
1026 bgp_scan_ipv{4,6} into a single bgp_scan function. Tested, though
1027 a long time ago (and this change was hand-merged).
1028
ajs5a646652004-11-05 01:25:55 +000010292004-11-04 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1030
1031 * bgp_route.c: Remove all code related to VTY_CONTINUE; this feature
1032 is deprecated because the output did not represent a single point
1033 in time. All output needs to be generated inline and buffered
1034 by the library code.
1035 (route_vty_out,route_vty_out_tag,damp_route_vty_out,
1036 flap_route_vty_out) Remove code to count number of lines of output,
1037 since this was only useful for VTY_CONTINUE behavior.
1038 (bgp_show_callback,vty_calc_line) Removed.
1039 (bgp_show_table) Remove hooks for VTY_CONTINUE callback support.
1040 As a result, there's a new output_arg argument to this function.
1041 Make function static.
1042 (bgp_show) Make function static and add a new output_arg argument.
1043 Change all functions that call bgp_show or bgp_show_table to
1044 pass the new output_arg argument (that used to be passed inside
1045 vty->output_arg).
1046 * bgp_mplsvpn.c: Remove declarations of functions defined in
1047 bgp_route.c; these declarations belong in bgp_route.h.
1048 * bgp_route.h: Declare 3 global functions used in both bgp_route.c
1049 and in bgp_mplsvpn.c.
1050
paula2b1ecd2004-10-31 18:58:09 +000010512004-10-31 Paul Jakma <paul@dishone.st>
1052
1053 * {bgpd,bgp_attr}.c: size_t printf format should be ld.
1054
paul98f51632004-10-25 14:19:15 +000010552004-10-25 Paul Jakma <paul@dishone.st>
1056
1057 * Update with fix in debian bug id 222930.
1058 * bgp_main.c: Add ZCAP_RAW, needed to bind to interfaces.
1059 bgp_network.c: (....) raise/lower privs around call to
1060 SO_BINDTODEVICE sockopt.
1061
hasso3fb9cd62004-10-19 19:44:43 +000010622004-10-19 Andrew J. Schorr <aschorr@telemetry-investments.com>
1063
1064 * bgp_nexthop.c: (bgp_connected_add) Connected destination pointer
1065 may be NULL.
1066 (bgp_connected_delete) ditto.
1067
hasso501ba492004-10-13 21:32:46 +000010682004-10-14 Hasso Tepper <hasso at quagga.net>
1069
1070 * bgp_dump.c: Make dump configuration appear in vtysh.
1071
hassoc75105a2004-10-13 10:33:26 +000010722004-10-13 Hasso Tepper <hasso at quagga.net>
1073
1074 * bgp_snmp.c: Remove defaults used to initialize smux connection to
1075 snmpd. Connection is initialized only if smux peer is configured.
hasso8b3126b2004-10-13 20:59:04 +00001076 * bgp_view.c: It's dead file. Reomved.
hassoc75105a2004-10-13 10:33:26 +00001077
paulfd79ac92004-10-13 05:06:08 +000010782004-10-13 Paul Jakma <paul@dishone.st>
1079
1080 * (global) more const'ification and fixups of types to clean up code.
1081 * bgp_mplsvpn.{c,h}: (str2tag) fix abuse. Still not perfect,
1082 should use something like the VTY_GET_INTEGER macro, but without
1083 the vty_out bits..
1084 * bgp_routemap.c: (set_aggregator_as) use VTY_GET_INTEGER_RANGE
1085 (no_set_aggregator_as) ditto.
1086 * bgpd.c: (peer_uptime) fix unlikely bug, where no buffer is
1087 returned, add comments about troublesome return value.
1088
hasso18a6dce2004-10-03 18:18:34 +000010892004-10-03 James R. Leu <jleu at mindspring.com>
1090
1091 * bgp_vty.c: Router id from zebra can be manually overriden.
1092 * bgp_zebra.c: Read router id related messages from zebra daemon.
1093 Remove own code related with router id selection.
1094 * bgpd.c, bgpd.h: Remove own router id selection code. Use the one
1095 from zebra daemon if it isn't manually overriden.
1096
hassoc9e52be2004-09-26 16:09:34 +000010972004-09-26 Hasso Tepper <hasso at quagga.net>
1098
1099 * bgp_aspath.c, bgp_packet.c, bgp_vty.c: Fix compiler warnings.
1100
hasso52dc7ee2004-09-23 19:18:23 +000011012004-09-23 Hasso Tepper <hasso at quagga.net>
1102
1103 * *.[c|h]: list -> struct list *, listnode -> struct listnode *.
1104
paule01f9cb2004-07-09 17:48:53 +000011052004-07-09 Paul Jakma <paul@dishone.st>
1106
1107 * Merge of GNU Zebra cvs2svn changesets r799, r800 and r807.
1108 * bgp_dump.c: (bgp_dump_attr) cleanup. return status code. check
1109 attributes present before printing.
1110 * bgp_dump.c: update bgp_dump_attr prototype.
1111 * bgp_packet.c: (bgp_update_receive) init attrstr. check status
1112 of bgp_dump_attr. Log end-of-rib UPDATEs.
1113
paulf5ba3872004-07-09 12:11:31 +000011142004-07-09 Sowmini Varadhan <sowmini.varadhan@sun.com>
1115
1116 * bgp_packet.c: (bgp_collision_detect) Send NOTIFY on new socket
1117 if that is connection we're closing.
1118 (bgp_read) invalid marker check applies to KEEPALIVE too.
1119 * bgp_route.c: Ignore multicast NRLI, dont send NOTIFY.
1120
paul5228ad22004-06-04 17:58:18 +000011212004-06-04 Paul Jakma <paul@dishone.st>
1122
1123 * type mismatch fixes
1124
hasso538621f2004-05-21 09:31:30 +000011252004-05-21 Akihiro Mizutani <mizutani@net-chef.net>
1126
1127 * bgpd.h, bgp_open.[ch], bgp_debug.c, bgp_vty.[ch], bgp_fsm.c:
1128 Graceful restart capability display.
1129
hasso3950fda2004-05-20 10:22:49 +000011302005-05-20 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1131
1132 * bgp_debug.c: Cosmetical fixes and log neighbor changes.
1133
hasso4372df72004-05-20 10:20:02 +000011342004-05-20 Akihiro Mizutani <mizutani@net-chef.net>
1135
1136 * bgp_ecommunity.c: Transit ecommunity support.
1137 * bgp_ecommunity.c: Fix for unknown community crush.
1138
hassoe0701b72004-05-20 09:19:34 +000011392005-05-20 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1140
1141 * *: Maximum prefix threshold support.
1142 * *: Reset notification fixups.
1143
paul0a589352004-05-08 11:48:26 +000011442004-05-08 Paul Jakma <paul@dishone.st>
1145
1146 * bgp_zebra.c: (bgp_interface_address_add) sync to zclient changes
1147 (bgp_interface_address_delete) ditto.
1148 (bgp_zebra_announce) ditto.
1149 (bgp_zebra_withdraw) ditto.
1150
paulc5317402004-05-03 13:25:06 +000011512004-05-03 Daniel Roesen <dr@cluenet.de>
1152
1153 * bgp_fsm.c: (bgp_stop) Reset uptime only on transition from
1154 Established so that it reflects true downtime (rather time
1155 since last transition, eg Active->Idle)
1156
paul35be31b2004-05-01 18:17:04 +000011572004-05-01 rivo nurges <rix@estpak.ee>
1158
1159 * bgp_route.c: fix UNH IOL BGP-4.1.12f
1160
pauleb821182004-05-01 08:44:08 +000011612004-05-01 Paul Jakma <paul@dishone.st>
1162
1163 * Revert the attempted clean-up of the dummy peer hack, reverts
1164 patchsets 435 (see 2004-02-17 below) and 456.
1165
paul545acaf2004-04-20 15:13:15 +000011662004-04-16 rivo nurges <rix@estpak.ee>
1167
hasso9b87e412004-04-20 16:54:49 +00001168 * bgpd.h, bgp_debug.c: update cease subcodes to
1169 draft-ietf-idr-cease-subcode-05
paul545acaf2004-04-20 15:13:15 +00001170 * bgpd.h, bgpd.c, bgp_route.c, bgp_route.h: fix UNH IOL BGP-4.1.6a
1171
paul6ad23f02004-02-17 19:45:10 +000011722004-02-17 Paul Jakma <paul@dishone.st>
1173
1174 * bgpd.h: (bgp_peer) add fd_local and fd_accept
1175 file descriptor's, fd becomes a pointer to one of these.
1176 * bgpd.c: (global) adjust for fact that fd is now a pointer.
1177 (peer_create_accept) removed.
1178 * bgp_route.c: (global) adjust for change of peer fd to pointer
1179 * bgp_packet.c: (bgp_collision_detect) adjust and remove the
1180 "replace with other peer" hack.
1181 * bgp_network.c: (bgp_accept) Remove the dummy peer hack.
1182 Update peer->fd_accept instead.
1183 (global) Adjust fd references - now a pointer.
1184 * bgp_fsm.c: (global) adjust peer fd to pointer.
1185 (bgp_connection_stop) new function, to stop connection.
1186 (global) adjust everything which closed peer fd to use
1187 bgp_connection_stop().
1188
gdt10d60ad2003-12-23 17:34:39 +000011892003-12-23 Krzysztof Oledzki <oleq@ans.pl>
1190
1191 * bgp_network.c: drop privs on error cases
1192
paul6ad23f02004-02-17 19:45:10 +000011932003-08-11 kunihiro <kunihiro@zebra.org>
paulac41b2a2003-08-12 05:32:27 +00001194
1195 * bgp_route{,map}.c: Extend 'set ip next-hop' in route-maps with
1196 ability to specify 'peer-address' rather than IP.
1197
paul9238b1e2003-06-11 08:03:08 +000011982003-06-09 Paul Jakma <paul@dishone.st>
1199
1200 * bgp_clist.c (community_list_delete): honour deny statements
1201
paul445f1432003-05-16 19:00:31 +000012022003-04-19 Hasso Tepper <hasso@estpak.ee>
1203
1204 * rip_routemap.c: sync daemon's route-map commands to have same
1205 syntax
1206
12072003-01-09 Akihiro Mizutani <mizutani@net-chef.net>
1208
1209 * bgp_routemap.c: Add match extcommunity command.
1210
paul718e3742002-12-13 20:15:29 +000012112002-10-23 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1212
1213 * bgp_aspath.c (aspath_init): Extend hash size from default to
1214 32767.
1215 (aspath_key_make): Use unsigned shoft for making hash. Suggested
1216 by: Marc Evans <Marc@SoftwareHackery.Com>
1217
12182002-08-19 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1219
1220 * bgp_clist.c (community_entry_free): Fix memory leak of standard
1221 extcommunity-list config string.
1222
12232002-08-19 Akihiro Mizutani <mizutani@net-chef.net>
1224
1225 * bgp_route.c (route_vty_out_detail): Fix bug of router-id display
1226 when multiple instance is used.
1227
12282002-08-18 Akihiro Mizutani <mizutani@net-chef.net>
1229
1230 * bgpd.c: Make "default-originate" and "maximum-prefix" commands
1231 available in peer-group configuration.
1232
12332002-08-13 Akihiro Mizutani <mizutani@net-chef.net>
1234
1235 * bgp_packet.c (bgp_open_send): Put Opt Parm Len 0 when last
1236 capability packet cause error or dont-capability-negotiate option
1237 is specified.
1238
12392002-07-07 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1240
1241 * zebra-0.93 released.
1242
12432001-10-28 Kunihiro Ishiguro <kunihiro@zebra.org>
1244
1245 * bgpd.c (bgp_vty_init): Translate update commands are removed.
1246
12472001-10-10 Kunihiro Ishiguro <kunihiro@zebra.org>
1248
1249 * bgp_route.c (bgp_static_set): Add workaround for BGP static
1250 route announcement when there is no zebra running.
1251
12522001-10-08 Kunihiro Ishiguro <kunihiro@zebra.org>
1253
1254 * bgpd.c (neighbor_remote_as_unicast): Remove "remote-as nlri
1255 unicast multicast" commands.
1256
12572001-09-14 Akihiro Mizutani <mizutani@dml.com>
1258
1259 * bgp_open.c: When we receive capability route-refresh, we should
1260 check we send the capability not we receive the capability.
1261
1262 * bgp_route.c (bgp_network_mask_natural_route_map): network
1263 statement route-map is added.
1264
12652001-08-31 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1266
1267 * bgp_advertise.c (bgp_advertise_intern): attr must be interned
1268 before looking up hash table.
1269
12702001-08-30 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1271
1272 * bgpd.h (struct peer): BGP filter is moved from peer_conf to
1273 peer.
1274
12752001-08-28 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1276
1277 * bgp_nexthop.c (bnc_nexthop_free): Fix next pointer bug.
1278 Suggested by: "Hong-Sung Kim" <hoskim@lanbird.co.kr>.
1279
12802001-08-26 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1281
1282 * bgp_table.c (bgp_node_create): Clearn memory before use it.
1283
12842001-08-24 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1285
1286 * Change to use bgp_table.[ch].
1287
12882001-08-23 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1289
1290 * bgpd.c (bgp_init): Add "transparent-as" and
1291 "transparent-nexthop" for old version compatibility.
1292
12932001-08-23 Akihiro Mizutani <mizutani@dml.com>
1294
1295 * bgpd.h (struct peer): default-originate route-map is added.
1296
1297 * bgp_route.c: When self originated route is advertised with
1298 attrubute-unchanged, nexthop was not properly set. This bug is
1299 fixed.
1300
13012001-08-22 Akihiro Mizutani <mizutani@dml.com>
1302
1303 * bgpd.c (neighbor_attr_unchanged): transparent-as and
1304 transparent-next-hop commands are restructured. Instead of
1305 current transparent-* commands, attribute-unchanged command is
1306 introduced.
1307
1308 neighbor A.B.C.D attribute-unchanged [as-path|next-hop|med]
1309
1310 (neighbor_default_originate): "default-originate" configuration
1311 announce default route even 0.0.0.0/0 does not exists in BGP RIB.
1312
13132001-08-19 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1314
1315 * zebra-0.92a released.
1316
13172001-08-19 Akihiro Mizutani <mizutani@dml.com>
1318
1319 * bgpd.c: AF specific soft-reconfiguration inbound commands are
1320 added.
1321
13222001-08-17 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1323
1324 * bgp_route.c (bgp_show_callback): Do not do community NULL check.
1325
1326 * bgp_community.c (community_cmp): Add check for commnunity NULL
1327 check.
1328
1329 * bgp_routemap.c (route_match_community): Do not check comunity is
1330 NULL. It may match to community-list "^$".
1331
1332 * bgp_community.c (community_match): Add check for community is
1333 NULL case.
1334
13352001-08-17 Akihiro Mizutani <mizutani@dml.com>
1336
1337 * bgpd.c: AF specific route-reflector-client and
1338 route-server-client configuration are added.
1339
13402001-08-17 Rick Payne <rickp@ayrnetworks.com>
1341
1342 * bgp_clist.c (community_match_regexp): Check special ^$ case.
1343
13442001-08-17 Akihiro Mizutani <mizutani@dml.com>
1345
1346 * bgp_clist.c (community_list_match): Fix bug of community list
1347 permit and deny check.
1348
13492001-08-16 Akihiro Mizutani <mizutani@dml.com>
1350
1351 * bgp_mplsvpn.c (bgp_mplsvpn_init): Add AF specific "nexthop-self"
1352 command.
1353
13542001-08-15 Akihiro Mizutani <mizutani@dml.com>
1355
1356 * bgpd.h (PEER_FLAG_SEND_COMMUNITY): Per AF based configuration
1357 flag is introduced.
1358
1359 * bgp_mplsvpn.c (bgp_mplsvpn_init): VPNv4 filtering is added.
1360
13612001-08-15 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1362
1363 * zebra-0.92 released.
1364
13652001-08-13 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1366
1367 * bgpd.c (bgp_delete): "no router bgp" free static, aggregate, rib
1368 table properly.
1369
13702001-08-12 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1371
1372 * bgp_route.c (bgp_node_safi): Return SAFI of current node.
1373 (bgp_config_write_network_vpnv4): VPNv4 static configuration
1374 display.
1375
13762001-08-11 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1377
1378 * bgpd.c (no_bgp_ipv4_multicast_route_map): Add IPv4 multicast
1379 node filter commands.
1380
13812001-08-11 Kunihiro Ishiguro <kunihiro@zebra.org>
1382
1383 * bgpd.h (PEER_FLAG_IGNORE_LINK_LOCAL_NEXTHOP): Add
1384 "ignore-link-local-nexthop" flag for ignore link-local nexthop for
1385 IPv6.
1386
13872001-08-07 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1388
1389 * bgpd.c (address_family_ipv4_multicast): "address-family ipv4
1390 multicast" is added.
1391 (address_family_ipv6_unicast): "address-family ipv6 unicast" is
1392 added.
1393
13942001-08-07 Akihiro Mizutani <mizutani@dml.com>
1395
1396 * bgp_route.c (bgp_process): Use flag instead of as_selected
1397 memeber in struct bgp_info.
1398
1399 * bgp_route.h (struct bgp_info): Remove as_selected memeber from
1400 struct bgp_info.
1401
14022001-07-31 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1403
1404 * bgp_route.c (bgp_announce_check): Enclose sending time AS loop
1405 check code with #ifdef BGP_SEND_ASPATH_CHECK.
1406
14072001-07-29 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1408
1409 * bgp_packet.c (bgp_withdraw_send): Simplify address family check.
1410
1411 * bgpd.h (BGP_INFO_HOLDDOWN): Introduce new macro to check BGP
1412 information is alive or not.
1413
1414 * bgp_community.c: Use community_val_get() on all OS.
1415
14162001-07-24 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1417
1418 * bgp_route.c (bgp_announce_check): Simplify set next-hop self
1419 check.
1420
14212001-07-24 Akihiro Mizutani <mizutani@dml.com>
1422
1423 * bgp_route.c (bgp_announce_check): To route server clients, we
1424 announce AS path, MED and nexthop transparently.
1425
14262001-06-21 Kunihiro Ishiguro <kunihiro@zebra.org>
1427
1428 * bgp_routemap.c (route_set_atomic_aggregate_free): Do not call
1429 XFREE. No memory is allocated in
1430 route_set_atomic_aggregate_compile().
1431
14322001-06-21 Kunihiro Ishiguro <kunihiro@zebra.org>
1433
1434 * bgp_routemap.c (bgp_route_map_init): `match nlri` and `set nlri`
1435 are replaced by `address-family ipv4` and `address-family vpnvr'.
1436
14372001-06-19 Kunihiro Ishiguro <kunihiro@zebra.org>
1438
1439 * bgp_route.c (bgp_withdraw): Add check for BGP_PEER_CONFED.
1440 Reported by Rick Payne <rickp@rossfell.co.uk>.
1441
14422001-06-17 Kunihiro Ishiguro <kunihiro@zebra.org>
1443
1444 * bgp_zebra.c (bgp_zebra_announce): When global IPv6 nexthop is
1445 empty, use socket's remote address for the nexthop.
1446
14472001-06-04 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1448
1449 * bgpd.c (peer_delete): Fix memory leak. Reported by Yosi Yarchi
1450 <Yosi_Yarchi@KereniX.com>
1451
14522001-06-01 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1453
1454 * bgpd.c (bgp_delete): Fix memory leak. Reported by Yosi Yarchi
1455 <Yosi_Yarchi@KereniX.com>
1456
14572001-05-27 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1458
1459 * bgp_route.c (bgp_route_clear_with_afi_vpnv4): Use next instead
1460 of ri->next.
1461
1462 * bgp_packet.c (bgp_withdraw_send): MPLS/VPN withdraw takes effect
1463 when HAVE_IPV6 is not defined.
1464
14652001-03-07 "Akihiro Mizutani" <mizutani@dml.com>
1466
1467 * bgpd.c (peer_timers_set): Adjust keepalive timer to fit less
1468 than holdtime / 3.
1469 (bgp_confederation_peers_unset): Only set peer->local_as when
1470 confederation is enabled.
1471 (bgp_timers): Add "timers bgp <0-65535> <0-65535>" command.
1472
1473 * bgp_route.c (bgp_announce_check): Set med of redistributed route
1474 when it is announced to EBGP peer.
1475
14762001-03-06 "Akihiro Mizutani" <mizutani@dml.com>
1477
1478 * bgp_nexthop.c (bgp_scan_ipv4): bgp_scan() call bgp_process() for
1479 all prefixes.
1480
14812001-03-06 Kunihiro Ishiguro <kunihiro@zebra.org>
1482
1483 * bgp_attr.c (bgp_attr_origin): When bgpd send NOTIFICATION with
1484 erroneous attribute (type, length and value), it does include
1485 attribute flags field.
1486
14872001-02-21 "Akihiro Mizutani" <mizutani@dml.com>
1488
1489 * bgp_route.c (bgp_announce_check): The route reflector is not
1490 allowed to modify the attributes of the reflected IBGP routes.
1491
14922001-02-20 "Akihiro Mizutani" <mizutani@dml.com>
1493
1494 * bgp_route.c (bgp_info_cmp): During path seleciton, BGP
1495 confederation peer is treated as same as IBGP peer.
1496
14972001-02-19 Kunihiro Ishiguro <kunihiro@zebra.org>
1498
1499 * bgp_route.c (bgp_redistribute_add): Initialize attr_new with
1500 attr. Call aspath_unintern when return from this function.
1501
15022001-02-19 "Akihiro Mizutani" <mizutani@dml.com>
1503
1504 * bgpd.c (bgp_router_id_set): Reset BGP peer when router-id is
1505 changed.
1506
15072001-02-18 "Akihiro Mizutani" <mizutani@dml.com>
1508
1509 * bgp_packet.c (bgp_open_receive): When user configure holdtimer,
1510 do not refrect the value to current session.
1511
15122001-02-16 Kunihiro Ishiguro <kunihiro@zebra.org>
1513
1514 * bgp_route.c (bgp_aggregate_delete): Set BGP_INFO_ATTR_CHANGE to
1515 suppress route withdraw.
1516
1517 * bgp_damp.c (bgp_damp_init): Fix bug of flap dampening.
1518
15192001-02-16 "Akihiro Mizutani" <mizutani@dml.com>
1520
1521 * bgp_aspath.c (aspath_make_str_count): Use ',' for separator for
1522 AS_SET and AS_CONFED_SET.
1523
15242001-02-15 Kunihiro Ishiguro <kunihiro@zebra.org>
1525
1526 * bgp_route.c (bgp_process): Do not consider suppress route.
1527
1528 * bgp_aspath.c (aspath_aggregate_as_set_add): Reset asset when
1529 aspath->data is realloced.
1530
15312001-02-15 "Akihiro Mizutani" <mizutani@dml.com>
1532
1533 * bgp_attr.c (bgp_attr_aggregate_intern): Do not set atomic
1534 aggregate when using as-set.
1535
15362001-02-14 "Akihiro Mizutani" <mizutani@dml.com>
1537
1538 * bgpd.c (bgp_confederation_peers_unset): Set peer's local-as
1539 correctly.
1540
1541 * bgp_route.c (bgp_update): Just ignore AS path loop for
1542 confederation peer.
1543
15442001-02-10 Kunihiro Ishiguro <kunihiro@zebra.org>
1545
1546 * bgp_route.c (bgp_aggregate_set): Add as_set argument.
1547 (bgp_aggregate_unset): Remove summary_only argument.
1548 (aggregate_address_as_set): New commands.
1549 "aggregate-address A.B.C.D/M as-set"
1550 "no aggregate-address A.B.C.D/M as-set"
1551
15522001-02-08 "Akihiro Mizutani" <mizutani@dml.com>
1553
1554 * bgp_route.c (bgp_announce_check): Do not modify nexthop when the
1555 route is passed by route reflector.
1556
15572001-02-08 Kunihiro Ishiguro <kunihiro@zebra.org>
1558
1559 * bgp_route.c: "no bgp dampening" with argument.
1560 (bgp_announce_check): Do not modify nexthop when the route is
1561 passed by route reflector.
1562
15632001-02-07 "Akihiro Mizutani" <mizutani@dml.com>
1564
1565 * bgpd.c (neighbor_passive): Change "neighbor NEIGHBOR remote-as
1566 ASN passive" to "neighbor NEIGHBOR passive".
1567 (bgp_announce_check): Check well-known community attribute even
1568 when "no neighbor send-community" is set.
1569
15702001-02-03 Kunihiro Ishiguro <kunihiro@zebra.org>
1571
1572 * bgp_fsm.c (bgp_establish): Do not send keepalive at established
1573 time when keepalive timer is configured as zero.
1574
15752001-02-01 Kunihiro Ishiguro <kunihiro@zebra.org>
1576
1577 * bgp_attr.c (bgp_attr_check): When peer is IBGP peer, local
1578 preference is well-known attribute.
1579
15802001-01-30 Kunihiro Ishiguro <kunihiro@zebra.org>
1581
1582 * zebra-0.91 is released.
1583
1584 * bgp_attr.h (struct attr): Comment out DPA value.
1585 (struct attr): Change refcnt type from int to unsinged long.
1586
1587 * bgp_attr.c (attrhash_key_make): Likewise.
1588 (attrhash_cmp): Likewise.
1589 (bgp_attr_dpa): Likewise.
1590
15912001-01-30 "Akihiro Mizutani" <mizutani@dml.com>
1592
1593 * bgp_route.c (bgp_info_cmp): Make route selection completely same
1594 as Cisco's.
1595
15962001-01-30 Kunihiro Ishiguro <kunihiro@zebra.org>
1597
1598 * bgp_attr.h (BGP_ATTR_FLAG_OPTIONAL): Rename old ATTR_FLAG_* to
1599 BGP_ATTR_FLAG_* to clarify meenings.
1600
16012001-01-30 "Akihiro Mizutani" <mizutani@dml.com>
1602
1603 * bgp_route.c (route_vty_out): Display argument to suppress same
1604 prefix information display.
1605 (route_vty_out_route): Don't display mask information for
1606 classfull network.
1607
16082001-01-30 Kunihiro Ishiguro <kunihiro@zebra.org>
1609
1610 * bgp_attr.h (SET_BITMAP): Simple bitmapping macros.
1611
1612 * bgp_attr.c (bgp_attr_parse): Use bitmap for attribute type
1613 check.
1614
16152001-01-29 Kunihiro Ishiguro <kunihiro@zebra.org>
1616
1617 * bgp_attr.c (bgp_mp_reach_parse): Enclose loggin with BGP_DEBUG.
1618 (bgp_attr_parse): Comment out well-known attribute check.
1619
16202001-01-28 Kunihiro Ishiguro <kunihiro@zebra.org>
1621
1622 * bgp_route.c (bgp_static_unset): Link-local IPv6 address can't be
1623 used for network advertisement.
1624 (nlri_parse): When link-local IPv6 address NLRI comes from
1625 remote-peer, log the information then simply ignore it.
1626
1627 * bgp_zebra.c (zebra_read_ipv6): Link-local IPv6 address is not
1628 redistributed.
1629
1630 * bgp_route.c (bgp_update): Check IPv6 global nexthop
1631 reachability.
1632
16332001-01-26 Kunihiro Ishiguro <kunihiro@zebra.org>
1634
1635 * bgp_route.c (bgp_update): Check nexthop points local address or
1636 not.
1637 (bgp_static_update_vpnv4): Set valid flag.
1638
1639 * bgp_attr.c (bgp_attr_parse): Duplicate attribute check.
1640 (bgp_attr_parse): Well-known attribute check.
1641
1642 * bgp_open.c (bgp_auth_parse): Authentication is not yet supported.
1643
1644 * bgp_packet.c (bgp_valid_marker): Check marker is synchronized.
1645
1646 * bgpd.c (clear_bgp): Send NOTIFICATION Cease when SEND_CEASE is
1647 defined.
1648
1649 * bgp_snmp.c (bgp4PathAttrTable): Fix compile error.
1650
16512001-01-24 Kunihiro Ishiguro <kunihiro@zebra.org>
1652
1653 * bgpd.c (bgp_network_import_check): New command for IGP network
1654 check.
1655
16562001-01-23 Kunihiro Ishiguro <kunihiro@zebra.org>
1657
1658 * bgp_nexthop.c (bgp_scan): Run bgp_process when IGP metric is
1659 changed. Call bgp_process once for each node.
1660
16612001-01-23 "Akihiro Mizutani" <mizutani@dml.com>
1662
1663 * bgp_route.c (bgp_info_cmp): Add IGP metric comparison.
1664
16652001-01-23 Kunihiro Ishiguro <kunihiro@zebra.org>
1666
1667 * bgp_route.c (bgp_info_cmp): Add IGP metric comparison.
1668
1669 * bgp_nexthop.c (bgp_nexthop_lookup): Set IGP metric for valid
1670 IBGP route.
1671
16722001-01-23 "Akihiro Mizutani" <mizutani@dml.com>
1673
1674 * bgp_route.c (show_ip_bgp_prefix_longer): Add new commands.
1675 "show ip bgp A.B.C.D/M longer-prefixes"
1676 "show ip bgp ipv4 (unicast|multicast) A.B.C.D/M longer-prefixes"
1677 "show ipv6 bgp X:X::X:X/M longer-prefixes"
1678 "show ipv6 mbgp X:X::X:X/M longer-prefixes"
1679
16802001-01-20 "Akihiro Mizutani" <mizutani@dml.com>
1681
1682 * bgp_route.c (show_ip_bgp_cidr_only): Add new commands.
1683 "show ip bgp cidr-only"
1684 "show ip bgp ipv4 (unicast|multicast) cidr-only"
1685
16862001-01-18 "Akihiro Mizutani" <mizutani@dml.com>
1687
1688 * bgp_route.c (bgp_update): AS path lookup check is done in
1689 bgp_update() not in attr_parse().
1690
16912001-01-18 Kunihiro Ishiguro <kunihiro@zebra.org>
1692
1693 * bgp_route.c (bgp_update): Call bgp_aggregate_decrement() just
1694 before bgp_attr_unintern().
1695
16962001-01-17 Kunihiro Ishiguro <kunihiro@zebra.org>
1697
1698 * bgp_route.c (bgp_update): Now intern is performed very last part
1699 of the BGP packet update procedure.
1700
17012001-01-17 "Akihiro Mizutani" <mizutani@dml.com>
1702
1703 * bgp_route.c (bgp_update): When implicit withdraw occur, reuse
1704 existing bgp_info structure.
1705
17062001-01-17 Kunihiro Ishiguro <kunihiro@zebra.org>
1707
1708 * bgp_route.c (bgp_aggregate_decrement): Fix bug of aggregate
1709 address matching method.
1710 (bgp_update):
1711
1712 * bgp_nexthop.c (bgp_nexthop_onlink): Separate EBGP nexthop onlink
1713 check and IBGP nexthop route check.
1714
17152001-01-16 "Akihiro Mizutani" <mizutani@dml.com>
1716
1717 * bgp_route.h (BGP_INFO_ATRR_CHANGED): Added for track attribute
1718 change.
1719
17202001-01-16 Kunihiro Ishiguro <kunihiro@zebra.org>
1721
1722 * bgp_route.h (struct bgp_info): Remove selected flag. Use
1723 BGP_INFO_SELECTED for flags instead.
1724 (struct bgp_info): Remove valid flag. Use BGP_INFO_VALID for
1725 flags instead.
1726 (struct bgp_info): Add igpmetric for IBGP route nexthop IGP
1727 metric.
1728 (struct bgp_info_tab): Struct bgp_info_tag is integrated into
1729 struct bgp_info.
1730 (BGP_INFO_ATRR_CHANGED): Added for track attribute change.
1731
1732 * bgp_community.c (community_val_get): gcc-2.95 on
1733 sparc-sun-solaris cause crush. This function is for avoid the
1734 crush.
1735
17362001-01-15 Kunihiro Ishiguro <kunihiro@zebra.org>
1737
1738 * bgp_packet.c (bgp_open_receive): Translated peer's packet_size
1739 clear bug is fixed.
1740
17412001-01-14 "Akihiro Mizutani" <mizutani@dml.com>
1742
1743 * bgp_packet.c (bgp_open_receive): Return notification with
1744 supported version number.
1745
17462001-01-13 Kunihiro Ishiguro <kunihiro@zebra.org>
1747
1748 * bgpd.c (bgp_show_summary): Display AS path and community
1749 entries. Suggested by: "Matt Ranney" <mjr@ranney.com>.
1750
1751 * bgp_packet.c (bgp_read_packet): Fix bug of unblocking BGP socket
1752 read. When BGP packet read is partial, we must get size and type
1753 from packet again.
1754
17552001-01-12 "Akihiro Mizutani" <mizutani@dml.com>
1756
1757 * bgp_route.c (bgp_update): Do not unset BGP_INFO_HISTORY flag.
1758 (bgp_update): When there is a history entry increment route count.
1759 (bgp_damp_set): Check BGP_CONFIG_DAMPENING flag.
1760
1761 * bgp_damp.c (bgp_damp_withdraw): Set status to
1762 BGP_DAMP_DISCONTINUE.
1763
17642001-01-11 Kunihiro Ishiguro <kunihiro@zebra.org>
1765
1766 * bgp_attr.c (bgp_mp_reach_parse): Fix warning code when second
1767 IPv6 nexthop is not link-local addresss.
1768
17692001-01-11 "Akihiro Mizutani" <mizutani@dml.com>
1770
1771 * bgp_damp.c (bgp_config_write_damp): Smart flap dampening
1772 configuration display.
1773 (bgp_damp_info_print): Display elapsed time from flap started.
1774
1775 * bgp_damp.h (struct bgp_damp_info): Add flap start time.
1776
1777 * bgpd.c (peer_create): Set last read time.
1778 (bgp_show_peer): Display last read time.
1779 (bgp_show_summary): Use BGP_CONFIG_DAMPENING flag to check
1780 configuration.
1781
1782 * bgpd.h (BGP_CONFIG_DAMPENING): Add new configuration option.
1783 (struct peer): Add last read time member.
1784 (BGP_VERSION_MP_4): Remove obsolete definition.
1785
17862001-01-10 Kunihiro Ishiguro <kunihiro@zebra.org>
1787
1788 * bgp_nexthop.c: Remove OLD_RIB codes.
1789
1790 * bgp_route.c (bgp_process): Likewise.
1791
1792 * zebra-0.90 is released.
1793
1794 * bgp_route.h (BGP_INFO_HISTORY): Remove damped member from struct
1795 bgp_info. Instead of that use BGP_INFO_DAMPED flag.
1796 (struct bgp_info): Remove invalid member from struct bgp_info.
1797 Instead of that use BGP_INFO_HISTORY flag.
1798
17992001-01-10 "Akihiro Mizutani" <mizutani@dml.com>
1800
1801 * bgp_damp.c (bgp_damp_info_print): New function to display
1802 dampening status.
1803 (DEFAULT_HARF_LIFE): Define default value.
1804 (DEFAULT_REUSE): Likewise.
1805 (DEFAULT_SUPPRESS): Likewise.
1806 (bgp_config_write_damp): When config value is same as default
1807 value, simply display "bgp dampening" to configuration.
1808
1809 * bgp_damp.h (struct bgp_damp_info): Add flap member.
1810
1811 * bgp_route.h (struct bgp_info): Added for BGP flap dampening
1812 history status.
1813
18142001-01-10 Kunihiro Ishiguro <kunihiro@zebra.org>
1815
1816 * bgp_nexthop.c (bgp_connected_add): Point-to-point connected
1817 address is properly handled.
1818 (bgp_connected_delete): Likewise.
1819
1820 * bgp_route.c (bgp_route_init): Turn off BGP Flap dampening code
1821 until it works fine.
1822
18232001-01-09 Kunihiro Ishiguro <kunihiro@zebra.org>
1824
1825 * bgpd.c (bgp_show_summary): Add BGP_VERSION_MP_4 case.
1826
1827 * bgp_route.c (bgp_update): When this is not damped route, clear
1828 ri pointer.
1829
18302001-01-09 Kunihiro Ishiguro <kunihiro@zebra.org>
1831
1832 * bgp_main.c: Add "-n" no_kernel option to not install route to
1833 kernel. Suggested by: "Matt Ranney" <mjr@ranney.com>
1834
18352001-01-09 Kunihiro Ishiguro <kunihiro@zebra.org>
1836
1837 * bgp_nexthop.c (bgp_connected_add): Revert point-to-point
1838 connected route patch. Reported by ruud@ruud.org (Ruud de Rooij)
1839
1840 * bgp_damp.c (bgp_config_write_damp): Add configuration display
1841 function.
1842
1843 * bgp_route.c (bgp_info_free): Set NULL to BGP dampening
1844 information when BGP info structure is freed.
1845 (bgp_info_cmp): Check damped flag.
1846 (bgp_announce_check): Damped route is not announced.
1847
18482001-01-09 "Akihiro Mizutani" <mizutani@dml.com>
1849
1850 * bgpd.c (neighbor_capability_route_refresh): Change "neighbor
1851 route-refresh" command to "neighbor capability route-refresh".
1852 (clear_bgp_soft_in): Change soft-reconfig method.
1853
1854 clear ip bgp <neighbor> soft in
1855 --------------------------------------
1856 Try stored cache first then route-refresh
1857
1858 clear ip bgp <neighbor> in
1859 ---------------------------------
1860 Try route-refresh first then try to use stored cache
1861
18622001-01-09 Kunihiro Ishiguro <kunihiro@zebra.org>
1863
1864 * bgp_nexthop.c (bgp_connected_add): Check point-to-point
1865 connected route. Reported by ruud@ruud.org (Ruud de Rooij)
1866
18672001-01-08 Kunihiro Ishiguro <kunihiro@zebra.org>
1868
1869 * bgp_nexthop.c (bgp_nexthop_lookup): When IBGP nexthop is
1870 changed, refresh it.
1871
18722001-01-04 Kunihiro Ishiguro <kunihiro@zebra.org>
1873
1874 * bgp_route.h (struct bgp_info_tag): Add as_selected to
1875 bgp_info_tag.
1876
18772001-01-03 Kunihiro Ishiguro <kunihiro@zebra.org>
1878
1879 * bgp_route.h (struct bgp_info_tag): Add damped and bgp_damp_info
1880 member for BGP flap dampening.
1881
1882 * bgp_damp.c: New file is added.
1883
1884 * bgp_damp.h: Likewise.
1885
18862001-01-01 Kunihiro Ishiguro <kunihiro@zebra.org>
1887
1888 * bgpd.h (BGP_VTYSH_PATH): Change "/tmp/bgpd" to "/tmp/.bgpd".
1889
18902000-12-29 Kunihiro Ishiguro <kunihiro@zebra.org>
1891
1892 * bgp_nexthop.c (zlookup_connect): Change to use UNIX domain
1893 socket for zebra communication.
1894
18952000-12-29 Akihiro Mizutani <mizutani@dml.com>
1896
1897 * bgp_route.c (bgp_process): Fix "bgp deterministic-med" process.
1898
18992000-12-27 Akihiro Mizutani <mizutani@dml.com>
1900
1901 * bgp_route.c (bgp_process): Add "bgp deterministic-med" process.
1902
19032000-12-25 Akihiro Mizutani <mizutani@dml.com>
1904
1905 * bgp_route.c (bgp_info_cmp): Use ntohl comparing router ID.
1906
19072000-12-18 Akihiro Mizutani <mizutani@dml.com>
1908
1909 * bgp_route.c (bgp_info_cmp): When over three same prefix exit,
1910 withdrawing best prefix perform router ID comparison.
1911
19122000-12-15 Akihiro Mizutani <mizutani@dml.com>
1913
1914 * bgp_route.c (bgp_info_cmp): Do not compare router ID when the
1915 routes comes from EBGP peer. When originator ID is same, take
1916 shorter cluster-list route. If cluster-list is same take smaller
1917 IP address neighbor's route.
1918
1919 * bgpd.c (bgp_bestpath_aspath_ignore): Add "bgp bestpath as-path
1920 ignore" command. When this option is set, do not concider AS path
1921 length when route selection.
1922 (bgp_bestpath_compare_router_id): Add "bgp bestpath
1923 compare-routerid". When this option is set, compare router ID
1924 when the routes comes from EBGP peer.
1925
19262000-12-15 Akihiro Mizutani <mizutani@dml.com>
1927
1928 * bgp_route.c (bgp_info_cmp): Compare originator ID when it is
1929 available.
1930
19312000-12-14 Akihiro Mizutani <mizutani@dml.com>
1932
1933 * bgp_packet.c (bgp_notify_receive): Disply received Notify data
1934 information.
1935
19362000-12-14 Kunihiro Ishiguro <kunihiro@zebra.org>
1937
1938 * bgp_filter.c (as_filter_free): Use MTYPE_AS_FILTER_STR to make
1939 it sure the memory is freed.
1940
1941 * bgp_route.c (route_vty_out_detail): Do not use AF_INET6 outside
1942 HAVE_IPV6.
1943
19442000-12-08 Akihiro Mizutani <mizutani@dml.com>
1945
1946 * bgp_packet.c (bgp_notify_send_with_data): Store BGP notification
1947 data part.
1948
1949 * bgp_network.c (bgp_accept): When BGP connection comes from
1950 unconfigured IP address, close socket immediately.
1951
1952 * bgpd.c: Fix some display format.
1953
19542000-11-29 Kunihiro Ishiguro <kunihiro@zebra.org>
1955
1956 * bgp_packet.c (bgp_keepalive_send): Delete duplicate
1957 bgp_packet_set_size () call.
1958
19592000-11-28 Kunihiro Ishiguro <kunihiro@zebra.org>
1960
1961 * bgp_packet.c (bgp_read_packet): Remove debug codes.
1962
19632000-11-27 Kunihiro Ishiguro <kunihiro@zebra.org>
1964
1965 * bgp_snmp.c (write_bgpPeerTable): Add SNMP set method routine.
1966
1967 * bgp_fsm.c (bgp_stop): Use fsm_change_status to change peer's
1968 status.
1969 (bgp_establish): Likewise.
1970
19712000-11-26 Akihiro Mizutani <mizutani@dml.com>
1972
1973 * bgp_open.c: Fix error messages.
1974
19752000-11-25 Kunihiro Ishiguro <kunihiro@zebra.org>
1976
1977 * bgp_fsm.c (bgp_establish): Call BGP trap when the peer is
1978 established.
1979 (bgp_stop): Call BGP trap when the peer is dropped.
1980
19812000-11-24 Kunihiro Ishiguro <kunihiro@zebra.org>
1982
1983 * bgp_snmp.c (bgp4PathAttrTable): Return BGP path attribute table.
1984
1985 * bgpd.h (struct peer): Add update_time for track last update
1986 received time.
1987
1988 * bgp_packet.c (bgp_notify_receive): Preserv notify code and sub
1989 code in any case.
1990
1991 * bgp_snmp.c (bgpPeerTable): Return remote router ID instead of
1992 peering IP address.
1993 (bgpPeerTable): Return actual BGP version number.
1994
19952000-11-22 Akihiro Mizutani <mizutani@dml.com>
1996
1997 * bgp_debug.c (bgp_notify_print): Notify data length display bug
1998 is fixed.
1999
20002000-11-16 Kunihiro Ishiguro <kunihiro@zebra.org>
2001
2002 * bgp_nexthop.c (zlookup_connect): When UNIX domain connection to
2003 zebra is enabled, use the method.
2004
20052000-11-16 Akihiro Mizutani <mizutani@dml.com>
2006
2007 * bgpd.c: Revise debug message output.
2008
20092000-11-15 Akihiro Mizutani <mizutani@dml.com>
2010
2011 * bgp_clist.c (ip_community_list): Fix bug of string comparison.
2012
20132000-11-14 Akihiro Mizutani <mizutani@dml.com>
2014
2015 * bgp_community.c (community_match): Fix bug of memcmp return
2016 value check.
2017
20182000-11-07 Kunihiro Ishiguro <kunihiro@zebra.org>
2019
2020 * bgp_clist.c (community_list_match_exact): Add check for
2021 entry->style is COMMUNITY_LIST.
2022 (community_match_regexp): Apply new com_nthval macro.
2023
20242000-11-07 Rick Payne <rickp@rossfell.co.uk>
2025
2026 * bgp_routemap.c (route_set_community_delete): "set
2027 community-delete COMMUNITY-LIST" is added.
2028
2029 * bgp_community.c (community_del_val): Delete one community.
2030 (community_delete): Delete all community included in list.
2031 (community_match): Fix bug of matching community value.
2032
2033 * bgp_clist.c (community_entry_free): Free community regular
2034 expression.
2035 (community_entry_make): Default style is COMMUNITY_LIST.
2036 (community_entry_lookup): Make it sure style is COMMUNITY_LIST.
2037 (community_entry_regexp_lookup): New function for community
2038 regular expression lookup.
2039 (community_match_regexp): New function.
2040 (community_delete_regexp): New function.
2041 (community_list_delete_entries): New function.
2042 (community_list_match): Add COMMUNITY_REGEXP treatment.
2043 (community_list_match_exact): Likewise.
2044 (config_write_community): Write community list according to
2045 entry->style.
2046
20472000-11-07 Rick Payne <rickp@rossfell.co.uk>
2048
2049 * bgp_attr.c (bgp_attr_aspath): AS path first AS check.
2050
2051 * bgp_clist.c (struct community_entry): Add style, regexp, reg to
2052 community_entry.
2053
20542000-11-06 Rick Payne <rickp@rossfell.co.uk>
2055
2056 * bgp_aspath.c (aspath_firstas_check): AS path first AS check.
2057
2058 * bgpd.c (bgp_enforce_first_as): New command "bgp
2059 enforce-first-as".
2060
2061 * bgpd.h (BGP_CONFIG_ENFORCE_FIRST_AS): Add new flag.
2062
20632000-11-06 Kunihiro Ishiguro <kunihiro@zebra.org>
2064
2065 * bgp_community.c (community_compare): Copy byte stream data to
2066 actual value instead of using type casting hack.
2067 (community_add_val): Likewise.
2068 (community_uniq_sort): Likewise.
2069 (community_print): Likewise.
2070 (community_print_vty): Likewise.
2071 (community_include): Use memcmp to compare community value.
2072
2073 * bgp_community.h (com_lastval): com_lastval and com_nthval macro
2074 return pointer.
2075
20762000-11-06 Akihiro Mizutani <mizutani@dml.com>
2077
2078 * bgpd.h (struct peer): Add established and dropped member for
2079 count peering up/down statistics.
2080
2081 * bgpd.c (bgp_show_peer): Display peering up/down statistics.
2082
2083 * bgp_fsm.c (bgp_establish): Increment established count.
2084 (bgp_stop): Increment dropped count.
2085
2086 * bgp_packet.c (bgp_notify_receive): Increament notify count.
2087
20882000-11-1 Akihiro Mizutani <mizutani@dml.com>
2089
2090 * bgp_fsm.c: Fix bug of holdtimer is not reset when bgp cleared.
2091
20922000-10-31 Kunihiro Ishiguro <kunihiro@zebra.org>
2093
2094 * bgpd.h: Static bit flag is set by (1 << DIGIT).
2095
20962000-10-24 Akihiro Mizutani <mizutani@dml.com>
2097
2098 * bgp_ecommunity.c (ecommunity_dup): Extended community display
2099 format fix.
2100
21012000-10-24 Arkadiusz Miskiewicz <misiek@pld.org.pl>
2102
2103 * bgp_network.c (bgp_serv_sock_addrinfo): Use gai_strerror.
2104 (bgp_serv_sock_addrinfo): Check address family.
2105
21062000-10-23 Jochen Friedrich <jochen@scram.de>
2107
2108 * bgp_snmp.c: bgp_oid and bgpd_oid are used in smux_open after it
2109 is registered. So those variables must be static.
2110
21112000-10-23 Akihiro Mizutani <mizutani@dml.com>
2112
2113 * bgp_routemap.c (route_match_ip_next_hop): Change "match ip
2114 next-hop" argument from IP address to access-list name.
2115 Remove zebra-0.88 compatibility commands.
2116 "match ip prefix-list WORD"
2117 "match ipv6 prefix-list WORD"
2118
21192000-10-23 Kunihiro Ishiguro <kunihiro@zebra.org>
2120
2121 * bgp_routemap.c (route_match_ipv6_next_hop_compile): Fix bug of
2122 passing the pointer to the pointer of struct in6_addr instead of
2123 the pointer of struct in6_addr in "match ipv6 next-hop" command.
2124
2125 * bgp_route.c (bgp_announce_check): Enclose IPv6 part with
2126 HAVE_IPV6.
2127
21282000-10-20 Jasper Wallace <jasper@ivision.co.uk>
2129
2130 * bgp_snmp.c (bgpPeerTable): ntohs missing bug is fixed. Change
2131 to use linklist.c. Define COUNTER32 as ASN_COUNTER.
2132
21332000-10-18 Kunihiro Ishiguro <kunihiro@zebra.org>
2134
2135 * bgp_route.c (bgp_announce_check): attr->nexthop empty check
2136 should be done by attr->nexthop.s_addr instead of strcmp.
2137
21382000-10-18 Akihiro Mizutani <mizutani@dml.com>
2139
2140 * bgp_zebra.c (zebra_read_ipv4): Pass nexthop value to
2141 bgp_redistribute_add().
2142
2143 * bgp_nexthop.c (bgp_multiaccess_check_v4): New function for
2144 checking IPv4 multiaccess nexthop.
2145
2146 * bgp_route.c (bgp_announce_check): In case of the nexthop is
2147 reachable on multiaccess media, do not change nexthop.
2148 (bgp_redistribute_add): Set nexthop when the value is passed.
2149
21502000-10-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2151
2152 * bgp_fsm.c (bgp_timer_set): If peer is passive mode, do not set
2153 connect timer.
2154 (bgp_start): If the peer is passive mode, force to move to Active
2155 mode.
2156
21572000-10-17 Horms <horms@vergenet.net>
2158
2159 * bgp_debug.c (debug_bgp_fsm): Fix typo.
2160
21612000-10-17 Akihiro Mizutani <mizutani@dml.com>
2162
2163 * bgp_route.c: "show ipv6 bgp" route display improvement.
2164
21652000-10-03 Kunihiro Ishiguro <kunihiro@zebra.org>
2166
2167 * bgp_route.c (neighbor_routes): Allocate sockunion for callback
2168 function.
2169 (bgp_show_neighbor_route): Remove static declaration for union
2170 sockunion.
2171
2172 * bgpd.c (peer_update_source_set): Clean previously allocated
2173 memory before allocate new one.
2174
21752000-10-03 Akihiro Mizutani <mizutani@dml.com>
2176
2177 * bgp_route.c (neighbor_routes): Add show neighbor's routes
2178 command.
2179 "show ip bgp neighbors (A.B.C.D|X:X::X:X) routes"
2180 "show ip bgp ipv4 (unicast|multicast) neighbors (A.B.C.D|X:X::X:X) routes"
2181 "show ipv6 bgp neighbors (A.B.C.D|X:X::X:X) routes"
2182 "show ipv6 mbgp neighbors (A.B.C.D|X:X::X:X) routes"
2183
21842000-10-02 Kunihiro Ishiguro <kunihiro@zebra.org>
2185
2186 * zebra-0.89 is released.
2187
21882000-10-02 Akihiro Mizutani <mizutani@dml.com>
2189
2190 * bgpd.c: "bgp deterministic-med" command is added.
2191
21922000-10-02 Kunihiro Ishiguro <kunihiro@zebra.org>
2193
2194 * bgp_nexthop.c (bgp_connected_add): Apply mask for connected
2195 route addition and deletion.
2196
21972000-09-29 Kunihiro Ishiguro <kunihiro@zebra.org>
2198
2199 * bgp_aspath.c (aspath_cmp_left): Skip confederation AS segment
2200 when comparing leftmost AS number.
2201
22022000-09-29 Akihiro Mizutani <mizutani@dml.com>
2203
2204 * bgpd.c (peer_route_reflector): Route reflector can be set for
2205 IBGP peer.
2206 (bgp_distribute_set): Fix bug of string check for (in|out).
2207 (bgp_show_summary): Display total neighbor count.
2208
22092000-09-28 Akihiro Mizutani <mizutani@dml.com>
2210
2211 * bgp_attr.c (bgp_packet_attribute): Only add cluster_list and
2212 originator for clinet to client routes.
2213 (bgp_packet_attribute): Add new cluster_list to the beginning of
2214 existing cluster_list.
2215 (bgp_packet_attribute): Fix bug of originator is rewritten even
2216 when originator is already set.
2217
22182000-09-27 Kunihiro Ishiguro <kunihiro@zebra.org>
2219
2220 * bgpd.c (bgp_client_to_client_reflection): Add new command.
2221 "no bgp client-to-client reflection"
2222 "bgp client-to-client reflection"
2223
2224 * bgpd.h (BGP_CONFIG_NO_CLIENT_TO_CLIENT): Add new definition.
2225
22262000-09-26 Kunihiro Ishiguro <kunihiro@zebra.org>
2227
2228 * bgp_packet.c (bgp_read): Make BGP packet read to non-blocking
2229 read.
2230 (bgp_read_packet): Likewise.
2231 (bgp_read_packet): When errono is EAGAIN, try to read it again.
2232
2233 * bgp_fsm.c (bgp_stop): Clear packet size and read buffer.
2234
22352000-09-26 Akihiro Mizutani <mizutani@dml.com>
2236
2237 * bgp_routemap.c: Configuration of prefix-list match is shown as
2238 "match ip address prefix-list <WORD>". Old configuration "match
2239 ip prefix-list <WORD>" is left for compatibilitty.
2240
22412000-09-25 Akihiro Mizutani <mizutani@dml.com>
2242
2243 * bgpd.h (BGP_CONFIG_MED_MISSING_AS_WORST): Changed from
2244 BGP_CONFIG_MISSING_AS_WORST.
2245
2246 * bgpd.c (bgp_bestpath_med): Change missing-as-worst syntax.
2247 Old "bgp bestpath missing-as-worst"
2248 New "bgp bestpath med missing-as-worst"
2249
22502000-09-24 Akihiro Mizutani <mizutani@dml.com>
2251
2252 * bgp_route.c: Compare MED properly in case of CONFED-IBGP.
2253
22542000-09-21 steve@Watt.COM (Steve Watt)
2255
2256 * bgp_debug.h: Do not declare debug variables conf_bgp_debug_* and
2257 term_bgp_debug_*.
2258
2259 * bgp_debug.c: Declare variables here.
2260
22612000-09-21 Akihiro Mizutani <mizutani@dml.com>
2262
2263 * bgpd.c: MBGP soft-reconfiguration command is added.
2264 clear ip bgp x.x.x.x ipv4 (unicast|multicast) in
2265 clear ip bgp x.x.x.x ipv4 (unicast|multicast) out
2266 clear ip bgp x.x.x.x ipv4 (unicast|multicast) soft
2267 clear ip bgp <1-65535> ipv4 (unicast|multicast) in
2268 clear ip bgp <1-65535> ipv4 (unicast|multicast) out
2269 clear ip bgp <1-65535> ipv4 (unicast|multicast) soft
2270 clear ip bgp * ipv4 (unicast|multicast) in
2271 clear ip bgp * ipv4 (unicast|multicast) out
2272 clear ip bgp * ipv4 (unicast|multicast) soft
2273
2274 Change "clear ip bgp vpnv4 x.x.x.x soft" command to
2275 "clear ip bgp x.x.x.x vpnv4 unicast soft".
2276
2277 "bgp bestpath med confed" command is added.
2278
2279 * bgpd.h (BGP_CONFIG_MED_CONFED): Add New definition.
2280
22812000-09-18 Rick Payne <rickp@rossfell.co.uk>
2282
2283 * bgpd.c (bgp_show_peer): Fix misplaced #endif.
2284
22852000-09-12 Akihiro Mizutani <mizutani@dml.com>
2286
2287 * bgpd.c (bgp_default_local_preference): Add "bgp default
2288 local-preference" command.
2289
2290 * bgp_nexthop.c (no_bgp_scan_time): Add "no bgp scan-time"
2291 command.
2292
22932000-09-10 Kunihiro Ishiguro <kunihiro@zebra.org>
2294
2295 * bgp_zebra.c (bgp_zebra_announce): BGP confederation peer's routes
2296 are passed to zebra like IBGP route.
2297
22982000-09-10 Akihiro Mizutani <mizutani@dml.com>
2299
2300 * bgpd.c (bgp_config_write_peer): Make it consistent passive
2301 configuration.
2302
2303 * bgp_route.c: Community match command is added.
2304 "show ip bgp community <val>"
2305 "show ip bgp community <val> exact-match"
2306
23072000-09-08 Kunihiro Ishiguro <kunihiro@zebra.org>
2308
2309 * bgp_nexthop.c (bgp_nexthop_lookup): ebgp-multihop routes are
2310 treated as IBGP routes.
2311
23122000-09-08 Akihiro Mizutani <mizutani@dml.com>
2313
2314 * bgp_route.c (bgp_show_route): When local-AS community route is
2315 selected, display "not advertised outside local AS" to "show ip
2316 route A.B.C.D" output.
2317 (show_ip_bgp_ipv4_filter_list): Add below four commands.
2318 "show ip bgp ipv4 (unicast|multicast) filter-list WORD"
2319 "show ip bgp ipv4 (unicast|multicast) community"
2320 "show ip bgp ipv4 (unicast|multicast) community-list WORD"
2321 "show ip bgp ipv4 (unicast|multicast) community-list WORD exact-match"
2322
2323 * bgp_clist.c (community_list_match_exact): Community exact match
2324 function.
2325
23262000-09-07 Kunihiro Ishiguro <kunihiro@zebra.org>
2327
2328 * bgp_route.c (bgp_update): Add peer's ttl check.
2329
2330 * bgpd.h (struct peer): Structure member refresh is renamed to
2331 refresh_adv.
2332
2333 * bgpd.c (clear_bgp_soft_in): Check PEER_FLAG_ROUTE_REFRESH flag
2334 when soft reconfiguration is performed.
2335
2336 * bgp_zebra.c (bgp_zebra_announce): When the peer is EBGP and
2337 ebgp-multiphop is set, set ZEBRA_FLAG_INTERNAL for nexthop lookup.
2338
2339 * bgp_route.h (struct bgp_info_tag): Add valid flag.
2340
23412000-08-25 Akihiro Mizutani <mizutani@dml.com>
2342
2343 * bgpd.c: Add AS base BGP soft reconfiguration.
2344
2345 * bgp_route.c: When no-advertise or no-export route is selected,
2346 "show ip bgp" display "not advertised to EBGP peer" or "not
2347 advertised to any peer" message.
2348
23492000-08-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2350
2351 * zebra-0.88 is released.
2352
2353 * bgp_dump.c (dump_bgp_routes): Change "dump bgp routes" to "dump
2354 bgp route-mrt" to support MRT specific dump format.
2355
2356 * bgpd.c (bgp_init): "clear ip bgp vpnv4 soft {in,out}" command is
2357 added.
2358
2359 * bgp_route.c (bgp_update): Currently nexthop check is only works
2360 for IPv4.
2361
23622000-08-17 Akihiro Mizutani <mizutani@dml.com>
2363
2364 * bgpd. (clear_ip_bgp_all_soft): Add "clear ip bgp * soft" for
2365 both inbound and outbound soft reconfiguration.
2366
23672000-08-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2368
2369 * bgpd.c (clear_ip_bgp_peer_soft_out): Add soft-reconfiguration
2370 outbound.
2371 (peer_new): Set route-refresh flag.
2372
23732000-08-16 Akihiro Mizutani <mizutani@dml.com>
2374
2375 * bgpd.c: "no bgp router-id A.B.C.D" alias is added. "no bgp
2376 cluster-id A.B.C.D" alias is added. " bgp cluster-id
2377 <1-4294967295>" alias is added. "clear ip bgp * soft in" command
2378 is added. "clear ip bgp A.B.C.D in" alias is added. "clear ip
2379 bgp * in" alias is added.
2380
23812000-08-16 Kunihiro Ishiguro <kunihiro@zebra.org>
2382
2383 * bgp_route.c (bgp_update): Add soft_reconfig flag. When the flag
2384 is set do not install the route into Adj-RIBs-In.
2385 (bgp_update): Perform implicit withdraw before filtering of the
2386 route.
2387
2388 * bgp_packet.c (bgp_read): draft-ietf-idr-bgp-route-refresh-01.txt
2389 capability code and BGP message can be accepted.
2390
2391 * bgp_open.c (bgp_capability_parse): Likewise.
2392
2393 * bgp_route.c (bgp_refresh_table): New function for route refresh.
2394 (bgp_refresh_rib): Likewise.
2395
2396 * bgpd.c (bgp_show_peer): Display route refresh status.
2397
2398 * bgp_route.c (bgp_aggregate_add): Add check for the route
2399 validness.
2400 (bgp_aggregate_delete): Likewise.
2401
24022000-08-15 Kunihiro Ishiguro <kunihiro@zebra.org>
2403
2404 * bgp_nexthop.c (bgp_scan): Care for aggregate route when the
2405 route become inaccessible.
2406
24072000-08-15 Akihiro Mizutani <mizutani@dml.com>
2408
2409 * bgp_route.c (show_ip_bgp_prefix): "show ip bgp A.B.C.D/M"
2410 command is added.
2411
24122000-08-15 Kunihiro Ishiguro <kunihiro@zebra.org>
2413
2414 * bgp_zebra.c (bgp_interface_up): Register connected route.
2415 (bgp_interface_down): Unregister connected route.
2416
24172000-08-14 Kunihiro Ishiguro <kunihiro@zebra.org>
2418
2419 * bgp_route.h (struct bgp_info): Add distance to the structure.
2420
2421 * bgp_route.c (bgp_aggregate_increment): Aggregate route only
2422 match to smaller prefixlen route not match same prefixlen route.
2423 (bgp_aggregate_decrement): Likewise.
2424 (bgp_aggregate_add): Likewise.
2425 (bgp_aggregate_delete): Likewise.
2426 (bgp_network_backdoor): Add backdoor network configuration.
2427
2428 * bgpd.h (struct bgp ): Add distance_{ebgp,ibgp,local} for store
2429 configuration distance value.
2430
2431 * bgp_route.c (bgp_update): Filter EBGP route which has non
2432 connected nexthop.
2433
2434 * bgp_attr.c (bgp_attr_aggregate_intern): New function for
2435 aggregate route. Set origin to IGP. Set atomic aggregate flag.
2436 Set aggregator AS and address.
2437 (bgp_attr_aggregate_intern): Check BGP_CONFIG_CONFEDERATION when
2438 filling aggregator_as.
2439
2440 * bgp_route.c (bgp_process): Delete suppress check for install
2441 suppressed route into local routing table.
2442 (bgp_aggregate_increment): Use bgp_attr_aggregate_intern() instead
2443 of bgp_attr_default_intern ().
2444 (bgp_aggregate_add): Likewise.
2445
2446 * bgpd.c (bgp_get): Call bgp_if_update_all() after BGP instance is
2447 created. This is for avoid 0.0.0.0 router-id.
2448
24492000-08-13 Akihiro Mizutani <mizutani@dml.com>
2450
2451 * bgp_route.c (route_vty_out_detail): Display "valid" when the
2452 route is valied. Display "aggregated" when the route is
2453 aggregated. "Advertisements suppressed by an aggregate" is
2454 displayed when the route is suppressed.
2455 (bgp_info_cmp): Prefer EBGP than Confed-EBGP.
2456
24572000-08-10 Akihiro Mizutani <mizutani@dml.com>
2458
2459 * bgp_route.c (route_vty_out_detail): Display format change.
2460
24612000-08-06 Kunihiro Ishiguro <kunihiro@zebra.org>
2462
2463 * bgp_route.c (bgp_update): Only AFI_IP nexthop check is enabled.
2464
2465 * bgpd.c (bgp_delete): Delete static route before delete peer
2466 configuration.
2467
24682000-08-02 Kunihiro Ishiguro <kunihiro@zebra.org>
2469
2470 * bgpd.c: Include bgpd/bgp_nexthop.h.
2471
24722000-07-31 Akihiro Mizutani <mizutani@dml.com>
2473
2474 * bgpd.c (bgp_show_summary): "show ip bgp summary" shows own BGP
2475 identifier. And status is changed like below.
2476
2477 State/Pref -> State/PfxRcd
2478 Shutdown -> Idle (Admin)
2479 PrefixOvflw -> Idle (PfxCt)
2480
2481 * bgp_route.c (route_vty_out): Show internal route as "i".
2482
24832000-07-13 Jim Bowen <jimb@zereau.net>
2484
2485 * bgp_snmp.c: Add BGP peer MIB implementation.
2486
24872000-07-12 Akihiro Mizutani <mizutani@dml.com>
2488
2489 * bgpd.c (bgp_show_peer): Fix typo.
2490
24912000-07-11 Akihiro Mizutani <mizutani@dml.com>
2492
2493 * bgp_routemap.c: Add commands for deleting set without argument.
2494
24952000-07-03 Akihiro Mizutani <mizutani@dml.com>
2496
2497 * bgp_zebra.c: Fix redistribute help strings.
2498
24992000-07-01 Kunihiro Ishiguro <kunihiro@zebra.org>
2500
2501 * bgp_route.c (bgp_show): When bgpd works as vtysh server send all
2502 output to vty at once.
2503
25042000-06-13 Kunihiro Ishiguro <kunihiro@zebra.org>
2505
2506 * bgp_mplsvpn.c (no_vpnv4_network): "no network A.B.C.D/M rd WORD
2507 tag WORD" command is added.
2508
2509 * bgp_ecommunity.c (ecommunity_vty_out): New function added.
2510
25112000-06-12 Kunihiro Ishiguro <kunihiro@zebra.org>
2512
2513 * bgp_route.c (bgp_show): Fix total number of prefix count bug.
2514
2515 * bgpd.c (bgp_show_peer): Display VPNv4 unicast configuration and
2516 negotiation result in "show ip bgp neighbors".
2517
25182000-06-12 Akihiro Mizutani <mizutani@dml.com>
2519
2520 * bgpd.c: Fix help strings.
2521
2522 * bgpd.h: Likewise.
2523
25242000-06-11 Kunihiro Ishiguro <kunihiro@zebra.org>
2525
2526 * bgp_route.c (bgp_aggregate_unset): Fix bug of checking rn->info
2527 instead of rn. Reported by Akihiro Mizutani <mizutani@dml.com>.
2528
2529 * bgp_mplsvpn.c (vpnv4_network): For testing purpose, "network
2530 A.B.C.D rd RD" is added to address-family vpnv4 unicast node.
2531
2532 * bgp_route.c (bgp_static_set): Set safi to p.safi.
2533
25342000-06-10 Kunihiro Ishiguro <kunihiro@zebra.org>
2535
2536 * bgp_route.c (bgp_show_prefix_list): Change to use bgp_show().
2537 (bgp_show_regexp): Change to use bgp_show().
2538 (show_adj_route): Change to display header.
2539
2540 * bgpd.c (clear_bgp): Set peer->v_start to default value when peer
2541 is cleared manually.
2542
2543 * bgp_route.c (bgp_show_route): New function which display
2544 specific BGP route. Divided from bgp_show().
2545 (bgp_static_delete): Delete all static route.
2546
25472000-06-09 NOGUCHI Kay <kay@v6.access.co.jp>
2548
2549 * bgp_route.c (show_ipv6_bgp): "show ipv6 bgp" is broken with
2550 invalid privious fix. Now show_ipv6_bgp and show_ipv6_bgp_route
2551 take care of "show ipv6 bgp [X:X::X:X]". Same change for "show ip
2552 mbgp" and "show ipv6 mbgp".
2553
25542000-06-07 Akihiro Mizutani <mizutani@dml.com>
2555
2556 * bgp_route.c: Fix help strings and command arguments.
2557
25582000-06-06 Kunihiro Ishiguro <kunihiro@zebra.org>
2559
2560 * bgp_ecommunity.c: Include prefix.h
2561
25622000-06-05 Kunihiro Ishiguro <kunihiro@zebra.org>
2563
2564 * bgp_route.h (struct bgp_info_tag): New structure to hold tag
2565 value.
2566
2567 * bgp_route.c (bgp_adj_set): table NULL check is added.
2568 (bgp_adj_unset): Likewise.
2569 (bgp_adj_lookup): Likewise.
2570 (bgp_adj_clear): Likewise.
2571 (route_vty_out): Add SAFI check for nexthop display.
2572 (bgp_withdraw): Add SAFI check for withdraw route.
2573
2574 * Remove all #ifdef MPLS_VPN then include it as default.
2575
2576 * bgpd.c: Temporary disable peer-group command until the
2577 implementation is completed.
2578
2579 * bgp_routemap.c (bgp_route_map_init): Install
2580 route_metric_match_cmd.
2581 (route_match_metric_compile): MED value compile using strtoul.
2582
25832000-06-05 Akihiro Mizutani <mizutani@dml.com>
2584
2585 * bgp_filter.c: Fix help strings. Change REGEXP to LINE. Change
2586 NAME to WORD.
2587
2588 * Change command argument to more comprehensive.
2589
2590 METRIC -> <0-4294967295>
2591 WEIGHT -> <0-4294967295>
2592 LOCAL_PREF -> <0-4294967295>
2593 IP_ADDR -> A.B.C.D
2594 AS -> <1-65535>
2595 AS-PATH-NAME -> WORD
2596 ACCESS_LIST -> WORD
2597 PREFIX_LIST -> WORD
2598 COMMUNITY -> AA:NN
2599 EXT_COMMUNITY -> ASN:nn_or_IP-address:nn
2600 IPv6_ADDR -> X:X::X:X
2601
2602 * bgp_clist.c: Fix help strings.
2603
26042000-06-03 Kunihiro Ishiguro <kunihiro@zebra.org>
2605
2606 * bgpd.c (peer_active): Add new function for check the peer is
2607 active or not.
2608 (neighbor_activate): New command "neighbor PEER activate" and "no
2609 neighbor PEER activate" are added.
2610
2611 * bgp_packet.c: Include bgpd/bgp_mplsvpn.h.
2612
26132000-06-02 Akihiro Mizutani <mizutani@dml.com>
2614
2615 * bgp_clist.c: Fix commuity-list help strings.
2616
2617 * bgp_routemap.c: Fix "set community" help strings. Add #define
2618 SET_STR. Use (unicast|multicast) argument for "set nlri" command.
2619
26202000-06-01 Kunihiro Ishiguro <kunihiro@zebra.org>
2621
2622 * bgp_routemap.c (route_set_community_none_cmd): "set community
2623 none" command is added to route-map.
2624
26252000-06-01 Akihiro Mizutani <mizutani@dml.com>
2626
2627 * bgp_debug.c: Change "show debug" to "show debugging". Now "show
2628 debugging" is not used in VIEW_NODE.
2629
26302000-05-30 Kunihiro Ishiguro <kunihiro@zebra.org>
2631
2632 * bgp_fsm.c (bgp_timer_set): Add check for shutdown flag. This
2633 fix unconditional BGP connection.
2634
2635 * bgpd.c (peer_shutdown): Replace peer_shutdown() with
2636 peer_change_flag_with_reset().
2637
26382000-05-26 Kunihiro Ishiguro <kunihiro@zebra.org>
2639
2640 * bgpd.c (no_bgp_default_ipv4_unicast): Add "no bgp default
2641 ipv4-unicast" command.
2642
2643 * bgpd.h (BGP_CONFIG_NO_DEFAULT_IPV4): Add new definition.
2644
2645 * bgp_filter.c (as_list_delete): Free all AS filter.
2646
2647 * bgp_clist.c (community_list_delete): Free all community entry.
2648
2649 * bgp_filter.c (no_ip_as_path_all): New DEFUN for "no ip as-path
2650 access-list NAME".
2651
2652 * bgp_clist.c (no_ip_community_list_all): New DEFUN for "no ip
2653 community-list NAME".
2654
26552000-05-19 Kunihiro Ishiguro <kunihiro@zebra.org>
2656
2657 * bgp_route.c (ipv6_mbgp_neighbor_routes): Change "show ip bgp PEER
2658 routes" to "show ip bgp PEER received-routes"
2659
26602000-05-14 Kunihiro Ishiguro <kunihiro@zebra.org>
2661
2662 * bgp_ecommunity.c (ecommunity_parse): New file for Extended
2663 Communities attribute.
2664 * bgp_ecommunity.h: Likewise.
2665
26662000-05-11 Kunihiro Ishiguro <kunihiro@zebra.org>
2667
2668 * bgp_mplsvpn.h: New file for MPLS-VPN.
2669 * bgp_mplsvpn.c: Likewise.
2670
2671 * bgpd.c (bgp_delete): Fix bug of "no router bgp" crush.
2672
26732000-05-10 Kunihiro Ishiguro <kunihiro@zebra.org>
2674
2675 * bgpd.c (bgp_bestpath_missing_as_worst): Add "bgp bestpath
2676 missing-as-worst".
2677
26782000-05-08 Kunihiro Ishiguro <kunihiro@zebra.org>
2679
2680 * bgp_routemap.c (match_community): Clarify help of "match
2681 community".
2682
26832000-05-02 Kunihiro Ishiguro <kunihiro@zebra.org>
2684
2685 * bgp_aspath.c (aspath_cmp_left): Remove debug code.
2686
26872000-04-27 Kunihiro Ishiguro <kunihiro@zebra.org>
2688
2689 * bgp_route.c (bgp_info_cmp): Compare MED only both routes comes
2690 from same neighboring AS.
2691
2692 * bgp_aspath.c (aspath_cmp_left): Compare leftmost AS value.
2693
2694 * bgp_route.c (bgp_info_cmp): Fix misused htonl() to ntohl().
2695
26962000-04-26 Kunihiro Ishiguro <kunihiro@zebra.org>
2697
2698 * bgp_route.c (bgp_output_filter): When distribute-list's
2699 corresponding access-list does not exist, filter all routes.
2700 (bgp_input_filter): Likewise.
2701
27022000-04-19 Kunihiro Ishiguro <kunihiro@zebra.org>
2703
2704 * bgp_attr.c (bgp_packet_attribute): Propagate MED to IBGP peer.
2705
2706 * bgp_route.c (bgp_info_cmp): Add evaluation of local preference.
2707
27082000-04-18 Kunihiro Ishiguro <kunihiro@zebra.org>
2709
2710 * bgpd.c (bgp_distribute_update): Add struct access_list *
2711 argument.
2712
27132000-04-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2714
2715 * bgp_clist.c (community_list_dup_check): Add duplicate insertion
2716 check.
2717
2718 * bgp_filter.c (as_list_dup_check): Add duplicate insertion check.
2719
2720 * bgp_route.c (bgp_show): Fix undeclared write variable.
2721
27222000-04-13 Kunihiro Ishiguro <kunihiro@zebra.org>
2723
2724 * bgp_routemap.c: Add "match ip address prefix-list".
2725
27262000-03-29 Rick Payne <rickp@rossfell.co.uk>
2727
2728 * bgp_aspath.c (aspath_strip_confed): Fix realloc problem.
2729
27302000-03-16 Kunihiro Ishiguro <kunihiro@zebra.org>
2731
2732 * bgp_fsm.c (bgp_reconnect): Connect retry timer is expired when
2733 the peer status is Connect.
2734
27352000-03-03 Kunihiro Ishiguro <kunihiro@zebra.org>
2736
2737 * Fix bug of rewritten originator-id.
2738
27392000-01-27 Rick Payne <rickp@rossfell.co.uk>
2740
2741 * bgp_aspath.c (aspath_delimiter_char): New function. Instead of
2742 directly referencing array, search proper AS path delimiter.
2743 (aspath_strip_confed): Strip the confederation stuff from the
2744 front of an AS path.
2745 (aspath_add_left_confed): New function for adding specified AS to
2746 the leftmost AS_CONFED_SEQUENCE.
2747
2748 * bgp_aspath.h: Change AS_CONFED_SEQUENCE and AS_CONFED_SET value
2749 to Cisco compatible.
2750
2751 * bgpd.c (bgp_confederation_id_set): Confederation configuration.
2752 (bgp_confederation_id_unset): Likewise.
2753 (bgp_confederation_peers_check): Likewise.
2754 (bgp_confederation_peers_add): Likewise.
2755 (bgp_confederation_peers_remove): Likewise.
2756 (bgp_confederation_peers_set): Likewise.
2757 (bgp_confederation_peers_unset): Likewise.
2758 (bgp_confederation_peers_print): Likewise.
2759
27602000-01-16 Kunihiro Ishiguro <kunihiro@zebra.org>
2761
2762 * bgpd.c: Introduce peer_change_flag_with_reset() fucntion.
2763
27642000-01-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2765
2766 * bgp_open.c (bgp_open_option_parse): When there is no common
2767 capability send Unsupported Capability error to the peer.
2768
27692000-01-14 Kunihiro Ishiguro <kunihiro@zebra.org>
2770
2771 * bgp_open.c (bgp_capability_mp): Fix bug of mis-negotiation about
2772 IPv6 unicast.
2773
2774 * bgpd.c (bgp_init): Add "soft-reconfiguration inbound" command.
2775
27762000-01-12 Kunihiro Ishiguro <kunihiro@zebra.org>
2777
2778 * bgpd.c (neighbor_strict_capability): Add
2779 "strict-capability-match" command.
2780
2781 * bgp_zebra.c (bgp_if_update): Ignore NET127 determining
2782 router-id.
2783
2784 * bgpd.c (peer_override_capability): Add "override-capability"
2785 command.
2786
27871999-12-16 Kunihiro Ishiguro <kunihiro@zebra.org>
2788
2789 * bgp_packet.c (bgp_write): Change status to Idle and set timer
2790 after write failed.
2791
27921999-12-14 Kunihiro Ishiguro <kunihiro@zebra.org>
2793
2794 * bgp_zebra.c (bgp_zebra_announce): Add info->selected check.
2795
27961999-12-12 Kunihiro Ishiguro <kunihiro@zebra.org>
2797
2798 * bgp_route.c (nlri_unfeasible): nlri_unfeasible() is merged with
2799 nlri_parse().
2800
28011999-12-10 Kunihiro Ishiguro <kunihiro@zebra.org>
2802
2803 * bgp_fsm.h (BGP_EVENT_DELETE): Macro added.
2804
2805 * bgp_fsm.c (bgp_stop): Clear all event threads of the peer when
2806 the peer is cleared.
2807
2808 * bgp_zebra.c (bgp_nexthop_set): Clear interface index of
2809 link-local address. This is KAME specific problem.
2810
28111999-12-06 Kunihiro Ishiguro <kunihiro@zebra.org>
2812
2813 * bgp_attr.c (bgp_mp_reach_parse): Comment out previous code for a
2814 while. We don't completely detect the link is shared or not at
2815 this moment.
2816
2817 * bgp_packet.c (bgp_notify_send): Make shortcut call of
2818 bgp_write() and bgp_stop().
2819
2820 * bgp_attr.c (bgp_mp_reach_parse): Fix serious bug when getting
2821 global and link-local address.
2822
28231999-12-05 Kunihiro Ishiguro <kunihiro@zebra.org>
2824
2825 * bgpd.c (no_neighbor_port): New command added.
2826 (peer_new): Set send_community.
2827
28281999-12-04 Kunihiro Ishiguro <kunihiro@zebra.org>
2829
2830 * bgpd.c (show_ip_bgp_summary): Changed to use bgp_show_summary().
2831 (show_ip_mbgp_summary): Likewise.
2832 (show_ipv6_bgp_summary): Likewise.
2833 (show_ipv6_mbgp_summary): Add new command.
2834 (peer_free): Free peer->host.
2835 (peer_lookup_by_su): Delete function.
2836 (ipv6_bgp_neighbor): Changed to use peer_remote_as().
2837 (sockunion_vty_out): Function deleted.
2838 (vty_clear_bgp): Use afi instead of family.
2839 Delete old list bgp_list. Use struct newlist *bgplist.
2840 (peer_lookup_by_host): Function deleted.
2841
28421999-12-03 Kunihiro Ishiguro <kunihiro@zebra.org>
2843
2844 * bgpd.h (struct peer_group): New structure added.
2845 (struct peer_conf): New structure added.
2846 (struct peer): Change all prefix_count to unsigned long.
2847
2848 * bgpd.c: Reconstruct all of VTY commands reflect internal
2849 structure change.
2850 Use bgplist instead of bgp_list.
2851 Use peerlist intstead of peer_list.
2852
2853 * bgp_attr.c (bgp_mp_reach_parse): If nlri_parse return -1, stop
2854 parsing then return immediately.
2855
2856 * bgp_route.c (nlri_parse): When NLRI parse error occured, return
2857 -1.
2858 (nlri_process): Use pcount_v4_{unicast,multicast}.
2859 (nlri_delete): Likewise.
2860
28611999-11-25 Robert Olsson <Robert.Olsson@data.slu.se>
2862
2863 * bgp_routemap.c (route_match_nlri): `match nlri
2864 unicast|multicast' and `set nlri unicast|multicast' command are
2865 added.
2866
28671999-11-22 Robert Olsson <Robert.Olsson@data.slu.se>
2868
2869 * bgpd.c: Add translate-update support.
2870
2871 * bgpd.h (TRANSLATE_UPDATE_OFF): Add translate-update definition.
2872
28731999-11-19 Robert.Olsson@data.slu.se
2874
2875 * bgp_route.c (bgp_peer_delete): Add MBGP peer clear codes.
2876
28771999-11-14 Kunihiro Ishiguro <kunihiro@zebra.org>
2878
2879 * bgp_open.c (bgp_capability_mp): Temporary comment out
2880 SAFI_UNICAST_MULTICAST handling until we know the meanings.
2881
28821999-11-13 Kunihiro Ishiguro <kunihiro@zebra.org>
2883
2884 * bgp_btoa.c: New file added.
2885
28861999-11-12 Kunihiro Ishiguro <kunihiro@zebra.org>
2887
2888 * bgpd.h (struct peer): Add dont_capability flag.
2889 (struct peer): Add override_capability flag.
2890
2891 * bgpd.c (neighbor_dont_capability_negotiation): `neighbor PEER
2892 dont-capability-negotiation' added.
2893
28941999-11-12 Bill Sommerfeld <sommerfeld@orchard.arlington.ma.us>
2895
2896 * bgp_attr.c (bgp_mp_reach_parse): Ignore link-local addresses
2897 attribute from non-shared-network peers.
2898
28991999-11-10 Kunihiro Ishiguro <kunihiro@zebra.org>
2900
2901 * bgp_snmp.c: New file added.
2902
2903 * BGP4-MIB.txt: Updated to the latest Internet-Draft
2904 draft-ietf-idr-bgp4-mib-04.txt.
2905
29061999-11-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2907
2908 * bgp_route.c (bgp_route_init): Add `show ipv6 bgp prefix-list'.
2909
2910 * bgp_attr.c (bgp_mp_unreach_parse): Enclose safi setup with
2911 #ifdef HAVE_MBGPV4.
2912
29131999-11-08 Kunihiro Ishiguro <kunihiro@zebra.org>
2914
2915 * bgp_dump.c (no_dump_bgp_all): Add [PATH] and [INTERVAL] to no
2916 dump bgp commands.
2917 (config_write_bgp_dump): Write interval value to the
2918 configuration.
2919
29201999-11-07 Kunihiro Ishiguro <kunihiro@zebra.org>
2921
2922 * bgp_zebra.c: Redistribute route-map support is added.
2923
2924 * bgp_zebra.h: New file added.
2925
29261999-11-04 Kunihiro Ishiguro <kunihiro@zebra.org>
2927
2928 * bgp_dump.c: BGP packet dump routine compatible with MRT.
2929 * bgp_dump.h: BGP packet dump routine compatible with MRT.
2930
2931 * bgp_debug.c: Renamed from bgp_dump.c
2932 * bgp_debug.h: Renamed from bgp_dump.h
2933
29341999-10-27 Kunihiro Ishiguro <kunihiro@zebra.org>
2935
2936 * BGP4-MIB.txt: New file added. Edited version of RFC1657.
2937
29381999-10-25 Bill Sommerfeld <sommerfeld@orchard.arlington.ma.us>
2939
2940 * bgp_route.c (bgp_announce): If we're not on a shared network
2941 with the peer and we don't have a link-local next hop, but the
2942 inbound next-hop has a link-local address, don't readvertise it to
2943 our peer.
2944
29451999-10-25 Marc Boucher <marc@mbsi.ca>
2946
2947 * bgp_zebra.c: Add redistribute kernel command.
2948
29491999-10-25 Kunihiro Ishiguro <kunihiro@zebra.org>
2950
2951 * bgp_route.c (bgp_reset): New function added.
2952
2953 * bgpd.conf.sample2: Add IPv6 configuration sample.
2954
29551999-10-24 Bill Sommerfeld <sommerfeld@orchard.arlington.ma.us>
2956
2957 * bgp_route.c (ipv6_aggregate_address): Function added.
2958
29591999-10-21 Kunihiro Ishiguro <kunihiro@zebra.org>
2960
2961 * bgp_packet.c (bgp_update): Unintern aspath, community, cluster
2962 list after parsing BGP update packet.
2963
2964 * bgp_attr.c (bgp_attr_aspath): Intern parsed aspath.
2965 (bgp_attr_community): Intern parsed community.
2966 (bgp_attr_cluster_list): Intern parsed cluster list.
2967
2968 * bgp_routemap.c: Add `set community-additive' command.
2969
29701999-10-21 Alexandr D. Kanevskiy <kad@blackcatlinux.com>
2971
2972 * bgp_routemap.c (route_set_local_pref): Fix bug of setting
2973 attribute flag.
2974
29751999-10-21 Bill Sommerfeld <sommerfeld@orchard.arlington.ma.us>
2976
2977 * bgp_route.c (bgp_announce): Add check of IPv6 default route
2978 announcement.
2979
2980 * bgp_packet.c (bgp_update_send): Add BGP announcement logging.
2981
29821999-10-15 Kunihiro Ishiguro <kunihiro@zebra.org>
2983
2984 * `show ip[v6] bgp PREFIX' show uptime of the route.
2985
29861999-10-04 Kunihiro Ishiguro <kunihiro@zebra.org>
2987
2988 * bgpd.c (bgp_filter_set): Delete PEER_FAMILY_{IPV4,IPV6}. instead
2989 of that use AF_INET and AF_INET6 directly.
2990 (vty_clear_bgp): Add new function to support various clear ip bgp
2991 method.
2992
29931999-10-04 Lars Fenneberg <lf@elemental.net>
2994
2995 * bgpd.c (clear_ip_bgp): Add `clear ip bgp ASN'.
2996
29971999-10-03 Kunihiro Ishiguro <kunihiro@zebra.org>
2998
2999 * bgp_routemap.c: Add `match ip prefix-list' and `match ipv6
3000 prefix-list'.
3001
30021999-09-28 Kunihiro Ishiguro <kunihiro@zebra.org>
3003
3004 * bgpd.c (bgp_collision_detect): Add BGP collision detection
3005 function.
3006
30071999-09-26 Blake Meike <bmeike@adero.com>
3008
3009 * bgpd.c (neighbor_port): New command `neighbor PEER port PORT' is
3010 added.
3011
30121999-08-24 Kunihiro Ishiguro <kunihiro@zebra.org>
3013
3014 * bgpd.c (no_neighbor_timers_keepalive): Change MIN to min. Add
3015 min() macro.
3016
30171999-08-19 Rick Payne <rickp@rossfell.co.uk>
3018
3019 * bgp_packet.c (bgp_open): BGP holdtimer bug is fixed. Make BGP
3020 keepalive timer configurable.
3021
30221999-08-15 Kunihiro Ishiguro <kunihiro@zebra.org>
3023
3024 * bgp_zebra.c (bgp_redistribute_set): Fix redistribute bug.
3025
30261999-08-13 Kunihiro Ishiguro <kunihiro@zebra.org>
3027
3028 * bgpd.c (bgp_peer_display): show ip bgp neighbors PEER only list
3029 the peer not all of them.
3030
30311999-08-11 Rick Payne <rickp@rossfell.co.uk>
3032
3033 * bgp_route.c (bgp_announce): Remove MED if its an EBGP peer -
3034 will get overwritten by route-maps.
3035
30361999-08-08 Rick Payne <rickp@rossfell.co.uk>
3037
3038 * bgp_routemap.c: Multi protocol route-map modification.
3039
30401999-08-01 Kunihiro Ishiguro <kunihiro@zebra.org>
3041
3042 * bgp_route.c: Set network statement route's origin attribute as
3043 igp.
3044
3045 * bgp_zebra.c: Set redistribute route's origin attribute as
3046 incomplete.
3047
3048 * bgp_route.c (bgp_info_cmp): Add attribute existance check,
3049 origin attribute check, BGP peer type check.
3050
30511999-07-30 Kunihiro Ishiguro <kunihiro@zebra.org>
3052
3053 * bgp_route.c (bgp_peer_delete): Reselect of IPv6 route.
3054
30551999-07-29 Rick Payne <rickp@rossfell.co.uk>
3056
3057 * Changed route-maps to behave in a more cisco-like fashion
3058
30591999-07-27 Kunihiro Ishiguro <kunihiro@zebra.org>
3060
3061 * bgp_fsm.c (bgp_stop): Very serious bug of bgp_stop () is fixed.
3062 When multiple route to the same destination exist, bgpd try to
3063 announce the information to stopped peer. Then add orphan write
3064 thread is added. This cause many strange behavior of bgpd.
3065 Reported by Georg Hitsch <georg@atnet.at>.
3066
30671999-07-23 Kunihiro Ishiguro <kunihiro@zebra.org>
3068
3069 * bgpd.c: Change peer's A.B.C.D to PEER.
3070
30711999-07-22 Kunihiro Ishiguro <kunihiro@zebra.org>
3072
3073 * bgp_route.c (bgp_announce): Add hack for link-local nexthop.
3074
3075 * bgp_zebra.c (bgp_zebra_announce): Fill in nexthop address from
3076 local address.
3077
30781999-07-21 Kunihiro Ishiguro <kunihiro@zebra.org>
3079
3080 * bgp_packet.c (bgp_open): Holdtime fetch bug is fixed. Reported
3081 by Yuji SEKIYA <sekiya@sfc.wide.ad.jp>.
3082
30831999-07-15 Kunihiro Ishiguro <kunihiro@zebra.org>
3084
3085 * bgp_fsm.c (fsm_holdtime): Don't close file descriptor in
3086 fsm_holdtime ().
3087
30881999-07-11 Kunihiro Ishiguro <kunihiro@zebra.org>
3089
3090 * bgp_routemap.c: Add `set atomic-aggregate' command.
3091
30921999-07-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3093
3094 * bgp_routemap.c (route_set_ip_nexthop_cmd): Change "ip nexthop"
3095 to "ip next-hop".
3096
30971999-07-02 Kunihiro Ishiguro <kunihiro@zebra.org>
3098
3099 * bgp_route.c (show_ipv6_bgp_regexp): `show ipv6 bgp regexp'
3100 added.
3101
31021999-07-01 Rick Payne <rickp@rossfell.co.uk>
3103
3104 * bgp_zebra.c (zebra_init): Install standard commands to
3105 ZEBRA_NODE.
3106
31071999-06-28 Rick Payne <rickp@rossfell.co.uk>
3108
3109 * bgpd.c (bgp_delete): bgp peer deletion bug is fixed.
3110
31111999-06-25 Kunihiro Ishiguro <kunihiro@zebra.org>
3112
3113 * bgpd.c: Add neighbor update-source command as ALIAS to
3114 neighbor_interface.
3115
31161999-06-19 Kunihiro Ishiguro <kunihiro@zebra.org>
3117
3118 * bgp_attr.c (bgp_packet_attribute): Send community attribute when
3119 send_community flag is set.
3120
3121 * bgpd.h (struct peer): Add send_community flag.
3122
31231999-06-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3124
3125 * bgpd.c (router_bgp): router bgp's argument changed from AS_NO to
3126 <1-65535>.
3127
31281999-06-08 Kunihiro Ishiguro <kunihiro@zebra.org>
3129
3130 * bgp_route.h (struct bgp_info): Add subtype for BGP route type.
3131
31321999-06-07 Kunihiro Ishiguro <kunihiro@zebra.org>
3133
3134 * bgp_community.c (community_merge): Function added.
3135
31361999-06-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3137
3138 * bgp_clist.c: New file.
3139 * bgp_clist.h: New file.
3140
3141 * bgp_community.h (COMMUNITY_LOCAL_AS): Added for Cisco
3142 compatibility.
3143 (COMMUNITY_NO_ADVERTISE): Fix typo.
3144
31451999-05-30 Kunihiro Ishiguro <kunihiro@zebra.org>
3146
3147 * bgp_routemap.c: Add `set weight WEIGHT' command.
3148
3149 * bgpd.c: Remove all_digit_check function. Instead of that use
3150 all_digit function in lib/prefix.c.
3151
3152 * bgp_routemap.c (bgp_route_map_init): Install
3153 no_set_ipv6_nexthop_global_cmd and no_set_ipv6_nexthop_local_cmd
3154 element to the RMAP_NODE.
3155
31561999-05-28 Kunihiro Ishiguro <kunihiro@zebra.org>
3157
3158 * bgp_aspath.c (aspath_make_str): Declare aspath_delimiter_char
3159 inside aspath_make_str function.
3160 (aspath_prepend): New function is added for AS path prepend.
3161 (aspath_make_str_count): Renamed from aspath_make_str. AS path
3162 count is set to the structure.
3163 (aspath_merge): New function.
3164
31651999-05-22 Kunihiro Ishiguro <kunihiro@zebra.org>
3166
3167 * bgp_zebra.c (redistribute_bgp): Add new DEFUN.
3168 (no_redistribute_bgp): Likewise.
3169 (router_zebra): Semantics changed. Now 'router zebra' is default
3170 behavior of bgpd.
3171
31721999-05-14 Kunihiro Ishiguro <kunihiro@zebra.org>
3173
3174 * bgp_routemap.c: Add some commands to bgp route-map.
3175 match ip next-hop: New command.
3176 match metric: New command.
3177 set metric: Doc fix.
3178 set local-preference: Add DEFUN.
3179
31801999-05-14 Stephen R. van den Berg <srb@cuci.nl>
3181
3182 * bgp_main.c (signal_init): SIGTERM call sigint.
3183 (sigint): Loggging more better message.
3184
31851999-05-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3186
3187 * bgp_attr.c (bgp_packet_attribute): AS path attribute extended
3188 length bit check is added.
3189
31901999-05-11 Kunihiro Ishiguro <kunihiro@zebra.org>
3191
3192 * bgp_routemap.c (bgp_route_map_init): Call route_map_install_set
3193 function with route_set_local_pref_cmd argument.
3194 (no_match_aspath): Function added.
3195 (route_set_metric): Set attribute flag bit.
3196
3197 * bgp_attr.c (bgp_packet_attribute): MULTI_EXIT_DISC is now in BGP
3198 packet.
3199
32001999-05-07 Kunihiro Ishiguro <kunihiro@zebra.org>
3201
3202 * bgpd.c (no_neighbor_timers_holdtime): `no neighbor PEER timers
3203 holdtime' command is added.
3204
3205 * bgpd.h (BGP_DEFAULT_HOLDTIME_BIG): Delete define.
3206
3207 * bgpd.c (bgp_prefix_list_set): New function added.
3208 (bgp_prefix_list_unset): Likewise.
3209 (bgp_prefix_list_update): Likewise.
3210 (show_ip_bgp_neighbors): prefix-list information display.
3211
32121999-05-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3213
3214 * bgpd.c (bgp_delete): Function added for `no router bgp'.
3215
32161999-05-05 Kunihiro Ishiguro <kunihiro@zebra.org>
3217
3218 * bgp_dump.c (bgp_dump_attr): Add originator_id display.
3219
3220 * bgpd.c (bgp_router_id): Even when address is malformed set the
3221 value to configuration bug fixed.
3222 (no_bgp_router_id): New function.
3223 (no_bgp_cluster_id): New function.
3224
32251999-05-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3226
3227 * bgpd.h (BGP_ATTR_ORIGINATOR_ID): Changed from BGP_ATTR_ORIGINATOR.
3228
32291999-05-02 Kunihiro Ishiguro <kunihiro@zebra.org>
3230
3231 * bgp_route.c (bgp_announce): Add route reflector check.
3232
32331999-05-01 Kunihiro Ishiguro <kunihiro@zebra.org>
3234
3235 * bgpd.c (bgp_cluster_id): Add function for route reflector.
3236 (neighbor_route_reflector_client): Likewise.
3237 (no_neighbor_route_reflector_client): Likewise.
3238
3239 * bgpd.h (struct bgp ): Add cluster for route reflector.
3240
3241 * bgp_route.c (show_ip_bgp_prefix_list): New command is added.
3242
32431999-04-24 Kunihiro Ishiguro <kunihiro@zebra.org>
3244
3245 * Makefile.am (noinst_HEADERS): Add bgp_filter.h
3246
3247 * bgp_aspath.c (aspath_undup): Function deleted. aspath_free ()
3248 has same functionality.
3249
3250 * bgp_filter.h: New file.
3251
3252 * bgp_aspath.c (aspath_unintern): Rename aspath_free () to
3253 aspath_unintern ()
3254 (aspath_free): New function.
3255
32561999-04-23 Kunihiro Ishiguro <kunihiro@zebra.org>
3257
3258 * bgp_aspath.c (aspath_aggregate): Function added.
3259
3260 * bgp_aspath.h (aspath_aggregate): Prototype added.
3261
3262 * bgp_aspath.c (aspath_empty_aspath): New argument
3263 gated_dont_eat_flag is added.
3264
32651999-04-18 Kunihiro Ishiguro <kunihiro@zebra.org>
3266
3267 * bgp_route.c: Add bgp_aggregate_ipv4 and bgp_aggregate_ipv6.
3268
32691999-04-17 Kunihiro Ishiguro <kunihiro@zebra.org>
3270
3271 * bgp_route.c (aggregate_address): Function added.
3272
3273 * bgp_zebra.c (zebra_read): Change log to zlog.
3274
32751999-04-15 Kunihiro Ishiguro <kunihiro@zebra.org>
3276
3277 * Makefile.am (noninst_HEADERS): Added for make dist.
3278
32791999-04-09 Kunihiro Ishiguro <kunihiro@zebra.org>
3280
3281 * aspath_regex.c: Removed from distribution.
3282
32831999-04-07 Kunihiro Ishiguro <kunihiro@zebra.org>
3284
3285 * bgp_attr.c (bgp_packet_attribute): Old draft-00 packet treatment
3286 bug fixed.
3287
32881999-04-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3289
3290 * bgp_aspath.c (aspath_add_left): Fix empty aspath bug. Reported
3291 by kad@gibson.skif.net.
3292
3293 * bgp_regex.[ch]: New file added.
3294
3295
32961999-04-05 Kunihiro Ishiguro <kunihiro@zebra.org>
3297
3298 * bgp_filter.c: New file added.
3299
33001999-04-01 Kunihiro Ishiguro <kunihiro@zebra.org>
3301
3302 * bgp_aspath.c (aspath_empty_aspath): Change for peering with
3303 gated.
3304
33051999-03-24 Kunihiro Ishiguro <kunihiro@zebra.org>
3306
3307 * bgp_main.c (main): Default loggin method changed from syslog to
3308 stdout.
3309
33101999-03-05 Kunihiro Ishiguro <kunihiro@zebra.org>
3311
3312 * bgp_route.c: Delete obsolete default attribute DEFUN.
3313
33141999-03-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3315
3316 * bgp_attr.c: Make attribute structure put into attribute hash.
3317
33181999-03-02 Kunihiro Ishiguro <kunihiro@zebra.org>
3319
3320 * bgp_view.c : Delete file.
3321
33221999-02-25 Kunihiro Ishiguro <kunihiro@zebra.org>
3323
3324 * bgp_routemap.c (bgp_apply_route_map): Add prefix argument.
3325
3326 * bgp_route.h (struct bgp_info): Add bgp_info structre. I'll
3327 replace bgp_route with this.
3328
3329 * bgp_routemap.c (route_match_ip_address): Fix bug of passing non
3330 prefix value to access_list_apply().
3331
3332 * bgpd.conf.sample: Add route-map sample.
3333 Delete obsolete default-attr statements.
3334
3335 * bgp_packet.c: Use stream_fifo for packet queueing.
3336
33371999-02-24 Kunihiro Ishiguro <kunihiro@zebra.org>
3338
3339 * bgp_aspath.c (aspath_add_left): add non empty aspath treatment.
3340
3341 * bgp_main.c: include unistd.h for daemon().
3342
3343 * bgp_route.c (nlri_process): add IPv6 table lookup.
3344
3345 * bgp_attr.c (route_parse_ipv6): call nlri_process().
3346 (attr_make): Obsolete function attr_make deleted.
3347
33481999-02-22 Kunihiro Ishiguro <kunihiro@zebra.org>
3349
3350 * bgp_aspath.c (aspath_add_left): change function name from
3351 aspath_add_leftmost_as().
3352
33531999-02-21 Kunihiro Ishiguro <kunihiro@zebra.org>
3354
3355 * bgp_aspath.c: add aspath_add_leftmost_as ().
3356
33571999-02-18 Peter Galbavy <Peter.Galbavy@knowledge.com>
3358
3359 * syslog support added
3360
33611999-01-26 Kunihiro Ishiguro <kunihiro@zebra.org>
3362
3363 * bgpd.c: DEFUN (neighbor_nexthop): deleted.
3364 DEFUN (neighbor_distribute_list): added.
3365
33661999-01-19 Kunihiro Ishiguro <kunihiro@zebra.org>
3367
3368 * bgpd.h (struct peer ): header_buf and read_buf is removed.
3369
3370 * bgp_peer.[ch]: Deleted. Peer related functions are merged to
3371 bgpd.c
3372
3373 * bgp_network.c: New file.
3374 * bgp_network.h: New file.
3375
3376 * bgp_packet.h: New file.
3377
33781999-01-11 Kunihiro Ishiguro <kunihiro@zebra.org>
3379
3380 * bgp_packet.c (bgp_keepalive_send): Now BGP keepalive packet is
3381 buffered.
3382
33831999-01-08 Kunihiro Ishiguro <kunihiro@zebra.org>
3384
3385 * bgp_packet.c: New file.
3386
33871998-12-22 Kunihiro Ishiguro <kunihiro@zebra.org>
3388
3389 * bgp_zebra.c (zebra_client): Use zebra_connect() in lib/client.c.
3390
3391 * `show ip bgp' bug fixed.
3392 * aspath_log (): Remove argument logfp.
3393
33941998-12-15 Kunihiro Ishiguro <kunihiro@zebra.org>
3395
3396 * bgp_fsm.h: New file.
3397
33981998-12-15 Magnus Ahltorp <map@stacken.kth.se>
3399
3400 * bgp_attr.c, bgp_community.h, bgp_dump.c, bgp_fsm.c, bgp_open.c
3401 bgp_peer.c, bgp_peer.h, bgp_route.c, bgp_route.h, bgp_view.c
3402 bgpd.c, bgpd.h, bgp_attr.c, bgp_community.h, bgp_dump.c,
3403 bgp_fsm.c, bgp_open.c, bgp_peer.c, bgp_peer.h: Prototype fixes.
3404
34051998-12-09 Kunihiro Ishiguro <kunihiro@zebra.org>
3406
3407 * bgpd.c (bgp_config_write): Delete vector v argument.
3408
34091998-12-07 Kunihiro Ishiguro <kunihiro@zebra.org>
3410
3411 * bgpd.h: Delete annoying ld_[124]byte and st_[124]byte macros.
3412
34131998-11-23 Kunihiro Ishiguro <kunihiro@zebra.org>
3414
3415 * bgp_radix.[ch]: removed.
3416
34171998-09-15 HEO SeonMeyong <seirios@matrix.iri.co.jp>
3418
3419 * bgp_main.c: ifdef HYDRANGEA -> ifdef KAME
3420
34211998-08-13 Kunihiro Ishiguro <kunihiro@zebra.org>
3422
3423 * bgp_dump.c: delete nroute().
3424
34251998-05-19 Yamshita TAKAO <jargon@lares.dti.ne.jp>
3426
3427 * bgp_aspath.c: HAVE_CONFIG_H typo :-)
3428 * bgpd.h: Modify for compile on Solaris.
3429 * bgp_aspath.h: likewize
3430 * bgp_community.h: likewize
3431 * bgp_routemap.c: likewize
3432
34331998-05-18 Yamshita TAKAO <jargon@lares.dti.ne.jp>
3434
3435 * bgpd.h: Modify for compile on Solaris.
3436 * bgp_aspath.h: likewize
3437
34381998-05-08 Kunihiro Ishiguro <kunihiro@zebra.org>
3439
3440 * routemap.[ch]: move to ../lib directory.
3441
34421998-05-07 Kunihiro Ishiguro <kunihiro@zebra.org>
3443
3444 * routemap.c (route_map_apply): add function.
3445
34461998-05-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3447
3448 * routemap.h: add file.
3449
3450 * bgp_peer.h (enum ): change PEER_{IBGP,EBGP} to BGP_PEER_{IBGP,EBGP}
3451
34521998-05-03 Kunihiro Ishiguro <kunihiro@zebra.org>
3453
3454 * Makefile.am: sysconfdir_DATA added.
3455
34561998-05-02 Kunihiro Ishiguro <kunihiro@zebra.org>
3457
3458 * bgp_dump.c: add `debug bgp fsm'
3459 add `no debug bgp fsm'
3460 add `show debug bgp'
3461 * bgp_open.c: File added.
3462
34631998-05-01 Kunihiro Ishiguro <kunihiro@zebra.org>
3464
3465 * .cvsignore: File added.
3466
34671998-04-30 Kunihiro Ishiguro <kunihiro@zebra.org>
3468
3469 * bgp_community.[ch]: File added.
3470
34711998-03-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3472
3473 * bgpd now use lib/thread.[ch].
3474
34751998-01-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3476
3477 * bgpd.c (show_ip_bgp_neighbors): add 'show ip bgp neighbors' command.
3478
3479 * bgpd.h (BGP_DEFAULT_START_TIMER): change from 1 to 30.
3480
34811997-12-30 Kunihiro Ishiguro <kunihiro@zebra.org>
3482
3483 * bgp_vty.c: bgp_vty.c deleted.
3484
3485 * bgpd.c (config_write_neighbor): add ebgp-multihop command.
3486
34871997-12-29 Kunihiro Ishiguro <kunihiro@zebra.org>
3488
3489 * bgp_fsm.c: [-p bgp_port] and [-P vty_port] works
3490
34911997-12-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3492
3493 * bgp_vty.c: new file.
3494
3495 * bgp_attr.c: add new logging system.
3496
34971997-11-23 Kunihiro Ishiguro <kunihiro@zebra.org>
3498
3499 * Change all inet_addr call into inet_aton.
3500
35011997-11-10 Kunihiro Ishiguro <kunihiro@zebra.org>
3502
3503 * bgp_radix.c: change radix_peer_delete
3504
35051997-10-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3506
3507 * bgp_aspath.c: move AS_TOKEN_??? definition from header to c source.
3508
35091997-09-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3510
3511 * bgp_dump.c (bgp_log_route): add dump_attr function
3512
35131997-09-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3514
3515 * bgp_aspath.c (aspath_test): change AS_SET brace from '[' to '{'
3516 * bgp_dump.c (bgp_log_route): change logfile format.
3517
35181997-08-19 Kunihiro Ishiguro <kunihiro@zebra.org>
3519
3520 * bgp_open.c (bgp_open): move bgp_open function from bgpd.c
3521 * bgp_attr.c (community_str2com): add community value generation
3522 * bgp_attr.h: add SAFI definition for BGP-4+
3523
35241997-08-18 Kunihiro Ishiguro <kunihiro@zebra.org>
3525
3526 * bgpd.h: add BGP_OPEN_OPT_CAP for Capabilities Optional Parameter
3527 * Makefile.in: add bgp_open.o, delete bgp_loop.o
3528 * bgp_open.c: newfile which manages BGP Open message
3529 * bgp_loop.c: this file is merged with bgp_fsm.c
3530 * bgp_radix.c (radix_add): radix_add() now return route_t instead
3531 of int
3532 (bgp_sim): now we can read update & withdraw from file
3533 * bgp_route.c: add route_free() call into route_parse etc.
3534
35351997-08-17 Kunihiro Ishiguro <kunihiro@zebra.org>
3536
3537 * bgp_radix.c: Radix code is completely rewritten. It has better
3538 memory treatment than old one.
3539
35401997-08-14 Kunihiro Ishiguro <kunihiro@zebra.org>
3541
3542 * bgp_route.c: route_alloc for route struct allocation statistics.
3543 * bgpd.c (bgp_make_update): now we cann announce MED attribute.
3544 * bgp_aspath.c (aspath_print_all): change aspath_print_all output
3545 format.
3546
35471997-08-13 Kunihiro Ishiguro <kunihiro@zebra.org>
3548
3549 * bgp_term.c (term_parse): add command : show asstat, show ashash
3550 * bgp_aspath.c: aspath_cmp bug fix
3551 (aspath_print_all): add aspath_print_all ();
3552 * bgp_peer.h: delete rlist element from struct peer.
3553
35541997-08-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3555
3556 * bgp_aspath.c: completely rewritten.
3557 * bgp_aspath.h: completely rewritten.
3558 add AsPath, AsSegment structure
3559 add AS_SET treatment
3560 change Hash codes
3561
35621997-08-09 Kunihiro Ishiguro <kunihiro@zebra.org>
3563
3564 * bgp_attr.h: add Attribute flags defines
3565 * bgp_route.c: delete rlist related functions
3566 * bgp_aspath.c (as_origin): add as_origin function
3567 (aspath_print): move from bgp_dump.c and add support of AS_SET
3568 change Hash related function names.
3569
35701997-08-08 Kunihiro Ishiguro <kunihiro@zebra.org>
3571
3572 * bgp_aspath.h: add next entry, delete rlist entry from struct aspath
3573
35741997-08-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3575
3576 * bgp_aspath.c (as_sort): add function as_sort
3577 * bgp_aspath.h: add IBGP, EBGP
3578