blob: e1c4b1621b8724735959379feee692449539a97e [file] [log] [blame]
Joey Armstronge6cdd8e2022-12-29 11:58:15 -05001# -*- makefile -*-
2# -----------------------------------------------------------------------
Joey Armstronge66eaaf2023-01-15 18:58:52 -05003# Copyright 2019-2023 Open Networking Foundation (ONF) and the ONF Contributors
Zack Williams52209662019-02-07 10:15:31 -07004#
5# Licensed under the Apache License, Version 2.0 (the "License");
6# you may not use this file except in compliance with the License.
7# You may obtain a copy of the License at
8#
9# http://www.apache.org/licenses/LICENSE-2.0
10#
11# Unless required by applicable law or agreed to in writing, software
12# distributed under the License is distributed on an "AS IS" BASIS,
13# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
14# See the License for the specific language governing permissions and
15# limitations under the License.
Joey Armstronge6cdd8e2022-12-29 11:58:15 -050016# -----------------------------------------------------------------------
17
Joey Armstronge66eaaf2023-01-15 18:58:52 -050018.PHONY: test
Joey Armstronge6cdd8e2022-12-29 11:58:15 -050019.DEFAULT_GOAL := test
20
Joey Armstronge66eaaf2023-01-15 18:58:52 -050021##-------------------##
22##---] GLOBALS [---##
23##-------------------##
Joey Armstronge6cdd8e2022-12-29 11:58:15 -050024TOP ?= .
25MAKEDIR ?= $(TOP)/makefiles
26
27$(if $(VERBOSE),$(eval export VERBOSE=$(VERBOSE))) # visible to include(s)
28
Joey Armstrong761579c2023-05-08 11:59:57 -040029##--------------------------
30## Enable setup.py debugging
31##--------------------------
32# https://docs.python.org/3/distutils/setupscript.html#debugging-the-setup-script
Joey Armstrong56b36782023-05-30 17:30:11 -040033# export DISTUTILS_DEBUG := 1 # verbose: pip
34export DOCKER_DEBUG := 1 # verbose: docker
Joey Armstrong761579c2023-05-08 11:59:57 -040035
Joey Armstrongc2277652023-01-11 17:41:36 -050036# Makefile for voltha-protos
37default: test
38
Joey Armstronge66eaaf2023-01-15 18:58:52 -050039## Library linting
40# NO-LINT-MAKEFILE := true # cleanup needed
41NO-LINT-SHELL := true # cleanup needed
42
Joey Armstronge6cdd8e2022-12-29 11:58:15 -050043##--------------------##
44##---] INCLUDES [---##
45##--------------------##
Joey Armstronge66eaaf2023-01-15 18:58:52 -050046include $(MAKEDIR)/include.mk
Zack Williams52209662019-02-07 10:15:31 -070047
Zack Williams43bfd9e2019-04-12 13:09:31 -070048# Function to extract the last path component from go_package line in .proto files
49define go_package_path
50$(shell grep go_package $(1) | sed -n 's/.*\/\(.*\)";/\1/p')
51endef
52
Joey Armstronge05f6492023-05-31 11:27:31 -040053# -----------------------------------------------------------------------
Serkant Uluderyacbcfaa42019-10-18 13:25:08 +030054# Function to extract the last path component from package line in .proto files
Joey Armstronge05f6492023-05-31 11:27:31 -040055# % grep 'package' will match:
56# o package <name> ;
57# o option java_package='<dot-pkg-fqdn>
58# -----------------------------------------------------------------------
59# RETURN: protos/voltha_protos/common.proto => common
60# -----------------------------------------------------------------------
Serkant Uluderyacbcfaa42019-10-18 13:25:08 +030061define java_package_path
62$(shell grep package $(1) | sed -n 's/.*\/\(.*\)";/\1/p')
63endef
64
Zack Williams52209662019-02-07 10:15:31 -070065# Variables
Zack Williams43bfd9e2019-04-12 13:09:31 -070066PROTO_FILES := $(sort $(wildcard protos/voltha_protos/*.proto))
67
Zack Williams52209662019-02-07 10:15:31 -070068PROTO_PYTHON_DEST_DIR := python/voltha_protos
69PROTO_PYTHON_PB2 := $(foreach f, $(PROTO_FILES), $(patsubst protos/voltha_protos/%.proto,$(PROTO_PYTHON_DEST_DIR)/%_pb2.py,$(f)))
Matt Jeanneret37e0fc62019-03-07 12:33:21 -050070PROTO_PYTHON_PB2_GRPC := $(foreach f, $(PROTO_FILES), $(patsubst protos/voltha_protos/%.proto,$(PROTO_PYTHON_DEST_DIR)/%_pb2_grpc.py,$(f)))
Zack Williams43bfd9e2019-04-12 13:09:31 -070071PROTO_GO_DEST_DIR := go
72PROTO_GO_PB:= $(foreach f, $(PROTO_FILES), $(patsubst protos/voltha_protos/%.proto,$(PROTO_GO_DEST_DIR)/$(call go_package_path,$(f))/%.pb.go,$(f)))
Serkant Uluderyacbcfaa42019-10-18 13:25:08 +030073PROTO_JAVA_DEST_DIR := java
Joey Armstrong670d40c2023-05-11 20:49:26 -040074PROTO_JAVA_PB := $(foreach f, $(PROTO_FILES), $(patsubst protos/voltha_protos/%.proto,$(PROTO_JAVA_DEST_DIR)/$(call java_package_path,$(f))/%.pb.java,$(f)))
Joey Armstrong761579c2023-05-08 11:59:57 -040075
Zack Williams25e0a322019-06-07 14:07:21 -070076# Force pb file to be regenrated every time. Otherwise the make process assumes generated version is still valid
Kent Hagerman868dc382020-01-20 11:24:09 -050077.PHONY: voltha.pb
Matt Jeanneret15249fa2019-04-12 20:25:31 -040078
Joey Armstronge0c1a8d2023-04-13 15:16:21 -040079##----------------##
80##---] DEPS [---##
81##----------------##
82infra-deps := $(null)
83infra-deps += Makefile
84infra-deps += $(venv-activate-script)
85
86## -----------------------------------------------------------------------
87## -----------------------------------------------------------------------
Zack Williams52209662019-02-07 10:15:31 -070088print:
Zack Williams43bfd9e2019-04-12 13:09:31 -070089 @echo "Proto files: $(PROTO_FILES)"
90 @echo "Python PB2 files: $(PROTO_PYTHON_PB2)"
91 @echo "Go PB files: $(PROTO_GO_PB)"
Serkant Uluderyacbcfaa42019-10-18 13:25:08 +030092 @echo "JAVA PB files: $(PROTO_JAVA_PB)"
Zack Williams52209662019-02-07 10:15:31 -070093
94# Generic targets
Serkant Uluderyacbcfaa42019-10-18 13:25:08 +030095protos: python-protos go-protos java-protos
Zack Williams52209662019-02-07 10:15:31 -070096
Serkant Uluderyacbcfaa42019-10-18 13:25:08 +030097build: protos python-build go-protos java-protos
Zack Williams52209662019-02-07 10:15:31 -070098
Serkant Uluderyacbcfaa42019-10-18 13:25:08 +030099test: python-test go-test java-test
Zack Williams52209662019-02-07 10:15:31 -0700100
Joey Armstrong761579c2023-05-08 11:59:57 -0400101clean :: python-clean java-clean go-clean
Zack Williams52209662019-02-07 10:15:31 -0700102
Joey Armstrong761579c2023-05-08 11:59:57 -0400103sterile :: clean
Joey Armstrongc2277652023-01-11 17:41:36 -0500104
Joey Armstronge0c1a8d2023-04-13 15:16:21 -0400105## -----------------------------------------------------------------------
106## Python targets
107## -----------------------------------------------------------------------
108python-protos: $(infra-deps) $(PROTO_PYTHON_PB2)
Zack Williams52209662019-02-07 10:15:31 -0700109
Joey Armstrong761579c2023-05-08 11:59:57 -0400110## -----------------------------------------------------------------------
111## -----------------------------------------------------------------------
112$(PROTO_PYTHON_DEST_DIR)/%_pb2.py: \
113 protos/voltha_protos/%.proto \
114 Makefile \
115 $(venv-activate-script)
Joey Armstrong670d40c2023-05-11 20:49:26 -0400116
117 @echo
118 @echo "** -----------------------------------------------------------------------"
119 @echo "** $(MAKE): processing target [$@]"
120 @echo "** -----------------------------------------------------------------------"
121
122 $(activate) && python -m grpc_tools.protoc \
Zack Williams43bfd9e2019-04-12 13:09:31 -0700123 -I protos \
124 --python_out=python \
125 --grpc_python_out=python \
126 --descriptor_set_out=$(PROTO_PYTHON_DEST_DIR)/$(basename $(notdir $<)).desc \
127 --include_imports \
128 --include_source_info \
129 $<
Zack Williams52209662019-02-07 10:15:31 -0700130
Joey Armstrong670d40c2023-05-11 20:49:26 -0400131## -----------------------------------------------------------------------
132## Intent:
133## -----------------------------------------------------------------------
134show:
135 $(call banner-enter,target $@)
136 @echo
137 $(call banner-leave,target $@)
138
139## -----------------------------------------------------------------------
140## Intent:
141## -----------------------------------------------------------------------
142python-build: setup.py python-protos
143
144 $(call banner-enter,target $@)
145
Joey Armstronge6cdd8e2022-12-29 11:58:15 -0500146 $(RM) -r dist/
Zack Williams52209662019-02-07 10:15:31 -0700147 python ./setup.py sdist
148
Joey Armstrong670d40c2023-05-11 20:49:26 -0400149 $(call banner-leave,target $@)
150
151## -----------------------------------------------------------------------
152## Intent:
153## -----------------------------------------------------------------------
Zack Williams52209662019-02-07 10:15:31 -0700154python-test: tox.ini setup.py python-protos
Joey Armstrong670d40c2023-05-11 20:49:26 -0400155 $(call banner-enter,target $@)
Joey Armstrong670d40c2023-05-11 20:49:26 -0400156 $(activate) && python --version
Zack Williams52209662019-02-07 10:15:31 -0700157 tox
Joey Armstrong670d40c2023-05-11 20:49:26 -0400158 $(call banner-leave,target $@)
159
160## -----------------------------------------------------------------------
161## Intent:
162## -----------------------------------------------------------------------
Zack Williams52209662019-02-07 10:15:31 -0700163python-clean:
Joey Armstronge66eaaf2023-01-15 18:58:52 -0500164 find python -name '__pycache__' -type d -print0 \
165 | xargs -0 --no-run-if-empty $(RM) -r
Joey Armstrongc2277652023-01-11 17:41:36 -0500166 find python -name '*.pyc' -type f -print0 \
167 | xargs -0 --no-run-if-empty $(RM)
Joey Armstronge6cdd8e2022-12-29 11:58:15 -0500168 $(RM) -r \
Zack Williams43bfd9e2019-04-12 13:09:31 -0700169 .coverage \
170 .tox \
171 coverage.xml \
172 dist \
173 nose2-results.xml \
174 python/__pycache__ \
175 python/test/__pycache__ \
176 python/voltha_protos.egg-info \
Joey Armstrong761579c2023-05-08 11:59:57 -0400177 "$(venv-abs-path)" \
Zack Williams43bfd9e2019-04-12 13:09:31 -0700178 $(PROTO_PYTHON_DEST_DIR)/*.desc \
179 $(PROTO_PYTHON_PB2) \
180 $(PROTO_PYTHON_PB2_GRPC)
Zack Williams52209662019-02-07 10:15:31 -0700181
Joey Armstrong761579c2023-05-08 11:59:57 -0400182## -----------------------------------------------------------------------
183## Intent: Revert go to a clean state.
184## o TODO - go/ directory should not be placed under revision control.
185## o Build should retrieve versioned sources from a central repo.
186## -----------------------------------------------------------------------
khenaidoo5fc5cea2021-08-11 17:39:16 -0400187go-clean:
Joey Armstronge6cdd8e2022-12-29 11:58:15 -0500188 $(RM) -r go/*
Joey Armstrong761579c2023-05-08 11:59:57 -0400189 $(HIDE)$(MAKE) repair
190
191## -----------------------------------------------------------------------
192## Intent: Recover from a fatal failed build state:
193## o build removes go/ while regenerating prototypes.
194## o chicken-n-egg: make becomes fatal when go/ is removed and proten fails.
195## -----------------------------------------------------------------------
196repair:
197 /usr/bin/env git checkout go
198
Joey Armstrong670d40c2023-05-11 20:49:26 -0400199## -----------------------------------------------------------------------
200## Intent: Go targets
201## -----------------------------------------------------------------------
Kent Hagerman868dc382020-01-20 11:24:09 -0500202go-protos: voltha.pb
Joey Armstrong670d40c2023-05-11 20:49:26 -0400203
Joey Armstrong56b36782023-05-30 17:30:11 -0400204 $(call banner-enter,target $@)
Joey Armstrong50080092023-07-06 15:18:37 -0400205 @echo "** Creating *.go.pb files"
Joey Armstrong1ff23e92023-07-13 16:24:32 -0400206
Joey Armstrong761579c2023-05-08 11:59:57 -0400207 ${PROTOC_SH} $(quote-double)\
Kent Hagerman868dc382020-01-20 11:24:09 -0500208 set -e -o pipefail; \
209 for x in ${PROTO_FILES}; do \
210 echo \$$x; \
211 protoc --go_out=plugins=grpc:/go/src -I protos \$$x; \
Joey Armstrong56b36782023-05-30 17:30:11 -0400212 done\
213 $(quote-double)
214
215 $(call banner-leave,target $@)
Zack Williams43bfd9e2019-04-12 13:09:31 -0700216
Joey Armstrong670d40c2023-05-11 20:49:26 -0400217## -----------------------------------------------------------------------
218## Intent:
Joey Armstrong56b36782023-05-30 17:30:11 -0400219## ----------------------------------------------------------------------
220voltha.pb: show-proto-files
Joey Armstrong670d40c2023-05-11 20:49:26 -0400221 $(call banner-enter,target $@)
222
223 ${PROTOC} \
224 -I protos \
225 -I protos/google/api \
226 --include_imports \
227 --include_source_info \
Kent Hagerman868dc382020-01-20 11:24:09 -0500228 --descriptor_set_out=$@ \
229 ${PROTO_FILES}
Zack Williams43bfd9e2019-04-12 13:09:31 -0700230
Joey Armstrong670d40c2023-05-11 20:49:26 -0400231 $(call banner-leave,target $@)
232
233## -----------------------------------------------------------------------
234## Intent:
235## -----------------------------------------------------------------------
Kent Hagerman868dc382020-01-20 11:24:09 -0500236go-test:
Joey Armstrong670d40c2023-05-11 20:49:26 -0400237 $(call banner-enter,target $@)
238
William Kurkianad745652019-03-20 08:45:51 -0400239 test/test-go-proto-consistency.sh
Kent Hagerman868dc382020-01-20 11:24:09 -0500240 ${GO} mod verify
Zack Williams52209662019-02-07 10:15:31 -0700241
Joey Armstrong670d40c2023-05-11 20:49:26 -0400242 $(call banner-leave,target $@)
243
244## -----------------------------------------------------------------------
245## Intent: Java targets
246## -----------------------------------------------------------------------
Joey Armstrong56b36782023-05-30 17:30:11 -0400247
248java-protos-dirs += java_temp/src/main/java
249java-protos-dirs += java_temp/src/main/java/org
250# local docker problem
251java-protos-dirs += java_temp/src/main/java/org/opencord/voltha/adapter
252java-protos-dirs += java_temp/src/main/java/org/opencord/voltha/adapter_service
253
254mkdir-args += -vp
Joey Armstrong56b36782023-05-30 17:30:11 -0400255
Kent Hagerman868dc382020-01-20 11:24:09 -0500256java-protos: voltha.pb
Joey Armstrong56b36782023-05-30 17:30:11 -0400257
Joey Armstrong670d40c2023-05-11 20:49:26 -0400258 $(call banner-enter,target $@)
259
Joey Armstrong56b36782023-05-30 17:30:11 -0400260 mkdir $(mkdir-args) $(java-protos-dirs)
Joey Armstrongcb986bf2023-12-12 17:22:05 -0500261
Joey Armstrong56b36782023-05-30 17:30:11 -0400262 $(docker-sh) $(quote-double) find $(java-protos-dirs) -print0 \
263 | xargs -0 -n1 /bin/ls -ld $(quote-double)
264
Joey Armstrongcb986bf2023-12-12 17:22:05 -0500265 $(if $(LOCAL_FIX_PERMS),chmod -R o+w java_temp)
Joey Armstrong761579c2023-05-08 11:59:57 -0400266 @${PROTOC_SH} $(quote-double) \
Kent Hagerman868dc382020-01-20 11:24:09 -0500267 set -e -o pipefail; \
268 for x in ${PROTO_FILES}; do \
269 echo \$$x; \
270 protoc --java_out=java_temp/src/main/java -I protos \$$x; \
Joey Armstrong56b36782023-05-30 17:30:11 -0400271 done\
272 $(quote-double)
Joey Armstrongcb986bf2023-12-12 17:22:05 -0500273 $(if $(LOCAL_FIX_PERMS),chmod -R o-w java_temp)
Serkant Uluderyacbcfaa42019-10-18 13:25:08 +0300274
Joey Armstrong670d40c2023-05-11 20:49:26 -0400275 # Move files into place after all prototypes have generated.
276 # TODO: Remove the extra step, use makefile deps and
277 # generate in-place as needed.
278 @mkdir -p java
Joey Armstrong50080092023-07-06 15:18:37 -0400279 rsync -r --checksum java_temp/src/main/java/. java/.
Joey Armstrong670d40c2023-05-11 20:49:26 -0400280
281 $(call banner-leave,target $@)
282
283## -----------------------------------------------------------------------
284## Intent: Tests if the generated java classes are compilable
285## -----------------------------------------------------------------------
Serkant Uluderyacbcfaa42019-10-18 13:25:08 +0300286java-test: java-protos
287 cp test/pom.xml java_temp
288 cd java_temp && mvn compile
289
Joey Armstrong670d40c2023-05-11 20:49:26 -0400290## -----------------------------------------------------------------------
291## Intent: Custodial service
292## -----------------------------------------------------------------------
Serkant Uluderyacbcfaa42019-10-18 13:25:08 +0300293java-clean:
Joey Armstronge6cdd8e2022-12-29 11:58:15 -0500294 $(RM) -r java
295 $(RM) -r java_temp
296
Joey Armstrong56b36782023-05-30 17:30:11 -0400297## -----------------------------------------------------------------------
298## Intent: Placeholder for library targets
299## -----------------------------------------------------------------------
Joey Armstronge66eaaf2023-01-15 18:58:52 -0500300lint :
301
Joey Armstrong56b36782023-05-30 17:30:11 -0400302## -----------------------------------------------------------------------
Joey Armstrong50080092023-07-06 15:18:37 -0400303## Intent: Make sterile is unrecoverable due to handling of java_temp
304## -----------------------------------------------------------------------
305protos-clean:
306 $(MAKE) sterile
307 $(MAKE) build
308 $(MAKE) protos
309 $(MAKE) test
310
311## -----------------------------------------------------------------------
Joey Armstrong56b36782023-05-30 17:30:11 -0400312## Intent: Display/debug targets
313## -----------------------------------------------------------------------
314.PHONY: show-proto-files
315show-proto-files:
Joey Armstrong1ff23e92023-07-13 16:24:32 -0400316
317 $(call banner-enter,Target $@)
318 @echo -e "PROTO_FILES:\n$(PROTO_FILES)" | tr ' ' '\n'
319 $(call banner-leave,Target $@)
Joey Armstrong56b36782023-05-30 17:30:11 -0400320
Joey Armstronge6cdd8e2022-12-29 11:58:15 -0500321# [EOF]
Joey Armstrong56b36782023-05-30 17:30:11 -0400322