blob: 5a31d9cb5452178324d10efe41a9d1290463d123 [file] [log] [blame]
Paul Jakma0b2aa3a2007-10-14 22:32:21 +000012007-09-27 Paul Jakma <paul.jakma@sun.com>
2
3 * bgp_aspath.c: (assegment_normalise) remove duplicates from
4 from sets.
5 (aspath_reconcile_as4) disregard a broken part of the RFC around
6 error handling in path reconciliation.
7
82007-09-25 Paul Jakma <paul.jakma@sun.com>
9
10 * bgp_open.c: (peek_for_as4_capability) Fix to work.
11 * bgp_packet.c: (bgp_open_receive) Fix sanity check of as4.
12
132007-09-18 Paul Jakma <paul.jakma@sun.com>
14
15 * bgp_open.c: (bgp_capability_as4) debug printf inline with others.
16 (peek_for_as4_capability) There's no need to signal failure, as
17 failure is better dealt with through full capability parser -
18 just return the AS4, simpler.
19 * bgp_packet.c: (bgp_open_receive) Update to match
20 peek_for_as4_capability change.
21 Allow use of BGP_AS_TRANS by 2b speakers.
22 Use NOTIFY_OPEN_ERR rather than CEASE for OPEN parsing errors.
23 (bgp_capability_msg_parse) missing argument to debug print
24 (bgp_capability_receive) missing return values.
25
26
272007-07-25 Paul Jakma <paul.jakma@sun.com>
28
29 * Remove 2-byte size macros, just make existing macros take
30 argument to indicate which size to use.
31 Adjust all users - typically they want '1'.
32 * bgp_aspath.c: (aspath_has_as4) New, return 1 if there are any
33 as4's in a path.
34 (aspath_put) Return the number of bytes actually written, to
35 fix the bug Juergen noted: Splitting of segments will change
36 the number of bytes written from that already written to the
37 AS_PATH header.
38 (aspath_snmp_pathseg) Pass 2-byte flag to aspath_put. SNMP
39 is still defined as 2b.
40 (aspath_aggregate) fix latent bug.
41 (aspath_reconcile_as4) AS_PATH+NEW_AS_PATH reconciliation
42 function.
43 (aspath_key_make) Hash the AS_PATH string, rather than
44 just taking the addition of assegment ASes as the hash value,
45 hopefully sligthly more collision resistant.
46 (bgp_attr_munge_as4_attrs) Collide the NEW_ attributes
47 together with the OLD 2-byte forms, code Juergen
48 had in bgp_attr_parse but re-organised a bit.
49 (bgp_attr_parse) Bunch of code from Juergen moves
50 to previous function.
51 (bgp_packet_attribute) Compact significantly by
52 just /always/ using extended-length attr header.
53 Fix bug Juergen noted, by using aspath_put's
54 (new) returned size value for the attr header rather
55 than the (guesstimate) of aspath_size() - the two could
56 differ when aspath_put had to split large segments, unlikely
57 this bug was ever hit in the 'wild'.
58 (bgp_dump_routes_attr) Always use extended-len and
59 use aspath_put return for header length. Output 4b ASN
60 for AS_PATH and AGGREGATOR.
61 * bgp_ecommunity.c: (ecommunity_{hash_make,cmp}) fix
62 hash callback declarations to match prototypes.
63 (ecommunity_gettoken) Updated for ECOMMUNITY_ENCODE_AS4,
64 complete rewrite of Juergen's changes (no asdot support)
65 * bgp_open.c: (bgp_capability_as4) New, does what it says
66 on the tin.
67 (peek_for_as4_capability) Rewritten to use streams and
68 bgp_capability_as4.
69 * bgp_packet.c: (bgp_open_send) minor edit
70 checked (in the abstract at least) with Juergen.
71 Changes are to be more accepting, e.g, allow AS_TRANS on
72 a 2-byte session.
73 * (general) Update all commands to use CMD_AS_RANGE.
74 * bgp_vty.c: (bgp_clear) Fix return vals to use CMD_..
75 Remove stuff replicated by VTY_GET_LONG
76 (bgp_clear_vty) Return bgp_clear directly to vty.
77
78
792007-07-25 Juergen Kammer <j.kammer@eurodata.de>
80
81 * (general) AS4 support.
82 * bgpd.h: as_t changes to 4-bytes.
83 * bgp_aspath.h: Add BGP_AS4_MAX and BGP_AS_TRANS defines.
84 * bgp_aspath.c: AS_VALUE_SIZE becomes 4-byte, AS16_VALUE_SIZE
85 added for 2-byte.
86 Add AS16 versions of length calc macros.
87 (aspath_count_numas) New, count number of ASes.
88 (aspath_has_as4) New, return 1 if there are any as4's in a
89 path.
90 (assegments_parse) Interpret assegment as 4 or 2 byte,
91 according to how the caller instructs us, with a new
92 argument.
93 (aspath_parse) Add use32bit argument to pass to
94 assegments_parse. Adjust all its callers to pass 1, unless
95 otherwise noted.
96 (assegment_data_put) Adjust to be able to write 2 or 4 byte
97 AS, according to new use32bit argument.
98 (aspath_put) Adjust to write 2 or 4.
99 (aspath_gettoken) Use a long for passed in asno.
100 * bgp_attr.c: (attr_str) Add BGP_ATTR_AS4_PATH and
101 BGP_ATTR_AS4_AGGREGATOR.
102 (bgp_attr_aspath) Call aspath_parse with right 2/4 arg, as
103 determined by received-capability flag.
104 (bgp_attr_aspath_check) New, code previously in attr_aspath
105 but moved to new func so it can be run after NEW_AS_PATH
106 reconciliation.
107 (bgp_attr_as4_path) New, handle NEW_AS_PATH.
108 (bgp_attr_aggregator) Adjust to cope with 2/4 byte ASes.
109 (bgp_attr_as4_aggregator) New, read NEW_AGGREGATOR.
110 (bgp_attr_parse) Add handoffs to previous parsers for the two
111 new AS4 NEW_ attributes.
112 Various checks added for NEW/OLD reconciliation.
113 (bgp_packet_attribute) Support 2/4 for AS_PATH and
114 AGGREGATOR, detect when NEW_ attrs need to be sent.
115 * bgp_debug.{c,h}: Add 'debug bgp as4'.
116 * bgp_dump.c: MRTv2 support, unconditionally enabled, which
117 supports AS4. Based on patches from Erik (RIPE?).
118 * bgp_ecommunity.c: (ecommunity_ecom2str) ECOMMUNITY_ENCODE_AS4
119 support.
120 * bgp_open.c: (peek_for_as4_capability) New, peek for AS4
121 capability prior to full capability parsing, so we know which
122 ASN to use for struct peer lookup.
123 (bgp_open_capability) Always send AS4 capability.
124 * bgp_packet.c: (bgp_open_send) AS4 handling for AS field
125 (bgp_open_receive) Peek for AS4 capability first, and figure
126 out which AS to believe.
127 * bgp_vty.c: (bgp_show_peer) Print AS4 cap
128
Paul Jakmae08286b2007-09-18 12:11:26 +00001292007-09-17 Paul Jakma <paul.jakma@sun.com>
130
131 * bgp_open.c: (bgp_capability_mp) We were setting
132 afc_nego[safi][safi] rather than afc_nego[afi][safi], thus
133 failling to announce any non-IPv4 prefixes. Remove the extra,
134 typo-ed character.
135
Paul Jakmab2ceea12007-09-07 14:24:55 +00001362007-09-07 Paul Jakma <paul.jakma@sun.com>
137
138 * (general) bgpd can be made crash by remote peers if debug
139 bgp updates is set, due to NULL pointer dereference.
140 Reported by "Mu Security Research Team",
141 <security@musecurity.com>.
142 * bgp_attr.c: (bgp_attr_community) If community length is 0,
143 don't set the community-present attribute bit, just return
144 early.
145 * bgp_debug.c: (community_str,community_com2str) Check com
146 pointer before dereferencing.
147
Paul Jakma9eda90c2007-08-30 13:36:17 +00001482007-08-27 Paul Jakma <paul.jakma@sun.com>
149
150 * bgp_route.c: (bgp_announce_check) Fix bug #398, slight
151 modification of Vladimir Ivanov's suggested fix - to keep
152 memory alloc conditional.
153 (bgp_process_announce_selected) Don't take struct attr as
154 argument, none of the callers need it and it needlessly
155 distances allocation from use.
156 Free the extended attr, the attr itself is on the stack.
157 Fix bad indentation.
158 * bgp_attr.c: (bgp_packet_attribute) Remove incorrect assert,
159 and adjust conditional to test attr->extra, diagnosis by
160 Vladimir Ivanov in bug #398.
161
1622007-08-27 Vladimir Ivanov <wawa@yandex-team.ru>
163
164 * bgp_route.c: (bgp_announce_check_rsclient) copy of
165 ri->attr is no longer deep enough, due to addition of
166 attr->extra. It should use bgp_attr_dup, as
167 bgp_announce_check() does.
168
Paul Jakma6d134fb2007-08-23 23:22:02 +00001692007-08-23 Paul Jakma <paul.jakma@sun.com>
170
171 * bgp_regex.c: (bgp_regcomp) Pass NOSUB flag to regcomp to
172 prevent parsing of substitutions, which can have profound
173 performance effects on bgpd and are of no use to the CLI
174 anyway. How much it helps depends on the regex
175 implementation.
176
Paul Jakma41367172007-08-06 15:24:51 +00001772007-07-31 Paul Jakma <paul.jakma@sun.com>
178
179 * (general) Support for draft-ietf-idr-as-pathlimit-03.
180 * bgp_attr.h: (struct attr) Add pathlimit struct
181 bgp_attr.c: (attr_str) Add BGP_ATTR_AS_PATHLIMIT string.
182 (attrhash_key_make) tally pathlimit too
183 (attrhash_cmp) cmp pathlimit attr
184 (bgp_attr_aspathlimit) New, parse AS_PATHLIMIT attr.
185 (bgp_attr_parse) ditto
186 (bgp_packet_attribute) Write out AS_PATHLIMIT when set
187 (bgp_dump_routes_attr) ditto
188 * bgp_route.h: (struct bgp_static) Add TTL field
189 * bgp_route.c: (bgp_announce_check) Drop paths that are over
190 their hop-count TTL before sending via EBGP.
191 Mangle ASN in pathlimit for confeds/private as best we can.
192 (bgp_static_update_{rsclient,main}) Add any configure pathlimit
193 information.
194 (bgp_pathlimit_update_parents) New, update atomic-aggr setting for
195 parents of an aspathlimit'ed static.
196 (bgp_static_set) Add TTL argument, for all the 'bgp network'
197 commands.
198 Call previous for TTL changed statics.
199 (bgp_static_unset) Call pathlimit_update_parents.
200 (various bgp network commands) Add 'pathlimit <0-255>' qualifier
201 to all the various forms, bar route-map - which can set ttl
202 itself.
203 * bgp_routemap.c: (general) Add support for 'set pathlimit ttl' and
204 'match pathlimit as'.
205
Paul Jakma6d582722007-08-06 15:21:45 +00002062007-07-26 Paul Jakma <paul.jakma@sun.com>
207
208 * (general) Clean up and compact capability parsing slightly.
209 Consolidate validation of length and logging of generic TLV, and
210 memcpy of capability data, thus removing such from cap specifc
211 code (not always present or correct).
212 * bgp_open.h: Add structures for the generic capability TLV header
213 and for the data formats of the various specific capabilities we
214 support. Hence remove the badly named, or else misdefined, struct
215 capability.
216 * bgp_open.c: (bgp_capability_vty_out) Use struct capability_mp_data.
217 Do the length checks *before* memcpy()'ing based on that length
218 (stored capability - should have been validated anyway on input,
219 but..).
220 (bgp_afi_safi_valid_indices) new function to validate (afi,safi)
221 which is about to be used as index into arrays, consolidates
222 several instances of same, at least one of which appeared to be
223 incomplete..
224 (bgp_capability_mp) Much condensed.
225 (bgp_capability_orf_entry) New, process one ORF entry
226 (bgp_capability_orf) Condensed. Fixed to process all ORF entries.
227 (bgp_capability_restart) Condensed, and fixed to use a
228 cap-specific type, rather than abusing capability_mp.
229 (struct message capcode_str) added to aid generic logging.
230 (size_t cap_minsizes[]) added to aid generic validation of
231 capability length field.
232 (bgp_capability_parse) Generic logging and validation of TLV
233 consolidated here. Code compacted as much as possible.
234 * bgp_packet.c: (bgp_open_receive) Capability parsers now use
235 streams, so no more need here to manually fudge the input stream
236 getp.
237 (bgp_capability_msg_parse) use struct capability_mp_data. Validate
238 lengths /before/ memcpy. Use bgp_afi_safi_valid_indices.
239 (bgp_capability_receive) Exported for use by test harness.
240 * bgp_vty.c: (bgp_show_summary) fix conversion warning
241 (bgp_show_peer) ditto
242 * bgp_debug.h: Fix storage 'extern' after type 'const'.
243
Paul Jakma45ad5922007-07-31 17:35:36 +00002442007-07-31 Lorenzo Colitti <lorenzo@colitti.com>
245
246 * bgp_dump.c: (general) Add comments to code.
247 (bgp_dump_interval_add) remove some redundant lines.
248 (bgp_dump_set) Use enum for type argument.
249 Avoid scheduling dump twice if exact same command
250 is given twice..
251
Paul Jakma536792c2007-06-22 19:11:14 +00002522007-06-22 Paul Jakma <paul.jakma@sun.com>
253
254 * bgp_fsm.c: (struct FSM) Bug #368. TCP Errors during OpenSent
255 should cycle to Active, not to Idle or else peer bringup can
256 race and cycle Idle<->Active. Reported and fix tested by
257 Mukesh Agrawal.
258
Paul Jakmab2497022007-06-14 11:17:58 +00002592007-05-25 Paul Jakma <paul.jakma@sun.com>
260
261 * bgp_route.c: (bgp_default_originate) Sanity check added
262 previously was broken and always failed, thus this function
263 never could run, bug #370.
264
Paul Jakmafb982c22007-05-04 20:15:47 +00002652007-05-03 Paul Jakma <paul.jakma@sun.com>
Paul Jakma923de652007-04-29 18:25:17 +0000266
Paul Jakmafb982c22007-05-04 20:15:47 +0000267 * bgp_route.h: (struct info) Move less frequently used
268 fields to a lazily allocated struct info_extra.
269 Export bgp_info_extra_get
270 * bgp_route.c: (bgp_info_extra_new) allocate extra
271 (bgp_info_extra_free) Free damp info and the info_extra.
272 (bgp_info_extra_get) Retrieve the info_extra of a struct
273 info, allocating as required.
274 (generally) adjust to use info->extra
275 * bgp_damp.c: (generally) use bgp_info_extra_get to access
276 dampinfo
277 * bgp_attr.h: Move rarely allocated attributes from struct attr
278 to a struct attr_extra, for a substantial saving in size of
279 struct attr.
280 * bgp_attr.c: (bgp_attr_extra_{new,free}), new, self-explanatory.
281 (bgp_attr_extra_get) Get the attr_extra for a given struct
282 attr, allocating it if needs be.
283 (bgp_attr_dup) Shallow copy the struct attr and its attr_extra.
284 (generally) adjust to know about attr->extra.
285 * bgp_debug.c: (bgp_dump_attr) ditto
286 * bgp_vty.c: (show_bgp_memory) print attr and info extra sizes.
287 * bgp_nexthop.c: (generally) adjust to know about attr->extra
288 and info->extra.
289 * bgp_{packet,routemap,snmp,zebra}.c: ditto
290
2912007-04-22 Sebastien Tandel <sebastien@tandel.be>
Paul Jakma923de652007-04-29 18:25:17 +0000292 * bgp_advertise.c : (baa_hash_alloc, baa_hash_key, baa_hash_cmp)
293 conforms to quagga hash API. Defines _hash_[alloc|key|cmp] with
294 void * arguments as defined by the API.
295 * bgp_aspath.c,h : (aspath_key_make) conforms to quagga hash API.
296 Defines _hash_[alloc|key|cmp] with void * arguments as defined by
297 the API.
298 * bgp_attr.c,h : (cluster_hash_alloc, cluster_hash_key_make,
299 cluster_hash_cmp, transit_hash_alloc, transit_hash_key_make,
300 transit_hash_cmp, attrhash_key_make, attrhash_cmp,
301 bgp_attr_hash_alloc) conforms to quagga hash API. Defines
302 _hash_[alloc|key|cmp] with void * arguments as defined by the API.
Paul Jakma03e214c2007-04-29 18:31:07 +0000303 * bgp_attr.h : Definition of BGP_ATTR_DEFAULT_WEIGHT.
304 * bgp_attr.c : (bgp_attr_default_intern) now uses
305 bgp_attr_default_set instead of duplicating the same code.
306 (general) Use of BGP_ATTR_DEFAULT_WEIGHT. Replace two 16 by
307 IPV6_MAX_BYTELEN.
Paul Jakma923de652007-04-29 18:25:17 +0000308
Andrew J. Schorr93c17492007-04-15 19:17:24 +00003092007-04-15 Sebastien Tandel <sebastien@tandel.be>
310
311 * bgp_aspath.c: (aspath_as_add, aspath_segment_add) Minor performance
312 optimization: while loop should test one pointer instead of two.
313
Paul Jakma16d2e242007-04-10 19:32:10 +00003142007-04-08 Paul Jakma <paul.jakma@sun.com>
315
316 * bgp_route.c: (general) Same bug as fixed on 2006-11-28 by ajs for
317 bgp static routes, but for main BGP RIB: Quick 'flap' of routes
318 can cause bgpd to mistake a new route for a duplicate route,
319 due to presence of removed, but not yet processed BGP RIB entry.
320 (bgp_update_rsclient) Ignore REMOVED bgp_info for duplicate,
321 restore route instead.
322 (bgp_update_main) Ditto.
Paul Jakma6e4ab122007-04-10 19:36:48 +0000323 * bgp_attr.c: (general) Bug #354: parsing of MP_REACH_NLRI and
324 MP_UNREACH_NLRI does not take sufficient care to ensure reads
325 from stream buffer stay in-bounds. Hence bgpd may attempt to read
326 beyond end of stream, if given a crafted packet. As it uses the
327 stream access methods to do so, this will typically result in
328 assert() being hit in stream.c. Where code is compiled without
329 assert() enabled, result is unknown.
330 (struct message attr_str) should be static.
331 (bgp_mp_reach_parse) Carefully check length remaining in stream
332 against amount desired to read from stream, prior to each read,
333 particularly where lengths are conditional on data obtained from
334 stream - using STREAM_READABLE.
335 Remove code to parse SNPA-number, it's a defunct field and changed
336 to a fixed size in latest BGP MP update RFC - log warning if
337 SNPA-number is not 0.
338 (bgp_mp_unreach_parse) Check withdraw_length carefully against
339 STREAM_READABLE.
340 (bgp_attr_parse) If attribute-parser function returns error, log
341 warning.
342 Log attribute type on mismatch.
Paul Jakma16d2e242007-04-10 19:32:10 +0000343
Paul Jakma37a217a2007-04-10 19:20:29 +00003442007-04-07 Paul Jakma <paul.jakma@sun.com>
345
346 * bgpd.c: (general) Fix bug #352
347 (bgp_config_write_family_header) write ipv6/multicast
348 address family header.
349 (bgp_config_write) write out ipv6 multicast AF config.
350
Paul Jakmaf2c31ac2007-02-22 17:48:42 +00003512007-02-22 Paul Jakma <paul.jakma@sun.com>
352
353 * bgp_fsm.c: (bgp_fsm_change_status) Handle state change into
354 clearing or greater here. Simpler.
355 (bgp_event) Clearing state change work moved to previous
356 * bgp_route.c: (bgp_clear_route_node) Clearing adj-in here
357 is too late, as it leaves a race between a peer being deleted
358 and an identical peer being configured before clearing
359 completes, leading to a crash.
360 Simplest fix is to clean peers Adj-in up-front, rather than
361 queueing such work.
362 (bgp_clear_route_table) Clear peer's Adj-In and Adj-Out
363 up-front here, rather than queueing such work.
364 Extensive comment added on the various bits of indexed data
365 that exist and how they need to be dealt with.
366 (bgp_clear_route) Update comment.
367
Andrew J. Schorre4529632006-12-12 19:18:21 +00003682006-12-12 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
369
370 * bgp_nexthop.c: (bgp_connected_add, bgp_connected_delete)
371 Simplify logic by using new CONNECTED_PREFIX macro.
372
Paul Jakma95fdcd82006-12-08 00:31:22 +00003732006-12-07 Paul Jakma <paul.jakma@sun.com>
374
375 * bgp_fsm.c: Bug #302 fix, diagnosis, suggestions and testing
376 by Juergen Kammer <j.kammer@eurodata.de>. Fix follows from
377 his suggested fix, just made in a slightly different way.
378 (bgp_event) Transitions into Clearing always must call
379 bgp_clear_route_all().
380 (bgp_stop) No need to clear routes here, BGP FSM should do
381 it.
382
Andrew J. Schorra39275d2006-11-30 16:36:57 +00003832006-11-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
384
385 * bgp_debug.h: Declare new bgp_debug_zebra conf and term flags,
386 and define BGP_DEBUG_ZEBRA.
387 * bgp_debug.c: Declare conf_bgp_debug_zebra and term_bgp_debug_zebra.
388 (debug_bgp_zebra, no_debug_bgp_zebra, undebug_bgp_zebra) New
389 functions to enable/disable bgp zebra debugging.
390 (no_debug_bgp_all) Turn off zebra debugging.
391 (show_debugging_bgp) Show whether zebra debugging is on.
392 (bgp_config_write_debug) Add 'debug bgp zebra' if configured.
393 (bgp_debug_init) Add new zebra debugging commands.
394 * bgp_zebra.c: (bgp_router_id_update, bgp_interface_add,
395 bgp_interface_delete, bgp_interface_up, bgp_interface_down,
396 bgp_interface_address_add, bgp_interface_address_delete,
397 zebra_read_ipv4, zebra_read_ipv6, bgp_zebra_announce,
398 bgp_zebra_withdraw, bgp_redistribute_set, bgp_redistribute_unset)
399 If zebra debugging is enabled, log an appropriate debug message.
400
Andrew J. Schorr8d452102006-11-28 19:50:46 +00004012006-11-28 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
402
403 * bgp_route.c: (bgp_info_restore) New function that undoes
404 the effects of a previous call to bgp_info_delete. This is
405 used when a route is deleted and quickly re-added before the
406 deletion has been processed.
407 (bgp_static_update_rsclient, bgp_static_update_main,
408 bgp_redistribute_add) Check whether a pre-existing route
409 has the BGP_INFO_REMOVED set, and, if so, we need to call
410 bgp_info_restore to resurrect it.
411
Paul Jakma56395af2006-10-27 16:58:20 +00004122006-10-27 Paul Jakma <paul.jakma@sun.com>
413
414 * bgp_route.c: (bgp_table_stats) oops, u_intXX_t should be
415 uintXX_t
416
Paul Jakma6f585442006-10-22 19:13:07 +00004172006-10-19 Paul Jakma <paul.jakma@sun.com>
418
419 * bgpd.c: (peer_new) bgp element of peer absolutely must be
420 filled in, make peer_new() require it as argument and update
421 all callers. Fixes a crash reported by Jan 'yanek' Bortl and
422 Andrew Schorr where bgpd would crash in bgp_pcount_adjust
423 trying to dereference the bgp member of bgp->peer_self,
424 triggered through redistribution.
425 * bgp_route.c: (bgp_pcount_adjust) assert sanity of arguments.
426
Paul Jakma53d9f672006-10-15 23:41:16 +00004272006-10-15 Paul Jakma <paul.jakma@sun.com>
428
429 * bgp_route.c: (bgp_table_stats_walker) NULL deref if table is
430 empty, bgp_table_top may return NULL, Coverity CID#73.
Paul Jakmaed3ebfa2006-10-15 23:50:16 +0000431 * bgp_packet.c: (bgp_update_packet) adv->rn can not be NULL,
432 check is bogus - changed to assert(), CID#64.
433 binfo is checked for NULL, but then dereferenced
434 unconditionally, fix, CID #63.
435 (bgp_withdraw_packet) Assert adv->rn is valid, as with
436 bgp_update_packet().
Paul Jakma53d9f672006-10-15 23:41:16 +0000437
Paul Jakmadcdf3992006-10-15 23:39:59 +00004382006-10-14 Paul Jakma <paul.jakma@sun.com>
439
440 * bgp_fsm.h: Remove BGP_EVENT_FLUSH_ADD, dangerous and not
441 needed.
442 * bgp_fsm.c: (bgp_stop) Move BGP_EVENT_FLUSH to the top of the
443 of the function, otherwise it could flush a ClearingCompleted
444 event, bug #302.
445 * bgp_packet.c: Replace all BGP_EVENT_FLUSH_ADD with
446 BGP_EVENT_ADD, fixing bug #302.
447
Andrew J. Schorr0cd1c322006-09-19 18:51:53 +00004482006-09-19 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
449
450 * bgpd.c: (peer_uptime) Fix printf format/arg mismatch in
451 zlog_warn message (%ld/size_t -> %lu/u_long).
452
Paul Jakmaca058a32006-09-14 02:58:49 +00004532006-09-14 Paul Jakma <paul.jakma@sun.com>
454
Paul Jakma8383a9b2006-09-14 03:06:54 +0000455 * bgp_route.c: (bgp_table_stats_walker) Address space announced
456 should only count top-level unaggregateable prefixes, to
457 avoid falling afoul of anti-dodgy-accounting regulations
458 in various jurisdictions.. ;)
Paul Jakma09dd5612006-09-14 03:38:16 +0000459 (bgp_process_queue_init) process queue hold time too high,
460 adds extra memory load. Change to be much lower, until such
461 time as it's made configurable.
Paul Jakma8383a9b2006-09-14 03:06:54 +0000462
4632006-09-14 Paul Jakma <paul.jakma@sun.com>
464
Paul Jakma9fde6622006-09-14 03:02:02 +0000465 * (general) fix the peer refcount issue exposed by previous, by
466 just removing refcounting of peer threads, which is mostly
467 senseless as they're references leading from struct peer,
468 which peer_free cancels anyway. No need to muck around..
469 * bgp_fsm.h: Just remove the refcounting from the various
470 TIMER/READ/WRITE/EVENT ON/OFF/ADD macros.
471 * bgp_fsm.c: (bgp_stop) use BGP_EVENT_FLUSH, no refcounts attached
472 to events anymore.
473 (bgp_event) remove peer_unlock, events not refcounted.
474 * bgpd.c: (peer_free) flush events before free.
475
4762006-09-14 Paul Jakma <paul.jakma@sun.com>
477
Paul Jakmaca058a32006-09-14 02:58:49 +0000478 * (general) Fix some niggly issues around 'shutdown' and clearing
479 by adding a Clearing FSM wait-state and a hidden 'Deleted'
480 FSM state, to allow deleted peers to 'cool off' and hit 0
481 references. This introduces a slow memory leak of struct peer,
482 however that's more a testament to the fragility of the
483 reference counting than a bug in this patch, cleanup of
484 reference counting to fix this is to follow.
485 * bgpd.h: Add Clearing, Deleted states and Clearing_Completed
486 and event.
487 * bgp_debug.c: (bgp_status_msg[]) Add strings for Clearing and
488 Deleted.
489 * bgp_fsm.h: Don't allow timer/event threads to set anything
490 for Deleted peers.
491 * bgp_fsm.c: (bgp_timer_set) Add Clearing and Deleted. Deleted
492 needs to stop everything.
493 (bgp_stop) Remove explicit fsm_change_status call, the
494 general framework handles the transition.
495 (bgp_start) Log a warning if a start is attempted on a peer
496 that should stay down, trying to start a peer.
497 (struct .. FSM) Add Clearing_Completed
498 events, has little influence except when in state
499 Clearing to signal wait-state can end.
500 Add Clearing and Deleted states, former is a wait-state,
501 latter is a placeholder state to allow peers to disappear
502 quietly once refcounts settle.
503 (bgp_event) Try reduce verbosity of FSM state-change debug,
504 changes to same state are not interesting (Established->Established)
505 Allow NULL action functions in FSM.
506 * bgp_packet.c: (bgp_write) Use FSM events, rather than trying
507 to twiddle directly with FSM state behind the back of FSM.
508 (bgp_write_notify) ditto.
509 (bgp_read) Remove the vague ACCEPT_PEER peer_unlock, or else
510 this patch crashes, now it leaks instead.
511 * bgp_route.c: (bgp_clear_node_complete) Clearing_Completed
512 event, to end clearing.
513 (bgp_clear_route) See extensive comments.
514 * bgpd.c: (peer_free) should only be called while in Deleted,
515 peer refcounting controls when peer_free is called.
516 bgp_sync_delete should be here, not in peer_delete.
517 (peer_delete) Initiate delete.
518 Transition to Deleted state manually.
519 When removing peer from indices that provide visibility of it,
520 take great care to be idempotent wrt the reference counting
521 of struct peer through those indices.
522 Use bgp_timer_set, rather than replicating.
523 Call to bgp_sync_delete isn't appropriate here, sync can be
524 referenced while shutting down and finishing deletion.
525 (peer_group_bind) Take care to be idempotent wrt list references
526 indexing peers.
527
Paul Jakma2815e612006-09-14 02:56:07 +00005282006-09-13 Paul Jakma <paul.jakma@sun.com>
529
530 * bgp_aspath.c: (aspath_highest) new, return highest ASN in an
531 aspath.
532 * bgp_route.c: (bgp_peer_count_walker) new, do the walk done
533 in bgp_peer_counts as a thread.
534 (bgp_peer_counts) move walk to previous and call it via
535 thread_execute so this RIB walk shows up in thread stats.
536 (bgp_table_stats) New, gather some statistics for a given
537 RIB.
538 (bgp_table_stats_walker) New, RIB walker thread for former.
539 (bgp_table_stats_vty) Parsing front-end for 'show bgp ...',
540 useful model for future rationalisation of 'show ... bgp'.
541 (bgp_route_init) Add new RIB stats commands.
542
Paul Jakma1a392d42006-09-07 00:24:49 +00005432006-09-06 Paul Jakma <paul.jakma@sun.com>
544
545 * (general) Squash any and all prefix-count issues by
546 abstracting route flag changes, and maintaining count as and
547 when flags are modified (rather than relying on explicit
548 modifications of count being sprinkled in just the right
549 places throughout the code).
550 * bgp_route.c: (bgp_pcount_{dec,inc}rement) removed.
551 (bgp_pcount_adjust) new, update prefix count as
552 needed for a given route.
553 (bgp_info_{uns,s}et_flag) set/unset a BGP_INFO route status
554 flag, calling previous function when appropriate.
555 (general) Update all set/unsets of flags to use previous.
556 Remove pcount_{dec,inc}rement calls.
557 No need to unset BGP_INFO_VALID in places where
558 bgp_info_delete is called, it does that anyway.
559 * bgp_{damp,nexthop}.c: Update to use bgp_info_{un,}set_flag.
560 * bgp_route.h: Export bgp_info_{un,}set_flag.
561 Add a 'meta' BGP_INFO flag, BGP_INFO_UNUSEABLE.
562 Move BGP_INFO_HOLDDOWN macro to here from bgpd.h
563
Paul Jakmaff7924f2006-09-04 01:10:36 +00005642006-09-03 Paul Jakma <paul.jakma@sun.com>
565
566 * bgp_route.c: Add 'show ... bgp ... <neighbour> prefix-count'
567 commands, to provide detailed counts of prefixes for a peer.
568 Informative, and should help pin down to pfxcnt drift
569 problems.
570
Paul Jakma9f906c72006-08-27 06:57:47 +00005712006-08-27 Paul Jakma <paul.jakma@sun.com>
572
573 * bgp_advertise.c: (bgp_sync_delete) fix mtype in XFREE.
574 NULL out peer->hash after free, to be sure.
575
Paul Jakma1f742f22006-08-06 15:52:11 +00005762006-08-06 Paul Jakma <paul.jakma@sun.com>
577
578 * bgp_aspath.c: (aspath_loop_check) Fix the typo-bug which
579 essentially had disabled this check. Problem reported by
580 Bartek Kania <mrbk@gnarf.org> in [quagga-users 7388].
581
Paul Jakma18937402006-07-27 19:05:12 +00005822006-07-27 Paul Jakma <paul.jakma@sun.com>
583
584 * bgpd.c: (peer_delete) Ensure freed buffers can not be
585 accidently reused. A potential fix for bug #287.
586
Paul Jakma33d5ab92006-07-02 11:01:50 +00005872006-07-02 Paul Jakma <paul.jakma@sun.com>
588
589 * bgp_fsm.c: (bgp_{stop,start}) Move clear/free of certain
590 bits of state from stop to start, as they may be used via
591 peer references on clearing queues..
592
Paul Jakma369688c2006-05-23 22:27:55 +00005932006-05-23 Paul Jakma <paul.jakma@sun.com>
594
595 * bgp_vty.c: (neighbor_update_source_cmd) Expand tab completion
596 to make it clear it takes both address and ifname.
597
Paul Jakma34c3f812006-05-12 23:25:37 +00005982006-05-12 Paul Jakma <paul.jakma@sun.com>
599
600 * bgp_attr.c: (bgp_packet_attribute) Remove dead code, Coverity
601 CID #1
Paul Jakmab2518c12006-05-12 23:48:40 +0000602 * bgp_aspath.{c,h}: (aspath_print_vty) take a format string,
603 so as to reduce burden on callers, all in bgp_route.c
Paul Jakmadd8103a2006-05-12 23:27:30 +0000604 * bgp_route.c: (bgp_static_update_main) Remove useless NULL
605 check, code already assumes bgp_static can not be NULL,
606 fixes CID #7.
Paul Jakma06e110f2006-05-12 23:29:22 +0000607 (bgp_static_update_rsclient) ditto, CID #6
Paul Jakmab2518c12006-05-12 23:48:40 +0000608 (route_vty_out{,tmp}) Update to match aspath_print_vty,
609 simplifying checks needed to get spacing right. CID #4,#5.
610 ({damp,flap}_route_vty_out) Ditto, CID #9, #10
Paul Jakma34c3f812006-05-12 23:25:37 +0000611
Paul Jakma542bcb72006-05-08 14:25:09 +00006122006-05-08 Paul Jakma <paul.jakma@sun.com>
613
614 * bgp_community.c: (community_str2com) Coverity CID#62, fix
615 double-free, use-after-free.
Paul Jakmada5b30f2006-05-08 14:37:17 +0000616 * bgp_route.c: (bgp_afi_node_get) given table should never be
617 NULL, check/assert this.
618 (bgp_static_update) Bug #240. Rsclients should only be passed
619 the static update if they are configured for the afi,safi.
Paul Jakma542bcb72006-05-08 14:25:09 +0000620
Paul Jakmaa3b6ea52006-05-04 07:52:12 +00006212006-05-04 Paul Jakma <paul.jakma@sun.com>
622
623 * (general) VPNv4 fixes. Certain VPNv4 code was not enabled.
624 See bug #210.
625 * bgp_attr.{c,h}: (bgp_packet_{withdraw,attribute}) Tag should be
626 u_char really.
627 * bgp_packet.c: (bgp_{update,withdraw}_packet) Enable some
628 VPNv4 code which inexplicably was ifdef'd out. comments from
629 a tester on IRC suggest this fixes bug #210.
Paul Jakma65ca75e2006-05-04 08:08:15 +0000630 * bgp_route.c: (general) Fix logical bug in clearing, noted
631 by Chris Caputo in [quagga-users 6728] - clearing depended on
632 at least one route being added to workqueue, in order for
633 workqueue completion function to restart FSM. However, if no
634 routes are cleared, then the completion function never is
635 called, it needs to be called manually if the workqueue
636 didn't get scheduled.
637 Finally, clearing is per-peer-session, not per AFI/SAFI, so
638 the FSM synchronisation should be in bgp_clear_route_table.
639 (bgp_clear_route_table) Wrong place for FSM/clearing
640 synchronisation, move to..
641 (bgp_clear_route) FSM/clearing synchronisation should be
642 here.
643 If no routes were cleared, no workqueue scheduled, call
644 the completion func to ensure FSM kicks off again.
Paul Jakmaa3b6ea52006-05-04 07:52:12 +0000645
Paul Jakma15aa6a12006-03-30 14:39:35 +00006462006-03-30 Paul Jakma <paul.jakma@sun.com>
647
648 * bgp_community.c: (community_gettoken) Unknown token should
649 return NULL, to give a strong indication to callers that
650 the token no longer can be parsed, otherwise callers looping
651 on this function may have a hard time ending their loop.
652 (community_str2com) While loop around community_gettoken appears
653 to have been coded thinking that break statement would break
654 from the while{}, hence it could never exit for unknown token
655 case. Fix it to do..while, so it can use the NULL result from
656 community_gettoken easily.
657
Paul Jakmaa625ca32006-03-30 14:12:38 +00006582006-03-22 Paul Jakma <paul.jakma@sun.com>
659
660 * bgpd.c: (peer_free) release the per-peer workqueue when
661 freeing the peer.
662
Paul Jakma5304cb52006-03-30 14:01:14 +00006632006-03-19 Paul Jakma <paul.jakma@sun.com>
664
Paul Jakma4bf6a362006-03-30 14:05:23 +0000665 * bgpd/bgp_vty.c: Add includes to get several structs we want
666 to provide usage statistics on.
667 (show_bgp_memory_cmd) Show memory usage stats for various
668 notable fixed size objects. Using mtype_stats_alloc and
669 mtype_memstr recently added to memory.c.
670 (bgp_show_summary) Report some additional stats specific to
671 the given BGP instance and/or AFI/SAFI such as table counts,
672 peers, rsclients and peer-groups.
673 (bgp_vty_init) Install show_bgp_memory_cmd.
Paul Jakma5304cb52006-03-30 14:01:14 +0000674 * bgp_nexthop.h: Include if.h as a dependent header, for struct
675 connected.
Paul Jakmab51f1262006-03-30 14:09:38 +0000676 * bgp_advertise.c: Use a distinct memory type for struct
677 bgp_synchronize.
Paul Jakma5304cb52006-03-30 14:01:14 +0000678
Paul Jakmacbdfbaa2006-03-30 13:20:48 +00006792006-03-12 Paul Jakma <paul.jakma@sun.com>
680
681 * bgp_attr.h: (struct attr) rearrange fields to avoid
682 wasted padding between them as much as possible.
683 (attr_count,attr_unknown_count) export new functions to
684 return number of counts of cached attributes.
685 * bgp_attr.c: (attr_count,attr_unknown_count) new functions to
686 return number of counts of cached attributes.
687 * bgp_route.h: (struct bgp_info) rearrange fields to avoid
688 wasted padding.
689 * bgp_table.h: (struct bgp_table) Add a count field, of number
690 of nodes in the table.
691 (struct bgp_node) rearrange fields to avoid
692 wasted padding between them, though I don't think there
693 was any in this case.
694 * bgp_table.c: (bgp_node_{delete,get}) Maintain the table node count.
695 (bgp_table_count) new function to access the table count.
696
Paul Jakma3e0c78e2006-03-06 18:06:53 +00006972006-03-03 Paul Jakma <paul.jakma@sun.com>
698
699 * bgp_route.c: (bgp_clear_node_complete) Doh. When clearing
700 is complete we need to kick off FSM again.
701
Paul Jakma64e580a2006-02-21 01:09:01 +00007022006-02-21 Paul Jakma <paul.jakma@sun.com>
703
704 * bgpd.h: move the clear_node_queue to be peer specific.
705 Add a new peer status flag, PEER_STATUS_CLEARING.
706 * bgp_table.h: (struct bgp_table) Add fields to record afi,
707 safi of the table.
708 (bgp_table_init) Take afi and safi to create table for.
709 * bgp_table.c: (bgp_table_init) record the afi and safi.
710 * bgp_nexthop.c: Update all calls to bgp_table_init.
711 * bgp_vty.c: ditto.
712 * bgpd.c: ditto.
713 * bgp_fsm.c: (bgp_timer_set) dont bring up a session which is
714 clearing.
715 * bgp_route.c: (general) Update all bgp_table_init calls.
716 (bgp_process_{rsclient,main}) clear_node is serialised
717 via PEER_STATUS_CLEARING and fsm now.
718 (struct bgp_clear_node_queue) can be removed. struct bgp_node
719 can be the queue item data directly, as struct peer can be
720 kept in the new wq global user data and afi/safi can be
721 retrieved via bgp_node -> bgp_table.
722 (bgp_clear_route_node) fix to get peer via wq->spec.data,
723 afi/safi via bgp_node->bgp_table.
724 (bgp_clear_node_queue_del) no more item data to delete, only
725 unlock the bgp_node.
726 (bgp_clear_node_complete) only need to unset CLEARING flag
727 and unlock struct peer.
728 (bgp_clear_node_queue_init) queue attaches to struct peer
729 now. record peer name as queue name.
730 (bgp_clear_route_table) If queue transitions to active,
731 serialise clearing by setting PEER_STATUS_CLEARING rather
732 than plugging process queue, and lock peer while queue
733 active.
734 Update to pass only bgp_node as per-queue-item specific data.
Paul Jakma6a419732006-02-21 01:14:13 +0000735 * bgp_vty.c: (bgp_show_summary) Add a 'Clrng' sub-description
736 to state of peer while it's suppressed due to clearing.
Paul Jakma64e580a2006-02-21 01:09:01 +0000737
Paul Jakmaaa94ca82006-02-18 10:49:04 +00007382006-02-18 Paul Jakma <paul.jakma@sun.com>
739
740 * bgp_routemap.c: (route_set_community) Quick, very hacky, fix
741 for the set-community leak, bug #89. True fix will be to
742 detangle the web of *_intern caching and provide saner object
743 caching for Quagga, future work.
Paul Jakma7c7fa1b2006-02-18 10:52:09 +0000744 * bgp_route.c: (bgp_announce_check) trivial, move declaration
745 of two local variables into the only block where they are
746 used, to aid the reader.
Paul Jakmaaa94ca82006-02-18 10:49:04 +0000747
paul902212c2006-02-05 17:51:19 +00007482006-02-05 Paul Jakma <paul.jakma@sun.com>
749
750 * bgp_route.h: Add BGP_INFO_COUNTED to track whether
751 prefix has been counted or not.
752 * bgp_route.c: (bgp_pcount_{inc,dec}rement) new helpers, to
753 centralise inc/dec of prefix-count,
754 (bgp_rib_remove) Remove pcount decrement, use helper.
755 (bgp_rib_withdraw) ditto, additionally use previous function
756 too.
757 (bgp_update_main) Use pcount helpers.
758 (bgp_clear_route_node) ditto, aslo REMOVED routes don't need
759 clearing.
paul3fff6ff2006-02-05 17:55:35 +0000760 * bgp_aspath.c: (aspath_gettoken) fix gcc warning about
761 possible uninitialised usage.
paul902212c2006-02-05 17:51:19 +0000762
paul306d8892006-02-02 17:50:19 +00007632006-02-02 Paul Jakma <paul.jakma@sun.com>
764
765 * bgp_route.c: (bgp_{clear_node,process}_queue_init) delay
766 field is removed from workqueue spec.
767
paule8e19462006-01-19 20:16:55 +00007682006-01-19 Paul Jakma <paul.jakma@sun.com>
769
770 * (general) various miscellaneous compiler warning fixes.
771 Remove redundant break statements from switch clauses
772 which return.
773 return from main, not exit, cause it annoys SOS.
774 Remove stray semi-colons which cause empty-statement
775 warnings.
776
pauld3092e72006-01-17 17:33:46 +00007772006-01-17 Paul Jakma <paul.jakma@sun.com>
778
779 * bgp_nexthop.c: (zlookup_read*) convert to new Zserv format.
780 (zlookup_query_ipv6) ditto.
781 (bgp_import_check) ditto.
782
paul02335422006-01-16 11:13:27 +00007832006-01-16 Paul Jakma <paul.jakma@sun.com>
784
785 * bgp_aspath.c: (assegment_append_asns) XREALLOC can return
786 NULL theoretically, take care not to lose the allocated data.
787 (aspath_hash_alloc) aspath_dup already set the aspath
788 string - fix leak.
789 (aspath_parse) aspath_hash_alloc dupes the entire aspath,
790 including segments, but we forgot to free the temporary
791 assegment.
paul8fdc32a2006-01-16 12:01:29 +0000792 (aspath_snmp_pathseg) move the static stream pointer out to
793 file scope, so it can be freed.
794 (aspath_finish) new function, free aspath resources.
795 * bgp_aspath.h: (aspath_finish) export.
paul02335422006-01-16 11:13:27 +0000796
paul37c38302006-01-10 22:15:45 +00007972006-01-10 Juris Kalnins <juris@mt.lv>
798
799 * bgpd.h: (bgp_router_id_unset) ex-function, remove.
800
paulad727402005-11-23 02:47:02 +00008012005-11-23 Paul Jakma <paul.jakma@sun.com>
802
803 * bgp_aspath.c: (assegments_parse) should be static
804
8052005-11-23 Juergen Kammer <j.kammer@eurodata.de>
806
807 * bgp_aspath.c: (aspath_cmp_left_confed) fix SEGV for case
808 where one or both paths are empty.
809
paul0fb58d52005-11-14 14:31:49 +00008102005-11-14 Paul Jakma <paul.jakma@sun.com>
811
812 * bgp_route.c: (bgp_process_rsclient) convert to new workqueue
813 specs and shut up gcc, which complains about cast from void
814 via function parameters, for some dumb reason. Do the cast
815 inside the function instead.
816 (bgp_process_main,bgp_processq_del) ditto.
817 (bgp_clear_route_node) ditto.
818 (bgp_clear_node_queue_del) ditto.
819
paul41200852005-11-03 12:52:18 +00008202005-11-03 Paul Jakma <paul.jakma@sun.com>
821
822 * bgp_damp.c: (bgp_reuse_timer) struct bgp can be retrieved via
823 the struct bgp_damp_info, no need to guess by using
824 bgp_get_default().
825
ajsf52d13c2005-10-01 17:38:06 +00008262005-10-01 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
827
828 * bgp_vty.c: (bgp_config_write_redistribute) Use new library function
829 zebra_route_string instead of a local hard-coded table.
830
jardin2d74db52005-10-01 00:07:50 +00008312005-09-30 Vincent Jardin <vincent.jardin@6wind.com>
832
833 * bgp_packet.c: fix compilation when DEBUG is used.
834
paul1f8ae702005-09-09 23:49:49 +00008352005-09-10 Paul Jakma <paul.jakma@sun.com>
836
paulfe69a502005-09-10 16:55:02 +0000837 * Makefile.am: bgpd shouldn't list libgp's sources as its own.
838 Use LDADD.
839 * bgp_aspath.h:
840 (struct assegment) New struct, abstract representation of a
841 list of AS_PATH segments and the contained ASNs.
842 (struct aspath) Remove the raw-data related
843 fields, reference the abstract struct assegment instead.
844 Remove several other computed fields, it's just a
845 headache to maintain them and they're cheap to compute from
846 struct assegment.
847 (aspath_parse) parse a stream, not a pointer to raw data.
848 (aspath_count_{hops,confeds,size}) helpers to access
849 information formerly directly contained in struct aspath.
850 (aspath_snmp_pathseg) Helper for SNMP, BGP MIB wants
851 to be able to output hex representation of raw data.
852 * bgp_aspath.c: (general) partial-rewrite. Store aspath data
853 as an abstract singly-linked list of abstract segments,
854 rather than storing the raw data, and parsing it each and
855 every time. Remove several count/size fields which are cheap
856 to compute from the abstract segment structure.
857 (global) Include stream.h, needed for aspath_parse, and
858 others. Couple of helper macros added.
859 (struct assegment_header) Just the header, and only the
860 header.
861 (assegment_data_{new,free}) convenience functions for
862 AS_SEG_DATA allocation, the dynamic, per-segment array of
863 ASNs.
864 (assegment_{new,free,free_all,dup,dup_all}) convenience
865 functions for creating struct assegments. The _all forms will
866 follow the entire chain of segments from the given segment.
867 (assegment_prepend_asns) new function, prepend an ASN N times
868 to segment.
869 (assegment_append_asns) Append a list (array) of ASNs to
870 segment.
871 (int_cmp) convenience function for the aspath hash.
872 (assegment_normalise) new function. Normalise the given
873 segment chain to meet expectations of Quagga, and to
874 eliminate differing raw representations of the same paths.
875 Merge 'runs' of SEQUENCEs into one segment as our internal
876 segment is not limited by the protocol AS_PATH segment
877 length. Sort ASNs in SETs.
878 (aspath_new) Take void argument to quell warnings. Use the
879 assegment convenience functions.
880 (assegment_count_{asns,confeds,hops}) new functions to
881 compute at runtime values previously held in struct aspath.
882 (aspath_size) ditto.
883 (aspath_make_str_count) rewritten to stringify new
884 representation, and to be slightly easier to understand
885 hopefully.
886 (aspath_str_update) convenience function, update the aspath
887 str. Should investigate removing maintained string from
888 struct aspath, just run-time compute it, as per other fields.
889 It's just a maintenance headache, would save noticeable
890 amount of RAM with possibly not much extra run-time cost.
891 (aspath_dup) use the assegment dup functions.
892 (aspath_hash_alloc) Take void * argument to satisfy gcc. Use
893 the proper helper functions to dup data.
894 (assegments_parse) new function. parse raw AS_PATH data into
895 struct assegments. Normalise and return the head of the list.
896 (aspath_parse) Parse a stream, not pointer to raw data and
897 use assegments_parse to do it.
898 (assegment_data_put) Write out a single segment data in protocol
899 form to stream.
900 (assegment_header_put) ditto but for segment header.
901 (aspath_put) new function. As per previous but for an entire
902 struct aspath.
903 (aspath_snmp_pathseg) wrapper around aspath_put for
904 bgp_snmp.c. Uses a static buffer sadly.
905 (aspath_aggregate_as_set_add) rewritten to use assegments.
906 (aspath_aggregate) ditto
907 (aspath_{firstas,loop,private_as}_check) ditto
908 (aspath_{merge,prepend,add_one_as}) ditto
909 (aspath_cmp_left{_confed}) ditto
910 (aspath_delete_confed_seq) ditto, plus fixed to properly
911 delete all leading confed segments.
912 (aspath_as_add) Just use assegment_append_asns.
913 (aspath_segment_add) updated to use assegments.
914 (enum as_token) Add values for confeds
915 (aspath_gettoken) Add support for confeds
916 (aspath_str2aspath) ditto
917 (aspath_key_make) updated to use as_segments. Also, add
918 segment type into the hash value as appropriate.
919 (aspath_cmp) updated to use as_segments.
920 (aspath_print) don't segfault on NULL argument.
921 * bgp_attr.c: (bgp_attr_aspath) aspath_parse wants the stream
922 now. No need for manual forwarding of stream.
923 (bgp_packet_attribute) empty aspath is now denoted by NULL
924 segment field, length is gone.
925 Use aspath_size() to determine size.
926 (bgp_attr_init) Fix declaration, explicitely specify void
927 arg.
928 (bgp_dump_routes_attr) Use aspath_size() to determine size.
929 * bgp_route.c: (bgp_info_cmp) use the aspath_count_* functions.
930 (bgp_rib_withdraw) remove unused variable. Use
931 aspath_count_hops.
932 * bgp_snmp.c: (bgp4PathAttrTable) raw data is gone, use
933 aspath_snmp_pathseg to get the representation.
934
9352005-09-10 Paul Jakma <paul.jakma@sun.com>
936
paul1f8ae702005-09-09 23:49:49 +0000937 * bgp_vty.c: (bgp_vty_init) gcc 4 compile fix. static
938 function declarations shouldn't be inside functions.
939 * bgp_dump.c: (bgp_dump_interval_add) ditto.
940
hassob7395792005-08-26 12:58:38 +00009412005-08-26 Hasso Tepper <hasso at quagga.net>
942
943 * bgp_route.c: Third (?) attempt to fix best selection breakage
944 introduced long time ago with route server patch. Hopefully
945 it's last case to fix - route-server client not in peer group.
946
paul25ffbdc2005-08-22 22:42:08 +00009472005-08-22 Hugo Santos <hsantos@av.it.pt>
948
949 * bgp_vty.c: (general) Add support for BGP IPv6 Multicast SAFI
950 commands and BGP_IPV6M_NODE.
951
paulb40d9392005-08-22 22:34:41 +00009522005-08-22 Paul Jakma <paul.jakma@sun.com>
953
954 * bgp_route.h: (struct bgp_info) add a new flag, BGP_INFO_REMOVED.
955 BGP_INFO_VALID is already overloaded, don't care to do same thing
956 to STALE or HISTORY.
957 * bgpd.h: (BGP_INFO_HOLDDOWN) Add INFO_REMOVED to the macro, as a
958 route which should generally be ignored.
959 * bgp_route.c: (bgp_info_delete) Just set the REMOVE flag, rather
960 than doing actual work, so that bgp_process (called directly,
961 or indirectly via the scanner) can catch withdrawn routes.
962 (bgp_info_reap) Actually remove the route, what bgp_info_delete
963 used to do, only for use by bgp_process.
964 (bgp_best_selection) reap any REMOVED routes, other than the old
965 selected route.
966 (bgp_process_rsclient) reap the old-selected route, if appropriate
967 (bgp_process_main) ditto
968 (bgp_rib_withdraw, bgp_rib_remove) make them more consistent with
969 each other. Don't play games with the VALID flag, bgp_process
970 is async now, so it didn't make a difference anyway.
971 Remove the 'force' argument from bgp_rib_withdraw, withdraw+force
972 is equivalent to bgp_rib_remove. Update all its callers.
973 (bgp_update_rsclient) bgp_rib_withdraw and force set is same as
974 bgp_rib_remove.
975 (route_vty_short_status_out) new helper to print the leading
976 route-status string used in many command outputs. Consolidate.
977 (route_vty_out, route_vty_out_tag, damp_route_vty_out,
978 flap_route_vty_out) use route_vty_short_status_out rather than
979 duplicate.
980 (route_vty_out_detail) print state of REMOVED flag.
981 (BGP_SHOW_SCODE_HEADER) update for Removed flag.
982
hassoe279c7a2005-08-03 17:23:20 +00009832005-08-03 Hasso Tepper <hasso at quagga.net>
984
985 * bgp_routemap.c: Revert part of leaking communities fix commited in
986 2005-05-27. While ecommunity fix seems to be correct, community case
987 isn't.
988
paul94f2b392005-06-28 12:44:16 +00009892005-06-28 Paul Jakma <paul.jakma@sun.com>
990
991 * (global) The great bgpd extern and static'ification.
992 * bgp_routemap.c: remove unused ROUTE_MATCH_ASPATH_OLD code
993 (route_set_metric_compile) fix u_int32_t to ULONG_MAX comparison
994 warnings.
995 * bgp_route.h: (bgp_process, bgp_withdraw, bgp_update) export these
996 used by various files which had their own private declarations,
997 in the case of mplsvpn - incorrect.
998
paule210cf92005-06-15 19:15:35 +00009992005-06-15 Paul Jakma <paul.jakma@sun.com>
1000
1001 * bgpd.c: (bgp_terminate) workqueue's are lazy allocated and its
1002 possible to terminate bgpd before workqueues were setup, causing
1003 an abort/crash. Reported by Ashish Mehta of Sun.
1004
paul200df112005-06-01 11:17:05 +000010052005-06-01 Paul Jakma <paul.jakma@sun.com>
1006
1007 * (general) refcount struct peer and bgp_info, hence allowing us
1008 add work_queues for bgp_process.
1009 * bgp_route.h: (struct bgp_info) Add 'lock' field for refcount.
1010 Add bgp_info_{lock,unlock} helper functions.
1011 Add bgp_info_{add,delete} helpers, to remove need for
1012 users managing locking/freeing of bgp_info and bgp_node's.
1013 * bgp_table.h: (struct bgp_node) Add a flags field, and
1014 BGP_NODE_PROCESS_SCHEDULED to merge redundant processing of
1015 nodes.
1016 * bgp_fsm.h: Make the ON/OFF/ADD/REMOVE macros lock and unlock
1017 peer reference as appropriate.
1018 * bgp_damp.c: Remove its internal prototypes for
1019 bgp_info_delete/free. Just use bgp_info_delete.
1020 * bgpd.h: (struct bgp_master) Add work_queue pointers.
1021 (struct peer) Add reference count 'lock'
1022 (peer_lock,peer_unlock) New helpers to take/release reference
1023 on struct peer.
1024 * bgp_advertise.c: (general) Add peer and bgp_info refcounting
1025 and balance how references are taken and released.
1026 (bgp_advertise_free) release bgp_info reference, if appropriate
1027 (bgp_adj_out_free) unlock peer
1028 (bgp_advertise_clean) leave the adv references alone, or else
1029 call bgp_advertise_free cant unlock them.
1030 (bgp_adj_out_set) lock the peer on new adj's, leave the reference
1031 alone otherwise. lock the new bgp_info reference.
1032 (bgp_adj_in_set) lock the peer reference
1033 (bgp_adj_in_remove) and unlock it here
1034 (bgp_sync_delete) make hash_free on peer conditional, just in
1035 case.
1036 * bgp_fsm.c: (general) document that the timers depend on
1037 bgp_event to release a peer reference.
1038 (bgp_fsm_change_status) moved up the file, unchanged.
1039 (bgp_stop) Decrement peer lock as many times as cancel_event
1040 canceled - shouldnt be needed but just in case.
1041 stream_fifo_clean of obuf made conditional, just in case.
1042 (bgp_event) always unlock the peer, regardless of return value
1043 of bgp_fsm_change_status.
1044 * bgp_packet.c: (general) change several bgp_stop's to BGP_EVENT's.
1045 (bgp_read) Add a mysterious extra peer_unlock for ACCEPT_PEERs
1046 along with a comment on it.
1047 * bgp_route.c: (general) Add refcounting of bgp_info, cleanup
1048 some of the resource management around bgp_info. Refcount peer.
1049 Add workqueues for bgp_process and clear_table.
1050 (bgp_info_new) make static
1051 (bgp_info_free) Ditto, and unlock the peer reference.
1052 (bgp_info_lock,bgp_info_unlock) new exported functions
1053 (bgp_info_add) Add a bgp_info to a bgp_node in correct fashion,
1054 taking care of reference counts.
1055 (bgp_info_delete) do the opposite of bgp_info_add.
1056 (bgp_process_rsclient) Converted into a work_queue work function.
1057 (bgp_process_main) ditto.
1058 (bgp_processq_del) process work queue item deconstructor
1059 (bgp_process_queue_init) process work queue init
1060 (bgp_process) call init function if required, set up queue item
1061 and add to queue, rather than calling process functions directly.
1062 (bgp_rib_remove) let bgp_info_delete manage bgp_info refcounts
1063 (bgp_rib_withdraw) ditto
1064 (bgp_update_rsclient) let bgp_info_add manage refcounts
1065 (bgp_update_main) ditto
1066 (bgp_clear_route_node) clear_node_queue work function, does
1067 per-node aspects of what bgp_clear_route_table did previously
1068 (bgp_clear_node_queue_del) clear_node_queue item delete function
1069 (bgp_clear_node_complete) clear_node_queue completion function,
1070 it unplugs the process queues, which have to be blocked while
1071 clear_node_queue is being processed to prevent a race.
1072 (bgp_clear_node_queue_init) init function for clear_node_queue
1073 work queues
1074 (bgp_clear_route_table) Sets up items onto a workqueue now, rather
1075 than clearing each node directly. Plugs both process queues to
1076 avoid potential race.
1077 (bgp_static_withdraw_rsclient) let bgp_info_{add,delete} manage
1078 bgp_info refcounts.
1079 (bgp_static_update_rsclient) ditto
1080 (bgp_static_update_main) ditto
1081 (bgp_static_update_vpnv4) ditto, remove unneeded cast.
1082 (bgp_static_withdraw) see bgp_static_withdraw_rsclient
1083 (bgp_static_withdraw_vpnv4) ditto
1084 (bgp_aggregate_{route,add,delete}) ditto
1085 (bgp_redistribute_{add,delete,withdraw}) ditto
1086 * bgp_vty.c: (peer_rsclient_set_vty) lock rsclient list peer
1087 reference
1088 (peer_rsclient_unset_vty) ditto, but unlock same reference
1089 * bgpd.c: (peer_free) handle frees of info to be kept for lifetime
1090 of struct peer.
1091 (peer_lock,peer_unlock) peer refcount helpers
1092 (peer_new) add initial refcounts
1093 (peer_create,peer_create_accept) lock peer as appropriate
1094 (peer_delete) unlock as appropriate, move out some free's to
1095 peer_free.
1096 (peer_group_bind,peer_group_unbind) peer refcounting as
1097 appropriate.
1098 (bgp_create) check CALLOC return value.
1099 (bgp_terminate) free workqueues too.
1100
hasso033e8612005-05-28 04:50:54 +000011012005-05-28 Hasso Tepper <hasso at quagga.net>
1102
1103 * bgp_routemap.c: Sync set_metric_addsub_cmd with ripd.
1104
hasso54a6ed32005-05-26 22:12:33 +000011052005-05-27 Hasso Tepper <hasso at quagga.net>
1106
hasso70601e02005-05-27 03:26:57 +00001107 * bgp_routemap.c: Stop leaking communities.
1108
11092005-05-27 Hasso Tepper <hasso at quagga.net>
1110
hasso54a6ed32005-05-26 22:12:33 +00001111 * bgpd.c: Deleting bgp->rsclient list needs fix similar to pree-groups
1112 deleting fix. Avoid leaking bgp->group, bgp->peer and bgp->rsclient
1113 lists.
1114
11152005-05-26 Hasso Tepper <hasso at quagga.net>
hassob6b7cff2005-05-26 08:29:07 +00001116
1117 * bgpd.c: Don't crash while deleting list of peer-groups.
1118
hassob5f29602005-05-25 21:00:28 +000011192005-05-25 Hasso Tepper <hasso at quagga.net>
1120
1121 * bgpd.c: Fix obvious (routeserver patch) merge error. This makes "no
1122 neighbor x.x.x.x routemap [export|import] commands work again.
1123
paula94feb32005-05-23 13:17:29 +000011242005-05-23 Paul Jakma <paul@dishone.st>
1125
1126 * bgp_routemap.c: add semi-colons to VTY_GET_* to match vty.h change
paul00d252c2005-05-23 14:19:54 +00001127 * bgp_fsm.h: Add extern qualifier to exported functions
1128 * bgp_nexthop.c: add static to nexthop specific globals
1129 * *.h: Add guard defines
paula94feb32005-05-23 13:17:29 +00001130
paul22db9de2005-05-19 01:50:11 +000011312005-05-19 Paul Jakma <paul@dishone.st>
1132
1133 * bgp_fsm.c: (bgp_stop) use sockunion_free, not XFREE..
1134 * bgp_network.c: (bgp_getsockname) ditto
paule83e2082005-05-19 02:12:25 +00001135 (bgp_accept) use XSTRDUP
paul22db9de2005-05-19 01:50:11 +00001136 * bgp_routemap.c: (route_match_peer) ditto, als use a ret value and
1137 remove one sockunion_free.
paule83e2082005-05-19 02:12:25 +00001138 * bgpd.c: (peer_delete) ditto.
1139 XFREE the correct memtype, not free.
1140 (peer_create) use XSTRDUP
1141 * bgp_packet.c: (bgp_stream_dup) deleted, stream_dup should be used
1142 (various) update -> s/bgp_stream_dup/stream_dup
1143
paul22db9de2005-05-19 01:50:11 +00001144
ajs634f9ea2005-04-11 15:51:40 +000011452005-04-11 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1146
1147 * bgp_zebra.c (bgp_redistribute_set, bgp_redistribute_unset):
1148 The 2nd arg to zebra_redistribute_send is now zclient instead of
1149 zclient->sock.
1150
hassoa8a80d52005-04-09 13:07:47 +000011512005-04-09 Akihiro Mizutani <mizutani@net-chef.net>
1152
1153 * bgp_vty.c: Make "exit-address-family" work in IPv4 unicast address
1154 family node.
1155
hasso68118452005-04-08 15:40:36 +000011562005-04-08 Martin Ling <martin-quagga@earth.li>
1157
1158 * bgp_aspath.[ch], bgp_route.c, bgp_vty.c, bgpd.[ch]: Allow to enable
1159 the length of confederation path segments to be included during the
1160 as-path length check in the best path decision.
1161
ajsd2fc8892005-04-02 18:38:43 +000011622005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1163
1164 * bgp_zebra.c: (bgp_interface_delete) After deleting, set ifp->ifindex
1165 to IFINDEX_INTERNAL.
1166
hasso6cf159b2005-03-21 10:28:14 +000011672005-03-21 Hasso Tepper <hasso at quagga.net>
1168
1169 * bgp_route.c: Don't crash while clearing route tables if there is
1170 no particular afi/safi configured.
1171
hasso338b3422005-02-23 14:27:24 +000011722005-02-23 Hasso Tepper <hasso at quagga.net>
1173
1174 * bgp_route.c: Make reannouncing prefixes with changed attributes
1175 work again.
1176
hasso6ffd2072005-02-02 14:50:11 +000011772005-02-02 Akihiro Mizutani <mizutani@net-chef.net>
1178
hassodd4c5932005-02-02 17:15:34 +00001179 * bgp_vty.c: Deprecate "neighbor transparent-as" and "neighbor
1180 transparent-nexthop" commands.
1181
11822005-02-02 Akihiro Mizutani <mizutani@net-chef.net>
1183
hassoc1643bb2005-02-02 16:43:17 +00001184 * bgp_routemap.c: New route-map command - "match ip route-source".
1185
11862005-02-02 Akihiro Mizutani <mizutani@net-chef.net>
1187
hassofee6e4e2005-02-02 16:29:31 +00001188 * bgp_clist.[ch], bgp_route.c, bgp_routemap.c, bgp_vty.c:
1189 community-list cleanup.
1190
11912005-02-02 Akihiro Mizutani <mizutani@net-chef.net>
1192
hasso6ffd2072005-02-02 14:50:11 +00001193 * bgp_route.c, bgp_vty.c, bgp_zebra.c, bgpd.[ch]: "enforce-multihop"
1194 -> "disable-connected-check".
1195
11962005-02-02 Akihiro Mizutani <mizutani@net-chef.net>
hasso93406d82005-02-02 14:40:33 +00001197
1198 * bgp_fsm.c, bgp_open.c, bgp_packet.c, bgp_route.[ch], bgp_vty.c,
1199 bgpd.[ch]: Add BGP_INFO_STALE flag and end-of-rib support. "bgp
1200 graceful-restart" commands added. Show numbers of individual
1201 messages in "show ip bgp neighbor" command. Final pieces of graceful
1202 restart.
1203
hassof4184462005-02-01 20:13:16 +000012042005-02-01 Akihiro Mizutani <mizutani@net-chef.net>
1205
hassoc9502432005-02-01 22:01:48 +00001206 * bgp_open.c, bgp_packet.c, bgp_vty.c, bgpd.[ch]: Remove "no neighbor
1207 capability route-refresh" commands. Route refresh capability is sent
1208 anyway now. Preserve dummy deprecated commands.
1209
12102005-02-01 Akihiro Mizutani <mizutani@net-chef.net>
1211
hasso3d515fd2005-02-01 21:30:04 +00001212 * bgp_attr.c, bgp_snmp.c, bgp_vty.c, bgpd.[ch]: Remove support for old
1213 draft - ie. "neighbor version 4-" commands. Preserve dummy "neighbor
1214 version" command as deprecated.
1215
12162005-02-01 Akihiro Mizutani <mizutani@net-chef.net>
1217
hasso0a486e52005-02-01 20:57:17 +00001218 * bgpd.[ch], bgp_vty.c, bgp_route.c: "Restart session after
1219 maximum-prefix limit" feature support.
1220
12212005-02-01 Akihiro Mizutani <mizutani@net-chef.net>
1222
hassof4184462005-02-01 20:13:16 +00001223 * bgp_nexthop.c: Improve debug.
1224 * bgpd.[ch], bgp_nexthop.c, bgp_snmp.c: Remove useless bgp_get_master()
1225 function.
1226 * bgp_packet.c: MP AFI_IP update and withdraw parsing.
1227 * bgp_fsm.c: Reset peer synctime in bgp_stop(). bgp_fsm_change_status()
1228 is better place to log about peer status change than bgp_event().
1229 Log in bgp_connect_success().
1230 * bgp_vty.c: Fix typo in comment.
1231 * bgp_attr.c: Better log about unknown attribute.
1232
ajs3b8b1852005-01-29 18:19:13 +000012332005-01-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1234
1235 * bgp_filter.c: (ip_as_path,no_ip_as_path) Use argv_concat instead
1236 of buffer_getstr.
1237 * bgp_route.c: (bgp_show_regexp) Fix memory leak: need to free string
1238 returned by buffer_getstr.
1239 (bgp_show_community) Must use XFREE instead of free on string
1240 returned by buffer_getstr.
1241 * bgp_routemap.c: (set_community) Must use XFREE instead of free
1242 on string returned by buffer_getstr.
1243 * bgp_vty.c: (neighbor_description) Use argv_concat instead of
1244 buffer_getstr.
1245
hasso6d694292005-01-24 09:29:42 +000012462005-01-24 Hasso Tepper <hasso at quagga.net>
1247
1248 * bgp_route.c: Fix showstopper bug. New route must be selected also
1249 if old one is flaged as BGP_INFO_ATTR_CHANGED.
1250
hassof1271652005-01-17 11:04:32 +000012512005-01-17 Hasso Tepper <hasso at quagga.net>
1252
1253 * bgp_route.c: Clear peer's routing table regardless whether it's
1254 configured or not. Being not configured is even better reason to
1255 do it.
1256
paula24a7e12005-01-05 08:14:13 +000012572005-01-05 Paul Jakma <paul@dishone.st>
1258
1259 * bgp_packet.c: (bgp_write) set socket to nonblock while writing
1260 this should be generalised. See bugzilla #102. Fix supplied by
1261 wawa@yandex-team.ru (Vladimir Ivanov).
1262
ajsd2c1f162004-12-08 21:10:20 +000012632004-12-08 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1264
1265 * *.c: Change level of debug messages to LOG_DEBUG.
1266
ajs274a4a42004-12-07 15:39:31 +000012672004-12-07 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1268
1269 * bgp_main.c: (main) The 2nd argument to openzlog has been removed.
1270
ajs887c44a2004-12-03 16:36:46 +000012712004-12-03 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1272
1273 * bgp_main.c: (sigint) Use zlog_notice for termination message.
1274 (main) Use zlog_notice for startup announcement.
1275
hassoc0652302004-11-25 19:33:48 +000012762004-11-25 Hasso Tepper <hasso at quagga.net>
1277
1278 * bgp_main.c: Make group to run as configurable.
1279
paul59320202004-11-09 01:54:03 +000012802004-11-09 Paul Jakma <paul@dishone.st>
1281
1282 * bgp_nexthop.c: collapse bgp_connected_ipvX, bgp_nexthop_cache_ipvX
1283 and cache{1,2}.. into arrays of tables and hence collapse
1284 bgp_scan_ipv{4,6} into a single bgp_scan function. Tested, though
1285 a long time ago (and this change was hand-merged).
1286
ajs5a646652004-11-05 01:25:55 +000012872004-11-04 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1288
1289 * bgp_route.c: Remove all code related to VTY_CONTINUE; this feature
1290 is deprecated because the output did not represent a single point
1291 in time. All output needs to be generated inline and buffered
1292 by the library code.
1293 (route_vty_out,route_vty_out_tag,damp_route_vty_out,
1294 flap_route_vty_out) Remove code to count number of lines of output,
1295 since this was only useful for VTY_CONTINUE behavior.
1296 (bgp_show_callback,vty_calc_line) Removed.
1297 (bgp_show_table) Remove hooks for VTY_CONTINUE callback support.
1298 As a result, there's a new output_arg argument to this function.
1299 Make function static.
1300 (bgp_show) Make function static and add a new output_arg argument.
1301 Change all functions that call bgp_show or bgp_show_table to
1302 pass the new output_arg argument (that used to be passed inside
1303 vty->output_arg).
1304 * bgp_mplsvpn.c: Remove declarations of functions defined in
1305 bgp_route.c; these declarations belong in bgp_route.h.
1306 * bgp_route.h: Declare 3 global functions used in both bgp_route.c
1307 and in bgp_mplsvpn.c.
1308
paula2b1ecd2004-10-31 18:58:09 +000013092004-10-31 Paul Jakma <paul@dishone.st>
1310
1311 * {bgpd,bgp_attr}.c: size_t printf format should be ld.
1312
paul98f51632004-10-25 14:19:15 +000013132004-10-25 Paul Jakma <paul@dishone.st>
1314
1315 * Update with fix in debian bug id 222930.
1316 * bgp_main.c: Add ZCAP_RAW, needed to bind to interfaces.
1317 bgp_network.c: (....) raise/lower privs around call to
1318 SO_BINDTODEVICE sockopt.
1319
hasso3fb9cd62004-10-19 19:44:43 +000013202004-10-19 Andrew J. Schorr <aschorr@telemetry-investments.com>
1321
1322 * bgp_nexthop.c: (bgp_connected_add) Connected destination pointer
1323 may be NULL.
1324 (bgp_connected_delete) ditto.
1325
hasso501ba492004-10-13 21:32:46 +000013262004-10-14 Hasso Tepper <hasso at quagga.net>
1327
1328 * bgp_dump.c: Make dump configuration appear in vtysh.
1329
hassoc75105a2004-10-13 10:33:26 +000013302004-10-13 Hasso Tepper <hasso at quagga.net>
1331
1332 * bgp_snmp.c: Remove defaults used to initialize smux connection to
1333 snmpd. Connection is initialized only if smux peer is configured.
hasso8b3126b2004-10-13 20:59:04 +00001334 * bgp_view.c: It's dead file. Reomved.
hassoc75105a2004-10-13 10:33:26 +00001335
paulfd79ac92004-10-13 05:06:08 +000013362004-10-13 Paul Jakma <paul@dishone.st>
1337
1338 * (global) more const'ification and fixups of types to clean up code.
1339 * bgp_mplsvpn.{c,h}: (str2tag) fix abuse. Still not perfect,
1340 should use something like the VTY_GET_INTEGER macro, but without
1341 the vty_out bits..
1342 * bgp_routemap.c: (set_aggregator_as) use VTY_GET_INTEGER_RANGE
1343 (no_set_aggregator_as) ditto.
1344 * bgpd.c: (peer_uptime) fix unlikely bug, where no buffer is
1345 returned, add comments about troublesome return value.
1346
hasso18a6dce2004-10-03 18:18:34 +000013472004-10-03 James R. Leu <jleu at mindspring.com>
1348
1349 * bgp_vty.c: Router id from zebra can be manually overriden.
1350 * bgp_zebra.c: Read router id related messages from zebra daemon.
1351 Remove own code related with router id selection.
1352 * bgpd.c, bgpd.h: Remove own router id selection code. Use the one
1353 from zebra daemon if it isn't manually overriden.
1354
hassoc9e52be2004-09-26 16:09:34 +000013552004-09-26 Hasso Tepper <hasso at quagga.net>
1356
1357 * bgp_aspath.c, bgp_packet.c, bgp_vty.c: Fix compiler warnings.
1358
hasso52dc7ee2004-09-23 19:18:23 +000013592004-09-23 Hasso Tepper <hasso at quagga.net>
1360
1361 * *.[c|h]: list -> struct list *, listnode -> struct listnode *.
1362
paule01f9cb2004-07-09 17:48:53 +000013632004-07-09 Paul Jakma <paul@dishone.st>
1364
1365 * Merge of GNU Zebra cvs2svn changesets r799, r800 and r807.
1366 * bgp_dump.c: (bgp_dump_attr) cleanup. return status code. check
1367 attributes present before printing.
1368 * bgp_dump.c: update bgp_dump_attr prototype.
1369 * bgp_packet.c: (bgp_update_receive) init attrstr. check status
1370 of bgp_dump_attr. Log end-of-rib UPDATEs.
1371
paulf5ba3872004-07-09 12:11:31 +000013722004-07-09 Sowmini Varadhan <sowmini.varadhan@sun.com>
1373
1374 * bgp_packet.c: (bgp_collision_detect) Send NOTIFY on new socket
1375 if that is connection we're closing.
1376 (bgp_read) invalid marker check applies to KEEPALIVE too.
1377 * bgp_route.c: Ignore multicast NRLI, dont send NOTIFY.
1378
paul5228ad22004-06-04 17:58:18 +000013792004-06-04 Paul Jakma <paul@dishone.st>
1380
1381 * type mismatch fixes
1382
hasso538621f2004-05-21 09:31:30 +000013832004-05-21 Akihiro Mizutani <mizutani@net-chef.net>
1384
1385 * bgpd.h, bgp_open.[ch], bgp_debug.c, bgp_vty.[ch], bgp_fsm.c:
1386 Graceful restart capability display.
1387
hasso3950fda2004-05-20 10:22:49 +000013882005-05-20 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1389
1390 * bgp_debug.c: Cosmetical fixes and log neighbor changes.
1391
hasso4372df72004-05-20 10:20:02 +000013922004-05-20 Akihiro Mizutani <mizutani@net-chef.net>
1393
1394 * bgp_ecommunity.c: Transit ecommunity support.
1395 * bgp_ecommunity.c: Fix for unknown community crush.
1396
hassoe0701b72004-05-20 09:19:34 +000013972005-05-20 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1398
1399 * *: Maximum prefix threshold support.
1400 * *: Reset notification fixups.
1401
paul0a589352004-05-08 11:48:26 +000014022004-05-08 Paul Jakma <paul@dishone.st>
1403
1404 * bgp_zebra.c: (bgp_interface_address_add) sync to zclient changes
1405 (bgp_interface_address_delete) ditto.
1406 (bgp_zebra_announce) ditto.
1407 (bgp_zebra_withdraw) ditto.
1408
paulc5317402004-05-03 13:25:06 +000014092004-05-03 Daniel Roesen <dr@cluenet.de>
1410
1411 * bgp_fsm.c: (bgp_stop) Reset uptime only on transition from
1412 Established so that it reflects true downtime (rather time
1413 since last transition, eg Active->Idle)
1414
paul35be31b2004-05-01 18:17:04 +000014152004-05-01 rivo nurges <rix@estpak.ee>
1416
1417 * bgp_route.c: fix UNH IOL BGP-4.1.12f
1418
pauleb821182004-05-01 08:44:08 +000014192004-05-01 Paul Jakma <paul@dishone.st>
1420
1421 * Revert the attempted clean-up of the dummy peer hack, reverts
1422 patchsets 435 (see 2004-02-17 below) and 456.
1423
paul545acaf2004-04-20 15:13:15 +000014242004-04-16 rivo nurges <rix@estpak.ee>
1425
hasso9b87e412004-04-20 16:54:49 +00001426 * bgpd.h, bgp_debug.c: update cease subcodes to
1427 draft-ietf-idr-cease-subcode-05
paul545acaf2004-04-20 15:13:15 +00001428 * bgpd.h, bgpd.c, bgp_route.c, bgp_route.h: fix UNH IOL BGP-4.1.6a
1429
paul6ad23f02004-02-17 19:45:10 +000014302004-02-17 Paul Jakma <paul@dishone.st>
1431
1432 * bgpd.h: (bgp_peer) add fd_local and fd_accept
1433 file descriptor's, fd becomes a pointer to one of these.
1434 * bgpd.c: (global) adjust for fact that fd is now a pointer.
1435 (peer_create_accept) removed.
1436 * bgp_route.c: (global) adjust for change of peer fd to pointer
1437 * bgp_packet.c: (bgp_collision_detect) adjust and remove the
1438 "replace with other peer" hack.
1439 * bgp_network.c: (bgp_accept) Remove the dummy peer hack.
1440 Update peer->fd_accept instead.
1441 (global) Adjust fd references - now a pointer.
1442 * bgp_fsm.c: (global) adjust peer fd to pointer.
1443 (bgp_connection_stop) new function, to stop connection.
1444 (global) adjust everything which closed peer fd to use
1445 bgp_connection_stop().
1446
gdt10d60ad2003-12-23 17:34:39 +000014472003-12-23 Krzysztof Oledzki <oleq@ans.pl>
1448
1449 * bgp_network.c: drop privs on error cases
1450
paul6ad23f02004-02-17 19:45:10 +000014512003-08-11 kunihiro <kunihiro@zebra.org>
paulac41b2a2003-08-12 05:32:27 +00001452
1453 * bgp_route{,map}.c: Extend 'set ip next-hop' in route-maps with
1454 ability to specify 'peer-address' rather than IP.
1455
paul9238b1e2003-06-11 08:03:08 +000014562003-06-09 Paul Jakma <paul@dishone.st>
1457
1458 * bgp_clist.c (community_list_delete): honour deny statements
1459
paul445f1432003-05-16 19:00:31 +000014602003-04-19 Hasso Tepper <hasso@estpak.ee>
1461
1462 * rip_routemap.c: sync daemon's route-map commands to have same
1463 syntax
1464
14652003-01-09 Akihiro Mizutani <mizutani@net-chef.net>
1466
1467 * bgp_routemap.c: Add match extcommunity command.
1468
paul718e3742002-12-13 20:15:29 +000014692002-10-23 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1470
1471 * bgp_aspath.c (aspath_init): Extend hash size from default to
1472 32767.
1473 (aspath_key_make): Use unsigned shoft for making hash. Suggested
1474 by: Marc Evans <Marc@SoftwareHackery.Com>
1475
14762002-08-19 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1477
1478 * bgp_clist.c (community_entry_free): Fix memory leak of standard
1479 extcommunity-list config string.
1480
14812002-08-19 Akihiro Mizutani <mizutani@net-chef.net>
1482
1483 * bgp_route.c (route_vty_out_detail): Fix bug of router-id display
1484 when multiple instance is used.
1485
14862002-08-18 Akihiro Mizutani <mizutani@net-chef.net>
1487
1488 * bgpd.c: Make "default-originate" and "maximum-prefix" commands
1489 available in peer-group configuration.
1490
14912002-08-13 Akihiro Mizutani <mizutani@net-chef.net>
1492
1493 * bgp_packet.c (bgp_open_send): Put Opt Parm Len 0 when last
1494 capability packet cause error or dont-capability-negotiate option
1495 is specified.
1496
14972002-07-07 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1498
1499 * zebra-0.93 released.
1500
15012001-10-28 Kunihiro Ishiguro <kunihiro@zebra.org>
1502
1503 * bgpd.c (bgp_vty_init): Translate update commands are removed.
1504
15052001-10-10 Kunihiro Ishiguro <kunihiro@zebra.org>
1506
1507 * bgp_route.c (bgp_static_set): Add workaround for BGP static
1508 route announcement when there is no zebra running.
1509
15102001-10-08 Kunihiro Ishiguro <kunihiro@zebra.org>
1511
1512 * bgpd.c (neighbor_remote_as_unicast): Remove "remote-as nlri
1513 unicast multicast" commands.
1514
15152001-09-14 Akihiro Mizutani <mizutani@dml.com>
1516
1517 * bgp_open.c: When we receive capability route-refresh, we should
1518 check we send the capability not we receive the capability.
1519
1520 * bgp_route.c (bgp_network_mask_natural_route_map): network
1521 statement route-map is added.
1522
15232001-08-31 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1524
1525 * bgp_advertise.c (bgp_advertise_intern): attr must be interned
1526 before looking up hash table.
1527
15282001-08-30 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1529
1530 * bgpd.h (struct peer): BGP filter is moved from peer_conf to
1531 peer.
1532
15332001-08-28 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1534
1535 * bgp_nexthop.c (bnc_nexthop_free): Fix next pointer bug.
1536 Suggested by: "Hong-Sung Kim" <hoskim@lanbird.co.kr>.
1537
15382001-08-26 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1539
1540 * bgp_table.c (bgp_node_create): Clearn memory before use it.
1541
15422001-08-24 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1543
1544 * Change to use bgp_table.[ch].
1545
15462001-08-23 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1547
1548 * bgpd.c (bgp_init): Add "transparent-as" and
1549 "transparent-nexthop" for old version compatibility.
1550
15512001-08-23 Akihiro Mizutani <mizutani@dml.com>
1552
1553 * bgpd.h (struct peer): default-originate route-map is added.
1554
1555 * bgp_route.c: When self originated route is advertised with
1556 attrubute-unchanged, nexthop was not properly set. This bug is
1557 fixed.
1558
15592001-08-22 Akihiro Mizutani <mizutani@dml.com>
1560
1561 * bgpd.c (neighbor_attr_unchanged): transparent-as and
1562 transparent-next-hop commands are restructured. Instead of
1563 current transparent-* commands, attribute-unchanged command is
1564 introduced.
1565
1566 neighbor A.B.C.D attribute-unchanged [as-path|next-hop|med]
1567
1568 (neighbor_default_originate): "default-originate" configuration
1569 announce default route even 0.0.0.0/0 does not exists in BGP RIB.
1570
15712001-08-19 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1572
1573 * zebra-0.92a released.
1574
15752001-08-19 Akihiro Mizutani <mizutani@dml.com>
1576
1577 * bgpd.c: AF specific soft-reconfiguration inbound commands are
1578 added.
1579
15802001-08-17 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1581
1582 * bgp_route.c (bgp_show_callback): Do not do community NULL check.
1583
1584 * bgp_community.c (community_cmp): Add check for commnunity NULL
1585 check.
1586
1587 * bgp_routemap.c (route_match_community): Do not check comunity is
1588 NULL. It may match to community-list "^$".
1589
1590 * bgp_community.c (community_match): Add check for community is
1591 NULL case.
1592
15932001-08-17 Akihiro Mizutani <mizutani@dml.com>
1594
1595 * bgpd.c: AF specific route-reflector-client and
1596 route-server-client configuration are added.
1597
15982001-08-17 Rick Payne <rickp@ayrnetworks.com>
1599
1600 * bgp_clist.c (community_match_regexp): Check special ^$ case.
1601
16022001-08-17 Akihiro Mizutani <mizutani@dml.com>
1603
1604 * bgp_clist.c (community_list_match): Fix bug of community list
1605 permit and deny check.
1606
16072001-08-16 Akihiro Mizutani <mizutani@dml.com>
1608
1609 * bgp_mplsvpn.c (bgp_mplsvpn_init): Add AF specific "nexthop-self"
1610 command.
1611
16122001-08-15 Akihiro Mizutani <mizutani@dml.com>
1613
1614 * bgpd.h (PEER_FLAG_SEND_COMMUNITY): Per AF based configuration
1615 flag is introduced.
1616
1617 * bgp_mplsvpn.c (bgp_mplsvpn_init): VPNv4 filtering is added.
1618
16192001-08-15 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1620
1621 * zebra-0.92 released.
1622
16232001-08-13 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1624
1625 * bgpd.c (bgp_delete): "no router bgp" free static, aggregate, rib
1626 table properly.
1627
16282001-08-12 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1629
1630 * bgp_route.c (bgp_node_safi): Return SAFI of current node.
1631 (bgp_config_write_network_vpnv4): VPNv4 static configuration
1632 display.
1633
16342001-08-11 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1635
1636 * bgpd.c (no_bgp_ipv4_multicast_route_map): Add IPv4 multicast
1637 node filter commands.
1638
16392001-08-11 Kunihiro Ishiguro <kunihiro@zebra.org>
1640
1641 * bgpd.h (PEER_FLAG_IGNORE_LINK_LOCAL_NEXTHOP): Add
1642 "ignore-link-local-nexthop" flag for ignore link-local nexthop for
1643 IPv6.
1644
16452001-08-07 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1646
1647 * bgpd.c (address_family_ipv4_multicast): "address-family ipv4
1648 multicast" is added.
1649 (address_family_ipv6_unicast): "address-family ipv6 unicast" is
1650 added.
1651
16522001-08-07 Akihiro Mizutani <mizutani@dml.com>
1653
1654 * bgp_route.c (bgp_process): Use flag instead of as_selected
1655 memeber in struct bgp_info.
1656
1657 * bgp_route.h (struct bgp_info): Remove as_selected memeber from
1658 struct bgp_info.
1659
16602001-07-31 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1661
1662 * bgp_route.c (bgp_announce_check): Enclose sending time AS loop
1663 check code with #ifdef BGP_SEND_ASPATH_CHECK.
1664
16652001-07-29 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1666
1667 * bgp_packet.c (bgp_withdraw_send): Simplify address family check.
1668
1669 * bgpd.h (BGP_INFO_HOLDDOWN): Introduce new macro to check BGP
1670 information is alive or not.
1671
1672 * bgp_community.c: Use community_val_get() on all OS.
1673
16742001-07-24 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1675
1676 * bgp_route.c (bgp_announce_check): Simplify set next-hop self
1677 check.
1678
16792001-07-24 Akihiro Mizutani <mizutani@dml.com>
1680
1681 * bgp_route.c (bgp_announce_check): To route server clients, we
1682 announce AS path, MED and nexthop transparently.
1683
16842001-06-21 Kunihiro Ishiguro <kunihiro@zebra.org>
1685
1686 * bgp_routemap.c (route_set_atomic_aggregate_free): Do not call
1687 XFREE. No memory is allocated in
1688 route_set_atomic_aggregate_compile().
1689
16902001-06-21 Kunihiro Ishiguro <kunihiro@zebra.org>
1691
1692 * bgp_routemap.c (bgp_route_map_init): `match nlri` and `set nlri`
1693 are replaced by `address-family ipv4` and `address-family vpnvr'.
1694
16952001-06-19 Kunihiro Ishiguro <kunihiro@zebra.org>
1696
1697 * bgp_route.c (bgp_withdraw): Add check for BGP_PEER_CONFED.
1698 Reported by Rick Payne <rickp@rossfell.co.uk>.
1699
17002001-06-17 Kunihiro Ishiguro <kunihiro@zebra.org>
1701
1702 * bgp_zebra.c (bgp_zebra_announce): When global IPv6 nexthop is
1703 empty, use socket's remote address for the nexthop.
1704
17052001-06-04 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1706
1707 * bgpd.c (peer_delete): Fix memory leak. Reported by Yosi Yarchi
1708 <Yosi_Yarchi@KereniX.com>
1709
17102001-06-01 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1711
1712 * bgpd.c (bgp_delete): Fix memory leak. Reported by Yosi Yarchi
1713 <Yosi_Yarchi@KereniX.com>
1714
17152001-05-27 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1716
1717 * bgp_route.c (bgp_route_clear_with_afi_vpnv4): Use next instead
1718 of ri->next.
1719
1720 * bgp_packet.c (bgp_withdraw_send): MPLS/VPN withdraw takes effect
1721 when HAVE_IPV6 is not defined.
1722
17232001-03-07 "Akihiro Mizutani" <mizutani@dml.com>
1724
1725 * bgpd.c (peer_timers_set): Adjust keepalive timer to fit less
1726 than holdtime / 3.
1727 (bgp_confederation_peers_unset): Only set peer->local_as when
1728 confederation is enabled.
1729 (bgp_timers): Add "timers bgp <0-65535> <0-65535>" command.
1730
1731 * bgp_route.c (bgp_announce_check): Set med of redistributed route
1732 when it is announced to EBGP peer.
1733
17342001-03-06 "Akihiro Mizutani" <mizutani@dml.com>
1735
1736 * bgp_nexthop.c (bgp_scan_ipv4): bgp_scan() call bgp_process() for
1737 all prefixes.
1738
17392001-03-06 Kunihiro Ishiguro <kunihiro@zebra.org>
1740
1741 * bgp_attr.c (bgp_attr_origin): When bgpd send NOTIFICATION with
1742 erroneous attribute (type, length and value), it does include
1743 attribute flags field.
1744
17452001-02-21 "Akihiro Mizutani" <mizutani@dml.com>
1746
1747 * bgp_route.c (bgp_announce_check): The route reflector is not
1748 allowed to modify the attributes of the reflected IBGP routes.
1749
17502001-02-20 "Akihiro Mizutani" <mizutani@dml.com>
1751
1752 * bgp_route.c (bgp_info_cmp): During path seleciton, BGP
1753 confederation peer is treated as same as IBGP peer.
1754
17552001-02-19 Kunihiro Ishiguro <kunihiro@zebra.org>
1756
1757 * bgp_route.c (bgp_redistribute_add): Initialize attr_new with
1758 attr. Call aspath_unintern when return from this function.
1759
17602001-02-19 "Akihiro Mizutani" <mizutani@dml.com>
1761
1762 * bgpd.c (bgp_router_id_set): Reset BGP peer when router-id is
1763 changed.
1764
17652001-02-18 "Akihiro Mizutani" <mizutani@dml.com>
1766
1767 * bgp_packet.c (bgp_open_receive): When user configure holdtimer,
1768 do not refrect the value to current session.
1769
17702001-02-16 Kunihiro Ishiguro <kunihiro@zebra.org>
1771
1772 * bgp_route.c (bgp_aggregate_delete): Set BGP_INFO_ATTR_CHANGE to
1773 suppress route withdraw.
1774
1775 * bgp_damp.c (bgp_damp_init): Fix bug of flap dampening.
1776
17772001-02-16 "Akihiro Mizutani" <mizutani@dml.com>
1778
1779 * bgp_aspath.c (aspath_make_str_count): Use ',' for separator for
1780 AS_SET and AS_CONFED_SET.
1781
17822001-02-15 Kunihiro Ishiguro <kunihiro@zebra.org>
1783
1784 * bgp_route.c (bgp_process): Do not consider suppress route.
1785
1786 * bgp_aspath.c (aspath_aggregate_as_set_add): Reset asset when
1787 aspath->data is realloced.
1788
17892001-02-15 "Akihiro Mizutani" <mizutani@dml.com>
1790
1791 * bgp_attr.c (bgp_attr_aggregate_intern): Do not set atomic
1792 aggregate when using as-set.
1793
17942001-02-14 "Akihiro Mizutani" <mizutani@dml.com>
1795
1796 * bgpd.c (bgp_confederation_peers_unset): Set peer's local-as
1797 correctly.
1798
1799 * bgp_route.c (bgp_update): Just ignore AS path loop for
1800 confederation peer.
1801
18022001-02-10 Kunihiro Ishiguro <kunihiro@zebra.org>
1803
1804 * bgp_route.c (bgp_aggregate_set): Add as_set argument.
1805 (bgp_aggregate_unset): Remove summary_only argument.
1806 (aggregate_address_as_set): New commands.
1807 "aggregate-address A.B.C.D/M as-set"
1808 "no aggregate-address A.B.C.D/M as-set"
1809
18102001-02-08 "Akihiro Mizutani" <mizutani@dml.com>
1811
1812 * bgp_route.c (bgp_announce_check): Do not modify nexthop when the
1813 route is passed by route reflector.
1814
18152001-02-08 Kunihiro Ishiguro <kunihiro@zebra.org>
1816
1817 * bgp_route.c: "no bgp dampening" with argument.
1818 (bgp_announce_check): Do not modify nexthop when the route is
1819 passed by route reflector.
1820
18212001-02-07 "Akihiro Mizutani" <mizutani@dml.com>
1822
1823 * bgpd.c (neighbor_passive): Change "neighbor NEIGHBOR remote-as
1824 ASN passive" to "neighbor NEIGHBOR passive".
1825 (bgp_announce_check): Check well-known community attribute even
1826 when "no neighbor send-community" is set.
1827
18282001-02-03 Kunihiro Ishiguro <kunihiro@zebra.org>
1829
1830 * bgp_fsm.c (bgp_establish): Do not send keepalive at established
1831 time when keepalive timer is configured as zero.
1832
18332001-02-01 Kunihiro Ishiguro <kunihiro@zebra.org>
1834
1835 * bgp_attr.c (bgp_attr_check): When peer is IBGP peer, local
1836 preference is well-known attribute.
1837
18382001-01-30 Kunihiro Ishiguro <kunihiro@zebra.org>
1839
1840 * zebra-0.91 is released.
1841
1842 * bgp_attr.h (struct attr): Comment out DPA value.
1843 (struct attr): Change refcnt type from int to unsinged long.
1844
1845 * bgp_attr.c (attrhash_key_make): Likewise.
1846 (attrhash_cmp): Likewise.
1847 (bgp_attr_dpa): Likewise.
1848
18492001-01-30 "Akihiro Mizutani" <mizutani@dml.com>
1850
1851 * bgp_route.c (bgp_info_cmp): Make route selection completely same
1852 as Cisco's.
1853
18542001-01-30 Kunihiro Ishiguro <kunihiro@zebra.org>
1855
1856 * bgp_attr.h (BGP_ATTR_FLAG_OPTIONAL): Rename old ATTR_FLAG_* to
1857 BGP_ATTR_FLAG_* to clarify meenings.
1858
18592001-01-30 "Akihiro Mizutani" <mizutani@dml.com>
1860
1861 * bgp_route.c (route_vty_out): Display argument to suppress same
1862 prefix information display.
1863 (route_vty_out_route): Don't display mask information for
1864 classfull network.
1865
18662001-01-30 Kunihiro Ishiguro <kunihiro@zebra.org>
1867
1868 * bgp_attr.h (SET_BITMAP): Simple bitmapping macros.
1869
1870 * bgp_attr.c (bgp_attr_parse): Use bitmap for attribute type
1871 check.
1872
18732001-01-29 Kunihiro Ishiguro <kunihiro@zebra.org>
1874
1875 * bgp_attr.c (bgp_mp_reach_parse): Enclose loggin with BGP_DEBUG.
1876 (bgp_attr_parse): Comment out well-known attribute check.
1877
18782001-01-28 Kunihiro Ishiguro <kunihiro@zebra.org>
1879
1880 * bgp_route.c (bgp_static_unset): Link-local IPv6 address can't be
1881 used for network advertisement.
1882 (nlri_parse): When link-local IPv6 address NLRI comes from
1883 remote-peer, log the information then simply ignore it.
1884
1885 * bgp_zebra.c (zebra_read_ipv6): Link-local IPv6 address is not
1886 redistributed.
1887
1888 * bgp_route.c (bgp_update): Check IPv6 global nexthop
1889 reachability.
1890
18912001-01-26 Kunihiro Ishiguro <kunihiro@zebra.org>
1892
1893 * bgp_route.c (bgp_update): Check nexthop points local address or
1894 not.
1895 (bgp_static_update_vpnv4): Set valid flag.
1896
1897 * bgp_attr.c (bgp_attr_parse): Duplicate attribute check.
1898 (bgp_attr_parse): Well-known attribute check.
1899
1900 * bgp_open.c (bgp_auth_parse): Authentication is not yet supported.
1901
1902 * bgp_packet.c (bgp_valid_marker): Check marker is synchronized.
1903
1904 * bgpd.c (clear_bgp): Send NOTIFICATION Cease when SEND_CEASE is
1905 defined.
1906
1907 * bgp_snmp.c (bgp4PathAttrTable): Fix compile error.
1908
19092001-01-24 Kunihiro Ishiguro <kunihiro@zebra.org>
1910
1911 * bgpd.c (bgp_network_import_check): New command for IGP network
1912 check.
1913
19142001-01-23 Kunihiro Ishiguro <kunihiro@zebra.org>
1915
1916 * bgp_nexthop.c (bgp_scan): Run bgp_process when IGP metric is
1917 changed. Call bgp_process once for each node.
1918
19192001-01-23 "Akihiro Mizutani" <mizutani@dml.com>
1920
1921 * bgp_route.c (bgp_info_cmp): Add IGP metric comparison.
1922
19232001-01-23 Kunihiro Ishiguro <kunihiro@zebra.org>
1924
1925 * bgp_route.c (bgp_info_cmp): Add IGP metric comparison.
1926
1927 * bgp_nexthop.c (bgp_nexthop_lookup): Set IGP metric for valid
1928 IBGP route.
1929
19302001-01-23 "Akihiro Mizutani" <mizutani@dml.com>
1931
1932 * bgp_route.c (show_ip_bgp_prefix_longer): Add new commands.
1933 "show ip bgp A.B.C.D/M longer-prefixes"
1934 "show ip bgp ipv4 (unicast|multicast) A.B.C.D/M longer-prefixes"
1935 "show ipv6 bgp X:X::X:X/M longer-prefixes"
1936 "show ipv6 mbgp X:X::X:X/M longer-prefixes"
1937
19382001-01-20 "Akihiro Mizutani" <mizutani@dml.com>
1939
1940 * bgp_route.c (show_ip_bgp_cidr_only): Add new commands.
1941 "show ip bgp cidr-only"
1942 "show ip bgp ipv4 (unicast|multicast) cidr-only"
1943
19442001-01-18 "Akihiro Mizutani" <mizutani@dml.com>
1945
1946 * bgp_route.c (bgp_update): AS path lookup check is done in
1947 bgp_update() not in attr_parse().
1948
19492001-01-18 Kunihiro Ishiguro <kunihiro@zebra.org>
1950
1951 * bgp_route.c (bgp_update): Call bgp_aggregate_decrement() just
1952 before bgp_attr_unintern().
1953
19542001-01-17 Kunihiro Ishiguro <kunihiro@zebra.org>
1955
1956 * bgp_route.c (bgp_update): Now intern is performed very last part
1957 of the BGP packet update procedure.
1958
19592001-01-17 "Akihiro Mizutani" <mizutani@dml.com>
1960
1961 * bgp_route.c (bgp_update): When implicit withdraw occur, reuse
1962 existing bgp_info structure.
1963
19642001-01-17 Kunihiro Ishiguro <kunihiro@zebra.org>
1965
1966 * bgp_route.c (bgp_aggregate_decrement): Fix bug of aggregate
1967 address matching method.
1968 (bgp_update):
1969
1970 * bgp_nexthop.c (bgp_nexthop_onlink): Separate EBGP nexthop onlink
1971 check and IBGP nexthop route check.
1972
19732001-01-16 "Akihiro Mizutani" <mizutani@dml.com>
1974
1975 * bgp_route.h (BGP_INFO_ATRR_CHANGED): Added for track attribute
1976 change.
1977
19782001-01-16 Kunihiro Ishiguro <kunihiro@zebra.org>
1979
1980 * bgp_route.h (struct bgp_info): Remove selected flag. Use
1981 BGP_INFO_SELECTED for flags instead.
1982 (struct bgp_info): Remove valid flag. Use BGP_INFO_VALID for
1983 flags instead.
1984 (struct bgp_info): Add igpmetric for IBGP route nexthop IGP
1985 metric.
1986 (struct bgp_info_tab): Struct bgp_info_tag is integrated into
1987 struct bgp_info.
1988 (BGP_INFO_ATRR_CHANGED): Added for track attribute change.
1989
1990 * bgp_community.c (community_val_get): gcc-2.95 on
1991 sparc-sun-solaris cause crush. This function is for avoid the
1992 crush.
1993
19942001-01-15 Kunihiro Ishiguro <kunihiro@zebra.org>
1995
1996 * bgp_packet.c (bgp_open_receive): Translated peer's packet_size
1997 clear bug is fixed.
1998
19992001-01-14 "Akihiro Mizutani" <mizutani@dml.com>
2000
2001 * bgp_packet.c (bgp_open_receive): Return notification with
2002 supported version number.
2003
20042001-01-13 Kunihiro Ishiguro <kunihiro@zebra.org>
2005
2006 * bgpd.c (bgp_show_summary): Display AS path and community
2007 entries. Suggested by: "Matt Ranney" <mjr@ranney.com>.
2008
2009 * bgp_packet.c (bgp_read_packet): Fix bug of unblocking BGP socket
2010 read. When BGP packet read is partial, we must get size and type
2011 from packet again.
2012
20132001-01-12 "Akihiro Mizutani" <mizutani@dml.com>
2014
2015 * bgp_route.c (bgp_update): Do not unset BGP_INFO_HISTORY flag.
2016 (bgp_update): When there is a history entry increment route count.
2017 (bgp_damp_set): Check BGP_CONFIG_DAMPENING flag.
2018
2019 * bgp_damp.c (bgp_damp_withdraw): Set status to
2020 BGP_DAMP_DISCONTINUE.
2021
20222001-01-11 Kunihiro Ishiguro <kunihiro@zebra.org>
2023
2024 * bgp_attr.c (bgp_mp_reach_parse): Fix warning code when second
2025 IPv6 nexthop is not link-local addresss.
2026
20272001-01-11 "Akihiro Mizutani" <mizutani@dml.com>
2028
2029 * bgp_damp.c (bgp_config_write_damp): Smart flap dampening
2030 configuration display.
2031 (bgp_damp_info_print): Display elapsed time from flap started.
2032
2033 * bgp_damp.h (struct bgp_damp_info): Add flap start time.
2034
2035 * bgpd.c (peer_create): Set last read time.
2036 (bgp_show_peer): Display last read time.
2037 (bgp_show_summary): Use BGP_CONFIG_DAMPENING flag to check
2038 configuration.
2039
2040 * bgpd.h (BGP_CONFIG_DAMPENING): Add new configuration option.
2041 (struct peer): Add last read time member.
2042 (BGP_VERSION_MP_4): Remove obsolete definition.
2043
20442001-01-10 Kunihiro Ishiguro <kunihiro@zebra.org>
2045
2046 * bgp_nexthop.c: Remove OLD_RIB codes.
2047
2048 * bgp_route.c (bgp_process): Likewise.
2049
2050 * zebra-0.90 is released.
2051
2052 * bgp_route.h (BGP_INFO_HISTORY): Remove damped member from struct
2053 bgp_info. Instead of that use BGP_INFO_DAMPED flag.
2054 (struct bgp_info): Remove invalid member from struct bgp_info.
2055 Instead of that use BGP_INFO_HISTORY flag.
2056
20572001-01-10 "Akihiro Mizutani" <mizutani@dml.com>
2058
2059 * bgp_damp.c (bgp_damp_info_print): New function to display
2060 dampening status.
2061 (DEFAULT_HARF_LIFE): Define default value.
2062 (DEFAULT_REUSE): Likewise.
2063 (DEFAULT_SUPPRESS): Likewise.
2064 (bgp_config_write_damp): When config value is same as default
2065 value, simply display "bgp dampening" to configuration.
2066
2067 * bgp_damp.h (struct bgp_damp_info): Add flap member.
2068
2069 * bgp_route.h (struct bgp_info): Added for BGP flap dampening
2070 history status.
2071
20722001-01-10 Kunihiro Ishiguro <kunihiro@zebra.org>
2073
2074 * bgp_nexthop.c (bgp_connected_add): Point-to-point connected
2075 address is properly handled.
2076 (bgp_connected_delete): Likewise.
2077
2078 * bgp_route.c (bgp_route_init): Turn off BGP Flap dampening code
2079 until it works fine.
2080
20812001-01-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2082
2083 * bgpd.c (bgp_show_summary): Add BGP_VERSION_MP_4 case.
2084
2085 * bgp_route.c (bgp_update): When this is not damped route, clear
2086 ri pointer.
2087
20882001-01-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2089
2090 * bgp_main.c: Add "-n" no_kernel option to not install route to
2091 kernel. Suggested by: "Matt Ranney" <mjr@ranney.com>
2092
20932001-01-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2094
2095 * bgp_nexthop.c (bgp_connected_add): Revert point-to-point
2096 connected route patch. Reported by ruud@ruud.org (Ruud de Rooij)
2097
2098 * bgp_damp.c (bgp_config_write_damp): Add configuration display
2099 function.
2100
2101 * bgp_route.c (bgp_info_free): Set NULL to BGP dampening
2102 information when BGP info structure is freed.
2103 (bgp_info_cmp): Check damped flag.
2104 (bgp_announce_check): Damped route is not announced.
2105
21062001-01-09 "Akihiro Mizutani" <mizutani@dml.com>
2107
2108 * bgpd.c (neighbor_capability_route_refresh): Change "neighbor
2109 route-refresh" command to "neighbor capability route-refresh".
2110 (clear_bgp_soft_in): Change soft-reconfig method.
2111
2112 clear ip bgp <neighbor> soft in
2113 --------------------------------------
2114 Try stored cache first then route-refresh
2115
2116 clear ip bgp <neighbor> in
2117 ---------------------------------
2118 Try route-refresh first then try to use stored cache
2119
21202001-01-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2121
2122 * bgp_nexthop.c (bgp_connected_add): Check point-to-point
2123 connected route. Reported by ruud@ruud.org (Ruud de Rooij)
2124
21252001-01-08 Kunihiro Ishiguro <kunihiro@zebra.org>
2126
2127 * bgp_nexthop.c (bgp_nexthop_lookup): When IBGP nexthop is
2128 changed, refresh it.
2129
21302001-01-04 Kunihiro Ishiguro <kunihiro@zebra.org>
2131
2132 * bgp_route.h (struct bgp_info_tag): Add as_selected to
2133 bgp_info_tag.
2134
21352001-01-03 Kunihiro Ishiguro <kunihiro@zebra.org>
2136
2137 * bgp_route.h (struct bgp_info_tag): Add damped and bgp_damp_info
2138 member for BGP flap dampening.
2139
2140 * bgp_damp.c: New file is added.
2141
2142 * bgp_damp.h: Likewise.
2143
21442001-01-01 Kunihiro Ishiguro <kunihiro@zebra.org>
2145
2146 * bgpd.h (BGP_VTYSH_PATH): Change "/tmp/bgpd" to "/tmp/.bgpd".
2147
21482000-12-29 Kunihiro Ishiguro <kunihiro@zebra.org>
2149
2150 * bgp_nexthop.c (zlookup_connect): Change to use UNIX domain
2151 socket for zebra communication.
2152
21532000-12-29 Akihiro Mizutani <mizutani@dml.com>
2154
2155 * bgp_route.c (bgp_process): Fix "bgp deterministic-med" process.
2156
21572000-12-27 Akihiro Mizutani <mizutani@dml.com>
2158
2159 * bgp_route.c (bgp_process): Add "bgp deterministic-med" process.
2160
21612000-12-25 Akihiro Mizutani <mizutani@dml.com>
2162
2163 * bgp_route.c (bgp_info_cmp): Use ntohl comparing router ID.
2164
21652000-12-18 Akihiro Mizutani <mizutani@dml.com>
2166
2167 * bgp_route.c (bgp_info_cmp): When over three same prefix exit,
2168 withdrawing best prefix perform router ID comparison.
2169
21702000-12-15 Akihiro Mizutani <mizutani@dml.com>
2171
2172 * bgp_route.c (bgp_info_cmp): Do not compare router ID when the
2173 routes comes from EBGP peer. When originator ID is same, take
2174 shorter cluster-list route. If cluster-list is same take smaller
2175 IP address neighbor's route.
2176
2177 * bgpd.c (bgp_bestpath_aspath_ignore): Add "bgp bestpath as-path
2178 ignore" command. When this option is set, do not concider AS path
2179 length when route selection.
2180 (bgp_bestpath_compare_router_id): Add "bgp bestpath
2181 compare-routerid". When this option is set, compare router ID
2182 when the routes comes from EBGP peer.
2183
21842000-12-15 Akihiro Mizutani <mizutani@dml.com>
2185
2186 * bgp_route.c (bgp_info_cmp): Compare originator ID when it is
2187 available.
2188
21892000-12-14 Akihiro Mizutani <mizutani@dml.com>
2190
2191 * bgp_packet.c (bgp_notify_receive): Disply received Notify data
2192 information.
2193
21942000-12-14 Kunihiro Ishiguro <kunihiro@zebra.org>
2195
2196 * bgp_filter.c (as_filter_free): Use MTYPE_AS_FILTER_STR to make
2197 it sure the memory is freed.
2198
2199 * bgp_route.c (route_vty_out_detail): Do not use AF_INET6 outside
2200 HAVE_IPV6.
2201
22022000-12-08 Akihiro Mizutani <mizutani@dml.com>
2203
2204 * bgp_packet.c (bgp_notify_send_with_data): Store BGP notification
2205 data part.
2206
2207 * bgp_network.c (bgp_accept): When BGP connection comes from
2208 unconfigured IP address, close socket immediately.
2209
2210 * bgpd.c: Fix some display format.
2211
22122000-11-29 Kunihiro Ishiguro <kunihiro@zebra.org>
2213
2214 * bgp_packet.c (bgp_keepalive_send): Delete duplicate
2215 bgp_packet_set_size () call.
2216
22172000-11-28 Kunihiro Ishiguro <kunihiro@zebra.org>
2218
2219 * bgp_packet.c (bgp_read_packet): Remove debug codes.
2220
22212000-11-27 Kunihiro Ishiguro <kunihiro@zebra.org>
2222
2223 * bgp_snmp.c (write_bgpPeerTable): Add SNMP set method routine.
2224
2225 * bgp_fsm.c (bgp_stop): Use fsm_change_status to change peer's
2226 status.
2227 (bgp_establish): Likewise.
2228
22292000-11-26 Akihiro Mizutani <mizutani@dml.com>
2230
2231 * bgp_open.c: Fix error messages.
2232
22332000-11-25 Kunihiro Ishiguro <kunihiro@zebra.org>
2234
2235 * bgp_fsm.c (bgp_establish): Call BGP trap when the peer is
2236 established.
2237 (bgp_stop): Call BGP trap when the peer is dropped.
2238
22392000-11-24 Kunihiro Ishiguro <kunihiro@zebra.org>
2240
2241 * bgp_snmp.c (bgp4PathAttrTable): Return BGP path attribute table.
2242
2243 * bgpd.h (struct peer): Add update_time for track last update
2244 received time.
2245
2246 * bgp_packet.c (bgp_notify_receive): Preserv notify code and sub
2247 code in any case.
2248
2249 * bgp_snmp.c (bgpPeerTable): Return remote router ID instead of
2250 peering IP address.
2251 (bgpPeerTable): Return actual BGP version number.
2252
22532000-11-22 Akihiro Mizutani <mizutani@dml.com>
2254
2255 * bgp_debug.c (bgp_notify_print): Notify data length display bug
2256 is fixed.
2257
22582000-11-16 Kunihiro Ishiguro <kunihiro@zebra.org>
2259
2260 * bgp_nexthop.c (zlookup_connect): When UNIX domain connection to
2261 zebra is enabled, use the method.
2262
22632000-11-16 Akihiro Mizutani <mizutani@dml.com>
2264
2265 * bgpd.c: Revise debug message output.
2266
22672000-11-15 Akihiro Mizutani <mizutani@dml.com>
2268
2269 * bgp_clist.c (ip_community_list): Fix bug of string comparison.
2270
22712000-11-14 Akihiro Mizutani <mizutani@dml.com>
2272
2273 * bgp_community.c (community_match): Fix bug of memcmp return
2274 value check.
2275
22762000-11-07 Kunihiro Ishiguro <kunihiro@zebra.org>
2277
2278 * bgp_clist.c (community_list_match_exact): Add check for
2279 entry->style is COMMUNITY_LIST.
2280 (community_match_regexp): Apply new com_nthval macro.
2281
22822000-11-07 Rick Payne <rickp@rossfell.co.uk>
2283
2284 * bgp_routemap.c (route_set_community_delete): "set
2285 community-delete COMMUNITY-LIST" is added.
2286
2287 * bgp_community.c (community_del_val): Delete one community.
2288 (community_delete): Delete all community included in list.
2289 (community_match): Fix bug of matching community value.
2290
2291 * bgp_clist.c (community_entry_free): Free community regular
2292 expression.
2293 (community_entry_make): Default style is COMMUNITY_LIST.
2294 (community_entry_lookup): Make it sure style is COMMUNITY_LIST.
2295 (community_entry_regexp_lookup): New function for community
2296 regular expression lookup.
2297 (community_match_regexp): New function.
2298 (community_delete_regexp): New function.
2299 (community_list_delete_entries): New function.
2300 (community_list_match): Add COMMUNITY_REGEXP treatment.
2301 (community_list_match_exact): Likewise.
2302 (config_write_community): Write community list according to
2303 entry->style.
2304
23052000-11-07 Rick Payne <rickp@rossfell.co.uk>
2306
2307 * bgp_attr.c (bgp_attr_aspath): AS path first AS check.
2308
2309 * bgp_clist.c (struct community_entry): Add style, regexp, reg to
2310 community_entry.
2311
23122000-11-06 Rick Payne <rickp@rossfell.co.uk>
2313
2314 * bgp_aspath.c (aspath_firstas_check): AS path first AS check.
2315
2316 * bgpd.c (bgp_enforce_first_as): New command "bgp
2317 enforce-first-as".
2318
2319 * bgpd.h (BGP_CONFIG_ENFORCE_FIRST_AS): Add new flag.
2320
23212000-11-06 Kunihiro Ishiguro <kunihiro@zebra.org>
2322
2323 * bgp_community.c (community_compare): Copy byte stream data to
2324 actual value instead of using type casting hack.
2325 (community_add_val): Likewise.
2326 (community_uniq_sort): Likewise.
2327 (community_print): Likewise.
2328 (community_print_vty): Likewise.
2329 (community_include): Use memcmp to compare community value.
2330
2331 * bgp_community.h (com_lastval): com_lastval and com_nthval macro
2332 return pointer.
2333
23342000-11-06 Akihiro Mizutani <mizutani@dml.com>
2335
2336 * bgpd.h (struct peer): Add established and dropped member for
2337 count peering up/down statistics.
2338
2339 * bgpd.c (bgp_show_peer): Display peering up/down statistics.
2340
2341 * bgp_fsm.c (bgp_establish): Increment established count.
2342 (bgp_stop): Increment dropped count.
2343
2344 * bgp_packet.c (bgp_notify_receive): Increament notify count.
2345
23462000-11-1 Akihiro Mizutani <mizutani@dml.com>
2347
2348 * bgp_fsm.c: Fix bug of holdtimer is not reset when bgp cleared.
2349
23502000-10-31 Kunihiro Ishiguro <kunihiro@zebra.org>
2351
2352 * bgpd.h: Static bit flag is set by (1 << DIGIT).
2353
23542000-10-24 Akihiro Mizutani <mizutani@dml.com>
2355
2356 * bgp_ecommunity.c (ecommunity_dup): Extended community display
2357 format fix.
2358
23592000-10-24 Arkadiusz Miskiewicz <misiek@pld.org.pl>
2360
2361 * bgp_network.c (bgp_serv_sock_addrinfo): Use gai_strerror.
2362 (bgp_serv_sock_addrinfo): Check address family.
2363
23642000-10-23 Jochen Friedrich <jochen@scram.de>
2365
2366 * bgp_snmp.c: bgp_oid and bgpd_oid are used in smux_open after it
2367 is registered. So those variables must be static.
2368
23692000-10-23 Akihiro Mizutani <mizutani@dml.com>
2370
2371 * bgp_routemap.c (route_match_ip_next_hop): Change "match ip
2372 next-hop" argument from IP address to access-list name.
2373 Remove zebra-0.88 compatibility commands.
2374 "match ip prefix-list WORD"
2375 "match ipv6 prefix-list WORD"
2376
23772000-10-23 Kunihiro Ishiguro <kunihiro@zebra.org>
2378
2379 * bgp_routemap.c (route_match_ipv6_next_hop_compile): Fix bug of
2380 passing the pointer to the pointer of struct in6_addr instead of
2381 the pointer of struct in6_addr in "match ipv6 next-hop" command.
2382
2383 * bgp_route.c (bgp_announce_check): Enclose IPv6 part with
2384 HAVE_IPV6.
2385
23862000-10-20 Jasper Wallace <jasper@ivision.co.uk>
2387
2388 * bgp_snmp.c (bgpPeerTable): ntohs missing bug is fixed. Change
2389 to use linklist.c. Define COUNTER32 as ASN_COUNTER.
2390
23912000-10-18 Kunihiro Ishiguro <kunihiro@zebra.org>
2392
2393 * bgp_route.c (bgp_announce_check): attr->nexthop empty check
2394 should be done by attr->nexthop.s_addr instead of strcmp.
2395
23962000-10-18 Akihiro Mizutani <mizutani@dml.com>
2397
2398 * bgp_zebra.c (zebra_read_ipv4): Pass nexthop value to
2399 bgp_redistribute_add().
2400
2401 * bgp_nexthop.c (bgp_multiaccess_check_v4): New function for
2402 checking IPv4 multiaccess nexthop.
2403
2404 * bgp_route.c (bgp_announce_check): In case of the nexthop is
2405 reachable on multiaccess media, do not change nexthop.
2406 (bgp_redistribute_add): Set nexthop when the value is passed.
2407
24082000-10-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2409
2410 * bgp_fsm.c (bgp_timer_set): If peer is passive mode, do not set
2411 connect timer.
2412 (bgp_start): If the peer is passive mode, force to move to Active
2413 mode.
2414
24152000-10-17 Horms <horms@vergenet.net>
2416
2417 * bgp_debug.c (debug_bgp_fsm): Fix typo.
2418
24192000-10-17 Akihiro Mizutani <mizutani@dml.com>
2420
2421 * bgp_route.c: "show ipv6 bgp" route display improvement.
2422
24232000-10-03 Kunihiro Ishiguro <kunihiro@zebra.org>
2424
2425 * bgp_route.c (neighbor_routes): Allocate sockunion for callback
2426 function.
2427 (bgp_show_neighbor_route): Remove static declaration for union
2428 sockunion.
2429
2430 * bgpd.c (peer_update_source_set): Clean previously allocated
2431 memory before allocate new one.
2432
24332000-10-03 Akihiro Mizutani <mizutani@dml.com>
2434
2435 * bgp_route.c (neighbor_routes): Add show neighbor's routes
2436 command.
2437 "show ip bgp neighbors (A.B.C.D|X:X::X:X) routes"
2438 "show ip bgp ipv4 (unicast|multicast) neighbors (A.B.C.D|X:X::X:X) routes"
2439 "show ipv6 bgp neighbors (A.B.C.D|X:X::X:X) routes"
2440 "show ipv6 mbgp neighbors (A.B.C.D|X:X::X:X) routes"
2441
24422000-10-02 Kunihiro Ishiguro <kunihiro@zebra.org>
2443
2444 * zebra-0.89 is released.
2445
24462000-10-02 Akihiro Mizutani <mizutani@dml.com>
2447
2448 * bgpd.c: "bgp deterministic-med" command is added.
2449
24502000-10-02 Kunihiro Ishiguro <kunihiro@zebra.org>
2451
2452 * bgp_nexthop.c (bgp_connected_add): Apply mask for connected
2453 route addition and deletion.
2454
24552000-09-29 Kunihiro Ishiguro <kunihiro@zebra.org>
2456
2457 * bgp_aspath.c (aspath_cmp_left): Skip confederation AS segment
2458 when comparing leftmost AS number.
2459
24602000-09-29 Akihiro Mizutani <mizutani@dml.com>
2461
2462 * bgpd.c (peer_route_reflector): Route reflector can be set for
2463 IBGP peer.
2464 (bgp_distribute_set): Fix bug of string check for (in|out).
2465 (bgp_show_summary): Display total neighbor count.
2466
24672000-09-28 Akihiro Mizutani <mizutani@dml.com>
2468
2469 * bgp_attr.c (bgp_packet_attribute): Only add cluster_list and
2470 originator for clinet to client routes.
2471 (bgp_packet_attribute): Add new cluster_list to the beginning of
2472 existing cluster_list.
2473 (bgp_packet_attribute): Fix bug of originator is rewritten even
2474 when originator is already set.
2475
24762000-09-27 Kunihiro Ishiguro <kunihiro@zebra.org>
2477
2478 * bgpd.c (bgp_client_to_client_reflection): Add new command.
2479 "no bgp client-to-client reflection"
2480 "bgp client-to-client reflection"
2481
2482 * bgpd.h (BGP_CONFIG_NO_CLIENT_TO_CLIENT): Add new definition.
2483
24842000-09-26 Kunihiro Ishiguro <kunihiro@zebra.org>
2485
2486 * bgp_packet.c (bgp_read): Make BGP packet read to non-blocking
2487 read.
2488 (bgp_read_packet): Likewise.
2489 (bgp_read_packet): When errono is EAGAIN, try to read it again.
2490
2491 * bgp_fsm.c (bgp_stop): Clear packet size and read buffer.
2492
24932000-09-26 Akihiro Mizutani <mizutani@dml.com>
2494
2495 * bgp_routemap.c: Configuration of prefix-list match is shown as
2496 "match ip address prefix-list <WORD>". Old configuration "match
2497 ip prefix-list <WORD>" is left for compatibilitty.
2498
24992000-09-25 Akihiro Mizutani <mizutani@dml.com>
2500
2501 * bgpd.h (BGP_CONFIG_MED_MISSING_AS_WORST): Changed from
2502 BGP_CONFIG_MISSING_AS_WORST.
2503
2504 * bgpd.c (bgp_bestpath_med): Change missing-as-worst syntax.
2505 Old "bgp bestpath missing-as-worst"
2506 New "bgp bestpath med missing-as-worst"
2507
25082000-09-24 Akihiro Mizutani <mizutani@dml.com>
2509
2510 * bgp_route.c: Compare MED properly in case of CONFED-IBGP.
2511
25122000-09-21 steve@Watt.COM (Steve Watt)
2513
2514 * bgp_debug.h: Do not declare debug variables conf_bgp_debug_* and
2515 term_bgp_debug_*.
2516
2517 * bgp_debug.c: Declare variables here.
2518
25192000-09-21 Akihiro Mizutani <mizutani@dml.com>
2520
2521 * bgpd.c: MBGP soft-reconfiguration command is added.
2522 clear ip bgp x.x.x.x ipv4 (unicast|multicast) in
2523 clear ip bgp x.x.x.x ipv4 (unicast|multicast) out
2524 clear ip bgp x.x.x.x ipv4 (unicast|multicast) soft
2525 clear ip bgp <1-65535> ipv4 (unicast|multicast) in
2526 clear ip bgp <1-65535> ipv4 (unicast|multicast) out
2527 clear ip bgp <1-65535> ipv4 (unicast|multicast) soft
2528 clear ip bgp * ipv4 (unicast|multicast) in
2529 clear ip bgp * ipv4 (unicast|multicast) out
2530 clear ip bgp * ipv4 (unicast|multicast) soft
2531
2532 Change "clear ip bgp vpnv4 x.x.x.x soft" command to
2533 "clear ip bgp x.x.x.x vpnv4 unicast soft".
2534
2535 "bgp bestpath med confed" command is added.
2536
2537 * bgpd.h (BGP_CONFIG_MED_CONFED): Add New definition.
2538
25392000-09-18 Rick Payne <rickp@rossfell.co.uk>
2540
2541 * bgpd.c (bgp_show_peer): Fix misplaced #endif.
2542
25432000-09-12 Akihiro Mizutani <mizutani@dml.com>
2544
2545 * bgpd.c (bgp_default_local_preference): Add "bgp default
2546 local-preference" command.
2547
2548 * bgp_nexthop.c (no_bgp_scan_time): Add "no bgp scan-time"
2549 command.
2550
25512000-09-10 Kunihiro Ishiguro <kunihiro@zebra.org>
2552
2553 * bgp_zebra.c (bgp_zebra_announce): BGP confederation peer's routes
2554 are passed to zebra like IBGP route.
2555
25562000-09-10 Akihiro Mizutani <mizutani@dml.com>
2557
2558 * bgpd.c (bgp_config_write_peer): Make it consistent passive
2559 configuration.
2560
2561 * bgp_route.c: Community match command is added.
2562 "show ip bgp community <val>"
2563 "show ip bgp community <val> exact-match"
2564
25652000-09-08 Kunihiro Ishiguro <kunihiro@zebra.org>
2566
2567 * bgp_nexthop.c (bgp_nexthop_lookup): ebgp-multihop routes are
2568 treated as IBGP routes.
2569
25702000-09-08 Akihiro Mizutani <mizutani@dml.com>
2571
2572 * bgp_route.c (bgp_show_route): When local-AS community route is
2573 selected, display "not advertised outside local AS" to "show ip
2574 route A.B.C.D" output.
2575 (show_ip_bgp_ipv4_filter_list): Add below four commands.
2576 "show ip bgp ipv4 (unicast|multicast) filter-list WORD"
2577 "show ip bgp ipv4 (unicast|multicast) community"
2578 "show ip bgp ipv4 (unicast|multicast) community-list WORD"
2579 "show ip bgp ipv4 (unicast|multicast) community-list WORD exact-match"
2580
2581 * bgp_clist.c (community_list_match_exact): Community exact match
2582 function.
2583
25842000-09-07 Kunihiro Ishiguro <kunihiro@zebra.org>
2585
2586 * bgp_route.c (bgp_update): Add peer's ttl check.
2587
2588 * bgpd.h (struct peer): Structure member refresh is renamed to
2589 refresh_adv.
2590
2591 * bgpd.c (clear_bgp_soft_in): Check PEER_FLAG_ROUTE_REFRESH flag
2592 when soft reconfiguration is performed.
2593
2594 * bgp_zebra.c (bgp_zebra_announce): When the peer is EBGP and
2595 ebgp-multiphop is set, set ZEBRA_FLAG_INTERNAL for nexthop lookup.
2596
2597 * bgp_route.h (struct bgp_info_tag): Add valid flag.
2598
25992000-08-25 Akihiro Mizutani <mizutani@dml.com>
2600
2601 * bgpd.c: Add AS base BGP soft reconfiguration.
2602
2603 * bgp_route.c: When no-advertise or no-export route is selected,
2604 "show ip bgp" display "not advertised to EBGP peer" or "not
2605 advertised to any peer" message.
2606
26072000-08-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2608
2609 * zebra-0.88 is released.
2610
2611 * bgp_dump.c (dump_bgp_routes): Change "dump bgp routes" to "dump
2612 bgp route-mrt" to support MRT specific dump format.
2613
2614 * bgpd.c (bgp_init): "clear ip bgp vpnv4 soft {in,out}" command is
2615 added.
2616
2617 * bgp_route.c (bgp_update): Currently nexthop check is only works
2618 for IPv4.
2619
26202000-08-17 Akihiro Mizutani <mizutani@dml.com>
2621
2622 * bgpd. (clear_ip_bgp_all_soft): Add "clear ip bgp * soft" for
2623 both inbound and outbound soft reconfiguration.
2624
26252000-08-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2626
2627 * bgpd.c (clear_ip_bgp_peer_soft_out): Add soft-reconfiguration
2628 outbound.
2629 (peer_new): Set route-refresh flag.
2630
26312000-08-16 Akihiro Mizutani <mizutani@dml.com>
2632
2633 * bgpd.c: "no bgp router-id A.B.C.D" alias is added. "no bgp
2634 cluster-id A.B.C.D" alias is added. " bgp cluster-id
2635 <1-4294967295>" alias is added. "clear ip bgp * soft in" command
2636 is added. "clear ip bgp A.B.C.D in" alias is added. "clear ip
2637 bgp * in" alias is added.
2638
26392000-08-16 Kunihiro Ishiguro <kunihiro@zebra.org>
2640
2641 * bgp_route.c (bgp_update): Add soft_reconfig flag. When the flag
2642 is set do not install the route into Adj-RIBs-In.
2643 (bgp_update): Perform implicit withdraw before filtering of the
2644 route.
2645
2646 * bgp_packet.c (bgp_read): draft-ietf-idr-bgp-route-refresh-01.txt
2647 capability code and BGP message can be accepted.
2648
2649 * bgp_open.c (bgp_capability_parse): Likewise.
2650
2651 * bgp_route.c (bgp_refresh_table): New function for route refresh.
2652 (bgp_refresh_rib): Likewise.
2653
2654 * bgpd.c (bgp_show_peer): Display route refresh status.
2655
2656 * bgp_route.c (bgp_aggregate_add): Add check for the route
2657 validness.
2658 (bgp_aggregate_delete): Likewise.
2659
26602000-08-15 Kunihiro Ishiguro <kunihiro@zebra.org>
2661
2662 * bgp_nexthop.c (bgp_scan): Care for aggregate route when the
2663 route become inaccessible.
2664
26652000-08-15 Akihiro Mizutani <mizutani@dml.com>
2666
2667 * bgp_route.c (show_ip_bgp_prefix): "show ip bgp A.B.C.D/M"
2668 command is added.
2669
26702000-08-15 Kunihiro Ishiguro <kunihiro@zebra.org>
2671
2672 * bgp_zebra.c (bgp_interface_up): Register connected route.
2673 (bgp_interface_down): Unregister connected route.
2674
26752000-08-14 Kunihiro Ishiguro <kunihiro@zebra.org>
2676
2677 * bgp_route.h (struct bgp_info): Add distance to the structure.
2678
2679 * bgp_route.c (bgp_aggregate_increment): Aggregate route only
2680 match to smaller prefixlen route not match same prefixlen route.
2681 (bgp_aggregate_decrement): Likewise.
2682 (bgp_aggregate_add): Likewise.
2683 (bgp_aggregate_delete): Likewise.
2684 (bgp_network_backdoor): Add backdoor network configuration.
2685
2686 * bgpd.h (struct bgp ): Add distance_{ebgp,ibgp,local} for store
2687 configuration distance value.
2688
2689 * bgp_route.c (bgp_update): Filter EBGP route which has non
2690 connected nexthop.
2691
2692 * bgp_attr.c (bgp_attr_aggregate_intern): New function for
2693 aggregate route. Set origin to IGP. Set atomic aggregate flag.
2694 Set aggregator AS and address.
2695 (bgp_attr_aggregate_intern): Check BGP_CONFIG_CONFEDERATION when
2696 filling aggregator_as.
2697
2698 * bgp_route.c (bgp_process): Delete suppress check for install
2699 suppressed route into local routing table.
2700 (bgp_aggregate_increment): Use bgp_attr_aggregate_intern() instead
2701 of bgp_attr_default_intern ().
2702 (bgp_aggregate_add): Likewise.
2703
2704 * bgpd.c (bgp_get): Call bgp_if_update_all() after BGP instance is
2705 created. This is for avoid 0.0.0.0 router-id.
2706
27072000-08-13 Akihiro Mizutani <mizutani@dml.com>
2708
2709 * bgp_route.c (route_vty_out_detail): Display "valid" when the
2710 route is valied. Display "aggregated" when the route is
2711 aggregated. "Advertisements suppressed by an aggregate" is
2712 displayed when the route is suppressed.
2713 (bgp_info_cmp): Prefer EBGP than Confed-EBGP.
2714
27152000-08-10 Akihiro Mizutani <mizutani@dml.com>
2716
2717 * bgp_route.c (route_vty_out_detail): Display format change.
2718
27192000-08-06 Kunihiro Ishiguro <kunihiro@zebra.org>
2720
2721 * bgp_route.c (bgp_update): Only AFI_IP nexthop check is enabled.
2722
2723 * bgpd.c (bgp_delete): Delete static route before delete peer
2724 configuration.
2725
27262000-08-02 Kunihiro Ishiguro <kunihiro@zebra.org>
2727
2728 * bgpd.c: Include bgpd/bgp_nexthop.h.
2729
27302000-07-31 Akihiro Mizutani <mizutani@dml.com>
2731
2732 * bgpd.c (bgp_show_summary): "show ip bgp summary" shows own BGP
2733 identifier. And status is changed like below.
2734
2735 State/Pref -> State/PfxRcd
2736 Shutdown -> Idle (Admin)
2737 PrefixOvflw -> Idle (PfxCt)
2738
2739 * bgp_route.c (route_vty_out): Show internal route as "i".
2740
27412000-07-13 Jim Bowen <jimb@zereau.net>
2742
2743 * bgp_snmp.c: Add BGP peer MIB implementation.
2744
27452000-07-12 Akihiro Mizutani <mizutani@dml.com>
2746
2747 * bgpd.c (bgp_show_peer): Fix typo.
2748
27492000-07-11 Akihiro Mizutani <mizutani@dml.com>
2750
2751 * bgp_routemap.c: Add commands for deleting set without argument.
2752
27532000-07-03 Akihiro Mizutani <mizutani@dml.com>
2754
2755 * bgp_zebra.c: Fix redistribute help strings.
2756
27572000-07-01 Kunihiro Ishiguro <kunihiro@zebra.org>
2758
2759 * bgp_route.c (bgp_show): When bgpd works as vtysh server send all
2760 output to vty at once.
2761
27622000-06-13 Kunihiro Ishiguro <kunihiro@zebra.org>
2763
2764 * bgp_mplsvpn.c (no_vpnv4_network): "no network A.B.C.D/M rd WORD
2765 tag WORD" command is added.
2766
2767 * bgp_ecommunity.c (ecommunity_vty_out): New function added.
2768
27692000-06-12 Kunihiro Ishiguro <kunihiro@zebra.org>
2770
2771 * bgp_route.c (bgp_show): Fix total number of prefix count bug.
2772
2773 * bgpd.c (bgp_show_peer): Display VPNv4 unicast configuration and
2774 negotiation result in "show ip bgp neighbors".
2775
27762000-06-12 Akihiro Mizutani <mizutani@dml.com>
2777
2778 * bgpd.c: Fix help strings.
2779
2780 * bgpd.h: Likewise.
2781
27822000-06-11 Kunihiro Ishiguro <kunihiro@zebra.org>
2783
2784 * bgp_route.c (bgp_aggregate_unset): Fix bug of checking rn->info
2785 instead of rn. Reported by Akihiro Mizutani <mizutani@dml.com>.
2786
2787 * bgp_mplsvpn.c (vpnv4_network): For testing purpose, "network
2788 A.B.C.D rd RD" is added to address-family vpnv4 unicast node.
2789
2790 * bgp_route.c (bgp_static_set): Set safi to p.safi.
2791
27922000-06-10 Kunihiro Ishiguro <kunihiro@zebra.org>
2793
2794 * bgp_route.c (bgp_show_prefix_list): Change to use bgp_show().
2795 (bgp_show_regexp): Change to use bgp_show().
2796 (show_adj_route): Change to display header.
2797
2798 * bgpd.c (clear_bgp): Set peer->v_start to default value when peer
2799 is cleared manually.
2800
2801 * bgp_route.c (bgp_show_route): New function which display
2802 specific BGP route. Divided from bgp_show().
2803 (bgp_static_delete): Delete all static route.
2804
28052000-06-09 NOGUCHI Kay <kay@v6.access.co.jp>
2806
2807 * bgp_route.c (show_ipv6_bgp): "show ipv6 bgp" is broken with
2808 invalid privious fix. Now show_ipv6_bgp and show_ipv6_bgp_route
2809 take care of "show ipv6 bgp [X:X::X:X]". Same change for "show ip
2810 mbgp" and "show ipv6 mbgp".
2811
28122000-06-07 Akihiro Mizutani <mizutani@dml.com>
2813
2814 * bgp_route.c: Fix help strings and command arguments.
2815
28162000-06-06 Kunihiro Ishiguro <kunihiro@zebra.org>
2817
2818 * bgp_ecommunity.c: Include prefix.h
2819
28202000-06-05 Kunihiro Ishiguro <kunihiro@zebra.org>
2821
2822 * bgp_route.h (struct bgp_info_tag): New structure to hold tag
2823 value.
2824
2825 * bgp_route.c (bgp_adj_set): table NULL check is added.
2826 (bgp_adj_unset): Likewise.
2827 (bgp_adj_lookup): Likewise.
2828 (bgp_adj_clear): Likewise.
2829 (route_vty_out): Add SAFI check for nexthop display.
2830 (bgp_withdraw): Add SAFI check for withdraw route.
2831
2832 * Remove all #ifdef MPLS_VPN then include it as default.
2833
2834 * bgpd.c: Temporary disable peer-group command until the
2835 implementation is completed.
2836
2837 * bgp_routemap.c (bgp_route_map_init): Install
2838 route_metric_match_cmd.
2839 (route_match_metric_compile): MED value compile using strtoul.
2840
28412000-06-05 Akihiro Mizutani <mizutani@dml.com>
2842
2843 * bgp_filter.c: Fix help strings. Change REGEXP to LINE. Change
2844 NAME to WORD.
2845
2846 * Change command argument to more comprehensive.
2847
2848 METRIC -> <0-4294967295>
2849 WEIGHT -> <0-4294967295>
2850 LOCAL_PREF -> <0-4294967295>
2851 IP_ADDR -> A.B.C.D
2852 AS -> <1-65535>
2853 AS-PATH-NAME -> WORD
2854 ACCESS_LIST -> WORD
2855 PREFIX_LIST -> WORD
2856 COMMUNITY -> AA:NN
2857 EXT_COMMUNITY -> ASN:nn_or_IP-address:nn
2858 IPv6_ADDR -> X:X::X:X
2859
2860 * bgp_clist.c: Fix help strings.
2861
28622000-06-03 Kunihiro Ishiguro <kunihiro@zebra.org>
2863
2864 * bgpd.c (peer_active): Add new function for check the peer is
2865 active or not.
2866 (neighbor_activate): New command "neighbor PEER activate" and "no
2867 neighbor PEER activate" are added.
2868
2869 * bgp_packet.c: Include bgpd/bgp_mplsvpn.h.
2870
28712000-06-02 Akihiro Mizutani <mizutani@dml.com>
2872
2873 * bgp_clist.c: Fix commuity-list help strings.
2874
2875 * bgp_routemap.c: Fix "set community" help strings. Add #define
2876 SET_STR. Use (unicast|multicast) argument for "set nlri" command.
2877
28782000-06-01 Kunihiro Ishiguro <kunihiro@zebra.org>
2879
2880 * bgp_routemap.c (route_set_community_none_cmd): "set community
2881 none" command is added to route-map.
2882
28832000-06-01 Akihiro Mizutani <mizutani@dml.com>
2884
2885 * bgp_debug.c: Change "show debug" to "show debugging". Now "show
2886 debugging" is not used in VIEW_NODE.
2887
28882000-05-30 Kunihiro Ishiguro <kunihiro@zebra.org>
2889
2890 * bgp_fsm.c (bgp_timer_set): Add check for shutdown flag. This
2891 fix unconditional BGP connection.
2892
2893 * bgpd.c (peer_shutdown): Replace peer_shutdown() with
2894 peer_change_flag_with_reset().
2895
28962000-05-26 Kunihiro Ishiguro <kunihiro@zebra.org>
2897
2898 * bgpd.c (no_bgp_default_ipv4_unicast): Add "no bgp default
2899 ipv4-unicast" command.
2900
2901 * bgpd.h (BGP_CONFIG_NO_DEFAULT_IPV4): Add new definition.
2902
2903 * bgp_filter.c (as_list_delete): Free all AS filter.
2904
2905 * bgp_clist.c (community_list_delete): Free all community entry.
2906
2907 * bgp_filter.c (no_ip_as_path_all): New DEFUN for "no ip as-path
2908 access-list NAME".
2909
2910 * bgp_clist.c (no_ip_community_list_all): New DEFUN for "no ip
2911 community-list NAME".
2912
29132000-05-19 Kunihiro Ishiguro <kunihiro@zebra.org>
2914
2915 * bgp_route.c (ipv6_mbgp_neighbor_routes): Change "show ip bgp PEER
2916 routes" to "show ip bgp PEER received-routes"
2917
29182000-05-14 Kunihiro Ishiguro <kunihiro@zebra.org>
2919
2920 * bgp_ecommunity.c (ecommunity_parse): New file for Extended
2921 Communities attribute.
2922 * bgp_ecommunity.h: Likewise.
2923
29242000-05-11 Kunihiro Ishiguro <kunihiro@zebra.org>
2925
2926 * bgp_mplsvpn.h: New file for MPLS-VPN.
2927 * bgp_mplsvpn.c: Likewise.
2928
2929 * bgpd.c (bgp_delete): Fix bug of "no router bgp" crush.
2930
29312000-05-10 Kunihiro Ishiguro <kunihiro@zebra.org>
2932
2933 * bgpd.c (bgp_bestpath_missing_as_worst): Add "bgp bestpath
2934 missing-as-worst".
2935
29362000-05-08 Kunihiro Ishiguro <kunihiro@zebra.org>
2937
2938 * bgp_routemap.c (match_community): Clarify help of "match
2939 community".
2940
29412000-05-02 Kunihiro Ishiguro <kunihiro@zebra.org>
2942
2943 * bgp_aspath.c (aspath_cmp_left): Remove debug code.
2944
29452000-04-27 Kunihiro Ishiguro <kunihiro@zebra.org>
2946
2947 * bgp_route.c (bgp_info_cmp): Compare MED only both routes comes
2948 from same neighboring AS.
2949
2950 * bgp_aspath.c (aspath_cmp_left): Compare leftmost AS value.
2951
2952 * bgp_route.c (bgp_info_cmp): Fix misused htonl() to ntohl().
2953
29542000-04-26 Kunihiro Ishiguro <kunihiro@zebra.org>
2955
2956 * bgp_route.c (bgp_output_filter): When distribute-list's
2957 corresponding access-list does not exist, filter all routes.
2958 (bgp_input_filter): Likewise.
2959
29602000-04-19 Kunihiro Ishiguro <kunihiro@zebra.org>
2961
2962 * bgp_attr.c (bgp_packet_attribute): Propagate MED to IBGP peer.
2963
2964 * bgp_route.c (bgp_info_cmp): Add evaluation of local preference.
2965
29662000-04-18 Kunihiro Ishiguro <kunihiro@zebra.org>
2967
2968 * bgpd.c (bgp_distribute_update): Add struct access_list *
2969 argument.
2970
29712000-04-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2972
2973 * bgp_clist.c (community_list_dup_check): Add duplicate insertion
2974 check.
2975
2976 * bgp_filter.c (as_list_dup_check): Add duplicate insertion check.
2977
2978 * bgp_route.c (bgp_show): Fix undeclared write variable.
2979
29802000-04-13 Kunihiro Ishiguro <kunihiro@zebra.org>
2981
2982 * bgp_routemap.c: Add "match ip address prefix-list".
2983
29842000-03-29 Rick Payne <rickp@rossfell.co.uk>
2985
2986 * bgp_aspath.c (aspath_strip_confed): Fix realloc problem.
2987
29882000-03-16 Kunihiro Ishiguro <kunihiro@zebra.org>
2989
2990 * bgp_fsm.c (bgp_reconnect): Connect retry timer is expired when
2991 the peer status is Connect.
2992
29932000-03-03 Kunihiro Ishiguro <kunihiro@zebra.org>
2994
2995 * Fix bug of rewritten originator-id.
2996
29972000-01-27 Rick Payne <rickp@rossfell.co.uk>
2998
2999 * bgp_aspath.c (aspath_delimiter_char): New function. Instead of
3000 directly referencing array, search proper AS path delimiter.
3001 (aspath_strip_confed): Strip the confederation stuff from the
3002 front of an AS path.
3003 (aspath_add_left_confed): New function for adding specified AS to
3004 the leftmost AS_CONFED_SEQUENCE.
3005
3006 * bgp_aspath.h: Change AS_CONFED_SEQUENCE and AS_CONFED_SET value
3007 to Cisco compatible.
3008
3009 * bgpd.c (bgp_confederation_id_set): Confederation configuration.
3010 (bgp_confederation_id_unset): Likewise.
3011 (bgp_confederation_peers_check): Likewise.
3012 (bgp_confederation_peers_add): Likewise.
3013 (bgp_confederation_peers_remove): Likewise.
3014 (bgp_confederation_peers_set): Likewise.
3015 (bgp_confederation_peers_unset): Likewise.
3016 (bgp_confederation_peers_print): Likewise.
3017
30182000-01-16 Kunihiro Ishiguro <kunihiro@zebra.org>
3019
3020 * bgpd.c: Introduce peer_change_flag_with_reset() fucntion.
3021
30222000-01-17 Kunihiro Ishiguro <kunihiro@zebra.org>
3023
3024 * bgp_open.c (bgp_open_option_parse): When there is no common
3025 capability send Unsupported Capability error to the peer.
3026
30272000-01-14 Kunihiro Ishiguro <kunihiro@zebra.org>
3028
3029 * bgp_open.c (bgp_capability_mp): Fix bug of mis-negotiation about
3030 IPv6 unicast.
3031
3032 * bgpd.c (bgp_init): Add "soft-reconfiguration inbound" command.
3033
30342000-01-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3035
3036 * bgpd.c (neighbor_strict_capability): Add
3037 "strict-capability-match" command.
3038
3039 * bgp_zebra.c (bgp_if_update): Ignore NET127 determining
3040 router-id.
3041
3042 * bgpd.c (peer_override_capability): Add "override-capability"
3043 command.
3044
30451999-12-16 Kunihiro Ishiguro <kunihiro@zebra.org>
3046
3047 * bgp_packet.c (bgp_write): Change status to Idle and set timer
3048 after write failed.
3049
30501999-12-14 Kunihiro Ishiguro <kunihiro@zebra.org>
3051
3052 * bgp_zebra.c (bgp_zebra_announce): Add info->selected check.
3053
30541999-12-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3055
3056 * bgp_route.c (nlri_unfeasible): nlri_unfeasible() is merged with
3057 nlri_parse().
3058
30591999-12-10 Kunihiro Ishiguro <kunihiro@zebra.org>
3060
3061 * bgp_fsm.h (BGP_EVENT_DELETE): Macro added.
3062
3063 * bgp_fsm.c (bgp_stop): Clear all event threads of the peer when
3064 the peer is cleared.
3065
3066 * bgp_zebra.c (bgp_nexthop_set): Clear interface index of
3067 link-local address. This is KAME specific problem.
3068
30691999-12-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3070
3071 * bgp_attr.c (bgp_mp_reach_parse): Comment out previous code for a
3072 while. We don't completely detect the link is shared or not at
3073 this moment.
3074
3075 * bgp_packet.c (bgp_notify_send): Make shortcut call of
3076 bgp_write() and bgp_stop().
3077
3078 * bgp_attr.c (bgp_mp_reach_parse): Fix serious bug when getting
3079 global and link-local address.
3080
30811999-12-05 Kunihiro Ishiguro <kunihiro@zebra.org>
3082
3083 * bgpd.c (no_neighbor_port): New command added.
3084 (peer_new): Set send_community.
3085
30861999-12-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3087
3088 * bgpd.c (show_ip_bgp_summary): Changed to use bgp_show_summary().
3089 (show_ip_mbgp_summary): Likewise.
3090 (show_ipv6_bgp_summary): Likewise.
3091 (show_ipv6_mbgp_summary): Add new command.
3092 (peer_free): Free peer->host.
3093 (peer_lookup_by_su): Delete function.
3094 (ipv6_bgp_neighbor): Changed to use peer_remote_as().
3095 (sockunion_vty_out): Function deleted.
3096 (vty_clear_bgp): Use afi instead of family.
3097 Delete old list bgp_list. Use struct newlist *bgplist.
3098 (peer_lookup_by_host): Function deleted.
3099
31001999-12-03 Kunihiro Ishiguro <kunihiro@zebra.org>
3101
3102 * bgpd.h (struct peer_group): New structure added.
3103 (struct peer_conf): New structure added.
3104 (struct peer): Change all prefix_count to unsigned long.
3105
3106 * bgpd.c: Reconstruct all of VTY commands reflect internal
3107 structure change.
3108 Use bgplist instead of bgp_list.
3109 Use peerlist intstead of peer_list.
3110
3111 * bgp_attr.c (bgp_mp_reach_parse): If nlri_parse return -1, stop
3112 parsing then return immediately.
3113
3114 * bgp_route.c (nlri_parse): When NLRI parse error occured, return
3115 -1.
3116 (nlri_process): Use pcount_v4_{unicast,multicast}.
3117 (nlri_delete): Likewise.
3118
31191999-11-25 Robert Olsson <Robert.Olsson@data.slu.se>
3120
3121 * bgp_routemap.c (route_match_nlri): `match nlri
3122 unicast|multicast' and `set nlri unicast|multicast' command are
3123 added.
3124
31251999-11-22 Robert Olsson <Robert.Olsson@data.slu.se>
3126
3127 * bgpd.c: Add translate-update support.
3128
3129 * bgpd.h (TRANSLATE_UPDATE_OFF): Add translate-update definition.
3130
31311999-11-19 Robert.Olsson@data.slu.se
3132
3133 * bgp_route.c (bgp_peer_delete): Add MBGP peer clear codes.
3134
31351999-11-14 Kunihiro Ishiguro <kunihiro@zebra.org>
3136
3137 * bgp_open.c (bgp_capability_mp): Temporary comment out
3138 SAFI_UNICAST_MULTICAST handling until we know the meanings.
3139
31401999-11-13 Kunihiro Ishiguro <kunihiro@zebra.org>
3141
3142 * bgp_btoa.c: New file added.
3143
31441999-11-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3145
3146 * bgpd.h (struct peer): Add dont_capability flag.
3147 (struct peer): Add override_capability flag.
3148
3149 * bgpd.c (neighbor_dont_capability_negotiation): `neighbor PEER
3150 dont-capability-negotiation' added.
3151
31521999-11-12 Bill Sommerfeld <sommerfeld@orchard.arlington.ma.us>
3153
3154 * bgp_attr.c (bgp_mp_reach_parse): Ignore link-local addresses
3155 attribute from non-shared-network peers.
3156
31571999-11-10 Kunihiro Ishiguro <kunihiro@zebra.org>
3158
3159 * bgp_snmp.c: New file added.
3160
3161 * BGP4-MIB.txt: Updated to the latest Internet-Draft
3162 draft-ietf-idr-bgp4-mib-04.txt.
3163
31641999-11-09 Kunihiro Ishiguro <kunihiro@zebra.org>
3165
3166 * bgp_route.c (bgp_route_init): Add `show ipv6 bgp prefix-list'.
3167
3168 * bgp_attr.c (bgp_mp_unreach_parse): Enclose safi setup with
3169 #ifdef HAVE_MBGPV4.
3170
31711999-11-08 Kunihiro Ishiguro <kunihiro@zebra.org>
3172
3173 * bgp_dump.c (no_dump_bgp_all): Add [PATH] and [INTERVAL] to no
3174 dump bgp commands.
3175 (config_write_bgp_dump): Write interval value to the
3176 configuration.
3177
31781999-11-07 Kunihiro Ishiguro <kunihiro@zebra.org>
3179
3180 * bgp_zebra.c: Redistribute route-map support is added.
3181
3182 * bgp_zebra.h: New file added.
3183
31841999-11-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3185
3186 * bgp_dump.c: BGP packet dump routine compatible with MRT.
3187 * bgp_dump.h: BGP packet dump routine compatible with MRT.
3188
3189 * bgp_debug.c: Renamed from bgp_dump.c
3190 * bgp_debug.h: Renamed from bgp_dump.h
3191
31921999-10-27 Kunihiro Ishiguro <kunihiro@zebra.org>
3193
3194 * BGP4-MIB.txt: New file added. Edited version of RFC1657.
3195
31961999-10-25 Bill Sommerfeld <sommerfeld@orchard.arlington.ma.us>
3197
3198 * bgp_route.c (bgp_announce): If we're not on a shared network
3199 with the peer and we don't have a link-local next hop, but the
3200 inbound next-hop has a link-local address, don't readvertise it to
3201 our peer.
3202
32031999-10-25 Marc Boucher <marc@mbsi.ca>
3204
3205 * bgp_zebra.c: Add redistribute kernel command.
3206
32071999-10-25 Kunihiro Ishiguro <kunihiro@zebra.org>
3208
3209 * bgp_route.c (bgp_reset): New function added.
3210
3211 * bgpd.conf.sample2: Add IPv6 configuration sample.
3212
32131999-10-24 Bill Sommerfeld <sommerfeld@orchard.arlington.ma.us>
3214
3215 * bgp_route.c (ipv6_aggregate_address): Function added.
3216
32171999-10-21 Kunihiro Ishiguro <kunihiro@zebra.org>
3218
3219 * bgp_packet.c (bgp_update): Unintern aspath, community, cluster
3220 list after parsing BGP update packet.
3221
3222 * bgp_attr.c (bgp_attr_aspath): Intern parsed aspath.
3223 (bgp_attr_community): Intern parsed community.
3224 (bgp_attr_cluster_list): Intern parsed cluster list.
3225
3226 * bgp_routemap.c: Add `set community-additive' command.
3227
32281999-10-21 Alexandr D. Kanevskiy <kad@blackcatlinux.com>
3229
3230 * bgp_routemap.c (route_set_local_pref): Fix bug of setting
3231 attribute flag.
3232
32331999-10-21 Bill Sommerfeld <sommerfeld@orchard.arlington.ma.us>
3234
3235 * bgp_route.c (bgp_announce): Add check of IPv6 default route
3236 announcement.
3237
3238 * bgp_packet.c (bgp_update_send): Add BGP announcement logging.
3239
32401999-10-15 Kunihiro Ishiguro <kunihiro@zebra.org>
3241
3242 * `show ip[v6] bgp PREFIX' show uptime of the route.
3243
32441999-10-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3245
3246 * bgpd.c (bgp_filter_set): Delete PEER_FAMILY_{IPV4,IPV6}. instead
3247 of that use AF_INET and AF_INET6 directly.
3248 (vty_clear_bgp): Add new function to support various clear ip bgp
3249 method.
3250
32511999-10-04 Lars Fenneberg <lf@elemental.net>
3252
3253 * bgpd.c (clear_ip_bgp): Add `clear ip bgp ASN'.
3254
32551999-10-03 Kunihiro Ishiguro <kunihiro@zebra.org>
3256
3257 * bgp_routemap.c: Add `match ip prefix-list' and `match ipv6
3258 prefix-list'.
3259
32601999-09-28 Kunihiro Ishiguro <kunihiro@zebra.org>
3261
3262 * bgpd.c (bgp_collision_detect): Add BGP collision detection
3263 function.
3264
32651999-09-26 Blake Meike <bmeike@adero.com>
3266
3267 * bgpd.c (neighbor_port): New command `neighbor PEER port PORT' is
3268 added.
3269
32701999-08-24 Kunihiro Ishiguro <kunihiro@zebra.org>
3271
3272 * bgpd.c (no_neighbor_timers_keepalive): Change MIN to min. Add
3273 min() macro.
3274
32751999-08-19 Rick Payne <rickp@rossfell.co.uk>
3276
3277 * bgp_packet.c (bgp_open): BGP holdtimer bug is fixed. Make BGP
3278 keepalive timer configurable.
3279
32801999-08-15 Kunihiro Ishiguro <kunihiro@zebra.org>
3281
3282 * bgp_zebra.c (bgp_redistribute_set): Fix redistribute bug.
3283
32841999-08-13 Kunihiro Ishiguro <kunihiro@zebra.org>
3285
3286 * bgpd.c (bgp_peer_display): show ip bgp neighbors PEER only list
3287 the peer not all of them.
3288
32891999-08-11 Rick Payne <rickp@rossfell.co.uk>
3290
3291 * bgp_route.c (bgp_announce): Remove MED if its an EBGP peer -
3292 will get overwritten by route-maps.
3293
32941999-08-08 Rick Payne <rickp@rossfell.co.uk>
3295
3296 * bgp_routemap.c: Multi protocol route-map modification.
3297
32981999-08-01 Kunihiro Ishiguro <kunihiro@zebra.org>
3299
3300 * bgp_route.c: Set network statement route's origin attribute as
3301 igp.
3302
3303 * bgp_zebra.c: Set redistribute route's origin attribute as
3304 incomplete.
3305
3306 * bgp_route.c (bgp_info_cmp): Add attribute existance check,
3307 origin attribute check, BGP peer type check.
3308
33091999-07-30 Kunihiro Ishiguro <kunihiro@zebra.org>
3310
3311 * bgp_route.c (bgp_peer_delete): Reselect of IPv6 route.
3312
33131999-07-29 Rick Payne <rickp@rossfell.co.uk>
3314
3315 * Changed route-maps to behave in a more cisco-like fashion
3316
33171999-07-27 Kunihiro Ishiguro <kunihiro@zebra.org>
3318
3319 * bgp_fsm.c (bgp_stop): Very serious bug of bgp_stop () is fixed.
3320 When multiple route to the same destination exist, bgpd try to
3321 announce the information to stopped peer. Then add orphan write
3322 thread is added. This cause many strange behavior of bgpd.
3323 Reported by Georg Hitsch <georg@atnet.at>.
3324
33251999-07-23 Kunihiro Ishiguro <kunihiro@zebra.org>
3326
3327 * bgpd.c: Change peer's A.B.C.D to PEER.
3328
33291999-07-22 Kunihiro Ishiguro <kunihiro@zebra.org>
3330
3331 * bgp_route.c (bgp_announce): Add hack for link-local nexthop.
3332
3333 * bgp_zebra.c (bgp_zebra_announce): Fill in nexthop address from
3334 local address.
3335
33361999-07-21 Kunihiro Ishiguro <kunihiro@zebra.org>
3337
3338 * bgp_packet.c (bgp_open): Holdtime fetch bug is fixed. Reported
3339 by Yuji SEKIYA <sekiya@sfc.wide.ad.jp>.
3340
33411999-07-15 Kunihiro Ishiguro <kunihiro@zebra.org>
3342
3343 * bgp_fsm.c (fsm_holdtime): Don't close file descriptor in
3344 fsm_holdtime ().
3345
33461999-07-11 Kunihiro Ishiguro <kunihiro@zebra.org>
3347
3348 * bgp_routemap.c: Add `set atomic-aggregate' command.
3349
33501999-07-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3351
3352 * bgp_routemap.c (route_set_ip_nexthop_cmd): Change "ip nexthop"
3353 to "ip next-hop".
3354
33551999-07-02 Kunihiro Ishiguro <kunihiro@zebra.org>
3356
3357 * bgp_route.c (show_ipv6_bgp_regexp): `show ipv6 bgp regexp'
3358 added.
3359
33601999-07-01 Rick Payne <rickp@rossfell.co.uk>
3361
3362 * bgp_zebra.c (zebra_init): Install standard commands to
3363 ZEBRA_NODE.
3364
33651999-06-28 Rick Payne <rickp@rossfell.co.uk>
3366
3367 * bgpd.c (bgp_delete): bgp peer deletion bug is fixed.
3368
33691999-06-25 Kunihiro Ishiguro <kunihiro@zebra.org>
3370
3371 * bgpd.c: Add neighbor update-source command as ALIAS to
3372 neighbor_interface.
3373
33741999-06-19 Kunihiro Ishiguro <kunihiro@zebra.org>
3375
3376 * bgp_attr.c (bgp_packet_attribute): Send community attribute when
3377 send_community flag is set.
3378
3379 * bgpd.h (struct peer): Add send_community flag.
3380
33811999-06-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3382
3383 * bgpd.c (router_bgp): router bgp's argument changed from AS_NO to
3384 <1-65535>.
3385
33861999-06-08 Kunihiro Ishiguro <kunihiro@zebra.org>
3387
3388 * bgp_route.h (struct bgp_info): Add subtype for BGP route type.
3389
33901999-06-07 Kunihiro Ishiguro <kunihiro@zebra.org>
3391
3392 * bgp_community.c (community_merge): Function added.
3393
33941999-06-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3395
3396 * bgp_clist.c: New file.
3397 * bgp_clist.h: New file.
3398
3399 * bgp_community.h (COMMUNITY_LOCAL_AS): Added for Cisco
3400 compatibility.
3401 (COMMUNITY_NO_ADVERTISE): Fix typo.
3402
34031999-05-30 Kunihiro Ishiguro <kunihiro@zebra.org>
3404
3405 * bgp_routemap.c: Add `set weight WEIGHT' command.
3406
3407 * bgpd.c: Remove all_digit_check function. Instead of that use
3408 all_digit function in lib/prefix.c.
3409
3410 * bgp_routemap.c (bgp_route_map_init): Install
3411 no_set_ipv6_nexthop_global_cmd and no_set_ipv6_nexthop_local_cmd
3412 element to the RMAP_NODE.
3413
34141999-05-28 Kunihiro Ishiguro <kunihiro@zebra.org>
3415
3416 * bgp_aspath.c (aspath_make_str): Declare aspath_delimiter_char
3417 inside aspath_make_str function.
3418 (aspath_prepend): New function is added for AS path prepend.
3419 (aspath_make_str_count): Renamed from aspath_make_str. AS path
3420 count is set to the structure.
3421 (aspath_merge): New function.
3422
34231999-05-22 Kunihiro Ishiguro <kunihiro@zebra.org>
3424
3425 * bgp_zebra.c (redistribute_bgp): Add new DEFUN.
3426 (no_redistribute_bgp): Likewise.
3427 (router_zebra): Semantics changed. Now 'router zebra' is default
3428 behavior of bgpd.
3429
34301999-05-14 Kunihiro Ishiguro <kunihiro@zebra.org>
3431
3432 * bgp_routemap.c: Add some commands to bgp route-map.
3433 match ip next-hop: New command.
3434 match metric: New command.
3435 set metric: Doc fix.
3436 set local-preference: Add DEFUN.
3437
34381999-05-14 Stephen R. van den Berg <srb@cuci.nl>
3439
3440 * bgp_main.c (signal_init): SIGTERM call sigint.
3441 (sigint): Loggging more better message.
3442
34431999-05-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3444
3445 * bgp_attr.c (bgp_packet_attribute): AS path attribute extended
3446 length bit check is added.
3447
34481999-05-11 Kunihiro Ishiguro <kunihiro@zebra.org>
3449
3450 * bgp_routemap.c (bgp_route_map_init): Call route_map_install_set
3451 function with route_set_local_pref_cmd argument.
3452 (no_match_aspath): Function added.
3453 (route_set_metric): Set attribute flag bit.
3454
3455 * bgp_attr.c (bgp_packet_attribute): MULTI_EXIT_DISC is now in BGP
3456 packet.
3457
34581999-05-07 Kunihiro Ishiguro <kunihiro@zebra.org>
3459
3460 * bgpd.c (no_neighbor_timers_holdtime): `no neighbor PEER timers
3461 holdtime' command is added.
3462
3463 * bgpd.h (BGP_DEFAULT_HOLDTIME_BIG): Delete define.
3464
3465 * bgpd.c (bgp_prefix_list_set): New function added.
3466 (bgp_prefix_list_unset): Likewise.
3467 (bgp_prefix_list_update): Likewise.
3468 (show_ip_bgp_neighbors): prefix-list information display.
3469
34701999-05-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3471
3472 * bgpd.c (bgp_delete): Function added for `no router bgp'.
3473
34741999-05-05 Kunihiro Ishiguro <kunihiro@zebra.org>
3475
3476 * bgp_dump.c (bgp_dump_attr): Add originator_id display.
3477
3478 * bgpd.c (bgp_router_id): Even when address is malformed set the
3479 value to configuration bug fixed.
3480 (no_bgp_router_id): New function.
3481 (no_bgp_cluster_id): New function.
3482
34831999-05-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3484
3485 * bgpd.h (BGP_ATTR_ORIGINATOR_ID): Changed from BGP_ATTR_ORIGINATOR.
3486
34871999-05-02 Kunihiro Ishiguro <kunihiro@zebra.org>
3488
3489 * bgp_route.c (bgp_announce): Add route reflector check.
3490
34911999-05-01 Kunihiro Ishiguro <kunihiro@zebra.org>
3492
3493 * bgpd.c (bgp_cluster_id): Add function for route reflector.
3494 (neighbor_route_reflector_client): Likewise.
3495 (no_neighbor_route_reflector_client): Likewise.
3496
3497 * bgpd.h (struct bgp ): Add cluster for route reflector.
3498
3499 * bgp_route.c (show_ip_bgp_prefix_list): New command is added.
3500
35011999-04-24 Kunihiro Ishiguro <kunihiro@zebra.org>
3502
3503 * Makefile.am (noinst_HEADERS): Add bgp_filter.h
3504
3505 * bgp_aspath.c (aspath_undup): Function deleted. aspath_free ()
3506 has same functionality.
3507
3508 * bgp_filter.h: New file.
3509
3510 * bgp_aspath.c (aspath_unintern): Rename aspath_free () to
3511 aspath_unintern ()
3512 (aspath_free): New function.
3513
35141999-04-23 Kunihiro Ishiguro <kunihiro@zebra.org>
3515
3516 * bgp_aspath.c (aspath_aggregate): Function added.
3517
3518 * bgp_aspath.h (aspath_aggregate): Prototype added.
3519
3520 * bgp_aspath.c (aspath_empty_aspath): New argument
3521 gated_dont_eat_flag is added.
3522
35231999-04-18 Kunihiro Ishiguro <kunihiro@zebra.org>
3524
3525 * bgp_route.c: Add bgp_aggregate_ipv4 and bgp_aggregate_ipv6.
3526
35271999-04-17 Kunihiro Ishiguro <kunihiro@zebra.org>
3528
3529 * bgp_route.c (aggregate_address): Function added.
3530
3531 * bgp_zebra.c (zebra_read): Change log to zlog.
3532
35331999-04-15 Kunihiro Ishiguro <kunihiro@zebra.org>
3534
3535 * Makefile.am (noninst_HEADERS): Added for make dist.
3536
35371999-04-09 Kunihiro Ishiguro <kunihiro@zebra.org>
3538
3539 * aspath_regex.c: Removed from distribution.
3540
35411999-04-07 Kunihiro Ishiguro <kunihiro@zebra.org>
3542
3543 * bgp_attr.c (bgp_packet_attribute): Old draft-00 packet treatment
3544 bug fixed.
3545
35461999-04-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3547
3548 * bgp_aspath.c (aspath_add_left): Fix empty aspath bug. Reported
3549 by kad@gibson.skif.net.
3550
3551 * bgp_regex.[ch]: New file added.
3552
3553
35541999-04-05 Kunihiro Ishiguro <kunihiro@zebra.org>
3555
3556 * bgp_filter.c: New file added.
3557
35581999-04-01 Kunihiro Ishiguro <kunihiro@zebra.org>
3559
3560 * bgp_aspath.c (aspath_empty_aspath): Change for peering with
3561 gated.
3562
35631999-03-24 Kunihiro Ishiguro <kunihiro@zebra.org>
3564
3565 * bgp_main.c (main): Default loggin method changed from syslog to
3566 stdout.
3567
35681999-03-05 Kunihiro Ishiguro <kunihiro@zebra.org>
3569
3570 * bgp_route.c: Delete obsolete default attribute DEFUN.
3571
35721999-03-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3573
3574 * bgp_attr.c: Make attribute structure put into attribute hash.
3575
35761999-03-02 Kunihiro Ishiguro <kunihiro@zebra.org>
3577
3578 * bgp_view.c : Delete file.
3579
35801999-02-25 Kunihiro Ishiguro <kunihiro@zebra.org>
3581
3582 * bgp_routemap.c (bgp_apply_route_map): Add prefix argument.
3583
3584 * bgp_route.h (struct bgp_info): Add bgp_info structre. I'll
3585 replace bgp_route with this.
3586
3587 * bgp_routemap.c (route_match_ip_address): Fix bug of passing non
3588 prefix value to access_list_apply().
3589
3590 * bgpd.conf.sample: Add route-map sample.
3591 Delete obsolete default-attr statements.
3592
3593 * bgp_packet.c: Use stream_fifo for packet queueing.
3594
35951999-02-24 Kunihiro Ishiguro <kunihiro@zebra.org>
3596
3597 * bgp_aspath.c (aspath_add_left): add non empty aspath treatment.
3598
3599 * bgp_main.c: include unistd.h for daemon().
3600
3601 * bgp_route.c (nlri_process): add IPv6 table lookup.
3602
3603 * bgp_attr.c (route_parse_ipv6): call nlri_process().
3604 (attr_make): Obsolete function attr_make deleted.
3605
36061999-02-22 Kunihiro Ishiguro <kunihiro@zebra.org>
3607
3608 * bgp_aspath.c (aspath_add_left): change function name from
3609 aspath_add_leftmost_as().
3610
36111999-02-21 Kunihiro Ishiguro <kunihiro@zebra.org>
3612
3613 * bgp_aspath.c: add aspath_add_leftmost_as ().
3614
36151999-02-18 Peter Galbavy <Peter.Galbavy@knowledge.com>
3616
3617 * syslog support added
3618
36191999-01-26 Kunihiro Ishiguro <kunihiro@zebra.org>
3620
3621 * bgpd.c: DEFUN (neighbor_nexthop): deleted.
3622 DEFUN (neighbor_distribute_list): added.
3623
36241999-01-19 Kunihiro Ishiguro <kunihiro@zebra.org>
3625
3626 * bgpd.h (struct peer ): header_buf and read_buf is removed.
3627
3628 * bgp_peer.[ch]: Deleted. Peer related functions are merged to
3629 bgpd.c
3630
3631 * bgp_network.c: New file.
3632 * bgp_network.h: New file.
3633
3634 * bgp_packet.h: New file.
3635
36361999-01-11 Kunihiro Ishiguro <kunihiro@zebra.org>
3637
3638 * bgp_packet.c (bgp_keepalive_send): Now BGP keepalive packet is
3639 buffered.
3640
36411999-01-08 Kunihiro Ishiguro <kunihiro@zebra.org>
3642
3643 * bgp_packet.c: New file.
3644
36451998-12-22 Kunihiro Ishiguro <kunihiro@zebra.org>
3646
3647 * bgp_zebra.c (zebra_client): Use zebra_connect() in lib/client.c.
3648
3649 * `show ip bgp' bug fixed.
3650 * aspath_log (): Remove argument logfp.
3651
36521998-12-15 Kunihiro Ishiguro <kunihiro@zebra.org>
3653
3654 * bgp_fsm.h: New file.
3655
36561998-12-15 Magnus Ahltorp <map@stacken.kth.se>
3657
3658 * bgp_attr.c, bgp_community.h, bgp_dump.c, bgp_fsm.c, bgp_open.c
3659 bgp_peer.c, bgp_peer.h, bgp_route.c, bgp_route.h, bgp_view.c
3660 bgpd.c, bgpd.h, bgp_attr.c, bgp_community.h, bgp_dump.c,
3661 bgp_fsm.c, bgp_open.c, bgp_peer.c, bgp_peer.h: Prototype fixes.
3662
36631998-12-09 Kunihiro Ishiguro <kunihiro@zebra.org>
3664
3665 * bgpd.c (bgp_config_write): Delete vector v argument.
3666
36671998-12-07 Kunihiro Ishiguro <kunihiro@zebra.org>
3668
3669 * bgpd.h: Delete annoying ld_[124]byte and st_[124]byte macros.
3670
36711998-11-23 Kunihiro Ishiguro <kunihiro@zebra.org>
3672
3673 * bgp_radix.[ch]: removed.
3674
36751998-09-15 HEO SeonMeyong <seirios@matrix.iri.co.jp>
3676
3677 * bgp_main.c: ifdef HYDRANGEA -> ifdef KAME
3678
36791998-08-13 Kunihiro Ishiguro <kunihiro@zebra.org>
3680
3681 * bgp_dump.c: delete nroute().
3682
36831998-05-19 Yamshita TAKAO <jargon@lares.dti.ne.jp>
3684
3685 * bgp_aspath.c: HAVE_CONFIG_H typo :-)
3686 * bgpd.h: Modify for compile on Solaris.
3687 * bgp_aspath.h: likewize
3688 * bgp_community.h: likewize
3689 * bgp_routemap.c: likewize
3690
36911998-05-18 Yamshita TAKAO <jargon@lares.dti.ne.jp>
3692
3693 * bgpd.h: Modify for compile on Solaris.
3694 * bgp_aspath.h: likewize
3695
36961998-05-08 Kunihiro Ishiguro <kunihiro@zebra.org>
3697
3698 * routemap.[ch]: move to ../lib directory.
3699
37001998-05-07 Kunihiro Ishiguro <kunihiro@zebra.org>
3701
3702 * routemap.c (route_map_apply): add function.
3703
37041998-05-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3705
3706 * routemap.h: add file.
3707
3708 * bgp_peer.h (enum ): change PEER_{IBGP,EBGP} to BGP_PEER_{IBGP,EBGP}
3709
37101998-05-03 Kunihiro Ishiguro <kunihiro@zebra.org>
3711
3712 * Makefile.am: sysconfdir_DATA added.
3713
37141998-05-02 Kunihiro Ishiguro <kunihiro@zebra.org>
3715
3716 * bgp_dump.c: add `debug bgp fsm'
3717 add `no debug bgp fsm'
3718 add `show debug bgp'
3719 * bgp_open.c: File added.
3720
37211998-05-01 Kunihiro Ishiguro <kunihiro@zebra.org>
3722
3723 * .cvsignore: File added.
3724
37251998-04-30 Kunihiro Ishiguro <kunihiro@zebra.org>
3726
3727 * bgp_community.[ch]: File added.
3728
37291998-03-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3730
3731 * bgpd now use lib/thread.[ch].
3732
37331998-01-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3734
3735 * bgpd.c (show_ip_bgp_neighbors): add 'show ip bgp neighbors' command.
3736
3737 * bgpd.h (BGP_DEFAULT_START_TIMER): change from 1 to 30.
3738
37391997-12-30 Kunihiro Ishiguro <kunihiro@zebra.org>
3740
3741 * bgp_vty.c: bgp_vty.c deleted.
3742
3743 * bgpd.c (config_write_neighbor): add ebgp-multihop command.
3744
37451997-12-29 Kunihiro Ishiguro <kunihiro@zebra.org>
3746
3747 * bgp_fsm.c: [-p bgp_port] and [-P vty_port] works
3748
37491997-12-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3750
3751 * bgp_vty.c: new file.
3752
3753 * bgp_attr.c: add new logging system.
3754
37551997-11-23 Kunihiro Ishiguro <kunihiro@zebra.org>
3756
3757 * Change all inet_addr call into inet_aton.
3758
37591997-11-10 Kunihiro Ishiguro <kunihiro@zebra.org>
3760
3761 * bgp_radix.c: change radix_peer_delete
3762
37631997-10-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3764
3765 * bgp_aspath.c: move AS_TOKEN_??? definition from header to c source.
3766
37671997-09-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3768
3769 * bgp_dump.c (bgp_log_route): add dump_attr function
3770
37711997-09-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3772
3773 * bgp_aspath.c (aspath_test): change AS_SET brace from '[' to '{'
3774 * bgp_dump.c (bgp_log_route): change logfile format.
3775
37761997-08-19 Kunihiro Ishiguro <kunihiro@zebra.org>
3777
3778 * bgp_open.c (bgp_open): move bgp_open function from bgpd.c
3779 * bgp_attr.c (community_str2com): add community value generation
3780 * bgp_attr.h: add SAFI definition for BGP-4+
3781
37821997-08-18 Kunihiro Ishiguro <kunihiro@zebra.org>
3783
3784 * bgpd.h: add BGP_OPEN_OPT_CAP for Capabilities Optional Parameter
3785 * Makefile.in: add bgp_open.o, delete bgp_loop.o
3786 * bgp_open.c: newfile which manages BGP Open message
3787 * bgp_loop.c: this file is merged with bgp_fsm.c
3788 * bgp_radix.c (radix_add): radix_add() now return route_t instead
3789 of int
3790 (bgp_sim): now we can read update & withdraw from file
3791 * bgp_route.c: add route_free() call into route_parse etc.
3792
37931997-08-17 Kunihiro Ishiguro <kunihiro@zebra.org>
3794
3795 * bgp_radix.c: Radix code is completely rewritten. It has better
3796 memory treatment than old one.
3797
37981997-08-14 Kunihiro Ishiguro <kunihiro@zebra.org>
3799
3800 * bgp_route.c: route_alloc for route struct allocation statistics.
3801 * bgpd.c (bgp_make_update): now we cann announce MED attribute.
3802 * bgp_aspath.c (aspath_print_all): change aspath_print_all output
3803 format.
3804
38051997-08-13 Kunihiro Ishiguro <kunihiro@zebra.org>
3806
3807 * bgp_term.c (term_parse): add command : show asstat, show ashash
3808 * bgp_aspath.c: aspath_cmp bug fix
3809 (aspath_print_all): add aspath_print_all ();
3810 * bgp_peer.h: delete rlist element from struct peer.
3811
38121997-08-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3813
3814 * bgp_aspath.c: completely rewritten.
3815 * bgp_aspath.h: completely rewritten.
3816 add AsPath, AsSegment structure
3817 add AS_SET treatment
3818 change Hash codes
3819
38201997-08-09 Kunihiro Ishiguro <kunihiro@zebra.org>
3821
3822 * bgp_attr.h: add Attribute flags defines
3823 * bgp_route.c: delete rlist related functions
3824 * bgp_aspath.c (as_origin): add as_origin function
3825 (aspath_print): move from bgp_dump.c and add support of AS_SET
3826 change Hash related function names.
3827
38281997-08-08 Kunihiro Ishiguro <kunihiro@zebra.org>
3829
3830 * bgp_aspath.h: add next entry, delete rlist entry from struct aspath
3831
38321997-08-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3833
3834 * bgp_aspath.c (as_sort): add function as_sort
3835 * bgp_aspath.h: add IBGP, EBGP
3836