blob: 35ffd69d4978e4f43dd1d8d9135fb0efa1902ffd [file] [log] [blame]
Paul Jakmabd34fb32007-02-26 17:14:48 +000012007-02-26 Paul Jakma <paul.jakma@sun.com>
2
3 * ospf_spf.c: Fix regression introduced with bug #330 fix: The
4 cost update added to ospf_spf_add_parent only handled PtP
5 case, differing from same functionality in higher-level
6 ospf_spf_next. Regression diagnosed by Anders Pedersen,
7 mailnews+router-quagga-dev@news.cohaesio.com.
8 (ospf_vertex_new) Initialise vertices to max-cost.
9 (ospf_spf_init) Root vertex always creates with 0 cost.
10 (ospf_spf_add_parent) Remove the buggy V->W cost calculating
11 code, instead take the new distance as a parameter.
12 (ospf_nexthop_calculation) Take distance as parameter, so it
13 can be passed down to add_parent.
14 (ospf_spf_next) Dont initialise candiate vertex distance,
15 vertex_new does so already. Pass distance down to
16 nexthop_calculation (see above).
17
Paul Jakmabc20c1a2007-01-24 14:51:51 +0000182007-01-24 Paul Jakma <paul.jakma@sun.com>
19
20 * ospf_spf.c: Bug #330: Nexthop calculation sometimes may fail,
21 and it needs to indicate this result to SPF.
22 (ospf_spf_add_parent) Flush of parent list needs to be done here,
23 for simplicity.
24 (ospf_nexthop_calculation) Caller needs to know whether
25 nexthop calculation succeeded. Every return statement must
26 correctly indicate such.
27 (ospf_spf_next) Queueing/prioritisation of vertices in SPF
28 must take into account whether nexthop_calculation succeeded,
29 or SPF may fail to find best paths.
30
Andrew J. Schorre4529632006-12-12 19:18:21 +0000312006-12-12 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
32
33 * ospf_interface.c: (ospf_if_is_configured, ospf_if_lookup_by_prefix,
34 ospf_if_lookup_recv_if) Simplify logic using new CONNECTED_PREFIX
35 macro.
36 * ospf_lsa.c: (lsa_link_ptop_set) Using the new CONNECTED_PREFIX
37 macro, both options collapse into the same code.
38 * ospf_snmp.c: (ospf_snmp_if_update) Simplify logic using new
39 CONNECTED_ID macro.
40 (ospf_snmp_is_if_have_addr) Simplify logic using new CONNECTED_PREFIX
41 macro.
42 * ospf_vty.c: (show_ip_ospf_interface_sub) Use new CONNECTED_PEER macro
43 instead of testing the IFF_POINTOPOINT flag.
44 * ospfd.c: (ospf_network_match_iface) Use new CONNECTED_PEER macro
45 instead of testing with if_is_pointopoint. And add commented-out
46 code to implement alternative (in my opinion) more elegant behavior
47 that has no special-case treatment for PtP addresses.
48 (ospf_network_run) Use new CONNECTED_ID macro to simplify logic.
49
Andrew J. Schorred589c12006-12-04 18:26:37 +0000502006-12-04 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
51
52 * ospfd.c: (ospf_network_run) Remove an offending 'break' statement.
53 Previously, after creating a single ospf_interface on a given
54 network interface, the code would skip to the next interface
55 without considering other connected addresses on the interface.
56 After removing the 'break', we now consider all connected addresses.
57
Andrew J. Schorr7f643eb2006-11-30 16:17:02 +0000582006-11-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
59
60 * ospf_zebra.c: (ospf_router_id_update_zebra,
61 ospf_interface_address_add, ospf_interface_address_delete)
62 If (IS_DEBUG_OSPF (zebra, ZEBRA_INTERFACE)) is enabled, then
63 add a debug message about what Zebra is telling us.
64 (ospf_zebra_add_discard) Add a debug message matching the one
65 already in ospf_zebra_delete_discard.
66
Andrew J. Schorr43540882006-11-28 16:36:39 +0000672006-11-28 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
68
69 * ospf_vty.c: (ospf_passive_interface_default) Take additional
70 'newval' arg so we can update ospf->passive_interface_default inside
71 this function. More importantly, we now call ospf_if_set_multicast
72 on all ospf_interfaces.
73 (ospf_passive_interface, no_ospf_passive_interface) Fix bug:
74 for 'default' case, argv[0] is undefined, so we must test for
75 (argc == 0) before using argv[0]. And since
76 ospf_passive_interface_default now calls ospf_if_set_multicast as
77 needed, we can just return after calling
78 ospf_passive_interface_default.
79
Andrew J. Schorr8fb8a502006-10-24 19:04:26 +0000802006-10-24 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
81
82 * ospf_zebra.c: (ospf_redistribute_default_set) Fix bug where
83 a new value for ospf->default_originate was being ignored
84 if a previous 'default-information originate' command
85 had already been processed.
86
Paul Jakma7ffa8fa2006-10-22 20:07:53 +0000872006-10-22 Yar Tikhiy <yar@comp.chem.msu.su>
88
89 * (general) Add support for passive-interface default (with
90 minor edits by Paul Jakma).
91 * ospf_interface.h: Add OSPF_IF_PASSIVE_STATUS macro, looking
92 at configured value, or the global 'default' value, as
93 required.
94 * ospf_interface.c: (ospf_if_new_hook) Leave passive
95 unconfigured per default, allowing global 'default' to
96 take effect for unconfigured interfaces.
97 * ospf_packet.c: (various) use OSPF_IF_PASSIVE_STATUS
98 * ospf_vty.c: (ospf_passive_interface_default) new function,
99 unset passive from all interfaces if default is enabled, as
100 the per-iface settings become redundant.
101 (ospf_passive_interface_update) new func, update passive
102 setting taking global default into account.
103 ({no,}ospf_passive_interface_addr_cmd) Add support for
104 'default' variant of command.
105 (show_ip_ospf_interface_sub) Update to take global
106 default into account when printing passive status.
107 (ospf_config_write) ditto.
108 * ospfd.c: (ospf_new) set global passive-interface default.
109 * ospfd.h: (struct ospf) Add field for global
110 passive-interface.
111
Andrew J. Schorr08c83672006-09-25 13:26:14 +00001122006-09-25 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
113
114 * ospf_packet.c: (ospf_packet_dup, ospf_make_md5_digest)
115 Fix zlog_warn messages to eliminate compiler warnings.
116 (ospf_hello) Improve warning messages to show why we
117 are complaining.
118
Paul Jakmab5aeb442006-08-30 18:47:37 +00001192006-08-28 Andy Gay <andy@andynet.net>
120
121 * ospf_packet.c: (ospf_make_db_desc) Assert added with More-bit
122 fixes does not hold up with addition of Ogier DB-Exchange
123 optimisation, which can empty the db-summary list in between
124 sent DD packets. Remove assert, update More-bit always when
125 in Exchange.
126
Paul Jakma29b5a042006-08-27 08:01:20 +00001272006-08-27 J.J. Krabbendam <jkrabbendam@aimsys.nl>
128
129 * ospfd.c: (ospf_finish_final) default redistribute should be
130 unset too, fixes bug where reconfiguring ospfd completely
131 can no longer enable default redistribution.
132
Paul Jakma2518efd2006-08-27 06:49:29 +00001332006-08-25 Paul Jakma <paul.jakma@sun.com>
134
135 * (general) Bug #134. Be more robust to backward time changes,
136 use the newly added libzebra time functions.
137 In most cases: recent_time -> recent_relative_time()
138 gettimeofday -> quagga_gettime (QUAGGA_CLK_MONOTONIC, ..)
139 time -> quagga_time.
140 (ospf_make_md5_digest) time() call deliberately not changed.
141 (ospf_external_lsa_refresh) remove useless gettimeofday, LSA
142 tv_orig time was already set in ospf_lsa_new, called via
143 ospf_external_lsa_new.
144
Paul Jakmaba122e72006-08-27 06:24:34 +00001452006-08-04 Paul Jakma <paul.jakma@sun.com>
146
147 * ospf_lsdb.c: (ospf_lsdb_delete_entry) new function, consolidate
148 exact same functionality replicated in other functions.
149 (ospf_lsdb_add) Strip out code by using ospf_lsdb_delete_entry.
150 (ospf_lsdb_delete) ditto.
151 (ospf_lsdb_delete_all) ditto.
152
Paul Jakma8dd24ee2006-08-27 06:29:30 +00001532006-08-03 Paul Jakma <paul.jakma@sun.com>
154
155 * ospf_packet.c: (ospf_make_db_desc) Unset the DD More bit
156 after constructing the packet, if appropriate.
157 (ospf_db_desc_proc) Speed up Exchange, slave should raise
158 ExchangeDone earlier, as RFC mandates, by forming its reply
159 before deciding whether both sides are done, avoids a
160 needless round of empty DD packet exchanges at the end of
161 Exchange, hence speeding up ExchangeDone.
Paul Jakmaf0894cf2006-08-27 06:40:04 +0000162 Implement draft-ogier-ospf-dbex-opt DB-exchange optimisation.
Paul Jakma8dd24ee2006-08-27 06:29:30 +0000163 (ospf_db_desc) use UNSET_FLAG macro.
164
Andrew J. Schorr16700082006-07-27 22:29:06 +00001652006-07-27 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
166
167 * ospfd.c: (ospf_router_id_update) Fix and document the algorithm for
168 selecting the router ID: if there is not a statically configured ID,
169 then stick to the most recent value to avoid disruptive changes.
170 This should fix bug #288.
171
Paul Jakma1fe6ed32006-07-26 09:37:26 +00001722006-07-26 Paul Jakma <paul.jakma@sun.com>
173
174 * ospf_lsa.{c,h}: (ospf_lsa_unlock) Change to take a double pointer
175 to the LSA to be 'unlocked', so that, if the LSA is freed, the
176 callers pointer to the LSA can be NULLed out, allowing any further
177 use of that pointer to provoke a crash sooner rather than later.
178 * ospf_*.c: (general) Adjust callers of ospf_lsa_unlock to match
179 previous. Try annotate 'locking' somewhat to show which 'locks'
180 are protecting what LSA reference, if not obvious.
181 * ospf_opaque.c: (ospf_opaque_lsa_install) Trivial: remove useless
182 goto, replace with return.
183 * ospf_packet.c: (ospf_make_ls_ack) Trivial: merge two list loops,
184 the dual-loop predated the delete-safe list-loop macro.
185
Paul Jakma3fed4162006-07-25 20:44:12 +00001862006-07-25 Paul Jakma <paul.jakma@sun.com>
187
188 * ospf_neigbor.h: (struct ospf_neighbor) Add some additional
189 neighbour state statistics fields, timestamps for progressive
190 and regressive state changes, and pointer to event string
191 for the latter state change.
192 * ospf_nsm.c: (nsm_notice_state_change) Update new state changs
193 history as required.
194 * ospf_vty.c: (show_ip_ospf_neighbor_detail_sub) Print out above
195 new per-neighbour state change stats.
196
Paul Jakma539e1522006-07-11 17:49:22 +00001972006-07-10 Paul Jakma <paul.jakma@sun.com>
198
199 * ospf_nsm.c: (nsm_change_state) call nsm_clear_adj for all
200 adjacency losses, hence removing need for nsm_reset_nbr.
201 (nsm_reset_nbr) kill it, clear_adj in previous does fine.
202 (nsm_kill_nbr,nsm_start) remove nsm_reset_nbr call.
203 (ospf_nsm_event) Allow NSM function to be NULL, this along with
204 removal of nsm_reset_nbr, allows a bunch of now useless functiosn
205 to be removed.
206 Remove some useless variables.
207 (nsm_ignore) now useless, remove.
208 (nsm_bad_ls_req) ditto
209 (nsm_seq_number_mismatch) "
210 (nsm_oneway_received) "
211 (nsm_inactivity_timer) "
212 (nsm_ll_down) "
213 (NSM) replace removed action functions with NULL.
Paul Jakma3d63f382006-07-11 17:52:53 +0000214 (nsm_notice_state_changes) Move state change logging code to new
215 func to declutter nsm_change_state and ospf_nsm_event.
216 Log event with AdjChange, it's useful to know.
217 (nsm_change_state) move adjchange and snmp logging to previous.
218 (ospf_nsm_event) call nsm_notice_state_changes from here.
219 Move the debug message to entry of function, so it gets out
220 even if something goes wrong.
Paul Jakma90c33172006-07-11 17:57:25 +0000221 Record state change timestamp and event in nbr struct.
222 * ospf_neighbor.h: (struct ospf_neighbor) Add fields to record
223 timestamp of last NSM change and event.
224 * ospf_vty.c: (show_ip_ospf_neighbor_detail_sub) Print
225 last state change timestamp and event, if available.
Paul Jakma539e1522006-07-11 17:49:22 +0000226
Andrew J. Schorr13cd3dc2006-07-11 01:50:30 +00002272006-07-10 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
228
229 * ospf_packet.c: (ospf_hello) Improve NetworkMask mismatch warning
230 message to include interface name and conflicting prefix lengths.
231
Paul Jakma1f2c2742006-07-10 07:45:13 +00002322006-07-07 Paul Jakma <paul.jakma@sun.com>
233
234 * ospf_nsm.h: Add a NSM_Deleted neighbour state, to act as dummy
235 state indicating the neighbour is to be deleted.
236 * ospf_nsm.c: (general) Use the NSM_Deleted state to delete
237 neighbours, thus allowing code to be slightly more obvious
238 in its flow.
239 (nsm_timer_set) Add NSM_Deleted. Add another timer the code
240 missed.
241 (nsm_kill_nbr) No need for special case call to nsm_change_state
242 anymore.
243 Make the assert and error-handling for same case more readable
244 (Andrew Schorr)
245 Remove the call to ospf_nbr_delete, nsm_change_state can do
246 this generally now via NSM_Deleted.
247 (struct ... NSM) Add the dummy NSM_Deleted state, the 3 events
248 that can lead to nsm_kill_nbr all now transition the NBR to
249 NSM_Deleted and the general change_state function can be left
250 to do the work.
251 (ospf_nsm_event) Special casing of events and early-return can
252 be removed now.
253 On transition into Deleted, delete the nbr.
254 * ospf_dump.c: (ospf_nsm_state_msg) Add Deleted.
255
Paul Jakmaaa2737a2006-07-06 11:12:39 +00002562006-07-06 Paul Jakma <paul.jakma@sun.com>
257
258 * ospf_nsm.c: (ospf_nsm_event) LLDown event also results in nbr
259 being deleted, requires early-return too. Likely explains
260 some crash reports after interface events.
261
Paul Jakmaf7a76ab2006-07-04 13:57:49 +00002622006-07-04 Paul Jakma <paul.jakma@sun.com>
263
264 * ospf_nsm.c: (general) Various small cleanups from Andrew's
265 review of last set of patches.
266 (nsm_timer_set) Loading, Full and default can share
267 same code too.
268 (nsm_should_adj) Can just be one big OR.
269 (nsm_twoway_received) Collapse into return statement.
270
Paul Jakmad7b0fb62006-07-04 13:35:24 +00002712006-07-02 Paul Jakma <paul.jakma@sun.com>
272
273 * ospf_nsm.c: (nsm_should_adj) New function, just consolidate the
274 10.4 adjacency check from nsm_twoway_received/nsm_adj_ok.
275 (nsm_twoway_received/nsm_adj_ok) Use former.
Paul Jakmad1b1cd82006-07-04 13:50:44 +0000276 (nsm_clear_adj) clear adjacency related state for a
277 neighbour, needed for some state changes from > ExStart down
278 to ExStart or less, which need not go through nsm_reset_nbr.
279 (nsm_reset_nbr) move code to former. Should be static.
Paul Jakmaba0beb42006-07-04 13:44:19 +0000280 (ospf_nsm_event) Don't allow action functions to change
281 next_state if the NSM tables do not indicate next_state is
282 conditional, log warning if one tries - existing code
283 appears fine though.
Paul Jakmad1b1cd82006-07-04 13:50:44 +0000284 Remove long dead code.
285 Use nsm_clear_adj for state changes that take down
286 adjacencies to TwoWay/ExStart.
Paul Jakmae55dd532006-07-04 13:46:14 +0000287 (nsm_timer_set) ls_req timer should be OFF in early states.
288 Compact several identical sections.
289 Set inactivity timer to OFF for Down, for documentary
290 purposes.
Paul Jakmad1b1cd82006-07-04 13:50:44 +0000291 (nsm_kill_nbr) Oops, action function shouldn't try return
292 1 for error.
Paul Jakma5db95bc2006-07-04 13:52:29 +0000293 * ospf_lsa.c: (ospf_translated_nssa_refresh) CID #13.
Paul Jakmad7b0fb62006-07-04 13:35:24 +0000294
Andrew J. Schorr1c066bf2006-06-30 16:53:47 +00002952006-06-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
296
297 * ospf_vty.c: (show_ip_ospf_neighbor_id) Should show all instances
298 of that neighbor (since it may appear on multiple interfaces)
299 instead of bailing out after showing the first match.
300
Andrew J. Schorr76947872006-06-30 03:21:05 +00003012006-06-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
302
303 * ospf_nsm.c: (nsm_twoway_received) When deciding whether to
304 change from state Init to ExStart, the test for whether the
305 neighboring router is DR or BDR should be against the
306 local router's notion of DR/BDR, not the neighbor's view.
307
Andrew J. Schorrd7e60dd2006-06-29 20:20:52 +00003082006-06-28 Erik Muller <erikm@internap.com>
309
310 * ospfd.h: Define 2 new struct ospf config flags:
311 OSPF_LOG_ADJACENCY_CHANGES and OSPF_LOG_ADJACENCY_DETAIL
312 * ospf_nsm.c (nsm_change_state): Log adjacency changes if
313 requested.
314 * ospf_vty.c (ospf_log_adjacency_changes): New command function
315 to implement ospf subcommand "log-adjacency-changes [detail]".
316 (no_ospf_log_adjacency_changes) Turn off log-adjacency-changes.
317 (show_ip_ospf) Show whether adjacency changes are logged.
318 (ospf_config_write) Add "log-adjacency-changes [detail]" to config.
319 (ospf_vty_init) Add ospf_log_adjacency_changes and
320 no_ospf_log_adjacency_changes.
321
Paul Jakma9560fa82006-06-26 12:50:06 +00003222006-06-26 Paul Jakma <paul.jakma@sun.com>
323
324 * ospf_abr.c: (general) NSSA translate-candidate ABRs need to
325 be ASBRs, or other routers may rightfully refuse to install
326 translated type-5s LSAs. reported by dendroot@gmail.com.
327 (ospf_abr_nssa_check_status) Detect change in translator
328 state when ABR, and inc/dec redistribute count as when we
329 leave/enter the disabled state - so that translate-enabled
330 ABR properly sets ASBR bit on non-NSSA areas.
331 Run the resulting function through indent to clean it up.
332 * ospf_lsa.c: (router_lsa_flags) For purposes of ASBR bit,
333 NSSA area is same as stub area.
334
Andrew J. Schorr0ffb7092006-06-24 19:40:13 +00003352006-06-24 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
336
Andrew J. Schorr9aecfae2006-06-24 20:05:02 +0000337 * ospf_snmp.c: (ospfTrapNbrStateChange, ospfTrapIfStateChange) Improve
338 info log message to indicate why the trap is being sent.
339
3402006-06-24 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
341
Andrew J. Schorr0ffb7092006-06-24 19:40:13 +0000342 * ospf_dump.c: (config_write_debug) Fix typo to show debug ospf nsm
343 status properly (not ism status).
344
Andrew J. Schorr6e72cb62006-06-18 00:45:48 +00003452006-06-17 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
346
347 * ospf_vty.c: ({no_,}ospf_passive_interface) Replace if_lookup_by_name
348 with a call to if_get_by_name -- if the interface does not exist
349 already, it should be created. And remove the obsolete warning
350 message.
351
Paul Jakma429ac782006-06-15 18:40:49 +00003522006-06-15 Paul Jakma <paul.jakma@sun.com>
353
354 * ospf_interface.h: (struct ospf_if_info) Add reference counts
355 for multicast group memberships. Add various macros to help
356 manipulate/check membership state.
357 * ospf_interface.c: (ospf_if_set_multicast) Maintain the
358 ospf_if_info reference counts, and only actually drop
359 memberships if it hits 0, to avoid losing membership when
360 OSPF is disabled on an interface with multiple active OSPF
361 interfaces.
362 * ospf_packet.c: (ospf_{hello,read}) Use the new macros to
363 check/set
364 multicast membership.
365 * ospf_vty.c: (show_ip_ospf_interface_sub) ditto.
366
Paul Jakmaac904de2006-06-15 12:04:57 +00003672006-05-31 Paul Jakma <paul.jakma@sun.com>
368
369 * ospf_lsdb.c: (ospf_lsdb_delete) robustify against NULL arguments,
370 print warning.
371 * ospf_lsa.c: (ospf_discard_from_db) ditto.
372 (ospf_maxage_lsa_remover) Check lsa->lsdb for validity, possible
373 mitigation (but not solution) for bug #269.
374
Paul Jakma88871b12006-06-15 11:41:19 +00003752006-05-30 Paul Jakma <paul.jakma@sun.com>
376
377 * ospf_packet.c: (ospf_read) Debug message about packets
378 received on unenabled interfaces should be conditional on
379 debug being set.
380
Paul Jakmad1c65c22006-06-27 08:01:43 +00003812006-05-23 Paul Jakma <paul.jakma@sun.com>
382
383 * ospf_vty.c: (general) Replace in-place route redistribution
384 command and help strings with the new auto-generated defines
385 from lib/route_types.h
386
Paul Jakmaae128052006-05-12 23:15:30 +00003872006-05-13 Paul Jakma <paul.jakma@sun.com>
388
389 * ospf_lsa.c: (ospf_translated_nssa_refresh) fix the sanity
390 check to match the assert, small error in CID #13 fix.
391
Paul Jakma70461d72006-05-12 22:57:57 +00003922006-05-12 Paul Jakma <paul.jakma@sun.com>
393
394 * ospf_lsa.c: (ospf_lsa_action) Get rid of the ospf_lookup
395 call, which is not checked for NULL return, by stripping out
396 functionality which is never used, hence fixing Coverity CID
397 #29.
398 (struct lsa_action) remove unused member.
Paul Jakmae54e6e52006-05-12 23:11:14 +0000399 (ospf_translated_nssa_refresh) Add non-assert sanity check,
400 in case DEBUG isn't defined.
401 Debug message when no type7 exists should print the ID from
402 the type5, not the type7, fixes CID #13.
403 * ospf_interface.c: (ospf_if_exists) Fix missing NULL return
Paul Jakmae43be0e2006-05-12 23:00:06 +0000404 check on ospf_lookup, CID #27.
Paul Jakma6db3a6f2006-05-12 23:02:46 +0000405 * ospf_asbr.c: (ospf_redistribute_withdraw) remove ospf_lookup
406 call by taking the struct ospf * as argument, which the
407 caller has, fixing CID #28.
408 * ospf_asbr.h: (ospf_redistribute_withdraw) update declaration
409 * ospf_zebra.c: (ospf_redistribute_unset) update call to
410 ospf_redistribute_withdraw to match.
Paul Jakmabfd7c7d2006-05-12 23:04:45 +0000411 * ospf_ia.c: (ospf_update_router_route) ospf->backbone could be
412 NULL when passed to ospf_find_asbr_route_through_area,
413 check for NULL first, CID #14.
Paul Jakmadeb15612006-05-12 23:07:27 +0000414 * ospf_ism.c: (ism_change_state) NULL check on oi->area is
415 useless, it's always valid. Only possibility where it
416 couldn't be is if there is a race between abr_task and
417 cleaning up oi's, in which case a NULL check here isn't going
418 to do anything. Fixes CID #15.
Paul Jakma70461d72006-05-12 22:57:57 +0000419
Paul Jakmacac3b5c2006-05-11 13:31:11 +00004202006-05-11 Paul Jakma <paul.jakma@sun.com>
421
422 * ospf_vty.c: (general) Audit ospf_lookup calls in commands,
423 ensure check for NULL result, make vty messages consistent.
424 (show_ip_ospf_interface) Missing NULL check on ospf_lookup
425 result, fixes Coverity CID #70.
Paul Jakma1a8ec2b2006-05-11 13:34:08 +0000426 (no_ospf_area_filter_list) Check NULL result from
427 ospf_area_lookup_by_area_id, fixes Coverity CID #69
Paul Jakma894f8b62006-05-12 22:50:40 +0000428 * ospf_route.c: (ospf_route_delete_same_ext) Fix deref before
429 NULL check by moving into check-protected block, fix CID #49.
Paul Jakma214a4452006-05-12 22:51:49 +0000430 * ospf_abr.c: (ospf_area_range_cost_set) Shouldn't create a new
431 range, should just lookup to see if one exists, the new range
432 is just leaked. Fixes CID #46.
Paul Jakma4021b602006-05-12 22:55:41 +0000433 * ospf_lsa.c: (ospf_default_originate_timer) Let the thread
434 take (struct ospf *) as thread argument, rather than (struct
435 ospf *)->default_originate, thus avoiding having to call
436 ospf_lookup.
437 * ospf_zebra.c: (ospf_redistribute_default_set) change setup
438 of ospf_default_originate_timer thread to match.
439 * ospfd.c: (ospf_router_id_update) ditto.
Paul Jakmacac3b5c2006-05-11 13:31:11 +0000440
Paul Jakma9c27ef92006-05-04 07:32:57 +00004412006-04-24 Paul Jakma <paul.jakma@sun.com>
442
443 * (general) More Virtual-link fixes, again with much help in
444 testing / debug from Juergen Kammer. Primarily in SPF.
445 * ospf_spf.h: Add guard. ospf_interface.h will include this
446 header.
447 * ospf_interface.h: Modify ospf_vl_lookup definition to take
448 struct ospf as argument, so as to allow for NULL area
449 argument.
450 (struct ospf_vl_data) Remove out_oi, instead add a struct
451 vertex_nexthop, to use as initial nexthop for backbone paths
452 through a vlink.
453 * ospf_interface.c: (ospf_vl_lookup) Modified to allow
454 NULL area to be passed to indicate "any" (first) area.
455 Add extra debug.
456 (ospf_vl_set_params) vl_oi -> nexthop. Add extra debug.
457 (ospf_vl_up_check) Fix debug, inet_ntoa returns a static
458 buffer..
459 * ospf_route.c: (ospf_intra_add_router) Vlinks dont go through
460 backbone, don't bother checking.
461 * ospf_spf.c: (static struct list vertex_list) Record vertices
462 that will need to be freed.
463 (cmp) Order network before router vertices, as required,
464 wasn't implemented.
465 (vertex_nexthop_free) Mild additional robustness check.
466 (vertex_parent_free) Take void argument, as this function
467 is passed as list deconstructor for vertex parent list.
468 (ospf_vertex_new) More debug. Set deconstructor for parent
469 list. Track allocated vertices on the vertex_list.
470 (ospf_vertex_free) Get rid of the tricky recursive cleanup of
471 vertices. Now frees only the given vertex.
472 (ospf_vertex_add_parent) Fix assert.
473 (ospf_nexthop_calculation) Fix calculation of nexthop for
474 VLink vertices, lookup the vl_data and use its previously
475 recorded nexthop information.
476 (ospf_spf_calculate) Vertices are freed simply by deleting
477 vertex_list nodes and letting ospf_vertex_free as deconstructor
478 work per-node.
479 (ospf_spf_calculate_timer) Trivial optimisation, leave
480 backbone SPF calculation till last to reduce SPF churn on
481 VLink updates.
482 * ospf_vty.c: (ospf_find_vl_data) update call to ospf_vl_lookup
483 (no_ospf_area_vlink_cmd) ditto.
484 (show_ip_ospf_interface_sub) For Vlinks, the peer address is
485 more interesting than the output interface.
486
Paul Jakma478aab92006-04-03 21:25:32 +00004872006-04-03 Paul Jakma <paul.jakma@sun.com>
488
489 * (general) Fix issues with handling of Vlinks and entries
490 in the nbrs route-table which were highlighted by the
491 nsm/nbr_self fixes from bug #234. Many thanks to Juergen
492 Kammer for his help and efforts in testing out debug patches to
493 pinpoint the issue.
494 * ospf_interface.c: (ospf_vl_new) Add nbr_self for Vlink.
495 * ospf_neighbor.c: (ospf_nbr_key) new static function, helper
496 to create key in nbrs table for a given nbr.
497 (ospf_nbr_delete) Use ospf_nbr_key. Add an assert() to
498 document an expected state.
499 (ospf_nbr_add_self) Ditto.
500 (ospf_nbr_lookup_by_addr) Add an assert.
501 * ospf_nsm.c: (nsm_kill_nbr) Can never kill the nbr_self
502 psuedo-neighbour.
503
Paul Jakma075c2012006-03-30 14:34:31 +00005042006-03-27 Paul Jakma <paul.jakma@sun.com>
505
506 * ospf_lsa.c: (ospf_lsa_checksum) Add an explicit cast to avoid
507 the ambiguities of ANSI and C99 C with respect to type
508 conversion. Detailed problem report and test case with
509 example data supplied by Dmitry Ivanov <dimss@telecentrs.lv>.
510
Paul Jakma1a8ee0e2006-03-30 14:20:00 +00005112006-03-25 Paul Jakma <paul.jakma@sun.com>
512
513 * ospf_interface.c: (ospf_if_lookup_recv_if) Ignore loopbacks,
514 we can never ever receive packets on those. Should fix
515 case where CARP is run with address in same subnet as real
516 interface. Problem report and diagnosis thanks to:
517 Landon Fuller <landonf@opendarwin.org>.
518 However, ospf_read() still can't deal deterministically with
519 multiple interfaces in same subnet.
520
Paul Jakmac2b478d2006-03-30 14:16:11 +00005212006-03-23 Steve Lawson <steve.lawson@aheadcomusa.com>
522
523 * ospf_lsa.c: (ospf_lsa_install) Fix incorrect byte-order
524 conversion of OSPF_MAX_SEQUENCE_NUMBER
525
paule8e19462006-01-19 20:16:55 +00005262006-01-19 Paul Jakma <paul.jakma@sun.com>
527
528 * (general) various miscellaneous compiler warning fixes.
529 Remove redundant break statements from switch clauses
530 which return.
531 return from main, not exit, cause it annoys SOS.
532 Remove stray semi-colons which cause empty-statement
533 warnings.
534
paul779adb02006-01-18 15:07:38 +00005352006-01-18 Juergen Kammer <j.kammer@eurodata.de>
536
537 * ospf_lsa.c: (ospf_router_lsa_new) dont take reference to the
538 stream data until it is constructed, data reference is
539 volatile due to the potential resize in link_info_set
540
5412006-01-18 Paul Jakma <paul.jakma@sun.com>
542
543 * ospf_lsa.c: (link_info_set) Resize the stream if required and
544 possible. Return number of links added.
545 (lsa_link_*_set) use return value from previous.
546 * ospf_lsa.h: Add OSPF_ROUTER_LSA_LINK_SIZE define.
547
paulc6371712006-01-17 17:49:53 +00005482006-01-17 Paul Jakma <paul.jakma@sun.com>
549
550 * ospf_packet.c: (ospf_verify_header) print out the types
551 involved if there's a mismatch.
552 * ospf_zebra.c: (ospf_zebra_add) Adjust to new zserv format.
553
paul818e56c2006-01-10 23:27:05 +00005542006-01-10 Len Sorensen <lennartsorensen@ruggedcom.com>
555
556 * (general) Bug #234, see also [quagga-dev 3902].
557 Fix problem with nbr_self not being properly reinitialised
558 when an interface comes up, after having been down.
paul1a643f82006-01-11 01:08:19 +0000559 Some re-arrangement done by Paul Jakma, any bugs introduced
560 on top of Len's suggested changes are his.
paul818e56c2006-01-10 23:27:05 +0000561 * ospf_neighbor.c: (ospf_nbr_add_self) centralise
562 initialisation of nbr_self parameters here.
563 * ospf_interface.c: (ospf_if_new) deleting initialisation of
564 parameters of nbr_self, just rely on call to
565 ospf_nbr_add_self.
566 (ospf_if_cleanup) ditto.
567 * ospfd.c: (ospf_network_run) ditto.
568
paul98429f62006-01-10 22:11:54 +00005692006-01-10 Juris Kalnins <juris@mt.lv>
570
571 * ospf_zebra.c: (ospf_interface_address_delete) fix rare leak of
572 struct connected in an error case.
paul818e56c2006-01-10 23:27:05 +0000573 * ospf_packet.c: (ospf_make_md5_digest) fix odd, if not
574 undefined effect, assignment of an increment expression.
paul98429f62006-01-10 22:11:54 +0000575
paul86752842006-01-10 20:34:46 +00005762006-01-10 Paul Jakma <paul.jakma@sun.com>
577
578 * ospfd.c: (ospf_network_run) checking to see if router-id
579 is set should be on ospf->router_id, not router_id_static.
580 This was causing ospfd to not start if router-id had not
581 been configured statically.
582 (ospf_if_update) ditto.
paulc42c1772006-01-10 20:36:49 +0000583 * ospf_vty.c: (config_write_ospf_distribute) trim down
584 redundant strings.
paul86752842006-01-10 20:34:46 +0000585
paul00c290e2005-11-26 09:21:43 +00005862005-11-26 Paul Jakma <paul.jakma@sun.com>
587
588 * ospf_api.c: (struct opaque_lsa) change from gcc zero-length
589 array to C99 incomplete type array.
paulc9c93d52005-11-26 13:31:11 +0000590 * (general) s/graceful/deferred/ in all files, the former term
591 is confusing wrt OSPF Graceful-Restart.
592 * ospfd.c: (ospf_deferred_shutdown_check) dont return
593 a function which returns void. SOS complains about this.
594 (ospf_finish)
paul00c290e2005-11-26 09:21:43 +0000595
paulb29800a2005-11-20 14:50:45 +00005962005-11-20 Paul Jakma <paul.jakma@sun.com>
597
598 * ospfd.h: remove the OSPF_ROUTER_ID_UPDATE_DELAY define
599 (struct ospf) remove the router_id timer thread.
600 remove export of ospf_router_id_update_timer.
601 * ospfd.c: (ospf_router_id_update) call ospf_if_update to
602 poke interfaces into action after ID has been configured.
603 (ospf_router_id_update_timer) removed.
604 (ospf_finish_final) t_router_id_update timer is gone.
605 (ospf_network_run) router-id update timer gone.
606 call ospf_router_id_update directly if ID not configured.
607 In the per-iface loop, don't ospf_if_up interfaces if
608 ID is still not configured. The update function will call
609 ospf_if_update anyway.
610 (ospf_if_update) ID update timer is gone. Just return if no
611 ID is set.
612 * ospf_vty.c: (ospf_router_id) call ospf_router_id_update, no
613 timer needed.
614 * ospf_zebra.c: (ospf_router_id_update_zebra) call
615 ospf_router_id_update directly, not via timer.
paulc24d6022005-11-20 14:54:12 +0000616 * ospf_abr.c: (ospf_abr_announce_network_to_area) check
617 returned LSA of ospf_summary_lsa_refresh and print warning if
618 it failed.
619 (ospf_abr_announce_network_to_area) similar
620 (ospf_abr_announce_rtr_to_area) similar
621 * ospf_lsa.c: (ospf_router_lsa_new) check LSA returned is valid.
622 (ospf_router_lsa_originate) similar
623 (ospf_router_lsa_refresh, ospf_network_lsa_new) similar
624 (ospf_summary_lsa_new) Check ID is valid.
625 (ospf_summary_lsa_originate) ditto, and check returned LSA from
626 previous function is !NULL.
627 (ospf_summary_lsa_refresh) check ospf_summary_lsa_new return
628 is !NULL.
629 (ospf_summary_asbr_lsa_new) ID valid check.
630 (ospf_summary_asbr_lsa_originate) similar.
paulb29800a2005-11-20 14:50:45 +0000631
ajs70cd3472005-11-16 19:33:22 +00006322005-11-16 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
633
ajs649654a2005-11-16 20:17:52 +0000634 * ospf_dump.h: Define OSPF_TIME_DUMP_SIZE as appropriate buffer size
635 for use with ospf_timer_dump and ospf_timeval_dump.
636 * ospf_vty.c: Change all buffer sizes used with ospf_timer_dump and
637 ospf_timeval_dump to have size OSPF_TIME_DUMP_SIZE.
638 (show_ip_ospf_interface_sub) Fix possible buffer overflow in
639 call to ospf_timer_dump.
640
6412005-11-16 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
642
ajs70cd3472005-11-16 19:33:22 +0000643 * ospf_ism.h: (OSPF_ISM_TIMER_OFF) Improve macro syntax by enclosing
644 in 'do {...} while(0)'.
645
paul31a59762005-11-14 11:11:11 +00006462005-11-14 Paul Jakma <paul.jakma@sun.com>
647
648 * ospfd.c: (ospf_new) stub-shutdown should just default to
649 unconfigured, too strange otherwise.
650 (ospf_finish_final) t_opaque_lsa_self TIMER_OFF should be
651 preprocessor conditional on HAVE_OPAQUE_LSA.
652 * ospfd.h: (struct ospf) remove the SHUTDOWN_DEFAULT define.
653 no longer used, plus it wasn't in range that the command
654 accepted.
655 * ospf_zebra.h: Depends on vty.h, include it.
656
paul58e1bef2005-11-11 12:10:03 +00006572005-11-11 Paul Jakma <paul.jakma@sun.com>
658
659 * ospf_spf.c: (ospf_canonical_nexthops_free) Free only
660 the nexthops pointing to the root vertex. We may visit a
661 vertex twice or the vertex may have some inherited nexthops,
662 if we free other nexthops we could crash.
663
paulc8c15212005-11-04 12:31:39 +00006642005-11-04 Paul Jakma <paul.jakma@sun.com>
665
666 * ospf_{dump,spf,vty}.c: Oops, use the internal tv_sub
667 function rather than unportable timersub.
668
paul484315f2005-11-03 09:08:29 +00006692005-11-03 Paul Jakma <paul.jakma@sun.com>
670
671 * ospf_apiserver.c: (apiserver_sync_callback) stray semi-colon
672 * ospf_packet.c: include checksum.h, remove the in_cksum extern
673 * prototypes.
674 * ospf_te.h: Add braces, quell warning.
paul6d452762005-11-03 11:15:44 +0000675 * ospf_packet.c: Change level of some warnings to
676 informational.
paulc8c15212005-11-04 12:31:39 +0000677
paul88d6cf32005-10-29 12:50:09 +00006782005-10-29 Paul Jakma <paul.jakma@sun.com>
679
680 * (general) RFC3137 stub-router support
681 * ospfd.h: Add OSPF_OUTPUT_COST_INFINITE define.
682 (struct ospf_master) Add a OSPF_MASTER_SHUTDOWN flag for
683 options, to allow shutdown to distinguish between complete
684 shutdown and shutdown of a subset of ospf instances.
685 (struct ospf)
686 Add stub_router_{startup,shutdown_}time, configuration of startup
687 and shutdown time for stub-router.
688 Add t_graceful_shutdown struct thread, timer for graceful
689 shutdown, if needed.
690 (struct ospf_area) Add stub_router_state - run time state of
691 stub-router for an area. Add flags for ADMIN, IS and WAS
692 states.
693 Add t_stub_router, timer thread to resend router-lsa for an
694 area.
695 * ospf_lsa.c: (ospf_link_cost) new simple function to spit out
696 either the given lnks cost or infinite cost if stub-router is
697 in effect.
698 (lsa_link_{ptop,broadcast,virtuallink,ptomp}_set) use
699 previous function for transit-links.
700 (ospf_stub_router_timer) timer thread for end of startup stub
701 router. Change state as required for the area and setup
702 re-origination of router-lsa.
703 (ospf_stub_router_check) Check/do whether stub-router should be
704 enabled, and whether it requires timer to be setup.
705 (ospf_router_lsa_new) call previous function at top.
706 (ospf_router_lsa_originate) no external callers, made static.
707 * ospf_lsa.h: (ospf_router_lsa_originate) removed.
708 * ospf_main.c: (sigint) make static.
709 remove call to exit, as ospf_terminate now deals with
710 exiting.
711 * ospf_route.c: (ospf_terminate) removed, now in ospfd.c.
712 * ospf_vty.c: (show_ip_ospf_area) print out state of
713 stub-router, if active.
714 (show_ip_ospf) print out configuration of stub-router
715 support, and details of graceful-shutdown if the timer is
716 active.
717 ((no)?ospf_max_metric_router_lsa_{admin,startup,shutdown}) new
718 commands to (de-)?configure stub-router support.
719 (config_write_stub_router) write out config of stub-router.
720 (ospf_config_write) call previous.
721 (ospf_vty_init) install the new stub-router commands.
722 * ospfd.c: various functions made static.
723 (ospf_new) Set defaults for stub-router. Graceful shutdown
724 is made to default on, just to be adventerous.
725 (ospf_graceful_shutdown_finish) new function, final part of
726 shutdown.
727 (ospf_graceful_shutdown_timer) timer thread wrapper for
728 graceful-shutdown.
729 (ospf_graceful_shutdown_check) check whether to setup timer
730 for shutdown or proceed directly to final shutdown.
731 (ospf_terminate) moved here from ospf_route.c, call
732 ospf_finish for each instance.
733 (ospf_finish) renamed to ospf_finish_final and made static.
734 (ospf_finish) new function, exported wrapper around
735 ospf_graceful_shutdown_check.
736 (ospf_finish_final) complete shutdown of an instance.
737 Add missing TIMER_OFF's of two timer threads.
738 (ospf_area_free) opaque self lsa timer should be turned off.
739
paulb8ad39d2005-10-23 15:23:05 +00007402005-10-23 Paul Jakma <paul.jakma@sun.com>
741
paule029d442005-10-23 15:26:24 +0000742 * ospf_apiserver.c: (ospf_apiserver_term) This function should
743 not have side-effects (eg segv) if no apiserver instances are
744 active, ie be robust.
paulb8ad39d2005-10-23 15:23:05 +0000745 * ospf_vty.c: (show_ip_ospf) fix display of SPF timer if it
746 has not yet been run.
747
paulf9ad9372005-10-21 00:45:17 +00007482005-10-21 Paul Jakma <paul.jakma@sun.com>
749
paulea4ffc92005-10-21 20:04:41 +0000750 * ospf_dump.c: (ospf_timeval_dump) fix ms adjustment, thanks to
751 Andrew Schorr.
752 * ospf_vty.c: (ospf_config_write) fix write out of spf timers
753 configuration.
754
7552005-10-21 Paul Jakma <paul.jakma@sun.com>
756
pauld24f6e22005-10-21 09:23:12 +0000757 * (general) SPF millisecond resolution timer with adaptive,
758 linear back-off holdtime. Prettification of ospf_timer_dump.
759 * ospf_dump.c: (ospf_timeval_dump) new function. The guts of
760 ospf_timer_dump, but made to be more dynamic in printing out
761 the relative timeval, sliding the precision printed out
762 according to the value.
763 (ospf_timer_dump) guts moved to ospf_timeval_dump.
764 * ospf_dump.h: export ospf_timeval_dump.
765 * ospf_flood.c: (ospf_flood) remove gettimeofday, use
766 the libzebra exported recent_time instead, as it's not
767 terribly critical to have time exactly right - the dropped
768 LSA will be retransmited to us if we don't ACK it.
769 * ospf_packet.c: (ospf_ls_upd_timer) Ditto, but here we're
770 not transmitting, just putting LSA back on update transmit list.
771 * ospfd.h: delay and holdtimes should be unsigned.
772 Add spf_max_holdtime and spf_hold_multiplier.
773 Update default defines for delay and hold time to be in msec.
774 (struct ospf) change the SPF timestamp to a struct timeval.
775 Remove ospf_timers_spf_(un)?set.
776 * ospfd.c: (ospf_timers_spf_{set,unset}) removed.
777 (ospf_new) initialise spf_max_holdtime and spf_hold_multiplier
778 * ospf_spf.c: (ospf_spf_calculate) SPF timestamp is a timeval
779 now, update with gettimeofday.
780 (ospf_spf_calculate_schedule) Change SPF timers to millisecond
781 resolution.
782 Make the holdtime be adaptive, with a linear increase in
783 holdtime ever consecutive SPF run which occurs within holdtime
784 of previous SPF, bounded by spf_max_holdtime.
785 * ospf_vty.c: Update spf timers commands.
786 (ospf_timers_spf_set) trivial helper.
787 (ospf_timers_throttle_spf_cmd) new command to set SPF delay,
788 initial hold and max hold times with millisecond resolution.
789 (ospf_timers_spf_cmd) Deprecated. Accept the old values,
790 convert to msec, truncate to new limits.
791 (no_ospf_timers_throttle_spf_cmd) set timers to defaults.
792 (no_ospf_timers_spf_cmd) deprecated form, same as previous.
793 (show_ip_ospf_cmd) Display SPF parameters and times.
794 (show_ip_ospf_neighbour_header) Centralise the 'sh ip os ne'
795 header.
796 (show_ip_ospf_neighbor_sub) Fix the field widths. Get rid of
797 the multiple spaces which were making the lines even longer.
798 (show_ip_ospf_neighbor_cmd) Use show_ip_ospf_neighbour_header
799 (show_ip_ospf_neighbor_all_cmd) ditto and fix the field
800 widths for NBMA neighbours.
801 (show_ip_ospf_neighbor_int) Use header function.
802 (show_ip_ospf_nbr_nbma_detail_sub) use sizeof for timebuf,
803 local array - safer.
804 (show_ip_ospf_neighbor_detail_sub) ditto
805 (ospf_vty_init) install the new SPF throttle timer commands.
806
8072005-10-21 Paul Jakma <paul.jakma@sun.com>
808
paulf9ad9372005-10-21 00:45:17 +0000809 * (general) OSPF fast, sub-second hello and 1s dead-interval
810 support.
811 * ospf_dump.c: (ospf_timer_dump) Print out milliseconds too.
812 Callers typically specify a length of 9, so most see
813 millisecs unless they specify the additional length.
814 * ospf_interface.h: (struct ospf_interface) new interface param,
815 fast_hello.
816 * ospf_interface.c: (ospf_if_table_lookup) add brackets,
817 gcc warning fix.
818 (ospf_new_if_params) Initialise fast_hello param.
819 (ospf_free_if_params) Check whether fast_hello is configured.
820 (ospf_if_new_hook) set fast_hello to default.
821 * ospf_ism.h: Wrap OSPF_ISM_TIMER_ON inside do {} while (0) to
822 prevent funny side-effects from its if statement when this
823 macro is used conditionally by other macros.
824 (OSPF_ISM_TIMER_MSEC_ON) new macro, set in milliseconds.
825 (OSPF_HELLO_TIMER_ON) new macro to set hello timer according
826 to whether fast_hello is set.
827 * ospf_ism.c: Update all setting of the hello timer to use
828 either OSPF_ISM_TIMER_MSEC_ON or OSPF_HELLO_TIMER_ON. The
829 former is used when hello is to be sent immediately.
830 * ospf_nsm.c: ditto
831 * ospf_packet.c: (ospf_hello) hello-interval is not checked
832 for mismatch if fast_hello is set.
833 (ospf_read) Annoying nit, fix "no ospf_interface" to be debug
834 rather than a warning, as it can be perfectly normal to
835 receive packets when logical subnets are used.
836 (ospf_make_hello) Set hello-interval to 0 if fast-hellos are
837 configured.
838 * ospf_vty.c: (ospf_auto_cost_reference_bandwidth) annoying
839 nit, don't vty_out if this command is given, it gets tired
840 quick.
841 (show_ip_ospf_interface_sub) Print the hello-interval
842 according to whether fast-hello is set or not.
843 Print the extra 5 millisec characters from (ospf_timer_dump)
844 if fast-hello is configured.
845 (ospf_vty_dead_interval_set) new function, common to all
846 forms of dead-interval command, to set dead-interval and
847 fast-hello correctly. If a dead-interval is given, unset
848 fast-hello, else if a hello-multiplier is set, set
849 dead-interval to 1 and fast-hello to given multiplier.
850 (ip_ospf_dead_interval_addr_cmd) use
851 ospf_vty_dead_interval_set().
852 (ip_ospf_dead_interval_minimal_addr_cmd) ditto.
853 (no_ip_ospf_dead_interval) Unset fast-hello.
854 (no_ip_ospf_hello_interval) Bug-fix, unset of hello-interval
855 should set it to OSPF_HELLO_INTERVAL_DEFAULT, not
856 OSPF_ROUTER_DEAD_INTERVAL_DEFAULT.
857 (config_write_interface) Write out fast-hello.
858 (ospf_config_write) Write a comment about
859 "auto-cost reference-bandwidth" having to be equal on all
860 routers. Hopefully just as noticeable as old practice of
861 writing to vty, but less annoying.
862 (ospf_vty_if_init) install the two new dead-interval
863 commands.
864 * ospfd.h: Add defines for OSPF_ROUTER_DEAD_INTERVAL_MINIMAL
865 and OSPF_FAST_HELLO_DEFAULT.
866
pauleb3da6d2005-10-18 04:20:33 +00008672005-10-18 Paul Jakma <paul.jakma@sun.com>
868
869 * (general) SPF memory management cleanup and fix for rare
870 double-free bug.
871 * ospf_spf.h: (struct vertex_parent) New struct to hold parent
872 specific data, eg the backlink and the parent vertex pointer,
873 and point to the appropriate general struct vertex_nexthop.
874 (struct vertex_nexthop) remove parent vertex pointer, so
875 this struct can be shared across vertices.
876 (struct vertex) rename list child to list children. Remove
877 list of nexthops, replace with list of vertex_parents.
878 * ospf_spf.c: (update_stat) trivial, remove cast from void *.
879 (vertex_nexthop_new) remove init of parent - field is gone
880 from struct vertex_nexthop.
881 (ospf_canonical_nexthops_free) Remove the canonical
882 vertex_nexthop memory objects. These are the vertex_nexthops
883 attached to the first level of router vertices from the root.
884 (vertex_parent_new) new function, create a vertex_parent.
885 (vertex_parent_free) ditto, but free it.
886 (ospf_vertex_new) Update to match changes to struct vertex.
887 (ospf_vertex_free) Recursively free a struct vertex and its
888 children. The parent list is used as a reference count.
889 vertex_nexthops must be free seperately, if required.
890 (ospf_vertex_dump) update to match struct vertex changes.
891 Print out backlink of parents too.
892 (ospf_vertex_add_parent) ditto.
893 (ospf_lsa_has_link) update comment.
894 (ospf_nexthop_add_unique) removed, not needed anymore.
895 (ospf_nexthop_merge) ditto.
896 (ospf_spf_consider_nexthop) renamed to ospf_spf_add_parent.
897 Simplified to just create vertex_parent and add it.
898 (ospf_spf_flush_parents) new function, flush out the parent
899 list.
900 (ospf_nexthop_calculation) Take the relevant route_lsa_link
901 as an argument, which simplifies things and removes the need
902 for the hack in ospf_nexthop_add_unique - ospf_spf_next
903 already knew exactly which link the cost calculated was for.
904 Update to match struct vertex changes too.
905 (ospf_spf_next) Don't create a vertex for W unnecessarily, if
906 it's there's a vertex already created for W, use it, and
907 hence there's no need to free it either.
908 Update some manipulation/comparisons of distance to match.
909 Flush the parent list if a lower cost path is found.
910 (ospf_spf_route_free) unused, removed.
911 (ospf_spf_dump) match the struct vertex changes, and dump the
912 ifname if possible.
913 (ospf_spf_calculate) At end of SPF, free the canonical nexthops
914 and call ospf_vertex_free on the root vertex to free the
915 entire tree.
916 * ospf_interface.c: (ospf_vl_set_params) match struct vertex
917 changes.
918 * ospf_route.c: (ospf_intra_route_add) ditto
919 (ospf_route_copy_nexthops_from_vertex) ditto
920
paul36238142005-10-11 04:12:54 +00009212005-10-11 Paul Jakma <paul.jakma@sun.com>
922
923 * ospf_api.c: sign warnings.
924 * ospf_apiserver.c: sign warning and convert all the struct
925 in_addr initialisations so as not to make assumptions about
926 how this struct is organised, initialise the s_addr member
927 explicitely.
928 * ospf_packet.c: Add const qualifier to auth_key.
929
vincent77df1f72005-10-06 07:46:22 +00009302005-10-06 Alain Ritoux <alain.ritoux@6wind.com>
931
932 * ospf_snmp.c: Avoid mixing interface and ospf_interface objects
933 which now allows snmpwalk to work with ospfIfTable and
934 also with ospfIfMetricTable
935
ajsf52d13c2005-10-01 17:38:06 +00009362005-10-01 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
937
938 * ospf_dump.c: Remove local hard-coded table ospf_redistributed_proto.
939 (ospf_redist_string) New function implemented using new library
940 function zebra_route_string(). Note that there are a few differences
941 in the output that will result: the new function returns strings
942 that are lower-case, whereas the old table was mixed case. Also,
943 the old table mapped ZEBRA_ROUTE_OSPF6 to "OSPFv3", whereas the
944 new function returns "ospf6".
945 * ospfd.h: Remove extern struct message ospf_redistributed_proto[],
946 and add extern const char *ospf_redist_string(u_int route_type)
947 instead.
948 * ospf_asbr.c: (ospf_external_info_add) In two messages, use
949 ospf_redist_string instead of LOOKUP(ospf_redistributed_proto).
950 * ospf_vty.c: Remove local hard-coded table distribute_str.
951 (config_write_ospf_redistribute,config_write_ospf_distribute): Use
952 new library function zebra_route_string() instead of distribute_str[].
953 * ospf_zebra.c: (ospf_redistribute_set,ospf_redistribute_unset,
954 ospf_redistribute_default_set,ospf_redistribute_check)
955 In debug messages, use ospf_redist_string() instead of
956 LOOKUP(ospf_redistributed_proto).
957
jardin6638c1a2005-10-01 00:08:54 +00009582005-09-30 Vincent Jardin <vincent.jardin@6wind.com>
959
960 * ospf_dump.c, ospf_ia.c, ospf_spf.c, ospf_ase.c:
961 remove unused DEBUG
962
vincentba682532005-09-29 13:52:57 +00009632005-09-29 Alain Ritoux <alain.ritoux@6wind.com>
964
vincent5e4914c2005-09-29 16:34:30 +0000965 * ospf_ism.c: generate SNMP traps on Interface state change
966 * ospf_nsm.c: generate SNMP traps on Neighbour state change
967 * ospf_snmp.[ch]: support for SNMP traps for interface and neighbours.
968
9692005-09-29 Alain Ritoux <alain.ritoux@6wind.com>
970
vincentba682532005-09-29 13:52:57 +0000971 * ospf_vty.c: forece default route LSA to be re_issued whenever
972 cost is changed ( [no] ip ospf area XXX default-cost YYY)
973 Support ignore-mtu option
974 * ospfd.h: define OSPF_MTU_IGNORE_DEFAULT
975 * ospf_packet.c: support ignore-mtu option
976 * ospf_interface.h: field added for skipping MTU check
977 * ospf_interface.c: fix memory leak in ospf_crypt_key_delete()
978 Set mtu_ignore field to default value
979 * ospf_abr.[ch]: export ospf_abr_announce_network_to_area()
980 * ospf_ism.h: add MACRO to convert internal ISM status into SNMP
981 correct values
982 * ospf_snmp.c: add sanity check on LSA type in lsdb_lookup_next()
983 convert OSPFIFSTATE internal status into SNMP values
984
vincentc1a03d42005-09-28 15:47:44 +00009852005-09-28 Alain Ritoux <alain.ritoux@6wind.com>
986
987 * ospf_packet.c: use new md5 API
988
ajs5339cfd2005-09-19 13:28:05 +00009892005-09-19 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
990
991 * ospf_lsa.h: (ospf_external_lsa_flush) Comment out the 5th argument
992 (nexthop) since it is not used in the function (except inside
993 some commented-out code).
994 * ospf_lsa.c: (ospf_external_lsa_flush,ospf_external_lsa_refresh)
995 Comment out the 5th argument to ospf_external_lsa_flush.
996 * ospf_asbr.c: (ospf_redistribute_withdraw) Comment out 5th arg
997 to ospf_external_lsa_flush.
998 * ospf_vty.c: (no_ospf_default_information_originate) Eliminate 5th
999 uninitialized nexthop arg to ospf_external_lsa_flush.
1000 * ospf_zebra.c: (ospf_zebra_read_ipv4) Comment out 5th arg
1001 to ospf_external_lsa_flush.
1002 * ospfd.c: (ospf_network_set) Comment out 5th arg
1003 to ospf_external_lsa_flush.
1004
ajse6a0bf92005-09-17 18:53:38 +000010052005-09-17 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1006
1007 * ospf_opaque.c:
1008 (ospf_opaque_lsa_refresh_schedule,ospf_opaque_lsa_flush_schedule)
1009 No need to call ospf_lookup(), just use lsa0->area->ospf instead.
1010
hassobb5b7552005-08-21 20:01:15 +000010112005-08-21 Hasso Tepper <hasso at quagga.net>
1012
1013 * ospf_vty.c: Make "show ip ospf neighbor xxx" commands work.
1014 Interface should be specified by name now.
1015
hasso54bedb52005-08-17 13:31:47 +000010162005-08-17 Hasso Tepper <hasso at quagga.net>
1017
1018 * ospf_vty.c: Check carefully if interface exists before trying to
1019 print info about it.
1020
hasso01018ce2005-08-05 07:40:15 +000010212005-08-05 Hasso Tepper <hasso at quagga.net>
1022
1023 * ospf_zebra.c: Don't assert/stop before type == ZEBRA_ROUTE_MAX if
1024 dealing with routemaps. There is ospf->route_map[ZEBRA_ROUTE_MAX]
1025 for default-information.
1026
paulc8987752005-07-26 06:07:22 +000010272005-07-26 Paul Jakma <paul.jakma@sun.com>
1028
1029 * ospf_abr.c: (ospf_abr_announce_network_to_area) SET_FLAG
1030 should be on lsa not old, which may be freed for one thing,
1031 obviously.
1032
pauld57834f2005-07-12 20:04:22 +000010332005-07-12 Paul Jakma <paul.jakma@sun.com>
1034
1035 * ospfd.h: add OSPF_ABR_DEFAULT for convenience, make
1036 OSPF_ABR_CISCO be the default ABR type.
1037 * ospfd.c: (ospf_new) initialise abr_type to OSPF_ABR_DEFAULT
1038 * ospf_vty.c: (no_ospf_abr_type_cmd) add standard as a negatable
1039 abr_type. default abr_type should be OSPF_ABR_DEFAULT.
1040 (ospf_config_write) test whether default abr_type against
1041 OSPF_ABR_DEFAULT, rather than any specific ABR_TYPE.
1042
hasso8469bd72005-06-20 20:50:10 +000010432005-06-20 Hasso Tepper <hasso at quagga.net>
hassof4833e92005-06-20 20:42:26 +00001044
1045 * ospf_nsm.c: Make database exchange for NSSA database work.
1046
paul7461d452005-06-13 13:57:16 +000010472005-06-13 Paul Jakma <paul.jakma@sun.com>
1048
1049 * ospf_spf.c: Try get more information on a SEGV under
1050 ospf_spf_vertex_add_parent.
1051 (ospf_vertex_free) NULL out the child and nexthop lists
1052 (ospf_vertex_add_parent) nexthop and child can not be NULL
1053 vertex_nexthop's parent->child list can not be NULL
1054 (ospf_spf_next) w and cw are per-loop iteration variables, move
1055 declarations into loop body.
1056
hasso1ddd7292005-06-07 19:54:04 +000010572005-06-07 Hasso Tepper <hasso at quagga.net>
1058
1059 * ospf_apiserver.c: Fix obvious error in notifying clients about ISM
1060 changes - oi->ifp->status doesn't give to us info about ISM,
1061 oi->state does.
1062
paul7e440862005-06-01 11:20:51 +000010632005-06-01 Akihiro Mizutani <mizutani@net-chef.net>
1064
1065 * ospf_ism.c (ospf_elect_bdr/ospf_elect_dr): Fix DR election bug.
1066
paul500e4182005-05-26 17:11:13 +000010672005-05-26 Paul Jakma <paul.jakma@sun.com>
1068
1069 * ospf_abr.c: (ospf_abr_update_aggregate) Fix comment, cost bug itself
1070 had been fixed long ago by Sowmini.
1071
paula3387a42005-05-18 23:29:57 +000010722005-05-19 Paul Jakma <paul.jakma@sun.com>
1073
1074 * ospf_interface.c: (ospf_if_table_lookup) Fix a serious bug
1075 a less serious one.
1076 1: this function is supposed to lookup
1077 entries in the oifs ospf_interface route_table and return either
1078 an existing oi or NULL to indicate not found, its caller depends
1079 on this, yet this function uses route_node_get which /always/
1080 returns a route_node - one is created if none exists. Use
1081 route_node_lookup instead. This should fix root cause of the
1082 reports of the (ospf_add_to_if) assert being hit.
1083 2: oi's are inserted into this table with prefixlength set to
1084 /32 (indeed, it should be a hash table, not a route_table),
1085 however prefixlength to lookup was not changed, if no valid entry
1086 can be inserted other than /32, then nothng but /32 should be
1087 looked up. This possibly only worked by fluke..
1088 Fix confirmed by 2 reporters (one list, one IRC), definitely a
1089 backport candidate once it has been incubated in HEAD for a while.
1090 Thanks to Patrick Friedel and Ivan Warren for testing.
1091
paul69310a62005-05-11 18:09:59 +000010922005-05-11 Paul Jakma <paul.jakma@sun.com>
1093
1094 * (general) Fix memory leaks in opaque AS-scope LSAs, reported and
1095 with much debugging done by by scott collins <scollins@agile.tv>.
1096 * ospf_lsa.c: (ospf_discard_from_db) dont call
1097 ospf_ase_unregister_external_lsa for opaque-lsa's, opaques are
1098 never registered with ase in the first place.
1099 * ospf_packet.c: (general) Disabuse opaque related code of its
1100 tendency to try gather up things into temporary lists.
1101 (ospf_ls_upd) remove the temporary lists opaque uses, call
1102 opaque functions inline, just like all other types.
1103 (ospf_ls_ack) ditto.
1104 (ospf_recv_packet) fixup sign warning.
1105 * ospf_opaque.c: (general) fix the unneeded use of lists, and
1106 untwist some of the logic.
1107 (ospf_opaque_self_originated_lsa_received) take a single LSA
1108 as argument, not a list of them. Remove the list loop. Logic
1109 otherwise unchanged.
1110 (ospf_opaque_ls_ack_received) Mostly ditto. But untwist the logic,
1111 move the actions up into the switch block, remove the goto's and
1112 sanitise the logic near the end a bit.
1113 * ospf_opaque.h: Adjust definitions of aforementioned functions
1114 in ospf_opaque.c to match.
1115
paul42c98192005-05-07 02:22:51 +000011162005-05-07 Yar Tikhiy <yar@comp.chem.msu.su>
1117
1118 * ospf_network.c: Log ifindex on multicast membership leave/join
1119 events.
1120
paul4dadc292005-05-06 21:37:42 +000011212005-05-06 Paul Jakma <paul.jakma@sun.com>
1122
1123 * (general) extern and static qualifiers added.
1124 unspecified arguments in definitions fixed, typically they should
1125 be 'void'.
1126 function casts added for callbacks.
1127 Guards added to headers which lacked them.
1128 Proper headers included rather than relying on incomplete
1129 definitions.
1130 gcc noreturn function attribute where appropriate.
1131 * ospf_opaque.c: remove the private definition of ospf_lsa's
1132 ospf_lsa_refresh_delay.
1133 * ospf_lsa.h: export ospf_lsa_refresh_delay
1134 * ospf_packet.c: (ospf_make_md5_digest) make *auth_key const,
1135 correct thing to do - removes need for the casts later.
1136 * ospf_vty.c: Use vty.h's VTY_GET_INTEGER rather than ospf_vty's
1137 home-brewed versions, shuts up several warnings.
1138 * ospf_vty.h: remove VTY_GET_UINT32. VTY_GET_IPV4_ADDRESS and
1139 VTY_GET_IPV4_PREFIX moved to lib/vty.h.
1140 * ospf_zebra.c: (ospf_distribute_list_update_timer) hacky
1141 overloading of the THREAD_ARG pointer should at least use
1142 uintptr_t.
1143
paul9e67dc22005-04-15 12:10:17 +000011442005-04-15 Zhipeng Gong <zpgong@cdc.3upsystems.com>
1145
1146 * ospf_abr.c: (ospf_abr_announce_network_to_area) dont forget
1147 to approve LSAs for the case where metric has changed, lsa gets
1148 flushed otherwise. (backport candidate).
1149
ajs634f9ea2005-04-11 15:51:40 +000011502005-04-11 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1151
1152 * ospf_zebra.c (ospf_zebra_add): Call zclient_send_message instead
1153 of writen.
1154
ajsd2fc8892005-04-02 18:38:43 +000011552005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1156
ajse4319de2005-04-02 23:23:55 +00001157 * ospf_interface.h: (ospf_if_lookup_by_name) Remove declaration of a
1158 function that does not exist.
1159
11602005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1161
ajs21fefa92005-04-02 23:16:41 +00001162 * ospf_zebra.c: (zebra_interface_if_lookup) Must use
1163 if_lookup_by_name_len.
1164
11652005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1166
ajsa3491982005-04-02 22:50:38 +00001167 * ospf_interface.c: (ospf_vl_new) Use strnlen to fix call to if_create.
1168
11692005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1170
ajsd2fc8892005-04-02 18:38:43 +00001171 * ospf_vty.c: (show_ip_ospf_interface_sub) Show ifindex and interface
1172 flags to help with debugging.
1173 * ospf_zebra.c: (ospf_interface_delete) After deleting, set ifp->ifindex
1174 to IFINDEX_INTERNAL.
1175 (zebra_interface_if_lookup) Make function static. Tighten up code.
1176
ajsaca72fd2005-03-31 15:18:21 +000011772005-03-31 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1178
1179 * ospf_dump.c: (show_debugging_ospf) Show if ospf event debugging
1180 is turned on.
1181
ajsfd651fa2005-03-29 16:08:16 +000011822005-03-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1183
ajsa608bbf2005-03-29 17:03:49 +00001184 * ospf_zebra.c: (ospf_interface_state_up) If the MTU of an operative
1185 interface changes, print a debug message and call ospf_if_reset()
1186 to simulate down/up on the interface.
1187 * ospf_interface.h: Declare new function ospf_if_reset().
1188 * ospf_interface.c: (ospf_if_reset) New function to call ospf_if_down
1189 and ospf_if_up for all ospf interfaces attached to an interface.
1190
11912005-03-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1192
ajs5dcbdf82005-03-29 16:13:49 +00001193 * ospf_packet.c: (ospf_write_frags) Enhance error message to
1194 show MTU. Also make function static.
1195 (ospf_write) Enhance error message to show interface name and MTU.
1196 Also make function static.
1197
11982005-03-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1199
1200 * ospf_vty.c: (show_ip_ospf_interface_sub) Display interface MTU and
1201 bandwidth; this is useful for debugging problems. Also, the function
1202 should be static.
ajsfd651fa2005-03-29 16:08:16 +00001203
hasso1b639042005-03-27 13:32:25 +000012042005-03-27 Hasso Tepper <hasso at quagga.net>
1205
1206 * ospf_snmp.c: Don't crash in snmp query if ospf instance doesn't
1207 exist at all.
1208
hasso343f5cc2005-03-25 19:48:40 +000012092005-03-25 Hasso Tepper <hasso at quagga.net>
1210
1211 * ospfd.h: Include log.h, fixes compile with gcc-4.0.
1212
ajs9dbc7972005-03-13 19:27:22 +000012132005-03-13 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1214
1215 * ospf_lsa.c: (ospf_lsa_refresh_walker) If the system clock jumps
1216 backward, then current time may be less than
1217 ospf->lsa_refresher_started. This was causing invalid values
1218 for ospf->lsa_refresh_queue.index resulting in infinite loops.
1219 Problem fixed by casting the expression to unsigned before taking
1220 the modulus.
1221
ajs5c333492005-02-23 15:43:01 +000012222005-02-23 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1223
1224 * ospfd.h: Add new field struct stream *ibuf to struct ospf.
1225 * ospfd.c: (ospf_new) Check return code from ospf_sock_init.
1226 Allocate ibuf using stream_new(OSPF_MAX_PACKET_SIZE+1).
1227 (ospf_finish) Call stream_free(ospf->ibuf.
1228 * ospf_packet.c: (ospf_read) Call stream_reset(ospf->ibuf) and then
1229 pass it to ospf_recv_packet for use in receiving the packet
1230 (instead of allocating a new stream for each packet received).
1231 Eliminate all calls to stream_free(ibuf).
1232 (ospf_recv_packet) The struct stream *ibuf is now passed in as
1233 an argument. No need to use recvfrom to peek at the packet
1234 header (to see how big it is), just use ospf->ibuf which is
1235 always large enough (this eliminates a system call to recvfrom).
1236 Therefore, no need to allocate a stream just for this packet,
1237 and no need to free it when done.
1238
hasso462f20d2005-02-23 11:29:02 +000012392005-02-23 Vincenzo Eramo <eramo at infocom.ing.uniroma1.it>
1240
1241 * ospf_lsa.h: New flag to the LSA structure for the SPF calculation.
1242 * ospf_lsdb.h: Export ospf_lsdb_clean_stat() function.
1243 * ospf_spf.h: Add link to the LSA stat structure into vertex.
1244 * ospf_spf.c: New functions cmp() and update_stat() to manage
1245 candidates. Remove ospf_spf_has_vertex(), ospf_vertex_lookup(),
1246 ospf_install_candidate() and ospf_spf_register() functions not needed
1247 any more. Update ospf_vertex_new(), ospf_spf_next() and
1248 ospf_spf_calculate() functions to use pqueue instead of linked list.
1249
hassoe40dcce2005-02-21 14:58:42 +000012502005-02-21 Hasso Tepper <hasso at quagga.net>
1251
1252 * ospf_ase.c: Don't show messages related to the ase calculations if
1253 we are not debugging.
1254
hasso306541b2005-02-19 17:58:40 +000012552005-02-19 Hasso Tepper <hasso at quagga.net>
1256
1257 * ospf_api.h: char isn't always signed, but it has to be it here.
1258
paulfa81b712005-02-19 01:19:20 +000012592005-02-19 Paul Jakma <paul.jakma@sun.com>
1260
1261 * ospf_packet.c: (ospf_stream_copy) remove
1262 (ospf_packet_dup) use stream_copy instead of ospf_stream_copy
1263
ajs038163f2005-02-17 19:55:59 +000012642005-02-17 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1265
1266 * ospf_packet.c: (ospf_recv_packet) If there is somehow a runt
1267 packet in the queue, it must be discarded. Improve warning messages.
1268 Fix scope to static.
1269 (ospf_read) Fix bug: should reset the read thread in all cases
1270 to make sure we continue to get incoming messages.
1271
paul658b03a2005-02-15 10:10:55 +000012722005-02-15 Paul Jakma <paul.jakma@sun.com>
1273
1274 * ospf_packet.c: (ospf_recv_packet) Fix silly error wrt allocating
1275 ibuf. Thanks Andrew.
1276
paulbfdc44a2005-02-14 23:48:42 +000012772005-02-14 Paul Jakma <paul.jakma@sun.com>
1278
1279 * ospf_packet.c: (ospf_recv_packet) use stream_recvmsg.
1280
hasso082253f2005-02-11 08:31:54 +000012812005-02-11 Hasso Tepper <hasso at quagga.net>
1282
1283 * ospf_lsdb.c: Fix sum of checksums calculation.
1284
ajs083ee9d2005-02-09 15:35:50 +000012852005-02-09 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1286
1287 * ospf_packet.c: (ospf_write) If sendmsg fails, give more info in the
1288 error message.
1289
ajsba6454e2005-02-08 15:37:30 +000012902005-02-08 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1291
ajs8cfde372005-02-08 15:59:16 +00001292 * ospf_interface.h: Reduce structure padding by putting new u_char
1293 field multicast_memberships in a better spot (grouped with
1294 other u_char fields type and state).
1295
12962005-02-08 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1297
ajsba6454e2005-02-08 15:37:30 +00001298 * ospf_interface.h: Improve passive_interface comment. Add new
1299 multicast_memberships bitmask to struct ospf_interface to track
1300 active multicast subscriptions. Declare new function
1301 ospf_if_set_multicast.
1302 * ospf_interface.c: (ospf_if_set_multicast) New function to configure
1303 multicast memberships properly based on the current
1304 multicast_memberships status and the current values of the
1305 ospf_interface state, type, and passive_interface status.
1306 (ospf_if_up) Remove call to ospf_if_add_allspfrouters (this is
1307 now handled by ism_change_state's call to ospf_if_set_multicast).
1308 (ospf_if_down) Remove call to ospf_if_drop_allspfrouters (now
1309 handled by ism_change_state).
1310 * ospf_ism.c: (ospf_dr_election) Remove logic to join or leave
1311 the DRouters multicast group (now handled by ism_change_state's call
1312 to ospf_if_set_multicast).
1313 (ism_change_state) Add call to ospf_if_set_multicast to change
1314 multicast memberships as necessary to reflect the new interface state.
1315 * ospf_packet.c: (ospf_hello) When a Hello packet is received on a
1316 passive interface: 1. Increase the severity of the error message
1317 from LOG_INFO to LOG_WARNING; 2. Add more information to the error
1318 message (packet destination address and interface address);
1319 and 3. If the packet was sent to ospf-all-routers, then try
1320 to fix the multicast group memberships.
1321 (ospf_read) When a packet is received on an interface whose state
1322 is ISM_Down, enhance the warning message to show the packet
1323 destination address, and try to update/fix the multicast group
1324 memberships if the packet was sent to a multicast address.
1325 When a packet is received for ospf-designated-routers, but the
1326 current interface state is not DR or BDR, then increase the
1327 severity level of the error message from LOG_INFO to LOG_WARNING,
1328 and try to fix the multicast group memberships.
1329 * ospf_vty.c: (ospf_passive_interface) Call ospf_if_set_multicast for
1330 any ospf interface that may have changed from active to passive.
1331 (no_ospf_passive_interface) Call ospf_if_set_multicast for
1332 any ospf interface that may have changed from passive to active.
1333 (show_ip_ospf_interface_sub) Show multicast group memberships.
1334
paul3a9eb092005-02-08 11:29:41 +000013352005-02-08 Paul Jakma <paul@dishone.st>
1336
1337 * ospf_packet.c: (various) Remove unneeded stream_set_putp abuse.
1338
ajs847947f2005-02-02 18:38:48 +000013392005-02-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1340
1341 * ospf_packet.c: (ospf_read) Fix bug: must check for state ISM_Down,
1342 not for event ISM_InterfaceDown. And improve the message by
1343 adding the interface flags.
1344
ajs0b7d97d2005-01-30 17:24:02 +000013452005-01-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1346
1347 * ospf_network.c: (ospf_sock_init) Save errno before calling
1348 ospfd_privs.change.
1349
ajsc3eab872005-01-29 15:52:07 +000013502005-01-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1351
1352 * ospf_packet.c: (ospf_packet_add) If oi->obuf is NULL, print
1353 an error message and return.
1354 (ospf_read) If the interface state is ISM_InterfaceDown, issue
1355 a warning message and ignore the packet.
1356
gdt86f1fd92005-01-10 14:20:43 +000013572005-01-10 Greg Troxel <gdt@fnord.ir.bbn.com>
1358
1359 * ospf_packet.h: Remove commented out definition of
1360 OSPF_MAX_PACKET; neither it or the uncommented one are used any more.
1361
1362 * ospf_packet.c (ospf_make_ls_upd): Leave room for authentication
1363 when deciding if an update will fit.
1364 (ospf_packet_authspace): Factor out calculation of size required
1365 for authentication.
1366 (ospf_make_db_desc): Use ospf_max_packet, not OSPF_MAX_PACKET.
1367 Don't confuse readers that there is a macro.
1368
ajs3dc56b52004-12-30 15:11:19 +000013692004-12-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1370
1371 * ospf_network.c: Improve all setsockopt error messages to give detailed
1372 information on the arguments.
1373
ajsb87f7722004-12-29 20:41:26 +000013742004-12-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1375
ajs17eaa722004-12-29 21:04:48 +00001376 * ospf_packet.c: (ospf_db_desc) Reduce severity of "Negotiation done"
1377 messages from LOG_WARNING to LOG_INFO, since this seems to be
1378 normal.
1379
13802004-12-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1381
ajsb87f7722004-12-29 20:41:26 +00001382 * ospf_packet.c: (ospf_read) Always look up the interface if
1383 ospf_recv_packet returns NULL ifp, since some platforms such
1384 as Solaris 8 appear to support ifindex retrieval but don't.
1385
hasso1d806282004-12-22 09:43:20 +000013862004-12-22 Hasso Tepper <hasso at quagga.net>
1387
1388 * ospf_dump.c: Show debug configuration in vtysh.
hassoc6b87812004-12-22 13:09:59 +00001389 * ospf_vty.c: Fix "show ip ospf" output. Router can't be elected in
1390 any case if it's configured as "translate-never".
hassofe71a972004-12-22 16:16:02 +00001391 * ospf_lsdb.[ch]: New function to calculate sum of checksums.
1392 * ospf_vty.c: Bugfix to show really number of AS external LSAs, not
1393 number of all LSAs with AS scope, this includes opaque as LSAs as
1394 well, show this number separately. Show numbers and sums of
1395 checksums for each type of LSAs.
1396 * ospf_lsa.c: Calculate checksum before putting LSA into database.
hasso1d806282004-12-22 09:43:20 +00001397
ajsbc18d612004-12-15 15:07:19 +000013982004-12-15 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1399
1400 * ospf_interface.h: Declare new function ospf_default_iftype.
1401 * ospf_interface.c: (ospf_default_iftype) New function to centralize
1402 this logic in one place.
1403 * ospf_zebra.c: (ospf_interface_add) Use new function
1404 ospf_default_iftype.
1405 * ospf_vty.c: (no_ip_ospf_network,config_write_interface) Fix logic
1406 by using new function ospf_default_iftype.
1407
ajs3aa8d5f2004-12-11 18:00:06 +000014082004-12-11 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1409
1410 * ospf_packet.c: (ospf_db_desc) Should be static, not global.
1411 (ospf_hello,ospf_db_desc,ospf_ls_upd,ospf_ls_ack) Improve warning
1412 messages to include identifying information (e.g. router id).
1413 * ospf_nsm.c: (nsm_change_state) Improve info message to include
1414 router id and state names.
1415
gdt91f3e522004-12-09 14:51:03 +000014162004-12-09 Greg Troxel <gdt@fnord.ir.bbn.com>
1417
gdt3fb9de72004-12-09 16:30:04 +00001418 * ospf_apiserver.c (ospf_apiserver_term): Obtain struct
1419 ospf_apiserver * from listnode. Remove unused variables. Follows
1420 suggestion from Jay Fenlason.
gdt91f3e522004-12-09 14:51:03 +00001421
ajs9b0e25c2004-12-08 19:06:51 +000014222004-12-08 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1423
1424 * *.c: Change level of debug messages to LOG_DEBUG.
1425
ajs274a4a42004-12-07 15:39:31 +000014262004-12-07 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1427
1428 * ospf_main.c: (main) The 2nd argument to openzlog has been removed.
1429
ajs887c44a2004-12-03 16:36:46 +000014302004-12-03 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1431
ajs1210fa62004-12-03 16:43:24 +00001432 * ospf_packet.c: (ospf_db_desc) Reduce priority on a debug message
1433 from LOG_NOTICE to LOG_DEBUG.
1434
14352004-12-03 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1436
ajs887c44a2004-12-03 16:36:46 +00001437 * ospf_main.c: (sigint) Use zlog_notice for termination message.
1438 (main) Issue a startup announcement using zlog_notice.
1439
ajsbec595a2004-11-30 22:38:43 +000014402004-11-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1441
1442 * ospf_packet.c: (ospf_db_desc_proc) Fix spelling of packet in warning
1443 message and in comment.
1444 (ospf_db_desc) Warning message that a packet is being discarded
1445 should give the router id of the packet source. Fix spelling
1446 of packet in two warning messages.
1447 (ospf_ls_req) Warning message that a link state request is being
1448 discarded should give the router id of the neighbor that sent it.
1449
ajs5b85fac2004-11-26 19:36:42 +000014502004-11-26 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1451
1452 * ospf_main.c: Remove #include "debug.h" (was not being used, and
1453 lib/debug.h has now been deleted).
1454
hassoc0652302004-11-25 19:33:48 +000014552004-11-25 Hasso Tepper <hasso at quagga.net>
1456
1457 * ospf_main.c: Make group to run as configurable.
1458
gdt69e13252004-11-15 18:51:15 +000014592004-11-15 Greg Troxel <gdt@fnord.ir.bbn.com>
1460
1461 * ospf_packet.c (ospf_recv_packet): Assume CMSG_SPACE is present
1462 and works (lib/zebra.h provides if OS doesn't).
1463
paul788dab12004-11-15 11:48:37 +000014642004-11-15 Paul Jakma <paul@dishone.st>
1465
1466 * ospf_{apiserver,te}.c: ospf_lsa_free's should be ospf_lsa_unlock.
1467
paul05e85fa2004-11-12 10:52:19 +000014682004-11-12 Paul Jakma <paul@dishone.st>
1469
1470 * ospf_ia.c: (process_summary_lsa) Only an ABR has any reason to
1471 ignore stub area summary default. Even so it seems a strange
1472 check, add a comment to that effect.
1473
paulf3ae74c2004-11-04 20:35:31 +000014742004-11-04 Paul Jakma <paul@dishone.st>
1475
1476 * ospfd.c: (ospf_network_match_iface) revert to previous network
1477 statement match behaviour.
1478
paul62d8e962004-11-02 20:26:45 +000014792004-11-02 Paul Jakma <paul@dishone.st>
1480
1481 * ospf_packet.c: (ospf_write_frags) remove iov arg, msg already points
1482 to it. Add convenience pointer to msg->msg_iov[1], and use this,
1483 fixing the unfortunate borkenness introduced in moving of this code
1484 to a function.
1485 (ospf_write) remove iovp and fix up call to previous.
1486 (ospf_ls_upd_packet_new) cast size to long int - unfortunately
1487 glibc's size_t format modifier is not portable.
1488
paul37ccfa32004-10-31 11:24:51 +000014892004-10-31 Paul Jakma <paul@dishone.st>
1490
1491 * ospf_packet.c: (ospf_write_frags) Add debug output
1492 (ospf_write) set type early, so we can pass it to
1493 ospf_write_frags.
1494 (ospf_ls_upd_packet_new) print size in debug output when too large
1495 packet is encountered.
paul64511f32004-10-31 18:01:13 +00001496 * ospf_zebra.c: (ospf_distribute_list_update_timer) Ugly misuse of
1497 THREAD_ARG to store an integer, but it should at least use same
1498 same type to retrieve the value. Assert value is sane.
paul37ccfa32004-10-31 11:24:51 +00001499
paulac191232004-10-22 12:05:17 +000015002004-10-22 Paul Jakma <paul@dishone.st>
1501
1502 * ospf_network.c: (ospf_sock_init) call neutral setsock_ifindex()
1503 function.
1504 * ospf_packet.c: (ospf_read) manually look up ifindex
paul4ccb2c42004-10-22 22:52:33 +00001505 if system could not have returned one, eg openbsd, thanks to Rivo
1506 Nurges for highlighting problem and fix.
paul06f953f2004-10-22 17:00:38 +00001507 Change setsockopt_pktinfo to setsockopt_ifindex.
paulac191232004-10-22 12:05:17 +00001508
hasso3fb9cd62004-10-19 19:44:43 +000015092004-10-19 Andrew J. Schorr <aschorr@telemetry-investments.com>
1510
1511 * ospf_snmp.c: (ospf_snmp_if_update) Fix logic to handle PtP links
1512 with dedicated subnets properly.
1513 * ospf_lsa.c: (lsa_link_ptop_set) ditto.
1514 * ospfd.c: (ospf_network_match_iface) ditto.
1515 (ospf_network_run) ditto.
1516 * ospf_interface.c: (ospf_if_is_configured) ditto.
1517 (ospf_if_lookup_by_prefix) ditto.
1518 (ospf_if_lookup_recv_if) ditto.
1519 * ospf_vty.c: (show_ip_ospf_interface_sub) Display the peer or
1520 broadcast address if present.
1521
hassod68614d2004-10-13 09:32:48 +000015222004-10-13 Hasso Tepper <hasso at quagga.net>
1523
1524 * ospf_main.c: Unbreak compilation with ospfapi disabled.
hassoc75105a2004-10-13 10:33:26 +00001525 * ospf_snmp.c: Remove defaults used to initialize smux connection to
1526 snmpd. Connection is initialized only if smux peer is configured.
hassod68614d2004-10-13 09:32:48 +00001527
hassof4d58ce2004-10-12 06:13:54 +000015282004-10-12 Hasso Tepper <hasso at quagga.net>
1529
1530 * ospf_main.c, ospf_opaque.c: Unbreak ospfclient compilation - move
1531 static variable from ospf_main.c into ospf_opaque.c.
1532
hassoc3abdb72004-10-11 16:27:03 +000015332004-10-11 Hasso Tepper <hasso at quagga.net>
1534
1535 * ospf_main.c, ospf_opaque.c: Disable ospfapi init by default. New
1536 command line switch to enable it.
1537
paul6b333612004-10-11 10:11:25 +000015382004-10-11 Paul Jakma <paul@dishone.st>
1539
1540 * ospf_dump.c: (ospf_ip_header_dump) Assume header is in host order
1541 remove ntohs that should have dissappeared. Take struct ip
1542 as argument, caller has to know there's an IP header at start of
1543 stream anyway.
1544 * ospf_dump.h: update declaration of ospf_ip_header_dump.
1545 * ospf_packet.c: (ospf_write) correct call to
1546 sockopt_iphdrincl_swab_htosys which was munging the header.
1547 (ospf_recv_packet) ip_len is needed for old OpenBSD fixup.
1548 (ospf_read) sockopt_iphdrincl_swab_systoh ip header as soon as
1549 we have it.
paul6c835672004-10-11 11:00:30 +00001550 * (global) Const char update and signed/unsigned fixes.
1551 * (various headers) size defines should be unsigned.
1552 * ospf_interface.h: remove duplicated defines, include the
1553 authoritative header - though, these defines should probably
1554 be moved to a dedicated header, or ospfd.h.
1555 * ospf_lsa.h: (struct lsa) ls_seqnum should be unsigned.
1556 * ospf_packet.c: (ospf_write) cast result of shift to unsigned.
paul6b333612004-10-11 10:11:25 +00001557
hassoeb1ce602004-10-08 08:17:22 +000015582004-10-08 Hasso Tepper <hasso at quagga.net>
1559
1560 * *.[c|h]: Fix compiler warnings: make some strings const, signed ->
1561 unsigned, remove unused variables etc.
1562
gdt54ade992004-10-07 19:38:20 +000015632004-10-07 Greg Troxel <gdt@claude.ir.bbn.com>
1564
1565 * ospf_apiserver.c (ospf_apiserver_unregister_opaque_type): Don't
1566 use of variable names 'node' and 'nextnode' to avoid possible
1567 conflict with list macros. Move variable declaration inside for
1568 loop after a statement to top of function.
1569
paulaa20c6f2004-10-07 14:19:36 +000015702004-10-07 Paul Jakma <paul@dishone.st>
1571
1572 * ospf_snmp.c: Missed list typedef update
1573 * ospf_dump.c: Include sockopt.h for header swab functions.
1574
paul18b12c32004-10-05 14:38:29 +000015752004-10-05 Paul Jakma <paul@dishone.st>
1576
1577 * ospf_packet.c: replace ospf_swap_iph_to... with
1578 sockopt_iphdrincl_swab_...
1579
hasso18a6dce2004-10-03 18:18:34 +000015802004-10-03 James R. Leu <jleu at mindspring.com>
1581
1582 * ospf_zebra.c: Read router id related messages from zebra daemon.
1583 Schedule router-id update thread if it's changed.
1584 * ospfd.c: Remove own router-id selection function. Use router id from
1585 zebra daemon if it isn't manually overriden in configuration.
1586
paul68defd62004-09-27 07:27:13 +000015872004-09-27 Paul Jakma <paul@dishone.st>
1588
paul6a99f832004-09-27 12:56:30 +00001589 * ospf_dump.c: (ospf_ip_header_dump) Use HAVE_IP_HDRINCL_BSD_ORDER
1590 Apply to offset too. Print ip_cksum, lets not worry about
1591 possible 2.0.37 compile problems.
1592 * ospf_packet.c: (ospf_swap_iph_to{n,h}) Use
1593 HAVE_IP_HDRINCL_BSD_ORDER.
1594 (ospf_recv_packet) ditto.
1595 (ospf_write) Fixup iov argument to ospf_write_frags.
1596 (struct msghdr).msg_name is caddr_t on most platforms.
paul68defd62004-09-27 07:27:13 +00001597 (ospf_recv_packet) ditto. And msg_flags is not always there
1598 memset struct then set fields we care about rather than
1599 initialise all fields individually.
1600
hassoc9e52be2004-09-26 16:09:34 +000016012004-09-26 Hasso Tepper <hasso at quagga.net>
1602
1603 * ospf_abr.c, ospf_dump.c, ospf_lsa.c, ospf_packet.c, ospf_vty.c,
1604 ospf_zebra.c: Fix compiler warnings.
1605
paul87d6f872004-09-24 08:01:38 +000016062004-09-24 Paul Jakma <paul@dishone.st>
1607
1608 * ospf_apiserver.{c,h}: lists typedef removal cleanup.
1609 update some list loops to LIST_LOOP. some miscellaneous indent
1610 fixups.
1611 (ospf_apiserver_unregister_opaque_type) fix listnode_delete of
1612 referenced node in loop.
paul1603c062004-09-24 08:23:24 +00001613 (ospf_apiserver_term) loops calling ospf_apiserver_free, which
1614 deletes referenced nodes from apiserver_list, fixed.
paul87d6f872004-09-24 08:01:38 +00001615 * ospf_interface.h: lists typedef removal cleanup.
1616 * ospf_opaque.{c,h}: lists typedef removal cleanup. update some list
1617 loops to LIST_LOOP. miscellaneous style and indent fixups.
1618 * ospf_te.{c,h}: ditto
1619 * ospf_packet.c: lists typedef removal cleanup.
paula2570682004-09-24 08:09:57 +00001620 (ospf_write) ifdef fragmentation support. move actual
1621 fragmentation out to a new, similarly ifdefed, function.
1622 (ospf_write_frags) fragmented write support, moved from previous.
paul87d6f872004-09-24 08:01:38 +00001623
hasso52dc7ee2004-09-23 19:18:23 +000016242004-09-23 Hasso Tepper <hasso at quagga.net>
1625
1626 * *.[c|h]: list -> struct list *, listnode -> struct listnode *.
1627
paul68b73392004-09-12 14:21:37 +000016282004-09-12 Paul Jakma <paul@dishone.st>
1629
1630 * ospf_packet.c: Fix bugzilla #107
1631 (ospf_packet_max) get rid of the magic 88 constant
1632 (ospf_swab_iph_ton) new function. set ip header to network order,
1633 taking BSDisms into account.
1634 (ospf_swab_iph_toh) the inverse.
1635 (ospf_write) Add support for IP fragmentation, will only work on
1636 linux though, other kernels make it impossible. get rid of the
1637 magic 4 constant.
1638 (ospf_make_ls_upd) Bound check to end of stream, not to
1639 interface mtu.
1640 (ospf_ls_upd_packet_new) New function, allocate upd packet
1641 taking oversized LSAs into account.
1642 (ospf_ls_upd_queue_send) use ospf_ls_upd_packet_new to allocate,
1643 rather than statically allocating mtu sized packet buffer, which
1644 actually was wrong - it didnt take ip header into account, which
1645 should not be included in packet buffer.
1646 (ospf_ls_upd_send_queue_event) minor tweaks and remove
1647 TODO comment.
1648
gdt630e4802004-08-31 17:28:41 +000016492004-08-31 David Wiggins <dwiggins@bbn.com>
1650
1651 * ospf_spf.c (ospf_spf_calculate): Many more comments and debug
1652 print statements. New function ospf_vertex_dump used in debugging.
1653
16542004-08-31 David Wiggins <dwiggins@bbn.com>
1655
1656 * ospf_spf.h (struct vertex): Comments for flags and structure members.
1657
16582004-08-31 David Wiggins <dwiggins@bbn.com>
1659
1660 * ospf_route.c: When finding an alternate route, log cost as well.
1661
16622004-08-31 David Wiggins <dwiggins@bbn.com>
1663
1664 * ospf_interface.c (ospf_lookup_if_params): Initialize af in
1665 struct prefix allocated on stack.
1666
16672004-08-31 David Wiggins <dwiggins@bbn.com>
1668
1669 * ospf_packet.c (ospf_ls_ack_send_delayed): In p2mp mode, send
1670 acks to AllSPFRouters, rather than All-DR.
1671
hasso7b901432004-08-31 13:37:42 +000016722004-08-27 Hasso Tepper <hasso at quagga.net>
1673
1674 * ospf_vty.c: Don't print ospf network type under interface only
1675 if interface is in broadcast mode and interface type really is
1676 broadcast. Fixes Bugzilla #108.
1677
gdtd7d93992004-08-27 12:03:42 +000016782004-08-27 David Wiggins <dwiggins@bbn.com>
1679
1680 * ospf_spf.c (ospf_nexthop_calculation): Initialize address family
1681 in on-stack struct prefix_ipv4. Fixes point-to-multipoint SPF
1682 calculation.
1683
gdtd0deca62004-08-26 13:14:07 +000016842004-08-26 Greg Troxel <gdt@fnord.ir.bbn.com>
1685
1686 * ospf_packet.c (ospf_recv_packet): adjust size declaration of
gdtd7d93992004-08-27 12:03:42 +00001687 buffer used to get interface index so that it compiles on other
1688 than Linux and includes the required alignment space. Probably
1689 this was only working on sparc/sparc64 because most of
1690 sockaddr_dl was not being written.
gdtd0deca62004-08-26 13:14:07 +00001691
paul863082d2004-08-19 04:43:43 +000016922004-08-19 Paul Jakma <paul@dishone.st>
1693
1694 * ospf_packet.c: update to match sockopt renames.
1695
paul75ee0b82004-08-05 09:10:31 +000016962004-08-04 Paul Jakma <paul@dishone.st>
1697
1698 * ospf_spf.c: (ospf_spf_consider_nexthop) Add comment about issue.
1699 Compare only against list head - all nexthops must be same cost
1700 anyway, fixes a reference-listnode-after-delete bug noted by
1701 Kir Kostuchenko.
1702 (ospf_nexthop_calculation) Use ospf_spf_consider_nexthop for all
1703 candidates attached to root.
1704
paul36c64ef2004-07-27 11:19:11 +000017052004-07-27 Paul Jakma <paul@dishone.st>
1706
paul48fe13b2004-07-27 17:40:44 +00001707 * ospf_packet.c: (ospf_ls_upd_send_queue_event) fix thinko from
1708 last fix for ospfd wedging due to oversize LSAs: dont list loop on
1709 ospf_ls_upd_queue_send() - guaranteed segfault.
1710
17112004-07-27 Paul Jakma <paul@dishone.st>
1712
paul36c64ef2004-07-27 11:19:11 +00001713 * ospf_opaque.c: (ospf_opaque_lsa_flush_schedule) do not NULL out
1714 the LSA as then free_opaque_info_per_id() can never unlock (and
1715 free) the LSA. Reported by Gunnar Stigen.
1716
paul2dd8bb42004-07-23 15:13:48 +000017172004-07-23 Paul Jakma <paul@dishone.st>
1718
1719 * ospf_network.c: Replace PKTINFO/RECVIF with call to
1720 setsockopt_pktinfo
1721 * ospf_packet.c: Use getsockopt_pktinfo_ifindex and
1722 SOPT_SIZE_CMSG_PKTINFO_IPV4.
1723
paul59ea14c2004-07-14 20:50:36 +000017242004-07-14 Paul Jakma <paul@dishone.st>
1725
1726 * ospf_packet.c: (ospf_ls_upd_send_queue_event) Partial fix for
1727 problem reported by Peter Frost amongst others, where function
1728 will spin indefinitely if update list contains LSAs greater than
1729 MTU-headers or other condition leading to update list never being
1730 cleared. Problem of what to do with these LSAs remains.
1731 (ospf_make_ls_upd) add comment about large LSA problem,
1732 indentation cleanup.
1733
gdtb2c1b282004-07-01 12:35:36 +000017342004-07-01 Greg Troxel <gdt@fnord.ir.bbn.com>
1735
1736 * Makefile.am (lib_LTLIBRARIES): make libospf shared
1737
gdt87efd642004-06-30 17:36:11 +000017382004-06-30 Greg Troxel <gdt@poblano.ir.bbn.com>
1739
1740 * Makefile.am: Add shlib support.
1741
hassobeebba72004-06-20 21:00:27 +000017422004-06-10 Hasso Tepper <hasso@estpak.ee>
1743
1744 * *: Removed ifdefs HAVE_NSSA.
1745
paul553ff112004-06-06 09:41:00 +000017462004-06-06 Paul Jakma <paul@dishone.st>
1747
1748 * ospf_dump.c,ospf_lsa.c: Fix typos of merge of previous.
1749 ospf_flood.c: (ospf_process_self_originated_lsa) fix zlog format
1750
paul0c2be262004-05-31 14:16:54 +000017512004-05-31 Sagun Shakya <sagun.shakya@sun.com>
1752
1753 * ospf_dump.c: (ospf_lsa_header_dump) LOOKUP can return null if
1754 index is out of range.
1755 ospf_flood.c: endianness fix
1756 ospf_lsa.c: Missing ntohl's on (struct lsa *)->data->ls_seqnum
1757 in various places.
1758
hassodd669bb2004-05-10 07:43:59 +000017592004-05-10 Hasso Tepper <hasso@estpak.ee>
1760
1761 * ospf_zebra.c, ospfd.c: Move ospf_prefix_list_update() function
1762 to ospf_zebra.c from ospfd.c and add redistribution updates if
1763 route-map is used in redistribution.
1764 * ospf_main.c: Remove now useless call to ospf_init().
1765
paul0a589352004-05-08 11:48:26 +000017662004-05-08 Paul Jakma <paul@dishone.st>
1767
1768 * ospf_zebra.c: Sync with lib/zclient changes
1769
pauld3f0d622004-05-05 15:27:15 +000017702004-05-05 Paul Jakma <paul@dishone.st>
1771
paul5bd41892004-05-05 17:29:24 +00001772 * ospf_network.c: (ospf_sock_init) Check whether IP_HDRINCL is
1773 defined. Warn at compile and runtime. Use
1774 IPTOS_PREC_INTERNETCONTROL otherwise.
pauld3f0d622004-05-05 15:27:15 +00001775 * ospf_packet.c: (ospf_associate_packet_vl) cleanup, move
1776 some of the checks up to ospf_read, return either a
1777 virtual link oi, or NULL.
1778 (ospf_read) Cleanup, make it responsible for checks. Remove
1779 the nbr lookup - moved to ospf_neighbor. Adjust all nbr
1780 lookups to use new wrappers exported by ospf_neighbor.
1781 * ospf_neighbor.h: Add ospf_neigbour_get and ospf_nbr_lookup.
1782 * ospf_neighbor.c: (ospf_neigbour_get) Index ospf_interface
1783 neighbour table by router-id for virtual-link ospf_interfaces,
1784 not by peer_addr (which breaks for asymmetric vlinks)
1785 (ospf_nbr_lookup) add a wrapper for nbr lookups to deal with
1786 above.
paulcd59da62004-05-05 17:26:55 +00001787 * ospf_interface.c: (ospf_vl_set_params) Catch changes of interface
1788 address for either end of a virtual-link, and hence potential cost
1789 changes.
1790
hassoa0a39762004-04-23 08:51:10 +000017912004-04-22 Hasso Tepper <hasso@estpak.ee>
1792
1793 * ospf_zebra.c: Don't ignore reject/bh routes, it's the only way
1794 to "summarize" routes in ASBR at the moment.
1795
hasso8585d4e2004-04-20 17:25:12 +000017962004-04-20 Hasso Tepper <hasso@estpak.ee>
1797
1798 * ospfd.c: Unset NP flag if area is going to be normal or stub.
1799 Fixes UNH OSPF_NSSA.1.2a comment.
1800 * ospf_abr.c: Originate default into stub/nssa area even if
1801 summaries are disabled.
1802 * ospf_zebra.c: Don't attempt to redistribute 127.0.0.0/8.
1803
hassoc266ac72004-04-19 17:31:00 +000018042004-04-19 Hasso Tepper <hasso@estpak.ee>
1805
1806 * ospf_vty.c: Don't warn that export- and import-list can't be
1807 configured to backbone area if they are applied and are working
1808 fine.
1809
hasso128d31d2004-04-04 12:52:33 +000018102004-02-19 Sowmini Varadhan <sowmini.varadhan@sun.com>
1811
1812 * ospf_packet.c: Don't drop packets in Solaris x86.
1813 [quagga-dev 1005].
1814
hasso0d85b992004-03-18 19:18:33 +000018152004-03-18 Amir Guindehi <amir@datacore.ch>
1816
1817 * ospf_opaque.c: Attempt to correct the incorrect behavior of
1818 Quagga's ospfd in the special situation that a node's opaque
1819 capability has changed as "ON -> OFF -> ON". [quagga-dev 843].
1820
paul7f352b82004-02-19 19:37:47 +000018212004-02-19 Sowmini Varadhan <sowmini.varadhan@sun.com>
1822
1823 * ospf_abr.c: (ospf_abr_update_aggregate) UNH 3.12b,c, address range
1824 should be configured with the highest cost path within the range,
1825 not lowest.
1826
paul940b01a2004-02-17 20:07:30 +000018272004-02-17 Paul Jakma <paul@dishone.st>
1828
1829 * ospf_zebra.c: (ospf_interface_delete) Do not delete the interface
1830 params, nor the interface structure, if an interface delete
1831 message is received from zebra.
1832 * ospf_interface.c: (ospf_if_delete_hook) Delete the interface
1833 params and interface, ie that which was previously removed in
1834 (ospf_interface_delete) above.
1835
hasso2db3d052004-02-11 21:52:13 +000018362004-02-11 Hasso Tepper <hasso@estpak.ee>
1837 * ospf_interface.c, ospf_zebra.c: Don't attempt to read path->oi->ifp
1838 if oi doesn't exist any more.
1839
hassocb05eb22004-02-11 21:10:19 +000018402004-02-11 Vadim Suraev <vadim.suraev@terayon.com>
1841 * ospf_packet.c (ospf_ls_upd): Router should flush received network
1842 LSA if it was originated with older router-id ([zebra 14710] #6).
1843
18442003-12-08 Mattias Amnefelt <mattiasa@kth.se>
paul239aecc2003-12-08 10:34:54 +00001845
1846 * ospf_packet.c: (ospf_recv_packet) OpenBSD now leaves iph.ip_len
1847 network byte order.
1848
gdt8f40e892003-12-05 14:01:43 +000018492003-12-05 Greg Troxel <gdt@poblano.ir.bbn.com>
1850
1851 * ospfd.c (ospf_network_match_iface): Rewrite code for clarity
1852 while trying not to change semantics. Add ifdefed-out code to
1853 avoid matching ppp interfaces whose destination address does not
1854 also match the prefix under consideration, to help out people with
1855 problems due to as-yet-unfixed bugs with p2p interfaces coming and
1856 going.
1857
paul736d3442003-07-24 23:22:57 +000018582003-07-25 kamatchi soundaram <kamatchi@tdd.sj.nec.com>
1859
1860 * ospf_packet.c (ospf_ls_upd_send_queue_event): get next route
1861 node in body of the loop to avoid chance that route node
1862 is unlocked and deleted before the next iteration tries to
1863 get next route node.
1864
paul0a825c72003-05-24 13:48:16 +000018652003-05-24 Kenji Yabuuchi
1866
1867 * ospf_interface.c(ospf_if_lookup_recv_if): Use the most specific
1868 match for interface lookup.
1869
paul551a8972003-05-18 15:22:55 +000018702003-05-18 Hasso Tepper <hasso@estpak.ee>
paul445f1432003-05-16 19:00:31 +00001871
paul551a8972003-05-18 15:22:55 +00001872 * ospf_vty.c: Show NSSA LSA route info in "show ip ospf database"
1873 output
paul445f1432003-05-16 19:00:31 +00001874
pauld7480322003-05-16 17:31:51 +000018752003-05-16 Hasso Tepper <hasso@estpak.ee>
1876
1877 * ospf_lsa.c: Fix handling of NSSA
1878
paul551a8972003-05-18 15:22:55 +000018792003-04-23 Hasso Tepper <hasso@estpak.ee>
1880
1881 * ospf_vty.c: fix "router xxx" node commands in vtysh
1882
paul445f1432003-05-16 19:00:31 +000018832003-04-19 Hasso Tepper <hasso@estpak.ee>
1884
1885 * {ospf_abr,ospfd}.c: area id's DECIMAL -> ADDRESS
1886 * ospf_routemap.c: sync daemon's route-map commands to have same
1887 syntax.
1888
18892003-04-19 Sergey Vyshnevetskiy <serg@vostok.net>
1890
1891 * ospf_packet.c: Add missing param to zlog
1892 * ospf_flood.c: remove unused vars
1893
18942003-04-17 Denis Ovsienko <zebra@pilot.org.ua>
1895
1896 * ospf_interface.c: fix incorrect memset
1897
paul28a13842003-05-16 20:30:37 +000018982003-04-10 Amir Guindehi <amir@datacore.ch>
paul445f1432003-05-16 19:00:31 +00001899
1900 * ospf_lsa.[ch]: opaque LSA fix, use ospf_lookup.
1901
19022003-04-03 David Watson <dwatson@eecs.umich.edu>
1903
1904 * ospf_lsa.c: byte order fix
1905
paul07661cb2003-03-18 00:03:05 +000019062002-03-17 Amir Guindehi <amir@datacore.ch>
1907
1908 * ospf_apiserver.[ch]: Merge Ralph Keller's OSPFAPI support.
1909 * ospf_api.[ch]: Merge Ralph Keller's OSPFAPI support.
1910 * ospfclient: OSPFAPI demonstration client.
1911
19122003-01-23 Masahiko Endo <endo@suri.co.jp>
1913
1914 * ospf_ism.c: NSM event schedule bug fix.
1915
19162002-10-30 Greg Troxel <gdt@ir.bbn.com>
1917
1918 * ospf_packet.c (ospf_make_md5_digest): MD5 length fix.
1919
paul718e3742002-12-13 20:15:29 +000019202002-10-23 endo@suri.co.jp (Masahiko Endo)
1921
1922 * ospf_opaque.c: Update Opaque LSA patch.
1923
19242002-10-23 Ralph Keller <keller@tik.ee.ethz.ch>
1925
1926 * ospf_vty.c (show_ip_ospf_database): Fix CLI parse.
1927
19282002-10-23 Juris Kalnins <juris@mt.lv>
1929
1930 * ospf_interface.c (ospf_if_stream_unset): When write queue
1931 becomes empty stop write timer.
1932
19332002-10-10 Greg Troxel <gdt@ir.bbn.com>
1934
1935 * ospf_packet.c (ospf_check_md5_digest): Change >= to > to make it
1936 conform to RFC.
1937
19382002-07-07 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1939
1940 * zebra-0.93 released.
1941
19422002-06-19 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1943
1944 * ospf_spf.c (ospf_nexthop_calculation): Add NULL set to oi and
1945 check of l2. Reported by: Daniel Drown <dan-zebra@drown.org>
1946 (ospf_lsa_has_link): LSA Length calculation fix. Reported by:
1947 Paul Jakma <paulj@alphyra.ie>.
1948
1949 * ospfd.c (ospf_if_update): Fix nextnode reference bug. Reported
1950 by: juris@mt.lv.
1951
19522002-01-21 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1953
1954 * ospfd.c: Merge [zebra 11445] Masahiko ENDO's Opaque-LSA support.
1955
19562001-08-27 Kunihiro Ishiguro <kunihiro@zebra.org>
1957
1958 * ospf_interface.c (ospf_add_to_if): Use /32 address to register
1959 OSPF interface information.
1960 (ospf_delete_from_if): Likewise.
1961
1962 * ospf_zebra.c (ospf_interface_address_delete): Likewise.
1963
19642001-08-23 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1965
1966 * ospf_zebra.c (ospf_redistribute_unset): When redistribute type
1967 is OSPF, do not unset redistribute flag.
1968
19692001-08-19 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1970
1971 * zebra-0.92a released.
1972
19732001-08-15 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1974
1975 * zebra-0.92 released.
1976
19772001-08-12 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1978
1979 * ospfd.c (ospf_config_write): auto-cost reference-bandwidth
1980 configuration display.
1981
19822001-07-24 David Watson <dwatson@eecs.umich.edu>
1983
1984 * ospf_spf.c (ospf_spf_next): Modify ospf_vertex_add_parent to
1985 check for an existing link before connecting the parent and child.
1986 ospf_nexthop_calculation is also modified to check for duplicate
1987 entries when copying from the parent. Finally, ospf_spf_next
1988 removes duplicates when it merges two equal cost candidates.
1989
19902001-07-23 itojun@iijlab.net
1991
1992 * ospfd.c (show_ip_ospf_neighbor): Check ospf_top before use it
1993 [zebra 8549].
1994
19952001-07-23 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1996
1997 * ospf_packet.c (ospf_write): Remove defined(__OpenBSD__) to make
1998 it work on OpenBSD.
1999
20002001-06-26 Kunihiro Ishiguro <kunihiro@zebra.org>
2001
2002 * ospf_zebra.c (config_write_ospf_default_metric): Display
2003 default-metric configuration.
2004
20052001-06-18 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
2006
2007 * ospf_ia.h (OSPF_EXAMINE_SUMMARIES_ALL): Remove old macros.
2008
20092001-05-28 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
2010
2011 * ospf_snmp.c (ospfIfEntry): Fix interface lookup bug to avoid
2012 crush.
2013 (ospfIfMetricEntry): Likewise.
2014
20152001-03-18 Kunihiro Ishiguro <kunihiro@zebra.org>
2016
2017 * ospf_packet.c (ospf_read): Fix typo. Reported by: "Jen B
2018 Lin'Kova" <jen@stack.net>.
2019
20202001-03-15 Gleb Natapov <gleb@nbase.co.il>
2021
2022 * ospf_interface.c (ip_ospf_network): Set interface parameter.
2023 (interface_config_write): Add check for OSPF_IFTYPE_LOOPBACK.
2024
2025 * ospf_zebra.c (ospf_interface_add): Set interface parameter.
2026
20272001-02-21 Kunihiro Ishiguro <kunihiro@zebra.org>
2028
2029 * ospf_packet.c (ospf_recv_packet): Solaris also need to add
2030 (iph.ip_hl << 2) to iph.ip_len.
2031
20322001-02-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2033
2034 * ospfd.h (OSPF_LS_REFRESH_TIME): Fix OSPF_LS_REFRESH_TIME value.
2035 Suggested by: David Watson <dwatson@eecs.umich.edu>.
2036
2037 * ospf_zebra.c (zebra_init): Remove zebra node.
2038
2039 * ospfd.c (ospf_area_range_set): Function name is changed from
2040 ospf_ara_range_cmd.
2041 (ospf_area_range_unset): New function which separated from DEFUN.
2042 New commands are added:
2043 "no area A.B.C.D range A.B.C.D/M advertise"
2044 "no area <0-4294967295> range A.B.C.D/M advertise"
2045 "no area A.B.C.D range A.B.C.D/M not-advertise"
2046 "no area <0-4294967295> range A.B.C.D/M not-advertise"
2047
2048 * ospf_lsa.c (ospf_lsa_more_recent): Fix previous change.
2049
20502001-02-08 Matthew Grant <grantma@anathoth.gen.nz>
2051
2052 * ospf_network.c (ospf_if_add_allspfrouters): Use
2053 setsockopt_multicast_ipv4.
2054 (ospf_if_drop_allspfrouters): Likewise.
2055
2056 * ospf_lsa.c (ospf_router_lsa_install): Add rt_recalc flag.
2057 (ospf_network_lsa_install): Likewise.
2058 (ospf_summary_lsa_install): Likewise.
2059 (ospf_summary_asbr_lsa_install): Likewise.
2060 (ospf_external_lsa_install): Likewise.
2061 (ospf_lsa_install): Call ospf_lsa_different to check this LSA is
2062 new one or not.
2063
20642001-02-08 Kunihiro Ishiguro <kunihiro@zebra.org>
2065
2066 * ospf_zebra.c (ospf_interface_delete): Do not free interface
2067 structure when ospfd receive interface delete message to support
2068 pseudo interface.
2069
20702001-02-01 Dick Glasspool <dick@ipinfusion.com>
2071
2072 * ospfd.c (area_range_notadvertise): Change area range "suppress"
2073 command to "not-advertise".
2074
2075 * ospfd.h (OSPF_LS_REFRESH_TIME): Change OSPF_LS_REFRESH_TIME from
2076 1800 to 60.
2077
2078 * ospf_abr.c (ospf_abr_update_aggregate): When update_aggregate is
2079 updating the area-range, the lowest cost is now saved.
2080
2081 * ospf_lsa.c (ospf_lsa_more_recent): Routing to compare sequence
2082 numbers rather than creating overflow during calculation.
2083
20842001-02-01 Kunihiro Ishiguro <kunihiro@zebra.org>
2085
2086 * zebra-0.91 is released.
2087
20882001-01-31 Kunihiro Ishiguro <kunihiro@zebra.org>
2089
2090 * ospf_packet.c (ospf_db_desc_proc): Do not continue process when
2091 NSM_SeqNumberMismatch is scheduled.
2092 (ospf_ls_req): Free ls_upd when return from this function.
2093 (ospf_ls_upd_timer): When update list is empty do not call
2094 ospf_ls_upd_send(). Suggested by: endo@suri.co.jp (Masahiko
2095 Endo).
2096
20972001-01-26 Kunihiro Ishiguro <kunihiro@zebra.org>
2098
2099 * ospf_lsa.c (ospf_maxage_flood): Flood LSA when it reaches
2100 MaxAge. RFC2328 Section 14.
2101 (ospf_maxage_lsa_remover): Call above function during removing
2102 MaxAge LSA.
2103
21042001-01-26 Dick Glasspool <dick@ipinfusion.com>
2105
2106 * ospf_flood.c (ospf_flood_through_as): Function is updated for
2107 NSSA Translations now done at ospf_abr.c with no change in P-bit.
2108
2109 * ospf_lsa.c (ospf_get_nssa_ip): Get 1st IP connection for Forward
2110 Addr.
2111 (ospf_install_flood_nssa): Leave Type-7 LSA at Lock Count = 2.
2112
2113 * ospf_ase.c (ospf_ase_calculate_route): Add debug codes.
2114
2115 * ospf_abr.c (ospf_abr_translate_nssa): Recalculate LSA checksum.
2116
2117 * ospf_packet.h (OSPF_SEND_PACKET_LOOP): Added for test packet.
2118
2119 * ospf_dump.c (ospf_lsa_type_msg): Add OSPF_GROUP_MEMBER_LSA and
2120 OSPF_AS_NSSA_LSA.
2121
2122 * ospfd.c (data_injection): Function to inject LSA. This is
2123 debugging command.
2124
21252001-01-11 Kunihiro Ishiguro <kunihiro@zebra.org>
2126
2127 * ospf_route.c (ospf_route_match_same): Remove function.
2128 (ospf_route_match_same_new): Renamed to ospf_route_match_same.
2129
2130 * ospf_zebra.c (ospf_interface_address_delete): Add check for
2131 oi->address. Suggested by Matthew Grant
2132 <grantma@anathoth.gen.nz>.
2133 (ospf_zebra_add): Remove function.
2134 (ospf_zebra_add_multipath): Rename to ospf_zebra_add.
2135
2136 * ospf_interface.c: Remove HAVE_IF_PSEUDO part.
2137
2138 * ospf_zebra.c: Likewise.
2139
21402001-01-10 Kunihiro Ishiguro <kunihiro@zebra.org>
2141
2142 * ospf_ase.c: Remove OLD_RIB part.
2143
2144 * ospf_route.c: Likewise.
2145
2146 * zebra-0.90 is released.
2147
2148 * ospf_packet.c (ospf_recv_packet): Use ip_len adjestment code to
2149 NetBSD.
2150
21512001-01-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2152
2153 * ospf_route.c (ospf_route_delete): Use
2154 ospf_zebra_delete_multipath.
2155
21562001-01-09 Matthew Grant <grantma@anathoth.gen.nz>
2157
2158 * ospf_interface.c (ospf_if_cleanup): Function name is renamed
2159 from ospf_if_free(). Rewrite whole procudure to support primary
2160 address deletion.
2161
2162 * ospf_zebra.c (ospf_interface_address_delete): Add primary
2163 address deletion process.
2164
21652001-01-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2166
2167 * ospf_packet.c (ospf_recv_packet): OpenBSD has same ip_len
2168 treatment like FreeBSD.
2169
21702001-01-09 endo@suri.co.jp (Masahiko Endo)
2171
2172 * ospf_packet.c (ospf_recv_packet): FreeBSD kernel network code
2173 strips IP header size from receiving IP Packet. So we adjust
2174 ip_len to whole IP packet size by adding IP header size.
2175
21762001-01-08 endo@suri.co.jp (Masahiko Endo)
2177
2178 * ospf_network.c (ospf_serv_sock): When socket() is failed return
2179 immediately.
2180 (ospf_serv_sock): Close socket when it is not used.
2181
2182 * ospf_packet.c (ospf_write): Set sin_len when HAVE_SIN_LEN is
2183 defined.
2184 (ospf_write): When bind is fined, close sock.
2185
21862001-01-07 Gleb Natapov <gleb@nbase.co.il>
2187
2188 * ospf_zebra.c (ospf_interface_state_up): Fixes coredump that
2189 appears when you try to configure bandwidth on the ppp interface
2190 that is not yet configured in ospfd.
2191
21922001-01-07 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2193
2194 * ospf_route.c (show_ip_ospf_route_external): "show ip ospf route"
2195 will print nexthops for AS-external routes.
2196
2197 * ospf_ase.c (ospf_ase_route_match_same): New function to compare
2198 ASE route under multipath environment.
2199 (ospf_ase_compare_tables): Likewise.
2200
22012001-01-01 Kunihiro Ishiguro <kunihiro@zebra.org>
2202
2203 * ospfd.h (OSPF_VTYSH_PATH): Change "/tmp/ospfd" to "/tmp/.ospfd".
2204
22052000-12-28 Kunihiro Ishiguro <kunihiro@zebra.org>
2206
2207 * ospf_route.c (ospf_route_install): Install multipath information
2208 to zebra daemon.
2209
2210 * ospf_zebra.c (ospf_zebra_add_multipath): Function for passing
2211 multipath information to zebra daemon.
2212
22132000-12-25 Dick Glasspool <dick@ipinfusion.com>
2214
2215 * ospf_packet.c (ospf_write): Call ospf_packet_delete when sendto
2216 fail.
2217 (DISCARD_LSA): Add argument N for logging point of DISCARD_LSA is
2218 called.
2219
2220 * ospf_lsa.c (ospf_external_lsa_refresh): NSSA install_flood will
2221 leave Type-7 LSA at Lock Count = 2.
2222
2223 * ospf_flood.c (ospf_flood_through): Flood_though_as updated for
2224 NSSA no P-bit off during Area flooding, but P-bit is turned off
2225 for mulitple NSSA AS flooding.
2226
2227 * ospf_ase.c (ospf_ase_calculate_timer): Added calculations for
2228 Type-7 LSDB.
2229
2230 * ospf_abr.c (ospf_abr_translate_nssa): Removed one unlock call.
2231 (ospf_abr_announce_nssa_defaults): Corrected Debug from EVENT to
2232 NSSA.
2233
22342000-12-25 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2235
2236 * ospf_zebra.c (ospf_zebra_read_ipv4): Checking the age of the
2237 found LSA and if the LSA is MAXAGE we should call refresh instead
2238 of originate.
2239
22402000-12-18 Dick Glasspool <dick@ipinfusion.com>
2241
2242 * ospf_abr.c: Removed redundant "...flood" in
2243 announce_network_to_area(). Repaired nssa Unlock by using
2244 discard.
2245
2246 * ospf_packet.c: Removed old NSSA translate during mk_ls_update.
2247
2248 * ospfd.c: Free up all data bases including NSSA.
2249
2250 * ospf_lsa.c: Now allow removal of XLATE LSA's Check in
2251 discard_callback. Added routine to get ip addr from within the
2252 ifp.
2253
2254 * ospf_flood.c: Now set Forward Address for outgoing Type-7.
2255
2256 * ospf_lsa.h: Added prototype for the below. struct in_addr
2257 ospf_get_ip_from_ifp (struct interface *ifp).
2258
22592000-12-14 Gleb Natapov <gleb@nbase.co.il>
2260
2261 * ospf_packet.c (ospf_recv_packet): New OSPF pakcet read method.
2262 Now maximum packet length may be 65535 bytes (maximum IP packet
2263 length).
2264
2265 * ospf_interface.c (ospf_if_stream_set): Don't make input buffer.
2266
2267 * ospfd.c (config_write_network_area): Remove unnecessary area
2268 lookup code.
2269
22702000-12-13 Kunihiro Ishiguro <kunihiro@zebra.org>
2271
2272 * ospf_packet.c (ospf_read): Accept packet bigger than MTU value.
2273
22742000-12-13 Gleb Natapov <gleb@nbase.co.il>
2275
2276 * ospfd.c (config_write_network_area): Fix bug in
2277 config_write_network_area function.
2278
22792000-12-12 Gleb Natapov <gleb@nbase.co.il>
2280
2281 * ospf_abr.c (ospf_abr_announce_network_to_area): Make Summary
2282 LSA's origination and refreshment as same as other type of LSA.
2283
2284 * ospf_lsa.c (ospf_summary_lsa_refresh): Return struct ospf_lsa *.
2285
2286 * ospf_lsa.c (ospf_summary_asbr_lsa_refresh): Likewise.
2287
22882000-12-08 Dick Glasspool <dick@ipinfusion.com>
2289
2290 The bulk of NSSA changes are contained herein; This version will
2291 require manual setting of "always" for NSSA Translator, and will
2292 not perform aggregation yet.
2293
2294 * ospf_dump.c: "debug ospf nssa" is added.
2295
2296 * ospf_dump.h: Likewise.
2297
2298 * ospf_packet.c (ospf_hello): Display router ID on Bad NSSA Hello.
2299
2300 * ospfd.c: Discard_LSA to stay away from LOCAL_XLT Process NSSA
2301 'never, candidate, always'. Change "suppress" to "not-advertise".
2302
2303 * ospfd.h: Add TranslatorRole to struct ospf_area. Add anyNSSA to
2304 struct ospf.
2305
2306 * ospf_ase.c (ospf_ase_calculate_route): External to stay away
2307 from LOCAL_XLT
2308
2309 * ospf_nsm.c (ospf_db_summary_add): External to stay away from
2310 LOCAL_XLT
2311
2312 * ospf_abr.c: Major logic added for abr_nssa_task(). If ABR, and
2313 NSSA translator, then do it. Approve the global list, and flush
2314 any unapproved.
2315
2316 * ospf_lsa.h: New LSA flag OSPF_LSA_LOCAL_XLT to indicate that the
2317 Type-5 resulted from a Local Type-7 translation; not used for
2318 flooding, but used for flushing.
2319
2320 * ospf_flood.c: New NSSA flooding.
2321
23222000-12-08 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2323
2324 * ospfd.c (ospf_find_vl_data): New function for looking up virtual
2325 link data.
2326 (ospf_vl_set_security): Virtual link configuration with
2327 authentication.
2328 (ospf_vl_set_timers): Set timers for virtual link.
2329
2330 * New commands are added.
2331 "area A.B.C.D virtual-link A.B.C.D"
2332 "area A.B.C.D virtual-link A.B.C.D hello-interval <1-65535> retransmit-interval <3-65535> transmit-delay <1-65535> dead-interval <1-65535>"
2333 "area A.B.C.D virtual-link A.B.C.D hello-interval <1-65535> retransmit-interval <3-65535> transmit-delay <1-65535> dead-interval <1-65535> authentication-key AUTH_KEY"
2334 "area A.B.C.D virtual-link A.B.C.D authentication-key AUTH_KEY"
2335 "area A.B.C.D virtual-link A.B.C.D hello-interval <1-65535> retransmit-interval <3-65535> transmit-delay <1-65535> dead-interval <1-65535> message-digest-key <1-255> md5 KEY"
2336 "area A.B.C.D virtual-link A.B.C.D message-digest-key <1-255> md5 KEY"
2337
2338 * ospf_packet.c (ospf_check_md5_digest): Add neighbor's
2339 cryptographic sequence number treatment.
2340 (ospf_check_auth): OSPF input buffer is added to argument.
2341 (ospf_read): Save neighbor's cryptographic sequence number.
2342
2343 * ospf_nsm.c (nsm_change_status): Clear cryptographic sequence
2344 number when neighbor status is changed to NSM down.
2345
2346 * ospf_neighbor.c (ospf_nbr_new): Set zero to crypt_seqnum.
2347
2348 * ospf_neighbor.h (struct ospf_neighbor): Add cryptographic
2349 sequence number to neighbor structure.
2350
23512000-11-29 Kunihiro Ishiguro <kunihiro@zebra.org>
2352
2353 * ospf_snmp.c (ospfIfLookup): OSPF MIB updates.
2354 (ospfExtLsdbEntry): Add OspfExtLsdbTable treatment.
2355
23562000-11-28 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2357
2358 * ospfd.c (ospf_interface_down): Clear a ls_upd_queue queue of the
2359 interface.
2360 (ospf_ls_upd_queue_empty): New function to empty ls update queue
2361 of the OSPF interface.
2362 (no_router_ospf): 'no router ospf' unregister redistribution
2363 requests from zebra.
2364
23652000-11-28 Kunihiro Ishiguro <kunihiro@zebra.org>
2366
2367 * ospf_ism.c (ism_change_status): Increment status change number.
2368
2369 * ospf_interface.h (struct ospf_interface): Add new member for
2370 status change statistics.
2371
2372 * Makefile.am: Update dependencies.
2373
2374 * ospf_zebra.c (ospf_interface_add): OSPF SNMP interface update.
2375 (ospf_interface_delete): OSPF SNMP interface delete.
2376
2377 * ospf_snmp.h: New file is added.
2378
23792000-11-23 Dick Glasspool <dick@ipinfusion.com>
2380
2381 * ospfd.h: Add new ospf_area structure member for
2382 NSSATranslatorRole and NSSATranslator state.
2383
2384 * ospfd.c: Provided for eventual commands to specify NSSA
2385 elections for "translator- ALWAYS/NEVER/CANDIDATE". Provided for
2386 decimal integer version of area-suppress.
2387
2388 * ospf_flood.c: Flood Type-7's only into NSSA (not AS).
2389
2390 * ospf_lsa.c: Undo some previous changes for NSSA. If NSSA
2391 translator, advertise Nt bit.
2392
2393 * ospf_route.c: 1st version of "sh ip os border-routers".
2394
23952000-11-23 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2396
2397 * ospfd.c (area_vlink): Virtual link can not configured in stub
2398 area.
2399
24002000-11-23 Gleb Natapov <gleb@nbase.co.il>
2401
2402 * ospf_packet.c (ospf_db_desc): In states Loading and Full the
2403 slave must resend its last Database Description packet in response
2404 to duplicate Database Description packets received from the
2405 master. For this reason the slave must wait RouterDeadInterval
2406 seconds before freeing the last Database Description packet.
2407 Reception of a Database Description packet from the master after
2408 this interval will generate a SeqNumberMismatch neighbor
2409 event. RFC2328 Section 10.8
2410 (ospf_make_db_desc): DD Master flag treatment.
2411
2412 * ospf_nsm.c (nsm_twoway_received): Move DD related procedure to
2413 nsm_change_status().
2414 (nsm_bad_ls_req): Likewise.
2415 (nsm_adj_ok): Likewise.
2416 (nsm_seq_number_mismatch): Likewise.
2417 (nsm_oneway_received): Likewise.
2418
2419 * ospf_neighbor.h (struct ospf_neighbor): New structure member
2420 last_send_ts for timestemp when last Database Description packet
2421 was sent.
2422
2423 * ospf_nsm.c (ospf_db_desc_timer): Make it sure nbr->last_send is
2424 there. Call ospf_db_desc_resend() in any case.
2425
24262000-11-16 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2427
2428 * ospf_lsa.c (lsa_link_broadcast_set): When there is no DR on
2429 network (suppose you have only one router with interface priority
2430 0). It's router LSA does not contain the link information about
2431 this network.
2432
2433 * ospf_nsm.c (nsm_timer_set): When you change a priority of
2434 interface from/to 0 ISM_NeighborChange event should be scheduled
2435 in order to elect new DR/BDR on the network.
2436
2437 * ospf_interface.c (ip_ospf_priority): Likewise.
2438
2439 * ospf_flood.c (ospf_ls_retransmit_add): When we add some LSA into
2440 retransmit list we need to check whether the present old LSA in
2441 retransmit list is not more recent than the new
2442 one.
2443
24442000-11-09 Dick Glasspool <dick@ipinfusion.com>
2445
2446 * ospf_packet.c: Allows for NSSA Type-7 LSA's throughout the NSSA
2447 area. Any that exit the NSSA area are translated to type-5 LSA's.
2448 The instantiated image is restored after translation.
2449 (ospf_ls_upd_send_list): Renamed to ospf_ls_upd_queu_send().
2450 (ospf_ls_upd_send): Old function which enclosed by #ifdef 0 is
2451 removed.
2452 (ospf_ls_ack_send): Likewise.
2453
2454 * ospf_flood.c: NSSA-LSA's without P-bit will be restricted to
2455 local area. Otherwise they are allowed out the area to be
2456 translated by ospf_packet.c.
2457
2458 * ospf_lsa.c: Undo some previous changes for NSSA.
2459
2460 * ospf_lsdb.h: New access for type 7.
2461
24622000-11-07 Kunihiro Ishiguro <kunihiro@zebra.org>
2463
2464 * ospf_route.c (ospf_path_exist): New function to check nexthop
2465 and interface are in current OSPF path or not.
2466 (ospf_route_copy_nexthops_from_vertex): Add nexthop to OSPF path
2467 when it is not there. Reported by Michael Rozhavsky
2468 <mrozhavsky@opticalaccess.com>
2469
24702000-11-06 Kunihiro Ishiguro <kunihiro@zebra.org>
2471
2472 * ospf_dump.c (config_write_debug): Add seventh string "detail" is
2473 added for flag is OSPF_DEBUG_SEND | OSPF_DEBUG_RECV |
2474 OSPF_DEBUG_DETAIL.
2475
24762000-11-06 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2477
2478 * ospf_lsa.c (router_lsa_flags): ASBR can't exit in stub area.
2479
24802000-11-06 Kunihiro Ishiguro <kunihiro@zebra.org>
2481
2482 * ospf_lsa.c (ospf_router_lsa_originate): Reduce unconditional
2483 logging.
2484
24852000-11-06 Dick Glasspool <dick@ipinfusion.com>
2486
2487 * ospfd.h: Add ait_ntoa function prototype.
2488
2489 * ospfd.c (ait_ntoa): New function for displaying area ID and
2490 Stub/NSSA status.
2491 (show_ip_ospf_interface_sub): Use ait_ntoa.
2492 (show_ip_ospf_nbr_static_detail_sub): Likewise.
2493 (show_ip_ospf_neighbor_detail_sub): Likewise.
2494
2495 * ospf_route.c (ospf_intra_route_add): Set external routing type
2496 to ospf route.
2497 (ospf_intra_add_router): Likewise.
2498 (ospf_intra_add_transit): Likewise.
2499 (ospf_intra_add_stub): Likewise.
2500 (ospf_add_discard_route): Likewise.
2501 (show_ip_ospf_route_network): Use ait_ntoa.
2502 (show_ip_ospf_route_network): Likewise.
2503 (show_ip_ospf_route_router): Likewise.
2504
2505 * ospf_lsa.c (show_lsa_detail): Use ait_ntoa.
2506 (show_lsa_detail_adv_router): Likewise.
2507 (show_ip_ospf_database_summary): Likewise.
2508
2509 * ospf_route.h (struct route_standard): Add new member
2510 external_routing.
2511
2512 * ospf_ia.c (process_summary_lsa): Set external routing tyep to ospf
2513 route.
2514 (ospf_update_network_route): Likewise.
2515 (ospf_update_router_route): Likewise.
2516
25172000-11-04 Kunihiro Ishiguro <kunihiro@zebra.org>
2518
2519 * ospf_flood.c (ospf_process_self_originated_lsa): Enclose
2520 OSPF_AS_NSSA_LSA treatment with #ifdef HAVE_NSSA.
2521
25222000-11-03 Kunihiro Ishiguro <kunihiro@zebra.org>
2523
2524 * Unconditional logging is enclosed with if (IS_DEBUG_OSPF_EVENT).
2525 Please specify "debug ospf event" for enable logging.
2526
2527 * ospf_ism.c: Do not extern debug flag varible. It is done by
2528 ospf_debug.h
2529 * ospf_asbr.c: Likewise.
2530 * ospf_lsa.c: Likewise.
2531 * ospf_nsm.c: Likewise.
2532 * ospf_zebra.c: Likewise.
2533
2534 * ospf_dump.c (debug_ospf_event): New command "debug ospf event"
2535 is added.
2536
2537 * ospfd.c (router_ospf): Change logging from vty_out() to
2538 zlog_info().
2539 (ospf_area_stub_cmd): Likewise.
2540
2541 * ospf_dump.h: Extern term_debug flags.
2542 (OSPF_DEBUG_EVENT): Add new flag.
2543 (IS_DEBUG_OSPF_EVENT): Add new macro.
2544
25452000-11-03 Dick Glasspool <dick@ipinfusion.com>
2546
2547 * ospf_flood.c (ospf_process_self_originated_lsa):
2548 OSPF_AS_NSSA_LSA is treated as same as OSPF_AS_EXTERNAL_LSA.
2549 (ospf_flood): Type-5's have no change. Type-7's can be received,
2550 and will Flood the AS as Type-5's They will also flood the local
2551 NSSA Area as Type-7's. The LSDB will be updated as Type-5's, and
2552 during re-fresh will be converted back to Type-7's (if within an
2553 NSSA).
2554 (ospf_flood_through): Incoming Type-7's were allowed here if our
2555 neighbor was an NSSA. So Flood our area with the Type-7 and also
2556 if we are an ABR, flood thru AS as Type-5.
2557
2558 * ospf_lsa.c (ospf_external_lsa_refresh): Flood NSSA both NSSA
2559 area and other area.
2560
2561 * ospf_packet.c (ospf_db_desc_proc): When AS External LSA is
2562 exists in DD packet, make it sure that this area is not stub.
2563 (ospf_ls_upd_list_lsa): When LSA type is NSSA then set lsa's area
2564 to NULL.
2565 (ospf_ls_upd): If the LSA is AS External LSA and the area is stub
2566 then discard the lsa. If the LSA is NSSA LSA and the area is not
2567 NSSA then discard the lsa.
2568
25692000-11-03 Kunihiro Ishiguro <kunihiro@zebra.org>
2570
2571 * ospfd.c (ospf_interface_run): Fix bug of Hello packet's option
2572 is not properly set when interface comes up.
2573
25742000-11-02 Kunihiro Ishiguro <kunihiro@zebra.org>
2575
2576 * ospfd.h (OSPF_OPTION_O): Add new hello header option.
2577
25782000-11-01 Dick Glasspool <dick@ipinfusion.com>
2579
2580 * ospf_lsa.h: Define OSPF_MAX_LSA to 8 when HAVE_NSSA is enabled.
2581 (OSPF_GROUP_MEMBER_LSA): Define OSPF_GROUP_MEMBER_LSA.
2582
2583 * ospf_lsa.c (show_database_desc): Add "Group Membership LSA"
2584 string.
2585
25862000-10-31 Dick Glasspool <dick@ipinfusion.com>
2587
2588 * ospf_lsa.h (OSPF_AS_NSSA_LSA): Define OSPF_AS_NSSA_LSA.
2589
2590 * ospf_lsa.c (show_ip_ospf_database): NSSA database display
2591 function is added. ALIASES which have "show ip ospf database
2592 nssa-external" is added.
2593 (show_ip_ospf_border_routers): New command "show ip ospf
2594 border-routers" is added.
2595
25962000-10-30 Dick Glasspool <dick@ipinfusion.com>
2597
2598 * ospfd.c (router_ospf): NSSA Enabled message is added for
2599 testing.
2600 (ospf_area_type_set): Are type set for NSSA area.
2601 (ospf_area_stub_cmd): Special translation of no_summary into NSSA
2602 and summary information. If NSSA is enabled pass the information
2603 to ospf_area_type_set().
2604 (area_nssa): New commands are added:
2605 "area A.B.C.D nssa"
2606 "area <0-4294967295> nssa"
2607 "area A.B.C.D nssa no-summary"
2608 "area <0-4294967295> nssa no-summary"
2609 (ospf_no_area_stub_cmd): Special translation of no_summary into
2610 NSSA and summary information. If external_routing is
2611 OSPF_AREA_NSSA unset area with ospf_area_type_set (area,
2612 OSPF_AREA_DEFAULT).
2613 (show_ip_ospf_area): Display NSSA status.
2614 (config_write_ospf_area): Show NSSA configuration.
2615
2616 * ospf_packet.c (ospf_hello): For NSSA support, ensure that NP is
2617 on and E is off.
2618
26192000-10-26 Gleb Natapov <gleb@nbase.co.il>
2620
2621 * ospf_lsa.c (ospf_network_lsa_body_set): The network-LSA lists
2622 those routers that are fully adjacent to the Designated Router;
2623 each fully adjacent router is identified by its OSPF Router ID.
2624 The Designated Router includes itself in this list. RFC2328,
2625 Section 12.4.2.
2626
26272000-10-23 Jochen Friedrich <jochen@scram.de>
2628
2629 * ospf_snmp.c: ospf_oid and ospfd_oid are used in smux_open after
2630 it is registered. So those variables must be static.
2631
26322000-10-18 K N Sridhar <sridhar@euler.ece.iisc.ernet.in>
2633
2634 * ospfd.c: Add area_default_cost_decimal_cmd and
2635 no_area_default_cost_decimal_cmd alias.
2636
26372000-10-05 Gleb Natapov <gleb@nbase.co.il>
2638
2639 * ospfd.c (ospf_network_new): Fix setting area format.
2640 (no_router_ospf): Check area existance when calling
2641 ospf_interface_down().
2642
2643 * ospf_flood.c (ospf_external_info_check): Fix bug of refreshing
2644 default route.
2645
26462000-10-02 Kunihiro Ishiguro <kunihiro@zebra.org>
2647
2648 * zebra-0.89 is released.
2649
26502000-09-29 Kunihiro Ishiguro <kunihiro@zebra.org>
2651
2652 * ospf_snmp.c (ospfHostEntry): OSPF Host MIB is implemented.
2653
2654 * ospfd.c (ospf_nbr_static_cmp): OSPF neighbor is sorted by it's
2655 address.
2656
26572000-09-28 Michael Rozhavsky <mike@nbase.co.il>
2658
2659 * ospf_interface.c (ospf_if_free): Fix deleting self neighbor twice.
2660
26612000-09-27 Kunihiro Ishiguro <kunihiro@zebra.org>
2662
2663 * ospf_packet.c (ospf_read): Solaris on x86 has ip_len with host
2664 byte order.
2665
26662000-09-25 Toshiaki Takada <takada@zebra.org>
2667
2668 * ospfd.c (ospf_compatible_rfc1583), (no_ospf_compatible_rfc1583):
2669 Add CISCO compatible command.
2670
26712000-09-25 Kunihiro Ishiguro <kunihiro@zebra.org>
2672
2673 * ospf_abr.c (ospf_area_range_lookup): New function is added for
2674 area range lookup in OSPF-MIB.
2675 (ospf_area_range_lookup_next): Likewise.
2676
26772000-09-22 Kunihiro Ishiguro <kunihiro@zebra.org>
2678
2679 * ospfd.c (no_router_ospf): Delete virtual link before deleting
2680 area structure.
2681
2682 * ospf_lsa.c (ospf_external_lsa_refresh_type): Check
2683 EXTERNAL_INFO(type).
2684
2685 * ospfd.c (no_router_ospf): Call ospf_vl_delete() instead of
2686 ospf_vl_data_free().
2687
2688 * ospf_interface.c (ospf_vl_shutdown): Execute ISM_InterfaceDown
2689 when ospf_vl_shutdown is called.
2690 (ospf_vl_delete): Call ospf_vl_shutdown() to delete virtual link
2691 interface's thread.
2692
26932000-09-21 Gleb Natapov <gleb@nbase.co.il>
2694
2695 * ospf_lsa.c: New implementation of OSPF refresh.
2696
26972000-09-20 Kunihiro Ishiguro <kunihiro@zebra.org>
2698
2699 * ospf_snmp.c (ospfLsdbLookup): Add LSDB MIB implementation.
2700
27012000-09-18 Kunihiro Ishiguro <kunihiro@zebra.org>
2702
2703 * ospf_snmp.c (ospfStubAreaEntry): Add OSPF stub area MIB.
2704
27052000-09-18 Gleb Natapov <gleb@nbase.co.il>
2706
2707 * ospf_route.h (route_standard): Change member from `struct area'
2708 to area_id.
2709
2710 * ospf_abr.c (ospf_abr_announce_network), (ospf_abr_should_announce),
2711 (ospf_abr_process_network_rt), (ospf_abr_announce_rtr),
2712 (ospf_abr_process_router_rt):
2713 * ospf_ase.c (ospf_find_asbr_route),
2714 (ospf_find_asbr_router_through_area),
2715 * ospf_ia.c (ospf_find_abr_route), (ospf_ia_router_route),
2716 (process_summary_lsa), (ospf_update_network_route),
2717 (ospf_update_router_route):
2718 * ospf_route.c (ospf_intra_route_add), (ospf_intra_add_router),
2719 (ospf_intra_add_transit), (ospf_intra_add_stub),
2720 (ospf_route_table_dump), (show_ip_ospf_route_network),
2721 (show_ip_ospf_route_router), (ospf_asbr_route_cmp),
2722 (ospf_prune_unreachable_routers):
2723 * ospf_spf.c (ospf_rtrs_print):
2724 * ospfd.c (ospf_rtrs_free): Fix the struct change above.
2725
27262000-09-14 Kunihiro Ishiguro <kunihiro@zebra.org>
2727
2728 * ospf_network.c (ospf_serv_sock_init): Enclose SO_BINDTODEVICE
2729 with ifdef.
2730
27312000-09-13 Gleb Natapov <gleb@nbase.co.il>
2732
2733 * ospf_ism.c (ospf_elect_dr), (ospf_elect_bdr): Fix DR election.
2734
2735 * ospf_network.c (ospf_serv_sock_init): Add socket option
2736 SO_BINDTODEVICE on read socket.
2737
2738 * ospf_packet.c (ospf_hello): Ignore Hello packet if E-bit does
2739 not match.
2740
2741 * ospfd.c (ospf_area_check_free), (ospf_area_get),
2742 (ospf_area_add_if): New function added.
2743
27442000-09-13 Kunihiro Ishiguro <kunihiro@zebra.org>
2745
2746 * ospf_route.c (ospf_intra_add_router): Update ABR and ASBR router
2747 count.
2748
2749 * ospf_spf.c (ospf_spf_init): Rest ABR and ASBR router count
2750 starting SPF calculation.
2751
2752 * ospfd.h (struct ospf_area): Add ABR and ASBR router count.
2753
27542000-09-12 Kunihiro Ishiguro <kunihiro@zebra.org>
2755
2756 * ospfd.c (ospf_area_id_cmp): New area structure is sorted by area
2757 ID.
2758
2759 * ospf_lsa.c (ospf_router_lsa_originate): For OSPF MIB update
2760 lsa_originate_count.
2761 (ospf_network_lsa_originate): Likewise.
2762 (ospf_summary_lsa_originate): Likewise.
2763 (ospf_summary_asbr_lsa_originate): Likewise.
2764 (ospf_external_lsa_originate): Likewise.
2765
27662000-09-11 Kunihiro Ishiguro <kunihiro@zebra.org>
2767
2768 * ospf_snmp.c (ospf_variables): ospfRouterID's type RouterID
2769 syntax is IpAddress.
2770 (ospf_admin_stat): New function for OSPF administrative status
2771 check.
2772
27732000-09-10 Jochen Friedrich <jochen@scram.de>
2774
2775 * ospf_snmp.c: Implement OSPF MIB skeleton.
2776
27772000-09-08 Kunihiro Ishiguro <kunihiro@zebra.org>
2778
2779 * ospf_snmp.c: New file is added.
2780
27812000-09-07 David Lipovkov <davidl@nbase.co.il>
2782
2783 * ospf_zebra.c (ospf_interface_delete): Add pseudo interface
2784 treatment.
2785
2786 * ospf_interface.c (interface_config_write): Likewise.
2787
27882000-08-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2789
2790 * zebra-0.88 is released.
2791
27922000-08-17 Michael Rozhavsky <mike@nbase.co.il>
2793
2794 * ospfd.c (ospf_area_free): Remove virtual link configuration only
2795 when Area is removed.
2796
27972000-08-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2798
2799 * ospfd.c (network_area): Revert check for EXTERNAL_INFO
2800 (ZEBRA_ROUTE_CONNECT).
2801 (no_network_area): Likewise.
2802
28032000-08-16 Kunihiro Ishiguro <kunihiro@zebra.org>
2804
2805 * ospfd.h (struct ospf): Add distance_table and
2806 distance_{all,intra,inter,external}.
2807
2808 * ospf_zebra.c: Add OSPF distance related functions.
2809
28102000-08-15 Gleb Natapov <gleb@nbase.co.il>
2811
2812 * ospf_asbr.c (ospf_external_info_find_lsa): New function added.
2813
2814 * ospf_lsa.c (ospf_default_external_info),
2815 (ospf_default_originate_timer), (ospf_external_lsa_refresh_default):
2816 New function added.
2817
2818 * ospf_zebra.c
2819 (ospf_default_information_originate_metric_type_routemap),
2820 (ospf_default_information_originate_always_metric_type_routemap):
2821 Change name and add route-map function.
2822 (ospf_default_information_originate_metric_routemap),
2823 (ospf_default_information_originate_routemap),
2824 (ospf_default_information_originate_type_metric_routemap):
2825 New DEFUN added.
2826
28272000-08-14 Kunihiro Ishiguro <kunihiro@zebra.org>
2828
2829 * ospf_zebra.c (zebra_interface_if_set_value): Change ifindex
2830 restore size from two octet to four.
2831
28322000-08-14 Michael Rozhavsky <mike@nbase.co.il>
2833
2834 * ospf_ase.c (ospf_ase_incremental_update): Implement incremental
2835 AS-external-LSA in 16.6 of RFC2328.
2836
28372000-08-14 Matthew Grant <grantma@anathoth.gen.nz>
2838
2839 * ospf_interface.c (ospf_if_get_output_cost): Change cost
2840 calculation algorithm.
2841
2842 * ospf_packet (ospf_ls_upd): Fix problem of LSA retransmitting.
2843
28442000-08-11 Michael Rozhavsky <mike@nbase.co.il>
2845
2846 * ospf_lsa.c (ospf_maxage_lsa_remover): Fix maxage remover for
2847 AS-external-LSAs.
2848
28492000-08-10 Toshiaki Takada <takada@zebra.org>
2850
2851 * ospfd.c (auto_cost_reference_bandwidth): New DEFUN added.
2852 `auto-cost reference-bandwidth' OSPF router command added.
2853
28542000-08-08 Gleb Natapov <gleb@nbase.co.il>
2855
2856 * ospf_routemap.c (ospf_route_map_update): New function added.
2857 Add route-map event hook.
2858
28592000-08-08 Toshiaki Takada <takada@zebra.org>
2860
2861 * ospf_zebra.c (ospf_distribute_check_connected): If redistribute
2862 prefix is connected route on OSPF enabled interface, suppress to
2863 announce it.
2864
28652000-08-08 Matthew Grant <grantma@anathoth.gen.nz>
2866
2867 * ospf_interface.c (ospf_if_get_output_cost):
2868 New function added. Handle bandwidth parameter for cost
2869 calculation.
2870
28712000-08-08 Michael Rozhavsky <mike@nbase.co.il>
2872
2873 * ospf_interface.c (interface_config_write): Show interface
2874 configuration regardless interface is down.
2875
2876 * ospf_ase.c (ospf_ase_caocluate_route): Whole rewritten external
2877 route calculate function.
2878
28792000-08-08 Gleb Natapov <gleb@nbase.co.il>
2880
2881 * ospf_routemap.c: New file added.
2882
2883 * ospf_asbr.c (ospf_reset_route_map_set_values),
2884 (ospf_route_map_set_compare): New function added.
2885
2886 * ospf_lsa.c (ospf_external_lsa_body_set): Set routemap metric
2887 with AS-external-LSA.
2888
28892000-08-05 Kunihiro Ishiguro <kunihiro@zebra.org>
2890
2891 * ospf_ase.c (ospf_ase_calculate_route_add): Pass new->cost to
2892 ospf_zebra_add as metric.
2893 (ospf_ase_calculate_route_add): Likewise.
2894
2895 * ospf_route.c (ospf_route_install): Pass or->cost to
2896 ospf_zebra_add as metric.
2897
2898 * ospf_zebra.c (ospf_zebra_add): Add metric arguemnt.
2899 (ospf_zebra_delete): Likewise.
2900
29012000-08-03 Matthew Grant <grantma@anathoth.gen.nz>
2902
2903 * ospf_flood.c (ospf_flood_delayed_lsa_ack): New function added.
2904 Dispatch delayed-ACK with flooding AS-external-LSA across virtual
2905 link.
2906
29072000-07-31 Matthew Grant <grantma@anathoth.gen.nz>
2908
2909 * ospfd.c (show_ip_ospf_area): Fix lack of VTY_NEWLINE when
2910 `show ip ospf'.
2911
2912 * ospf_interface.c (ospf_if_free): Fix bug of crash with
2913 Point-to-Point interface.
2914
29152000-07-27 Michael Rozhavsky <mike@nbase.co.il>
2916
2917 * ospf_flood.c (ospf_process_self_originated_lsa):
2918 Make sure to clear LSA->param (redistributed external information)
2919 before refreshment.
2920
29212000-07-27 Gleb Natapov <gleb@nbase.co.il>
2922
2923 * ospfd.c (refresh_group_limit), (refresh_per_slice),
2924 (refresh_age_diff): New defun added. Refresher related parameter
2925 can be configurable.
2926
29272000-07-27 Akihiro Mizutani <mizutani@dml.com>
2928
2929 * ospf_interface.c (interface_config_write): Print `description'
2930 config directive to work.
2931
29322000-07-24 Akihiro Mizutani <mizutani@dml.com>
2933
2934 * ospf_interface.c (ospf_if_init): Use install_default for
2935 INTERFACE_NODE.
2936
29372000-07-24 Gleb Natapov <gleb@nbase.co.il>
2938
2939 * ospf_packet.c (ospf_ls_upd_send_list), (ospf_ls_upd_send_event),
2940 (ospf_ls_ack_send_list), (ospf_ls_ack_send_event): New function added.
2941 This make sending always as many LS update/Ack combined in one ospf
2942 packet.
2943
29442000-07-24 Gleb Natapov <gleb@nbase.co.il>
2945
2946 * ospf_packet.c (ospf_ls_upd_list_lsa): Set NULL to lsa->area if
2947 LSA is AS-external-LSA.
2948
2949 * ospf_nsm.c (nsm_reset_nbr): Do not cancel Inactivity timer.
2950
29512000-07-21 Toshiaki Takada <takada@zebra.org>
2952
2953 * ospf_zebra.c (ospf_default_originate_timer): Set timer for
2954 `default-information originate'. Fix some default originate
2955 related functions.
2956
29572000-07-12 Toshiaki Takada <takada@zebra.org>
2958
2959 * ospf_lsa.c (stream_put_ospf_metric): New function added.
2960
29612000-07-12 Toshiaki Takada <takada@zebra.org>
2962
2963 * ospf_lsa.c (show_ip_ospf_database_router),
2964 (show_ip_ospf_database_network), (show_ip_ospf_database_summary),
2965 (show_ip_ospf_database_summary_asbr), (show_ip_ospf_database_externel),
2966 (show_router_lsa), (show_any_lsa), (show_router_lsa_self),
2967 (show_any_lsa_self): Functions removed.
2968
2969 (show_lsa_prefix_set), (show_lsa_detail_proc), (show_lsa_detail),
2970 (show_lsa_detail_adv_router_proc), (show_lsa_detail_adv_router):
2971 New functions added. Replace above functions.
2972
2973 (show_ip_ospf_database_all), (show_ip_ospf_database_self_originated):
2974 Functions removed.
2975 (show_ip_ospf_database_summary): New functions added. Replace
2976 above functions.
2977
2978 (show_ip_ospf_database_cmd): DEFUN rearranged.
2979 (show_ip_ospf_database_type_id_cmd),
2980 (show_ip_ospf_database_type_id_adv_router_cmd),
2981 (show_ip_ospf_database_type_is_self_cmd): New ALIASes added.
2982 (show_ip_ospf_database_type_adv_rotuer_cmd): New DEFUN added.
2983 (show_ip_ospf_database_type_self_cmd): New ALIAS added.
2984
29852000-07-11 Toshiaki Takada <takada@zebra.org>
2986
2987 * ospf_asbr.c (ospf_external_info_new),
2988 (ospf_external_info_free): New functions added.
2989
2990 * ospf_lsa.h (ospf_lsa): Add new member `void *param' to set
2991 origination parameter for external-LSA.
2992 Remove member `redistribute'.
2993
2994 * ospf_zebra.c (ospf_redistirbute_set): When `redistribute'
2995 command executed, metric and metric-type values are overridden.
2996 If one of those is changed refresh AS-external-LSAs for appropriate
2997 type.
2998
29992000-07-11 Michael Rozhavsky <mike@nbase.co.il>
3000
3001 * ospf_lsa.c (ospf_summary_lsa_refresh),
3002 (ospf_summary_asbr_lsa_refresh): Make sure to refresh summary-LSAs.
3003
3004 * ospf_abr.c (set_metric): New function added.
3005
30062000-07-07 Toshiaki Takada <takada@zebra.org>
3007
3008 * ospf_zebra.c (ospf_default_information_originate_metric_type),
3009 (ospf_default_information_originate_type_metric): New defun added.
3010 Metic and Metric type can be set to default route.
3011 (ospf_default_information_originate_always_metric_type):
3012 (ospf_default_information_originate_always_type_metric):
3013 New defun added. Metric and Metric type can be set to default
3014 always route.
3015
3016 * ospf_zebra.c (ospf_default_metric), (no_ospf_default_metric):
3017 New defun added.
3018
30192000-07-06 Gleb Natapov <gleb@nbase.co.il>
3020
3021 * ospf_flood.c (ospf_flood_through_area): Fix bug of considering
3022 on the same interface the LSA was received from.
3023
30242000-07-06 Michael Rozhavsky <mike@nbase.co.il>
3025
3026 * ospfd.c (ospf_config_write): Fix bug of printing `area stub'
3027 command with `write mem'.
3028
3029 * ospfd.c (no_router_ospf): Remove installed routes from zebra.
3030
3031 * ospf_zebra.c (ospf_interface_delete): Fix function to handle
3032 zebra interface delete event.
3033
30342000-07-06 Toshiaki Takada <takada@zebra.org>
3035
3036 * ospf_zebra.c (ospf_default_information_originate),
3037 (ospf_default_information_originate_always): New DEFUN added.
3038
30392000-07-05 Michael Rozhavsky <mike@nbase.co.il>
3040
3041 * ospf_route.c (ospf_terminate): Make sure to remove external route
3042 when SIGINT received.
3043
30442000-07-03 Gleb Natapov <gleb@nbase.co.il>
3045
3046 * ospf_flood.c, ospf_ism.c, ospf_lsa,c, ospfd.c: Make sure to free
3047 many structure with `no router ospf'.
3048
30492000-06-30 Gleb Natapov <gleb@nbase.co.il>
3050
3051 * ospf_neighbor.c (ospf_nbr_new),
3052 ospf_nsm.c (nsm_timer_set): Start LS update timer only
3053 when neighbor enters Exchange state.
3054
30552000-06-29 Gleb Natapov <gleb@nbase.co.il>
3056
3057 * ospf_nsm.c (nsm_timer_set), (nsm_exchange_done),
3058 ospf_packet.c (ospf_db_desc_proc):
3059 Do not cancel DD retransmit timer when Master.
3060
30612000-06-29 Gleb Natapov <gleb@nbase.co.il>
3062
3063 * ospf_abr.c (ospf_abr_announce_network_to_area),
3064 (ospf_abr_announce_rtr_to_area)
3065 ospf_ase.c (ospf_ase_rtrs_register_lsa),
3066 ospf_flood.c (ospf_process_self_originated_lsa),
3067 (ospf_flood_through_area), (ospf_ls_request_delete),
3068 ospf_interface.c (ospf_if_free),
3069 ospf_ism.c (ism_change_status),
3070 ospf_lsa.c (ospf_router_lsa_update_timer),
3071 (ospf_router_lsa_install), (ospf_network_lsa_install),
3072 (ospf_lsa_maxage_delete), (ospf_lsa_action),
3073 (ospf_schedule_lsa_flood_area),
3074 ospf_nsm.c (nsm_change_status),
3075 ospf_packet.c (ospf_make_ls_req_func), (ospf_make_ls_ack):
3076 Use ospf_lsa_{lock,unlock} for all looking-up of LSA.
3077
3078 * ospf_flood.c (ospf_ls_request_free): Function deleted.
3079
3080 * ospf_lsa.c (ospf_discard_from_db): New function added.
3081
30822000-06-26 Toshiaki Takada <takada@zebra.org>
3083
3084 * ospfd.h (ospf): struct member `external_lsa' name changed to
3085 `lsdb'.
3086
30872000-06-26 Toshiaki Takada <takada@zebra.org>
3088
3089 * ospf_lsa.c (ospf_lsa_install), (ospf_router_lsa_install),
3090 (ospf_network_lsa_install), (ospf_summary_lsa_install),
3091 (ospf_summary_asbr_lsa_install), (ospf_external_lsa_install):
3092 Functions re-arranged.
3093
3094 * ospf_lsa.c (IS_LSA_MAXAGE), (IS_LSA_SELF): Macro added.
3095
30962000-06-20 Michael Rozhavsky <mike@nbase.co.il>
3097
3098 * ospf_packet.c (ospf_ls_req), (ospf_ls_upd), (ospf_ls_ack): Add
3099 verification of LS type.
3100
31012000-06-20 Gleb Natapov <gleb@nbase.co.il>
3102
3103 * ospf_ase.c (ospf_ase_calculate_timer): Add more sanity check
3104 whether rn->info is NULL.
3105
31062000-06-20 Toshiaki Takada <takada@zebra.org>
3107
3108 * ospfd.c (show_ip_ospf_interface_sub): Show Router-ID of both
3109 DR and Backup correctly with `show ip ospf interface' command.
3110
31112000-06-20 Toshiaki Takada <takada@zebra.org>
3112
3113 * ospf_lsa.c (ospf_lsa_lock), (ospf_lsa_unlock),
3114 (ospf_lsa_discard): These functions are used for avoiding
3115 unexpected reference to freed LSAs.
3116
31172000-06-13 Kunihiro Ishiguro <kunihiro@zebra.org>
3118
3119 * ospf_packet.c (ospf_ls_upd): Initialize lsa by NULL to avoid
3120 warning.
3121
31222000-06-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3123
3124 * ospf_ase.h (ospf_ase_rtrs_register_lsa): Add prototype.
3125
31262000-06-12 Toshiaki Takada <takada@zebra.org>
3127
3128 * ospf_lsa.c (ospf_external_lsa_install): Make sure to register
3129 LSA to rtrs_external when replacing AS-external-LSAs in LSDB.
3130 Fix core dump.
3131
31322000-06-10 Toshiaki Takada <takada@zebra.org>
3133
3134 * ospf_lsdb.c (id_to_prefix), (ospf_lsdb_hash_key),
3135 (ospf_lsdb_hash_cmp), (ospf_lsdb_new), (ospf_lsdb_iterator),
3136 (lsdb_free), (ospf_lsdb_free), (ospf_lsdb_add), (ospf_lsdb_delete),
3137 (find_lsa), (ospf_lsdb_lookup), (find_by_id),
3138 (ospf_lsdb_lookup_by_id), (ospf_lsdb_lookup_by_header): Functinos
3139 removed for migration to new_lsdb.
3140
3141 * ospf_lsa.c (ospf_summary_lsa_install),
3142 (ospf_summary_asbr_lsa_install), (ospf_maxage_lsa_remover),
3143 (ospf_lsa_maxage_walker), (ospf_lsa_lookup),
3144 (ospf_lsa_lookup_by_id): Use new_lsdb instead of ospf_lsdb.
3145 (count_lsa), (ospf_lsa_count_table), (ospf_lsa_count),
3146 (ospf_get_free_id_for_prefix): Funcitions removed.
3147
31482000-06-09 Gleb Natapov <gleb@nbase.co.il>
3149
3150 * ospf_ism.c (ism_interface_down): Prevent some unneeded DR changes.
3151
3152 * ospf_packet.c (ospf_db_desc_proc): Fix memory leak.
3153 (ospf_hello): Always copy router-ID when hello is received.
3154
31552000-06-08 Gleb Natapov <gleb@nbase.co.il>
3156
3157 * ospf_lsa.h (struct ospf_lsa): Add member of pointer to struct
3158 ospf_area.
3159
31602000-06-08 Michael Rozhavsky <mike@nbase.co.il>
3161
3162 * ospf_ase.c (ospf_asbr_route_same): New function added.
3163 This function makes sure external route calculation more
3164 precisely.
3165
31662000-06-07 Michael Rozhavsky <mike@nbase.co.il>
3167
3168 * ospf_ism.c (ism_change_status): Use ospf_lsa_flush_area for
3169 network-LSA deletion instead of using ospf_lsdb_delete.
3170 Also cancel network-LSA origination timer.
3171
31722000-06-07 Levi Harper <lharper@kennedytech.com>
3173
3174 * ospf_interface.c (ospf_if_down): Close read fd when an interface
3175 goes down.
3176
31772000-06-05 Kunihiro Ishiguro <kunihiro@zebra.org>
3178
3179 * ospf_asbr.c (ospf_external_info_lookup): Add explicit brace for
3180 avoid ambiguous else.
3181
3182 * ospf_flood.c (ospf_external_info_check): Likewise.
3183
31842000-06-05 Toshiaki Takada <takada@zebra.org>
3185
3186 * ospf_nsm.c (nsm_adj_ok): Fix bug of DR election.
3187
31882000-06-04 Toshiaki Takada <takada@zebra.org>
3189
3190 * ospf_zebra.c (ospf_default_information_originate),
3191 (no_ospf_default_information_originate): New DEFUN added.
3192
31932000-06-03 Toshiaki Takada <takada@zebra.org>
3194
3195 * ospf_lsa.h, ospf_asbr.h (external_info): Struct moved from
3196 ospf_lsa.h to ospf_asbr.h.
3197
3198 * ospf_lsa.c, ospf_asbr.c (ospf_external_info_add),
3199 (ospf_external_info_delete): Function moved from ospf_lsa.c
3200 to ospf_asbr.c.
3201
32022000-06-03 Toshiaki Takada <takada@zebra.org>
3203
3204 * ospf_flood.c (ospf_external_info_check): New function added.
3205 (ospf_process_self_orignated_lsa): Make sure to flush
3206 self-originated AS-external-LSA, when router reboot and no longer
3207 originate those AS-external-LSA.
3208
32092000-06-02 Toshiaki Takada <takada@zebra.org>
3210
3211 * ospf_network.c (ospf_serv_sock): Remove SO_DONTROUTE
3212 socket option.
3213
3214 * ospf_packet.c (ospf_write): Set MSG_DONTROUTE flag for
3215 unicast destination packets.
3216
32172000-06-02 Toshiaki Takada <takada@zebra.org>
3218
3219 * ospf_lsdb.c (new_lsdb_delete): Delete entry from LSDB only when
3220 specified LSA matches.
3221
32222000-06-02 Gleb Natapov <gleb@nbase.co.il>
3223
3224 * ospf_network.c (ospf_serv_sock): Set SO_DONTROUTE
3225 socket option.
3226
32272000-06-01 Akihiro Mizutani <mizutani@dml.com>
3228
3229 * ospf_dump.c: Replace string `Debugging functions\n' with DEBUG_STR.
3230 Replace string `OSPF information\n' with OSPF_STR.
3231
32322000-06-01 Toshiaki Takada <takada@zebra.org>
3233
3234 * ospf_lsdb.[ch]: Use new_lsdb struct for network-LSA instead of
3235 ospf_lsdb.
3236
32372000-06-01 Toshiaki Takada <takada@zebra.org>
3238
3239 * ospf_dump.c (config_debug_ospf_packet), (config_debug_ospf_event),
3240 (config_debug_ospf_ism), (config_debug_ospf_nsm),
3241 (config_debug_ospf_lsa), (config_debug_ospf_zebra),
3242 (term_debug_ospf_packet), (term_debug_ospf_event),
3243 (term_debug_ospf_ism), (term_debug_ospf_nsm),
3244 (term_debug_ospf_lsa), (term_debug_ospf_zebra): Repalce debug_ospf_*
3245 variable to use for debug option flags.
3246
3247 (debug_ospf_packet), (debug_ospf_ism), (debug_ospf_nsm),
3248 (debug_ospf_lsa), (debug_ospf_zebra): Set {config,term}_debug_*
3249 flags when vty->node is CONFIG_NODE, otherwise set only term_debug_*
3250 flags.
3251
3252 * ospf_dump.h (CONF_DEBUG_PACKET_ON), (CONF_DEBUG_PACKET_OFF),
3253 (TERM_DEBUG_PACKET_ON), (TERM_DEBUG_PACKET_OFF),
3254 (CONF_DEBUG_ON), (CONF_DEBUG_OFF), (IS_CONF_DEBUG_OSPF_PACKET),
3255 (IS_CONF_DEBUG_OSPF): New Macro added.
3256
32572000-05-31 Toshiaki Takada <takada@zebra.org>
3258
3259 * ospfd.c (clear_ip_ospf_neighbor): New DEFUN added.
3260 Currently this command is used for only debugging.
3261
3262 * ospf_nsm.c (nsm_change_status): Make sure thread cancellation
3263 for network-LSA when DR has no full neighbors.
3264
3265 * ospf_nsm.c (ospf_db_summary_clear): New function added.
3266
32672000-05-30 Toshiaki Takada <takada@zebra.org>
3268
3269 * ospf_lsdb.c (new_lsdb_insert): LSAs are always freed by
3270 maxage_lsa_remover when LSA is replaced.
3271
32722000-05-25 Gleb Natapov <gleb@nbase.co.il>
3273
3274 * ospf_flood.c (ospf_ls_retransmit_delete_nbr_all): Add argument
3275 `struct ospf_area' to remove LSA from Link State retransmission list
3276 of neighbor from only one Area.
3277
32782000-05-24 Michael Rozhavsky <mike@nbase.co.il>
3279
3280 * ospf_lsdb.c (ospf_lsdb_add): Preserve flags field when
3281 overriting old LSA with new LSA.
3282
32832000-05-24 Gleb Natapov <gleb@nbase.co.il>
3284
3285 * ospf_lsa.c (ospf_router_lsa_body_set): Fix bug of router-LSA
3286 size calculation.
3287
32882000-05-22 Michael Rozhavsky <mike@nbase.co.il>
3289
3290 * ospf_route.c (ospf_intra_add_stub):
3291 * ospf_spf.h (struct vertex): Use u_int32_t for distance (cost)
3292 value instead of u_int16_t.
3293
32942000-05-22 Axel Gerlach <agerlach@datus.datus.com>
3295
3296 * ospf_ia.c (ospf_ia_network_route): Fix bug of Inter-area route
3297 equal cost path calculation.
3298
32992000-05-21 Toshiaki Takada <takada@zebra.org>
3300
3301 * ospf_ase.c (ospf_ase_calculate_route_delete): New function added.
3302 Make sure, when rotuer route is deleted, related external routes
3303 are also deleted.
3304
33052000-05-20 Toshiaki Takada <takada@zebra.org>
3306
3307 * ospfd.c (ospf_interface_down): Make sure interface flag is disable
3308 and set fd to -1.
3309
33102000-05-16 Toshiaki Takada <takada@zebra.org>
3311
3312 * ospf_asbr.c (ospf_asbr_should_announce), (ospf_asbr_route_remove):
3313 Functions removed.
3314
3315 * ospfd.h (EXTERNAL_INFO): Macro added.
3316 Substitute `ospf_top->external_info[type]' with it.
3317
33182000-05-16 Toshiaki Takada <takada@zebra.org>
3319
3320 * ospf_lsa.c (ospf_rtrs_external_remove): New function added.
3321
33222000-05-14 Gleb Natapov <gleb@nbase.co.il>
3323
3324 * ospf_flood.c (ospf_ls_retransmit_delete_nbr_all)
3325 * ospf_lsdb.c (new_lsdb_insert)
3326 * ospf_packet.c (ospf_ls_ack): Fix database synchonization problem.
3327
33282000-05-14 Gleb Natapov <gleb@nbase.co.il>
3329
3330 * ospf_lsa.h (tv_adjust), (tv_ceil), (tv_floor), (int2tv),
3331 (tv_add), (tv_sub), (tv_cmp): Prototype definition added.
3332
3333 * ospf_nsm.h (ospf_db_summary_delete_all): Prototype definition added.
3334
33352000-05-13 Toshiaki Takada <takada@zebra.org>
3336
3337 * ospf_lsa.[ch] (ospf_lsa): struct timestamp type is changed from
3338 time_t to struct timeval.
3339 (tv_adjust), (tv_ceil), (tv_floor), (int2tv), (tv_add),
3340 (tv_sub), (tv_cmp): timeval utillity functions added.
3341
33422000-05-12 Toshiaki Takada <takada@zebra.org>
3343
3344 * ospf_lsa.[ch] (ospf_schedule_update_router_lsas): Delete function.
3345 Change to use macro OSPF_LSA_UPDATE_TIMER instead of using
3346 this function.
3347 router-LSA refresh timer related stuff is re-organized.
3348
33492000-05-10 Gleb Natapov <gleb@nbase.co.il>
3350
3351 * ospf_interface.c (ospf_vl_set_params):
3352 * ospf_packet.c (ospf_check_network_mask):
3353 * ospf_spf.[ch] (ospf_spf_next):
3354 Remove field address from `struct vertex', and search for peer
3355 address of virtual link in function `ospf_vl_set_params' instead.
3356
33572000-05-10 Gleb Natapov <gleb@nbase.co.il>
3358
3359 * ospf_packet.c (ospf_ls_upd): Fix some memory leak related LSA.
3360
33612000-05-08 Thomas Molkenbur <tmo@datus.com>
3362
3363 * ospf_packet.c (ospf_packet_dup): Replace ospf_steram_copy()
3364 with ospf_stream_dup() to fix memory leak.
3365
33662000-05-08 Michael Rozhavsky <mike@nbase.co.il>
3367
3368 * ospf_flood.c (ospf_flood_through_area): Fix the problem of
3369 LSA update without DROther.
3370
33712000-05-04 Gleb Natapov <gleb@nbase.co.il>
3372
3373 * ospf_spf.c (ospf_vertex_free): Fix memory leak of SPF calculation.
3374
33752000-05-03 Toshiaki Takada <takada@zebra.org>
3376
3377 * ospf_neighbor.c (ospf_db_summary_add): Use new_lsdb struct
3378 instead linked-list.
3379 (ospf_db_summary_count), (ospf_db_summary_isempty):
3380 New function added.
3381
3382 * ospf_lsa.c (ospf_rotuer_lsa): Re-arrange and divide functions.
3383
33842000-05-02 Gleb Natapov <gleb@nbase.co.il>
3385
3386 * ospf_lsdb.c (new_lsdb_cleanup): Fix memory leak. When LSDB are
3387 not needed any more, then free them.
3388
33892000-05-02 Toshiaki Takada <takada@zebra.org>
3390
3391 * ospfd.c (timers_spf), (no_timers_spf): New defun added.
3392 SPF calculation timers related stuff is rearranged.
3393
3394 * ospf_spf.c (ospf_spf_calculate_timer_add): Function removed.
3395 SPF timer is scheduled by SPF calculation delay and holdtime
3396 configuration variable.
3397
3398 * ospf_lsa.c (ospf_external_lsa_nexthop_get): Set AS-external-LSA's
3399 forwarding address when nexthop learned by other protocols is
3400 in the OSPF domain.
3401
3402 * ospf_zebra.c (ospf_redistribute_source_metric_type),
3403 (ospf_redistribute_source_type_metric): Re-arrange DEFUNs and
3404 ALIASes.
3405
34062000-05-01 Toshiaki Takada <takada@zebra.org>
3407
3408 * ospf_flood.c (ospf_ls_retransmit_count),
3409 (ospf_ls_retransmit_isempty): New function added.
3410
3411 (ospf_ls_retransmit_add), (ospf_ls_retransmit_delete),
3412 (ospf_ls_retransmit_clear), (ospf_ls_retransmit_lookup),
3413 (ospf_ls_retransmit_delete_all), (ospf_ls_retransmit_delete_nbr_all),
3414 (ospf_ls_retransmit_add_nbr_all): Replace these functions to use
3415 new_lsdb.
3416
34172000-04-29 Toshiaki Takada <takada@zebra.org>
3418
3419 * ospfd.c (no_network_area): Add check Area-ID whether specified
3420 Area-ID with prefix matches config.
3421
34222000-04-27 Toshiaki Takada <takada@zebra.org>
3423
3424 * ospf_lsa.c (ospf_maxage_lsa_remover): Fix problem of
3425 remaining withdrawn routes on zebra.
3426
34272000-04-25 Michael Rozhavsky <mike@nbase.co.il>
3428
3429 * ospf_nsm.c (nsm_kill_nbr), (nsm_ll_down), (nsm_change_status),
3430 (ospf_nsm_event): Fix network-LSA re-origination problem.
3431
34322000-04-24 Toshiaki Takada <takada@zebra.org>
3433
3434 * ospf_nsm.c (ospf_db_desc_timer): Fix bug of segmentation fault
3435 with DD retransmission.
3436
3437 * ospf_nsm.c (nsm_kill_nbr): Fix bug of re-origination when
3438 a neighbor disappears.
3439
34402000-04-23 Michael Rozhavsky <mike@nbase.co.il>
3441
3442 * ospf_abr.c (ospf_abr_announce_network_to_area): Fix bug of
3443 summary-LSAs reorigination. Correctly copy OSPF_LSA_APPROVED
3444 flag to new LSA. when summary-LSA is reoriginatd.
3445
3446 * ospf_flood.c (ospf_flood_through_area): Fix bug of flooding
3447 procedure. Change the condition of interface selection.
3448
34492000-04-21 Toshiaki Takada <takada@zebra.org>
3450
3451 * ospf_lsa.c (ospf_refresher_register_lsa): Fix bug of refresh never
3452 occurs.
3453
3454 * ospfd.c (show_ip_ospf_neighbor_id): New defun added.
3455 `show ip ospf neighbor' related commands are re-arranged.
3456
34572000-04-20 Toshiaki Takada <takada@zebra.org>
3458
3459 * ospf_dump.c (debug_ospf_zebra): New defun added.
3460 Suppress zebra related debug information.
3461
34622000-04-19 Toshiaki Takada <takada@zebra.org>
3463
3464 * ospf_zebra.c (ospf_distribute_list_update_timer),
3465 (ospf_distribute_list_update), (ospf_filter_update):
3466 New function added. Re-organize `distribute-list' router ospf
3467 command.
3468
34692000-04-13 Michael Rozhavsky <mike@nbase.co.il>
3470
3471 * ospf_packet.c (ospf_make_ls_upd): Add check for MAX_AGE.
3472
34732000-04-14 Michael Rozhavsky <mike@nbase.co.il>
3474
3475 * ospf_packet.c (ospf_make_ls_upd): Increment LS age by configured
3476 interface transmit_delay.
3477
34782000-04-14 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3479
3480 * ospf_interface.c (ip_ospf_cost), (no_ip_ospf_cost):
3481 Add to schedule router_lsa origination when the interface cost changes.
3482
34832000-04-12 Toshiaki Takada <takada@zebra.org>
3484
3485 * ospf_lsa.c (ospf_refresher_register_lsa),
3486 (ospf_refresher_unregister_lsa): Fix bug of core dumped.
3487
3488 * ospfd.c (no_router_ospf): Fix bug of core dumped.
3489
34902000-03-29 Toshiaki Takada <takada@zebra.org>
3491
3492 * ospf_nsm.c (nsm_oneway_received): Fix bug of MS flag unset.
3493
34942000-03-29 Michael Rozhavsky <mike@nbase.co.il>
3495
3496 * ospf_lsa.c (ospf_network_lsa):
3497 * ospf_nsm.c (ospf_nsm_event): Fix bug of Network-LSA originated
3498 in stub network.
3499
35002000-03-28 Toshiaki Takada <takada@zebra.org>
3501
3502 * ospf_nsm.c (nsm_bad_ls_req), (nsm_seq_number_mismatch),
3503 (nsm_oneway_received): Fix bug of NSM state flapping between
3504 ExStart and Exchange.
3505
35062000-03-28 Toshiaki Takada <takada@zebra.org>
3507
3508 * ospf_packet.h (strcut ospf_header): Fix the size of ospf_header,
3509 change u_int8_t to u_char.
3510
35112000-03-27 Toshiaki Takada <takada@zebra.org>
3512
3513 * ospf_lsa.c (ospf_lsa_checksum): Take care of BIGENDIAN architecture.
3514
35152000-03-27 Toshiaki Takada <takada@zebra.org>
3516
3517 * ospfd.c (ospf_interface_run): Make sure Address family matches.
3518
35192000-03-26 Love <lha@s3.kth.se>
3520
3521 * ospf_packet.c (ospf_write): Chack result of sendto().
3522
35232000-03-26 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3524
3525 * ospf_nsm.c (nsm_oneway_received): Fix bug of 1-WayReceived in NSM.
3526
35272000-03-23 Libor Pechacek <farco@clnet.cz>
3528
3529 * ospf_lsa.c (ospf_network_lsa)
3530 * ospf_lsdb.c (new_lsdb_insert): Fix bug of accessing to
3531 unallocated memory.
3532
35332000-03-23 Toshiaki Takada <takada@zebra.org>
3534
3535 * ospfd.c (ospf_config_write): Fix bug of duplicate line for
3536 `area A.B.C.D authentication'.
3537
35382000-03-22 Toshiaki Takada <takada@zebra.org>
3539
3540 * ospf_debug.c (debug_ospf_lsa), (no_debug_ospf_lsa): Defun added.
3541 Suppress all zlog related to LSAs with this config option.
3542
35432000-03-21 Kunihiro Ishiguro <kunihiro@zebra.org>
3544
3545 * ospf_nsm.c (ospf_nsm_event): Add check for NSM_InactivityTimer.
3546
35472000-03-21 Toshiaki Takada <takada@zebra.org>
3548
3549 * ospf_packet.c (ospf_ls_upd_timer), (ospf_ls_req):
3550 Fix bug of memory leak about linklist.
3551
3552 * ospf_flood.c (ospf_flood_through_area): Likewise.
3553
35542000-03-18 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3555
3556 * ospf_flood.c (ospf_ls_retransmit_lookup): Add checksum comparison
3557 to identify LSA uniquely. This fix routes lost.
3558
35592000-03-18 Toshiaki Takada <takada@zebra.org>
3560
3561 * ospf_ase.c (ospf_find_asbr_route): Add sanity check with router
3562 routing table.
3563
35642000-03-17 Alex Zinin <zinin@amt.ru>
3565
3566 * ospf_spf.[ch]: Bug fix.
3567 The 2nd stage of Dijkstra could consider one vertex
3568 more than once if there is more than one link
3569 between the routers, thus adding extra CPU overhead
3570 and extra next-hops.
3571 Fixed.
3572
35732000-03-15 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3574
3575 * ospf_nsm.c (nsm_inactivity_timer): Changed to call nsm_kill_nbr().
3576
35772000-03-14 Toshiaki Takada <takada@zebra.org>
3578
3579 * ospf_route.c (ospf_route_copy_nexthops): Fix bug of memory leak of
3580 ospf_path. Actually ignore merging ospf_route with completely same
3581 paths.
3582
35832000-03-12 Toshiaki Takada <takada@zebra.org>
3584
3585 * ospf_lsa.c (show_as_external_lsa_detail): fix bug of
3586 external route tag byte order.
3587
35882000-03-11 Toshiaki Takada <takada@zebra.org>
3589
3590 * ospf_lsdb.c (ospf_lsdb_insert): New function added.
3591
35922000-03-09 Toshiaki Takada <takada@zebra.org>
3593
3594 * ospf_lsa.c (ospf_external_lsa_install),
3595 (ospf_lsa_lookup), (show_ip_ospf_database_all),
3596 (show_ip_ospf_database_self_originate): Use struct new_lsdb for
3597 LSDB of AS-external-LSAs instead of ospf_lsdb.
3598
3599 * ospf_lsa.c (ospf_lsa_unique_id): New function added.
3600 Use for assigning Unique Link State ID instead of
3601 ospf_get_free_id_for_prefix().
3602
36032000-03-09 Toshiaki Takada <takada@zebra.org>
3604
3605 * ospf_ase.c (ospf_ase_calculate_timer): Fix bug of segmentation
3606 fault reported by George Bonser <george@siteROCK.com>.
3607
36082000-03-07 Libor Pechacek <farco@clnet.cz>
3609
3610 * ospfd.c (ospf_interface_down): Fix bug of segmentation fault.
3611
36122000-03-06 Toshiaki Takada <takada@zebra.org>
3613
3614 * ospf_route.c (ospf_route_cmp): Change meaning of return values.
3615
36162000-03-02 Alex Zinin <zinin@amt.ru>
3617 * ospfd.h, ospf_ia.h
3618 New Shortcut ABR code. Now area's flag can be configured
3619 with Default, Enable, and Disable values.
3620 More info will be in the new ver of I-D soon (see IETF web).
3621
36222000-02-25 Toshiaki Takada <takada@zebra.org>
3623
3624 * ospf_lsa.c (ospf_lsa_header_set), (ospf_external_lsa_body_set),
3625 (osfp_external_lsa_originate), (ospf_external_lsa_queue),
3626 (ospf_external_lsa_originate_from_queue): New function added.
3627 (ospf_external_lsa): Function removed.
3628
3629 * ospf_zebra.c (ospf_zebra_read_ipv4): Originate AS-external-LSA
3630 when listen a route from Zebra, instead creating external route.
3631
3632 * ospf_asbr.c (ospf_asbr_route_add_flood_lsa),
3633 (ospf_asbr_route_add_queue_lsa),
3634 (ospf_asbr_route_install_lsa), (ospf_asbr_route_add):
3635 Functions removed.
3636
3637 * ospf_ase.c (process_ase_lsa): Function will not be used.
3638 (ospf_ase_calculate), (ospf_ase_calculate_route_add),
3639 (ospf_ase_calculate_new_route), (ospf_ase_caluculate_asbr_route):
3640 process_ase_lsa () is separated to these functions.
3641
3642 OSPF AS-external-LSA origination is whole re-organized.
3643
36442000-02-18 Toshiaki Takada <takada@zebra.org>
3645
3646 * ospf_packet.c (ospf_ls_upd): Fix bug of OSPF LSA memory leak.
3647
3648 * ospf_asbr.c (ospf_asbr_route_add_flood_lsa),
3649 (ospf_asbr_route_add_queue_lsa): Fix bug of OSPF external route
3650 memory leak.
3651
36522000-02-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3653
3654 * ospf_asbr.c (ospf_asbr_route_install_lsa): Re-calculate LSA
3655 checksum after change Advertised Router field.
3656
36572000-02-09 Toshiaki Takada <takada@zebra.org>
3658
3659 * ospf_asbr.c (ospf_external_route_lookup): Add new function.
3660
36612000-02-08 Toshiaki Takada <takada@zebra.org>
3662
3663 * ospfd.c (ospf_router_id_get), (ospf_router_id_update),
3664 (ospf_router_id_update_timer): Router ID decision algorithm is changed.
3665 Router ID is chosen from all of eligible interface addresses even if
3666 it is not enable to OSPF.
3667
36682000-02-08 Toshiaki Takada <takada@zebra.org>
3669
3670 * ospf_asbr.c (ospf_asbr_route_add): Function divided to
3671 ospf_asbr_route_add_flood_lsa, ospf_asbr_route_add_queue_lsa and
3672 ospf_asbr_route_install_lsa. If Router-ID is not set, then LSA is
3673 waited to install to LSDB.
3674 `0.0.0.0 adv_router' AS-external-LSA origination bug was fixed.
3675
36762000-02-01 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3677
3678 * ospf_flood.c (ospf_ls_retransmit_lookup): Compare LS seqnum
3679 in the ACK before deleting.
3680
3681 * ospf_packet.c (ospf_hello): Reset the flags after a shutdown
3682 and no shutdown of the interface.
3683
36842000-01-31 Toshiaki Takada <takada@zebra.org>
3685
3686 * ospf_packet.c (ospf_ls_req): Send multiple Link State Update
3687 packets respond to a Link State Request packet.
3688
3689 * ospfd.c (show_ip_ospf_neighbor_detail_sub): Show thread state.
3690
3691 * ospf_interface.c (ospf_vl_new): Crash when backbone area
3692 is not configured and set virtual-link to no-backbone area,
3693 bug fixed.
3694
36952000-01-30 Kunihiro Ishiguro <kunihiro@zebra.org>
3696
3697 * ospf_neighbor.h (struct ospf_neighbor): Add pointer to last send
3698 LS Request LSA.
3699
3700 * ospf_packet.c (ospf_ls_upd): Comment out LS request list
3701 treatment. That should be done in OSPF flooding procedure.
3702
3703 * ospf_flood.c (ospf_flood_through_area): Enclose
3704 ospf_check_nbr_loding inside if-else close.
3705
37062000-01-31 Toshiaki Takada <takada@zebra.org>
3707
3708 * ospf_packet.c (ospf_make_ls_upd): Fix bug of #LSAs counting.
3709
37102000-01-29 Toshiaki Takada <takada@zebra.org>
3711
3712 * ospf_packet.c (ospf_make_md5_digest): Fix bug of md5 authentication.
3713
37142000-01-28 Toshiaki Takada <takada@zebra.org>
3715
3716 * ospfd.c (show_ip_ospf): Show Number of ASE-LSAs.
3717
37182000-01-27 Kunihiro Ishiguro <kunihiro@zebra.org>
3719
3720 * ospf_packet.c (ospf_make_db_desc): Don't use rm_list for
3721 removing LSA from nbr->db_summary.
3722
37232000-01-27 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3724
3725 * ospf_packet.c (ospf_ls_upd_send): Set AllSPFRouters to
3726 destination when the link is point-to-point.
3727 (ospf_ls_ack_send_delayed): Likewise.
3728
37292000-01-27 Kunihiro Ishiguro <kunihiro@zebra.org>
3730
3731 * ospf_flood.c (ospf_ls_request_delete_all): Fix bug of next
3732 pointer lookup after the node is freed.
3733
37342000-01-26 Kunihiro Ishiguro <kunihiro@zebra.org>
3735
3736 * ospf_asbr.c (ospf_asbr_route_add): Instead of scanning all AS
3737 external route, use ospf_top->external_self.
3738
37392000-01-27 Toshiaki Takada <takada@zebra.org>
3740
3741 * ospf_lsa.c (ospf_forward_address_get): New function added.
3742
3743 * ospf_asbr.c (ospf_asbr_check_lsas): Originate AS-external-LSA
3744 only when it should be replaced.
3745
37462000-01-25 Kunihiro Ishiguro <kunihiro@zebra.org>
3747
3748 * ospf_flood.c (ospf_ls_retransmit_clear): Delete list node.
3749
3750 * ospf_lsa.c (ospf_lsa_free): Reduce logging message using
3751 ospf_zlog value.
3752
3753 * ospf_ism.c (ism_change_status): Fix bug of DR -> non DR status
3754 change. Self originated LSA is freed but not deleted from lsdb.
3755
37562000-01-24 Kunihiro Ishiguro <kunihiro@zebra.org>
3757
3758 * ospf_ism.c (ism_interface_down): Don't use router_id for
3759 detecting self neighbor structure. Instead of that compare
3760 pointer itself.
3761
3762 * ospf_neighbor.c (ospf_nbr_free): Cancel all timer when neighbor
3763 is deleted.
3764 (ospf_nbr_free): Free last send packet.
3765
3766 * ospf_neighbor.h (struct ospf_neighbor): Remove host strucutre.
3767 Instead of that src is introduced.
3768
3769 * ospf_nsm.h: Enclose macro defenition with do {} while (0).
3770
37712000-01-17 Kunihiro Ishiguro <kunihiro@zebra.org>
3772
3773 * ospfd.c: Change part of passive interface implementation. For
3774 passive interface just disabling sending/receiving Hello on the
3775 interface.
3776
37772000-01-16 Kai Bankett <kai.bankett@vew-telnet.net>
3778
3779 * ospf_interface.h (OSPF_IF_PASSIVE): Add passive flag.
3780 * ospf_interface.c (ospf_if_lookup_by_name): Add new function.
3781 * ospf_lsa.c (ospf_router_lsa): Skip passive interface.
3782 * ospfd.c (passive_interface): New command passive-interface is
3783 added.
3784 (ospf_config_write): Print passive interface.
3785
37862000-01-15 Toshiaki Takada <takada@zebra.org>
3787
3788 * ospf_interface.h (crypt_key): New struct added to store
3789 multiple cryptographic autheitication keys.
3790 (ospf_interface): struct changed.
3791
3792 * ospf_interface.c: ospf_crypt_key_new, ospf_crypt_key_add,
3793 ospf_crypt_key_lookup, ospf_crypt_key_delete: new functions added.
3794
3795 * ospf_packet.c (ip_ospf_message_digest_key): Changed to store
3796 multiple cryptographic authentication keys.
3797
37982000-01-14 Toshiaki Takada <takada@zebra.org>
3799
3800 * ospf_interface.c: DEFUN (if_ospf_*) commands changed name to
3801 ip_ospf_* ().
3802 Old notation `ospf *' still remains backward compatibility.
3803
38041999-12-29 Alex Zinin <zinin@amt.ru>
3805 * ospf_lsa.c: ospf_lsa_more_recent() bug fix
3806 * ospf_nsm.c, ospf_packet.c: remove nbr data struct when
3807 int goes down, also check DD flags correctly (bug fix)
3808
38091999-12-28 Alex Zinin <zinin@amt.ru>
3810 * "redistribute <source> metric-type (1|2) metric <XXX>" added
3811
38121999-12-23 Alex Zinin <zinin@amt.ru>
3813 * added RFC1583Compatibility flag
3814 * added dynamic interface up/down functionality
3815
38161999-11-19 Toshiaki Takada <takada@zebra.org>
3817
3818 * ospf_neighbor.h (struct ospf_neighbor): Add member state_change
3819 for NSM state change statistics.
3820
38211999-11-19 Toshiaki Takada <takada@zebra.org>
3822
3823 * ospfd.c (show_ip_ospf_neighbor_detail),
3824 (show_ip_ospf_neighbor_int_detail): DEFUN Added.
3825
38261999-11-14 Kunihiro Ishiguro <kunihiro@zebra.org>
3827
3828 * ospf_asbr.c (ospf_asbr_check_lsas): Add check of
3829 lsa->refresh_list.
3830
38311999-11-11 Toshiaki Takada <takada@zebra.org>
3832
3833 * ospf_ia.[ch] (OSPF_EXAMINE_SUMMARIES_ALL): Macro added.
3834 This macro is expanded to ospf_examine_summaries ()
3835 for SUMMARY_LSA and SUMMARY_LSA_ASBR.
3836 (OSPF_EXAMINE_TRANSIT_SUMMARIES_ALL): Macro added.
3837 This macro is expanded to ospf_examine_transit_summaries ()
3838 for SUMMARY_LSA and SUMMARY_LSA_ASBR.
3839
38401999-11-11 Toshiaki Takada <takada@zebra.org>
3841
3842 * ospf_lsa.[ch] (ospf_find_self_summary_lsa_by_prefix): Changed to
3843 macro OSPF_SUMMARY_LSA_SELF_FIND_BY_PREFIX.
3844 (ospf_find_self_summary_asbr_lsa_by_prefix): Changed to
3845 macro OSPF_SUMMARY_ASBR_LSA_SELF_FIND_BY_PREFIX.
3846 (ospf_find_self_external_lsa_by_prefix): Changed to
3847 macro OSPF_EXTERNAL_LSA_SELF_FIND_BY_PREFIX.
3848
38491999-11-11 Toshiaki Takada <takada@zebra.org>
3850
3851 * ospfd.c (ospf_abr_type): ospf_abr_type_cisco, ospf_abr_type_ibm,
3852 ospf_abr_type_shortcut and ospf_abr_type_standard DEFUNs are
3853 combined.
3854 * ospfd.c (no_ospf_abr_type): no_ospf_abr_type_cisco,
3855 no_ospf_abr_type_ibm and no_ospf_abr_type_shortcut DEFUNS are
3856 combined.
3857
38581999-11-10 Toshiaki Takada <takada@zebra.org>
3859
3860 * ospf_route.c (ospf_lookup_int_by_prefix): Move function to
3861 ospf_interface.c and change name to ospf_if_lookup_by_prefix ().
3862
38631999-11-01 Alex Zinin <zinin@amt.ru>
3864 * ospf_packet.c
3865 some correction to LSU processing
3866
3867 * ospf_lsa.c ospfd.h
3868 randomize initial LSA refreshment interval
3869 and limit the size of LSA-group to 10
3870 to let randomization work more effectively.
3871
38721999-10-31 Alex Zinin <zinin@amt.ru>
3873 * ospf_interface.c
3874 cancel t_network_lsa_self
3875 when freeing int structure
3876
3877 * ospf_abr.c ospf_asbr.c ospf_flood.c ospf_lsa.c
3878 ospf_lsa.h ospf_lsdb.h ospfd.c ospfd.h
3879
3880 Summary and ASE LSA refreshment functions
3881 added---LSA refreshment is paced to 70 LSAs
3882 per sec to avoid link overflow. Refreshment events
3883 are further randomized within a 10 sec interval
3884 to avoid syncing.
3885
3886 Also the sigfault of memcmp() in ospf_lsa_is_different()
3887 is fixed.
3888
38891999-10-30 Alex Zinin <zinin@amt.ru>
3890 * ospf_nsm.c
3891 Fix the bug where MAX_AGE LSAs
3892 are included into the DB summary.
3893
3894 * ospf_interface.c
3895 allocate 2*MTU input buffer instead of just MTU
3896 for the cases when the other router mistakenly
3897 sends larger packets thus causing fragmentation, etc.
3898
3899 * ospf_nsm.c
3900 in nsm_reset_nbr() lists should be freed
3901 not when they are empty.
3902
39031999-10-29 Kunihiro Ishiguro <kunihiro@zebra.org>
3904
3905 * ospf_zebra.c (ospf_acl_hook): Move OSPF_IS_ASBR and OSPF_IS_ABR
3906 check inside of if (ospf_top).
3907
39081999-10-29 Alex Zinin <zinin@amt.ru>
3909 * ospf_lsa.c ospf_lsdb.c :
3910 add assertion in lsa and lsa->data alloc functions,
3911 as well as in lsdb_add for new->data
3912
3913 * ospf_lsdb.c: free hash table correctly
3914
39151999-10-28 John Capo <jc@irbs.com>
3916
3917 * ospf_packet.h (OSPF_PACKET_MAX): Correct MAX packet length
3918 calculation
3919
39201999-10-27 Kunihiro Ishiguro <kunihiro@zebra.org>
3921
3922 * OSPF-TRAP-MIB.txt: New file added. Edited version of RFC1850.
3923
3924 * OSPF-MIB.txt: New file added. Edited version of RFC1850.
3925
39261999-10-27 Alex Zinin <zinin@amt.ru>
3927 * ospfd, ospf_zebra, ospf_abr
3928 "area import-list" command is added.
3929 This command allows to filter the inter-area routes
3930 injected into an area. Access list hook function
3931 extended to invalidate area exp/imp lists.
3932
39331999-10-25 Yoshinobu Inoue <shin@nd.net.fujitsu.co.jp>
3934
3935 * ospfd.c (ospf_interface_run): Enable to detect P2P network
3936 on an OSPF interface.
3937
39381999-10-19 Jordan Mendelson <jordy@wserv.com>
3939
3940 * ospf_lsdb.c (ospf_lsdb_add): Fix bug of crash
3941 in ospf_ls_retransmit_lookup ().
3942
39431999-10-19 Vladimir B. Grebenschikov <vova@express.ru>
3944
3945 * ospf_route.c: Workaround about installation of OSPF routes into
3946 the zebra daemon. Add checking of existance routes. Free
3947 ospf_top->old_table if it exists.
3948
39491999-10-15 Jordan Mendelson <jordy@wserv.com>
3950
3951 * Add support for MD5 authentication.
3952
39531999-10-12 Alex Zinin <zinin@amt.ru>
3954 * ospfd.c, ospfd.h, ospf_abr.c:
3955 a new command "area export-list" was added, it allows
3956 the admin. to control which intra-area routes are
3957 announced to other areas by the ABR
3958
39591999-10-12 Alex Zinin <zinin@amt.ru>
3960 * ospf_asbr.c (ospf_asbr_check_lsas): Fix bug of coredump
3961 when "no redistribute" is used after a distribute list
3962 denying some networks was used
3963
39641999-10-05 Toshiaki Takada <takada@zebra.org>
3965
3966 * ospf_route.c (ospf_path_dup): New function added.
3967
39681999-10-05 Toshiaki Takada <takada@zebra.org>
3969
3970 * ospf_interface.[ch]: Some of VL related funciton name changed.
3971
39721999-09-27 Alex Zinin <zinin@amt.ru>
3973
3974 * ospf_zebra.c: Distribute-list functionality added
3975
39761999-09-27 Toshiaki Takada <takada@zebra.org>
3977
3978 * ospfd.c (show_ip_ospf): Fix bug of segmentation fault when no ospf
3979 instance exists.
3980
39811999-09-25 Kunihiro Ishiguro <kunihiro@zebra.org>
3982
3983 * ospfd.c (ospf_interface_down): Fix bug of misusing nextnode()
3984 instead of node->next. Reported by Hiroki Ishibashi
3985 <ishibasi@dcd.abk.nec.co.jp>.
3986
3987 * ospf_route.c (show_ip_ospf_route): Add check for ospf is enabled
3988 or not.
3989
39901999-09-23 Alex Zinin <zinin@amt.ru>
3991
3992 * stub area support added
3993
39941999-09-23 Alex Zinin <zinin@amt.ru>
3995
3996 * fwd_addr in ASE-LSAs is now set correctly
3997 * ASE routing changed to check the fwd_addr
3998 and skip the route if the addr points to one
3999 of our interfaces to avoid loops.
4000
40011999-09-22 Alex Zinin <zinin@amt.ru>
4002
4003 * ospf_interface:
4004 ospf_vls_in_area() added, it returns
4005 the number of VLs configured through the area
4006
4007 * ospf_interface.c ospf_lsa.c ospf_lsdb.c ospfd.c
4008 honor correct mem alloc
4009
40101999-09-22 Alex Zinin <zinin@amt.ru>
4011
4012 * memory.[ch]:
4013 Some OSPF mem types added,
4014 plus more info in "show mem"
4015
40161999-09-21 Alex Zinin <zinin@amt.ru>
4017
4018 * ospfd.c:
4019 "area range substitute" added.
4020 It can be used on NAT-enabled (IP-masquarade)
4021 routers to announce private networks
4022 from an area as public ones into the outside
4023 world (not in the RFC, btw :)
4024
40251999-09-21 Alex Zinin <zinin@amt.ru>
4026
4027 * ospfd.c:
4028 "area range suppress" added.
4029 This command allows to instruct the router
4030 to be silent about specific ranges, i.e.,
4031 it is a method of route filtering on area
4032 borders
4033
40341999-09-21 Alex Zinin <zinin@amt.ru>
4035
4036 * ospfd.c VLs removed when "no network area" executed
4037
40381999-09-20 Alex Zinin <zinin@amt.ru>
4039
4040 * ospf_ase.c bug fix for not-zero fwd_addr
4041 and directly connected routes.
4042
40431999-09-20 Yon Uriarte <yon@plannet.de>
4044
4045 * ospf_packet.c (ospf_make_ls_req): Introduce delta value for
4046 checking the length of OSPF packet exceeds MTU or not.
4047
4048 * ospf_lsa.c (ospf_lsa_different): Apply ntohs for checking
4049 l1->data->length.
4050
40511999-09-18 Alex Zinin <zinin@amt.ru>
4052
4053 * ospf_lsa.c bug fix for ospf_network_lsa() to
4054 include itself into the RID list
4055
40561999-09-10 Alex Zinin <zinin@amt.ru>
4057
4058 * Alternative ABR behaviors IBM/Cisco/Shortcut
4059 implemented
4060
40611999-09-10 Alex Zinin <zinin@amt.ru>
4062
4063 * router and network-LSA origination
4064 changed to honor MinLSInterval
4065
40661999-09-08 Alex Zinin <zinin@amt.ru>
4067
4068 * modified ABR behavior to honor VLs and transit
4069 areas
4070
40711999-09-07 Alex Zinin <zinin@amt.ru>
4072
4073 * completed VL functionality
4074
40751999-09-06 Kunihiro Ishiguro <kunihiro@zebra.org>
4076
4077 * ospf_asbr.c: New file.
4078 ospf_asbr.h: New file.
4079
4080 * ospf_zebra.c (ospf_redistribute_connected): Add redistribute
4081 related stuff.
4082
40831999-09-05 Kunihiro Ishiguro <kunihiro@zebra.org>
4084
4085 * ospfd.h (OSPF_FLAG_VIRTUAL_LINK): Change OSPF_FLAG_VEND to
4086 OSPF_FLAG_VIRTUAL_LINK for comprehensiveness.
4087
40881999-09-03 Kunihiro Ishiguro <kunihiro@zebra.org>
4089
4090 * ospf_spf.c (ospf_spf_register): Change name from
4091 ospf_spf_route_add() to ospf_spf_register().
4092 Include "ospfd/ospf_abr.h" for ospf_abr_task() prototype.
4093
40941999-09-02 Kunihiro Ishiguro <kunihiro@zebra.org>
4095
4096 * ospf_lsa.c (ospf_external_lsa_install): Change to update
4097 lsa->data rather than install new one, when same id lsa is already
4098 installed.
4099
41001999-09-01 Kunihiro Ishiguro <kunihiro@zebra.org>
4101
4102 * ospf_lsa.c (ospf_router_lsa_install): Return lsa value.
4103 (ospf_network_lsa_install): Likewise.
4104 (ospf_summary_lsa_install): Likewise.
4105 (ospf_summary_asbr_lsa_install): Likewise.
4106 (ospf_external_lsa_install): Likewise.
4107
4108 * ospf_spf.c (ospf_spf_calculate): Comment out debug function
4109 ospf_rtrs_print().
4110
41111999-08-31 Kunihiro Ishiguro <kunihiro@zebra.org>
4112
4113 * ospf_spf.c (ospf_rtrs_free): Add ospf_spf_calculate() for
4114 freeing rtrs.
4115
41161999-08-31 Toshiaki Takada <takada@zebra.org>
4117
4118 * ospf_lsa.c (show_ip_ospf_database_summary),
4119 (show_ip_ospf_database_summary_asbr),
4120 (show_ip_ospf_database_external): New function added.
4121 `show ip ospf database summary',
4122 `show ip ospf database asbr-summary'
4123 `show ip ospf database external' command can be used.
4124
4125 * ospf_lsa.c (ospf_lsa_count_table): New function added.
4126 (show_ip_ospf_database_all): show nothing if a type of LSA
4127 does not exist.
4128
41291999-08-31 Kunihiro Ishiguro <kunihiro@zebra.org>
4130
4131 * ospf_lsa.c (ospf_maxage_lsa_remover): Preserve next pointer when
4132 the node is deleted.
4133
41341999-08-31 Toshiaki Takada <takada@zebra.org>
4135
4136 * ospf_flood.c (ospf_ls_retransmit_lookup): change to return
4137 struct ospf_lsa *.
4138 (ospf_ls_request_new), (ospf_ls_request_free),
4139 (ospf_ls_request_add), (ospf_ls_request_delete),
4140 (ospf_ls_request_delete_all), (ospf_ls_request_lookup):
4141 New function added.
4142
4143 * ospf_packet.c (ospf_ls_upd_send_lsa): New function added.
4144
4145 * ospf_lsa.h (LS_AGE): Slightly change macro definition.
4146
4147 * ospf_lsa.c (ospf_lsa_more_recent), (ospf_lsa_diffrent):
4148 Use LS_AGE macro.
4149
41501999-08-30 Alex Zinin <zinin@amt.ru>
4151
4152 * ospfd.c
4153 fix a bug with area range config write
4154 added "show ip ospf" command, it will be enhanced later on
4155
41561999-08-30 Alex Zinin <zinin@amt.ru>
4157
4158 * ospf_lsa.c
4159 updated ospf_router_lsa() to honor flags (B-bit)
4160
41611999-08-30 Alex Zinin <zinin@amt.ru>
4162
4163 * ospf_abr.c
4164 wrote major functions implementing ABR activity
4165
41661999-08-30 Alex Zinin <zinin@amt.ru>
4167
4168 * ospf_ia.c ospf_route.c ospf_route.h
4169 fixed the bug with ospf_route.origin field.
4170 Now it holds pointer to lsa_header
4171
41721999-08-30 Alex Zinin <zinin@amt.ru>
4173
4174 * ospf_flood.c ospf_flood.h:
4175 transformed ospf_flood_if_select into ospf_flood_through_area()
4176 added new ospf_flood_if_select() and ospf_flood_through_as()
4177
41781999-08-30 Toshiaki Takada <takada@zebra.org>
4179
4180 * ospf_flood.[ch]: New file added.
4181
4182 * ospf_packet.c (ospf_lsa_flooding),
4183 (ospf_lsa_flooding_select_if): functions move to ospf_flood.c
4184
4185 * ospf_neighbor.c (ospf_put_lsa_on_retransm_list),
4186 (ospf_remove_lsa_from_retransm_list),
4187 (ospf_nbr_remove_all_lsas_from_retransm_list),
4188 (ospf_lsa_remove_from_ls_retransmit):
4189 (ospf_lsa_retransmit): functions move to
4190 ospf_flood.c, and change function's name:
4191
4192 ospf_put_lsa_on_retransm_list ()
4193 -> ospf_ls_retransmit_add ()
4194 ospf_remove_lsa_from_retransm_list ()
4195 -> ospf_ls_retransmit_delete ()
4196 ospf_nbr_remove_all_lsas_from_retransm_list ()
4197 -> ospf_ls_retransmit_clear ()
4198 ospf_lsa_remove_from_ls_retransmit ()
4199 -> ospf_ls_retransmit_delete_nbr_all ()
4200 ospf_lsa_retransmit ()
4201 -> ospf_ls_retransmit_add_nbr_all ()
4202
4203 * ospf_lsa.c (ospf_lsa_lookup_from_list): function move to
4204 ospf_flood.c, and change name to ospf_ls_retransmit_lookup ().
4205
42061999-08-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4207
4208 * ospf_neighbor.c (ospf_nbr_lookup_by_addr): Use
4209 route_node_lookup() instead of route_node_get().
4210
4211 * ospf_packet.c (ospf_ls_upd): Temporary comment out (6) check.
4212
42131999-08-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4214
4215 * ospf_route.c (ospf_lookup_int_by_prefix): Add check of
4216 oi->address.
4217
42181999-08-29 Alex Zinin <zinin@amt.ru>
4219 * ospf_lsa.c
4220 MaxAge LSA deletion functions added.
4221
42221999-08-29 Alex Zinin <zinin@amt.ru>
4223 * ospf_neighbor.c
4224 ospf_nbr_lookup_by_addr(): added route_unlock_node()
4225 when function returns NULL if (rn->info == NULL)
4226
42271999-08-29 Alex Zinin <zinin@amt.ru>
4228 * ospfd.c
4229 added a hack for area range deletion
4230
42311999-08-29 Alex Zinin <zinin@amt.ru>
4232 * ospf_lsa.h
4233 included lsdb field into struct ospf_lsa, to find
4234 LSDB easier when removing MaxAge LSAs.
4235
42361999-08-29 Alex Zinin <zinin@amt.ru>
4237 * ospf_lsa.c ospf_neighbor.c ospf_nsm.c
4238 ospf_packet.c changed to honor new retransmit list
4239 management functions
4240
42411999-08-29 Alex Zinin <zinin@amt.ru>
4242 * ospf_neighbor.c , .h added new retransmit list functions.
4243
42441999-08-29 Alex Zinin <zinin@amt.ru>
4245 * Makefile.in
4246 added ospf_ase, ospf_abr, ospf_ia
4247
42481999-08-29 Alex Zinin <zinin@amt.ru>
4249 * ospf_spf.c:
4250 - changed ospf_next_hop_calculation() to include interface
4251 and nexthop addr for directly connected routers---more informative
4252 and solves problem with route installation into the kernel
4253 - changed ospf_nexthop_out_if_addr() to support routers, not only
4254 transit networks
4255 - added ospf_process_stubs();
4256
42571999-08-29 Alex Zinin <zinin@amt.ru>
4258 * ospf_lsa.c:
4259 - changed ospf_router_lsa() to provide correct links
4260 for p-t-p interfaces;
4261 - changed ospf_summary_lsa_install() to support table
4262 of self-originated summary-LSAs;
4263 - added ospf_summary_asbr_lsa_install() and ospf_external_lsa_install()
4264 - changed ospf_lsa_install() accordingly
4265 - changed show_ip_ospf_database_router_links() to support p-t-p
4266
42671999-08-29 Kunihiro Ishiguro <kunihiro@zebra.org>
4268
4269 * ospf_packet.c (ospf_make_db_desc): Only master can clear more
4270 flag.
4271
42721999-08-29 Kunihiro Ishiguro <kunihiro@zebra.org>
4273
4274 * ospf_packet.c (ospf_read): Add check of IP src address.
4275
42761999-08-28 Alex Zinin <zinin@amt.ru>
4277 * ospf_neighbor.h
4278 added ospf_nbr_lookup_by_routerid()
4279
42801999-08-28 Alex Zinin <zinin@amt.ru>
4281 * ospfd.h
4282 added ABR/ASBR flag definitions and fields;
4283 added iflist field to area structure;
4284 summary_lsa_self and summary_lsa_asbr_self are changed
4285 to be route tables;
4286 added ranges field---configured area ranges;
4287 A separate Routers RT added;
4288 area range config commands and config write added
4289
4290
42911999-08-28 Alex Zinin <zinin@amt.ru>
4292 * ospf_route.c :
4293 ospf_route_free()--added code to free the list of paths;
4294 The following functions added:
4295 ospf_intra_add_router();
4296 ospf_intra_add_transit();
4297 ospf_intra_add_stub();
4298 the last function uses new ospf_int_lookup_by_prefix();
4299 show_ip_ospf_route_cmd()--changed to support new RT structure;
4300 added ospf_cmp_routes()--general route comparision function;
4301 added ospf_route_copy_nexthops() and ospf_route_copy_nexthops_from_vertex()
4302 they are used in ASE and IA routing;
4303 added ospf_subst_route() and ospf_add_route();
4304
43051999-08-28 Alex Zinin <zinin@amt.ru>
4306 * ospf_route.h :
4307 changed struct ospf_path to include output interface,
4308 changed struct ospf_route to support IA and ASE routing.
4309 added prototypes of the function used in IA and ASE modules.
4310
43111999-08-28 Alex Zinin <zinin@amt.ru>
4312 * ospf_lsa.h ospf_lsa.c :
4313 added ospf_my_lsa(), an interface independent version of
4314 ospf_lsa_is_self_originated(), it will be used in ASE and IA-routing.
4315
43161999-08-27 Kunihiro Ishiguro <kunihiro@zebra.org>
4317
4318 * ospf_interface.c (interface_config_write): Add check for
4319 oi->nbr_self.
4320
43211999-08-25 Toshiaki Takada <takada@zebra.org>
4322
4323 * ospf_lsa.c (ospf_lsa_dup): New function added.
4324
4325 * ospf_packet.c (ospf_write), (ospf_read): Print send/recv
4326 interface in debug message.
4327
43281999-08-25 Toshiaki Takada <takada@zebra.org>
4329
4330 * ospf_packet.c (ospf_ls_ack_send): The name is changed from
4331 `ospf_ls_ack_send'.
4332 (ospf_ls_ack_send_delayed) (ospf_ls_ack_timer): New function added.
4333 Delayed Link State Acknowledgment is scheduled by timer.
4334
43351999-08-25 Alex Zinin <zinin@amt.ru>
4336
4337 * ospf_lsa.c (ospf_router_lsa): Incorrectly included link to
4338 a stub network instead of link to a transit network into
4339 originated router-LSA, bug fixed.
4340
43411999-08-24 Toshiaki Takada <takada@zebra.org>
4342
4343 * ospfd.c (ospf_update_router_id): New function added.
4344
4345 * ospf_network.c (ospf_write): Create new socket per transmission.
4346 And select outgoing interface whether dst is unicast or multicast.
4347
4348 * ospf_packet.c: LSA flooding will work.
4349
43501999-08-24 VOP <vop@unity.net>
4351
4352 * ospf_route.c: Include "sockunion.h"
4353
43541999-08-24 Kunihiro Ishiguro <kunihiro@zebra.org>
4355
4356 * ospf_network.c (ospf_serv_sock_init): Enclose
4357 IPTOS_PREC_INTERNETCONTROL setting with #ifdef for OS which does
4358 not have the definition.
4359
43601999-08-23 Toshiaki Takada <takada@zebra.org>
4361
4362 * ospf_packet.c: Fix bug of DD processing.
4363
43641999-08-18 Toshiaki Takada <takada@zebra.org>
4365
4366 * ospf_lsa.c (show_ip_ospf_database): Show actual `LS age'.
4367
43681999-08-17 Toshiaki Takada <takada@zebra.org>
4369
4370 * ospf_lsa.h (OSPF_MAX_LSA): The value of OSPF_MAX_LSA is
4371 corrected. The bug of `mes_lookup' is fixed.
4372 This had been reported by Poul-Henning Kamp <phk@freebsd.org>.
4373
4374 * ospf_lsa.c (ospf_router_lsa_install): The name is changed from
4375 `ospf_add_router_lsa'.
4376 (ospf_network_lsa_install): The name is changed from
4377 `ospf_add_network_lsa'.
4378
4379 * ospf_interface.h (ospf_interface): Add member `nbr_self'.
4380
4381 * ospf_interface.c (ospf_if_is_enable): New function added.
4382
43831999-08-16 Toshiaki Takada <takada@zebra.org>
4384
4385 * ospf_lsa.h (struct lsa_header): The name is changed from
4386 `struct ospf_lsa'.
4387 (struct ospf_lsa): New struct added to control each LSA's aging
4388 and timers.
4389
4390 * ospf_lsa.c (ospf_lsa_data_free): The name is change from
4391 `ospf_lsa_free'.
4392 (ospf_lsa_data_new), (ospf_lsa_new), (ospf_lsa_free),
4393 (ospf_lsa_different), (ospf_lsa_install): New function added.
4394
4395 * ospf_packet.c (ospf_ls_upd_list_lsa): New function added.
4396
43971999-08-12 Toshiaki Takada <takada@zebra.org>
4398
4399 * ospf_nsm.c (nsm_reset_nbr): New function added.
4400 KillNbr and LLDown neighbor event call this function.
4401
44021999-08-10 Toshiaki Takada <takada@zebra.org>
4403
4404 * ospf_packet.c (ospf_ls_retransmit)
4405 (ospf_ls_upd_timer): New function added.
4406 Set retransmission timer for Link State Update.
4407
44081999-07-29 Toshiaki Takada <takada@zebra.org>
4409
4410 * ospf_ism.c (ospf_dr_election): Fix bug of DR election.
4411
44121999-07-28 Toshiaki Takada <takada@zebra.org>
4413
4414 * ospf_network.c (ospf_serv_sock_init): Set IP precedence field
4415 with IPTOS_PREC_INTERNET_CONTROL.
4416
4417 * ospf_nsm.c (nsm_change_status): Schedule NeighborChange event
4418 if NSM status change.
4419
4420 * ospf_packet.c (ospf_make_hello): Never include a neighbor in
4421 Hello packet, when the neighbor goes down.
4422
44231999-07-26 Kunihiro Ishiguro <kunihiro@zebra.org>
4424
4425 * Makefile.am (noinst_HEADERS): Add ospf_route.h.
4426
4427 * ospf_route.c (show_ip_ospf_route): Add `show ip ospf route'
4428 command.
4429
44301999-07-25 Toshiaki Takada <takada@zebra.org>
4431
4432 * ospf_lsa.c (ospf_router_lsa): Fix bug of LS sequence number
4433 assignement.
4434
44351999-07-25 Kunihiro Ishiguro <kunihiro@zebra.org>
4436
4437 * ospf_route.c (ospf_route_table_free): New function added.
4438
4439 * ospf_spf.c (ospf_spf_next): Free vertex w when cw's and w's
4440 distance is same.
4441
4442 * ospfd.h (struct ospf): Add old_table.
4443
4444 * ospf_main.c (sighup): Call of log_rotate () removed.
4445
4446 * ospf_lsa.c (ospf_lsa_is_self_originated): Fix bug of checking
4447 area->lsa as self LSA. This should be area->lsa_self.
4448
44491999-07-24 Kunihiro Ishiguro <kunihiro@zebra.org>
4450
4451 * ospf_zebra.c (ospf_zebra_add): ospf_zebra_add
4452 (),ospf_zebra_delete () added.
4453
4454 * ospf_spf.c (ospf_spf_calculate): Call ospf_intra_route_add ().
4455
44561999-07-24 Toshiaki Takada <takada@zebra.org>
4457
4458 * ospf_lsa.c: Change LS sequence number treatment.
4459 (ospf_lsa_is_self_originated): New function added.
4460 (show_ip_ospf_database_self_originated): New DEFUN added.
4461
44621999-07-23 Kunihiro Ishiguro <kunihiro@zebra.org>
4463
4464 * ospf_interface.c (ospf_if_lookup_by_addr): Add loopback check.
4465
44661999-07-22 Toshiaki Takada <takada@zebra.org>
4467
4468 * ospf_spf.c (ospf_nexthop_new), (ospf_nexthop_free),
4469 (ospf_nexthop_dup): function added.
4470 (ospf_nexthop_calculation): function changed.
4471
4472 * ospf_interface.c (ospf_if_lookup_by_addr): function added.
4473
44741999-07-21 Toshiaki Takada <takada@zebra.org>
4475
4476 * ospf_spf.c (ospf_spf_closest_vertex): function removed.
4477
44781999-07-21 Kunihiro Ishiguro <kunihiro@zebra.org>
4479
4480 * ospf_spf.c (ospf_spf_next): Apply ntohs for fetching metric.
4481
44821999-07-21 Toshiaki Takada <takada@zebra.org>
4483
4484 * ospf_neighbor.c (ospf_nbr_lookup_by_router_id): fundtion removed.
4485
4486 * ospf_lsa.c (show_ip_ospf_database_router): describe each
4487 connected link.
4488
44891999-07-21 Kunihiro Ishiguro <kunihiro@zebra.org>
4490
4491 * ospf_spf.c (ospf_spf_next): V is router LSA or network LSA so
4492 change behavior according to LSA type.
4493 (ospf_lsa_has_link): Link check function is added.
4494
44951999-07-20 Kunihiro Ishiguro <kunihiro@zebra.org>
4496
4497 * ospf_spf.c (ospf_spf_calculate_schedule): Add new function for
4498 SPF calcultion schedule addtition.
4499 (ospf_spf_calculate_timer_add): Rough 30 sec interval SPF calc
4500 timer is added.
4501 (ospf_spf_next_router): Delete ospf_spf_next_network ().
4502
4503 * ospf_lsa.c (show_ip_ospf_database_all): Network-LSA display
4504 header typo correction. Display of router LSA's #link added.
4505
45061999-07-19 Toshiaki Takada <takada@zebra.org>
4507
4508 * ospf_packet.c (ospf_check_network_mask): Added new function for
4509 receiving Raw IP packet on an appropriate interface.
4510
45111999-07-16 Toshiaki Takada <takada@zebra.org>
4512
4513 * ospfd.c (ospf_router_id): new DEFUN added.
4514
45151999-07-15 Toshiaki Takada <takada@zebra.org>
4516
4517 * ospf_spf.c (ospf_spf_init), (ospf_spf_free),
4518 (ospf_spf_has_vertex), (ospf_vertex_lookup),
4519 (ospf_spf_next_router), (ospf_spf_next_network),
4520 (ospf_spf_closest_vertex), (ospf_spf_calculate):
4521 function added.
4522
45231999-07-13 Toshiaki Takada <takada@zebra.org>
4524
4525 * ospf_ism.c: fix bug of DR Election.
4526
4527 * ospf_nsm.c: fix bug of adjacency forming.
4528
45291999-07-05 Kunihiro Ishiguro <kunihiro@zebra.org>
4530
4531 * ospfd.c (ospf_init): Change to use install_default.
4532
45331999-07-01 Rick Payne <rickp@rossfell.co.uk>
4534
4535 * ospf_zebra.c (zebra_init): Install standard commands to
4536 ZEBRA_NODE.
4537
45381999-06-30 Toshiaki Takada <takada@zebra.org>
4539
4540 * ospf_dump.c: Whole debug command is improved.
4541 (ISM|NSM) (events|status|timers) debug option added.
4542 (show_debugging_ospf): new DEFUN added.
4543
45441999-06-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4545
4546 * ospf_lsa.c (ospf_lsa_lookup_from_list): Change !IPV4_ADDR_CMP to
4547 IPV4_ADDR_SAME.
4548
45491999-06-29 Toshiaki Takada <takada@zebra.org>
4550
4551 * ospf_dump.c (ospf_summary_lsa_dump): Add summary-LSA dump routine.
4552 (ospf_as_external_lsa_dump): Add AS-external-LSA dump routine.
4553
4554 * ospf_nsm.c (nsm_twoway_received): fix condtion of adjacnet.
4555
4556 * ospf_ism.c (ospf_dr_election): fix DR Election.
4557
4558 * ospf_dump.c (ospf_nbr_state_message): fix `show ip ospf neighbor'
4559 command's state.
4560
45611999-06-29 Kunihiro Ishiguro <kunihiro@zebra.org>
4562
4563 * ospf_dump.c (ospf_router_lsa_dump): Add router-LSA dump routine.
4564
45651999-06-28 Toshiaki Takada <takada@zebra.org>
4566
4567 * ospf_lsa.c (show_ip_ospf_database_network): fix bug of
4568 `show ip ospf database network' command output.
4569
4570 * ospf_nsm.c (nsm_inactivity_timer): Clear list of Link State
4571 Retransmission, Database Summary and Link State Request.
4572
4573 * ospf_packet.c (ospf_ls_req_timer): New function added.
4574 Set Link State Request retransmission timer.
4575
45761999-06-27 Kunihiro Ishiguro <kunihiro@zebra.org>
4577
4578 * ospf_main.c (main): Change default output from ZLOG_SYSLOG to
4579 ZLOG_STDOUT.
4580
4581 * ospfd.c (ospf_init): Register show_ip_ospf_interface_cmd and
4582 show_ip_ospf_neighbor_cmd to VIEW_NODE.
4583
4584 * ospf_lsa.c (ospf_lsa_init): Register show_ip_ospf_database_cmd
4585 and show_ip_ospf_database_type_cmd to VIEW_NODE.
4586
45871999-06-25 Toshiaki Takada <takada@zebra.org>
4588
4589 * ospf_packet.c: fix bug of DD making.
4590 fix bug of LS-Update reading.
4591
45921999-06-23 Toshiaki Takada <takada@zebra.org>
4593
4594 * ospf_packet.c: All type of packets are changed to use
4595 fifo queue structure.
4596 (ospf_fill_header) function added.
4597
45981999-06-22 Toshiaki Takada <takada@zebra.org>
4599
4600 * ospf_packet.c (ospf_packet_new): New function added to handle
4601 sending ospf packet by fifo queue structure.
4602 (ospf_packet_free), (ospf_fifo_new), (ospf_fifo_push),
4603 (ospf_fifo_pop), (ospf_fifo_head), (ospf_fifo_flush),
4604 (ospf_fifo_free): Likewise.
4605
46061999-06-21 Toshiaki Takada <takada@zebra.org>
4607
4608 * ospf_nsm.c (ospf_db_desc_timer): function added.
4609 (nsm_timer_set) function added.
4610 * ospf_dump.c (ospf_option_dump): function added.
4611 * ospf_packet.c (ospf_ls_req) (ospf_make_ls_req): function added.
4612
46131999-06-20 Toshiaki Takada <takada@zebra.org>
4614
4615 * ospf_lsa.c (ospf_lsa_more_recent): function added.
4616 * ospf_neighbor.h (struct ospf_neighbor): Change member ms_flag
4617 to dd_flags.
4618
46191999-06-19 Toshiaki Takada <takada@zebra.org>
4620
4621 * ospf_lsa.c: DEFUN (show_ip_ospf_database) Added.
4622 * ospf_interface.c (if_ospf_cost), (if_ospf_dead_interval),
4623 (if_ospf_hello_interval), (if_ospf_priority),
4624 (if_ospf_retransmit_interval), (if_ospf_transmit_delay)
4625 argument changed from NUMBER to <range>.
4626 DEFUN (if_ospf_network_broadcast),
4627 DEFUN (if_ospf_network_non_broadcast),
4628 DEFUN (if_ospf_network_point_to_multipoint),
4629 DEFUN (if_ospf_network_point_to_point) functions are combined to
4630 DEFUN (if_ospf_network).
4631
46321999-06-18 Toshiaki Takada <takada@zebra.org>
4633
4634 * ospf_lsa.c: ospf_add_router_lsa (), ospf_add_network_lsa (),
4635 ospf_lsa_lookup (), ospf_lsa_count () Added.
4636
46371999-06-15 Toshiaki Takada <takada@zebra.org>
4638
4639 * DEFUN (ospf_debug_ism), DEFUN (ospf_debug_nsm),
4640 DEFUN (no_ospf_debug_ism), DEFUN (no_ospf_debug_nsm) Added.
4641 `debug ospf ism' command shows debug message.
4642 `debuf ospf nsm' command shows debug message.
4643
46441999-06-14 Toshiaki Takada <takada@zebra.org>
4645
4646 * ospf_lsa.c: ospf_network_lsa () Added.
4647 ospf_lsa_checksum () Added.
4648 * DEFUN (ospf_debug_packet), DEFUN (no_ospf_debug_packet) Added.
4649 `debug ospf packet' command shows debug message.
4650
46511999-06-13 Toshiaki Takada <takada@zebra.org>
4652
4653 * ospf_packet.h: Remove struct ospf_ls_req {}, ospf_ls_upd {},
4654 ospf_ls_ack {}.
4655
46561999-06-11 Toshiaki Takada <takada@zebra.org>
4657
4658 * ospf_dump.c: fix IP packet length treatment.
4659
46601999-06-10 Toshiaki Takada <takada@zebra.org>
4661
4662 * ospf_ism.h: Add OSPF_ISM_EVENT_EXECUTE() Macro Added.
4663 * ospf_nsm.h: Add OSPF_NSM_EVENT_EXECUTE() Macro Added.
4664
4665 * ospf_packet.c: ospf_db_desc (), ospf_db_desc_send () Added.
4666 ospf_make_hello (), ospf_make_db_desc () Added.
4667 ospf_db_desc_proc () Added.n
4668
4669 * Database Description packet can be processed.
4670
46711999-06-08 Toshiaki Takada <takada@zebra.org>
4672
4673 * ospf_lsa.c: New file.
4674
46751999-06-07 Toshiaki Takada <takada@zebra.org>
4676
4677 * ospf_neighbor.c: ospf_fully_adjacent_count () Added.
4678
46791999-06-07 Kunihiro Ishiguro <kunihiro@zebra.org>
4680
4681 * ospf_spf.[ch]: New file.
4682
46831999-05-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4684
4685 * ospf_zebra.c: Changed to use lib/zclient.c routines.
4686
4687 * ospf_zebra.h (zebra_start): Remove struct zebra.
4688
46891999-05-29 Kunihiro Ishiguro <kunihiro@zebra.org>
4690
4691 * ospfd.c (ospf_config_write): Add cast (unsigned long int) to
4692 ntohl for sprintf warning.
4693
46941999-05-19 Toshiaki Takada <takada@zebra.org>
4695
4696 * ospf_ism.c (ospf_dr_election): Join AllDRouters Multicast group
4697 if interface state changes to DR or BDR.
4698
46991999-05-14 Stephen R. van den Berg <srb@cuci.nl>
4700
4701 * ospf_main.c (signal_init): SIGTERM call sigint.
4702 (sigint): Logging more better message.
4703
47041999-05-12 Toshiaki Takada <takada@zebra.org>
4705
4706 * ospfd.c: Fix bug of `no router ospf' statement, it will work.
4707
47081999-05-11 Toshiaki Takada <takada@zebra.org>
4709
4710 * ospf_neighbor.c: ospf_nbr_free () Added.
4711
47121999-05-10 Toshiaki Takada <takada@zebra.org>
4713
4714 * ospfd.h: struct ospf_area { }, struct ospf_network { } Changed.
4715 * Fix bug of `no network' statement, it will work.
4716
47171999-05-07 Toshiaki Takada <takada@zebra.org>
4718
4719 * ospf_interface.c, ospf_zebra.c: Fix bug of last interface is not
4720 updated by ospf_if_update ().
4721
47221999-04-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4723
4724 * Makefile.am (noinst_HEADERS): Add ospf_lsa.h for distribution.
4725
47261999-04-25 Toshiaki Takada <takada@zebra.org>
4727
4728 * ospf_interface.c: DEFUN (no_if_ospf_cost),
4729 DEFUN (no_if_ospf_dead_interval),
4730 DEFUN (no_if_ospf_hello_interval),
4731 DEFUN (no_if_ospf_priority),
4732 DEFUN (no_if_ospf_retransmit_interval),
4733 DEFUN (no_if_ospf_transmit_delay) Added.
4734
4735 interface_config_write () suppress showing interface
4736 default values.
4737
47381999-04-25 Kunihiro Ishiguro <kunihiro@zebra.org>
4739
4740 * ospf_dump.c (ospf_timer_dump): If thread is NULL return "inactive".
4741
4742 * ospfd.c (ospf_if_update): Fix bug of using ospf_area { } instead
4743 of ospf_network { }. So `router ospf' statement in ospfd.conf
4744 works again.
4745 (ospf_if_update): Call ospf_get_router_id for updating router ID.
4746
47471999-04-25 Toshiaki Takada <takada@zebra.org>
4748
4749 * ospf_interface.c: DEFUN (if_ospf_network) deleted.
4750 DEFUN (if_ospf_network_broadcast),
4751 DEFUN (if_ospf_network_non_broadcast),
4752 DEFUN (if_ospf_network_point_to_multipoint),
4753 DEFUN (if_ospf_network_point_to_point),
4754 DEFUN (no_if_ospf_network) Added.
4755
47561999-04-23 Toshiaki Takada <takada@zebra.org>
4757
4758 * ospfd.h: struct area { } changed to struct ospf_network { }.
4759 Add struct ospf_area { }.
4760 * ospfd.c: Add ospf_area_lookup_by_area_id (), ospf_network_new (),
4761 and ospf_network_free ().
4762 DEFUN (area_authentication), DEFUN (no_area_authentication) Added.
4763
47641999-04-22 Toshiaki Takada <takada@zebra.org>
4765
4766 * ospf_lsa.h: New file.
4767 * ospf_packet.h: LSA related struct definition are moved to
4768 ospf_lsa.h.
4769 * ospf_packet.c: ospf_verify_header () Added.
4770
47711999-04-21 Toshiaki Takada <takada@zebra.org>
4772
4773 * ospf_ism.c: ospf_elect_dr () and related function is changed.
4774 DR Election bug fixed.
4775 * ospf_dump.c: ospf_nbr_state_message (), ospf_timer_dump () Added.
4776 * ospfd.c: DEFUN (show_ip_ospf_neighbor) Added.
4777
47781999-04-19 Kunihiro Ishiguro <kunihiro@zebra.org>
4779
4780 * ospf_main.c (main): access_list_init () is added for vty
4781 connection filtering.
4782
47831999-04-16 Toshiaki Takada <takada@zebra.org>
4784
4785 * ospfd.c: DEFUN (show_ip_ospf_interface) Added.
4786 * ospf_neighbor.c: ospf_nbr_count () Added.
4787
47881999-04-15 Toshiaki Takada <takada@zebra.org>
4789
4790 * ospfd.h: struct ospf { } Changed.
4791 * ospfd.c: ospf_lookup_by_process_id () Deleted.
4792 * ospf_ism.c: ospf_wait_timer () Added. WaitTimer will work.
4793
47941999-04-14 Toshiaki Takada <takada@zebra.org>
4795
4796 * ospf_ism.c: ospf_elect_dr () Added.
4797 * ospf_network.c: ospf_if_ipmulticast () Added.
4798
47991999-04-11 Toshiaki Takada <takada@zebra.org>
4800
4801 * ospf_interface.c: interface_config_write (),
4802 DEFUN (if_ip_ospf_cost),
4803 DEFUN (if_ip_ospf_dead_interval),
4804 DEFUN (if_ip_ospf_hello_interval),
4805 DEFUN (if_ip_ospf_priority),
4806 DEFUN (if_ip_ospf_retransmit_interval) and
4807 DEFUN (if_ip_ospf_transmit_delay) Added.
4808
48091999-04-08 Toshiaki Takada <takada@zebra.org>
4810
4811 * ospf_dump.c: ospf_packet_db_desc_dump () Added.
4812 * ospf_neighbor.c: ospf_nbr_bidirectional () Added.
4813 * ospf_nsm.c: nsm_twoway_received () Added.
4814
48151999-04-02 Toshiaki Takada <takada@zebra.org>
4816
4817 * ospf_neighbor.c: New file.
4818 * ospf_neighbor.h: New file.
4819 * ospf_nsm.c: New file.
4820 * ospf_nsm.h: New file.
4821 * ospf_packet.c: Add ospf_make_header (), ospf_hello () and
4822 ospf_hello_send (). Now OSPFd can receive Hello and send Hello.
4823
48241999-03-27 Kunihiro Ishiguro <kunihiro@zebra.org>
4825
4826 * ospf_packet.c: Add ospf_recv_packet (). Now OSPF Hello can receive.
4827
48281999-03-19 Toshiaki Takada <takada@zebra.org>
4829
4830 * ospf_packet.c: New file.
4831 * ospf_packet.h: New file.
4832 * ospf_network.c: New file.
4833 * ospf_network.h: New file.
4834 * ospfd.h: move OSPF message structure has moved to ospf_packet.h.
4835
48361999-03-17 Kunihiro Ishiguro <kunihiro@zebra.org>
4837
4838 * ospf_zebra.c (ospf_zebra_get_interface): Fix for IPv6 interface
4839 address.
4840
4841 * Makefile.am (install-sysconfDATA): Overwrite install-sysconfDATA
4842 for install ospfd.conf.sample as owner read only file.
4843
4844 * ospf_main.c (usage): Change to use ZEBRA_BUG_ADDRESS.
4845
48461999-03-15 Toshiaki Takada <takada@zebra.org>
4847
4848 * ospf_ism.c: New file.
4849 * ospf_ism.h: New file.
4850 * ospf_dump.c: New file.
4851 * ospf_dump.h: New file.
4852
4853 * ospfd.h: Add (struct ospf), (struct config_network),
4854 (struct message) structure.
4855
4856 * ospf_interface.c: Add ospf_if_match_network ().
4857 * ospf_interface.h (struct ospf_interface): Change struct members.
4858
4859 * ospfd.c: ospf_lookup_by_process_id (), ospf_network_new (),
4860 DEFUN (network_area): Added.
4861
4862 * ospfd.conf.sample: Change sample configuration.
4863
48641999-03-05 Toshiaki Takada <takada@zebra.org>
4865
4866 * ospf_interface.c: New file.
4867 * ospf_interface.h: New file.
4868 * ospf_zebra.h: New file.
4869 * ospf_zebra.c: Add interface function for zebra daemon.
4870 * ospfd.c: New file.
4871
48721999-02-23 Kunihiro Ishiguro <kunihiro@zebra.org>
4873
4874 * Move IPv6 codes and files to ospf6d directory.
4875
48761999-02-18 Peter Galbavy <Peter.Galbavy@knowledge.com>
4877
4878 * syslog support added
4879
48801998-12-22 Toshiaki Takada <takada@zebra.org>
4881
4882 * ospfd.h: New file.
4883 * ospf_lsa.h: New file.
4884
48851998-12-15 Kunihiro Ishiguro <kunihiro@zebra.org>
4886
4887 * Makefile.am: New file.
4888 * ospf_main.c: New file.
4889