blob: 0a2b9994e3a6f0b7f00d02c7b9c3baf6d7a9a76c [file] [log] [blame]
Andrew J. Schorred589c12006-12-04 18:26:37 +000012006-12-04 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
2
3 * ospfd.c: (ospf_network_run) Remove an offending 'break' statement.
4 Previously, after creating a single ospf_interface on a given
5 network interface, the code would skip to the next interface
6 without considering other connected addresses on the interface.
7 After removing the 'break', we now consider all connected addresses.
8
Andrew J. Schorr7f643eb2006-11-30 16:17:02 +000092006-11-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
10
11 * ospf_zebra.c: (ospf_router_id_update_zebra,
12 ospf_interface_address_add, ospf_interface_address_delete)
13 If (IS_DEBUG_OSPF (zebra, ZEBRA_INTERFACE)) is enabled, then
14 add a debug message about what Zebra is telling us.
15 (ospf_zebra_add_discard) Add a debug message matching the one
16 already in ospf_zebra_delete_discard.
17
Andrew J. Schorr43540882006-11-28 16:36:39 +0000182006-11-28 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
19
20 * ospf_vty.c: (ospf_passive_interface_default) Take additional
21 'newval' arg so we can update ospf->passive_interface_default inside
22 this function. More importantly, we now call ospf_if_set_multicast
23 on all ospf_interfaces.
24 (ospf_passive_interface, no_ospf_passive_interface) Fix bug:
25 for 'default' case, argv[0] is undefined, so we must test for
26 (argc == 0) before using argv[0]. And since
27 ospf_passive_interface_default now calls ospf_if_set_multicast as
28 needed, we can just return after calling
29 ospf_passive_interface_default.
30
Andrew J. Schorr8fb8a502006-10-24 19:04:26 +0000312006-10-24 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
32
33 * ospf_zebra.c: (ospf_redistribute_default_set) Fix bug where
34 a new value for ospf->default_originate was being ignored
35 if a previous 'default-information originate' command
36 had already been processed.
37
Paul Jakma7ffa8fa2006-10-22 20:07:53 +0000382006-10-22 Yar Tikhiy <yar@comp.chem.msu.su>
39
40 * (general) Add support for passive-interface default (with
41 minor edits by Paul Jakma).
42 * ospf_interface.h: Add OSPF_IF_PASSIVE_STATUS macro, looking
43 at configured value, or the global 'default' value, as
44 required.
45 * ospf_interface.c: (ospf_if_new_hook) Leave passive
46 unconfigured per default, allowing global 'default' to
47 take effect for unconfigured interfaces.
48 * ospf_packet.c: (various) use OSPF_IF_PASSIVE_STATUS
49 * ospf_vty.c: (ospf_passive_interface_default) new function,
50 unset passive from all interfaces if default is enabled, as
51 the per-iface settings become redundant.
52 (ospf_passive_interface_update) new func, update passive
53 setting taking global default into account.
54 ({no,}ospf_passive_interface_addr_cmd) Add support for
55 'default' variant of command.
56 (show_ip_ospf_interface_sub) Update to take global
57 default into account when printing passive status.
58 (ospf_config_write) ditto.
59 * ospfd.c: (ospf_new) set global passive-interface default.
60 * ospfd.h: (struct ospf) Add field for global
61 passive-interface.
62
Andrew J. Schorr08c83672006-09-25 13:26:14 +0000632006-09-25 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
64
65 * ospf_packet.c: (ospf_packet_dup, ospf_make_md5_digest)
66 Fix zlog_warn messages to eliminate compiler warnings.
67 (ospf_hello) Improve warning messages to show why we
68 are complaining.
69
Paul Jakmab5aeb442006-08-30 18:47:37 +0000702006-08-28 Andy Gay <andy@andynet.net>
71
72 * ospf_packet.c: (ospf_make_db_desc) Assert added with More-bit
73 fixes does not hold up with addition of Ogier DB-Exchange
74 optimisation, which can empty the db-summary list in between
75 sent DD packets. Remove assert, update More-bit always when
76 in Exchange.
77
Paul Jakma29b5a042006-08-27 08:01:20 +0000782006-08-27 J.J. Krabbendam <jkrabbendam@aimsys.nl>
79
80 * ospfd.c: (ospf_finish_final) default redistribute should be
81 unset too, fixes bug where reconfiguring ospfd completely
82 can no longer enable default redistribution.
83
Paul Jakma2518efd2006-08-27 06:49:29 +0000842006-08-25 Paul Jakma <paul.jakma@sun.com>
85
86 * (general) Bug #134. Be more robust to backward time changes,
87 use the newly added libzebra time functions.
88 In most cases: recent_time -> recent_relative_time()
89 gettimeofday -> quagga_gettime (QUAGGA_CLK_MONOTONIC, ..)
90 time -> quagga_time.
91 (ospf_make_md5_digest) time() call deliberately not changed.
92 (ospf_external_lsa_refresh) remove useless gettimeofday, LSA
93 tv_orig time was already set in ospf_lsa_new, called via
94 ospf_external_lsa_new.
95
Paul Jakmaba122e72006-08-27 06:24:34 +0000962006-08-04 Paul Jakma <paul.jakma@sun.com>
97
98 * ospf_lsdb.c: (ospf_lsdb_delete_entry) new function, consolidate
99 exact same functionality replicated in other functions.
100 (ospf_lsdb_add) Strip out code by using ospf_lsdb_delete_entry.
101 (ospf_lsdb_delete) ditto.
102 (ospf_lsdb_delete_all) ditto.
103
Paul Jakma8dd24ee2006-08-27 06:29:30 +00001042006-08-03 Paul Jakma <paul.jakma@sun.com>
105
106 * ospf_packet.c: (ospf_make_db_desc) Unset the DD More bit
107 after constructing the packet, if appropriate.
108 (ospf_db_desc_proc) Speed up Exchange, slave should raise
109 ExchangeDone earlier, as RFC mandates, by forming its reply
110 before deciding whether both sides are done, avoids a
111 needless round of empty DD packet exchanges at the end of
112 Exchange, hence speeding up ExchangeDone.
Paul Jakmaf0894cf2006-08-27 06:40:04 +0000113 Implement draft-ogier-ospf-dbex-opt DB-exchange optimisation.
Paul Jakma8dd24ee2006-08-27 06:29:30 +0000114 (ospf_db_desc) use UNSET_FLAG macro.
115
Andrew J. Schorr16700082006-07-27 22:29:06 +00001162006-07-27 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
117
118 * ospfd.c: (ospf_router_id_update) Fix and document the algorithm for
119 selecting the router ID: if there is not a statically configured ID,
120 then stick to the most recent value to avoid disruptive changes.
121 This should fix bug #288.
122
Paul Jakma1fe6ed32006-07-26 09:37:26 +00001232006-07-26 Paul Jakma <paul.jakma@sun.com>
124
125 * ospf_lsa.{c,h}: (ospf_lsa_unlock) Change to take a double pointer
126 to the LSA to be 'unlocked', so that, if the LSA is freed, the
127 callers pointer to the LSA can be NULLed out, allowing any further
128 use of that pointer to provoke a crash sooner rather than later.
129 * ospf_*.c: (general) Adjust callers of ospf_lsa_unlock to match
130 previous. Try annotate 'locking' somewhat to show which 'locks'
131 are protecting what LSA reference, if not obvious.
132 * ospf_opaque.c: (ospf_opaque_lsa_install) Trivial: remove useless
133 goto, replace with return.
134 * ospf_packet.c: (ospf_make_ls_ack) Trivial: merge two list loops,
135 the dual-loop predated the delete-safe list-loop macro.
136
Paul Jakma3fed4162006-07-25 20:44:12 +00001372006-07-25 Paul Jakma <paul.jakma@sun.com>
138
139 * ospf_neigbor.h: (struct ospf_neighbor) Add some additional
140 neighbour state statistics fields, timestamps for progressive
141 and regressive state changes, and pointer to event string
142 for the latter state change.
143 * ospf_nsm.c: (nsm_notice_state_change) Update new state changs
144 history as required.
145 * ospf_vty.c: (show_ip_ospf_neighbor_detail_sub) Print out above
146 new per-neighbour state change stats.
147
Paul Jakma539e1522006-07-11 17:49:22 +00001482006-07-10 Paul Jakma <paul.jakma@sun.com>
149
150 * ospf_nsm.c: (nsm_change_state) call nsm_clear_adj for all
151 adjacency losses, hence removing need for nsm_reset_nbr.
152 (nsm_reset_nbr) kill it, clear_adj in previous does fine.
153 (nsm_kill_nbr,nsm_start) remove nsm_reset_nbr call.
154 (ospf_nsm_event) Allow NSM function to be NULL, this along with
155 removal of nsm_reset_nbr, allows a bunch of now useless functiosn
156 to be removed.
157 Remove some useless variables.
158 (nsm_ignore) now useless, remove.
159 (nsm_bad_ls_req) ditto
160 (nsm_seq_number_mismatch) "
161 (nsm_oneway_received) "
162 (nsm_inactivity_timer) "
163 (nsm_ll_down) "
164 (NSM) replace removed action functions with NULL.
Paul Jakma3d63f382006-07-11 17:52:53 +0000165 (nsm_notice_state_changes) Move state change logging code to new
166 func to declutter nsm_change_state and ospf_nsm_event.
167 Log event with AdjChange, it's useful to know.
168 (nsm_change_state) move adjchange and snmp logging to previous.
169 (ospf_nsm_event) call nsm_notice_state_changes from here.
170 Move the debug message to entry of function, so it gets out
171 even if something goes wrong.
Paul Jakma90c33172006-07-11 17:57:25 +0000172 Record state change timestamp and event in nbr struct.
173 * ospf_neighbor.h: (struct ospf_neighbor) Add fields to record
174 timestamp of last NSM change and event.
175 * ospf_vty.c: (show_ip_ospf_neighbor_detail_sub) Print
176 last state change timestamp and event, if available.
Paul Jakma539e1522006-07-11 17:49:22 +0000177
Andrew J. Schorr13cd3dc2006-07-11 01:50:30 +00001782006-07-10 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
179
180 * ospf_packet.c: (ospf_hello) Improve NetworkMask mismatch warning
181 message to include interface name and conflicting prefix lengths.
182
Paul Jakma1f2c2742006-07-10 07:45:13 +00001832006-07-07 Paul Jakma <paul.jakma@sun.com>
184
185 * ospf_nsm.h: Add a NSM_Deleted neighbour state, to act as dummy
186 state indicating the neighbour is to be deleted.
187 * ospf_nsm.c: (general) Use the NSM_Deleted state to delete
188 neighbours, thus allowing code to be slightly more obvious
189 in its flow.
190 (nsm_timer_set) Add NSM_Deleted. Add another timer the code
191 missed.
192 (nsm_kill_nbr) No need for special case call to nsm_change_state
193 anymore.
194 Make the assert and error-handling for same case more readable
195 (Andrew Schorr)
196 Remove the call to ospf_nbr_delete, nsm_change_state can do
197 this generally now via NSM_Deleted.
198 (struct ... NSM) Add the dummy NSM_Deleted state, the 3 events
199 that can lead to nsm_kill_nbr all now transition the NBR to
200 NSM_Deleted and the general change_state function can be left
201 to do the work.
202 (ospf_nsm_event) Special casing of events and early-return can
203 be removed now.
204 On transition into Deleted, delete the nbr.
205 * ospf_dump.c: (ospf_nsm_state_msg) Add Deleted.
206
Paul Jakmaaa2737a2006-07-06 11:12:39 +00002072006-07-06 Paul Jakma <paul.jakma@sun.com>
208
209 * ospf_nsm.c: (ospf_nsm_event) LLDown event also results in nbr
210 being deleted, requires early-return too. Likely explains
211 some crash reports after interface events.
212
Paul Jakmaf7a76ab2006-07-04 13:57:49 +00002132006-07-04 Paul Jakma <paul.jakma@sun.com>
214
215 * ospf_nsm.c: (general) Various small cleanups from Andrew's
216 review of last set of patches.
217 (nsm_timer_set) Loading, Full and default can share
218 same code too.
219 (nsm_should_adj) Can just be one big OR.
220 (nsm_twoway_received) Collapse into return statement.
221
Paul Jakmad7b0fb62006-07-04 13:35:24 +00002222006-07-02 Paul Jakma <paul.jakma@sun.com>
223
224 * ospf_nsm.c: (nsm_should_adj) New function, just consolidate the
225 10.4 adjacency check from nsm_twoway_received/nsm_adj_ok.
226 (nsm_twoway_received/nsm_adj_ok) Use former.
Paul Jakmad1b1cd82006-07-04 13:50:44 +0000227 (nsm_clear_adj) clear adjacency related state for a
228 neighbour, needed for some state changes from > ExStart down
229 to ExStart or less, which need not go through nsm_reset_nbr.
230 (nsm_reset_nbr) move code to former. Should be static.
Paul Jakmaba0beb42006-07-04 13:44:19 +0000231 (ospf_nsm_event) Don't allow action functions to change
232 next_state if the NSM tables do not indicate next_state is
233 conditional, log warning if one tries - existing code
234 appears fine though.
Paul Jakmad1b1cd82006-07-04 13:50:44 +0000235 Remove long dead code.
236 Use nsm_clear_adj for state changes that take down
237 adjacencies to TwoWay/ExStart.
Paul Jakmae55dd532006-07-04 13:46:14 +0000238 (nsm_timer_set) ls_req timer should be OFF in early states.
239 Compact several identical sections.
240 Set inactivity timer to OFF for Down, for documentary
241 purposes.
Paul Jakmad1b1cd82006-07-04 13:50:44 +0000242 (nsm_kill_nbr) Oops, action function shouldn't try return
243 1 for error.
Paul Jakma5db95bc2006-07-04 13:52:29 +0000244 * ospf_lsa.c: (ospf_translated_nssa_refresh) CID #13.
Paul Jakmad7b0fb62006-07-04 13:35:24 +0000245
Andrew J. Schorr1c066bf2006-06-30 16:53:47 +00002462006-06-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
247
248 * ospf_vty.c: (show_ip_ospf_neighbor_id) Should show all instances
249 of that neighbor (since it may appear on multiple interfaces)
250 instead of bailing out after showing the first match.
251
Andrew J. Schorr76947872006-06-30 03:21:05 +00002522006-06-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
253
254 * ospf_nsm.c: (nsm_twoway_received) When deciding whether to
255 change from state Init to ExStart, the test for whether the
256 neighboring router is DR or BDR should be against the
257 local router's notion of DR/BDR, not the neighbor's view.
258
Andrew J. Schorrd7e60dd2006-06-29 20:20:52 +00002592006-06-28 Erik Muller <erikm@internap.com>
260
261 * ospfd.h: Define 2 new struct ospf config flags:
262 OSPF_LOG_ADJACENCY_CHANGES and OSPF_LOG_ADJACENCY_DETAIL
263 * ospf_nsm.c (nsm_change_state): Log adjacency changes if
264 requested.
265 * ospf_vty.c (ospf_log_adjacency_changes): New command function
266 to implement ospf subcommand "log-adjacency-changes [detail]".
267 (no_ospf_log_adjacency_changes) Turn off log-adjacency-changes.
268 (show_ip_ospf) Show whether adjacency changes are logged.
269 (ospf_config_write) Add "log-adjacency-changes [detail]" to config.
270 (ospf_vty_init) Add ospf_log_adjacency_changes and
271 no_ospf_log_adjacency_changes.
272
Paul Jakma9560fa82006-06-26 12:50:06 +00002732006-06-26 Paul Jakma <paul.jakma@sun.com>
274
275 * ospf_abr.c: (general) NSSA translate-candidate ABRs need to
276 be ASBRs, or other routers may rightfully refuse to install
277 translated type-5s LSAs. reported by dendroot@gmail.com.
278 (ospf_abr_nssa_check_status) Detect change in translator
279 state when ABR, and inc/dec redistribute count as when we
280 leave/enter the disabled state - so that translate-enabled
281 ABR properly sets ASBR bit on non-NSSA areas.
282 Run the resulting function through indent to clean it up.
283 * ospf_lsa.c: (router_lsa_flags) For purposes of ASBR bit,
284 NSSA area is same as stub area.
285
Andrew J. Schorr0ffb7092006-06-24 19:40:13 +00002862006-06-24 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
287
Andrew J. Schorr9aecfae2006-06-24 20:05:02 +0000288 * ospf_snmp.c: (ospfTrapNbrStateChange, ospfTrapIfStateChange) Improve
289 info log message to indicate why the trap is being sent.
290
2912006-06-24 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
292
Andrew J. Schorr0ffb7092006-06-24 19:40:13 +0000293 * ospf_dump.c: (config_write_debug) Fix typo to show debug ospf nsm
294 status properly (not ism status).
295
Andrew J. Schorr6e72cb62006-06-18 00:45:48 +00002962006-06-17 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
297
298 * ospf_vty.c: ({no_,}ospf_passive_interface) Replace if_lookup_by_name
299 with a call to if_get_by_name -- if the interface does not exist
300 already, it should be created. And remove the obsolete warning
301 message.
302
Paul Jakma429ac782006-06-15 18:40:49 +00003032006-06-15 Paul Jakma <paul.jakma@sun.com>
304
305 * ospf_interface.h: (struct ospf_if_info) Add reference counts
306 for multicast group memberships. Add various macros to help
307 manipulate/check membership state.
308 * ospf_interface.c: (ospf_if_set_multicast) Maintain the
309 ospf_if_info reference counts, and only actually drop
310 memberships if it hits 0, to avoid losing membership when
311 OSPF is disabled on an interface with multiple active OSPF
312 interfaces.
313 * ospf_packet.c: (ospf_{hello,read}) Use the new macros to
314 check/set
315 multicast membership.
316 * ospf_vty.c: (show_ip_ospf_interface_sub) ditto.
317
Paul Jakmaac904de2006-06-15 12:04:57 +00003182006-05-31 Paul Jakma <paul.jakma@sun.com>
319
320 * ospf_lsdb.c: (ospf_lsdb_delete) robustify against NULL arguments,
321 print warning.
322 * ospf_lsa.c: (ospf_discard_from_db) ditto.
323 (ospf_maxage_lsa_remover) Check lsa->lsdb for validity, possible
324 mitigation (but not solution) for bug #269.
325
Paul Jakma88871b12006-06-15 11:41:19 +00003262006-05-30 Paul Jakma <paul.jakma@sun.com>
327
328 * ospf_packet.c: (ospf_read) Debug message about packets
329 received on unenabled interfaces should be conditional on
330 debug being set.
331
Paul Jakmad1c65c22006-06-27 08:01:43 +00003322006-05-23 Paul Jakma <paul.jakma@sun.com>
333
334 * ospf_vty.c: (general) Replace in-place route redistribution
335 command and help strings with the new auto-generated defines
336 from lib/route_types.h
337
Paul Jakmaae128052006-05-12 23:15:30 +00003382006-05-13 Paul Jakma <paul.jakma@sun.com>
339
340 * ospf_lsa.c: (ospf_translated_nssa_refresh) fix the sanity
341 check to match the assert, small error in CID #13 fix.
342
Paul Jakma70461d72006-05-12 22:57:57 +00003432006-05-12 Paul Jakma <paul.jakma@sun.com>
344
345 * ospf_lsa.c: (ospf_lsa_action) Get rid of the ospf_lookup
346 call, which is not checked for NULL return, by stripping out
347 functionality which is never used, hence fixing Coverity CID
348 #29.
349 (struct lsa_action) remove unused member.
Paul Jakmae54e6e52006-05-12 23:11:14 +0000350 (ospf_translated_nssa_refresh) Add non-assert sanity check,
351 in case DEBUG isn't defined.
352 Debug message when no type7 exists should print the ID from
353 the type5, not the type7, fixes CID #13.
354 * ospf_interface.c: (ospf_if_exists) Fix missing NULL return
Paul Jakmae43be0e2006-05-12 23:00:06 +0000355 check on ospf_lookup, CID #27.
Paul Jakma6db3a6f2006-05-12 23:02:46 +0000356 * ospf_asbr.c: (ospf_redistribute_withdraw) remove ospf_lookup
357 call by taking the struct ospf * as argument, which the
358 caller has, fixing CID #28.
359 * ospf_asbr.h: (ospf_redistribute_withdraw) update declaration
360 * ospf_zebra.c: (ospf_redistribute_unset) update call to
361 ospf_redistribute_withdraw to match.
Paul Jakmabfd7c7d2006-05-12 23:04:45 +0000362 * ospf_ia.c: (ospf_update_router_route) ospf->backbone could be
363 NULL when passed to ospf_find_asbr_route_through_area,
364 check for NULL first, CID #14.
Paul Jakmadeb15612006-05-12 23:07:27 +0000365 * ospf_ism.c: (ism_change_state) NULL check on oi->area is
366 useless, it's always valid. Only possibility where it
367 couldn't be is if there is a race between abr_task and
368 cleaning up oi's, in which case a NULL check here isn't going
369 to do anything. Fixes CID #15.
Paul Jakma70461d72006-05-12 22:57:57 +0000370
Paul Jakmacac3b5c2006-05-11 13:31:11 +00003712006-05-11 Paul Jakma <paul.jakma@sun.com>
372
373 * ospf_vty.c: (general) Audit ospf_lookup calls in commands,
374 ensure check for NULL result, make vty messages consistent.
375 (show_ip_ospf_interface) Missing NULL check on ospf_lookup
376 result, fixes Coverity CID #70.
Paul Jakma1a8ec2b2006-05-11 13:34:08 +0000377 (no_ospf_area_filter_list) Check NULL result from
378 ospf_area_lookup_by_area_id, fixes Coverity CID #69
Paul Jakma894f8b62006-05-12 22:50:40 +0000379 * ospf_route.c: (ospf_route_delete_same_ext) Fix deref before
380 NULL check by moving into check-protected block, fix CID #49.
Paul Jakma214a4452006-05-12 22:51:49 +0000381 * ospf_abr.c: (ospf_area_range_cost_set) Shouldn't create a new
382 range, should just lookup to see if one exists, the new range
383 is just leaked. Fixes CID #46.
Paul Jakma4021b602006-05-12 22:55:41 +0000384 * ospf_lsa.c: (ospf_default_originate_timer) Let the thread
385 take (struct ospf *) as thread argument, rather than (struct
386 ospf *)->default_originate, thus avoiding having to call
387 ospf_lookup.
388 * ospf_zebra.c: (ospf_redistribute_default_set) change setup
389 of ospf_default_originate_timer thread to match.
390 * ospfd.c: (ospf_router_id_update) ditto.
Paul Jakmacac3b5c2006-05-11 13:31:11 +0000391
Paul Jakma9c27ef92006-05-04 07:32:57 +00003922006-04-24 Paul Jakma <paul.jakma@sun.com>
393
394 * (general) More Virtual-link fixes, again with much help in
395 testing / debug from Juergen Kammer. Primarily in SPF.
396 * ospf_spf.h: Add guard. ospf_interface.h will include this
397 header.
398 * ospf_interface.h: Modify ospf_vl_lookup definition to take
399 struct ospf as argument, so as to allow for NULL area
400 argument.
401 (struct ospf_vl_data) Remove out_oi, instead add a struct
402 vertex_nexthop, to use as initial nexthop for backbone paths
403 through a vlink.
404 * ospf_interface.c: (ospf_vl_lookup) Modified to allow
405 NULL area to be passed to indicate "any" (first) area.
406 Add extra debug.
407 (ospf_vl_set_params) vl_oi -> nexthop. Add extra debug.
408 (ospf_vl_up_check) Fix debug, inet_ntoa returns a static
409 buffer..
410 * ospf_route.c: (ospf_intra_add_router) Vlinks dont go through
411 backbone, don't bother checking.
412 * ospf_spf.c: (static struct list vertex_list) Record vertices
413 that will need to be freed.
414 (cmp) Order network before router vertices, as required,
415 wasn't implemented.
416 (vertex_nexthop_free) Mild additional robustness check.
417 (vertex_parent_free) Take void argument, as this function
418 is passed as list deconstructor for vertex parent list.
419 (ospf_vertex_new) More debug. Set deconstructor for parent
420 list. Track allocated vertices on the vertex_list.
421 (ospf_vertex_free) Get rid of the tricky recursive cleanup of
422 vertices. Now frees only the given vertex.
423 (ospf_vertex_add_parent) Fix assert.
424 (ospf_nexthop_calculation) Fix calculation of nexthop for
425 VLink vertices, lookup the vl_data and use its previously
426 recorded nexthop information.
427 (ospf_spf_calculate) Vertices are freed simply by deleting
428 vertex_list nodes and letting ospf_vertex_free as deconstructor
429 work per-node.
430 (ospf_spf_calculate_timer) Trivial optimisation, leave
431 backbone SPF calculation till last to reduce SPF churn on
432 VLink updates.
433 * ospf_vty.c: (ospf_find_vl_data) update call to ospf_vl_lookup
434 (no_ospf_area_vlink_cmd) ditto.
435 (show_ip_ospf_interface_sub) For Vlinks, the peer address is
436 more interesting than the output interface.
437
Paul Jakma478aab92006-04-03 21:25:32 +00004382006-04-03 Paul Jakma <paul.jakma@sun.com>
439
440 * (general) Fix issues with handling of Vlinks and entries
441 in the nbrs route-table which were highlighted by the
442 nsm/nbr_self fixes from bug #234. Many thanks to Juergen
443 Kammer for his help and efforts in testing out debug patches to
444 pinpoint the issue.
445 * ospf_interface.c: (ospf_vl_new) Add nbr_self for Vlink.
446 * ospf_neighbor.c: (ospf_nbr_key) new static function, helper
447 to create key in nbrs table for a given nbr.
448 (ospf_nbr_delete) Use ospf_nbr_key. Add an assert() to
449 document an expected state.
450 (ospf_nbr_add_self) Ditto.
451 (ospf_nbr_lookup_by_addr) Add an assert.
452 * ospf_nsm.c: (nsm_kill_nbr) Can never kill the nbr_self
453 psuedo-neighbour.
454
Paul Jakma075c2012006-03-30 14:34:31 +00004552006-03-27 Paul Jakma <paul.jakma@sun.com>
456
457 * ospf_lsa.c: (ospf_lsa_checksum) Add an explicit cast to avoid
458 the ambiguities of ANSI and C99 C with respect to type
459 conversion. Detailed problem report and test case with
460 example data supplied by Dmitry Ivanov <dimss@telecentrs.lv>.
461
Paul Jakma1a8ee0e2006-03-30 14:20:00 +00004622006-03-25 Paul Jakma <paul.jakma@sun.com>
463
464 * ospf_interface.c: (ospf_if_lookup_recv_if) Ignore loopbacks,
465 we can never ever receive packets on those. Should fix
466 case where CARP is run with address in same subnet as real
467 interface. Problem report and diagnosis thanks to:
468 Landon Fuller <landonf@opendarwin.org>.
469 However, ospf_read() still can't deal deterministically with
470 multiple interfaces in same subnet.
471
Paul Jakmac2b478d2006-03-30 14:16:11 +00004722006-03-23 Steve Lawson <steve.lawson@aheadcomusa.com>
473
474 * ospf_lsa.c: (ospf_lsa_install) Fix incorrect byte-order
475 conversion of OSPF_MAX_SEQUENCE_NUMBER
476
paule8e19462006-01-19 20:16:55 +00004772006-01-19 Paul Jakma <paul.jakma@sun.com>
478
479 * (general) various miscellaneous compiler warning fixes.
480 Remove redundant break statements from switch clauses
481 which return.
482 return from main, not exit, cause it annoys SOS.
483 Remove stray semi-colons which cause empty-statement
484 warnings.
485
paul779adb02006-01-18 15:07:38 +00004862006-01-18 Juergen Kammer <j.kammer@eurodata.de>
487
488 * ospf_lsa.c: (ospf_router_lsa_new) dont take reference to the
489 stream data until it is constructed, data reference is
490 volatile due to the potential resize in link_info_set
491
4922006-01-18 Paul Jakma <paul.jakma@sun.com>
493
494 * ospf_lsa.c: (link_info_set) Resize the stream if required and
495 possible. Return number of links added.
496 (lsa_link_*_set) use return value from previous.
497 * ospf_lsa.h: Add OSPF_ROUTER_LSA_LINK_SIZE define.
498
paulc6371712006-01-17 17:49:53 +00004992006-01-17 Paul Jakma <paul.jakma@sun.com>
500
501 * ospf_packet.c: (ospf_verify_header) print out the types
502 involved if there's a mismatch.
503 * ospf_zebra.c: (ospf_zebra_add) Adjust to new zserv format.
504
paul818e56c2006-01-10 23:27:05 +00005052006-01-10 Len Sorensen <lennartsorensen@ruggedcom.com>
506
507 * (general) Bug #234, see also [quagga-dev 3902].
508 Fix problem with nbr_self not being properly reinitialised
509 when an interface comes up, after having been down.
paul1a643f82006-01-11 01:08:19 +0000510 Some re-arrangement done by Paul Jakma, any bugs introduced
511 on top of Len's suggested changes are his.
paul818e56c2006-01-10 23:27:05 +0000512 * ospf_neighbor.c: (ospf_nbr_add_self) centralise
513 initialisation of nbr_self parameters here.
514 * ospf_interface.c: (ospf_if_new) deleting initialisation of
515 parameters of nbr_self, just rely on call to
516 ospf_nbr_add_self.
517 (ospf_if_cleanup) ditto.
518 * ospfd.c: (ospf_network_run) ditto.
519
paul98429f62006-01-10 22:11:54 +00005202006-01-10 Juris Kalnins <juris@mt.lv>
521
522 * ospf_zebra.c: (ospf_interface_address_delete) fix rare leak of
523 struct connected in an error case.
paul818e56c2006-01-10 23:27:05 +0000524 * ospf_packet.c: (ospf_make_md5_digest) fix odd, if not
525 undefined effect, assignment of an increment expression.
paul98429f62006-01-10 22:11:54 +0000526
paul86752842006-01-10 20:34:46 +00005272006-01-10 Paul Jakma <paul.jakma@sun.com>
528
529 * ospfd.c: (ospf_network_run) checking to see if router-id
530 is set should be on ospf->router_id, not router_id_static.
531 This was causing ospfd to not start if router-id had not
532 been configured statically.
533 (ospf_if_update) ditto.
paulc42c1772006-01-10 20:36:49 +0000534 * ospf_vty.c: (config_write_ospf_distribute) trim down
535 redundant strings.
paul86752842006-01-10 20:34:46 +0000536
paul00c290e2005-11-26 09:21:43 +00005372005-11-26 Paul Jakma <paul.jakma@sun.com>
538
539 * ospf_api.c: (struct opaque_lsa) change from gcc zero-length
540 array to C99 incomplete type array.
paulc9c93d52005-11-26 13:31:11 +0000541 * (general) s/graceful/deferred/ in all files, the former term
542 is confusing wrt OSPF Graceful-Restart.
543 * ospfd.c: (ospf_deferred_shutdown_check) dont return
544 a function which returns void. SOS complains about this.
545 (ospf_finish)
paul00c290e2005-11-26 09:21:43 +0000546
paulb29800a2005-11-20 14:50:45 +00005472005-11-20 Paul Jakma <paul.jakma@sun.com>
548
549 * ospfd.h: remove the OSPF_ROUTER_ID_UPDATE_DELAY define
550 (struct ospf) remove the router_id timer thread.
551 remove export of ospf_router_id_update_timer.
552 * ospfd.c: (ospf_router_id_update) call ospf_if_update to
553 poke interfaces into action after ID has been configured.
554 (ospf_router_id_update_timer) removed.
555 (ospf_finish_final) t_router_id_update timer is gone.
556 (ospf_network_run) router-id update timer gone.
557 call ospf_router_id_update directly if ID not configured.
558 In the per-iface loop, don't ospf_if_up interfaces if
559 ID is still not configured. The update function will call
560 ospf_if_update anyway.
561 (ospf_if_update) ID update timer is gone. Just return if no
562 ID is set.
563 * ospf_vty.c: (ospf_router_id) call ospf_router_id_update, no
564 timer needed.
565 * ospf_zebra.c: (ospf_router_id_update_zebra) call
566 ospf_router_id_update directly, not via timer.
paulc24d6022005-11-20 14:54:12 +0000567 * ospf_abr.c: (ospf_abr_announce_network_to_area) check
568 returned LSA of ospf_summary_lsa_refresh and print warning if
569 it failed.
570 (ospf_abr_announce_network_to_area) similar
571 (ospf_abr_announce_rtr_to_area) similar
572 * ospf_lsa.c: (ospf_router_lsa_new) check LSA returned is valid.
573 (ospf_router_lsa_originate) similar
574 (ospf_router_lsa_refresh, ospf_network_lsa_new) similar
575 (ospf_summary_lsa_new) Check ID is valid.
576 (ospf_summary_lsa_originate) ditto, and check returned LSA from
577 previous function is !NULL.
578 (ospf_summary_lsa_refresh) check ospf_summary_lsa_new return
579 is !NULL.
580 (ospf_summary_asbr_lsa_new) ID valid check.
581 (ospf_summary_asbr_lsa_originate) similar.
paulb29800a2005-11-20 14:50:45 +0000582
ajs70cd3472005-11-16 19:33:22 +00005832005-11-16 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
584
ajs649654a2005-11-16 20:17:52 +0000585 * ospf_dump.h: Define OSPF_TIME_DUMP_SIZE as appropriate buffer size
586 for use with ospf_timer_dump and ospf_timeval_dump.
587 * ospf_vty.c: Change all buffer sizes used with ospf_timer_dump and
588 ospf_timeval_dump to have size OSPF_TIME_DUMP_SIZE.
589 (show_ip_ospf_interface_sub) Fix possible buffer overflow in
590 call to ospf_timer_dump.
591
5922005-11-16 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
593
ajs70cd3472005-11-16 19:33:22 +0000594 * ospf_ism.h: (OSPF_ISM_TIMER_OFF) Improve macro syntax by enclosing
595 in 'do {...} while(0)'.
596
paul31a59762005-11-14 11:11:11 +00005972005-11-14 Paul Jakma <paul.jakma@sun.com>
598
599 * ospfd.c: (ospf_new) stub-shutdown should just default to
600 unconfigured, too strange otherwise.
601 (ospf_finish_final) t_opaque_lsa_self TIMER_OFF should be
602 preprocessor conditional on HAVE_OPAQUE_LSA.
603 * ospfd.h: (struct ospf) remove the SHUTDOWN_DEFAULT define.
604 no longer used, plus it wasn't in range that the command
605 accepted.
606 * ospf_zebra.h: Depends on vty.h, include it.
607
paul58e1bef2005-11-11 12:10:03 +00006082005-11-11 Paul Jakma <paul.jakma@sun.com>
609
610 * ospf_spf.c: (ospf_canonical_nexthops_free) Free only
611 the nexthops pointing to the root vertex. We may visit a
612 vertex twice or the vertex may have some inherited nexthops,
613 if we free other nexthops we could crash.
614
paulc8c15212005-11-04 12:31:39 +00006152005-11-04 Paul Jakma <paul.jakma@sun.com>
616
617 * ospf_{dump,spf,vty}.c: Oops, use the internal tv_sub
618 function rather than unportable timersub.
619
paul484315f2005-11-03 09:08:29 +00006202005-11-03 Paul Jakma <paul.jakma@sun.com>
621
622 * ospf_apiserver.c: (apiserver_sync_callback) stray semi-colon
623 * ospf_packet.c: include checksum.h, remove the in_cksum extern
624 * prototypes.
625 * ospf_te.h: Add braces, quell warning.
paul6d452762005-11-03 11:15:44 +0000626 * ospf_packet.c: Change level of some warnings to
627 informational.
paulc8c15212005-11-04 12:31:39 +0000628
paul88d6cf32005-10-29 12:50:09 +00006292005-10-29 Paul Jakma <paul.jakma@sun.com>
630
631 * (general) RFC3137 stub-router support
632 * ospfd.h: Add OSPF_OUTPUT_COST_INFINITE define.
633 (struct ospf_master) Add a OSPF_MASTER_SHUTDOWN flag for
634 options, to allow shutdown to distinguish between complete
635 shutdown and shutdown of a subset of ospf instances.
636 (struct ospf)
637 Add stub_router_{startup,shutdown_}time, configuration of startup
638 and shutdown time for stub-router.
639 Add t_graceful_shutdown struct thread, timer for graceful
640 shutdown, if needed.
641 (struct ospf_area) Add stub_router_state - run time state of
642 stub-router for an area. Add flags for ADMIN, IS and WAS
643 states.
644 Add t_stub_router, timer thread to resend router-lsa for an
645 area.
646 * ospf_lsa.c: (ospf_link_cost) new simple function to spit out
647 either the given lnks cost or infinite cost if stub-router is
648 in effect.
649 (lsa_link_{ptop,broadcast,virtuallink,ptomp}_set) use
650 previous function for transit-links.
651 (ospf_stub_router_timer) timer thread for end of startup stub
652 router. Change state as required for the area and setup
653 re-origination of router-lsa.
654 (ospf_stub_router_check) Check/do whether stub-router should be
655 enabled, and whether it requires timer to be setup.
656 (ospf_router_lsa_new) call previous function at top.
657 (ospf_router_lsa_originate) no external callers, made static.
658 * ospf_lsa.h: (ospf_router_lsa_originate) removed.
659 * ospf_main.c: (sigint) make static.
660 remove call to exit, as ospf_terminate now deals with
661 exiting.
662 * ospf_route.c: (ospf_terminate) removed, now in ospfd.c.
663 * ospf_vty.c: (show_ip_ospf_area) print out state of
664 stub-router, if active.
665 (show_ip_ospf) print out configuration of stub-router
666 support, and details of graceful-shutdown if the timer is
667 active.
668 ((no)?ospf_max_metric_router_lsa_{admin,startup,shutdown}) new
669 commands to (de-)?configure stub-router support.
670 (config_write_stub_router) write out config of stub-router.
671 (ospf_config_write) call previous.
672 (ospf_vty_init) install the new stub-router commands.
673 * ospfd.c: various functions made static.
674 (ospf_new) Set defaults for stub-router. Graceful shutdown
675 is made to default on, just to be adventerous.
676 (ospf_graceful_shutdown_finish) new function, final part of
677 shutdown.
678 (ospf_graceful_shutdown_timer) timer thread wrapper for
679 graceful-shutdown.
680 (ospf_graceful_shutdown_check) check whether to setup timer
681 for shutdown or proceed directly to final shutdown.
682 (ospf_terminate) moved here from ospf_route.c, call
683 ospf_finish for each instance.
684 (ospf_finish) renamed to ospf_finish_final and made static.
685 (ospf_finish) new function, exported wrapper around
686 ospf_graceful_shutdown_check.
687 (ospf_finish_final) complete shutdown of an instance.
688 Add missing TIMER_OFF's of two timer threads.
689 (ospf_area_free) opaque self lsa timer should be turned off.
690
paulb8ad39d2005-10-23 15:23:05 +00006912005-10-23 Paul Jakma <paul.jakma@sun.com>
692
paule029d442005-10-23 15:26:24 +0000693 * ospf_apiserver.c: (ospf_apiserver_term) This function should
694 not have side-effects (eg segv) if no apiserver instances are
695 active, ie be robust.
paulb8ad39d2005-10-23 15:23:05 +0000696 * ospf_vty.c: (show_ip_ospf) fix display of SPF timer if it
697 has not yet been run.
698
paulf9ad9372005-10-21 00:45:17 +00006992005-10-21 Paul Jakma <paul.jakma@sun.com>
700
paulea4ffc92005-10-21 20:04:41 +0000701 * ospf_dump.c: (ospf_timeval_dump) fix ms adjustment, thanks to
702 Andrew Schorr.
703 * ospf_vty.c: (ospf_config_write) fix write out of spf timers
704 configuration.
705
7062005-10-21 Paul Jakma <paul.jakma@sun.com>
707
pauld24f6e22005-10-21 09:23:12 +0000708 * (general) SPF millisecond resolution timer with adaptive,
709 linear back-off holdtime. Prettification of ospf_timer_dump.
710 * ospf_dump.c: (ospf_timeval_dump) new function. The guts of
711 ospf_timer_dump, but made to be more dynamic in printing out
712 the relative timeval, sliding the precision printed out
713 according to the value.
714 (ospf_timer_dump) guts moved to ospf_timeval_dump.
715 * ospf_dump.h: export ospf_timeval_dump.
716 * ospf_flood.c: (ospf_flood) remove gettimeofday, use
717 the libzebra exported recent_time instead, as it's not
718 terribly critical to have time exactly right - the dropped
719 LSA will be retransmited to us if we don't ACK it.
720 * ospf_packet.c: (ospf_ls_upd_timer) Ditto, but here we're
721 not transmitting, just putting LSA back on update transmit list.
722 * ospfd.h: delay and holdtimes should be unsigned.
723 Add spf_max_holdtime and spf_hold_multiplier.
724 Update default defines for delay and hold time to be in msec.
725 (struct ospf) change the SPF timestamp to a struct timeval.
726 Remove ospf_timers_spf_(un)?set.
727 * ospfd.c: (ospf_timers_spf_{set,unset}) removed.
728 (ospf_new) initialise spf_max_holdtime and spf_hold_multiplier
729 * ospf_spf.c: (ospf_spf_calculate) SPF timestamp is a timeval
730 now, update with gettimeofday.
731 (ospf_spf_calculate_schedule) Change SPF timers to millisecond
732 resolution.
733 Make the holdtime be adaptive, with a linear increase in
734 holdtime ever consecutive SPF run which occurs within holdtime
735 of previous SPF, bounded by spf_max_holdtime.
736 * ospf_vty.c: Update spf timers commands.
737 (ospf_timers_spf_set) trivial helper.
738 (ospf_timers_throttle_spf_cmd) new command to set SPF delay,
739 initial hold and max hold times with millisecond resolution.
740 (ospf_timers_spf_cmd) Deprecated. Accept the old values,
741 convert to msec, truncate to new limits.
742 (no_ospf_timers_throttle_spf_cmd) set timers to defaults.
743 (no_ospf_timers_spf_cmd) deprecated form, same as previous.
744 (show_ip_ospf_cmd) Display SPF parameters and times.
745 (show_ip_ospf_neighbour_header) Centralise the 'sh ip os ne'
746 header.
747 (show_ip_ospf_neighbor_sub) Fix the field widths. Get rid of
748 the multiple spaces which were making the lines even longer.
749 (show_ip_ospf_neighbor_cmd) Use show_ip_ospf_neighbour_header
750 (show_ip_ospf_neighbor_all_cmd) ditto and fix the field
751 widths for NBMA neighbours.
752 (show_ip_ospf_neighbor_int) Use header function.
753 (show_ip_ospf_nbr_nbma_detail_sub) use sizeof for timebuf,
754 local array - safer.
755 (show_ip_ospf_neighbor_detail_sub) ditto
756 (ospf_vty_init) install the new SPF throttle timer commands.
757
7582005-10-21 Paul Jakma <paul.jakma@sun.com>
759
paulf9ad9372005-10-21 00:45:17 +0000760 * (general) OSPF fast, sub-second hello and 1s dead-interval
761 support.
762 * ospf_dump.c: (ospf_timer_dump) Print out milliseconds too.
763 Callers typically specify a length of 9, so most see
764 millisecs unless they specify the additional length.
765 * ospf_interface.h: (struct ospf_interface) new interface param,
766 fast_hello.
767 * ospf_interface.c: (ospf_if_table_lookup) add brackets,
768 gcc warning fix.
769 (ospf_new_if_params) Initialise fast_hello param.
770 (ospf_free_if_params) Check whether fast_hello is configured.
771 (ospf_if_new_hook) set fast_hello to default.
772 * ospf_ism.h: Wrap OSPF_ISM_TIMER_ON inside do {} while (0) to
773 prevent funny side-effects from its if statement when this
774 macro is used conditionally by other macros.
775 (OSPF_ISM_TIMER_MSEC_ON) new macro, set in milliseconds.
776 (OSPF_HELLO_TIMER_ON) new macro to set hello timer according
777 to whether fast_hello is set.
778 * ospf_ism.c: Update all setting of the hello timer to use
779 either OSPF_ISM_TIMER_MSEC_ON or OSPF_HELLO_TIMER_ON. The
780 former is used when hello is to be sent immediately.
781 * ospf_nsm.c: ditto
782 * ospf_packet.c: (ospf_hello) hello-interval is not checked
783 for mismatch if fast_hello is set.
784 (ospf_read) Annoying nit, fix "no ospf_interface" to be debug
785 rather than a warning, as it can be perfectly normal to
786 receive packets when logical subnets are used.
787 (ospf_make_hello) Set hello-interval to 0 if fast-hellos are
788 configured.
789 * ospf_vty.c: (ospf_auto_cost_reference_bandwidth) annoying
790 nit, don't vty_out if this command is given, it gets tired
791 quick.
792 (show_ip_ospf_interface_sub) Print the hello-interval
793 according to whether fast-hello is set or not.
794 Print the extra 5 millisec characters from (ospf_timer_dump)
795 if fast-hello is configured.
796 (ospf_vty_dead_interval_set) new function, common to all
797 forms of dead-interval command, to set dead-interval and
798 fast-hello correctly. If a dead-interval is given, unset
799 fast-hello, else if a hello-multiplier is set, set
800 dead-interval to 1 and fast-hello to given multiplier.
801 (ip_ospf_dead_interval_addr_cmd) use
802 ospf_vty_dead_interval_set().
803 (ip_ospf_dead_interval_minimal_addr_cmd) ditto.
804 (no_ip_ospf_dead_interval) Unset fast-hello.
805 (no_ip_ospf_hello_interval) Bug-fix, unset of hello-interval
806 should set it to OSPF_HELLO_INTERVAL_DEFAULT, not
807 OSPF_ROUTER_DEAD_INTERVAL_DEFAULT.
808 (config_write_interface) Write out fast-hello.
809 (ospf_config_write) Write a comment about
810 "auto-cost reference-bandwidth" having to be equal on all
811 routers. Hopefully just as noticeable as old practice of
812 writing to vty, but less annoying.
813 (ospf_vty_if_init) install the two new dead-interval
814 commands.
815 * ospfd.h: Add defines for OSPF_ROUTER_DEAD_INTERVAL_MINIMAL
816 and OSPF_FAST_HELLO_DEFAULT.
817
pauleb3da6d2005-10-18 04:20:33 +00008182005-10-18 Paul Jakma <paul.jakma@sun.com>
819
820 * (general) SPF memory management cleanup and fix for rare
821 double-free bug.
822 * ospf_spf.h: (struct vertex_parent) New struct to hold parent
823 specific data, eg the backlink and the parent vertex pointer,
824 and point to the appropriate general struct vertex_nexthop.
825 (struct vertex_nexthop) remove parent vertex pointer, so
826 this struct can be shared across vertices.
827 (struct vertex) rename list child to list children. Remove
828 list of nexthops, replace with list of vertex_parents.
829 * ospf_spf.c: (update_stat) trivial, remove cast from void *.
830 (vertex_nexthop_new) remove init of parent - field is gone
831 from struct vertex_nexthop.
832 (ospf_canonical_nexthops_free) Remove the canonical
833 vertex_nexthop memory objects. These are the vertex_nexthops
834 attached to the first level of router vertices from the root.
835 (vertex_parent_new) new function, create a vertex_parent.
836 (vertex_parent_free) ditto, but free it.
837 (ospf_vertex_new) Update to match changes to struct vertex.
838 (ospf_vertex_free) Recursively free a struct vertex and its
839 children. The parent list is used as a reference count.
840 vertex_nexthops must be free seperately, if required.
841 (ospf_vertex_dump) update to match struct vertex changes.
842 Print out backlink of parents too.
843 (ospf_vertex_add_parent) ditto.
844 (ospf_lsa_has_link) update comment.
845 (ospf_nexthop_add_unique) removed, not needed anymore.
846 (ospf_nexthop_merge) ditto.
847 (ospf_spf_consider_nexthop) renamed to ospf_spf_add_parent.
848 Simplified to just create vertex_parent and add it.
849 (ospf_spf_flush_parents) new function, flush out the parent
850 list.
851 (ospf_nexthop_calculation) Take the relevant route_lsa_link
852 as an argument, which simplifies things and removes the need
853 for the hack in ospf_nexthop_add_unique - ospf_spf_next
854 already knew exactly which link the cost calculated was for.
855 Update to match struct vertex changes too.
856 (ospf_spf_next) Don't create a vertex for W unnecessarily, if
857 it's there's a vertex already created for W, use it, and
858 hence there's no need to free it either.
859 Update some manipulation/comparisons of distance to match.
860 Flush the parent list if a lower cost path is found.
861 (ospf_spf_route_free) unused, removed.
862 (ospf_spf_dump) match the struct vertex changes, and dump the
863 ifname if possible.
864 (ospf_spf_calculate) At end of SPF, free the canonical nexthops
865 and call ospf_vertex_free on the root vertex to free the
866 entire tree.
867 * ospf_interface.c: (ospf_vl_set_params) match struct vertex
868 changes.
869 * ospf_route.c: (ospf_intra_route_add) ditto
870 (ospf_route_copy_nexthops_from_vertex) ditto
871
paul36238142005-10-11 04:12:54 +00008722005-10-11 Paul Jakma <paul.jakma@sun.com>
873
874 * ospf_api.c: sign warnings.
875 * ospf_apiserver.c: sign warning and convert all the struct
876 in_addr initialisations so as not to make assumptions about
877 how this struct is organised, initialise the s_addr member
878 explicitely.
879 * ospf_packet.c: Add const qualifier to auth_key.
880
vincent77df1f72005-10-06 07:46:22 +00008812005-10-06 Alain Ritoux <alain.ritoux@6wind.com>
882
883 * ospf_snmp.c: Avoid mixing interface and ospf_interface objects
884 which now allows snmpwalk to work with ospfIfTable and
885 also with ospfIfMetricTable
886
ajsf52d13c2005-10-01 17:38:06 +00008872005-10-01 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
888
889 * ospf_dump.c: Remove local hard-coded table ospf_redistributed_proto.
890 (ospf_redist_string) New function implemented using new library
891 function zebra_route_string(). Note that there are a few differences
892 in the output that will result: the new function returns strings
893 that are lower-case, whereas the old table was mixed case. Also,
894 the old table mapped ZEBRA_ROUTE_OSPF6 to "OSPFv3", whereas the
895 new function returns "ospf6".
896 * ospfd.h: Remove extern struct message ospf_redistributed_proto[],
897 and add extern const char *ospf_redist_string(u_int route_type)
898 instead.
899 * ospf_asbr.c: (ospf_external_info_add) In two messages, use
900 ospf_redist_string instead of LOOKUP(ospf_redistributed_proto).
901 * ospf_vty.c: Remove local hard-coded table distribute_str.
902 (config_write_ospf_redistribute,config_write_ospf_distribute): Use
903 new library function zebra_route_string() instead of distribute_str[].
904 * ospf_zebra.c: (ospf_redistribute_set,ospf_redistribute_unset,
905 ospf_redistribute_default_set,ospf_redistribute_check)
906 In debug messages, use ospf_redist_string() instead of
907 LOOKUP(ospf_redistributed_proto).
908
jardin6638c1a2005-10-01 00:08:54 +00009092005-09-30 Vincent Jardin <vincent.jardin@6wind.com>
910
911 * ospf_dump.c, ospf_ia.c, ospf_spf.c, ospf_ase.c:
912 remove unused DEBUG
913
vincentba682532005-09-29 13:52:57 +00009142005-09-29 Alain Ritoux <alain.ritoux@6wind.com>
915
vincent5e4914c2005-09-29 16:34:30 +0000916 * ospf_ism.c: generate SNMP traps on Interface state change
917 * ospf_nsm.c: generate SNMP traps on Neighbour state change
918 * ospf_snmp.[ch]: support for SNMP traps for interface and neighbours.
919
9202005-09-29 Alain Ritoux <alain.ritoux@6wind.com>
921
vincentba682532005-09-29 13:52:57 +0000922 * ospf_vty.c: forece default route LSA to be re_issued whenever
923 cost is changed ( [no] ip ospf area XXX default-cost YYY)
924 Support ignore-mtu option
925 * ospfd.h: define OSPF_MTU_IGNORE_DEFAULT
926 * ospf_packet.c: support ignore-mtu option
927 * ospf_interface.h: field added for skipping MTU check
928 * ospf_interface.c: fix memory leak in ospf_crypt_key_delete()
929 Set mtu_ignore field to default value
930 * ospf_abr.[ch]: export ospf_abr_announce_network_to_area()
931 * ospf_ism.h: add MACRO to convert internal ISM status into SNMP
932 correct values
933 * ospf_snmp.c: add sanity check on LSA type in lsdb_lookup_next()
934 convert OSPFIFSTATE internal status into SNMP values
935
vincentc1a03d42005-09-28 15:47:44 +00009362005-09-28 Alain Ritoux <alain.ritoux@6wind.com>
937
938 * ospf_packet.c: use new md5 API
939
ajs5339cfd2005-09-19 13:28:05 +00009402005-09-19 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
941
942 * ospf_lsa.h: (ospf_external_lsa_flush) Comment out the 5th argument
943 (nexthop) since it is not used in the function (except inside
944 some commented-out code).
945 * ospf_lsa.c: (ospf_external_lsa_flush,ospf_external_lsa_refresh)
946 Comment out the 5th argument to ospf_external_lsa_flush.
947 * ospf_asbr.c: (ospf_redistribute_withdraw) Comment out 5th arg
948 to ospf_external_lsa_flush.
949 * ospf_vty.c: (no_ospf_default_information_originate) Eliminate 5th
950 uninitialized nexthop arg to ospf_external_lsa_flush.
951 * ospf_zebra.c: (ospf_zebra_read_ipv4) Comment out 5th arg
952 to ospf_external_lsa_flush.
953 * ospfd.c: (ospf_network_set) Comment out 5th arg
954 to ospf_external_lsa_flush.
955
ajse6a0bf92005-09-17 18:53:38 +00009562005-09-17 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
957
958 * ospf_opaque.c:
959 (ospf_opaque_lsa_refresh_schedule,ospf_opaque_lsa_flush_schedule)
960 No need to call ospf_lookup(), just use lsa0->area->ospf instead.
961
hassobb5b7552005-08-21 20:01:15 +00009622005-08-21 Hasso Tepper <hasso at quagga.net>
963
964 * ospf_vty.c: Make "show ip ospf neighbor xxx" commands work.
965 Interface should be specified by name now.
966
hasso54bedb52005-08-17 13:31:47 +00009672005-08-17 Hasso Tepper <hasso at quagga.net>
968
969 * ospf_vty.c: Check carefully if interface exists before trying to
970 print info about it.
971
hasso01018ce2005-08-05 07:40:15 +00009722005-08-05 Hasso Tepper <hasso at quagga.net>
973
974 * ospf_zebra.c: Don't assert/stop before type == ZEBRA_ROUTE_MAX if
975 dealing with routemaps. There is ospf->route_map[ZEBRA_ROUTE_MAX]
976 for default-information.
977
paulc8987752005-07-26 06:07:22 +00009782005-07-26 Paul Jakma <paul.jakma@sun.com>
979
980 * ospf_abr.c: (ospf_abr_announce_network_to_area) SET_FLAG
981 should be on lsa not old, which may be freed for one thing,
982 obviously.
983
pauld57834f2005-07-12 20:04:22 +00009842005-07-12 Paul Jakma <paul.jakma@sun.com>
985
986 * ospfd.h: add OSPF_ABR_DEFAULT for convenience, make
987 OSPF_ABR_CISCO be the default ABR type.
988 * ospfd.c: (ospf_new) initialise abr_type to OSPF_ABR_DEFAULT
989 * ospf_vty.c: (no_ospf_abr_type_cmd) add standard as a negatable
990 abr_type. default abr_type should be OSPF_ABR_DEFAULT.
991 (ospf_config_write) test whether default abr_type against
992 OSPF_ABR_DEFAULT, rather than any specific ABR_TYPE.
993
hasso8469bd72005-06-20 20:50:10 +00009942005-06-20 Hasso Tepper <hasso at quagga.net>
hassof4833e92005-06-20 20:42:26 +0000995
996 * ospf_nsm.c: Make database exchange for NSSA database work.
997
paul7461d452005-06-13 13:57:16 +00009982005-06-13 Paul Jakma <paul.jakma@sun.com>
999
1000 * ospf_spf.c: Try get more information on a SEGV under
1001 ospf_spf_vertex_add_parent.
1002 (ospf_vertex_free) NULL out the child and nexthop lists
1003 (ospf_vertex_add_parent) nexthop and child can not be NULL
1004 vertex_nexthop's parent->child list can not be NULL
1005 (ospf_spf_next) w and cw are per-loop iteration variables, move
1006 declarations into loop body.
1007
hasso1ddd7292005-06-07 19:54:04 +000010082005-06-07 Hasso Tepper <hasso at quagga.net>
1009
1010 * ospf_apiserver.c: Fix obvious error in notifying clients about ISM
1011 changes - oi->ifp->status doesn't give to us info about ISM,
1012 oi->state does.
1013
paul7e440862005-06-01 11:20:51 +000010142005-06-01 Akihiro Mizutani <mizutani@net-chef.net>
1015
1016 * ospf_ism.c (ospf_elect_bdr/ospf_elect_dr): Fix DR election bug.
1017
paul500e4182005-05-26 17:11:13 +000010182005-05-26 Paul Jakma <paul.jakma@sun.com>
1019
1020 * ospf_abr.c: (ospf_abr_update_aggregate) Fix comment, cost bug itself
1021 had been fixed long ago by Sowmini.
1022
paula3387a42005-05-18 23:29:57 +000010232005-05-19 Paul Jakma <paul.jakma@sun.com>
1024
1025 * ospf_interface.c: (ospf_if_table_lookup) Fix a serious bug
1026 a less serious one.
1027 1: this function is supposed to lookup
1028 entries in the oifs ospf_interface route_table and return either
1029 an existing oi or NULL to indicate not found, its caller depends
1030 on this, yet this function uses route_node_get which /always/
1031 returns a route_node - one is created if none exists. Use
1032 route_node_lookup instead. This should fix root cause of the
1033 reports of the (ospf_add_to_if) assert being hit.
1034 2: oi's are inserted into this table with prefixlength set to
1035 /32 (indeed, it should be a hash table, not a route_table),
1036 however prefixlength to lookup was not changed, if no valid entry
1037 can be inserted other than /32, then nothng but /32 should be
1038 looked up. This possibly only worked by fluke..
1039 Fix confirmed by 2 reporters (one list, one IRC), definitely a
1040 backport candidate once it has been incubated in HEAD for a while.
1041 Thanks to Patrick Friedel and Ivan Warren for testing.
1042
paul69310a62005-05-11 18:09:59 +000010432005-05-11 Paul Jakma <paul.jakma@sun.com>
1044
1045 * (general) Fix memory leaks in opaque AS-scope LSAs, reported and
1046 with much debugging done by by scott collins <scollins@agile.tv>.
1047 * ospf_lsa.c: (ospf_discard_from_db) dont call
1048 ospf_ase_unregister_external_lsa for opaque-lsa's, opaques are
1049 never registered with ase in the first place.
1050 * ospf_packet.c: (general) Disabuse opaque related code of its
1051 tendency to try gather up things into temporary lists.
1052 (ospf_ls_upd) remove the temporary lists opaque uses, call
1053 opaque functions inline, just like all other types.
1054 (ospf_ls_ack) ditto.
1055 (ospf_recv_packet) fixup sign warning.
1056 * ospf_opaque.c: (general) fix the unneeded use of lists, and
1057 untwist some of the logic.
1058 (ospf_opaque_self_originated_lsa_received) take a single LSA
1059 as argument, not a list of them. Remove the list loop. Logic
1060 otherwise unchanged.
1061 (ospf_opaque_ls_ack_received) Mostly ditto. But untwist the logic,
1062 move the actions up into the switch block, remove the goto's and
1063 sanitise the logic near the end a bit.
1064 * ospf_opaque.h: Adjust definitions of aforementioned functions
1065 in ospf_opaque.c to match.
1066
paul42c98192005-05-07 02:22:51 +000010672005-05-07 Yar Tikhiy <yar@comp.chem.msu.su>
1068
1069 * ospf_network.c: Log ifindex on multicast membership leave/join
1070 events.
1071
paul4dadc292005-05-06 21:37:42 +000010722005-05-06 Paul Jakma <paul.jakma@sun.com>
1073
1074 * (general) extern and static qualifiers added.
1075 unspecified arguments in definitions fixed, typically they should
1076 be 'void'.
1077 function casts added for callbacks.
1078 Guards added to headers which lacked them.
1079 Proper headers included rather than relying on incomplete
1080 definitions.
1081 gcc noreturn function attribute where appropriate.
1082 * ospf_opaque.c: remove the private definition of ospf_lsa's
1083 ospf_lsa_refresh_delay.
1084 * ospf_lsa.h: export ospf_lsa_refresh_delay
1085 * ospf_packet.c: (ospf_make_md5_digest) make *auth_key const,
1086 correct thing to do - removes need for the casts later.
1087 * ospf_vty.c: Use vty.h's VTY_GET_INTEGER rather than ospf_vty's
1088 home-brewed versions, shuts up several warnings.
1089 * ospf_vty.h: remove VTY_GET_UINT32. VTY_GET_IPV4_ADDRESS and
1090 VTY_GET_IPV4_PREFIX moved to lib/vty.h.
1091 * ospf_zebra.c: (ospf_distribute_list_update_timer) hacky
1092 overloading of the THREAD_ARG pointer should at least use
1093 uintptr_t.
1094
paul9e67dc22005-04-15 12:10:17 +000010952005-04-15 Zhipeng Gong <zpgong@cdc.3upsystems.com>
1096
1097 * ospf_abr.c: (ospf_abr_announce_network_to_area) dont forget
1098 to approve LSAs for the case where metric has changed, lsa gets
1099 flushed otherwise. (backport candidate).
1100
ajs634f9ea2005-04-11 15:51:40 +000011012005-04-11 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1102
1103 * ospf_zebra.c (ospf_zebra_add): Call zclient_send_message instead
1104 of writen.
1105
ajsd2fc8892005-04-02 18:38:43 +000011062005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1107
ajse4319de2005-04-02 23:23:55 +00001108 * ospf_interface.h: (ospf_if_lookup_by_name) Remove declaration of a
1109 function that does not exist.
1110
11112005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1112
ajs21fefa92005-04-02 23:16:41 +00001113 * ospf_zebra.c: (zebra_interface_if_lookup) Must use
1114 if_lookup_by_name_len.
1115
11162005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1117
ajsa3491982005-04-02 22:50:38 +00001118 * ospf_interface.c: (ospf_vl_new) Use strnlen to fix call to if_create.
1119
11202005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1121
ajsd2fc8892005-04-02 18:38:43 +00001122 * ospf_vty.c: (show_ip_ospf_interface_sub) Show ifindex and interface
1123 flags to help with debugging.
1124 * ospf_zebra.c: (ospf_interface_delete) After deleting, set ifp->ifindex
1125 to IFINDEX_INTERNAL.
1126 (zebra_interface_if_lookup) Make function static. Tighten up code.
1127
ajsaca72fd2005-03-31 15:18:21 +000011282005-03-31 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1129
1130 * ospf_dump.c: (show_debugging_ospf) Show if ospf event debugging
1131 is turned on.
1132
ajsfd651fa2005-03-29 16:08:16 +000011332005-03-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1134
ajsa608bbf2005-03-29 17:03:49 +00001135 * ospf_zebra.c: (ospf_interface_state_up) If the MTU of an operative
1136 interface changes, print a debug message and call ospf_if_reset()
1137 to simulate down/up on the interface.
1138 * ospf_interface.h: Declare new function ospf_if_reset().
1139 * ospf_interface.c: (ospf_if_reset) New function to call ospf_if_down
1140 and ospf_if_up for all ospf interfaces attached to an interface.
1141
11422005-03-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1143
ajs5dcbdf82005-03-29 16:13:49 +00001144 * ospf_packet.c: (ospf_write_frags) Enhance error message to
1145 show MTU. Also make function static.
1146 (ospf_write) Enhance error message to show interface name and MTU.
1147 Also make function static.
1148
11492005-03-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1150
1151 * ospf_vty.c: (show_ip_ospf_interface_sub) Display interface MTU and
1152 bandwidth; this is useful for debugging problems. Also, the function
1153 should be static.
ajsfd651fa2005-03-29 16:08:16 +00001154
hasso1b639042005-03-27 13:32:25 +000011552005-03-27 Hasso Tepper <hasso at quagga.net>
1156
1157 * ospf_snmp.c: Don't crash in snmp query if ospf instance doesn't
1158 exist at all.
1159
hasso343f5cc2005-03-25 19:48:40 +000011602005-03-25 Hasso Tepper <hasso at quagga.net>
1161
1162 * ospfd.h: Include log.h, fixes compile with gcc-4.0.
1163
ajs9dbc7972005-03-13 19:27:22 +000011642005-03-13 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1165
1166 * ospf_lsa.c: (ospf_lsa_refresh_walker) If the system clock jumps
1167 backward, then current time may be less than
1168 ospf->lsa_refresher_started. This was causing invalid values
1169 for ospf->lsa_refresh_queue.index resulting in infinite loops.
1170 Problem fixed by casting the expression to unsigned before taking
1171 the modulus.
1172
ajs5c333492005-02-23 15:43:01 +000011732005-02-23 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1174
1175 * ospfd.h: Add new field struct stream *ibuf to struct ospf.
1176 * ospfd.c: (ospf_new) Check return code from ospf_sock_init.
1177 Allocate ibuf using stream_new(OSPF_MAX_PACKET_SIZE+1).
1178 (ospf_finish) Call stream_free(ospf->ibuf.
1179 * ospf_packet.c: (ospf_read) Call stream_reset(ospf->ibuf) and then
1180 pass it to ospf_recv_packet for use in receiving the packet
1181 (instead of allocating a new stream for each packet received).
1182 Eliminate all calls to stream_free(ibuf).
1183 (ospf_recv_packet) The struct stream *ibuf is now passed in as
1184 an argument. No need to use recvfrom to peek at the packet
1185 header (to see how big it is), just use ospf->ibuf which is
1186 always large enough (this eliminates a system call to recvfrom).
1187 Therefore, no need to allocate a stream just for this packet,
1188 and no need to free it when done.
1189
hasso462f20d2005-02-23 11:29:02 +000011902005-02-23 Vincenzo Eramo <eramo at infocom.ing.uniroma1.it>
1191
1192 * ospf_lsa.h: New flag to the LSA structure for the SPF calculation.
1193 * ospf_lsdb.h: Export ospf_lsdb_clean_stat() function.
1194 * ospf_spf.h: Add link to the LSA stat structure into vertex.
1195 * ospf_spf.c: New functions cmp() and update_stat() to manage
1196 candidates. Remove ospf_spf_has_vertex(), ospf_vertex_lookup(),
1197 ospf_install_candidate() and ospf_spf_register() functions not needed
1198 any more. Update ospf_vertex_new(), ospf_spf_next() and
1199 ospf_spf_calculate() functions to use pqueue instead of linked list.
1200
hassoe40dcce2005-02-21 14:58:42 +000012012005-02-21 Hasso Tepper <hasso at quagga.net>
1202
1203 * ospf_ase.c: Don't show messages related to the ase calculations if
1204 we are not debugging.
1205
hasso306541b2005-02-19 17:58:40 +000012062005-02-19 Hasso Tepper <hasso at quagga.net>
1207
1208 * ospf_api.h: char isn't always signed, but it has to be it here.
1209
paulfa81b712005-02-19 01:19:20 +000012102005-02-19 Paul Jakma <paul.jakma@sun.com>
1211
1212 * ospf_packet.c: (ospf_stream_copy) remove
1213 (ospf_packet_dup) use stream_copy instead of ospf_stream_copy
1214
ajs038163f2005-02-17 19:55:59 +000012152005-02-17 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1216
1217 * ospf_packet.c: (ospf_recv_packet) If there is somehow a runt
1218 packet in the queue, it must be discarded. Improve warning messages.
1219 Fix scope to static.
1220 (ospf_read) Fix bug: should reset the read thread in all cases
1221 to make sure we continue to get incoming messages.
1222
paul658b03a2005-02-15 10:10:55 +000012232005-02-15 Paul Jakma <paul.jakma@sun.com>
1224
1225 * ospf_packet.c: (ospf_recv_packet) Fix silly error wrt allocating
1226 ibuf. Thanks Andrew.
1227
paulbfdc44a2005-02-14 23:48:42 +000012282005-02-14 Paul Jakma <paul.jakma@sun.com>
1229
1230 * ospf_packet.c: (ospf_recv_packet) use stream_recvmsg.
1231
hasso082253f2005-02-11 08:31:54 +000012322005-02-11 Hasso Tepper <hasso at quagga.net>
1233
1234 * ospf_lsdb.c: Fix sum of checksums calculation.
1235
ajs083ee9d2005-02-09 15:35:50 +000012362005-02-09 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1237
1238 * ospf_packet.c: (ospf_write) If sendmsg fails, give more info in the
1239 error message.
1240
ajsba6454e2005-02-08 15:37:30 +000012412005-02-08 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1242
ajs8cfde372005-02-08 15:59:16 +00001243 * ospf_interface.h: Reduce structure padding by putting new u_char
1244 field multicast_memberships in a better spot (grouped with
1245 other u_char fields type and state).
1246
12472005-02-08 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1248
ajsba6454e2005-02-08 15:37:30 +00001249 * ospf_interface.h: Improve passive_interface comment. Add new
1250 multicast_memberships bitmask to struct ospf_interface to track
1251 active multicast subscriptions. Declare new function
1252 ospf_if_set_multicast.
1253 * ospf_interface.c: (ospf_if_set_multicast) New function to configure
1254 multicast memberships properly based on the current
1255 multicast_memberships status and the current values of the
1256 ospf_interface state, type, and passive_interface status.
1257 (ospf_if_up) Remove call to ospf_if_add_allspfrouters (this is
1258 now handled by ism_change_state's call to ospf_if_set_multicast).
1259 (ospf_if_down) Remove call to ospf_if_drop_allspfrouters (now
1260 handled by ism_change_state).
1261 * ospf_ism.c: (ospf_dr_election) Remove logic to join or leave
1262 the DRouters multicast group (now handled by ism_change_state's call
1263 to ospf_if_set_multicast).
1264 (ism_change_state) Add call to ospf_if_set_multicast to change
1265 multicast memberships as necessary to reflect the new interface state.
1266 * ospf_packet.c: (ospf_hello) When a Hello packet is received on a
1267 passive interface: 1. Increase the severity of the error message
1268 from LOG_INFO to LOG_WARNING; 2. Add more information to the error
1269 message (packet destination address and interface address);
1270 and 3. If the packet was sent to ospf-all-routers, then try
1271 to fix the multicast group memberships.
1272 (ospf_read) When a packet is received on an interface whose state
1273 is ISM_Down, enhance the warning message to show the packet
1274 destination address, and try to update/fix the multicast group
1275 memberships if the packet was sent to a multicast address.
1276 When a packet is received for ospf-designated-routers, but the
1277 current interface state is not DR or BDR, then increase the
1278 severity level of the error message from LOG_INFO to LOG_WARNING,
1279 and try to fix the multicast group memberships.
1280 * ospf_vty.c: (ospf_passive_interface) Call ospf_if_set_multicast for
1281 any ospf interface that may have changed from active to passive.
1282 (no_ospf_passive_interface) Call ospf_if_set_multicast for
1283 any ospf interface that may have changed from passive to active.
1284 (show_ip_ospf_interface_sub) Show multicast group memberships.
1285
paul3a9eb092005-02-08 11:29:41 +000012862005-02-08 Paul Jakma <paul@dishone.st>
1287
1288 * ospf_packet.c: (various) Remove unneeded stream_set_putp abuse.
1289
ajs847947f2005-02-02 18:38:48 +000012902005-02-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1291
1292 * ospf_packet.c: (ospf_read) Fix bug: must check for state ISM_Down,
1293 not for event ISM_InterfaceDown. And improve the message by
1294 adding the interface flags.
1295
ajs0b7d97d2005-01-30 17:24:02 +000012962005-01-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1297
1298 * ospf_network.c: (ospf_sock_init) Save errno before calling
1299 ospfd_privs.change.
1300
ajsc3eab872005-01-29 15:52:07 +000013012005-01-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1302
1303 * ospf_packet.c: (ospf_packet_add) If oi->obuf is NULL, print
1304 an error message and return.
1305 (ospf_read) If the interface state is ISM_InterfaceDown, issue
1306 a warning message and ignore the packet.
1307
gdt86f1fd92005-01-10 14:20:43 +000013082005-01-10 Greg Troxel <gdt@fnord.ir.bbn.com>
1309
1310 * ospf_packet.h: Remove commented out definition of
1311 OSPF_MAX_PACKET; neither it or the uncommented one are used any more.
1312
1313 * ospf_packet.c (ospf_make_ls_upd): Leave room for authentication
1314 when deciding if an update will fit.
1315 (ospf_packet_authspace): Factor out calculation of size required
1316 for authentication.
1317 (ospf_make_db_desc): Use ospf_max_packet, not OSPF_MAX_PACKET.
1318 Don't confuse readers that there is a macro.
1319
ajs3dc56b52004-12-30 15:11:19 +000013202004-12-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1321
1322 * ospf_network.c: Improve all setsockopt error messages to give detailed
1323 information on the arguments.
1324
ajsb87f7722004-12-29 20:41:26 +000013252004-12-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1326
ajs17eaa722004-12-29 21:04:48 +00001327 * ospf_packet.c: (ospf_db_desc) Reduce severity of "Negotiation done"
1328 messages from LOG_WARNING to LOG_INFO, since this seems to be
1329 normal.
1330
13312004-12-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1332
ajsb87f7722004-12-29 20:41:26 +00001333 * ospf_packet.c: (ospf_read) Always look up the interface if
1334 ospf_recv_packet returns NULL ifp, since some platforms such
1335 as Solaris 8 appear to support ifindex retrieval but don't.
1336
hasso1d806282004-12-22 09:43:20 +000013372004-12-22 Hasso Tepper <hasso at quagga.net>
1338
1339 * ospf_dump.c: Show debug configuration in vtysh.
hassoc6b87812004-12-22 13:09:59 +00001340 * ospf_vty.c: Fix "show ip ospf" output. Router can't be elected in
1341 any case if it's configured as "translate-never".
hassofe71a972004-12-22 16:16:02 +00001342 * ospf_lsdb.[ch]: New function to calculate sum of checksums.
1343 * ospf_vty.c: Bugfix to show really number of AS external LSAs, not
1344 number of all LSAs with AS scope, this includes opaque as LSAs as
1345 well, show this number separately. Show numbers and sums of
1346 checksums for each type of LSAs.
1347 * ospf_lsa.c: Calculate checksum before putting LSA into database.
hasso1d806282004-12-22 09:43:20 +00001348
ajsbc18d612004-12-15 15:07:19 +000013492004-12-15 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1350
1351 * ospf_interface.h: Declare new function ospf_default_iftype.
1352 * ospf_interface.c: (ospf_default_iftype) New function to centralize
1353 this logic in one place.
1354 * ospf_zebra.c: (ospf_interface_add) Use new function
1355 ospf_default_iftype.
1356 * ospf_vty.c: (no_ip_ospf_network,config_write_interface) Fix logic
1357 by using new function ospf_default_iftype.
1358
ajs3aa8d5f2004-12-11 18:00:06 +000013592004-12-11 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1360
1361 * ospf_packet.c: (ospf_db_desc) Should be static, not global.
1362 (ospf_hello,ospf_db_desc,ospf_ls_upd,ospf_ls_ack) Improve warning
1363 messages to include identifying information (e.g. router id).
1364 * ospf_nsm.c: (nsm_change_state) Improve info message to include
1365 router id and state names.
1366
gdt91f3e522004-12-09 14:51:03 +000013672004-12-09 Greg Troxel <gdt@fnord.ir.bbn.com>
1368
gdt3fb9de72004-12-09 16:30:04 +00001369 * ospf_apiserver.c (ospf_apiserver_term): Obtain struct
1370 ospf_apiserver * from listnode. Remove unused variables. Follows
1371 suggestion from Jay Fenlason.
gdt91f3e522004-12-09 14:51:03 +00001372
ajs9b0e25c2004-12-08 19:06:51 +000013732004-12-08 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1374
1375 * *.c: Change level of debug messages to LOG_DEBUG.
1376
ajs274a4a42004-12-07 15:39:31 +000013772004-12-07 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1378
1379 * ospf_main.c: (main) The 2nd argument to openzlog has been removed.
1380
ajs887c44a2004-12-03 16:36:46 +000013812004-12-03 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1382
ajs1210fa62004-12-03 16:43:24 +00001383 * ospf_packet.c: (ospf_db_desc) Reduce priority on a debug message
1384 from LOG_NOTICE to LOG_DEBUG.
1385
13862004-12-03 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1387
ajs887c44a2004-12-03 16:36:46 +00001388 * ospf_main.c: (sigint) Use zlog_notice for termination message.
1389 (main) Issue a startup announcement using zlog_notice.
1390
ajsbec595a2004-11-30 22:38:43 +000013912004-11-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1392
1393 * ospf_packet.c: (ospf_db_desc_proc) Fix spelling of packet in warning
1394 message and in comment.
1395 (ospf_db_desc) Warning message that a packet is being discarded
1396 should give the router id of the packet source. Fix spelling
1397 of packet in two warning messages.
1398 (ospf_ls_req) Warning message that a link state request is being
1399 discarded should give the router id of the neighbor that sent it.
1400
ajs5b85fac2004-11-26 19:36:42 +000014012004-11-26 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1402
1403 * ospf_main.c: Remove #include "debug.h" (was not being used, and
1404 lib/debug.h has now been deleted).
1405
hassoc0652302004-11-25 19:33:48 +000014062004-11-25 Hasso Tepper <hasso at quagga.net>
1407
1408 * ospf_main.c: Make group to run as configurable.
1409
gdt69e13252004-11-15 18:51:15 +000014102004-11-15 Greg Troxel <gdt@fnord.ir.bbn.com>
1411
1412 * ospf_packet.c (ospf_recv_packet): Assume CMSG_SPACE is present
1413 and works (lib/zebra.h provides if OS doesn't).
1414
paul788dab12004-11-15 11:48:37 +000014152004-11-15 Paul Jakma <paul@dishone.st>
1416
1417 * ospf_{apiserver,te}.c: ospf_lsa_free's should be ospf_lsa_unlock.
1418
paul05e85fa2004-11-12 10:52:19 +000014192004-11-12 Paul Jakma <paul@dishone.st>
1420
1421 * ospf_ia.c: (process_summary_lsa) Only an ABR has any reason to
1422 ignore stub area summary default. Even so it seems a strange
1423 check, add a comment to that effect.
1424
paulf3ae74c2004-11-04 20:35:31 +000014252004-11-04 Paul Jakma <paul@dishone.st>
1426
1427 * ospfd.c: (ospf_network_match_iface) revert to previous network
1428 statement match behaviour.
1429
paul62d8e962004-11-02 20:26:45 +000014302004-11-02 Paul Jakma <paul@dishone.st>
1431
1432 * ospf_packet.c: (ospf_write_frags) remove iov arg, msg already points
1433 to it. Add convenience pointer to msg->msg_iov[1], and use this,
1434 fixing the unfortunate borkenness introduced in moving of this code
1435 to a function.
1436 (ospf_write) remove iovp and fix up call to previous.
1437 (ospf_ls_upd_packet_new) cast size to long int - unfortunately
1438 glibc's size_t format modifier is not portable.
1439
paul37ccfa32004-10-31 11:24:51 +000014402004-10-31 Paul Jakma <paul@dishone.st>
1441
1442 * ospf_packet.c: (ospf_write_frags) Add debug output
1443 (ospf_write) set type early, so we can pass it to
1444 ospf_write_frags.
1445 (ospf_ls_upd_packet_new) print size in debug output when too large
1446 packet is encountered.
paul64511f32004-10-31 18:01:13 +00001447 * ospf_zebra.c: (ospf_distribute_list_update_timer) Ugly misuse of
1448 THREAD_ARG to store an integer, but it should at least use same
1449 same type to retrieve the value. Assert value is sane.
paul37ccfa32004-10-31 11:24:51 +00001450
paulac191232004-10-22 12:05:17 +000014512004-10-22 Paul Jakma <paul@dishone.st>
1452
1453 * ospf_network.c: (ospf_sock_init) call neutral setsock_ifindex()
1454 function.
1455 * ospf_packet.c: (ospf_read) manually look up ifindex
paul4ccb2c42004-10-22 22:52:33 +00001456 if system could not have returned one, eg openbsd, thanks to Rivo
1457 Nurges for highlighting problem and fix.
paul06f953f2004-10-22 17:00:38 +00001458 Change setsockopt_pktinfo to setsockopt_ifindex.
paulac191232004-10-22 12:05:17 +00001459
hasso3fb9cd62004-10-19 19:44:43 +000014602004-10-19 Andrew J. Schorr <aschorr@telemetry-investments.com>
1461
1462 * ospf_snmp.c: (ospf_snmp_if_update) Fix logic to handle PtP links
1463 with dedicated subnets properly.
1464 * ospf_lsa.c: (lsa_link_ptop_set) ditto.
1465 * ospfd.c: (ospf_network_match_iface) ditto.
1466 (ospf_network_run) ditto.
1467 * ospf_interface.c: (ospf_if_is_configured) ditto.
1468 (ospf_if_lookup_by_prefix) ditto.
1469 (ospf_if_lookup_recv_if) ditto.
1470 * ospf_vty.c: (show_ip_ospf_interface_sub) Display the peer or
1471 broadcast address if present.
1472
hassod68614d2004-10-13 09:32:48 +000014732004-10-13 Hasso Tepper <hasso at quagga.net>
1474
1475 * ospf_main.c: Unbreak compilation with ospfapi disabled.
hassoc75105a2004-10-13 10:33:26 +00001476 * ospf_snmp.c: Remove defaults used to initialize smux connection to
1477 snmpd. Connection is initialized only if smux peer is configured.
hassod68614d2004-10-13 09:32:48 +00001478
hassof4d58ce2004-10-12 06:13:54 +000014792004-10-12 Hasso Tepper <hasso at quagga.net>
1480
1481 * ospf_main.c, ospf_opaque.c: Unbreak ospfclient compilation - move
1482 static variable from ospf_main.c into ospf_opaque.c.
1483
hassoc3abdb72004-10-11 16:27:03 +000014842004-10-11 Hasso Tepper <hasso at quagga.net>
1485
1486 * ospf_main.c, ospf_opaque.c: Disable ospfapi init by default. New
1487 command line switch to enable it.
1488
paul6b333612004-10-11 10:11:25 +000014892004-10-11 Paul Jakma <paul@dishone.st>
1490
1491 * ospf_dump.c: (ospf_ip_header_dump) Assume header is in host order
1492 remove ntohs that should have dissappeared. Take struct ip
1493 as argument, caller has to know there's an IP header at start of
1494 stream anyway.
1495 * ospf_dump.h: update declaration of ospf_ip_header_dump.
1496 * ospf_packet.c: (ospf_write) correct call to
1497 sockopt_iphdrincl_swab_htosys which was munging the header.
1498 (ospf_recv_packet) ip_len is needed for old OpenBSD fixup.
1499 (ospf_read) sockopt_iphdrincl_swab_systoh ip header as soon as
1500 we have it.
paul6c835672004-10-11 11:00:30 +00001501 * (global) Const char update and signed/unsigned fixes.
1502 * (various headers) size defines should be unsigned.
1503 * ospf_interface.h: remove duplicated defines, include the
1504 authoritative header - though, these defines should probably
1505 be moved to a dedicated header, or ospfd.h.
1506 * ospf_lsa.h: (struct lsa) ls_seqnum should be unsigned.
1507 * ospf_packet.c: (ospf_write) cast result of shift to unsigned.
paul6b333612004-10-11 10:11:25 +00001508
hassoeb1ce602004-10-08 08:17:22 +000015092004-10-08 Hasso Tepper <hasso at quagga.net>
1510
1511 * *.[c|h]: Fix compiler warnings: make some strings const, signed ->
1512 unsigned, remove unused variables etc.
1513
gdt54ade992004-10-07 19:38:20 +000015142004-10-07 Greg Troxel <gdt@claude.ir.bbn.com>
1515
1516 * ospf_apiserver.c (ospf_apiserver_unregister_opaque_type): Don't
1517 use of variable names 'node' and 'nextnode' to avoid possible
1518 conflict with list macros. Move variable declaration inside for
1519 loop after a statement to top of function.
1520
paulaa20c6f2004-10-07 14:19:36 +000015212004-10-07 Paul Jakma <paul@dishone.st>
1522
1523 * ospf_snmp.c: Missed list typedef update
1524 * ospf_dump.c: Include sockopt.h for header swab functions.
1525
paul18b12c32004-10-05 14:38:29 +000015262004-10-05 Paul Jakma <paul@dishone.st>
1527
1528 * ospf_packet.c: replace ospf_swap_iph_to... with
1529 sockopt_iphdrincl_swab_...
1530
hasso18a6dce2004-10-03 18:18:34 +000015312004-10-03 James R. Leu <jleu at mindspring.com>
1532
1533 * ospf_zebra.c: Read router id related messages from zebra daemon.
1534 Schedule router-id update thread if it's changed.
1535 * ospfd.c: Remove own router-id selection function. Use router id from
1536 zebra daemon if it isn't manually overriden in configuration.
1537
paul68defd62004-09-27 07:27:13 +000015382004-09-27 Paul Jakma <paul@dishone.st>
1539
paul6a99f832004-09-27 12:56:30 +00001540 * ospf_dump.c: (ospf_ip_header_dump) Use HAVE_IP_HDRINCL_BSD_ORDER
1541 Apply to offset too. Print ip_cksum, lets not worry about
1542 possible 2.0.37 compile problems.
1543 * ospf_packet.c: (ospf_swap_iph_to{n,h}) Use
1544 HAVE_IP_HDRINCL_BSD_ORDER.
1545 (ospf_recv_packet) ditto.
1546 (ospf_write) Fixup iov argument to ospf_write_frags.
1547 (struct msghdr).msg_name is caddr_t on most platforms.
paul68defd62004-09-27 07:27:13 +00001548 (ospf_recv_packet) ditto. And msg_flags is not always there
1549 memset struct then set fields we care about rather than
1550 initialise all fields individually.
1551
hassoc9e52be2004-09-26 16:09:34 +000015522004-09-26 Hasso Tepper <hasso at quagga.net>
1553
1554 * ospf_abr.c, ospf_dump.c, ospf_lsa.c, ospf_packet.c, ospf_vty.c,
1555 ospf_zebra.c: Fix compiler warnings.
1556
paul87d6f872004-09-24 08:01:38 +000015572004-09-24 Paul Jakma <paul@dishone.st>
1558
1559 * ospf_apiserver.{c,h}: lists typedef removal cleanup.
1560 update some list loops to LIST_LOOP. some miscellaneous indent
1561 fixups.
1562 (ospf_apiserver_unregister_opaque_type) fix listnode_delete of
1563 referenced node in loop.
paul1603c062004-09-24 08:23:24 +00001564 (ospf_apiserver_term) loops calling ospf_apiserver_free, which
1565 deletes referenced nodes from apiserver_list, fixed.
paul87d6f872004-09-24 08:01:38 +00001566 * ospf_interface.h: lists typedef removal cleanup.
1567 * ospf_opaque.{c,h}: lists typedef removal cleanup. update some list
1568 loops to LIST_LOOP. miscellaneous style and indent fixups.
1569 * ospf_te.{c,h}: ditto
1570 * ospf_packet.c: lists typedef removal cleanup.
paula2570682004-09-24 08:09:57 +00001571 (ospf_write) ifdef fragmentation support. move actual
1572 fragmentation out to a new, similarly ifdefed, function.
1573 (ospf_write_frags) fragmented write support, moved from previous.
paul87d6f872004-09-24 08:01:38 +00001574
hasso52dc7ee2004-09-23 19:18:23 +000015752004-09-23 Hasso Tepper <hasso at quagga.net>
1576
1577 * *.[c|h]: list -> struct list *, listnode -> struct listnode *.
1578
paul68b73392004-09-12 14:21:37 +000015792004-09-12 Paul Jakma <paul@dishone.st>
1580
1581 * ospf_packet.c: Fix bugzilla #107
1582 (ospf_packet_max) get rid of the magic 88 constant
1583 (ospf_swab_iph_ton) new function. set ip header to network order,
1584 taking BSDisms into account.
1585 (ospf_swab_iph_toh) the inverse.
1586 (ospf_write) Add support for IP fragmentation, will only work on
1587 linux though, other kernels make it impossible. get rid of the
1588 magic 4 constant.
1589 (ospf_make_ls_upd) Bound check to end of stream, not to
1590 interface mtu.
1591 (ospf_ls_upd_packet_new) New function, allocate upd packet
1592 taking oversized LSAs into account.
1593 (ospf_ls_upd_queue_send) use ospf_ls_upd_packet_new to allocate,
1594 rather than statically allocating mtu sized packet buffer, which
1595 actually was wrong - it didnt take ip header into account, which
1596 should not be included in packet buffer.
1597 (ospf_ls_upd_send_queue_event) minor tweaks and remove
1598 TODO comment.
1599
gdt630e4802004-08-31 17:28:41 +000016002004-08-31 David Wiggins <dwiggins@bbn.com>
1601
1602 * ospf_spf.c (ospf_spf_calculate): Many more comments and debug
1603 print statements. New function ospf_vertex_dump used in debugging.
1604
16052004-08-31 David Wiggins <dwiggins@bbn.com>
1606
1607 * ospf_spf.h (struct vertex): Comments for flags and structure members.
1608
16092004-08-31 David Wiggins <dwiggins@bbn.com>
1610
1611 * ospf_route.c: When finding an alternate route, log cost as well.
1612
16132004-08-31 David Wiggins <dwiggins@bbn.com>
1614
1615 * ospf_interface.c (ospf_lookup_if_params): Initialize af in
1616 struct prefix allocated on stack.
1617
16182004-08-31 David Wiggins <dwiggins@bbn.com>
1619
1620 * ospf_packet.c (ospf_ls_ack_send_delayed): In p2mp mode, send
1621 acks to AllSPFRouters, rather than All-DR.
1622
hasso7b901432004-08-31 13:37:42 +000016232004-08-27 Hasso Tepper <hasso at quagga.net>
1624
1625 * ospf_vty.c: Don't print ospf network type under interface only
1626 if interface is in broadcast mode and interface type really is
1627 broadcast. Fixes Bugzilla #108.
1628
gdtd7d93992004-08-27 12:03:42 +000016292004-08-27 David Wiggins <dwiggins@bbn.com>
1630
1631 * ospf_spf.c (ospf_nexthop_calculation): Initialize address family
1632 in on-stack struct prefix_ipv4. Fixes point-to-multipoint SPF
1633 calculation.
1634
gdtd0deca62004-08-26 13:14:07 +000016352004-08-26 Greg Troxel <gdt@fnord.ir.bbn.com>
1636
1637 * ospf_packet.c (ospf_recv_packet): adjust size declaration of
gdtd7d93992004-08-27 12:03:42 +00001638 buffer used to get interface index so that it compiles on other
1639 than Linux and includes the required alignment space. Probably
1640 this was only working on sparc/sparc64 because most of
1641 sockaddr_dl was not being written.
gdtd0deca62004-08-26 13:14:07 +00001642
paul863082d2004-08-19 04:43:43 +000016432004-08-19 Paul Jakma <paul@dishone.st>
1644
1645 * ospf_packet.c: update to match sockopt renames.
1646
paul75ee0b82004-08-05 09:10:31 +000016472004-08-04 Paul Jakma <paul@dishone.st>
1648
1649 * ospf_spf.c: (ospf_spf_consider_nexthop) Add comment about issue.
1650 Compare only against list head - all nexthops must be same cost
1651 anyway, fixes a reference-listnode-after-delete bug noted by
1652 Kir Kostuchenko.
1653 (ospf_nexthop_calculation) Use ospf_spf_consider_nexthop for all
1654 candidates attached to root.
1655
paul36c64ef2004-07-27 11:19:11 +000016562004-07-27 Paul Jakma <paul@dishone.st>
1657
paul48fe13b2004-07-27 17:40:44 +00001658 * ospf_packet.c: (ospf_ls_upd_send_queue_event) fix thinko from
1659 last fix for ospfd wedging due to oversize LSAs: dont list loop on
1660 ospf_ls_upd_queue_send() - guaranteed segfault.
1661
16622004-07-27 Paul Jakma <paul@dishone.st>
1663
paul36c64ef2004-07-27 11:19:11 +00001664 * ospf_opaque.c: (ospf_opaque_lsa_flush_schedule) do not NULL out
1665 the LSA as then free_opaque_info_per_id() can never unlock (and
1666 free) the LSA. Reported by Gunnar Stigen.
1667
paul2dd8bb42004-07-23 15:13:48 +000016682004-07-23 Paul Jakma <paul@dishone.st>
1669
1670 * ospf_network.c: Replace PKTINFO/RECVIF with call to
1671 setsockopt_pktinfo
1672 * ospf_packet.c: Use getsockopt_pktinfo_ifindex and
1673 SOPT_SIZE_CMSG_PKTINFO_IPV4.
1674
paul59ea14c2004-07-14 20:50:36 +000016752004-07-14 Paul Jakma <paul@dishone.st>
1676
1677 * ospf_packet.c: (ospf_ls_upd_send_queue_event) Partial fix for
1678 problem reported by Peter Frost amongst others, where function
1679 will spin indefinitely if update list contains LSAs greater than
1680 MTU-headers or other condition leading to update list never being
1681 cleared. Problem of what to do with these LSAs remains.
1682 (ospf_make_ls_upd) add comment about large LSA problem,
1683 indentation cleanup.
1684
gdtb2c1b282004-07-01 12:35:36 +000016852004-07-01 Greg Troxel <gdt@fnord.ir.bbn.com>
1686
1687 * Makefile.am (lib_LTLIBRARIES): make libospf shared
1688
gdt87efd642004-06-30 17:36:11 +000016892004-06-30 Greg Troxel <gdt@poblano.ir.bbn.com>
1690
1691 * Makefile.am: Add shlib support.
1692
hassobeebba72004-06-20 21:00:27 +000016932004-06-10 Hasso Tepper <hasso@estpak.ee>
1694
1695 * *: Removed ifdefs HAVE_NSSA.
1696
paul553ff112004-06-06 09:41:00 +000016972004-06-06 Paul Jakma <paul@dishone.st>
1698
1699 * ospf_dump.c,ospf_lsa.c: Fix typos of merge of previous.
1700 ospf_flood.c: (ospf_process_self_originated_lsa) fix zlog format
1701
paul0c2be262004-05-31 14:16:54 +000017022004-05-31 Sagun Shakya <sagun.shakya@sun.com>
1703
1704 * ospf_dump.c: (ospf_lsa_header_dump) LOOKUP can return null if
1705 index is out of range.
1706 ospf_flood.c: endianness fix
1707 ospf_lsa.c: Missing ntohl's on (struct lsa *)->data->ls_seqnum
1708 in various places.
1709
hassodd669bb2004-05-10 07:43:59 +000017102004-05-10 Hasso Tepper <hasso@estpak.ee>
1711
1712 * ospf_zebra.c, ospfd.c: Move ospf_prefix_list_update() function
1713 to ospf_zebra.c from ospfd.c and add redistribution updates if
1714 route-map is used in redistribution.
1715 * ospf_main.c: Remove now useless call to ospf_init().
1716
paul0a589352004-05-08 11:48:26 +000017172004-05-08 Paul Jakma <paul@dishone.st>
1718
1719 * ospf_zebra.c: Sync with lib/zclient changes
1720
pauld3f0d622004-05-05 15:27:15 +000017212004-05-05 Paul Jakma <paul@dishone.st>
1722
paul5bd41892004-05-05 17:29:24 +00001723 * ospf_network.c: (ospf_sock_init) Check whether IP_HDRINCL is
1724 defined. Warn at compile and runtime. Use
1725 IPTOS_PREC_INTERNETCONTROL otherwise.
pauld3f0d622004-05-05 15:27:15 +00001726 * ospf_packet.c: (ospf_associate_packet_vl) cleanup, move
1727 some of the checks up to ospf_read, return either a
1728 virtual link oi, or NULL.
1729 (ospf_read) Cleanup, make it responsible for checks. Remove
1730 the nbr lookup - moved to ospf_neighbor. Adjust all nbr
1731 lookups to use new wrappers exported by ospf_neighbor.
1732 * ospf_neighbor.h: Add ospf_neigbour_get and ospf_nbr_lookup.
1733 * ospf_neighbor.c: (ospf_neigbour_get) Index ospf_interface
1734 neighbour table by router-id for virtual-link ospf_interfaces,
1735 not by peer_addr (which breaks for asymmetric vlinks)
1736 (ospf_nbr_lookup) add a wrapper for nbr lookups to deal with
1737 above.
paulcd59da62004-05-05 17:26:55 +00001738 * ospf_interface.c: (ospf_vl_set_params) Catch changes of interface
1739 address for either end of a virtual-link, and hence potential cost
1740 changes.
1741
hassoa0a39762004-04-23 08:51:10 +000017422004-04-22 Hasso Tepper <hasso@estpak.ee>
1743
1744 * ospf_zebra.c: Don't ignore reject/bh routes, it's the only way
1745 to "summarize" routes in ASBR at the moment.
1746
hasso8585d4e2004-04-20 17:25:12 +000017472004-04-20 Hasso Tepper <hasso@estpak.ee>
1748
1749 * ospfd.c: Unset NP flag if area is going to be normal or stub.
1750 Fixes UNH OSPF_NSSA.1.2a comment.
1751 * ospf_abr.c: Originate default into stub/nssa area even if
1752 summaries are disabled.
1753 * ospf_zebra.c: Don't attempt to redistribute 127.0.0.0/8.
1754
hassoc266ac72004-04-19 17:31:00 +000017552004-04-19 Hasso Tepper <hasso@estpak.ee>
1756
1757 * ospf_vty.c: Don't warn that export- and import-list can't be
1758 configured to backbone area if they are applied and are working
1759 fine.
1760
hasso128d31d2004-04-04 12:52:33 +000017612004-02-19 Sowmini Varadhan <sowmini.varadhan@sun.com>
1762
1763 * ospf_packet.c: Don't drop packets in Solaris x86.
1764 [quagga-dev 1005].
1765
hasso0d85b992004-03-18 19:18:33 +000017662004-03-18 Amir Guindehi <amir@datacore.ch>
1767
1768 * ospf_opaque.c: Attempt to correct the incorrect behavior of
1769 Quagga's ospfd in the special situation that a node's opaque
1770 capability has changed as "ON -> OFF -> ON". [quagga-dev 843].
1771
paul7f352b82004-02-19 19:37:47 +000017722004-02-19 Sowmini Varadhan <sowmini.varadhan@sun.com>
1773
1774 * ospf_abr.c: (ospf_abr_update_aggregate) UNH 3.12b,c, address range
1775 should be configured with the highest cost path within the range,
1776 not lowest.
1777
paul940b01a2004-02-17 20:07:30 +000017782004-02-17 Paul Jakma <paul@dishone.st>
1779
1780 * ospf_zebra.c: (ospf_interface_delete) Do not delete the interface
1781 params, nor the interface structure, if an interface delete
1782 message is received from zebra.
1783 * ospf_interface.c: (ospf_if_delete_hook) Delete the interface
1784 params and interface, ie that which was previously removed in
1785 (ospf_interface_delete) above.
1786
hasso2db3d052004-02-11 21:52:13 +000017872004-02-11 Hasso Tepper <hasso@estpak.ee>
1788 * ospf_interface.c, ospf_zebra.c: Don't attempt to read path->oi->ifp
1789 if oi doesn't exist any more.
1790
hassocb05eb22004-02-11 21:10:19 +000017912004-02-11 Vadim Suraev <vadim.suraev@terayon.com>
1792 * ospf_packet.c (ospf_ls_upd): Router should flush received network
1793 LSA if it was originated with older router-id ([zebra 14710] #6).
1794
17952003-12-08 Mattias Amnefelt <mattiasa@kth.se>
paul239aecc2003-12-08 10:34:54 +00001796
1797 * ospf_packet.c: (ospf_recv_packet) OpenBSD now leaves iph.ip_len
1798 network byte order.
1799
gdt8f40e892003-12-05 14:01:43 +000018002003-12-05 Greg Troxel <gdt@poblano.ir.bbn.com>
1801
1802 * ospfd.c (ospf_network_match_iface): Rewrite code for clarity
1803 while trying not to change semantics. Add ifdefed-out code to
1804 avoid matching ppp interfaces whose destination address does not
1805 also match the prefix under consideration, to help out people with
1806 problems due to as-yet-unfixed bugs with p2p interfaces coming and
1807 going.
1808
paul736d3442003-07-24 23:22:57 +000018092003-07-25 kamatchi soundaram <kamatchi@tdd.sj.nec.com>
1810
1811 * ospf_packet.c (ospf_ls_upd_send_queue_event): get next route
1812 node in body of the loop to avoid chance that route node
1813 is unlocked and deleted before the next iteration tries to
1814 get next route node.
1815
paul0a825c72003-05-24 13:48:16 +000018162003-05-24 Kenji Yabuuchi
1817
1818 * ospf_interface.c(ospf_if_lookup_recv_if): Use the most specific
1819 match for interface lookup.
1820
paul551a8972003-05-18 15:22:55 +000018212003-05-18 Hasso Tepper <hasso@estpak.ee>
paul445f1432003-05-16 19:00:31 +00001822
paul551a8972003-05-18 15:22:55 +00001823 * ospf_vty.c: Show NSSA LSA route info in "show ip ospf database"
1824 output
paul445f1432003-05-16 19:00:31 +00001825
pauld7480322003-05-16 17:31:51 +000018262003-05-16 Hasso Tepper <hasso@estpak.ee>
1827
1828 * ospf_lsa.c: Fix handling of NSSA
1829
paul551a8972003-05-18 15:22:55 +000018302003-04-23 Hasso Tepper <hasso@estpak.ee>
1831
1832 * ospf_vty.c: fix "router xxx" node commands in vtysh
1833
paul445f1432003-05-16 19:00:31 +000018342003-04-19 Hasso Tepper <hasso@estpak.ee>
1835
1836 * {ospf_abr,ospfd}.c: area id's DECIMAL -> ADDRESS
1837 * ospf_routemap.c: sync daemon's route-map commands to have same
1838 syntax.
1839
18402003-04-19 Sergey Vyshnevetskiy <serg@vostok.net>
1841
1842 * ospf_packet.c: Add missing param to zlog
1843 * ospf_flood.c: remove unused vars
1844
18452003-04-17 Denis Ovsienko <zebra@pilot.org.ua>
1846
1847 * ospf_interface.c: fix incorrect memset
1848
paul28a13842003-05-16 20:30:37 +000018492003-04-10 Amir Guindehi <amir@datacore.ch>
paul445f1432003-05-16 19:00:31 +00001850
1851 * ospf_lsa.[ch]: opaque LSA fix, use ospf_lookup.
1852
18532003-04-03 David Watson <dwatson@eecs.umich.edu>
1854
1855 * ospf_lsa.c: byte order fix
1856
paul07661cb2003-03-18 00:03:05 +000018572002-03-17 Amir Guindehi <amir@datacore.ch>
1858
1859 * ospf_apiserver.[ch]: Merge Ralph Keller's OSPFAPI support.
1860 * ospf_api.[ch]: Merge Ralph Keller's OSPFAPI support.
1861 * ospfclient: OSPFAPI demonstration client.
1862
18632003-01-23 Masahiko Endo <endo@suri.co.jp>
1864
1865 * ospf_ism.c: NSM event schedule bug fix.
1866
18672002-10-30 Greg Troxel <gdt@ir.bbn.com>
1868
1869 * ospf_packet.c (ospf_make_md5_digest): MD5 length fix.
1870
paul718e3742002-12-13 20:15:29 +000018712002-10-23 endo@suri.co.jp (Masahiko Endo)
1872
1873 * ospf_opaque.c: Update Opaque LSA patch.
1874
18752002-10-23 Ralph Keller <keller@tik.ee.ethz.ch>
1876
1877 * ospf_vty.c (show_ip_ospf_database): Fix CLI parse.
1878
18792002-10-23 Juris Kalnins <juris@mt.lv>
1880
1881 * ospf_interface.c (ospf_if_stream_unset): When write queue
1882 becomes empty stop write timer.
1883
18842002-10-10 Greg Troxel <gdt@ir.bbn.com>
1885
1886 * ospf_packet.c (ospf_check_md5_digest): Change >= to > to make it
1887 conform to RFC.
1888
18892002-07-07 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1890
1891 * zebra-0.93 released.
1892
18932002-06-19 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1894
1895 * ospf_spf.c (ospf_nexthop_calculation): Add NULL set to oi and
1896 check of l2. Reported by: Daniel Drown <dan-zebra@drown.org>
1897 (ospf_lsa_has_link): LSA Length calculation fix. Reported by:
1898 Paul Jakma <paulj@alphyra.ie>.
1899
1900 * ospfd.c (ospf_if_update): Fix nextnode reference bug. Reported
1901 by: juris@mt.lv.
1902
19032002-01-21 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1904
1905 * ospfd.c: Merge [zebra 11445] Masahiko ENDO's Opaque-LSA support.
1906
19072001-08-27 Kunihiro Ishiguro <kunihiro@zebra.org>
1908
1909 * ospf_interface.c (ospf_add_to_if): Use /32 address to register
1910 OSPF interface information.
1911 (ospf_delete_from_if): Likewise.
1912
1913 * ospf_zebra.c (ospf_interface_address_delete): Likewise.
1914
19152001-08-23 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1916
1917 * ospf_zebra.c (ospf_redistribute_unset): When redistribute type
1918 is OSPF, do not unset redistribute flag.
1919
19202001-08-19 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1921
1922 * zebra-0.92a released.
1923
19242001-08-15 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1925
1926 * zebra-0.92 released.
1927
19282001-08-12 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1929
1930 * ospfd.c (ospf_config_write): auto-cost reference-bandwidth
1931 configuration display.
1932
19332001-07-24 David Watson <dwatson@eecs.umich.edu>
1934
1935 * ospf_spf.c (ospf_spf_next): Modify ospf_vertex_add_parent to
1936 check for an existing link before connecting the parent and child.
1937 ospf_nexthop_calculation is also modified to check for duplicate
1938 entries when copying from the parent. Finally, ospf_spf_next
1939 removes duplicates when it merges two equal cost candidates.
1940
19412001-07-23 itojun@iijlab.net
1942
1943 * ospfd.c (show_ip_ospf_neighbor): Check ospf_top before use it
1944 [zebra 8549].
1945
19462001-07-23 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1947
1948 * ospf_packet.c (ospf_write): Remove defined(__OpenBSD__) to make
1949 it work on OpenBSD.
1950
19512001-06-26 Kunihiro Ishiguro <kunihiro@zebra.org>
1952
1953 * ospf_zebra.c (config_write_ospf_default_metric): Display
1954 default-metric configuration.
1955
19562001-06-18 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1957
1958 * ospf_ia.h (OSPF_EXAMINE_SUMMARIES_ALL): Remove old macros.
1959
19602001-05-28 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1961
1962 * ospf_snmp.c (ospfIfEntry): Fix interface lookup bug to avoid
1963 crush.
1964 (ospfIfMetricEntry): Likewise.
1965
19662001-03-18 Kunihiro Ishiguro <kunihiro@zebra.org>
1967
1968 * ospf_packet.c (ospf_read): Fix typo. Reported by: "Jen B
1969 Lin'Kova" <jen@stack.net>.
1970
19712001-03-15 Gleb Natapov <gleb@nbase.co.il>
1972
1973 * ospf_interface.c (ip_ospf_network): Set interface parameter.
1974 (interface_config_write): Add check for OSPF_IFTYPE_LOOPBACK.
1975
1976 * ospf_zebra.c (ospf_interface_add): Set interface parameter.
1977
19782001-02-21 Kunihiro Ishiguro <kunihiro@zebra.org>
1979
1980 * ospf_packet.c (ospf_recv_packet): Solaris also need to add
1981 (iph.ip_hl << 2) to iph.ip_len.
1982
19832001-02-09 Kunihiro Ishiguro <kunihiro@zebra.org>
1984
1985 * ospfd.h (OSPF_LS_REFRESH_TIME): Fix OSPF_LS_REFRESH_TIME value.
1986 Suggested by: David Watson <dwatson@eecs.umich.edu>.
1987
1988 * ospf_zebra.c (zebra_init): Remove zebra node.
1989
1990 * ospfd.c (ospf_area_range_set): Function name is changed from
1991 ospf_ara_range_cmd.
1992 (ospf_area_range_unset): New function which separated from DEFUN.
1993 New commands are added:
1994 "no area A.B.C.D range A.B.C.D/M advertise"
1995 "no area <0-4294967295> range A.B.C.D/M advertise"
1996 "no area A.B.C.D range A.B.C.D/M not-advertise"
1997 "no area <0-4294967295> range A.B.C.D/M not-advertise"
1998
1999 * ospf_lsa.c (ospf_lsa_more_recent): Fix previous change.
2000
20012001-02-08 Matthew Grant <grantma@anathoth.gen.nz>
2002
2003 * ospf_network.c (ospf_if_add_allspfrouters): Use
2004 setsockopt_multicast_ipv4.
2005 (ospf_if_drop_allspfrouters): Likewise.
2006
2007 * ospf_lsa.c (ospf_router_lsa_install): Add rt_recalc flag.
2008 (ospf_network_lsa_install): Likewise.
2009 (ospf_summary_lsa_install): Likewise.
2010 (ospf_summary_asbr_lsa_install): Likewise.
2011 (ospf_external_lsa_install): Likewise.
2012 (ospf_lsa_install): Call ospf_lsa_different to check this LSA is
2013 new one or not.
2014
20152001-02-08 Kunihiro Ishiguro <kunihiro@zebra.org>
2016
2017 * ospf_zebra.c (ospf_interface_delete): Do not free interface
2018 structure when ospfd receive interface delete message to support
2019 pseudo interface.
2020
20212001-02-01 Dick Glasspool <dick@ipinfusion.com>
2022
2023 * ospfd.c (area_range_notadvertise): Change area range "suppress"
2024 command to "not-advertise".
2025
2026 * ospfd.h (OSPF_LS_REFRESH_TIME): Change OSPF_LS_REFRESH_TIME from
2027 1800 to 60.
2028
2029 * ospf_abr.c (ospf_abr_update_aggregate): When update_aggregate is
2030 updating the area-range, the lowest cost is now saved.
2031
2032 * ospf_lsa.c (ospf_lsa_more_recent): Routing to compare sequence
2033 numbers rather than creating overflow during calculation.
2034
20352001-02-01 Kunihiro Ishiguro <kunihiro@zebra.org>
2036
2037 * zebra-0.91 is released.
2038
20392001-01-31 Kunihiro Ishiguro <kunihiro@zebra.org>
2040
2041 * ospf_packet.c (ospf_db_desc_proc): Do not continue process when
2042 NSM_SeqNumberMismatch is scheduled.
2043 (ospf_ls_req): Free ls_upd when return from this function.
2044 (ospf_ls_upd_timer): When update list is empty do not call
2045 ospf_ls_upd_send(). Suggested by: endo@suri.co.jp (Masahiko
2046 Endo).
2047
20482001-01-26 Kunihiro Ishiguro <kunihiro@zebra.org>
2049
2050 * ospf_lsa.c (ospf_maxage_flood): Flood LSA when it reaches
2051 MaxAge. RFC2328 Section 14.
2052 (ospf_maxage_lsa_remover): Call above function during removing
2053 MaxAge LSA.
2054
20552001-01-26 Dick Glasspool <dick@ipinfusion.com>
2056
2057 * ospf_flood.c (ospf_flood_through_as): Function is updated for
2058 NSSA Translations now done at ospf_abr.c with no change in P-bit.
2059
2060 * ospf_lsa.c (ospf_get_nssa_ip): Get 1st IP connection for Forward
2061 Addr.
2062 (ospf_install_flood_nssa): Leave Type-7 LSA at Lock Count = 2.
2063
2064 * ospf_ase.c (ospf_ase_calculate_route): Add debug codes.
2065
2066 * ospf_abr.c (ospf_abr_translate_nssa): Recalculate LSA checksum.
2067
2068 * ospf_packet.h (OSPF_SEND_PACKET_LOOP): Added for test packet.
2069
2070 * ospf_dump.c (ospf_lsa_type_msg): Add OSPF_GROUP_MEMBER_LSA and
2071 OSPF_AS_NSSA_LSA.
2072
2073 * ospfd.c (data_injection): Function to inject LSA. This is
2074 debugging command.
2075
20762001-01-11 Kunihiro Ishiguro <kunihiro@zebra.org>
2077
2078 * ospf_route.c (ospf_route_match_same): Remove function.
2079 (ospf_route_match_same_new): Renamed to ospf_route_match_same.
2080
2081 * ospf_zebra.c (ospf_interface_address_delete): Add check for
2082 oi->address. Suggested by Matthew Grant
2083 <grantma@anathoth.gen.nz>.
2084 (ospf_zebra_add): Remove function.
2085 (ospf_zebra_add_multipath): Rename to ospf_zebra_add.
2086
2087 * ospf_interface.c: Remove HAVE_IF_PSEUDO part.
2088
2089 * ospf_zebra.c: Likewise.
2090
20912001-01-10 Kunihiro Ishiguro <kunihiro@zebra.org>
2092
2093 * ospf_ase.c: Remove OLD_RIB part.
2094
2095 * ospf_route.c: Likewise.
2096
2097 * zebra-0.90 is released.
2098
2099 * ospf_packet.c (ospf_recv_packet): Use ip_len adjestment code to
2100 NetBSD.
2101
21022001-01-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2103
2104 * ospf_route.c (ospf_route_delete): Use
2105 ospf_zebra_delete_multipath.
2106
21072001-01-09 Matthew Grant <grantma@anathoth.gen.nz>
2108
2109 * ospf_interface.c (ospf_if_cleanup): Function name is renamed
2110 from ospf_if_free(). Rewrite whole procudure to support primary
2111 address deletion.
2112
2113 * ospf_zebra.c (ospf_interface_address_delete): Add primary
2114 address deletion process.
2115
21162001-01-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2117
2118 * ospf_packet.c (ospf_recv_packet): OpenBSD has same ip_len
2119 treatment like FreeBSD.
2120
21212001-01-09 endo@suri.co.jp (Masahiko Endo)
2122
2123 * ospf_packet.c (ospf_recv_packet): FreeBSD kernel network code
2124 strips IP header size from receiving IP Packet. So we adjust
2125 ip_len to whole IP packet size by adding IP header size.
2126
21272001-01-08 endo@suri.co.jp (Masahiko Endo)
2128
2129 * ospf_network.c (ospf_serv_sock): When socket() is failed return
2130 immediately.
2131 (ospf_serv_sock): Close socket when it is not used.
2132
2133 * ospf_packet.c (ospf_write): Set sin_len when HAVE_SIN_LEN is
2134 defined.
2135 (ospf_write): When bind is fined, close sock.
2136
21372001-01-07 Gleb Natapov <gleb@nbase.co.il>
2138
2139 * ospf_zebra.c (ospf_interface_state_up): Fixes coredump that
2140 appears when you try to configure bandwidth on the ppp interface
2141 that is not yet configured in ospfd.
2142
21432001-01-07 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2144
2145 * ospf_route.c (show_ip_ospf_route_external): "show ip ospf route"
2146 will print nexthops for AS-external routes.
2147
2148 * ospf_ase.c (ospf_ase_route_match_same): New function to compare
2149 ASE route under multipath environment.
2150 (ospf_ase_compare_tables): Likewise.
2151
21522001-01-01 Kunihiro Ishiguro <kunihiro@zebra.org>
2153
2154 * ospfd.h (OSPF_VTYSH_PATH): Change "/tmp/ospfd" to "/tmp/.ospfd".
2155
21562000-12-28 Kunihiro Ishiguro <kunihiro@zebra.org>
2157
2158 * ospf_route.c (ospf_route_install): Install multipath information
2159 to zebra daemon.
2160
2161 * ospf_zebra.c (ospf_zebra_add_multipath): Function for passing
2162 multipath information to zebra daemon.
2163
21642000-12-25 Dick Glasspool <dick@ipinfusion.com>
2165
2166 * ospf_packet.c (ospf_write): Call ospf_packet_delete when sendto
2167 fail.
2168 (DISCARD_LSA): Add argument N for logging point of DISCARD_LSA is
2169 called.
2170
2171 * ospf_lsa.c (ospf_external_lsa_refresh): NSSA install_flood will
2172 leave Type-7 LSA at Lock Count = 2.
2173
2174 * ospf_flood.c (ospf_flood_through): Flood_though_as updated for
2175 NSSA no P-bit off during Area flooding, but P-bit is turned off
2176 for mulitple NSSA AS flooding.
2177
2178 * ospf_ase.c (ospf_ase_calculate_timer): Added calculations for
2179 Type-7 LSDB.
2180
2181 * ospf_abr.c (ospf_abr_translate_nssa): Removed one unlock call.
2182 (ospf_abr_announce_nssa_defaults): Corrected Debug from EVENT to
2183 NSSA.
2184
21852000-12-25 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2186
2187 * ospf_zebra.c (ospf_zebra_read_ipv4): Checking the age of the
2188 found LSA and if the LSA is MAXAGE we should call refresh instead
2189 of originate.
2190
21912000-12-18 Dick Glasspool <dick@ipinfusion.com>
2192
2193 * ospf_abr.c: Removed redundant "...flood" in
2194 announce_network_to_area(). Repaired nssa Unlock by using
2195 discard.
2196
2197 * ospf_packet.c: Removed old NSSA translate during mk_ls_update.
2198
2199 * ospfd.c: Free up all data bases including NSSA.
2200
2201 * ospf_lsa.c: Now allow removal of XLATE LSA's Check in
2202 discard_callback. Added routine to get ip addr from within the
2203 ifp.
2204
2205 * ospf_flood.c: Now set Forward Address for outgoing Type-7.
2206
2207 * ospf_lsa.h: Added prototype for the below. struct in_addr
2208 ospf_get_ip_from_ifp (struct interface *ifp).
2209
22102000-12-14 Gleb Natapov <gleb@nbase.co.il>
2211
2212 * ospf_packet.c (ospf_recv_packet): New OSPF pakcet read method.
2213 Now maximum packet length may be 65535 bytes (maximum IP packet
2214 length).
2215
2216 * ospf_interface.c (ospf_if_stream_set): Don't make input buffer.
2217
2218 * ospfd.c (config_write_network_area): Remove unnecessary area
2219 lookup code.
2220
22212000-12-13 Kunihiro Ishiguro <kunihiro@zebra.org>
2222
2223 * ospf_packet.c (ospf_read): Accept packet bigger than MTU value.
2224
22252000-12-13 Gleb Natapov <gleb@nbase.co.il>
2226
2227 * ospfd.c (config_write_network_area): Fix bug in
2228 config_write_network_area function.
2229
22302000-12-12 Gleb Natapov <gleb@nbase.co.il>
2231
2232 * ospf_abr.c (ospf_abr_announce_network_to_area): Make Summary
2233 LSA's origination and refreshment as same as other type of LSA.
2234
2235 * ospf_lsa.c (ospf_summary_lsa_refresh): Return struct ospf_lsa *.
2236
2237 * ospf_lsa.c (ospf_summary_asbr_lsa_refresh): Likewise.
2238
22392000-12-08 Dick Glasspool <dick@ipinfusion.com>
2240
2241 The bulk of NSSA changes are contained herein; This version will
2242 require manual setting of "always" for NSSA Translator, and will
2243 not perform aggregation yet.
2244
2245 * ospf_dump.c: "debug ospf nssa" is added.
2246
2247 * ospf_dump.h: Likewise.
2248
2249 * ospf_packet.c (ospf_hello): Display router ID on Bad NSSA Hello.
2250
2251 * ospfd.c: Discard_LSA to stay away from LOCAL_XLT Process NSSA
2252 'never, candidate, always'. Change "suppress" to "not-advertise".
2253
2254 * ospfd.h: Add TranslatorRole to struct ospf_area. Add anyNSSA to
2255 struct ospf.
2256
2257 * ospf_ase.c (ospf_ase_calculate_route): External to stay away
2258 from LOCAL_XLT
2259
2260 * ospf_nsm.c (ospf_db_summary_add): External to stay away from
2261 LOCAL_XLT
2262
2263 * ospf_abr.c: Major logic added for abr_nssa_task(). If ABR, and
2264 NSSA translator, then do it. Approve the global list, and flush
2265 any unapproved.
2266
2267 * ospf_lsa.h: New LSA flag OSPF_LSA_LOCAL_XLT to indicate that the
2268 Type-5 resulted from a Local Type-7 translation; not used for
2269 flooding, but used for flushing.
2270
2271 * ospf_flood.c: New NSSA flooding.
2272
22732000-12-08 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2274
2275 * ospfd.c (ospf_find_vl_data): New function for looking up virtual
2276 link data.
2277 (ospf_vl_set_security): Virtual link configuration with
2278 authentication.
2279 (ospf_vl_set_timers): Set timers for virtual link.
2280
2281 * New commands are added.
2282 "area A.B.C.D virtual-link A.B.C.D"
2283 "area A.B.C.D virtual-link A.B.C.D hello-interval <1-65535> retransmit-interval <3-65535> transmit-delay <1-65535> dead-interval <1-65535>"
2284 "area A.B.C.D virtual-link A.B.C.D hello-interval <1-65535> retransmit-interval <3-65535> transmit-delay <1-65535> dead-interval <1-65535> authentication-key AUTH_KEY"
2285 "area A.B.C.D virtual-link A.B.C.D authentication-key AUTH_KEY"
2286 "area A.B.C.D virtual-link A.B.C.D hello-interval <1-65535> retransmit-interval <3-65535> transmit-delay <1-65535> dead-interval <1-65535> message-digest-key <1-255> md5 KEY"
2287 "area A.B.C.D virtual-link A.B.C.D message-digest-key <1-255> md5 KEY"
2288
2289 * ospf_packet.c (ospf_check_md5_digest): Add neighbor's
2290 cryptographic sequence number treatment.
2291 (ospf_check_auth): OSPF input buffer is added to argument.
2292 (ospf_read): Save neighbor's cryptographic sequence number.
2293
2294 * ospf_nsm.c (nsm_change_status): Clear cryptographic sequence
2295 number when neighbor status is changed to NSM down.
2296
2297 * ospf_neighbor.c (ospf_nbr_new): Set zero to crypt_seqnum.
2298
2299 * ospf_neighbor.h (struct ospf_neighbor): Add cryptographic
2300 sequence number to neighbor structure.
2301
23022000-11-29 Kunihiro Ishiguro <kunihiro@zebra.org>
2303
2304 * ospf_snmp.c (ospfIfLookup): OSPF MIB updates.
2305 (ospfExtLsdbEntry): Add OspfExtLsdbTable treatment.
2306
23072000-11-28 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2308
2309 * ospfd.c (ospf_interface_down): Clear a ls_upd_queue queue of the
2310 interface.
2311 (ospf_ls_upd_queue_empty): New function to empty ls update queue
2312 of the OSPF interface.
2313 (no_router_ospf): 'no router ospf' unregister redistribution
2314 requests from zebra.
2315
23162000-11-28 Kunihiro Ishiguro <kunihiro@zebra.org>
2317
2318 * ospf_ism.c (ism_change_status): Increment status change number.
2319
2320 * ospf_interface.h (struct ospf_interface): Add new member for
2321 status change statistics.
2322
2323 * Makefile.am: Update dependencies.
2324
2325 * ospf_zebra.c (ospf_interface_add): OSPF SNMP interface update.
2326 (ospf_interface_delete): OSPF SNMP interface delete.
2327
2328 * ospf_snmp.h: New file is added.
2329
23302000-11-23 Dick Glasspool <dick@ipinfusion.com>
2331
2332 * ospfd.h: Add new ospf_area structure member for
2333 NSSATranslatorRole and NSSATranslator state.
2334
2335 * ospfd.c: Provided for eventual commands to specify NSSA
2336 elections for "translator- ALWAYS/NEVER/CANDIDATE". Provided for
2337 decimal integer version of area-suppress.
2338
2339 * ospf_flood.c: Flood Type-7's only into NSSA (not AS).
2340
2341 * ospf_lsa.c: Undo some previous changes for NSSA. If NSSA
2342 translator, advertise Nt bit.
2343
2344 * ospf_route.c: 1st version of "sh ip os border-routers".
2345
23462000-11-23 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2347
2348 * ospfd.c (area_vlink): Virtual link can not configured in stub
2349 area.
2350
23512000-11-23 Gleb Natapov <gleb@nbase.co.il>
2352
2353 * ospf_packet.c (ospf_db_desc): In states Loading and Full the
2354 slave must resend its last Database Description packet in response
2355 to duplicate Database Description packets received from the
2356 master. For this reason the slave must wait RouterDeadInterval
2357 seconds before freeing the last Database Description packet.
2358 Reception of a Database Description packet from the master after
2359 this interval will generate a SeqNumberMismatch neighbor
2360 event. RFC2328 Section 10.8
2361 (ospf_make_db_desc): DD Master flag treatment.
2362
2363 * ospf_nsm.c (nsm_twoway_received): Move DD related procedure to
2364 nsm_change_status().
2365 (nsm_bad_ls_req): Likewise.
2366 (nsm_adj_ok): Likewise.
2367 (nsm_seq_number_mismatch): Likewise.
2368 (nsm_oneway_received): Likewise.
2369
2370 * ospf_neighbor.h (struct ospf_neighbor): New structure member
2371 last_send_ts for timestemp when last Database Description packet
2372 was sent.
2373
2374 * ospf_nsm.c (ospf_db_desc_timer): Make it sure nbr->last_send is
2375 there. Call ospf_db_desc_resend() in any case.
2376
23772000-11-16 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2378
2379 * ospf_lsa.c (lsa_link_broadcast_set): When there is no DR on
2380 network (suppose you have only one router with interface priority
2381 0). It's router LSA does not contain the link information about
2382 this network.
2383
2384 * ospf_nsm.c (nsm_timer_set): When you change a priority of
2385 interface from/to 0 ISM_NeighborChange event should be scheduled
2386 in order to elect new DR/BDR on the network.
2387
2388 * ospf_interface.c (ip_ospf_priority): Likewise.
2389
2390 * ospf_flood.c (ospf_ls_retransmit_add): When we add some LSA into
2391 retransmit list we need to check whether the present old LSA in
2392 retransmit list is not more recent than the new
2393 one.
2394
23952000-11-09 Dick Glasspool <dick@ipinfusion.com>
2396
2397 * ospf_packet.c: Allows for NSSA Type-7 LSA's throughout the NSSA
2398 area. Any that exit the NSSA area are translated to type-5 LSA's.
2399 The instantiated image is restored after translation.
2400 (ospf_ls_upd_send_list): Renamed to ospf_ls_upd_queu_send().
2401 (ospf_ls_upd_send): Old function which enclosed by #ifdef 0 is
2402 removed.
2403 (ospf_ls_ack_send): Likewise.
2404
2405 * ospf_flood.c: NSSA-LSA's without P-bit will be restricted to
2406 local area. Otherwise they are allowed out the area to be
2407 translated by ospf_packet.c.
2408
2409 * ospf_lsa.c: Undo some previous changes for NSSA.
2410
2411 * ospf_lsdb.h: New access for type 7.
2412
24132000-11-07 Kunihiro Ishiguro <kunihiro@zebra.org>
2414
2415 * ospf_route.c (ospf_path_exist): New function to check nexthop
2416 and interface are in current OSPF path or not.
2417 (ospf_route_copy_nexthops_from_vertex): Add nexthop to OSPF path
2418 when it is not there. Reported by Michael Rozhavsky
2419 <mrozhavsky@opticalaccess.com>
2420
24212000-11-06 Kunihiro Ishiguro <kunihiro@zebra.org>
2422
2423 * ospf_dump.c (config_write_debug): Add seventh string "detail" is
2424 added for flag is OSPF_DEBUG_SEND | OSPF_DEBUG_RECV |
2425 OSPF_DEBUG_DETAIL.
2426
24272000-11-06 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2428
2429 * ospf_lsa.c (router_lsa_flags): ASBR can't exit in stub area.
2430
24312000-11-06 Kunihiro Ishiguro <kunihiro@zebra.org>
2432
2433 * ospf_lsa.c (ospf_router_lsa_originate): Reduce unconditional
2434 logging.
2435
24362000-11-06 Dick Glasspool <dick@ipinfusion.com>
2437
2438 * ospfd.h: Add ait_ntoa function prototype.
2439
2440 * ospfd.c (ait_ntoa): New function for displaying area ID and
2441 Stub/NSSA status.
2442 (show_ip_ospf_interface_sub): Use ait_ntoa.
2443 (show_ip_ospf_nbr_static_detail_sub): Likewise.
2444 (show_ip_ospf_neighbor_detail_sub): Likewise.
2445
2446 * ospf_route.c (ospf_intra_route_add): Set external routing type
2447 to ospf route.
2448 (ospf_intra_add_router): Likewise.
2449 (ospf_intra_add_transit): Likewise.
2450 (ospf_intra_add_stub): Likewise.
2451 (ospf_add_discard_route): Likewise.
2452 (show_ip_ospf_route_network): Use ait_ntoa.
2453 (show_ip_ospf_route_network): Likewise.
2454 (show_ip_ospf_route_router): Likewise.
2455
2456 * ospf_lsa.c (show_lsa_detail): Use ait_ntoa.
2457 (show_lsa_detail_adv_router): Likewise.
2458 (show_ip_ospf_database_summary): Likewise.
2459
2460 * ospf_route.h (struct route_standard): Add new member
2461 external_routing.
2462
2463 * ospf_ia.c (process_summary_lsa): Set external routing tyep to ospf
2464 route.
2465 (ospf_update_network_route): Likewise.
2466 (ospf_update_router_route): Likewise.
2467
24682000-11-04 Kunihiro Ishiguro <kunihiro@zebra.org>
2469
2470 * ospf_flood.c (ospf_process_self_originated_lsa): Enclose
2471 OSPF_AS_NSSA_LSA treatment with #ifdef HAVE_NSSA.
2472
24732000-11-03 Kunihiro Ishiguro <kunihiro@zebra.org>
2474
2475 * Unconditional logging is enclosed with if (IS_DEBUG_OSPF_EVENT).
2476 Please specify "debug ospf event" for enable logging.
2477
2478 * ospf_ism.c: Do not extern debug flag varible. It is done by
2479 ospf_debug.h
2480 * ospf_asbr.c: Likewise.
2481 * ospf_lsa.c: Likewise.
2482 * ospf_nsm.c: Likewise.
2483 * ospf_zebra.c: Likewise.
2484
2485 * ospf_dump.c (debug_ospf_event): New command "debug ospf event"
2486 is added.
2487
2488 * ospfd.c (router_ospf): Change logging from vty_out() to
2489 zlog_info().
2490 (ospf_area_stub_cmd): Likewise.
2491
2492 * ospf_dump.h: Extern term_debug flags.
2493 (OSPF_DEBUG_EVENT): Add new flag.
2494 (IS_DEBUG_OSPF_EVENT): Add new macro.
2495
24962000-11-03 Dick Glasspool <dick@ipinfusion.com>
2497
2498 * ospf_flood.c (ospf_process_self_originated_lsa):
2499 OSPF_AS_NSSA_LSA is treated as same as OSPF_AS_EXTERNAL_LSA.
2500 (ospf_flood): Type-5's have no change. Type-7's can be received,
2501 and will Flood the AS as Type-5's They will also flood the local
2502 NSSA Area as Type-7's. The LSDB will be updated as Type-5's, and
2503 during re-fresh will be converted back to Type-7's (if within an
2504 NSSA).
2505 (ospf_flood_through): Incoming Type-7's were allowed here if our
2506 neighbor was an NSSA. So Flood our area with the Type-7 and also
2507 if we are an ABR, flood thru AS as Type-5.
2508
2509 * ospf_lsa.c (ospf_external_lsa_refresh): Flood NSSA both NSSA
2510 area and other area.
2511
2512 * ospf_packet.c (ospf_db_desc_proc): When AS External LSA is
2513 exists in DD packet, make it sure that this area is not stub.
2514 (ospf_ls_upd_list_lsa): When LSA type is NSSA then set lsa's area
2515 to NULL.
2516 (ospf_ls_upd): If the LSA is AS External LSA and the area is stub
2517 then discard the lsa. If the LSA is NSSA LSA and the area is not
2518 NSSA then discard the lsa.
2519
25202000-11-03 Kunihiro Ishiguro <kunihiro@zebra.org>
2521
2522 * ospfd.c (ospf_interface_run): Fix bug of Hello packet's option
2523 is not properly set when interface comes up.
2524
25252000-11-02 Kunihiro Ishiguro <kunihiro@zebra.org>
2526
2527 * ospfd.h (OSPF_OPTION_O): Add new hello header option.
2528
25292000-11-01 Dick Glasspool <dick@ipinfusion.com>
2530
2531 * ospf_lsa.h: Define OSPF_MAX_LSA to 8 when HAVE_NSSA is enabled.
2532 (OSPF_GROUP_MEMBER_LSA): Define OSPF_GROUP_MEMBER_LSA.
2533
2534 * ospf_lsa.c (show_database_desc): Add "Group Membership LSA"
2535 string.
2536
25372000-10-31 Dick Glasspool <dick@ipinfusion.com>
2538
2539 * ospf_lsa.h (OSPF_AS_NSSA_LSA): Define OSPF_AS_NSSA_LSA.
2540
2541 * ospf_lsa.c (show_ip_ospf_database): NSSA database display
2542 function is added. ALIASES which have "show ip ospf database
2543 nssa-external" is added.
2544 (show_ip_ospf_border_routers): New command "show ip ospf
2545 border-routers" is added.
2546
25472000-10-30 Dick Glasspool <dick@ipinfusion.com>
2548
2549 * ospfd.c (router_ospf): NSSA Enabled message is added for
2550 testing.
2551 (ospf_area_type_set): Are type set for NSSA area.
2552 (ospf_area_stub_cmd): Special translation of no_summary into NSSA
2553 and summary information. If NSSA is enabled pass the information
2554 to ospf_area_type_set().
2555 (area_nssa): New commands are added:
2556 "area A.B.C.D nssa"
2557 "area <0-4294967295> nssa"
2558 "area A.B.C.D nssa no-summary"
2559 "area <0-4294967295> nssa no-summary"
2560 (ospf_no_area_stub_cmd): Special translation of no_summary into
2561 NSSA and summary information. If external_routing is
2562 OSPF_AREA_NSSA unset area with ospf_area_type_set (area,
2563 OSPF_AREA_DEFAULT).
2564 (show_ip_ospf_area): Display NSSA status.
2565 (config_write_ospf_area): Show NSSA configuration.
2566
2567 * ospf_packet.c (ospf_hello): For NSSA support, ensure that NP is
2568 on and E is off.
2569
25702000-10-26 Gleb Natapov <gleb@nbase.co.il>
2571
2572 * ospf_lsa.c (ospf_network_lsa_body_set): The network-LSA lists
2573 those routers that are fully adjacent to the Designated Router;
2574 each fully adjacent router is identified by its OSPF Router ID.
2575 The Designated Router includes itself in this list. RFC2328,
2576 Section 12.4.2.
2577
25782000-10-23 Jochen Friedrich <jochen@scram.de>
2579
2580 * ospf_snmp.c: ospf_oid and ospfd_oid are used in smux_open after
2581 it is registered. So those variables must be static.
2582
25832000-10-18 K N Sridhar <sridhar@euler.ece.iisc.ernet.in>
2584
2585 * ospfd.c: Add area_default_cost_decimal_cmd and
2586 no_area_default_cost_decimal_cmd alias.
2587
25882000-10-05 Gleb Natapov <gleb@nbase.co.il>
2589
2590 * ospfd.c (ospf_network_new): Fix setting area format.
2591 (no_router_ospf): Check area existance when calling
2592 ospf_interface_down().
2593
2594 * ospf_flood.c (ospf_external_info_check): Fix bug of refreshing
2595 default route.
2596
25972000-10-02 Kunihiro Ishiguro <kunihiro@zebra.org>
2598
2599 * zebra-0.89 is released.
2600
26012000-09-29 Kunihiro Ishiguro <kunihiro@zebra.org>
2602
2603 * ospf_snmp.c (ospfHostEntry): OSPF Host MIB is implemented.
2604
2605 * ospfd.c (ospf_nbr_static_cmp): OSPF neighbor is sorted by it's
2606 address.
2607
26082000-09-28 Michael Rozhavsky <mike@nbase.co.il>
2609
2610 * ospf_interface.c (ospf_if_free): Fix deleting self neighbor twice.
2611
26122000-09-27 Kunihiro Ishiguro <kunihiro@zebra.org>
2613
2614 * ospf_packet.c (ospf_read): Solaris on x86 has ip_len with host
2615 byte order.
2616
26172000-09-25 Toshiaki Takada <takada@zebra.org>
2618
2619 * ospfd.c (ospf_compatible_rfc1583), (no_ospf_compatible_rfc1583):
2620 Add CISCO compatible command.
2621
26222000-09-25 Kunihiro Ishiguro <kunihiro@zebra.org>
2623
2624 * ospf_abr.c (ospf_area_range_lookup): New function is added for
2625 area range lookup in OSPF-MIB.
2626 (ospf_area_range_lookup_next): Likewise.
2627
26282000-09-22 Kunihiro Ishiguro <kunihiro@zebra.org>
2629
2630 * ospfd.c (no_router_ospf): Delete virtual link before deleting
2631 area structure.
2632
2633 * ospf_lsa.c (ospf_external_lsa_refresh_type): Check
2634 EXTERNAL_INFO(type).
2635
2636 * ospfd.c (no_router_ospf): Call ospf_vl_delete() instead of
2637 ospf_vl_data_free().
2638
2639 * ospf_interface.c (ospf_vl_shutdown): Execute ISM_InterfaceDown
2640 when ospf_vl_shutdown is called.
2641 (ospf_vl_delete): Call ospf_vl_shutdown() to delete virtual link
2642 interface's thread.
2643
26442000-09-21 Gleb Natapov <gleb@nbase.co.il>
2645
2646 * ospf_lsa.c: New implementation of OSPF refresh.
2647
26482000-09-20 Kunihiro Ishiguro <kunihiro@zebra.org>
2649
2650 * ospf_snmp.c (ospfLsdbLookup): Add LSDB MIB implementation.
2651
26522000-09-18 Kunihiro Ishiguro <kunihiro@zebra.org>
2653
2654 * ospf_snmp.c (ospfStubAreaEntry): Add OSPF stub area MIB.
2655
26562000-09-18 Gleb Natapov <gleb@nbase.co.il>
2657
2658 * ospf_route.h (route_standard): Change member from `struct area'
2659 to area_id.
2660
2661 * ospf_abr.c (ospf_abr_announce_network), (ospf_abr_should_announce),
2662 (ospf_abr_process_network_rt), (ospf_abr_announce_rtr),
2663 (ospf_abr_process_router_rt):
2664 * ospf_ase.c (ospf_find_asbr_route),
2665 (ospf_find_asbr_router_through_area),
2666 * ospf_ia.c (ospf_find_abr_route), (ospf_ia_router_route),
2667 (process_summary_lsa), (ospf_update_network_route),
2668 (ospf_update_router_route):
2669 * ospf_route.c (ospf_intra_route_add), (ospf_intra_add_router),
2670 (ospf_intra_add_transit), (ospf_intra_add_stub),
2671 (ospf_route_table_dump), (show_ip_ospf_route_network),
2672 (show_ip_ospf_route_router), (ospf_asbr_route_cmp),
2673 (ospf_prune_unreachable_routers):
2674 * ospf_spf.c (ospf_rtrs_print):
2675 * ospfd.c (ospf_rtrs_free): Fix the struct change above.
2676
26772000-09-14 Kunihiro Ishiguro <kunihiro@zebra.org>
2678
2679 * ospf_network.c (ospf_serv_sock_init): Enclose SO_BINDTODEVICE
2680 with ifdef.
2681
26822000-09-13 Gleb Natapov <gleb@nbase.co.il>
2683
2684 * ospf_ism.c (ospf_elect_dr), (ospf_elect_bdr): Fix DR election.
2685
2686 * ospf_network.c (ospf_serv_sock_init): Add socket option
2687 SO_BINDTODEVICE on read socket.
2688
2689 * ospf_packet.c (ospf_hello): Ignore Hello packet if E-bit does
2690 not match.
2691
2692 * ospfd.c (ospf_area_check_free), (ospf_area_get),
2693 (ospf_area_add_if): New function added.
2694
26952000-09-13 Kunihiro Ishiguro <kunihiro@zebra.org>
2696
2697 * ospf_route.c (ospf_intra_add_router): Update ABR and ASBR router
2698 count.
2699
2700 * ospf_spf.c (ospf_spf_init): Rest ABR and ASBR router count
2701 starting SPF calculation.
2702
2703 * ospfd.h (struct ospf_area): Add ABR and ASBR router count.
2704
27052000-09-12 Kunihiro Ishiguro <kunihiro@zebra.org>
2706
2707 * ospfd.c (ospf_area_id_cmp): New area structure is sorted by area
2708 ID.
2709
2710 * ospf_lsa.c (ospf_router_lsa_originate): For OSPF MIB update
2711 lsa_originate_count.
2712 (ospf_network_lsa_originate): Likewise.
2713 (ospf_summary_lsa_originate): Likewise.
2714 (ospf_summary_asbr_lsa_originate): Likewise.
2715 (ospf_external_lsa_originate): Likewise.
2716
27172000-09-11 Kunihiro Ishiguro <kunihiro@zebra.org>
2718
2719 * ospf_snmp.c (ospf_variables): ospfRouterID's type RouterID
2720 syntax is IpAddress.
2721 (ospf_admin_stat): New function for OSPF administrative status
2722 check.
2723
27242000-09-10 Jochen Friedrich <jochen@scram.de>
2725
2726 * ospf_snmp.c: Implement OSPF MIB skeleton.
2727
27282000-09-08 Kunihiro Ishiguro <kunihiro@zebra.org>
2729
2730 * ospf_snmp.c: New file is added.
2731
27322000-09-07 David Lipovkov <davidl@nbase.co.il>
2733
2734 * ospf_zebra.c (ospf_interface_delete): Add pseudo interface
2735 treatment.
2736
2737 * ospf_interface.c (interface_config_write): Likewise.
2738
27392000-08-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2740
2741 * zebra-0.88 is released.
2742
27432000-08-17 Michael Rozhavsky <mike@nbase.co.il>
2744
2745 * ospfd.c (ospf_area_free): Remove virtual link configuration only
2746 when Area is removed.
2747
27482000-08-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2749
2750 * ospfd.c (network_area): Revert check for EXTERNAL_INFO
2751 (ZEBRA_ROUTE_CONNECT).
2752 (no_network_area): Likewise.
2753
27542000-08-16 Kunihiro Ishiguro <kunihiro@zebra.org>
2755
2756 * ospfd.h (struct ospf): Add distance_table and
2757 distance_{all,intra,inter,external}.
2758
2759 * ospf_zebra.c: Add OSPF distance related functions.
2760
27612000-08-15 Gleb Natapov <gleb@nbase.co.il>
2762
2763 * ospf_asbr.c (ospf_external_info_find_lsa): New function added.
2764
2765 * ospf_lsa.c (ospf_default_external_info),
2766 (ospf_default_originate_timer), (ospf_external_lsa_refresh_default):
2767 New function added.
2768
2769 * ospf_zebra.c
2770 (ospf_default_information_originate_metric_type_routemap),
2771 (ospf_default_information_originate_always_metric_type_routemap):
2772 Change name and add route-map function.
2773 (ospf_default_information_originate_metric_routemap),
2774 (ospf_default_information_originate_routemap),
2775 (ospf_default_information_originate_type_metric_routemap):
2776 New DEFUN added.
2777
27782000-08-14 Kunihiro Ishiguro <kunihiro@zebra.org>
2779
2780 * ospf_zebra.c (zebra_interface_if_set_value): Change ifindex
2781 restore size from two octet to four.
2782
27832000-08-14 Michael Rozhavsky <mike@nbase.co.il>
2784
2785 * ospf_ase.c (ospf_ase_incremental_update): Implement incremental
2786 AS-external-LSA in 16.6 of RFC2328.
2787
27882000-08-14 Matthew Grant <grantma@anathoth.gen.nz>
2789
2790 * ospf_interface.c (ospf_if_get_output_cost): Change cost
2791 calculation algorithm.
2792
2793 * ospf_packet (ospf_ls_upd): Fix problem of LSA retransmitting.
2794
27952000-08-11 Michael Rozhavsky <mike@nbase.co.il>
2796
2797 * ospf_lsa.c (ospf_maxage_lsa_remover): Fix maxage remover for
2798 AS-external-LSAs.
2799
28002000-08-10 Toshiaki Takada <takada@zebra.org>
2801
2802 * ospfd.c (auto_cost_reference_bandwidth): New DEFUN added.
2803 `auto-cost reference-bandwidth' OSPF router command added.
2804
28052000-08-08 Gleb Natapov <gleb@nbase.co.il>
2806
2807 * ospf_routemap.c (ospf_route_map_update): New function added.
2808 Add route-map event hook.
2809
28102000-08-08 Toshiaki Takada <takada@zebra.org>
2811
2812 * ospf_zebra.c (ospf_distribute_check_connected): If redistribute
2813 prefix is connected route on OSPF enabled interface, suppress to
2814 announce it.
2815
28162000-08-08 Matthew Grant <grantma@anathoth.gen.nz>
2817
2818 * ospf_interface.c (ospf_if_get_output_cost):
2819 New function added. Handle bandwidth parameter for cost
2820 calculation.
2821
28222000-08-08 Michael Rozhavsky <mike@nbase.co.il>
2823
2824 * ospf_interface.c (interface_config_write): Show interface
2825 configuration regardless interface is down.
2826
2827 * ospf_ase.c (ospf_ase_caocluate_route): Whole rewritten external
2828 route calculate function.
2829
28302000-08-08 Gleb Natapov <gleb@nbase.co.il>
2831
2832 * ospf_routemap.c: New file added.
2833
2834 * ospf_asbr.c (ospf_reset_route_map_set_values),
2835 (ospf_route_map_set_compare): New function added.
2836
2837 * ospf_lsa.c (ospf_external_lsa_body_set): Set routemap metric
2838 with AS-external-LSA.
2839
28402000-08-05 Kunihiro Ishiguro <kunihiro@zebra.org>
2841
2842 * ospf_ase.c (ospf_ase_calculate_route_add): Pass new->cost to
2843 ospf_zebra_add as metric.
2844 (ospf_ase_calculate_route_add): Likewise.
2845
2846 * ospf_route.c (ospf_route_install): Pass or->cost to
2847 ospf_zebra_add as metric.
2848
2849 * ospf_zebra.c (ospf_zebra_add): Add metric arguemnt.
2850 (ospf_zebra_delete): Likewise.
2851
28522000-08-03 Matthew Grant <grantma@anathoth.gen.nz>
2853
2854 * ospf_flood.c (ospf_flood_delayed_lsa_ack): New function added.
2855 Dispatch delayed-ACK with flooding AS-external-LSA across virtual
2856 link.
2857
28582000-07-31 Matthew Grant <grantma@anathoth.gen.nz>
2859
2860 * ospfd.c (show_ip_ospf_area): Fix lack of VTY_NEWLINE when
2861 `show ip ospf'.
2862
2863 * ospf_interface.c (ospf_if_free): Fix bug of crash with
2864 Point-to-Point interface.
2865
28662000-07-27 Michael Rozhavsky <mike@nbase.co.il>
2867
2868 * ospf_flood.c (ospf_process_self_originated_lsa):
2869 Make sure to clear LSA->param (redistributed external information)
2870 before refreshment.
2871
28722000-07-27 Gleb Natapov <gleb@nbase.co.il>
2873
2874 * ospfd.c (refresh_group_limit), (refresh_per_slice),
2875 (refresh_age_diff): New defun added. Refresher related parameter
2876 can be configurable.
2877
28782000-07-27 Akihiro Mizutani <mizutani@dml.com>
2879
2880 * ospf_interface.c (interface_config_write): Print `description'
2881 config directive to work.
2882
28832000-07-24 Akihiro Mizutani <mizutani@dml.com>
2884
2885 * ospf_interface.c (ospf_if_init): Use install_default for
2886 INTERFACE_NODE.
2887
28882000-07-24 Gleb Natapov <gleb@nbase.co.il>
2889
2890 * ospf_packet.c (ospf_ls_upd_send_list), (ospf_ls_upd_send_event),
2891 (ospf_ls_ack_send_list), (ospf_ls_ack_send_event): New function added.
2892 This make sending always as many LS update/Ack combined in one ospf
2893 packet.
2894
28952000-07-24 Gleb Natapov <gleb@nbase.co.il>
2896
2897 * ospf_packet.c (ospf_ls_upd_list_lsa): Set NULL to lsa->area if
2898 LSA is AS-external-LSA.
2899
2900 * ospf_nsm.c (nsm_reset_nbr): Do not cancel Inactivity timer.
2901
29022000-07-21 Toshiaki Takada <takada@zebra.org>
2903
2904 * ospf_zebra.c (ospf_default_originate_timer): Set timer for
2905 `default-information originate'. Fix some default originate
2906 related functions.
2907
29082000-07-12 Toshiaki Takada <takada@zebra.org>
2909
2910 * ospf_lsa.c (stream_put_ospf_metric): New function added.
2911
29122000-07-12 Toshiaki Takada <takada@zebra.org>
2913
2914 * ospf_lsa.c (show_ip_ospf_database_router),
2915 (show_ip_ospf_database_network), (show_ip_ospf_database_summary),
2916 (show_ip_ospf_database_summary_asbr), (show_ip_ospf_database_externel),
2917 (show_router_lsa), (show_any_lsa), (show_router_lsa_self),
2918 (show_any_lsa_self): Functions removed.
2919
2920 (show_lsa_prefix_set), (show_lsa_detail_proc), (show_lsa_detail),
2921 (show_lsa_detail_adv_router_proc), (show_lsa_detail_adv_router):
2922 New functions added. Replace above functions.
2923
2924 (show_ip_ospf_database_all), (show_ip_ospf_database_self_originated):
2925 Functions removed.
2926 (show_ip_ospf_database_summary): New functions added. Replace
2927 above functions.
2928
2929 (show_ip_ospf_database_cmd): DEFUN rearranged.
2930 (show_ip_ospf_database_type_id_cmd),
2931 (show_ip_ospf_database_type_id_adv_router_cmd),
2932 (show_ip_ospf_database_type_is_self_cmd): New ALIASes added.
2933 (show_ip_ospf_database_type_adv_rotuer_cmd): New DEFUN added.
2934 (show_ip_ospf_database_type_self_cmd): New ALIAS added.
2935
29362000-07-11 Toshiaki Takada <takada@zebra.org>
2937
2938 * ospf_asbr.c (ospf_external_info_new),
2939 (ospf_external_info_free): New functions added.
2940
2941 * ospf_lsa.h (ospf_lsa): Add new member `void *param' to set
2942 origination parameter for external-LSA.
2943 Remove member `redistribute'.
2944
2945 * ospf_zebra.c (ospf_redistirbute_set): When `redistribute'
2946 command executed, metric and metric-type values are overridden.
2947 If one of those is changed refresh AS-external-LSAs for appropriate
2948 type.
2949
29502000-07-11 Michael Rozhavsky <mike@nbase.co.il>
2951
2952 * ospf_lsa.c (ospf_summary_lsa_refresh),
2953 (ospf_summary_asbr_lsa_refresh): Make sure to refresh summary-LSAs.
2954
2955 * ospf_abr.c (set_metric): New function added.
2956
29572000-07-07 Toshiaki Takada <takada@zebra.org>
2958
2959 * ospf_zebra.c (ospf_default_information_originate_metric_type),
2960 (ospf_default_information_originate_type_metric): New defun added.
2961 Metic and Metric type can be set to default route.
2962 (ospf_default_information_originate_always_metric_type):
2963 (ospf_default_information_originate_always_type_metric):
2964 New defun added. Metric and Metric type can be set to default
2965 always route.
2966
2967 * ospf_zebra.c (ospf_default_metric), (no_ospf_default_metric):
2968 New defun added.
2969
29702000-07-06 Gleb Natapov <gleb@nbase.co.il>
2971
2972 * ospf_flood.c (ospf_flood_through_area): Fix bug of considering
2973 on the same interface the LSA was received from.
2974
29752000-07-06 Michael Rozhavsky <mike@nbase.co.il>
2976
2977 * ospfd.c (ospf_config_write): Fix bug of printing `area stub'
2978 command with `write mem'.
2979
2980 * ospfd.c (no_router_ospf): Remove installed routes from zebra.
2981
2982 * ospf_zebra.c (ospf_interface_delete): Fix function to handle
2983 zebra interface delete event.
2984
29852000-07-06 Toshiaki Takada <takada@zebra.org>
2986
2987 * ospf_zebra.c (ospf_default_information_originate),
2988 (ospf_default_information_originate_always): New DEFUN added.
2989
29902000-07-05 Michael Rozhavsky <mike@nbase.co.il>
2991
2992 * ospf_route.c (ospf_terminate): Make sure to remove external route
2993 when SIGINT received.
2994
29952000-07-03 Gleb Natapov <gleb@nbase.co.il>
2996
2997 * ospf_flood.c, ospf_ism.c, ospf_lsa,c, ospfd.c: Make sure to free
2998 many structure with `no router ospf'.
2999
30002000-06-30 Gleb Natapov <gleb@nbase.co.il>
3001
3002 * ospf_neighbor.c (ospf_nbr_new),
3003 ospf_nsm.c (nsm_timer_set): Start LS update timer only
3004 when neighbor enters Exchange state.
3005
30062000-06-29 Gleb Natapov <gleb@nbase.co.il>
3007
3008 * ospf_nsm.c (nsm_timer_set), (nsm_exchange_done),
3009 ospf_packet.c (ospf_db_desc_proc):
3010 Do not cancel DD retransmit timer when Master.
3011
30122000-06-29 Gleb Natapov <gleb@nbase.co.il>
3013
3014 * ospf_abr.c (ospf_abr_announce_network_to_area),
3015 (ospf_abr_announce_rtr_to_area)
3016 ospf_ase.c (ospf_ase_rtrs_register_lsa),
3017 ospf_flood.c (ospf_process_self_originated_lsa),
3018 (ospf_flood_through_area), (ospf_ls_request_delete),
3019 ospf_interface.c (ospf_if_free),
3020 ospf_ism.c (ism_change_status),
3021 ospf_lsa.c (ospf_router_lsa_update_timer),
3022 (ospf_router_lsa_install), (ospf_network_lsa_install),
3023 (ospf_lsa_maxage_delete), (ospf_lsa_action),
3024 (ospf_schedule_lsa_flood_area),
3025 ospf_nsm.c (nsm_change_status),
3026 ospf_packet.c (ospf_make_ls_req_func), (ospf_make_ls_ack):
3027 Use ospf_lsa_{lock,unlock} for all looking-up of LSA.
3028
3029 * ospf_flood.c (ospf_ls_request_free): Function deleted.
3030
3031 * ospf_lsa.c (ospf_discard_from_db): New function added.
3032
30332000-06-26 Toshiaki Takada <takada@zebra.org>
3034
3035 * ospfd.h (ospf): struct member `external_lsa' name changed to
3036 `lsdb'.
3037
30382000-06-26 Toshiaki Takada <takada@zebra.org>
3039
3040 * ospf_lsa.c (ospf_lsa_install), (ospf_router_lsa_install),
3041 (ospf_network_lsa_install), (ospf_summary_lsa_install),
3042 (ospf_summary_asbr_lsa_install), (ospf_external_lsa_install):
3043 Functions re-arranged.
3044
3045 * ospf_lsa.c (IS_LSA_MAXAGE), (IS_LSA_SELF): Macro added.
3046
30472000-06-20 Michael Rozhavsky <mike@nbase.co.il>
3048
3049 * ospf_packet.c (ospf_ls_req), (ospf_ls_upd), (ospf_ls_ack): Add
3050 verification of LS type.
3051
30522000-06-20 Gleb Natapov <gleb@nbase.co.il>
3053
3054 * ospf_ase.c (ospf_ase_calculate_timer): Add more sanity check
3055 whether rn->info is NULL.
3056
30572000-06-20 Toshiaki Takada <takada@zebra.org>
3058
3059 * ospfd.c (show_ip_ospf_interface_sub): Show Router-ID of both
3060 DR and Backup correctly with `show ip ospf interface' command.
3061
30622000-06-20 Toshiaki Takada <takada@zebra.org>
3063
3064 * ospf_lsa.c (ospf_lsa_lock), (ospf_lsa_unlock),
3065 (ospf_lsa_discard): These functions are used for avoiding
3066 unexpected reference to freed LSAs.
3067
30682000-06-13 Kunihiro Ishiguro <kunihiro@zebra.org>
3069
3070 * ospf_packet.c (ospf_ls_upd): Initialize lsa by NULL to avoid
3071 warning.
3072
30732000-06-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3074
3075 * ospf_ase.h (ospf_ase_rtrs_register_lsa): Add prototype.
3076
30772000-06-12 Toshiaki Takada <takada@zebra.org>
3078
3079 * ospf_lsa.c (ospf_external_lsa_install): Make sure to register
3080 LSA to rtrs_external when replacing AS-external-LSAs in LSDB.
3081 Fix core dump.
3082
30832000-06-10 Toshiaki Takada <takada@zebra.org>
3084
3085 * ospf_lsdb.c (id_to_prefix), (ospf_lsdb_hash_key),
3086 (ospf_lsdb_hash_cmp), (ospf_lsdb_new), (ospf_lsdb_iterator),
3087 (lsdb_free), (ospf_lsdb_free), (ospf_lsdb_add), (ospf_lsdb_delete),
3088 (find_lsa), (ospf_lsdb_lookup), (find_by_id),
3089 (ospf_lsdb_lookup_by_id), (ospf_lsdb_lookup_by_header): Functinos
3090 removed for migration to new_lsdb.
3091
3092 * ospf_lsa.c (ospf_summary_lsa_install),
3093 (ospf_summary_asbr_lsa_install), (ospf_maxage_lsa_remover),
3094 (ospf_lsa_maxage_walker), (ospf_lsa_lookup),
3095 (ospf_lsa_lookup_by_id): Use new_lsdb instead of ospf_lsdb.
3096 (count_lsa), (ospf_lsa_count_table), (ospf_lsa_count),
3097 (ospf_get_free_id_for_prefix): Funcitions removed.
3098
30992000-06-09 Gleb Natapov <gleb@nbase.co.il>
3100
3101 * ospf_ism.c (ism_interface_down): Prevent some unneeded DR changes.
3102
3103 * ospf_packet.c (ospf_db_desc_proc): Fix memory leak.
3104 (ospf_hello): Always copy router-ID when hello is received.
3105
31062000-06-08 Gleb Natapov <gleb@nbase.co.il>
3107
3108 * ospf_lsa.h (struct ospf_lsa): Add member of pointer to struct
3109 ospf_area.
3110
31112000-06-08 Michael Rozhavsky <mike@nbase.co.il>
3112
3113 * ospf_ase.c (ospf_asbr_route_same): New function added.
3114 This function makes sure external route calculation more
3115 precisely.
3116
31172000-06-07 Michael Rozhavsky <mike@nbase.co.il>
3118
3119 * ospf_ism.c (ism_change_status): Use ospf_lsa_flush_area for
3120 network-LSA deletion instead of using ospf_lsdb_delete.
3121 Also cancel network-LSA origination timer.
3122
31232000-06-07 Levi Harper <lharper@kennedytech.com>
3124
3125 * ospf_interface.c (ospf_if_down): Close read fd when an interface
3126 goes down.
3127
31282000-06-05 Kunihiro Ishiguro <kunihiro@zebra.org>
3129
3130 * ospf_asbr.c (ospf_external_info_lookup): Add explicit brace for
3131 avoid ambiguous else.
3132
3133 * ospf_flood.c (ospf_external_info_check): Likewise.
3134
31352000-06-05 Toshiaki Takada <takada@zebra.org>
3136
3137 * ospf_nsm.c (nsm_adj_ok): Fix bug of DR election.
3138
31392000-06-04 Toshiaki Takada <takada@zebra.org>
3140
3141 * ospf_zebra.c (ospf_default_information_originate),
3142 (no_ospf_default_information_originate): New DEFUN added.
3143
31442000-06-03 Toshiaki Takada <takada@zebra.org>
3145
3146 * ospf_lsa.h, ospf_asbr.h (external_info): Struct moved from
3147 ospf_lsa.h to ospf_asbr.h.
3148
3149 * ospf_lsa.c, ospf_asbr.c (ospf_external_info_add),
3150 (ospf_external_info_delete): Function moved from ospf_lsa.c
3151 to ospf_asbr.c.
3152
31532000-06-03 Toshiaki Takada <takada@zebra.org>
3154
3155 * ospf_flood.c (ospf_external_info_check): New function added.
3156 (ospf_process_self_orignated_lsa): Make sure to flush
3157 self-originated AS-external-LSA, when router reboot and no longer
3158 originate those AS-external-LSA.
3159
31602000-06-02 Toshiaki Takada <takada@zebra.org>
3161
3162 * ospf_network.c (ospf_serv_sock): Remove SO_DONTROUTE
3163 socket option.
3164
3165 * ospf_packet.c (ospf_write): Set MSG_DONTROUTE flag for
3166 unicast destination packets.
3167
31682000-06-02 Toshiaki Takada <takada@zebra.org>
3169
3170 * ospf_lsdb.c (new_lsdb_delete): Delete entry from LSDB only when
3171 specified LSA matches.
3172
31732000-06-02 Gleb Natapov <gleb@nbase.co.il>
3174
3175 * ospf_network.c (ospf_serv_sock): Set SO_DONTROUTE
3176 socket option.
3177
31782000-06-01 Akihiro Mizutani <mizutani@dml.com>
3179
3180 * ospf_dump.c: Replace string `Debugging functions\n' with DEBUG_STR.
3181 Replace string `OSPF information\n' with OSPF_STR.
3182
31832000-06-01 Toshiaki Takada <takada@zebra.org>
3184
3185 * ospf_lsdb.[ch]: Use new_lsdb struct for network-LSA instead of
3186 ospf_lsdb.
3187
31882000-06-01 Toshiaki Takada <takada@zebra.org>
3189
3190 * ospf_dump.c (config_debug_ospf_packet), (config_debug_ospf_event),
3191 (config_debug_ospf_ism), (config_debug_ospf_nsm),
3192 (config_debug_ospf_lsa), (config_debug_ospf_zebra),
3193 (term_debug_ospf_packet), (term_debug_ospf_event),
3194 (term_debug_ospf_ism), (term_debug_ospf_nsm),
3195 (term_debug_ospf_lsa), (term_debug_ospf_zebra): Repalce debug_ospf_*
3196 variable to use for debug option flags.
3197
3198 (debug_ospf_packet), (debug_ospf_ism), (debug_ospf_nsm),
3199 (debug_ospf_lsa), (debug_ospf_zebra): Set {config,term}_debug_*
3200 flags when vty->node is CONFIG_NODE, otherwise set only term_debug_*
3201 flags.
3202
3203 * ospf_dump.h (CONF_DEBUG_PACKET_ON), (CONF_DEBUG_PACKET_OFF),
3204 (TERM_DEBUG_PACKET_ON), (TERM_DEBUG_PACKET_OFF),
3205 (CONF_DEBUG_ON), (CONF_DEBUG_OFF), (IS_CONF_DEBUG_OSPF_PACKET),
3206 (IS_CONF_DEBUG_OSPF): New Macro added.
3207
32082000-05-31 Toshiaki Takada <takada@zebra.org>
3209
3210 * ospfd.c (clear_ip_ospf_neighbor): New DEFUN added.
3211 Currently this command is used for only debugging.
3212
3213 * ospf_nsm.c (nsm_change_status): Make sure thread cancellation
3214 for network-LSA when DR has no full neighbors.
3215
3216 * ospf_nsm.c (ospf_db_summary_clear): New function added.
3217
32182000-05-30 Toshiaki Takada <takada@zebra.org>
3219
3220 * ospf_lsdb.c (new_lsdb_insert): LSAs are always freed by
3221 maxage_lsa_remover when LSA is replaced.
3222
32232000-05-25 Gleb Natapov <gleb@nbase.co.il>
3224
3225 * ospf_flood.c (ospf_ls_retransmit_delete_nbr_all): Add argument
3226 `struct ospf_area' to remove LSA from Link State retransmission list
3227 of neighbor from only one Area.
3228
32292000-05-24 Michael Rozhavsky <mike@nbase.co.il>
3230
3231 * ospf_lsdb.c (ospf_lsdb_add): Preserve flags field when
3232 overriting old LSA with new LSA.
3233
32342000-05-24 Gleb Natapov <gleb@nbase.co.il>
3235
3236 * ospf_lsa.c (ospf_router_lsa_body_set): Fix bug of router-LSA
3237 size calculation.
3238
32392000-05-22 Michael Rozhavsky <mike@nbase.co.il>
3240
3241 * ospf_route.c (ospf_intra_add_stub):
3242 * ospf_spf.h (struct vertex): Use u_int32_t for distance (cost)
3243 value instead of u_int16_t.
3244
32452000-05-22 Axel Gerlach <agerlach@datus.datus.com>
3246
3247 * ospf_ia.c (ospf_ia_network_route): Fix bug of Inter-area route
3248 equal cost path calculation.
3249
32502000-05-21 Toshiaki Takada <takada@zebra.org>
3251
3252 * ospf_ase.c (ospf_ase_calculate_route_delete): New function added.
3253 Make sure, when rotuer route is deleted, related external routes
3254 are also deleted.
3255
32562000-05-20 Toshiaki Takada <takada@zebra.org>
3257
3258 * ospfd.c (ospf_interface_down): Make sure interface flag is disable
3259 and set fd to -1.
3260
32612000-05-16 Toshiaki Takada <takada@zebra.org>
3262
3263 * ospf_asbr.c (ospf_asbr_should_announce), (ospf_asbr_route_remove):
3264 Functions removed.
3265
3266 * ospfd.h (EXTERNAL_INFO): Macro added.
3267 Substitute `ospf_top->external_info[type]' with it.
3268
32692000-05-16 Toshiaki Takada <takada@zebra.org>
3270
3271 * ospf_lsa.c (ospf_rtrs_external_remove): New function added.
3272
32732000-05-14 Gleb Natapov <gleb@nbase.co.il>
3274
3275 * ospf_flood.c (ospf_ls_retransmit_delete_nbr_all)
3276 * ospf_lsdb.c (new_lsdb_insert)
3277 * ospf_packet.c (ospf_ls_ack): Fix database synchonization problem.
3278
32792000-05-14 Gleb Natapov <gleb@nbase.co.il>
3280
3281 * ospf_lsa.h (tv_adjust), (tv_ceil), (tv_floor), (int2tv),
3282 (tv_add), (tv_sub), (tv_cmp): Prototype definition added.
3283
3284 * ospf_nsm.h (ospf_db_summary_delete_all): Prototype definition added.
3285
32862000-05-13 Toshiaki Takada <takada@zebra.org>
3287
3288 * ospf_lsa.[ch] (ospf_lsa): struct timestamp type is changed from
3289 time_t to struct timeval.
3290 (tv_adjust), (tv_ceil), (tv_floor), (int2tv), (tv_add),
3291 (tv_sub), (tv_cmp): timeval utillity functions added.
3292
32932000-05-12 Toshiaki Takada <takada@zebra.org>
3294
3295 * ospf_lsa.[ch] (ospf_schedule_update_router_lsas): Delete function.
3296 Change to use macro OSPF_LSA_UPDATE_TIMER instead of using
3297 this function.
3298 router-LSA refresh timer related stuff is re-organized.
3299
33002000-05-10 Gleb Natapov <gleb@nbase.co.il>
3301
3302 * ospf_interface.c (ospf_vl_set_params):
3303 * ospf_packet.c (ospf_check_network_mask):
3304 * ospf_spf.[ch] (ospf_spf_next):
3305 Remove field address from `struct vertex', and search for peer
3306 address of virtual link in function `ospf_vl_set_params' instead.
3307
33082000-05-10 Gleb Natapov <gleb@nbase.co.il>
3309
3310 * ospf_packet.c (ospf_ls_upd): Fix some memory leak related LSA.
3311
33122000-05-08 Thomas Molkenbur <tmo@datus.com>
3313
3314 * ospf_packet.c (ospf_packet_dup): Replace ospf_steram_copy()
3315 with ospf_stream_dup() to fix memory leak.
3316
33172000-05-08 Michael Rozhavsky <mike@nbase.co.il>
3318
3319 * ospf_flood.c (ospf_flood_through_area): Fix the problem of
3320 LSA update without DROther.
3321
33222000-05-04 Gleb Natapov <gleb@nbase.co.il>
3323
3324 * ospf_spf.c (ospf_vertex_free): Fix memory leak of SPF calculation.
3325
33262000-05-03 Toshiaki Takada <takada@zebra.org>
3327
3328 * ospf_neighbor.c (ospf_db_summary_add): Use new_lsdb struct
3329 instead linked-list.
3330 (ospf_db_summary_count), (ospf_db_summary_isempty):
3331 New function added.
3332
3333 * ospf_lsa.c (ospf_rotuer_lsa): Re-arrange and divide functions.
3334
33352000-05-02 Gleb Natapov <gleb@nbase.co.il>
3336
3337 * ospf_lsdb.c (new_lsdb_cleanup): Fix memory leak. When LSDB are
3338 not needed any more, then free them.
3339
33402000-05-02 Toshiaki Takada <takada@zebra.org>
3341
3342 * ospfd.c (timers_spf), (no_timers_spf): New defun added.
3343 SPF calculation timers related stuff is rearranged.
3344
3345 * ospf_spf.c (ospf_spf_calculate_timer_add): Function removed.
3346 SPF timer is scheduled by SPF calculation delay and holdtime
3347 configuration variable.
3348
3349 * ospf_lsa.c (ospf_external_lsa_nexthop_get): Set AS-external-LSA's
3350 forwarding address when nexthop learned by other protocols is
3351 in the OSPF domain.
3352
3353 * ospf_zebra.c (ospf_redistribute_source_metric_type),
3354 (ospf_redistribute_source_type_metric): Re-arrange DEFUNs and
3355 ALIASes.
3356
33572000-05-01 Toshiaki Takada <takada@zebra.org>
3358
3359 * ospf_flood.c (ospf_ls_retransmit_count),
3360 (ospf_ls_retransmit_isempty): New function added.
3361
3362 (ospf_ls_retransmit_add), (ospf_ls_retransmit_delete),
3363 (ospf_ls_retransmit_clear), (ospf_ls_retransmit_lookup),
3364 (ospf_ls_retransmit_delete_all), (ospf_ls_retransmit_delete_nbr_all),
3365 (ospf_ls_retransmit_add_nbr_all): Replace these functions to use
3366 new_lsdb.
3367
33682000-04-29 Toshiaki Takada <takada@zebra.org>
3369
3370 * ospfd.c (no_network_area): Add check Area-ID whether specified
3371 Area-ID with prefix matches config.
3372
33732000-04-27 Toshiaki Takada <takada@zebra.org>
3374
3375 * ospf_lsa.c (ospf_maxage_lsa_remover): Fix problem of
3376 remaining withdrawn routes on zebra.
3377
33782000-04-25 Michael Rozhavsky <mike@nbase.co.il>
3379
3380 * ospf_nsm.c (nsm_kill_nbr), (nsm_ll_down), (nsm_change_status),
3381 (ospf_nsm_event): Fix network-LSA re-origination problem.
3382
33832000-04-24 Toshiaki Takada <takada@zebra.org>
3384
3385 * ospf_nsm.c (ospf_db_desc_timer): Fix bug of segmentation fault
3386 with DD retransmission.
3387
3388 * ospf_nsm.c (nsm_kill_nbr): Fix bug of re-origination when
3389 a neighbor disappears.
3390
33912000-04-23 Michael Rozhavsky <mike@nbase.co.il>
3392
3393 * ospf_abr.c (ospf_abr_announce_network_to_area): Fix bug of
3394 summary-LSAs reorigination. Correctly copy OSPF_LSA_APPROVED
3395 flag to new LSA. when summary-LSA is reoriginatd.
3396
3397 * ospf_flood.c (ospf_flood_through_area): Fix bug of flooding
3398 procedure. Change the condition of interface selection.
3399
34002000-04-21 Toshiaki Takada <takada@zebra.org>
3401
3402 * ospf_lsa.c (ospf_refresher_register_lsa): Fix bug of refresh never
3403 occurs.
3404
3405 * ospfd.c (show_ip_ospf_neighbor_id): New defun added.
3406 `show ip ospf neighbor' related commands are re-arranged.
3407
34082000-04-20 Toshiaki Takada <takada@zebra.org>
3409
3410 * ospf_dump.c (debug_ospf_zebra): New defun added.
3411 Suppress zebra related debug information.
3412
34132000-04-19 Toshiaki Takada <takada@zebra.org>
3414
3415 * ospf_zebra.c (ospf_distribute_list_update_timer),
3416 (ospf_distribute_list_update), (ospf_filter_update):
3417 New function added. Re-organize `distribute-list' router ospf
3418 command.
3419
34202000-04-13 Michael Rozhavsky <mike@nbase.co.il>
3421
3422 * ospf_packet.c (ospf_make_ls_upd): Add check for MAX_AGE.
3423
34242000-04-14 Michael Rozhavsky <mike@nbase.co.il>
3425
3426 * ospf_packet.c (ospf_make_ls_upd): Increment LS age by configured
3427 interface transmit_delay.
3428
34292000-04-14 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3430
3431 * ospf_interface.c (ip_ospf_cost), (no_ip_ospf_cost):
3432 Add to schedule router_lsa origination when the interface cost changes.
3433
34342000-04-12 Toshiaki Takada <takada@zebra.org>
3435
3436 * ospf_lsa.c (ospf_refresher_register_lsa),
3437 (ospf_refresher_unregister_lsa): Fix bug of core dumped.
3438
3439 * ospfd.c (no_router_ospf): Fix bug of core dumped.
3440
34412000-03-29 Toshiaki Takada <takada@zebra.org>
3442
3443 * ospf_nsm.c (nsm_oneway_received): Fix bug of MS flag unset.
3444
34452000-03-29 Michael Rozhavsky <mike@nbase.co.il>
3446
3447 * ospf_lsa.c (ospf_network_lsa):
3448 * ospf_nsm.c (ospf_nsm_event): Fix bug of Network-LSA originated
3449 in stub network.
3450
34512000-03-28 Toshiaki Takada <takada@zebra.org>
3452
3453 * ospf_nsm.c (nsm_bad_ls_req), (nsm_seq_number_mismatch),
3454 (nsm_oneway_received): Fix bug of NSM state flapping between
3455 ExStart and Exchange.
3456
34572000-03-28 Toshiaki Takada <takada@zebra.org>
3458
3459 * ospf_packet.h (strcut ospf_header): Fix the size of ospf_header,
3460 change u_int8_t to u_char.
3461
34622000-03-27 Toshiaki Takada <takada@zebra.org>
3463
3464 * ospf_lsa.c (ospf_lsa_checksum): Take care of BIGENDIAN architecture.
3465
34662000-03-27 Toshiaki Takada <takada@zebra.org>
3467
3468 * ospfd.c (ospf_interface_run): Make sure Address family matches.
3469
34702000-03-26 Love <lha@s3.kth.se>
3471
3472 * ospf_packet.c (ospf_write): Chack result of sendto().
3473
34742000-03-26 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3475
3476 * ospf_nsm.c (nsm_oneway_received): Fix bug of 1-WayReceived in NSM.
3477
34782000-03-23 Libor Pechacek <farco@clnet.cz>
3479
3480 * ospf_lsa.c (ospf_network_lsa)
3481 * ospf_lsdb.c (new_lsdb_insert): Fix bug of accessing to
3482 unallocated memory.
3483
34842000-03-23 Toshiaki Takada <takada@zebra.org>
3485
3486 * ospfd.c (ospf_config_write): Fix bug of duplicate line for
3487 `area A.B.C.D authentication'.
3488
34892000-03-22 Toshiaki Takada <takada@zebra.org>
3490
3491 * ospf_debug.c (debug_ospf_lsa), (no_debug_ospf_lsa): Defun added.
3492 Suppress all zlog related to LSAs with this config option.
3493
34942000-03-21 Kunihiro Ishiguro <kunihiro@zebra.org>
3495
3496 * ospf_nsm.c (ospf_nsm_event): Add check for NSM_InactivityTimer.
3497
34982000-03-21 Toshiaki Takada <takada@zebra.org>
3499
3500 * ospf_packet.c (ospf_ls_upd_timer), (ospf_ls_req):
3501 Fix bug of memory leak about linklist.
3502
3503 * ospf_flood.c (ospf_flood_through_area): Likewise.
3504
35052000-03-18 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3506
3507 * ospf_flood.c (ospf_ls_retransmit_lookup): Add checksum comparison
3508 to identify LSA uniquely. This fix routes lost.
3509
35102000-03-18 Toshiaki Takada <takada@zebra.org>
3511
3512 * ospf_ase.c (ospf_find_asbr_route): Add sanity check with router
3513 routing table.
3514
35152000-03-17 Alex Zinin <zinin@amt.ru>
3516
3517 * ospf_spf.[ch]: Bug fix.
3518 The 2nd stage of Dijkstra could consider one vertex
3519 more than once if there is more than one link
3520 between the routers, thus adding extra CPU overhead
3521 and extra next-hops.
3522 Fixed.
3523
35242000-03-15 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3525
3526 * ospf_nsm.c (nsm_inactivity_timer): Changed to call nsm_kill_nbr().
3527
35282000-03-14 Toshiaki Takada <takada@zebra.org>
3529
3530 * ospf_route.c (ospf_route_copy_nexthops): Fix bug of memory leak of
3531 ospf_path. Actually ignore merging ospf_route with completely same
3532 paths.
3533
35342000-03-12 Toshiaki Takada <takada@zebra.org>
3535
3536 * ospf_lsa.c (show_as_external_lsa_detail): fix bug of
3537 external route tag byte order.
3538
35392000-03-11 Toshiaki Takada <takada@zebra.org>
3540
3541 * ospf_lsdb.c (ospf_lsdb_insert): New function added.
3542
35432000-03-09 Toshiaki Takada <takada@zebra.org>
3544
3545 * ospf_lsa.c (ospf_external_lsa_install),
3546 (ospf_lsa_lookup), (show_ip_ospf_database_all),
3547 (show_ip_ospf_database_self_originate): Use struct new_lsdb for
3548 LSDB of AS-external-LSAs instead of ospf_lsdb.
3549
3550 * ospf_lsa.c (ospf_lsa_unique_id): New function added.
3551 Use for assigning Unique Link State ID instead of
3552 ospf_get_free_id_for_prefix().
3553
35542000-03-09 Toshiaki Takada <takada@zebra.org>
3555
3556 * ospf_ase.c (ospf_ase_calculate_timer): Fix bug of segmentation
3557 fault reported by George Bonser <george@siteROCK.com>.
3558
35592000-03-07 Libor Pechacek <farco@clnet.cz>
3560
3561 * ospfd.c (ospf_interface_down): Fix bug of segmentation fault.
3562
35632000-03-06 Toshiaki Takada <takada@zebra.org>
3564
3565 * ospf_route.c (ospf_route_cmp): Change meaning of return values.
3566
35672000-03-02 Alex Zinin <zinin@amt.ru>
3568 * ospfd.h, ospf_ia.h
3569 New Shortcut ABR code. Now area's flag can be configured
3570 with Default, Enable, and Disable values.
3571 More info will be in the new ver of I-D soon (see IETF web).
3572
35732000-02-25 Toshiaki Takada <takada@zebra.org>
3574
3575 * ospf_lsa.c (ospf_lsa_header_set), (ospf_external_lsa_body_set),
3576 (osfp_external_lsa_originate), (ospf_external_lsa_queue),
3577 (ospf_external_lsa_originate_from_queue): New function added.
3578 (ospf_external_lsa): Function removed.
3579
3580 * ospf_zebra.c (ospf_zebra_read_ipv4): Originate AS-external-LSA
3581 when listen a route from Zebra, instead creating external route.
3582
3583 * ospf_asbr.c (ospf_asbr_route_add_flood_lsa),
3584 (ospf_asbr_route_add_queue_lsa),
3585 (ospf_asbr_route_install_lsa), (ospf_asbr_route_add):
3586 Functions removed.
3587
3588 * ospf_ase.c (process_ase_lsa): Function will not be used.
3589 (ospf_ase_calculate), (ospf_ase_calculate_route_add),
3590 (ospf_ase_calculate_new_route), (ospf_ase_caluculate_asbr_route):
3591 process_ase_lsa () is separated to these functions.
3592
3593 OSPF AS-external-LSA origination is whole re-organized.
3594
35952000-02-18 Toshiaki Takada <takada@zebra.org>
3596
3597 * ospf_packet.c (ospf_ls_upd): Fix bug of OSPF LSA memory leak.
3598
3599 * ospf_asbr.c (ospf_asbr_route_add_flood_lsa),
3600 (ospf_asbr_route_add_queue_lsa): Fix bug of OSPF external route
3601 memory leak.
3602
36032000-02-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3604
3605 * ospf_asbr.c (ospf_asbr_route_install_lsa): Re-calculate LSA
3606 checksum after change Advertised Router field.
3607
36082000-02-09 Toshiaki Takada <takada@zebra.org>
3609
3610 * ospf_asbr.c (ospf_external_route_lookup): Add new function.
3611
36122000-02-08 Toshiaki Takada <takada@zebra.org>
3613
3614 * ospfd.c (ospf_router_id_get), (ospf_router_id_update),
3615 (ospf_router_id_update_timer): Router ID decision algorithm is changed.
3616 Router ID is chosen from all of eligible interface addresses even if
3617 it is not enable to OSPF.
3618
36192000-02-08 Toshiaki Takada <takada@zebra.org>
3620
3621 * ospf_asbr.c (ospf_asbr_route_add): Function divided to
3622 ospf_asbr_route_add_flood_lsa, ospf_asbr_route_add_queue_lsa and
3623 ospf_asbr_route_install_lsa. If Router-ID is not set, then LSA is
3624 waited to install to LSDB.
3625 `0.0.0.0 adv_router' AS-external-LSA origination bug was fixed.
3626
36272000-02-01 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3628
3629 * ospf_flood.c (ospf_ls_retransmit_lookup): Compare LS seqnum
3630 in the ACK before deleting.
3631
3632 * ospf_packet.c (ospf_hello): Reset the flags after a shutdown
3633 and no shutdown of the interface.
3634
36352000-01-31 Toshiaki Takada <takada@zebra.org>
3636
3637 * ospf_packet.c (ospf_ls_req): Send multiple Link State Update
3638 packets respond to a Link State Request packet.
3639
3640 * ospfd.c (show_ip_ospf_neighbor_detail_sub): Show thread state.
3641
3642 * ospf_interface.c (ospf_vl_new): Crash when backbone area
3643 is not configured and set virtual-link to no-backbone area,
3644 bug fixed.
3645
36462000-01-30 Kunihiro Ishiguro <kunihiro@zebra.org>
3647
3648 * ospf_neighbor.h (struct ospf_neighbor): Add pointer to last send
3649 LS Request LSA.
3650
3651 * ospf_packet.c (ospf_ls_upd): Comment out LS request list
3652 treatment. That should be done in OSPF flooding procedure.
3653
3654 * ospf_flood.c (ospf_flood_through_area): Enclose
3655 ospf_check_nbr_loding inside if-else close.
3656
36572000-01-31 Toshiaki Takada <takada@zebra.org>
3658
3659 * ospf_packet.c (ospf_make_ls_upd): Fix bug of #LSAs counting.
3660
36612000-01-29 Toshiaki Takada <takada@zebra.org>
3662
3663 * ospf_packet.c (ospf_make_md5_digest): Fix bug of md5 authentication.
3664
36652000-01-28 Toshiaki Takada <takada@zebra.org>
3666
3667 * ospfd.c (show_ip_ospf): Show Number of ASE-LSAs.
3668
36692000-01-27 Kunihiro Ishiguro <kunihiro@zebra.org>
3670
3671 * ospf_packet.c (ospf_make_db_desc): Don't use rm_list for
3672 removing LSA from nbr->db_summary.
3673
36742000-01-27 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3675
3676 * ospf_packet.c (ospf_ls_upd_send): Set AllSPFRouters to
3677 destination when the link is point-to-point.
3678 (ospf_ls_ack_send_delayed): Likewise.
3679
36802000-01-27 Kunihiro Ishiguro <kunihiro@zebra.org>
3681
3682 * ospf_flood.c (ospf_ls_request_delete_all): Fix bug of next
3683 pointer lookup after the node is freed.
3684
36852000-01-26 Kunihiro Ishiguro <kunihiro@zebra.org>
3686
3687 * ospf_asbr.c (ospf_asbr_route_add): Instead of scanning all AS
3688 external route, use ospf_top->external_self.
3689
36902000-01-27 Toshiaki Takada <takada@zebra.org>
3691
3692 * ospf_lsa.c (ospf_forward_address_get): New function added.
3693
3694 * ospf_asbr.c (ospf_asbr_check_lsas): Originate AS-external-LSA
3695 only when it should be replaced.
3696
36972000-01-25 Kunihiro Ishiguro <kunihiro@zebra.org>
3698
3699 * ospf_flood.c (ospf_ls_retransmit_clear): Delete list node.
3700
3701 * ospf_lsa.c (ospf_lsa_free): Reduce logging message using
3702 ospf_zlog value.
3703
3704 * ospf_ism.c (ism_change_status): Fix bug of DR -> non DR status
3705 change. Self originated LSA is freed but not deleted from lsdb.
3706
37072000-01-24 Kunihiro Ishiguro <kunihiro@zebra.org>
3708
3709 * ospf_ism.c (ism_interface_down): Don't use router_id for
3710 detecting self neighbor structure. Instead of that compare
3711 pointer itself.
3712
3713 * ospf_neighbor.c (ospf_nbr_free): Cancel all timer when neighbor
3714 is deleted.
3715 (ospf_nbr_free): Free last send packet.
3716
3717 * ospf_neighbor.h (struct ospf_neighbor): Remove host strucutre.
3718 Instead of that src is introduced.
3719
3720 * ospf_nsm.h: Enclose macro defenition with do {} while (0).
3721
37222000-01-17 Kunihiro Ishiguro <kunihiro@zebra.org>
3723
3724 * ospfd.c: Change part of passive interface implementation. For
3725 passive interface just disabling sending/receiving Hello on the
3726 interface.
3727
37282000-01-16 Kai Bankett <kai.bankett@vew-telnet.net>
3729
3730 * ospf_interface.h (OSPF_IF_PASSIVE): Add passive flag.
3731 * ospf_interface.c (ospf_if_lookup_by_name): Add new function.
3732 * ospf_lsa.c (ospf_router_lsa): Skip passive interface.
3733 * ospfd.c (passive_interface): New command passive-interface is
3734 added.
3735 (ospf_config_write): Print passive interface.
3736
37372000-01-15 Toshiaki Takada <takada@zebra.org>
3738
3739 * ospf_interface.h (crypt_key): New struct added to store
3740 multiple cryptographic autheitication keys.
3741 (ospf_interface): struct changed.
3742
3743 * ospf_interface.c: ospf_crypt_key_new, ospf_crypt_key_add,
3744 ospf_crypt_key_lookup, ospf_crypt_key_delete: new functions added.
3745
3746 * ospf_packet.c (ip_ospf_message_digest_key): Changed to store
3747 multiple cryptographic authentication keys.
3748
37492000-01-14 Toshiaki Takada <takada@zebra.org>
3750
3751 * ospf_interface.c: DEFUN (if_ospf_*) commands changed name to
3752 ip_ospf_* ().
3753 Old notation `ospf *' still remains backward compatibility.
3754
37551999-12-29 Alex Zinin <zinin@amt.ru>
3756 * ospf_lsa.c: ospf_lsa_more_recent() bug fix
3757 * ospf_nsm.c, ospf_packet.c: remove nbr data struct when
3758 int goes down, also check DD flags correctly (bug fix)
3759
37601999-12-28 Alex Zinin <zinin@amt.ru>
3761 * "redistribute <source> metric-type (1|2) metric <XXX>" added
3762
37631999-12-23 Alex Zinin <zinin@amt.ru>
3764 * added RFC1583Compatibility flag
3765 * added dynamic interface up/down functionality
3766
37671999-11-19 Toshiaki Takada <takada@zebra.org>
3768
3769 * ospf_neighbor.h (struct ospf_neighbor): Add member state_change
3770 for NSM state change statistics.
3771
37721999-11-19 Toshiaki Takada <takada@zebra.org>
3773
3774 * ospfd.c (show_ip_ospf_neighbor_detail),
3775 (show_ip_ospf_neighbor_int_detail): DEFUN Added.
3776
37771999-11-14 Kunihiro Ishiguro <kunihiro@zebra.org>
3778
3779 * ospf_asbr.c (ospf_asbr_check_lsas): Add check of
3780 lsa->refresh_list.
3781
37821999-11-11 Toshiaki Takada <takada@zebra.org>
3783
3784 * ospf_ia.[ch] (OSPF_EXAMINE_SUMMARIES_ALL): Macro added.
3785 This macro is expanded to ospf_examine_summaries ()
3786 for SUMMARY_LSA and SUMMARY_LSA_ASBR.
3787 (OSPF_EXAMINE_TRANSIT_SUMMARIES_ALL): Macro added.
3788 This macro is expanded to ospf_examine_transit_summaries ()
3789 for SUMMARY_LSA and SUMMARY_LSA_ASBR.
3790
37911999-11-11 Toshiaki Takada <takada@zebra.org>
3792
3793 * ospf_lsa.[ch] (ospf_find_self_summary_lsa_by_prefix): Changed to
3794 macro OSPF_SUMMARY_LSA_SELF_FIND_BY_PREFIX.
3795 (ospf_find_self_summary_asbr_lsa_by_prefix): Changed to
3796 macro OSPF_SUMMARY_ASBR_LSA_SELF_FIND_BY_PREFIX.
3797 (ospf_find_self_external_lsa_by_prefix): Changed to
3798 macro OSPF_EXTERNAL_LSA_SELF_FIND_BY_PREFIX.
3799
38001999-11-11 Toshiaki Takada <takada@zebra.org>
3801
3802 * ospfd.c (ospf_abr_type): ospf_abr_type_cisco, ospf_abr_type_ibm,
3803 ospf_abr_type_shortcut and ospf_abr_type_standard DEFUNs are
3804 combined.
3805 * ospfd.c (no_ospf_abr_type): no_ospf_abr_type_cisco,
3806 no_ospf_abr_type_ibm and no_ospf_abr_type_shortcut DEFUNS are
3807 combined.
3808
38091999-11-10 Toshiaki Takada <takada@zebra.org>
3810
3811 * ospf_route.c (ospf_lookup_int_by_prefix): Move function to
3812 ospf_interface.c and change name to ospf_if_lookup_by_prefix ().
3813
38141999-11-01 Alex Zinin <zinin@amt.ru>
3815 * ospf_packet.c
3816 some correction to LSU processing
3817
3818 * ospf_lsa.c ospfd.h
3819 randomize initial LSA refreshment interval
3820 and limit the size of LSA-group to 10
3821 to let randomization work more effectively.
3822
38231999-10-31 Alex Zinin <zinin@amt.ru>
3824 * ospf_interface.c
3825 cancel t_network_lsa_self
3826 when freeing int structure
3827
3828 * ospf_abr.c ospf_asbr.c ospf_flood.c ospf_lsa.c
3829 ospf_lsa.h ospf_lsdb.h ospfd.c ospfd.h
3830
3831 Summary and ASE LSA refreshment functions
3832 added---LSA refreshment is paced to 70 LSAs
3833 per sec to avoid link overflow. Refreshment events
3834 are further randomized within a 10 sec interval
3835 to avoid syncing.
3836
3837 Also the sigfault of memcmp() in ospf_lsa_is_different()
3838 is fixed.
3839
38401999-10-30 Alex Zinin <zinin@amt.ru>
3841 * ospf_nsm.c
3842 Fix the bug where MAX_AGE LSAs
3843 are included into the DB summary.
3844
3845 * ospf_interface.c
3846 allocate 2*MTU input buffer instead of just MTU
3847 for the cases when the other router mistakenly
3848 sends larger packets thus causing fragmentation, etc.
3849
3850 * ospf_nsm.c
3851 in nsm_reset_nbr() lists should be freed
3852 not when they are empty.
3853
38541999-10-29 Kunihiro Ishiguro <kunihiro@zebra.org>
3855
3856 * ospf_zebra.c (ospf_acl_hook): Move OSPF_IS_ASBR and OSPF_IS_ABR
3857 check inside of if (ospf_top).
3858
38591999-10-29 Alex Zinin <zinin@amt.ru>
3860 * ospf_lsa.c ospf_lsdb.c :
3861 add assertion in lsa and lsa->data alloc functions,
3862 as well as in lsdb_add for new->data
3863
3864 * ospf_lsdb.c: free hash table correctly
3865
38661999-10-28 John Capo <jc@irbs.com>
3867
3868 * ospf_packet.h (OSPF_PACKET_MAX): Correct MAX packet length
3869 calculation
3870
38711999-10-27 Kunihiro Ishiguro <kunihiro@zebra.org>
3872
3873 * OSPF-TRAP-MIB.txt: New file added. Edited version of RFC1850.
3874
3875 * OSPF-MIB.txt: New file added. Edited version of RFC1850.
3876
38771999-10-27 Alex Zinin <zinin@amt.ru>
3878 * ospfd, ospf_zebra, ospf_abr
3879 "area import-list" command is added.
3880 This command allows to filter the inter-area routes
3881 injected into an area. Access list hook function
3882 extended to invalidate area exp/imp lists.
3883
38841999-10-25 Yoshinobu Inoue <shin@nd.net.fujitsu.co.jp>
3885
3886 * ospfd.c (ospf_interface_run): Enable to detect P2P network
3887 on an OSPF interface.
3888
38891999-10-19 Jordan Mendelson <jordy@wserv.com>
3890
3891 * ospf_lsdb.c (ospf_lsdb_add): Fix bug of crash
3892 in ospf_ls_retransmit_lookup ().
3893
38941999-10-19 Vladimir B. Grebenschikov <vova@express.ru>
3895
3896 * ospf_route.c: Workaround about installation of OSPF routes into
3897 the zebra daemon. Add checking of existance routes. Free
3898 ospf_top->old_table if it exists.
3899
39001999-10-15 Jordan Mendelson <jordy@wserv.com>
3901
3902 * Add support for MD5 authentication.
3903
39041999-10-12 Alex Zinin <zinin@amt.ru>
3905 * ospfd.c, ospfd.h, ospf_abr.c:
3906 a new command "area export-list" was added, it allows
3907 the admin. to control which intra-area routes are
3908 announced to other areas by the ABR
3909
39101999-10-12 Alex Zinin <zinin@amt.ru>
3911 * ospf_asbr.c (ospf_asbr_check_lsas): Fix bug of coredump
3912 when "no redistribute" is used after a distribute list
3913 denying some networks was used
3914
39151999-10-05 Toshiaki Takada <takada@zebra.org>
3916
3917 * ospf_route.c (ospf_path_dup): New function added.
3918
39191999-10-05 Toshiaki Takada <takada@zebra.org>
3920
3921 * ospf_interface.[ch]: Some of VL related funciton name changed.
3922
39231999-09-27 Alex Zinin <zinin@amt.ru>
3924
3925 * ospf_zebra.c: Distribute-list functionality added
3926
39271999-09-27 Toshiaki Takada <takada@zebra.org>
3928
3929 * ospfd.c (show_ip_ospf): Fix bug of segmentation fault when no ospf
3930 instance exists.
3931
39321999-09-25 Kunihiro Ishiguro <kunihiro@zebra.org>
3933
3934 * ospfd.c (ospf_interface_down): Fix bug of misusing nextnode()
3935 instead of node->next. Reported by Hiroki Ishibashi
3936 <ishibasi@dcd.abk.nec.co.jp>.
3937
3938 * ospf_route.c (show_ip_ospf_route): Add check for ospf is enabled
3939 or not.
3940
39411999-09-23 Alex Zinin <zinin@amt.ru>
3942
3943 * stub area support added
3944
39451999-09-23 Alex Zinin <zinin@amt.ru>
3946
3947 * fwd_addr in ASE-LSAs is now set correctly
3948 * ASE routing changed to check the fwd_addr
3949 and skip the route if the addr points to one
3950 of our interfaces to avoid loops.
3951
39521999-09-22 Alex Zinin <zinin@amt.ru>
3953
3954 * ospf_interface:
3955 ospf_vls_in_area() added, it returns
3956 the number of VLs configured through the area
3957
3958 * ospf_interface.c ospf_lsa.c ospf_lsdb.c ospfd.c
3959 honor correct mem alloc
3960
39611999-09-22 Alex Zinin <zinin@amt.ru>
3962
3963 * memory.[ch]:
3964 Some OSPF mem types added,
3965 plus more info in "show mem"
3966
39671999-09-21 Alex Zinin <zinin@amt.ru>
3968
3969 * ospfd.c:
3970 "area range substitute" added.
3971 It can be used on NAT-enabled (IP-masquarade)
3972 routers to announce private networks
3973 from an area as public ones into the outside
3974 world (not in the RFC, btw :)
3975
39761999-09-21 Alex Zinin <zinin@amt.ru>
3977
3978 * ospfd.c:
3979 "area range suppress" added.
3980 This command allows to instruct the router
3981 to be silent about specific ranges, i.e.,
3982 it is a method of route filtering on area
3983 borders
3984
39851999-09-21 Alex Zinin <zinin@amt.ru>
3986
3987 * ospfd.c VLs removed when "no network area" executed
3988
39891999-09-20 Alex Zinin <zinin@amt.ru>
3990
3991 * ospf_ase.c bug fix for not-zero fwd_addr
3992 and directly connected routes.
3993
39941999-09-20 Yon Uriarte <yon@plannet.de>
3995
3996 * ospf_packet.c (ospf_make_ls_req): Introduce delta value for
3997 checking the length of OSPF packet exceeds MTU or not.
3998
3999 * ospf_lsa.c (ospf_lsa_different): Apply ntohs for checking
4000 l1->data->length.
4001
40021999-09-18 Alex Zinin <zinin@amt.ru>
4003
4004 * ospf_lsa.c bug fix for ospf_network_lsa() to
4005 include itself into the RID list
4006
40071999-09-10 Alex Zinin <zinin@amt.ru>
4008
4009 * Alternative ABR behaviors IBM/Cisco/Shortcut
4010 implemented
4011
40121999-09-10 Alex Zinin <zinin@amt.ru>
4013
4014 * router and network-LSA origination
4015 changed to honor MinLSInterval
4016
40171999-09-08 Alex Zinin <zinin@amt.ru>
4018
4019 * modified ABR behavior to honor VLs and transit
4020 areas
4021
40221999-09-07 Alex Zinin <zinin@amt.ru>
4023
4024 * completed VL functionality
4025
40261999-09-06 Kunihiro Ishiguro <kunihiro@zebra.org>
4027
4028 * ospf_asbr.c: New file.
4029 ospf_asbr.h: New file.
4030
4031 * ospf_zebra.c (ospf_redistribute_connected): Add redistribute
4032 related stuff.
4033
40341999-09-05 Kunihiro Ishiguro <kunihiro@zebra.org>
4035
4036 * ospfd.h (OSPF_FLAG_VIRTUAL_LINK): Change OSPF_FLAG_VEND to
4037 OSPF_FLAG_VIRTUAL_LINK for comprehensiveness.
4038
40391999-09-03 Kunihiro Ishiguro <kunihiro@zebra.org>
4040
4041 * ospf_spf.c (ospf_spf_register): Change name from
4042 ospf_spf_route_add() to ospf_spf_register().
4043 Include "ospfd/ospf_abr.h" for ospf_abr_task() prototype.
4044
40451999-09-02 Kunihiro Ishiguro <kunihiro@zebra.org>
4046
4047 * ospf_lsa.c (ospf_external_lsa_install): Change to update
4048 lsa->data rather than install new one, when same id lsa is already
4049 installed.
4050
40511999-09-01 Kunihiro Ishiguro <kunihiro@zebra.org>
4052
4053 * ospf_lsa.c (ospf_router_lsa_install): Return lsa value.
4054 (ospf_network_lsa_install): Likewise.
4055 (ospf_summary_lsa_install): Likewise.
4056 (ospf_summary_asbr_lsa_install): Likewise.
4057 (ospf_external_lsa_install): Likewise.
4058
4059 * ospf_spf.c (ospf_spf_calculate): Comment out debug function
4060 ospf_rtrs_print().
4061
40621999-08-31 Kunihiro Ishiguro <kunihiro@zebra.org>
4063
4064 * ospf_spf.c (ospf_rtrs_free): Add ospf_spf_calculate() for
4065 freeing rtrs.
4066
40671999-08-31 Toshiaki Takada <takada@zebra.org>
4068
4069 * ospf_lsa.c (show_ip_ospf_database_summary),
4070 (show_ip_ospf_database_summary_asbr),
4071 (show_ip_ospf_database_external): New function added.
4072 `show ip ospf database summary',
4073 `show ip ospf database asbr-summary'
4074 `show ip ospf database external' command can be used.
4075
4076 * ospf_lsa.c (ospf_lsa_count_table): New function added.
4077 (show_ip_ospf_database_all): show nothing if a type of LSA
4078 does not exist.
4079
40801999-08-31 Kunihiro Ishiguro <kunihiro@zebra.org>
4081
4082 * ospf_lsa.c (ospf_maxage_lsa_remover): Preserve next pointer when
4083 the node is deleted.
4084
40851999-08-31 Toshiaki Takada <takada@zebra.org>
4086
4087 * ospf_flood.c (ospf_ls_retransmit_lookup): change to return
4088 struct ospf_lsa *.
4089 (ospf_ls_request_new), (ospf_ls_request_free),
4090 (ospf_ls_request_add), (ospf_ls_request_delete),
4091 (ospf_ls_request_delete_all), (ospf_ls_request_lookup):
4092 New function added.
4093
4094 * ospf_packet.c (ospf_ls_upd_send_lsa): New function added.
4095
4096 * ospf_lsa.h (LS_AGE): Slightly change macro definition.
4097
4098 * ospf_lsa.c (ospf_lsa_more_recent), (ospf_lsa_diffrent):
4099 Use LS_AGE macro.
4100
41011999-08-30 Alex Zinin <zinin@amt.ru>
4102
4103 * ospfd.c
4104 fix a bug with area range config write
4105 added "show ip ospf" command, it will be enhanced later on
4106
41071999-08-30 Alex Zinin <zinin@amt.ru>
4108
4109 * ospf_lsa.c
4110 updated ospf_router_lsa() to honor flags (B-bit)
4111
41121999-08-30 Alex Zinin <zinin@amt.ru>
4113
4114 * ospf_abr.c
4115 wrote major functions implementing ABR activity
4116
41171999-08-30 Alex Zinin <zinin@amt.ru>
4118
4119 * ospf_ia.c ospf_route.c ospf_route.h
4120 fixed the bug with ospf_route.origin field.
4121 Now it holds pointer to lsa_header
4122
41231999-08-30 Alex Zinin <zinin@amt.ru>
4124
4125 * ospf_flood.c ospf_flood.h:
4126 transformed ospf_flood_if_select into ospf_flood_through_area()
4127 added new ospf_flood_if_select() and ospf_flood_through_as()
4128
41291999-08-30 Toshiaki Takada <takada@zebra.org>
4130
4131 * ospf_flood.[ch]: New file added.
4132
4133 * ospf_packet.c (ospf_lsa_flooding),
4134 (ospf_lsa_flooding_select_if): functions move to ospf_flood.c
4135
4136 * ospf_neighbor.c (ospf_put_lsa_on_retransm_list),
4137 (ospf_remove_lsa_from_retransm_list),
4138 (ospf_nbr_remove_all_lsas_from_retransm_list),
4139 (ospf_lsa_remove_from_ls_retransmit):
4140 (ospf_lsa_retransmit): functions move to
4141 ospf_flood.c, and change function's name:
4142
4143 ospf_put_lsa_on_retransm_list ()
4144 -> ospf_ls_retransmit_add ()
4145 ospf_remove_lsa_from_retransm_list ()
4146 -> ospf_ls_retransmit_delete ()
4147 ospf_nbr_remove_all_lsas_from_retransm_list ()
4148 -> ospf_ls_retransmit_clear ()
4149 ospf_lsa_remove_from_ls_retransmit ()
4150 -> ospf_ls_retransmit_delete_nbr_all ()
4151 ospf_lsa_retransmit ()
4152 -> ospf_ls_retransmit_add_nbr_all ()
4153
4154 * ospf_lsa.c (ospf_lsa_lookup_from_list): function move to
4155 ospf_flood.c, and change name to ospf_ls_retransmit_lookup ().
4156
41571999-08-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4158
4159 * ospf_neighbor.c (ospf_nbr_lookup_by_addr): Use
4160 route_node_lookup() instead of route_node_get().
4161
4162 * ospf_packet.c (ospf_ls_upd): Temporary comment out (6) check.
4163
41641999-08-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4165
4166 * ospf_route.c (ospf_lookup_int_by_prefix): Add check of
4167 oi->address.
4168
41691999-08-29 Alex Zinin <zinin@amt.ru>
4170 * ospf_lsa.c
4171 MaxAge LSA deletion functions added.
4172
41731999-08-29 Alex Zinin <zinin@amt.ru>
4174 * ospf_neighbor.c
4175 ospf_nbr_lookup_by_addr(): added route_unlock_node()
4176 when function returns NULL if (rn->info == NULL)
4177
41781999-08-29 Alex Zinin <zinin@amt.ru>
4179 * ospfd.c
4180 added a hack for area range deletion
4181
41821999-08-29 Alex Zinin <zinin@amt.ru>
4183 * ospf_lsa.h
4184 included lsdb field into struct ospf_lsa, to find
4185 LSDB easier when removing MaxAge LSAs.
4186
41871999-08-29 Alex Zinin <zinin@amt.ru>
4188 * ospf_lsa.c ospf_neighbor.c ospf_nsm.c
4189 ospf_packet.c changed to honor new retransmit list
4190 management functions
4191
41921999-08-29 Alex Zinin <zinin@amt.ru>
4193 * ospf_neighbor.c , .h added new retransmit list functions.
4194
41951999-08-29 Alex Zinin <zinin@amt.ru>
4196 * Makefile.in
4197 added ospf_ase, ospf_abr, ospf_ia
4198
41991999-08-29 Alex Zinin <zinin@amt.ru>
4200 * ospf_spf.c:
4201 - changed ospf_next_hop_calculation() to include interface
4202 and nexthop addr for directly connected routers---more informative
4203 and solves problem with route installation into the kernel
4204 - changed ospf_nexthop_out_if_addr() to support routers, not only
4205 transit networks
4206 - added ospf_process_stubs();
4207
42081999-08-29 Alex Zinin <zinin@amt.ru>
4209 * ospf_lsa.c:
4210 - changed ospf_router_lsa() to provide correct links
4211 for p-t-p interfaces;
4212 - changed ospf_summary_lsa_install() to support table
4213 of self-originated summary-LSAs;
4214 - added ospf_summary_asbr_lsa_install() and ospf_external_lsa_install()
4215 - changed ospf_lsa_install() accordingly
4216 - changed show_ip_ospf_database_router_links() to support p-t-p
4217
42181999-08-29 Kunihiro Ishiguro <kunihiro@zebra.org>
4219
4220 * ospf_packet.c (ospf_make_db_desc): Only master can clear more
4221 flag.
4222
42231999-08-29 Kunihiro Ishiguro <kunihiro@zebra.org>
4224
4225 * ospf_packet.c (ospf_read): Add check of IP src address.
4226
42271999-08-28 Alex Zinin <zinin@amt.ru>
4228 * ospf_neighbor.h
4229 added ospf_nbr_lookup_by_routerid()
4230
42311999-08-28 Alex Zinin <zinin@amt.ru>
4232 * ospfd.h
4233 added ABR/ASBR flag definitions and fields;
4234 added iflist field to area structure;
4235 summary_lsa_self and summary_lsa_asbr_self are changed
4236 to be route tables;
4237 added ranges field---configured area ranges;
4238 A separate Routers RT added;
4239 area range config commands and config write added
4240
4241
42421999-08-28 Alex Zinin <zinin@amt.ru>
4243 * ospf_route.c :
4244 ospf_route_free()--added code to free the list of paths;
4245 The following functions added:
4246 ospf_intra_add_router();
4247 ospf_intra_add_transit();
4248 ospf_intra_add_stub();
4249 the last function uses new ospf_int_lookup_by_prefix();
4250 show_ip_ospf_route_cmd()--changed to support new RT structure;
4251 added ospf_cmp_routes()--general route comparision function;
4252 added ospf_route_copy_nexthops() and ospf_route_copy_nexthops_from_vertex()
4253 they are used in ASE and IA routing;
4254 added ospf_subst_route() and ospf_add_route();
4255
42561999-08-28 Alex Zinin <zinin@amt.ru>
4257 * ospf_route.h :
4258 changed struct ospf_path to include output interface,
4259 changed struct ospf_route to support IA and ASE routing.
4260 added prototypes of the function used in IA and ASE modules.
4261
42621999-08-28 Alex Zinin <zinin@amt.ru>
4263 * ospf_lsa.h ospf_lsa.c :
4264 added ospf_my_lsa(), an interface independent version of
4265 ospf_lsa_is_self_originated(), it will be used in ASE and IA-routing.
4266
42671999-08-27 Kunihiro Ishiguro <kunihiro@zebra.org>
4268
4269 * ospf_interface.c (interface_config_write): Add check for
4270 oi->nbr_self.
4271
42721999-08-25 Toshiaki Takada <takada@zebra.org>
4273
4274 * ospf_lsa.c (ospf_lsa_dup): New function added.
4275
4276 * ospf_packet.c (ospf_write), (ospf_read): Print send/recv
4277 interface in debug message.
4278
42791999-08-25 Toshiaki Takada <takada@zebra.org>
4280
4281 * ospf_packet.c (ospf_ls_ack_send): The name is changed from
4282 `ospf_ls_ack_send'.
4283 (ospf_ls_ack_send_delayed) (ospf_ls_ack_timer): New function added.
4284 Delayed Link State Acknowledgment is scheduled by timer.
4285
42861999-08-25 Alex Zinin <zinin@amt.ru>
4287
4288 * ospf_lsa.c (ospf_router_lsa): Incorrectly included link to
4289 a stub network instead of link to a transit network into
4290 originated router-LSA, bug fixed.
4291
42921999-08-24 Toshiaki Takada <takada@zebra.org>
4293
4294 * ospfd.c (ospf_update_router_id): New function added.
4295
4296 * ospf_network.c (ospf_write): Create new socket per transmission.
4297 And select outgoing interface whether dst is unicast or multicast.
4298
4299 * ospf_packet.c: LSA flooding will work.
4300
43011999-08-24 VOP <vop@unity.net>
4302
4303 * ospf_route.c: Include "sockunion.h"
4304
43051999-08-24 Kunihiro Ishiguro <kunihiro@zebra.org>
4306
4307 * ospf_network.c (ospf_serv_sock_init): Enclose
4308 IPTOS_PREC_INTERNETCONTROL setting with #ifdef for OS which does
4309 not have the definition.
4310
43111999-08-23 Toshiaki Takada <takada@zebra.org>
4312
4313 * ospf_packet.c: Fix bug of DD processing.
4314
43151999-08-18 Toshiaki Takada <takada@zebra.org>
4316
4317 * ospf_lsa.c (show_ip_ospf_database): Show actual `LS age'.
4318
43191999-08-17 Toshiaki Takada <takada@zebra.org>
4320
4321 * ospf_lsa.h (OSPF_MAX_LSA): The value of OSPF_MAX_LSA is
4322 corrected. The bug of `mes_lookup' is fixed.
4323 This had been reported by Poul-Henning Kamp <phk@freebsd.org>.
4324
4325 * ospf_lsa.c (ospf_router_lsa_install): The name is changed from
4326 `ospf_add_router_lsa'.
4327 (ospf_network_lsa_install): The name is changed from
4328 `ospf_add_network_lsa'.
4329
4330 * ospf_interface.h (ospf_interface): Add member `nbr_self'.
4331
4332 * ospf_interface.c (ospf_if_is_enable): New function added.
4333
43341999-08-16 Toshiaki Takada <takada@zebra.org>
4335
4336 * ospf_lsa.h (struct lsa_header): The name is changed from
4337 `struct ospf_lsa'.
4338 (struct ospf_lsa): New struct added to control each LSA's aging
4339 and timers.
4340
4341 * ospf_lsa.c (ospf_lsa_data_free): The name is change from
4342 `ospf_lsa_free'.
4343 (ospf_lsa_data_new), (ospf_lsa_new), (ospf_lsa_free),
4344 (ospf_lsa_different), (ospf_lsa_install): New function added.
4345
4346 * ospf_packet.c (ospf_ls_upd_list_lsa): New function added.
4347
43481999-08-12 Toshiaki Takada <takada@zebra.org>
4349
4350 * ospf_nsm.c (nsm_reset_nbr): New function added.
4351 KillNbr and LLDown neighbor event call this function.
4352
43531999-08-10 Toshiaki Takada <takada@zebra.org>
4354
4355 * ospf_packet.c (ospf_ls_retransmit)
4356 (ospf_ls_upd_timer): New function added.
4357 Set retransmission timer for Link State Update.
4358
43591999-07-29 Toshiaki Takada <takada@zebra.org>
4360
4361 * ospf_ism.c (ospf_dr_election): Fix bug of DR election.
4362
43631999-07-28 Toshiaki Takada <takada@zebra.org>
4364
4365 * ospf_network.c (ospf_serv_sock_init): Set IP precedence field
4366 with IPTOS_PREC_INTERNET_CONTROL.
4367
4368 * ospf_nsm.c (nsm_change_status): Schedule NeighborChange event
4369 if NSM status change.
4370
4371 * ospf_packet.c (ospf_make_hello): Never include a neighbor in
4372 Hello packet, when the neighbor goes down.
4373
43741999-07-26 Kunihiro Ishiguro <kunihiro@zebra.org>
4375
4376 * Makefile.am (noinst_HEADERS): Add ospf_route.h.
4377
4378 * ospf_route.c (show_ip_ospf_route): Add `show ip ospf route'
4379 command.
4380
43811999-07-25 Toshiaki Takada <takada@zebra.org>
4382
4383 * ospf_lsa.c (ospf_router_lsa): Fix bug of LS sequence number
4384 assignement.
4385
43861999-07-25 Kunihiro Ishiguro <kunihiro@zebra.org>
4387
4388 * ospf_route.c (ospf_route_table_free): New function added.
4389
4390 * ospf_spf.c (ospf_spf_next): Free vertex w when cw's and w's
4391 distance is same.
4392
4393 * ospfd.h (struct ospf): Add old_table.
4394
4395 * ospf_main.c (sighup): Call of log_rotate () removed.
4396
4397 * ospf_lsa.c (ospf_lsa_is_self_originated): Fix bug of checking
4398 area->lsa as self LSA. This should be area->lsa_self.
4399
44001999-07-24 Kunihiro Ishiguro <kunihiro@zebra.org>
4401
4402 * ospf_zebra.c (ospf_zebra_add): ospf_zebra_add
4403 (),ospf_zebra_delete () added.
4404
4405 * ospf_spf.c (ospf_spf_calculate): Call ospf_intra_route_add ().
4406
44071999-07-24 Toshiaki Takada <takada@zebra.org>
4408
4409 * ospf_lsa.c: Change LS sequence number treatment.
4410 (ospf_lsa_is_self_originated): New function added.
4411 (show_ip_ospf_database_self_originated): New DEFUN added.
4412
44131999-07-23 Kunihiro Ishiguro <kunihiro@zebra.org>
4414
4415 * ospf_interface.c (ospf_if_lookup_by_addr): Add loopback check.
4416
44171999-07-22 Toshiaki Takada <takada@zebra.org>
4418
4419 * ospf_spf.c (ospf_nexthop_new), (ospf_nexthop_free),
4420 (ospf_nexthop_dup): function added.
4421 (ospf_nexthop_calculation): function changed.
4422
4423 * ospf_interface.c (ospf_if_lookup_by_addr): function added.
4424
44251999-07-21 Toshiaki Takada <takada@zebra.org>
4426
4427 * ospf_spf.c (ospf_spf_closest_vertex): function removed.
4428
44291999-07-21 Kunihiro Ishiguro <kunihiro@zebra.org>
4430
4431 * ospf_spf.c (ospf_spf_next): Apply ntohs for fetching metric.
4432
44331999-07-21 Toshiaki Takada <takada@zebra.org>
4434
4435 * ospf_neighbor.c (ospf_nbr_lookup_by_router_id): fundtion removed.
4436
4437 * ospf_lsa.c (show_ip_ospf_database_router): describe each
4438 connected link.
4439
44401999-07-21 Kunihiro Ishiguro <kunihiro@zebra.org>
4441
4442 * ospf_spf.c (ospf_spf_next): V is router LSA or network LSA so
4443 change behavior according to LSA type.
4444 (ospf_lsa_has_link): Link check function is added.
4445
44461999-07-20 Kunihiro Ishiguro <kunihiro@zebra.org>
4447
4448 * ospf_spf.c (ospf_spf_calculate_schedule): Add new function for
4449 SPF calcultion schedule addtition.
4450 (ospf_spf_calculate_timer_add): Rough 30 sec interval SPF calc
4451 timer is added.
4452 (ospf_spf_next_router): Delete ospf_spf_next_network ().
4453
4454 * ospf_lsa.c (show_ip_ospf_database_all): Network-LSA display
4455 header typo correction. Display of router LSA's #link added.
4456
44571999-07-19 Toshiaki Takada <takada@zebra.org>
4458
4459 * ospf_packet.c (ospf_check_network_mask): Added new function for
4460 receiving Raw IP packet on an appropriate interface.
4461
44621999-07-16 Toshiaki Takada <takada@zebra.org>
4463
4464 * ospfd.c (ospf_router_id): new DEFUN added.
4465
44661999-07-15 Toshiaki Takada <takada@zebra.org>
4467
4468 * ospf_spf.c (ospf_spf_init), (ospf_spf_free),
4469 (ospf_spf_has_vertex), (ospf_vertex_lookup),
4470 (ospf_spf_next_router), (ospf_spf_next_network),
4471 (ospf_spf_closest_vertex), (ospf_spf_calculate):
4472 function added.
4473
44741999-07-13 Toshiaki Takada <takada@zebra.org>
4475
4476 * ospf_ism.c: fix bug of DR Election.
4477
4478 * ospf_nsm.c: fix bug of adjacency forming.
4479
44801999-07-05 Kunihiro Ishiguro <kunihiro@zebra.org>
4481
4482 * ospfd.c (ospf_init): Change to use install_default.
4483
44841999-07-01 Rick Payne <rickp@rossfell.co.uk>
4485
4486 * ospf_zebra.c (zebra_init): Install standard commands to
4487 ZEBRA_NODE.
4488
44891999-06-30 Toshiaki Takada <takada@zebra.org>
4490
4491 * ospf_dump.c: Whole debug command is improved.
4492 (ISM|NSM) (events|status|timers) debug option added.
4493 (show_debugging_ospf): new DEFUN added.
4494
44951999-06-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4496
4497 * ospf_lsa.c (ospf_lsa_lookup_from_list): Change !IPV4_ADDR_CMP to
4498 IPV4_ADDR_SAME.
4499
45001999-06-29 Toshiaki Takada <takada@zebra.org>
4501
4502 * ospf_dump.c (ospf_summary_lsa_dump): Add summary-LSA dump routine.
4503 (ospf_as_external_lsa_dump): Add AS-external-LSA dump routine.
4504
4505 * ospf_nsm.c (nsm_twoway_received): fix condtion of adjacnet.
4506
4507 * ospf_ism.c (ospf_dr_election): fix DR Election.
4508
4509 * ospf_dump.c (ospf_nbr_state_message): fix `show ip ospf neighbor'
4510 command's state.
4511
45121999-06-29 Kunihiro Ishiguro <kunihiro@zebra.org>
4513
4514 * ospf_dump.c (ospf_router_lsa_dump): Add router-LSA dump routine.
4515
45161999-06-28 Toshiaki Takada <takada@zebra.org>
4517
4518 * ospf_lsa.c (show_ip_ospf_database_network): fix bug of
4519 `show ip ospf database network' command output.
4520
4521 * ospf_nsm.c (nsm_inactivity_timer): Clear list of Link State
4522 Retransmission, Database Summary and Link State Request.
4523
4524 * ospf_packet.c (ospf_ls_req_timer): New function added.
4525 Set Link State Request retransmission timer.
4526
45271999-06-27 Kunihiro Ishiguro <kunihiro@zebra.org>
4528
4529 * ospf_main.c (main): Change default output from ZLOG_SYSLOG to
4530 ZLOG_STDOUT.
4531
4532 * ospfd.c (ospf_init): Register show_ip_ospf_interface_cmd and
4533 show_ip_ospf_neighbor_cmd to VIEW_NODE.
4534
4535 * ospf_lsa.c (ospf_lsa_init): Register show_ip_ospf_database_cmd
4536 and show_ip_ospf_database_type_cmd to VIEW_NODE.
4537
45381999-06-25 Toshiaki Takada <takada@zebra.org>
4539
4540 * ospf_packet.c: fix bug of DD making.
4541 fix bug of LS-Update reading.
4542
45431999-06-23 Toshiaki Takada <takada@zebra.org>
4544
4545 * ospf_packet.c: All type of packets are changed to use
4546 fifo queue structure.
4547 (ospf_fill_header) function added.
4548
45491999-06-22 Toshiaki Takada <takada@zebra.org>
4550
4551 * ospf_packet.c (ospf_packet_new): New function added to handle
4552 sending ospf packet by fifo queue structure.
4553 (ospf_packet_free), (ospf_fifo_new), (ospf_fifo_push),
4554 (ospf_fifo_pop), (ospf_fifo_head), (ospf_fifo_flush),
4555 (ospf_fifo_free): Likewise.
4556
45571999-06-21 Toshiaki Takada <takada@zebra.org>
4558
4559 * ospf_nsm.c (ospf_db_desc_timer): function added.
4560 (nsm_timer_set) function added.
4561 * ospf_dump.c (ospf_option_dump): function added.
4562 * ospf_packet.c (ospf_ls_req) (ospf_make_ls_req): function added.
4563
45641999-06-20 Toshiaki Takada <takada@zebra.org>
4565
4566 * ospf_lsa.c (ospf_lsa_more_recent): function added.
4567 * ospf_neighbor.h (struct ospf_neighbor): Change member ms_flag
4568 to dd_flags.
4569
45701999-06-19 Toshiaki Takada <takada@zebra.org>
4571
4572 * ospf_lsa.c: DEFUN (show_ip_ospf_database) Added.
4573 * ospf_interface.c (if_ospf_cost), (if_ospf_dead_interval),
4574 (if_ospf_hello_interval), (if_ospf_priority),
4575 (if_ospf_retransmit_interval), (if_ospf_transmit_delay)
4576 argument changed from NUMBER to <range>.
4577 DEFUN (if_ospf_network_broadcast),
4578 DEFUN (if_ospf_network_non_broadcast),
4579 DEFUN (if_ospf_network_point_to_multipoint),
4580 DEFUN (if_ospf_network_point_to_point) functions are combined to
4581 DEFUN (if_ospf_network).
4582
45831999-06-18 Toshiaki Takada <takada@zebra.org>
4584
4585 * ospf_lsa.c: ospf_add_router_lsa (), ospf_add_network_lsa (),
4586 ospf_lsa_lookup (), ospf_lsa_count () Added.
4587
45881999-06-15 Toshiaki Takada <takada@zebra.org>
4589
4590 * DEFUN (ospf_debug_ism), DEFUN (ospf_debug_nsm),
4591 DEFUN (no_ospf_debug_ism), DEFUN (no_ospf_debug_nsm) Added.
4592 `debug ospf ism' command shows debug message.
4593 `debuf ospf nsm' command shows debug message.
4594
45951999-06-14 Toshiaki Takada <takada@zebra.org>
4596
4597 * ospf_lsa.c: ospf_network_lsa () Added.
4598 ospf_lsa_checksum () Added.
4599 * DEFUN (ospf_debug_packet), DEFUN (no_ospf_debug_packet) Added.
4600 `debug ospf packet' command shows debug message.
4601
46021999-06-13 Toshiaki Takada <takada@zebra.org>
4603
4604 * ospf_packet.h: Remove struct ospf_ls_req {}, ospf_ls_upd {},
4605 ospf_ls_ack {}.
4606
46071999-06-11 Toshiaki Takada <takada@zebra.org>
4608
4609 * ospf_dump.c: fix IP packet length treatment.
4610
46111999-06-10 Toshiaki Takada <takada@zebra.org>
4612
4613 * ospf_ism.h: Add OSPF_ISM_EVENT_EXECUTE() Macro Added.
4614 * ospf_nsm.h: Add OSPF_NSM_EVENT_EXECUTE() Macro Added.
4615
4616 * ospf_packet.c: ospf_db_desc (), ospf_db_desc_send () Added.
4617 ospf_make_hello (), ospf_make_db_desc () Added.
4618 ospf_db_desc_proc () Added.n
4619
4620 * Database Description packet can be processed.
4621
46221999-06-08 Toshiaki Takada <takada@zebra.org>
4623
4624 * ospf_lsa.c: New file.
4625
46261999-06-07 Toshiaki Takada <takada@zebra.org>
4627
4628 * ospf_neighbor.c: ospf_fully_adjacent_count () Added.
4629
46301999-06-07 Kunihiro Ishiguro <kunihiro@zebra.org>
4631
4632 * ospf_spf.[ch]: New file.
4633
46341999-05-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4635
4636 * ospf_zebra.c: Changed to use lib/zclient.c routines.
4637
4638 * ospf_zebra.h (zebra_start): Remove struct zebra.
4639
46401999-05-29 Kunihiro Ishiguro <kunihiro@zebra.org>
4641
4642 * ospfd.c (ospf_config_write): Add cast (unsigned long int) to
4643 ntohl for sprintf warning.
4644
46451999-05-19 Toshiaki Takada <takada@zebra.org>
4646
4647 * ospf_ism.c (ospf_dr_election): Join AllDRouters Multicast group
4648 if interface state changes to DR or BDR.
4649
46501999-05-14 Stephen R. van den Berg <srb@cuci.nl>
4651
4652 * ospf_main.c (signal_init): SIGTERM call sigint.
4653 (sigint): Logging more better message.
4654
46551999-05-12 Toshiaki Takada <takada@zebra.org>
4656
4657 * ospfd.c: Fix bug of `no router ospf' statement, it will work.
4658
46591999-05-11 Toshiaki Takada <takada@zebra.org>
4660
4661 * ospf_neighbor.c: ospf_nbr_free () Added.
4662
46631999-05-10 Toshiaki Takada <takada@zebra.org>
4664
4665 * ospfd.h: struct ospf_area { }, struct ospf_network { } Changed.
4666 * Fix bug of `no network' statement, it will work.
4667
46681999-05-07 Toshiaki Takada <takada@zebra.org>
4669
4670 * ospf_interface.c, ospf_zebra.c: Fix bug of last interface is not
4671 updated by ospf_if_update ().
4672
46731999-04-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4674
4675 * Makefile.am (noinst_HEADERS): Add ospf_lsa.h for distribution.
4676
46771999-04-25 Toshiaki Takada <takada@zebra.org>
4678
4679 * ospf_interface.c: DEFUN (no_if_ospf_cost),
4680 DEFUN (no_if_ospf_dead_interval),
4681 DEFUN (no_if_ospf_hello_interval),
4682 DEFUN (no_if_ospf_priority),
4683 DEFUN (no_if_ospf_retransmit_interval),
4684 DEFUN (no_if_ospf_transmit_delay) Added.
4685
4686 interface_config_write () suppress showing interface
4687 default values.
4688
46891999-04-25 Kunihiro Ishiguro <kunihiro@zebra.org>
4690
4691 * ospf_dump.c (ospf_timer_dump): If thread is NULL return "inactive".
4692
4693 * ospfd.c (ospf_if_update): Fix bug of using ospf_area { } instead
4694 of ospf_network { }. So `router ospf' statement in ospfd.conf
4695 works again.
4696 (ospf_if_update): Call ospf_get_router_id for updating router ID.
4697
46981999-04-25 Toshiaki Takada <takada@zebra.org>
4699
4700 * ospf_interface.c: DEFUN (if_ospf_network) deleted.
4701 DEFUN (if_ospf_network_broadcast),
4702 DEFUN (if_ospf_network_non_broadcast),
4703 DEFUN (if_ospf_network_point_to_multipoint),
4704 DEFUN (if_ospf_network_point_to_point),
4705 DEFUN (no_if_ospf_network) Added.
4706
47071999-04-23 Toshiaki Takada <takada@zebra.org>
4708
4709 * ospfd.h: struct area { } changed to struct ospf_network { }.
4710 Add struct ospf_area { }.
4711 * ospfd.c: Add ospf_area_lookup_by_area_id (), ospf_network_new (),
4712 and ospf_network_free ().
4713 DEFUN (area_authentication), DEFUN (no_area_authentication) Added.
4714
47151999-04-22 Toshiaki Takada <takada@zebra.org>
4716
4717 * ospf_lsa.h: New file.
4718 * ospf_packet.h: LSA related struct definition are moved to
4719 ospf_lsa.h.
4720 * ospf_packet.c: ospf_verify_header () Added.
4721
47221999-04-21 Toshiaki Takada <takada@zebra.org>
4723
4724 * ospf_ism.c: ospf_elect_dr () and related function is changed.
4725 DR Election bug fixed.
4726 * ospf_dump.c: ospf_nbr_state_message (), ospf_timer_dump () Added.
4727 * ospfd.c: DEFUN (show_ip_ospf_neighbor) Added.
4728
47291999-04-19 Kunihiro Ishiguro <kunihiro@zebra.org>
4730
4731 * ospf_main.c (main): access_list_init () is added for vty
4732 connection filtering.
4733
47341999-04-16 Toshiaki Takada <takada@zebra.org>
4735
4736 * ospfd.c: DEFUN (show_ip_ospf_interface) Added.
4737 * ospf_neighbor.c: ospf_nbr_count () Added.
4738
47391999-04-15 Toshiaki Takada <takada@zebra.org>
4740
4741 * ospfd.h: struct ospf { } Changed.
4742 * ospfd.c: ospf_lookup_by_process_id () Deleted.
4743 * ospf_ism.c: ospf_wait_timer () Added. WaitTimer will work.
4744
47451999-04-14 Toshiaki Takada <takada@zebra.org>
4746
4747 * ospf_ism.c: ospf_elect_dr () Added.
4748 * ospf_network.c: ospf_if_ipmulticast () Added.
4749
47501999-04-11 Toshiaki Takada <takada@zebra.org>
4751
4752 * ospf_interface.c: interface_config_write (),
4753 DEFUN (if_ip_ospf_cost),
4754 DEFUN (if_ip_ospf_dead_interval),
4755 DEFUN (if_ip_ospf_hello_interval),
4756 DEFUN (if_ip_ospf_priority),
4757 DEFUN (if_ip_ospf_retransmit_interval) and
4758 DEFUN (if_ip_ospf_transmit_delay) Added.
4759
47601999-04-08 Toshiaki Takada <takada@zebra.org>
4761
4762 * ospf_dump.c: ospf_packet_db_desc_dump () Added.
4763 * ospf_neighbor.c: ospf_nbr_bidirectional () Added.
4764 * ospf_nsm.c: nsm_twoway_received () Added.
4765
47661999-04-02 Toshiaki Takada <takada@zebra.org>
4767
4768 * ospf_neighbor.c: New file.
4769 * ospf_neighbor.h: New file.
4770 * ospf_nsm.c: New file.
4771 * ospf_nsm.h: New file.
4772 * ospf_packet.c: Add ospf_make_header (), ospf_hello () and
4773 ospf_hello_send (). Now OSPFd can receive Hello and send Hello.
4774
47751999-03-27 Kunihiro Ishiguro <kunihiro@zebra.org>
4776
4777 * ospf_packet.c: Add ospf_recv_packet (). Now OSPF Hello can receive.
4778
47791999-03-19 Toshiaki Takada <takada@zebra.org>
4780
4781 * ospf_packet.c: New file.
4782 * ospf_packet.h: New file.
4783 * ospf_network.c: New file.
4784 * ospf_network.h: New file.
4785 * ospfd.h: move OSPF message structure has moved to ospf_packet.h.
4786
47871999-03-17 Kunihiro Ishiguro <kunihiro@zebra.org>
4788
4789 * ospf_zebra.c (ospf_zebra_get_interface): Fix for IPv6 interface
4790 address.
4791
4792 * Makefile.am (install-sysconfDATA): Overwrite install-sysconfDATA
4793 for install ospfd.conf.sample as owner read only file.
4794
4795 * ospf_main.c (usage): Change to use ZEBRA_BUG_ADDRESS.
4796
47971999-03-15 Toshiaki Takada <takada@zebra.org>
4798
4799 * ospf_ism.c: New file.
4800 * ospf_ism.h: New file.
4801 * ospf_dump.c: New file.
4802 * ospf_dump.h: New file.
4803
4804 * ospfd.h: Add (struct ospf), (struct config_network),
4805 (struct message) structure.
4806
4807 * ospf_interface.c: Add ospf_if_match_network ().
4808 * ospf_interface.h (struct ospf_interface): Change struct members.
4809
4810 * ospfd.c: ospf_lookup_by_process_id (), ospf_network_new (),
4811 DEFUN (network_area): Added.
4812
4813 * ospfd.conf.sample: Change sample configuration.
4814
48151999-03-05 Toshiaki Takada <takada@zebra.org>
4816
4817 * ospf_interface.c: New file.
4818 * ospf_interface.h: New file.
4819 * ospf_zebra.h: New file.
4820 * ospf_zebra.c: Add interface function for zebra daemon.
4821 * ospfd.c: New file.
4822
48231999-02-23 Kunihiro Ishiguro <kunihiro@zebra.org>
4824
4825 * Move IPv6 codes and files to ospf6d directory.
4826
48271999-02-18 Peter Galbavy <Peter.Galbavy@knowledge.com>
4828
4829 * syslog support added
4830
48311998-12-22 Toshiaki Takada <takada@zebra.org>
4832
4833 * ospfd.h: New file.
4834 * ospf_lsa.h: New file.
4835
48361998-12-15 Kunihiro Ishiguro <kunihiro@zebra.org>
4837
4838 * Makefile.am: New file.
4839 * ospf_main.c: New file.
4840