blob: 0fdd36ac1fea5ef7b5090413f04c384bd9515a37 [file] [log] [blame]
Paul Jakma3a02d1f2007-11-01 14:29:11 +000012007-10-30 Nick Hilliard <nick@inex.ie>
2
3 * bgp_main.c: Add 'listenon' argument, to pass address to bind
4 to.
5 * bgp_network.c: (bgp_socket) Extend to take bind address.
6 * bgpd.c: (bgp_init) Pass stored address.
7 * bgpd.h: (struct bgp_master) storage for bind address
8
Paul Jakma0b2aa3a2007-10-14 22:32:21 +000092007-09-27 Paul Jakma <paul.jakma@sun.com>
10
11 * bgp_aspath.c: (assegment_normalise) remove duplicates from
12 from sets.
13 (aspath_reconcile_as4) disregard a broken part of the RFC around
14 error handling in path reconciliation.
15
162007-09-25 Paul Jakma <paul.jakma@sun.com>
17
18 * bgp_open.c: (peek_for_as4_capability) Fix to work.
19 * bgp_packet.c: (bgp_open_receive) Fix sanity check of as4.
20
212007-09-18 Paul Jakma <paul.jakma@sun.com>
22
23 * bgp_open.c: (bgp_capability_as4) debug printf inline with others.
24 (peek_for_as4_capability) There's no need to signal failure, as
25 failure is better dealt with through full capability parser -
26 just return the AS4, simpler.
27 * bgp_packet.c: (bgp_open_receive) Update to match
28 peek_for_as4_capability change.
29 Allow use of BGP_AS_TRANS by 2b speakers.
30 Use NOTIFY_OPEN_ERR rather than CEASE for OPEN parsing errors.
31 (bgp_capability_msg_parse) missing argument to debug print
32 (bgp_capability_receive) missing return values.
33
34
352007-07-25 Paul Jakma <paul.jakma@sun.com>
36
37 * Remove 2-byte size macros, just make existing macros take
38 argument to indicate which size to use.
39 Adjust all users - typically they want '1'.
40 * bgp_aspath.c: (aspath_has_as4) New, return 1 if there are any
41 as4's in a path.
42 (aspath_put) Return the number of bytes actually written, to
43 fix the bug Juergen noted: Splitting of segments will change
44 the number of bytes written from that already written to the
45 AS_PATH header.
46 (aspath_snmp_pathseg) Pass 2-byte flag to aspath_put. SNMP
47 is still defined as 2b.
48 (aspath_aggregate) fix latent bug.
49 (aspath_reconcile_as4) AS_PATH+NEW_AS_PATH reconciliation
50 function.
51 (aspath_key_make) Hash the AS_PATH string, rather than
52 just taking the addition of assegment ASes as the hash value,
53 hopefully sligthly more collision resistant.
54 (bgp_attr_munge_as4_attrs) Collide the NEW_ attributes
55 together with the OLD 2-byte forms, code Juergen
56 had in bgp_attr_parse but re-organised a bit.
57 (bgp_attr_parse) Bunch of code from Juergen moves
58 to previous function.
59 (bgp_packet_attribute) Compact significantly by
60 just /always/ using extended-length attr header.
61 Fix bug Juergen noted, by using aspath_put's
62 (new) returned size value for the attr header rather
63 than the (guesstimate) of aspath_size() - the two could
64 differ when aspath_put had to split large segments, unlikely
65 this bug was ever hit in the 'wild'.
66 (bgp_dump_routes_attr) Always use extended-len and
67 use aspath_put return for header length. Output 4b ASN
68 for AS_PATH and AGGREGATOR.
69 * bgp_ecommunity.c: (ecommunity_{hash_make,cmp}) fix
70 hash callback declarations to match prototypes.
71 (ecommunity_gettoken) Updated for ECOMMUNITY_ENCODE_AS4,
72 complete rewrite of Juergen's changes (no asdot support)
73 * bgp_open.c: (bgp_capability_as4) New, does what it says
74 on the tin.
75 (peek_for_as4_capability) Rewritten to use streams and
76 bgp_capability_as4.
77 * bgp_packet.c: (bgp_open_send) minor edit
78 checked (in the abstract at least) with Juergen.
79 Changes are to be more accepting, e.g, allow AS_TRANS on
80 a 2-byte session.
81 * (general) Update all commands to use CMD_AS_RANGE.
82 * bgp_vty.c: (bgp_clear) Fix return vals to use CMD_..
83 Remove stuff replicated by VTY_GET_LONG
84 (bgp_clear_vty) Return bgp_clear directly to vty.
85
86
872007-07-25 Juergen Kammer <j.kammer@eurodata.de>
88
89 * (general) AS4 support.
90 * bgpd.h: as_t changes to 4-bytes.
91 * bgp_aspath.h: Add BGP_AS4_MAX and BGP_AS_TRANS defines.
92 * bgp_aspath.c: AS_VALUE_SIZE becomes 4-byte, AS16_VALUE_SIZE
93 added for 2-byte.
94 Add AS16 versions of length calc macros.
95 (aspath_count_numas) New, count number of ASes.
96 (aspath_has_as4) New, return 1 if there are any as4's in a
97 path.
98 (assegments_parse) Interpret assegment as 4 or 2 byte,
99 according to how the caller instructs us, with a new
100 argument.
101 (aspath_parse) Add use32bit argument to pass to
102 assegments_parse. Adjust all its callers to pass 1, unless
103 otherwise noted.
104 (assegment_data_put) Adjust to be able to write 2 or 4 byte
105 AS, according to new use32bit argument.
106 (aspath_put) Adjust to write 2 or 4.
107 (aspath_gettoken) Use a long for passed in asno.
108 * bgp_attr.c: (attr_str) Add BGP_ATTR_AS4_PATH and
109 BGP_ATTR_AS4_AGGREGATOR.
110 (bgp_attr_aspath) Call aspath_parse with right 2/4 arg, as
111 determined by received-capability flag.
112 (bgp_attr_aspath_check) New, code previously in attr_aspath
113 but moved to new func so it can be run after NEW_AS_PATH
114 reconciliation.
115 (bgp_attr_as4_path) New, handle NEW_AS_PATH.
116 (bgp_attr_aggregator) Adjust to cope with 2/4 byte ASes.
117 (bgp_attr_as4_aggregator) New, read NEW_AGGREGATOR.
118 (bgp_attr_parse) Add handoffs to previous parsers for the two
119 new AS4 NEW_ attributes.
120 Various checks added for NEW/OLD reconciliation.
121 (bgp_packet_attribute) Support 2/4 for AS_PATH and
122 AGGREGATOR, detect when NEW_ attrs need to be sent.
123 * bgp_debug.{c,h}: Add 'debug bgp as4'.
124 * bgp_dump.c: MRTv2 support, unconditionally enabled, which
125 supports AS4. Based on patches from Erik (RIPE?).
126 * bgp_ecommunity.c: (ecommunity_ecom2str) ECOMMUNITY_ENCODE_AS4
127 support.
128 * bgp_open.c: (peek_for_as4_capability) New, peek for AS4
129 capability prior to full capability parsing, so we know which
130 ASN to use for struct peer lookup.
131 (bgp_open_capability) Always send AS4 capability.
132 * bgp_packet.c: (bgp_open_send) AS4 handling for AS field
133 (bgp_open_receive) Peek for AS4 capability first, and figure
134 out which AS to believe.
135 * bgp_vty.c: (bgp_show_peer) Print AS4 cap
136
Paul Jakmae08286b2007-09-18 12:11:26 +00001372007-09-17 Paul Jakma <paul.jakma@sun.com>
138
139 * bgp_open.c: (bgp_capability_mp) We were setting
140 afc_nego[safi][safi] rather than afc_nego[afi][safi], thus
141 failling to announce any non-IPv4 prefixes. Remove the extra,
142 typo-ed character.
143
Paul Jakmab2ceea12007-09-07 14:24:55 +00001442007-09-07 Paul Jakma <paul.jakma@sun.com>
145
146 * (general) bgpd can be made crash by remote peers if debug
147 bgp updates is set, due to NULL pointer dereference.
148 Reported by "Mu Security Research Team",
149 <security@musecurity.com>.
150 * bgp_attr.c: (bgp_attr_community) If community length is 0,
151 don't set the community-present attribute bit, just return
152 early.
153 * bgp_debug.c: (community_str,community_com2str) Check com
154 pointer before dereferencing.
155
Paul Jakma9eda90c2007-08-30 13:36:17 +00001562007-08-27 Paul Jakma <paul.jakma@sun.com>
157
158 * bgp_route.c: (bgp_announce_check) Fix bug #398, slight
159 modification of Vladimir Ivanov's suggested fix - to keep
160 memory alloc conditional.
161 (bgp_process_announce_selected) Don't take struct attr as
162 argument, none of the callers need it and it needlessly
163 distances allocation from use.
164 Free the extended attr, the attr itself is on the stack.
165 Fix bad indentation.
166 * bgp_attr.c: (bgp_packet_attribute) Remove incorrect assert,
167 and adjust conditional to test attr->extra, diagnosis by
168 Vladimir Ivanov in bug #398.
169
1702007-08-27 Vladimir Ivanov <wawa@yandex-team.ru>
171
172 * bgp_route.c: (bgp_announce_check_rsclient) copy of
173 ri->attr is no longer deep enough, due to addition of
174 attr->extra. It should use bgp_attr_dup, as
175 bgp_announce_check() does.
176
Paul Jakma6d134fb2007-08-23 23:22:02 +00001772007-08-23 Paul Jakma <paul.jakma@sun.com>
178
179 * bgp_regex.c: (bgp_regcomp) Pass NOSUB flag to regcomp to
180 prevent parsing of substitutions, which can have profound
181 performance effects on bgpd and are of no use to the CLI
182 anyway. How much it helps depends on the regex
183 implementation.
184
Paul Jakma41367172007-08-06 15:24:51 +00001852007-07-31 Paul Jakma <paul.jakma@sun.com>
186
187 * (general) Support for draft-ietf-idr-as-pathlimit-03.
188 * bgp_attr.h: (struct attr) Add pathlimit struct
189 bgp_attr.c: (attr_str) Add BGP_ATTR_AS_PATHLIMIT string.
190 (attrhash_key_make) tally pathlimit too
191 (attrhash_cmp) cmp pathlimit attr
192 (bgp_attr_aspathlimit) New, parse AS_PATHLIMIT attr.
193 (bgp_attr_parse) ditto
194 (bgp_packet_attribute) Write out AS_PATHLIMIT when set
195 (bgp_dump_routes_attr) ditto
196 * bgp_route.h: (struct bgp_static) Add TTL field
197 * bgp_route.c: (bgp_announce_check) Drop paths that are over
198 their hop-count TTL before sending via EBGP.
199 Mangle ASN in pathlimit for confeds/private as best we can.
200 (bgp_static_update_{rsclient,main}) Add any configure pathlimit
201 information.
202 (bgp_pathlimit_update_parents) New, update atomic-aggr setting for
203 parents of an aspathlimit'ed static.
204 (bgp_static_set) Add TTL argument, for all the 'bgp network'
205 commands.
206 Call previous for TTL changed statics.
207 (bgp_static_unset) Call pathlimit_update_parents.
208 (various bgp network commands) Add 'pathlimit <0-255>' qualifier
209 to all the various forms, bar route-map - which can set ttl
210 itself.
211 * bgp_routemap.c: (general) Add support for 'set pathlimit ttl' and
212 'match pathlimit as'.
213
Paul Jakma6d582722007-08-06 15:21:45 +00002142007-07-26 Paul Jakma <paul.jakma@sun.com>
215
216 * (general) Clean up and compact capability parsing slightly.
217 Consolidate validation of length and logging of generic TLV, and
218 memcpy of capability data, thus removing such from cap specifc
219 code (not always present or correct).
220 * bgp_open.h: Add structures for the generic capability TLV header
221 and for the data formats of the various specific capabilities we
222 support. Hence remove the badly named, or else misdefined, struct
223 capability.
224 * bgp_open.c: (bgp_capability_vty_out) Use struct capability_mp_data.
225 Do the length checks *before* memcpy()'ing based on that length
226 (stored capability - should have been validated anyway on input,
227 but..).
228 (bgp_afi_safi_valid_indices) new function to validate (afi,safi)
229 which is about to be used as index into arrays, consolidates
230 several instances of same, at least one of which appeared to be
231 incomplete..
232 (bgp_capability_mp) Much condensed.
233 (bgp_capability_orf_entry) New, process one ORF entry
234 (bgp_capability_orf) Condensed. Fixed to process all ORF entries.
235 (bgp_capability_restart) Condensed, and fixed to use a
236 cap-specific type, rather than abusing capability_mp.
237 (struct message capcode_str) added to aid generic logging.
238 (size_t cap_minsizes[]) added to aid generic validation of
239 capability length field.
240 (bgp_capability_parse) Generic logging and validation of TLV
241 consolidated here. Code compacted as much as possible.
242 * bgp_packet.c: (bgp_open_receive) Capability parsers now use
243 streams, so no more need here to manually fudge the input stream
244 getp.
245 (bgp_capability_msg_parse) use struct capability_mp_data. Validate
246 lengths /before/ memcpy. Use bgp_afi_safi_valid_indices.
247 (bgp_capability_receive) Exported for use by test harness.
248 * bgp_vty.c: (bgp_show_summary) fix conversion warning
249 (bgp_show_peer) ditto
250 * bgp_debug.h: Fix storage 'extern' after type 'const'.
251
Paul Jakma45ad5922007-07-31 17:35:36 +00002522007-07-31 Lorenzo Colitti <lorenzo@colitti.com>
253
254 * bgp_dump.c: (general) Add comments to code.
255 (bgp_dump_interval_add) remove some redundant lines.
256 (bgp_dump_set) Use enum for type argument.
257 Avoid scheduling dump twice if exact same command
258 is given twice..
259
Paul Jakma536792c2007-06-22 19:11:14 +00002602007-06-22 Paul Jakma <paul.jakma@sun.com>
261
262 * bgp_fsm.c: (struct FSM) Bug #368. TCP Errors during OpenSent
263 should cycle to Active, not to Idle or else peer bringup can
264 race and cycle Idle<->Active. Reported and fix tested by
265 Mukesh Agrawal.
266
Paul Jakmab2497022007-06-14 11:17:58 +00002672007-05-25 Paul Jakma <paul.jakma@sun.com>
268
269 * bgp_route.c: (bgp_default_originate) Sanity check added
270 previously was broken and always failed, thus this function
271 never could run, bug #370.
272
Paul Jakmafb982c22007-05-04 20:15:47 +00002732007-05-03 Paul Jakma <paul.jakma@sun.com>
Paul Jakma923de652007-04-29 18:25:17 +0000274
Paul Jakmafb982c22007-05-04 20:15:47 +0000275 * bgp_route.h: (struct info) Move less frequently used
276 fields to a lazily allocated struct info_extra.
277 Export bgp_info_extra_get
278 * bgp_route.c: (bgp_info_extra_new) allocate extra
279 (bgp_info_extra_free) Free damp info and the info_extra.
280 (bgp_info_extra_get) Retrieve the info_extra of a struct
281 info, allocating as required.
282 (generally) adjust to use info->extra
283 * bgp_damp.c: (generally) use bgp_info_extra_get to access
284 dampinfo
285 * bgp_attr.h: Move rarely allocated attributes from struct attr
286 to a struct attr_extra, for a substantial saving in size of
287 struct attr.
288 * bgp_attr.c: (bgp_attr_extra_{new,free}), new, self-explanatory.
289 (bgp_attr_extra_get) Get the attr_extra for a given struct
290 attr, allocating it if needs be.
291 (bgp_attr_dup) Shallow copy the struct attr and its attr_extra.
292 (generally) adjust to know about attr->extra.
293 * bgp_debug.c: (bgp_dump_attr) ditto
294 * bgp_vty.c: (show_bgp_memory) print attr and info extra sizes.
295 * bgp_nexthop.c: (generally) adjust to know about attr->extra
296 and info->extra.
297 * bgp_{packet,routemap,snmp,zebra}.c: ditto
298
2992007-04-22 Sebastien Tandel <sebastien@tandel.be>
Paul Jakma923de652007-04-29 18:25:17 +0000300 * bgp_advertise.c : (baa_hash_alloc, baa_hash_key, baa_hash_cmp)
301 conforms to quagga hash API. Defines _hash_[alloc|key|cmp] with
302 void * arguments as defined by the API.
303 * bgp_aspath.c,h : (aspath_key_make) conforms to quagga hash API.
304 Defines _hash_[alloc|key|cmp] with void * arguments as defined by
305 the API.
306 * bgp_attr.c,h : (cluster_hash_alloc, cluster_hash_key_make,
307 cluster_hash_cmp, transit_hash_alloc, transit_hash_key_make,
308 transit_hash_cmp, attrhash_key_make, attrhash_cmp,
309 bgp_attr_hash_alloc) conforms to quagga hash API. Defines
310 _hash_[alloc|key|cmp] with void * arguments as defined by the API.
Paul Jakma03e214c2007-04-29 18:31:07 +0000311 * bgp_attr.h : Definition of BGP_ATTR_DEFAULT_WEIGHT.
312 * bgp_attr.c : (bgp_attr_default_intern) now uses
313 bgp_attr_default_set instead of duplicating the same code.
314 (general) Use of BGP_ATTR_DEFAULT_WEIGHT. Replace two 16 by
315 IPV6_MAX_BYTELEN.
Paul Jakma923de652007-04-29 18:25:17 +0000316
Andrew J. Schorr93c17492007-04-15 19:17:24 +00003172007-04-15 Sebastien Tandel <sebastien@tandel.be>
318
319 * bgp_aspath.c: (aspath_as_add, aspath_segment_add) Minor performance
320 optimization: while loop should test one pointer instead of two.
321
Paul Jakma16d2e242007-04-10 19:32:10 +00003222007-04-08 Paul Jakma <paul.jakma@sun.com>
323
324 * bgp_route.c: (general) Same bug as fixed on 2006-11-28 by ajs for
325 bgp static routes, but for main BGP RIB: Quick 'flap' of routes
326 can cause bgpd to mistake a new route for a duplicate route,
327 due to presence of removed, but not yet processed BGP RIB entry.
328 (bgp_update_rsclient) Ignore REMOVED bgp_info for duplicate,
329 restore route instead.
330 (bgp_update_main) Ditto.
Paul Jakma6e4ab122007-04-10 19:36:48 +0000331 * bgp_attr.c: (general) Bug #354: parsing of MP_REACH_NLRI and
332 MP_UNREACH_NLRI does not take sufficient care to ensure reads
333 from stream buffer stay in-bounds. Hence bgpd may attempt to read
334 beyond end of stream, if given a crafted packet. As it uses the
335 stream access methods to do so, this will typically result in
336 assert() being hit in stream.c. Where code is compiled without
337 assert() enabled, result is unknown.
338 (struct message attr_str) should be static.
339 (bgp_mp_reach_parse) Carefully check length remaining in stream
340 against amount desired to read from stream, prior to each read,
341 particularly where lengths are conditional on data obtained from
342 stream - using STREAM_READABLE.
343 Remove code to parse SNPA-number, it's a defunct field and changed
344 to a fixed size in latest BGP MP update RFC - log warning if
345 SNPA-number is not 0.
346 (bgp_mp_unreach_parse) Check withdraw_length carefully against
347 STREAM_READABLE.
348 (bgp_attr_parse) If attribute-parser function returns error, log
349 warning.
350 Log attribute type on mismatch.
Paul Jakma16d2e242007-04-10 19:32:10 +0000351
Paul Jakma37a217a2007-04-10 19:20:29 +00003522007-04-07 Paul Jakma <paul.jakma@sun.com>
353
354 * bgpd.c: (general) Fix bug #352
355 (bgp_config_write_family_header) write ipv6/multicast
356 address family header.
357 (bgp_config_write) write out ipv6 multicast AF config.
358
Paul Jakmaf2c31ac2007-02-22 17:48:42 +00003592007-02-22 Paul Jakma <paul.jakma@sun.com>
360
361 * bgp_fsm.c: (bgp_fsm_change_status) Handle state change into
362 clearing or greater here. Simpler.
363 (bgp_event) Clearing state change work moved to previous
364 * bgp_route.c: (bgp_clear_route_node) Clearing adj-in here
365 is too late, as it leaves a race between a peer being deleted
366 and an identical peer being configured before clearing
367 completes, leading to a crash.
368 Simplest fix is to clean peers Adj-in up-front, rather than
369 queueing such work.
370 (bgp_clear_route_table) Clear peer's Adj-In and Adj-Out
371 up-front here, rather than queueing such work.
372 Extensive comment added on the various bits of indexed data
373 that exist and how they need to be dealt with.
374 (bgp_clear_route) Update comment.
375
Andrew J. Schorre4529632006-12-12 19:18:21 +00003762006-12-12 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
377
378 * bgp_nexthop.c: (bgp_connected_add, bgp_connected_delete)
379 Simplify logic by using new CONNECTED_PREFIX macro.
380
Paul Jakma95fdcd82006-12-08 00:31:22 +00003812006-12-07 Paul Jakma <paul.jakma@sun.com>
382
383 * bgp_fsm.c: Bug #302 fix, diagnosis, suggestions and testing
384 by Juergen Kammer <j.kammer@eurodata.de>. Fix follows from
385 his suggested fix, just made in a slightly different way.
386 (bgp_event) Transitions into Clearing always must call
387 bgp_clear_route_all().
388 (bgp_stop) No need to clear routes here, BGP FSM should do
389 it.
390
Andrew J. Schorra39275d2006-11-30 16:36:57 +00003912006-11-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
392
393 * bgp_debug.h: Declare new bgp_debug_zebra conf and term flags,
394 and define BGP_DEBUG_ZEBRA.
395 * bgp_debug.c: Declare conf_bgp_debug_zebra and term_bgp_debug_zebra.
396 (debug_bgp_zebra, no_debug_bgp_zebra, undebug_bgp_zebra) New
397 functions to enable/disable bgp zebra debugging.
398 (no_debug_bgp_all) Turn off zebra debugging.
399 (show_debugging_bgp) Show whether zebra debugging is on.
400 (bgp_config_write_debug) Add 'debug bgp zebra' if configured.
401 (bgp_debug_init) Add new zebra debugging commands.
402 * bgp_zebra.c: (bgp_router_id_update, bgp_interface_add,
403 bgp_interface_delete, bgp_interface_up, bgp_interface_down,
404 bgp_interface_address_add, bgp_interface_address_delete,
405 zebra_read_ipv4, zebra_read_ipv6, bgp_zebra_announce,
406 bgp_zebra_withdraw, bgp_redistribute_set, bgp_redistribute_unset)
407 If zebra debugging is enabled, log an appropriate debug message.
408
Andrew J. Schorr8d452102006-11-28 19:50:46 +00004092006-11-28 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
410
411 * bgp_route.c: (bgp_info_restore) New function that undoes
412 the effects of a previous call to bgp_info_delete. This is
413 used when a route is deleted and quickly re-added before the
414 deletion has been processed.
415 (bgp_static_update_rsclient, bgp_static_update_main,
416 bgp_redistribute_add) Check whether a pre-existing route
417 has the BGP_INFO_REMOVED set, and, if so, we need to call
418 bgp_info_restore to resurrect it.
419
Paul Jakma56395af2006-10-27 16:58:20 +00004202006-10-27 Paul Jakma <paul.jakma@sun.com>
421
422 * bgp_route.c: (bgp_table_stats) oops, u_intXX_t should be
423 uintXX_t
424
Paul Jakma6f585442006-10-22 19:13:07 +00004252006-10-19 Paul Jakma <paul.jakma@sun.com>
426
427 * bgpd.c: (peer_new) bgp element of peer absolutely must be
428 filled in, make peer_new() require it as argument and update
429 all callers. Fixes a crash reported by Jan 'yanek' Bortl and
430 Andrew Schorr where bgpd would crash in bgp_pcount_adjust
431 trying to dereference the bgp member of bgp->peer_self,
432 triggered through redistribution.
433 * bgp_route.c: (bgp_pcount_adjust) assert sanity of arguments.
434
Paul Jakma53d9f672006-10-15 23:41:16 +00004352006-10-15 Paul Jakma <paul.jakma@sun.com>
436
437 * bgp_route.c: (bgp_table_stats_walker) NULL deref if table is
438 empty, bgp_table_top may return NULL, Coverity CID#73.
Paul Jakmaed3ebfa2006-10-15 23:50:16 +0000439 * bgp_packet.c: (bgp_update_packet) adv->rn can not be NULL,
440 check is bogus - changed to assert(), CID#64.
441 binfo is checked for NULL, but then dereferenced
442 unconditionally, fix, CID #63.
443 (bgp_withdraw_packet) Assert adv->rn is valid, as with
444 bgp_update_packet().
Paul Jakma53d9f672006-10-15 23:41:16 +0000445
Paul Jakmadcdf3992006-10-15 23:39:59 +00004462006-10-14 Paul Jakma <paul.jakma@sun.com>
447
448 * bgp_fsm.h: Remove BGP_EVENT_FLUSH_ADD, dangerous and not
449 needed.
450 * bgp_fsm.c: (bgp_stop) Move BGP_EVENT_FLUSH to the top of the
451 of the function, otherwise it could flush a ClearingCompleted
452 event, bug #302.
453 * bgp_packet.c: Replace all BGP_EVENT_FLUSH_ADD with
454 BGP_EVENT_ADD, fixing bug #302.
455
Andrew J. Schorr0cd1c322006-09-19 18:51:53 +00004562006-09-19 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
457
458 * bgpd.c: (peer_uptime) Fix printf format/arg mismatch in
459 zlog_warn message (%ld/size_t -> %lu/u_long).
460
Paul Jakmaca058a32006-09-14 02:58:49 +00004612006-09-14 Paul Jakma <paul.jakma@sun.com>
462
Paul Jakma8383a9b2006-09-14 03:06:54 +0000463 * bgp_route.c: (bgp_table_stats_walker) Address space announced
464 should only count top-level unaggregateable prefixes, to
465 avoid falling afoul of anti-dodgy-accounting regulations
466 in various jurisdictions.. ;)
Paul Jakma09dd5612006-09-14 03:38:16 +0000467 (bgp_process_queue_init) process queue hold time too high,
468 adds extra memory load. Change to be much lower, until such
469 time as it's made configurable.
Paul Jakma8383a9b2006-09-14 03:06:54 +0000470
4712006-09-14 Paul Jakma <paul.jakma@sun.com>
472
Paul Jakma9fde6622006-09-14 03:02:02 +0000473 * (general) fix the peer refcount issue exposed by previous, by
474 just removing refcounting of peer threads, which is mostly
475 senseless as they're references leading from struct peer,
476 which peer_free cancels anyway. No need to muck around..
477 * bgp_fsm.h: Just remove the refcounting from the various
478 TIMER/READ/WRITE/EVENT ON/OFF/ADD macros.
479 * bgp_fsm.c: (bgp_stop) use BGP_EVENT_FLUSH, no refcounts attached
480 to events anymore.
481 (bgp_event) remove peer_unlock, events not refcounted.
482 * bgpd.c: (peer_free) flush events before free.
483
4842006-09-14 Paul Jakma <paul.jakma@sun.com>
485
Paul Jakmaca058a32006-09-14 02:58:49 +0000486 * (general) Fix some niggly issues around 'shutdown' and clearing
487 by adding a Clearing FSM wait-state and a hidden 'Deleted'
488 FSM state, to allow deleted peers to 'cool off' and hit 0
489 references. This introduces a slow memory leak of struct peer,
490 however that's more a testament to the fragility of the
491 reference counting than a bug in this patch, cleanup of
492 reference counting to fix this is to follow.
493 * bgpd.h: Add Clearing, Deleted states and Clearing_Completed
494 and event.
495 * bgp_debug.c: (bgp_status_msg[]) Add strings for Clearing and
496 Deleted.
497 * bgp_fsm.h: Don't allow timer/event threads to set anything
498 for Deleted peers.
499 * bgp_fsm.c: (bgp_timer_set) Add Clearing and Deleted. Deleted
500 needs to stop everything.
501 (bgp_stop) Remove explicit fsm_change_status call, the
502 general framework handles the transition.
503 (bgp_start) Log a warning if a start is attempted on a peer
504 that should stay down, trying to start a peer.
505 (struct .. FSM) Add Clearing_Completed
506 events, has little influence except when in state
507 Clearing to signal wait-state can end.
508 Add Clearing and Deleted states, former is a wait-state,
509 latter is a placeholder state to allow peers to disappear
510 quietly once refcounts settle.
511 (bgp_event) Try reduce verbosity of FSM state-change debug,
512 changes to same state are not interesting (Established->Established)
513 Allow NULL action functions in FSM.
514 * bgp_packet.c: (bgp_write) Use FSM events, rather than trying
515 to twiddle directly with FSM state behind the back of FSM.
516 (bgp_write_notify) ditto.
517 (bgp_read) Remove the vague ACCEPT_PEER peer_unlock, or else
518 this patch crashes, now it leaks instead.
519 * bgp_route.c: (bgp_clear_node_complete) Clearing_Completed
520 event, to end clearing.
521 (bgp_clear_route) See extensive comments.
522 * bgpd.c: (peer_free) should only be called while in Deleted,
523 peer refcounting controls when peer_free is called.
524 bgp_sync_delete should be here, not in peer_delete.
525 (peer_delete) Initiate delete.
526 Transition to Deleted state manually.
527 When removing peer from indices that provide visibility of it,
528 take great care to be idempotent wrt the reference counting
529 of struct peer through those indices.
530 Use bgp_timer_set, rather than replicating.
531 Call to bgp_sync_delete isn't appropriate here, sync can be
532 referenced while shutting down and finishing deletion.
533 (peer_group_bind) Take care to be idempotent wrt list references
534 indexing peers.
535
Paul Jakma2815e612006-09-14 02:56:07 +00005362006-09-13 Paul Jakma <paul.jakma@sun.com>
537
538 * bgp_aspath.c: (aspath_highest) new, return highest ASN in an
539 aspath.
540 * bgp_route.c: (bgp_peer_count_walker) new, do the walk done
541 in bgp_peer_counts as a thread.
542 (bgp_peer_counts) move walk to previous and call it via
543 thread_execute so this RIB walk shows up in thread stats.
544 (bgp_table_stats) New, gather some statistics for a given
545 RIB.
546 (bgp_table_stats_walker) New, RIB walker thread for former.
547 (bgp_table_stats_vty) Parsing front-end for 'show bgp ...',
548 useful model for future rationalisation of 'show ... bgp'.
549 (bgp_route_init) Add new RIB stats commands.
550
Paul Jakma1a392d42006-09-07 00:24:49 +00005512006-09-06 Paul Jakma <paul.jakma@sun.com>
552
553 * (general) Squash any and all prefix-count issues by
554 abstracting route flag changes, and maintaining count as and
555 when flags are modified (rather than relying on explicit
556 modifications of count being sprinkled in just the right
557 places throughout the code).
558 * bgp_route.c: (bgp_pcount_{dec,inc}rement) removed.
559 (bgp_pcount_adjust) new, update prefix count as
560 needed for a given route.
561 (bgp_info_{uns,s}et_flag) set/unset a BGP_INFO route status
562 flag, calling previous function when appropriate.
563 (general) Update all set/unsets of flags to use previous.
564 Remove pcount_{dec,inc}rement calls.
565 No need to unset BGP_INFO_VALID in places where
566 bgp_info_delete is called, it does that anyway.
567 * bgp_{damp,nexthop}.c: Update to use bgp_info_{un,}set_flag.
568 * bgp_route.h: Export bgp_info_{un,}set_flag.
569 Add a 'meta' BGP_INFO flag, BGP_INFO_UNUSEABLE.
570 Move BGP_INFO_HOLDDOWN macro to here from bgpd.h
571
Paul Jakmaff7924f2006-09-04 01:10:36 +00005722006-09-03 Paul Jakma <paul.jakma@sun.com>
573
574 * bgp_route.c: Add 'show ... bgp ... <neighbour> prefix-count'
575 commands, to provide detailed counts of prefixes for a peer.
576 Informative, and should help pin down to pfxcnt drift
577 problems.
578
Paul Jakma9f906c72006-08-27 06:57:47 +00005792006-08-27 Paul Jakma <paul.jakma@sun.com>
580
581 * bgp_advertise.c: (bgp_sync_delete) fix mtype in XFREE.
582 NULL out peer->hash after free, to be sure.
583
Paul Jakma1f742f22006-08-06 15:52:11 +00005842006-08-06 Paul Jakma <paul.jakma@sun.com>
585
586 * bgp_aspath.c: (aspath_loop_check) Fix the typo-bug which
587 essentially had disabled this check. Problem reported by
588 Bartek Kania <mrbk@gnarf.org> in [quagga-users 7388].
589
Paul Jakma18937402006-07-27 19:05:12 +00005902006-07-27 Paul Jakma <paul.jakma@sun.com>
591
592 * bgpd.c: (peer_delete) Ensure freed buffers can not be
593 accidently reused. A potential fix for bug #287.
594
Paul Jakma33d5ab92006-07-02 11:01:50 +00005952006-07-02 Paul Jakma <paul.jakma@sun.com>
596
597 * bgp_fsm.c: (bgp_{stop,start}) Move clear/free of certain
598 bits of state from stop to start, as they may be used via
599 peer references on clearing queues..
600
Paul Jakma369688c2006-05-23 22:27:55 +00006012006-05-23 Paul Jakma <paul.jakma@sun.com>
602
603 * bgp_vty.c: (neighbor_update_source_cmd) Expand tab completion
604 to make it clear it takes both address and ifname.
605
Paul Jakma34c3f812006-05-12 23:25:37 +00006062006-05-12 Paul Jakma <paul.jakma@sun.com>
607
608 * bgp_attr.c: (bgp_packet_attribute) Remove dead code, Coverity
609 CID #1
Paul Jakmab2518c12006-05-12 23:48:40 +0000610 * bgp_aspath.{c,h}: (aspath_print_vty) take a format string,
611 so as to reduce burden on callers, all in bgp_route.c
Paul Jakmadd8103a2006-05-12 23:27:30 +0000612 * bgp_route.c: (bgp_static_update_main) Remove useless NULL
613 check, code already assumes bgp_static can not be NULL,
614 fixes CID #7.
Paul Jakma06e110f2006-05-12 23:29:22 +0000615 (bgp_static_update_rsclient) ditto, CID #6
Paul Jakmab2518c12006-05-12 23:48:40 +0000616 (route_vty_out{,tmp}) Update to match aspath_print_vty,
617 simplifying checks needed to get spacing right. CID #4,#5.
618 ({damp,flap}_route_vty_out) Ditto, CID #9, #10
Paul Jakma34c3f812006-05-12 23:25:37 +0000619
Paul Jakma542bcb72006-05-08 14:25:09 +00006202006-05-08 Paul Jakma <paul.jakma@sun.com>
621
622 * bgp_community.c: (community_str2com) Coverity CID#62, fix
623 double-free, use-after-free.
Paul Jakmada5b30f2006-05-08 14:37:17 +0000624 * bgp_route.c: (bgp_afi_node_get) given table should never be
625 NULL, check/assert this.
626 (bgp_static_update) Bug #240. Rsclients should only be passed
627 the static update if they are configured for the afi,safi.
Paul Jakma542bcb72006-05-08 14:25:09 +0000628
Paul Jakmaa3b6ea52006-05-04 07:52:12 +00006292006-05-04 Paul Jakma <paul.jakma@sun.com>
630
631 * (general) VPNv4 fixes. Certain VPNv4 code was not enabled.
632 See bug #210.
633 * bgp_attr.{c,h}: (bgp_packet_{withdraw,attribute}) Tag should be
634 u_char really.
635 * bgp_packet.c: (bgp_{update,withdraw}_packet) Enable some
636 VPNv4 code which inexplicably was ifdef'd out. comments from
637 a tester on IRC suggest this fixes bug #210.
Paul Jakma65ca75e2006-05-04 08:08:15 +0000638 * bgp_route.c: (general) Fix logical bug in clearing, noted
639 by Chris Caputo in [quagga-users 6728] - clearing depended on
640 at least one route being added to workqueue, in order for
641 workqueue completion function to restart FSM. However, if no
642 routes are cleared, then the completion function never is
643 called, it needs to be called manually if the workqueue
644 didn't get scheduled.
645 Finally, clearing is per-peer-session, not per AFI/SAFI, so
646 the FSM synchronisation should be in bgp_clear_route_table.
647 (bgp_clear_route_table) Wrong place for FSM/clearing
648 synchronisation, move to..
649 (bgp_clear_route) FSM/clearing synchronisation should be
650 here.
651 If no routes were cleared, no workqueue scheduled, call
652 the completion func to ensure FSM kicks off again.
Paul Jakmaa3b6ea52006-05-04 07:52:12 +0000653
Paul Jakma15aa6a12006-03-30 14:39:35 +00006542006-03-30 Paul Jakma <paul.jakma@sun.com>
655
656 * bgp_community.c: (community_gettoken) Unknown token should
657 return NULL, to give a strong indication to callers that
658 the token no longer can be parsed, otherwise callers looping
659 on this function may have a hard time ending their loop.
660 (community_str2com) While loop around community_gettoken appears
661 to have been coded thinking that break statement would break
662 from the while{}, hence it could never exit for unknown token
663 case. Fix it to do..while, so it can use the NULL result from
664 community_gettoken easily.
665
Paul Jakmaa625ca32006-03-30 14:12:38 +00006662006-03-22 Paul Jakma <paul.jakma@sun.com>
667
668 * bgpd.c: (peer_free) release the per-peer workqueue when
669 freeing the peer.
670
Paul Jakma5304cb52006-03-30 14:01:14 +00006712006-03-19 Paul Jakma <paul.jakma@sun.com>
672
Paul Jakma4bf6a362006-03-30 14:05:23 +0000673 * bgpd/bgp_vty.c: Add includes to get several structs we want
674 to provide usage statistics on.
675 (show_bgp_memory_cmd) Show memory usage stats for various
676 notable fixed size objects. Using mtype_stats_alloc and
677 mtype_memstr recently added to memory.c.
678 (bgp_show_summary) Report some additional stats specific to
679 the given BGP instance and/or AFI/SAFI such as table counts,
680 peers, rsclients and peer-groups.
681 (bgp_vty_init) Install show_bgp_memory_cmd.
Paul Jakma5304cb52006-03-30 14:01:14 +0000682 * bgp_nexthop.h: Include if.h as a dependent header, for struct
683 connected.
Paul Jakmab51f1262006-03-30 14:09:38 +0000684 * bgp_advertise.c: Use a distinct memory type for struct
685 bgp_synchronize.
Paul Jakma5304cb52006-03-30 14:01:14 +0000686
Paul Jakmacbdfbaa2006-03-30 13:20:48 +00006872006-03-12 Paul Jakma <paul.jakma@sun.com>
688
689 * bgp_attr.h: (struct attr) rearrange fields to avoid
690 wasted padding between them as much as possible.
691 (attr_count,attr_unknown_count) export new functions to
692 return number of counts of cached attributes.
693 * bgp_attr.c: (attr_count,attr_unknown_count) new functions to
694 return number of counts of cached attributes.
695 * bgp_route.h: (struct bgp_info) rearrange fields to avoid
696 wasted padding.
697 * bgp_table.h: (struct bgp_table) Add a count field, of number
698 of nodes in the table.
699 (struct bgp_node) rearrange fields to avoid
700 wasted padding between them, though I don't think there
701 was any in this case.
702 * bgp_table.c: (bgp_node_{delete,get}) Maintain the table node count.
703 (bgp_table_count) new function to access the table count.
704
Paul Jakma3e0c78e2006-03-06 18:06:53 +00007052006-03-03 Paul Jakma <paul.jakma@sun.com>
706
707 * bgp_route.c: (bgp_clear_node_complete) Doh. When clearing
708 is complete we need to kick off FSM again.
709
Paul Jakma64e580a2006-02-21 01:09:01 +00007102006-02-21 Paul Jakma <paul.jakma@sun.com>
711
712 * bgpd.h: move the clear_node_queue to be peer specific.
713 Add a new peer status flag, PEER_STATUS_CLEARING.
714 * bgp_table.h: (struct bgp_table) Add fields to record afi,
715 safi of the table.
716 (bgp_table_init) Take afi and safi to create table for.
717 * bgp_table.c: (bgp_table_init) record the afi and safi.
718 * bgp_nexthop.c: Update all calls to bgp_table_init.
719 * bgp_vty.c: ditto.
720 * bgpd.c: ditto.
721 * bgp_fsm.c: (bgp_timer_set) dont bring up a session which is
722 clearing.
723 * bgp_route.c: (general) Update all bgp_table_init calls.
724 (bgp_process_{rsclient,main}) clear_node is serialised
725 via PEER_STATUS_CLEARING and fsm now.
726 (struct bgp_clear_node_queue) can be removed. struct bgp_node
727 can be the queue item data directly, as struct peer can be
728 kept in the new wq global user data and afi/safi can be
729 retrieved via bgp_node -> bgp_table.
730 (bgp_clear_route_node) fix to get peer via wq->spec.data,
731 afi/safi via bgp_node->bgp_table.
732 (bgp_clear_node_queue_del) no more item data to delete, only
733 unlock the bgp_node.
734 (bgp_clear_node_complete) only need to unset CLEARING flag
735 and unlock struct peer.
736 (bgp_clear_node_queue_init) queue attaches to struct peer
737 now. record peer name as queue name.
738 (bgp_clear_route_table) If queue transitions to active,
739 serialise clearing by setting PEER_STATUS_CLEARING rather
740 than plugging process queue, and lock peer while queue
741 active.
742 Update to pass only bgp_node as per-queue-item specific data.
Paul Jakma6a419732006-02-21 01:14:13 +0000743 * bgp_vty.c: (bgp_show_summary) Add a 'Clrng' sub-description
744 to state of peer while it's suppressed due to clearing.
Paul Jakma64e580a2006-02-21 01:09:01 +0000745
Paul Jakmaaa94ca82006-02-18 10:49:04 +00007462006-02-18 Paul Jakma <paul.jakma@sun.com>
747
748 * bgp_routemap.c: (route_set_community) Quick, very hacky, fix
749 for the set-community leak, bug #89. True fix will be to
750 detangle the web of *_intern caching and provide saner object
751 caching for Quagga, future work.
Paul Jakma7c7fa1b2006-02-18 10:52:09 +0000752 * bgp_route.c: (bgp_announce_check) trivial, move declaration
753 of two local variables into the only block where they are
754 used, to aid the reader.
Paul Jakmaaa94ca82006-02-18 10:49:04 +0000755
paul902212c2006-02-05 17:51:19 +00007562006-02-05 Paul Jakma <paul.jakma@sun.com>
757
758 * bgp_route.h: Add BGP_INFO_COUNTED to track whether
759 prefix has been counted or not.
760 * bgp_route.c: (bgp_pcount_{inc,dec}rement) new helpers, to
761 centralise inc/dec of prefix-count,
762 (bgp_rib_remove) Remove pcount decrement, use helper.
763 (bgp_rib_withdraw) ditto, additionally use previous function
764 too.
765 (bgp_update_main) Use pcount helpers.
766 (bgp_clear_route_node) ditto, aslo REMOVED routes don't need
767 clearing.
paul3fff6ff2006-02-05 17:55:35 +0000768 * bgp_aspath.c: (aspath_gettoken) fix gcc warning about
769 possible uninitialised usage.
paul902212c2006-02-05 17:51:19 +0000770
paul306d8892006-02-02 17:50:19 +00007712006-02-02 Paul Jakma <paul.jakma@sun.com>
772
773 * bgp_route.c: (bgp_{clear_node,process}_queue_init) delay
774 field is removed from workqueue spec.
775
paule8e19462006-01-19 20:16:55 +00007762006-01-19 Paul Jakma <paul.jakma@sun.com>
777
778 * (general) various miscellaneous compiler warning fixes.
779 Remove redundant break statements from switch clauses
780 which return.
781 return from main, not exit, cause it annoys SOS.
782 Remove stray semi-colons which cause empty-statement
783 warnings.
784
pauld3092e72006-01-17 17:33:46 +00007852006-01-17 Paul Jakma <paul.jakma@sun.com>
786
787 * bgp_nexthop.c: (zlookup_read*) convert to new Zserv format.
788 (zlookup_query_ipv6) ditto.
789 (bgp_import_check) ditto.
790
paul02335422006-01-16 11:13:27 +00007912006-01-16 Paul Jakma <paul.jakma@sun.com>
792
793 * bgp_aspath.c: (assegment_append_asns) XREALLOC can return
794 NULL theoretically, take care not to lose the allocated data.
795 (aspath_hash_alloc) aspath_dup already set the aspath
796 string - fix leak.
797 (aspath_parse) aspath_hash_alloc dupes the entire aspath,
798 including segments, but we forgot to free the temporary
799 assegment.
paul8fdc32a2006-01-16 12:01:29 +0000800 (aspath_snmp_pathseg) move the static stream pointer out to
801 file scope, so it can be freed.
802 (aspath_finish) new function, free aspath resources.
803 * bgp_aspath.h: (aspath_finish) export.
paul02335422006-01-16 11:13:27 +0000804
paul37c38302006-01-10 22:15:45 +00008052006-01-10 Juris Kalnins <juris@mt.lv>
806
807 * bgpd.h: (bgp_router_id_unset) ex-function, remove.
808
paulad727402005-11-23 02:47:02 +00008092005-11-23 Paul Jakma <paul.jakma@sun.com>
810
811 * bgp_aspath.c: (assegments_parse) should be static
812
8132005-11-23 Juergen Kammer <j.kammer@eurodata.de>
814
815 * bgp_aspath.c: (aspath_cmp_left_confed) fix SEGV for case
816 where one or both paths are empty.
817
paul0fb58d52005-11-14 14:31:49 +00008182005-11-14 Paul Jakma <paul.jakma@sun.com>
819
820 * bgp_route.c: (bgp_process_rsclient) convert to new workqueue
821 specs and shut up gcc, which complains about cast from void
822 via function parameters, for some dumb reason. Do the cast
823 inside the function instead.
824 (bgp_process_main,bgp_processq_del) ditto.
825 (bgp_clear_route_node) ditto.
826 (bgp_clear_node_queue_del) ditto.
827
paul41200852005-11-03 12:52:18 +00008282005-11-03 Paul Jakma <paul.jakma@sun.com>
829
830 * bgp_damp.c: (bgp_reuse_timer) struct bgp can be retrieved via
831 the struct bgp_damp_info, no need to guess by using
832 bgp_get_default().
833
ajsf52d13c2005-10-01 17:38:06 +00008342005-10-01 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
835
836 * bgp_vty.c: (bgp_config_write_redistribute) Use new library function
837 zebra_route_string instead of a local hard-coded table.
838
jardin2d74db52005-10-01 00:07:50 +00008392005-09-30 Vincent Jardin <vincent.jardin@6wind.com>
840
841 * bgp_packet.c: fix compilation when DEBUG is used.
842
paul1f8ae702005-09-09 23:49:49 +00008432005-09-10 Paul Jakma <paul.jakma@sun.com>
844
paulfe69a502005-09-10 16:55:02 +0000845 * Makefile.am: bgpd shouldn't list libgp's sources as its own.
846 Use LDADD.
847 * bgp_aspath.h:
848 (struct assegment) New struct, abstract representation of a
849 list of AS_PATH segments and the contained ASNs.
850 (struct aspath) Remove the raw-data related
851 fields, reference the abstract struct assegment instead.
852 Remove several other computed fields, it's just a
853 headache to maintain them and they're cheap to compute from
854 struct assegment.
855 (aspath_parse) parse a stream, not a pointer to raw data.
856 (aspath_count_{hops,confeds,size}) helpers to access
857 information formerly directly contained in struct aspath.
858 (aspath_snmp_pathseg) Helper for SNMP, BGP MIB wants
859 to be able to output hex representation of raw data.
860 * bgp_aspath.c: (general) partial-rewrite. Store aspath data
861 as an abstract singly-linked list of abstract segments,
862 rather than storing the raw data, and parsing it each and
863 every time. Remove several count/size fields which are cheap
864 to compute from the abstract segment structure.
865 (global) Include stream.h, needed for aspath_parse, and
866 others. Couple of helper macros added.
867 (struct assegment_header) Just the header, and only the
868 header.
869 (assegment_data_{new,free}) convenience functions for
870 AS_SEG_DATA allocation, the dynamic, per-segment array of
871 ASNs.
872 (assegment_{new,free,free_all,dup,dup_all}) convenience
873 functions for creating struct assegments. The _all forms will
874 follow the entire chain of segments from the given segment.
875 (assegment_prepend_asns) new function, prepend an ASN N times
876 to segment.
877 (assegment_append_asns) Append a list (array) of ASNs to
878 segment.
879 (int_cmp) convenience function for the aspath hash.
880 (assegment_normalise) new function. Normalise the given
881 segment chain to meet expectations of Quagga, and to
882 eliminate differing raw representations of the same paths.
883 Merge 'runs' of SEQUENCEs into one segment as our internal
884 segment is not limited by the protocol AS_PATH segment
885 length. Sort ASNs in SETs.
886 (aspath_new) Take void argument to quell warnings. Use the
887 assegment convenience functions.
888 (assegment_count_{asns,confeds,hops}) new functions to
889 compute at runtime values previously held in struct aspath.
890 (aspath_size) ditto.
891 (aspath_make_str_count) rewritten to stringify new
892 representation, and to be slightly easier to understand
893 hopefully.
894 (aspath_str_update) convenience function, update the aspath
895 str. Should investigate removing maintained string from
896 struct aspath, just run-time compute it, as per other fields.
897 It's just a maintenance headache, would save noticeable
898 amount of RAM with possibly not much extra run-time cost.
899 (aspath_dup) use the assegment dup functions.
900 (aspath_hash_alloc) Take void * argument to satisfy gcc. Use
901 the proper helper functions to dup data.
902 (assegments_parse) new function. parse raw AS_PATH data into
903 struct assegments. Normalise and return the head of the list.
904 (aspath_parse) Parse a stream, not pointer to raw data and
905 use assegments_parse to do it.
906 (assegment_data_put) Write out a single segment data in protocol
907 form to stream.
908 (assegment_header_put) ditto but for segment header.
909 (aspath_put) new function. As per previous but for an entire
910 struct aspath.
911 (aspath_snmp_pathseg) wrapper around aspath_put for
912 bgp_snmp.c. Uses a static buffer sadly.
913 (aspath_aggregate_as_set_add) rewritten to use assegments.
914 (aspath_aggregate) ditto
915 (aspath_{firstas,loop,private_as}_check) ditto
916 (aspath_{merge,prepend,add_one_as}) ditto
917 (aspath_cmp_left{_confed}) ditto
918 (aspath_delete_confed_seq) ditto, plus fixed to properly
919 delete all leading confed segments.
920 (aspath_as_add) Just use assegment_append_asns.
921 (aspath_segment_add) updated to use assegments.
922 (enum as_token) Add values for confeds
923 (aspath_gettoken) Add support for confeds
924 (aspath_str2aspath) ditto
925 (aspath_key_make) updated to use as_segments. Also, add
926 segment type into the hash value as appropriate.
927 (aspath_cmp) updated to use as_segments.
928 (aspath_print) don't segfault on NULL argument.
929 * bgp_attr.c: (bgp_attr_aspath) aspath_parse wants the stream
930 now. No need for manual forwarding of stream.
931 (bgp_packet_attribute) empty aspath is now denoted by NULL
932 segment field, length is gone.
933 Use aspath_size() to determine size.
934 (bgp_attr_init) Fix declaration, explicitely specify void
935 arg.
936 (bgp_dump_routes_attr) Use aspath_size() to determine size.
937 * bgp_route.c: (bgp_info_cmp) use the aspath_count_* functions.
938 (bgp_rib_withdraw) remove unused variable. Use
939 aspath_count_hops.
940 * bgp_snmp.c: (bgp4PathAttrTable) raw data is gone, use
941 aspath_snmp_pathseg to get the representation.
942
9432005-09-10 Paul Jakma <paul.jakma@sun.com>
944
paul1f8ae702005-09-09 23:49:49 +0000945 * bgp_vty.c: (bgp_vty_init) gcc 4 compile fix. static
946 function declarations shouldn't be inside functions.
947 * bgp_dump.c: (bgp_dump_interval_add) ditto.
948
hassob7395792005-08-26 12:58:38 +00009492005-08-26 Hasso Tepper <hasso at quagga.net>
950
951 * bgp_route.c: Third (?) attempt to fix best selection breakage
952 introduced long time ago with route server patch. Hopefully
953 it's last case to fix - route-server client not in peer group.
954
paul25ffbdc2005-08-22 22:42:08 +00009552005-08-22 Hugo Santos <hsantos@av.it.pt>
956
957 * bgp_vty.c: (general) Add support for BGP IPv6 Multicast SAFI
958 commands and BGP_IPV6M_NODE.
959
paulb40d9392005-08-22 22:34:41 +00009602005-08-22 Paul Jakma <paul.jakma@sun.com>
961
962 * bgp_route.h: (struct bgp_info) add a new flag, BGP_INFO_REMOVED.
963 BGP_INFO_VALID is already overloaded, don't care to do same thing
964 to STALE or HISTORY.
965 * bgpd.h: (BGP_INFO_HOLDDOWN) Add INFO_REMOVED to the macro, as a
966 route which should generally be ignored.
967 * bgp_route.c: (bgp_info_delete) Just set the REMOVE flag, rather
968 than doing actual work, so that bgp_process (called directly,
969 or indirectly via the scanner) can catch withdrawn routes.
970 (bgp_info_reap) Actually remove the route, what bgp_info_delete
971 used to do, only for use by bgp_process.
972 (bgp_best_selection) reap any REMOVED routes, other than the old
973 selected route.
974 (bgp_process_rsclient) reap the old-selected route, if appropriate
975 (bgp_process_main) ditto
976 (bgp_rib_withdraw, bgp_rib_remove) make them more consistent with
977 each other. Don't play games with the VALID flag, bgp_process
978 is async now, so it didn't make a difference anyway.
979 Remove the 'force' argument from bgp_rib_withdraw, withdraw+force
980 is equivalent to bgp_rib_remove. Update all its callers.
981 (bgp_update_rsclient) bgp_rib_withdraw and force set is same as
982 bgp_rib_remove.
983 (route_vty_short_status_out) new helper to print the leading
984 route-status string used in many command outputs. Consolidate.
985 (route_vty_out, route_vty_out_tag, damp_route_vty_out,
986 flap_route_vty_out) use route_vty_short_status_out rather than
987 duplicate.
988 (route_vty_out_detail) print state of REMOVED flag.
989 (BGP_SHOW_SCODE_HEADER) update for Removed flag.
990
hassoe279c7a2005-08-03 17:23:20 +00009912005-08-03 Hasso Tepper <hasso at quagga.net>
992
993 * bgp_routemap.c: Revert part of leaking communities fix commited in
994 2005-05-27. While ecommunity fix seems to be correct, community case
995 isn't.
996
paul94f2b392005-06-28 12:44:16 +00009972005-06-28 Paul Jakma <paul.jakma@sun.com>
998
999 * (global) The great bgpd extern and static'ification.
1000 * bgp_routemap.c: remove unused ROUTE_MATCH_ASPATH_OLD code
1001 (route_set_metric_compile) fix u_int32_t to ULONG_MAX comparison
1002 warnings.
1003 * bgp_route.h: (bgp_process, bgp_withdraw, bgp_update) export these
1004 used by various files which had their own private declarations,
1005 in the case of mplsvpn - incorrect.
1006
paule210cf92005-06-15 19:15:35 +000010072005-06-15 Paul Jakma <paul.jakma@sun.com>
1008
1009 * bgpd.c: (bgp_terminate) workqueue's are lazy allocated and its
1010 possible to terminate bgpd before workqueues were setup, causing
1011 an abort/crash. Reported by Ashish Mehta of Sun.
1012
paul200df112005-06-01 11:17:05 +000010132005-06-01 Paul Jakma <paul.jakma@sun.com>
1014
1015 * (general) refcount struct peer and bgp_info, hence allowing us
1016 add work_queues for bgp_process.
1017 * bgp_route.h: (struct bgp_info) Add 'lock' field for refcount.
1018 Add bgp_info_{lock,unlock} helper functions.
1019 Add bgp_info_{add,delete} helpers, to remove need for
1020 users managing locking/freeing of bgp_info and bgp_node's.
1021 * bgp_table.h: (struct bgp_node) Add a flags field, and
1022 BGP_NODE_PROCESS_SCHEDULED to merge redundant processing of
1023 nodes.
1024 * bgp_fsm.h: Make the ON/OFF/ADD/REMOVE macros lock and unlock
1025 peer reference as appropriate.
1026 * bgp_damp.c: Remove its internal prototypes for
1027 bgp_info_delete/free. Just use bgp_info_delete.
1028 * bgpd.h: (struct bgp_master) Add work_queue pointers.
1029 (struct peer) Add reference count 'lock'
1030 (peer_lock,peer_unlock) New helpers to take/release reference
1031 on struct peer.
1032 * bgp_advertise.c: (general) Add peer and bgp_info refcounting
1033 and balance how references are taken and released.
1034 (bgp_advertise_free) release bgp_info reference, if appropriate
1035 (bgp_adj_out_free) unlock peer
1036 (bgp_advertise_clean) leave the adv references alone, or else
1037 call bgp_advertise_free cant unlock them.
1038 (bgp_adj_out_set) lock the peer on new adj's, leave the reference
1039 alone otherwise. lock the new bgp_info reference.
1040 (bgp_adj_in_set) lock the peer reference
1041 (bgp_adj_in_remove) and unlock it here
1042 (bgp_sync_delete) make hash_free on peer conditional, just in
1043 case.
1044 * bgp_fsm.c: (general) document that the timers depend on
1045 bgp_event to release a peer reference.
1046 (bgp_fsm_change_status) moved up the file, unchanged.
1047 (bgp_stop) Decrement peer lock as many times as cancel_event
1048 canceled - shouldnt be needed but just in case.
1049 stream_fifo_clean of obuf made conditional, just in case.
1050 (bgp_event) always unlock the peer, regardless of return value
1051 of bgp_fsm_change_status.
1052 * bgp_packet.c: (general) change several bgp_stop's to BGP_EVENT's.
1053 (bgp_read) Add a mysterious extra peer_unlock for ACCEPT_PEERs
1054 along with a comment on it.
1055 * bgp_route.c: (general) Add refcounting of bgp_info, cleanup
1056 some of the resource management around bgp_info. Refcount peer.
1057 Add workqueues for bgp_process and clear_table.
1058 (bgp_info_new) make static
1059 (bgp_info_free) Ditto, and unlock the peer reference.
1060 (bgp_info_lock,bgp_info_unlock) new exported functions
1061 (bgp_info_add) Add a bgp_info to a bgp_node in correct fashion,
1062 taking care of reference counts.
1063 (bgp_info_delete) do the opposite of bgp_info_add.
1064 (bgp_process_rsclient) Converted into a work_queue work function.
1065 (bgp_process_main) ditto.
1066 (bgp_processq_del) process work queue item deconstructor
1067 (bgp_process_queue_init) process work queue init
1068 (bgp_process) call init function if required, set up queue item
1069 and add to queue, rather than calling process functions directly.
1070 (bgp_rib_remove) let bgp_info_delete manage bgp_info refcounts
1071 (bgp_rib_withdraw) ditto
1072 (bgp_update_rsclient) let bgp_info_add manage refcounts
1073 (bgp_update_main) ditto
1074 (bgp_clear_route_node) clear_node_queue work function, does
1075 per-node aspects of what bgp_clear_route_table did previously
1076 (bgp_clear_node_queue_del) clear_node_queue item delete function
1077 (bgp_clear_node_complete) clear_node_queue completion function,
1078 it unplugs the process queues, which have to be blocked while
1079 clear_node_queue is being processed to prevent a race.
1080 (bgp_clear_node_queue_init) init function for clear_node_queue
1081 work queues
1082 (bgp_clear_route_table) Sets up items onto a workqueue now, rather
1083 than clearing each node directly. Plugs both process queues to
1084 avoid potential race.
1085 (bgp_static_withdraw_rsclient) let bgp_info_{add,delete} manage
1086 bgp_info refcounts.
1087 (bgp_static_update_rsclient) ditto
1088 (bgp_static_update_main) ditto
1089 (bgp_static_update_vpnv4) ditto, remove unneeded cast.
1090 (bgp_static_withdraw) see bgp_static_withdraw_rsclient
1091 (bgp_static_withdraw_vpnv4) ditto
1092 (bgp_aggregate_{route,add,delete}) ditto
1093 (bgp_redistribute_{add,delete,withdraw}) ditto
1094 * bgp_vty.c: (peer_rsclient_set_vty) lock rsclient list peer
1095 reference
1096 (peer_rsclient_unset_vty) ditto, but unlock same reference
1097 * bgpd.c: (peer_free) handle frees of info to be kept for lifetime
1098 of struct peer.
1099 (peer_lock,peer_unlock) peer refcount helpers
1100 (peer_new) add initial refcounts
1101 (peer_create,peer_create_accept) lock peer as appropriate
1102 (peer_delete) unlock as appropriate, move out some free's to
1103 peer_free.
1104 (peer_group_bind,peer_group_unbind) peer refcounting as
1105 appropriate.
1106 (bgp_create) check CALLOC return value.
1107 (bgp_terminate) free workqueues too.
1108
hasso033e8612005-05-28 04:50:54 +000011092005-05-28 Hasso Tepper <hasso at quagga.net>
1110
1111 * bgp_routemap.c: Sync set_metric_addsub_cmd with ripd.
1112
hasso54a6ed32005-05-26 22:12:33 +000011132005-05-27 Hasso Tepper <hasso at quagga.net>
1114
hasso70601e02005-05-27 03:26:57 +00001115 * bgp_routemap.c: Stop leaking communities.
1116
11172005-05-27 Hasso Tepper <hasso at quagga.net>
1118
hasso54a6ed32005-05-26 22:12:33 +00001119 * bgpd.c: Deleting bgp->rsclient list needs fix similar to pree-groups
1120 deleting fix. Avoid leaking bgp->group, bgp->peer and bgp->rsclient
1121 lists.
1122
11232005-05-26 Hasso Tepper <hasso at quagga.net>
hassob6b7cff2005-05-26 08:29:07 +00001124
1125 * bgpd.c: Don't crash while deleting list of peer-groups.
1126
hassob5f29602005-05-25 21:00:28 +000011272005-05-25 Hasso Tepper <hasso at quagga.net>
1128
1129 * bgpd.c: Fix obvious (routeserver patch) merge error. This makes "no
1130 neighbor x.x.x.x routemap [export|import] commands work again.
1131
paula94feb32005-05-23 13:17:29 +000011322005-05-23 Paul Jakma <paul@dishone.st>
1133
1134 * bgp_routemap.c: add semi-colons to VTY_GET_* to match vty.h change
paul00d252c2005-05-23 14:19:54 +00001135 * bgp_fsm.h: Add extern qualifier to exported functions
1136 * bgp_nexthop.c: add static to nexthop specific globals
1137 * *.h: Add guard defines
paula94feb32005-05-23 13:17:29 +00001138
paul22db9de2005-05-19 01:50:11 +000011392005-05-19 Paul Jakma <paul@dishone.st>
1140
1141 * bgp_fsm.c: (bgp_stop) use sockunion_free, not XFREE..
1142 * bgp_network.c: (bgp_getsockname) ditto
paule83e2082005-05-19 02:12:25 +00001143 (bgp_accept) use XSTRDUP
paul22db9de2005-05-19 01:50:11 +00001144 * bgp_routemap.c: (route_match_peer) ditto, als use a ret value and
1145 remove one sockunion_free.
paule83e2082005-05-19 02:12:25 +00001146 * bgpd.c: (peer_delete) ditto.
1147 XFREE the correct memtype, not free.
1148 (peer_create) use XSTRDUP
1149 * bgp_packet.c: (bgp_stream_dup) deleted, stream_dup should be used
1150 (various) update -> s/bgp_stream_dup/stream_dup
1151
paul22db9de2005-05-19 01:50:11 +00001152
ajs634f9ea2005-04-11 15:51:40 +000011532005-04-11 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1154
1155 * bgp_zebra.c (bgp_redistribute_set, bgp_redistribute_unset):
1156 The 2nd arg to zebra_redistribute_send is now zclient instead of
1157 zclient->sock.
1158
hassoa8a80d52005-04-09 13:07:47 +000011592005-04-09 Akihiro Mizutani <mizutani@net-chef.net>
1160
1161 * bgp_vty.c: Make "exit-address-family" work in IPv4 unicast address
1162 family node.
1163
hasso68118452005-04-08 15:40:36 +000011642005-04-08 Martin Ling <martin-quagga@earth.li>
1165
1166 * bgp_aspath.[ch], bgp_route.c, bgp_vty.c, bgpd.[ch]: Allow to enable
1167 the length of confederation path segments to be included during the
1168 as-path length check in the best path decision.
1169
ajsd2fc8892005-04-02 18:38:43 +000011702005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1171
1172 * bgp_zebra.c: (bgp_interface_delete) After deleting, set ifp->ifindex
1173 to IFINDEX_INTERNAL.
1174
hasso6cf159b2005-03-21 10:28:14 +000011752005-03-21 Hasso Tepper <hasso at quagga.net>
1176
1177 * bgp_route.c: Don't crash while clearing route tables if there is
1178 no particular afi/safi configured.
1179
hasso338b3422005-02-23 14:27:24 +000011802005-02-23 Hasso Tepper <hasso at quagga.net>
1181
1182 * bgp_route.c: Make reannouncing prefixes with changed attributes
1183 work again.
1184
hasso6ffd2072005-02-02 14:50:11 +000011852005-02-02 Akihiro Mizutani <mizutani@net-chef.net>
1186
hassodd4c5932005-02-02 17:15:34 +00001187 * bgp_vty.c: Deprecate "neighbor transparent-as" and "neighbor
1188 transparent-nexthop" commands.
1189
11902005-02-02 Akihiro Mizutani <mizutani@net-chef.net>
1191
hassoc1643bb2005-02-02 16:43:17 +00001192 * bgp_routemap.c: New route-map command - "match ip route-source".
1193
11942005-02-02 Akihiro Mizutani <mizutani@net-chef.net>
1195
hassofee6e4e2005-02-02 16:29:31 +00001196 * bgp_clist.[ch], bgp_route.c, bgp_routemap.c, bgp_vty.c:
1197 community-list cleanup.
1198
11992005-02-02 Akihiro Mizutani <mizutani@net-chef.net>
1200
hasso6ffd2072005-02-02 14:50:11 +00001201 * bgp_route.c, bgp_vty.c, bgp_zebra.c, bgpd.[ch]: "enforce-multihop"
1202 -> "disable-connected-check".
1203
12042005-02-02 Akihiro Mizutani <mizutani@net-chef.net>
hasso93406d82005-02-02 14:40:33 +00001205
1206 * bgp_fsm.c, bgp_open.c, bgp_packet.c, bgp_route.[ch], bgp_vty.c,
1207 bgpd.[ch]: Add BGP_INFO_STALE flag and end-of-rib support. "bgp
1208 graceful-restart" commands added. Show numbers of individual
1209 messages in "show ip bgp neighbor" command. Final pieces of graceful
1210 restart.
1211
hassof4184462005-02-01 20:13:16 +000012122005-02-01 Akihiro Mizutani <mizutani@net-chef.net>
1213
hassoc9502432005-02-01 22:01:48 +00001214 * bgp_open.c, bgp_packet.c, bgp_vty.c, bgpd.[ch]: Remove "no neighbor
1215 capability route-refresh" commands. Route refresh capability is sent
1216 anyway now. Preserve dummy deprecated commands.
1217
12182005-02-01 Akihiro Mizutani <mizutani@net-chef.net>
1219
hasso3d515fd2005-02-01 21:30:04 +00001220 * bgp_attr.c, bgp_snmp.c, bgp_vty.c, bgpd.[ch]: Remove support for old
1221 draft - ie. "neighbor version 4-" commands. Preserve dummy "neighbor
1222 version" command as deprecated.
1223
12242005-02-01 Akihiro Mizutani <mizutani@net-chef.net>
1225
hasso0a486e52005-02-01 20:57:17 +00001226 * bgpd.[ch], bgp_vty.c, bgp_route.c: "Restart session after
1227 maximum-prefix limit" feature support.
1228
12292005-02-01 Akihiro Mizutani <mizutani@net-chef.net>
1230
hassof4184462005-02-01 20:13:16 +00001231 * bgp_nexthop.c: Improve debug.
1232 * bgpd.[ch], bgp_nexthop.c, bgp_snmp.c: Remove useless bgp_get_master()
1233 function.
1234 * bgp_packet.c: MP AFI_IP update and withdraw parsing.
1235 * bgp_fsm.c: Reset peer synctime in bgp_stop(). bgp_fsm_change_status()
1236 is better place to log about peer status change than bgp_event().
1237 Log in bgp_connect_success().
1238 * bgp_vty.c: Fix typo in comment.
1239 * bgp_attr.c: Better log about unknown attribute.
1240
ajs3b8b1852005-01-29 18:19:13 +000012412005-01-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1242
1243 * bgp_filter.c: (ip_as_path,no_ip_as_path) Use argv_concat instead
1244 of buffer_getstr.
1245 * bgp_route.c: (bgp_show_regexp) Fix memory leak: need to free string
1246 returned by buffer_getstr.
1247 (bgp_show_community) Must use XFREE instead of free on string
1248 returned by buffer_getstr.
1249 * bgp_routemap.c: (set_community) Must use XFREE instead of free
1250 on string returned by buffer_getstr.
1251 * bgp_vty.c: (neighbor_description) Use argv_concat instead of
1252 buffer_getstr.
1253
hasso6d694292005-01-24 09:29:42 +000012542005-01-24 Hasso Tepper <hasso at quagga.net>
1255
1256 * bgp_route.c: Fix showstopper bug. New route must be selected also
1257 if old one is flaged as BGP_INFO_ATTR_CHANGED.
1258
hassof1271652005-01-17 11:04:32 +000012592005-01-17 Hasso Tepper <hasso at quagga.net>
1260
1261 * bgp_route.c: Clear peer's routing table regardless whether it's
1262 configured or not. Being not configured is even better reason to
1263 do it.
1264
paula24a7e12005-01-05 08:14:13 +000012652005-01-05 Paul Jakma <paul@dishone.st>
1266
1267 * bgp_packet.c: (bgp_write) set socket to nonblock while writing
1268 this should be generalised. See bugzilla #102. Fix supplied by
1269 wawa@yandex-team.ru (Vladimir Ivanov).
1270
ajsd2c1f162004-12-08 21:10:20 +000012712004-12-08 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1272
1273 * *.c: Change level of debug messages to LOG_DEBUG.
1274
ajs274a4a42004-12-07 15:39:31 +000012752004-12-07 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1276
1277 * bgp_main.c: (main) The 2nd argument to openzlog has been removed.
1278
ajs887c44a2004-12-03 16:36:46 +000012792004-12-03 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1280
1281 * bgp_main.c: (sigint) Use zlog_notice for termination message.
1282 (main) Use zlog_notice for startup announcement.
1283
hassoc0652302004-11-25 19:33:48 +000012842004-11-25 Hasso Tepper <hasso at quagga.net>
1285
1286 * bgp_main.c: Make group to run as configurable.
1287
paul59320202004-11-09 01:54:03 +000012882004-11-09 Paul Jakma <paul@dishone.st>
1289
1290 * bgp_nexthop.c: collapse bgp_connected_ipvX, bgp_nexthop_cache_ipvX
1291 and cache{1,2}.. into arrays of tables and hence collapse
1292 bgp_scan_ipv{4,6} into a single bgp_scan function. Tested, though
1293 a long time ago (and this change was hand-merged).
1294
ajs5a646652004-11-05 01:25:55 +000012952004-11-04 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1296
1297 * bgp_route.c: Remove all code related to VTY_CONTINUE; this feature
1298 is deprecated because the output did not represent a single point
1299 in time. All output needs to be generated inline and buffered
1300 by the library code.
1301 (route_vty_out,route_vty_out_tag,damp_route_vty_out,
1302 flap_route_vty_out) Remove code to count number of lines of output,
1303 since this was only useful for VTY_CONTINUE behavior.
1304 (bgp_show_callback,vty_calc_line) Removed.
1305 (bgp_show_table) Remove hooks for VTY_CONTINUE callback support.
1306 As a result, there's a new output_arg argument to this function.
1307 Make function static.
1308 (bgp_show) Make function static and add a new output_arg argument.
1309 Change all functions that call bgp_show or bgp_show_table to
1310 pass the new output_arg argument (that used to be passed inside
1311 vty->output_arg).
1312 * bgp_mplsvpn.c: Remove declarations of functions defined in
1313 bgp_route.c; these declarations belong in bgp_route.h.
1314 * bgp_route.h: Declare 3 global functions used in both bgp_route.c
1315 and in bgp_mplsvpn.c.
1316
paula2b1ecd2004-10-31 18:58:09 +000013172004-10-31 Paul Jakma <paul@dishone.st>
1318
1319 * {bgpd,bgp_attr}.c: size_t printf format should be ld.
1320
paul98f51632004-10-25 14:19:15 +000013212004-10-25 Paul Jakma <paul@dishone.st>
1322
1323 * Update with fix in debian bug id 222930.
1324 * bgp_main.c: Add ZCAP_RAW, needed to bind to interfaces.
1325 bgp_network.c: (....) raise/lower privs around call to
1326 SO_BINDTODEVICE sockopt.
1327
hasso3fb9cd62004-10-19 19:44:43 +000013282004-10-19 Andrew J. Schorr <aschorr@telemetry-investments.com>
1329
1330 * bgp_nexthop.c: (bgp_connected_add) Connected destination pointer
1331 may be NULL.
1332 (bgp_connected_delete) ditto.
1333
hasso501ba492004-10-13 21:32:46 +000013342004-10-14 Hasso Tepper <hasso at quagga.net>
1335
1336 * bgp_dump.c: Make dump configuration appear in vtysh.
1337
hassoc75105a2004-10-13 10:33:26 +000013382004-10-13 Hasso Tepper <hasso at quagga.net>
1339
1340 * bgp_snmp.c: Remove defaults used to initialize smux connection to
1341 snmpd. Connection is initialized only if smux peer is configured.
hasso8b3126b2004-10-13 20:59:04 +00001342 * bgp_view.c: It's dead file. Reomved.
hassoc75105a2004-10-13 10:33:26 +00001343
paulfd79ac92004-10-13 05:06:08 +000013442004-10-13 Paul Jakma <paul@dishone.st>
1345
1346 * (global) more const'ification and fixups of types to clean up code.
1347 * bgp_mplsvpn.{c,h}: (str2tag) fix abuse. Still not perfect,
1348 should use something like the VTY_GET_INTEGER macro, but without
1349 the vty_out bits..
1350 * bgp_routemap.c: (set_aggregator_as) use VTY_GET_INTEGER_RANGE
1351 (no_set_aggregator_as) ditto.
1352 * bgpd.c: (peer_uptime) fix unlikely bug, where no buffer is
1353 returned, add comments about troublesome return value.
1354
hasso18a6dce2004-10-03 18:18:34 +000013552004-10-03 James R. Leu <jleu at mindspring.com>
1356
1357 * bgp_vty.c: Router id from zebra can be manually overriden.
1358 * bgp_zebra.c: Read router id related messages from zebra daemon.
1359 Remove own code related with router id selection.
1360 * bgpd.c, bgpd.h: Remove own router id selection code. Use the one
1361 from zebra daemon if it isn't manually overriden.
1362
hassoc9e52be2004-09-26 16:09:34 +000013632004-09-26 Hasso Tepper <hasso at quagga.net>
1364
1365 * bgp_aspath.c, bgp_packet.c, bgp_vty.c: Fix compiler warnings.
1366
hasso52dc7ee2004-09-23 19:18:23 +000013672004-09-23 Hasso Tepper <hasso at quagga.net>
1368
1369 * *.[c|h]: list -> struct list *, listnode -> struct listnode *.
1370
paule01f9cb2004-07-09 17:48:53 +000013712004-07-09 Paul Jakma <paul@dishone.st>
1372
1373 * Merge of GNU Zebra cvs2svn changesets r799, r800 and r807.
1374 * bgp_dump.c: (bgp_dump_attr) cleanup. return status code. check
1375 attributes present before printing.
1376 * bgp_dump.c: update bgp_dump_attr prototype.
1377 * bgp_packet.c: (bgp_update_receive) init attrstr. check status
1378 of bgp_dump_attr. Log end-of-rib UPDATEs.
1379
paulf5ba3872004-07-09 12:11:31 +000013802004-07-09 Sowmini Varadhan <sowmini.varadhan@sun.com>
1381
1382 * bgp_packet.c: (bgp_collision_detect) Send NOTIFY on new socket
1383 if that is connection we're closing.
1384 (bgp_read) invalid marker check applies to KEEPALIVE too.
1385 * bgp_route.c: Ignore multicast NRLI, dont send NOTIFY.
1386
paul5228ad22004-06-04 17:58:18 +000013872004-06-04 Paul Jakma <paul@dishone.st>
1388
1389 * type mismatch fixes
1390
hasso538621f2004-05-21 09:31:30 +000013912004-05-21 Akihiro Mizutani <mizutani@net-chef.net>
1392
1393 * bgpd.h, bgp_open.[ch], bgp_debug.c, bgp_vty.[ch], bgp_fsm.c:
1394 Graceful restart capability display.
1395
hasso3950fda2004-05-20 10:22:49 +000013962005-05-20 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1397
1398 * bgp_debug.c: Cosmetical fixes and log neighbor changes.
1399
hasso4372df72004-05-20 10:20:02 +000014002004-05-20 Akihiro Mizutani <mizutani@net-chef.net>
1401
1402 * bgp_ecommunity.c: Transit ecommunity support.
1403 * bgp_ecommunity.c: Fix for unknown community crush.
1404
hassoe0701b72004-05-20 09:19:34 +000014052005-05-20 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1406
1407 * *: Maximum prefix threshold support.
1408 * *: Reset notification fixups.
1409
paul0a589352004-05-08 11:48:26 +000014102004-05-08 Paul Jakma <paul@dishone.st>
1411
1412 * bgp_zebra.c: (bgp_interface_address_add) sync to zclient changes
1413 (bgp_interface_address_delete) ditto.
1414 (bgp_zebra_announce) ditto.
1415 (bgp_zebra_withdraw) ditto.
1416
paulc5317402004-05-03 13:25:06 +000014172004-05-03 Daniel Roesen <dr@cluenet.de>
1418
1419 * bgp_fsm.c: (bgp_stop) Reset uptime only on transition from
1420 Established so that it reflects true downtime (rather time
1421 since last transition, eg Active->Idle)
1422
paul35be31b2004-05-01 18:17:04 +000014232004-05-01 rivo nurges <rix@estpak.ee>
1424
1425 * bgp_route.c: fix UNH IOL BGP-4.1.12f
1426
pauleb821182004-05-01 08:44:08 +000014272004-05-01 Paul Jakma <paul@dishone.st>
1428
1429 * Revert the attempted clean-up of the dummy peer hack, reverts
1430 patchsets 435 (see 2004-02-17 below) and 456.
1431
paul545acaf2004-04-20 15:13:15 +000014322004-04-16 rivo nurges <rix@estpak.ee>
1433
hasso9b87e412004-04-20 16:54:49 +00001434 * bgpd.h, bgp_debug.c: update cease subcodes to
1435 draft-ietf-idr-cease-subcode-05
paul545acaf2004-04-20 15:13:15 +00001436 * bgpd.h, bgpd.c, bgp_route.c, bgp_route.h: fix UNH IOL BGP-4.1.6a
1437
paul6ad23f02004-02-17 19:45:10 +000014382004-02-17 Paul Jakma <paul@dishone.st>
1439
1440 * bgpd.h: (bgp_peer) add fd_local and fd_accept
1441 file descriptor's, fd becomes a pointer to one of these.
1442 * bgpd.c: (global) adjust for fact that fd is now a pointer.
1443 (peer_create_accept) removed.
1444 * bgp_route.c: (global) adjust for change of peer fd to pointer
1445 * bgp_packet.c: (bgp_collision_detect) adjust and remove the
1446 "replace with other peer" hack.
1447 * bgp_network.c: (bgp_accept) Remove the dummy peer hack.
1448 Update peer->fd_accept instead.
1449 (global) Adjust fd references - now a pointer.
1450 * bgp_fsm.c: (global) adjust peer fd to pointer.
1451 (bgp_connection_stop) new function, to stop connection.
1452 (global) adjust everything which closed peer fd to use
1453 bgp_connection_stop().
1454
gdt10d60ad2003-12-23 17:34:39 +000014552003-12-23 Krzysztof Oledzki <oleq@ans.pl>
1456
1457 * bgp_network.c: drop privs on error cases
1458
paul6ad23f02004-02-17 19:45:10 +000014592003-08-11 kunihiro <kunihiro@zebra.org>
paulac41b2a2003-08-12 05:32:27 +00001460
1461 * bgp_route{,map}.c: Extend 'set ip next-hop' in route-maps with
1462 ability to specify 'peer-address' rather than IP.
1463
paul9238b1e2003-06-11 08:03:08 +000014642003-06-09 Paul Jakma <paul@dishone.st>
1465
1466 * bgp_clist.c (community_list_delete): honour deny statements
1467
paul445f1432003-05-16 19:00:31 +000014682003-04-19 Hasso Tepper <hasso@estpak.ee>
1469
1470 * rip_routemap.c: sync daemon's route-map commands to have same
1471 syntax
1472
14732003-01-09 Akihiro Mizutani <mizutani@net-chef.net>
1474
1475 * bgp_routemap.c: Add match extcommunity command.
1476
paul718e3742002-12-13 20:15:29 +000014772002-10-23 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1478
1479 * bgp_aspath.c (aspath_init): Extend hash size from default to
1480 32767.
1481 (aspath_key_make): Use unsigned shoft for making hash. Suggested
1482 by: Marc Evans <Marc@SoftwareHackery.Com>
1483
14842002-08-19 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1485
1486 * bgp_clist.c (community_entry_free): Fix memory leak of standard
1487 extcommunity-list config string.
1488
14892002-08-19 Akihiro Mizutani <mizutani@net-chef.net>
1490
1491 * bgp_route.c (route_vty_out_detail): Fix bug of router-id display
1492 when multiple instance is used.
1493
14942002-08-18 Akihiro Mizutani <mizutani@net-chef.net>
1495
1496 * bgpd.c: Make "default-originate" and "maximum-prefix" commands
1497 available in peer-group configuration.
1498
14992002-08-13 Akihiro Mizutani <mizutani@net-chef.net>
1500
1501 * bgp_packet.c (bgp_open_send): Put Opt Parm Len 0 when last
1502 capability packet cause error or dont-capability-negotiate option
1503 is specified.
1504
15052002-07-07 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1506
1507 * zebra-0.93 released.
1508
15092001-10-28 Kunihiro Ishiguro <kunihiro@zebra.org>
1510
1511 * bgpd.c (bgp_vty_init): Translate update commands are removed.
1512
15132001-10-10 Kunihiro Ishiguro <kunihiro@zebra.org>
1514
1515 * bgp_route.c (bgp_static_set): Add workaround for BGP static
1516 route announcement when there is no zebra running.
1517
15182001-10-08 Kunihiro Ishiguro <kunihiro@zebra.org>
1519
1520 * bgpd.c (neighbor_remote_as_unicast): Remove "remote-as nlri
1521 unicast multicast" commands.
1522
15232001-09-14 Akihiro Mizutani <mizutani@dml.com>
1524
1525 * bgp_open.c: When we receive capability route-refresh, we should
1526 check we send the capability not we receive the capability.
1527
1528 * bgp_route.c (bgp_network_mask_natural_route_map): network
1529 statement route-map is added.
1530
15312001-08-31 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1532
1533 * bgp_advertise.c (bgp_advertise_intern): attr must be interned
1534 before looking up hash table.
1535
15362001-08-30 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1537
1538 * bgpd.h (struct peer): BGP filter is moved from peer_conf to
1539 peer.
1540
15412001-08-28 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1542
1543 * bgp_nexthop.c (bnc_nexthop_free): Fix next pointer bug.
1544 Suggested by: "Hong-Sung Kim" <hoskim@lanbird.co.kr>.
1545
15462001-08-26 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1547
1548 * bgp_table.c (bgp_node_create): Clearn memory before use it.
1549
15502001-08-24 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1551
1552 * Change to use bgp_table.[ch].
1553
15542001-08-23 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1555
1556 * bgpd.c (bgp_init): Add "transparent-as" and
1557 "transparent-nexthop" for old version compatibility.
1558
15592001-08-23 Akihiro Mizutani <mizutani@dml.com>
1560
1561 * bgpd.h (struct peer): default-originate route-map is added.
1562
1563 * bgp_route.c: When self originated route is advertised with
1564 attrubute-unchanged, nexthop was not properly set. This bug is
1565 fixed.
1566
15672001-08-22 Akihiro Mizutani <mizutani@dml.com>
1568
1569 * bgpd.c (neighbor_attr_unchanged): transparent-as and
1570 transparent-next-hop commands are restructured. Instead of
1571 current transparent-* commands, attribute-unchanged command is
1572 introduced.
1573
1574 neighbor A.B.C.D attribute-unchanged [as-path|next-hop|med]
1575
1576 (neighbor_default_originate): "default-originate" configuration
1577 announce default route even 0.0.0.0/0 does not exists in BGP RIB.
1578
15792001-08-19 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1580
1581 * zebra-0.92a released.
1582
15832001-08-19 Akihiro Mizutani <mizutani@dml.com>
1584
1585 * bgpd.c: AF specific soft-reconfiguration inbound commands are
1586 added.
1587
15882001-08-17 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1589
1590 * bgp_route.c (bgp_show_callback): Do not do community NULL check.
1591
1592 * bgp_community.c (community_cmp): Add check for commnunity NULL
1593 check.
1594
1595 * bgp_routemap.c (route_match_community): Do not check comunity is
1596 NULL. It may match to community-list "^$".
1597
1598 * bgp_community.c (community_match): Add check for community is
1599 NULL case.
1600
16012001-08-17 Akihiro Mizutani <mizutani@dml.com>
1602
1603 * bgpd.c: AF specific route-reflector-client and
1604 route-server-client configuration are added.
1605
16062001-08-17 Rick Payne <rickp@ayrnetworks.com>
1607
1608 * bgp_clist.c (community_match_regexp): Check special ^$ case.
1609
16102001-08-17 Akihiro Mizutani <mizutani@dml.com>
1611
1612 * bgp_clist.c (community_list_match): Fix bug of community list
1613 permit and deny check.
1614
16152001-08-16 Akihiro Mizutani <mizutani@dml.com>
1616
1617 * bgp_mplsvpn.c (bgp_mplsvpn_init): Add AF specific "nexthop-self"
1618 command.
1619
16202001-08-15 Akihiro Mizutani <mizutani@dml.com>
1621
1622 * bgpd.h (PEER_FLAG_SEND_COMMUNITY): Per AF based configuration
1623 flag is introduced.
1624
1625 * bgp_mplsvpn.c (bgp_mplsvpn_init): VPNv4 filtering is added.
1626
16272001-08-15 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1628
1629 * zebra-0.92 released.
1630
16312001-08-13 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1632
1633 * bgpd.c (bgp_delete): "no router bgp" free static, aggregate, rib
1634 table properly.
1635
16362001-08-12 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1637
1638 * bgp_route.c (bgp_node_safi): Return SAFI of current node.
1639 (bgp_config_write_network_vpnv4): VPNv4 static configuration
1640 display.
1641
16422001-08-11 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1643
1644 * bgpd.c (no_bgp_ipv4_multicast_route_map): Add IPv4 multicast
1645 node filter commands.
1646
16472001-08-11 Kunihiro Ishiguro <kunihiro@zebra.org>
1648
1649 * bgpd.h (PEER_FLAG_IGNORE_LINK_LOCAL_NEXTHOP): Add
1650 "ignore-link-local-nexthop" flag for ignore link-local nexthop for
1651 IPv6.
1652
16532001-08-07 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1654
1655 * bgpd.c (address_family_ipv4_multicast): "address-family ipv4
1656 multicast" is added.
1657 (address_family_ipv6_unicast): "address-family ipv6 unicast" is
1658 added.
1659
16602001-08-07 Akihiro Mizutani <mizutani@dml.com>
1661
1662 * bgp_route.c (bgp_process): Use flag instead of as_selected
1663 memeber in struct bgp_info.
1664
1665 * bgp_route.h (struct bgp_info): Remove as_selected memeber from
1666 struct bgp_info.
1667
16682001-07-31 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1669
1670 * bgp_route.c (bgp_announce_check): Enclose sending time AS loop
1671 check code with #ifdef BGP_SEND_ASPATH_CHECK.
1672
16732001-07-29 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1674
1675 * bgp_packet.c (bgp_withdraw_send): Simplify address family check.
1676
1677 * bgpd.h (BGP_INFO_HOLDDOWN): Introduce new macro to check BGP
1678 information is alive or not.
1679
1680 * bgp_community.c: Use community_val_get() on all OS.
1681
16822001-07-24 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1683
1684 * bgp_route.c (bgp_announce_check): Simplify set next-hop self
1685 check.
1686
16872001-07-24 Akihiro Mizutani <mizutani@dml.com>
1688
1689 * bgp_route.c (bgp_announce_check): To route server clients, we
1690 announce AS path, MED and nexthop transparently.
1691
16922001-06-21 Kunihiro Ishiguro <kunihiro@zebra.org>
1693
1694 * bgp_routemap.c (route_set_atomic_aggregate_free): Do not call
1695 XFREE. No memory is allocated in
1696 route_set_atomic_aggregate_compile().
1697
16982001-06-21 Kunihiro Ishiguro <kunihiro@zebra.org>
1699
1700 * bgp_routemap.c (bgp_route_map_init): `match nlri` and `set nlri`
1701 are replaced by `address-family ipv4` and `address-family vpnvr'.
1702
17032001-06-19 Kunihiro Ishiguro <kunihiro@zebra.org>
1704
1705 * bgp_route.c (bgp_withdraw): Add check for BGP_PEER_CONFED.
1706 Reported by Rick Payne <rickp@rossfell.co.uk>.
1707
17082001-06-17 Kunihiro Ishiguro <kunihiro@zebra.org>
1709
1710 * bgp_zebra.c (bgp_zebra_announce): When global IPv6 nexthop is
1711 empty, use socket's remote address for the nexthop.
1712
17132001-06-04 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1714
1715 * bgpd.c (peer_delete): Fix memory leak. Reported by Yosi Yarchi
1716 <Yosi_Yarchi@KereniX.com>
1717
17182001-06-01 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1719
1720 * bgpd.c (bgp_delete): Fix memory leak. Reported by Yosi Yarchi
1721 <Yosi_Yarchi@KereniX.com>
1722
17232001-05-27 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1724
1725 * bgp_route.c (bgp_route_clear_with_afi_vpnv4): Use next instead
1726 of ri->next.
1727
1728 * bgp_packet.c (bgp_withdraw_send): MPLS/VPN withdraw takes effect
1729 when HAVE_IPV6 is not defined.
1730
17312001-03-07 "Akihiro Mizutani" <mizutani@dml.com>
1732
1733 * bgpd.c (peer_timers_set): Adjust keepalive timer to fit less
1734 than holdtime / 3.
1735 (bgp_confederation_peers_unset): Only set peer->local_as when
1736 confederation is enabled.
1737 (bgp_timers): Add "timers bgp <0-65535> <0-65535>" command.
1738
1739 * bgp_route.c (bgp_announce_check): Set med of redistributed route
1740 when it is announced to EBGP peer.
1741
17422001-03-06 "Akihiro Mizutani" <mizutani@dml.com>
1743
1744 * bgp_nexthop.c (bgp_scan_ipv4): bgp_scan() call bgp_process() for
1745 all prefixes.
1746
17472001-03-06 Kunihiro Ishiguro <kunihiro@zebra.org>
1748
1749 * bgp_attr.c (bgp_attr_origin): When bgpd send NOTIFICATION with
1750 erroneous attribute (type, length and value), it does include
1751 attribute flags field.
1752
17532001-02-21 "Akihiro Mizutani" <mizutani@dml.com>
1754
1755 * bgp_route.c (bgp_announce_check): The route reflector is not
1756 allowed to modify the attributes of the reflected IBGP routes.
1757
17582001-02-20 "Akihiro Mizutani" <mizutani@dml.com>
1759
1760 * bgp_route.c (bgp_info_cmp): During path seleciton, BGP
1761 confederation peer is treated as same as IBGP peer.
1762
17632001-02-19 Kunihiro Ishiguro <kunihiro@zebra.org>
1764
1765 * bgp_route.c (bgp_redistribute_add): Initialize attr_new with
1766 attr. Call aspath_unintern when return from this function.
1767
17682001-02-19 "Akihiro Mizutani" <mizutani@dml.com>
1769
1770 * bgpd.c (bgp_router_id_set): Reset BGP peer when router-id is
1771 changed.
1772
17732001-02-18 "Akihiro Mizutani" <mizutani@dml.com>
1774
1775 * bgp_packet.c (bgp_open_receive): When user configure holdtimer,
1776 do not refrect the value to current session.
1777
17782001-02-16 Kunihiro Ishiguro <kunihiro@zebra.org>
1779
1780 * bgp_route.c (bgp_aggregate_delete): Set BGP_INFO_ATTR_CHANGE to
1781 suppress route withdraw.
1782
1783 * bgp_damp.c (bgp_damp_init): Fix bug of flap dampening.
1784
17852001-02-16 "Akihiro Mizutani" <mizutani@dml.com>
1786
1787 * bgp_aspath.c (aspath_make_str_count): Use ',' for separator for
1788 AS_SET and AS_CONFED_SET.
1789
17902001-02-15 Kunihiro Ishiguro <kunihiro@zebra.org>
1791
1792 * bgp_route.c (bgp_process): Do not consider suppress route.
1793
1794 * bgp_aspath.c (aspath_aggregate_as_set_add): Reset asset when
1795 aspath->data is realloced.
1796
17972001-02-15 "Akihiro Mizutani" <mizutani@dml.com>
1798
1799 * bgp_attr.c (bgp_attr_aggregate_intern): Do not set atomic
1800 aggregate when using as-set.
1801
18022001-02-14 "Akihiro Mizutani" <mizutani@dml.com>
1803
1804 * bgpd.c (bgp_confederation_peers_unset): Set peer's local-as
1805 correctly.
1806
1807 * bgp_route.c (bgp_update): Just ignore AS path loop for
1808 confederation peer.
1809
18102001-02-10 Kunihiro Ishiguro <kunihiro@zebra.org>
1811
1812 * bgp_route.c (bgp_aggregate_set): Add as_set argument.
1813 (bgp_aggregate_unset): Remove summary_only argument.
1814 (aggregate_address_as_set): New commands.
1815 "aggregate-address A.B.C.D/M as-set"
1816 "no aggregate-address A.B.C.D/M as-set"
1817
18182001-02-08 "Akihiro Mizutani" <mizutani@dml.com>
1819
1820 * bgp_route.c (bgp_announce_check): Do not modify nexthop when the
1821 route is passed by route reflector.
1822
18232001-02-08 Kunihiro Ishiguro <kunihiro@zebra.org>
1824
1825 * bgp_route.c: "no bgp dampening" with argument.
1826 (bgp_announce_check): Do not modify nexthop when the route is
1827 passed by route reflector.
1828
18292001-02-07 "Akihiro Mizutani" <mizutani@dml.com>
1830
1831 * bgpd.c (neighbor_passive): Change "neighbor NEIGHBOR remote-as
1832 ASN passive" to "neighbor NEIGHBOR passive".
1833 (bgp_announce_check): Check well-known community attribute even
1834 when "no neighbor send-community" is set.
1835
18362001-02-03 Kunihiro Ishiguro <kunihiro@zebra.org>
1837
1838 * bgp_fsm.c (bgp_establish): Do not send keepalive at established
1839 time when keepalive timer is configured as zero.
1840
18412001-02-01 Kunihiro Ishiguro <kunihiro@zebra.org>
1842
1843 * bgp_attr.c (bgp_attr_check): When peer is IBGP peer, local
1844 preference is well-known attribute.
1845
18462001-01-30 Kunihiro Ishiguro <kunihiro@zebra.org>
1847
1848 * zebra-0.91 is released.
1849
1850 * bgp_attr.h (struct attr): Comment out DPA value.
1851 (struct attr): Change refcnt type from int to unsinged long.
1852
1853 * bgp_attr.c (attrhash_key_make): Likewise.
1854 (attrhash_cmp): Likewise.
1855 (bgp_attr_dpa): Likewise.
1856
18572001-01-30 "Akihiro Mizutani" <mizutani@dml.com>
1858
1859 * bgp_route.c (bgp_info_cmp): Make route selection completely same
1860 as Cisco's.
1861
18622001-01-30 Kunihiro Ishiguro <kunihiro@zebra.org>
1863
1864 * bgp_attr.h (BGP_ATTR_FLAG_OPTIONAL): Rename old ATTR_FLAG_* to
1865 BGP_ATTR_FLAG_* to clarify meenings.
1866
18672001-01-30 "Akihiro Mizutani" <mizutani@dml.com>
1868
1869 * bgp_route.c (route_vty_out): Display argument to suppress same
1870 prefix information display.
1871 (route_vty_out_route): Don't display mask information for
1872 classfull network.
1873
18742001-01-30 Kunihiro Ishiguro <kunihiro@zebra.org>
1875
1876 * bgp_attr.h (SET_BITMAP): Simple bitmapping macros.
1877
1878 * bgp_attr.c (bgp_attr_parse): Use bitmap for attribute type
1879 check.
1880
18812001-01-29 Kunihiro Ishiguro <kunihiro@zebra.org>
1882
1883 * bgp_attr.c (bgp_mp_reach_parse): Enclose loggin with BGP_DEBUG.
1884 (bgp_attr_parse): Comment out well-known attribute check.
1885
18862001-01-28 Kunihiro Ishiguro <kunihiro@zebra.org>
1887
1888 * bgp_route.c (bgp_static_unset): Link-local IPv6 address can't be
1889 used for network advertisement.
1890 (nlri_parse): When link-local IPv6 address NLRI comes from
1891 remote-peer, log the information then simply ignore it.
1892
1893 * bgp_zebra.c (zebra_read_ipv6): Link-local IPv6 address is not
1894 redistributed.
1895
1896 * bgp_route.c (bgp_update): Check IPv6 global nexthop
1897 reachability.
1898
18992001-01-26 Kunihiro Ishiguro <kunihiro@zebra.org>
1900
1901 * bgp_route.c (bgp_update): Check nexthop points local address or
1902 not.
1903 (bgp_static_update_vpnv4): Set valid flag.
1904
1905 * bgp_attr.c (bgp_attr_parse): Duplicate attribute check.
1906 (bgp_attr_parse): Well-known attribute check.
1907
1908 * bgp_open.c (bgp_auth_parse): Authentication is not yet supported.
1909
1910 * bgp_packet.c (bgp_valid_marker): Check marker is synchronized.
1911
1912 * bgpd.c (clear_bgp): Send NOTIFICATION Cease when SEND_CEASE is
1913 defined.
1914
1915 * bgp_snmp.c (bgp4PathAttrTable): Fix compile error.
1916
19172001-01-24 Kunihiro Ishiguro <kunihiro@zebra.org>
1918
1919 * bgpd.c (bgp_network_import_check): New command for IGP network
1920 check.
1921
19222001-01-23 Kunihiro Ishiguro <kunihiro@zebra.org>
1923
1924 * bgp_nexthop.c (bgp_scan): Run bgp_process when IGP metric is
1925 changed. Call bgp_process once for each node.
1926
19272001-01-23 "Akihiro Mizutani" <mizutani@dml.com>
1928
1929 * bgp_route.c (bgp_info_cmp): Add IGP metric comparison.
1930
19312001-01-23 Kunihiro Ishiguro <kunihiro@zebra.org>
1932
1933 * bgp_route.c (bgp_info_cmp): Add IGP metric comparison.
1934
1935 * bgp_nexthop.c (bgp_nexthop_lookup): Set IGP metric for valid
1936 IBGP route.
1937
19382001-01-23 "Akihiro Mizutani" <mizutani@dml.com>
1939
1940 * bgp_route.c (show_ip_bgp_prefix_longer): Add new commands.
1941 "show ip bgp A.B.C.D/M longer-prefixes"
1942 "show ip bgp ipv4 (unicast|multicast) A.B.C.D/M longer-prefixes"
1943 "show ipv6 bgp X:X::X:X/M longer-prefixes"
1944 "show ipv6 mbgp X:X::X:X/M longer-prefixes"
1945
19462001-01-20 "Akihiro Mizutani" <mizutani@dml.com>
1947
1948 * bgp_route.c (show_ip_bgp_cidr_only): Add new commands.
1949 "show ip bgp cidr-only"
1950 "show ip bgp ipv4 (unicast|multicast) cidr-only"
1951
19522001-01-18 "Akihiro Mizutani" <mizutani@dml.com>
1953
1954 * bgp_route.c (bgp_update): AS path lookup check is done in
1955 bgp_update() not in attr_parse().
1956
19572001-01-18 Kunihiro Ishiguro <kunihiro@zebra.org>
1958
1959 * bgp_route.c (bgp_update): Call bgp_aggregate_decrement() just
1960 before bgp_attr_unintern().
1961
19622001-01-17 Kunihiro Ishiguro <kunihiro@zebra.org>
1963
1964 * bgp_route.c (bgp_update): Now intern is performed very last part
1965 of the BGP packet update procedure.
1966
19672001-01-17 "Akihiro Mizutani" <mizutani@dml.com>
1968
1969 * bgp_route.c (bgp_update): When implicit withdraw occur, reuse
1970 existing bgp_info structure.
1971
19722001-01-17 Kunihiro Ishiguro <kunihiro@zebra.org>
1973
1974 * bgp_route.c (bgp_aggregate_decrement): Fix bug of aggregate
1975 address matching method.
1976 (bgp_update):
1977
1978 * bgp_nexthop.c (bgp_nexthop_onlink): Separate EBGP nexthop onlink
1979 check and IBGP nexthop route check.
1980
19812001-01-16 "Akihiro Mizutani" <mizutani@dml.com>
1982
1983 * bgp_route.h (BGP_INFO_ATRR_CHANGED): Added for track attribute
1984 change.
1985
19862001-01-16 Kunihiro Ishiguro <kunihiro@zebra.org>
1987
1988 * bgp_route.h (struct bgp_info): Remove selected flag. Use
1989 BGP_INFO_SELECTED for flags instead.
1990 (struct bgp_info): Remove valid flag. Use BGP_INFO_VALID for
1991 flags instead.
1992 (struct bgp_info): Add igpmetric for IBGP route nexthop IGP
1993 metric.
1994 (struct bgp_info_tab): Struct bgp_info_tag is integrated into
1995 struct bgp_info.
1996 (BGP_INFO_ATRR_CHANGED): Added for track attribute change.
1997
1998 * bgp_community.c (community_val_get): gcc-2.95 on
1999 sparc-sun-solaris cause crush. This function is for avoid the
2000 crush.
2001
20022001-01-15 Kunihiro Ishiguro <kunihiro@zebra.org>
2003
2004 * bgp_packet.c (bgp_open_receive): Translated peer's packet_size
2005 clear bug is fixed.
2006
20072001-01-14 "Akihiro Mizutani" <mizutani@dml.com>
2008
2009 * bgp_packet.c (bgp_open_receive): Return notification with
2010 supported version number.
2011
20122001-01-13 Kunihiro Ishiguro <kunihiro@zebra.org>
2013
2014 * bgpd.c (bgp_show_summary): Display AS path and community
2015 entries. Suggested by: "Matt Ranney" <mjr@ranney.com>.
2016
2017 * bgp_packet.c (bgp_read_packet): Fix bug of unblocking BGP socket
2018 read. When BGP packet read is partial, we must get size and type
2019 from packet again.
2020
20212001-01-12 "Akihiro Mizutani" <mizutani@dml.com>
2022
2023 * bgp_route.c (bgp_update): Do not unset BGP_INFO_HISTORY flag.
2024 (bgp_update): When there is a history entry increment route count.
2025 (bgp_damp_set): Check BGP_CONFIG_DAMPENING flag.
2026
2027 * bgp_damp.c (bgp_damp_withdraw): Set status to
2028 BGP_DAMP_DISCONTINUE.
2029
20302001-01-11 Kunihiro Ishiguro <kunihiro@zebra.org>
2031
2032 * bgp_attr.c (bgp_mp_reach_parse): Fix warning code when second
2033 IPv6 nexthop is not link-local addresss.
2034
20352001-01-11 "Akihiro Mizutani" <mizutani@dml.com>
2036
2037 * bgp_damp.c (bgp_config_write_damp): Smart flap dampening
2038 configuration display.
2039 (bgp_damp_info_print): Display elapsed time from flap started.
2040
2041 * bgp_damp.h (struct bgp_damp_info): Add flap start time.
2042
2043 * bgpd.c (peer_create): Set last read time.
2044 (bgp_show_peer): Display last read time.
2045 (bgp_show_summary): Use BGP_CONFIG_DAMPENING flag to check
2046 configuration.
2047
2048 * bgpd.h (BGP_CONFIG_DAMPENING): Add new configuration option.
2049 (struct peer): Add last read time member.
2050 (BGP_VERSION_MP_4): Remove obsolete definition.
2051
20522001-01-10 Kunihiro Ishiguro <kunihiro@zebra.org>
2053
2054 * bgp_nexthop.c: Remove OLD_RIB codes.
2055
2056 * bgp_route.c (bgp_process): Likewise.
2057
2058 * zebra-0.90 is released.
2059
2060 * bgp_route.h (BGP_INFO_HISTORY): Remove damped member from struct
2061 bgp_info. Instead of that use BGP_INFO_DAMPED flag.
2062 (struct bgp_info): Remove invalid member from struct bgp_info.
2063 Instead of that use BGP_INFO_HISTORY flag.
2064
20652001-01-10 "Akihiro Mizutani" <mizutani@dml.com>
2066
2067 * bgp_damp.c (bgp_damp_info_print): New function to display
2068 dampening status.
2069 (DEFAULT_HARF_LIFE): Define default value.
2070 (DEFAULT_REUSE): Likewise.
2071 (DEFAULT_SUPPRESS): Likewise.
2072 (bgp_config_write_damp): When config value is same as default
2073 value, simply display "bgp dampening" to configuration.
2074
2075 * bgp_damp.h (struct bgp_damp_info): Add flap member.
2076
2077 * bgp_route.h (struct bgp_info): Added for BGP flap dampening
2078 history status.
2079
20802001-01-10 Kunihiro Ishiguro <kunihiro@zebra.org>
2081
2082 * bgp_nexthop.c (bgp_connected_add): Point-to-point connected
2083 address is properly handled.
2084 (bgp_connected_delete): Likewise.
2085
2086 * bgp_route.c (bgp_route_init): Turn off BGP Flap dampening code
2087 until it works fine.
2088
20892001-01-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2090
2091 * bgpd.c (bgp_show_summary): Add BGP_VERSION_MP_4 case.
2092
2093 * bgp_route.c (bgp_update): When this is not damped route, clear
2094 ri pointer.
2095
20962001-01-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2097
2098 * bgp_main.c: Add "-n" no_kernel option to not install route to
2099 kernel. Suggested by: "Matt Ranney" <mjr@ranney.com>
2100
21012001-01-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2102
2103 * bgp_nexthop.c (bgp_connected_add): Revert point-to-point
2104 connected route patch. Reported by ruud@ruud.org (Ruud de Rooij)
2105
2106 * bgp_damp.c (bgp_config_write_damp): Add configuration display
2107 function.
2108
2109 * bgp_route.c (bgp_info_free): Set NULL to BGP dampening
2110 information when BGP info structure is freed.
2111 (bgp_info_cmp): Check damped flag.
2112 (bgp_announce_check): Damped route is not announced.
2113
21142001-01-09 "Akihiro Mizutani" <mizutani@dml.com>
2115
2116 * bgpd.c (neighbor_capability_route_refresh): Change "neighbor
2117 route-refresh" command to "neighbor capability route-refresh".
2118 (clear_bgp_soft_in): Change soft-reconfig method.
2119
2120 clear ip bgp <neighbor> soft in
2121 --------------------------------------
2122 Try stored cache first then route-refresh
2123
2124 clear ip bgp <neighbor> in
2125 ---------------------------------
2126 Try route-refresh first then try to use stored cache
2127
21282001-01-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2129
2130 * bgp_nexthop.c (bgp_connected_add): Check point-to-point
2131 connected route. Reported by ruud@ruud.org (Ruud de Rooij)
2132
21332001-01-08 Kunihiro Ishiguro <kunihiro@zebra.org>
2134
2135 * bgp_nexthop.c (bgp_nexthop_lookup): When IBGP nexthop is
2136 changed, refresh it.
2137
21382001-01-04 Kunihiro Ishiguro <kunihiro@zebra.org>
2139
2140 * bgp_route.h (struct bgp_info_tag): Add as_selected to
2141 bgp_info_tag.
2142
21432001-01-03 Kunihiro Ishiguro <kunihiro@zebra.org>
2144
2145 * bgp_route.h (struct bgp_info_tag): Add damped and bgp_damp_info
2146 member for BGP flap dampening.
2147
2148 * bgp_damp.c: New file is added.
2149
2150 * bgp_damp.h: Likewise.
2151
21522001-01-01 Kunihiro Ishiguro <kunihiro@zebra.org>
2153
2154 * bgpd.h (BGP_VTYSH_PATH): Change "/tmp/bgpd" to "/tmp/.bgpd".
2155
21562000-12-29 Kunihiro Ishiguro <kunihiro@zebra.org>
2157
2158 * bgp_nexthop.c (zlookup_connect): Change to use UNIX domain
2159 socket for zebra communication.
2160
21612000-12-29 Akihiro Mizutani <mizutani@dml.com>
2162
2163 * bgp_route.c (bgp_process): Fix "bgp deterministic-med" process.
2164
21652000-12-27 Akihiro Mizutani <mizutani@dml.com>
2166
2167 * bgp_route.c (bgp_process): Add "bgp deterministic-med" process.
2168
21692000-12-25 Akihiro Mizutani <mizutani@dml.com>
2170
2171 * bgp_route.c (bgp_info_cmp): Use ntohl comparing router ID.
2172
21732000-12-18 Akihiro Mizutani <mizutani@dml.com>
2174
2175 * bgp_route.c (bgp_info_cmp): When over three same prefix exit,
2176 withdrawing best prefix perform router ID comparison.
2177
21782000-12-15 Akihiro Mizutani <mizutani@dml.com>
2179
2180 * bgp_route.c (bgp_info_cmp): Do not compare router ID when the
2181 routes comes from EBGP peer. When originator ID is same, take
2182 shorter cluster-list route. If cluster-list is same take smaller
2183 IP address neighbor's route.
2184
2185 * bgpd.c (bgp_bestpath_aspath_ignore): Add "bgp bestpath as-path
2186 ignore" command. When this option is set, do not concider AS path
2187 length when route selection.
2188 (bgp_bestpath_compare_router_id): Add "bgp bestpath
2189 compare-routerid". When this option is set, compare router ID
2190 when the routes comes from EBGP peer.
2191
21922000-12-15 Akihiro Mizutani <mizutani@dml.com>
2193
2194 * bgp_route.c (bgp_info_cmp): Compare originator ID when it is
2195 available.
2196
21972000-12-14 Akihiro Mizutani <mizutani@dml.com>
2198
2199 * bgp_packet.c (bgp_notify_receive): Disply received Notify data
2200 information.
2201
22022000-12-14 Kunihiro Ishiguro <kunihiro@zebra.org>
2203
2204 * bgp_filter.c (as_filter_free): Use MTYPE_AS_FILTER_STR to make
2205 it sure the memory is freed.
2206
2207 * bgp_route.c (route_vty_out_detail): Do not use AF_INET6 outside
2208 HAVE_IPV6.
2209
22102000-12-08 Akihiro Mizutani <mizutani@dml.com>
2211
2212 * bgp_packet.c (bgp_notify_send_with_data): Store BGP notification
2213 data part.
2214
2215 * bgp_network.c (bgp_accept): When BGP connection comes from
2216 unconfigured IP address, close socket immediately.
2217
2218 * bgpd.c: Fix some display format.
2219
22202000-11-29 Kunihiro Ishiguro <kunihiro@zebra.org>
2221
2222 * bgp_packet.c (bgp_keepalive_send): Delete duplicate
2223 bgp_packet_set_size () call.
2224
22252000-11-28 Kunihiro Ishiguro <kunihiro@zebra.org>
2226
2227 * bgp_packet.c (bgp_read_packet): Remove debug codes.
2228
22292000-11-27 Kunihiro Ishiguro <kunihiro@zebra.org>
2230
2231 * bgp_snmp.c (write_bgpPeerTable): Add SNMP set method routine.
2232
2233 * bgp_fsm.c (bgp_stop): Use fsm_change_status to change peer's
2234 status.
2235 (bgp_establish): Likewise.
2236
22372000-11-26 Akihiro Mizutani <mizutani@dml.com>
2238
2239 * bgp_open.c: Fix error messages.
2240
22412000-11-25 Kunihiro Ishiguro <kunihiro@zebra.org>
2242
2243 * bgp_fsm.c (bgp_establish): Call BGP trap when the peer is
2244 established.
2245 (bgp_stop): Call BGP trap when the peer is dropped.
2246
22472000-11-24 Kunihiro Ishiguro <kunihiro@zebra.org>
2248
2249 * bgp_snmp.c (bgp4PathAttrTable): Return BGP path attribute table.
2250
2251 * bgpd.h (struct peer): Add update_time for track last update
2252 received time.
2253
2254 * bgp_packet.c (bgp_notify_receive): Preserv notify code and sub
2255 code in any case.
2256
2257 * bgp_snmp.c (bgpPeerTable): Return remote router ID instead of
2258 peering IP address.
2259 (bgpPeerTable): Return actual BGP version number.
2260
22612000-11-22 Akihiro Mizutani <mizutani@dml.com>
2262
2263 * bgp_debug.c (bgp_notify_print): Notify data length display bug
2264 is fixed.
2265
22662000-11-16 Kunihiro Ishiguro <kunihiro@zebra.org>
2267
2268 * bgp_nexthop.c (zlookup_connect): When UNIX domain connection to
2269 zebra is enabled, use the method.
2270
22712000-11-16 Akihiro Mizutani <mizutani@dml.com>
2272
2273 * bgpd.c: Revise debug message output.
2274
22752000-11-15 Akihiro Mizutani <mizutani@dml.com>
2276
2277 * bgp_clist.c (ip_community_list): Fix bug of string comparison.
2278
22792000-11-14 Akihiro Mizutani <mizutani@dml.com>
2280
2281 * bgp_community.c (community_match): Fix bug of memcmp return
2282 value check.
2283
22842000-11-07 Kunihiro Ishiguro <kunihiro@zebra.org>
2285
2286 * bgp_clist.c (community_list_match_exact): Add check for
2287 entry->style is COMMUNITY_LIST.
2288 (community_match_regexp): Apply new com_nthval macro.
2289
22902000-11-07 Rick Payne <rickp@rossfell.co.uk>
2291
2292 * bgp_routemap.c (route_set_community_delete): "set
2293 community-delete COMMUNITY-LIST" is added.
2294
2295 * bgp_community.c (community_del_val): Delete one community.
2296 (community_delete): Delete all community included in list.
2297 (community_match): Fix bug of matching community value.
2298
2299 * bgp_clist.c (community_entry_free): Free community regular
2300 expression.
2301 (community_entry_make): Default style is COMMUNITY_LIST.
2302 (community_entry_lookup): Make it sure style is COMMUNITY_LIST.
2303 (community_entry_regexp_lookup): New function for community
2304 regular expression lookup.
2305 (community_match_regexp): New function.
2306 (community_delete_regexp): New function.
2307 (community_list_delete_entries): New function.
2308 (community_list_match): Add COMMUNITY_REGEXP treatment.
2309 (community_list_match_exact): Likewise.
2310 (config_write_community): Write community list according to
2311 entry->style.
2312
23132000-11-07 Rick Payne <rickp@rossfell.co.uk>
2314
2315 * bgp_attr.c (bgp_attr_aspath): AS path first AS check.
2316
2317 * bgp_clist.c (struct community_entry): Add style, regexp, reg to
2318 community_entry.
2319
23202000-11-06 Rick Payne <rickp@rossfell.co.uk>
2321
2322 * bgp_aspath.c (aspath_firstas_check): AS path first AS check.
2323
2324 * bgpd.c (bgp_enforce_first_as): New command "bgp
2325 enforce-first-as".
2326
2327 * bgpd.h (BGP_CONFIG_ENFORCE_FIRST_AS): Add new flag.
2328
23292000-11-06 Kunihiro Ishiguro <kunihiro@zebra.org>
2330
2331 * bgp_community.c (community_compare): Copy byte stream data to
2332 actual value instead of using type casting hack.
2333 (community_add_val): Likewise.
2334 (community_uniq_sort): Likewise.
2335 (community_print): Likewise.
2336 (community_print_vty): Likewise.
2337 (community_include): Use memcmp to compare community value.
2338
2339 * bgp_community.h (com_lastval): com_lastval and com_nthval macro
2340 return pointer.
2341
23422000-11-06 Akihiro Mizutani <mizutani@dml.com>
2343
2344 * bgpd.h (struct peer): Add established and dropped member for
2345 count peering up/down statistics.
2346
2347 * bgpd.c (bgp_show_peer): Display peering up/down statistics.
2348
2349 * bgp_fsm.c (bgp_establish): Increment established count.
2350 (bgp_stop): Increment dropped count.
2351
2352 * bgp_packet.c (bgp_notify_receive): Increament notify count.
2353
23542000-11-1 Akihiro Mizutani <mizutani@dml.com>
2355
2356 * bgp_fsm.c: Fix bug of holdtimer is not reset when bgp cleared.
2357
23582000-10-31 Kunihiro Ishiguro <kunihiro@zebra.org>
2359
2360 * bgpd.h: Static bit flag is set by (1 << DIGIT).
2361
23622000-10-24 Akihiro Mizutani <mizutani@dml.com>
2363
2364 * bgp_ecommunity.c (ecommunity_dup): Extended community display
2365 format fix.
2366
23672000-10-24 Arkadiusz Miskiewicz <misiek@pld.org.pl>
2368
2369 * bgp_network.c (bgp_serv_sock_addrinfo): Use gai_strerror.
2370 (bgp_serv_sock_addrinfo): Check address family.
2371
23722000-10-23 Jochen Friedrich <jochen@scram.de>
2373
2374 * bgp_snmp.c: bgp_oid and bgpd_oid are used in smux_open after it
2375 is registered. So those variables must be static.
2376
23772000-10-23 Akihiro Mizutani <mizutani@dml.com>
2378
2379 * bgp_routemap.c (route_match_ip_next_hop): Change "match ip
2380 next-hop" argument from IP address to access-list name.
2381 Remove zebra-0.88 compatibility commands.
2382 "match ip prefix-list WORD"
2383 "match ipv6 prefix-list WORD"
2384
23852000-10-23 Kunihiro Ishiguro <kunihiro@zebra.org>
2386
2387 * bgp_routemap.c (route_match_ipv6_next_hop_compile): Fix bug of
2388 passing the pointer to the pointer of struct in6_addr instead of
2389 the pointer of struct in6_addr in "match ipv6 next-hop" command.
2390
2391 * bgp_route.c (bgp_announce_check): Enclose IPv6 part with
2392 HAVE_IPV6.
2393
23942000-10-20 Jasper Wallace <jasper@ivision.co.uk>
2395
2396 * bgp_snmp.c (bgpPeerTable): ntohs missing bug is fixed. Change
2397 to use linklist.c. Define COUNTER32 as ASN_COUNTER.
2398
23992000-10-18 Kunihiro Ishiguro <kunihiro@zebra.org>
2400
2401 * bgp_route.c (bgp_announce_check): attr->nexthop empty check
2402 should be done by attr->nexthop.s_addr instead of strcmp.
2403
24042000-10-18 Akihiro Mizutani <mizutani@dml.com>
2405
2406 * bgp_zebra.c (zebra_read_ipv4): Pass nexthop value to
2407 bgp_redistribute_add().
2408
2409 * bgp_nexthop.c (bgp_multiaccess_check_v4): New function for
2410 checking IPv4 multiaccess nexthop.
2411
2412 * bgp_route.c (bgp_announce_check): In case of the nexthop is
2413 reachable on multiaccess media, do not change nexthop.
2414 (bgp_redistribute_add): Set nexthop when the value is passed.
2415
24162000-10-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2417
2418 * bgp_fsm.c (bgp_timer_set): If peer is passive mode, do not set
2419 connect timer.
2420 (bgp_start): If the peer is passive mode, force to move to Active
2421 mode.
2422
24232000-10-17 Horms <horms@vergenet.net>
2424
2425 * bgp_debug.c (debug_bgp_fsm): Fix typo.
2426
24272000-10-17 Akihiro Mizutani <mizutani@dml.com>
2428
2429 * bgp_route.c: "show ipv6 bgp" route display improvement.
2430
24312000-10-03 Kunihiro Ishiguro <kunihiro@zebra.org>
2432
2433 * bgp_route.c (neighbor_routes): Allocate sockunion for callback
2434 function.
2435 (bgp_show_neighbor_route): Remove static declaration for union
2436 sockunion.
2437
2438 * bgpd.c (peer_update_source_set): Clean previously allocated
2439 memory before allocate new one.
2440
24412000-10-03 Akihiro Mizutani <mizutani@dml.com>
2442
2443 * bgp_route.c (neighbor_routes): Add show neighbor's routes
2444 command.
2445 "show ip bgp neighbors (A.B.C.D|X:X::X:X) routes"
2446 "show ip bgp ipv4 (unicast|multicast) neighbors (A.B.C.D|X:X::X:X) routes"
2447 "show ipv6 bgp neighbors (A.B.C.D|X:X::X:X) routes"
2448 "show ipv6 mbgp neighbors (A.B.C.D|X:X::X:X) routes"
2449
24502000-10-02 Kunihiro Ishiguro <kunihiro@zebra.org>
2451
2452 * zebra-0.89 is released.
2453
24542000-10-02 Akihiro Mizutani <mizutani@dml.com>
2455
2456 * bgpd.c: "bgp deterministic-med" command is added.
2457
24582000-10-02 Kunihiro Ishiguro <kunihiro@zebra.org>
2459
2460 * bgp_nexthop.c (bgp_connected_add): Apply mask for connected
2461 route addition and deletion.
2462
24632000-09-29 Kunihiro Ishiguro <kunihiro@zebra.org>
2464
2465 * bgp_aspath.c (aspath_cmp_left): Skip confederation AS segment
2466 when comparing leftmost AS number.
2467
24682000-09-29 Akihiro Mizutani <mizutani@dml.com>
2469
2470 * bgpd.c (peer_route_reflector): Route reflector can be set for
2471 IBGP peer.
2472 (bgp_distribute_set): Fix bug of string check for (in|out).
2473 (bgp_show_summary): Display total neighbor count.
2474
24752000-09-28 Akihiro Mizutani <mizutani@dml.com>
2476
2477 * bgp_attr.c (bgp_packet_attribute): Only add cluster_list and
2478 originator for clinet to client routes.
2479 (bgp_packet_attribute): Add new cluster_list to the beginning of
2480 existing cluster_list.
2481 (bgp_packet_attribute): Fix bug of originator is rewritten even
2482 when originator is already set.
2483
24842000-09-27 Kunihiro Ishiguro <kunihiro@zebra.org>
2485
2486 * bgpd.c (bgp_client_to_client_reflection): Add new command.
2487 "no bgp client-to-client reflection"
2488 "bgp client-to-client reflection"
2489
2490 * bgpd.h (BGP_CONFIG_NO_CLIENT_TO_CLIENT): Add new definition.
2491
24922000-09-26 Kunihiro Ishiguro <kunihiro@zebra.org>
2493
2494 * bgp_packet.c (bgp_read): Make BGP packet read to non-blocking
2495 read.
2496 (bgp_read_packet): Likewise.
2497 (bgp_read_packet): When errono is EAGAIN, try to read it again.
2498
2499 * bgp_fsm.c (bgp_stop): Clear packet size and read buffer.
2500
25012000-09-26 Akihiro Mizutani <mizutani@dml.com>
2502
2503 * bgp_routemap.c: Configuration of prefix-list match is shown as
2504 "match ip address prefix-list <WORD>". Old configuration "match
2505 ip prefix-list <WORD>" is left for compatibilitty.
2506
25072000-09-25 Akihiro Mizutani <mizutani@dml.com>
2508
2509 * bgpd.h (BGP_CONFIG_MED_MISSING_AS_WORST): Changed from
2510 BGP_CONFIG_MISSING_AS_WORST.
2511
2512 * bgpd.c (bgp_bestpath_med): Change missing-as-worst syntax.
2513 Old "bgp bestpath missing-as-worst"
2514 New "bgp bestpath med missing-as-worst"
2515
25162000-09-24 Akihiro Mizutani <mizutani@dml.com>
2517
2518 * bgp_route.c: Compare MED properly in case of CONFED-IBGP.
2519
25202000-09-21 steve@Watt.COM (Steve Watt)
2521
2522 * bgp_debug.h: Do not declare debug variables conf_bgp_debug_* and
2523 term_bgp_debug_*.
2524
2525 * bgp_debug.c: Declare variables here.
2526
25272000-09-21 Akihiro Mizutani <mizutani@dml.com>
2528
2529 * bgpd.c: MBGP soft-reconfiguration command is added.
2530 clear ip bgp x.x.x.x ipv4 (unicast|multicast) in
2531 clear ip bgp x.x.x.x ipv4 (unicast|multicast) out
2532 clear ip bgp x.x.x.x ipv4 (unicast|multicast) soft
2533 clear ip bgp <1-65535> ipv4 (unicast|multicast) in
2534 clear ip bgp <1-65535> ipv4 (unicast|multicast) out
2535 clear ip bgp <1-65535> ipv4 (unicast|multicast) soft
2536 clear ip bgp * ipv4 (unicast|multicast) in
2537 clear ip bgp * ipv4 (unicast|multicast) out
2538 clear ip bgp * ipv4 (unicast|multicast) soft
2539
2540 Change "clear ip bgp vpnv4 x.x.x.x soft" command to
2541 "clear ip bgp x.x.x.x vpnv4 unicast soft".
2542
2543 "bgp bestpath med confed" command is added.
2544
2545 * bgpd.h (BGP_CONFIG_MED_CONFED): Add New definition.
2546
25472000-09-18 Rick Payne <rickp@rossfell.co.uk>
2548
2549 * bgpd.c (bgp_show_peer): Fix misplaced #endif.
2550
25512000-09-12 Akihiro Mizutani <mizutani@dml.com>
2552
2553 * bgpd.c (bgp_default_local_preference): Add "bgp default
2554 local-preference" command.
2555
2556 * bgp_nexthop.c (no_bgp_scan_time): Add "no bgp scan-time"
2557 command.
2558
25592000-09-10 Kunihiro Ishiguro <kunihiro@zebra.org>
2560
2561 * bgp_zebra.c (bgp_zebra_announce): BGP confederation peer's routes
2562 are passed to zebra like IBGP route.
2563
25642000-09-10 Akihiro Mizutani <mizutani@dml.com>
2565
2566 * bgpd.c (bgp_config_write_peer): Make it consistent passive
2567 configuration.
2568
2569 * bgp_route.c: Community match command is added.
2570 "show ip bgp community <val>"
2571 "show ip bgp community <val> exact-match"
2572
25732000-09-08 Kunihiro Ishiguro <kunihiro@zebra.org>
2574
2575 * bgp_nexthop.c (bgp_nexthop_lookup): ebgp-multihop routes are
2576 treated as IBGP routes.
2577
25782000-09-08 Akihiro Mizutani <mizutani@dml.com>
2579
2580 * bgp_route.c (bgp_show_route): When local-AS community route is
2581 selected, display "not advertised outside local AS" to "show ip
2582 route A.B.C.D" output.
2583 (show_ip_bgp_ipv4_filter_list): Add below four commands.
2584 "show ip bgp ipv4 (unicast|multicast) filter-list WORD"
2585 "show ip bgp ipv4 (unicast|multicast) community"
2586 "show ip bgp ipv4 (unicast|multicast) community-list WORD"
2587 "show ip bgp ipv4 (unicast|multicast) community-list WORD exact-match"
2588
2589 * bgp_clist.c (community_list_match_exact): Community exact match
2590 function.
2591
25922000-09-07 Kunihiro Ishiguro <kunihiro@zebra.org>
2593
2594 * bgp_route.c (bgp_update): Add peer's ttl check.
2595
2596 * bgpd.h (struct peer): Structure member refresh is renamed to
2597 refresh_adv.
2598
2599 * bgpd.c (clear_bgp_soft_in): Check PEER_FLAG_ROUTE_REFRESH flag
2600 when soft reconfiguration is performed.
2601
2602 * bgp_zebra.c (bgp_zebra_announce): When the peer is EBGP and
2603 ebgp-multiphop is set, set ZEBRA_FLAG_INTERNAL for nexthop lookup.
2604
2605 * bgp_route.h (struct bgp_info_tag): Add valid flag.
2606
26072000-08-25 Akihiro Mizutani <mizutani@dml.com>
2608
2609 * bgpd.c: Add AS base BGP soft reconfiguration.
2610
2611 * bgp_route.c: When no-advertise or no-export route is selected,
2612 "show ip bgp" display "not advertised to EBGP peer" or "not
2613 advertised to any peer" message.
2614
26152000-08-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2616
2617 * zebra-0.88 is released.
2618
2619 * bgp_dump.c (dump_bgp_routes): Change "dump bgp routes" to "dump
2620 bgp route-mrt" to support MRT specific dump format.
2621
2622 * bgpd.c (bgp_init): "clear ip bgp vpnv4 soft {in,out}" command is
2623 added.
2624
2625 * bgp_route.c (bgp_update): Currently nexthop check is only works
2626 for IPv4.
2627
26282000-08-17 Akihiro Mizutani <mizutani@dml.com>
2629
2630 * bgpd. (clear_ip_bgp_all_soft): Add "clear ip bgp * soft" for
2631 both inbound and outbound soft reconfiguration.
2632
26332000-08-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2634
2635 * bgpd.c (clear_ip_bgp_peer_soft_out): Add soft-reconfiguration
2636 outbound.
2637 (peer_new): Set route-refresh flag.
2638
26392000-08-16 Akihiro Mizutani <mizutani@dml.com>
2640
2641 * bgpd.c: "no bgp router-id A.B.C.D" alias is added. "no bgp
2642 cluster-id A.B.C.D" alias is added. " bgp cluster-id
2643 <1-4294967295>" alias is added. "clear ip bgp * soft in" command
2644 is added. "clear ip bgp A.B.C.D in" alias is added. "clear ip
2645 bgp * in" alias is added.
2646
26472000-08-16 Kunihiro Ishiguro <kunihiro@zebra.org>
2648
2649 * bgp_route.c (bgp_update): Add soft_reconfig flag. When the flag
2650 is set do not install the route into Adj-RIBs-In.
2651 (bgp_update): Perform implicit withdraw before filtering of the
2652 route.
2653
2654 * bgp_packet.c (bgp_read): draft-ietf-idr-bgp-route-refresh-01.txt
2655 capability code and BGP message can be accepted.
2656
2657 * bgp_open.c (bgp_capability_parse): Likewise.
2658
2659 * bgp_route.c (bgp_refresh_table): New function for route refresh.
2660 (bgp_refresh_rib): Likewise.
2661
2662 * bgpd.c (bgp_show_peer): Display route refresh status.
2663
2664 * bgp_route.c (bgp_aggregate_add): Add check for the route
2665 validness.
2666 (bgp_aggregate_delete): Likewise.
2667
26682000-08-15 Kunihiro Ishiguro <kunihiro@zebra.org>
2669
2670 * bgp_nexthop.c (bgp_scan): Care for aggregate route when the
2671 route become inaccessible.
2672
26732000-08-15 Akihiro Mizutani <mizutani@dml.com>
2674
2675 * bgp_route.c (show_ip_bgp_prefix): "show ip bgp A.B.C.D/M"
2676 command is added.
2677
26782000-08-15 Kunihiro Ishiguro <kunihiro@zebra.org>
2679
2680 * bgp_zebra.c (bgp_interface_up): Register connected route.
2681 (bgp_interface_down): Unregister connected route.
2682
26832000-08-14 Kunihiro Ishiguro <kunihiro@zebra.org>
2684
2685 * bgp_route.h (struct bgp_info): Add distance to the structure.
2686
2687 * bgp_route.c (bgp_aggregate_increment): Aggregate route only
2688 match to smaller prefixlen route not match same prefixlen route.
2689 (bgp_aggregate_decrement): Likewise.
2690 (bgp_aggregate_add): Likewise.
2691 (bgp_aggregate_delete): Likewise.
2692 (bgp_network_backdoor): Add backdoor network configuration.
2693
2694 * bgpd.h (struct bgp ): Add distance_{ebgp,ibgp,local} for store
2695 configuration distance value.
2696
2697 * bgp_route.c (bgp_update): Filter EBGP route which has non
2698 connected nexthop.
2699
2700 * bgp_attr.c (bgp_attr_aggregate_intern): New function for
2701 aggregate route. Set origin to IGP. Set atomic aggregate flag.
2702 Set aggregator AS and address.
2703 (bgp_attr_aggregate_intern): Check BGP_CONFIG_CONFEDERATION when
2704 filling aggregator_as.
2705
2706 * bgp_route.c (bgp_process): Delete suppress check for install
2707 suppressed route into local routing table.
2708 (bgp_aggregate_increment): Use bgp_attr_aggregate_intern() instead
2709 of bgp_attr_default_intern ().
2710 (bgp_aggregate_add): Likewise.
2711
2712 * bgpd.c (bgp_get): Call bgp_if_update_all() after BGP instance is
2713 created. This is for avoid 0.0.0.0 router-id.
2714
27152000-08-13 Akihiro Mizutani <mizutani@dml.com>
2716
2717 * bgp_route.c (route_vty_out_detail): Display "valid" when the
2718 route is valied. Display "aggregated" when the route is
2719 aggregated. "Advertisements suppressed by an aggregate" is
2720 displayed when the route is suppressed.
2721 (bgp_info_cmp): Prefer EBGP than Confed-EBGP.
2722
27232000-08-10 Akihiro Mizutani <mizutani@dml.com>
2724
2725 * bgp_route.c (route_vty_out_detail): Display format change.
2726
27272000-08-06 Kunihiro Ishiguro <kunihiro@zebra.org>
2728
2729 * bgp_route.c (bgp_update): Only AFI_IP nexthop check is enabled.
2730
2731 * bgpd.c (bgp_delete): Delete static route before delete peer
2732 configuration.
2733
27342000-08-02 Kunihiro Ishiguro <kunihiro@zebra.org>
2735
2736 * bgpd.c: Include bgpd/bgp_nexthop.h.
2737
27382000-07-31 Akihiro Mizutani <mizutani@dml.com>
2739
2740 * bgpd.c (bgp_show_summary): "show ip bgp summary" shows own BGP
2741 identifier. And status is changed like below.
2742
2743 State/Pref -> State/PfxRcd
2744 Shutdown -> Idle (Admin)
2745 PrefixOvflw -> Idle (PfxCt)
2746
2747 * bgp_route.c (route_vty_out): Show internal route as "i".
2748
27492000-07-13 Jim Bowen <jimb@zereau.net>
2750
2751 * bgp_snmp.c: Add BGP peer MIB implementation.
2752
27532000-07-12 Akihiro Mizutani <mizutani@dml.com>
2754
2755 * bgpd.c (bgp_show_peer): Fix typo.
2756
27572000-07-11 Akihiro Mizutani <mizutani@dml.com>
2758
2759 * bgp_routemap.c: Add commands for deleting set without argument.
2760
27612000-07-03 Akihiro Mizutani <mizutani@dml.com>
2762
2763 * bgp_zebra.c: Fix redistribute help strings.
2764
27652000-07-01 Kunihiro Ishiguro <kunihiro@zebra.org>
2766
2767 * bgp_route.c (bgp_show): When bgpd works as vtysh server send all
2768 output to vty at once.
2769
27702000-06-13 Kunihiro Ishiguro <kunihiro@zebra.org>
2771
2772 * bgp_mplsvpn.c (no_vpnv4_network): "no network A.B.C.D/M rd WORD
2773 tag WORD" command is added.
2774
2775 * bgp_ecommunity.c (ecommunity_vty_out): New function added.
2776
27772000-06-12 Kunihiro Ishiguro <kunihiro@zebra.org>
2778
2779 * bgp_route.c (bgp_show): Fix total number of prefix count bug.
2780
2781 * bgpd.c (bgp_show_peer): Display VPNv4 unicast configuration and
2782 negotiation result in "show ip bgp neighbors".
2783
27842000-06-12 Akihiro Mizutani <mizutani@dml.com>
2785
2786 * bgpd.c: Fix help strings.
2787
2788 * bgpd.h: Likewise.
2789
27902000-06-11 Kunihiro Ishiguro <kunihiro@zebra.org>
2791
2792 * bgp_route.c (bgp_aggregate_unset): Fix bug of checking rn->info
2793 instead of rn. Reported by Akihiro Mizutani <mizutani@dml.com>.
2794
2795 * bgp_mplsvpn.c (vpnv4_network): For testing purpose, "network
2796 A.B.C.D rd RD" is added to address-family vpnv4 unicast node.
2797
2798 * bgp_route.c (bgp_static_set): Set safi to p.safi.
2799
28002000-06-10 Kunihiro Ishiguro <kunihiro@zebra.org>
2801
2802 * bgp_route.c (bgp_show_prefix_list): Change to use bgp_show().
2803 (bgp_show_regexp): Change to use bgp_show().
2804 (show_adj_route): Change to display header.
2805
2806 * bgpd.c (clear_bgp): Set peer->v_start to default value when peer
2807 is cleared manually.
2808
2809 * bgp_route.c (bgp_show_route): New function which display
2810 specific BGP route. Divided from bgp_show().
2811 (bgp_static_delete): Delete all static route.
2812
28132000-06-09 NOGUCHI Kay <kay@v6.access.co.jp>
2814
2815 * bgp_route.c (show_ipv6_bgp): "show ipv6 bgp" is broken with
2816 invalid privious fix. Now show_ipv6_bgp and show_ipv6_bgp_route
2817 take care of "show ipv6 bgp [X:X::X:X]". Same change for "show ip
2818 mbgp" and "show ipv6 mbgp".
2819
28202000-06-07 Akihiro Mizutani <mizutani@dml.com>
2821
2822 * bgp_route.c: Fix help strings and command arguments.
2823
28242000-06-06 Kunihiro Ishiguro <kunihiro@zebra.org>
2825
2826 * bgp_ecommunity.c: Include prefix.h
2827
28282000-06-05 Kunihiro Ishiguro <kunihiro@zebra.org>
2829
2830 * bgp_route.h (struct bgp_info_tag): New structure to hold tag
2831 value.
2832
2833 * bgp_route.c (bgp_adj_set): table NULL check is added.
2834 (bgp_adj_unset): Likewise.
2835 (bgp_adj_lookup): Likewise.
2836 (bgp_adj_clear): Likewise.
2837 (route_vty_out): Add SAFI check for nexthop display.
2838 (bgp_withdraw): Add SAFI check for withdraw route.
2839
2840 * Remove all #ifdef MPLS_VPN then include it as default.
2841
2842 * bgpd.c: Temporary disable peer-group command until the
2843 implementation is completed.
2844
2845 * bgp_routemap.c (bgp_route_map_init): Install
2846 route_metric_match_cmd.
2847 (route_match_metric_compile): MED value compile using strtoul.
2848
28492000-06-05 Akihiro Mizutani <mizutani@dml.com>
2850
2851 * bgp_filter.c: Fix help strings. Change REGEXP to LINE. Change
2852 NAME to WORD.
2853
2854 * Change command argument to more comprehensive.
2855
2856 METRIC -> <0-4294967295>
2857 WEIGHT -> <0-4294967295>
2858 LOCAL_PREF -> <0-4294967295>
2859 IP_ADDR -> A.B.C.D
2860 AS -> <1-65535>
2861 AS-PATH-NAME -> WORD
2862 ACCESS_LIST -> WORD
2863 PREFIX_LIST -> WORD
2864 COMMUNITY -> AA:NN
2865 EXT_COMMUNITY -> ASN:nn_or_IP-address:nn
2866 IPv6_ADDR -> X:X::X:X
2867
2868 * bgp_clist.c: Fix help strings.
2869
28702000-06-03 Kunihiro Ishiguro <kunihiro@zebra.org>
2871
2872 * bgpd.c (peer_active): Add new function for check the peer is
2873 active or not.
2874 (neighbor_activate): New command "neighbor PEER activate" and "no
2875 neighbor PEER activate" are added.
2876
2877 * bgp_packet.c: Include bgpd/bgp_mplsvpn.h.
2878
28792000-06-02 Akihiro Mizutani <mizutani@dml.com>
2880
2881 * bgp_clist.c: Fix commuity-list help strings.
2882
2883 * bgp_routemap.c: Fix "set community" help strings. Add #define
2884 SET_STR. Use (unicast|multicast) argument for "set nlri" command.
2885
28862000-06-01 Kunihiro Ishiguro <kunihiro@zebra.org>
2887
2888 * bgp_routemap.c (route_set_community_none_cmd): "set community
2889 none" command is added to route-map.
2890
28912000-06-01 Akihiro Mizutani <mizutani@dml.com>
2892
2893 * bgp_debug.c: Change "show debug" to "show debugging". Now "show
2894 debugging" is not used in VIEW_NODE.
2895
28962000-05-30 Kunihiro Ishiguro <kunihiro@zebra.org>
2897
2898 * bgp_fsm.c (bgp_timer_set): Add check for shutdown flag. This
2899 fix unconditional BGP connection.
2900
2901 * bgpd.c (peer_shutdown): Replace peer_shutdown() with
2902 peer_change_flag_with_reset().
2903
29042000-05-26 Kunihiro Ishiguro <kunihiro@zebra.org>
2905
2906 * bgpd.c (no_bgp_default_ipv4_unicast): Add "no bgp default
2907 ipv4-unicast" command.
2908
2909 * bgpd.h (BGP_CONFIG_NO_DEFAULT_IPV4): Add new definition.
2910
2911 * bgp_filter.c (as_list_delete): Free all AS filter.
2912
2913 * bgp_clist.c (community_list_delete): Free all community entry.
2914
2915 * bgp_filter.c (no_ip_as_path_all): New DEFUN for "no ip as-path
2916 access-list NAME".
2917
2918 * bgp_clist.c (no_ip_community_list_all): New DEFUN for "no ip
2919 community-list NAME".
2920
29212000-05-19 Kunihiro Ishiguro <kunihiro@zebra.org>
2922
2923 * bgp_route.c (ipv6_mbgp_neighbor_routes): Change "show ip bgp PEER
2924 routes" to "show ip bgp PEER received-routes"
2925
29262000-05-14 Kunihiro Ishiguro <kunihiro@zebra.org>
2927
2928 * bgp_ecommunity.c (ecommunity_parse): New file for Extended
2929 Communities attribute.
2930 * bgp_ecommunity.h: Likewise.
2931
29322000-05-11 Kunihiro Ishiguro <kunihiro@zebra.org>
2933
2934 * bgp_mplsvpn.h: New file for MPLS-VPN.
2935 * bgp_mplsvpn.c: Likewise.
2936
2937 * bgpd.c (bgp_delete): Fix bug of "no router bgp" crush.
2938
29392000-05-10 Kunihiro Ishiguro <kunihiro@zebra.org>
2940
2941 * bgpd.c (bgp_bestpath_missing_as_worst): Add "bgp bestpath
2942 missing-as-worst".
2943
29442000-05-08 Kunihiro Ishiguro <kunihiro@zebra.org>
2945
2946 * bgp_routemap.c (match_community): Clarify help of "match
2947 community".
2948
29492000-05-02 Kunihiro Ishiguro <kunihiro@zebra.org>
2950
2951 * bgp_aspath.c (aspath_cmp_left): Remove debug code.
2952
29532000-04-27 Kunihiro Ishiguro <kunihiro@zebra.org>
2954
2955 * bgp_route.c (bgp_info_cmp): Compare MED only both routes comes
2956 from same neighboring AS.
2957
2958 * bgp_aspath.c (aspath_cmp_left): Compare leftmost AS value.
2959
2960 * bgp_route.c (bgp_info_cmp): Fix misused htonl() to ntohl().
2961
29622000-04-26 Kunihiro Ishiguro <kunihiro@zebra.org>
2963
2964 * bgp_route.c (bgp_output_filter): When distribute-list's
2965 corresponding access-list does not exist, filter all routes.
2966 (bgp_input_filter): Likewise.
2967
29682000-04-19 Kunihiro Ishiguro <kunihiro@zebra.org>
2969
2970 * bgp_attr.c (bgp_packet_attribute): Propagate MED to IBGP peer.
2971
2972 * bgp_route.c (bgp_info_cmp): Add evaluation of local preference.
2973
29742000-04-18 Kunihiro Ishiguro <kunihiro@zebra.org>
2975
2976 * bgpd.c (bgp_distribute_update): Add struct access_list *
2977 argument.
2978
29792000-04-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2980
2981 * bgp_clist.c (community_list_dup_check): Add duplicate insertion
2982 check.
2983
2984 * bgp_filter.c (as_list_dup_check): Add duplicate insertion check.
2985
2986 * bgp_route.c (bgp_show): Fix undeclared write variable.
2987
29882000-04-13 Kunihiro Ishiguro <kunihiro@zebra.org>
2989
2990 * bgp_routemap.c: Add "match ip address prefix-list".
2991
29922000-03-29 Rick Payne <rickp@rossfell.co.uk>
2993
2994 * bgp_aspath.c (aspath_strip_confed): Fix realloc problem.
2995
29962000-03-16 Kunihiro Ishiguro <kunihiro@zebra.org>
2997
2998 * bgp_fsm.c (bgp_reconnect): Connect retry timer is expired when
2999 the peer status is Connect.
3000
30012000-03-03 Kunihiro Ishiguro <kunihiro@zebra.org>
3002
3003 * Fix bug of rewritten originator-id.
3004
30052000-01-27 Rick Payne <rickp@rossfell.co.uk>
3006
3007 * bgp_aspath.c (aspath_delimiter_char): New function. Instead of
3008 directly referencing array, search proper AS path delimiter.
3009 (aspath_strip_confed): Strip the confederation stuff from the
3010 front of an AS path.
3011 (aspath_add_left_confed): New function for adding specified AS to
3012 the leftmost AS_CONFED_SEQUENCE.
3013
3014 * bgp_aspath.h: Change AS_CONFED_SEQUENCE and AS_CONFED_SET value
3015 to Cisco compatible.
3016
3017 * bgpd.c (bgp_confederation_id_set): Confederation configuration.
3018 (bgp_confederation_id_unset): Likewise.
3019 (bgp_confederation_peers_check): Likewise.
3020 (bgp_confederation_peers_add): Likewise.
3021 (bgp_confederation_peers_remove): Likewise.
3022 (bgp_confederation_peers_set): Likewise.
3023 (bgp_confederation_peers_unset): Likewise.
3024 (bgp_confederation_peers_print): Likewise.
3025
30262000-01-16 Kunihiro Ishiguro <kunihiro@zebra.org>
3027
3028 * bgpd.c: Introduce peer_change_flag_with_reset() fucntion.
3029
30302000-01-17 Kunihiro Ishiguro <kunihiro@zebra.org>
3031
3032 * bgp_open.c (bgp_open_option_parse): When there is no common
3033 capability send Unsupported Capability error to the peer.
3034
30352000-01-14 Kunihiro Ishiguro <kunihiro@zebra.org>
3036
3037 * bgp_open.c (bgp_capability_mp): Fix bug of mis-negotiation about
3038 IPv6 unicast.
3039
3040 * bgpd.c (bgp_init): Add "soft-reconfiguration inbound" command.
3041
30422000-01-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3043
3044 * bgpd.c (neighbor_strict_capability): Add
3045 "strict-capability-match" command.
3046
3047 * bgp_zebra.c (bgp_if_update): Ignore NET127 determining
3048 router-id.
3049
3050 * bgpd.c (peer_override_capability): Add "override-capability"
3051 command.
3052
30531999-12-16 Kunihiro Ishiguro <kunihiro@zebra.org>
3054
3055 * bgp_packet.c (bgp_write): Change status to Idle and set timer
3056 after write failed.
3057
30581999-12-14 Kunihiro Ishiguro <kunihiro@zebra.org>
3059
3060 * bgp_zebra.c (bgp_zebra_announce): Add info->selected check.
3061
30621999-12-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3063
3064 * bgp_route.c (nlri_unfeasible): nlri_unfeasible() is merged with
3065 nlri_parse().
3066
30671999-12-10 Kunihiro Ishiguro <kunihiro@zebra.org>
3068
3069 * bgp_fsm.h (BGP_EVENT_DELETE): Macro added.
3070
3071 * bgp_fsm.c (bgp_stop): Clear all event threads of the peer when
3072 the peer is cleared.
3073
3074 * bgp_zebra.c (bgp_nexthop_set): Clear interface index of
3075 link-local address. This is KAME specific problem.
3076
30771999-12-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3078
3079 * bgp_attr.c (bgp_mp_reach_parse): Comment out previous code for a
3080 while. We don't completely detect the link is shared or not at
3081 this moment.
3082
3083 * bgp_packet.c (bgp_notify_send): Make shortcut call of
3084 bgp_write() and bgp_stop().
3085
3086 * bgp_attr.c (bgp_mp_reach_parse): Fix serious bug when getting
3087 global and link-local address.
3088
30891999-12-05 Kunihiro Ishiguro <kunihiro@zebra.org>
3090
3091 * bgpd.c (no_neighbor_port): New command added.
3092 (peer_new): Set send_community.
3093
30941999-12-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3095
3096 * bgpd.c (show_ip_bgp_summary): Changed to use bgp_show_summary().
3097 (show_ip_mbgp_summary): Likewise.
3098 (show_ipv6_bgp_summary): Likewise.
3099 (show_ipv6_mbgp_summary): Add new command.
3100 (peer_free): Free peer->host.
3101 (peer_lookup_by_su): Delete function.
3102 (ipv6_bgp_neighbor): Changed to use peer_remote_as().
3103 (sockunion_vty_out): Function deleted.
3104 (vty_clear_bgp): Use afi instead of family.
3105 Delete old list bgp_list. Use struct newlist *bgplist.
3106 (peer_lookup_by_host): Function deleted.
3107
31081999-12-03 Kunihiro Ishiguro <kunihiro@zebra.org>
3109
3110 * bgpd.h (struct peer_group): New structure added.
3111 (struct peer_conf): New structure added.
3112 (struct peer): Change all prefix_count to unsigned long.
3113
3114 * bgpd.c: Reconstruct all of VTY commands reflect internal
3115 structure change.
3116 Use bgplist instead of bgp_list.
3117 Use peerlist intstead of peer_list.
3118
3119 * bgp_attr.c (bgp_mp_reach_parse): If nlri_parse return -1, stop
3120 parsing then return immediately.
3121
3122 * bgp_route.c (nlri_parse): When NLRI parse error occured, return
3123 -1.
3124 (nlri_process): Use pcount_v4_{unicast,multicast}.
3125 (nlri_delete): Likewise.
3126
31271999-11-25 Robert Olsson <Robert.Olsson@data.slu.se>
3128
3129 * bgp_routemap.c (route_match_nlri): `match nlri
3130 unicast|multicast' and `set nlri unicast|multicast' command are
3131 added.
3132
31331999-11-22 Robert Olsson <Robert.Olsson@data.slu.se>
3134
3135 * bgpd.c: Add translate-update support.
3136
3137 * bgpd.h (TRANSLATE_UPDATE_OFF): Add translate-update definition.
3138
31391999-11-19 Robert.Olsson@data.slu.se
3140
3141 * bgp_route.c (bgp_peer_delete): Add MBGP peer clear codes.
3142
31431999-11-14 Kunihiro Ishiguro <kunihiro@zebra.org>
3144
3145 * bgp_open.c (bgp_capability_mp): Temporary comment out
3146 SAFI_UNICAST_MULTICAST handling until we know the meanings.
3147
31481999-11-13 Kunihiro Ishiguro <kunihiro@zebra.org>
3149
3150 * bgp_btoa.c: New file added.
3151
31521999-11-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3153
3154 * bgpd.h (struct peer): Add dont_capability flag.
3155 (struct peer): Add override_capability flag.
3156
3157 * bgpd.c (neighbor_dont_capability_negotiation): `neighbor PEER
3158 dont-capability-negotiation' added.
3159
31601999-11-12 Bill Sommerfeld <sommerfeld@orchard.arlington.ma.us>
3161
3162 * bgp_attr.c (bgp_mp_reach_parse): Ignore link-local addresses
3163 attribute from non-shared-network peers.
3164
31651999-11-10 Kunihiro Ishiguro <kunihiro@zebra.org>
3166
3167 * bgp_snmp.c: New file added.
3168
3169 * BGP4-MIB.txt: Updated to the latest Internet-Draft
3170 draft-ietf-idr-bgp4-mib-04.txt.
3171
31721999-11-09 Kunihiro Ishiguro <kunihiro@zebra.org>
3173
3174 * bgp_route.c (bgp_route_init): Add `show ipv6 bgp prefix-list'.
3175
3176 * bgp_attr.c (bgp_mp_unreach_parse): Enclose safi setup with
3177 #ifdef HAVE_MBGPV4.
3178
31791999-11-08 Kunihiro Ishiguro <kunihiro@zebra.org>
3180
3181 * bgp_dump.c (no_dump_bgp_all): Add [PATH] and [INTERVAL] to no
3182 dump bgp commands.
3183 (config_write_bgp_dump): Write interval value to the
3184 configuration.
3185
31861999-11-07 Kunihiro Ishiguro <kunihiro@zebra.org>
3187
3188 * bgp_zebra.c: Redistribute route-map support is added.
3189
3190 * bgp_zebra.h: New file added.
3191
31921999-11-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3193
3194 * bgp_dump.c: BGP packet dump routine compatible with MRT.
3195 * bgp_dump.h: BGP packet dump routine compatible with MRT.
3196
3197 * bgp_debug.c: Renamed from bgp_dump.c
3198 * bgp_debug.h: Renamed from bgp_dump.h
3199
32001999-10-27 Kunihiro Ishiguro <kunihiro@zebra.org>
3201
3202 * BGP4-MIB.txt: New file added. Edited version of RFC1657.
3203
32041999-10-25 Bill Sommerfeld <sommerfeld@orchard.arlington.ma.us>
3205
3206 * bgp_route.c (bgp_announce): If we're not on a shared network
3207 with the peer and we don't have a link-local next hop, but the
3208 inbound next-hop has a link-local address, don't readvertise it to
3209 our peer.
3210
32111999-10-25 Marc Boucher <marc@mbsi.ca>
3212
3213 * bgp_zebra.c: Add redistribute kernel command.
3214
32151999-10-25 Kunihiro Ishiguro <kunihiro@zebra.org>
3216
3217 * bgp_route.c (bgp_reset): New function added.
3218
3219 * bgpd.conf.sample2: Add IPv6 configuration sample.
3220
32211999-10-24 Bill Sommerfeld <sommerfeld@orchard.arlington.ma.us>
3222
3223 * bgp_route.c (ipv6_aggregate_address): Function added.
3224
32251999-10-21 Kunihiro Ishiguro <kunihiro@zebra.org>
3226
3227 * bgp_packet.c (bgp_update): Unintern aspath, community, cluster
3228 list after parsing BGP update packet.
3229
3230 * bgp_attr.c (bgp_attr_aspath): Intern parsed aspath.
3231 (bgp_attr_community): Intern parsed community.
3232 (bgp_attr_cluster_list): Intern parsed cluster list.
3233
3234 * bgp_routemap.c: Add `set community-additive' command.
3235
32361999-10-21 Alexandr D. Kanevskiy <kad@blackcatlinux.com>
3237
3238 * bgp_routemap.c (route_set_local_pref): Fix bug of setting
3239 attribute flag.
3240
32411999-10-21 Bill Sommerfeld <sommerfeld@orchard.arlington.ma.us>
3242
3243 * bgp_route.c (bgp_announce): Add check of IPv6 default route
3244 announcement.
3245
3246 * bgp_packet.c (bgp_update_send): Add BGP announcement logging.
3247
32481999-10-15 Kunihiro Ishiguro <kunihiro@zebra.org>
3249
3250 * `show ip[v6] bgp PREFIX' show uptime of the route.
3251
32521999-10-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3253
3254 * bgpd.c (bgp_filter_set): Delete PEER_FAMILY_{IPV4,IPV6}. instead
3255 of that use AF_INET and AF_INET6 directly.
3256 (vty_clear_bgp): Add new function to support various clear ip bgp
3257 method.
3258
32591999-10-04 Lars Fenneberg <lf@elemental.net>
3260
3261 * bgpd.c (clear_ip_bgp): Add `clear ip bgp ASN'.
3262
32631999-10-03 Kunihiro Ishiguro <kunihiro@zebra.org>
3264
3265 * bgp_routemap.c: Add `match ip prefix-list' and `match ipv6
3266 prefix-list'.
3267
32681999-09-28 Kunihiro Ishiguro <kunihiro@zebra.org>
3269
3270 * bgpd.c (bgp_collision_detect): Add BGP collision detection
3271 function.
3272
32731999-09-26 Blake Meike <bmeike@adero.com>
3274
3275 * bgpd.c (neighbor_port): New command `neighbor PEER port PORT' is
3276 added.
3277
32781999-08-24 Kunihiro Ishiguro <kunihiro@zebra.org>
3279
3280 * bgpd.c (no_neighbor_timers_keepalive): Change MIN to min. Add
3281 min() macro.
3282
32831999-08-19 Rick Payne <rickp@rossfell.co.uk>
3284
3285 * bgp_packet.c (bgp_open): BGP holdtimer bug is fixed. Make BGP
3286 keepalive timer configurable.
3287
32881999-08-15 Kunihiro Ishiguro <kunihiro@zebra.org>
3289
3290 * bgp_zebra.c (bgp_redistribute_set): Fix redistribute bug.
3291
32921999-08-13 Kunihiro Ishiguro <kunihiro@zebra.org>
3293
3294 * bgpd.c (bgp_peer_display): show ip bgp neighbors PEER only list
3295 the peer not all of them.
3296
32971999-08-11 Rick Payne <rickp@rossfell.co.uk>
3298
3299 * bgp_route.c (bgp_announce): Remove MED if its an EBGP peer -
3300 will get overwritten by route-maps.
3301
33021999-08-08 Rick Payne <rickp@rossfell.co.uk>
3303
3304 * bgp_routemap.c: Multi protocol route-map modification.
3305
33061999-08-01 Kunihiro Ishiguro <kunihiro@zebra.org>
3307
3308 * bgp_route.c: Set network statement route's origin attribute as
3309 igp.
3310
3311 * bgp_zebra.c: Set redistribute route's origin attribute as
3312 incomplete.
3313
3314 * bgp_route.c (bgp_info_cmp): Add attribute existance check,
3315 origin attribute check, BGP peer type check.
3316
33171999-07-30 Kunihiro Ishiguro <kunihiro@zebra.org>
3318
3319 * bgp_route.c (bgp_peer_delete): Reselect of IPv6 route.
3320
33211999-07-29 Rick Payne <rickp@rossfell.co.uk>
3322
3323 * Changed route-maps to behave in a more cisco-like fashion
3324
33251999-07-27 Kunihiro Ishiguro <kunihiro@zebra.org>
3326
3327 * bgp_fsm.c (bgp_stop): Very serious bug of bgp_stop () is fixed.
3328 When multiple route to the same destination exist, bgpd try to
3329 announce the information to stopped peer. Then add orphan write
3330 thread is added. This cause many strange behavior of bgpd.
3331 Reported by Georg Hitsch <georg@atnet.at>.
3332
33331999-07-23 Kunihiro Ishiguro <kunihiro@zebra.org>
3334
3335 * bgpd.c: Change peer's A.B.C.D to PEER.
3336
33371999-07-22 Kunihiro Ishiguro <kunihiro@zebra.org>
3338
3339 * bgp_route.c (bgp_announce): Add hack for link-local nexthop.
3340
3341 * bgp_zebra.c (bgp_zebra_announce): Fill in nexthop address from
3342 local address.
3343
33441999-07-21 Kunihiro Ishiguro <kunihiro@zebra.org>
3345
3346 * bgp_packet.c (bgp_open): Holdtime fetch bug is fixed. Reported
3347 by Yuji SEKIYA <sekiya@sfc.wide.ad.jp>.
3348
33491999-07-15 Kunihiro Ishiguro <kunihiro@zebra.org>
3350
3351 * bgp_fsm.c (fsm_holdtime): Don't close file descriptor in
3352 fsm_holdtime ().
3353
33541999-07-11 Kunihiro Ishiguro <kunihiro@zebra.org>
3355
3356 * bgp_routemap.c: Add `set atomic-aggregate' command.
3357
33581999-07-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3359
3360 * bgp_routemap.c (route_set_ip_nexthop_cmd): Change "ip nexthop"
3361 to "ip next-hop".
3362
33631999-07-02 Kunihiro Ishiguro <kunihiro@zebra.org>
3364
3365 * bgp_route.c (show_ipv6_bgp_regexp): `show ipv6 bgp regexp'
3366 added.
3367
33681999-07-01 Rick Payne <rickp@rossfell.co.uk>
3369
3370 * bgp_zebra.c (zebra_init): Install standard commands to
3371 ZEBRA_NODE.
3372
33731999-06-28 Rick Payne <rickp@rossfell.co.uk>
3374
3375 * bgpd.c (bgp_delete): bgp peer deletion bug is fixed.
3376
33771999-06-25 Kunihiro Ishiguro <kunihiro@zebra.org>
3378
3379 * bgpd.c: Add neighbor update-source command as ALIAS to
3380 neighbor_interface.
3381
33821999-06-19 Kunihiro Ishiguro <kunihiro@zebra.org>
3383
3384 * bgp_attr.c (bgp_packet_attribute): Send community attribute when
3385 send_community flag is set.
3386
3387 * bgpd.h (struct peer): Add send_community flag.
3388
33891999-06-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3390
3391 * bgpd.c (router_bgp): router bgp's argument changed from AS_NO to
3392 <1-65535>.
3393
33941999-06-08 Kunihiro Ishiguro <kunihiro@zebra.org>
3395
3396 * bgp_route.h (struct bgp_info): Add subtype for BGP route type.
3397
33981999-06-07 Kunihiro Ishiguro <kunihiro@zebra.org>
3399
3400 * bgp_community.c (community_merge): Function added.
3401
34021999-06-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3403
3404 * bgp_clist.c: New file.
3405 * bgp_clist.h: New file.
3406
3407 * bgp_community.h (COMMUNITY_LOCAL_AS): Added for Cisco
3408 compatibility.
3409 (COMMUNITY_NO_ADVERTISE): Fix typo.
3410
34111999-05-30 Kunihiro Ishiguro <kunihiro@zebra.org>
3412
3413 * bgp_routemap.c: Add `set weight WEIGHT' command.
3414
3415 * bgpd.c: Remove all_digit_check function. Instead of that use
3416 all_digit function in lib/prefix.c.
3417
3418 * bgp_routemap.c (bgp_route_map_init): Install
3419 no_set_ipv6_nexthop_global_cmd and no_set_ipv6_nexthop_local_cmd
3420 element to the RMAP_NODE.
3421
34221999-05-28 Kunihiro Ishiguro <kunihiro@zebra.org>
3423
3424 * bgp_aspath.c (aspath_make_str): Declare aspath_delimiter_char
3425 inside aspath_make_str function.
3426 (aspath_prepend): New function is added for AS path prepend.
3427 (aspath_make_str_count): Renamed from aspath_make_str. AS path
3428 count is set to the structure.
3429 (aspath_merge): New function.
3430
34311999-05-22 Kunihiro Ishiguro <kunihiro@zebra.org>
3432
3433 * bgp_zebra.c (redistribute_bgp): Add new DEFUN.
3434 (no_redistribute_bgp): Likewise.
3435 (router_zebra): Semantics changed. Now 'router zebra' is default
3436 behavior of bgpd.
3437
34381999-05-14 Kunihiro Ishiguro <kunihiro@zebra.org>
3439
3440 * bgp_routemap.c: Add some commands to bgp route-map.
3441 match ip next-hop: New command.
3442 match metric: New command.
3443 set metric: Doc fix.
3444 set local-preference: Add DEFUN.
3445
34461999-05-14 Stephen R. van den Berg <srb@cuci.nl>
3447
3448 * bgp_main.c (signal_init): SIGTERM call sigint.
3449 (sigint): Loggging more better message.
3450
34511999-05-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3452
3453 * bgp_attr.c (bgp_packet_attribute): AS path attribute extended
3454 length bit check is added.
3455
34561999-05-11 Kunihiro Ishiguro <kunihiro@zebra.org>
3457
3458 * bgp_routemap.c (bgp_route_map_init): Call route_map_install_set
3459 function with route_set_local_pref_cmd argument.
3460 (no_match_aspath): Function added.
3461 (route_set_metric): Set attribute flag bit.
3462
3463 * bgp_attr.c (bgp_packet_attribute): MULTI_EXIT_DISC is now in BGP
3464 packet.
3465
34661999-05-07 Kunihiro Ishiguro <kunihiro@zebra.org>
3467
3468 * bgpd.c (no_neighbor_timers_holdtime): `no neighbor PEER timers
3469 holdtime' command is added.
3470
3471 * bgpd.h (BGP_DEFAULT_HOLDTIME_BIG): Delete define.
3472
3473 * bgpd.c (bgp_prefix_list_set): New function added.
3474 (bgp_prefix_list_unset): Likewise.
3475 (bgp_prefix_list_update): Likewise.
3476 (show_ip_bgp_neighbors): prefix-list information display.
3477
34781999-05-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3479
3480 * bgpd.c (bgp_delete): Function added for `no router bgp'.
3481
34821999-05-05 Kunihiro Ishiguro <kunihiro@zebra.org>
3483
3484 * bgp_dump.c (bgp_dump_attr): Add originator_id display.
3485
3486 * bgpd.c (bgp_router_id): Even when address is malformed set the
3487 value to configuration bug fixed.
3488 (no_bgp_router_id): New function.
3489 (no_bgp_cluster_id): New function.
3490
34911999-05-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3492
3493 * bgpd.h (BGP_ATTR_ORIGINATOR_ID): Changed from BGP_ATTR_ORIGINATOR.
3494
34951999-05-02 Kunihiro Ishiguro <kunihiro@zebra.org>
3496
3497 * bgp_route.c (bgp_announce): Add route reflector check.
3498
34991999-05-01 Kunihiro Ishiguro <kunihiro@zebra.org>
3500
3501 * bgpd.c (bgp_cluster_id): Add function for route reflector.
3502 (neighbor_route_reflector_client): Likewise.
3503 (no_neighbor_route_reflector_client): Likewise.
3504
3505 * bgpd.h (struct bgp ): Add cluster for route reflector.
3506
3507 * bgp_route.c (show_ip_bgp_prefix_list): New command is added.
3508
35091999-04-24 Kunihiro Ishiguro <kunihiro@zebra.org>
3510
3511 * Makefile.am (noinst_HEADERS): Add bgp_filter.h
3512
3513 * bgp_aspath.c (aspath_undup): Function deleted. aspath_free ()
3514 has same functionality.
3515
3516 * bgp_filter.h: New file.
3517
3518 * bgp_aspath.c (aspath_unintern): Rename aspath_free () to
3519 aspath_unintern ()
3520 (aspath_free): New function.
3521
35221999-04-23 Kunihiro Ishiguro <kunihiro@zebra.org>
3523
3524 * bgp_aspath.c (aspath_aggregate): Function added.
3525
3526 * bgp_aspath.h (aspath_aggregate): Prototype added.
3527
3528 * bgp_aspath.c (aspath_empty_aspath): New argument
3529 gated_dont_eat_flag is added.
3530
35311999-04-18 Kunihiro Ishiguro <kunihiro@zebra.org>
3532
3533 * bgp_route.c: Add bgp_aggregate_ipv4 and bgp_aggregate_ipv6.
3534
35351999-04-17 Kunihiro Ishiguro <kunihiro@zebra.org>
3536
3537 * bgp_route.c (aggregate_address): Function added.
3538
3539 * bgp_zebra.c (zebra_read): Change log to zlog.
3540
35411999-04-15 Kunihiro Ishiguro <kunihiro@zebra.org>
3542
3543 * Makefile.am (noninst_HEADERS): Added for make dist.
3544
35451999-04-09 Kunihiro Ishiguro <kunihiro@zebra.org>
3546
3547 * aspath_regex.c: Removed from distribution.
3548
35491999-04-07 Kunihiro Ishiguro <kunihiro@zebra.org>
3550
3551 * bgp_attr.c (bgp_packet_attribute): Old draft-00 packet treatment
3552 bug fixed.
3553
35541999-04-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3555
3556 * bgp_aspath.c (aspath_add_left): Fix empty aspath bug. Reported
3557 by kad@gibson.skif.net.
3558
3559 * bgp_regex.[ch]: New file added.
3560
3561
35621999-04-05 Kunihiro Ishiguro <kunihiro@zebra.org>
3563
3564 * bgp_filter.c: New file added.
3565
35661999-04-01 Kunihiro Ishiguro <kunihiro@zebra.org>
3567
3568 * bgp_aspath.c (aspath_empty_aspath): Change for peering with
3569 gated.
3570
35711999-03-24 Kunihiro Ishiguro <kunihiro@zebra.org>
3572
3573 * bgp_main.c (main): Default loggin method changed from syslog to
3574 stdout.
3575
35761999-03-05 Kunihiro Ishiguro <kunihiro@zebra.org>
3577
3578 * bgp_route.c: Delete obsolete default attribute DEFUN.
3579
35801999-03-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3581
3582 * bgp_attr.c: Make attribute structure put into attribute hash.
3583
35841999-03-02 Kunihiro Ishiguro <kunihiro@zebra.org>
3585
3586 * bgp_view.c : Delete file.
3587
35881999-02-25 Kunihiro Ishiguro <kunihiro@zebra.org>
3589
3590 * bgp_routemap.c (bgp_apply_route_map): Add prefix argument.
3591
3592 * bgp_route.h (struct bgp_info): Add bgp_info structre. I'll
3593 replace bgp_route with this.
3594
3595 * bgp_routemap.c (route_match_ip_address): Fix bug of passing non
3596 prefix value to access_list_apply().
3597
3598 * bgpd.conf.sample: Add route-map sample.
3599 Delete obsolete default-attr statements.
3600
3601 * bgp_packet.c: Use stream_fifo for packet queueing.
3602
36031999-02-24 Kunihiro Ishiguro <kunihiro@zebra.org>
3604
3605 * bgp_aspath.c (aspath_add_left): add non empty aspath treatment.
3606
3607 * bgp_main.c: include unistd.h for daemon().
3608
3609 * bgp_route.c (nlri_process): add IPv6 table lookup.
3610
3611 * bgp_attr.c (route_parse_ipv6): call nlri_process().
3612 (attr_make): Obsolete function attr_make deleted.
3613
36141999-02-22 Kunihiro Ishiguro <kunihiro@zebra.org>
3615
3616 * bgp_aspath.c (aspath_add_left): change function name from
3617 aspath_add_leftmost_as().
3618
36191999-02-21 Kunihiro Ishiguro <kunihiro@zebra.org>
3620
3621 * bgp_aspath.c: add aspath_add_leftmost_as ().
3622
36231999-02-18 Peter Galbavy <Peter.Galbavy@knowledge.com>
3624
3625 * syslog support added
3626
36271999-01-26 Kunihiro Ishiguro <kunihiro@zebra.org>
3628
3629 * bgpd.c: DEFUN (neighbor_nexthop): deleted.
3630 DEFUN (neighbor_distribute_list): added.
3631
36321999-01-19 Kunihiro Ishiguro <kunihiro@zebra.org>
3633
3634 * bgpd.h (struct peer ): header_buf and read_buf is removed.
3635
3636 * bgp_peer.[ch]: Deleted. Peer related functions are merged to
3637 bgpd.c
3638
3639 * bgp_network.c: New file.
3640 * bgp_network.h: New file.
3641
3642 * bgp_packet.h: New file.
3643
36441999-01-11 Kunihiro Ishiguro <kunihiro@zebra.org>
3645
3646 * bgp_packet.c (bgp_keepalive_send): Now BGP keepalive packet is
3647 buffered.
3648
36491999-01-08 Kunihiro Ishiguro <kunihiro@zebra.org>
3650
3651 * bgp_packet.c: New file.
3652
36531998-12-22 Kunihiro Ishiguro <kunihiro@zebra.org>
3654
3655 * bgp_zebra.c (zebra_client): Use zebra_connect() in lib/client.c.
3656
3657 * `show ip bgp' bug fixed.
3658 * aspath_log (): Remove argument logfp.
3659
36601998-12-15 Kunihiro Ishiguro <kunihiro@zebra.org>
3661
3662 * bgp_fsm.h: New file.
3663
36641998-12-15 Magnus Ahltorp <map@stacken.kth.se>
3665
3666 * bgp_attr.c, bgp_community.h, bgp_dump.c, bgp_fsm.c, bgp_open.c
3667 bgp_peer.c, bgp_peer.h, bgp_route.c, bgp_route.h, bgp_view.c
3668 bgpd.c, bgpd.h, bgp_attr.c, bgp_community.h, bgp_dump.c,
3669 bgp_fsm.c, bgp_open.c, bgp_peer.c, bgp_peer.h: Prototype fixes.
3670
36711998-12-09 Kunihiro Ishiguro <kunihiro@zebra.org>
3672
3673 * bgpd.c (bgp_config_write): Delete vector v argument.
3674
36751998-12-07 Kunihiro Ishiguro <kunihiro@zebra.org>
3676
3677 * bgpd.h: Delete annoying ld_[124]byte and st_[124]byte macros.
3678
36791998-11-23 Kunihiro Ishiguro <kunihiro@zebra.org>
3680
3681 * bgp_radix.[ch]: removed.
3682
36831998-09-15 HEO SeonMeyong <seirios@matrix.iri.co.jp>
3684
3685 * bgp_main.c: ifdef HYDRANGEA -> ifdef KAME
3686
36871998-08-13 Kunihiro Ishiguro <kunihiro@zebra.org>
3688
3689 * bgp_dump.c: delete nroute().
3690
36911998-05-19 Yamshita TAKAO <jargon@lares.dti.ne.jp>
3692
3693 * bgp_aspath.c: HAVE_CONFIG_H typo :-)
3694 * bgpd.h: Modify for compile on Solaris.
3695 * bgp_aspath.h: likewize
3696 * bgp_community.h: likewize
3697 * bgp_routemap.c: likewize
3698
36991998-05-18 Yamshita TAKAO <jargon@lares.dti.ne.jp>
3700
3701 * bgpd.h: Modify for compile on Solaris.
3702 * bgp_aspath.h: likewize
3703
37041998-05-08 Kunihiro Ishiguro <kunihiro@zebra.org>
3705
3706 * routemap.[ch]: move to ../lib directory.
3707
37081998-05-07 Kunihiro Ishiguro <kunihiro@zebra.org>
3709
3710 * routemap.c (route_map_apply): add function.
3711
37121998-05-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3713
3714 * routemap.h: add file.
3715
3716 * bgp_peer.h (enum ): change PEER_{IBGP,EBGP} to BGP_PEER_{IBGP,EBGP}
3717
37181998-05-03 Kunihiro Ishiguro <kunihiro@zebra.org>
3719
3720 * Makefile.am: sysconfdir_DATA added.
3721
37221998-05-02 Kunihiro Ishiguro <kunihiro@zebra.org>
3723
3724 * bgp_dump.c: add `debug bgp fsm'
3725 add `no debug bgp fsm'
3726 add `show debug bgp'
3727 * bgp_open.c: File added.
3728
37291998-05-01 Kunihiro Ishiguro <kunihiro@zebra.org>
3730
3731 * .cvsignore: File added.
3732
37331998-04-30 Kunihiro Ishiguro <kunihiro@zebra.org>
3734
3735 * bgp_community.[ch]: File added.
3736
37371998-03-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3738
3739 * bgpd now use lib/thread.[ch].
3740
37411998-01-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3742
3743 * bgpd.c (show_ip_bgp_neighbors): add 'show ip bgp neighbors' command.
3744
3745 * bgpd.h (BGP_DEFAULT_START_TIMER): change from 1 to 30.
3746
37471997-12-30 Kunihiro Ishiguro <kunihiro@zebra.org>
3748
3749 * bgp_vty.c: bgp_vty.c deleted.
3750
3751 * bgpd.c (config_write_neighbor): add ebgp-multihop command.
3752
37531997-12-29 Kunihiro Ishiguro <kunihiro@zebra.org>
3754
3755 * bgp_fsm.c: [-p bgp_port] and [-P vty_port] works
3756
37571997-12-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3758
3759 * bgp_vty.c: new file.
3760
3761 * bgp_attr.c: add new logging system.
3762
37631997-11-23 Kunihiro Ishiguro <kunihiro@zebra.org>
3764
3765 * Change all inet_addr call into inet_aton.
3766
37671997-11-10 Kunihiro Ishiguro <kunihiro@zebra.org>
3768
3769 * bgp_radix.c: change radix_peer_delete
3770
37711997-10-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3772
3773 * bgp_aspath.c: move AS_TOKEN_??? definition from header to c source.
3774
37751997-09-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3776
3777 * bgp_dump.c (bgp_log_route): add dump_attr function
3778
37791997-09-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3780
3781 * bgp_aspath.c (aspath_test): change AS_SET brace from '[' to '{'
3782 * bgp_dump.c (bgp_log_route): change logfile format.
3783
37841997-08-19 Kunihiro Ishiguro <kunihiro@zebra.org>
3785
3786 * bgp_open.c (bgp_open): move bgp_open function from bgpd.c
3787 * bgp_attr.c (community_str2com): add community value generation
3788 * bgp_attr.h: add SAFI definition for BGP-4+
3789
37901997-08-18 Kunihiro Ishiguro <kunihiro@zebra.org>
3791
3792 * bgpd.h: add BGP_OPEN_OPT_CAP for Capabilities Optional Parameter
3793 * Makefile.in: add bgp_open.o, delete bgp_loop.o
3794 * bgp_open.c: newfile which manages BGP Open message
3795 * bgp_loop.c: this file is merged with bgp_fsm.c
3796 * bgp_radix.c (radix_add): radix_add() now return route_t instead
3797 of int
3798 (bgp_sim): now we can read update & withdraw from file
3799 * bgp_route.c: add route_free() call into route_parse etc.
3800
38011997-08-17 Kunihiro Ishiguro <kunihiro@zebra.org>
3802
3803 * bgp_radix.c: Radix code is completely rewritten. It has better
3804 memory treatment than old one.
3805
38061997-08-14 Kunihiro Ishiguro <kunihiro@zebra.org>
3807
3808 * bgp_route.c: route_alloc for route struct allocation statistics.
3809 * bgpd.c (bgp_make_update): now we cann announce MED attribute.
3810 * bgp_aspath.c (aspath_print_all): change aspath_print_all output
3811 format.
3812
38131997-08-13 Kunihiro Ishiguro <kunihiro@zebra.org>
3814
3815 * bgp_term.c (term_parse): add command : show asstat, show ashash
3816 * bgp_aspath.c: aspath_cmp bug fix
3817 (aspath_print_all): add aspath_print_all ();
3818 * bgp_peer.h: delete rlist element from struct peer.
3819
38201997-08-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3821
3822 * bgp_aspath.c: completely rewritten.
3823 * bgp_aspath.h: completely rewritten.
3824 add AsPath, AsSegment structure
3825 add AS_SET treatment
3826 change Hash codes
3827
38281997-08-09 Kunihiro Ishiguro <kunihiro@zebra.org>
3829
3830 * bgp_attr.h: add Attribute flags defines
3831 * bgp_route.c: delete rlist related functions
3832 * bgp_aspath.c (as_origin): add as_origin function
3833 (aspath_print): move from bgp_dump.c and add support of AS_SET
3834 change Hash related function names.
3835
38361997-08-08 Kunihiro Ishiguro <kunihiro@zebra.org>
3837
3838 * bgp_aspath.h: add next entry, delete rlist entry from struct aspath
3839
38401997-08-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3841
3842 * bgp_aspath.c (as_sort): add function as_sort
3843 * bgp_aspath.h: add IBGP, EBGP
3844