blob: 855ea29d7bf6fe3ec0c80c3759688351aac86207 [file] [log] [blame]
Andrew J. Schorr56b3ea02007-03-14 20:21:43 +000012007-03-14 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
2
3 * ospf_zebra.c: (ospf_zebra_add, ospf_zebra_delete) Fix bug
4 where inet_ntoa was used twice in the same debug message,
5 which doesn't work because there's a single shared buffer
6 for the returned string. The fix is to use inet_ntop.
7
Andrew J. Schorr4056a542007-02-27 13:55:46 +000082007-02-27 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
9
10 * ospfd.c: (ospf_terminate) Exit immediately if ospf is not
11 actually running (e.g. the config file was empty). Fixes
12 bug where SIGTERM would not kill ospfd.
13
Paul Jakmabd34fb32007-02-26 17:14:48 +0000142007-02-26 Paul Jakma <paul.jakma@sun.com>
15
16 * ospf_spf.c: Fix regression introduced with bug #330 fix: The
17 cost update added to ospf_spf_add_parent only handled PtP
18 case, differing from same functionality in higher-level
19 ospf_spf_next. Regression diagnosed by Anders Pedersen,
20 mailnews+router-quagga-dev@news.cohaesio.com.
21 (ospf_vertex_new) Initialise vertices to max-cost.
22 (ospf_spf_init) Root vertex always creates with 0 cost.
23 (ospf_spf_add_parent) Remove the buggy V->W cost calculating
24 code, instead take the new distance as a parameter.
25 (ospf_nexthop_calculation) Take distance as parameter, so it
26 can be passed down to add_parent.
27 (ospf_spf_next) Dont initialise candiate vertex distance,
28 vertex_new does so already. Pass distance down to
29 nexthop_calculation (see above).
30
Paul Jakmabc20c1a2007-01-24 14:51:51 +0000312007-01-24 Paul Jakma <paul.jakma@sun.com>
32
33 * ospf_spf.c: Bug #330: Nexthop calculation sometimes may fail,
34 and it needs to indicate this result to SPF.
35 (ospf_spf_add_parent) Flush of parent list needs to be done here,
36 for simplicity.
37 (ospf_nexthop_calculation) Caller needs to know whether
38 nexthop calculation succeeded. Every return statement must
39 correctly indicate such.
40 (ospf_spf_next) Queueing/prioritisation of vertices in SPF
41 must take into account whether nexthop_calculation succeeded,
42 or SPF may fail to find best paths.
43
Andrew J. Schorre4529632006-12-12 19:18:21 +0000442006-12-12 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
45
46 * ospf_interface.c: (ospf_if_is_configured, ospf_if_lookup_by_prefix,
47 ospf_if_lookup_recv_if) Simplify logic using new CONNECTED_PREFIX
48 macro.
49 * ospf_lsa.c: (lsa_link_ptop_set) Using the new CONNECTED_PREFIX
50 macro, both options collapse into the same code.
51 * ospf_snmp.c: (ospf_snmp_if_update) Simplify logic using new
52 CONNECTED_ID macro.
53 (ospf_snmp_is_if_have_addr) Simplify logic using new CONNECTED_PREFIX
54 macro.
55 * ospf_vty.c: (show_ip_ospf_interface_sub) Use new CONNECTED_PEER macro
56 instead of testing the IFF_POINTOPOINT flag.
57 * ospfd.c: (ospf_network_match_iface) Use new CONNECTED_PEER macro
58 instead of testing with if_is_pointopoint. And add commented-out
59 code to implement alternative (in my opinion) more elegant behavior
60 that has no special-case treatment for PtP addresses.
61 (ospf_network_run) Use new CONNECTED_ID macro to simplify logic.
62
Andrew J. Schorred589c12006-12-04 18:26:37 +0000632006-12-04 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
64
65 * ospfd.c: (ospf_network_run) Remove an offending 'break' statement.
66 Previously, after creating a single ospf_interface on a given
67 network interface, the code would skip to the next interface
68 without considering other connected addresses on the interface.
69 After removing the 'break', we now consider all connected addresses.
70
Andrew J. Schorr7f643eb2006-11-30 16:17:02 +0000712006-11-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
72
73 * ospf_zebra.c: (ospf_router_id_update_zebra,
74 ospf_interface_address_add, ospf_interface_address_delete)
75 If (IS_DEBUG_OSPF (zebra, ZEBRA_INTERFACE)) is enabled, then
76 add a debug message about what Zebra is telling us.
77 (ospf_zebra_add_discard) Add a debug message matching the one
78 already in ospf_zebra_delete_discard.
79
Andrew J. Schorr43540882006-11-28 16:36:39 +0000802006-11-28 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
81
82 * ospf_vty.c: (ospf_passive_interface_default) Take additional
83 'newval' arg so we can update ospf->passive_interface_default inside
84 this function. More importantly, we now call ospf_if_set_multicast
85 on all ospf_interfaces.
86 (ospf_passive_interface, no_ospf_passive_interface) Fix bug:
87 for 'default' case, argv[0] is undefined, so we must test for
88 (argc == 0) before using argv[0]. And since
89 ospf_passive_interface_default now calls ospf_if_set_multicast as
90 needed, we can just return after calling
91 ospf_passive_interface_default.
92
Andrew J. Schorr8fb8a502006-10-24 19:04:26 +0000932006-10-24 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
94
95 * ospf_zebra.c: (ospf_redistribute_default_set) Fix bug where
96 a new value for ospf->default_originate was being ignored
97 if a previous 'default-information originate' command
98 had already been processed.
99
Paul Jakma7ffa8fa2006-10-22 20:07:53 +00001002006-10-22 Yar Tikhiy <yar@comp.chem.msu.su>
101
102 * (general) Add support for passive-interface default (with
103 minor edits by Paul Jakma).
104 * ospf_interface.h: Add OSPF_IF_PASSIVE_STATUS macro, looking
105 at configured value, or the global 'default' value, as
106 required.
107 * ospf_interface.c: (ospf_if_new_hook) Leave passive
108 unconfigured per default, allowing global 'default' to
109 take effect for unconfigured interfaces.
110 * ospf_packet.c: (various) use OSPF_IF_PASSIVE_STATUS
111 * ospf_vty.c: (ospf_passive_interface_default) new function,
112 unset passive from all interfaces if default is enabled, as
113 the per-iface settings become redundant.
114 (ospf_passive_interface_update) new func, update passive
115 setting taking global default into account.
116 ({no,}ospf_passive_interface_addr_cmd) Add support for
117 'default' variant of command.
118 (show_ip_ospf_interface_sub) Update to take global
119 default into account when printing passive status.
120 (ospf_config_write) ditto.
121 * ospfd.c: (ospf_new) set global passive-interface default.
122 * ospfd.h: (struct ospf) Add field for global
123 passive-interface.
124
Andrew J. Schorr08c83672006-09-25 13:26:14 +00001252006-09-25 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
126
127 * ospf_packet.c: (ospf_packet_dup, ospf_make_md5_digest)
128 Fix zlog_warn messages to eliminate compiler warnings.
129 (ospf_hello) Improve warning messages to show why we
130 are complaining.
131
Paul Jakmab5aeb442006-08-30 18:47:37 +00001322006-08-28 Andy Gay <andy@andynet.net>
133
134 * ospf_packet.c: (ospf_make_db_desc) Assert added with More-bit
135 fixes does not hold up with addition of Ogier DB-Exchange
136 optimisation, which can empty the db-summary list in between
137 sent DD packets. Remove assert, update More-bit always when
138 in Exchange.
139
Paul Jakma29b5a042006-08-27 08:01:20 +00001402006-08-27 J.J. Krabbendam <jkrabbendam@aimsys.nl>
141
142 * ospfd.c: (ospf_finish_final) default redistribute should be
143 unset too, fixes bug where reconfiguring ospfd completely
144 can no longer enable default redistribution.
145
Paul Jakma2518efd2006-08-27 06:49:29 +00001462006-08-25 Paul Jakma <paul.jakma@sun.com>
147
148 * (general) Bug #134. Be more robust to backward time changes,
149 use the newly added libzebra time functions.
150 In most cases: recent_time -> recent_relative_time()
151 gettimeofday -> quagga_gettime (QUAGGA_CLK_MONOTONIC, ..)
152 time -> quagga_time.
153 (ospf_make_md5_digest) time() call deliberately not changed.
154 (ospf_external_lsa_refresh) remove useless gettimeofday, LSA
155 tv_orig time was already set in ospf_lsa_new, called via
156 ospf_external_lsa_new.
157
Paul Jakmaba122e72006-08-27 06:24:34 +00001582006-08-04 Paul Jakma <paul.jakma@sun.com>
159
160 * ospf_lsdb.c: (ospf_lsdb_delete_entry) new function, consolidate
161 exact same functionality replicated in other functions.
162 (ospf_lsdb_add) Strip out code by using ospf_lsdb_delete_entry.
163 (ospf_lsdb_delete) ditto.
164 (ospf_lsdb_delete_all) ditto.
165
Paul Jakma8dd24ee2006-08-27 06:29:30 +00001662006-08-03 Paul Jakma <paul.jakma@sun.com>
167
168 * ospf_packet.c: (ospf_make_db_desc) Unset the DD More bit
169 after constructing the packet, if appropriate.
170 (ospf_db_desc_proc) Speed up Exchange, slave should raise
171 ExchangeDone earlier, as RFC mandates, by forming its reply
172 before deciding whether both sides are done, avoids a
173 needless round of empty DD packet exchanges at the end of
174 Exchange, hence speeding up ExchangeDone.
Paul Jakmaf0894cf2006-08-27 06:40:04 +0000175 Implement draft-ogier-ospf-dbex-opt DB-exchange optimisation.
Paul Jakma8dd24ee2006-08-27 06:29:30 +0000176 (ospf_db_desc) use UNSET_FLAG macro.
177
Andrew J. Schorr16700082006-07-27 22:29:06 +00001782006-07-27 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
179
180 * ospfd.c: (ospf_router_id_update) Fix and document the algorithm for
181 selecting the router ID: if there is not a statically configured ID,
182 then stick to the most recent value to avoid disruptive changes.
183 This should fix bug #288.
184
Paul Jakma1fe6ed32006-07-26 09:37:26 +00001852006-07-26 Paul Jakma <paul.jakma@sun.com>
186
187 * ospf_lsa.{c,h}: (ospf_lsa_unlock) Change to take a double pointer
188 to the LSA to be 'unlocked', so that, if the LSA is freed, the
189 callers pointer to the LSA can be NULLed out, allowing any further
190 use of that pointer to provoke a crash sooner rather than later.
191 * ospf_*.c: (general) Adjust callers of ospf_lsa_unlock to match
192 previous. Try annotate 'locking' somewhat to show which 'locks'
193 are protecting what LSA reference, if not obvious.
194 * ospf_opaque.c: (ospf_opaque_lsa_install) Trivial: remove useless
195 goto, replace with return.
196 * ospf_packet.c: (ospf_make_ls_ack) Trivial: merge two list loops,
197 the dual-loop predated the delete-safe list-loop macro.
198
Paul Jakma3fed4162006-07-25 20:44:12 +00001992006-07-25 Paul Jakma <paul.jakma@sun.com>
200
201 * ospf_neigbor.h: (struct ospf_neighbor) Add some additional
202 neighbour state statistics fields, timestamps for progressive
203 and regressive state changes, and pointer to event string
204 for the latter state change.
205 * ospf_nsm.c: (nsm_notice_state_change) Update new state changs
206 history as required.
207 * ospf_vty.c: (show_ip_ospf_neighbor_detail_sub) Print out above
208 new per-neighbour state change stats.
209
Paul Jakma539e1522006-07-11 17:49:22 +00002102006-07-10 Paul Jakma <paul.jakma@sun.com>
211
212 * ospf_nsm.c: (nsm_change_state) call nsm_clear_adj for all
213 adjacency losses, hence removing need for nsm_reset_nbr.
214 (nsm_reset_nbr) kill it, clear_adj in previous does fine.
215 (nsm_kill_nbr,nsm_start) remove nsm_reset_nbr call.
216 (ospf_nsm_event) Allow NSM function to be NULL, this along with
217 removal of nsm_reset_nbr, allows a bunch of now useless functiosn
218 to be removed.
219 Remove some useless variables.
220 (nsm_ignore) now useless, remove.
221 (nsm_bad_ls_req) ditto
222 (nsm_seq_number_mismatch) "
223 (nsm_oneway_received) "
224 (nsm_inactivity_timer) "
225 (nsm_ll_down) "
226 (NSM) replace removed action functions with NULL.
Paul Jakma3d63f382006-07-11 17:52:53 +0000227 (nsm_notice_state_changes) Move state change logging code to new
228 func to declutter nsm_change_state and ospf_nsm_event.
229 Log event with AdjChange, it's useful to know.
230 (nsm_change_state) move adjchange and snmp logging to previous.
231 (ospf_nsm_event) call nsm_notice_state_changes from here.
232 Move the debug message to entry of function, so it gets out
233 even if something goes wrong.
Paul Jakma90c33172006-07-11 17:57:25 +0000234 Record state change timestamp and event in nbr struct.
235 * ospf_neighbor.h: (struct ospf_neighbor) Add fields to record
236 timestamp of last NSM change and event.
237 * ospf_vty.c: (show_ip_ospf_neighbor_detail_sub) Print
238 last state change timestamp and event, if available.
Paul Jakma539e1522006-07-11 17:49:22 +0000239
Andrew J. Schorr13cd3dc2006-07-11 01:50:30 +00002402006-07-10 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
241
242 * ospf_packet.c: (ospf_hello) Improve NetworkMask mismatch warning
243 message to include interface name and conflicting prefix lengths.
244
Paul Jakma1f2c2742006-07-10 07:45:13 +00002452006-07-07 Paul Jakma <paul.jakma@sun.com>
246
247 * ospf_nsm.h: Add a NSM_Deleted neighbour state, to act as dummy
248 state indicating the neighbour is to be deleted.
249 * ospf_nsm.c: (general) Use the NSM_Deleted state to delete
250 neighbours, thus allowing code to be slightly more obvious
251 in its flow.
252 (nsm_timer_set) Add NSM_Deleted. Add another timer the code
253 missed.
254 (nsm_kill_nbr) No need for special case call to nsm_change_state
255 anymore.
256 Make the assert and error-handling for same case more readable
257 (Andrew Schorr)
258 Remove the call to ospf_nbr_delete, nsm_change_state can do
259 this generally now via NSM_Deleted.
260 (struct ... NSM) Add the dummy NSM_Deleted state, the 3 events
261 that can lead to nsm_kill_nbr all now transition the NBR to
262 NSM_Deleted and the general change_state function can be left
263 to do the work.
264 (ospf_nsm_event) Special casing of events and early-return can
265 be removed now.
266 On transition into Deleted, delete the nbr.
267 * ospf_dump.c: (ospf_nsm_state_msg) Add Deleted.
268
Paul Jakmaaa2737a2006-07-06 11:12:39 +00002692006-07-06 Paul Jakma <paul.jakma@sun.com>
270
271 * ospf_nsm.c: (ospf_nsm_event) LLDown event also results in nbr
272 being deleted, requires early-return too. Likely explains
273 some crash reports after interface events.
274
Paul Jakmaf7a76ab2006-07-04 13:57:49 +00002752006-07-04 Paul Jakma <paul.jakma@sun.com>
276
277 * ospf_nsm.c: (general) Various small cleanups from Andrew's
278 review of last set of patches.
279 (nsm_timer_set) Loading, Full and default can share
280 same code too.
281 (nsm_should_adj) Can just be one big OR.
282 (nsm_twoway_received) Collapse into return statement.
283
Paul Jakmad7b0fb62006-07-04 13:35:24 +00002842006-07-02 Paul Jakma <paul.jakma@sun.com>
285
286 * ospf_nsm.c: (nsm_should_adj) New function, just consolidate the
287 10.4 adjacency check from nsm_twoway_received/nsm_adj_ok.
288 (nsm_twoway_received/nsm_adj_ok) Use former.
Paul Jakmad1b1cd82006-07-04 13:50:44 +0000289 (nsm_clear_adj) clear adjacency related state for a
290 neighbour, needed for some state changes from > ExStart down
291 to ExStart or less, which need not go through nsm_reset_nbr.
292 (nsm_reset_nbr) move code to former. Should be static.
Paul Jakmaba0beb42006-07-04 13:44:19 +0000293 (ospf_nsm_event) Don't allow action functions to change
294 next_state if the NSM tables do not indicate next_state is
295 conditional, log warning if one tries - existing code
296 appears fine though.
Paul Jakmad1b1cd82006-07-04 13:50:44 +0000297 Remove long dead code.
298 Use nsm_clear_adj for state changes that take down
299 adjacencies to TwoWay/ExStart.
Paul Jakmae55dd532006-07-04 13:46:14 +0000300 (nsm_timer_set) ls_req timer should be OFF in early states.
301 Compact several identical sections.
302 Set inactivity timer to OFF for Down, for documentary
303 purposes.
Paul Jakmad1b1cd82006-07-04 13:50:44 +0000304 (nsm_kill_nbr) Oops, action function shouldn't try return
305 1 for error.
Paul Jakma5db95bc2006-07-04 13:52:29 +0000306 * ospf_lsa.c: (ospf_translated_nssa_refresh) CID #13.
Paul Jakmad7b0fb62006-07-04 13:35:24 +0000307
Andrew J. Schorr1c066bf2006-06-30 16:53:47 +00003082006-06-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
309
310 * ospf_vty.c: (show_ip_ospf_neighbor_id) Should show all instances
311 of that neighbor (since it may appear on multiple interfaces)
312 instead of bailing out after showing the first match.
313
Andrew J. Schorr76947872006-06-30 03:21:05 +00003142006-06-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
315
316 * ospf_nsm.c: (nsm_twoway_received) When deciding whether to
317 change from state Init to ExStart, the test for whether the
318 neighboring router is DR or BDR should be against the
319 local router's notion of DR/BDR, not the neighbor's view.
320
Andrew J. Schorrd7e60dd2006-06-29 20:20:52 +00003212006-06-28 Erik Muller <erikm@internap.com>
322
323 * ospfd.h: Define 2 new struct ospf config flags:
324 OSPF_LOG_ADJACENCY_CHANGES and OSPF_LOG_ADJACENCY_DETAIL
325 * ospf_nsm.c (nsm_change_state): Log adjacency changes if
326 requested.
327 * ospf_vty.c (ospf_log_adjacency_changes): New command function
328 to implement ospf subcommand "log-adjacency-changes [detail]".
329 (no_ospf_log_adjacency_changes) Turn off log-adjacency-changes.
330 (show_ip_ospf) Show whether adjacency changes are logged.
331 (ospf_config_write) Add "log-adjacency-changes [detail]" to config.
332 (ospf_vty_init) Add ospf_log_adjacency_changes and
333 no_ospf_log_adjacency_changes.
334
Paul Jakma9560fa82006-06-26 12:50:06 +00003352006-06-26 Paul Jakma <paul.jakma@sun.com>
336
337 * ospf_abr.c: (general) NSSA translate-candidate ABRs need to
338 be ASBRs, or other routers may rightfully refuse to install
339 translated type-5s LSAs. reported by dendroot@gmail.com.
340 (ospf_abr_nssa_check_status) Detect change in translator
341 state when ABR, and inc/dec redistribute count as when we
342 leave/enter the disabled state - so that translate-enabled
343 ABR properly sets ASBR bit on non-NSSA areas.
344 Run the resulting function through indent to clean it up.
345 * ospf_lsa.c: (router_lsa_flags) For purposes of ASBR bit,
346 NSSA area is same as stub area.
347
Andrew J. Schorr0ffb7092006-06-24 19:40:13 +00003482006-06-24 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
349
Andrew J. Schorr9aecfae2006-06-24 20:05:02 +0000350 * ospf_snmp.c: (ospfTrapNbrStateChange, ospfTrapIfStateChange) Improve
351 info log message to indicate why the trap is being sent.
352
3532006-06-24 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
354
Andrew J. Schorr0ffb7092006-06-24 19:40:13 +0000355 * ospf_dump.c: (config_write_debug) Fix typo to show debug ospf nsm
356 status properly (not ism status).
357
Andrew J. Schorr6e72cb62006-06-18 00:45:48 +00003582006-06-17 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
359
360 * ospf_vty.c: ({no_,}ospf_passive_interface) Replace if_lookup_by_name
361 with a call to if_get_by_name -- if the interface does not exist
362 already, it should be created. And remove the obsolete warning
363 message.
364
Paul Jakma429ac782006-06-15 18:40:49 +00003652006-06-15 Paul Jakma <paul.jakma@sun.com>
366
367 * ospf_interface.h: (struct ospf_if_info) Add reference counts
368 for multicast group memberships. Add various macros to help
369 manipulate/check membership state.
370 * ospf_interface.c: (ospf_if_set_multicast) Maintain the
371 ospf_if_info reference counts, and only actually drop
372 memberships if it hits 0, to avoid losing membership when
373 OSPF is disabled on an interface with multiple active OSPF
374 interfaces.
375 * ospf_packet.c: (ospf_{hello,read}) Use the new macros to
376 check/set
377 multicast membership.
378 * ospf_vty.c: (show_ip_ospf_interface_sub) ditto.
379
Paul Jakmaac904de2006-06-15 12:04:57 +00003802006-05-31 Paul Jakma <paul.jakma@sun.com>
381
382 * ospf_lsdb.c: (ospf_lsdb_delete) robustify against NULL arguments,
383 print warning.
384 * ospf_lsa.c: (ospf_discard_from_db) ditto.
385 (ospf_maxage_lsa_remover) Check lsa->lsdb for validity, possible
386 mitigation (but not solution) for bug #269.
387
Paul Jakma88871b12006-06-15 11:41:19 +00003882006-05-30 Paul Jakma <paul.jakma@sun.com>
389
390 * ospf_packet.c: (ospf_read) Debug message about packets
391 received on unenabled interfaces should be conditional on
392 debug being set.
393
Paul Jakmad1c65c22006-06-27 08:01:43 +00003942006-05-23 Paul Jakma <paul.jakma@sun.com>
395
396 * ospf_vty.c: (general) Replace in-place route redistribution
397 command and help strings with the new auto-generated defines
398 from lib/route_types.h
399
Paul Jakmaae128052006-05-12 23:15:30 +00004002006-05-13 Paul Jakma <paul.jakma@sun.com>
401
402 * ospf_lsa.c: (ospf_translated_nssa_refresh) fix the sanity
403 check to match the assert, small error in CID #13 fix.
404
Paul Jakma70461d72006-05-12 22:57:57 +00004052006-05-12 Paul Jakma <paul.jakma@sun.com>
406
407 * ospf_lsa.c: (ospf_lsa_action) Get rid of the ospf_lookup
408 call, which is not checked for NULL return, by stripping out
409 functionality which is never used, hence fixing Coverity CID
410 #29.
411 (struct lsa_action) remove unused member.
Paul Jakmae54e6e52006-05-12 23:11:14 +0000412 (ospf_translated_nssa_refresh) Add non-assert sanity check,
413 in case DEBUG isn't defined.
414 Debug message when no type7 exists should print the ID from
415 the type5, not the type7, fixes CID #13.
416 * ospf_interface.c: (ospf_if_exists) Fix missing NULL return
Paul Jakmae43be0e2006-05-12 23:00:06 +0000417 check on ospf_lookup, CID #27.
Paul Jakma6db3a6f2006-05-12 23:02:46 +0000418 * ospf_asbr.c: (ospf_redistribute_withdraw) remove ospf_lookup
419 call by taking the struct ospf * as argument, which the
420 caller has, fixing CID #28.
421 * ospf_asbr.h: (ospf_redistribute_withdraw) update declaration
422 * ospf_zebra.c: (ospf_redistribute_unset) update call to
423 ospf_redistribute_withdraw to match.
Paul Jakmabfd7c7d2006-05-12 23:04:45 +0000424 * ospf_ia.c: (ospf_update_router_route) ospf->backbone could be
425 NULL when passed to ospf_find_asbr_route_through_area,
426 check for NULL first, CID #14.
Paul Jakmadeb15612006-05-12 23:07:27 +0000427 * ospf_ism.c: (ism_change_state) NULL check on oi->area is
428 useless, it's always valid. Only possibility where it
429 couldn't be is if there is a race between abr_task and
430 cleaning up oi's, in which case a NULL check here isn't going
431 to do anything. Fixes CID #15.
Paul Jakma70461d72006-05-12 22:57:57 +0000432
Paul Jakmacac3b5c2006-05-11 13:31:11 +00004332006-05-11 Paul Jakma <paul.jakma@sun.com>
434
435 * ospf_vty.c: (general) Audit ospf_lookup calls in commands,
436 ensure check for NULL result, make vty messages consistent.
437 (show_ip_ospf_interface) Missing NULL check on ospf_lookup
438 result, fixes Coverity CID #70.
Paul Jakma1a8ec2b2006-05-11 13:34:08 +0000439 (no_ospf_area_filter_list) Check NULL result from
440 ospf_area_lookup_by_area_id, fixes Coverity CID #69
Paul Jakma894f8b62006-05-12 22:50:40 +0000441 * ospf_route.c: (ospf_route_delete_same_ext) Fix deref before
442 NULL check by moving into check-protected block, fix CID #49.
Paul Jakma214a4452006-05-12 22:51:49 +0000443 * ospf_abr.c: (ospf_area_range_cost_set) Shouldn't create a new
444 range, should just lookup to see if one exists, the new range
445 is just leaked. Fixes CID #46.
Paul Jakma4021b602006-05-12 22:55:41 +0000446 * ospf_lsa.c: (ospf_default_originate_timer) Let the thread
447 take (struct ospf *) as thread argument, rather than (struct
448 ospf *)->default_originate, thus avoiding having to call
449 ospf_lookup.
450 * ospf_zebra.c: (ospf_redistribute_default_set) change setup
451 of ospf_default_originate_timer thread to match.
452 * ospfd.c: (ospf_router_id_update) ditto.
Paul Jakmacac3b5c2006-05-11 13:31:11 +0000453
Paul Jakma9c27ef92006-05-04 07:32:57 +00004542006-04-24 Paul Jakma <paul.jakma@sun.com>
455
456 * (general) More Virtual-link fixes, again with much help in
457 testing / debug from Juergen Kammer. Primarily in SPF.
458 * ospf_spf.h: Add guard. ospf_interface.h will include this
459 header.
460 * ospf_interface.h: Modify ospf_vl_lookup definition to take
461 struct ospf as argument, so as to allow for NULL area
462 argument.
463 (struct ospf_vl_data) Remove out_oi, instead add a struct
464 vertex_nexthop, to use as initial nexthop for backbone paths
465 through a vlink.
466 * ospf_interface.c: (ospf_vl_lookup) Modified to allow
467 NULL area to be passed to indicate "any" (first) area.
468 Add extra debug.
469 (ospf_vl_set_params) vl_oi -> nexthop. Add extra debug.
470 (ospf_vl_up_check) Fix debug, inet_ntoa returns a static
471 buffer..
472 * ospf_route.c: (ospf_intra_add_router) Vlinks dont go through
473 backbone, don't bother checking.
474 * ospf_spf.c: (static struct list vertex_list) Record vertices
475 that will need to be freed.
476 (cmp) Order network before router vertices, as required,
477 wasn't implemented.
478 (vertex_nexthop_free) Mild additional robustness check.
479 (vertex_parent_free) Take void argument, as this function
480 is passed as list deconstructor for vertex parent list.
481 (ospf_vertex_new) More debug. Set deconstructor for parent
482 list. Track allocated vertices on the vertex_list.
483 (ospf_vertex_free) Get rid of the tricky recursive cleanup of
484 vertices. Now frees only the given vertex.
485 (ospf_vertex_add_parent) Fix assert.
486 (ospf_nexthop_calculation) Fix calculation of nexthop for
487 VLink vertices, lookup the vl_data and use its previously
488 recorded nexthop information.
489 (ospf_spf_calculate) Vertices are freed simply by deleting
490 vertex_list nodes and letting ospf_vertex_free as deconstructor
491 work per-node.
492 (ospf_spf_calculate_timer) Trivial optimisation, leave
493 backbone SPF calculation till last to reduce SPF churn on
494 VLink updates.
495 * ospf_vty.c: (ospf_find_vl_data) update call to ospf_vl_lookup
496 (no_ospf_area_vlink_cmd) ditto.
497 (show_ip_ospf_interface_sub) For Vlinks, the peer address is
498 more interesting than the output interface.
499
Paul Jakma478aab92006-04-03 21:25:32 +00005002006-04-03 Paul Jakma <paul.jakma@sun.com>
501
502 * (general) Fix issues with handling of Vlinks and entries
503 in the nbrs route-table which were highlighted by the
504 nsm/nbr_self fixes from bug #234. Many thanks to Juergen
505 Kammer for his help and efforts in testing out debug patches to
506 pinpoint the issue.
507 * ospf_interface.c: (ospf_vl_new) Add nbr_self for Vlink.
508 * ospf_neighbor.c: (ospf_nbr_key) new static function, helper
509 to create key in nbrs table for a given nbr.
510 (ospf_nbr_delete) Use ospf_nbr_key. Add an assert() to
511 document an expected state.
512 (ospf_nbr_add_self) Ditto.
513 (ospf_nbr_lookup_by_addr) Add an assert.
514 * ospf_nsm.c: (nsm_kill_nbr) Can never kill the nbr_self
515 psuedo-neighbour.
516
Paul Jakma075c2012006-03-30 14:34:31 +00005172006-03-27 Paul Jakma <paul.jakma@sun.com>
518
519 * ospf_lsa.c: (ospf_lsa_checksum) Add an explicit cast to avoid
520 the ambiguities of ANSI and C99 C with respect to type
521 conversion. Detailed problem report and test case with
522 example data supplied by Dmitry Ivanov <dimss@telecentrs.lv>.
523
Paul Jakma1a8ee0e2006-03-30 14:20:00 +00005242006-03-25 Paul Jakma <paul.jakma@sun.com>
525
526 * ospf_interface.c: (ospf_if_lookup_recv_if) Ignore loopbacks,
527 we can never ever receive packets on those. Should fix
528 case where CARP is run with address in same subnet as real
529 interface. Problem report and diagnosis thanks to:
530 Landon Fuller <landonf@opendarwin.org>.
531 However, ospf_read() still can't deal deterministically with
532 multiple interfaces in same subnet.
533
Paul Jakmac2b478d2006-03-30 14:16:11 +00005342006-03-23 Steve Lawson <steve.lawson@aheadcomusa.com>
535
536 * ospf_lsa.c: (ospf_lsa_install) Fix incorrect byte-order
537 conversion of OSPF_MAX_SEQUENCE_NUMBER
538
paule8e19462006-01-19 20:16:55 +00005392006-01-19 Paul Jakma <paul.jakma@sun.com>
540
541 * (general) various miscellaneous compiler warning fixes.
542 Remove redundant break statements from switch clauses
543 which return.
544 return from main, not exit, cause it annoys SOS.
545 Remove stray semi-colons which cause empty-statement
546 warnings.
547
paul779adb02006-01-18 15:07:38 +00005482006-01-18 Juergen Kammer <j.kammer@eurodata.de>
549
550 * ospf_lsa.c: (ospf_router_lsa_new) dont take reference to the
551 stream data until it is constructed, data reference is
552 volatile due to the potential resize in link_info_set
553
5542006-01-18 Paul Jakma <paul.jakma@sun.com>
555
556 * ospf_lsa.c: (link_info_set) Resize the stream if required and
557 possible. Return number of links added.
558 (lsa_link_*_set) use return value from previous.
559 * ospf_lsa.h: Add OSPF_ROUTER_LSA_LINK_SIZE define.
560
paulc6371712006-01-17 17:49:53 +00005612006-01-17 Paul Jakma <paul.jakma@sun.com>
562
563 * ospf_packet.c: (ospf_verify_header) print out the types
564 involved if there's a mismatch.
565 * ospf_zebra.c: (ospf_zebra_add) Adjust to new zserv format.
566
paul818e56c2006-01-10 23:27:05 +00005672006-01-10 Len Sorensen <lennartsorensen@ruggedcom.com>
568
569 * (general) Bug #234, see also [quagga-dev 3902].
570 Fix problem with nbr_self not being properly reinitialised
571 when an interface comes up, after having been down.
paul1a643f82006-01-11 01:08:19 +0000572 Some re-arrangement done by Paul Jakma, any bugs introduced
573 on top of Len's suggested changes are his.
paul818e56c2006-01-10 23:27:05 +0000574 * ospf_neighbor.c: (ospf_nbr_add_self) centralise
575 initialisation of nbr_self parameters here.
576 * ospf_interface.c: (ospf_if_new) deleting initialisation of
577 parameters of nbr_self, just rely on call to
578 ospf_nbr_add_self.
579 (ospf_if_cleanup) ditto.
580 * ospfd.c: (ospf_network_run) ditto.
581
paul98429f62006-01-10 22:11:54 +00005822006-01-10 Juris Kalnins <juris@mt.lv>
583
584 * ospf_zebra.c: (ospf_interface_address_delete) fix rare leak of
585 struct connected in an error case.
paul818e56c2006-01-10 23:27:05 +0000586 * ospf_packet.c: (ospf_make_md5_digest) fix odd, if not
587 undefined effect, assignment of an increment expression.
paul98429f62006-01-10 22:11:54 +0000588
paul86752842006-01-10 20:34:46 +00005892006-01-10 Paul Jakma <paul.jakma@sun.com>
590
591 * ospfd.c: (ospf_network_run) checking to see if router-id
592 is set should be on ospf->router_id, not router_id_static.
593 This was causing ospfd to not start if router-id had not
594 been configured statically.
595 (ospf_if_update) ditto.
paulc42c1772006-01-10 20:36:49 +0000596 * ospf_vty.c: (config_write_ospf_distribute) trim down
597 redundant strings.
paul86752842006-01-10 20:34:46 +0000598
paul00c290e2005-11-26 09:21:43 +00005992005-11-26 Paul Jakma <paul.jakma@sun.com>
600
601 * ospf_api.c: (struct opaque_lsa) change from gcc zero-length
602 array to C99 incomplete type array.
paulc9c93d52005-11-26 13:31:11 +0000603 * (general) s/graceful/deferred/ in all files, the former term
604 is confusing wrt OSPF Graceful-Restart.
605 * ospfd.c: (ospf_deferred_shutdown_check) dont return
606 a function which returns void. SOS complains about this.
607 (ospf_finish)
paul00c290e2005-11-26 09:21:43 +0000608
paulb29800a2005-11-20 14:50:45 +00006092005-11-20 Paul Jakma <paul.jakma@sun.com>
610
611 * ospfd.h: remove the OSPF_ROUTER_ID_UPDATE_DELAY define
612 (struct ospf) remove the router_id timer thread.
613 remove export of ospf_router_id_update_timer.
614 * ospfd.c: (ospf_router_id_update) call ospf_if_update to
615 poke interfaces into action after ID has been configured.
616 (ospf_router_id_update_timer) removed.
617 (ospf_finish_final) t_router_id_update timer is gone.
618 (ospf_network_run) router-id update timer gone.
619 call ospf_router_id_update directly if ID not configured.
620 In the per-iface loop, don't ospf_if_up interfaces if
621 ID is still not configured. The update function will call
622 ospf_if_update anyway.
623 (ospf_if_update) ID update timer is gone. Just return if no
624 ID is set.
625 * ospf_vty.c: (ospf_router_id) call ospf_router_id_update, no
626 timer needed.
627 * ospf_zebra.c: (ospf_router_id_update_zebra) call
628 ospf_router_id_update directly, not via timer.
paulc24d6022005-11-20 14:54:12 +0000629 * ospf_abr.c: (ospf_abr_announce_network_to_area) check
630 returned LSA of ospf_summary_lsa_refresh and print warning if
631 it failed.
632 (ospf_abr_announce_network_to_area) similar
633 (ospf_abr_announce_rtr_to_area) similar
634 * ospf_lsa.c: (ospf_router_lsa_new) check LSA returned is valid.
635 (ospf_router_lsa_originate) similar
636 (ospf_router_lsa_refresh, ospf_network_lsa_new) similar
637 (ospf_summary_lsa_new) Check ID is valid.
638 (ospf_summary_lsa_originate) ditto, and check returned LSA from
639 previous function is !NULL.
640 (ospf_summary_lsa_refresh) check ospf_summary_lsa_new return
641 is !NULL.
642 (ospf_summary_asbr_lsa_new) ID valid check.
643 (ospf_summary_asbr_lsa_originate) similar.
paulb29800a2005-11-20 14:50:45 +0000644
ajs70cd3472005-11-16 19:33:22 +00006452005-11-16 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
646
ajs649654a2005-11-16 20:17:52 +0000647 * ospf_dump.h: Define OSPF_TIME_DUMP_SIZE as appropriate buffer size
648 for use with ospf_timer_dump and ospf_timeval_dump.
649 * ospf_vty.c: Change all buffer sizes used with ospf_timer_dump and
650 ospf_timeval_dump to have size OSPF_TIME_DUMP_SIZE.
651 (show_ip_ospf_interface_sub) Fix possible buffer overflow in
652 call to ospf_timer_dump.
653
6542005-11-16 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
655
ajs70cd3472005-11-16 19:33:22 +0000656 * ospf_ism.h: (OSPF_ISM_TIMER_OFF) Improve macro syntax by enclosing
657 in 'do {...} while(0)'.
658
paul31a59762005-11-14 11:11:11 +00006592005-11-14 Paul Jakma <paul.jakma@sun.com>
660
661 * ospfd.c: (ospf_new) stub-shutdown should just default to
662 unconfigured, too strange otherwise.
663 (ospf_finish_final) t_opaque_lsa_self TIMER_OFF should be
664 preprocessor conditional on HAVE_OPAQUE_LSA.
665 * ospfd.h: (struct ospf) remove the SHUTDOWN_DEFAULT define.
666 no longer used, plus it wasn't in range that the command
667 accepted.
668 * ospf_zebra.h: Depends on vty.h, include it.
669
paul58e1bef2005-11-11 12:10:03 +00006702005-11-11 Paul Jakma <paul.jakma@sun.com>
671
672 * ospf_spf.c: (ospf_canonical_nexthops_free) Free only
673 the nexthops pointing to the root vertex. We may visit a
674 vertex twice or the vertex may have some inherited nexthops,
675 if we free other nexthops we could crash.
676
paulc8c15212005-11-04 12:31:39 +00006772005-11-04 Paul Jakma <paul.jakma@sun.com>
678
679 * ospf_{dump,spf,vty}.c: Oops, use the internal tv_sub
680 function rather than unportable timersub.
681
paul484315f2005-11-03 09:08:29 +00006822005-11-03 Paul Jakma <paul.jakma@sun.com>
683
684 * ospf_apiserver.c: (apiserver_sync_callback) stray semi-colon
685 * ospf_packet.c: include checksum.h, remove the in_cksum extern
686 * prototypes.
687 * ospf_te.h: Add braces, quell warning.
paul6d452762005-11-03 11:15:44 +0000688 * ospf_packet.c: Change level of some warnings to
689 informational.
paulc8c15212005-11-04 12:31:39 +0000690
paul88d6cf32005-10-29 12:50:09 +00006912005-10-29 Paul Jakma <paul.jakma@sun.com>
692
693 * (general) RFC3137 stub-router support
694 * ospfd.h: Add OSPF_OUTPUT_COST_INFINITE define.
695 (struct ospf_master) Add a OSPF_MASTER_SHUTDOWN flag for
696 options, to allow shutdown to distinguish between complete
697 shutdown and shutdown of a subset of ospf instances.
698 (struct ospf)
699 Add stub_router_{startup,shutdown_}time, configuration of startup
700 and shutdown time for stub-router.
701 Add t_graceful_shutdown struct thread, timer for graceful
702 shutdown, if needed.
703 (struct ospf_area) Add stub_router_state - run time state of
704 stub-router for an area. Add flags for ADMIN, IS and WAS
705 states.
706 Add t_stub_router, timer thread to resend router-lsa for an
707 area.
708 * ospf_lsa.c: (ospf_link_cost) new simple function to spit out
709 either the given lnks cost or infinite cost if stub-router is
710 in effect.
711 (lsa_link_{ptop,broadcast,virtuallink,ptomp}_set) use
712 previous function for transit-links.
713 (ospf_stub_router_timer) timer thread for end of startup stub
714 router. Change state as required for the area and setup
715 re-origination of router-lsa.
716 (ospf_stub_router_check) Check/do whether stub-router should be
717 enabled, and whether it requires timer to be setup.
718 (ospf_router_lsa_new) call previous function at top.
719 (ospf_router_lsa_originate) no external callers, made static.
720 * ospf_lsa.h: (ospf_router_lsa_originate) removed.
721 * ospf_main.c: (sigint) make static.
722 remove call to exit, as ospf_terminate now deals with
723 exiting.
724 * ospf_route.c: (ospf_terminate) removed, now in ospfd.c.
725 * ospf_vty.c: (show_ip_ospf_area) print out state of
726 stub-router, if active.
727 (show_ip_ospf) print out configuration of stub-router
728 support, and details of graceful-shutdown if the timer is
729 active.
730 ((no)?ospf_max_metric_router_lsa_{admin,startup,shutdown}) new
731 commands to (de-)?configure stub-router support.
732 (config_write_stub_router) write out config of stub-router.
733 (ospf_config_write) call previous.
734 (ospf_vty_init) install the new stub-router commands.
735 * ospfd.c: various functions made static.
736 (ospf_new) Set defaults for stub-router. Graceful shutdown
737 is made to default on, just to be adventerous.
738 (ospf_graceful_shutdown_finish) new function, final part of
739 shutdown.
740 (ospf_graceful_shutdown_timer) timer thread wrapper for
741 graceful-shutdown.
742 (ospf_graceful_shutdown_check) check whether to setup timer
743 for shutdown or proceed directly to final shutdown.
744 (ospf_terminate) moved here from ospf_route.c, call
745 ospf_finish for each instance.
746 (ospf_finish) renamed to ospf_finish_final and made static.
747 (ospf_finish) new function, exported wrapper around
748 ospf_graceful_shutdown_check.
749 (ospf_finish_final) complete shutdown of an instance.
750 Add missing TIMER_OFF's of two timer threads.
751 (ospf_area_free) opaque self lsa timer should be turned off.
752
paulb8ad39d2005-10-23 15:23:05 +00007532005-10-23 Paul Jakma <paul.jakma@sun.com>
754
paule029d442005-10-23 15:26:24 +0000755 * ospf_apiserver.c: (ospf_apiserver_term) This function should
756 not have side-effects (eg segv) if no apiserver instances are
757 active, ie be robust.
paulb8ad39d2005-10-23 15:23:05 +0000758 * ospf_vty.c: (show_ip_ospf) fix display of SPF timer if it
759 has not yet been run.
760
paulf9ad9372005-10-21 00:45:17 +00007612005-10-21 Paul Jakma <paul.jakma@sun.com>
762
paulea4ffc92005-10-21 20:04:41 +0000763 * ospf_dump.c: (ospf_timeval_dump) fix ms adjustment, thanks to
764 Andrew Schorr.
765 * ospf_vty.c: (ospf_config_write) fix write out of spf timers
766 configuration.
767
7682005-10-21 Paul Jakma <paul.jakma@sun.com>
769
pauld24f6e22005-10-21 09:23:12 +0000770 * (general) SPF millisecond resolution timer with adaptive,
771 linear back-off holdtime. Prettification of ospf_timer_dump.
772 * ospf_dump.c: (ospf_timeval_dump) new function. The guts of
773 ospf_timer_dump, but made to be more dynamic in printing out
774 the relative timeval, sliding the precision printed out
775 according to the value.
776 (ospf_timer_dump) guts moved to ospf_timeval_dump.
777 * ospf_dump.h: export ospf_timeval_dump.
778 * ospf_flood.c: (ospf_flood) remove gettimeofday, use
779 the libzebra exported recent_time instead, as it's not
780 terribly critical to have time exactly right - the dropped
781 LSA will be retransmited to us if we don't ACK it.
782 * ospf_packet.c: (ospf_ls_upd_timer) Ditto, but here we're
783 not transmitting, just putting LSA back on update transmit list.
784 * ospfd.h: delay and holdtimes should be unsigned.
785 Add spf_max_holdtime and spf_hold_multiplier.
786 Update default defines for delay and hold time to be in msec.
787 (struct ospf) change the SPF timestamp to a struct timeval.
788 Remove ospf_timers_spf_(un)?set.
789 * ospfd.c: (ospf_timers_spf_{set,unset}) removed.
790 (ospf_new) initialise spf_max_holdtime and spf_hold_multiplier
791 * ospf_spf.c: (ospf_spf_calculate) SPF timestamp is a timeval
792 now, update with gettimeofday.
793 (ospf_spf_calculate_schedule) Change SPF timers to millisecond
794 resolution.
795 Make the holdtime be adaptive, with a linear increase in
796 holdtime ever consecutive SPF run which occurs within holdtime
797 of previous SPF, bounded by spf_max_holdtime.
798 * ospf_vty.c: Update spf timers commands.
799 (ospf_timers_spf_set) trivial helper.
800 (ospf_timers_throttle_spf_cmd) new command to set SPF delay,
801 initial hold and max hold times with millisecond resolution.
802 (ospf_timers_spf_cmd) Deprecated. Accept the old values,
803 convert to msec, truncate to new limits.
804 (no_ospf_timers_throttle_spf_cmd) set timers to defaults.
805 (no_ospf_timers_spf_cmd) deprecated form, same as previous.
806 (show_ip_ospf_cmd) Display SPF parameters and times.
807 (show_ip_ospf_neighbour_header) Centralise the 'sh ip os ne'
808 header.
809 (show_ip_ospf_neighbor_sub) Fix the field widths. Get rid of
810 the multiple spaces which were making the lines even longer.
811 (show_ip_ospf_neighbor_cmd) Use show_ip_ospf_neighbour_header
812 (show_ip_ospf_neighbor_all_cmd) ditto and fix the field
813 widths for NBMA neighbours.
814 (show_ip_ospf_neighbor_int) Use header function.
815 (show_ip_ospf_nbr_nbma_detail_sub) use sizeof for timebuf,
816 local array - safer.
817 (show_ip_ospf_neighbor_detail_sub) ditto
818 (ospf_vty_init) install the new SPF throttle timer commands.
819
8202005-10-21 Paul Jakma <paul.jakma@sun.com>
821
paulf9ad9372005-10-21 00:45:17 +0000822 * (general) OSPF fast, sub-second hello and 1s dead-interval
823 support.
824 * ospf_dump.c: (ospf_timer_dump) Print out milliseconds too.
825 Callers typically specify a length of 9, so most see
826 millisecs unless they specify the additional length.
827 * ospf_interface.h: (struct ospf_interface) new interface param,
828 fast_hello.
829 * ospf_interface.c: (ospf_if_table_lookup) add brackets,
830 gcc warning fix.
831 (ospf_new_if_params) Initialise fast_hello param.
832 (ospf_free_if_params) Check whether fast_hello is configured.
833 (ospf_if_new_hook) set fast_hello to default.
834 * ospf_ism.h: Wrap OSPF_ISM_TIMER_ON inside do {} while (0) to
835 prevent funny side-effects from its if statement when this
836 macro is used conditionally by other macros.
837 (OSPF_ISM_TIMER_MSEC_ON) new macro, set in milliseconds.
838 (OSPF_HELLO_TIMER_ON) new macro to set hello timer according
839 to whether fast_hello is set.
840 * ospf_ism.c: Update all setting of the hello timer to use
841 either OSPF_ISM_TIMER_MSEC_ON or OSPF_HELLO_TIMER_ON. The
842 former is used when hello is to be sent immediately.
843 * ospf_nsm.c: ditto
844 * ospf_packet.c: (ospf_hello) hello-interval is not checked
845 for mismatch if fast_hello is set.
846 (ospf_read) Annoying nit, fix "no ospf_interface" to be debug
847 rather than a warning, as it can be perfectly normal to
848 receive packets when logical subnets are used.
849 (ospf_make_hello) Set hello-interval to 0 if fast-hellos are
850 configured.
851 * ospf_vty.c: (ospf_auto_cost_reference_bandwidth) annoying
852 nit, don't vty_out if this command is given, it gets tired
853 quick.
854 (show_ip_ospf_interface_sub) Print the hello-interval
855 according to whether fast-hello is set or not.
856 Print the extra 5 millisec characters from (ospf_timer_dump)
857 if fast-hello is configured.
858 (ospf_vty_dead_interval_set) new function, common to all
859 forms of dead-interval command, to set dead-interval and
860 fast-hello correctly. If a dead-interval is given, unset
861 fast-hello, else if a hello-multiplier is set, set
862 dead-interval to 1 and fast-hello to given multiplier.
863 (ip_ospf_dead_interval_addr_cmd) use
864 ospf_vty_dead_interval_set().
865 (ip_ospf_dead_interval_minimal_addr_cmd) ditto.
866 (no_ip_ospf_dead_interval) Unset fast-hello.
867 (no_ip_ospf_hello_interval) Bug-fix, unset of hello-interval
868 should set it to OSPF_HELLO_INTERVAL_DEFAULT, not
869 OSPF_ROUTER_DEAD_INTERVAL_DEFAULT.
870 (config_write_interface) Write out fast-hello.
871 (ospf_config_write) Write a comment about
872 "auto-cost reference-bandwidth" having to be equal on all
873 routers. Hopefully just as noticeable as old practice of
874 writing to vty, but less annoying.
875 (ospf_vty_if_init) install the two new dead-interval
876 commands.
877 * ospfd.h: Add defines for OSPF_ROUTER_DEAD_INTERVAL_MINIMAL
878 and OSPF_FAST_HELLO_DEFAULT.
879
pauleb3da6d2005-10-18 04:20:33 +00008802005-10-18 Paul Jakma <paul.jakma@sun.com>
881
882 * (general) SPF memory management cleanup and fix for rare
883 double-free bug.
884 * ospf_spf.h: (struct vertex_parent) New struct to hold parent
885 specific data, eg the backlink and the parent vertex pointer,
886 and point to the appropriate general struct vertex_nexthop.
887 (struct vertex_nexthop) remove parent vertex pointer, so
888 this struct can be shared across vertices.
889 (struct vertex) rename list child to list children. Remove
890 list of nexthops, replace with list of vertex_parents.
891 * ospf_spf.c: (update_stat) trivial, remove cast from void *.
892 (vertex_nexthop_new) remove init of parent - field is gone
893 from struct vertex_nexthop.
894 (ospf_canonical_nexthops_free) Remove the canonical
895 vertex_nexthop memory objects. These are the vertex_nexthops
896 attached to the first level of router vertices from the root.
897 (vertex_parent_new) new function, create a vertex_parent.
898 (vertex_parent_free) ditto, but free it.
899 (ospf_vertex_new) Update to match changes to struct vertex.
900 (ospf_vertex_free) Recursively free a struct vertex and its
901 children. The parent list is used as a reference count.
902 vertex_nexthops must be free seperately, if required.
903 (ospf_vertex_dump) update to match struct vertex changes.
904 Print out backlink of parents too.
905 (ospf_vertex_add_parent) ditto.
906 (ospf_lsa_has_link) update comment.
907 (ospf_nexthop_add_unique) removed, not needed anymore.
908 (ospf_nexthop_merge) ditto.
909 (ospf_spf_consider_nexthop) renamed to ospf_spf_add_parent.
910 Simplified to just create vertex_parent and add it.
911 (ospf_spf_flush_parents) new function, flush out the parent
912 list.
913 (ospf_nexthop_calculation) Take the relevant route_lsa_link
914 as an argument, which simplifies things and removes the need
915 for the hack in ospf_nexthop_add_unique - ospf_spf_next
916 already knew exactly which link the cost calculated was for.
917 Update to match struct vertex changes too.
918 (ospf_spf_next) Don't create a vertex for W unnecessarily, if
919 it's there's a vertex already created for W, use it, and
920 hence there's no need to free it either.
921 Update some manipulation/comparisons of distance to match.
922 Flush the parent list if a lower cost path is found.
923 (ospf_spf_route_free) unused, removed.
924 (ospf_spf_dump) match the struct vertex changes, and dump the
925 ifname if possible.
926 (ospf_spf_calculate) At end of SPF, free the canonical nexthops
927 and call ospf_vertex_free on the root vertex to free the
928 entire tree.
929 * ospf_interface.c: (ospf_vl_set_params) match struct vertex
930 changes.
931 * ospf_route.c: (ospf_intra_route_add) ditto
932 (ospf_route_copy_nexthops_from_vertex) ditto
933
paul36238142005-10-11 04:12:54 +00009342005-10-11 Paul Jakma <paul.jakma@sun.com>
935
936 * ospf_api.c: sign warnings.
937 * ospf_apiserver.c: sign warning and convert all the struct
938 in_addr initialisations so as not to make assumptions about
939 how this struct is organised, initialise the s_addr member
940 explicitely.
941 * ospf_packet.c: Add const qualifier to auth_key.
942
vincent77df1f72005-10-06 07:46:22 +00009432005-10-06 Alain Ritoux <alain.ritoux@6wind.com>
944
945 * ospf_snmp.c: Avoid mixing interface and ospf_interface objects
946 which now allows snmpwalk to work with ospfIfTable and
947 also with ospfIfMetricTable
948
ajsf52d13c2005-10-01 17:38:06 +00009492005-10-01 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
950
951 * ospf_dump.c: Remove local hard-coded table ospf_redistributed_proto.
952 (ospf_redist_string) New function implemented using new library
953 function zebra_route_string(). Note that there are a few differences
954 in the output that will result: the new function returns strings
955 that are lower-case, whereas the old table was mixed case. Also,
956 the old table mapped ZEBRA_ROUTE_OSPF6 to "OSPFv3", whereas the
957 new function returns "ospf6".
958 * ospfd.h: Remove extern struct message ospf_redistributed_proto[],
959 and add extern const char *ospf_redist_string(u_int route_type)
960 instead.
961 * ospf_asbr.c: (ospf_external_info_add) In two messages, use
962 ospf_redist_string instead of LOOKUP(ospf_redistributed_proto).
963 * ospf_vty.c: Remove local hard-coded table distribute_str.
964 (config_write_ospf_redistribute,config_write_ospf_distribute): Use
965 new library function zebra_route_string() instead of distribute_str[].
966 * ospf_zebra.c: (ospf_redistribute_set,ospf_redistribute_unset,
967 ospf_redistribute_default_set,ospf_redistribute_check)
968 In debug messages, use ospf_redist_string() instead of
969 LOOKUP(ospf_redistributed_proto).
970
jardin6638c1a2005-10-01 00:08:54 +00009712005-09-30 Vincent Jardin <vincent.jardin@6wind.com>
972
973 * ospf_dump.c, ospf_ia.c, ospf_spf.c, ospf_ase.c:
974 remove unused DEBUG
975
vincentba682532005-09-29 13:52:57 +00009762005-09-29 Alain Ritoux <alain.ritoux@6wind.com>
977
vincent5e4914c2005-09-29 16:34:30 +0000978 * ospf_ism.c: generate SNMP traps on Interface state change
979 * ospf_nsm.c: generate SNMP traps on Neighbour state change
980 * ospf_snmp.[ch]: support for SNMP traps for interface and neighbours.
981
9822005-09-29 Alain Ritoux <alain.ritoux@6wind.com>
983
vincentba682532005-09-29 13:52:57 +0000984 * ospf_vty.c: forece default route LSA to be re_issued whenever
985 cost is changed ( [no] ip ospf area XXX default-cost YYY)
986 Support ignore-mtu option
987 * ospfd.h: define OSPF_MTU_IGNORE_DEFAULT
988 * ospf_packet.c: support ignore-mtu option
989 * ospf_interface.h: field added for skipping MTU check
990 * ospf_interface.c: fix memory leak in ospf_crypt_key_delete()
991 Set mtu_ignore field to default value
992 * ospf_abr.[ch]: export ospf_abr_announce_network_to_area()
993 * ospf_ism.h: add MACRO to convert internal ISM status into SNMP
994 correct values
995 * ospf_snmp.c: add sanity check on LSA type in lsdb_lookup_next()
996 convert OSPFIFSTATE internal status into SNMP values
997
vincentc1a03d42005-09-28 15:47:44 +00009982005-09-28 Alain Ritoux <alain.ritoux@6wind.com>
999
1000 * ospf_packet.c: use new md5 API
1001
ajs5339cfd2005-09-19 13:28:05 +000010022005-09-19 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1003
1004 * ospf_lsa.h: (ospf_external_lsa_flush) Comment out the 5th argument
1005 (nexthop) since it is not used in the function (except inside
1006 some commented-out code).
1007 * ospf_lsa.c: (ospf_external_lsa_flush,ospf_external_lsa_refresh)
1008 Comment out the 5th argument to ospf_external_lsa_flush.
1009 * ospf_asbr.c: (ospf_redistribute_withdraw) Comment out 5th arg
1010 to ospf_external_lsa_flush.
1011 * ospf_vty.c: (no_ospf_default_information_originate) Eliminate 5th
1012 uninitialized nexthop arg to ospf_external_lsa_flush.
1013 * ospf_zebra.c: (ospf_zebra_read_ipv4) Comment out 5th arg
1014 to ospf_external_lsa_flush.
1015 * ospfd.c: (ospf_network_set) Comment out 5th arg
1016 to ospf_external_lsa_flush.
1017
ajse6a0bf92005-09-17 18:53:38 +000010182005-09-17 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1019
1020 * ospf_opaque.c:
1021 (ospf_opaque_lsa_refresh_schedule,ospf_opaque_lsa_flush_schedule)
1022 No need to call ospf_lookup(), just use lsa0->area->ospf instead.
1023
hassobb5b7552005-08-21 20:01:15 +000010242005-08-21 Hasso Tepper <hasso at quagga.net>
1025
1026 * ospf_vty.c: Make "show ip ospf neighbor xxx" commands work.
1027 Interface should be specified by name now.
1028
hasso54bedb52005-08-17 13:31:47 +000010292005-08-17 Hasso Tepper <hasso at quagga.net>
1030
1031 * ospf_vty.c: Check carefully if interface exists before trying to
1032 print info about it.
1033
hasso01018ce2005-08-05 07:40:15 +000010342005-08-05 Hasso Tepper <hasso at quagga.net>
1035
1036 * ospf_zebra.c: Don't assert/stop before type == ZEBRA_ROUTE_MAX if
1037 dealing with routemaps. There is ospf->route_map[ZEBRA_ROUTE_MAX]
1038 for default-information.
1039
paulc8987752005-07-26 06:07:22 +000010402005-07-26 Paul Jakma <paul.jakma@sun.com>
1041
1042 * ospf_abr.c: (ospf_abr_announce_network_to_area) SET_FLAG
1043 should be on lsa not old, which may be freed for one thing,
1044 obviously.
1045
pauld57834f2005-07-12 20:04:22 +000010462005-07-12 Paul Jakma <paul.jakma@sun.com>
1047
1048 * ospfd.h: add OSPF_ABR_DEFAULT for convenience, make
1049 OSPF_ABR_CISCO be the default ABR type.
1050 * ospfd.c: (ospf_new) initialise abr_type to OSPF_ABR_DEFAULT
1051 * ospf_vty.c: (no_ospf_abr_type_cmd) add standard as a negatable
1052 abr_type. default abr_type should be OSPF_ABR_DEFAULT.
1053 (ospf_config_write) test whether default abr_type against
1054 OSPF_ABR_DEFAULT, rather than any specific ABR_TYPE.
1055
hasso8469bd72005-06-20 20:50:10 +000010562005-06-20 Hasso Tepper <hasso at quagga.net>
hassof4833e92005-06-20 20:42:26 +00001057
1058 * ospf_nsm.c: Make database exchange for NSSA database work.
1059
paul7461d452005-06-13 13:57:16 +000010602005-06-13 Paul Jakma <paul.jakma@sun.com>
1061
1062 * ospf_spf.c: Try get more information on a SEGV under
1063 ospf_spf_vertex_add_parent.
1064 (ospf_vertex_free) NULL out the child and nexthop lists
1065 (ospf_vertex_add_parent) nexthop and child can not be NULL
1066 vertex_nexthop's parent->child list can not be NULL
1067 (ospf_spf_next) w and cw are per-loop iteration variables, move
1068 declarations into loop body.
1069
hasso1ddd7292005-06-07 19:54:04 +000010702005-06-07 Hasso Tepper <hasso at quagga.net>
1071
1072 * ospf_apiserver.c: Fix obvious error in notifying clients about ISM
1073 changes - oi->ifp->status doesn't give to us info about ISM,
1074 oi->state does.
1075
paul7e440862005-06-01 11:20:51 +000010762005-06-01 Akihiro Mizutani <mizutani@net-chef.net>
1077
1078 * ospf_ism.c (ospf_elect_bdr/ospf_elect_dr): Fix DR election bug.
1079
paul500e4182005-05-26 17:11:13 +000010802005-05-26 Paul Jakma <paul.jakma@sun.com>
1081
1082 * ospf_abr.c: (ospf_abr_update_aggregate) Fix comment, cost bug itself
1083 had been fixed long ago by Sowmini.
1084
paula3387a42005-05-18 23:29:57 +000010852005-05-19 Paul Jakma <paul.jakma@sun.com>
1086
1087 * ospf_interface.c: (ospf_if_table_lookup) Fix a serious bug
1088 a less serious one.
1089 1: this function is supposed to lookup
1090 entries in the oifs ospf_interface route_table and return either
1091 an existing oi or NULL to indicate not found, its caller depends
1092 on this, yet this function uses route_node_get which /always/
1093 returns a route_node - one is created if none exists. Use
1094 route_node_lookup instead. This should fix root cause of the
1095 reports of the (ospf_add_to_if) assert being hit.
1096 2: oi's are inserted into this table with prefixlength set to
1097 /32 (indeed, it should be a hash table, not a route_table),
1098 however prefixlength to lookup was not changed, if no valid entry
1099 can be inserted other than /32, then nothng but /32 should be
1100 looked up. This possibly only worked by fluke..
1101 Fix confirmed by 2 reporters (one list, one IRC), definitely a
1102 backport candidate once it has been incubated in HEAD for a while.
1103 Thanks to Patrick Friedel and Ivan Warren for testing.
1104
paul69310a62005-05-11 18:09:59 +000011052005-05-11 Paul Jakma <paul.jakma@sun.com>
1106
1107 * (general) Fix memory leaks in opaque AS-scope LSAs, reported and
1108 with much debugging done by by scott collins <scollins@agile.tv>.
1109 * ospf_lsa.c: (ospf_discard_from_db) dont call
1110 ospf_ase_unregister_external_lsa for opaque-lsa's, opaques are
1111 never registered with ase in the first place.
1112 * ospf_packet.c: (general) Disabuse opaque related code of its
1113 tendency to try gather up things into temporary lists.
1114 (ospf_ls_upd) remove the temporary lists opaque uses, call
1115 opaque functions inline, just like all other types.
1116 (ospf_ls_ack) ditto.
1117 (ospf_recv_packet) fixup sign warning.
1118 * ospf_opaque.c: (general) fix the unneeded use of lists, and
1119 untwist some of the logic.
1120 (ospf_opaque_self_originated_lsa_received) take a single LSA
1121 as argument, not a list of them. Remove the list loop. Logic
1122 otherwise unchanged.
1123 (ospf_opaque_ls_ack_received) Mostly ditto. But untwist the logic,
1124 move the actions up into the switch block, remove the goto's and
1125 sanitise the logic near the end a bit.
1126 * ospf_opaque.h: Adjust definitions of aforementioned functions
1127 in ospf_opaque.c to match.
1128
paul42c98192005-05-07 02:22:51 +000011292005-05-07 Yar Tikhiy <yar@comp.chem.msu.su>
1130
1131 * ospf_network.c: Log ifindex on multicast membership leave/join
1132 events.
1133
paul4dadc292005-05-06 21:37:42 +000011342005-05-06 Paul Jakma <paul.jakma@sun.com>
1135
1136 * (general) extern and static qualifiers added.
1137 unspecified arguments in definitions fixed, typically they should
1138 be 'void'.
1139 function casts added for callbacks.
1140 Guards added to headers which lacked them.
1141 Proper headers included rather than relying on incomplete
1142 definitions.
1143 gcc noreturn function attribute where appropriate.
1144 * ospf_opaque.c: remove the private definition of ospf_lsa's
1145 ospf_lsa_refresh_delay.
1146 * ospf_lsa.h: export ospf_lsa_refresh_delay
1147 * ospf_packet.c: (ospf_make_md5_digest) make *auth_key const,
1148 correct thing to do - removes need for the casts later.
1149 * ospf_vty.c: Use vty.h's VTY_GET_INTEGER rather than ospf_vty's
1150 home-brewed versions, shuts up several warnings.
1151 * ospf_vty.h: remove VTY_GET_UINT32. VTY_GET_IPV4_ADDRESS and
1152 VTY_GET_IPV4_PREFIX moved to lib/vty.h.
1153 * ospf_zebra.c: (ospf_distribute_list_update_timer) hacky
1154 overloading of the THREAD_ARG pointer should at least use
1155 uintptr_t.
1156
paul9e67dc22005-04-15 12:10:17 +000011572005-04-15 Zhipeng Gong <zpgong@cdc.3upsystems.com>
1158
1159 * ospf_abr.c: (ospf_abr_announce_network_to_area) dont forget
1160 to approve LSAs for the case where metric has changed, lsa gets
1161 flushed otherwise. (backport candidate).
1162
ajs634f9ea2005-04-11 15:51:40 +000011632005-04-11 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1164
1165 * ospf_zebra.c (ospf_zebra_add): Call zclient_send_message instead
1166 of writen.
1167
ajsd2fc8892005-04-02 18:38:43 +000011682005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1169
ajse4319de2005-04-02 23:23:55 +00001170 * ospf_interface.h: (ospf_if_lookup_by_name) Remove declaration of a
1171 function that does not exist.
1172
11732005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1174
ajs21fefa92005-04-02 23:16:41 +00001175 * ospf_zebra.c: (zebra_interface_if_lookup) Must use
1176 if_lookup_by_name_len.
1177
11782005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1179
ajsa3491982005-04-02 22:50:38 +00001180 * ospf_interface.c: (ospf_vl_new) Use strnlen to fix call to if_create.
1181
11822005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1183
ajsd2fc8892005-04-02 18:38:43 +00001184 * ospf_vty.c: (show_ip_ospf_interface_sub) Show ifindex and interface
1185 flags to help with debugging.
1186 * ospf_zebra.c: (ospf_interface_delete) After deleting, set ifp->ifindex
1187 to IFINDEX_INTERNAL.
1188 (zebra_interface_if_lookup) Make function static. Tighten up code.
1189
ajsaca72fd2005-03-31 15:18:21 +000011902005-03-31 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1191
1192 * ospf_dump.c: (show_debugging_ospf) Show if ospf event debugging
1193 is turned on.
1194
ajsfd651fa2005-03-29 16:08:16 +000011952005-03-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1196
ajsa608bbf2005-03-29 17:03:49 +00001197 * ospf_zebra.c: (ospf_interface_state_up) If the MTU of an operative
1198 interface changes, print a debug message and call ospf_if_reset()
1199 to simulate down/up on the interface.
1200 * ospf_interface.h: Declare new function ospf_if_reset().
1201 * ospf_interface.c: (ospf_if_reset) New function to call ospf_if_down
1202 and ospf_if_up for all ospf interfaces attached to an interface.
1203
12042005-03-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1205
ajs5dcbdf82005-03-29 16:13:49 +00001206 * ospf_packet.c: (ospf_write_frags) Enhance error message to
1207 show MTU. Also make function static.
1208 (ospf_write) Enhance error message to show interface name and MTU.
1209 Also make function static.
1210
12112005-03-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1212
1213 * ospf_vty.c: (show_ip_ospf_interface_sub) Display interface MTU and
1214 bandwidth; this is useful for debugging problems. Also, the function
1215 should be static.
ajsfd651fa2005-03-29 16:08:16 +00001216
hasso1b639042005-03-27 13:32:25 +000012172005-03-27 Hasso Tepper <hasso at quagga.net>
1218
1219 * ospf_snmp.c: Don't crash in snmp query if ospf instance doesn't
1220 exist at all.
1221
hasso343f5cc2005-03-25 19:48:40 +000012222005-03-25 Hasso Tepper <hasso at quagga.net>
1223
1224 * ospfd.h: Include log.h, fixes compile with gcc-4.0.
1225
ajs9dbc7972005-03-13 19:27:22 +000012262005-03-13 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1227
1228 * ospf_lsa.c: (ospf_lsa_refresh_walker) If the system clock jumps
1229 backward, then current time may be less than
1230 ospf->lsa_refresher_started. This was causing invalid values
1231 for ospf->lsa_refresh_queue.index resulting in infinite loops.
1232 Problem fixed by casting the expression to unsigned before taking
1233 the modulus.
1234
ajs5c333492005-02-23 15:43:01 +000012352005-02-23 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1236
1237 * ospfd.h: Add new field struct stream *ibuf to struct ospf.
1238 * ospfd.c: (ospf_new) Check return code from ospf_sock_init.
1239 Allocate ibuf using stream_new(OSPF_MAX_PACKET_SIZE+1).
1240 (ospf_finish) Call stream_free(ospf->ibuf.
1241 * ospf_packet.c: (ospf_read) Call stream_reset(ospf->ibuf) and then
1242 pass it to ospf_recv_packet for use in receiving the packet
1243 (instead of allocating a new stream for each packet received).
1244 Eliminate all calls to stream_free(ibuf).
1245 (ospf_recv_packet) The struct stream *ibuf is now passed in as
1246 an argument. No need to use recvfrom to peek at the packet
1247 header (to see how big it is), just use ospf->ibuf which is
1248 always large enough (this eliminates a system call to recvfrom).
1249 Therefore, no need to allocate a stream just for this packet,
1250 and no need to free it when done.
1251
hasso462f20d2005-02-23 11:29:02 +000012522005-02-23 Vincenzo Eramo <eramo at infocom.ing.uniroma1.it>
1253
1254 * ospf_lsa.h: New flag to the LSA structure for the SPF calculation.
1255 * ospf_lsdb.h: Export ospf_lsdb_clean_stat() function.
1256 * ospf_spf.h: Add link to the LSA stat structure into vertex.
1257 * ospf_spf.c: New functions cmp() and update_stat() to manage
1258 candidates. Remove ospf_spf_has_vertex(), ospf_vertex_lookup(),
1259 ospf_install_candidate() and ospf_spf_register() functions not needed
1260 any more. Update ospf_vertex_new(), ospf_spf_next() and
1261 ospf_spf_calculate() functions to use pqueue instead of linked list.
1262
hassoe40dcce2005-02-21 14:58:42 +000012632005-02-21 Hasso Tepper <hasso at quagga.net>
1264
1265 * ospf_ase.c: Don't show messages related to the ase calculations if
1266 we are not debugging.
1267
hasso306541b2005-02-19 17:58:40 +000012682005-02-19 Hasso Tepper <hasso at quagga.net>
1269
1270 * ospf_api.h: char isn't always signed, but it has to be it here.
1271
paulfa81b712005-02-19 01:19:20 +000012722005-02-19 Paul Jakma <paul.jakma@sun.com>
1273
1274 * ospf_packet.c: (ospf_stream_copy) remove
1275 (ospf_packet_dup) use stream_copy instead of ospf_stream_copy
1276
ajs038163f2005-02-17 19:55:59 +000012772005-02-17 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1278
1279 * ospf_packet.c: (ospf_recv_packet) If there is somehow a runt
1280 packet in the queue, it must be discarded. Improve warning messages.
1281 Fix scope to static.
1282 (ospf_read) Fix bug: should reset the read thread in all cases
1283 to make sure we continue to get incoming messages.
1284
paul658b03a2005-02-15 10:10:55 +000012852005-02-15 Paul Jakma <paul.jakma@sun.com>
1286
1287 * ospf_packet.c: (ospf_recv_packet) Fix silly error wrt allocating
1288 ibuf. Thanks Andrew.
1289
paulbfdc44a2005-02-14 23:48:42 +000012902005-02-14 Paul Jakma <paul.jakma@sun.com>
1291
1292 * ospf_packet.c: (ospf_recv_packet) use stream_recvmsg.
1293
hasso082253f2005-02-11 08:31:54 +000012942005-02-11 Hasso Tepper <hasso at quagga.net>
1295
1296 * ospf_lsdb.c: Fix sum of checksums calculation.
1297
ajs083ee9d2005-02-09 15:35:50 +000012982005-02-09 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1299
1300 * ospf_packet.c: (ospf_write) If sendmsg fails, give more info in the
1301 error message.
1302
ajsba6454e2005-02-08 15:37:30 +000013032005-02-08 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1304
ajs8cfde372005-02-08 15:59:16 +00001305 * ospf_interface.h: Reduce structure padding by putting new u_char
1306 field multicast_memberships in a better spot (grouped with
1307 other u_char fields type and state).
1308
13092005-02-08 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1310
ajsba6454e2005-02-08 15:37:30 +00001311 * ospf_interface.h: Improve passive_interface comment. Add new
1312 multicast_memberships bitmask to struct ospf_interface to track
1313 active multicast subscriptions. Declare new function
1314 ospf_if_set_multicast.
1315 * ospf_interface.c: (ospf_if_set_multicast) New function to configure
1316 multicast memberships properly based on the current
1317 multicast_memberships status and the current values of the
1318 ospf_interface state, type, and passive_interface status.
1319 (ospf_if_up) Remove call to ospf_if_add_allspfrouters (this is
1320 now handled by ism_change_state's call to ospf_if_set_multicast).
1321 (ospf_if_down) Remove call to ospf_if_drop_allspfrouters (now
1322 handled by ism_change_state).
1323 * ospf_ism.c: (ospf_dr_election) Remove logic to join or leave
1324 the DRouters multicast group (now handled by ism_change_state's call
1325 to ospf_if_set_multicast).
1326 (ism_change_state) Add call to ospf_if_set_multicast to change
1327 multicast memberships as necessary to reflect the new interface state.
1328 * ospf_packet.c: (ospf_hello) When a Hello packet is received on a
1329 passive interface: 1. Increase the severity of the error message
1330 from LOG_INFO to LOG_WARNING; 2. Add more information to the error
1331 message (packet destination address and interface address);
1332 and 3. If the packet was sent to ospf-all-routers, then try
1333 to fix the multicast group memberships.
1334 (ospf_read) When a packet is received on an interface whose state
1335 is ISM_Down, enhance the warning message to show the packet
1336 destination address, and try to update/fix the multicast group
1337 memberships if the packet was sent to a multicast address.
1338 When a packet is received for ospf-designated-routers, but the
1339 current interface state is not DR or BDR, then increase the
1340 severity level of the error message from LOG_INFO to LOG_WARNING,
1341 and try to fix the multicast group memberships.
1342 * ospf_vty.c: (ospf_passive_interface) Call ospf_if_set_multicast for
1343 any ospf interface that may have changed from active to passive.
1344 (no_ospf_passive_interface) Call ospf_if_set_multicast for
1345 any ospf interface that may have changed from passive to active.
1346 (show_ip_ospf_interface_sub) Show multicast group memberships.
1347
paul3a9eb092005-02-08 11:29:41 +000013482005-02-08 Paul Jakma <paul@dishone.st>
1349
1350 * ospf_packet.c: (various) Remove unneeded stream_set_putp abuse.
1351
ajs847947f2005-02-02 18:38:48 +000013522005-02-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1353
1354 * ospf_packet.c: (ospf_read) Fix bug: must check for state ISM_Down,
1355 not for event ISM_InterfaceDown. And improve the message by
1356 adding the interface flags.
1357
ajs0b7d97d2005-01-30 17:24:02 +000013582005-01-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1359
1360 * ospf_network.c: (ospf_sock_init) Save errno before calling
1361 ospfd_privs.change.
1362
ajsc3eab872005-01-29 15:52:07 +000013632005-01-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1364
1365 * ospf_packet.c: (ospf_packet_add) If oi->obuf is NULL, print
1366 an error message and return.
1367 (ospf_read) If the interface state is ISM_InterfaceDown, issue
1368 a warning message and ignore the packet.
1369
gdt86f1fd92005-01-10 14:20:43 +000013702005-01-10 Greg Troxel <gdt@fnord.ir.bbn.com>
1371
1372 * ospf_packet.h: Remove commented out definition of
1373 OSPF_MAX_PACKET; neither it or the uncommented one are used any more.
1374
1375 * ospf_packet.c (ospf_make_ls_upd): Leave room for authentication
1376 when deciding if an update will fit.
1377 (ospf_packet_authspace): Factor out calculation of size required
1378 for authentication.
1379 (ospf_make_db_desc): Use ospf_max_packet, not OSPF_MAX_PACKET.
1380 Don't confuse readers that there is a macro.
1381
ajs3dc56b52004-12-30 15:11:19 +000013822004-12-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1383
1384 * ospf_network.c: Improve all setsockopt error messages to give detailed
1385 information on the arguments.
1386
ajsb87f7722004-12-29 20:41:26 +000013872004-12-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1388
ajs17eaa722004-12-29 21:04:48 +00001389 * ospf_packet.c: (ospf_db_desc) Reduce severity of "Negotiation done"
1390 messages from LOG_WARNING to LOG_INFO, since this seems to be
1391 normal.
1392
13932004-12-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1394
ajsb87f7722004-12-29 20:41:26 +00001395 * ospf_packet.c: (ospf_read) Always look up the interface if
1396 ospf_recv_packet returns NULL ifp, since some platforms such
1397 as Solaris 8 appear to support ifindex retrieval but don't.
1398
hasso1d806282004-12-22 09:43:20 +000013992004-12-22 Hasso Tepper <hasso at quagga.net>
1400
1401 * ospf_dump.c: Show debug configuration in vtysh.
hassoc6b87812004-12-22 13:09:59 +00001402 * ospf_vty.c: Fix "show ip ospf" output. Router can't be elected in
1403 any case if it's configured as "translate-never".
hassofe71a972004-12-22 16:16:02 +00001404 * ospf_lsdb.[ch]: New function to calculate sum of checksums.
1405 * ospf_vty.c: Bugfix to show really number of AS external LSAs, not
1406 number of all LSAs with AS scope, this includes opaque as LSAs as
1407 well, show this number separately. Show numbers and sums of
1408 checksums for each type of LSAs.
1409 * ospf_lsa.c: Calculate checksum before putting LSA into database.
hasso1d806282004-12-22 09:43:20 +00001410
ajsbc18d612004-12-15 15:07:19 +000014112004-12-15 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1412
1413 * ospf_interface.h: Declare new function ospf_default_iftype.
1414 * ospf_interface.c: (ospf_default_iftype) New function to centralize
1415 this logic in one place.
1416 * ospf_zebra.c: (ospf_interface_add) Use new function
1417 ospf_default_iftype.
1418 * ospf_vty.c: (no_ip_ospf_network,config_write_interface) Fix logic
1419 by using new function ospf_default_iftype.
1420
ajs3aa8d5f2004-12-11 18:00:06 +000014212004-12-11 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1422
1423 * ospf_packet.c: (ospf_db_desc) Should be static, not global.
1424 (ospf_hello,ospf_db_desc,ospf_ls_upd,ospf_ls_ack) Improve warning
1425 messages to include identifying information (e.g. router id).
1426 * ospf_nsm.c: (nsm_change_state) Improve info message to include
1427 router id and state names.
1428
gdt91f3e522004-12-09 14:51:03 +000014292004-12-09 Greg Troxel <gdt@fnord.ir.bbn.com>
1430
gdt3fb9de72004-12-09 16:30:04 +00001431 * ospf_apiserver.c (ospf_apiserver_term): Obtain struct
1432 ospf_apiserver * from listnode. Remove unused variables. Follows
1433 suggestion from Jay Fenlason.
gdt91f3e522004-12-09 14:51:03 +00001434
ajs9b0e25c2004-12-08 19:06:51 +000014352004-12-08 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1436
1437 * *.c: Change level of debug messages to LOG_DEBUG.
1438
ajs274a4a42004-12-07 15:39:31 +000014392004-12-07 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1440
1441 * ospf_main.c: (main) The 2nd argument to openzlog has been removed.
1442
ajs887c44a2004-12-03 16:36:46 +000014432004-12-03 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1444
ajs1210fa62004-12-03 16:43:24 +00001445 * ospf_packet.c: (ospf_db_desc) Reduce priority on a debug message
1446 from LOG_NOTICE to LOG_DEBUG.
1447
14482004-12-03 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1449
ajs887c44a2004-12-03 16:36:46 +00001450 * ospf_main.c: (sigint) Use zlog_notice for termination message.
1451 (main) Issue a startup announcement using zlog_notice.
1452
ajsbec595a2004-11-30 22:38:43 +000014532004-11-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1454
1455 * ospf_packet.c: (ospf_db_desc_proc) Fix spelling of packet in warning
1456 message and in comment.
1457 (ospf_db_desc) Warning message that a packet is being discarded
1458 should give the router id of the packet source. Fix spelling
1459 of packet in two warning messages.
1460 (ospf_ls_req) Warning message that a link state request is being
1461 discarded should give the router id of the neighbor that sent it.
1462
ajs5b85fac2004-11-26 19:36:42 +000014632004-11-26 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1464
1465 * ospf_main.c: Remove #include "debug.h" (was not being used, and
1466 lib/debug.h has now been deleted).
1467
hassoc0652302004-11-25 19:33:48 +000014682004-11-25 Hasso Tepper <hasso at quagga.net>
1469
1470 * ospf_main.c: Make group to run as configurable.
1471
gdt69e13252004-11-15 18:51:15 +000014722004-11-15 Greg Troxel <gdt@fnord.ir.bbn.com>
1473
1474 * ospf_packet.c (ospf_recv_packet): Assume CMSG_SPACE is present
1475 and works (lib/zebra.h provides if OS doesn't).
1476
paul788dab12004-11-15 11:48:37 +000014772004-11-15 Paul Jakma <paul@dishone.st>
1478
1479 * ospf_{apiserver,te}.c: ospf_lsa_free's should be ospf_lsa_unlock.
1480
paul05e85fa2004-11-12 10:52:19 +000014812004-11-12 Paul Jakma <paul@dishone.st>
1482
1483 * ospf_ia.c: (process_summary_lsa) Only an ABR has any reason to
1484 ignore stub area summary default. Even so it seems a strange
1485 check, add a comment to that effect.
1486
paulf3ae74c2004-11-04 20:35:31 +000014872004-11-04 Paul Jakma <paul@dishone.st>
1488
1489 * ospfd.c: (ospf_network_match_iface) revert to previous network
1490 statement match behaviour.
1491
paul62d8e962004-11-02 20:26:45 +000014922004-11-02 Paul Jakma <paul@dishone.st>
1493
1494 * ospf_packet.c: (ospf_write_frags) remove iov arg, msg already points
1495 to it. Add convenience pointer to msg->msg_iov[1], and use this,
1496 fixing the unfortunate borkenness introduced in moving of this code
1497 to a function.
1498 (ospf_write) remove iovp and fix up call to previous.
1499 (ospf_ls_upd_packet_new) cast size to long int - unfortunately
1500 glibc's size_t format modifier is not portable.
1501
paul37ccfa32004-10-31 11:24:51 +000015022004-10-31 Paul Jakma <paul@dishone.st>
1503
1504 * ospf_packet.c: (ospf_write_frags) Add debug output
1505 (ospf_write) set type early, so we can pass it to
1506 ospf_write_frags.
1507 (ospf_ls_upd_packet_new) print size in debug output when too large
1508 packet is encountered.
paul64511f32004-10-31 18:01:13 +00001509 * ospf_zebra.c: (ospf_distribute_list_update_timer) Ugly misuse of
1510 THREAD_ARG to store an integer, but it should at least use same
1511 same type to retrieve the value. Assert value is sane.
paul37ccfa32004-10-31 11:24:51 +00001512
paulac191232004-10-22 12:05:17 +000015132004-10-22 Paul Jakma <paul@dishone.st>
1514
1515 * ospf_network.c: (ospf_sock_init) call neutral setsock_ifindex()
1516 function.
1517 * ospf_packet.c: (ospf_read) manually look up ifindex
paul4ccb2c42004-10-22 22:52:33 +00001518 if system could not have returned one, eg openbsd, thanks to Rivo
1519 Nurges for highlighting problem and fix.
paul06f953f2004-10-22 17:00:38 +00001520 Change setsockopt_pktinfo to setsockopt_ifindex.
paulac191232004-10-22 12:05:17 +00001521
hasso3fb9cd62004-10-19 19:44:43 +000015222004-10-19 Andrew J. Schorr <aschorr@telemetry-investments.com>
1523
1524 * ospf_snmp.c: (ospf_snmp_if_update) Fix logic to handle PtP links
1525 with dedicated subnets properly.
1526 * ospf_lsa.c: (lsa_link_ptop_set) ditto.
1527 * ospfd.c: (ospf_network_match_iface) ditto.
1528 (ospf_network_run) ditto.
1529 * ospf_interface.c: (ospf_if_is_configured) ditto.
1530 (ospf_if_lookup_by_prefix) ditto.
1531 (ospf_if_lookup_recv_if) ditto.
1532 * ospf_vty.c: (show_ip_ospf_interface_sub) Display the peer or
1533 broadcast address if present.
1534
hassod68614d2004-10-13 09:32:48 +000015352004-10-13 Hasso Tepper <hasso at quagga.net>
1536
1537 * ospf_main.c: Unbreak compilation with ospfapi disabled.
hassoc75105a2004-10-13 10:33:26 +00001538 * ospf_snmp.c: Remove defaults used to initialize smux connection to
1539 snmpd. Connection is initialized only if smux peer is configured.
hassod68614d2004-10-13 09:32:48 +00001540
hassof4d58ce2004-10-12 06:13:54 +000015412004-10-12 Hasso Tepper <hasso at quagga.net>
1542
1543 * ospf_main.c, ospf_opaque.c: Unbreak ospfclient compilation - move
1544 static variable from ospf_main.c into ospf_opaque.c.
1545
hassoc3abdb72004-10-11 16:27:03 +000015462004-10-11 Hasso Tepper <hasso at quagga.net>
1547
1548 * ospf_main.c, ospf_opaque.c: Disable ospfapi init by default. New
1549 command line switch to enable it.
1550
paul6b333612004-10-11 10:11:25 +000015512004-10-11 Paul Jakma <paul@dishone.st>
1552
1553 * ospf_dump.c: (ospf_ip_header_dump) Assume header is in host order
1554 remove ntohs that should have dissappeared. Take struct ip
1555 as argument, caller has to know there's an IP header at start of
1556 stream anyway.
1557 * ospf_dump.h: update declaration of ospf_ip_header_dump.
1558 * ospf_packet.c: (ospf_write) correct call to
1559 sockopt_iphdrincl_swab_htosys which was munging the header.
1560 (ospf_recv_packet) ip_len is needed for old OpenBSD fixup.
1561 (ospf_read) sockopt_iphdrincl_swab_systoh ip header as soon as
1562 we have it.
paul6c835672004-10-11 11:00:30 +00001563 * (global) Const char update and signed/unsigned fixes.
1564 * (various headers) size defines should be unsigned.
1565 * ospf_interface.h: remove duplicated defines, include the
1566 authoritative header - though, these defines should probably
1567 be moved to a dedicated header, or ospfd.h.
1568 * ospf_lsa.h: (struct lsa) ls_seqnum should be unsigned.
1569 * ospf_packet.c: (ospf_write) cast result of shift to unsigned.
paul6b333612004-10-11 10:11:25 +00001570
hassoeb1ce602004-10-08 08:17:22 +000015712004-10-08 Hasso Tepper <hasso at quagga.net>
1572
1573 * *.[c|h]: Fix compiler warnings: make some strings const, signed ->
1574 unsigned, remove unused variables etc.
1575
gdt54ade992004-10-07 19:38:20 +000015762004-10-07 Greg Troxel <gdt@claude.ir.bbn.com>
1577
1578 * ospf_apiserver.c (ospf_apiserver_unregister_opaque_type): Don't
1579 use of variable names 'node' and 'nextnode' to avoid possible
1580 conflict with list macros. Move variable declaration inside for
1581 loop after a statement to top of function.
1582
paulaa20c6f2004-10-07 14:19:36 +000015832004-10-07 Paul Jakma <paul@dishone.st>
1584
1585 * ospf_snmp.c: Missed list typedef update
1586 * ospf_dump.c: Include sockopt.h for header swab functions.
1587
paul18b12c32004-10-05 14:38:29 +000015882004-10-05 Paul Jakma <paul@dishone.st>
1589
1590 * ospf_packet.c: replace ospf_swap_iph_to... with
1591 sockopt_iphdrincl_swab_...
1592
hasso18a6dce2004-10-03 18:18:34 +000015932004-10-03 James R. Leu <jleu at mindspring.com>
1594
1595 * ospf_zebra.c: Read router id related messages from zebra daemon.
1596 Schedule router-id update thread if it's changed.
1597 * ospfd.c: Remove own router-id selection function. Use router id from
1598 zebra daemon if it isn't manually overriden in configuration.
1599
paul68defd62004-09-27 07:27:13 +000016002004-09-27 Paul Jakma <paul@dishone.st>
1601
paul6a99f832004-09-27 12:56:30 +00001602 * ospf_dump.c: (ospf_ip_header_dump) Use HAVE_IP_HDRINCL_BSD_ORDER
1603 Apply to offset too. Print ip_cksum, lets not worry about
1604 possible 2.0.37 compile problems.
1605 * ospf_packet.c: (ospf_swap_iph_to{n,h}) Use
1606 HAVE_IP_HDRINCL_BSD_ORDER.
1607 (ospf_recv_packet) ditto.
1608 (ospf_write) Fixup iov argument to ospf_write_frags.
1609 (struct msghdr).msg_name is caddr_t on most platforms.
paul68defd62004-09-27 07:27:13 +00001610 (ospf_recv_packet) ditto. And msg_flags is not always there
1611 memset struct then set fields we care about rather than
1612 initialise all fields individually.
1613
hassoc9e52be2004-09-26 16:09:34 +000016142004-09-26 Hasso Tepper <hasso at quagga.net>
1615
1616 * ospf_abr.c, ospf_dump.c, ospf_lsa.c, ospf_packet.c, ospf_vty.c,
1617 ospf_zebra.c: Fix compiler warnings.
1618
paul87d6f872004-09-24 08:01:38 +000016192004-09-24 Paul Jakma <paul@dishone.st>
1620
1621 * ospf_apiserver.{c,h}: lists typedef removal cleanup.
1622 update some list loops to LIST_LOOP. some miscellaneous indent
1623 fixups.
1624 (ospf_apiserver_unregister_opaque_type) fix listnode_delete of
1625 referenced node in loop.
paul1603c062004-09-24 08:23:24 +00001626 (ospf_apiserver_term) loops calling ospf_apiserver_free, which
1627 deletes referenced nodes from apiserver_list, fixed.
paul87d6f872004-09-24 08:01:38 +00001628 * ospf_interface.h: lists typedef removal cleanup.
1629 * ospf_opaque.{c,h}: lists typedef removal cleanup. update some list
1630 loops to LIST_LOOP. miscellaneous style and indent fixups.
1631 * ospf_te.{c,h}: ditto
1632 * ospf_packet.c: lists typedef removal cleanup.
paula2570682004-09-24 08:09:57 +00001633 (ospf_write) ifdef fragmentation support. move actual
1634 fragmentation out to a new, similarly ifdefed, function.
1635 (ospf_write_frags) fragmented write support, moved from previous.
paul87d6f872004-09-24 08:01:38 +00001636
hasso52dc7ee2004-09-23 19:18:23 +000016372004-09-23 Hasso Tepper <hasso at quagga.net>
1638
1639 * *.[c|h]: list -> struct list *, listnode -> struct listnode *.
1640
paul68b73392004-09-12 14:21:37 +000016412004-09-12 Paul Jakma <paul@dishone.st>
1642
1643 * ospf_packet.c: Fix bugzilla #107
1644 (ospf_packet_max) get rid of the magic 88 constant
1645 (ospf_swab_iph_ton) new function. set ip header to network order,
1646 taking BSDisms into account.
1647 (ospf_swab_iph_toh) the inverse.
1648 (ospf_write) Add support for IP fragmentation, will only work on
1649 linux though, other kernels make it impossible. get rid of the
1650 magic 4 constant.
1651 (ospf_make_ls_upd) Bound check to end of stream, not to
1652 interface mtu.
1653 (ospf_ls_upd_packet_new) New function, allocate upd packet
1654 taking oversized LSAs into account.
1655 (ospf_ls_upd_queue_send) use ospf_ls_upd_packet_new to allocate,
1656 rather than statically allocating mtu sized packet buffer, which
1657 actually was wrong - it didnt take ip header into account, which
1658 should not be included in packet buffer.
1659 (ospf_ls_upd_send_queue_event) minor tweaks and remove
1660 TODO comment.
1661
gdt630e4802004-08-31 17:28:41 +000016622004-08-31 David Wiggins <dwiggins@bbn.com>
1663
1664 * ospf_spf.c (ospf_spf_calculate): Many more comments and debug
1665 print statements. New function ospf_vertex_dump used in debugging.
1666
16672004-08-31 David Wiggins <dwiggins@bbn.com>
1668
1669 * ospf_spf.h (struct vertex): Comments for flags and structure members.
1670
16712004-08-31 David Wiggins <dwiggins@bbn.com>
1672
1673 * ospf_route.c: When finding an alternate route, log cost as well.
1674
16752004-08-31 David Wiggins <dwiggins@bbn.com>
1676
1677 * ospf_interface.c (ospf_lookup_if_params): Initialize af in
1678 struct prefix allocated on stack.
1679
16802004-08-31 David Wiggins <dwiggins@bbn.com>
1681
1682 * ospf_packet.c (ospf_ls_ack_send_delayed): In p2mp mode, send
1683 acks to AllSPFRouters, rather than All-DR.
1684
hasso7b901432004-08-31 13:37:42 +000016852004-08-27 Hasso Tepper <hasso at quagga.net>
1686
1687 * ospf_vty.c: Don't print ospf network type under interface only
1688 if interface is in broadcast mode and interface type really is
1689 broadcast. Fixes Bugzilla #108.
1690
gdtd7d93992004-08-27 12:03:42 +000016912004-08-27 David Wiggins <dwiggins@bbn.com>
1692
1693 * ospf_spf.c (ospf_nexthop_calculation): Initialize address family
1694 in on-stack struct prefix_ipv4. Fixes point-to-multipoint SPF
1695 calculation.
1696
gdtd0deca62004-08-26 13:14:07 +000016972004-08-26 Greg Troxel <gdt@fnord.ir.bbn.com>
1698
1699 * ospf_packet.c (ospf_recv_packet): adjust size declaration of
gdtd7d93992004-08-27 12:03:42 +00001700 buffer used to get interface index so that it compiles on other
1701 than Linux and includes the required alignment space. Probably
1702 this was only working on sparc/sparc64 because most of
1703 sockaddr_dl was not being written.
gdtd0deca62004-08-26 13:14:07 +00001704
paul863082d2004-08-19 04:43:43 +000017052004-08-19 Paul Jakma <paul@dishone.st>
1706
1707 * ospf_packet.c: update to match sockopt renames.
1708
paul75ee0b82004-08-05 09:10:31 +000017092004-08-04 Paul Jakma <paul@dishone.st>
1710
1711 * ospf_spf.c: (ospf_spf_consider_nexthop) Add comment about issue.
1712 Compare only against list head - all nexthops must be same cost
1713 anyway, fixes a reference-listnode-after-delete bug noted by
1714 Kir Kostuchenko.
1715 (ospf_nexthop_calculation) Use ospf_spf_consider_nexthop for all
1716 candidates attached to root.
1717
paul36c64ef2004-07-27 11:19:11 +000017182004-07-27 Paul Jakma <paul@dishone.st>
1719
paul48fe13b2004-07-27 17:40:44 +00001720 * ospf_packet.c: (ospf_ls_upd_send_queue_event) fix thinko from
1721 last fix for ospfd wedging due to oversize LSAs: dont list loop on
1722 ospf_ls_upd_queue_send() - guaranteed segfault.
1723
17242004-07-27 Paul Jakma <paul@dishone.st>
1725
paul36c64ef2004-07-27 11:19:11 +00001726 * ospf_opaque.c: (ospf_opaque_lsa_flush_schedule) do not NULL out
1727 the LSA as then free_opaque_info_per_id() can never unlock (and
1728 free) the LSA. Reported by Gunnar Stigen.
1729
paul2dd8bb42004-07-23 15:13:48 +000017302004-07-23 Paul Jakma <paul@dishone.st>
1731
1732 * ospf_network.c: Replace PKTINFO/RECVIF with call to
1733 setsockopt_pktinfo
1734 * ospf_packet.c: Use getsockopt_pktinfo_ifindex and
1735 SOPT_SIZE_CMSG_PKTINFO_IPV4.
1736
paul59ea14c2004-07-14 20:50:36 +000017372004-07-14 Paul Jakma <paul@dishone.st>
1738
1739 * ospf_packet.c: (ospf_ls_upd_send_queue_event) Partial fix for
1740 problem reported by Peter Frost amongst others, where function
1741 will spin indefinitely if update list contains LSAs greater than
1742 MTU-headers or other condition leading to update list never being
1743 cleared. Problem of what to do with these LSAs remains.
1744 (ospf_make_ls_upd) add comment about large LSA problem,
1745 indentation cleanup.
1746
gdtb2c1b282004-07-01 12:35:36 +000017472004-07-01 Greg Troxel <gdt@fnord.ir.bbn.com>
1748
1749 * Makefile.am (lib_LTLIBRARIES): make libospf shared
1750
gdt87efd642004-06-30 17:36:11 +000017512004-06-30 Greg Troxel <gdt@poblano.ir.bbn.com>
1752
1753 * Makefile.am: Add shlib support.
1754
hassobeebba72004-06-20 21:00:27 +000017552004-06-10 Hasso Tepper <hasso@estpak.ee>
1756
1757 * *: Removed ifdefs HAVE_NSSA.
1758
paul553ff112004-06-06 09:41:00 +000017592004-06-06 Paul Jakma <paul@dishone.st>
1760
1761 * ospf_dump.c,ospf_lsa.c: Fix typos of merge of previous.
1762 ospf_flood.c: (ospf_process_self_originated_lsa) fix zlog format
1763
paul0c2be262004-05-31 14:16:54 +000017642004-05-31 Sagun Shakya <sagun.shakya@sun.com>
1765
1766 * ospf_dump.c: (ospf_lsa_header_dump) LOOKUP can return null if
1767 index is out of range.
1768 ospf_flood.c: endianness fix
1769 ospf_lsa.c: Missing ntohl's on (struct lsa *)->data->ls_seqnum
1770 in various places.
1771
hassodd669bb2004-05-10 07:43:59 +000017722004-05-10 Hasso Tepper <hasso@estpak.ee>
1773
1774 * ospf_zebra.c, ospfd.c: Move ospf_prefix_list_update() function
1775 to ospf_zebra.c from ospfd.c and add redistribution updates if
1776 route-map is used in redistribution.
1777 * ospf_main.c: Remove now useless call to ospf_init().
1778
paul0a589352004-05-08 11:48:26 +000017792004-05-08 Paul Jakma <paul@dishone.st>
1780
1781 * ospf_zebra.c: Sync with lib/zclient changes
1782
pauld3f0d622004-05-05 15:27:15 +000017832004-05-05 Paul Jakma <paul@dishone.st>
1784
paul5bd41892004-05-05 17:29:24 +00001785 * ospf_network.c: (ospf_sock_init) Check whether IP_HDRINCL is
1786 defined. Warn at compile and runtime. Use
1787 IPTOS_PREC_INTERNETCONTROL otherwise.
pauld3f0d622004-05-05 15:27:15 +00001788 * ospf_packet.c: (ospf_associate_packet_vl) cleanup, move
1789 some of the checks up to ospf_read, return either a
1790 virtual link oi, or NULL.
1791 (ospf_read) Cleanup, make it responsible for checks. Remove
1792 the nbr lookup - moved to ospf_neighbor. Adjust all nbr
1793 lookups to use new wrappers exported by ospf_neighbor.
1794 * ospf_neighbor.h: Add ospf_neigbour_get and ospf_nbr_lookup.
1795 * ospf_neighbor.c: (ospf_neigbour_get) Index ospf_interface
1796 neighbour table by router-id for virtual-link ospf_interfaces,
1797 not by peer_addr (which breaks for asymmetric vlinks)
1798 (ospf_nbr_lookup) add a wrapper for nbr lookups to deal with
1799 above.
paulcd59da62004-05-05 17:26:55 +00001800 * ospf_interface.c: (ospf_vl_set_params) Catch changes of interface
1801 address for either end of a virtual-link, and hence potential cost
1802 changes.
1803
hassoa0a39762004-04-23 08:51:10 +000018042004-04-22 Hasso Tepper <hasso@estpak.ee>
1805
1806 * ospf_zebra.c: Don't ignore reject/bh routes, it's the only way
1807 to "summarize" routes in ASBR at the moment.
1808
hasso8585d4e2004-04-20 17:25:12 +000018092004-04-20 Hasso Tepper <hasso@estpak.ee>
1810
1811 * ospfd.c: Unset NP flag if area is going to be normal or stub.
1812 Fixes UNH OSPF_NSSA.1.2a comment.
1813 * ospf_abr.c: Originate default into stub/nssa area even if
1814 summaries are disabled.
1815 * ospf_zebra.c: Don't attempt to redistribute 127.0.0.0/8.
1816
hassoc266ac72004-04-19 17:31:00 +000018172004-04-19 Hasso Tepper <hasso@estpak.ee>
1818
1819 * ospf_vty.c: Don't warn that export- and import-list can't be
1820 configured to backbone area if they are applied and are working
1821 fine.
1822
hasso128d31d2004-04-04 12:52:33 +000018232004-02-19 Sowmini Varadhan <sowmini.varadhan@sun.com>
1824
1825 * ospf_packet.c: Don't drop packets in Solaris x86.
1826 [quagga-dev 1005].
1827
hasso0d85b992004-03-18 19:18:33 +000018282004-03-18 Amir Guindehi <amir@datacore.ch>
1829
1830 * ospf_opaque.c: Attempt to correct the incorrect behavior of
1831 Quagga's ospfd in the special situation that a node's opaque
1832 capability has changed as "ON -> OFF -> ON". [quagga-dev 843].
1833
paul7f352b82004-02-19 19:37:47 +000018342004-02-19 Sowmini Varadhan <sowmini.varadhan@sun.com>
1835
1836 * ospf_abr.c: (ospf_abr_update_aggregate) UNH 3.12b,c, address range
1837 should be configured with the highest cost path within the range,
1838 not lowest.
1839
paul940b01a2004-02-17 20:07:30 +000018402004-02-17 Paul Jakma <paul@dishone.st>
1841
1842 * ospf_zebra.c: (ospf_interface_delete) Do not delete the interface
1843 params, nor the interface structure, if an interface delete
1844 message is received from zebra.
1845 * ospf_interface.c: (ospf_if_delete_hook) Delete the interface
1846 params and interface, ie that which was previously removed in
1847 (ospf_interface_delete) above.
1848
hasso2db3d052004-02-11 21:52:13 +000018492004-02-11 Hasso Tepper <hasso@estpak.ee>
1850 * ospf_interface.c, ospf_zebra.c: Don't attempt to read path->oi->ifp
1851 if oi doesn't exist any more.
1852
hassocb05eb22004-02-11 21:10:19 +000018532004-02-11 Vadim Suraev <vadim.suraev@terayon.com>
1854 * ospf_packet.c (ospf_ls_upd): Router should flush received network
1855 LSA if it was originated with older router-id ([zebra 14710] #6).
1856
18572003-12-08 Mattias Amnefelt <mattiasa@kth.se>
paul239aecc2003-12-08 10:34:54 +00001858
1859 * ospf_packet.c: (ospf_recv_packet) OpenBSD now leaves iph.ip_len
1860 network byte order.
1861
gdt8f40e892003-12-05 14:01:43 +000018622003-12-05 Greg Troxel <gdt@poblano.ir.bbn.com>
1863
1864 * ospfd.c (ospf_network_match_iface): Rewrite code for clarity
1865 while trying not to change semantics. Add ifdefed-out code to
1866 avoid matching ppp interfaces whose destination address does not
1867 also match the prefix under consideration, to help out people with
1868 problems due to as-yet-unfixed bugs with p2p interfaces coming and
1869 going.
1870
paul736d3442003-07-24 23:22:57 +000018712003-07-25 kamatchi soundaram <kamatchi@tdd.sj.nec.com>
1872
1873 * ospf_packet.c (ospf_ls_upd_send_queue_event): get next route
1874 node in body of the loop to avoid chance that route node
1875 is unlocked and deleted before the next iteration tries to
1876 get next route node.
1877
paul0a825c72003-05-24 13:48:16 +000018782003-05-24 Kenji Yabuuchi
1879
1880 * ospf_interface.c(ospf_if_lookup_recv_if): Use the most specific
1881 match for interface lookup.
1882
paul551a8972003-05-18 15:22:55 +000018832003-05-18 Hasso Tepper <hasso@estpak.ee>
paul445f1432003-05-16 19:00:31 +00001884
paul551a8972003-05-18 15:22:55 +00001885 * ospf_vty.c: Show NSSA LSA route info in "show ip ospf database"
1886 output
paul445f1432003-05-16 19:00:31 +00001887
pauld7480322003-05-16 17:31:51 +000018882003-05-16 Hasso Tepper <hasso@estpak.ee>
1889
1890 * ospf_lsa.c: Fix handling of NSSA
1891
paul551a8972003-05-18 15:22:55 +000018922003-04-23 Hasso Tepper <hasso@estpak.ee>
1893
1894 * ospf_vty.c: fix "router xxx" node commands in vtysh
1895
paul445f1432003-05-16 19:00:31 +000018962003-04-19 Hasso Tepper <hasso@estpak.ee>
1897
1898 * {ospf_abr,ospfd}.c: area id's DECIMAL -> ADDRESS
1899 * ospf_routemap.c: sync daemon's route-map commands to have same
1900 syntax.
1901
19022003-04-19 Sergey Vyshnevetskiy <serg@vostok.net>
1903
1904 * ospf_packet.c: Add missing param to zlog
1905 * ospf_flood.c: remove unused vars
1906
19072003-04-17 Denis Ovsienko <zebra@pilot.org.ua>
1908
1909 * ospf_interface.c: fix incorrect memset
1910
paul28a13842003-05-16 20:30:37 +000019112003-04-10 Amir Guindehi <amir@datacore.ch>
paul445f1432003-05-16 19:00:31 +00001912
1913 * ospf_lsa.[ch]: opaque LSA fix, use ospf_lookup.
1914
19152003-04-03 David Watson <dwatson@eecs.umich.edu>
1916
1917 * ospf_lsa.c: byte order fix
1918
paul07661cb2003-03-18 00:03:05 +000019192002-03-17 Amir Guindehi <amir@datacore.ch>
1920
1921 * ospf_apiserver.[ch]: Merge Ralph Keller's OSPFAPI support.
1922 * ospf_api.[ch]: Merge Ralph Keller's OSPFAPI support.
1923 * ospfclient: OSPFAPI demonstration client.
1924
19252003-01-23 Masahiko Endo <endo@suri.co.jp>
1926
1927 * ospf_ism.c: NSM event schedule bug fix.
1928
19292002-10-30 Greg Troxel <gdt@ir.bbn.com>
1930
1931 * ospf_packet.c (ospf_make_md5_digest): MD5 length fix.
1932
paul718e3742002-12-13 20:15:29 +000019332002-10-23 endo@suri.co.jp (Masahiko Endo)
1934
1935 * ospf_opaque.c: Update Opaque LSA patch.
1936
19372002-10-23 Ralph Keller <keller@tik.ee.ethz.ch>
1938
1939 * ospf_vty.c (show_ip_ospf_database): Fix CLI parse.
1940
19412002-10-23 Juris Kalnins <juris@mt.lv>
1942
1943 * ospf_interface.c (ospf_if_stream_unset): When write queue
1944 becomes empty stop write timer.
1945
19462002-10-10 Greg Troxel <gdt@ir.bbn.com>
1947
1948 * ospf_packet.c (ospf_check_md5_digest): Change >= to > to make it
1949 conform to RFC.
1950
19512002-07-07 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1952
1953 * zebra-0.93 released.
1954
19552002-06-19 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1956
1957 * ospf_spf.c (ospf_nexthop_calculation): Add NULL set to oi and
1958 check of l2. Reported by: Daniel Drown <dan-zebra@drown.org>
1959 (ospf_lsa_has_link): LSA Length calculation fix. Reported by:
1960 Paul Jakma <paulj@alphyra.ie>.
1961
1962 * ospfd.c (ospf_if_update): Fix nextnode reference bug. Reported
1963 by: juris@mt.lv.
1964
19652002-01-21 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1966
1967 * ospfd.c: Merge [zebra 11445] Masahiko ENDO's Opaque-LSA support.
1968
19692001-08-27 Kunihiro Ishiguro <kunihiro@zebra.org>
1970
1971 * ospf_interface.c (ospf_add_to_if): Use /32 address to register
1972 OSPF interface information.
1973 (ospf_delete_from_if): Likewise.
1974
1975 * ospf_zebra.c (ospf_interface_address_delete): Likewise.
1976
19772001-08-23 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1978
1979 * ospf_zebra.c (ospf_redistribute_unset): When redistribute type
1980 is OSPF, do not unset redistribute flag.
1981
19822001-08-19 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1983
1984 * zebra-0.92a released.
1985
19862001-08-15 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1987
1988 * zebra-0.92 released.
1989
19902001-08-12 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1991
1992 * ospfd.c (ospf_config_write): auto-cost reference-bandwidth
1993 configuration display.
1994
19952001-07-24 David Watson <dwatson@eecs.umich.edu>
1996
1997 * ospf_spf.c (ospf_spf_next): Modify ospf_vertex_add_parent to
1998 check for an existing link before connecting the parent and child.
1999 ospf_nexthop_calculation is also modified to check for duplicate
2000 entries when copying from the parent. Finally, ospf_spf_next
2001 removes duplicates when it merges two equal cost candidates.
2002
20032001-07-23 itojun@iijlab.net
2004
2005 * ospfd.c (show_ip_ospf_neighbor): Check ospf_top before use it
2006 [zebra 8549].
2007
20082001-07-23 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
2009
2010 * ospf_packet.c (ospf_write): Remove defined(__OpenBSD__) to make
2011 it work on OpenBSD.
2012
20132001-06-26 Kunihiro Ishiguro <kunihiro@zebra.org>
2014
2015 * ospf_zebra.c (config_write_ospf_default_metric): Display
2016 default-metric configuration.
2017
20182001-06-18 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
2019
2020 * ospf_ia.h (OSPF_EXAMINE_SUMMARIES_ALL): Remove old macros.
2021
20222001-05-28 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
2023
2024 * ospf_snmp.c (ospfIfEntry): Fix interface lookup bug to avoid
2025 crush.
2026 (ospfIfMetricEntry): Likewise.
2027
20282001-03-18 Kunihiro Ishiguro <kunihiro@zebra.org>
2029
2030 * ospf_packet.c (ospf_read): Fix typo. Reported by: "Jen B
2031 Lin'Kova" <jen@stack.net>.
2032
20332001-03-15 Gleb Natapov <gleb@nbase.co.il>
2034
2035 * ospf_interface.c (ip_ospf_network): Set interface parameter.
2036 (interface_config_write): Add check for OSPF_IFTYPE_LOOPBACK.
2037
2038 * ospf_zebra.c (ospf_interface_add): Set interface parameter.
2039
20402001-02-21 Kunihiro Ishiguro <kunihiro@zebra.org>
2041
2042 * ospf_packet.c (ospf_recv_packet): Solaris also need to add
2043 (iph.ip_hl << 2) to iph.ip_len.
2044
20452001-02-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2046
2047 * ospfd.h (OSPF_LS_REFRESH_TIME): Fix OSPF_LS_REFRESH_TIME value.
2048 Suggested by: David Watson <dwatson@eecs.umich.edu>.
2049
2050 * ospf_zebra.c (zebra_init): Remove zebra node.
2051
2052 * ospfd.c (ospf_area_range_set): Function name is changed from
2053 ospf_ara_range_cmd.
2054 (ospf_area_range_unset): New function which separated from DEFUN.
2055 New commands are added:
2056 "no area A.B.C.D range A.B.C.D/M advertise"
2057 "no area <0-4294967295> range A.B.C.D/M advertise"
2058 "no area A.B.C.D range A.B.C.D/M not-advertise"
2059 "no area <0-4294967295> range A.B.C.D/M not-advertise"
2060
2061 * ospf_lsa.c (ospf_lsa_more_recent): Fix previous change.
2062
20632001-02-08 Matthew Grant <grantma@anathoth.gen.nz>
2064
2065 * ospf_network.c (ospf_if_add_allspfrouters): Use
2066 setsockopt_multicast_ipv4.
2067 (ospf_if_drop_allspfrouters): Likewise.
2068
2069 * ospf_lsa.c (ospf_router_lsa_install): Add rt_recalc flag.
2070 (ospf_network_lsa_install): Likewise.
2071 (ospf_summary_lsa_install): Likewise.
2072 (ospf_summary_asbr_lsa_install): Likewise.
2073 (ospf_external_lsa_install): Likewise.
2074 (ospf_lsa_install): Call ospf_lsa_different to check this LSA is
2075 new one or not.
2076
20772001-02-08 Kunihiro Ishiguro <kunihiro@zebra.org>
2078
2079 * ospf_zebra.c (ospf_interface_delete): Do not free interface
2080 structure when ospfd receive interface delete message to support
2081 pseudo interface.
2082
20832001-02-01 Dick Glasspool <dick@ipinfusion.com>
2084
2085 * ospfd.c (area_range_notadvertise): Change area range "suppress"
2086 command to "not-advertise".
2087
2088 * ospfd.h (OSPF_LS_REFRESH_TIME): Change OSPF_LS_REFRESH_TIME from
2089 1800 to 60.
2090
2091 * ospf_abr.c (ospf_abr_update_aggregate): When update_aggregate is
2092 updating the area-range, the lowest cost is now saved.
2093
2094 * ospf_lsa.c (ospf_lsa_more_recent): Routing to compare sequence
2095 numbers rather than creating overflow during calculation.
2096
20972001-02-01 Kunihiro Ishiguro <kunihiro@zebra.org>
2098
2099 * zebra-0.91 is released.
2100
21012001-01-31 Kunihiro Ishiguro <kunihiro@zebra.org>
2102
2103 * ospf_packet.c (ospf_db_desc_proc): Do not continue process when
2104 NSM_SeqNumberMismatch is scheduled.
2105 (ospf_ls_req): Free ls_upd when return from this function.
2106 (ospf_ls_upd_timer): When update list is empty do not call
2107 ospf_ls_upd_send(). Suggested by: endo@suri.co.jp (Masahiko
2108 Endo).
2109
21102001-01-26 Kunihiro Ishiguro <kunihiro@zebra.org>
2111
2112 * ospf_lsa.c (ospf_maxage_flood): Flood LSA when it reaches
2113 MaxAge. RFC2328 Section 14.
2114 (ospf_maxage_lsa_remover): Call above function during removing
2115 MaxAge LSA.
2116
21172001-01-26 Dick Glasspool <dick@ipinfusion.com>
2118
2119 * ospf_flood.c (ospf_flood_through_as): Function is updated for
2120 NSSA Translations now done at ospf_abr.c with no change in P-bit.
2121
2122 * ospf_lsa.c (ospf_get_nssa_ip): Get 1st IP connection for Forward
2123 Addr.
2124 (ospf_install_flood_nssa): Leave Type-7 LSA at Lock Count = 2.
2125
2126 * ospf_ase.c (ospf_ase_calculate_route): Add debug codes.
2127
2128 * ospf_abr.c (ospf_abr_translate_nssa): Recalculate LSA checksum.
2129
2130 * ospf_packet.h (OSPF_SEND_PACKET_LOOP): Added for test packet.
2131
2132 * ospf_dump.c (ospf_lsa_type_msg): Add OSPF_GROUP_MEMBER_LSA and
2133 OSPF_AS_NSSA_LSA.
2134
2135 * ospfd.c (data_injection): Function to inject LSA. This is
2136 debugging command.
2137
21382001-01-11 Kunihiro Ishiguro <kunihiro@zebra.org>
2139
2140 * ospf_route.c (ospf_route_match_same): Remove function.
2141 (ospf_route_match_same_new): Renamed to ospf_route_match_same.
2142
2143 * ospf_zebra.c (ospf_interface_address_delete): Add check for
2144 oi->address. Suggested by Matthew Grant
2145 <grantma@anathoth.gen.nz>.
2146 (ospf_zebra_add): Remove function.
2147 (ospf_zebra_add_multipath): Rename to ospf_zebra_add.
2148
2149 * ospf_interface.c: Remove HAVE_IF_PSEUDO part.
2150
2151 * ospf_zebra.c: Likewise.
2152
21532001-01-10 Kunihiro Ishiguro <kunihiro@zebra.org>
2154
2155 * ospf_ase.c: Remove OLD_RIB part.
2156
2157 * ospf_route.c: Likewise.
2158
2159 * zebra-0.90 is released.
2160
2161 * ospf_packet.c (ospf_recv_packet): Use ip_len adjestment code to
2162 NetBSD.
2163
21642001-01-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2165
2166 * ospf_route.c (ospf_route_delete): Use
2167 ospf_zebra_delete_multipath.
2168
21692001-01-09 Matthew Grant <grantma@anathoth.gen.nz>
2170
2171 * ospf_interface.c (ospf_if_cleanup): Function name is renamed
2172 from ospf_if_free(). Rewrite whole procudure to support primary
2173 address deletion.
2174
2175 * ospf_zebra.c (ospf_interface_address_delete): Add primary
2176 address deletion process.
2177
21782001-01-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2179
2180 * ospf_packet.c (ospf_recv_packet): OpenBSD has same ip_len
2181 treatment like FreeBSD.
2182
21832001-01-09 endo@suri.co.jp (Masahiko Endo)
2184
2185 * ospf_packet.c (ospf_recv_packet): FreeBSD kernel network code
2186 strips IP header size from receiving IP Packet. So we adjust
2187 ip_len to whole IP packet size by adding IP header size.
2188
21892001-01-08 endo@suri.co.jp (Masahiko Endo)
2190
2191 * ospf_network.c (ospf_serv_sock): When socket() is failed return
2192 immediately.
2193 (ospf_serv_sock): Close socket when it is not used.
2194
2195 * ospf_packet.c (ospf_write): Set sin_len when HAVE_SIN_LEN is
2196 defined.
2197 (ospf_write): When bind is fined, close sock.
2198
21992001-01-07 Gleb Natapov <gleb@nbase.co.il>
2200
2201 * ospf_zebra.c (ospf_interface_state_up): Fixes coredump that
2202 appears when you try to configure bandwidth on the ppp interface
2203 that is not yet configured in ospfd.
2204
22052001-01-07 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2206
2207 * ospf_route.c (show_ip_ospf_route_external): "show ip ospf route"
2208 will print nexthops for AS-external routes.
2209
2210 * ospf_ase.c (ospf_ase_route_match_same): New function to compare
2211 ASE route under multipath environment.
2212 (ospf_ase_compare_tables): Likewise.
2213
22142001-01-01 Kunihiro Ishiguro <kunihiro@zebra.org>
2215
2216 * ospfd.h (OSPF_VTYSH_PATH): Change "/tmp/ospfd" to "/tmp/.ospfd".
2217
22182000-12-28 Kunihiro Ishiguro <kunihiro@zebra.org>
2219
2220 * ospf_route.c (ospf_route_install): Install multipath information
2221 to zebra daemon.
2222
2223 * ospf_zebra.c (ospf_zebra_add_multipath): Function for passing
2224 multipath information to zebra daemon.
2225
22262000-12-25 Dick Glasspool <dick@ipinfusion.com>
2227
2228 * ospf_packet.c (ospf_write): Call ospf_packet_delete when sendto
2229 fail.
2230 (DISCARD_LSA): Add argument N for logging point of DISCARD_LSA is
2231 called.
2232
2233 * ospf_lsa.c (ospf_external_lsa_refresh): NSSA install_flood will
2234 leave Type-7 LSA at Lock Count = 2.
2235
2236 * ospf_flood.c (ospf_flood_through): Flood_though_as updated for
2237 NSSA no P-bit off during Area flooding, but P-bit is turned off
2238 for mulitple NSSA AS flooding.
2239
2240 * ospf_ase.c (ospf_ase_calculate_timer): Added calculations for
2241 Type-7 LSDB.
2242
2243 * ospf_abr.c (ospf_abr_translate_nssa): Removed one unlock call.
2244 (ospf_abr_announce_nssa_defaults): Corrected Debug from EVENT to
2245 NSSA.
2246
22472000-12-25 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2248
2249 * ospf_zebra.c (ospf_zebra_read_ipv4): Checking the age of the
2250 found LSA and if the LSA is MAXAGE we should call refresh instead
2251 of originate.
2252
22532000-12-18 Dick Glasspool <dick@ipinfusion.com>
2254
2255 * ospf_abr.c: Removed redundant "...flood" in
2256 announce_network_to_area(). Repaired nssa Unlock by using
2257 discard.
2258
2259 * ospf_packet.c: Removed old NSSA translate during mk_ls_update.
2260
2261 * ospfd.c: Free up all data bases including NSSA.
2262
2263 * ospf_lsa.c: Now allow removal of XLATE LSA's Check in
2264 discard_callback. Added routine to get ip addr from within the
2265 ifp.
2266
2267 * ospf_flood.c: Now set Forward Address for outgoing Type-7.
2268
2269 * ospf_lsa.h: Added prototype for the below. struct in_addr
2270 ospf_get_ip_from_ifp (struct interface *ifp).
2271
22722000-12-14 Gleb Natapov <gleb@nbase.co.il>
2273
2274 * ospf_packet.c (ospf_recv_packet): New OSPF pakcet read method.
2275 Now maximum packet length may be 65535 bytes (maximum IP packet
2276 length).
2277
2278 * ospf_interface.c (ospf_if_stream_set): Don't make input buffer.
2279
2280 * ospfd.c (config_write_network_area): Remove unnecessary area
2281 lookup code.
2282
22832000-12-13 Kunihiro Ishiguro <kunihiro@zebra.org>
2284
2285 * ospf_packet.c (ospf_read): Accept packet bigger than MTU value.
2286
22872000-12-13 Gleb Natapov <gleb@nbase.co.il>
2288
2289 * ospfd.c (config_write_network_area): Fix bug in
2290 config_write_network_area function.
2291
22922000-12-12 Gleb Natapov <gleb@nbase.co.il>
2293
2294 * ospf_abr.c (ospf_abr_announce_network_to_area): Make Summary
2295 LSA's origination and refreshment as same as other type of LSA.
2296
2297 * ospf_lsa.c (ospf_summary_lsa_refresh): Return struct ospf_lsa *.
2298
2299 * ospf_lsa.c (ospf_summary_asbr_lsa_refresh): Likewise.
2300
23012000-12-08 Dick Glasspool <dick@ipinfusion.com>
2302
2303 The bulk of NSSA changes are contained herein; This version will
2304 require manual setting of "always" for NSSA Translator, and will
2305 not perform aggregation yet.
2306
2307 * ospf_dump.c: "debug ospf nssa" is added.
2308
2309 * ospf_dump.h: Likewise.
2310
2311 * ospf_packet.c (ospf_hello): Display router ID on Bad NSSA Hello.
2312
2313 * ospfd.c: Discard_LSA to stay away from LOCAL_XLT Process NSSA
2314 'never, candidate, always'. Change "suppress" to "not-advertise".
2315
2316 * ospfd.h: Add TranslatorRole to struct ospf_area. Add anyNSSA to
2317 struct ospf.
2318
2319 * ospf_ase.c (ospf_ase_calculate_route): External to stay away
2320 from LOCAL_XLT
2321
2322 * ospf_nsm.c (ospf_db_summary_add): External to stay away from
2323 LOCAL_XLT
2324
2325 * ospf_abr.c: Major logic added for abr_nssa_task(). If ABR, and
2326 NSSA translator, then do it. Approve the global list, and flush
2327 any unapproved.
2328
2329 * ospf_lsa.h: New LSA flag OSPF_LSA_LOCAL_XLT to indicate that the
2330 Type-5 resulted from a Local Type-7 translation; not used for
2331 flooding, but used for flushing.
2332
2333 * ospf_flood.c: New NSSA flooding.
2334
23352000-12-08 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2336
2337 * ospfd.c (ospf_find_vl_data): New function for looking up virtual
2338 link data.
2339 (ospf_vl_set_security): Virtual link configuration with
2340 authentication.
2341 (ospf_vl_set_timers): Set timers for virtual link.
2342
2343 * New commands are added.
2344 "area A.B.C.D virtual-link A.B.C.D"
2345 "area A.B.C.D virtual-link A.B.C.D hello-interval <1-65535> retransmit-interval <3-65535> transmit-delay <1-65535> dead-interval <1-65535>"
2346 "area A.B.C.D virtual-link A.B.C.D hello-interval <1-65535> retransmit-interval <3-65535> transmit-delay <1-65535> dead-interval <1-65535> authentication-key AUTH_KEY"
2347 "area A.B.C.D virtual-link A.B.C.D authentication-key AUTH_KEY"
2348 "area A.B.C.D virtual-link A.B.C.D hello-interval <1-65535> retransmit-interval <3-65535> transmit-delay <1-65535> dead-interval <1-65535> message-digest-key <1-255> md5 KEY"
2349 "area A.B.C.D virtual-link A.B.C.D message-digest-key <1-255> md5 KEY"
2350
2351 * ospf_packet.c (ospf_check_md5_digest): Add neighbor's
2352 cryptographic sequence number treatment.
2353 (ospf_check_auth): OSPF input buffer is added to argument.
2354 (ospf_read): Save neighbor's cryptographic sequence number.
2355
2356 * ospf_nsm.c (nsm_change_status): Clear cryptographic sequence
2357 number when neighbor status is changed to NSM down.
2358
2359 * ospf_neighbor.c (ospf_nbr_new): Set zero to crypt_seqnum.
2360
2361 * ospf_neighbor.h (struct ospf_neighbor): Add cryptographic
2362 sequence number to neighbor structure.
2363
23642000-11-29 Kunihiro Ishiguro <kunihiro@zebra.org>
2365
2366 * ospf_snmp.c (ospfIfLookup): OSPF MIB updates.
2367 (ospfExtLsdbEntry): Add OspfExtLsdbTable treatment.
2368
23692000-11-28 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2370
2371 * ospfd.c (ospf_interface_down): Clear a ls_upd_queue queue of the
2372 interface.
2373 (ospf_ls_upd_queue_empty): New function to empty ls update queue
2374 of the OSPF interface.
2375 (no_router_ospf): 'no router ospf' unregister redistribution
2376 requests from zebra.
2377
23782000-11-28 Kunihiro Ishiguro <kunihiro@zebra.org>
2379
2380 * ospf_ism.c (ism_change_status): Increment status change number.
2381
2382 * ospf_interface.h (struct ospf_interface): Add new member for
2383 status change statistics.
2384
2385 * Makefile.am: Update dependencies.
2386
2387 * ospf_zebra.c (ospf_interface_add): OSPF SNMP interface update.
2388 (ospf_interface_delete): OSPF SNMP interface delete.
2389
2390 * ospf_snmp.h: New file is added.
2391
23922000-11-23 Dick Glasspool <dick@ipinfusion.com>
2393
2394 * ospfd.h: Add new ospf_area structure member for
2395 NSSATranslatorRole and NSSATranslator state.
2396
2397 * ospfd.c: Provided for eventual commands to specify NSSA
2398 elections for "translator- ALWAYS/NEVER/CANDIDATE". Provided for
2399 decimal integer version of area-suppress.
2400
2401 * ospf_flood.c: Flood Type-7's only into NSSA (not AS).
2402
2403 * ospf_lsa.c: Undo some previous changes for NSSA. If NSSA
2404 translator, advertise Nt bit.
2405
2406 * ospf_route.c: 1st version of "sh ip os border-routers".
2407
24082000-11-23 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2409
2410 * ospfd.c (area_vlink): Virtual link can not configured in stub
2411 area.
2412
24132000-11-23 Gleb Natapov <gleb@nbase.co.il>
2414
2415 * ospf_packet.c (ospf_db_desc): In states Loading and Full the
2416 slave must resend its last Database Description packet in response
2417 to duplicate Database Description packets received from the
2418 master. For this reason the slave must wait RouterDeadInterval
2419 seconds before freeing the last Database Description packet.
2420 Reception of a Database Description packet from the master after
2421 this interval will generate a SeqNumberMismatch neighbor
2422 event. RFC2328 Section 10.8
2423 (ospf_make_db_desc): DD Master flag treatment.
2424
2425 * ospf_nsm.c (nsm_twoway_received): Move DD related procedure to
2426 nsm_change_status().
2427 (nsm_bad_ls_req): Likewise.
2428 (nsm_adj_ok): Likewise.
2429 (nsm_seq_number_mismatch): Likewise.
2430 (nsm_oneway_received): Likewise.
2431
2432 * ospf_neighbor.h (struct ospf_neighbor): New structure member
2433 last_send_ts for timestemp when last Database Description packet
2434 was sent.
2435
2436 * ospf_nsm.c (ospf_db_desc_timer): Make it sure nbr->last_send is
2437 there. Call ospf_db_desc_resend() in any case.
2438
24392000-11-16 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2440
2441 * ospf_lsa.c (lsa_link_broadcast_set): When there is no DR on
2442 network (suppose you have only one router with interface priority
2443 0). It's router LSA does not contain the link information about
2444 this network.
2445
2446 * ospf_nsm.c (nsm_timer_set): When you change a priority of
2447 interface from/to 0 ISM_NeighborChange event should be scheduled
2448 in order to elect new DR/BDR on the network.
2449
2450 * ospf_interface.c (ip_ospf_priority): Likewise.
2451
2452 * ospf_flood.c (ospf_ls_retransmit_add): When we add some LSA into
2453 retransmit list we need to check whether the present old LSA in
2454 retransmit list is not more recent than the new
2455 one.
2456
24572000-11-09 Dick Glasspool <dick@ipinfusion.com>
2458
2459 * ospf_packet.c: Allows for NSSA Type-7 LSA's throughout the NSSA
2460 area. Any that exit the NSSA area are translated to type-5 LSA's.
2461 The instantiated image is restored after translation.
2462 (ospf_ls_upd_send_list): Renamed to ospf_ls_upd_queu_send().
2463 (ospf_ls_upd_send): Old function which enclosed by #ifdef 0 is
2464 removed.
2465 (ospf_ls_ack_send): Likewise.
2466
2467 * ospf_flood.c: NSSA-LSA's without P-bit will be restricted to
2468 local area. Otherwise they are allowed out the area to be
2469 translated by ospf_packet.c.
2470
2471 * ospf_lsa.c: Undo some previous changes for NSSA.
2472
2473 * ospf_lsdb.h: New access for type 7.
2474
24752000-11-07 Kunihiro Ishiguro <kunihiro@zebra.org>
2476
2477 * ospf_route.c (ospf_path_exist): New function to check nexthop
2478 and interface are in current OSPF path or not.
2479 (ospf_route_copy_nexthops_from_vertex): Add nexthop to OSPF path
2480 when it is not there. Reported by Michael Rozhavsky
2481 <mrozhavsky@opticalaccess.com>
2482
24832000-11-06 Kunihiro Ishiguro <kunihiro@zebra.org>
2484
2485 * ospf_dump.c (config_write_debug): Add seventh string "detail" is
2486 added for flag is OSPF_DEBUG_SEND | OSPF_DEBUG_RECV |
2487 OSPF_DEBUG_DETAIL.
2488
24892000-11-06 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2490
2491 * ospf_lsa.c (router_lsa_flags): ASBR can't exit in stub area.
2492
24932000-11-06 Kunihiro Ishiguro <kunihiro@zebra.org>
2494
2495 * ospf_lsa.c (ospf_router_lsa_originate): Reduce unconditional
2496 logging.
2497
24982000-11-06 Dick Glasspool <dick@ipinfusion.com>
2499
2500 * ospfd.h: Add ait_ntoa function prototype.
2501
2502 * ospfd.c (ait_ntoa): New function for displaying area ID and
2503 Stub/NSSA status.
2504 (show_ip_ospf_interface_sub): Use ait_ntoa.
2505 (show_ip_ospf_nbr_static_detail_sub): Likewise.
2506 (show_ip_ospf_neighbor_detail_sub): Likewise.
2507
2508 * ospf_route.c (ospf_intra_route_add): Set external routing type
2509 to ospf route.
2510 (ospf_intra_add_router): Likewise.
2511 (ospf_intra_add_transit): Likewise.
2512 (ospf_intra_add_stub): Likewise.
2513 (ospf_add_discard_route): Likewise.
2514 (show_ip_ospf_route_network): Use ait_ntoa.
2515 (show_ip_ospf_route_network): Likewise.
2516 (show_ip_ospf_route_router): Likewise.
2517
2518 * ospf_lsa.c (show_lsa_detail): Use ait_ntoa.
2519 (show_lsa_detail_adv_router): Likewise.
2520 (show_ip_ospf_database_summary): Likewise.
2521
2522 * ospf_route.h (struct route_standard): Add new member
2523 external_routing.
2524
2525 * ospf_ia.c (process_summary_lsa): Set external routing tyep to ospf
2526 route.
2527 (ospf_update_network_route): Likewise.
2528 (ospf_update_router_route): Likewise.
2529
25302000-11-04 Kunihiro Ishiguro <kunihiro@zebra.org>
2531
2532 * ospf_flood.c (ospf_process_self_originated_lsa): Enclose
2533 OSPF_AS_NSSA_LSA treatment with #ifdef HAVE_NSSA.
2534
25352000-11-03 Kunihiro Ishiguro <kunihiro@zebra.org>
2536
2537 * Unconditional logging is enclosed with if (IS_DEBUG_OSPF_EVENT).
2538 Please specify "debug ospf event" for enable logging.
2539
2540 * ospf_ism.c: Do not extern debug flag varible. It is done by
2541 ospf_debug.h
2542 * ospf_asbr.c: Likewise.
2543 * ospf_lsa.c: Likewise.
2544 * ospf_nsm.c: Likewise.
2545 * ospf_zebra.c: Likewise.
2546
2547 * ospf_dump.c (debug_ospf_event): New command "debug ospf event"
2548 is added.
2549
2550 * ospfd.c (router_ospf): Change logging from vty_out() to
2551 zlog_info().
2552 (ospf_area_stub_cmd): Likewise.
2553
2554 * ospf_dump.h: Extern term_debug flags.
2555 (OSPF_DEBUG_EVENT): Add new flag.
2556 (IS_DEBUG_OSPF_EVENT): Add new macro.
2557
25582000-11-03 Dick Glasspool <dick@ipinfusion.com>
2559
2560 * ospf_flood.c (ospf_process_self_originated_lsa):
2561 OSPF_AS_NSSA_LSA is treated as same as OSPF_AS_EXTERNAL_LSA.
2562 (ospf_flood): Type-5's have no change. Type-7's can be received,
2563 and will Flood the AS as Type-5's They will also flood the local
2564 NSSA Area as Type-7's. The LSDB will be updated as Type-5's, and
2565 during re-fresh will be converted back to Type-7's (if within an
2566 NSSA).
2567 (ospf_flood_through): Incoming Type-7's were allowed here if our
2568 neighbor was an NSSA. So Flood our area with the Type-7 and also
2569 if we are an ABR, flood thru AS as Type-5.
2570
2571 * ospf_lsa.c (ospf_external_lsa_refresh): Flood NSSA both NSSA
2572 area and other area.
2573
2574 * ospf_packet.c (ospf_db_desc_proc): When AS External LSA is
2575 exists in DD packet, make it sure that this area is not stub.
2576 (ospf_ls_upd_list_lsa): When LSA type is NSSA then set lsa's area
2577 to NULL.
2578 (ospf_ls_upd): If the LSA is AS External LSA and the area is stub
2579 then discard the lsa. If the LSA is NSSA LSA and the area is not
2580 NSSA then discard the lsa.
2581
25822000-11-03 Kunihiro Ishiguro <kunihiro@zebra.org>
2583
2584 * ospfd.c (ospf_interface_run): Fix bug of Hello packet's option
2585 is not properly set when interface comes up.
2586
25872000-11-02 Kunihiro Ishiguro <kunihiro@zebra.org>
2588
2589 * ospfd.h (OSPF_OPTION_O): Add new hello header option.
2590
25912000-11-01 Dick Glasspool <dick@ipinfusion.com>
2592
2593 * ospf_lsa.h: Define OSPF_MAX_LSA to 8 when HAVE_NSSA is enabled.
2594 (OSPF_GROUP_MEMBER_LSA): Define OSPF_GROUP_MEMBER_LSA.
2595
2596 * ospf_lsa.c (show_database_desc): Add "Group Membership LSA"
2597 string.
2598
25992000-10-31 Dick Glasspool <dick@ipinfusion.com>
2600
2601 * ospf_lsa.h (OSPF_AS_NSSA_LSA): Define OSPF_AS_NSSA_LSA.
2602
2603 * ospf_lsa.c (show_ip_ospf_database): NSSA database display
2604 function is added. ALIASES which have "show ip ospf database
2605 nssa-external" is added.
2606 (show_ip_ospf_border_routers): New command "show ip ospf
2607 border-routers" is added.
2608
26092000-10-30 Dick Glasspool <dick@ipinfusion.com>
2610
2611 * ospfd.c (router_ospf): NSSA Enabled message is added for
2612 testing.
2613 (ospf_area_type_set): Are type set for NSSA area.
2614 (ospf_area_stub_cmd): Special translation of no_summary into NSSA
2615 and summary information. If NSSA is enabled pass the information
2616 to ospf_area_type_set().
2617 (area_nssa): New commands are added:
2618 "area A.B.C.D nssa"
2619 "area <0-4294967295> nssa"
2620 "area A.B.C.D nssa no-summary"
2621 "area <0-4294967295> nssa no-summary"
2622 (ospf_no_area_stub_cmd): Special translation of no_summary into
2623 NSSA and summary information. If external_routing is
2624 OSPF_AREA_NSSA unset area with ospf_area_type_set (area,
2625 OSPF_AREA_DEFAULT).
2626 (show_ip_ospf_area): Display NSSA status.
2627 (config_write_ospf_area): Show NSSA configuration.
2628
2629 * ospf_packet.c (ospf_hello): For NSSA support, ensure that NP is
2630 on and E is off.
2631
26322000-10-26 Gleb Natapov <gleb@nbase.co.il>
2633
2634 * ospf_lsa.c (ospf_network_lsa_body_set): The network-LSA lists
2635 those routers that are fully adjacent to the Designated Router;
2636 each fully adjacent router is identified by its OSPF Router ID.
2637 The Designated Router includes itself in this list. RFC2328,
2638 Section 12.4.2.
2639
26402000-10-23 Jochen Friedrich <jochen@scram.de>
2641
2642 * ospf_snmp.c: ospf_oid and ospfd_oid are used in smux_open after
2643 it is registered. So those variables must be static.
2644
26452000-10-18 K N Sridhar <sridhar@euler.ece.iisc.ernet.in>
2646
2647 * ospfd.c: Add area_default_cost_decimal_cmd and
2648 no_area_default_cost_decimal_cmd alias.
2649
26502000-10-05 Gleb Natapov <gleb@nbase.co.il>
2651
2652 * ospfd.c (ospf_network_new): Fix setting area format.
2653 (no_router_ospf): Check area existance when calling
2654 ospf_interface_down().
2655
2656 * ospf_flood.c (ospf_external_info_check): Fix bug of refreshing
2657 default route.
2658
26592000-10-02 Kunihiro Ishiguro <kunihiro@zebra.org>
2660
2661 * zebra-0.89 is released.
2662
26632000-09-29 Kunihiro Ishiguro <kunihiro@zebra.org>
2664
2665 * ospf_snmp.c (ospfHostEntry): OSPF Host MIB is implemented.
2666
2667 * ospfd.c (ospf_nbr_static_cmp): OSPF neighbor is sorted by it's
2668 address.
2669
26702000-09-28 Michael Rozhavsky <mike@nbase.co.il>
2671
2672 * ospf_interface.c (ospf_if_free): Fix deleting self neighbor twice.
2673
26742000-09-27 Kunihiro Ishiguro <kunihiro@zebra.org>
2675
2676 * ospf_packet.c (ospf_read): Solaris on x86 has ip_len with host
2677 byte order.
2678
26792000-09-25 Toshiaki Takada <takada@zebra.org>
2680
2681 * ospfd.c (ospf_compatible_rfc1583), (no_ospf_compatible_rfc1583):
2682 Add CISCO compatible command.
2683
26842000-09-25 Kunihiro Ishiguro <kunihiro@zebra.org>
2685
2686 * ospf_abr.c (ospf_area_range_lookup): New function is added for
2687 area range lookup in OSPF-MIB.
2688 (ospf_area_range_lookup_next): Likewise.
2689
26902000-09-22 Kunihiro Ishiguro <kunihiro@zebra.org>
2691
2692 * ospfd.c (no_router_ospf): Delete virtual link before deleting
2693 area structure.
2694
2695 * ospf_lsa.c (ospf_external_lsa_refresh_type): Check
2696 EXTERNAL_INFO(type).
2697
2698 * ospfd.c (no_router_ospf): Call ospf_vl_delete() instead of
2699 ospf_vl_data_free().
2700
2701 * ospf_interface.c (ospf_vl_shutdown): Execute ISM_InterfaceDown
2702 when ospf_vl_shutdown is called.
2703 (ospf_vl_delete): Call ospf_vl_shutdown() to delete virtual link
2704 interface's thread.
2705
27062000-09-21 Gleb Natapov <gleb@nbase.co.il>
2707
2708 * ospf_lsa.c: New implementation of OSPF refresh.
2709
27102000-09-20 Kunihiro Ishiguro <kunihiro@zebra.org>
2711
2712 * ospf_snmp.c (ospfLsdbLookup): Add LSDB MIB implementation.
2713
27142000-09-18 Kunihiro Ishiguro <kunihiro@zebra.org>
2715
2716 * ospf_snmp.c (ospfStubAreaEntry): Add OSPF stub area MIB.
2717
27182000-09-18 Gleb Natapov <gleb@nbase.co.il>
2719
2720 * ospf_route.h (route_standard): Change member from `struct area'
2721 to area_id.
2722
2723 * ospf_abr.c (ospf_abr_announce_network), (ospf_abr_should_announce),
2724 (ospf_abr_process_network_rt), (ospf_abr_announce_rtr),
2725 (ospf_abr_process_router_rt):
2726 * ospf_ase.c (ospf_find_asbr_route),
2727 (ospf_find_asbr_router_through_area),
2728 * ospf_ia.c (ospf_find_abr_route), (ospf_ia_router_route),
2729 (process_summary_lsa), (ospf_update_network_route),
2730 (ospf_update_router_route):
2731 * ospf_route.c (ospf_intra_route_add), (ospf_intra_add_router),
2732 (ospf_intra_add_transit), (ospf_intra_add_stub),
2733 (ospf_route_table_dump), (show_ip_ospf_route_network),
2734 (show_ip_ospf_route_router), (ospf_asbr_route_cmp),
2735 (ospf_prune_unreachable_routers):
2736 * ospf_spf.c (ospf_rtrs_print):
2737 * ospfd.c (ospf_rtrs_free): Fix the struct change above.
2738
27392000-09-14 Kunihiro Ishiguro <kunihiro@zebra.org>
2740
2741 * ospf_network.c (ospf_serv_sock_init): Enclose SO_BINDTODEVICE
2742 with ifdef.
2743
27442000-09-13 Gleb Natapov <gleb@nbase.co.il>
2745
2746 * ospf_ism.c (ospf_elect_dr), (ospf_elect_bdr): Fix DR election.
2747
2748 * ospf_network.c (ospf_serv_sock_init): Add socket option
2749 SO_BINDTODEVICE on read socket.
2750
2751 * ospf_packet.c (ospf_hello): Ignore Hello packet if E-bit does
2752 not match.
2753
2754 * ospfd.c (ospf_area_check_free), (ospf_area_get),
2755 (ospf_area_add_if): New function added.
2756
27572000-09-13 Kunihiro Ishiguro <kunihiro@zebra.org>
2758
2759 * ospf_route.c (ospf_intra_add_router): Update ABR and ASBR router
2760 count.
2761
2762 * ospf_spf.c (ospf_spf_init): Rest ABR and ASBR router count
2763 starting SPF calculation.
2764
2765 * ospfd.h (struct ospf_area): Add ABR and ASBR router count.
2766
27672000-09-12 Kunihiro Ishiguro <kunihiro@zebra.org>
2768
2769 * ospfd.c (ospf_area_id_cmp): New area structure is sorted by area
2770 ID.
2771
2772 * ospf_lsa.c (ospf_router_lsa_originate): For OSPF MIB update
2773 lsa_originate_count.
2774 (ospf_network_lsa_originate): Likewise.
2775 (ospf_summary_lsa_originate): Likewise.
2776 (ospf_summary_asbr_lsa_originate): Likewise.
2777 (ospf_external_lsa_originate): Likewise.
2778
27792000-09-11 Kunihiro Ishiguro <kunihiro@zebra.org>
2780
2781 * ospf_snmp.c (ospf_variables): ospfRouterID's type RouterID
2782 syntax is IpAddress.
2783 (ospf_admin_stat): New function for OSPF administrative status
2784 check.
2785
27862000-09-10 Jochen Friedrich <jochen@scram.de>
2787
2788 * ospf_snmp.c: Implement OSPF MIB skeleton.
2789
27902000-09-08 Kunihiro Ishiguro <kunihiro@zebra.org>
2791
2792 * ospf_snmp.c: New file is added.
2793
27942000-09-07 David Lipovkov <davidl@nbase.co.il>
2795
2796 * ospf_zebra.c (ospf_interface_delete): Add pseudo interface
2797 treatment.
2798
2799 * ospf_interface.c (interface_config_write): Likewise.
2800
28012000-08-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2802
2803 * zebra-0.88 is released.
2804
28052000-08-17 Michael Rozhavsky <mike@nbase.co.il>
2806
2807 * ospfd.c (ospf_area_free): Remove virtual link configuration only
2808 when Area is removed.
2809
28102000-08-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2811
2812 * ospfd.c (network_area): Revert check for EXTERNAL_INFO
2813 (ZEBRA_ROUTE_CONNECT).
2814 (no_network_area): Likewise.
2815
28162000-08-16 Kunihiro Ishiguro <kunihiro@zebra.org>
2817
2818 * ospfd.h (struct ospf): Add distance_table and
2819 distance_{all,intra,inter,external}.
2820
2821 * ospf_zebra.c: Add OSPF distance related functions.
2822
28232000-08-15 Gleb Natapov <gleb@nbase.co.il>
2824
2825 * ospf_asbr.c (ospf_external_info_find_lsa): New function added.
2826
2827 * ospf_lsa.c (ospf_default_external_info),
2828 (ospf_default_originate_timer), (ospf_external_lsa_refresh_default):
2829 New function added.
2830
2831 * ospf_zebra.c
2832 (ospf_default_information_originate_metric_type_routemap),
2833 (ospf_default_information_originate_always_metric_type_routemap):
2834 Change name and add route-map function.
2835 (ospf_default_information_originate_metric_routemap),
2836 (ospf_default_information_originate_routemap),
2837 (ospf_default_information_originate_type_metric_routemap):
2838 New DEFUN added.
2839
28402000-08-14 Kunihiro Ishiguro <kunihiro@zebra.org>
2841
2842 * ospf_zebra.c (zebra_interface_if_set_value): Change ifindex
2843 restore size from two octet to four.
2844
28452000-08-14 Michael Rozhavsky <mike@nbase.co.il>
2846
2847 * ospf_ase.c (ospf_ase_incremental_update): Implement incremental
2848 AS-external-LSA in 16.6 of RFC2328.
2849
28502000-08-14 Matthew Grant <grantma@anathoth.gen.nz>
2851
2852 * ospf_interface.c (ospf_if_get_output_cost): Change cost
2853 calculation algorithm.
2854
2855 * ospf_packet (ospf_ls_upd): Fix problem of LSA retransmitting.
2856
28572000-08-11 Michael Rozhavsky <mike@nbase.co.il>
2858
2859 * ospf_lsa.c (ospf_maxage_lsa_remover): Fix maxage remover for
2860 AS-external-LSAs.
2861
28622000-08-10 Toshiaki Takada <takada@zebra.org>
2863
2864 * ospfd.c (auto_cost_reference_bandwidth): New DEFUN added.
2865 `auto-cost reference-bandwidth' OSPF router command added.
2866
28672000-08-08 Gleb Natapov <gleb@nbase.co.il>
2868
2869 * ospf_routemap.c (ospf_route_map_update): New function added.
2870 Add route-map event hook.
2871
28722000-08-08 Toshiaki Takada <takada@zebra.org>
2873
2874 * ospf_zebra.c (ospf_distribute_check_connected): If redistribute
2875 prefix is connected route on OSPF enabled interface, suppress to
2876 announce it.
2877
28782000-08-08 Matthew Grant <grantma@anathoth.gen.nz>
2879
2880 * ospf_interface.c (ospf_if_get_output_cost):
2881 New function added. Handle bandwidth parameter for cost
2882 calculation.
2883
28842000-08-08 Michael Rozhavsky <mike@nbase.co.il>
2885
2886 * ospf_interface.c (interface_config_write): Show interface
2887 configuration regardless interface is down.
2888
2889 * ospf_ase.c (ospf_ase_caocluate_route): Whole rewritten external
2890 route calculate function.
2891
28922000-08-08 Gleb Natapov <gleb@nbase.co.il>
2893
2894 * ospf_routemap.c: New file added.
2895
2896 * ospf_asbr.c (ospf_reset_route_map_set_values),
2897 (ospf_route_map_set_compare): New function added.
2898
2899 * ospf_lsa.c (ospf_external_lsa_body_set): Set routemap metric
2900 with AS-external-LSA.
2901
29022000-08-05 Kunihiro Ishiguro <kunihiro@zebra.org>
2903
2904 * ospf_ase.c (ospf_ase_calculate_route_add): Pass new->cost to
2905 ospf_zebra_add as metric.
2906 (ospf_ase_calculate_route_add): Likewise.
2907
2908 * ospf_route.c (ospf_route_install): Pass or->cost to
2909 ospf_zebra_add as metric.
2910
2911 * ospf_zebra.c (ospf_zebra_add): Add metric arguemnt.
2912 (ospf_zebra_delete): Likewise.
2913
29142000-08-03 Matthew Grant <grantma@anathoth.gen.nz>
2915
2916 * ospf_flood.c (ospf_flood_delayed_lsa_ack): New function added.
2917 Dispatch delayed-ACK with flooding AS-external-LSA across virtual
2918 link.
2919
29202000-07-31 Matthew Grant <grantma@anathoth.gen.nz>
2921
2922 * ospfd.c (show_ip_ospf_area): Fix lack of VTY_NEWLINE when
2923 `show ip ospf'.
2924
2925 * ospf_interface.c (ospf_if_free): Fix bug of crash with
2926 Point-to-Point interface.
2927
29282000-07-27 Michael Rozhavsky <mike@nbase.co.il>
2929
2930 * ospf_flood.c (ospf_process_self_originated_lsa):
2931 Make sure to clear LSA->param (redistributed external information)
2932 before refreshment.
2933
29342000-07-27 Gleb Natapov <gleb@nbase.co.il>
2935
2936 * ospfd.c (refresh_group_limit), (refresh_per_slice),
2937 (refresh_age_diff): New defun added. Refresher related parameter
2938 can be configurable.
2939
29402000-07-27 Akihiro Mizutani <mizutani@dml.com>
2941
2942 * ospf_interface.c (interface_config_write): Print `description'
2943 config directive to work.
2944
29452000-07-24 Akihiro Mizutani <mizutani@dml.com>
2946
2947 * ospf_interface.c (ospf_if_init): Use install_default for
2948 INTERFACE_NODE.
2949
29502000-07-24 Gleb Natapov <gleb@nbase.co.il>
2951
2952 * ospf_packet.c (ospf_ls_upd_send_list), (ospf_ls_upd_send_event),
2953 (ospf_ls_ack_send_list), (ospf_ls_ack_send_event): New function added.
2954 This make sending always as many LS update/Ack combined in one ospf
2955 packet.
2956
29572000-07-24 Gleb Natapov <gleb@nbase.co.il>
2958
2959 * ospf_packet.c (ospf_ls_upd_list_lsa): Set NULL to lsa->area if
2960 LSA is AS-external-LSA.
2961
2962 * ospf_nsm.c (nsm_reset_nbr): Do not cancel Inactivity timer.
2963
29642000-07-21 Toshiaki Takada <takada@zebra.org>
2965
2966 * ospf_zebra.c (ospf_default_originate_timer): Set timer for
2967 `default-information originate'. Fix some default originate
2968 related functions.
2969
29702000-07-12 Toshiaki Takada <takada@zebra.org>
2971
2972 * ospf_lsa.c (stream_put_ospf_metric): New function added.
2973
29742000-07-12 Toshiaki Takada <takada@zebra.org>
2975
2976 * ospf_lsa.c (show_ip_ospf_database_router),
2977 (show_ip_ospf_database_network), (show_ip_ospf_database_summary),
2978 (show_ip_ospf_database_summary_asbr), (show_ip_ospf_database_externel),
2979 (show_router_lsa), (show_any_lsa), (show_router_lsa_self),
2980 (show_any_lsa_self): Functions removed.
2981
2982 (show_lsa_prefix_set), (show_lsa_detail_proc), (show_lsa_detail),
2983 (show_lsa_detail_adv_router_proc), (show_lsa_detail_adv_router):
2984 New functions added. Replace above functions.
2985
2986 (show_ip_ospf_database_all), (show_ip_ospf_database_self_originated):
2987 Functions removed.
2988 (show_ip_ospf_database_summary): New functions added. Replace
2989 above functions.
2990
2991 (show_ip_ospf_database_cmd): DEFUN rearranged.
2992 (show_ip_ospf_database_type_id_cmd),
2993 (show_ip_ospf_database_type_id_adv_router_cmd),
2994 (show_ip_ospf_database_type_is_self_cmd): New ALIASes added.
2995 (show_ip_ospf_database_type_adv_rotuer_cmd): New DEFUN added.
2996 (show_ip_ospf_database_type_self_cmd): New ALIAS added.
2997
29982000-07-11 Toshiaki Takada <takada@zebra.org>
2999
3000 * ospf_asbr.c (ospf_external_info_new),
3001 (ospf_external_info_free): New functions added.
3002
3003 * ospf_lsa.h (ospf_lsa): Add new member `void *param' to set
3004 origination parameter for external-LSA.
3005 Remove member `redistribute'.
3006
3007 * ospf_zebra.c (ospf_redistirbute_set): When `redistribute'
3008 command executed, metric and metric-type values are overridden.
3009 If one of those is changed refresh AS-external-LSAs for appropriate
3010 type.
3011
30122000-07-11 Michael Rozhavsky <mike@nbase.co.il>
3013
3014 * ospf_lsa.c (ospf_summary_lsa_refresh),
3015 (ospf_summary_asbr_lsa_refresh): Make sure to refresh summary-LSAs.
3016
3017 * ospf_abr.c (set_metric): New function added.
3018
30192000-07-07 Toshiaki Takada <takada@zebra.org>
3020
3021 * ospf_zebra.c (ospf_default_information_originate_metric_type),
3022 (ospf_default_information_originate_type_metric): New defun added.
3023 Metic and Metric type can be set to default route.
3024 (ospf_default_information_originate_always_metric_type):
3025 (ospf_default_information_originate_always_type_metric):
3026 New defun added. Metric and Metric type can be set to default
3027 always route.
3028
3029 * ospf_zebra.c (ospf_default_metric), (no_ospf_default_metric):
3030 New defun added.
3031
30322000-07-06 Gleb Natapov <gleb@nbase.co.il>
3033
3034 * ospf_flood.c (ospf_flood_through_area): Fix bug of considering
3035 on the same interface the LSA was received from.
3036
30372000-07-06 Michael Rozhavsky <mike@nbase.co.il>
3038
3039 * ospfd.c (ospf_config_write): Fix bug of printing `area stub'
3040 command with `write mem'.
3041
3042 * ospfd.c (no_router_ospf): Remove installed routes from zebra.
3043
3044 * ospf_zebra.c (ospf_interface_delete): Fix function to handle
3045 zebra interface delete event.
3046
30472000-07-06 Toshiaki Takada <takada@zebra.org>
3048
3049 * ospf_zebra.c (ospf_default_information_originate),
3050 (ospf_default_information_originate_always): New DEFUN added.
3051
30522000-07-05 Michael Rozhavsky <mike@nbase.co.il>
3053
3054 * ospf_route.c (ospf_terminate): Make sure to remove external route
3055 when SIGINT received.
3056
30572000-07-03 Gleb Natapov <gleb@nbase.co.il>
3058
3059 * ospf_flood.c, ospf_ism.c, ospf_lsa,c, ospfd.c: Make sure to free
3060 many structure with `no router ospf'.
3061
30622000-06-30 Gleb Natapov <gleb@nbase.co.il>
3063
3064 * ospf_neighbor.c (ospf_nbr_new),
3065 ospf_nsm.c (nsm_timer_set): Start LS update timer only
3066 when neighbor enters Exchange state.
3067
30682000-06-29 Gleb Natapov <gleb@nbase.co.il>
3069
3070 * ospf_nsm.c (nsm_timer_set), (nsm_exchange_done),
3071 ospf_packet.c (ospf_db_desc_proc):
3072 Do not cancel DD retransmit timer when Master.
3073
30742000-06-29 Gleb Natapov <gleb@nbase.co.il>
3075
3076 * ospf_abr.c (ospf_abr_announce_network_to_area),
3077 (ospf_abr_announce_rtr_to_area)
3078 ospf_ase.c (ospf_ase_rtrs_register_lsa),
3079 ospf_flood.c (ospf_process_self_originated_lsa),
3080 (ospf_flood_through_area), (ospf_ls_request_delete),
3081 ospf_interface.c (ospf_if_free),
3082 ospf_ism.c (ism_change_status),
3083 ospf_lsa.c (ospf_router_lsa_update_timer),
3084 (ospf_router_lsa_install), (ospf_network_lsa_install),
3085 (ospf_lsa_maxage_delete), (ospf_lsa_action),
3086 (ospf_schedule_lsa_flood_area),
3087 ospf_nsm.c (nsm_change_status),
3088 ospf_packet.c (ospf_make_ls_req_func), (ospf_make_ls_ack):
3089 Use ospf_lsa_{lock,unlock} for all looking-up of LSA.
3090
3091 * ospf_flood.c (ospf_ls_request_free): Function deleted.
3092
3093 * ospf_lsa.c (ospf_discard_from_db): New function added.
3094
30952000-06-26 Toshiaki Takada <takada@zebra.org>
3096
3097 * ospfd.h (ospf): struct member `external_lsa' name changed to
3098 `lsdb'.
3099
31002000-06-26 Toshiaki Takada <takada@zebra.org>
3101
3102 * ospf_lsa.c (ospf_lsa_install), (ospf_router_lsa_install),
3103 (ospf_network_lsa_install), (ospf_summary_lsa_install),
3104 (ospf_summary_asbr_lsa_install), (ospf_external_lsa_install):
3105 Functions re-arranged.
3106
3107 * ospf_lsa.c (IS_LSA_MAXAGE), (IS_LSA_SELF): Macro added.
3108
31092000-06-20 Michael Rozhavsky <mike@nbase.co.il>
3110
3111 * ospf_packet.c (ospf_ls_req), (ospf_ls_upd), (ospf_ls_ack): Add
3112 verification of LS type.
3113
31142000-06-20 Gleb Natapov <gleb@nbase.co.il>
3115
3116 * ospf_ase.c (ospf_ase_calculate_timer): Add more sanity check
3117 whether rn->info is NULL.
3118
31192000-06-20 Toshiaki Takada <takada@zebra.org>
3120
3121 * ospfd.c (show_ip_ospf_interface_sub): Show Router-ID of both
3122 DR and Backup correctly with `show ip ospf interface' command.
3123
31242000-06-20 Toshiaki Takada <takada@zebra.org>
3125
3126 * ospf_lsa.c (ospf_lsa_lock), (ospf_lsa_unlock),
3127 (ospf_lsa_discard): These functions are used for avoiding
3128 unexpected reference to freed LSAs.
3129
31302000-06-13 Kunihiro Ishiguro <kunihiro@zebra.org>
3131
3132 * ospf_packet.c (ospf_ls_upd): Initialize lsa by NULL to avoid
3133 warning.
3134
31352000-06-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3136
3137 * ospf_ase.h (ospf_ase_rtrs_register_lsa): Add prototype.
3138
31392000-06-12 Toshiaki Takada <takada@zebra.org>
3140
3141 * ospf_lsa.c (ospf_external_lsa_install): Make sure to register
3142 LSA to rtrs_external when replacing AS-external-LSAs in LSDB.
3143 Fix core dump.
3144
31452000-06-10 Toshiaki Takada <takada@zebra.org>
3146
3147 * ospf_lsdb.c (id_to_prefix), (ospf_lsdb_hash_key),
3148 (ospf_lsdb_hash_cmp), (ospf_lsdb_new), (ospf_lsdb_iterator),
3149 (lsdb_free), (ospf_lsdb_free), (ospf_lsdb_add), (ospf_lsdb_delete),
3150 (find_lsa), (ospf_lsdb_lookup), (find_by_id),
3151 (ospf_lsdb_lookup_by_id), (ospf_lsdb_lookup_by_header): Functinos
3152 removed for migration to new_lsdb.
3153
3154 * ospf_lsa.c (ospf_summary_lsa_install),
3155 (ospf_summary_asbr_lsa_install), (ospf_maxage_lsa_remover),
3156 (ospf_lsa_maxage_walker), (ospf_lsa_lookup),
3157 (ospf_lsa_lookup_by_id): Use new_lsdb instead of ospf_lsdb.
3158 (count_lsa), (ospf_lsa_count_table), (ospf_lsa_count),
3159 (ospf_get_free_id_for_prefix): Funcitions removed.
3160
31612000-06-09 Gleb Natapov <gleb@nbase.co.il>
3162
3163 * ospf_ism.c (ism_interface_down): Prevent some unneeded DR changes.
3164
3165 * ospf_packet.c (ospf_db_desc_proc): Fix memory leak.
3166 (ospf_hello): Always copy router-ID when hello is received.
3167
31682000-06-08 Gleb Natapov <gleb@nbase.co.il>
3169
3170 * ospf_lsa.h (struct ospf_lsa): Add member of pointer to struct
3171 ospf_area.
3172
31732000-06-08 Michael Rozhavsky <mike@nbase.co.il>
3174
3175 * ospf_ase.c (ospf_asbr_route_same): New function added.
3176 This function makes sure external route calculation more
3177 precisely.
3178
31792000-06-07 Michael Rozhavsky <mike@nbase.co.il>
3180
3181 * ospf_ism.c (ism_change_status): Use ospf_lsa_flush_area for
3182 network-LSA deletion instead of using ospf_lsdb_delete.
3183 Also cancel network-LSA origination timer.
3184
31852000-06-07 Levi Harper <lharper@kennedytech.com>
3186
3187 * ospf_interface.c (ospf_if_down): Close read fd when an interface
3188 goes down.
3189
31902000-06-05 Kunihiro Ishiguro <kunihiro@zebra.org>
3191
3192 * ospf_asbr.c (ospf_external_info_lookup): Add explicit brace for
3193 avoid ambiguous else.
3194
3195 * ospf_flood.c (ospf_external_info_check): Likewise.
3196
31972000-06-05 Toshiaki Takada <takada@zebra.org>
3198
3199 * ospf_nsm.c (nsm_adj_ok): Fix bug of DR election.
3200
32012000-06-04 Toshiaki Takada <takada@zebra.org>
3202
3203 * ospf_zebra.c (ospf_default_information_originate),
3204 (no_ospf_default_information_originate): New DEFUN added.
3205
32062000-06-03 Toshiaki Takada <takada@zebra.org>
3207
3208 * ospf_lsa.h, ospf_asbr.h (external_info): Struct moved from
3209 ospf_lsa.h to ospf_asbr.h.
3210
3211 * ospf_lsa.c, ospf_asbr.c (ospf_external_info_add),
3212 (ospf_external_info_delete): Function moved from ospf_lsa.c
3213 to ospf_asbr.c.
3214
32152000-06-03 Toshiaki Takada <takada@zebra.org>
3216
3217 * ospf_flood.c (ospf_external_info_check): New function added.
3218 (ospf_process_self_orignated_lsa): Make sure to flush
3219 self-originated AS-external-LSA, when router reboot and no longer
3220 originate those AS-external-LSA.
3221
32222000-06-02 Toshiaki Takada <takada@zebra.org>
3223
3224 * ospf_network.c (ospf_serv_sock): Remove SO_DONTROUTE
3225 socket option.
3226
3227 * ospf_packet.c (ospf_write): Set MSG_DONTROUTE flag for
3228 unicast destination packets.
3229
32302000-06-02 Toshiaki Takada <takada@zebra.org>
3231
3232 * ospf_lsdb.c (new_lsdb_delete): Delete entry from LSDB only when
3233 specified LSA matches.
3234
32352000-06-02 Gleb Natapov <gleb@nbase.co.il>
3236
3237 * ospf_network.c (ospf_serv_sock): Set SO_DONTROUTE
3238 socket option.
3239
32402000-06-01 Akihiro Mizutani <mizutani@dml.com>
3241
3242 * ospf_dump.c: Replace string `Debugging functions\n' with DEBUG_STR.
3243 Replace string `OSPF information\n' with OSPF_STR.
3244
32452000-06-01 Toshiaki Takada <takada@zebra.org>
3246
3247 * ospf_lsdb.[ch]: Use new_lsdb struct for network-LSA instead of
3248 ospf_lsdb.
3249
32502000-06-01 Toshiaki Takada <takada@zebra.org>
3251
3252 * ospf_dump.c (config_debug_ospf_packet), (config_debug_ospf_event),
3253 (config_debug_ospf_ism), (config_debug_ospf_nsm),
3254 (config_debug_ospf_lsa), (config_debug_ospf_zebra),
3255 (term_debug_ospf_packet), (term_debug_ospf_event),
3256 (term_debug_ospf_ism), (term_debug_ospf_nsm),
3257 (term_debug_ospf_lsa), (term_debug_ospf_zebra): Repalce debug_ospf_*
3258 variable to use for debug option flags.
3259
3260 (debug_ospf_packet), (debug_ospf_ism), (debug_ospf_nsm),
3261 (debug_ospf_lsa), (debug_ospf_zebra): Set {config,term}_debug_*
3262 flags when vty->node is CONFIG_NODE, otherwise set only term_debug_*
3263 flags.
3264
3265 * ospf_dump.h (CONF_DEBUG_PACKET_ON), (CONF_DEBUG_PACKET_OFF),
3266 (TERM_DEBUG_PACKET_ON), (TERM_DEBUG_PACKET_OFF),
3267 (CONF_DEBUG_ON), (CONF_DEBUG_OFF), (IS_CONF_DEBUG_OSPF_PACKET),
3268 (IS_CONF_DEBUG_OSPF): New Macro added.
3269
32702000-05-31 Toshiaki Takada <takada@zebra.org>
3271
3272 * ospfd.c (clear_ip_ospf_neighbor): New DEFUN added.
3273 Currently this command is used for only debugging.
3274
3275 * ospf_nsm.c (nsm_change_status): Make sure thread cancellation
3276 for network-LSA when DR has no full neighbors.
3277
3278 * ospf_nsm.c (ospf_db_summary_clear): New function added.
3279
32802000-05-30 Toshiaki Takada <takada@zebra.org>
3281
3282 * ospf_lsdb.c (new_lsdb_insert): LSAs are always freed by
3283 maxage_lsa_remover when LSA is replaced.
3284
32852000-05-25 Gleb Natapov <gleb@nbase.co.il>
3286
3287 * ospf_flood.c (ospf_ls_retransmit_delete_nbr_all): Add argument
3288 `struct ospf_area' to remove LSA from Link State retransmission list
3289 of neighbor from only one Area.
3290
32912000-05-24 Michael Rozhavsky <mike@nbase.co.il>
3292
3293 * ospf_lsdb.c (ospf_lsdb_add): Preserve flags field when
3294 overriting old LSA with new LSA.
3295
32962000-05-24 Gleb Natapov <gleb@nbase.co.il>
3297
3298 * ospf_lsa.c (ospf_router_lsa_body_set): Fix bug of router-LSA
3299 size calculation.
3300
33012000-05-22 Michael Rozhavsky <mike@nbase.co.il>
3302
3303 * ospf_route.c (ospf_intra_add_stub):
3304 * ospf_spf.h (struct vertex): Use u_int32_t for distance (cost)
3305 value instead of u_int16_t.
3306
33072000-05-22 Axel Gerlach <agerlach@datus.datus.com>
3308
3309 * ospf_ia.c (ospf_ia_network_route): Fix bug of Inter-area route
3310 equal cost path calculation.
3311
33122000-05-21 Toshiaki Takada <takada@zebra.org>
3313
3314 * ospf_ase.c (ospf_ase_calculate_route_delete): New function added.
3315 Make sure, when rotuer route is deleted, related external routes
3316 are also deleted.
3317
33182000-05-20 Toshiaki Takada <takada@zebra.org>
3319
3320 * ospfd.c (ospf_interface_down): Make sure interface flag is disable
3321 and set fd to -1.
3322
33232000-05-16 Toshiaki Takada <takada@zebra.org>
3324
3325 * ospf_asbr.c (ospf_asbr_should_announce), (ospf_asbr_route_remove):
3326 Functions removed.
3327
3328 * ospfd.h (EXTERNAL_INFO): Macro added.
3329 Substitute `ospf_top->external_info[type]' with it.
3330
33312000-05-16 Toshiaki Takada <takada@zebra.org>
3332
3333 * ospf_lsa.c (ospf_rtrs_external_remove): New function added.
3334
33352000-05-14 Gleb Natapov <gleb@nbase.co.il>
3336
3337 * ospf_flood.c (ospf_ls_retransmit_delete_nbr_all)
3338 * ospf_lsdb.c (new_lsdb_insert)
3339 * ospf_packet.c (ospf_ls_ack): Fix database synchonization problem.
3340
33412000-05-14 Gleb Natapov <gleb@nbase.co.il>
3342
3343 * ospf_lsa.h (tv_adjust), (tv_ceil), (tv_floor), (int2tv),
3344 (tv_add), (tv_sub), (tv_cmp): Prototype definition added.
3345
3346 * ospf_nsm.h (ospf_db_summary_delete_all): Prototype definition added.
3347
33482000-05-13 Toshiaki Takada <takada@zebra.org>
3349
3350 * ospf_lsa.[ch] (ospf_lsa): struct timestamp type is changed from
3351 time_t to struct timeval.
3352 (tv_adjust), (tv_ceil), (tv_floor), (int2tv), (tv_add),
3353 (tv_sub), (tv_cmp): timeval utillity functions added.
3354
33552000-05-12 Toshiaki Takada <takada@zebra.org>
3356
3357 * ospf_lsa.[ch] (ospf_schedule_update_router_lsas): Delete function.
3358 Change to use macro OSPF_LSA_UPDATE_TIMER instead of using
3359 this function.
3360 router-LSA refresh timer related stuff is re-organized.
3361
33622000-05-10 Gleb Natapov <gleb@nbase.co.il>
3363
3364 * ospf_interface.c (ospf_vl_set_params):
3365 * ospf_packet.c (ospf_check_network_mask):
3366 * ospf_spf.[ch] (ospf_spf_next):
3367 Remove field address from `struct vertex', and search for peer
3368 address of virtual link in function `ospf_vl_set_params' instead.
3369
33702000-05-10 Gleb Natapov <gleb@nbase.co.il>
3371
3372 * ospf_packet.c (ospf_ls_upd): Fix some memory leak related LSA.
3373
33742000-05-08 Thomas Molkenbur <tmo@datus.com>
3375
3376 * ospf_packet.c (ospf_packet_dup): Replace ospf_steram_copy()
3377 with ospf_stream_dup() to fix memory leak.
3378
33792000-05-08 Michael Rozhavsky <mike@nbase.co.il>
3380
3381 * ospf_flood.c (ospf_flood_through_area): Fix the problem of
3382 LSA update without DROther.
3383
33842000-05-04 Gleb Natapov <gleb@nbase.co.il>
3385
3386 * ospf_spf.c (ospf_vertex_free): Fix memory leak of SPF calculation.
3387
33882000-05-03 Toshiaki Takada <takada@zebra.org>
3389
3390 * ospf_neighbor.c (ospf_db_summary_add): Use new_lsdb struct
3391 instead linked-list.
3392 (ospf_db_summary_count), (ospf_db_summary_isempty):
3393 New function added.
3394
3395 * ospf_lsa.c (ospf_rotuer_lsa): Re-arrange and divide functions.
3396
33972000-05-02 Gleb Natapov <gleb@nbase.co.il>
3398
3399 * ospf_lsdb.c (new_lsdb_cleanup): Fix memory leak. When LSDB are
3400 not needed any more, then free them.
3401
34022000-05-02 Toshiaki Takada <takada@zebra.org>
3403
3404 * ospfd.c (timers_spf), (no_timers_spf): New defun added.
3405 SPF calculation timers related stuff is rearranged.
3406
3407 * ospf_spf.c (ospf_spf_calculate_timer_add): Function removed.
3408 SPF timer is scheduled by SPF calculation delay and holdtime
3409 configuration variable.
3410
3411 * ospf_lsa.c (ospf_external_lsa_nexthop_get): Set AS-external-LSA's
3412 forwarding address when nexthop learned by other protocols is
3413 in the OSPF domain.
3414
3415 * ospf_zebra.c (ospf_redistribute_source_metric_type),
3416 (ospf_redistribute_source_type_metric): Re-arrange DEFUNs and
3417 ALIASes.
3418
34192000-05-01 Toshiaki Takada <takada@zebra.org>
3420
3421 * ospf_flood.c (ospf_ls_retransmit_count),
3422 (ospf_ls_retransmit_isempty): New function added.
3423
3424 (ospf_ls_retransmit_add), (ospf_ls_retransmit_delete),
3425 (ospf_ls_retransmit_clear), (ospf_ls_retransmit_lookup),
3426 (ospf_ls_retransmit_delete_all), (ospf_ls_retransmit_delete_nbr_all),
3427 (ospf_ls_retransmit_add_nbr_all): Replace these functions to use
3428 new_lsdb.
3429
34302000-04-29 Toshiaki Takada <takada@zebra.org>
3431
3432 * ospfd.c (no_network_area): Add check Area-ID whether specified
3433 Area-ID with prefix matches config.
3434
34352000-04-27 Toshiaki Takada <takada@zebra.org>
3436
3437 * ospf_lsa.c (ospf_maxage_lsa_remover): Fix problem of
3438 remaining withdrawn routes on zebra.
3439
34402000-04-25 Michael Rozhavsky <mike@nbase.co.il>
3441
3442 * ospf_nsm.c (nsm_kill_nbr), (nsm_ll_down), (nsm_change_status),
3443 (ospf_nsm_event): Fix network-LSA re-origination problem.
3444
34452000-04-24 Toshiaki Takada <takada@zebra.org>
3446
3447 * ospf_nsm.c (ospf_db_desc_timer): Fix bug of segmentation fault
3448 with DD retransmission.
3449
3450 * ospf_nsm.c (nsm_kill_nbr): Fix bug of re-origination when
3451 a neighbor disappears.
3452
34532000-04-23 Michael Rozhavsky <mike@nbase.co.il>
3454
3455 * ospf_abr.c (ospf_abr_announce_network_to_area): Fix bug of
3456 summary-LSAs reorigination. Correctly copy OSPF_LSA_APPROVED
3457 flag to new LSA. when summary-LSA is reoriginatd.
3458
3459 * ospf_flood.c (ospf_flood_through_area): Fix bug of flooding
3460 procedure. Change the condition of interface selection.
3461
34622000-04-21 Toshiaki Takada <takada@zebra.org>
3463
3464 * ospf_lsa.c (ospf_refresher_register_lsa): Fix bug of refresh never
3465 occurs.
3466
3467 * ospfd.c (show_ip_ospf_neighbor_id): New defun added.
3468 `show ip ospf neighbor' related commands are re-arranged.
3469
34702000-04-20 Toshiaki Takada <takada@zebra.org>
3471
3472 * ospf_dump.c (debug_ospf_zebra): New defun added.
3473 Suppress zebra related debug information.
3474
34752000-04-19 Toshiaki Takada <takada@zebra.org>
3476
3477 * ospf_zebra.c (ospf_distribute_list_update_timer),
3478 (ospf_distribute_list_update), (ospf_filter_update):
3479 New function added. Re-organize `distribute-list' router ospf
3480 command.
3481
34822000-04-13 Michael Rozhavsky <mike@nbase.co.il>
3483
3484 * ospf_packet.c (ospf_make_ls_upd): Add check for MAX_AGE.
3485
34862000-04-14 Michael Rozhavsky <mike@nbase.co.il>
3487
3488 * ospf_packet.c (ospf_make_ls_upd): Increment LS age by configured
3489 interface transmit_delay.
3490
34912000-04-14 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3492
3493 * ospf_interface.c (ip_ospf_cost), (no_ip_ospf_cost):
3494 Add to schedule router_lsa origination when the interface cost changes.
3495
34962000-04-12 Toshiaki Takada <takada@zebra.org>
3497
3498 * ospf_lsa.c (ospf_refresher_register_lsa),
3499 (ospf_refresher_unregister_lsa): Fix bug of core dumped.
3500
3501 * ospfd.c (no_router_ospf): Fix bug of core dumped.
3502
35032000-03-29 Toshiaki Takada <takada@zebra.org>
3504
3505 * ospf_nsm.c (nsm_oneway_received): Fix bug of MS flag unset.
3506
35072000-03-29 Michael Rozhavsky <mike@nbase.co.il>
3508
3509 * ospf_lsa.c (ospf_network_lsa):
3510 * ospf_nsm.c (ospf_nsm_event): Fix bug of Network-LSA originated
3511 in stub network.
3512
35132000-03-28 Toshiaki Takada <takada@zebra.org>
3514
3515 * ospf_nsm.c (nsm_bad_ls_req), (nsm_seq_number_mismatch),
3516 (nsm_oneway_received): Fix bug of NSM state flapping between
3517 ExStart and Exchange.
3518
35192000-03-28 Toshiaki Takada <takada@zebra.org>
3520
3521 * ospf_packet.h (strcut ospf_header): Fix the size of ospf_header,
3522 change u_int8_t to u_char.
3523
35242000-03-27 Toshiaki Takada <takada@zebra.org>
3525
3526 * ospf_lsa.c (ospf_lsa_checksum): Take care of BIGENDIAN architecture.
3527
35282000-03-27 Toshiaki Takada <takada@zebra.org>
3529
3530 * ospfd.c (ospf_interface_run): Make sure Address family matches.
3531
35322000-03-26 Love <lha@s3.kth.se>
3533
3534 * ospf_packet.c (ospf_write): Chack result of sendto().
3535
35362000-03-26 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3537
3538 * ospf_nsm.c (nsm_oneway_received): Fix bug of 1-WayReceived in NSM.
3539
35402000-03-23 Libor Pechacek <farco@clnet.cz>
3541
3542 * ospf_lsa.c (ospf_network_lsa)
3543 * ospf_lsdb.c (new_lsdb_insert): Fix bug of accessing to
3544 unallocated memory.
3545
35462000-03-23 Toshiaki Takada <takada@zebra.org>
3547
3548 * ospfd.c (ospf_config_write): Fix bug of duplicate line for
3549 `area A.B.C.D authentication'.
3550
35512000-03-22 Toshiaki Takada <takada@zebra.org>
3552
3553 * ospf_debug.c (debug_ospf_lsa), (no_debug_ospf_lsa): Defun added.
3554 Suppress all zlog related to LSAs with this config option.
3555
35562000-03-21 Kunihiro Ishiguro <kunihiro@zebra.org>
3557
3558 * ospf_nsm.c (ospf_nsm_event): Add check for NSM_InactivityTimer.
3559
35602000-03-21 Toshiaki Takada <takada@zebra.org>
3561
3562 * ospf_packet.c (ospf_ls_upd_timer), (ospf_ls_req):
3563 Fix bug of memory leak about linklist.
3564
3565 * ospf_flood.c (ospf_flood_through_area): Likewise.
3566
35672000-03-18 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3568
3569 * ospf_flood.c (ospf_ls_retransmit_lookup): Add checksum comparison
3570 to identify LSA uniquely. This fix routes lost.
3571
35722000-03-18 Toshiaki Takada <takada@zebra.org>
3573
3574 * ospf_ase.c (ospf_find_asbr_route): Add sanity check with router
3575 routing table.
3576
35772000-03-17 Alex Zinin <zinin@amt.ru>
3578
3579 * ospf_spf.[ch]: Bug fix.
3580 The 2nd stage of Dijkstra could consider one vertex
3581 more than once if there is more than one link
3582 between the routers, thus adding extra CPU overhead
3583 and extra next-hops.
3584 Fixed.
3585
35862000-03-15 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3587
3588 * ospf_nsm.c (nsm_inactivity_timer): Changed to call nsm_kill_nbr().
3589
35902000-03-14 Toshiaki Takada <takada@zebra.org>
3591
3592 * ospf_route.c (ospf_route_copy_nexthops): Fix bug of memory leak of
3593 ospf_path. Actually ignore merging ospf_route with completely same
3594 paths.
3595
35962000-03-12 Toshiaki Takada <takada@zebra.org>
3597
3598 * ospf_lsa.c (show_as_external_lsa_detail): fix bug of
3599 external route tag byte order.
3600
36012000-03-11 Toshiaki Takada <takada@zebra.org>
3602
3603 * ospf_lsdb.c (ospf_lsdb_insert): New function added.
3604
36052000-03-09 Toshiaki Takada <takada@zebra.org>
3606
3607 * ospf_lsa.c (ospf_external_lsa_install),
3608 (ospf_lsa_lookup), (show_ip_ospf_database_all),
3609 (show_ip_ospf_database_self_originate): Use struct new_lsdb for
3610 LSDB of AS-external-LSAs instead of ospf_lsdb.
3611
3612 * ospf_lsa.c (ospf_lsa_unique_id): New function added.
3613 Use for assigning Unique Link State ID instead of
3614 ospf_get_free_id_for_prefix().
3615
36162000-03-09 Toshiaki Takada <takada@zebra.org>
3617
3618 * ospf_ase.c (ospf_ase_calculate_timer): Fix bug of segmentation
3619 fault reported by George Bonser <george@siteROCK.com>.
3620
36212000-03-07 Libor Pechacek <farco@clnet.cz>
3622
3623 * ospfd.c (ospf_interface_down): Fix bug of segmentation fault.
3624
36252000-03-06 Toshiaki Takada <takada@zebra.org>
3626
3627 * ospf_route.c (ospf_route_cmp): Change meaning of return values.
3628
36292000-03-02 Alex Zinin <zinin@amt.ru>
3630 * ospfd.h, ospf_ia.h
3631 New Shortcut ABR code. Now area's flag can be configured
3632 with Default, Enable, and Disable values.
3633 More info will be in the new ver of I-D soon (see IETF web).
3634
36352000-02-25 Toshiaki Takada <takada@zebra.org>
3636
3637 * ospf_lsa.c (ospf_lsa_header_set), (ospf_external_lsa_body_set),
3638 (osfp_external_lsa_originate), (ospf_external_lsa_queue),
3639 (ospf_external_lsa_originate_from_queue): New function added.
3640 (ospf_external_lsa): Function removed.
3641
3642 * ospf_zebra.c (ospf_zebra_read_ipv4): Originate AS-external-LSA
3643 when listen a route from Zebra, instead creating external route.
3644
3645 * ospf_asbr.c (ospf_asbr_route_add_flood_lsa),
3646 (ospf_asbr_route_add_queue_lsa),
3647 (ospf_asbr_route_install_lsa), (ospf_asbr_route_add):
3648 Functions removed.
3649
3650 * ospf_ase.c (process_ase_lsa): Function will not be used.
3651 (ospf_ase_calculate), (ospf_ase_calculate_route_add),
3652 (ospf_ase_calculate_new_route), (ospf_ase_caluculate_asbr_route):
3653 process_ase_lsa () is separated to these functions.
3654
3655 OSPF AS-external-LSA origination is whole re-organized.
3656
36572000-02-18 Toshiaki Takada <takada@zebra.org>
3658
3659 * ospf_packet.c (ospf_ls_upd): Fix bug of OSPF LSA memory leak.
3660
3661 * ospf_asbr.c (ospf_asbr_route_add_flood_lsa),
3662 (ospf_asbr_route_add_queue_lsa): Fix bug of OSPF external route
3663 memory leak.
3664
36652000-02-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3666
3667 * ospf_asbr.c (ospf_asbr_route_install_lsa): Re-calculate LSA
3668 checksum after change Advertised Router field.
3669
36702000-02-09 Toshiaki Takada <takada@zebra.org>
3671
3672 * ospf_asbr.c (ospf_external_route_lookup): Add new function.
3673
36742000-02-08 Toshiaki Takada <takada@zebra.org>
3675
3676 * ospfd.c (ospf_router_id_get), (ospf_router_id_update),
3677 (ospf_router_id_update_timer): Router ID decision algorithm is changed.
3678 Router ID is chosen from all of eligible interface addresses even if
3679 it is not enable to OSPF.
3680
36812000-02-08 Toshiaki Takada <takada@zebra.org>
3682
3683 * ospf_asbr.c (ospf_asbr_route_add): Function divided to
3684 ospf_asbr_route_add_flood_lsa, ospf_asbr_route_add_queue_lsa and
3685 ospf_asbr_route_install_lsa. If Router-ID is not set, then LSA is
3686 waited to install to LSDB.
3687 `0.0.0.0 adv_router' AS-external-LSA origination bug was fixed.
3688
36892000-02-01 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3690
3691 * ospf_flood.c (ospf_ls_retransmit_lookup): Compare LS seqnum
3692 in the ACK before deleting.
3693
3694 * ospf_packet.c (ospf_hello): Reset the flags after a shutdown
3695 and no shutdown of the interface.
3696
36972000-01-31 Toshiaki Takada <takada@zebra.org>
3698
3699 * ospf_packet.c (ospf_ls_req): Send multiple Link State Update
3700 packets respond to a Link State Request packet.
3701
3702 * ospfd.c (show_ip_ospf_neighbor_detail_sub): Show thread state.
3703
3704 * ospf_interface.c (ospf_vl_new): Crash when backbone area
3705 is not configured and set virtual-link to no-backbone area,
3706 bug fixed.
3707
37082000-01-30 Kunihiro Ishiguro <kunihiro@zebra.org>
3709
3710 * ospf_neighbor.h (struct ospf_neighbor): Add pointer to last send
3711 LS Request LSA.
3712
3713 * ospf_packet.c (ospf_ls_upd): Comment out LS request list
3714 treatment. That should be done in OSPF flooding procedure.
3715
3716 * ospf_flood.c (ospf_flood_through_area): Enclose
3717 ospf_check_nbr_loding inside if-else close.
3718
37192000-01-31 Toshiaki Takada <takada@zebra.org>
3720
3721 * ospf_packet.c (ospf_make_ls_upd): Fix bug of #LSAs counting.
3722
37232000-01-29 Toshiaki Takada <takada@zebra.org>
3724
3725 * ospf_packet.c (ospf_make_md5_digest): Fix bug of md5 authentication.
3726
37272000-01-28 Toshiaki Takada <takada@zebra.org>
3728
3729 * ospfd.c (show_ip_ospf): Show Number of ASE-LSAs.
3730
37312000-01-27 Kunihiro Ishiguro <kunihiro@zebra.org>
3732
3733 * ospf_packet.c (ospf_make_db_desc): Don't use rm_list for
3734 removing LSA from nbr->db_summary.
3735
37362000-01-27 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3737
3738 * ospf_packet.c (ospf_ls_upd_send): Set AllSPFRouters to
3739 destination when the link is point-to-point.
3740 (ospf_ls_ack_send_delayed): Likewise.
3741
37422000-01-27 Kunihiro Ishiguro <kunihiro@zebra.org>
3743
3744 * ospf_flood.c (ospf_ls_request_delete_all): Fix bug of next
3745 pointer lookup after the node is freed.
3746
37472000-01-26 Kunihiro Ishiguro <kunihiro@zebra.org>
3748
3749 * ospf_asbr.c (ospf_asbr_route_add): Instead of scanning all AS
3750 external route, use ospf_top->external_self.
3751
37522000-01-27 Toshiaki Takada <takada@zebra.org>
3753
3754 * ospf_lsa.c (ospf_forward_address_get): New function added.
3755
3756 * ospf_asbr.c (ospf_asbr_check_lsas): Originate AS-external-LSA
3757 only when it should be replaced.
3758
37592000-01-25 Kunihiro Ishiguro <kunihiro@zebra.org>
3760
3761 * ospf_flood.c (ospf_ls_retransmit_clear): Delete list node.
3762
3763 * ospf_lsa.c (ospf_lsa_free): Reduce logging message using
3764 ospf_zlog value.
3765
3766 * ospf_ism.c (ism_change_status): Fix bug of DR -> non DR status
3767 change. Self originated LSA is freed but not deleted from lsdb.
3768
37692000-01-24 Kunihiro Ishiguro <kunihiro@zebra.org>
3770
3771 * ospf_ism.c (ism_interface_down): Don't use router_id for
3772 detecting self neighbor structure. Instead of that compare
3773 pointer itself.
3774
3775 * ospf_neighbor.c (ospf_nbr_free): Cancel all timer when neighbor
3776 is deleted.
3777 (ospf_nbr_free): Free last send packet.
3778
3779 * ospf_neighbor.h (struct ospf_neighbor): Remove host strucutre.
3780 Instead of that src is introduced.
3781
3782 * ospf_nsm.h: Enclose macro defenition with do {} while (0).
3783
37842000-01-17 Kunihiro Ishiguro <kunihiro@zebra.org>
3785
3786 * ospfd.c: Change part of passive interface implementation. For
3787 passive interface just disabling sending/receiving Hello on the
3788 interface.
3789
37902000-01-16 Kai Bankett <kai.bankett@vew-telnet.net>
3791
3792 * ospf_interface.h (OSPF_IF_PASSIVE): Add passive flag.
3793 * ospf_interface.c (ospf_if_lookup_by_name): Add new function.
3794 * ospf_lsa.c (ospf_router_lsa): Skip passive interface.
3795 * ospfd.c (passive_interface): New command passive-interface is
3796 added.
3797 (ospf_config_write): Print passive interface.
3798
37992000-01-15 Toshiaki Takada <takada@zebra.org>
3800
3801 * ospf_interface.h (crypt_key): New struct added to store
3802 multiple cryptographic autheitication keys.
3803 (ospf_interface): struct changed.
3804
3805 * ospf_interface.c: ospf_crypt_key_new, ospf_crypt_key_add,
3806 ospf_crypt_key_lookup, ospf_crypt_key_delete: new functions added.
3807
3808 * ospf_packet.c (ip_ospf_message_digest_key): Changed to store
3809 multiple cryptographic authentication keys.
3810
38112000-01-14 Toshiaki Takada <takada@zebra.org>
3812
3813 * ospf_interface.c: DEFUN (if_ospf_*) commands changed name to
3814 ip_ospf_* ().
3815 Old notation `ospf *' still remains backward compatibility.
3816
38171999-12-29 Alex Zinin <zinin@amt.ru>
3818 * ospf_lsa.c: ospf_lsa_more_recent() bug fix
3819 * ospf_nsm.c, ospf_packet.c: remove nbr data struct when
3820 int goes down, also check DD flags correctly (bug fix)
3821
38221999-12-28 Alex Zinin <zinin@amt.ru>
3823 * "redistribute <source> metric-type (1|2) metric <XXX>" added
3824
38251999-12-23 Alex Zinin <zinin@amt.ru>
3826 * added RFC1583Compatibility flag
3827 * added dynamic interface up/down functionality
3828
38291999-11-19 Toshiaki Takada <takada@zebra.org>
3830
3831 * ospf_neighbor.h (struct ospf_neighbor): Add member state_change
3832 for NSM state change statistics.
3833
38341999-11-19 Toshiaki Takada <takada@zebra.org>
3835
3836 * ospfd.c (show_ip_ospf_neighbor_detail),
3837 (show_ip_ospf_neighbor_int_detail): DEFUN Added.
3838
38391999-11-14 Kunihiro Ishiguro <kunihiro@zebra.org>
3840
3841 * ospf_asbr.c (ospf_asbr_check_lsas): Add check of
3842 lsa->refresh_list.
3843
38441999-11-11 Toshiaki Takada <takada@zebra.org>
3845
3846 * ospf_ia.[ch] (OSPF_EXAMINE_SUMMARIES_ALL): Macro added.
3847 This macro is expanded to ospf_examine_summaries ()
3848 for SUMMARY_LSA and SUMMARY_LSA_ASBR.
3849 (OSPF_EXAMINE_TRANSIT_SUMMARIES_ALL): Macro added.
3850 This macro is expanded to ospf_examine_transit_summaries ()
3851 for SUMMARY_LSA and SUMMARY_LSA_ASBR.
3852
38531999-11-11 Toshiaki Takada <takada@zebra.org>
3854
3855 * ospf_lsa.[ch] (ospf_find_self_summary_lsa_by_prefix): Changed to
3856 macro OSPF_SUMMARY_LSA_SELF_FIND_BY_PREFIX.
3857 (ospf_find_self_summary_asbr_lsa_by_prefix): Changed to
3858 macro OSPF_SUMMARY_ASBR_LSA_SELF_FIND_BY_PREFIX.
3859 (ospf_find_self_external_lsa_by_prefix): Changed to
3860 macro OSPF_EXTERNAL_LSA_SELF_FIND_BY_PREFIX.
3861
38621999-11-11 Toshiaki Takada <takada@zebra.org>
3863
3864 * ospfd.c (ospf_abr_type): ospf_abr_type_cisco, ospf_abr_type_ibm,
3865 ospf_abr_type_shortcut and ospf_abr_type_standard DEFUNs are
3866 combined.
3867 * ospfd.c (no_ospf_abr_type): no_ospf_abr_type_cisco,
3868 no_ospf_abr_type_ibm and no_ospf_abr_type_shortcut DEFUNS are
3869 combined.
3870
38711999-11-10 Toshiaki Takada <takada@zebra.org>
3872
3873 * ospf_route.c (ospf_lookup_int_by_prefix): Move function to
3874 ospf_interface.c and change name to ospf_if_lookup_by_prefix ().
3875
38761999-11-01 Alex Zinin <zinin@amt.ru>
3877 * ospf_packet.c
3878 some correction to LSU processing
3879
3880 * ospf_lsa.c ospfd.h
3881 randomize initial LSA refreshment interval
3882 and limit the size of LSA-group to 10
3883 to let randomization work more effectively.
3884
38851999-10-31 Alex Zinin <zinin@amt.ru>
3886 * ospf_interface.c
3887 cancel t_network_lsa_self
3888 when freeing int structure
3889
3890 * ospf_abr.c ospf_asbr.c ospf_flood.c ospf_lsa.c
3891 ospf_lsa.h ospf_lsdb.h ospfd.c ospfd.h
3892
3893 Summary and ASE LSA refreshment functions
3894 added---LSA refreshment is paced to 70 LSAs
3895 per sec to avoid link overflow. Refreshment events
3896 are further randomized within a 10 sec interval
3897 to avoid syncing.
3898
3899 Also the sigfault of memcmp() in ospf_lsa_is_different()
3900 is fixed.
3901
39021999-10-30 Alex Zinin <zinin@amt.ru>
3903 * ospf_nsm.c
3904 Fix the bug where MAX_AGE LSAs
3905 are included into the DB summary.
3906
3907 * ospf_interface.c
3908 allocate 2*MTU input buffer instead of just MTU
3909 for the cases when the other router mistakenly
3910 sends larger packets thus causing fragmentation, etc.
3911
3912 * ospf_nsm.c
3913 in nsm_reset_nbr() lists should be freed
3914 not when they are empty.
3915
39161999-10-29 Kunihiro Ishiguro <kunihiro@zebra.org>
3917
3918 * ospf_zebra.c (ospf_acl_hook): Move OSPF_IS_ASBR and OSPF_IS_ABR
3919 check inside of if (ospf_top).
3920
39211999-10-29 Alex Zinin <zinin@amt.ru>
3922 * ospf_lsa.c ospf_lsdb.c :
3923 add assertion in lsa and lsa->data alloc functions,
3924 as well as in lsdb_add for new->data
3925
3926 * ospf_lsdb.c: free hash table correctly
3927
39281999-10-28 John Capo <jc@irbs.com>
3929
3930 * ospf_packet.h (OSPF_PACKET_MAX): Correct MAX packet length
3931 calculation
3932
39331999-10-27 Kunihiro Ishiguro <kunihiro@zebra.org>
3934
3935 * OSPF-TRAP-MIB.txt: New file added. Edited version of RFC1850.
3936
3937 * OSPF-MIB.txt: New file added. Edited version of RFC1850.
3938
39391999-10-27 Alex Zinin <zinin@amt.ru>
3940 * ospfd, ospf_zebra, ospf_abr
3941 "area import-list" command is added.
3942 This command allows to filter the inter-area routes
3943 injected into an area. Access list hook function
3944 extended to invalidate area exp/imp lists.
3945
39461999-10-25 Yoshinobu Inoue <shin@nd.net.fujitsu.co.jp>
3947
3948 * ospfd.c (ospf_interface_run): Enable to detect P2P network
3949 on an OSPF interface.
3950
39511999-10-19 Jordan Mendelson <jordy@wserv.com>
3952
3953 * ospf_lsdb.c (ospf_lsdb_add): Fix bug of crash
3954 in ospf_ls_retransmit_lookup ().
3955
39561999-10-19 Vladimir B. Grebenschikov <vova@express.ru>
3957
3958 * ospf_route.c: Workaround about installation of OSPF routes into
3959 the zebra daemon. Add checking of existance routes. Free
3960 ospf_top->old_table if it exists.
3961
39621999-10-15 Jordan Mendelson <jordy@wserv.com>
3963
3964 * Add support for MD5 authentication.
3965
39661999-10-12 Alex Zinin <zinin@amt.ru>
3967 * ospfd.c, ospfd.h, ospf_abr.c:
3968 a new command "area export-list" was added, it allows
3969 the admin. to control which intra-area routes are
3970 announced to other areas by the ABR
3971
39721999-10-12 Alex Zinin <zinin@amt.ru>
3973 * ospf_asbr.c (ospf_asbr_check_lsas): Fix bug of coredump
3974 when "no redistribute" is used after a distribute list
3975 denying some networks was used
3976
39771999-10-05 Toshiaki Takada <takada@zebra.org>
3978
3979 * ospf_route.c (ospf_path_dup): New function added.
3980
39811999-10-05 Toshiaki Takada <takada@zebra.org>
3982
3983 * ospf_interface.[ch]: Some of VL related funciton name changed.
3984
39851999-09-27 Alex Zinin <zinin@amt.ru>
3986
3987 * ospf_zebra.c: Distribute-list functionality added
3988
39891999-09-27 Toshiaki Takada <takada@zebra.org>
3990
3991 * ospfd.c (show_ip_ospf): Fix bug of segmentation fault when no ospf
3992 instance exists.
3993
39941999-09-25 Kunihiro Ishiguro <kunihiro@zebra.org>
3995
3996 * ospfd.c (ospf_interface_down): Fix bug of misusing nextnode()
3997 instead of node->next. Reported by Hiroki Ishibashi
3998 <ishibasi@dcd.abk.nec.co.jp>.
3999
4000 * ospf_route.c (show_ip_ospf_route): Add check for ospf is enabled
4001 or not.
4002
40031999-09-23 Alex Zinin <zinin@amt.ru>
4004
4005 * stub area support added
4006
40071999-09-23 Alex Zinin <zinin@amt.ru>
4008
4009 * fwd_addr in ASE-LSAs is now set correctly
4010 * ASE routing changed to check the fwd_addr
4011 and skip the route if the addr points to one
4012 of our interfaces to avoid loops.
4013
40141999-09-22 Alex Zinin <zinin@amt.ru>
4015
4016 * ospf_interface:
4017 ospf_vls_in_area() added, it returns
4018 the number of VLs configured through the area
4019
4020 * ospf_interface.c ospf_lsa.c ospf_lsdb.c ospfd.c
4021 honor correct mem alloc
4022
40231999-09-22 Alex Zinin <zinin@amt.ru>
4024
4025 * memory.[ch]:
4026 Some OSPF mem types added,
4027 plus more info in "show mem"
4028
40291999-09-21 Alex Zinin <zinin@amt.ru>
4030
4031 * ospfd.c:
4032 "area range substitute" added.
4033 It can be used on NAT-enabled (IP-masquarade)
4034 routers to announce private networks
4035 from an area as public ones into the outside
4036 world (not in the RFC, btw :)
4037
40381999-09-21 Alex Zinin <zinin@amt.ru>
4039
4040 * ospfd.c:
4041 "area range suppress" added.
4042 This command allows to instruct the router
4043 to be silent about specific ranges, i.e.,
4044 it is a method of route filtering on area
4045 borders
4046
40471999-09-21 Alex Zinin <zinin@amt.ru>
4048
4049 * ospfd.c VLs removed when "no network area" executed
4050
40511999-09-20 Alex Zinin <zinin@amt.ru>
4052
4053 * ospf_ase.c bug fix for not-zero fwd_addr
4054 and directly connected routes.
4055
40561999-09-20 Yon Uriarte <yon@plannet.de>
4057
4058 * ospf_packet.c (ospf_make_ls_req): Introduce delta value for
4059 checking the length of OSPF packet exceeds MTU or not.
4060
4061 * ospf_lsa.c (ospf_lsa_different): Apply ntohs for checking
4062 l1->data->length.
4063
40641999-09-18 Alex Zinin <zinin@amt.ru>
4065
4066 * ospf_lsa.c bug fix for ospf_network_lsa() to
4067 include itself into the RID list
4068
40691999-09-10 Alex Zinin <zinin@amt.ru>
4070
4071 * Alternative ABR behaviors IBM/Cisco/Shortcut
4072 implemented
4073
40741999-09-10 Alex Zinin <zinin@amt.ru>
4075
4076 * router and network-LSA origination
4077 changed to honor MinLSInterval
4078
40791999-09-08 Alex Zinin <zinin@amt.ru>
4080
4081 * modified ABR behavior to honor VLs and transit
4082 areas
4083
40841999-09-07 Alex Zinin <zinin@amt.ru>
4085
4086 * completed VL functionality
4087
40881999-09-06 Kunihiro Ishiguro <kunihiro@zebra.org>
4089
4090 * ospf_asbr.c: New file.
4091 ospf_asbr.h: New file.
4092
4093 * ospf_zebra.c (ospf_redistribute_connected): Add redistribute
4094 related stuff.
4095
40961999-09-05 Kunihiro Ishiguro <kunihiro@zebra.org>
4097
4098 * ospfd.h (OSPF_FLAG_VIRTUAL_LINK): Change OSPF_FLAG_VEND to
4099 OSPF_FLAG_VIRTUAL_LINK for comprehensiveness.
4100
41011999-09-03 Kunihiro Ishiguro <kunihiro@zebra.org>
4102
4103 * ospf_spf.c (ospf_spf_register): Change name from
4104 ospf_spf_route_add() to ospf_spf_register().
4105 Include "ospfd/ospf_abr.h" for ospf_abr_task() prototype.
4106
41071999-09-02 Kunihiro Ishiguro <kunihiro@zebra.org>
4108
4109 * ospf_lsa.c (ospf_external_lsa_install): Change to update
4110 lsa->data rather than install new one, when same id lsa is already
4111 installed.
4112
41131999-09-01 Kunihiro Ishiguro <kunihiro@zebra.org>
4114
4115 * ospf_lsa.c (ospf_router_lsa_install): Return lsa value.
4116 (ospf_network_lsa_install): Likewise.
4117 (ospf_summary_lsa_install): Likewise.
4118 (ospf_summary_asbr_lsa_install): Likewise.
4119 (ospf_external_lsa_install): Likewise.
4120
4121 * ospf_spf.c (ospf_spf_calculate): Comment out debug function
4122 ospf_rtrs_print().
4123
41241999-08-31 Kunihiro Ishiguro <kunihiro@zebra.org>
4125
4126 * ospf_spf.c (ospf_rtrs_free): Add ospf_spf_calculate() for
4127 freeing rtrs.
4128
41291999-08-31 Toshiaki Takada <takada@zebra.org>
4130
4131 * ospf_lsa.c (show_ip_ospf_database_summary),
4132 (show_ip_ospf_database_summary_asbr),
4133 (show_ip_ospf_database_external): New function added.
4134 `show ip ospf database summary',
4135 `show ip ospf database asbr-summary'
4136 `show ip ospf database external' command can be used.
4137
4138 * ospf_lsa.c (ospf_lsa_count_table): New function added.
4139 (show_ip_ospf_database_all): show nothing if a type of LSA
4140 does not exist.
4141
41421999-08-31 Kunihiro Ishiguro <kunihiro@zebra.org>
4143
4144 * ospf_lsa.c (ospf_maxage_lsa_remover): Preserve next pointer when
4145 the node is deleted.
4146
41471999-08-31 Toshiaki Takada <takada@zebra.org>
4148
4149 * ospf_flood.c (ospf_ls_retransmit_lookup): change to return
4150 struct ospf_lsa *.
4151 (ospf_ls_request_new), (ospf_ls_request_free),
4152 (ospf_ls_request_add), (ospf_ls_request_delete),
4153 (ospf_ls_request_delete_all), (ospf_ls_request_lookup):
4154 New function added.
4155
4156 * ospf_packet.c (ospf_ls_upd_send_lsa): New function added.
4157
4158 * ospf_lsa.h (LS_AGE): Slightly change macro definition.
4159
4160 * ospf_lsa.c (ospf_lsa_more_recent), (ospf_lsa_diffrent):
4161 Use LS_AGE macro.
4162
41631999-08-30 Alex Zinin <zinin@amt.ru>
4164
4165 * ospfd.c
4166 fix a bug with area range config write
4167 added "show ip ospf" command, it will be enhanced later on
4168
41691999-08-30 Alex Zinin <zinin@amt.ru>
4170
4171 * ospf_lsa.c
4172 updated ospf_router_lsa() to honor flags (B-bit)
4173
41741999-08-30 Alex Zinin <zinin@amt.ru>
4175
4176 * ospf_abr.c
4177 wrote major functions implementing ABR activity
4178
41791999-08-30 Alex Zinin <zinin@amt.ru>
4180
4181 * ospf_ia.c ospf_route.c ospf_route.h
4182 fixed the bug with ospf_route.origin field.
4183 Now it holds pointer to lsa_header
4184
41851999-08-30 Alex Zinin <zinin@amt.ru>
4186
4187 * ospf_flood.c ospf_flood.h:
4188 transformed ospf_flood_if_select into ospf_flood_through_area()
4189 added new ospf_flood_if_select() and ospf_flood_through_as()
4190
41911999-08-30 Toshiaki Takada <takada@zebra.org>
4192
4193 * ospf_flood.[ch]: New file added.
4194
4195 * ospf_packet.c (ospf_lsa_flooding),
4196 (ospf_lsa_flooding_select_if): functions move to ospf_flood.c
4197
4198 * ospf_neighbor.c (ospf_put_lsa_on_retransm_list),
4199 (ospf_remove_lsa_from_retransm_list),
4200 (ospf_nbr_remove_all_lsas_from_retransm_list),
4201 (ospf_lsa_remove_from_ls_retransmit):
4202 (ospf_lsa_retransmit): functions move to
4203 ospf_flood.c, and change function's name:
4204
4205 ospf_put_lsa_on_retransm_list ()
4206 -> ospf_ls_retransmit_add ()
4207 ospf_remove_lsa_from_retransm_list ()
4208 -> ospf_ls_retransmit_delete ()
4209 ospf_nbr_remove_all_lsas_from_retransm_list ()
4210 -> ospf_ls_retransmit_clear ()
4211 ospf_lsa_remove_from_ls_retransmit ()
4212 -> ospf_ls_retransmit_delete_nbr_all ()
4213 ospf_lsa_retransmit ()
4214 -> ospf_ls_retransmit_add_nbr_all ()
4215
4216 * ospf_lsa.c (ospf_lsa_lookup_from_list): function move to
4217 ospf_flood.c, and change name to ospf_ls_retransmit_lookup ().
4218
42191999-08-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4220
4221 * ospf_neighbor.c (ospf_nbr_lookup_by_addr): Use
4222 route_node_lookup() instead of route_node_get().
4223
4224 * ospf_packet.c (ospf_ls_upd): Temporary comment out (6) check.
4225
42261999-08-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4227
4228 * ospf_route.c (ospf_lookup_int_by_prefix): Add check of
4229 oi->address.
4230
42311999-08-29 Alex Zinin <zinin@amt.ru>
4232 * ospf_lsa.c
4233 MaxAge LSA deletion functions added.
4234
42351999-08-29 Alex Zinin <zinin@amt.ru>
4236 * ospf_neighbor.c
4237 ospf_nbr_lookup_by_addr(): added route_unlock_node()
4238 when function returns NULL if (rn->info == NULL)
4239
42401999-08-29 Alex Zinin <zinin@amt.ru>
4241 * ospfd.c
4242 added a hack for area range deletion
4243
42441999-08-29 Alex Zinin <zinin@amt.ru>
4245 * ospf_lsa.h
4246 included lsdb field into struct ospf_lsa, to find
4247 LSDB easier when removing MaxAge LSAs.
4248
42491999-08-29 Alex Zinin <zinin@amt.ru>
4250 * ospf_lsa.c ospf_neighbor.c ospf_nsm.c
4251 ospf_packet.c changed to honor new retransmit list
4252 management functions
4253
42541999-08-29 Alex Zinin <zinin@amt.ru>
4255 * ospf_neighbor.c , .h added new retransmit list functions.
4256
42571999-08-29 Alex Zinin <zinin@amt.ru>
4258 * Makefile.in
4259 added ospf_ase, ospf_abr, ospf_ia
4260
42611999-08-29 Alex Zinin <zinin@amt.ru>
4262 * ospf_spf.c:
4263 - changed ospf_next_hop_calculation() to include interface
4264 and nexthop addr for directly connected routers---more informative
4265 and solves problem with route installation into the kernel
4266 - changed ospf_nexthop_out_if_addr() to support routers, not only
4267 transit networks
4268 - added ospf_process_stubs();
4269
42701999-08-29 Alex Zinin <zinin@amt.ru>
4271 * ospf_lsa.c:
4272 - changed ospf_router_lsa() to provide correct links
4273 for p-t-p interfaces;
4274 - changed ospf_summary_lsa_install() to support table
4275 of self-originated summary-LSAs;
4276 - added ospf_summary_asbr_lsa_install() and ospf_external_lsa_install()
4277 - changed ospf_lsa_install() accordingly
4278 - changed show_ip_ospf_database_router_links() to support p-t-p
4279
42801999-08-29 Kunihiro Ishiguro <kunihiro@zebra.org>
4281
4282 * ospf_packet.c (ospf_make_db_desc): Only master can clear more
4283 flag.
4284
42851999-08-29 Kunihiro Ishiguro <kunihiro@zebra.org>
4286
4287 * ospf_packet.c (ospf_read): Add check of IP src address.
4288
42891999-08-28 Alex Zinin <zinin@amt.ru>
4290 * ospf_neighbor.h
4291 added ospf_nbr_lookup_by_routerid()
4292
42931999-08-28 Alex Zinin <zinin@amt.ru>
4294 * ospfd.h
4295 added ABR/ASBR flag definitions and fields;
4296 added iflist field to area structure;
4297 summary_lsa_self and summary_lsa_asbr_self are changed
4298 to be route tables;
4299 added ranges field---configured area ranges;
4300 A separate Routers RT added;
4301 area range config commands and config write added
4302
4303
43041999-08-28 Alex Zinin <zinin@amt.ru>
4305 * ospf_route.c :
4306 ospf_route_free()--added code to free the list of paths;
4307 The following functions added:
4308 ospf_intra_add_router();
4309 ospf_intra_add_transit();
4310 ospf_intra_add_stub();
4311 the last function uses new ospf_int_lookup_by_prefix();
4312 show_ip_ospf_route_cmd()--changed to support new RT structure;
4313 added ospf_cmp_routes()--general route comparision function;
4314 added ospf_route_copy_nexthops() and ospf_route_copy_nexthops_from_vertex()
4315 they are used in ASE and IA routing;
4316 added ospf_subst_route() and ospf_add_route();
4317
43181999-08-28 Alex Zinin <zinin@amt.ru>
4319 * ospf_route.h :
4320 changed struct ospf_path to include output interface,
4321 changed struct ospf_route to support IA and ASE routing.
4322 added prototypes of the function used in IA and ASE modules.
4323
43241999-08-28 Alex Zinin <zinin@amt.ru>
4325 * ospf_lsa.h ospf_lsa.c :
4326 added ospf_my_lsa(), an interface independent version of
4327 ospf_lsa_is_self_originated(), it will be used in ASE and IA-routing.
4328
43291999-08-27 Kunihiro Ishiguro <kunihiro@zebra.org>
4330
4331 * ospf_interface.c (interface_config_write): Add check for
4332 oi->nbr_self.
4333
43341999-08-25 Toshiaki Takada <takada@zebra.org>
4335
4336 * ospf_lsa.c (ospf_lsa_dup): New function added.
4337
4338 * ospf_packet.c (ospf_write), (ospf_read): Print send/recv
4339 interface in debug message.
4340
43411999-08-25 Toshiaki Takada <takada@zebra.org>
4342
4343 * ospf_packet.c (ospf_ls_ack_send): The name is changed from
4344 `ospf_ls_ack_send'.
4345 (ospf_ls_ack_send_delayed) (ospf_ls_ack_timer): New function added.
4346 Delayed Link State Acknowledgment is scheduled by timer.
4347
43481999-08-25 Alex Zinin <zinin@amt.ru>
4349
4350 * ospf_lsa.c (ospf_router_lsa): Incorrectly included link to
4351 a stub network instead of link to a transit network into
4352 originated router-LSA, bug fixed.
4353
43541999-08-24 Toshiaki Takada <takada@zebra.org>
4355
4356 * ospfd.c (ospf_update_router_id): New function added.
4357
4358 * ospf_network.c (ospf_write): Create new socket per transmission.
4359 And select outgoing interface whether dst is unicast or multicast.
4360
4361 * ospf_packet.c: LSA flooding will work.
4362
43631999-08-24 VOP <vop@unity.net>
4364
4365 * ospf_route.c: Include "sockunion.h"
4366
43671999-08-24 Kunihiro Ishiguro <kunihiro@zebra.org>
4368
4369 * ospf_network.c (ospf_serv_sock_init): Enclose
4370 IPTOS_PREC_INTERNETCONTROL setting with #ifdef for OS which does
4371 not have the definition.
4372
43731999-08-23 Toshiaki Takada <takada@zebra.org>
4374
4375 * ospf_packet.c: Fix bug of DD processing.
4376
43771999-08-18 Toshiaki Takada <takada@zebra.org>
4378
4379 * ospf_lsa.c (show_ip_ospf_database): Show actual `LS age'.
4380
43811999-08-17 Toshiaki Takada <takada@zebra.org>
4382
4383 * ospf_lsa.h (OSPF_MAX_LSA): The value of OSPF_MAX_LSA is
4384 corrected. The bug of `mes_lookup' is fixed.
4385 This had been reported by Poul-Henning Kamp <phk@freebsd.org>.
4386
4387 * ospf_lsa.c (ospf_router_lsa_install): The name is changed from
4388 `ospf_add_router_lsa'.
4389 (ospf_network_lsa_install): The name is changed from
4390 `ospf_add_network_lsa'.
4391
4392 * ospf_interface.h (ospf_interface): Add member `nbr_self'.
4393
4394 * ospf_interface.c (ospf_if_is_enable): New function added.
4395
43961999-08-16 Toshiaki Takada <takada@zebra.org>
4397
4398 * ospf_lsa.h (struct lsa_header): The name is changed from
4399 `struct ospf_lsa'.
4400 (struct ospf_lsa): New struct added to control each LSA's aging
4401 and timers.
4402
4403 * ospf_lsa.c (ospf_lsa_data_free): The name is change from
4404 `ospf_lsa_free'.
4405 (ospf_lsa_data_new), (ospf_lsa_new), (ospf_lsa_free),
4406 (ospf_lsa_different), (ospf_lsa_install): New function added.
4407
4408 * ospf_packet.c (ospf_ls_upd_list_lsa): New function added.
4409
44101999-08-12 Toshiaki Takada <takada@zebra.org>
4411
4412 * ospf_nsm.c (nsm_reset_nbr): New function added.
4413 KillNbr and LLDown neighbor event call this function.
4414
44151999-08-10 Toshiaki Takada <takada@zebra.org>
4416
4417 * ospf_packet.c (ospf_ls_retransmit)
4418 (ospf_ls_upd_timer): New function added.
4419 Set retransmission timer for Link State Update.
4420
44211999-07-29 Toshiaki Takada <takada@zebra.org>
4422
4423 * ospf_ism.c (ospf_dr_election): Fix bug of DR election.
4424
44251999-07-28 Toshiaki Takada <takada@zebra.org>
4426
4427 * ospf_network.c (ospf_serv_sock_init): Set IP precedence field
4428 with IPTOS_PREC_INTERNET_CONTROL.
4429
4430 * ospf_nsm.c (nsm_change_status): Schedule NeighborChange event
4431 if NSM status change.
4432
4433 * ospf_packet.c (ospf_make_hello): Never include a neighbor in
4434 Hello packet, when the neighbor goes down.
4435
44361999-07-26 Kunihiro Ishiguro <kunihiro@zebra.org>
4437
4438 * Makefile.am (noinst_HEADERS): Add ospf_route.h.
4439
4440 * ospf_route.c (show_ip_ospf_route): Add `show ip ospf route'
4441 command.
4442
44431999-07-25 Toshiaki Takada <takada@zebra.org>
4444
4445 * ospf_lsa.c (ospf_router_lsa): Fix bug of LS sequence number
4446 assignement.
4447
44481999-07-25 Kunihiro Ishiguro <kunihiro@zebra.org>
4449
4450 * ospf_route.c (ospf_route_table_free): New function added.
4451
4452 * ospf_spf.c (ospf_spf_next): Free vertex w when cw's and w's
4453 distance is same.
4454
4455 * ospfd.h (struct ospf): Add old_table.
4456
4457 * ospf_main.c (sighup): Call of log_rotate () removed.
4458
4459 * ospf_lsa.c (ospf_lsa_is_self_originated): Fix bug of checking
4460 area->lsa as self LSA. This should be area->lsa_self.
4461
44621999-07-24 Kunihiro Ishiguro <kunihiro@zebra.org>
4463
4464 * ospf_zebra.c (ospf_zebra_add): ospf_zebra_add
4465 (),ospf_zebra_delete () added.
4466
4467 * ospf_spf.c (ospf_spf_calculate): Call ospf_intra_route_add ().
4468
44691999-07-24 Toshiaki Takada <takada@zebra.org>
4470
4471 * ospf_lsa.c: Change LS sequence number treatment.
4472 (ospf_lsa_is_self_originated): New function added.
4473 (show_ip_ospf_database_self_originated): New DEFUN added.
4474
44751999-07-23 Kunihiro Ishiguro <kunihiro@zebra.org>
4476
4477 * ospf_interface.c (ospf_if_lookup_by_addr): Add loopback check.
4478
44791999-07-22 Toshiaki Takada <takada@zebra.org>
4480
4481 * ospf_spf.c (ospf_nexthop_new), (ospf_nexthop_free),
4482 (ospf_nexthop_dup): function added.
4483 (ospf_nexthop_calculation): function changed.
4484
4485 * ospf_interface.c (ospf_if_lookup_by_addr): function added.
4486
44871999-07-21 Toshiaki Takada <takada@zebra.org>
4488
4489 * ospf_spf.c (ospf_spf_closest_vertex): function removed.
4490
44911999-07-21 Kunihiro Ishiguro <kunihiro@zebra.org>
4492
4493 * ospf_spf.c (ospf_spf_next): Apply ntohs for fetching metric.
4494
44951999-07-21 Toshiaki Takada <takada@zebra.org>
4496
4497 * ospf_neighbor.c (ospf_nbr_lookup_by_router_id): fundtion removed.
4498
4499 * ospf_lsa.c (show_ip_ospf_database_router): describe each
4500 connected link.
4501
45021999-07-21 Kunihiro Ishiguro <kunihiro@zebra.org>
4503
4504 * ospf_spf.c (ospf_spf_next): V is router LSA or network LSA so
4505 change behavior according to LSA type.
4506 (ospf_lsa_has_link): Link check function is added.
4507
45081999-07-20 Kunihiro Ishiguro <kunihiro@zebra.org>
4509
4510 * ospf_spf.c (ospf_spf_calculate_schedule): Add new function for
4511 SPF calcultion schedule addtition.
4512 (ospf_spf_calculate_timer_add): Rough 30 sec interval SPF calc
4513 timer is added.
4514 (ospf_spf_next_router): Delete ospf_spf_next_network ().
4515
4516 * ospf_lsa.c (show_ip_ospf_database_all): Network-LSA display
4517 header typo correction. Display of router LSA's #link added.
4518
45191999-07-19 Toshiaki Takada <takada@zebra.org>
4520
4521 * ospf_packet.c (ospf_check_network_mask): Added new function for
4522 receiving Raw IP packet on an appropriate interface.
4523
45241999-07-16 Toshiaki Takada <takada@zebra.org>
4525
4526 * ospfd.c (ospf_router_id): new DEFUN added.
4527
45281999-07-15 Toshiaki Takada <takada@zebra.org>
4529
4530 * ospf_spf.c (ospf_spf_init), (ospf_spf_free),
4531 (ospf_spf_has_vertex), (ospf_vertex_lookup),
4532 (ospf_spf_next_router), (ospf_spf_next_network),
4533 (ospf_spf_closest_vertex), (ospf_spf_calculate):
4534 function added.
4535
45361999-07-13 Toshiaki Takada <takada@zebra.org>
4537
4538 * ospf_ism.c: fix bug of DR Election.
4539
4540 * ospf_nsm.c: fix bug of adjacency forming.
4541
45421999-07-05 Kunihiro Ishiguro <kunihiro@zebra.org>
4543
4544 * ospfd.c (ospf_init): Change to use install_default.
4545
45461999-07-01 Rick Payne <rickp@rossfell.co.uk>
4547
4548 * ospf_zebra.c (zebra_init): Install standard commands to
4549 ZEBRA_NODE.
4550
45511999-06-30 Toshiaki Takada <takada@zebra.org>
4552
4553 * ospf_dump.c: Whole debug command is improved.
4554 (ISM|NSM) (events|status|timers) debug option added.
4555 (show_debugging_ospf): new DEFUN added.
4556
45571999-06-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4558
4559 * ospf_lsa.c (ospf_lsa_lookup_from_list): Change !IPV4_ADDR_CMP to
4560 IPV4_ADDR_SAME.
4561
45621999-06-29 Toshiaki Takada <takada@zebra.org>
4563
4564 * ospf_dump.c (ospf_summary_lsa_dump): Add summary-LSA dump routine.
4565 (ospf_as_external_lsa_dump): Add AS-external-LSA dump routine.
4566
4567 * ospf_nsm.c (nsm_twoway_received): fix condtion of adjacnet.
4568
4569 * ospf_ism.c (ospf_dr_election): fix DR Election.
4570
4571 * ospf_dump.c (ospf_nbr_state_message): fix `show ip ospf neighbor'
4572 command's state.
4573
45741999-06-29 Kunihiro Ishiguro <kunihiro@zebra.org>
4575
4576 * ospf_dump.c (ospf_router_lsa_dump): Add router-LSA dump routine.
4577
45781999-06-28 Toshiaki Takada <takada@zebra.org>
4579
4580 * ospf_lsa.c (show_ip_ospf_database_network): fix bug of
4581 `show ip ospf database network' command output.
4582
4583 * ospf_nsm.c (nsm_inactivity_timer): Clear list of Link State
4584 Retransmission, Database Summary and Link State Request.
4585
4586 * ospf_packet.c (ospf_ls_req_timer): New function added.
4587 Set Link State Request retransmission timer.
4588
45891999-06-27 Kunihiro Ishiguro <kunihiro@zebra.org>
4590
4591 * ospf_main.c (main): Change default output from ZLOG_SYSLOG to
4592 ZLOG_STDOUT.
4593
4594 * ospfd.c (ospf_init): Register show_ip_ospf_interface_cmd and
4595 show_ip_ospf_neighbor_cmd to VIEW_NODE.
4596
4597 * ospf_lsa.c (ospf_lsa_init): Register show_ip_ospf_database_cmd
4598 and show_ip_ospf_database_type_cmd to VIEW_NODE.
4599
46001999-06-25 Toshiaki Takada <takada@zebra.org>
4601
4602 * ospf_packet.c: fix bug of DD making.
4603 fix bug of LS-Update reading.
4604
46051999-06-23 Toshiaki Takada <takada@zebra.org>
4606
4607 * ospf_packet.c: All type of packets are changed to use
4608 fifo queue structure.
4609 (ospf_fill_header) function added.
4610
46111999-06-22 Toshiaki Takada <takada@zebra.org>
4612
4613 * ospf_packet.c (ospf_packet_new): New function added to handle
4614 sending ospf packet by fifo queue structure.
4615 (ospf_packet_free), (ospf_fifo_new), (ospf_fifo_push),
4616 (ospf_fifo_pop), (ospf_fifo_head), (ospf_fifo_flush),
4617 (ospf_fifo_free): Likewise.
4618
46191999-06-21 Toshiaki Takada <takada@zebra.org>
4620
4621 * ospf_nsm.c (ospf_db_desc_timer): function added.
4622 (nsm_timer_set) function added.
4623 * ospf_dump.c (ospf_option_dump): function added.
4624 * ospf_packet.c (ospf_ls_req) (ospf_make_ls_req): function added.
4625
46261999-06-20 Toshiaki Takada <takada@zebra.org>
4627
4628 * ospf_lsa.c (ospf_lsa_more_recent): function added.
4629 * ospf_neighbor.h (struct ospf_neighbor): Change member ms_flag
4630 to dd_flags.
4631
46321999-06-19 Toshiaki Takada <takada@zebra.org>
4633
4634 * ospf_lsa.c: DEFUN (show_ip_ospf_database) Added.
4635 * ospf_interface.c (if_ospf_cost), (if_ospf_dead_interval),
4636 (if_ospf_hello_interval), (if_ospf_priority),
4637 (if_ospf_retransmit_interval), (if_ospf_transmit_delay)
4638 argument changed from NUMBER to <range>.
4639 DEFUN (if_ospf_network_broadcast),
4640 DEFUN (if_ospf_network_non_broadcast),
4641 DEFUN (if_ospf_network_point_to_multipoint),
4642 DEFUN (if_ospf_network_point_to_point) functions are combined to
4643 DEFUN (if_ospf_network).
4644
46451999-06-18 Toshiaki Takada <takada@zebra.org>
4646
4647 * ospf_lsa.c: ospf_add_router_lsa (), ospf_add_network_lsa (),
4648 ospf_lsa_lookup (), ospf_lsa_count () Added.
4649
46501999-06-15 Toshiaki Takada <takada@zebra.org>
4651
4652 * DEFUN (ospf_debug_ism), DEFUN (ospf_debug_nsm),
4653 DEFUN (no_ospf_debug_ism), DEFUN (no_ospf_debug_nsm) Added.
4654 `debug ospf ism' command shows debug message.
4655 `debuf ospf nsm' command shows debug message.
4656
46571999-06-14 Toshiaki Takada <takada@zebra.org>
4658
4659 * ospf_lsa.c: ospf_network_lsa () Added.
4660 ospf_lsa_checksum () Added.
4661 * DEFUN (ospf_debug_packet), DEFUN (no_ospf_debug_packet) Added.
4662 `debug ospf packet' command shows debug message.
4663
46641999-06-13 Toshiaki Takada <takada@zebra.org>
4665
4666 * ospf_packet.h: Remove struct ospf_ls_req {}, ospf_ls_upd {},
4667 ospf_ls_ack {}.
4668
46691999-06-11 Toshiaki Takada <takada@zebra.org>
4670
4671 * ospf_dump.c: fix IP packet length treatment.
4672
46731999-06-10 Toshiaki Takada <takada@zebra.org>
4674
4675 * ospf_ism.h: Add OSPF_ISM_EVENT_EXECUTE() Macro Added.
4676 * ospf_nsm.h: Add OSPF_NSM_EVENT_EXECUTE() Macro Added.
4677
4678 * ospf_packet.c: ospf_db_desc (), ospf_db_desc_send () Added.
4679 ospf_make_hello (), ospf_make_db_desc () Added.
4680 ospf_db_desc_proc () Added.n
4681
4682 * Database Description packet can be processed.
4683
46841999-06-08 Toshiaki Takada <takada@zebra.org>
4685
4686 * ospf_lsa.c: New file.
4687
46881999-06-07 Toshiaki Takada <takada@zebra.org>
4689
4690 * ospf_neighbor.c: ospf_fully_adjacent_count () Added.
4691
46921999-06-07 Kunihiro Ishiguro <kunihiro@zebra.org>
4693
4694 * ospf_spf.[ch]: New file.
4695
46961999-05-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4697
4698 * ospf_zebra.c: Changed to use lib/zclient.c routines.
4699
4700 * ospf_zebra.h (zebra_start): Remove struct zebra.
4701
47021999-05-29 Kunihiro Ishiguro <kunihiro@zebra.org>
4703
4704 * ospfd.c (ospf_config_write): Add cast (unsigned long int) to
4705 ntohl for sprintf warning.
4706
47071999-05-19 Toshiaki Takada <takada@zebra.org>
4708
4709 * ospf_ism.c (ospf_dr_election): Join AllDRouters Multicast group
4710 if interface state changes to DR or BDR.
4711
47121999-05-14 Stephen R. van den Berg <srb@cuci.nl>
4713
4714 * ospf_main.c (signal_init): SIGTERM call sigint.
4715 (sigint): Logging more better message.
4716
47171999-05-12 Toshiaki Takada <takada@zebra.org>
4718
4719 * ospfd.c: Fix bug of `no router ospf' statement, it will work.
4720
47211999-05-11 Toshiaki Takada <takada@zebra.org>
4722
4723 * ospf_neighbor.c: ospf_nbr_free () Added.
4724
47251999-05-10 Toshiaki Takada <takada@zebra.org>
4726
4727 * ospfd.h: struct ospf_area { }, struct ospf_network { } Changed.
4728 * Fix bug of `no network' statement, it will work.
4729
47301999-05-07 Toshiaki Takada <takada@zebra.org>
4731
4732 * ospf_interface.c, ospf_zebra.c: Fix bug of last interface is not
4733 updated by ospf_if_update ().
4734
47351999-04-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4736
4737 * Makefile.am (noinst_HEADERS): Add ospf_lsa.h for distribution.
4738
47391999-04-25 Toshiaki Takada <takada@zebra.org>
4740
4741 * ospf_interface.c: DEFUN (no_if_ospf_cost),
4742 DEFUN (no_if_ospf_dead_interval),
4743 DEFUN (no_if_ospf_hello_interval),
4744 DEFUN (no_if_ospf_priority),
4745 DEFUN (no_if_ospf_retransmit_interval),
4746 DEFUN (no_if_ospf_transmit_delay) Added.
4747
4748 interface_config_write () suppress showing interface
4749 default values.
4750
47511999-04-25 Kunihiro Ishiguro <kunihiro@zebra.org>
4752
4753 * ospf_dump.c (ospf_timer_dump): If thread is NULL return "inactive".
4754
4755 * ospfd.c (ospf_if_update): Fix bug of using ospf_area { } instead
4756 of ospf_network { }. So `router ospf' statement in ospfd.conf
4757 works again.
4758 (ospf_if_update): Call ospf_get_router_id for updating router ID.
4759
47601999-04-25 Toshiaki Takada <takada@zebra.org>
4761
4762 * ospf_interface.c: DEFUN (if_ospf_network) deleted.
4763 DEFUN (if_ospf_network_broadcast),
4764 DEFUN (if_ospf_network_non_broadcast),
4765 DEFUN (if_ospf_network_point_to_multipoint),
4766 DEFUN (if_ospf_network_point_to_point),
4767 DEFUN (no_if_ospf_network) Added.
4768
47691999-04-23 Toshiaki Takada <takada@zebra.org>
4770
4771 * ospfd.h: struct area { } changed to struct ospf_network { }.
4772 Add struct ospf_area { }.
4773 * ospfd.c: Add ospf_area_lookup_by_area_id (), ospf_network_new (),
4774 and ospf_network_free ().
4775 DEFUN (area_authentication), DEFUN (no_area_authentication) Added.
4776
47771999-04-22 Toshiaki Takada <takada@zebra.org>
4778
4779 * ospf_lsa.h: New file.
4780 * ospf_packet.h: LSA related struct definition are moved to
4781 ospf_lsa.h.
4782 * ospf_packet.c: ospf_verify_header () Added.
4783
47841999-04-21 Toshiaki Takada <takada@zebra.org>
4785
4786 * ospf_ism.c: ospf_elect_dr () and related function is changed.
4787 DR Election bug fixed.
4788 * ospf_dump.c: ospf_nbr_state_message (), ospf_timer_dump () Added.
4789 * ospfd.c: DEFUN (show_ip_ospf_neighbor) Added.
4790
47911999-04-19 Kunihiro Ishiguro <kunihiro@zebra.org>
4792
4793 * ospf_main.c (main): access_list_init () is added for vty
4794 connection filtering.
4795
47961999-04-16 Toshiaki Takada <takada@zebra.org>
4797
4798 * ospfd.c: DEFUN (show_ip_ospf_interface) Added.
4799 * ospf_neighbor.c: ospf_nbr_count () Added.
4800
48011999-04-15 Toshiaki Takada <takada@zebra.org>
4802
4803 * ospfd.h: struct ospf { } Changed.
4804 * ospfd.c: ospf_lookup_by_process_id () Deleted.
4805 * ospf_ism.c: ospf_wait_timer () Added. WaitTimer will work.
4806
48071999-04-14 Toshiaki Takada <takada@zebra.org>
4808
4809 * ospf_ism.c: ospf_elect_dr () Added.
4810 * ospf_network.c: ospf_if_ipmulticast () Added.
4811
48121999-04-11 Toshiaki Takada <takada@zebra.org>
4813
4814 * ospf_interface.c: interface_config_write (),
4815 DEFUN (if_ip_ospf_cost),
4816 DEFUN (if_ip_ospf_dead_interval),
4817 DEFUN (if_ip_ospf_hello_interval),
4818 DEFUN (if_ip_ospf_priority),
4819 DEFUN (if_ip_ospf_retransmit_interval) and
4820 DEFUN (if_ip_ospf_transmit_delay) Added.
4821
48221999-04-08 Toshiaki Takada <takada@zebra.org>
4823
4824 * ospf_dump.c: ospf_packet_db_desc_dump () Added.
4825 * ospf_neighbor.c: ospf_nbr_bidirectional () Added.
4826 * ospf_nsm.c: nsm_twoway_received () Added.
4827
48281999-04-02 Toshiaki Takada <takada@zebra.org>
4829
4830 * ospf_neighbor.c: New file.
4831 * ospf_neighbor.h: New file.
4832 * ospf_nsm.c: New file.
4833 * ospf_nsm.h: New file.
4834 * ospf_packet.c: Add ospf_make_header (), ospf_hello () and
4835 ospf_hello_send (). Now OSPFd can receive Hello and send Hello.
4836
48371999-03-27 Kunihiro Ishiguro <kunihiro@zebra.org>
4838
4839 * ospf_packet.c: Add ospf_recv_packet (). Now OSPF Hello can receive.
4840
48411999-03-19 Toshiaki Takada <takada@zebra.org>
4842
4843 * ospf_packet.c: New file.
4844 * ospf_packet.h: New file.
4845 * ospf_network.c: New file.
4846 * ospf_network.h: New file.
4847 * ospfd.h: move OSPF message structure has moved to ospf_packet.h.
4848
48491999-03-17 Kunihiro Ishiguro <kunihiro@zebra.org>
4850
4851 * ospf_zebra.c (ospf_zebra_get_interface): Fix for IPv6 interface
4852 address.
4853
4854 * Makefile.am (install-sysconfDATA): Overwrite install-sysconfDATA
4855 for install ospfd.conf.sample as owner read only file.
4856
4857 * ospf_main.c (usage): Change to use ZEBRA_BUG_ADDRESS.
4858
48591999-03-15 Toshiaki Takada <takada@zebra.org>
4860
4861 * ospf_ism.c: New file.
4862 * ospf_ism.h: New file.
4863 * ospf_dump.c: New file.
4864 * ospf_dump.h: New file.
4865
4866 * ospfd.h: Add (struct ospf), (struct config_network),
4867 (struct message) structure.
4868
4869 * ospf_interface.c: Add ospf_if_match_network ().
4870 * ospf_interface.h (struct ospf_interface): Change struct members.
4871
4872 * ospfd.c: ospf_lookup_by_process_id (), ospf_network_new (),
4873 DEFUN (network_area): Added.
4874
4875 * ospfd.conf.sample: Change sample configuration.
4876
48771999-03-05 Toshiaki Takada <takada@zebra.org>
4878
4879 * ospf_interface.c: New file.
4880 * ospf_interface.h: New file.
4881 * ospf_zebra.h: New file.
4882 * ospf_zebra.c: Add interface function for zebra daemon.
4883 * ospfd.c: New file.
4884
48851999-02-23 Kunihiro Ishiguro <kunihiro@zebra.org>
4886
4887 * Move IPv6 codes and files to ospf6d directory.
4888
48891999-02-18 Peter Galbavy <Peter.Galbavy@knowledge.com>
4890
4891 * syslog support added
4892
48931998-12-22 Toshiaki Takada <takada@zebra.org>
4894
4895 * ospfd.h: New file.
4896 * ospf_lsa.h: New file.
4897
48981998-12-15 Kunihiro Ishiguro <kunihiro@zebra.org>
4899
4900 * Makefile.am: New file.
4901 * ospf_main.c: New file.
4902