blob: 777801c324f5bdf2998044f0e1954df77f566ec3 [file] [log] [blame]
Paul Jakma90b68762008-01-29 17:26:34 +000012008-01-29 Jorge Boncompte <jorge@dti2.net>
2
3 * bgp_network.c: (bgp_socket) IPv4-only version crashes if -l is not
4 used as address will be null.
5
Paul Jakma370b64a2007-12-22 16:49:52 +000062007-12-22 Paul Jakma <paul.jakma@sun.com>
7
8 * Fix series of vulnerabilities reported by "Mu Security
9 Research Team", where bgpd can be made to crash by sending
10 malformed packets - requires that bgpd be configured with a
11 session to the peer.
12 * bgp_attr.c: (bgp_attr_as4_path) aspath_parse may fail, only
13 set the attribute flag indicating AS4_PATH if we actually managed
14 to parse one.
15 (bgp_attr_munge_as4_attrs) Assert was too general, it is possible
16 to receive AS4_AGGREGATOR before AGGREGATOR.
17 (bgp_attr_parse) Check that we have actually received the extra
18 byte of header for Extended-Length attributes.
19 * bgp_attr.h: Fix BGP_ATTR_MIN_LEN to account for the length byte.
20 * bgp_open.c: (cap_minsizes) Fix size of CAPABILITY_CODE_RESTART,
21 incorrect -2 left in place from a development version of as4-path
22 patch.
23 * bgp_packet.c: (bgp_route_refresh_receive) ORF length parameter
24 needs to be properly sanity checked.
25
Denis Ovsienkoa7f93f32007-12-18 15:13:06 +0000262007-12-18 Denis Ovsienko
27
28 * bgp_routemap.c: (no_set_aspath_prepend) This command cancelled
29 existing "set" command regardless if "no set" matched it or not.
30 Fixed.
31
Paul Jakma7e992e92007-11-13 09:32:23 +0000322007-11-13 Paul Jakma <paul.jakma@sun.com>
33
34 * bgp_main.c: Small fix, format string parameters should never
35 be NULL - it's not strictly valid and some libc's don't let
36 you away with.
37
Paul Jakma3a02d1f2007-11-01 14:29:11 +0000382007-10-30 Nick Hilliard <nick@inex.ie>
39
40 * bgp_main.c: Add 'listenon' argument, to pass address to bind
41 to.
42 * bgp_network.c: (bgp_socket) Extend to take bind address.
43 * bgpd.c: (bgp_init) Pass stored address.
44 * bgpd.h: (struct bgp_master) storage for bind address
45
Paul Jakma0b2aa3a2007-10-14 22:32:21 +0000462007-09-27 Paul Jakma <paul.jakma@sun.com>
47
48 * bgp_aspath.c: (assegment_normalise) remove duplicates from
49 from sets.
50 (aspath_reconcile_as4) disregard a broken part of the RFC around
51 error handling in path reconciliation.
52
532007-09-25 Paul Jakma <paul.jakma@sun.com>
54
55 * bgp_open.c: (peek_for_as4_capability) Fix to work.
56 * bgp_packet.c: (bgp_open_receive) Fix sanity check of as4.
57
582007-09-18 Paul Jakma <paul.jakma@sun.com>
59
60 * bgp_open.c: (bgp_capability_as4) debug printf inline with others.
61 (peek_for_as4_capability) There's no need to signal failure, as
62 failure is better dealt with through full capability parser -
63 just return the AS4, simpler.
64 * bgp_packet.c: (bgp_open_receive) Update to match
65 peek_for_as4_capability change.
66 Allow use of BGP_AS_TRANS by 2b speakers.
67 Use NOTIFY_OPEN_ERR rather than CEASE for OPEN parsing errors.
68 (bgp_capability_msg_parse) missing argument to debug print
69 (bgp_capability_receive) missing return values.
70
71
722007-07-25 Paul Jakma <paul.jakma@sun.com>
73
74 * Remove 2-byte size macros, just make existing macros take
75 argument to indicate which size to use.
76 Adjust all users - typically they want '1'.
77 * bgp_aspath.c: (aspath_has_as4) New, return 1 if there are any
78 as4's in a path.
79 (aspath_put) Return the number of bytes actually written, to
80 fix the bug Juergen noted: Splitting of segments will change
81 the number of bytes written from that already written to the
82 AS_PATH header.
83 (aspath_snmp_pathseg) Pass 2-byte flag to aspath_put. SNMP
84 is still defined as 2b.
85 (aspath_aggregate) fix latent bug.
86 (aspath_reconcile_as4) AS_PATH+NEW_AS_PATH reconciliation
87 function.
88 (aspath_key_make) Hash the AS_PATH string, rather than
89 just taking the addition of assegment ASes as the hash value,
90 hopefully sligthly more collision resistant.
91 (bgp_attr_munge_as4_attrs) Collide the NEW_ attributes
92 together with the OLD 2-byte forms, code Juergen
93 had in bgp_attr_parse but re-organised a bit.
94 (bgp_attr_parse) Bunch of code from Juergen moves
95 to previous function.
96 (bgp_packet_attribute) Compact significantly by
97 just /always/ using extended-length attr header.
98 Fix bug Juergen noted, by using aspath_put's
99 (new) returned size value for the attr header rather
100 than the (guesstimate) of aspath_size() - the two could
101 differ when aspath_put had to split large segments, unlikely
102 this bug was ever hit in the 'wild'.
103 (bgp_dump_routes_attr) Always use extended-len and
104 use aspath_put return for header length. Output 4b ASN
105 for AS_PATH and AGGREGATOR.
106 * bgp_ecommunity.c: (ecommunity_{hash_make,cmp}) fix
107 hash callback declarations to match prototypes.
108 (ecommunity_gettoken) Updated for ECOMMUNITY_ENCODE_AS4,
109 complete rewrite of Juergen's changes (no asdot support)
110 * bgp_open.c: (bgp_capability_as4) New, does what it says
111 on the tin.
112 (peek_for_as4_capability) Rewritten to use streams and
113 bgp_capability_as4.
114 * bgp_packet.c: (bgp_open_send) minor edit
115 checked (in the abstract at least) with Juergen.
116 Changes are to be more accepting, e.g, allow AS_TRANS on
117 a 2-byte session.
118 * (general) Update all commands to use CMD_AS_RANGE.
119 * bgp_vty.c: (bgp_clear) Fix return vals to use CMD_..
120 Remove stuff replicated by VTY_GET_LONG
121 (bgp_clear_vty) Return bgp_clear directly to vty.
122
123
1242007-07-25 Juergen Kammer <j.kammer@eurodata.de>
125
126 * (general) AS4 support.
127 * bgpd.h: as_t changes to 4-bytes.
128 * bgp_aspath.h: Add BGP_AS4_MAX and BGP_AS_TRANS defines.
129 * bgp_aspath.c: AS_VALUE_SIZE becomes 4-byte, AS16_VALUE_SIZE
130 added for 2-byte.
131 Add AS16 versions of length calc macros.
132 (aspath_count_numas) New, count number of ASes.
133 (aspath_has_as4) New, return 1 if there are any as4's in a
134 path.
135 (assegments_parse) Interpret assegment as 4 or 2 byte,
136 according to how the caller instructs us, with a new
137 argument.
138 (aspath_parse) Add use32bit argument to pass to
139 assegments_parse. Adjust all its callers to pass 1, unless
140 otherwise noted.
141 (assegment_data_put) Adjust to be able to write 2 or 4 byte
142 AS, according to new use32bit argument.
143 (aspath_put) Adjust to write 2 or 4.
144 (aspath_gettoken) Use a long for passed in asno.
145 * bgp_attr.c: (attr_str) Add BGP_ATTR_AS4_PATH and
146 BGP_ATTR_AS4_AGGREGATOR.
147 (bgp_attr_aspath) Call aspath_parse with right 2/4 arg, as
148 determined by received-capability flag.
149 (bgp_attr_aspath_check) New, code previously in attr_aspath
150 but moved to new func so it can be run after NEW_AS_PATH
151 reconciliation.
152 (bgp_attr_as4_path) New, handle NEW_AS_PATH.
153 (bgp_attr_aggregator) Adjust to cope with 2/4 byte ASes.
154 (bgp_attr_as4_aggregator) New, read NEW_AGGREGATOR.
155 (bgp_attr_parse) Add handoffs to previous parsers for the two
156 new AS4 NEW_ attributes.
157 Various checks added for NEW/OLD reconciliation.
158 (bgp_packet_attribute) Support 2/4 for AS_PATH and
159 AGGREGATOR, detect when NEW_ attrs need to be sent.
160 * bgp_debug.{c,h}: Add 'debug bgp as4'.
161 * bgp_dump.c: MRTv2 support, unconditionally enabled, which
162 supports AS4. Based on patches from Erik (RIPE?).
163 * bgp_ecommunity.c: (ecommunity_ecom2str) ECOMMUNITY_ENCODE_AS4
164 support.
165 * bgp_open.c: (peek_for_as4_capability) New, peek for AS4
166 capability prior to full capability parsing, so we know which
167 ASN to use for struct peer lookup.
168 (bgp_open_capability) Always send AS4 capability.
169 * bgp_packet.c: (bgp_open_send) AS4 handling for AS field
170 (bgp_open_receive) Peek for AS4 capability first, and figure
171 out which AS to believe.
172 * bgp_vty.c: (bgp_show_peer) Print AS4 cap
173
Paul Jakmae08286b2007-09-18 12:11:26 +00001742007-09-17 Paul Jakma <paul.jakma@sun.com>
175
176 * bgp_open.c: (bgp_capability_mp) We were setting
177 afc_nego[safi][safi] rather than afc_nego[afi][safi], thus
178 failling to announce any non-IPv4 prefixes. Remove the extra,
179 typo-ed character.
180
Paul Jakmab2ceea12007-09-07 14:24:55 +00001812007-09-07 Paul Jakma <paul.jakma@sun.com>
182
183 * (general) bgpd can be made crash by remote peers if debug
184 bgp updates is set, due to NULL pointer dereference.
185 Reported by "Mu Security Research Team",
186 <security@musecurity.com>.
187 * bgp_attr.c: (bgp_attr_community) If community length is 0,
188 don't set the community-present attribute bit, just return
189 early.
190 * bgp_debug.c: (community_str,community_com2str) Check com
191 pointer before dereferencing.
192
Paul Jakma9eda90c2007-08-30 13:36:17 +00001932007-08-27 Paul Jakma <paul.jakma@sun.com>
194
195 * bgp_route.c: (bgp_announce_check) Fix bug #398, slight
196 modification of Vladimir Ivanov's suggested fix - to keep
197 memory alloc conditional.
198 (bgp_process_announce_selected) Don't take struct attr as
199 argument, none of the callers need it and it needlessly
200 distances allocation from use.
201 Free the extended attr, the attr itself is on the stack.
202 Fix bad indentation.
203 * bgp_attr.c: (bgp_packet_attribute) Remove incorrect assert,
204 and adjust conditional to test attr->extra, diagnosis by
205 Vladimir Ivanov in bug #398.
206
2072007-08-27 Vladimir Ivanov <wawa@yandex-team.ru>
208
209 * bgp_route.c: (bgp_announce_check_rsclient) copy of
210 ri->attr is no longer deep enough, due to addition of
211 attr->extra. It should use bgp_attr_dup, as
212 bgp_announce_check() does.
213
Paul Jakma6d134fb2007-08-23 23:22:02 +00002142007-08-23 Paul Jakma <paul.jakma@sun.com>
215
216 * bgp_regex.c: (bgp_regcomp) Pass NOSUB flag to regcomp to
217 prevent parsing of substitutions, which can have profound
218 performance effects on bgpd and are of no use to the CLI
219 anyway. How much it helps depends on the regex
220 implementation.
221
Paul Jakma41367172007-08-06 15:24:51 +00002222007-07-31 Paul Jakma <paul.jakma@sun.com>
223
224 * (general) Support for draft-ietf-idr-as-pathlimit-03.
225 * bgp_attr.h: (struct attr) Add pathlimit struct
226 bgp_attr.c: (attr_str) Add BGP_ATTR_AS_PATHLIMIT string.
227 (attrhash_key_make) tally pathlimit too
228 (attrhash_cmp) cmp pathlimit attr
229 (bgp_attr_aspathlimit) New, parse AS_PATHLIMIT attr.
230 (bgp_attr_parse) ditto
231 (bgp_packet_attribute) Write out AS_PATHLIMIT when set
232 (bgp_dump_routes_attr) ditto
233 * bgp_route.h: (struct bgp_static) Add TTL field
234 * bgp_route.c: (bgp_announce_check) Drop paths that are over
235 their hop-count TTL before sending via EBGP.
236 Mangle ASN in pathlimit for confeds/private as best we can.
237 (bgp_static_update_{rsclient,main}) Add any configure pathlimit
238 information.
239 (bgp_pathlimit_update_parents) New, update atomic-aggr setting for
240 parents of an aspathlimit'ed static.
241 (bgp_static_set) Add TTL argument, for all the 'bgp network'
242 commands.
243 Call previous for TTL changed statics.
244 (bgp_static_unset) Call pathlimit_update_parents.
245 (various bgp network commands) Add 'pathlimit <0-255>' qualifier
246 to all the various forms, bar route-map - which can set ttl
247 itself.
248 * bgp_routemap.c: (general) Add support for 'set pathlimit ttl' and
249 'match pathlimit as'.
250
Paul Jakma6d582722007-08-06 15:21:45 +00002512007-07-26 Paul Jakma <paul.jakma@sun.com>
252
253 * (general) Clean up and compact capability parsing slightly.
254 Consolidate validation of length and logging of generic TLV, and
255 memcpy of capability data, thus removing such from cap specifc
256 code (not always present or correct).
257 * bgp_open.h: Add structures for the generic capability TLV header
258 and for the data formats of the various specific capabilities we
259 support. Hence remove the badly named, or else misdefined, struct
260 capability.
261 * bgp_open.c: (bgp_capability_vty_out) Use struct capability_mp_data.
262 Do the length checks *before* memcpy()'ing based on that length
263 (stored capability - should have been validated anyway on input,
264 but..).
265 (bgp_afi_safi_valid_indices) new function to validate (afi,safi)
266 which is about to be used as index into arrays, consolidates
267 several instances of same, at least one of which appeared to be
268 incomplete..
269 (bgp_capability_mp) Much condensed.
270 (bgp_capability_orf_entry) New, process one ORF entry
271 (bgp_capability_orf) Condensed. Fixed to process all ORF entries.
272 (bgp_capability_restart) Condensed, and fixed to use a
273 cap-specific type, rather than abusing capability_mp.
274 (struct message capcode_str) added to aid generic logging.
275 (size_t cap_minsizes[]) added to aid generic validation of
276 capability length field.
277 (bgp_capability_parse) Generic logging and validation of TLV
278 consolidated here. Code compacted as much as possible.
279 * bgp_packet.c: (bgp_open_receive) Capability parsers now use
280 streams, so no more need here to manually fudge the input stream
281 getp.
282 (bgp_capability_msg_parse) use struct capability_mp_data. Validate
283 lengths /before/ memcpy. Use bgp_afi_safi_valid_indices.
284 (bgp_capability_receive) Exported for use by test harness.
285 * bgp_vty.c: (bgp_show_summary) fix conversion warning
286 (bgp_show_peer) ditto
287 * bgp_debug.h: Fix storage 'extern' after type 'const'.
288
Paul Jakma45ad5922007-07-31 17:35:36 +00002892007-07-31 Lorenzo Colitti <lorenzo@colitti.com>
290
291 * bgp_dump.c: (general) Add comments to code.
292 (bgp_dump_interval_add) remove some redundant lines.
293 (bgp_dump_set) Use enum for type argument.
294 Avoid scheduling dump twice if exact same command
295 is given twice..
296
Paul Jakma536792c2007-06-22 19:11:14 +00002972007-06-22 Paul Jakma <paul.jakma@sun.com>
298
299 * bgp_fsm.c: (struct FSM) Bug #368. TCP Errors during OpenSent
300 should cycle to Active, not to Idle or else peer bringup can
301 race and cycle Idle<->Active. Reported and fix tested by
302 Mukesh Agrawal.
303
Paul Jakmab2497022007-06-14 11:17:58 +00003042007-05-25 Paul Jakma <paul.jakma@sun.com>
305
306 * bgp_route.c: (bgp_default_originate) Sanity check added
307 previously was broken and always failed, thus this function
308 never could run, bug #370.
309
Paul Jakmafb982c22007-05-04 20:15:47 +00003102007-05-03 Paul Jakma <paul.jakma@sun.com>
Paul Jakma923de652007-04-29 18:25:17 +0000311
Paul Jakmafb982c22007-05-04 20:15:47 +0000312 * bgp_route.h: (struct info) Move less frequently used
313 fields to a lazily allocated struct info_extra.
314 Export bgp_info_extra_get
315 * bgp_route.c: (bgp_info_extra_new) allocate extra
316 (bgp_info_extra_free) Free damp info and the info_extra.
317 (bgp_info_extra_get) Retrieve the info_extra of a struct
318 info, allocating as required.
319 (generally) adjust to use info->extra
320 * bgp_damp.c: (generally) use bgp_info_extra_get to access
321 dampinfo
322 * bgp_attr.h: Move rarely allocated attributes from struct attr
323 to a struct attr_extra, for a substantial saving in size of
324 struct attr.
325 * bgp_attr.c: (bgp_attr_extra_{new,free}), new, self-explanatory.
326 (bgp_attr_extra_get) Get the attr_extra for a given struct
327 attr, allocating it if needs be.
328 (bgp_attr_dup) Shallow copy the struct attr and its attr_extra.
329 (generally) adjust to know about attr->extra.
330 * bgp_debug.c: (bgp_dump_attr) ditto
331 * bgp_vty.c: (show_bgp_memory) print attr and info extra sizes.
332 * bgp_nexthop.c: (generally) adjust to know about attr->extra
333 and info->extra.
334 * bgp_{packet,routemap,snmp,zebra}.c: ditto
335
3362007-04-22 Sebastien Tandel <sebastien@tandel.be>
Paul Jakma923de652007-04-29 18:25:17 +0000337 * bgp_advertise.c : (baa_hash_alloc, baa_hash_key, baa_hash_cmp)
338 conforms to quagga hash API. Defines _hash_[alloc|key|cmp] with
339 void * arguments as defined by the API.
340 * bgp_aspath.c,h : (aspath_key_make) conforms to quagga hash API.
341 Defines _hash_[alloc|key|cmp] with void * arguments as defined by
342 the API.
343 * bgp_attr.c,h : (cluster_hash_alloc, cluster_hash_key_make,
344 cluster_hash_cmp, transit_hash_alloc, transit_hash_key_make,
345 transit_hash_cmp, attrhash_key_make, attrhash_cmp,
346 bgp_attr_hash_alloc) conforms to quagga hash API. Defines
347 _hash_[alloc|key|cmp] with void * arguments as defined by the API.
Paul Jakma03e214c2007-04-29 18:31:07 +0000348 * bgp_attr.h : Definition of BGP_ATTR_DEFAULT_WEIGHT.
349 * bgp_attr.c : (bgp_attr_default_intern) now uses
350 bgp_attr_default_set instead of duplicating the same code.
351 (general) Use of BGP_ATTR_DEFAULT_WEIGHT. Replace two 16 by
352 IPV6_MAX_BYTELEN.
Paul Jakma923de652007-04-29 18:25:17 +0000353
Andrew J. Schorr93c17492007-04-15 19:17:24 +00003542007-04-15 Sebastien Tandel <sebastien@tandel.be>
355
356 * bgp_aspath.c: (aspath_as_add, aspath_segment_add) Minor performance
357 optimization: while loop should test one pointer instead of two.
358
Paul Jakma16d2e242007-04-10 19:32:10 +00003592007-04-08 Paul Jakma <paul.jakma@sun.com>
360
361 * bgp_route.c: (general) Same bug as fixed on 2006-11-28 by ajs for
362 bgp static routes, but for main BGP RIB: Quick 'flap' of routes
363 can cause bgpd to mistake a new route for a duplicate route,
364 due to presence of removed, but not yet processed BGP RIB entry.
365 (bgp_update_rsclient) Ignore REMOVED bgp_info for duplicate,
366 restore route instead.
367 (bgp_update_main) Ditto.
Paul Jakma6e4ab122007-04-10 19:36:48 +0000368 * bgp_attr.c: (general) Bug #354: parsing of MP_REACH_NLRI and
369 MP_UNREACH_NLRI does not take sufficient care to ensure reads
370 from stream buffer stay in-bounds. Hence bgpd may attempt to read
371 beyond end of stream, if given a crafted packet. As it uses the
372 stream access methods to do so, this will typically result in
373 assert() being hit in stream.c. Where code is compiled without
374 assert() enabled, result is unknown.
375 (struct message attr_str) should be static.
376 (bgp_mp_reach_parse) Carefully check length remaining in stream
377 against amount desired to read from stream, prior to each read,
378 particularly where lengths are conditional on data obtained from
379 stream - using STREAM_READABLE.
380 Remove code to parse SNPA-number, it's a defunct field and changed
381 to a fixed size in latest BGP MP update RFC - log warning if
382 SNPA-number is not 0.
383 (bgp_mp_unreach_parse) Check withdraw_length carefully against
384 STREAM_READABLE.
385 (bgp_attr_parse) If attribute-parser function returns error, log
386 warning.
387 Log attribute type on mismatch.
Paul Jakma16d2e242007-04-10 19:32:10 +0000388
Paul Jakma37a217a2007-04-10 19:20:29 +00003892007-04-07 Paul Jakma <paul.jakma@sun.com>
390
391 * bgpd.c: (general) Fix bug #352
392 (bgp_config_write_family_header) write ipv6/multicast
393 address family header.
394 (bgp_config_write) write out ipv6 multicast AF config.
395
Paul Jakmaf2c31ac2007-02-22 17:48:42 +00003962007-02-22 Paul Jakma <paul.jakma@sun.com>
397
398 * bgp_fsm.c: (bgp_fsm_change_status) Handle state change into
399 clearing or greater here. Simpler.
400 (bgp_event) Clearing state change work moved to previous
401 * bgp_route.c: (bgp_clear_route_node) Clearing adj-in here
402 is too late, as it leaves a race between a peer being deleted
403 and an identical peer being configured before clearing
404 completes, leading to a crash.
405 Simplest fix is to clean peers Adj-in up-front, rather than
406 queueing such work.
407 (bgp_clear_route_table) Clear peer's Adj-In and Adj-Out
408 up-front here, rather than queueing such work.
409 Extensive comment added on the various bits of indexed data
410 that exist and how they need to be dealt with.
411 (bgp_clear_route) Update comment.
412
Andrew J. Schorre4529632006-12-12 19:18:21 +00004132006-12-12 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
414
415 * bgp_nexthop.c: (bgp_connected_add, bgp_connected_delete)
416 Simplify logic by using new CONNECTED_PREFIX macro.
417
Paul Jakma95fdcd82006-12-08 00:31:22 +00004182006-12-07 Paul Jakma <paul.jakma@sun.com>
419
420 * bgp_fsm.c: Bug #302 fix, diagnosis, suggestions and testing
421 by Juergen Kammer <j.kammer@eurodata.de>. Fix follows from
422 his suggested fix, just made in a slightly different way.
423 (bgp_event) Transitions into Clearing always must call
424 bgp_clear_route_all().
425 (bgp_stop) No need to clear routes here, BGP FSM should do
426 it.
427
Andrew J. Schorra39275d2006-11-30 16:36:57 +00004282006-11-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
429
430 * bgp_debug.h: Declare new bgp_debug_zebra conf and term flags,
431 and define BGP_DEBUG_ZEBRA.
432 * bgp_debug.c: Declare conf_bgp_debug_zebra and term_bgp_debug_zebra.
433 (debug_bgp_zebra, no_debug_bgp_zebra, undebug_bgp_zebra) New
434 functions to enable/disable bgp zebra debugging.
435 (no_debug_bgp_all) Turn off zebra debugging.
436 (show_debugging_bgp) Show whether zebra debugging is on.
437 (bgp_config_write_debug) Add 'debug bgp zebra' if configured.
438 (bgp_debug_init) Add new zebra debugging commands.
439 * bgp_zebra.c: (bgp_router_id_update, bgp_interface_add,
440 bgp_interface_delete, bgp_interface_up, bgp_interface_down,
441 bgp_interface_address_add, bgp_interface_address_delete,
442 zebra_read_ipv4, zebra_read_ipv6, bgp_zebra_announce,
443 bgp_zebra_withdraw, bgp_redistribute_set, bgp_redistribute_unset)
444 If zebra debugging is enabled, log an appropriate debug message.
445
Andrew J. Schorr8d452102006-11-28 19:50:46 +00004462006-11-28 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
447
448 * bgp_route.c: (bgp_info_restore) New function that undoes
449 the effects of a previous call to bgp_info_delete. This is
450 used when a route is deleted and quickly re-added before the
451 deletion has been processed.
452 (bgp_static_update_rsclient, bgp_static_update_main,
453 bgp_redistribute_add) Check whether a pre-existing route
454 has the BGP_INFO_REMOVED set, and, if so, we need to call
455 bgp_info_restore to resurrect it.
456
Paul Jakma56395af2006-10-27 16:58:20 +00004572006-10-27 Paul Jakma <paul.jakma@sun.com>
458
459 * bgp_route.c: (bgp_table_stats) oops, u_intXX_t should be
460 uintXX_t
461
Paul Jakma6f585442006-10-22 19:13:07 +00004622006-10-19 Paul Jakma <paul.jakma@sun.com>
463
464 * bgpd.c: (peer_new) bgp element of peer absolutely must be
465 filled in, make peer_new() require it as argument and update
466 all callers. Fixes a crash reported by Jan 'yanek' Bortl and
467 Andrew Schorr where bgpd would crash in bgp_pcount_adjust
468 trying to dereference the bgp member of bgp->peer_self,
469 triggered through redistribution.
470 * bgp_route.c: (bgp_pcount_adjust) assert sanity of arguments.
471
Paul Jakma53d9f672006-10-15 23:41:16 +00004722006-10-15 Paul Jakma <paul.jakma@sun.com>
473
474 * bgp_route.c: (bgp_table_stats_walker) NULL deref if table is
475 empty, bgp_table_top may return NULL, Coverity CID#73.
Paul Jakmaed3ebfa2006-10-15 23:50:16 +0000476 * bgp_packet.c: (bgp_update_packet) adv->rn can not be NULL,
477 check is bogus - changed to assert(), CID#64.
478 binfo is checked for NULL, but then dereferenced
479 unconditionally, fix, CID #63.
480 (bgp_withdraw_packet) Assert adv->rn is valid, as with
481 bgp_update_packet().
Paul Jakma53d9f672006-10-15 23:41:16 +0000482
Paul Jakmadcdf3992006-10-15 23:39:59 +00004832006-10-14 Paul Jakma <paul.jakma@sun.com>
484
485 * bgp_fsm.h: Remove BGP_EVENT_FLUSH_ADD, dangerous and not
486 needed.
487 * bgp_fsm.c: (bgp_stop) Move BGP_EVENT_FLUSH to the top of the
488 of the function, otherwise it could flush a ClearingCompleted
489 event, bug #302.
490 * bgp_packet.c: Replace all BGP_EVENT_FLUSH_ADD with
491 BGP_EVENT_ADD, fixing bug #302.
492
Andrew J. Schorr0cd1c322006-09-19 18:51:53 +00004932006-09-19 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
494
495 * bgpd.c: (peer_uptime) Fix printf format/arg mismatch in
496 zlog_warn message (%ld/size_t -> %lu/u_long).
497
Paul Jakmaca058a32006-09-14 02:58:49 +00004982006-09-14 Paul Jakma <paul.jakma@sun.com>
499
Paul Jakma8383a9b2006-09-14 03:06:54 +0000500 * bgp_route.c: (bgp_table_stats_walker) Address space announced
501 should only count top-level unaggregateable prefixes, to
502 avoid falling afoul of anti-dodgy-accounting regulations
503 in various jurisdictions.. ;)
Paul Jakma09dd5612006-09-14 03:38:16 +0000504 (bgp_process_queue_init) process queue hold time too high,
505 adds extra memory load. Change to be much lower, until such
506 time as it's made configurable.
Paul Jakma8383a9b2006-09-14 03:06:54 +0000507
5082006-09-14 Paul Jakma <paul.jakma@sun.com>
509
Paul Jakma9fde6622006-09-14 03:02:02 +0000510 * (general) fix the peer refcount issue exposed by previous, by
511 just removing refcounting of peer threads, which is mostly
512 senseless as they're references leading from struct peer,
513 which peer_free cancels anyway. No need to muck around..
514 * bgp_fsm.h: Just remove the refcounting from the various
515 TIMER/READ/WRITE/EVENT ON/OFF/ADD macros.
516 * bgp_fsm.c: (bgp_stop) use BGP_EVENT_FLUSH, no refcounts attached
517 to events anymore.
518 (bgp_event) remove peer_unlock, events not refcounted.
519 * bgpd.c: (peer_free) flush events before free.
520
5212006-09-14 Paul Jakma <paul.jakma@sun.com>
522
Paul Jakmaca058a32006-09-14 02:58:49 +0000523 * (general) Fix some niggly issues around 'shutdown' and clearing
524 by adding a Clearing FSM wait-state and a hidden 'Deleted'
525 FSM state, to allow deleted peers to 'cool off' and hit 0
526 references. This introduces a slow memory leak of struct peer,
527 however that's more a testament to the fragility of the
528 reference counting than a bug in this patch, cleanup of
529 reference counting to fix this is to follow.
530 * bgpd.h: Add Clearing, Deleted states and Clearing_Completed
531 and event.
532 * bgp_debug.c: (bgp_status_msg[]) Add strings for Clearing and
533 Deleted.
534 * bgp_fsm.h: Don't allow timer/event threads to set anything
535 for Deleted peers.
536 * bgp_fsm.c: (bgp_timer_set) Add Clearing and Deleted. Deleted
537 needs to stop everything.
538 (bgp_stop) Remove explicit fsm_change_status call, the
539 general framework handles the transition.
540 (bgp_start) Log a warning if a start is attempted on a peer
541 that should stay down, trying to start a peer.
542 (struct .. FSM) Add Clearing_Completed
543 events, has little influence except when in state
544 Clearing to signal wait-state can end.
545 Add Clearing and Deleted states, former is a wait-state,
546 latter is a placeholder state to allow peers to disappear
547 quietly once refcounts settle.
548 (bgp_event) Try reduce verbosity of FSM state-change debug,
549 changes to same state are not interesting (Established->Established)
550 Allow NULL action functions in FSM.
551 * bgp_packet.c: (bgp_write) Use FSM events, rather than trying
552 to twiddle directly with FSM state behind the back of FSM.
553 (bgp_write_notify) ditto.
554 (bgp_read) Remove the vague ACCEPT_PEER peer_unlock, or else
555 this patch crashes, now it leaks instead.
556 * bgp_route.c: (bgp_clear_node_complete) Clearing_Completed
557 event, to end clearing.
558 (bgp_clear_route) See extensive comments.
559 * bgpd.c: (peer_free) should only be called while in Deleted,
560 peer refcounting controls when peer_free is called.
561 bgp_sync_delete should be here, not in peer_delete.
562 (peer_delete) Initiate delete.
563 Transition to Deleted state manually.
564 When removing peer from indices that provide visibility of it,
565 take great care to be idempotent wrt the reference counting
566 of struct peer through those indices.
567 Use bgp_timer_set, rather than replicating.
568 Call to bgp_sync_delete isn't appropriate here, sync can be
569 referenced while shutting down and finishing deletion.
570 (peer_group_bind) Take care to be idempotent wrt list references
571 indexing peers.
572
Paul Jakma2815e612006-09-14 02:56:07 +00005732006-09-13 Paul Jakma <paul.jakma@sun.com>
574
575 * bgp_aspath.c: (aspath_highest) new, return highest ASN in an
576 aspath.
577 * bgp_route.c: (bgp_peer_count_walker) new, do the walk done
578 in bgp_peer_counts as a thread.
579 (bgp_peer_counts) move walk to previous and call it via
580 thread_execute so this RIB walk shows up in thread stats.
581 (bgp_table_stats) New, gather some statistics for a given
582 RIB.
583 (bgp_table_stats_walker) New, RIB walker thread for former.
584 (bgp_table_stats_vty) Parsing front-end for 'show bgp ...',
585 useful model for future rationalisation of 'show ... bgp'.
586 (bgp_route_init) Add new RIB stats commands.
587
Paul Jakma1a392d42006-09-07 00:24:49 +00005882006-09-06 Paul Jakma <paul.jakma@sun.com>
589
590 * (general) Squash any and all prefix-count issues by
591 abstracting route flag changes, and maintaining count as and
592 when flags are modified (rather than relying on explicit
593 modifications of count being sprinkled in just the right
594 places throughout the code).
595 * bgp_route.c: (bgp_pcount_{dec,inc}rement) removed.
596 (bgp_pcount_adjust) new, update prefix count as
597 needed for a given route.
598 (bgp_info_{uns,s}et_flag) set/unset a BGP_INFO route status
599 flag, calling previous function when appropriate.
600 (general) Update all set/unsets of flags to use previous.
601 Remove pcount_{dec,inc}rement calls.
602 No need to unset BGP_INFO_VALID in places where
603 bgp_info_delete is called, it does that anyway.
604 * bgp_{damp,nexthop}.c: Update to use bgp_info_{un,}set_flag.
605 * bgp_route.h: Export bgp_info_{un,}set_flag.
606 Add a 'meta' BGP_INFO flag, BGP_INFO_UNUSEABLE.
607 Move BGP_INFO_HOLDDOWN macro to here from bgpd.h
608
Paul Jakmaff7924f2006-09-04 01:10:36 +00006092006-09-03 Paul Jakma <paul.jakma@sun.com>
610
611 * bgp_route.c: Add 'show ... bgp ... <neighbour> prefix-count'
612 commands, to provide detailed counts of prefixes for a peer.
613 Informative, and should help pin down to pfxcnt drift
614 problems.
615
Paul Jakma9f906c72006-08-27 06:57:47 +00006162006-08-27 Paul Jakma <paul.jakma@sun.com>
617
618 * bgp_advertise.c: (bgp_sync_delete) fix mtype in XFREE.
619 NULL out peer->hash after free, to be sure.
620
Paul Jakma1f742f22006-08-06 15:52:11 +00006212006-08-06 Paul Jakma <paul.jakma@sun.com>
622
623 * bgp_aspath.c: (aspath_loop_check) Fix the typo-bug which
624 essentially had disabled this check. Problem reported by
625 Bartek Kania <mrbk@gnarf.org> in [quagga-users 7388].
626
Paul Jakma18937402006-07-27 19:05:12 +00006272006-07-27 Paul Jakma <paul.jakma@sun.com>
628
629 * bgpd.c: (peer_delete) Ensure freed buffers can not be
630 accidently reused. A potential fix for bug #287.
631
Paul Jakma33d5ab92006-07-02 11:01:50 +00006322006-07-02 Paul Jakma <paul.jakma@sun.com>
633
634 * bgp_fsm.c: (bgp_{stop,start}) Move clear/free of certain
635 bits of state from stop to start, as they may be used via
636 peer references on clearing queues..
637
Paul Jakma369688c2006-05-23 22:27:55 +00006382006-05-23 Paul Jakma <paul.jakma@sun.com>
639
640 * bgp_vty.c: (neighbor_update_source_cmd) Expand tab completion
641 to make it clear it takes both address and ifname.
642
Paul Jakma34c3f812006-05-12 23:25:37 +00006432006-05-12 Paul Jakma <paul.jakma@sun.com>
644
645 * bgp_attr.c: (bgp_packet_attribute) Remove dead code, Coverity
646 CID #1
Paul Jakmab2518c12006-05-12 23:48:40 +0000647 * bgp_aspath.{c,h}: (aspath_print_vty) take a format string,
648 so as to reduce burden on callers, all in bgp_route.c
Paul Jakmadd8103a2006-05-12 23:27:30 +0000649 * bgp_route.c: (bgp_static_update_main) Remove useless NULL
650 check, code already assumes bgp_static can not be NULL,
651 fixes CID #7.
Paul Jakma06e110f2006-05-12 23:29:22 +0000652 (bgp_static_update_rsclient) ditto, CID #6
Paul Jakmab2518c12006-05-12 23:48:40 +0000653 (route_vty_out{,tmp}) Update to match aspath_print_vty,
654 simplifying checks needed to get spacing right. CID #4,#5.
655 ({damp,flap}_route_vty_out) Ditto, CID #9, #10
Paul Jakma34c3f812006-05-12 23:25:37 +0000656
Paul Jakma542bcb72006-05-08 14:25:09 +00006572006-05-08 Paul Jakma <paul.jakma@sun.com>
658
659 * bgp_community.c: (community_str2com) Coverity CID#62, fix
660 double-free, use-after-free.
Paul Jakmada5b30f2006-05-08 14:37:17 +0000661 * bgp_route.c: (bgp_afi_node_get) given table should never be
662 NULL, check/assert this.
663 (bgp_static_update) Bug #240. Rsclients should only be passed
664 the static update if they are configured for the afi,safi.
Paul Jakma542bcb72006-05-08 14:25:09 +0000665
Paul Jakmaa3b6ea52006-05-04 07:52:12 +00006662006-05-04 Paul Jakma <paul.jakma@sun.com>
667
668 * (general) VPNv4 fixes. Certain VPNv4 code was not enabled.
669 See bug #210.
670 * bgp_attr.{c,h}: (bgp_packet_{withdraw,attribute}) Tag should be
671 u_char really.
672 * bgp_packet.c: (bgp_{update,withdraw}_packet) Enable some
673 VPNv4 code which inexplicably was ifdef'd out. comments from
674 a tester on IRC suggest this fixes bug #210.
Paul Jakma65ca75e2006-05-04 08:08:15 +0000675 * bgp_route.c: (general) Fix logical bug in clearing, noted
676 by Chris Caputo in [quagga-users 6728] - clearing depended on
677 at least one route being added to workqueue, in order for
678 workqueue completion function to restart FSM. However, if no
679 routes are cleared, then the completion function never is
680 called, it needs to be called manually if the workqueue
681 didn't get scheduled.
682 Finally, clearing is per-peer-session, not per AFI/SAFI, so
683 the FSM synchronisation should be in bgp_clear_route_table.
684 (bgp_clear_route_table) Wrong place for FSM/clearing
685 synchronisation, move to..
686 (bgp_clear_route) FSM/clearing synchronisation should be
687 here.
688 If no routes were cleared, no workqueue scheduled, call
689 the completion func to ensure FSM kicks off again.
Paul Jakmaa3b6ea52006-05-04 07:52:12 +0000690
Paul Jakma15aa6a12006-03-30 14:39:35 +00006912006-03-30 Paul Jakma <paul.jakma@sun.com>
692
693 * bgp_community.c: (community_gettoken) Unknown token should
694 return NULL, to give a strong indication to callers that
695 the token no longer can be parsed, otherwise callers looping
696 on this function may have a hard time ending their loop.
697 (community_str2com) While loop around community_gettoken appears
698 to have been coded thinking that break statement would break
699 from the while{}, hence it could never exit for unknown token
700 case. Fix it to do..while, so it can use the NULL result from
701 community_gettoken easily.
702
Paul Jakmaa625ca32006-03-30 14:12:38 +00007032006-03-22 Paul Jakma <paul.jakma@sun.com>
704
705 * bgpd.c: (peer_free) release the per-peer workqueue when
706 freeing the peer.
707
Paul Jakma5304cb52006-03-30 14:01:14 +00007082006-03-19 Paul Jakma <paul.jakma@sun.com>
709
Paul Jakma4bf6a362006-03-30 14:05:23 +0000710 * bgpd/bgp_vty.c: Add includes to get several structs we want
711 to provide usage statistics on.
712 (show_bgp_memory_cmd) Show memory usage stats for various
713 notable fixed size objects. Using mtype_stats_alloc and
714 mtype_memstr recently added to memory.c.
715 (bgp_show_summary) Report some additional stats specific to
716 the given BGP instance and/or AFI/SAFI such as table counts,
717 peers, rsclients and peer-groups.
718 (bgp_vty_init) Install show_bgp_memory_cmd.
Paul Jakma5304cb52006-03-30 14:01:14 +0000719 * bgp_nexthop.h: Include if.h as a dependent header, for struct
720 connected.
Paul Jakmab51f1262006-03-30 14:09:38 +0000721 * bgp_advertise.c: Use a distinct memory type for struct
722 bgp_synchronize.
Paul Jakma5304cb52006-03-30 14:01:14 +0000723
Paul Jakmacbdfbaa2006-03-30 13:20:48 +00007242006-03-12 Paul Jakma <paul.jakma@sun.com>
725
726 * bgp_attr.h: (struct attr) rearrange fields to avoid
727 wasted padding between them as much as possible.
728 (attr_count,attr_unknown_count) export new functions to
729 return number of counts of cached attributes.
730 * bgp_attr.c: (attr_count,attr_unknown_count) new functions to
731 return number of counts of cached attributes.
732 * bgp_route.h: (struct bgp_info) rearrange fields to avoid
733 wasted padding.
734 * bgp_table.h: (struct bgp_table) Add a count field, of number
735 of nodes in the table.
736 (struct bgp_node) rearrange fields to avoid
737 wasted padding between them, though I don't think there
738 was any in this case.
739 * bgp_table.c: (bgp_node_{delete,get}) Maintain the table node count.
740 (bgp_table_count) new function to access the table count.
741
Paul Jakma3e0c78e2006-03-06 18:06:53 +00007422006-03-03 Paul Jakma <paul.jakma@sun.com>
743
744 * bgp_route.c: (bgp_clear_node_complete) Doh. When clearing
745 is complete we need to kick off FSM again.
746
Paul Jakma64e580a2006-02-21 01:09:01 +00007472006-02-21 Paul Jakma <paul.jakma@sun.com>
748
749 * bgpd.h: move the clear_node_queue to be peer specific.
750 Add a new peer status flag, PEER_STATUS_CLEARING.
751 * bgp_table.h: (struct bgp_table) Add fields to record afi,
752 safi of the table.
753 (bgp_table_init) Take afi and safi to create table for.
754 * bgp_table.c: (bgp_table_init) record the afi and safi.
755 * bgp_nexthop.c: Update all calls to bgp_table_init.
756 * bgp_vty.c: ditto.
757 * bgpd.c: ditto.
758 * bgp_fsm.c: (bgp_timer_set) dont bring up a session which is
759 clearing.
760 * bgp_route.c: (general) Update all bgp_table_init calls.
761 (bgp_process_{rsclient,main}) clear_node is serialised
762 via PEER_STATUS_CLEARING and fsm now.
763 (struct bgp_clear_node_queue) can be removed. struct bgp_node
764 can be the queue item data directly, as struct peer can be
765 kept in the new wq global user data and afi/safi can be
766 retrieved via bgp_node -> bgp_table.
767 (bgp_clear_route_node) fix to get peer via wq->spec.data,
768 afi/safi via bgp_node->bgp_table.
769 (bgp_clear_node_queue_del) no more item data to delete, only
770 unlock the bgp_node.
771 (bgp_clear_node_complete) only need to unset CLEARING flag
772 and unlock struct peer.
773 (bgp_clear_node_queue_init) queue attaches to struct peer
774 now. record peer name as queue name.
775 (bgp_clear_route_table) If queue transitions to active,
776 serialise clearing by setting PEER_STATUS_CLEARING rather
777 than plugging process queue, and lock peer while queue
778 active.
779 Update to pass only bgp_node as per-queue-item specific data.
Paul Jakma6a419732006-02-21 01:14:13 +0000780 * bgp_vty.c: (bgp_show_summary) Add a 'Clrng' sub-description
781 to state of peer while it's suppressed due to clearing.
Paul Jakma64e580a2006-02-21 01:09:01 +0000782
Paul Jakmaaa94ca82006-02-18 10:49:04 +00007832006-02-18 Paul Jakma <paul.jakma@sun.com>
784
785 * bgp_routemap.c: (route_set_community) Quick, very hacky, fix
786 for the set-community leak, bug #89. True fix will be to
787 detangle the web of *_intern caching and provide saner object
788 caching for Quagga, future work.
Paul Jakma7c7fa1b2006-02-18 10:52:09 +0000789 * bgp_route.c: (bgp_announce_check) trivial, move declaration
790 of two local variables into the only block where they are
791 used, to aid the reader.
Paul Jakmaaa94ca82006-02-18 10:49:04 +0000792
paul902212c2006-02-05 17:51:19 +00007932006-02-05 Paul Jakma <paul.jakma@sun.com>
794
795 * bgp_route.h: Add BGP_INFO_COUNTED to track whether
796 prefix has been counted or not.
797 * bgp_route.c: (bgp_pcount_{inc,dec}rement) new helpers, to
798 centralise inc/dec of prefix-count,
799 (bgp_rib_remove) Remove pcount decrement, use helper.
800 (bgp_rib_withdraw) ditto, additionally use previous function
801 too.
802 (bgp_update_main) Use pcount helpers.
803 (bgp_clear_route_node) ditto, aslo REMOVED routes don't need
804 clearing.
paul3fff6ff2006-02-05 17:55:35 +0000805 * bgp_aspath.c: (aspath_gettoken) fix gcc warning about
806 possible uninitialised usage.
paul902212c2006-02-05 17:51:19 +0000807
paul306d8892006-02-02 17:50:19 +00008082006-02-02 Paul Jakma <paul.jakma@sun.com>
809
810 * bgp_route.c: (bgp_{clear_node,process}_queue_init) delay
811 field is removed from workqueue spec.
812
paule8e19462006-01-19 20:16:55 +00008132006-01-19 Paul Jakma <paul.jakma@sun.com>
814
815 * (general) various miscellaneous compiler warning fixes.
816 Remove redundant break statements from switch clauses
817 which return.
818 return from main, not exit, cause it annoys SOS.
819 Remove stray semi-colons which cause empty-statement
820 warnings.
821
pauld3092e72006-01-17 17:33:46 +00008222006-01-17 Paul Jakma <paul.jakma@sun.com>
823
824 * bgp_nexthop.c: (zlookup_read*) convert to new Zserv format.
825 (zlookup_query_ipv6) ditto.
826 (bgp_import_check) ditto.
827
paul02335422006-01-16 11:13:27 +00008282006-01-16 Paul Jakma <paul.jakma@sun.com>
829
830 * bgp_aspath.c: (assegment_append_asns) XREALLOC can return
831 NULL theoretically, take care not to lose the allocated data.
832 (aspath_hash_alloc) aspath_dup already set the aspath
833 string - fix leak.
834 (aspath_parse) aspath_hash_alloc dupes the entire aspath,
835 including segments, but we forgot to free the temporary
836 assegment.
paul8fdc32a2006-01-16 12:01:29 +0000837 (aspath_snmp_pathseg) move the static stream pointer out to
838 file scope, so it can be freed.
839 (aspath_finish) new function, free aspath resources.
840 * bgp_aspath.h: (aspath_finish) export.
paul02335422006-01-16 11:13:27 +0000841
paul37c38302006-01-10 22:15:45 +00008422006-01-10 Juris Kalnins <juris@mt.lv>
843
844 * bgpd.h: (bgp_router_id_unset) ex-function, remove.
845
paulad727402005-11-23 02:47:02 +00008462005-11-23 Paul Jakma <paul.jakma@sun.com>
847
848 * bgp_aspath.c: (assegments_parse) should be static
849
8502005-11-23 Juergen Kammer <j.kammer@eurodata.de>
851
852 * bgp_aspath.c: (aspath_cmp_left_confed) fix SEGV for case
853 where one or both paths are empty.
854
paul0fb58d52005-11-14 14:31:49 +00008552005-11-14 Paul Jakma <paul.jakma@sun.com>
856
857 * bgp_route.c: (bgp_process_rsclient) convert to new workqueue
858 specs and shut up gcc, which complains about cast from void
859 via function parameters, for some dumb reason. Do the cast
860 inside the function instead.
861 (bgp_process_main,bgp_processq_del) ditto.
862 (bgp_clear_route_node) ditto.
863 (bgp_clear_node_queue_del) ditto.
864
paul41200852005-11-03 12:52:18 +00008652005-11-03 Paul Jakma <paul.jakma@sun.com>
866
867 * bgp_damp.c: (bgp_reuse_timer) struct bgp can be retrieved via
868 the struct bgp_damp_info, no need to guess by using
869 bgp_get_default().
870
ajsf52d13c2005-10-01 17:38:06 +00008712005-10-01 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
872
873 * bgp_vty.c: (bgp_config_write_redistribute) Use new library function
874 zebra_route_string instead of a local hard-coded table.
875
jardin2d74db52005-10-01 00:07:50 +00008762005-09-30 Vincent Jardin <vincent.jardin@6wind.com>
877
878 * bgp_packet.c: fix compilation when DEBUG is used.
879
paul1f8ae702005-09-09 23:49:49 +00008802005-09-10 Paul Jakma <paul.jakma@sun.com>
881
paulfe69a502005-09-10 16:55:02 +0000882 * Makefile.am: bgpd shouldn't list libgp's sources as its own.
883 Use LDADD.
884 * bgp_aspath.h:
885 (struct assegment) New struct, abstract representation of a
886 list of AS_PATH segments and the contained ASNs.
887 (struct aspath) Remove the raw-data related
888 fields, reference the abstract struct assegment instead.
889 Remove several other computed fields, it's just a
890 headache to maintain them and they're cheap to compute from
891 struct assegment.
892 (aspath_parse) parse a stream, not a pointer to raw data.
893 (aspath_count_{hops,confeds,size}) helpers to access
894 information formerly directly contained in struct aspath.
895 (aspath_snmp_pathseg) Helper for SNMP, BGP MIB wants
896 to be able to output hex representation of raw data.
897 * bgp_aspath.c: (general) partial-rewrite. Store aspath data
898 as an abstract singly-linked list of abstract segments,
899 rather than storing the raw data, and parsing it each and
900 every time. Remove several count/size fields which are cheap
901 to compute from the abstract segment structure.
902 (global) Include stream.h, needed for aspath_parse, and
903 others. Couple of helper macros added.
904 (struct assegment_header) Just the header, and only the
905 header.
906 (assegment_data_{new,free}) convenience functions for
907 AS_SEG_DATA allocation, the dynamic, per-segment array of
908 ASNs.
909 (assegment_{new,free,free_all,dup,dup_all}) convenience
910 functions for creating struct assegments. The _all forms will
911 follow the entire chain of segments from the given segment.
912 (assegment_prepend_asns) new function, prepend an ASN N times
913 to segment.
914 (assegment_append_asns) Append a list (array) of ASNs to
915 segment.
916 (int_cmp) convenience function for the aspath hash.
917 (assegment_normalise) new function. Normalise the given
918 segment chain to meet expectations of Quagga, and to
919 eliminate differing raw representations of the same paths.
920 Merge 'runs' of SEQUENCEs into one segment as our internal
921 segment is not limited by the protocol AS_PATH segment
922 length. Sort ASNs in SETs.
923 (aspath_new) Take void argument to quell warnings. Use the
924 assegment convenience functions.
925 (assegment_count_{asns,confeds,hops}) new functions to
926 compute at runtime values previously held in struct aspath.
927 (aspath_size) ditto.
928 (aspath_make_str_count) rewritten to stringify new
929 representation, and to be slightly easier to understand
930 hopefully.
931 (aspath_str_update) convenience function, update the aspath
932 str. Should investigate removing maintained string from
933 struct aspath, just run-time compute it, as per other fields.
934 It's just a maintenance headache, would save noticeable
935 amount of RAM with possibly not much extra run-time cost.
936 (aspath_dup) use the assegment dup functions.
937 (aspath_hash_alloc) Take void * argument to satisfy gcc. Use
938 the proper helper functions to dup data.
939 (assegments_parse) new function. parse raw AS_PATH data into
940 struct assegments. Normalise and return the head of the list.
941 (aspath_parse) Parse a stream, not pointer to raw data and
942 use assegments_parse to do it.
943 (assegment_data_put) Write out a single segment data in protocol
944 form to stream.
945 (assegment_header_put) ditto but for segment header.
946 (aspath_put) new function. As per previous but for an entire
947 struct aspath.
948 (aspath_snmp_pathseg) wrapper around aspath_put for
949 bgp_snmp.c. Uses a static buffer sadly.
950 (aspath_aggregate_as_set_add) rewritten to use assegments.
951 (aspath_aggregate) ditto
952 (aspath_{firstas,loop,private_as}_check) ditto
953 (aspath_{merge,prepend,add_one_as}) ditto
954 (aspath_cmp_left{_confed}) ditto
955 (aspath_delete_confed_seq) ditto, plus fixed to properly
956 delete all leading confed segments.
957 (aspath_as_add) Just use assegment_append_asns.
958 (aspath_segment_add) updated to use assegments.
959 (enum as_token) Add values for confeds
960 (aspath_gettoken) Add support for confeds
961 (aspath_str2aspath) ditto
962 (aspath_key_make) updated to use as_segments. Also, add
963 segment type into the hash value as appropriate.
964 (aspath_cmp) updated to use as_segments.
965 (aspath_print) don't segfault on NULL argument.
966 * bgp_attr.c: (bgp_attr_aspath) aspath_parse wants the stream
967 now. No need for manual forwarding of stream.
968 (bgp_packet_attribute) empty aspath is now denoted by NULL
969 segment field, length is gone.
970 Use aspath_size() to determine size.
971 (bgp_attr_init) Fix declaration, explicitely specify void
972 arg.
973 (bgp_dump_routes_attr) Use aspath_size() to determine size.
974 * bgp_route.c: (bgp_info_cmp) use the aspath_count_* functions.
975 (bgp_rib_withdraw) remove unused variable. Use
976 aspath_count_hops.
977 * bgp_snmp.c: (bgp4PathAttrTable) raw data is gone, use
978 aspath_snmp_pathseg to get the representation.
979
9802005-09-10 Paul Jakma <paul.jakma@sun.com>
981
paul1f8ae702005-09-09 23:49:49 +0000982 * bgp_vty.c: (bgp_vty_init) gcc 4 compile fix. static
983 function declarations shouldn't be inside functions.
984 * bgp_dump.c: (bgp_dump_interval_add) ditto.
985
hassob7395792005-08-26 12:58:38 +00009862005-08-26 Hasso Tepper <hasso at quagga.net>
987
988 * bgp_route.c: Third (?) attempt to fix best selection breakage
989 introduced long time ago with route server patch. Hopefully
990 it's last case to fix - route-server client not in peer group.
991
paul25ffbdc2005-08-22 22:42:08 +00009922005-08-22 Hugo Santos <hsantos@av.it.pt>
993
994 * bgp_vty.c: (general) Add support for BGP IPv6 Multicast SAFI
995 commands and BGP_IPV6M_NODE.
996
paulb40d9392005-08-22 22:34:41 +00009972005-08-22 Paul Jakma <paul.jakma@sun.com>
998
999 * bgp_route.h: (struct bgp_info) add a new flag, BGP_INFO_REMOVED.
1000 BGP_INFO_VALID is already overloaded, don't care to do same thing
1001 to STALE or HISTORY.
1002 * bgpd.h: (BGP_INFO_HOLDDOWN) Add INFO_REMOVED to the macro, as a
1003 route which should generally be ignored.
1004 * bgp_route.c: (bgp_info_delete) Just set the REMOVE flag, rather
1005 than doing actual work, so that bgp_process (called directly,
1006 or indirectly via the scanner) can catch withdrawn routes.
1007 (bgp_info_reap) Actually remove the route, what bgp_info_delete
1008 used to do, only for use by bgp_process.
1009 (bgp_best_selection) reap any REMOVED routes, other than the old
1010 selected route.
1011 (bgp_process_rsclient) reap the old-selected route, if appropriate
1012 (bgp_process_main) ditto
1013 (bgp_rib_withdraw, bgp_rib_remove) make them more consistent with
1014 each other. Don't play games with the VALID flag, bgp_process
1015 is async now, so it didn't make a difference anyway.
1016 Remove the 'force' argument from bgp_rib_withdraw, withdraw+force
1017 is equivalent to bgp_rib_remove. Update all its callers.
1018 (bgp_update_rsclient) bgp_rib_withdraw and force set is same as
1019 bgp_rib_remove.
1020 (route_vty_short_status_out) new helper to print the leading
1021 route-status string used in many command outputs. Consolidate.
1022 (route_vty_out, route_vty_out_tag, damp_route_vty_out,
1023 flap_route_vty_out) use route_vty_short_status_out rather than
1024 duplicate.
1025 (route_vty_out_detail) print state of REMOVED flag.
1026 (BGP_SHOW_SCODE_HEADER) update for Removed flag.
1027
hassoe279c7a2005-08-03 17:23:20 +000010282005-08-03 Hasso Tepper <hasso at quagga.net>
1029
1030 * bgp_routemap.c: Revert part of leaking communities fix commited in
1031 2005-05-27. While ecommunity fix seems to be correct, community case
1032 isn't.
1033
paul94f2b392005-06-28 12:44:16 +000010342005-06-28 Paul Jakma <paul.jakma@sun.com>
1035
1036 * (global) The great bgpd extern and static'ification.
1037 * bgp_routemap.c: remove unused ROUTE_MATCH_ASPATH_OLD code
1038 (route_set_metric_compile) fix u_int32_t to ULONG_MAX comparison
1039 warnings.
1040 * bgp_route.h: (bgp_process, bgp_withdraw, bgp_update) export these
1041 used by various files which had their own private declarations,
1042 in the case of mplsvpn - incorrect.
1043
paule210cf92005-06-15 19:15:35 +000010442005-06-15 Paul Jakma <paul.jakma@sun.com>
1045
1046 * bgpd.c: (bgp_terminate) workqueue's are lazy allocated and its
1047 possible to terminate bgpd before workqueues were setup, causing
1048 an abort/crash. Reported by Ashish Mehta of Sun.
1049
paul200df112005-06-01 11:17:05 +000010502005-06-01 Paul Jakma <paul.jakma@sun.com>
1051
1052 * (general) refcount struct peer and bgp_info, hence allowing us
1053 add work_queues for bgp_process.
1054 * bgp_route.h: (struct bgp_info) Add 'lock' field for refcount.
1055 Add bgp_info_{lock,unlock} helper functions.
1056 Add bgp_info_{add,delete} helpers, to remove need for
1057 users managing locking/freeing of bgp_info and bgp_node's.
1058 * bgp_table.h: (struct bgp_node) Add a flags field, and
1059 BGP_NODE_PROCESS_SCHEDULED to merge redundant processing of
1060 nodes.
1061 * bgp_fsm.h: Make the ON/OFF/ADD/REMOVE macros lock and unlock
1062 peer reference as appropriate.
1063 * bgp_damp.c: Remove its internal prototypes for
1064 bgp_info_delete/free. Just use bgp_info_delete.
1065 * bgpd.h: (struct bgp_master) Add work_queue pointers.
1066 (struct peer) Add reference count 'lock'
1067 (peer_lock,peer_unlock) New helpers to take/release reference
1068 on struct peer.
1069 * bgp_advertise.c: (general) Add peer and bgp_info refcounting
1070 and balance how references are taken and released.
1071 (bgp_advertise_free) release bgp_info reference, if appropriate
1072 (bgp_adj_out_free) unlock peer
1073 (bgp_advertise_clean) leave the adv references alone, or else
1074 call bgp_advertise_free cant unlock them.
1075 (bgp_adj_out_set) lock the peer on new adj's, leave the reference
1076 alone otherwise. lock the new bgp_info reference.
1077 (bgp_adj_in_set) lock the peer reference
1078 (bgp_adj_in_remove) and unlock it here
1079 (bgp_sync_delete) make hash_free on peer conditional, just in
1080 case.
1081 * bgp_fsm.c: (general) document that the timers depend on
1082 bgp_event to release a peer reference.
1083 (bgp_fsm_change_status) moved up the file, unchanged.
1084 (bgp_stop) Decrement peer lock as many times as cancel_event
1085 canceled - shouldnt be needed but just in case.
1086 stream_fifo_clean of obuf made conditional, just in case.
1087 (bgp_event) always unlock the peer, regardless of return value
1088 of bgp_fsm_change_status.
1089 * bgp_packet.c: (general) change several bgp_stop's to BGP_EVENT's.
1090 (bgp_read) Add a mysterious extra peer_unlock for ACCEPT_PEERs
1091 along with a comment on it.
1092 * bgp_route.c: (general) Add refcounting of bgp_info, cleanup
1093 some of the resource management around bgp_info. Refcount peer.
1094 Add workqueues for bgp_process and clear_table.
1095 (bgp_info_new) make static
1096 (bgp_info_free) Ditto, and unlock the peer reference.
1097 (bgp_info_lock,bgp_info_unlock) new exported functions
1098 (bgp_info_add) Add a bgp_info to a bgp_node in correct fashion,
1099 taking care of reference counts.
1100 (bgp_info_delete) do the opposite of bgp_info_add.
1101 (bgp_process_rsclient) Converted into a work_queue work function.
1102 (bgp_process_main) ditto.
1103 (bgp_processq_del) process work queue item deconstructor
1104 (bgp_process_queue_init) process work queue init
1105 (bgp_process) call init function if required, set up queue item
1106 and add to queue, rather than calling process functions directly.
1107 (bgp_rib_remove) let bgp_info_delete manage bgp_info refcounts
1108 (bgp_rib_withdraw) ditto
1109 (bgp_update_rsclient) let bgp_info_add manage refcounts
1110 (bgp_update_main) ditto
1111 (bgp_clear_route_node) clear_node_queue work function, does
1112 per-node aspects of what bgp_clear_route_table did previously
1113 (bgp_clear_node_queue_del) clear_node_queue item delete function
1114 (bgp_clear_node_complete) clear_node_queue completion function,
1115 it unplugs the process queues, which have to be blocked while
1116 clear_node_queue is being processed to prevent a race.
1117 (bgp_clear_node_queue_init) init function for clear_node_queue
1118 work queues
1119 (bgp_clear_route_table) Sets up items onto a workqueue now, rather
1120 than clearing each node directly. Plugs both process queues to
1121 avoid potential race.
1122 (bgp_static_withdraw_rsclient) let bgp_info_{add,delete} manage
1123 bgp_info refcounts.
1124 (bgp_static_update_rsclient) ditto
1125 (bgp_static_update_main) ditto
1126 (bgp_static_update_vpnv4) ditto, remove unneeded cast.
1127 (bgp_static_withdraw) see bgp_static_withdraw_rsclient
1128 (bgp_static_withdraw_vpnv4) ditto
1129 (bgp_aggregate_{route,add,delete}) ditto
1130 (bgp_redistribute_{add,delete,withdraw}) ditto
1131 * bgp_vty.c: (peer_rsclient_set_vty) lock rsclient list peer
1132 reference
1133 (peer_rsclient_unset_vty) ditto, but unlock same reference
1134 * bgpd.c: (peer_free) handle frees of info to be kept for lifetime
1135 of struct peer.
1136 (peer_lock,peer_unlock) peer refcount helpers
1137 (peer_new) add initial refcounts
1138 (peer_create,peer_create_accept) lock peer as appropriate
1139 (peer_delete) unlock as appropriate, move out some free's to
1140 peer_free.
1141 (peer_group_bind,peer_group_unbind) peer refcounting as
1142 appropriate.
1143 (bgp_create) check CALLOC return value.
1144 (bgp_terminate) free workqueues too.
1145
hasso033e8612005-05-28 04:50:54 +000011462005-05-28 Hasso Tepper <hasso at quagga.net>
1147
1148 * bgp_routemap.c: Sync set_metric_addsub_cmd with ripd.
1149
hasso54a6ed32005-05-26 22:12:33 +000011502005-05-27 Hasso Tepper <hasso at quagga.net>
1151
hasso70601e02005-05-27 03:26:57 +00001152 * bgp_routemap.c: Stop leaking communities.
1153
11542005-05-27 Hasso Tepper <hasso at quagga.net>
1155
hasso54a6ed32005-05-26 22:12:33 +00001156 * bgpd.c: Deleting bgp->rsclient list needs fix similar to pree-groups
1157 deleting fix. Avoid leaking bgp->group, bgp->peer and bgp->rsclient
1158 lists.
1159
11602005-05-26 Hasso Tepper <hasso at quagga.net>
hassob6b7cff2005-05-26 08:29:07 +00001161
1162 * bgpd.c: Don't crash while deleting list of peer-groups.
1163
hassob5f29602005-05-25 21:00:28 +000011642005-05-25 Hasso Tepper <hasso at quagga.net>
1165
1166 * bgpd.c: Fix obvious (routeserver patch) merge error. This makes "no
1167 neighbor x.x.x.x routemap [export|import] commands work again.
1168
paula94feb32005-05-23 13:17:29 +000011692005-05-23 Paul Jakma <paul@dishone.st>
1170
1171 * bgp_routemap.c: add semi-colons to VTY_GET_* to match vty.h change
paul00d252c2005-05-23 14:19:54 +00001172 * bgp_fsm.h: Add extern qualifier to exported functions
1173 * bgp_nexthop.c: add static to nexthop specific globals
1174 * *.h: Add guard defines
paula94feb32005-05-23 13:17:29 +00001175
paul22db9de2005-05-19 01:50:11 +000011762005-05-19 Paul Jakma <paul@dishone.st>
1177
1178 * bgp_fsm.c: (bgp_stop) use sockunion_free, not XFREE..
1179 * bgp_network.c: (bgp_getsockname) ditto
paule83e2082005-05-19 02:12:25 +00001180 (bgp_accept) use XSTRDUP
paul22db9de2005-05-19 01:50:11 +00001181 * bgp_routemap.c: (route_match_peer) ditto, als use a ret value and
1182 remove one sockunion_free.
paule83e2082005-05-19 02:12:25 +00001183 * bgpd.c: (peer_delete) ditto.
1184 XFREE the correct memtype, not free.
1185 (peer_create) use XSTRDUP
1186 * bgp_packet.c: (bgp_stream_dup) deleted, stream_dup should be used
1187 (various) update -> s/bgp_stream_dup/stream_dup
1188
paul22db9de2005-05-19 01:50:11 +00001189
ajs634f9ea2005-04-11 15:51:40 +000011902005-04-11 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1191
1192 * bgp_zebra.c (bgp_redistribute_set, bgp_redistribute_unset):
1193 The 2nd arg to zebra_redistribute_send is now zclient instead of
1194 zclient->sock.
1195
hassoa8a80d52005-04-09 13:07:47 +000011962005-04-09 Akihiro Mizutani <mizutani@net-chef.net>
1197
1198 * bgp_vty.c: Make "exit-address-family" work in IPv4 unicast address
1199 family node.
1200
hasso68118452005-04-08 15:40:36 +000012012005-04-08 Martin Ling <martin-quagga@earth.li>
1202
1203 * bgp_aspath.[ch], bgp_route.c, bgp_vty.c, bgpd.[ch]: Allow to enable
1204 the length of confederation path segments to be included during the
1205 as-path length check in the best path decision.
1206
ajsd2fc8892005-04-02 18:38:43 +000012072005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1208
1209 * bgp_zebra.c: (bgp_interface_delete) After deleting, set ifp->ifindex
1210 to IFINDEX_INTERNAL.
1211
hasso6cf159b2005-03-21 10:28:14 +000012122005-03-21 Hasso Tepper <hasso at quagga.net>
1213
1214 * bgp_route.c: Don't crash while clearing route tables if there is
1215 no particular afi/safi configured.
1216
hasso338b3422005-02-23 14:27:24 +000012172005-02-23 Hasso Tepper <hasso at quagga.net>
1218
1219 * bgp_route.c: Make reannouncing prefixes with changed attributes
1220 work again.
1221
hasso6ffd2072005-02-02 14:50:11 +000012222005-02-02 Akihiro Mizutani <mizutani@net-chef.net>
1223
hassodd4c5932005-02-02 17:15:34 +00001224 * bgp_vty.c: Deprecate "neighbor transparent-as" and "neighbor
1225 transparent-nexthop" commands.
1226
12272005-02-02 Akihiro Mizutani <mizutani@net-chef.net>
1228
hassoc1643bb2005-02-02 16:43:17 +00001229 * bgp_routemap.c: New route-map command - "match ip route-source".
1230
12312005-02-02 Akihiro Mizutani <mizutani@net-chef.net>
1232
hassofee6e4e2005-02-02 16:29:31 +00001233 * bgp_clist.[ch], bgp_route.c, bgp_routemap.c, bgp_vty.c:
1234 community-list cleanup.
1235
12362005-02-02 Akihiro Mizutani <mizutani@net-chef.net>
1237
hasso6ffd2072005-02-02 14:50:11 +00001238 * bgp_route.c, bgp_vty.c, bgp_zebra.c, bgpd.[ch]: "enforce-multihop"
1239 -> "disable-connected-check".
1240
12412005-02-02 Akihiro Mizutani <mizutani@net-chef.net>
hasso93406d82005-02-02 14:40:33 +00001242
1243 * bgp_fsm.c, bgp_open.c, bgp_packet.c, bgp_route.[ch], bgp_vty.c,
1244 bgpd.[ch]: Add BGP_INFO_STALE flag and end-of-rib support. "bgp
1245 graceful-restart" commands added. Show numbers of individual
1246 messages in "show ip bgp neighbor" command. Final pieces of graceful
1247 restart.
1248
hassof4184462005-02-01 20:13:16 +000012492005-02-01 Akihiro Mizutani <mizutani@net-chef.net>
1250
hassoc9502432005-02-01 22:01:48 +00001251 * bgp_open.c, bgp_packet.c, bgp_vty.c, bgpd.[ch]: Remove "no neighbor
1252 capability route-refresh" commands. Route refresh capability is sent
1253 anyway now. Preserve dummy deprecated commands.
1254
12552005-02-01 Akihiro Mizutani <mizutani@net-chef.net>
1256
hasso3d515fd2005-02-01 21:30:04 +00001257 * bgp_attr.c, bgp_snmp.c, bgp_vty.c, bgpd.[ch]: Remove support for old
1258 draft - ie. "neighbor version 4-" commands. Preserve dummy "neighbor
1259 version" command as deprecated.
1260
12612005-02-01 Akihiro Mizutani <mizutani@net-chef.net>
1262
hasso0a486e52005-02-01 20:57:17 +00001263 * bgpd.[ch], bgp_vty.c, bgp_route.c: "Restart session after
1264 maximum-prefix limit" feature support.
1265
12662005-02-01 Akihiro Mizutani <mizutani@net-chef.net>
1267
hassof4184462005-02-01 20:13:16 +00001268 * bgp_nexthop.c: Improve debug.
1269 * bgpd.[ch], bgp_nexthop.c, bgp_snmp.c: Remove useless bgp_get_master()
1270 function.
1271 * bgp_packet.c: MP AFI_IP update and withdraw parsing.
1272 * bgp_fsm.c: Reset peer synctime in bgp_stop(). bgp_fsm_change_status()
1273 is better place to log about peer status change than bgp_event().
1274 Log in bgp_connect_success().
1275 * bgp_vty.c: Fix typo in comment.
1276 * bgp_attr.c: Better log about unknown attribute.
1277
ajs3b8b1852005-01-29 18:19:13 +000012782005-01-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1279
1280 * bgp_filter.c: (ip_as_path,no_ip_as_path) Use argv_concat instead
1281 of buffer_getstr.
1282 * bgp_route.c: (bgp_show_regexp) Fix memory leak: need to free string
1283 returned by buffer_getstr.
1284 (bgp_show_community) Must use XFREE instead of free on string
1285 returned by buffer_getstr.
1286 * bgp_routemap.c: (set_community) Must use XFREE instead of free
1287 on string returned by buffer_getstr.
1288 * bgp_vty.c: (neighbor_description) Use argv_concat instead of
1289 buffer_getstr.
1290
hasso6d694292005-01-24 09:29:42 +000012912005-01-24 Hasso Tepper <hasso at quagga.net>
1292
1293 * bgp_route.c: Fix showstopper bug. New route must be selected also
1294 if old one is flaged as BGP_INFO_ATTR_CHANGED.
1295
hassof1271652005-01-17 11:04:32 +000012962005-01-17 Hasso Tepper <hasso at quagga.net>
1297
1298 * bgp_route.c: Clear peer's routing table regardless whether it's
1299 configured or not. Being not configured is even better reason to
1300 do it.
1301
paula24a7e12005-01-05 08:14:13 +000013022005-01-05 Paul Jakma <paul@dishone.st>
1303
1304 * bgp_packet.c: (bgp_write) set socket to nonblock while writing
1305 this should be generalised. See bugzilla #102. Fix supplied by
1306 wawa@yandex-team.ru (Vladimir Ivanov).
1307
ajsd2c1f162004-12-08 21:10:20 +000013082004-12-08 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1309
1310 * *.c: Change level of debug messages to LOG_DEBUG.
1311
ajs274a4a42004-12-07 15:39:31 +000013122004-12-07 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1313
1314 * bgp_main.c: (main) The 2nd argument to openzlog has been removed.
1315
ajs887c44a2004-12-03 16:36:46 +000013162004-12-03 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1317
1318 * bgp_main.c: (sigint) Use zlog_notice for termination message.
1319 (main) Use zlog_notice for startup announcement.
1320
hassoc0652302004-11-25 19:33:48 +000013212004-11-25 Hasso Tepper <hasso at quagga.net>
1322
1323 * bgp_main.c: Make group to run as configurable.
1324
paul59320202004-11-09 01:54:03 +000013252004-11-09 Paul Jakma <paul@dishone.st>
1326
1327 * bgp_nexthop.c: collapse bgp_connected_ipvX, bgp_nexthop_cache_ipvX
1328 and cache{1,2}.. into arrays of tables and hence collapse
1329 bgp_scan_ipv{4,6} into a single bgp_scan function. Tested, though
1330 a long time ago (and this change was hand-merged).
1331
ajs5a646652004-11-05 01:25:55 +000013322004-11-04 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1333
1334 * bgp_route.c: Remove all code related to VTY_CONTINUE; this feature
1335 is deprecated because the output did not represent a single point
1336 in time. All output needs to be generated inline and buffered
1337 by the library code.
1338 (route_vty_out,route_vty_out_tag,damp_route_vty_out,
1339 flap_route_vty_out) Remove code to count number of lines of output,
1340 since this was only useful for VTY_CONTINUE behavior.
1341 (bgp_show_callback,vty_calc_line) Removed.
1342 (bgp_show_table) Remove hooks for VTY_CONTINUE callback support.
1343 As a result, there's a new output_arg argument to this function.
1344 Make function static.
1345 (bgp_show) Make function static and add a new output_arg argument.
1346 Change all functions that call bgp_show or bgp_show_table to
1347 pass the new output_arg argument (that used to be passed inside
1348 vty->output_arg).
1349 * bgp_mplsvpn.c: Remove declarations of functions defined in
1350 bgp_route.c; these declarations belong in bgp_route.h.
1351 * bgp_route.h: Declare 3 global functions used in both bgp_route.c
1352 and in bgp_mplsvpn.c.
1353
paula2b1ecd2004-10-31 18:58:09 +000013542004-10-31 Paul Jakma <paul@dishone.st>
1355
1356 * {bgpd,bgp_attr}.c: size_t printf format should be ld.
1357
paul98f51632004-10-25 14:19:15 +000013582004-10-25 Paul Jakma <paul@dishone.st>
1359
1360 * Update with fix in debian bug id 222930.
1361 * bgp_main.c: Add ZCAP_RAW, needed to bind to interfaces.
1362 bgp_network.c: (....) raise/lower privs around call to
1363 SO_BINDTODEVICE sockopt.
1364
hasso3fb9cd62004-10-19 19:44:43 +000013652004-10-19 Andrew J. Schorr <aschorr@telemetry-investments.com>
1366
1367 * bgp_nexthop.c: (bgp_connected_add) Connected destination pointer
1368 may be NULL.
1369 (bgp_connected_delete) ditto.
1370
hasso501ba492004-10-13 21:32:46 +000013712004-10-14 Hasso Tepper <hasso at quagga.net>
1372
1373 * bgp_dump.c: Make dump configuration appear in vtysh.
1374
hassoc75105a2004-10-13 10:33:26 +000013752004-10-13 Hasso Tepper <hasso at quagga.net>
1376
1377 * bgp_snmp.c: Remove defaults used to initialize smux connection to
1378 snmpd. Connection is initialized only if smux peer is configured.
hasso8b3126b2004-10-13 20:59:04 +00001379 * bgp_view.c: It's dead file. Reomved.
hassoc75105a2004-10-13 10:33:26 +00001380
paulfd79ac92004-10-13 05:06:08 +000013812004-10-13 Paul Jakma <paul@dishone.st>
1382
1383 * (global) more const'ification and fixups of types to clean up code.
1384 * bgp_mplsvpn.{c,h}: (str2tag) fix abuse. Still not perfect,
1385 should use something like the VTY_GET_INTEGER macro, but without
1386 the vty_out bits..
1387 * bgp_routemap.c: (set_aggregator_as) use VTY_GET_INTEGER_RANGE
1388 (no_set_aggregator_as) ditto.
1389 * bgpd.c: (peer_uptime) fix unlikely bug, where no buffer is
1390 returned, add comments about troublesome return value.
1391
hasso18a6dce2004-10-03 18:18:34 +000013922004-10-03 James R. Leu <jleu at mindspring.com>
1393
1394 * bgp_vty.c: Router id from zebra can be manually overriden.
1395 * bgp_zebra.c: Read router id related messages from zebra daemon.
1396 Remove own code related with router id selection.
1397 * bgpd.c, bgpd.h: Remove own router id selection code. Use the one
1398 from zebra daemon if it isn't manually overriden.
1399
hassoc9e52be2004-09-26 16:09:34 +000014002004-09-26 Hasso Tepper <hasso at quagga.net>
1401
1402 * bgp_aspath.c, bgp_packet.c, bgp_vty.c: Fix compiler warnings.
1403
hasso52dc7ee2004-09-23 19:18:23 +000014042004-09-23 Hasso Tepper <hasso at quagga.net>
1405
1406 * *.[c|h]: list -> struct list *, listnode -> struct listnode *.
1407
paule01f9cb2004-07-09 17:48:53 +000014082004-07-09 Paul Jakma <paul@dishone.st>
1409
1410 * Merge of GNU Zebra cvs2svn changesets r799, r800 and r807.
1411 * bgp_dump.c: (bgp_dump_attr) cleanup. return status code. check
1412 attributes present before printing.
1413 * bgp_dump.c: update bgp_dump_attr prototype.
1414 * bgp_packet.c: (bgp_update_receive) init attrstr. check status
1415 of bgp_dump_attr. Log end-of-rib UPDATEs.
1416
paulf5ba3872004-07-09 12:11:31 +000014172004-07-09 Sowmini Varadhan <sowmini.varadhan@sun.com>
1418
1419 * bgp_packet.c: (bgp_collision_detect) Send NOTIFY on new socket
1420 if that is connection we're closing.
1421 (bgp_read) invalid marker check applies to KEEPALIVE too.
1422 * bgp_route.c: Ignore multicast NRLI, dont send NOTIFY.
1423
paul5228ad22004-06-04 17:58:18 +000014242004-06-04 Paul Jakma <paul@dishone.st>
1425
1426 * type mismatch fixes
1427
hasso538621f2004-05-21 09:31:30 +000014282004-05-21 Akihiro Mizutani <mizutani@net-chef.net>
1429
1430 * bgpd.h, bgp_open.[ch], bgp_debug.c, bgp_vty.[ch], bgp_fsm.c:
1431 Graceful restart capability display.
1432
hasso3950fda2004-05-20 10:22:49 +000014332005-05-20 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1434
1435 * bgp_debug.c: Cosmetical fixes and log neighbor changes.
1436
hasso4372df72004-05-20 10:20:02 +000014372004-05-20 Akihiro Mizutani <mizutani@net-chef.net>
1438
1439 * bgp_ecommunity.c: Transit ecommunity support.
1440 * bgp_ecommunity.c: Fix for unknown community crush.
1441
hassoe0701b72004-05-20 09:19:34 +000014422005-05-20 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1443
1444 * *: Maximum prefix threshold support.
1445 * *: Reset notification fixups.
1446
paul0a589352004-05-08 11:48:26 +000014472004-05-08 Paul Jakma <paul@dishone.st>
1448
1449 * bgp_zebra.c: (bgp_interface_address_add) sync to zclient changes
1450 (bgp_interface_address_delete) ditto.
1451 (bgp_zebra_announce) ditto.
1452 (bgp_zebra_withdraw) ditto.
1453
paulc5317402004-05-03 13:25:06 +000014542004-05-03 Daniel Roesen <dr@cluenet.de>
1455
1456 * bgp_fsm.c: (bgp_stop) Reset uptime only on transition from
1457 Established so that it reflects true downtime (rather time
1458 since last transition, eg Active->Idle)
1459
paul35be31b2004-05-01 18:17:04 +000014602004-05-01 rivo nurges <rix@estpak.ee>
1461
1462 * bgp_route.c: fix UNH IOL BGP-4.1.12f
1463
pauleb821182004-05-01 08:44:08 +000014642004-05-01 Paul Jakma <paul@dishone.st>
1465
1466 * Revert the attempted clean-up of the dummy peer hack, reverts
1467 patchsets 435 (see 2004-02-17 below) and 456.
1468
paul545acaf2004-04-20 15:13:15 +000014692004-04-16 rivo nurges <rix@estpak.ee>
1470
hasso9b87e412004-04-20 16:54:49 +00001471 * bgpd.h, bgp_debug.c: update cease subcodes to
1472 draft-ietf-idr-cease-subcode-05
paul545acaf2004-04-20 15:13:15 +00001473 * bgpd.h, bgpd.c, bgp_route.c, bgp_route.h: fix UNH IOL BGP-4.1.6a
1474
paul6ad23f02004-02-17 19:45:10 +000014752004-02-17 Paul Jakma <paul@dishone.st>
1476
1477 * bgpd.h: (bgp_peer) add fd_local and fd_accept
1478 file descriptor's, fd becomes a pointer to one of these.
1479 * bgpd.c: (global) adjust for fact that fd is now a pointer.
1480 (peer_create_accept) removed.
1481 * bgp_route.c: (global) adjust for change of peer fd to pointer
1482 * bgp_packet.c: (bgp_collision_detect) adjust and remove the
1483 "replace with other peer" hack.
1484 * bgp_network.c: (bgp_accept) Remove the dummy peer hack.
1485 Update peer->fd_accept instead.
1486 (global) Adjust fd references - now a pointer.
1487 * bgp_fsm.c: (global) adjust peer fd to pointer.
1488 (bgp_connection_stop) new function, to stop connection.
1489 (global) adjust everything which closed peer fd to use
1490 bgp_connection_stop().
1491
gdt10d60ad2003-12-23 17:34:39 +000014922003-12-23 Krzysztof Oledzki <oleq@ans.pl>
1493
1494 * bgp_network.c: drop privs on error cases
1495
paul6ad23f02004-02-17 19:45:10 +000014962003-08-11 kunihiro <kunihiro@zebra.org>
paulac41b2a2003-08-12 05:32:27 +00001497
1498 * bgp_route{,map}.c: Extend 'set ip next-hop' in route-maps with
1499 ability to specify 'peer-address' rather than IP.
1500
paul9238b1e2003-06-11 08:03:08 +000015012003-06-09 Paul Jakma <paul@dishone.st>
1502
1503 * bgp_clist.c (community_list_delete): honour deny statements
1504
paul445f1432003-05-16 19:00:31 +000015052003-04-19 Hasso Tepper <hasso@estpak.ee>
1506
1507 * rip_routemap.c: sync daemon's route-map commands to have same
1508 syntax
1509
15102003-01-09 Akihiro Mizutani <mizutani@net-chef.net>
1511
1512 * bgp_routemap.c: Add match extcommunity command.
1513
paul718e3742002-12-13 20:15:29 +000015142002-10-23 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1515
1516 * bgp_aspath.c (aspath_init): Extend hash size from default to
1517 32767.
1518 (aspath_key_make): Use unsigned shoft for making hash. Suggested
1519 by: Marc Evans <Marc@SoftwareHackery.Com>
1520
15212002-08-19 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1522
1523 * bgp_clist.c (community_entry_free): Fix memory leak of standard
1524 extcommunity-list config string.
1525
15262002-08-19 Akihiro Mizutani <mizutani@net-chef.net>
1527
1528 * bgp_route.c (route_vty_out_detail): Fix bug of router-id display
1529 when multiple instance is used.
1530
15312002-08-18 Akihiro Mizutani <mizutani@net-chef.net>
1532
1533 * bgpd.c: Make "default-originate" and "maximum-prefix" commands
1534 available in peer-group configuration.
1535
15362002-08-13 Akihiro Mizutani <mizutani@net-chef.net>
1537
1538 * bgp_packet.c (bgp_open_send): Put Opt Parm Len 0 when last
1539 capability packet cause error or dont-capability-negotiate option
1540 is specified.
1541
15422002-07-07 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1543
1544 * zebra-0.93 released.
1545
15462001-10-28 Kunihiro Ishiguro <kunihiro@zebra.org>
1547
1548 * bgpd.c (bgp_vty_init): Translate update commands are removed.
1549
15502001-10-10 Kunihiro Ishiguro <kunihiro@zebra.org>
1551
1552 * bgp_route.c (bgp_static_set): Add workaround for BGP static
1553 route announcement when there is no zebra running.
1554
15552001-10-08 Kunihiro Ishiguro <kunihiro@zebra.org>
1556
1557 * bgpd.c (neighbor_remote_as_unicast): Remove "remote-as nlri
1558 unicast multicast" commands.
1559
15602001-09-14 Akihiro Mizutani <mizutani@dml.com>
1561
1562 * bgp_open.c: When we receive capability route-refresh, we should
1563 check we send the capability not we receive the capability.
1564
1565 * bgp_route.c (bgp_network_mask_natural_route_map): network
1566 statement route-map is added.
1567
15682001-08-31 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1569
1570 * bgp_advertise.c (bgp_advertise_intern): attr must be interned
1571 before looking up hash table.
1572
15732001-08-30 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1574
1575 * bgpd.h (struct peer): BGP filter is moved from peer_conf to
1576 peer.
1577
15782001-08-28 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1579
1580 * bgp_nexthop.c (bnc_nexthop_free): Fix next pointer bug.
1581 Suggested by: "Hong-Sung Kim" <hoskim@lanbird.co.kr>.
1582
15832001-08-26 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1584
1585 * bgp_table.c (bgp_node_create): Clearn memory before use it.
1586
15872001-08-24 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1588
1589 * Change to use bgp_table.[ch].
1590
15912001-08-23 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1592
1593 * bgpd.c (bgp_init): Add "transparent-as" and
1594 "transparent-nexthop" for old version compatibility.
1595
15962001-08-23 Akihiro Mizutani <mizutani@dml.com>
1597
1598 * bgpd.h (struct peer): default-originate route-map is added.
1599
1600 * bgp_route.c: When self originated route is advertised with
1601 attrubute-unchanged, nexthop was not properly set. This bug is
1602 fixed.
1603
16042001-08-22 Akihiro Mizutani <mizutani@dml.com>
1605
1606 * bgpd.c (neighbor_attr_unchanged): transparent-as and
1607 transparent-next-hop commands are restructured. Instead of
1608 current transparent-* commands, attribute-unchanged command is
1609 introduced.
1610
1611 neighbor A.B.C.D attribute-unchanged [as-path|next-hop|med]
1612
1613 (neighbor_default_originate): "default-originate" configuration
1614 announce default route even 0.0.0.0/0 does not exists in BGP RIB.
1615
16162001-08-19 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1617
1618 * zebra-0.92a released.
1619
16202001-08-19 Akihiro Mizutani <mizutani@dml.com>
1621
1622 * bgpd.c: AF specific soft-reconfiguration inbound commands are
1623 added.
1624
16252001-08-17 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1626
1627 * bgp_route.c (bgp_show_callback): Do not do community NULL check.
1628
1629 * bgp_community.c (community_cmp): Add check for commnunity NULL
1630 check.
1631
1632 * bgp_routemap.c (route_match_community): Do not check comunity is
1633 NULL. It may match to community-list "^$".
1634
1635 * bgp_community.c (community_match): Add check for community is
1636 NULL case.
1637
16382001-08-17 Akihiro Mizutani <mizutani@dml.com>
1639
1640 * bgpd.c: AF specific route-reflector-client and
1641 route-server-client configuration are added.
1642
16432001-08-17 Rick Payne <rickp@ayrnetworks.com>
1644
1645 * bgp_clist.c (community_match_regexp): Check special ^$ case.
1646
16472001-08-17 Akihiro Mizutani <mizutani@dml.com>
1648
1649 * bgp_clist.c (community_list_match): Fix bug of community list
1650 permit and deny check.
1651
16522001-08-16 Akihiro Mizutani <mizutani@dml.com>
1653
1654 * bgp_mplsvpn.c (bgp_mplsvpn_init): Add AF specific "nexthop-self"
1655 command.
1656
16572001-08-15 Akihiro Mizutani <mizutani@dml.com>
1658
1659 * bgpd.h (PEER_FLAG_SEND_COMMUNITY): Per AF based configuration
1660 flag is introduced.
1661
1662 * bgp_mplsvpn.c (bgp_mplsvpn_init): VPNv4 filtering is added.
1663
16642001-08-15 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1665
1666 * zebra-0.92 released.
1667
16682001-08-13 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1669
1670 * bgpd.c (bgp_delete): "no router bgp" free static, aggregate, rib
1671 table properly.
1672
16732001-08-12 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1674
1675 * bgp_route.c (bgp_node_safi): Return SAFI of current node.
1676 (bgp_config_write_network_vpnv4): VPNv4 static configuration
1677 display.
1678
16792001-08-11 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1680
1681 * bgpd.c (no_bgp_ipv4_multicast_route_map): Add IPv4 multicast
1682 node filter commands.
1683
16842001-08-11 Kunihiro Ishiguro <kunihiro@zebra.org>
1685
1686 * bgpd.h (PEER_FLAG_IGNORE_LINK_LOCAL_NEXTHOP): Add
1687 "ignore-link-local-nexthop" flag for ignore link-local nexthop for
1688 IPv6.
1689
16902001-08-07 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1691
1692 * bgpd.c (address_family_ipv4_multicast): "address-family ipv4
1693 multicast" is added.
1694 (address_family_ipv6_unicast): "address-family ipv6 unicast" is
1695 added.
1696
16972001-08-07 Akihiro Mizutani <mizutani@dml.com>
1698
1699 * bgp_route.c (bgp_process): Use flag instead of as_selected
1700 memeber in struct bgp_info.
1701
1702 * bgp_route.h (struct bgp_info): Remove as_selected memeber from
1703 struct bgp_info.
1704
17052001-07-31 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1706
1707 * bgp_route.c (bgp_announce_check): Enclose sending time AS loop
1708 check code with #ifdef BGP_SEND_ASPATH_CHECK.
1709
17102001-07-29 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1711
1712 * bgp_packet.c (bgp_withdraw_send): Simplify address family check.
1713
1714 * bgpd.h (BGP_INFO_HOLDDOWN): Introduce new macro to check BGP
1715 information is alive or not.
1716
1717 * bgp_community.c: Use community_val_get() on all OS.
1718
17192001-07-24 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1720
1721 * bgp_route.c (bgp_announce_check): Simplify set next-hop self
1722 check.
1723
17242001-07-24 Akihiro Mizutani <mizutani@dml.com>
1725
1726 * bgp_route.c (bgp_announce_check): To route server clients, we
1727 announce AS path, MED and nexthop transparently.
1728
17292001-06-21 Kunihiro Ishiguro <kunihiro@zebra.org>
1730
1731 * bgp_routemap.c (route_set_atomic_aggregate_free): Do not call
1732 XFREE. No memory is allocated in
1733 route_set_atomic_aggregate_compile().
1734
17352001-06-21 Kunihiro Ishiguro <kunihiro@zebra.org>
1736
1737 * bgp_routemap.c (bgp_route_map_init): `match nlri` and `set nlri`
1738 are replaced by `address-family ipv4` and `address-family vpnvr'.
1739
17402001-06-19 Kunihiro Ishiguro <kunihiro@zebra.org>
1741
1742 * bgp_route.c (bgp_withdraw): Add check for BGP_PEER_CONFED.
1743 Reported by Rick Payne <rickp@rossfell.co.uk>.
1744
17452001-06-17 Kunihiro Ishiguro <kunihiro@zebra.org>
1746
1747 * bgp_zebra.c (bgp_zebra_announce): When global IPv6 nexthop is
1748 empty, use socket's remote address for the nexthop.
1749
17502001-06-04 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1751
1752 * bgpd.c (peer_delete): Fix memory leak. Reported by Yosi Yarchi
1753 <Yosi_Yarchi@KereniX.com>
1754
17552001-06-01 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1756
1757 * bgpd.c (bgp_delete): Fix memory leak. Reported by Yosi Yarchi
1758 <Yosi_Yarchi@KereniX.com>
1759
17602001-05-27 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1761
1762 * bgp_route.c (bgp_route_clear_with_afi_vpnv4): Use next instead
1763 of ri->next.
1764
1765 * bgp_packet.c (bgp_withdraw_send): MPLS/VPN withdraw takes effect
1766 when HAVE_IPV6 is not defined.
1767
17682001-03-07 "Akihiro Mizutani" <mizutani@dml.com>
1769
1770 * bgpd.c (peer_timers_set): Adjust keepalive timer to fit less
1771 than holdtime / 3.
1772 (bgp_confederation_peers_unset): Only set peer->local_as when
1773 confederation is enabled.
1774 (bgp_timers): Add "timers bgp <0-65535> <0-65535>" command.
1775
1776 * bgp_route.c (bgp_announce_check): Set med of redistributed route
1777 when it is announced to EBGP peer.
1778
17792001-03-06 "Akihiro Mizutani" <mizutani@dml.com>
1780
1781 * bgp_nexthop.c (bgp_scan_ipv4): bgp_scan() call bgp_process() for
1782 all prefixes.
1783
17842001-03-06 Kunihiro Ishiguro <kunihiro@zebra.org>
1785
1786 * bgp_attr.c (bgp_attr_origin): When bgpd send NOTIFICATION with
1787 erroneous attribute (type, length and value), it does include
1788 attribute flags field.
1789
17902001-02-21 "Akihiro Mizutani" <mizutani@dml.com>
1791
1792 * bgp_route.c (bgp_announce_check): The route reflector is not
1793 allowed to modify the attributes of the reflected IBGP routes.
1794
17952001-02-20 "Akihiro Mizutani" <mizutani@dml.com>
1796
1797 * bgp_route.c (bgp_info_cmp): During path seleciton, BGP
1798 confederation peer is treated as same as IBGP peer.
1799
18002001-02-19 Kunihiro Ishiguro <kunihiro@zebra.org>
1801
1802 * bgp_route.c (bgp_redistribute_add): Initialize attr_new with
1803 attr. Call aspath_unintern when return from this function.
1804
18052001-02-19 "Akihiro Mizutani" <mizutani@dml.com>
1806
1807 * bgpd.c (bgp_router_id_set): Reset BGP peer when router-id is
1808 changed.
1809
18102001-02-18 "Akihiro Mizutani" <mizutani@dml.com>
1811
1812 * bgp_packet.c (bgp_open_receive): When user configure holdtimer,
1813 do not refrect the value to current session.
1814
18152001-02-16 Kunihiro Ishiguro <kunihiro@zebra.org>
1816
1817 * bgp_route.c (bgp_aggregate_delete): Set BGP_INFO_ATTR_CHANGE to
1818 suppress route withdraw.
1819
1820 * bgp_damp.c (bgp_damp_init): Fix bug of flap dampening.
1821
18222001-02-16 "Akihiro Mizutani" <mizutani@dml.com>
1823
1824 * bgp_aspath.c (aspath_make_str_count): Use ',' for separator for
1825 AS_SET and AS_CONFED_SET.
1826
18272001-02-15 Kunihiro Ishiguro <kunihiro@zebra.org>
1828
1829 * bgp_route.c (bgp_process): Do not consider suppress route.
1830
1831 * bgp_aspath.c (aspath_aggregate_as_set_add): Reset asset when
1832 aspath->data is realloced.
1833
18342001-02-15 "Akihiro Mizutani" <mizutani@dml.com>
1835
1836 * bgp_attr.c (bgp_attr_aggregate_intern): Do not set atomic
1837 aggregate when using as-set.
1838
18392001-02-14 "Akihiro Mizutani" <mizutani@dml.com>
1840
1841 * bgpd.c (bgp_confederation_peers_unset): Set peer's local-as
1842 correctly.
1843
1844 * bgp_route.c (bgp_update): Just ignore AS path loop for
1845 confederation peer.
1846
18472001-02-10 Kunihiro Ishiguro <kunihiro@zebra.org>
1848
1849 * bgp_route.c (bgp_aggregate_set): Add as_set argument.
1850 (bgp_aggregate_unset): Remove summary_only argument.
1851 (aggregate_address_as_set): New commands.
1852 "aggregate-address A.B.C.D/M as-set"
1853 "no aggregate-address A.B.C.D/M as-set"
1854
18552001-02-08 "Akihiro Mizutani" <mizutani@dml.com>
1856
1857 * bgp_route.c (bgp_announce_check): Do not modify nexthop when the
1858 route is passed by route reflector.
1859
18602001-02-08 Kunihiro Ishiguro <kunihiro@zebra.org>
1861
1862 * bgp_route.c: "no bgp dampening" with argument.
1863 (bgp_announce_check): Do not modify nexthop when the route is
1864 passed by route reflector.
1865
18662001-02-07 "Akihiro Mizutani" <mizutani@dml.com>
1867
1868 * bgpd.c (neighbor_passive): Change "neighbor NEIGHBOR remote-as
1869 ASN passive" to "neighbor NEIGHBOR passive".
1870 (bgp_announce_check): Check well-known community attribute even
1871 when "no neighbor send-community" is set.
1872
18732001-02-03 Kunihiro Ishiguro <kunihiro@zebra.org>
1874
1875 * bgp_fsm.c (bgp_establish): Do not send keepalive at established
1876 time when keepalive timer is configured as zero.
1877
18782001-02-01 Kunihiro Ishiguro <kunihiro@zebra.org>
1879
1880 * bgp_attr.c (bgp_attr_check): When peer is IBGP peer, local
1881 preference is well-known attribute.
1882
18832001-01-30 Kunihiro Ishiguro <kunihiro@zebra.org>
1884
1885 * zebra-0.91 is released.
1886
1887 * bgp_attr.h (struct attr): Comment out DPA value.
1888 (struct attr): Change refcnt type from int to unsinged long.
1889
1890 * bgp_attr.c (attrhash_key_make): Likewise.
1891 (attrhash_cmp): Likewise.
1892 (bgp_attr_dpa): Likewise.
1893
18942001-01-30 "Akihiro Mizutani" <mizutani@dml.com>
1895
1896 * bgp_route.c (bgp_info_cmp): Make route selection completely same
1897 as Cisco's.
1898
18992001-01-30 Kunihiro Ishiguro <kunihiro@zebra.org>
1900
1901 * bgp_attr.h (BGP_ATTR_FLAG_OPTIONAL): Rename old ATTR_FLAG_* to
1902 BGP_ATTR_FLAG_* to clarify meenings.
1903
19042001-01-30 "Akihiro Mizutani" <mizutani@dml.com>
1905
1906 * bgp_route.c (route_vty_out): Display argument to suppress same
1907 prefix information display.
1908 (route_vty_out_route): Don't display mask information for
1909 classfull network.
1910
19112001-01-30 Kunihiro Ishiguro <kunihiro@zebra.org>
1912
1913 * bgp_attr.h (SET_BITMAP): Simple bitmapping macros.
1914
1915 * bgp_attr.c (bgp_attr_parse): Use bitmap for attribute type
1916 check.
1917
19182001-01-29 Kunihiro Ishiguro <kunihiro@zebra.org>
1919
1920 * bgp_attr.c (bgp_mp_reach_parse): Enclose loggin with BGP_DEBUG.
1921 (bgp_attr_parse): Comment out well-known attribute check.
1922
19232001-01-28 Kunihiro Ishiguro <kunihiro@zebra.org>
1924
1925 * bgp_route.c (bgp_static_unset): Link-local IPv6 address can't be
1926 used for network advertisement.
1927 (nlri_parse): When link-local IPv6 address NLRI comes from
1928 remote-peer, log the information then simply ignore it.
1929
1930 * bgp_zebra.c (zebra_read_ipv6): Link-local IPv6 address is not
1931 redistributed.
1932
1933 * bgp_route.c (bgp_update): Check IPv6 global nexthop
1934 reachability.
1935
19362001-01-26 Kunihiro Ishiguro <kunihiro@zebra.org>
1937
1938 * bgp_route.c (bgp_update): Check nexthop points local address or
1939 not.
1940 (bgp_static_update_vpnv4): Set valid flag.
1941
1942 * bgp_attr.c (bgp_attr_parse): Duplicate attribute check.
1943 (bgp_attr_parse): Well-known attribute check.
1944
1945 * bgp_open.c (bgp_auth_parse): Authentication is not yet supported.
1946
1947 * bgp_packet.c (bgp_valid_marker): Check marker is synchronized.
1948
1949 * bgpd.c (clear_bgp): Send NOTIFICATION Cease when SEND_CEASE is
1950 defined.
1951
1952 * bgp_snmp.c (bgp4PathAttrTable): Fix compile error.
1953
19542001-01-24 Kunihiro Ishiguro <kunihiro@zebra.org>
1955
1956 * bgpd.c (bgp_network_import_check): New command for IGP network
1957 check.
1958
19592001-01-23 Kunihiro Ishiguro <kunihiro@zebra.org>
1960
1961 * bgp_nexthop.c (bgp_scan): Run bgp_process when IGP metric is
1962 changed. Call bgp_process once for each node.
1963
19642001-01-23 "Akihiro Mizutani" <mizutani@dml.com>
1965
1966 * bgp_route.c (bgp_info_cmp): Add IGP metric comparison.
1967
19682001-01-23 Kunihiro Ishiguro <kunihiro@zebra.org>
1969
1970 * bgp_route.c (bgp_info_cmp): Add IGP metric comparison.
1971
1972 * bgp_nexthop.c (bgp_nexthop_lookup): Set IGP metric for valid
1973 IBGP route.
1974
19752001-01-23 "Akihiro Mizutani" <mizutani@dml.com>
1976
1977 * bgp_route.c (show_ip_bgp_prefix_longer): Add new commands.
1978 "show ip bgp A.B.C.D/M longer-prefixes"
1979 "show ip bgp ipv4 (unicast|multicast) A.B.C.D/M longer-prefixes"
1980 "show ipv6 bgp X:X::X:X/M longer-prefixes"
1981 "show ipv6 mbgp X:X::X:X/M longer-prefixes"
1982
19832001-01-20 "Akihiro Mizutani" <mizutani@dml.com>
1984
1985 * bgp_route.c (show_ip_bgp_cidr_only): Add new commands.
1986 "show ip bgp cidr-only"
1987 "show ip bgp ipv4 (unicast|multicast) cidr-only"
1988
19892001-01-18 "Akihiro Mizutani" <mizutani@dml.com>
1990
1991 * bgp_route.c (bgp_update): AS path lookup check is done in
1992 bgp_update() not in attr_parse().
1993
19942001-01-18 Kunihiro Ishiguro <kunihiro@zebra.org>
1995
1996 * bgp_route.c (bgp_update): Call bgp_aggregate_decrement() just
1997 before bgp_attr_unintern().
1998
19992001-01-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2000
2001 * bgp_route.c (bgp_update): Now intern is performed very last part
2002 of the BGP packet update procedure.
2003
20042001-01-17 "Akihiro Mizutani" <mizutani@dml.com>
2005
2006 * bgp_route.c (bgp_update): When implicit withdraw occur, reuse
2007 existing bgp_info structure.
2008
20092001-01-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2010
2011 * bgp_route.c (bgp_aggregate_decrement): Fix bug of aggregate
2012 address matching method.
2013 (bgp_update):
2014
2015 * bgp_nexthop.c (bgp_nexthop_onlink): Separate EBGP nexthop onlink
2016 check and IBGP nexthop route check.
2017
20182001-01-16 "Akihiro Mizutani" <mizutani@dml.com>
2019
2020 * bgp_route.h (BGP_INFO_ATRR_CHANGED): Added for track attribute
2021 change.
2022
20232001-01-16 Kunihiro Ishiguro <kunihiro@zebra.org>
2024
2025 * bgp_route.h (struct bgp_info): Remove selected flag. Use
2026 BGP_INFO_SELECTED for flags instead.
2027 (struct bgp_info): Remove valid flag. Use BGP_INFO_VALID for
2028 flags instead.
2029 (struct bgp_info): Add igpmetric for IBGP route nexthop IGP
2030 metric.
2031 (struct bgp_info_tab): Struct bgp_info_tag is integrated into
2032 struct bgp_info.
2033 (BGP_INFO_ATRR_CHANGED): Added for track attribute change.
2034
2035 * bgp_community.c (community_val_get): gcc-2.95 on
2036 sparc-sun-solaris cause crush. This function is for avoid the
2037 crush.
2038
20392001-01-15 Kunihiro Ishiguro <kunihiro@zebra.org>
2040
2041 * bgp_packet.c (bgp_open_receive): Translated peer's packet_size
2042 clear bug is fixed.
2043
20442001-01-14 "Akihiro Mizutani" <mizutani@dml.com>
2045
2046 * bgp_packet.c (bgp_open_receive): Return notification with
2047 supported version number.
2048
20492001-01-13 Kunihiro Ishiguro <kunihiro@zebra.org>
2050
2051 * bgpd.c (bgp_show_summary): Display AS path and community
2052 entries. Suggested by: "Matt Ranney" <mjr@ranney.com>.
2053
2054 * bgp_packet.c (bgp_read_packet): Fix bug of unblocking BGP socket
2055 read. When BGP packet read is partial, we must get size and type
2056 from packet again.
2057
20582001-01-12 "Akihiro Mizutani" <mizutani@dml.com>
2059
2060 * bgp_route.c (bgp_update): Do not unset BGP_INFO_HISTORY flag.
2061 (bgp_update): When there is a history entry increment route count.
2062 (bgp_damp_set): Check BGP_CONFIG_DAMPENING flag.
2063
2064 * bgp_damp.c (bgp_damp_withdraw): Set status to
2065 BGP_DAMP_DISCONTINUE.
2066
20672001-01-11 Kunihiro Ishiguro <kunihiro@zebra.org>
2068
2069 * bgp_attr.c (bgp_mp_reach_parse): Fix warning code when second
2070 IPv6 nexthop is not link-local addresss.
2071
20722001-01-11 "Akihiro Mizutani" <mizutani@dml.com>
2073
2074 * bgp_damp.c (bgp_config_write_damp): Smart flap dampening
2075 configuration display.
2076 (bgp_damp_info_print): Display elapsed time from flap started.
2077
2078 * bgp_damp.h (struct bgp_damp_info): Add flap start time.
2079
2080 * bgpd.c (peer_create): Set last read time.
2081 (bgp_show_peer): Display last read time.
2082 (bgp_show_summary): Use BGP_CONFIG_DAMPENING flag to check
2083 configuration.
2084
2085 * bgpd.h (BGP_CONFIG_DAMPENING): Add new configuration option.
2086 (struct peer): Add last read time member.
2087 (BGP_VERSION_MP_4): Remove obsolete definition.
2088
20892001-01-10 Kunihiro Ishiguro <kunihiro@zebra.org>
2090
2091 * bgp_nexthop.c: Remove OLD_RIB codes.
2092
2093 * bgp_route.c (bgp_process): Likewise.
2094
2095 * zebra-0.90 is released.
2096
2097 * bgp_route.h (BGP_INFO_HISTORY): Remove damped member from struct
2098 bgp_info. Instead of that use BGP_INFO_DAMPED flag.
2099 (struct bgp_info): Remove invalid member from struct bgp_info.
2100 Instead of that use BGP_INFO_HISTORY flag.
2101
21022001-01-10 "Akihiro Mizutani" <mizutani@dml.com>
2103
2104 * bgp_damp.c (bgp_damp_info_print): New function to display
2105 dampening status.
2106 (DEFAULT_HARF_LIFE): Define default value.
2107 (DEFAULT_REUSE): Likewise.
2108 (DEFAULT_SUPPRESS): Likewise.
2109 (bgp_config_write_damp): When config value is same as default
2110 value, simply display "bgp dampening" to configuration.
2111
2112 * bgp_damp.h (struct bgp_damp_info): Add flap member.
2113
2114 * bgp_route.h (struct bgp_info): Added for BGP flap dampening
2115 history status.
2116
21172001-01-10 Kunihiro Ishiguro <kunihiro@zebra.org>
2118
2119 * bgp_nexthop.c (bgp_connected_add): Point-to-point connected
2120 address is properly handled.
2121 (bgp_connected_delete): Likewise.
2122
2123 * bgp_route.c (bgp_route_init): Turn off BGP Flap dampening code
2124 until it works fine.
2125
21262001-01-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2127
2128 * bgpd.c (bgp_show_summary): Add BGP_VERSION_MP_4 case.
2129
2130 * bgp_route.c (bgp_update): When this is not damped route, clear
2131 ri pointer.
2132
21332001-01-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2134
2135 * bgp_main.c: Add "-n" no_kernel option to not install route to
2136 kernel. Suggested by: "Matt Ranney" <mjr@ranney.com>
2137
21382001-01-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2139
2140 * bgp_nexthop.c (bgp_connected_add): Revert point-to-point
2141 connected route patch. Reported by ruud@ruud.org (Ruud de Rooij)
2142
2143 * bgp_damp.c (bgp_config_write_damp): Add configuration display
2144 function.
2145
2146 * bgp_route.c (bgp_info_free): Set NULL to BGP dampening
2147 information when BGP info structure is freed.
2148 (bgp_info_cmp): Check damped flag.
2149 (bgp_announce_check): Damped route is not announced.
2150
21512001-01-09 "Akihiro Mizutani" <mizutani@dml.com>
2152
2153 * bgpd.c (neighbor_capability_route_refresh): Change "neighbor
2154 route-refresh" command to "neighbor capability route-refresh".
2155 (clear_bgp_soft_in): Change soft-reconfig method.
2156
2157 clear ip bgp <neighbor> soft in
2158 --------------------------------------
2159 Try stored cache first then route-refresh
2160
2161 clear ip bgp <neighbor> in
2162 ---------------------------------
2163 Try route-refresh first then try to use stored cache
2164
21652001-01-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2166
2167 * bgp_nexthop.c (bgp_connected_add): Check point-to-point
2168 connected route. Reported by ruud@ruud.org (Ruud de Rooij)
2169
21702001-01-08 Kunihiro Ishiguro <kunihiro@zebra.org>
2171
2172 * bgp_nexthop.c (bgp_nexthop_lookup): When IBGP nexthop is
2173 changed, refresh it.
2174
21752001-01-04 Kunihiro Ishiguro <kunihiro@zebra.org>
2176
2177 * bgp_route.h (struct bgp_info_tag): Add as_selected to
2178 bgp_info_tag.
2179
21802001-01-03 Kunihiro Ishiguro <kunihiro@zebra.org>
2181
2182 * bgp_route.h (struct bgp_info_tag): Add damped and bgp_damp_info
2183 member for BGP flap dampening.
2184
2185 * bgp_damp.c: New file is added.
2186
2187 * bgp_damp.h: Likewise.
2188
21892001-01-01 Kunihiro Ishiguro <kunihiro@zebra.org>
2190
2191 * bgpd.h (BGP_VTYSH_PATH): Change "/tmp/bgpd" to "/tmp/.bgpd".
2192
21932000-12-29 Kunihiro Ishiguro <kunihiro@zebra.org>
2194
2195 * bgp_nexthop.c (zlookup_connect): Change to use UNIX domain
2196 socket for zebra communication.
2197
21982000-12-29 Akihiro Mizutani <mizutani@dml.com>
2199
2200 * bgp_route.c (bgp_process): Fix "bgp deterministic-med" process.
2201
22022000-12-27 Akihiro Mizutani <mizutani@dml.com>
2203
2204 * bgp_route.c (bgp_process): Add "bgp deterministic-med" process.
2205
22062000-12-25 Akihiro Mizutani <mizutani@dml.com>
2207
2208 * bgp_route.c (bgp_info_cmp): Use ntohl comparing router ID.
2209
22102000-12-18 Akihiro Mizutani <mizutani@dml.com>
2211
2212 * bgp_route.c (bgp_info_cmp): When over three same prefix exit,
2213 withdrawing best prefix perform router ID comparison.
2214
22152000-12-15 Akihiro Mizutani <mizutani@dml.com>
2216
2217 * bgp_route.c (bgp_info_cmp): Do not compare router ID when the
2218 routes comes from EBGP peer. When originator ID is same, take
2219 shorter cluster-list route. If cluster-list is same take smaller
2220 IP address neighbor's route.
2221
2222 * bgpd.c (bgp_bestpath_aspath_ignore): Add "bgp bestpath as-path
2223 ignore" command. When this option is set, do not concider AS path
2224 length when route selection.
2225 (bgp_bestpath_compare_router_id): Add "bgp bestpath
2226 compare-routerid". When this option is set, compare router ID
2227 when the routes comes from EBGP peer.
2228
22292000-12-15 Akihiro Mizutani <mizutani@dml.com>
2230
2231 * bgp_route.c (bgp_info_cmp): Compare originator ID when it is
2232 available.
2233
22342000-12-14 Akihiro Mizutani <mizutani@dml.com>
2235
2236 * bgp_packet.c (bgp_notify_receive): Disply received Notify data
2237 information.
2238
22392000-12-14 Kunihiro Ishiguro <kunihiro@zebra.org>
2240
2241 * bgp_filter.c (as_filter_free): Use MTYPE_AS_FILTER_STR to make
2242 it sure the memory is freed.
2243
2244 * bgp_route.c (route_vty_out_detail): Do not use AF_INET6 outside
2245 HAVE_IPV6.
2246
22472000-12-08 Akihiro Mizutani <mizutani@dml.com>
2248
2249 * bgp_packet.c (bgp_notify_send_with_data): Store BGP notification
2250 data part.
2251
2252 * bgp_network.c (bgp_accept): When BGP connection comes from
2253 unconfigured IP address, close socket immediately.
2254
2255 * bgpd.c: Fix some display format.
2256
22572000-11-29 Kunihiro Ishiguro <kunihiro@zebra.org>
2258
2259 * bgp_packet.c (bgp_keepalive_send): Delete duplicate
2260 bgp_packet_set_size () call.
2261
22622000-11-28 Kunihiro Ishiguro <kunihiro@zebra.org>
2263
2264 * bgp_packet.c (bgp_read_packet): Remove debug codes.
2265
22662000-11-27 Kunihiro Ishiguro <kunihiro@zebra.org>
2267
2268 * bgp_snmp.c (write_bgpPeerTable): Add SNMP set method routine.
2269
2270 * bgp_fsm.c (bgp_stop): Use fsm_change_status to change peer's
2271 status.
2272 (bgp_establish): Likewise.
2273
22742000-11-26 Akihiro Mizutani <mizutani@dml.com>
2275
2276 * bgp_open.c: Fix error messages.
2277
22782000-11-25 Kunihiro Ishiguro <kunihiro@zebra.org>
2279
2280 * bgp_fsm.c (bgp_establish): Call BGP trap when the peer is
2281 established.
2282 (bgp_stop): Call BGP trap when the peer is dropped.
2283
22842000-11-24 Kunihiro Ishiguro <kunihiro@zebra.org>
2285
2286 * bgp_snmp.c (bgp4PathAttrTable): Return BGP path attribute table.
2287
2288 * bgpd.h (struct peer): Add update_time for track last update
2289 received time.
2290
2291 * bgp_packet.c (bgp_notify_receive): Preserv notify code and sub
2292 code in any case.
2293
2294 * bgp_snmp.c (bgpPeerTable): Return remote router ID instead of
2295 peering IP address.
2296 (bgpPeerTable): Return actual BGP version number.
2297
22982000-11-22 Akihiro Mizutani <mizutani@dml.com>
2299
2300 * bgp_debug.c (bgp_notify_print): Notify data length display bug
2301 is fixed.
2302
23032000-11-16 Kunihiro Ishiguro <kunihiro@zebra.org>
2304
2305 * bgp_nexthop.c (zlookup_connect): When UNIX domain connection to
2306 zebra is enabled, use the method.
2307
23082000-11-16 Akihiro Mizutani <mizutani@dml.com>
2309
2310 * bgpd.c: Revise debug message output.
2311
23122000-11-15 Akihiro Mizutani <mizutani@dml.com>
2313
2314 * bgp_clist.c (ip_community_list): Fix bug of string comparison.
2315
23162000-11-14 Akihiro Mizutani <mizutani@dml.com>
2317
2318 * bgp_community.c (community_match): Fix bug of memcmp return
2319 value check.
2320
23212000-11-07 Kunihiro Ishiguro <kunihiro@zebra.org>
2322
2323 * bgp_clist.c (community_list_match_exact): Add check for
2324 entry->style is COMMUNITY_LIST.
2325 (community_match_regexp): Apply new com_nthval macro.
2326
23272000-11-07 Rick Payne <rickp@rossfell.co.uk>
2328
2329 * bgp_routemap.c (route_set_community_delete): "set
2330 community-delete COMMUNITY-LIST" is added.
2331
2332 * bgp_community.c (community_del_val): Delete one community.
2333 (community_delete): Delete all community included in list.
2334 (community_match): Fix bug of matching community value.
2335
2336 * bgp_clist.c (community_entry_free): Free community regular
2337 expression.
2338 (community_entry_make): Default style is COMMUNITY_LIST.
2339 (community_entry_lookup): Make it sure style is COMMUNITY_LIST.
2340 (community_entry_regexp_lookup): New function for community
2341 regular expression lookup.
2342 (community_match_regexp): New function.
2343 (community_delete_regexp): New function.
2344 (community_list_delete_entries): New function.
2345 (community_list_match): Add COMMUNITY_REGEXP treatment.
2346 (community_list_match_exact): Likewise.
2347 (config_write_community): Write community list according to
2348 entry->style.
2349
23502000-11-07 Rick Payne <rickp@rossfell.co.uk>
2351
2352 * bgp_attr.c (bgp_attr_aspath): AS path first AS check.
2353
2354 * bgp_clist.c (struct community_entry): Add style, regexp, reg to
2355 community_entry.
2356
23572000-11-06 Rick Payne <rickp@rossfell.co.uk>
2358
2359 * bgp_aspath.c (aspath_firstas_check): AS path first AS check.
2360
2361 * bgpd.c (bgp_enforce_first_as): New command "bgp
2362 enforce-first-as".
2363
2364 * bgpd.h (BGP_CONFIG_ENFORCE_FIRST_AS): Add new flag.
2365
23662000-11-06 Kunihiro Ishiguro <kunihiro@zebra.org>
2367
2368 * bgp_community.c (community_compare): Copy byte stream data to
2369 actual value instead of using type casting hack.
2370 (community_add_val): Likewise.
2371 (community_uniq_sort): Likewise.
2372 (community_print): Likewise.
2373 (community_print_vty): Likewise.
2374 (community_include): Use memcmp to compare community value.
2375
2376 * bgp_community.h (com_lastval): com_lastval and com_nthval macro
2377 return pointer.
2378
23792000-11-06 Akihiro Mizutani <mizutani@dml.com>
2380
2381 * bgpd.h (struct peer): Add established and dropped member for
2382 count peering up/down statistics.
2383
2384 * bgpd.c (bgp_show_peer): Display peering up/down statistics.
2385
2386 * bgp_fsm.c (bgp_establish): Increment established count.
2387 (bgp_stop): Increment dropped count.
2388
2389 * bgp_packet.c (bgp_notify_receive): Increament notify count.
2390
23912000-11-1 Akihiro Mizutani <mizutani@dml.com>
2392
2393 * bgp_fsm.c: Fix bug of holdtimer is not reset when bgp cleared.
2394
23952000-10-31 Kunihiro Ishiguro <kunihiro@zebra.org>
2396
2397 * bgpd.h: Static bit flag is set by (1 << DIGIT).
2398
23992000-10-24 Akihiro Mizutani <mizutani@dml.com>
2400
2401 * bgp_ecommunity.c (ecommunity_dup): Extended community display
2402 format fix.
2403
24042000-10-24 Arkadiusz Miskiewicz <misiek@pld.org.pl>
2405
2406 * bgp_network.c (bgp_serv_sock_addrinfo): Use gai_strerror.
2407 (bgp_serv_sock_addrinfo): Check address family.
2408
24092000-10-23 Jochen Friedrich <jochen@scram.de>
2410
2411 * bgp_snmp.c: bgp_oid and bgpd_oid are used in smux_open after it
2412 is registered. So those variables must be static.
2413
24142000-10-23 Akihiro Mizutani <mizutani@dml.com>
2415
2416 * bgp_routemap.c (route_match_ip_next_hop): Change "match ip
2417 next-hop" argument from IP address to access-list name.
2418 Remove zebra-0.88 compatibility commands.
2419 "match ip prefix-list WORD"
2420 "match ipv6 prefix-list WORD"
2421
24222000-10-23 Kunihiro Ishiguro <kunihiro@zebra.org>
2423
2424 * bgp_routemap.c (route_match_ipv6_next_hop_compile): Fix bug of
2425 passing the pointer to the pointer of struct in6_addr instead of
2426 the pointer of struct in6_addr in "match ipv6 next-hop" command.
2427
2428 * bgp_route.c (bgp_announce_check): Enclose IPv6 part with
2429 HAVE_IPV6.
2430
24312000-10-20 Jasper Wallace <jasper@ivision.co.uk>
2432
2433 * bgp_snmp.c (bgpPeerTable): ntohs missing bug is fixed. Change
2434 to use linklist.c. Define COUNTER32 as ASN_COUNTER.
2435
24362000-10-18 Kunihiro Ishiguro <kunihiro@zebra.org>
2437
2438 * bgp_route.c (bgp_announce_check): attr->nexthop empty check
2439 should be done by attr->nexthop.s_addr instead of strcmp.
2440
24412000-10-18 Akihiro Mizutani <mizutani@dml.com>
2442
2443 * bgp_zebra.c (zebra_read_ipv4): Pass nexthop value to
2444 bgp_redistribute_add().
2445
2446 * bgp_nexthop.c (bgp_multiaccess_check_v4): New function for
2447 checking IPv4 multiaccess nexthop.
2448
2449 * bgp_route.c (bgp_announce_check): In case of the nexthop is
2450 reachable on multiaccess media, do not change nexthop.
2451 (bgp_redistribute_add): Set nexthop when the value is passed.
2452
24532000-10-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2454
2455 * bgp_fsm.c (bgp_timer_set): If peer is passive mode, do not set
2456 connect timer.
2457 (bgp_start): If the peer is passive mode, force to move to Active
2458 mode.
2459
24602000-10-17 Horms <horms@vergenet.net>
2461
2462 * bgp_debug.c (debug_bgp_fsm): Fix typo.
2463
24642000-10-17 Akihiro Mizutani <mizutani@dml.com>
2465
2466 * bgp_route.c: "show ipv6 bgp" route display improvement.
2467
24682000-10-03 Kunihiro Ishiguro <kunihiro@zebra.org>
2469
2470 * bgp_route.c (neighbor_routes): Allocate sockunion for callback
2471 function.
2472 (bgp_show_neighbor_route): Remove static declaration for union
2473 sockunion.
2474
2475 * bgpd.c (peer_update_source_set): Clean previously allocated
2476 memory before allocate new one.
2477
24782000-10-03 Akihiro Mizutani <mizutani@dml.com>
2479
2480 * bgp_route.c (neighbor_routes): Add show neighbor's routes
2481 command.
2482 "show ip bgp neighbors (A.B.C.D|X:X::X:X) routes"
2483 "show ip bgp ipv4 (unicast|multicast) neighbors (A.B.C.D|X:X::X:X) routes"
2484 "show ipv6 bgp neighbors (A.B.C.D|X:X::X:X) routes"
2485 "show ipv6 mbgp neighbors (A.B.C.D|X:X::X:X) routes"
2486
24872000-10-02 Kunihiro Ishiguro <kunihiro@zebra.org>
2488
2489 * zebra-0.89 is released.
2490
24912000-10-02 Akihiro Mizutani <mizutani@dml.com>
2492
2493 * bgpd.c: "bgp deterministic-med" command is added.
2494
24952000-10-02 Kunihiro Ishiguro <kunihiro@zebra.org>
2496
2497 * bgp_nexthop.c (bgp_connected_add): Apply mask for connected
2498 route addition and deletion.
2499
25002000-09-29 Kunihiro Ishiguro <kunihiro@zebra.org>
2501
2502 * bgp_aspath.c (aspath_cmp_left): Skip confederation AS segment
2503 when comparing leftmost AS number.
2504
25052000-09-29 Akihiro Mizutani <mizutani@dml.com>
2506
2507 * bgpd.c (peer_route_reflector): Route reflector can be set for
2508 IBGP peer.
2509 (bgp_distribute_set): Fix bug of string check for (in|out).
2510 (bgp_show_summary): Display total neighbor count.
2511
25122000-09-28 Akihiro Mizutani <mizutani@dml.com>
2513
2514 * bgp_attr.c (bgp_packet_attribute): Only add cluster_list and
2515 originator for clinet to client routes.
2516 (bgp_packet_attribute): Add new cluster_list to the beginning of
2517 existing cluster_list.
2518 (bgp_packet_attribute): Fix bug of originator is rewritten even
2519 when originator is already set.
2520
25212000-09-27 Kunihiro Ishiguro <kunihiro@zebra.org>
2522
2523 * bgpd.c (bgp_client_to_client_reflection): Add new command.
2524 "no bgp client-to-client reflection"
2525 "bgp client-to-client reflection"
2526
2527 * bgpd.h (BGP_CONFIG_NO_CLIENT_TO_CLIENT): Add new definition.
2528
25292000-09-26 Kunihiro Ishiguro <kunihiro@zebra.org>
2530
2531 * bgp_packet.c (bgp_read): Make BGP packet read to non-blocking
2532 read.
2533 (bgp_read_packet): Likewise.
2534 (bgp_read_packet): When errono is EAGAIN, try to read it again.
2535
2536 * bgp_fsm.c (bgp_stop): Clear packet size and read buffer.
2537
25382000-09-26 Akihiro Mizutani <mizutani@dml.com>
2539
2540 * bgp_routemap.c: Configuration of prefix-list match is shown as
2541 "match ip address prefix-list <WORD>". Old configuration "match
2542 ip prefix-list <WORD>" is left for compatibilitty.
2543
25442000-09-25 Akihiro Mizutani <mizutani@dml.com>
2545
2546 * bgpd.h (BGP_CONFIG_MED_MISSING_AS_WORST): Changed from
2547 BGP_CONFIG_MISSING_AS_WORST.
2548
2549 * bgpd.c (bgp_bestpath_med): Change missing-as-worst syntax.
2550 Old "bgp bestpath missing-as-worst"
2551 New "bgp bestpath med missing-as-worst"
2552
25532000-09-24 Akihiro Mizutani <mizutani@dml.com>
2554
2555 * bgp_route.c: Compare MED properly in case of CONFED-IBGP.
2556
25572000-09-21 steve@Watt.COM (Steve Watt)
2558
2559 * bgp_debug.h: Do not declare debug variables conf_bgp_debug_* and
2560 term_bgp_debug_*.
2561
2562 * bgp_debug.c: Declare variables here.
2563
25642000-09-21 Akihiro Mizutani <mizutani@dml.com>
2565
2566 * bgpd.c: MBGP soft-reconfiguration command is added.
2567 clear ip bgp x.x.x.x ipv4 (unicast|multicast) in
2568 clear ip bgp x.x.x.x ipv4 (unicast|multicast) out
2569 clear ip bgp x.x.x.x ipv4 (unicast|multicast) soft
2570 clear ip bgp <1-65535> ipv4 (unicast|multicast) in
2571 clear ip bgp <1-65535> ipv4 (unicast|multicast) out
2572 clear ip bgp <1-65535> ipv4 (unicast|multicast) soft
2573 clear ip bgp * ipv4 (unicast|multicast) in
2574 clear ip bgp * ipv4 (unicast|multicast) out
2575 clear ip bgp * ipv4 (unicast|multicast) soft
2576
2577 Change "clear ip bgp vpnv4 x.x.x.x soft" command to
2578 "clear ip bgp x.x.x.x vpnv4 unicast soft".
2579
2580 "bgp bestpath med confed" command is added.
2581
2582 * bgpd.h (BGP_CONFIG_MED_CONFED): Add New definition.
2583
25842000-09-18 Rick Payne <rickp@rossfell.co.uk>
2585
2586 * bgpd.c (bgp_show_peer): Fix misplaced #endif.
2587
25882000-09-12 Akihiro Mizutani <mizutani@dml.com>
2589
2590 * bgpd.c (bgp_default_local_preference): Add "bgp default
2591 local-preference" command.
2592
2593 * bgp_nexthop.c (no_bgp_scan_time): Add "no bgp scan-time"
2594 command.
2595
25962000-09-10 Kunihiro Ishiguro <kunihiro@zebra.org>
2597
2598 * bgp_zebra.c (bgp_zebra_announce): BGP confederation peer's routes
2599 are passed to zebra like IBGP route.
2600
26012000-09-10 Akihiro Mizutani <mizutani@dml.com>
2602
2603 * bgpd.c (bgp_config_write_peer): Make it consistent passive
2604 configuration.
2605
2606 * bgp_route.c: Community match command is added.
2607 "show ip bgp community <val>"
2608 "show ip bgp community <val> exact-match"
2609
26102000-09-08 Kunihiro Ishiguro <kunihiro@zebra.org>
2611
2612 * bgp_nexthop.c (bgp_nexthop_lookup): ebgp-multihop routes are
2613 treated as IBGP routes.
2614
26152000-09-08 Akihiro Mizutani <mizutani@dml.com>
2616
2617 * bgp_route.c (bgp_show_route): When local-AS community route is
2618 selected, display "not advertised outside local AS" to "show ip
2619 route A.B.C.D" output.
2620 (show_ip_bgp_ipv4_filter_list): Add below four commands.
2621 "show ip bgp ipv4 (unicast|multicast) filter-list WORD"
2622 "show ip bgp ipv4 (unicast|multicast) community"
2623 "show ip bgp ipv4 (unicast|multicast) community-list WORD"
2624 "show ip bgp ipv4 (unicast|multicast) community-list WORD exact-match"
2625
2626 * bgp_clist.c (community_list_match_exact): Community exact match
2627 function.
2628
26292000-09-07 Kunihiro Ishiguro <kunihiro@zebra.org>
2630
2631 * bgp_route.c (bgp_update): Add peer's ttl check.
2632
2633 * bgpd.h (struct peer): Structure member refresh is renamed to
2634 refresh_adv.
2635
2636 * bgpd.c (clear_bgp_soft_in): Check PEER_FLAG_ROUTE_REFRESH flag
2637 when soft reconfiguration is performed.
2638
2639 * bgp_zebra.c (bgp_zebra_announce): When the peer is EBGP and
2640 ebgp-multiphop is set, set ZEBRA_FLAG_INTERNAL for nexthop lookup.
2641
2642 * bgp_route.h (struct bgp_info_tag): Add valid flag.
2643
26442000-08-25 Akihiro Mizutani <mizutani@dml.com>
2645
2646 * bgpd.c: Add AS base BGP soft reconfiguration.
2647
2648 * bgp_route.c: When no-advertise or no-export route is selected,
2649 "show ip bgp" display "not advertised to EBGP peer" or "not
2650 advertised to any peer" message.
2651
26522000-08-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2653
2654 * zebra-0.88 is released.
2655
2656 * bgp_dump.c (dump_bgp_routes): Change "dump bgp routes" to "dump
2657 bgp route-mrt" to support MRT specific dump format.
2658
2659 * bgpd.c (bgp_init): "clear ip bgp vpnv4 soft {in,out}" command is
2660 added.
2661
2662 * bgp_route.c (bgp_update): Currently nexthop check is only works
2663 for IPv4.
2664
26652000-08-17 Akihiro Mizutani <mizutani@dml.com>
2666
2667 * bgpd. (clear_ip_bgp_all_soft): Add "clear ip bgp * soft" for
2668 both inbound and outbound soft reconfiguration.
2669
26702000-08-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2671
2672 * bgpd.c (clear_ip_bgp_peer_soft_out): Add soft-reconfiguration
2673 outbound.
2674 (peer_new): Set route-refresh flag.
2675
26762000-08-16 Akihiro Mizutani <mizutani@dml.com>
2677
2678 * bgpd.c: "no bgp router-id A.B.C.D" alias is added. "no bgp
2679 cluster-id A.B.C.D" alias is added. " bgp cluster-id
2680 <1-4294967295>" alias is added. "clear ip bgp * soft in" command
2681 is added. "clear ip bgp A.B.C.D in" alias is added. "clear ip
2682 bgp * in" alias is added.
2683
26842000-08-16 Kunihiro Ishiguro <kunihiro@zebra.org>
2685
2686 * bgp_route.c (bgp_update): Add soft_reconfig flag. When the flag
2687 is set do not install the route into Adj-RIBs-In.
2688 (bgp_update): Perform implicit withdraw before filtering of the
2689 route.
2690
2691 * bgp_packet.c (bgp_read): draft-ietf-idr-bgp-route-refresh-01.txt
2692 capability code and BGP message can be accepted.
2693
2694 * bgp_open.c (bgp_capability_parse): Likewise.
2695
2696 * bgp_route.c (bgp_refresh_table): New function for route refresh.
2697 (bgp_refresh_rib): Likewise.
2698
2699 * bgpd.c (bgp_show_peer): Display route refresh status.
2700
2701 * bgp_route.c (bgp_aggregate_add): Add check for the route
2702 validness.
2703 (bgp_aggregate_delete): Likewise.
2704
27052000-08-15 Kunihiro Ishiguro <kunihiro@zebra.org>
2706
2707 * bgp_nexthop.c (bgp_scan): Care for aggregate route when the
2708 route become inaccessible.
2709
27102000-08-15 Akihiro Mizutani <mizutani@dml.com>
2711
2712 * bgp_route.c (show_ip_bgp_prefix): "show ip bgp A.B.C.D/M"
2713 command is added.
2714
27152000-08-15 Kunihiro Ishiguro <kunihiro@zebra.org>
2716
2717 * bgp_zebra.c (bgp_interface_up): Register connected route.
2718 (bgp_interface_down): Unregister connected route.
2719
27202000-08-14 Kunihiro Ishiguro <kunihiro@zebra.org>
2721
2722 * bgp_route.h (struct bgp_info): Add distance to the structure.
2723
2724 * bgp_route.c (bgp_aggregate_increment): Aggregate route only
2725 match to smaller prefixlen route not match same prefixlen route.
2726 (bgp_aggregate_decrement): Likewise.
2727 (bgp_aggregate_add): Likewise.
2728 (bgp_aggregate_delete): Likewise.
2729 (bgp_network_backdoor): Add backdoor network configuration.
2730
2731 * bgpd.h (struct bgp ): Add distance_{ebgp,ibgp,local} for store
2732 configuration distance value.
2733
2734 * bgp_route.c (bgp_update): Filter EBGP route which has non
2735 connected nexthop.
2736
2737 * bgp_attr.c (bgp_attr_aggregate_intern): New function for
2738 aggregate route. Set origin to IGP. Set atomic aggregate flag.
2739 Set aggregator AS and address.
2740 (bgp_attr_aggregate_intern): Check BGP_CONFIG_CONFEDERATION when
2741 filling aggregator_as.
2742
2743 * bgp_route.c (bgp_process): Delete suppress check for install
2744 suppressed route into local routing table.
2745 (bgp_aggregate_increment): Use bgp_attr_aggregate_intern() instead
2746 of bgp_attr_default_intern ().
2747 (bgp_aggregate_add): Likewise.
2748
2749 * bgpd.c (bgp_get): Call bgp_if_update_all() after BGP instance is
2750 created. This is for avoid 0.0.0.0 router-id.
2751
27522000-08-13 Akihiro Mizutani <mizutani@dml.com>
2753
2754 * bgp_route.c (route_vty_out_detail): Display "valid" when the
2755 route is valied. Display "aggregated" when the route is
2756 aggregated. "Advertisements suppressed by an aggregate" is
2757 displayed when the route is suppressed.
2758 (bgp_info_cmp): Prefer EBGP than Confed-EBGP.
2759
27602000-08-10 Akihiro Mizutani <mizutani@dml.com>
2761
2762 * bgp_route.c (route_vty_out_detail): Display format change.
2763
27642000-08-06 Kunihiro Ishiguro <kunihiro@zebra.org>
2765
2766 * bgp_route.c (bgp_update): Only AFI_IP nexthop check is enabled.
2767
2768 * bgpd.c (bgp_delete): Delete static route before delete peer
2769 configuration.
2770
27712000-08-02 Kunihiro Ishiguro <kunihiro@zebra.org>
2772
2773 * bgpd.c: Include bgpd/bgp_nexthop.h.
2774
27752000-07-31 Akihiro Mizutani <mizutani@dml.com>
2776
2777 * bgpd.c (bgp_show_summary): "show ip bgp summary" shows own BGP
2778 identifier. And status is changed like below.
2779
2780 State/Pref -> State/PfxRcd
2781 Shutdown -> Idle (Admin)
2782 PrefixOvflw -> Idle (PfxCt)
2783
2784 * bgp_route.c (route_vty_out): Show internal route as "i".
2785
27862000-07-13 Jim Bowen <jimb@zereau.net>
2787
2788 * bgp_snmp.c: Add BGP peer MIB implementation.
2789
27902000-07-12 Akihiro Mizutani <mizutani@dml.com>
2791
2792 * bgpd.c (bgp_show_peer): Fix typo.
2793
27942000-07-11 Akihiro Mizutani <mizutani@dml.com>
2795
2796 * bgp_routemap.c: Add commands for deleting set without argument.
2797
27982000-07-03 Akihiro Mizutani <mizutani@dml.com>
2799
2800 * bgp_zebra.c: Fix redistribute help strings.
2801
28022000-07-01 Kunihiro Ishiguro <kunihiro@zebra.org>
2803
2804 * bgp_route.c (bgp_show): When bgpd works as vtysh server send all
2805 output to vty at once.
2806
28072000-06-13 Kunihiro Ishiguro <kunihiro@zebra.org>
2808
2809 * bgp_mplsvpn.c (no_vpnv4_network): "no network A.B.C.D/M rd WORD
2810 tag WORD" command is added.
2811
2812 * bgp_ecommunity.c (ecommunity_vty_out): New function added.
2813
28142000-06-12 Kunihiro Ishiguro <kunihiro@zebra.org>
2815
2816 * bgp_route.c (bgp_show): Fix total number of prefix count bug.
2817
2818 * bgpd.c (bgp_show_peer): Display VPNv4 unicast configuration and
2819 negotiation result in "show ip bgp neighbors".
2820
28212000-06-12 Akihiro Mizutani <mizutani@dml.com>
2822
2823 * bgpd.c: Fix help strings.
2824
2825 * bgpd.h: Likewise.
2826
28272000-06-11 Kunihiro Ishiguro <kunihiro@zebra.org>
2828
2829 * bgp_route.c (bgp_aggregate_unset): Fix bug of checking rn->info
2830 instead of rn. Reported by Akihiro Mizutani <mizutani@dml.com>.
2831
2832 * bgp_mplsvpn.c (vpnv4_network): For testing purpose, "network
2833 A.B.C.D rd RD" is added to address-family vpnv4 unicast node.
2834
2835 * bgp_route.c (bgp_static_set): Set safi to p.safi.
2836
28372000-06-10 Kunihiro Ishiguro <kunihiro@zebra.org>
2838
2839 * bgp_route.c (bgp_show_prefix_list): Change to use bgp_show().
2840 (bgp_show_regexp): Change to use bgp_show().
2841 (show_adj_route): Change to display header.
2842
2843 * bgpd.c (clear_bgp): Set peer->v_start to default value when peer
2844 is cleared manually.
2845
2846 * bgp_route.c (bgp_show_route): New function which display
2847 specific BGP route. Divided from bgp_show().
2848 (bgp_static_delete): Delete all static route.
2849
28502000-06-09 NOGUCHI Kay <kay@v6.access.co.jp>
2851
2852 * bgp_route.c (show_ipv6_bgp): "show ipv6 bgp" is broken with
2853 invalid privious fix. Now show_ipv6_bgp and show_ipv6_bgp_route
2854 take care of "show ipv6 bgp [X:X::X:X]". Same change for "show ip
2855 mbgp" and "show ipv6 mbgp".
2856
28572000-06-07 Akihiro Mizutani <mizutani@dml.com>
2858
2859 * bgp_route.c: Fix help strings and command arguments.
2860
28612000-06-06 Kunihiro Ishiguro <kunihiro@zebra.org>
2862
2863 * bgp_ecommunity.c: Include prefix.h
2864
28652000-06-05 Kunihiro Ishiguro <kunihiro@zebra.org>
2866
2867 * bgp_route.h (struct bgp_info_tag): New structure to hold tag
2868 value.
2869
2870 * bgp_route.c (bgp_adj_set): table NULL check is added.
2871 (bgp_adj_unset): Likewise.
2872 (bgp_adj_lookup): Likewise.
2873 (bgp_adj_clear): Likewise.
2874 (route_vty_out): Add SAFI check for nexthop display.
2875 (bgp_withdraw): Add SAFI check for withdraw route.
2876
2877 * Remove all #ifdef MPLS_VPN then include it as default.
2878
2879 * bgpd.c: Temporary disable peer-group command until the
2880 implementation is completed.
2881
2882 * bgp_routemap.c (bgp_route_map_init): Install
2883 route_metric_match_cmd.
2884 (route_match_metric_compile): MED value compile using strtoul.
2885
28862000-06-05 Akihiro Mizutani <mizutani@dml.com>
2887
2888 * bgp_filter.c: Fix help strings. Change REGEXP to LINE. Change
2889 NAME to WORD.
2890
2891 * Change command argument to more comprehensive.
2892
2893 METRIC -> <0-4294967295>
2894 WEIGHT -> <0-4294967295>
2895 LOCAL_PREF -> <0-4294967295>
2896 IP_ADDR -> A.B.C.D
2897 AS -> <1-65535>
2898 AS-PATH-NAME -> WORD
2899 ACCESS_LIST -> WORD
2900 PREFIX_LIST -> WORD
2901 COMMUNITY -> AA:NN
2902 EXT_COMMUNITY -> ASN:nn_or_IP-address:nn
2903 IPv6_ADDR -> X:X::X:X
2904
2905 * bgp_clist.c: Fix help strings.
2906
29072000-06-03 Kunihiro Ishiguro <kunihiro@zebra.org>
2908
2909 * bgpd.c (peer_active): Add new function for check the peer is
2910 active or not.
2911 (neighbor_activate): New command "neighbor PEER activate" and "no
2912 neighbor PEER activate" are added.
2913
2914 * bgp_packet.c: Include bgpd/bgp_mplsvpn.h.
2915
29162000-06-02 Akihiro Mizutani <mizutani@dml.com>
2917
2918 * bgp_clist.c: Fix commuity-list help strings.
2919
2920 * bgp_routemap.c: Fix "set community" help strings. Add #define
2921 SET_STR. Use (unicast|multicast) argument for "set nlri" command.
2922
29232000-06-01 Kunihiro Ishiguro <kunihiro@zebra.org>
2924
2925 * bgp_routemap.c (route_set_community_none_cmd): "set community
2926 none" command is added to route-map.
2927
29282000-06-01 Akihiro Mizutani <mizutani@dml.com>
2929
2930 * bgp_debug.c: Change "show debug" to "show debugging". Now "show
2931 debugging" is not used in VIEW_NODE.
2932
29332000-05-30 Kunihiro Ishiguro <kunihiro@zebra.org>
2934
2935 * bgp_fsm.c (bgp_timer_set): Add check for shutdown flag. This
2936 fix unconditional BGP connection.
2937
2938 * bgpd.c (peer_shutdown): Replace peer_shutdown() with
2939 peer_change_flag_with_reset().
2940
29412000-05-26 Kunihiro Ishiguro <kunihiro@zebra.org>
2942
2943 * bgpd.c (no_bgp_default_ipv4_unicast): Add "no bgp default
2944 ipv4-unicast" command.
2945
2946 * bgpd.h (BGP_CONFIG_NO_DEFAULT_IPV4): Add new definition.
2947
2948 * bgp_filter.c (as_list_delete): Free all AS filter.
2949
2950 * bgp_clist.c (community_list_delete): Free all community entry.
2951
2952 * bgp_filter.c (no_ip_as_path_all): New DEFUN for "no ip as-path
2953 access-list NAME".
2954
2955 * bgp_clist.c (no_ip_community_list_all): New DEFUN for "no ip
2956 community-list NAME".
2957
29582000-05-19 Kunihiro Ishiguro <kunihiro@zebra.org>
2959
2960 * bgp_route.c (ipv6_mbgp_neighbor_routes): Change "show ip bgp PEER
2961 routes" to "show ip bgp PEER received-routes"
2962
29632000-05-14 Kunihiro Ishiguro <kunihiro@zebra.org>
2964
2965 * bgp_ecommunity.c (ecommunity_parse): New file for Extended
2966 Communities attribute.
2967 * bgp_ecommunity.h: Likewise.
2968
29692000-05-11 Kunihiro Ishiguro <kunihiro@zebra.org>
2970
2971 * bgp_mplsvpn.h: New file for MPLS-VPN.
2972 * bgp_mplsvpn.c: Likewise.
2973
2974 * bgpd.c (bgp_delete): Fix bug of "no router bgp" crush.
2975
29762000-05-10 Kunihiro Ishiguro <kunihiro@zebra.org>
2977
2978 * bgpd.c (bgp_bestpath_missing_as_worst): Add "bgp bestpath
2979 missing-as-worst".
2980
29812000-05-08 Kunihiro Ishiguro <kunihiro@zebra.org>
2982
2983 * bgp_routemap.c (match_community): Clarify help of "match
2984 community".
2985
29862000-05-02 Kunihiro Ishiguro <kunihiro@zebra.org>
2987
2988 * bgp_aspath.c (aspath_cmp_left): Remove debug code.
2989
29902000-04-27 Kunihiro Ishiguro <kunihiro@zebra.org>
2991
2992 * bgp_route.c (bgp_info_cmp): Compare MED only both routes comes
2993 from same neighboring AS.
2994
2995 * bgp_aspath.c (aspath_cmp_left): Compare leftmost AS value.
2996
2997 * bgp_route.c (bgp_info_cmp): Fix misused htonl() to ntohl().
2998
29992000-04-26 Kunihiro Ishiguro <kunihiro@zebra.org>
3000
3001 * bgp_route.c (bgp_output_filter): When distribute-list's
3002 corresponding access-list does not exist, filter all routes.
3003 (bgp_input_filter): Likewise.
3004
30052000-04-19 Kunihiro Ishiguro <kunihiro@zebra.org>
3006
3007 * bgp_attr.c (bgp_packet_attribute): Propagate MED to IBGP peer.
3008
3009 * bgp_route.c (bgp_info_cmp): Add evaluation of local preference.
3010
30112000-04-18 Kunihiro Ishiguro <kunihiro@zebra.org>
3012
3013 * bgpd.c (bgp_distribute_update): Add struct access_list *
3014 argument.
3015
30162000-04-17 Kunihiro Ishiguro <kunihiro@zebra.org>
3017
3018 * bgp_clist.c (community_list_dup_check): Add duplicate insertion
3019 check.
3020
3021 * bgp_filter.c (as_list_dup_check): Add duplicate insertion check.
3022
3023 * bgp_route.c (bgp_show): Fix undeclared write variable.
3024
30252000-04-13 Kunihiro Ishiguro <kunihiro@zebra.org>
3026
3027 * bgp_routemap.c: Add "match ip address prefix-list".
3028
30292000-03-29 Rick Payne <rickp@rossfell.co.uk>
3030
3031 * bgp_aspath.c (aspath_strip_confed): Fix realloc problem.
3032
30332000-03-16 Kunihiro Ishiguro <kunihiro@zebra.org>
3034
3035 * bgp_fsm.c (bgp_reconnect): Connect retry timer is expired when
3036 the peer status is Connect.
3037
30382000-03-03 Kunihiro Ishiguro <kunihiro@zebra.org>
3039
3040 * Fix bug of rewritten originator-id.
3041
30422000-01-27 Rick Payne <rickp@rossfell.co.uk>
3043
3044 * bgp_aspath.c (aspath_delimiter_char): New function. Instead of
3045 directly referencing array, search proper AS path delimiter.
3046 (aspath_strip_confed): Strip the confederation stuff from the
3047 front of an AS path.
3048 (aspath_add_left_confed): New function for adding specified AS to
3049 the leftmost AS_CONFED_SEQUENCE.
3050
3051 * bgp_aspath.h: Change AS_CONFED_SEQUENCE and AS_CONFED_SET value
3052 to Cisco compatible.
3053
3054 * bgpd.c (bgp_confederation_id_set): Confederation configuration.
3055 (bgp_confederation_id_unset): Likewise.
3056 (bgp_confederation_peers_check): Likewise.
3057 (bgp_confederation_peers_add): Likewise.
3058 (bgp_confederation_peers_remove): Likewise.
3059 (bgp_confederation_peers_set): Likewise.
3060 (bgp_confederation_peers_unset): Likewise.
3061 (bgp_confederation_peers_print): Likewise.
3062
30632000-01-16 Kunihiro Ishiguro <kunihiro@zebra.org>
3064
3065 * bgpd.c: Introduce peer_change_flag_with_reset() fucntion.
3066
30672000-01-17 Kunihiro Ishiguro <kunihiro@zebra.org>
3068
3069 * bgp_open.c (bgp_open_option_parse): When there is no common
3070 capability send Unsupported Capability error to the peer.
3071
30722000-01-14 Kunihiro Ishiguro <kunihiro@zebra.org>
3073
3074 * bgp_open.c (bgp_capability_mp): Fix bug of mis-negotiation about
3075 IPv6 unicast.
3076
3077 * bgpd.c (bgp_init): Add "soft-reconfiguration inbound" command.
3078
30792000-01-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3080
3081 * bgpd.c (neighbor_strict_capability): Add
3082 "strict-capability-match" command.
3083
3084 * bgp_zebra.c (bgp_if_update): Ignore NET127 determining
3085 router-id.
3086
3087 * bgpd.c (peer_override_capability): Add "override-capability"
3088 command.
3089
30901999-12-16 Kunihiro Ishiguro <kunihiro@zebra.org>
3091
3092 * bgp_packet.c (bgp_write): Change status to Idle and set timer
3093 after write failed.
3094
30951999-12-14 Kunihiro Ishiguro <kunihiro@zebra.org>
3096
3097 * bgp_zebra.c (bgp_zebra_announce): Add info->selected check.
3098
30991999-12-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3100
3101 * bgp_route.c (nlri_unfeasible): nlri_unfeasible() is merged with
3102 nlri_parse().
3103
31041999-12-10 Kunihiro Ishiguro <kunihiro@zebra.org>
3105
3106 * bgp_fsm.h (BGP_EVENT_DELETE): Macro added.
3107
3108 * bgp_fsm.c (bgp_stop): Clear all event threads of the peer when
3109 the peer is cleared.
3110
3111 * bgp_zebra.c (bgp_nexthop_set): Clear interface index of
3112 link-local address. This is KAME specific problem.
3113
31141999-12-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3115
3116 * bgp_attr.c (bgp_mp_reach_parse): Comment out previous code for a
3117 while. We don't completely detect the link is shared or not at
3118 this moment.
3119
3120 * bgp_packet.c (bgp_notify_send): Make shortcut call of
3121 bgp_write() and bgp_stop().
3122
3123 * bgp_attr.c (bgp_mp_reach_parse): Fix serious bug when getting
3124 global and link-local address.
3125
31261999-12-05 Kunihiro Ishiguro <kunihiro@zebra.org>
3127
3128 * bgpd.c (no_neighbor_port): New command added.
3129 (peer_new): Set send_community.
3130
31311999-12-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3132
3133 * bgpd.c (show_ip_bgp_summary): Changed to use bgp_show_summary().
3134 (show_ip_mbgp_summary): Likewise.
3135 (show_ipv6_bgp_summary): Likewise.
3136 (show_ipv6_mbgp_summary): Add new command.
3137 (peer_free): Free peer->host.
3138 (peer_lookup_by_su): Delete function.
3139 (ipv6_bgp_neighbor): Changed to use peer_remote_as().
3140 (sockunion_vty_out): Function deleted.
3141 (vty_clear_bgp): Use afi instead of family.
3142 Delete old list bgp_list. Use struct newlist *bgplist.
3143 (peer_lookup_by_host): Function deleted.
3144
31451999-12-03 Kunihiro Ishiguro <kunihiro@zebra.org>
3146
3147 * bgpd.h (struct peer_group): New structure added.
3148 (struct peer_conf): New structure added.
3149 (struct peer): Change all prefix_count to unsigned long.
3150
3151 * bgpd.c: Reconstruct all of VTY commands reflect internal
3152 structure change.
3153 Use bgplist instead of bgp_list.
3154 Use peerlist intstead of peer_list.
3155
3156 * bgp_attr.c (bgp_mp_reach_parse): If nlri_parse return -1, stop
3157 parsing then return immediately.
3158
3159 * bgp_route.c (nlri_parse): When NLRI parse error occured, return
3160 -1.
3161 (nlri_process): Use pcount_v4_{unicast,multicast}.
3162 (nlri_delete): Likewise.
3163
31641999-11-25 Robert Olsson <Robert.Olsson@data.slu.se>
3165
3166 * bgp_routemap.c (route_match_nlri): `match nlri
3167 unicast|multicast' and `set nlri unicast|multicast' command are
3168 added.
3169
31701999-11-22 Robert Olsson <Robert.Olsson@data.slu.se>
3171
3172 * bgpd.c: Add translate-update support.
3173
3174 * bgpd.h (TRANSLATE_UPDATE_OFF): Add translate-update definition.
3175
31761999-11-19 Robert.Olsson@data.slu.se
3177
3178 * bgp_route.c (bgp_peer_delete): Add MBGP peer clear codes.
3179
31801999-11-14 Kunihiro Ishiguro <kunihiro@zebra.org>
3181
3182 * bgp_open.c (bgp_capability_mp): Temporary comment out
3183 SAFI_UNICAST_MULTICAST handling until we know the meanings.
3184
31851999-11-13 Kunihiro Ishiguro <kunihiro@zebra.org>
3186
3187 * bgp_btoa.c: New file added.
3188
31891999-11-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3190
3191 * bgpd.h (struct peer): Add dont_capability flag.
3192 (struct peer): Add override_capability flag.
3193
3194 * bgpd.c (neighbor_dont_capability_negotiation): `neighbor PEER
3195 dont-capability-negotiation' added.
3196
31971999-11-12 Bill Sommerfeld <sommerfeld@orchard.arlington.ma.us>
3198
3199 * bgp_attr.c (bgp_mp_reach_parse): Ignore link-local addresses
3200 attribute from non-shared-network peers.
3201
32021999-11-10 Kunihiro Ishiguro <kunihiro@zebra.org>
3203
3204 * bgp_snmp.c: New file added.
3205
3206 * BGP4-MIB.txt: Updated to the latest Internet-Draft
3207 draft-ietf-idr-bgp4-mib-04.txt.
3208
32091999-11-09 Kunihiro Ishiguro <kunihiro@zebra.org>
3210
3211 * bgp_route.c (bgp_route_init): Add `show ipv6 bgp prefix-list'.
3212
3213 * bgp_attr.c (bgp_mp_unreach_parse): Enclose safi setup with
3214 #ifdef HAVE_MBGPV4.
3215
32161999-11-08 Kunihiro Ishiguro <kunihiro@zebra.org>
3217
3218 * bgp_dump.c (no_dump_bgp_all): Add [PATH] and [INTERVAL] to no
3219 dump bgp commands.
3220 (config_write_bgp_dump): Write interval value to the
3221 configuration.
3222
32231999-11-07 Kunihiro Ishiguro <kunihiro@zebra.org>
3224
3225 * bgp_zebra.c: Redistribute route-map support is added.
3226
3227 * bgp_zebra.h: New file added.
3228
32291999-11-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3230
3231 * bgp_dump.c: BGP packet dump routine compatible with MRT.
3232 * bgp_dump.h: BGP packet dump routine compatible with MRT.
3233
3234 * bgp_debug.c: Renamed from bgp_dump.c
3235 * bgp_debug.h: Renamed from bgp_dump.h
3236
32371999-10-27 Kunihiro Ishiguro <kunihiro@zebra.org>
3238
3239 * BGP4-MIB.txt: New file added. Edited version of RFC1657.
3240
32411999-10-25 Bill Sommerfeld <sommerfeld@orchard.arlington.ma.us>
3242
3243 * bgp_route.c (bgp_announce): If we're not on a shared network
3244 with the peer and we don't have a link-local next hop, but the
3245 inbound next-hop has a link-local address, don't readvertise it to
3246 our peer.
3247
32481999-10-25 Marc Boucher <marc@mbsi.ca>
3249
3250 * bgp_zebra.c: Add redistribute kernel command.
3251
32521999-10-25 Kunihiro Ishiguro <kunihiro@zebra.org>
3253
3254 * bgp_route.c (bgp_reset): New function added.
3255
3256 * bgpd.conf.sample2: Add IPv6 configuration sample.
3257
32581999-10-24 Bill Sommerfeld <sommerfeld@orchard.arlington.ma.us>
3259
3260 * bgp_route.c (ipv6_aggregate_address): Function added.
3261
32621999-10-21 Kunihiro Ishiguro <kunihiro@zebra.org>
3263
3264 * bgp_packet.c (bgp_update): Unintern aspath, community, cluster
3265 list after parsing BGP update packet.
3266
3267 * bgp_attr.c (bgp_attr_aspath): Intern parsed aspath.
3268 (bgp_attr_community): Intern parsed community.
3269 (bgp_attr_cluster_list): Intern parsed cluster list.
3270
3271 * bgp_routemap.c: Add `set community-additive' command.
3272
32731999-10-21 Alexandr D. Kanevskiy <kad@blackcatlinux.com>
3274
3275 * bgp_routemap.c (route_set_local_pref): Fix bug of setting
3276 attribute flag.
3277
32781999-10-21 Bill Sommerfeld <sommerfeld@orchard.arlington.ma.us>
3279
3280 * bgp_route.c (bgp_announce): Add check of IPv6 default route
3281 announcement.
3282
3283 * bgp_packet.c (bgp_update_send): Add BGP announcement logging.
3284
32851999-10-15 Kunihiro Ishiguro <kunihiro@zebra.org>
3286
3287 * `show ip[v6] bgp PREFIX' show uptime of the route.
3288
32891999-10-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3290
3291 * bgpd.c (bgp_filter_set): Delete PEER_FAMILY_{IPV4,IPV6}. instead
3292 of that use AF_INET and AF_INET6 directly.
3293 (vty_clear_bgp): Add new function to support various clear ip bgp
3294 method.
3295
32961999-10-04 Lars Fenneberg <lf@elemental.net>
3297
3298 * bgpd.c (clear_ip_bgp): Add `clear ip bgp ASN'.
3299
33001999-10-03 Kunihiro Ishiguro <kunihiro@zebra.org>
3301
3302 * bgp_routemap.c: Add `match ip prefix-list' and `match ipv6
3303 prefix-list'.
3304
33051999-09-28 Kunihiro Ishiguro <kunihiro@zebra.org>
3306
3307 * bgpd.c (bgp_collision_detect): Add BGP collision detection
3308 function.
3309
33101999-09-26 Blake Meike <bmeike@adero.com>
3311
3312 * bgpd.c (neighbor_port): New command `neighbor PEER port PORT' is
3313 added.
3314
33151999-08-24 Kunihiro Ishiguro <kunihiro@zebra.org>
3316
3317 * bgpd.c (no_neighbor_timers_keepalive): Change MIN to min. Add
3318 min() macro.
3319
33201999-08-19 Rick Payne <rickp@rossfell.co.uk>
3321
3322 * bgp_packet.c (bgp_open): BGP holdtimer bug is fixed. Make BGP
3323 keepalive timer configurable.
3324
33251999-08-15 Kunihiro Ishiguro <kunihiro@zebra.org>
3326
3327 * bgp_zebra.c (bgp_redistribute_set): Fix redistribute bug.
3328
33291999-08-13 Kunihiro Ishiguro <kunihiro@zebra.org>
3330
3331 * bgpd.c (bgp_peer_display): show ip bgp neighbors PEER only list
3332 the peer not all of them.
3333
33341999-08-11 Rick Payne <rickp@rossfell.co.uk>
3335
3336 * bgp_route.c (bgp_announce): Remove MED if its an EBGP peer -
3337 will get overwritten by route-maps.
3338
33391999-08-08 Rick Payne <rickp@rossfell.co.uk>
3340
3341 * bgp_routemap.c: Multi protocol route-map modification.
3342
33431999-08-01 Kunihiro Ishiguro <kunihiro@zebra.org>
3344
3345 * bgp_route.c: Set network statement route's origin attribute as
3346 igp.
3347
3348 * bgp_zebra.c: Set redistribute route's origin attribute as
3349 incomplete.
3350
3351 * bgp_route.c (bgp_info_cmp): Add attribute existance check,
3352 origin attribute check, BGP peer type check.
3353
33541999-07-30 Kunihiro Ishiguro <kunihiro@zebra.org>
3355
3356 * bgp_route.c (bgp_peer_delete): Reselect of IPv6 route.
3357
33581999-07-29 Rick Payne <rickp@rossfell.co.uk>
3359
3360 * Changed route-maps to behave in a more cisco-like fashion
3361
33621999-07-27 Kunihiro Ishiguro <kunihiro@zebra.org>
3363
3364 * bgp_fsm.c (bgp_stop): Very serious bug of bgp_stop () is fixed.
3365 When multiple route to the same destination exist, bgpd try to
3366 announce the information to stopped peer. Then add orphan write
3367 thread is added. This cause many strange behavior of bgpd.
3368 Reported by Georg Hitsch <georg@atnet.at>.
3369
33701999-07-23 Kunihiro Ishiguro <kunihiro@zebra.org>
3371
3372 * bgpd.c: Change peer's A.B.C.D to PEER.
3373
33741999-07-22 Kunihiro Ishiguro <kunihiro@zebra.org>
3375
3376 * bgp_route.c (bgp_announce): Add hack for link-local nexthop.
3377
3378 * bgp_zebra.c (bgp_zebra_announce): Fill in nexthop address from
3379 local address.
3380
33811999-07-21 Kunihiro Ishiguro <kunihiro@zebra.org>
3382
3383 * bgp_packet.c (bgp_open): Holdtime fetch bug is fixed. Reported
3384 by Yuji SEKIYA <sekiya@sfc.wide.ad.jp>.
3385
33861999-07-15 Kunihiro Ishiguro <kunihiro@zebra.org>
3387
3388 * bgp_fsm.c (fsm_holdtime): Don't close file descriptor in
3389 fsm_holdtime ().
3390
33911999-07-11 Kunihiro Ishiguro <kunihiro@zebra.org>
3392
3393 * bgp_routemap.c: Add `set atomic-aggregate' command.
3394
33951999-07-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3396
3397 * bgp_routemap.c (route_set_ip_nexthop_cmd): Change "ip nexthop"
3398 to "ip next-hop".
3399
34001999-07-02 Kunihiro Ishiguro <kunihiro@zebra.org>
3401
3402 * bgp_route.c (show_ipv6_bgp_regexp): `show ipv6 bgp regexp'
3403 added.
3404
34051999-07-01 Rick Payne <rickp@rossfell.co.uk>
3406
3407 * bgp_zebra.c (zebra_init): Install standard commands to
3408 ZEBRA_NODE.
3409
34101999-06-28 Rick Payne <rickp@rossfell.co.uk>
3411
3412 * bgpd.c (bgp_delete): bgp peer deletion bug is fixed.
3413
34141999-06-25 Kunihiro Ishiguro <kunihiro@zebra.org>
3415
3416 * bgpd.c: Add neighbor update-source command as ALIAS to
3417 neighbor_interface.
3418
34191999-06-19 Kunihiro Ishiguro <kunihiro@zebra.org>
3420
3421 * bgp_attr.c (bgp_packet_attribute): Send community attribute when
3422 send_community flag is set.
3423
3424 * bgpd.h (struct peer): Add send_community flag.
3425
34261999-06-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3427
3428 * bgpd.c (router_bgp): router bgp's argument changed from AS_NO to
3429 <1-65535>.
3430
34311999-06-08 Kunihiro Ishiguro <kunihiro@zebra.org>
3432
3433 * bgp_route.h (struct bgp_info): Add subtype for BGP route type.
3434
34351999-06-07 Kunihiro Ishiguro <kunihiro@zebra.org>
3436
3437 * bgp_community.c (community_merge): Function added.
3438
34391999-06-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3440
3441 * bgp_clist.c: New file.
3442 * bgp_clist.h: New file.
3443
3444 * bgp_community.h (COMMUNITY_LOCAL_AS): Added for Cisco
3445 compatibility.
3446 (COMMUNITY_NO_ADVERTISE): Fix typo.
3447
34481999-05-30 Kunihiro Ishiguro <kunihiro@zebra.org>
3449
3450 * bgp_routemap.c: Add `set weight WEIGHT' command.
3451
3452 * bgpd.c: Remove all_digit_check function. Instead of that use
3453 all_digit function in lib/prefix.c.
3454
3455 * bgp_routemap.c (bgp_route_map_init): Install
3456 no_set_ipv6_nexthop_global_cmd and no_set_ipv6_nexthop_local_cmd
3457 element to the RMAP_NODE.
3458
34591999-05-28 Kunihiro Ishiguro <kunihiro@zebra.org>
3460
3461 * bgp_aspath.c (aspath_make_str): Declare aspath_delimiter_char
3462 inside aspath_make_str function.
3463 (aspath_prepend): New function is added for AS path prepend.
3464 (aspath_make_str_count): Renamed from aspath_make_str. AS path
3465 count is set to the structure.
3466 (aspath_merge): New function.
3467
34681999-05-22 Kunihiro Ishiguro <kunihiro@zebra.org>
3469
3470 * bgp_zebra.c (redistribute_bgp): Add new DEFUN.
3471 (no_redistribute_bgp): Likewise.
3472 (router_zebra): Semantics changed. Now 'router zebra' is default
3473 behavior of bgpd.
3474
34751999-05-14 Kunihiro Ishiguro <kunihiro@zebra.org>
3476
3477 * bgp_routemap.c: Add some commands to bgp route-map.
3478 match ip next-hop: New command.
3479 match metric: New command.
3480 set metric: Doc fix.
3481 set local-preference: Add DEFUN.
3482
34831999-05-14 Stephen R. van den Berg <srb@cuci.nl>
3484
3485 * bgp_main.c (signal_init): SIGTERM call sigint.
3486 (sigint): Loggging more better message.
3487
34881999-05-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3489
3490 * bgp_attr.c (bgp_packet_attribute): AS path attribute extended
3491 length bit check is added.
3492
34931999-05-11 Kunihiro Ishiguro <kunihiro@zebra.org>
3494
3495 * bgp_routemap.c (bgp_route_map_init): Call route_map_install_set
3496 function with route_set_local_pref_cmd argument.
3497 (no_match_aspath): Function added.
3498 (route_set_metric): Set attribute flag bit.
3499
3500 * bgp_attr.c (bgp_packet_attribute): MULTI_EXIT_DISC is now in BGP
3501 packet.
3502
35031999-05-07 Kunihiro Ishiguro <kunihiro@zebra.org>
3504
3505 * bgpd.c (no_neighbor_timers_holdtime): `no neighbor PEER timers
3506 holdtime' command is added.
3507
3508 * bgpd.h (BGP_DEFAULT_HOLDTIME_BIG): Delete define.
3509
3510 * bgpd.c (bgp_prefix_list_set): New function added.
3511 (bgp_prefix_list_unset): Likewise.
3512 (bgp_prefix_list_update): Likewise.
3513 (show_ip_bgp_neighbors): prefix-list information display.
3514
35151999-05-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3516
3517 * bgpd.c (bgp_delete): Function added for `no router bgp'.
3518
35191999-05-05 Kunihiro Ishiguro <kunihiro@zebra.org>
3520
3521 * bgp_dump.c (bgp_dump_attr): Add originator_id display.
3522
3523 * bgpd.c (bgp_router_id): Even when address is malformed set the
3524 value to configuration bug fixed.
3525 (no_bgp_router_id): New function.
3526 (no_bgp_cluster_id): New function.
3527
35281999-05-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3529
3530 * bgpd.h (BGP_ATTR_ORIGINATOR_ID): Changed from BGP_ATTR_ORIGINATOR.
3531
35321999-05-02 Kunihiro Ishiguro <kunihiro@zebra.org>
3533
3534 * bgp_route.c (bgp_announce): Add route reflector check.
3535
35361999-05-01 Kunihiro Ishiguro <kunihiro@zebra.org>
3537
3538 * bgpd.c (bgp_cluster_id): Add function for route reflector.
3539 (neighbor_route_reflector_client): Likewise.
3540 (no_neighbor_route_reflector_client): Likewise.
3541
3542 * bgpd.h (struct bgp ): Add cluster for route reflector.
3543
3544 * bgp_route.c (show_ip_bgp_prefix_list): New command is added.
3545
35461999-04-24 Kunihiro Ishiguro <kunihiro@zebra.org>
3547
3548 * Makefile.am (noinst_HEADERS): Add bgp_filter.h
3549
3550 * bgp_aspath.c (aspath_undup): Function deleted. aspath_free ()
3551 has same functionality.
3552
3553 * bgp_filter.h: New file.
3554
3555 * bgp_aspath.c (aspath_unintern): Rename aspath_free () to
3556 aspath_unintern ()
3557 (aspath_free): New function.
3558
35591999-04-23 Kunihiro Ishiguro <kunihiro@zebra.org>
3560
3561 * bgp_aspath.c (aspath_aggregate): Function added.
3562
3563 * bgp_aspath.h (aspath_aggregate): Prototype added.
3564
3565 * bgp_aspath.c (aspath_empty_aspath): New argument
3566 gated_dont_eat_flag is added.
3567
35681999-04-18 Kunihiro Ishiguro <kunihiro@zebra.org>
3569
3570 * bgp_route.c: Add bgp_aggregate_ipv4 and bgp_aggregate_ipv6.
3571
35721999-04-17 Kunihiro Ishiguro <kunihiro@zebra.org>
3573
3574 * bgp_route.c (aggregate_address): Function added.
3575
3576 * bgp_zebra.c (zebra_read): Change log to zlog.
3577
35781999-04-15 Kunihiro Ishiguro <kunihiro@zebra.org>
3579
3580 * Makefile.am (noninst_HEADERS): Added for make dist.
3581
35821999-04-09 Kunihiro Ishiguro <kunihiro@zebra.org>
3583
3584 * aspath_regex.c: Removed from distribution.
3585
35861999-04-07 Kunihiro Ishiguro <kunihiro@zebra.org>
3587
3588 * bgp_attr.c (bgp_packet_attribute): Old draft-00 packet treatment
3589 bug fixed.
3590
35911999-04-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3592
3593 * bgp_aspath.c (aspath_add_left): Fix empty aspath bug. Reported
3594 by kad@gibson.skif.net.
3595
3596 * bgp_regex.[ch]: New file added.
3597
3598
35991999-04-05 Kunihiro Ishiguro <kunihiro@zebra.org>
3600
3601 * bgp_filter.c: New file added.
3602
36031999-04-01 Kunihiro Ishiguro <kunihiro@zebra.org>
3604
3605 * bgp_aspath.c (aspath_empty_aspath): Change for peering with
3606 gated.
3607
36081999-03-24 Kunihiro Ishiguro <kunihiro@zebra.org>
3609
3610 * bgp_main.c (main): Default loggin method changed from syslog to
3611 stdout.
3612
36131999-03-05 Kunihiro Ishiguro <kunihiro@zebra.org>
3614
3615 * bgp_route.c: Delete obsolete default attribute DEFUN.
3616
36171999-03-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3618
3619 * bgp_attr.c: Make attribute structure put into attribute hash.
3620
36211999-03-02 Kunihiro Ishiguro <kunihiro@zebra.org>
3622
3623 * bgp_view.c : Delete file.
3624
36251999-02-25 Kunihiro Ishiguro <kunihiro@zebra.org>
3626
3627 * bgp_routemap.c (bgp_apply_route_map): Add prefix argument.
3628
3629 * bgp_route.h (struct bgp_info): Add bgp_info structre. I'll
3630 replace bgp_route with this.
3631
3632 * bgp_routemap.c (route_match_ip_address): Fix bug of passing non
3633 prefix value to access_list_apply().
3634
3635 * bgpd.conf.sample: Add route-map sample.
3636 Delete obsolete default-attr statements.
3637
3638 * bgp_packet.c: Use stream_fifo for packet queueing.
3639
36401999-02-24 Kunihiro Ishiguro <kunihiro@zebra.org>
3641
3642 * bgp_aspath.c (aspath_add_left): add non empty aspath treatment.
3643
3644 * bgp_main.c: include unistd.h for daemon().
3645
3646 * bgp_route.c (nlri_process): add IPv6 table lookup.
3647
3648 * bgp_attr.c (route_parse_ipv6): call nlri_process().
3649 (attr_make): Obsolete function attr_make deleted.
3650
36511999-02-22 Kunihiro Ishiguro <kunihiro@zebra.org>
3652
3653 * bgp_aspath.c (aspath_add_left): change function name from
3654 aspath_add_leftmost_as().
3655
36561999-02-21 Kunihiro Ishiguro <kunihiro@zebra.org>
3657
3658 * bgp_aspath.c: add aspath_add_leftmost_as ().
3659
36601999-02-18 Peter Galbavy <Peter.Galbavy@knowledge.com>
3661
3662 * syslog support added
3663
36641999-01-26 Kunihiro Ishiguro <kunihiro@zebra.org>
3665
3666 * bgpd.c: DEFUN (neighbor_nexthop): deleted.
3667 DEFUN (neighbor_distribute_list): added.
3668
36691999-01-19 Kunihiro Ishiguro <kunihiro@zebra.org>
3670
3671 * bgpd.h (struct peer ): header_buf and read_buf is removed.
3672
3673 * bgp_peer.[ch]: Deleted. Peer related functions are merged to
3674 bgpd.c
3675
3676 * bgp_network.c: New file.
3677 * bgp_network.h: New file.
3678
3679 * bgp_packet.h: New file.
3680
36811999-01-11 Kunihiro Ishiguro <kunihiro@zebra.org>
3682
3683 * bgp_packet.c (bgp_keepalive_send): Now BGP keepalive packet is
3684 buffered.
3685
36861999-01-08 Kunihiro Ishiguro <kunihiro@zebra.org>
3687
3688 * bgp_packet.c: New file.
3689
36901998-12-22 Kunihiro Ishiguro <kunihiro@zebra.org>
3691
3692 * bgp_zebra.c (zebra_client): Use zebra_connect() in lib/client.c.
3693
3694 * `show ip bgp' bug fixed.
3695 * aspath_log (): Remove argument logfp.
3696
36971998-12-15 Kunihiro Ishiguro <kunihiro@zebra.org>
3698
3699 * bgp_fsm.h: New file.
3700
37011998-12-15 Magnus Ahltorp <map@stacken.kth.se>
3702
3703 * bgp_attr.c, bgp_community.h, bgp_dump.c, bgp_fsm.c, bgp_open.c
3704 bgp_peer.c, bgp_peer.h, bgp_route.c, bgp_route.h, bgp_view.c
3705 bgpd.c, bgpd.h, bgp_attr.c, bgp_community.h, bgp_dump.c,
3706 bgp_fsm.c, bgp_open.c, bgp_peer.c, bgp_peer.h: Prototype fixes.
3707
37081998-12-09 Kunihiro Ishiguro <kunihiro@zebra.org>
3709
3710 * bgpd.c (bgp_config_write): Delete vector v argument.
3711
37121998-12-07 Kunihiro Ishiguro <kunihiro@zebra.org>
3713
3714 * bgpd.h: Delete annoying ld_[124]byte and st_[124]byte macros.
3715
37161998-11-23 Kunihiro Ishiguro <kunihiro@zebra.org>
3717
3718 * bgp_radix.[ch]: removed.
3719
37201998-09-15 HEO SeonMeyong <seirios@matrix.iri.co.jp>
3721
3722 * bgp_main.c: ifdef HYDRANGEA -> ifdef KAME
3723
37241998-08-13 Kunihiro Ishiguro <kunihiro@zebra.org>
3725
3726 * bgp_dump.c: delete nroute().
3727
37281998-05-19 Yamshita TAKAO <jargon@lares.dti.ne.jp>
3729
3730 * bgp_aspath.c: HAVE_CONFIG_H typo :-)
3731 * bgpd.h: Modify for compile on Solaris.
3732 * bgp_aspath.h: likewize
3733 * bgp_community.h: likewize
3734 * bgp_routemap.c: likewize
3735
37361998-05-18 Yamshita TAKAO <jargon@lares.dti.ne.jp>
3737
3738 * bgpd.h: Modify for compile on Solaris.
3739 * bgp_aspath.h: likewize
3740
37411998-05-08 Kunihiro Ishiguro <kunihiro@zebra.org>
3742
3743 * routemap.[ch]: move to ../lib directory.
3744
37451998-05-07 Kunihiro Ishiguro <kunihiro@zebra.org>
3746
3747 * routemap.c (route_map_apply): add function.
3748
37491998-05-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3750
3751 * routemap.h: add file.
3752
3753 * bgp_peer.h (enum ): change PEER_{IBGP,EBGP} to BGP_PEER_{IBGP,EBGP}
3754
37551998-05-03 Kunihiro Ishiguro <kunihiro@zebra.org>
3756
3757 * Makefile.am: sysconfdir_DATA added.
3758
37591998-05-02 Kunihiro Ishiguro <kunihiro@zebra.org>
3760
3761 * bgp_dump.c: add `debug bgp fsm'
3762 add `no debug bgp fsm'
3763 add `show debug bgp'
3764 * bgp_open.c: File added.
3765
37661998-05-01 Kunihiro Ishiguro <kunihiro@zebra.org>
3767
3768 * .cvsignore: File added.
3769
37701998-04-30 Kunihiro Ishiguro <kunihiro@zebra.org>
3771
3772 * bgp_community.[ch]: File added.
3773
37741998-03-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3775
3776 * bgpd now use lib/thread.[ch].
3777
37781998-01-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3779
3780 * bgpd.c (show_ip_bgp_neighbors): add 'show ip bgp neighbors' command.
3781
3782 * bgpd.h (BGP_DEFAULT_START_TIMER): change from 1 to 30.
3783
37841997-12-30 Kunihiro Ishiguro <kunihiro@zebra.org>
3785
3786 * bgp_vty.c: bgp_vty.c deleted.
3787
3788 * bgpd.c (config_write_neighbor): add ebgp-multihop command.
3789
37901997-12-29 Kunihiro Ishiguro <kunihiro@zebra.org>
3791
3792 * bgp_fsm.c: [-p bgp_port] and [-P vty_port] works
3793
37941997-12-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3795
3796 * bgp_vty.c: new file.
3797
3798 * bgp_attr.c: add new logging system.
3799
38001997-11-23 Kunihiro Ishiguro <kunihiro@zebra.org>
3801
3802 * Change all inet_addr call into inet_aton.
3803
38041997-11-10 Kunihiro Ishiguro <kunihiro@zebra.org>
3805
3806 * bgp_radix.c: change radix_peer_delete
3807
38081997-10-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3809
3810 * bgp_aspath.c: move AS_TOKEN_??? definition from header to c source.
3811
38121997-09-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3813
3814 * bgp_dump.c (bgp_log_route): add dump_attr function
3815
38161997-09-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3817
3818 * bgp_aspath.c (aspath_test): change AS_SET brace from '[' to '{'
3819 * bgp_dump.c (bgp_log_route): change logfile format.
3820
38211997-08-19 Kunihiro Ishiguro <kunihiro@zebra.org>
3822
3823 * bgp_open.c (bgp_open): move bgp_open function from bgpd.c
3824 * bgp_attr.c (community_str2com): add community value generation
3825 * bgp_attr.h: add SAFI definition for BGP-4+
3826
38271997-08-18 Kunihiro Ishiguro <kunihiro@zebra.org>
3828
3829 * bgpd.h: add BGP_OPEN_OPT_CAP for Capabilities Optional Parameter
3830 * Makefile.in: add bgp_open.o, delete bgp_loop.o
3831 * bgp_open.c: newfile which manages BGP Open message
3832 * bgp_loop.c: this file is merged with bgp_fsm.c
3833 * bgp_radix.c (radix_add): radix_add() now return route_t instead
3834 of int
3835 (bgp_sim): now we can read update & withdraw from file
3836 * bgp_route.c: add route_free() call into route_parse etc.
3837
38381997-08-17 Kunihiro Ishiguro <kunihiro@zebra.org>
3839
3840 * bgp_radix.c: Radix code is completely rewritten. It has better
3841 memory treatment than old one.
3842
38431997-08-14 Kunihiro Ishiguro <kunihiro@zebra.org>
3844
3845 * bgp_route.c: route_alloc for route struct allocation statistics.
3846 * bgpd.c (bgp_make_update): now we cann announce MED attribute.
3847 * bgp_aspath.c (aspath_print_all): change aspath_print_all output
3848 format.
3849
38501997-08-13 Kunihiro Ishiguro <kunihiro@zebra.org>
3851
3852 * bgp_term.c (term_parse): add command : show asstat, show ashash
3853 * bgp_aspath.c: aspath_cmp bug fix
3854 (aspath_print_all): add aspath_print_all ();
3855 * bgp_peer.h: delete rlist element from struct peer.
3856
38571997-08-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3858
3859 * bgp_aspath.c: completely rewritten.
3860 * bgp_aspath.h: completely rewritten.
3861 add AsPath, AsSegment structure
3862 add AS_SET treatment
3863 change Hash codes
3864
38651997-08-09 Kunihiro Ishiguro <kunihiro@zebra.org>
3866
3867 * bgp_attr.h: add Attribute flags defines
3868 * bgp_route.c: delete rlist related functions
3869 * bgp_aspath.c (as_origin): add as_origin function
3870 (aspath_print): move from bgp_dump.c and add support of AS_SET
3871 change Hash related function names.
3872
38731997-08-08 Kunihiro Ishiguro <kunihiro@zebra.org>
3874
3875 * bgp_aspath.h: add next entry, delete rlist entry from struct aspath
3876
38771997-08-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3878
3879 * bgp_aspath.c (as_sort): add function as_sort
3880 * bgp_aspath.h: add IBGP, EBGP
3881