blob: 3fa3837a3743d9827f7954263744595efb768b68 [file] [log] [blame]
Denis Ovsienkoa7f93f32007-12-18 15:13:06 +000012007-12-18 Denis Ovsienko
2
3 * bgp_routemap.c: (no_set_aspath_prepend) This command cancelled
4 existing "set" command regardless if "no set" matched it or not.
5 Fixed.
6
Paul Jakma7e992e92007-11-13 09:32:23 +000072007-11-13 Paul Jakma <paul.jakma@sun.com>
8
9 * bgp_main.c: Small fix, format string parameters should never
10 be NULL - it's not strictly valid and some libc's don't let
11 you away with.
12
Paul Jakma3a02d1f2007-11-01 14:29:11 +0000132007-10-30 Nick Hilliard <nick@inex.ie>
14
15 * bgp_main.c: Add 'listenon' argument, to pass address to bind
16 to.
17 * bgp_network.c: (bgp_socket) Extend to take bind address.
18 * bgpd.c: (bgp_init) Pass stored address.
19 * bgpd.h: (struct bgp_master) storage for bind address
20
Paul Jakma0b2aa3a2007-10-14 22:32:21 +0000212007-09-27 Paul Jakma <paul.jakma@sun.com>
22
23 * bgp_aspath.c: (assegment_normalise) remove duplicates from
24 from sets.
25 (aspath_reconcile_as4) disregard a broken part of the RFC around
26 error handling in path reconciliation.
27
282007-09-25 Paul Jakma <paul.jakma@sun.com>
29
30 * bgp_open.c: (peek_for_as4_capability) Fix to work.
31 * bgp_packet.c: (bgp_open_receive) Fix sanity check of as4.
32
332007-09-18 Paul Jakma <paul.jakma@sun.com>
34
35 * bgp_open.c: (bgp_capability_as4) debug printf inline with others.
36 (peek_for_as4_capability) There's no need to signal failure, as
37 failure is better dealt with through full capability parser -
38 just return the AS4, simpler.
39 * bgp_packet.c: (bgp_open_receive) Update to match
40 peek_for_as4_capability change.
41 Allow use of BGP_AS_TRANS by 2b speakers.
42 Use NOTIFY_OPEN_ERR rather than CEASE for OPEN parsing errors.
43 (bgp_capability_msg_parse) missing argument to debug print
44 (bgp_capability_receive) missing return values.
45
46
472007-07-25 Paul Jakma <paul.jakma@sun.com>
48
49 * Remove 2-byte size macros, just make existing macros take
50 argument to indicate which size to use.
51 Adjust all users - typically they want '1'.
52 * bgp_aspath.c: (aspath_has_as4) New, return 1 if there are any
53 as4's in a path.
54 (aspath_put) Return the number of bytes actually written, to
55 fix the bug Juergen noted: Splitting of segments will change
56 the number of bytes written from that already written to the
57 AS_PATH header.
58 (aspath_snmp_pathseg) Pass 2-byte flag to aspath_put. SNMP
59 is still defined as 2b.
60 (aspath_aggregate) fix latent bug.
61 (aspath_reconcile_as4) AS_PATH+NEW_AS_PATH reconciliation
62 function.
63 (aspath_key_make) Hash the AS_PATH string, rather than
64 just taking the addition of assegment ASes as the hash value,
65 hopefully sligthly more collision resistant.
66 (bgp_attr_munge_as4_attrs) Collide the NEW_ attributes
67 together with the OLD 2-byte forms, code Juergen
68 had in bgp_attr_parse but re-organised a bit.
69 (bgp_attr_parse) Bunch of code from Juergen moves
70 to previous function.
71 (bgp_packet_attribute) Compact significantly by
72 just /always/ using extended-length attr header.
73 Fix bug Juergen noted, by using aspath_put's
74 (new) returned size value for the attr header rather
75 than the (guesstimate) of aspath_size() - the two could
76 differ when aspath_put had to split large segments, unlikely
77 this bug was ever hit in the 'wild'.
78 (bgp_dump_routes_attr) Always use extended-len and
79 use aspath_put return for header length. Output 4b ASN
80 for AS_PATH and AGGREGATOR.
81 * bgp_ecommunity.c: (ecommunity_{hash_make,cmp}) fix
82 hash callback declarations to match prototypes.
83 (ecommunity_gettoken) Updated for ECOMMUNITY_ENCODE_AS4,
84 complete rewrite of Juergen's changes (no asdot support)
85 * bgp_open.c: (bgp_capability_as4) New, does what it says
86 on the tin.
87 (peek_for_as4_capability) Rewritten to use streams and
88 bgp_capability_as4.
89 * bgp_packet.c: (bgp_open_send) minor edit
90 checked (in the abstract at least) with Juergen.
91 Changes are to be more accepting, e.g, allow AS_TRANS on
92 a 2-byte session.
93 * (general) Update all commands to use CMD_AS_RANGE.
94 * bgp_vty.c: (bgp_clear) Fix return vals to use CMD_..
95 Remove stuff replicated by VTY_GET_LONG
96 (bgp_clear_vty) Return bgp_clear directly to vty.
97
98
992007-07-25 Juergen Kammer <j.kammer@eurodata.de>
100
101 * (general) AS4 support.
102 * bgpd.h: as_t changes to 4-bytes.
103 * bgp_aspath.h: Add BGP_AS4_MAX and BGP_AS_TRANS defines.
104 * bgp_aspath.c: AS_VALUE_SIZE becomes 4-byte, AS16_VALUE_SIZE
105 added for 2-byte.
106 Add AS16 versions of length calc macros.
107 (aspath_count_numas) New, count number of ASes.
108 (aspath_has_as4) New, return 1 if there are any as4's in a
109 path.
110 (assegments_parse) Interpret assegment as 4 or 2 byte,
111 according to how the caller instructs us, with a new
112 argument.
113 (aspath_parse) Add use32bit argument to pass to
114 assegments_parse. Adjust all its callers to pass 1, unless
115 otherwise noted.
116 (assegment_data_put) Adjust to be able to write 2 or 4 byte
117 AS, according to new use32bit argument.
118 (aspath_put) Adjust to write 2 or 4.
119 (aspath_gettoken) Use a long for passed in asno.
120 * bgp_attr.c: (attr_str) Add BGP_ATTR_AS4_PATH and
121 BGP_ATTR_AS4_AGGREGATOR.
122 (bgp_attr_aspath) Call aspath_parse with right 2/4 arg, as
123 determined by received-capability flag.
124 (bgp_attr_aspath_check) New, code previously in attr_aspath
125 but moved to new func so it can be run after NEW_AS_PATH
126 reconciliation.
127 (bgp_attr_as4_path) New, handle NEW_AS_PATH.
128 (bgp_attr_aggregator) Adjust to cope with 2/4 byte ASes.
129 (bgp_attr_as4_aggregator) New, read NEW_AGGREGATOR.
130 (bgp_attr_parse) Add handoffs to previous parsers for the two
131 new AS4 NEW_ attributes.
132 Various checks added for NEW/OLD reconciliation.
133 (bgp_packet_attribute) Support 2/4 for AS_PATH and
134 AGGREGATOR, detect when NEW_ attrs need to be sent.
135 * bgp_debug.{c,h}: Add 'debug bgp as4'.
136 * bgp_dump.c: MRTv2 support, unconditionally enabled, which
137 supports AS4. Based on patches from Erik (RIPE?).
138 * bgp_ecommunity.c: (ecommunity_ecom2str) ECOMMUNITY_ENCODE_AS4
139 support.
140 * bgp_open.c: (peek_for_as4_capability) New, peek for AS4
141 capability prior to full capability parsing, so we know which
142 ASN to use for struct peer lookup.
143 (bgp_open_capability) Always send AS4 capability.
144 * bgp_packet.c: (bgp_open_send) AS4 handling for AS field
145 (bgp_open_receive) Peek for AS4 capability first, and figure
146 out which AS to believe.
147 * bgp_vty.c: (bgp_show_peer) Print AS4 cap
148
Paul Jakmae08286b2007-09-18 12:11:26 +00001492007-09-17 Paul Jakma <paul.jakma@sun.com>
150
151 * bgp_open.c: (bgp_capability_mp) We were setting
152 afc_nego[safi][safi] rather than afc_nego[afi][safi], thus
153 failling to announce any non-IPv4 prefixes. Remove the extra,
154 typo-ed character.
155
Paul Jakmab2ceea12007-09-07 14:24:55 +00001562007-09-07 Paul Jakma <paul.jakma@sun.com>
157
158 * (general) bgpd can be made crash by remote peers if debug
159 bgp updates is set, due to NULL pointer dereference.
160 Reported by "Mu Security Research Team",
161 <security@musecurity.com>.
162 * bgp_attr.c: (bgp_attr_community) If community length is 0,
163 don't set the community-present attribute bit, just return
164 early.
165 * bgp_debug.c: (community_str,community_com2str) Check com
166 pointer before dereferencing.
167
Paul Jakma9eda90c2007-08-30 13:36:17 +00001682007-08-27 Paul Jakma <paul.jakma@sun.com>
169
170 * bgp_route.c: (bgp_announce_check) Fix bug #398, slight
171 modification of Vladimir Ivanov's suggested fix - to keep
172 memory alloc conditional.
173 (bgp_process_announce_selected) Don't take struct attr as
174 argument, none of the callers need it and it needlessly
175 distances allocation from use.
176 Free the extended attr, the attr itself is on the stack.
177 Fix bad indentation.
178 * bgp_attr.c: (bgp_packet_attribute) Remove incorrect assert,
179 and adjust conditional to test attr->extra, diagnosis by
180 Vladimir Ivanov in bug #398.
181
1822007-08-27 Vladimir Ivanov <wawa@yandex-team.ru>
183
184 * bgp_route.c: (bgp_announce_check_rsclient) copy of
185 ri->attr is no longer deep enough, due to addition of
186 attr->extra. It should use bgp_attr_dup, as
187 bgp_announce_check() does.
188
Paul Jakma6d134fb2007-08-23 23:22:02 +00001892007-08-23 Paul Jakma <paul.jakma@sun.com>
190
191 * bgp_regex.c: (bgp_regcomp) Pass NOSUB flag to regcomp to
192 prevent parsing of substitutions, which can have profound
193 performance effects on bgpd and are of no use to the CLI
194 anyway. How much it helps depends on the regex
195 implementation.
196
Paul Jakma41367172007-08-06 15:24:51 +00001972007-07-31 Paul Jakma <paul.jakma@sun.com>
198
199 * (general) Support for draft-ietf-idr-as-pathlimit-03.
200 * bgp_attr.h: (struct attr) Add pathlimit struct
201 bgp_attr.c: (attr_str) Add BGP_ATTR_AS_PATHLIMIT string.
202 (attrhash_key_make) tally pathlimit too
203 (attrhash_cmp) cmp pathlimit attr
204 (bgp_attr_aspathlimit) New, parse AS_PATHLIMIT attr.
205 (bgp_attr_parse) ditto
206 (bgp_packet_attribute) Write out AS_PATHLIMIT when set
207 (bgp_dump_routes_attr) ditto
208 * bgp_route.h: (struct bgp_static) Add TTL field
209 * bgp_route.c: (bgp_announce_check) Drop paths that are over
210 their hop-count TTL before sending via EBGP.
211 Mangle ASN in pathlimit for confeds/private as best we can.
212 (bgp_static_update_{rsclient,main}) Add any configure pathlimit
213 information.
214 (bgp_pathlimit_update_parents) New, update atomic-aggr setting for
215 parents of an aspathlimit'ed static.
216 (bgp_static_set) Add TTL argument, for all the 'bgp network'
217 commands.
218 Call previous for TTL changed statics.
219 (bgp_static_unset) Call pathlimit_update_parents.
220 (various bgp network commands) Add 'pathlimit <0-255>' qualifier
221 to all the various forms, bar route-map - which can set ttl
222 itself.
223 * bgp_routemap.c: (general) Add support for 'set pathlimit ttl' and
224 'match pathlimit as'.
225
Paul Jakma6d582722007-08-06 15:21:45 +00002262007-07-26 Paul Jakma <paul.jakma@sun.com>
227
228 * (general) Clean up and compact capability parsing slightly.
229 Consolidate validation of length and logging of generic TLV, and
230 memcpy of capability data, thus removing such from cap specifc
231 code (not always present or correct).
232 * bgp_open.h: Add structures for the generic capability TLV header
233 and for the data formats of the various specific capabilities we
234 support. Hence remove the badly named, or else misdefined, struct
235 capability.
236 * bgp_open.c: (bgp_capability_vty_out) Use struct capability_mp_data.
237 Do the length checks *before* memcpy()'ing based on that length
238 (stored capability - should have been validated anyway on input,
239 but..).
240 (bgp_afi_safi_valid_indices) new function to validate (afi,safi)
241 which is about to be used as index into arrays, consolidates
242 several instances of same, at least one of which appeared to be
243 incomplete..
244 (bgp_capability_mp) Much condensed.
245 (bgp_capability_orf_entry) New, process one ORF entry
246 (bgp_capability_orf) Condensed. Fixed to process all ORF entries.
247 (bgp_capability_restart) Condensed, and fixed to use a
248 cap-specific type, rather than abusing capability_mp.
249 (struct message capcode_str) added to aid generic logging.
250 (size_t cap_minsizes[]) added to aid generic validation of
251 capability length field.
252 (bgp_capability_parse) Generic logging and validation of TLV
253 consolidated here. Code compacted as much as possible.
254 * bgp_packet.c: (bgp_open_receive) Capability parsers now use
255 streams, so no more need here to manually fudge the input stream
256 getp.
257 (bgp_capability_msg_parse) use struct capability_mp_data. Validate
258 lengths /before/ memcpy. Use bgp_afi_safi_valid_indices.
259 (bgp_capability_receive) Exported for use by test harness.
260 * bgp_vty.c: (bgp_show_summary) fix conversion warning
261 (bgp_show_peer) ditto
262 * bgp_debug.h: Fix storage 'extern' after type 'const'.
263
Paul Jakma45ad5922007-07-31 17:35:36 +00002642007-07-31 Lorenzo Colitti <lorenzo@colitti.com>
265
266 * bgp_dump.c: (general) Add comments to code.
267 (bgp_dump_interval_add) remove some redundant lines.
268 (bgp_dump_set) Use enum for type argument.
269 Avoid scheduling dump twice if exact same command
270 is given twice..
271
Paul Jakma536792c2007-06-22 19:11:14 +00002722007-06-22 Paul Jakma <paul.jakma@sun.com>
273
274 * bgp_fsm.c: (struct FSM) Bug #368. TCP Errors during OpenSent
275 should cycle to Active, not to Idle or else peer bringup can
276 race and cycle Idle<->Active. Reported and fix tested by
277 Mukesh Agrawal.
278
Paul Jakmab2497022007-06-14 11:17:58 +00002792007-05-25 Paul Jakma <paul.jakma@sun.com>
280
281 * bgp_route.c: (bgp_default_originate) Sanity check added
282 previously was broken and always failed, thus this function
283 never could run, bug #370.
284
Paul Jakmafb982c22007-05-04 20:15:47 +00002852007-05-03 Paul Jakma <paul.jakma@sun.com>
Paul Jakma923de652007-04-29 18:25:17 +0000286
Paul Jakmafb982c22007-05-04 20:15:47 +0000287 * bgp_route.h: (struct info) Move less frequently used
288 fields to a lazily allocated struct info_extra.
289 Export bgp_info_extra_get
290 * bgp_route.c: (bgp_info_extra_new) allocate extra
291 (bgp_info_extra_free) Free damp info and the info_extra.
292 (bgp_info_extra_get) Retrieve the info_extra of a struct
293 info, allocating as required.
294 (generally) adjust to use info->extra
295 * bgp_damp.c: (generally) use bgp_info_extra_get to access
296 dampinfo
297 * bgp_attr.h: Move rarely allocated attributes from struct attr
298 to a struct attr_extra, for a substantial saving in size of
299 struct attr.
300 * bgp_attr.c: (bgp_attr_extra_{new,free}), new, self-explanatory.
301 (bgp_attr_extra_get) Get the attr_extra for a given struct
302 attr, allocating it if needs be.
303 (bgp_attr_dup) Shallow copy the struct attr and its attr_extra.
304 (generally) adjust to know about attr->extra.
305 * bgp_debug.c: (bgp_dump_attr) ditto
306 * bgp_vty.c: (show_bgp_memory) print attr and info extra sizes.
307 * bgp_nexthop.c: (generally) adjust to know about attr->extra
308 and info->extra.
309 * bgp_{packet,routemap,snmp,zebra}.c: ditto
310
3112007-04-22 Sebastien Tandel <sebastien@tandel.be>
Paul Jakma923de652007-04-29 18:25:17 +0000312 * bgp_advertise.c : (baa_hash_alloc, baa_hash_key, baa_hash_cmp)
313 conforms to quagga hash API. Defines _hash_[alloc|key|cmp] with
314 void * arguments as defined by the API.
315 * bgp_aspath.c,h : (aspath_key_make) conforms to quagga hash API.
316 Defines _hash_[alloc|key|cmp] with void * arguments as defined by
317 the API.
318 * bgp_attr.c,h : (cluster_hash_alloc, cluster_hash_key_make,
319 cluster_hash_cmp, transit_hash_alloc, transit_hash_key_make,
320 transit_hash_cmp, attrhash_key_make, attrhash_cmp,
321 bgp_attr_hash_alloc) conforms to quagga hash API. Defines
322 _hash_[alloc|key|cmp] with void * arguments as defined by the API.
Paul Jakma03e214c2007-04-29 18:31:07 +0000323 * bgp_attr.h : Definition of BGP_ATTR_DEFAULT_WEIGHT.
324 * bgp_attr.c : (bgp_attr_default_intern) now uses
325 bgp_attr_default_set instead of duplicating the same code.
326 (general) Use of BGP_ATTR_DEFAULT_WEIGHT. Replace two 16 by
327 IPV6_MAX_BYTELEN.
Paul Jakma923de652007-04-29 18:25:17 +0000328
Andrew J. Schorr93c17492007-04-15 19:17:24 +00003292007-04-15 Sebastien Tandel <sebastien@tandel.be>
330
331 * bgp_aspath.c: (aspath_as_add, aspath_segment_add) Minor performance
332 optimization: while loop should test one pointer instead of two.
333
Paul Jakma16d2e242007-04-10 19:32:10 +00003342007-04-08 Paul Jakma <paul.jakma@sun.com>
335
336 * bgp_route.c: (general) Same bug as fixed on 2006-11-28 by ajs for
337 bgp static routes, but for main BGP RIB: Quick 'flap' of routes
338 can cause bgpd to mistake a new route for a duplicate route,
339 due to presence of removed, but not yet processed BGP RIB entry.
340 (bgp_update_rsclient) Ignore REMOVED bgp_info for duplicate,
341 restore route instead.
342 (bgp_update_main) Ditto.
Paul Jakma6e4ab122007-04-10 19:36:48 +0000343 * bgp_attr.c: (general) Bug #354: parsing of MP_REACH_NLRI and
344 MP_UNREACH_NLRI does not take sufficient care to ensure reads
345 from stream buffer stay in-bounds. Hence bgpd may attempt to read
346 beyond end of stream, if given a crafted packet. As it uses the
347 stream access methods to do so, this will typically result in
348 assert() being hit in stream.c. Where code is compiled without
349 assert() enabled, result is unknown.
350 (struct message attr_str) should be static.
351 (bgp_mp_reach_parse) Carefully check length remaining in stream
352 against amount desired to read from stream, prior to each read,
353 particularly where lengths are conditional on data obtained from
354 stream - using STREAM_READABLE.
355 Remove code to parse SNPA-number, it's a defunct field and changed
356 to a fixed size in latest BGP MP update RFC - log warning if
357 SNPA-number is not 0.
358 (bgp_mp_unreach_parse) Check withdraw_length carefully against
359 STREAM_READABLE.
360 (bgp_attr_parse) If attribute-parser function returns error, log
361 warning.
362 Log attribute type on mismatch.
Paul Jakma16d2e242007-04-10 19:32:10 +0000363
Paul Jakma37a217a2007-04-10 19:20:29 +00003642007-04-07 Paul Jakma <paul.jakma@sun.com>
365
366 * bgpd.c: (general) Fix bug #352
367 (bgp_config_write_family_header) write ipv6/multicast
368 address family header.
369 (bgp_config_write) write out ipv6 multicast AF config.
370
Paul Jakmaf2c31ac2007-02-22 17:48:42 +00003712007-02-22 Paul Jakma <paul.jakma@sun.com>
372
373 * bgp_fsm.c: (bgp_fsm_change_status) Handle state change into
374 clearing or greater here. Simpler.
375 (bgp_event) Clearing state change work moved to previous
376 * bgp_route.c: (bgp_clear_route_node) Clearing adj-in here
377 is too late, as it leaves a race between a peer being deleted
378 and an identical peer being configured before clearing
379 completes, leading to a crash.
380 Simplest fix is to clean peers Adj-in up-front, rather than
381 queueing such work.
382 (bgp_clear_route_table) Clear peer's Adj-In and Adj-Out
383 up-front here, rather than queueing such work.
384 Extensive comment added on the various bits of indexed data
385 that exist and how they need to be dealt with.
386 (bgp_clear_route) Update comment.
387
Andrew J. Schorre4529632006-12-12 19:18:21 +00003882006-12-12 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
389
390 * bgp_nexthop.c: (bgp_connected_add, bgp_connected_delete)
391 Simplify logic by using new CONNECTED_PREFIX macro.
392
Paul Jakma95fdcd82006-12-08 00:31:22 +00003932006-12-07 Paul Jakma <paul.jakma@sun.com>
394
395 * bgp_fsm.c: Bug #302 fix, diagnosis, suggestions and testing
396 by Juergen Kammer <j.kammer@eurodata.de>. Fix follows from
397 his suggested fix, just made in a slightly different way.
398 (bgp_event) Transitions into Clearing always must call
399 bgp_clear_route_all().
400 (bgp_stop) No need to clear routes here, BGP FSM should do
401 it.
402
Andrew J. Schorra39275d2006-11-30 16:36:57 +00004032006-11-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
404
405 * bgp_debug.h: Declare new bgp_debug_zebra conf and term flags,
406 and define BGP_DEBUG_ZEBRA.
407 * bgp_debug.c: Declare conf_bgp_debug_zebra and term_bgp_debug_zebra.
408 (debug_bgp_zebra, no_debug_bgp_zebra, undebug_bgp_zebra) New
409 functions to enable/disable bgp zebra debugging.
410 (no_debug_bgp_all) Turn off zebra debugging.
411 (show_debugging_bgp) Show whether zebra debugging is on.
412 (bgp_config_write_debug) Add 'debug bgp zebra' if configured.
413 (bgp_debug_init) Add new zebra debugging commands.
414 * bgp_zebra.c: (bgp_router_id_update, bgp_interface_add,
415 bgp_interface_delete, bgp_interface_up, bgp_interface_down,
416 bgp_interface_address_add, bgp_interface_address_delete,
417 zebra_read_ipv4, zebra_read_ipv6, bgp_zebra_announce,
418 bgp_zebra_withdraw, bgp_redistribute_set, bgp_redistribute_unset)
419 If zebra debugging is enabled, log an appropriate debug message.
420
Andrew J. Schorr8d452102006-11-28 19:50:46 +00004212006-11-28 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
422
423 * bgp_route.c: (bgp_info_restore) New function that undoes
424 the effects of a previous call to bgp_info_delete. This is
425 used when a route is deleted and quickly re-added before the
426 deletion has been processed.
427 (bgp_static_update_rsclient, bgp_static_update_main,
428 bgp_redistribute_add) Check whether a pre-existing route
429 has the BGP_INFO_REMOVED set, and, if so, we need to call
430 bgp_info_restore to resurrect it.
431
Paul Jakma56395af2006-10-27 16:58:20 +00004322006-10-27 Paul Jakma <paul.jakma@sun.com>
433
434 * bgp_route.c: (bgp_table_stats) oops, u_intXX_t should be
435 uintXX_t
436
Paul Jakma6f585442006-10-22 19:13:07 +00004372006-10-19 Paul Jakma <paul.jakma@sun.com>
438
439 * bgpd.c: (peer_new) bgp element of peer absolutely must be
440 filled in, make peer_new() require it as argument and update
441 all callers. Fixes a crash reported by Jan 'yanek' Bortl and
442 Andrew Schorr where bgpd would crash in bgp_pcount_adjust
443 trying to dereference the bgp member of bgp->peer_self,
444 triggered through redistribution.
445 * bgp_route.c: (bgp_pcount_adjust) assert sanity of arguments.
446
Paul Jakma53d9f672006-10-15 23:41:16 +00004472006-10-15 Paul Jakma <paul.jakma@sun.com>
448
449 * bgp_route.c: (bgp_table_stats_walker) NULL deref if table is
450 empty, bgp_table_top may return NULL, Coverity CID#73.
Paul Jakmaed3ebfa2006-10-15 23:50:16 +0000451 * bgp_packet.c: (bgp_update_packet) adv->rn can not be NULL,
452 check is bogus - changed to assert(), CID#64.
453 binfo is checked for NULL, but then dereferenced
454 unconditionally, fix, CID #63.
455 (bgp_withdraw_packet) Assert adv->rn is valid, as with
456 bgp_update_packet().
Paul Jakma53d9f672006-10-15 23:41:16 +0000457
Paul Jakmadcdf3992006-10-15 23:39:59 +00004582006-10-14 Paul Jakma <paul.jakma@sun.com>
459
460 * bgp_fsm.h: Remove BGP_EVENT_FLUSH_ADD, dangerous and not
461 needed.
462 * bgp_fsm.c: (bgp_stop) Move BGP_EVENT_FLUSH to the top of the
463 of the function, otherwise it could flush a ClearingCompleted
464 event, bug #302.
465 * bgp_packet.c: Replace all BGP_EVENT_FLUSH_ADD with
466 BGP_EVENT_ADD, fixing bug #302.
467
Andrew J. Schorr0cd1c322006-09-19 18:51:53 +00004682006-09-19 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
469
470 * bgpd.c: (peer_uptime) Fix printf format/arg mismatch in
471 zlog_warn message (%ld/size_t -> %lu/u_long).
472
Paul Jakmaca058a32006-09-14 02:58:49 +00004732006-09-14 Paul Jakma <paul.jakma@sun.com>
474
Paul Jakma8383a9b2006-09-14 03:06:54 +0000475 * bgp_route.c: (bgp_table_stats_walker) Address space announced
476 should only count top-level unaggregateable prefixes, to
477 avoid falling afoul of anti-dodgy-accounting regulations
478 in various jurisdictions.. ;)
Paul Jakma09dd5612006-09-14 03:38:16 +0000479 (bgp_process_queue_init) process queue hold time too high,
480 adds extra memory load. Change to be much lower, until such
481 time as it's made configurable.
Paul Jakma8383a9b2006-09-14 03:06:54 +0000482
4832006-09-14 Paul Jakma <paul.jakma@sun.com>
484
Paul Jakma9fde6622006-09-14 03:02:02 +0000485 * (general) fix the peer refcount issue exposed by previous, by
486 just removing refcounting of peer threads, which is mostly
487 senseless as they're references leading from struct peer,
488 which peer_free cancels anyway. No need to muck around..
489 * bgp_fsm.h: Just remove the refcounting from the various
490 TIMER/READ/WRITE/EVENT ON/OFF/ADD macros.
491 * bgp_fsm.c: (bgp_stop) use BGP_EVENT_FLUSH, no refcounts attached
492 to events anymore.
493 (bgp_event) remove peer_unlock, events not refcounted.
494 * bgpd.c: (peer_free) flush events before free.
495
4962006-09-14 Paul Jakma <paul.jakma@sun.com>
497
Paul Jakmaca058a32006-09-14 02:58:49 +0000498 * (general) Fix some niggly issues around 'shutdown' and clearing
499 by adding a Clearing FSM wait-state and a hidden 'Deleted'
500 FSM state, to allow deleted peers to 'cool off' and hit 0
501 references. This introduces a slow memory leak of struct peer,
502 however that's more a testament to the fragility of the
503 reference counting than a bug in this patch, cleanup of
504 reference counting to fix this is to follow.
505 * bgpd.h: Add Clearing, Deleted states and Clearing_Completed
506 and event.
507 * bgp_debug.c: (bgp_status_msg[]) Add strings for Clearing and
508 Deleted.
509 * bgp_fsm.h: Don't allow timer/event threads to set anything
510 for Deleted peers.
511 * bgp_fsm.c: (bgp_timer_set) Add Clearing and Deleted. Deleted
512 needs to stop everything.
513 (bgp_stop) Remove explicit fsm_change_status call, the
514 general framework handles the transition.
515 (bgp_start) Log a warning if a start is attempted on a peer
516 that should stay down, trying to start a peer.
517 (struct .. FSM) Add Clearing_Completed
518 events, has little influence except when in state
519 Clearing to signal wait-state can end.
520 Add Clearing and Deleted states, former is a wait-state,
521 latter is a placeholder state to allow peers to disappear
522 quietly once refcounts settle.
523 (bgp_event) Try reduce verbosity of FSM state-change debug,
524 changes to same state are not interesting (Established->Established)
525 Allow NULL action functions in FSM.
526 * bgp_packet.c: (bgp_write) Use FSM events, rather than trying
527 to twiddle directly with FSM state behind the back of FSM.
528 (bgp_write_notify) ditto.
529 (bgp_read) Remove the vague ACCEPT_PEER peer_unlock, or else
530 this patch crashes, now it leaks instead.
531 * bgp_route.c: (bgp_clear_node_complete) Clearing_Completed
532 event, to end clearing.
533 (bgp_clear_route) See extensive comments.
534 * bgpd.c: (peer_free) should only be called while in Deleted,
535 peer refcounting controls when peer_free is called.
536 bgp_sync_delete should be here, not in peer_delete.
537 (peer_delete) Initiate delete.
538 Transition to Deleted state manually.
539 When removing peer from indices that provide visibility of it,
540 take great care to be idempotent wrt the reference counting
541 of struct peer through those indices.
542 Use bgp_timer_set, rather than replicating.
543 Call to bgp_sync_delete isn't appropriate here, sync can be
544 referenced while shutting down and finishing deletion.
545 (peer_group_bind) Take care to be idempotent wrt list references
546 indexing peers.
547
Paul Jakma2815e612006-09-14 02:56:07 +00005482006-09-13 Paul Jakma <paul.jakma@sun.com>
549
550 * bgp_aspath.c: (aspath_highest) new, return highest ASN in an
551 aspath.
552 * bgp_route.c: (bgp_peer_count_walker) new, do the walk done
553 in bgp_peer_counts as a thread.
554 (bgp_peer_counts) move walk to previous and call it via
555 thread_execute so this RIB walk shows up in thread stats.
556 (bgp_table_stats) New, gather some statistics for a given
557 RIB.
558 (bgp_table_stats_walker) New, RIB walker thread for former.
559 (bgp_table_stats_vty) Parsing front-end for 'show bgp ...',
560 useful model for future rationalisation of 'show ... bgp'.
561 (bgp_route_init) Add new RIB stats commands.
562
Paul Jakma1a392d42006-09-07 00:24:49 +00005632006-09-06 Paul Jakma <paul.jakma@sun.com>
564
565 * (general) Squash any and all prefix-count issues by
566 abstracting route flag changes, and maintaining count as and
567 when flags are modified (rather than relying on explicit
568 modifications of count being sprinkled in just the right
569 places throughout the code).
570 * bgp_route.c: (bgp_pcount_{dec,inc}rement) removed.
571 (bgp_pcount_adjust) new, update prefix count as
572 needed for a given route.
573 (bgp_info_{uns,s}et_flag) set/unset a BGP_INFO route status
574 flag, calling previous function when appropriate.
575 (general) Update all set/unsets of flags to use previous.
576 Remove pcount_{dec,inc}rement calls.
577 No need to unset BGP_INFO_VALID in places where
578 bgp_info_delete is called, it does that anyway.
579 * bgp_{damp,nexthop}.c: Update to use bgp_info_{un,}set_flag.
580 * bgp_route.h: Export bgp_info_{un,}set_flag.
581 Add a 'meta' BGP_INFO flag, BGP_INFO_UNUSEABLE.
582 Move BGP_INFO_HOLDDOWN macro to here from bgpd.h
583
Paul Jakmaff7924f2006-09-04 01:10:36 +00005842006-09-03 Paul Jakma <paul.jakma@sun.com>
585
586 * bgp_route.c: Add 'show ... bgp ... <neighbour> prefix-count'
587 commands, to provide detailed counts of prefixes for a peer.
588 Informative, and should help pin down to pfxcnt drift
589 problems.
590
Paul Jakma9f906c72006-08-27 06:57:47 +00005912006-08-27 Paul Jakma <paul.jakma@sun.com>
592
593 * bgp_advertise.c: (bgp_sync_delete) fix mtype in XFREE.
594 NULL out peer->hash after free, to be sure.
595
Paul Jakma1f742f22006-08-06 15:52:11 +00005962006-08-06 Paul Jakma <paul.jakma@sun.com>
597
598 * bgp_aspath.c: (aspath_loop_check) Fix the typo-bug which
599 essentially had disabled this check. Problem reported by
600 Bartek Kania <mrbk@gnarf.org> in [quagga-users 7388].
601
Paul Jakma18937402006-07-27 19:05:12 +00006022006-07-27 Paul Jakma <paul.jakma@sun.com>
603
604 * bgpd.c: (peer_delete) Ensure freed buffers can not be
605 accidently reused. A potential fix for bug #287.
606
Paul Jakma33d5ab92006-07-02 11:01:50 +00006072006-07-02 Paul Jakma <paul.jakma@sun.com>
608
609 * bgp_fsm.c: (bgp_{stop,start}) Move clear/free of certain
610 bits of state from stop to start, as they may be used via
611 peer references on clearing queues..
612
Paul Jakma369688c2006-05-23 22:27:55 +00006132006-05-23 Paul Jakma <paul.jakma@sun.com>
614
615 * bgp_vty.c: (neighbor_update_source_cmd) Expand tab completion
616 to make it clear it takes both address and ifname.
617
Paul Jakma34c3f812006-05-12 23:25:37 +00006182006-05-12 Paul Jakma <paul.jakma@sun.com>
619
620 * bgp_attr.c: (bgp_packet_attribute) Remove dead code, Coverity
621 CID #1
Paul Jakmab2518c12006-05-12 23:48:40 +0000622 * bgp_aspath.{c,h}: (aspath_print_vty) take a format string,
623 so as to reduce burden on callers, all in bgp_route.c
Paul Jakmadd8103a2006-05-12 23:27:30 +0000624 * bgp_route.c: (bgp_static_update_main) Remove useless NULL
625 check, code already assumes bgp_static can not be NULL,
626 fixes CID #7.
Paul Jakma06e110f2006-05-12 23:29:22 +0000627 (bgp_static_update_rsclient) ditto, CID #6
Paul Jakmab2518c12006-05-12 23:48:40 +0000628 (route_vty_out{,tmp}) Update to match aspath_print_vty,
629 simplifying checks needed to get spacing right. CID #4,#5.
630 ({damp,flap}_route_vty_out) Ditto, CID #9, #10
Paul Jakma34c3f812006-05-12 23:25:37 +0000631
Paul Jakma542bcb72006-05-08 14:25:09 +00006322006-05-08 Paul Jakma <paul.jakma@sun.com>
633
634 * bgp_community.c: (community_str2com) Coverity CID#62, fix
635 double-free, use-after-free.
Paul Jakmada5b30f2006-05-08 14:37:17 +0000636 * bgp_route.c: (bgp_afi_node_get) given table should never be
637 NULL, check/assert this.
638 (bgp_static_update) Bug #240. Rsclients should only be passed
639 the static update if they are configured for the afi,safi.
Paul Jakma542bcb72006-05-08 14:25:09 +0000640
Paul Jakmaa3b6ea52006-05-04 07:52:12 +00006412006-05-04 Paul Jakma <paul.jakma@sun.com>
642
643 * (general) VPNv4 fixes. Certain VPNv4 code was not enabled.
644 See bug #210.
645 * bgp_attr.{c,h}: (bgp_packet_{withdraw,attribute}) Tag should be
646 u_char really.
647 * bgp_packet.c: (bgp_{update,withdraw}_packet) Enable some
648 VPNv4 code which inexplicably was ifdef'd out. comments from
649 a tester on IRC suggest this fixes bug #210.
Paul Jakma65ca75e2006-05-04 08:08:15 +0000650 * bgp_route.c: (general) Fix logical bug in clearing, noted
651 by Chris Caputo in [quagga-users 6728] - clearing depended on
652 at least one route being added to workqueue, in order for
653 workqueue completion function to restart FSM. However, if no
654 routes are cleared, then the completion function never is
655 called, it needs to be called manually if the workqueue
656 didn't get scheduled.
657 Finally, clearing is per-peer-session, not per AFI/SAFI, so
658 the FSM synchronisation should be in bgp_clear_route_table.
659 (bgp_clear_route_table) Wrong place for FSM/clearing
660 synchronisation, move to..
661 (bgp_clear_route) FSM/clearing synchronisation should be
662 here.
663 If no routes were cleared, no workqueue scheduled, call
664 the completion func to ensure FSM kicks off again.
Paul Jakmaa3b6ea52006-05-04 07:52:12 +0000665
Paul Jakma15aa6a12006-03-30 14:39:35 +00006662006-03-30 Paul Jakma <paul.jakma@sun.com>
667
668 * bgp_community.c: (community_gettoken) Unknown token should
669 return NULL, to give a strong indication to callers that
670 the token no longer can be parsed, otherwise callers looping
671 on this function may have a hard time ending their loop.
672 (community_str2com) While loop around community_gettoken appears
673 to have been coded thinking that break statement would break
674 from the while{}, hence it could never exit for unknown token
675 case. Fix it to do..while, so it can use the NULL result from
676 community_gettoken easily.
677
Paul Jakmaa625ca32006-03-30 14:12:38 +00006782006-03-22 Paul Jakma <paul.jakma@sun.com>
679
680 * bgpd.c: (peer_free) release the per-peer workqueue when
681 freeing the peer.
682
Paul Jakma5304cb52006-03-30 14:01:14 +00006832006-03-19 Paul Jakma <paul.jakma@sun.com>
684
Paul Jakma4bf6a362006-03-30 14:05:23 +0000685 * bgpd/bgp_vty.c: Add includes to get several structs we want
686 to provide usage statistics on.
687 (show_bgp_memory_cmd) Show memory usage stats for various
688 notable fixed size objects. Using mtype_stats_alloc and
689 mtype_memstr recently added to memory.c.
690 (bgp_show_summary) Report some additional stats specific to
691 the given BGP instance and/or AFI/SAFI such as table counts,
692 peers, rsclients and peer-groups.
693 (bgp_vty_init) Install show_bgp_memory_cmd.
Paul Jakma5304cb52006-03-30 14:01:14 +0000694 * bgp_nexthop.h: Include if.h as a dependent header, for struct
695 connected.
Paul Jakmab51f1262006-03-30 14:09:38 +0000696 * bgp_advertise.c: Use a distinct memory type for struct
697 bgp_synchronize.
Paul Jakma5304cb52006-03-30 14:01:14 +0000698
Paul Jakmacbdfbaa2006-03-30 13:20:48 +00006992006-03-12 Paul Jakma <paul.jakma@sun.com>
700
701 * bgp_attr.h: (struct attr) rearrange fields to avoid
702 wasted padding between them as much as possible.
703 (attr_count,attr_unknown_count) export new functions to
704 return number of counts of cached attributes.
705 * bgp_attr.c: (attr_count,attr_unknown_count) new functions to
706 return number of counts of cached attributes.
707 * bgp_route.h: (struct bgp_info) rearrange fields to avoid
708 wasted padding.
709 * bgp_table.h: (struct bgp_table) Add a count field, of number
710 of nodes in the table.
711 (struct bgp_node) rearrange fields to avoid
712 wasted padding between them, though I don't think there
713 was any in this case.
714 * bgp_table.c: (bgp_node_{delete,get}) Maintain the table node count.
715 (bgp_table_count) new function to access the table count.
716
Paul Jakma3e0c78e2006-03-06 18:06:53 +00007172006-03-03 Paul Jakma <paul.jakma@sun.com>
718
719 * bgp_route.c: (bgp_clear_node_complete) Doh. When clearing
720 is complete we need to kick off FSM again.
721
Paul Jakma64e580a2006-02-21 01:09:01 +00007222006-02-21 Paul Jakma <paul.jakma@sun.com>
723
724 * bgpd.h: move the clear_node_queue to be peer specific.
725 Add a new peer status flag, PEER_STATUS_CLEARING.
726 * bgp_table.h: (struct bgp_table) Add fields to record afi,
727 safi of the table.
728 (bgp_table_init) Take afi and safi to create table for.
729 * bgp_table.c: (bgp_table_init) record the afi and safi.
730 * bgp_nexthop.c: Update all calls to bgp_table_init.
731 * bgp_vty.c: ditto.
732 * bgpd.c: ditto.
733 * bgp_fsm.c: (bgp_timer_set) dont bring up a session which is
734 clearing.
735 * bgp_route.c: (general) Update all bgp_table_init calls.
736 (bgp_process_{rsclient,main}) clear_node is serialised
737 via PEER_STATUS_CLEARING and fsm now.
738 (struct bgp_clear_node_queue) can be removed. struct bgp_node
739 can be the queue item data directly, as struct peer can be
740 kept in the new wq global user data and afi/safi can be
741 retrieved via bgp_node -> bgp_table.
742 (bgp_clear_route_node) fix to get peer via wq->spec.data,
743 afi/safi via bgp_node->bgp_table.
744 (bgp_clear_node_queue_del) no more item data to delete, only
745 unlock the bgp_node.
746 (bgp_clear_node_complete) only need to unset CLEARING flag
747 and unlock struct peer.
748 (bgp_clear_node_queue_init) queue attaches to struct peer
749 now. record peer name as queue name.
750 (bgp_clear_route_table) If queue transitions to active,
751 serialise clearing by setting PEER_STATUS_CLEARING rather
752 than plugging process queue, and lock peer while queue
753 active.
754 Update to pass only bgp_node as per-queue-item specific data.
Paul Jakma6a419732006-02-21 01:14:13 +0000755 * bgp_vty.c: (bgp_show_summary) Add a 'Clrng' sub-description
756 to state of peer while it's suppressed due to clearing.
Paul Jakma64e580a2006-02-21 01:09:01 +0000757
Paul Jakmaaa94ca82006-02-18 10:49:04 +00007582006-02-18 Paul Jakma <paul.jakma@sun.com>
759
760 * bgp_routemap.c: (route_set_community) Quick, very hacky, fix
761 for the set-community leak, bug #89. True fix will be to
762 detangle the web of *_intern caching and provide saner object
763 caching for Quagga, future work.
Paul Jakma7c7fa1b2006-02-18 10:52:09 +0000764 * bgp_route.c: (bgp_announce_check) trivial, move declaration
765 of two local variables into the only block where they are
766 used, to aid the reader.
Paul Jakmaaa94ca82006-02-18 10:49:04 +0000767
paul902212c2006-02-05 17:51:19 +00007682006-02-05 Paul Jakma <paul.jakma@sun.com>
769
770 * bgp_route.h: Add BGP_INFO_COUNTED to track whether
771 prefix has been counted or not.
772 * bgp_route.c: (bgp_pcount_{inc,dec}rement) new helpers, to
773 centralise inc/dec of prefix-count,
774 (bgp_rib_remove) Remove pcount decrement, use helper.
775 (bgp_rib_withdraw) ditto, additionally use previous function
776 too.
777 (bgp_update_main) Use pcount helpers.
778 (bgp_clear_route_node) ditto, aslo REMOVED routes don't need
779 clearing.
paul3fff6ff2006-02-05 17:55:35 +0000780 * bgp_aspath.c: (aspath_gettoken) fix gcc warning about
781 possible uninitialised usage.
paul902212c2006-02-05 17:51:19 +0000782
paul306d8892006-02-02 17:50:19 +00007832006-02-02 Paul Jakma <paul.jakma@sun.com>
784
785 * bgp_route.c: (bgp_{clear_node,process}_queue_init) delay
786 field is removed from workqueue spec.
787
paule8e19462006-01-19 20:16:55 +00007882006-01-19 Paul Jakma <paul.jakma@sun.com>
789
790 * (general) various miscellaneous compiler warning fixes.
791 Remove redundant break statements from switch clauses
792 which return.
793 return from main, not exit, cause it annoys SOS.
794 Remove stray semi-colons which cause empty-statement
795 warnings.
796
pauld3092e72006-01-17 17:33:46 +00007972006-01-17 Paul Jakma <paul.jakma@sun.com>
798
799 * bgp_nexthop.c: (zlookup_read*) convert to new Zserv format.
800 (zlookup_query_ipv6) ditto.
801 (bgp_import_check) ditto.
802
paul02335422006-01-16 11:13:27 +00008032006-01-16 Paul Jakma <paul.jakma@sun.com>
804
805 * bgp_aspath.c: (assegment_append_asns) XREALLOC can return
806 NULL theoretically, take care not to lose the allocated data.
807 (aspath_hash_alloc) aspath_dup already set the aspath
808 string - fix leak.
809 (aspath_parse) aspath_hash_alloc dupes the entire aspath,
810 including segments, but we forgot to free the temporary
811 assegment.
paul8fdc32a2006-01-16 12:01:29 +0000812 (aspath_snmp_pathseg) move the static stream pointer out to
813 file scope, so it can be freed.
814 (aspath_finish) new function, free aspath resources.
815 * bgp_aspath.h: (aspath_finish) export.
paul02335422006-01-16 11:13:27 +0000816
paul37c38302006-01-10 22:15:45 +00008172006-01-10 Juris Kalnins <juris@mt.lv>
818
819 * bgpd.h: (bgp_router_id_unset) ex-function, remove.
820
paulad727402005-11-23 02:47:02 +00008212005-11-23 Paul Jakma <paul.jakma@sun.com>
822
823 * bgp_aspath.c: (assegments_parse) should be static
824
8252005-11-23 Juergen Kammer <j.kammer@eurodata.de>
826
827 * bgp_aspath.c: (aspath_cmp_left_confed) fix SEGV for case
828 where one or both paths are empty.
829
paul0fb58d52005-11-14 14:31:49 +00008302005-11-14 Paul Jakma <paul.jakma@sun.com>
831
832 * bgp_route.c: (bgp_process_rsclient) convert to new workqueue
833 specs and shut up gcc, which complains about cast from void
834 via function parameters, for some dumb reason. Do the cast
835 inside the function instead.
836 (bgp_process_main,bgp_processq_del) ditto.
837 (bgp_clear_route_node) ditto.
838 (bgp_clear_node_queue_del) ditto.
839
paul41200852005-11-03 12:52:18 +00008402005-11-03 Paul Jakma <paul.jakma@sun.com>
841
842 * bgp_damp.c: (bgp_reuse_timer) struct bgp can be retrieved via
843 the struct bgp_damp_info, no need to guess by using
844 bgp_get_default().
845
ajsf52d13c2005-10-01 17:38:06 +00008462005-10-01 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
847
848 * bgp_vty.c: (bgp_config_write_redistribute) Use new library function
849 zebra_route_string instead of a local hard-coded table.
850
jardin2d74db52005-10-01 00:07:50 +00008512005-09-30 Vincent Jardin <vincent.jardin@6wind.com>
852
853 * bgp_packet.c: fix compilation when DEBUG is used.
854
paul1f8ae702005-09-09 23:49:49 +00008552005-09-10 Paul Jakma <paul.jakma@sun.com>
856
paulfe69a502005-09-10 16:55:02 +0000857 * Makefile.am: bgpd shouldn't list libgp's sources as its own.
858 Use LDADD.
859 * bgp_aspath.h:
860 (struct assegment) New struct, abstract representation of a
861 list of AS_PATH segments and the contained ASNs.
862 (struct aspath) Remove the raw-data related
863 fields, reference the abstract struct assegment instead.
864 Remove several other computed fields, it's just a
865 headache to maintain them and they're cheap to compute from
866 struct assegment.
867 (aspath_parse) parse a stream, not a pointer to raw data.
868 (aspath_count_{hops,confeds,size}) helpers to access
869 information formerly directly contained in struct aspath.
870 (aspath_snmp_pathseg) Helper for SNMP, BGP MIB wants
871 to be able to output hex representation of raw data.
872 * bgp_aspath.c: (general) partial-rewrite. Store aspath data
873 as an abstract singly-linked list of abstract segments,
874 rather than storing the raw data, and parsing it each and
875 every time. Remove several count/size fields which are cheap
876 to compute from the abstract segment structure.
877 (global) Include stream.h, needed for aspath_parse, and
878 others. Couple of helper macros added.
879 (struct assegment_header) Just the header, and only the
880 header.
881 (assegment_data_{new,free}) convenience functions for
882 AS_SEG_DATA allocation, the dynamic, per-segment array of
883 ASNs.
884 (assegment_{new,free,free_all,dup,dup_all}) convenience
885 functions for creating struct assegments. The _all forms will
886 follow the entire chain of segments from the given segment.
887 (assegment_prepend_asns) new function, prepend an ASN N times
888 to segment.
889 (assegment_append_asns) Append a list (array) of ASNs to
890 segment.
891 (int_cmp) convenience function for the aspath hash.
892 (assegment_normalise) new function. Normalise the given
893 segment chain to meet expectations of Quagga, and to
894 eliminate differing raw representations of the same paths.
895 Merge 'runs' of SEQUENCEs into one segment as our internal
896 segment is not limited by the protocol AS_PATH segment
897 length. Sort ASNs in SETs.
898 (aspath_new) Take void argument to quell warnings. Use the
899 assegment convenience functions.
900 (assegment_count_{asns,confeds,hops}) new functions to
901 compute at runtime values previously held in struct aspath.
902 (aspath_size) ditto.
903 (aspath_make_str_count) rewritten to stringify new
904 representation, and to be slightly easier to understand
905 hopefully.
906 (aspath_str_update) convenience function, update the aspath
907 str. Should investigate removing maintained string from
908 struct aspath, just run-time compute it, as per other fields.
909 It's just a maintenance headache, would save noticeable
910 amount of RAM with possibly not much extra run-time cost.
911 (aspath_dup) use the assegment dup functions.
912 (aspath_hash_alloc) Take void * argument to satisfy gcc. Use
913 the proper helper functions to dup data.
914 (assegments_parse) new function. parse raw AS_PATH data into
915 struct assegments. Normalise and return the head of the list.
916 (aspath_parse) Parse a stream, not pointer to raw data and
917 use assegments_parse to do it.
918 (assegment_data_put) Write out a single segment data in protocol
919 form to stream.
920 (assegment_header_put) ditto but for segment header.
921 (aspath_put) new function. As per previous but for an entire
922 struct aspath.
923 (aspath_snmp_pathseg) wrapper around aspath_put for
924 bgp_snmp.c. Uses a static buffer sadly.
925 (aspath_aggregate_as_set_add) rewritten to use assegments.
926 (aspath_aggregate) ditto
927 (aspath_{firstas,loop,private_as}_check) ditto
928 (aspath_{merge,prepend,add_one_as}) ditto
929 (aspath_cmp_left{_confed}) ditto
930 (aspath_delete_confed_seq) ditto, plus fixed to properly
931 delete all leading confed segments.
932 (aspath_as_add) Just use assegment_append_asns.
933 (aspath_segment_add) updated to use assegments.
934 (enum as_token) Add values for confeds
935 (aspath_gettoken) Add support for confeds
936 (aspath_str2aspath) ditto
937 (aspath_key_make) updated to use as_segments. Also, add
938 segment type into the hash value as appropriate.
939 (aspath_cmp) updated to use as_segments.
940 (aspath_print) don't segfault on NULL argument.
941 * bgp_attr.c: (bgp_attr_aspath) aspath_parse wants the stream
942 now. No need for manual forwarding of stream.
943 (bgp_packet_attribute) empty aspath is now denoted by NULL
944 segment field, length is gone.
945 Use aspath_size() to determine size.
946 (bgp_attr_init) Fix declaration, explicitely specify void
947 arg.
948 (bgp_dump_routes_attr) Use aspath_size() to determine size.
949 * bgp_route.c: (bgp_info_cmp) use the aspath_count_* functions.
950 (bgp_rib_withdraw) remove unused variable. Use
951 aspath_count_hops.
952 * bgp_snmp.c: (bgp4PathAttrTable) raw data is gone, use
953 aspath_snmp_pathseg to get the representation.
954
9552005-09-10 Paul Jakma <paul.jakma@sun.com>
956
paul1f8ae702005-09-09 23:49:49 +0000957 * bgp_vty.c: (bgp_vty_init) gcc 4 compile fix. static
958 function declarations shouldn't be inside functions.
959 * bgp_dump.c: (bgp_dump_interval_add) ditto.
960
hassob7395792005-08-26 12:58:38 +00009612005-08-26 Hasso Tepper <hasso at quagga.net>
962
963 * bgp_route.c: Third (?) attempt to fix best selection breakage
964 introduced long time ago with route server patch. Hopefully
965 it's last case to fix - route-server client not in peer group.
966
paul25ffbdc2005-08-22 22:42:08 +00009672005-08-22 Hugo Santos <hsantos@av.it.pt>
968
969 * bgp_vty.c: (general) Add support for BGP IPv6 Multicast SAFI
970 commands and BGP_IPV6M_NODE.
971
paulb40d9392005-08-22 22:34:41 +00009722005-08-22 Paul Jakma <paul.jakma@sun.com>
973
974 * bgp_route.h: (struct bgp_info) add a new flag, BGP_INFO_REMOVED.
975 BGP_INFO_VALID is already overloaded, don't care to do same thing
976 to STALE or HISTORY.
977 * bgpd.h: (BGP_INFO_HOLDDOWN) Add INFO_REMOVED to the macro, as a
978 route which should generally be ignored.
979 * bgp_route.c: (bgp_info_delete) Just set the REMOVE flag, rather
980 than doing actual work, so that bgp_process (called directly,
981 or indirectly via the scanner) can catch withdrawn routes.
982 (bgp_info_reap) Actually remove the route, what bgp_info_delete
983 used to do, only for use by bgp_process.
984 (bgp_best_selection) reap any REMOVED routes, other than the old
985 selected route.
986 (bgp_process_rsclient) reap the old-selected route, if appropriate
987 (bgp_process_main) ditto
988 (bgp_rib_withdraw, bgp_rib_remove) make them more consistent with
989 each other. Don't play games with the VALID flag, bgp_process
990 is async now, so it didn't make a difference anyway.
991 Remove the 'force' argument from bgp_rib_withdraw, withdraw+force
992 is equivalent to bgp_rib_remove. Update all its callers.
993 (bgp_update_rsclient) bgp_rib_withdraw and force set is same as
994 bgp_rib_remove.
995 (route_vty_short_status_out) new helper to print the leading
996 route-status string used in many command outputs. Consolidate.
997 (route_vty_out, route_vty_out_tag, damp_route_vty_out,
998 flap_route_vty_out) use route_vty_short_status_out rather than
999 duplicate.
1000 (route_vty_out_detail) print state of REMOVED flag.
1001 (BGP_SHOW_SCODE_HEADER) update for Removed flag.
1002
hassoe279c7a2005-08-03 17:23:20 +000010032005-08-03 Hasso Tepper <hasso at quagga.net>
1004
1005 * bgp_routemap.c: Revert part of leaking communities fix commited in
1006 2005-05-27. While ecommunity fix seems to be correct, community case
1007 isn't.
1008
paul94f2b392005-06-28 12:44:16 +000010092005-06-28 Paul Jakma <paul.jakma@sun.com>
1010
1011 * (global) The great bgpd extern and static'ification.
1012 * bgp_routemap.c: remove unused ROUTE_MATCH_ASPATH_OLD code
1013 (route_set_metric_compile) fix u_int32_t to ULONG_MAX comparison
1014 warnings.
1015 * bgp_route.h: (bgp_process, bgp_withdraw, bgp_update) export these
1016 used by various files which had their own private declarations,
1017 in the case of mplsvpn - incorrect.
1018
paule210cf92005-06-15 19:15:35 +000010192005-06-15 Paul Jakma <paul.jakma@sun.com>
1020
1021 * bgpd.c: (bgp_terminate) workqueue's are lazy allocated and its
1022 possible to terminate bgpd before workqueues were setup, causing
1023 an abort/crash. Reported by Ashish Mehta of Sun.
1024
paul200df112005-06-01 11:17:05 +000010252005-06-01 Paul Jakma <paul.jakma@sun.com>
1026
1027 * (general) refcount struct peer and bgp_info, hence allowing us
1028 add work_queues for bgp_process.
1029 * bgp_route.h: (struct bgp_info) Add 'lock' field for refcount.
1030 Add bgp_info_{lock,unlock} helper functions.
1031 Add bgp_info_{add,delete} helpers, to remove need for
1032 users managing locking/freeing of bgp_info and bgp_node's.
1033 * bgp_table.h: (struct bgp_node) Add a flags field, and
1034 BGP_NODE_PROCESS_SCHEDULED to merge redundant processing of
1035 nodes.
1036 * bgp_fsm.h: Make the ON/OFF/ADD/REMOVE macros lock and unlock
1037 peer reference as appropriate.
1038 * bgp_damp.c: Remove its internal prototypes for
1039 bgp_info_delete/free. Just use bgp_info_delete.
1040 * bgpd.h: (struct bgp_master) Add work_queue pointers.
1041 (struct peer) Add reference count 'lock'
1042 (peer_lock,peer_unlock) New helpers to take/release reference
1043 on struct peer.
1044 * bgp_advertise.c: (general) Add peer and bgp_info refcounting
1045 and balance how references are taken and released.
1046 (bgp_advertise_free) release bgp_info reference, if appropriate
1047 (bgp_adj_out_free) unlock peer
1048 (bgp_advertise_clean) leave the adv references alone, or else
1049 call bgp_advertise_free cant unlock them.
1050 (bgp_adj_out_set) lock the peer on new adj's, leave the reference
1051 alone otherwise. lock the new bgp_info reference.
1052 (bgp_adj_in_set) lock the peer reference
1053 (bgp_adj_in_remove) and unlock it here
1054 (bgp_sync_delete) make hash_free on peer conditional, just in
1055 case.
1056 * bgp_fsm.c: (general) document that the timers depend on
1057 bgp_event to release a peer reference.
1058 (bgp_fsm_change_status) moved up the file, unchanged.
1059 (bgp_stop) Decrement peer lock as many times as cancel_event
1060 canceled - shouldnt be needed but just in case.
1061 stream_fifo_clean of obuf made conditional, just in case.
1062 (bgp_event) always unlock the peer, regardless of return value
1063 of bgp_fsm_change_status.
1064 * bgp_packet.c: (general) change several bgp_stop's to BGP_EVENT's.
1065 (bgp_read) Add a mysterious extra peer_unlock for ACCEPT_PEERs
1066 along with a comment on it.
1067 * bgp_route.c: (general) Add refcounting of bgp_info, cleanup
1068 some of the resource management around bgp_info. Refcount peer.
1069 Add workqueues for bgp_process and clear_table.
1070 (bgp_info_new) make static
1071 (bgp_info_free) Ditto, and unlock the peer reference.
1072 (bgp_info_lock,bgp_info_unlock) new exported functions
1073 (bgp_info_add) Add a bgp_info to a bgp_node in correct fashion,
1074 taking care of reference counts.
1075 (bgp_info_delete) do the opposite of bgp_info_add.
1076 (bgp_process_rsclient) Converted into a work_queue work function.
1077 (bgp_process_main) ditto.
1078 (bgp_processq_del) process work queue item deconstructor
1079 (bgp_process_queue_init) process work queue init
1080 (bgp_process) call init function if required, set up queue item
1081 and add to queue, rather than calling process functions directly.
1082 (bgp_rib_remove) let bgp_info_delete manage bgp_info refcounts
1083 (bgp_rib_withdraw) ditto
1084 (bgp_update_rsclient) let bgp_info_add manage refcounts
1085 (bgp_update_main) ditto
1086 (bgp_clear_route_node) clear_node_queue work function, does
1087 per-node aspects of what bgp_clear_route_table did previously
1088 (bgp_clear_node_queue_del) clear_node_queue item delete function
1089 (bgp_clear_node_complete) clear_node_queue completion function,
1090 it unplugs the process queues, which have to be blocked while
1091 clear_node_queue is being processed to prevent a race.
1092 (bgp_clear_node_queue_init) init function for clear_node_queue
1093 work queues
1094 (bgp_clear_route_table) Sets up items onto a workqueue now, rather
1095 than clearing each node directly. Plugs both process queues to
1096 avoid potential race.
1097 (bgp_static_withdraw_rsclient) let bgp_info_{add,delete} manage
1098 bgp_info refcounts.
1099 (bgp_static_update_rsclient) ditto
1100 (bgp_static_update_main) ditto
1101 (bgp_static_update_vpnv4) ditto, remove unneeded cast.
1102 (bgp_static_withdraw) see bgp_static_withdraw_rsclient
1103 (bgp_static_withdraw_vpnv4) ditto
1104 (bgp_aggregate_{route,add,delete}) ditto
1105 (bgp_redistribute_{add,delete,withdraw}) ditto
1106 * bgp_vty.c: (peer_rsclient_set_vty) lock rsclient list peer
1107 reference
1108 (peer_rsclient_unset_vty) ditto, but unlock same reference
1109 * bgpd.c: (peer_free) handle frees of info to be kept for lifetime
1110 of struct peer.
1111 (peer_lock,peer_unlock) peer refcount helpers
1112 (peer_new) add initial refcounts
1113 (peer_create,peer_create_accept) lock peer as appropriate
1114 (peer_delete) unlock as appropriate, move out some free's to
1115 peer_free.
1116 (peer_group_bind,peer_group_unbind) peer refcounting as
1117 appropriate.
1118 (bgp_create) check CALLOC return value.
1119 (bgp_terminate) free workqueues too.
1120
hasso033e8612005-05-28 04:50:54 +000011212005-05-28 Hasso Tepper <hasso at quagga.net>
1122
1123 * bgp_routemap.c: Sync set_metric_addsub_cmd with ripd.
1124
hasso54a6ed32005-05-26 22:12:33 +000011252005-05-27 Hasso Tepper <hasso at quagga.net>
1126
hasso70601e02005-05-27 03:26:57 +00001127 * bgp_routemap.c: Stop leaking communities.
1128
11292005-05-27 Hasso Tepper <hasso at quagga.net>
1130
hasso54a6ed32005-05-26 22:12:33 +00001131 * bgpd.c: Deleting bgp->rsclient list needs fix similar to pree-groups
1132 deleting fix. Avoid leaking bgp->group, bgp->peer and bgp->rsclient
1133 lists.
1134
11352005-05-26 Hasso Tepper <hasso at quagga.net>
hassob6b7cff2005-05-26 08:29:07 +00001136
1137 * bgpd.c: Don't crash while deleting list of peer-groups.
1138
hassob5f29602005-05-25 21:00:28 +000011392005-05-25 Hasso Tepper <hasso at quagga.net>
1140
1141 * bgpd.c: Fix obvious (routeserver patch) merge error. This makes "no
1142 neighbor x.x.x.x routemap [export|import] commands work again.
1143
paula94feb32005-05-23 13:17:29 +000011442005-05-23 Paul Jakma <paul@dishone.st>
1145
1146 * bgp_routemap.c: add semi-colons to VTY_GET_* to match vty.h change
paul00d252c2005-05-23 14:19:54 +00001147 * bgp_fsm.h: Add extern qualifier to exported functions
1148 * bgp_nexthop.c: add static to nexthop specific globals
1149 * *.h: Add guard defines
paula94feb32005-05-23 13:17:29 +00001150
paul22db9de2005-05-19 01:50:11 +000011512005-05-19 Paul Jakma <paul@dishone.st>
1152
1153 * bgp_fsm.c: (bgp_stop) use sockunion_free, not XFREE..
1154 * bgp_network.c: (bgp_getsockname) ditto
paule83e2082005-05-19 02:12:25 +00001155 (bgp_accept) use XSTRDUP
paul22db9de2005-05-19 01:50:11 +00001156 * bgp_routemap.c: (route_match_peer) ditto, als use a ret value and
1157 remove one sockunion_free.
paule83e2082005-05-19 02:12:25 +00001158 * bgpd.c: (peer_delete) ditto.
1159 XFREE the correct memtype, not free.
1160 (peer_create) use XSTRDUP
1161 * bgp_packet.c: (bgp_stream_dup) deleted, stream_dup should be used
1162 (various) update -> s/bgp_stream_dup/stream_dup
1163
paul22db9de2005-05-19 01:50:11 +00001164
ajs634f9ea2005-04-11 15:51:40 +000011652005-04-11 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1166
1167 * bgp_zebra.c (bgp_redistribute_set, bgp_redistribute_unset):
1168 The 2nd arg to zebra_redistribute_send is now zclient instead of
1169 zclient->sock.
1170
hassoa8a80d52005-04-09 13:07:47 +000011712005-04-09 Akihiro Mizutani <mizutani@net-chef.net>
1172
1173 * bgp_vty.c: Make "exit-address-family" work in IPv4 unicast address
1174 family node.
1175
hasso68118452005-04-08 15:40:36 +000011762005-04-08 Martin Ling <martin-quagga@earth.li>
1177
1178 * bgp_aspath.[ch], bgp_route.c, bgp_vty.c, bgpd.[ch]: Allow to enable
1179 the length of confederation path segments to be included during the
1180 as-path length check in the best path decision.
1181
ajsd2fc8892005-04-02 18:38:43 +000011822005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1183
1184 * bgp_zebra.c: (bgp_interface_delete) After deleting, set ifp->ifindex
1185 to IFINDEX_INTERNAL.
1186
hasso6cf159b2005-03-21 10:28:14 +000011872005-03-21 Hasso Tepper <hasso at quagga.net>
1188
1189 * bgp_route.c: Don't crash while clearing route tables if there is
1190 no particular afi/safi configured.
1191
hasso338b3422005-02-23 14:27:24 +000011922005-02-23 Hasso Tepper <hasso at quagga.net>
1193
1194 * bgp_route.c: Make reannouncing prefixes with changed attributes
1195 work again.
1196
hasso6ffd2072005-02-02 14:50:11 +000011972005-02-02 Akihiro Mizutani <mizutani@net-chef.net>
1198
hassodd4c5932005-02-02 17:15:34 +00001199 * bgp_vty.c: Deprecate "neighbor transparent-as" and "neighbor
1200 transparent-nexthop" commands.
1201
12022005-02-02 Akihiro Mizutani <mizutani@net-chef.net>
1203
hassoc1643bb2005-02-02 16:43:17 +00001204 * bgp_routemap.c: New route-map command - "match ip route-source".
1205
12062005-02-02 Akihiro Mizutani <mizutani@net-chef.net>
1207
hassofee6e4e2005-02-02 16:29:31 +00001208 * bgp_clist.[ch], bgp_route.c, bgp_routemap.c, bgp_vty.c:
1209 community-list cleanup.
1210
12112005-02-02 Akihiro Mizutani <mizutani@net-chef.net>
1212
hasso6ffd2072005-02-02 14:50:11 +00001213 * bgp_route.c, bgp_vty.c, bgp_zebra.c, bgpd.[ch]: "enforce-multihop"
1214 -> "disable-connected-check".
1215
12162005-02-02 Akihiro Mizutani <mizutani@net-chef.net>
hasso93406d82005-02-02 14:40:33 +00001217
1218 * bgp_fsm.c, bgp_open.c, bgp_packet.c, bgp_route.[ch], bgp_vty.c,
1219 bgpd.[ch]: Add BGP_INFO_STALE flag and end-of-rib support. "bgp
1220 graceful-restart" commands added. Show numbers of individual
1221 messages in "show ip bgp neighbor" command. Final pieces of graceful
1222 restart.
1223
hassof4184462005-02-01 20:13:16 +000012242005-02-01 Akihiro Mizutani <mizutani@net-chef.net>
1225
hassoc9502432005-02-01 22:01:48 +00001226 * bgp_open.c, bgp_packet.c, bgp_vty.c, bgpd.[ch]: Remove "no neighbor
1227 capability route-refresh" commands. Route refresh capability is sent
1228 anyway now. Preserve dummy deprecated commands.
1229
12302005-02-01 Akihiro Mizutani <mizutani@net-chef.net>
1231
hasso3d515fd2005-02-01 21:30:04 +00001232 * bgp_attr.c, bgp_snmp.c, bgp_vty.c, bgpd.[ch]: Remove support for old
1233 draft - ie. "neighbor version 4-" commands. Preserve dummy "neighbor
1234 version" command as deprecated.
1235
12362005-02-01 Akihiro Mizutani <mizutani@net-chef.net>
1237
hasso0a486e52005-02-01 20:57:17 +00001238 * bgpd.[ch], bgp_vty.c, bgp_route.c: "Restart session after
1239 maximum-prefix limit" feature support.
1240
12412005-02-01 Akihiro Mizutani <mizutani@net-chef.net>
1242
hassof4184462005-02-01 20:13:16 +00001243 * bgp_nexthop.c: Improve debug.
1244 * bgpd.[ch], bgp_nexthop.c, bgp_snmp.c: Remove useless bgp_get_master()
1245 function.
1246 * bgp_packet.c: MP AFI_IP update and withdraw parsing.
1247 * bgp_fsm.c: Reset peer synctime in bgp_stop(). bgp_fsm_change_status()
1248 is better place to log about peer status change than bgp_event().
1249 Log in bgp_connect_success().
1250 * bgp_vty.c: Fix typo in comment.
1251 * bgp_attr.c: Better log about unknown attribute.
1252
ajs3b8b1852005-01-29 18:19:13 +000012532005-01-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1254
1255 * bgp_filter.c: (ip_as_path,no_ip_as_path) Use argv_concat instead
1256 of buffer_getstr.
1257 * bgp_route.c: (bgp_show_regexp) Fix memory leak: need to free string
1258 returned by buffer_getstr.
1259 (bgp_show_community) Must use XFREE instead of free on string
1260 returned by buffer_getstr.
1261 * bgp_routemap.c: (set_community) Must use XFREE instead of free
1262 on string returned by buffer_getstr.
1263 * bgp_vty.c: (neighbor_description) Use argv_concat instead of
1264 buffer_getstr.
1265
hasso6d694292005-01-24 09:29:42 +000012662005-01-24 Hasso Tepper <hasso at quagga.net>
1267
1268 * bgp_route.c: Fix showstopper bug. New route must be selected also
1269 if old one is flaged as BGP_INFO_ATTR_CHANGED.
1270
hassof1271652005-01-17 11:04:32 +000012712005-01-17 Hasso Tepper <hasso at quagga.net>
1272
1273 * bgp_route.c: Clear peer's routing table regardless whether it's
1274 configured or not. Being not configured is even better reason to
1275 do it.
1276
paula24a7e12005-01-05 08:14:13 +000012772005-01-05 Paul Jakma <paul@dishone.st>
1278
1279 * bgp_packet.c: (bgp_write) set socket to nonblock while writing
1280 this should be generalised. See bugzilla #102. Fix supplied by
1281 wawa@yandex-team.ru (Vladimir Ivanov).
1282
ajsd2c1f162004-12-08 21:10:20 +000012832004-12-08 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1284
1285 * *.c: Change level of debug messages to LOG_DEBUG.
1286
ajs274a4a42004-12-07 15:39:31 +000012872004-12-07 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1288
1289 * bgp_main.c: (main) The 2nd argument to openzlog has been removed.
1290
ajs887c44a2004-12-03 16:36:46 +000012912004-12-03 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1292
1293 * bgp_main.c: (sigint) Use zlog_notice for termination message.
1294 (main) Use zlog_notice for startup announcement.
1295
hassoc0652302004-11-25 19:33:48 +000012962004-11-25 Hasso Tepper <hasso at quagga.net>
1297
1298 * bgp_main.c: Make group to run as configurable.
1299
paul59320202004-11-09 01:54:03 +000013002004-11-09 Paul Jakma <paul@dishone.st>
1301
1302 * bgp_nexthop.c: collapse bgp_connected_ipvX, bgp_nexthop_cache_ipvX
1303 and cache{1,2}.. into arrays of tables and hence collapse
1304 bgp_scan_ipv{4,6} into a single bgp_scan function. Tested, though
1305 a long time ago (and this change was hand-merged).
1306
ajs5a646652004-11-05 01:25:55 +000013072004-11-04 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1308
1309 * bgp_route.c: Remove all code related to VTY_CONTINUE; this feature
1310 is deprecated because the output did not represent a single point
1311 in time. All output needs to be generated inline and buffered
1312 by the library code.
1313 (route_vty_out,route_vty_out_tag,damp_route_vty_out,
1314 flap_route_vty_out) Remove code to count number of lines of output,
1315 since this was only useful for VTY_CONTINUE behavior.
1316 (bgp_show_callback,vty_calc_line) Removed.
1317 (bgp_show_table) Remove hooks for VTY_CONTINUE callback support.
1318 As a result, there's a new output_arg argument to this function.
1319 Make function static.
1320 (bgp_show) Make function static and add a new output_arg argument.
1321 Change all functions that call bgp_show or bgp_show_table to
1322 pass the new output_arg argument (that used to be passed inside
1323 vty->output_arg).
1324 * bgp_mplsvpn.c: Remove declarations of functions defined in
1325 bgp_route.c; these declarations belong in bgp_route.h.
1326 * bgp_route.h: Declare 3 global functions used in both bgp_route.c
1327 and in bgp_mplsvpn.c.
1328
paula2b1ecd2004-10-31 18:58:09 +000013292004-10-31 Paul Jakma <paul@dishone.st>
1330
1331 * {bgpd,bgp_attr}.c: size_t printf format should be ld.
1332
paul98f51632004-10-25 14:19:15 +000013332004-10-25 Paul Jakma <paul@dishone.st>
1334
1335 * Update with fix in debian bug id 222930.
1336 * bgp_main.c: Add ZCAP_RAW, needed to bind to interfaces.
1337 bgp_network.c: (....) raise/lower privs around call to
1338 SO_BINDTODEVICE sockopt.
1339
hasso3fb9cd62004-10-19 19:44:43 +000013402004-10-19 Andrew J. Schorr <aschorr@telemetry-investments.com>
1341
1342 * bgp_nexthop.c: (bgp_connected_add) Connected destination pointer
1343 may be NULL.
1344 (bgp_connected_delete) ditto.
1345
hasso501ba492004-10-13 21:32:46 +000013462004-10-14 Hasso Tepper <hasso at quagga.net>
1347
1348 * bgp_dump.c: Make dump configuration appear in vtysh.
1349
hassoc75105a2004-10-13 10:33:26 +000013502004-10-13 Hasso Tepper <hasso at quagga.net>
1351
1352 * bgp_snmp.c: Remove defaults used to initialize smux connection to
1353 snmpd. Connection is initialized only if smux peer is configured.
hasso8b3126b2004-10-13 20:59:04 +00001354 * bgp_view.c: It's dead file. Reomved.
hassoc75105a2004-10-13 10:33:26 +00001355
paulfd79ac92004-10-13 05:06:08 +000013562004-10-13 Paul Jakma <paul@dishone.st>
1357
1358 * (global) more const'ification and fixups of types to clean up code.
1359 * bgp_mplsvpn.{c,h}: (str2tag) fix abuse. Still not perfect,
1360 should use something like the VTY_GET_INTEGER macro, but without
1361 the vty_out bits..
1362 * bgp_routemap.c: (set_aggregator_as) use VTY_GET_INTEGER_RANGE
1363 (no_set_aggregator_as) ditto.
1364 * bgpd.c: (peer_uptime) fix unlikely bug, where no buffer is
1365 returned, add comments about troublesome return value.
1366
hasso18a6dce2004-10-03 18:18:34 +000013672004-10-03 James R. Leu <jleu at mindspring.com>
1368
1369 * bgp_vty.c: Router id from zebra can be manually overriden.
1370 * bgp_zebra.c: Read router id related messages from zebra daemon.
1371 Remove own code related with router id selection.
1372 * bgpd.c, bgpd.h: Remove own router id selection code. Use the one
1373 from zebra daemon if it isn't manually overriden.
1374
hassoc9e52be2004-09-26 16:09:34 +000013752004-09-26 Hasso Tepper <hasso at quagga.net>
1376
1377 * bgp_aspath.c, bgp_packet.c, bgp_vty.c: Fix compiler warnings.
1378
hasso52dc7ee2004-09-23 19:18:23 +000013792004-09-23 Hasso Tepper <hasso at quagga.net>
1380
1381 * *.[c|h]: list -> struct list *, listnode -> struct listnode *.
1382
paule01f9cb2004-07-09 17:48:53 +000013832004-07-09 Paul Jakma <paul@dishone.st>
1384
1385 * Merge of GNU Zebra cvs2svn changesets r799, r800 and r807.
1386 * bgp_dump.c: (bgp_dump_attr) cleanup. return status code. check
1387 attributes present before printing.
1388 * bgp_dump.c: update bgp_dump_attr prototype.
1389 * bgp_packet.c: (bgp_update_receive) init attrstr. check status
1390 of bgp_dump_attr. Log end-of-rib UPDATEs.
1391
paulf5ba3872004-07-09 12:11:31 +000013922004-07-09 Sowmini Varadhan <sowmini.varadhan@sun.com>
1393
1394 * bgp_packet.c: (bgp_collision_detect) Send NOTIFY on new socket
1395 if that is connection we're closing.
1396 (bgp_read) invalid marker check applies to KEEPALIVE too.
1397 * bgp_route.c: Ignore multicast NRLI, dont send NOTIFY.
1398
paul5228ad22004-06-04 17:58:18 +000013992004-06-04 Paul Jakma <paul@dishone.st>
1400
1401 * type mismatch fixes
1402
hasso538621f2004-05-21 09:31:30 +000014032004-05-21 Akihiro Mizutani <mizutani@net-chef.net>
1404
1405 * bgpd.h, bgp_open.[ch], bgp_debug.c, bgp_vty.[ch], bgp_fsm.c:
1406 Graceful restart capability display.
1407
hasso3950fda2004-05-20 10:22:49 +000014082005-05-20 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1409
1410 * bgp_debug.c: Cosmetical fixes and log neighbor changes.
1411
hasso4372df72004-05-20 10:20:02 +000014122004-05-20 Akihiro Mizutani <mizutani@net-chef.net>
1413
1414 * bgp_ecommunity.c: Transit ecommunity support.
1415 * bgp_ecommunity.c: Fix for unknown community crush.
1416
hassoe0701b72004-05-20 09:19:34 +000014172005-05-20 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1418
1419 * *: Maximum prefix threshold support.
1420 * *: Reset notification fixups.
1421
paul0a589352004-05-08 11:48:26 +000014222004-05-08 Paul Jakma <paul@dishone.st>
1423
1424 * bgp_zebra.c: (bgp_interface_address_add) sync to zclient changes
1425 (bgp_interface_address_delete) ditto.
1426 (bgp_zebra_announce) ditto.
1427 (bgp_zebra_withdraw) ditto.
1428
paulc5317402004-05-03 13:25:06 +000014292004-05-03 Daniel Roesen <dr@cluenet.de>
1430
1431 * bgp_fsm.c: (bgp_stop) Reset uptime only on transition from
1432 Established so that it reflects true downtime (rather time
1433 since last transition, eg Active->Idle)
1434
paul35be31b2004-05-01 18:17:04 +000014352004-05-01 rivo nurges <rix@estpak.ee>
1436
1437 * bgp_route.c: fix UNH IOL BGP-4.1.12f
1438
pauleb821182004-05-01 08:44:08 +000014392004-05-01 Paul Jakma <paul@dishone.st>
1440
1441 * Revert the attempted clean-up of the dummy peer hack, reverts
1442 patchsets 435 (see 2004-02-17 below) and 456.
1443
paul545acaf2004-04-20 15:13:15 +000014442004-04-16 rivo nurges <rix@estpak.ee>
1445
hasso9b87e412004-04-20 16:54:49 +00001446 * bgpd.h, bgp_debug.c: update cease subcodes to
1447 draft-ietf-idr-cease-subcode-05
paul545acaf2004-04-20 15:13:15 +00001448 * bgpd.h, bgpd.c, bgp_route.c, bgp_route.h: fix UNH IOL BGP-4.1.6a
1449
paul6ad23f02004-02-17 19:45:10 +000014502004-02-17 Paul Jakma <paul@dishone.st>
1451
1452 * bgpd.h: (bgp_peer) add fd_local and fd_accept
1453 file descriptor's, fd becomes a pointer to one of these.
1454 * bgpd.c: (global) adjust for fact that fd is now a pointer.
1455 (peer_create_accept) removed.
1456 * bgp_route.c: (global) adjust for change of peer fd to pointer
1457 * bgp_packet.c: (bgp_collision_detect) adjust and remove the
1458 "replace with other peer" hack.
1459 * bgp_network.c: (bgp_accept) Remove the dummy peer hack.
1460 Update peer->fd_accept instead.
1461 (global) Adjust fd references - now a pointer.
1462 * bgp_fsm.c: (global) adjust peer fd to pointer.
1463 (bgp_connection_stop) new function, to stop connection.
1464 (global) adjust everything which closed peer fd to use
1465 bgp_connection_stop().
1466
gdt10d60ad2003-12-23 17:34:39 +000014672003-12-23 Krzysztof Oledzki <oleq@ans.pl>
1468
1469 * bgp_network.c: drop privs on error cases
1470
paul6ad23f02004-02-17 19:45:10 +000014712003-08-11 kunihiro <kunihiro@zebra.org>
paulac41b2a2003-08-12 05:32:27 +00001472
1473 * bgp_route{,map}.c: Extend 'set ip next-hop' in route-maps with
1474 ability to specify 'peer-address' rather than IP.
1475
paul9238b1e2003-06-11 08:03:08 +000014762003-06-09 Paul Jakma <paul@dishone.st>
1477
1478 * bgp_clist.c (community_list_delete): honour deny statements
1479
paul445f1432003-05-16 19:00:31 +000014802003-04-19 Hasso Tepper <hasso@estpak.ee>
1481
1482 * rip_routemap.c: sync daemon's route-map commands to have same
1483 syntax
1484
14852003-01-09 Akihiro Mizutani <mizutani@net-chef.net>
1486
1487 * bgp_routemap.c: Add match extcommunity command.
1488
paul718e3742002-12-13 20:15:29 +000014892002-10-23 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1490
1491 * bgp_aspath.c (aspath_init): Extend hash size from default to
1492 32767.
1493 (aspath_key_make): Use unsigned shoft for making hash. Suggested
1494 by: Marc Evans <Marc@SoftwareHackery.Com>
1495
14962002-08-19 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1497
1498 * bgp_clist.c (community_entry_free): Fix memory leak of standard
1499 extcommunity-list config string.
1500
15012002-08-19 Akihiro Mizutani <mizutani@net-chef.net>
1502
1503 * bgp_route.c (route_vty_out_detail): Fix bug of router-id display
1504 when multiple instance is used.
1505
15062002-08-18 Akihiro Mizutani <mizutani@net-chef.net>
1507
1508 * bgpd.c: Make "default-originate" and "maximum-prefix" commands
1509 available in peer-group configuration.
1510
15112002-08-13 Akihiro Mizutani <mizutani@net-chef.net>
1512
1513 * bgp_packet.c (bgp_open_send): Put Opt Parm Len 0 when last
1514 capability packet cause error or dont-capability-negotiate option
1515 is specified.
1516
15172002-07-07 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1518
1519 * zebra-0.93 released.
1520
15212001-10-28 Kunihiro Ishiguro <kunihiro@zebra.org>
1522
1523 * bgpd.c (bgp_vty_init): Translate update commands are removed.
1524
15252001-10-10 Kunihiro Ishiguro <kunihiro@zebra.org>
1526
1527 * bgp_route.c (bgp_static_set): Add workaround for BGP static
1528 route announcement when there is no zebra running.
1529
15302001-10-08 Kunihiro Ishiguro <kunihiro@zebra.org>
1531
1532 * bgpd.c (neighbor_remote_as_unicast): Remove "remote-as nlri
1533 unicast multicast" commands.
1534
15352001-09-14 Akihiro Mizutani <mizutani@dml.com>
1536
1537 * bgp_open.c: When we receive capability route-refresh, we should
1538 check we send the capability not we receive the capability.
1539
1540 * bgp_route.c (bgp_network_mask_natural_route_map): network
1541 statement route-map is added.
1542
15432001-08-31 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1544
1545 * bgp_advertise.c (bgp_advertise_intern): attr must be interned
1546 before looking up hash table.
1547
15482001-08-30 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1549
1550 * bgpd.h (struct peer): BGP filter is moved from peer_conf to
1551 peer.
1552
15532001-08-28 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1554
1555 * bgp_nexthop.c (bnc_nexthop_free): Fix next pointer bug.
1556 Suggested by: "Hong-Sung Kim" <hoskim@lanbird.co.kr>.
1557
15582001-08-26 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1559
1560 * bgp_table.c (bgp_node_create): Clearn memory before use it.
1561
15622001-08-24 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1563
1564 * Change to use bgp_table.[ch].
1565
15662001-08-23 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1567
1568 * bgpd.c (bgp_init): Add "transparent-as" and
1569 "transparent-nexthop" for old version compatibility.
1570
15712001-08-23 Akihiro Mizutani <mizutani@dml.com>
1572
1573 * bgpd.h (struct peer): default-originate route-map is added.
1574
1575 * bgp_route.c: When self originated route is advertised with
1576 attrubute-unchanged, nexthop was not properly set. This bug is
1577 fixed.
1578
15792001-08-22 Akihiro Mizutani <mizutani@dml.com>
1580
1581 * bgpd.c (neighbor_attr_unchanged): transparent-as and
1582 transparent-next-hop commands are restructured. Instead of
1583 current transparent-* commands, attribute-unchanged command is
1584 introduced.
1585
1586 neighbor A.B.C.D attribute-unchanged [as-path|next-hop|med]
1587
1588 (neighbor_default_originate): "default-originate" configuration
1589 announce default route even 0.0.0.0/0 does not exists in BGP RIB.
1590
15912001-08-19 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1592
1593 * zebra-0.92a released.
1594
15952001-08-19 Akihiro Mizutani <mizutani@dml.com>
1596
1597 * bgpd.c: AF specific soft-reconfiguration inbound commands are
1598 added.
1599
16002001-08-17 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1601
1602 * bgp_route.c (bgp_show_callback): Do not do community NULL check.
1603
1604 * bgp_community.c (community_cmp): Add check for commnunity NULL
1605 check.
1606
1607 * bgp_routemap.c (route_match_community): Do not check comunity is
1608 NULL. It may match to community-list "^$".
1609
1610 * bgp_community.c (community_match): Add check for community is
1611 NULL case.
1612
16132001-08-17 Akihiro Mizutani <mizutani@dml.com>
1614
1615 * bgpd.c: AF specific route-reflector-client and
1616 route-server-client configuration are added.
1617
16182001-08-17 Rick Payne <rickp@ayrnetworks.com>
1619
1620 * bgp_clist.c (community_match_regexp): Check special ^$ case.
1621
16222001-08-17 Akihiro Mizutani <mizutani@dml.com>
1623
1624 * bgp_clist.c (community_list_match): Fix bug of community list
1625 permit and deny check.
1626
16272001-08-16 Akihiro Mizutani <mizutani@dml.com>
1628
1629 * bgp_mplsvpn.c (bgp_mplsvpn_init): Add AF specific "nexthop-self"
1630 command.
1631
16322001-08-15 Akihiro Mizutani <mizutani@dml.com>
1633
1634 * bgpd.h (PEER_FLAG_SEND_COMMUNITY): Per AF based configuration
1635 flag is introduced.
1636
1637 * bgp_mplsvpn.c (bgp_mplsvpn_init): VPNv4 filtering is added.
1638
16392001-08-15 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1640
1641 * zebra-0.92 released.
1642
16432001-08-13 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1644
1645 * bgpd.c (bgp_delete): "no router bgp" free static, aggregate, rib
1646 table properly.
1647
16482001-08-12 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1649
1650 * bgp_route.c (bgp_node_safi): Return SAFI of current node.
1651 (bgp_config_write_network_vpnv4): VPNv4 static configuration
1652 display.
1653
16542001-08-11 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1655
1656 * bgpd.c (no_bgp_ipv4_multicast_route_map): Add IPv4 multicast
1657 node filter commands.
1658
16592001-08-11 Kunihiro Ishiguro <kunihiro@zebra.org>
1660
1661 * bgpd.h (PEER_FLAG_IGNORE_LINK_LOCAL_NEXTHOP): Add
1662 "ignore-link-local-nexthop" flag for ignore link-local nexthop for
1663 IPv6.
1664
16652001-08-07 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1666
1667 * bgpd.c (address_family_ipv4_multicast): "address-family ipv4
1668 multicast" is added.
1669 (address_family_ipv6_unicast): "address-family ipv6 unicast" is
1670 added.
1671
16722001-08-07 Akihiro Mizutani <mizutani@dml.com>
1673
1674 * bgp_route.c (bgp_process): Use flag instead of as_selected
1675 memeber in struct bgp_info.
1676
1677 * bgp_route.h (struct bgp_info): Remove as_selected memeber from
1678 struct bgp_info.
1679
16802001-07-31 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1681
1682 * bgp_route.c (bgp_announce_check): Enclose sending time AS loop
1683 check code with #ifdef BGP_SEND_ASPATH_CHECK.
1684
16852001-07-29 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1686
1687 * bgp_packet.c (bgp_withdraw_send): Simplify address family check.
1688
1689 * bgpd.h (BGP_INFO_HOLDDOWN): Introduce new macro to check BGP
1690 information is alive or not.
1691
1692 * bgp_community.c: Use community_val_get() on all OS.
1693
16942001-07-24 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1695
1696 * bgp_route.c (bgp_announce_check): Simplify set next-hop self
1697 check.
1698
16992001-07-24 Akihiro Mizutani <mizutani@dml.com>
1700
1701 * bgp_route.c (bgp_announce_check): To route server clients, we
1702 announce AS path, MED and nexthop transparently.
1703
17042001-06-21 Kunihiro Ishiguro <kunihiro@zebra.org>
1705
1706 * bgp_routemap.c (route_set_atomic_aggregate_free): Do not call
1707 XFREE. No memory is allocated in
1708 route_set_atomic_aggregate_compile().
1709
17102001-06-21 Kunihiro Ishiguro <kunihiro@zebra.org>
1711
1712 * bgp_routemap.c (bgp_route_map_init): `match nlri` and `set nlri`
1713 are replaced by `address-family ipv4` and `address-family vpnvr'.
1714
17152001-06-19 Kunihiro Ishiguro <kunihiro@zebra.org>
1716
1717 * bgp_route.c (bgp_withdraw): Add check for BGP_PEER_CONFED.
1718 Reported by Rick Payne <rickp@rossfell.co.uk>.
1719
17202001-06-17 Kunihiro Ishiguro <kunihiro@zebra.org>
1721
1722 * bgp_zebra.c (bgp_zebra_announce): When global IPv6 nexthop is
1723 empty, use socket's remote address for the nexthop.
1724
17252001-06-04 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1726
1727 * bgpd.c (peer_delete): Fix memory leak. Reported by Yosi Yarchi
1728 <Yosi_Yarchi@KereniX.com>
1729
17302001-06-01 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1731
1732 * bgpd.c (bgp_delete): Fix memory leak. Reported by Yosi Yarchi
1733 <Yosi_Yarchi@KereniX.com>
1734
17352001-05-27 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1736
1737 * bgp_route.c (bgp_route_clear_with_afi_vpnv4): Use next instead
1738 of ri->next.
1739
1740 * bgp_packet.c (bgp_withdraw_send): MPLS/VPN withdraw takes effect
1741 when HAVE_IPV6 is not defined.
1742
17432001-03-07 "Akihiro Mizutani" <mizutani@dml.com>
1744
1745 * bgpd.c (peer_timers_set): Adjust keepalive timer to fit less
1746 than holdtime / 3.
1747 (bgp_confederation_peers_unset): Only set peer->local_as when
1748 confederation is enabled.
1749 (bgp_timers): Add "timers bgp <0-65535> <0-65535>" command.
1750
1751 * bgp_route.c (bgp_announce_check): Set med of redistributed route
1752 when it is announced to EBGP peer.
1753
17542001-03-06 "Akihiro Mizutani" <mizutani@dml.com>
1755
1756 * bgp_nexthop.c (bgp_scan_ipv4): bgp_scan() call bgp_process() for
1757 all prefixes.
1758
17592001-03-06 Kunihiro Ishiguro <kunihiro@zebra.org>
1760
1761 * bgp_attr.c (bgp_attr_origin): When bgpd send NOTIFICATION with
1762 erroneous attribute (type, length and value), it does include
1763 attribute flags field.
1764
17652001-02-21 "Akihiro Mizutani" <mizutani@dml.com>
1766
1767 * bgp_route.c (bgp_announce_check): The route reflector is not
1768 allowed to modify the attributes of the reflected IBGP routes.
1769
17702001-02-20 "Akihiro Mizutani" <mizutani@dml.com>
1771
1772 * bgp_route.c (bgp_info_cmp): During path seleciton, BGP
1773 confederation peer is treated as same as IBGP peer.
1774
17752001-02-19 Kunihiro Ishiguro <kunihiro@zebra.org>
1776
1777 * bgp_route.c (bgp_redistribute_add): Initialize attr_new with
1778 attr. Call aspath_unintern when return from this function.
1779
17802001-02-19 "Akihiro Mizutani" <mizutani@dml.com>
1781
1782 * bgpd.c (bgp_router_id_set): Reset BGP peer when router-id is
1783 changed.
1784
17852001-02-18 "Akihiro Mizutani" <mizutani@dml.com>
1786
1787 * bgp_packet.c (bgp_open_receive): When user configure holdtimer,
1788 do not refrect the value to current session.
1789
17902001-02-16 Kunihiro Ishiguro <kunihiro@zebra.org>
1791
1792 * bgp_route.c (bgp_aggregate_delete): Set BGP_INFO_ATTR_CHANGE to
1793 suppress route withdraw.
1794
1795 * bgp_damp.c (bgp_damp_init): Fix bug of flap dampening.
1796
17972001-02-16 "Akihiro Mizutani" <mizutani@dml.com>
1798
1799 * bgp_aspath.c (aspath_make_str_count): Use ',' for separator for
1800 AS_SET and AS_CONFED_SET.
1801
18022001-02-15 Kunihiro Ishiguro <kunihiro@zebra.org>
1803
1804 * bgp_route.c (bgp_process): Do not consider suppress route.
1805
1806 * bgp_aspath.c (aspath_aggregate_as_set_add): Reset asset when
1807 aspath->data is realloced.
1808
18092001-02-15 "Akihiro Mizutani" <mizutani@dml.com>
1810
1811 * bgp_attr.c (bgp_attr_aggregate_intern): Do not set atomic
1812 aggregate when using as-set.
1813
18142001-02-14 "Akihiro Mizutani" <mizutani@dml.com>
1815
1816 * bgpd.c (bgp_confederation_peers_unset): Set peer's local-as
1817 correctly.
1818
1819 * bgp_route.c (bgp_update): Just ignore AS path loop for
1820 confederation peer.
1821
18222001-02-10 Kunihiro Ishiguro <kunihiro@zebra.org>
1823
1824 * bgp_route.c (bgp_aggregate_set): Add as_set argument.
1825 (bgp_aggregate_unset): Remove summary_only argument.
1826 (aggregate_address_as_set): New commands.
1827 "aggregate-address A.B.C.D/M as-set"
1828 "no aggregate-address A.B.C.D/M as-set"
1829
18302001-02-08 "Akihiro Mizutani" <mizutani@dml.com>
1831
1832 * bgp_route.c (bgp_announce_check): Do not modify nexthop when the
1833 route is passed by route reflector.
1834
18352001-02-08 Kunihiro Ishiguro <kunihiro@zebra.org>
1836
1837 * bgp_route.c: "no bgp dampening" with argument.
1838 (bgp_announce_check): Do not modify nexthop when the route is
1839 passed by route reflector.
1840
18412001-02-07 "Akihiro Mizutani" <mizutani@dml.com>
1842
1843 * bgpd.c (neighbor_passive): Change "neighbor NEIGHBOR remote-as
1844 ASN passive" to "neighbor NEIGHBOR passive".
1845 (bgp_announce_check): Check well-known community attribute even
1846 when "no neighbor send-community" is set.
1847
18482001-02-03 Kunihiro Ishiguro <kunihiro@zebra.org>
1849
1850 * bgp_fsm.c (bgp_establish): Do not send keepalive at established
1851 time when keepalive timer is configured as zero.
1852
18532001-02-01 Kunihiro Ishiguro <kunihiro@zebra.org>
1854
1855 * bgp_attr.c (bgp_attr_check): When peer is IBGP peer, local
1856 preference is well-known attribute.
1857
18582001-01-30 Kunihiro Ishiguro <kunihiro@zebra.org>
1859
1860 * zebra-0.91 is released.
1861
1862 * bgp_attr.h (struct attr): Comment out DPA value.
1863 (struct attr): Change refcnt type from int to unsinged long.
1864
1865 * bgp_attr.c (attrhash_key_make): Likewise.
1866 (attrhash_cmp): Likewise.
1867 (bgp_attr_dpa): Likewise.
1868
18692001-01-30 "Akihiro Mizutani" <mizutani@dml.com>
1870
1871 * bgp_route.c (bgp_info_cmp): Make route selection completely same
1872 as Cisco's.
1873
18742001-01-30 Kunihiro Ishiguro <kunihiro@zebra.org>
1875
1876 * bgp_attr.h (BGP_ATTR_FLAG_OPTIONAL): Rename old ATTR_FLAG_* to
1877 BGP_ATTR_FLAG_* to clarify meenings.
1878
18792001-01-30 "Akihiro Mizutani" <mizutani@dml.com>
1880
1881 * bgp_route.c (route_vty_out): Display argument to suppress same
1882 prefix information display.
1883 (route_vty_out_route): Don't display mask information for
1884 classfull network.
1885
18862001-01-30 Kunihiro Ishiguro <kunihiro@zebra.org>
1887
1888 * bgp_attr.h (SET_BITMAP): Simple bitmapping macros.
1889
1890 * bgp_attr.c (bgp_attr_parse): Use bitmap for attribute type
1891 check.
1892
18932001-01-29 Kunihiro Ishiguro <kunihiro@zebra.org>
1894
1895 * bgp_attr.c (bgp_mp_reach_parse): Enclose loggin with BGP_DEBUG.
1896 (bgp_attr_parse): Comment out well-known attribute check.
1897
18982001-01-28 Kunihiro Ishiguro <kunihiro@zebra.org>
1899
1900 * bgp_route.c (bgp_static_unset): Link-local IPv6 address can't be
1901 used for network advertisement.
1902 (nlri_parse): When link-local IPv6 address NLRI comes from
1903 remote-peer, log the information then simply ignore it.
1904
1905 * bgp_zebra.c (zebra_read_ipv6): Link-local IPv6 address is not
1906 redistributed.
1907
1908 * bgp_route.c (bgp_update): Check IPv6 global nexthop
1909 reachability.
1910
19112001-01-26 Kunihiro Ishiguro <kunihiro@zebra.org>
1912
1913 * bgp_route.c (bgp_update): Check nexthop points local address or
1914 not.
1915 (bgp_static_update_vpnv4): Set valid flag.
1916
1917 * bgp_attr.c (bgp_attr_parse): Duplicate attribute check.
1918 (bgp_attr_parse): Well-known attribute check.
1919
1920 * bgp_open.c (bgp_auth_parse): Authentication is not yet supported.
1921
1922 * bgp_packet.c (bgp_valid_marker): Check marker is synchronized.
1923
1924 * bgpd.c (clear_bgp): Send NOTIFICATION Cease when SEND_CEASE is
1925 defined.
1926
1927 * bgp_snmp.c (bgp4PathAttrTable): Fix compile error.
1928
19292001-01-24 Kunihiro Ishiguro <kunihiro@zebra.org>
1930
1931 * bgpd.c (bgp_network_import_check): New command for IGP network
1932 check.
1933
19342001-01-23 Kunihiro Ishiguro <kunihiro@zebra.org>
1935
1936 * bgp_nexthop.c (bgp_scan): Run bgp_process when IGP metric is
1937 changed. Call bgp_process once for each node.
1938
19392001-01-23 "Akihiro Mizutani" <mizutani@dml.com>
1940
1941 * bgp_route.c (bgp_info_cmp): Add IGP metric comparison.
1942
19432001-01-23 Kunihiro Ishiguro <kunihiro@zebra.org>
1944
1945 * bgp_route.c (bgp_info_cmp): Add IGP metric comparison.
1946
1947 * bgp_nexthop.c (bgp_nexthop_lookup): Set IGP metric for valid
1948 IBGP route.
1949
19502001-01-23 "Akihiro Mizutani" <mizutani@dml.com>
1951
1952 * bgp_route.c (show_ip_bgp_prefix_longer): Add new commands.
1953 "show ip bgp A.B.C.D/M longer-prefixes"
1954 "show ip bgp ipv4 (unicast|multicast) A.B.C.D/M longer-prefixes"
1955 "show ipv6 bgp X:X::X:X/M longer-prefixes"
1956 "show ipv6 mbgp X:X::X:X/M longer-prefixes"
1957
19582001-01-20 "Akihiro Mizutani" <mizutani@dml.com>
1959
1960 * bgp_route.c (show_ip_bgp_cidr_only): Add new commands.
1961 "show ip bgp cidr-only"
1962 "show ip bgp ipv4 (unicast|multicast) cidr-only"
1963
19642001-01-18 "Akihiro Mizutani" <mizutani@dml.com>
1965
1966 * bgp_route.c (bgp_update): AS path lookup check is done in
1967 bgp_update() not in attr_parse().
1968
19692001-01-18 Kunihiro Ishiguro <kunihiro@zebra.org>
1970
1971 * bgp_route.c (bgp_update): Call bgp_aggregate_decrement() just
1972 before bgp_attr_unintern().
1973
19742001-01-17 Kunihiro Ishiguro <kunihiro@zebra.org>
1975
1976 * bgp_route.c (bgp_update): Now intern is performed very last part
1977 of the BGP packet update procedure.
1978
19792001-01-17 "Akihiro Mizutani" <mizutani@dml.com>
1980
1981 * bgp_route.c (bgp_update): When implicit withdraw occur, reuse
1982 existing bgp_info structure.
1983
19842001-01-17 Kunihiro Ishiguro <kunihiro@zebra.org>
1985
1986 * bgp_route.c (bgp_aggregate_decrement): Fix bug of aggregate
1987 address matching method.
1988 (bgp_update):
1989
1990 * bgp_nexthop.c (bgp_nexthop_onlink): Separate EBGP nexthop onlink
1991 check and IBGP nexthop route check.
1992
19932001-01-16 "Akihiro Mizutani" <mizutani@dml.com>
1994
1995 * bgp_route.h (BGP_INFO_ATRR_CHANGED): Added for track attribute
1996 change.
1997
19982001-01-16 Kunihiro Ishiguro <kunihiro@zebra.org>
1999
2000 * bgp_route.h (struct bgp_info): Remove selected flag. Use
2001 BGP_INFO_SELECTED for flags instead.
2002 (struct bgp_info): Remove valid flag. Use BGP_INFO_VALID for
2003 flags instead.
2004 (struct bgp_info): Add igpmetric for IBGP route nexthop IGP
2005 metric.
2006 (struct bgp_info_tab): Struct bgp_info_tag is integrated into
2007 struct bgp_info.
2008 (BGP_INFO_ATRR_CHANGED): Added for track attribute change.
2009
2010 * bgp_community.c (community_val_get): gcc-2.95 on
2011 sparc-sun-solaris cause crush. This function is for avoid the
2012 crush.
2013
20142001-01-15 Kunihiro Ishiguro <kunihiro@zebra.org>
2015
2016 * bgp_packet.c (bgp_open_receive): Translated peer's packet_size
2017 clear bug is fixed.
2018
20192001-01-14 "Akihiro Mizutani" <mizutani@dml.com>
2020
2021 * bgp_packet.c (bgp_open_receive): Return notification with
2022 supported version number.
2023
20242001-01-13 Kunihiro Ishiguro <kunihiro@zebra.org>
2025
2026 * bgpd.c (bgp_show_summary): Display AS path and community
2027 entries. Suggested by: "Matt Ranney" <mjr@ranney.com>.
2028
2029 * bgp_packet.c (bgp_read_packet): Fix bug of unblocking BGP socket
2030 read. When BGP packet read is partial, we must get size and type
2031 from packet again.
2032
20332001-01-12 "Akihiro Mizutani" <mizutani@dml.com>
2034
2035 * bgp_route.c (bgp_update): Do not unset BGP_INFO_HISTORY flag.
2036 (bgp_update): When there is a history entry increment route count.
2037 (bgp_damp_set): Check BGP_CONFIG_DAMPENING flag.
2038
2039 * bgp_damp.c (bgp_damp_withdraw): Set status to
2040 BGP_DAMP_DISCONTINUE.
2041
20422001-01-11 Kunihiro Ishiguro <kunihiro@zebra.org>
2043
2044 * bgp_attr.c (bgp_mp_reach_parse): Fix warning code when second
2045 IPv6 nexthop is not link-local addresss.
2046
20472001-01-11 "Akihiro Mizutani" <mizutani@dml.com>
2048
2049 * bgp_damp.c (bgp_config_write_damp): Smart flap dampening
2050 configuration display.
2051 (bgp_damp_info_print): Display elapsed time from flap started.
2052
2053 * bgp_damp.h (struct bgp_damp_info): Add flap start time.
2054
2055 * bgpd.c (peer_create): Set last read time.
2056 (bgp_show_peer): Display last read time.
2057 (bgp_show_summary): Use BGP_CONFIG_DAMPENING flag to check
2058 configuration.
2059
2060 * bgpd.h (BGP_CONFIG_DAMPENING): Add new configuration option.
2061 (struct peer): Add last read time member.
2062 (BGP_VERSION_MP_4): Remove obsolete definition.
2063
20642001-01-10 Kunihiro Ishiguro <kunihiro@zebra.org>
2065
2066 * bgp_nexthop.c: Remove OLD_RIB codes.
2067
2068 * bgp_route.c (bgp_process): Likewise.
2069
2070 * zebra-0.90 is released.
2071
2072 * bgp_route.h (BGP_INFO_HISTORY): Remove damped member from struct
2073 bgp_info. Instead of that use BGP_INFO_DAMPED flag.
2074 (struct bgp_info): Remove invalid member from struct bgp_info.
2075 Instead of that use BGP_INFO_HISTORY flag.
2076
20772001-01-10 "Akihiro Mizutani" <mizutani@dml.com>
2078
2079 * bgp_damp.c (bgp_damp_info_print): New function to display
2080 dampening status.
2081 (DEFAULT_HARF_LIFE): Define default value.
2082 (DEFAULT_REUSE): Likewise.
2083 (DEFAULT_SUPPRESS): Likewise.
2084 (bgp_config_write_damp): When config value is same as default
2085 value, simply display "bgp dampening" to configuration.
2086
2087 * bgp_damp.h (struct bgp_damp_info): Add flap member.
2088
2089 * bgp_route.h (struct bgp_info): Added for BGP flap dampening
2090 history status.
2091
20922001-01-10 Kunihiro Ishiguro <kunihiro@zebra.org>
2093
2094 * bgp_nexthop.c (bgp_connected_add): Point-to-point connected
2095 address is properly handled.
2096 (bgp_connected_delete): Likewise.
2097
2098 * bgp_route.c (bgp_route_init): Turn off BGP Flap dampening code
2099 until it works fine.
2100
21012001-01-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2102
2103 * bgpd.c (bgp_show_summary): Add BGP_VERSION_MP_4 case.
2104
2105 * bgp_route.c (bgp_update): When this is not damped route, clear
2106 ri pointer.
2107
21082001-01-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2109
2110 * bgp_main.c: Add "-n" no_kernel option to not install route to
2111 kernel. Suggested by: "Matt Ranney" <mjr@ranney.com>
2112
21132001-01-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2114
2115 * bgp_nexthop.c (bgp_connected_add): Revert point-to-point
2116 connected route patch. Reported by ruud@ruud.org (Ruud de Rooij)
2117
2118 * bgp_damp.c (bgp_config_write_damp): Add configuration display
2119 function.
2120
2121 * bgp_route.c (bgp_info_free): Set NULL to BGP dampening
2122 information when BGP info structure is freed.
2123 (bgp_info_cmp): Check damped flag.
2124 (bgp_announce_check): Damped route is not announced.
2125
21262001-01-09 "Akihiro Mizutani" <mizutani@dml.com>
2127
2128 * bgpd.c (neighbor_capability_route_refresh): Change "neighbor
2129 route-refresh" command to "neighbor capability route-refresh".
2130 (clear_bgp_soft_in): Change soft-reconfig method.
2131
2132 clear ip bgp <neighbor> soft in
2133 --------------------------------------
2134 Try stored cache first then route-refresh
2135
2136 clear ip bgp <neighbor> in
2137 ---------------------------------
2138 Try route-refresh first then try to use stored cache
2139
21402001-01-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2141
2142 * bgp_nexthop.c (bgp_connected_add): Check point-to-point
2143 connected route. Reported by ruud@ruud.org (Ruud de Rooij)
2144
21452001-01-08 Kunihiro Ishiguro <kunihiro@zebra.org>
2146
2147 * bgp_nexthop.c (bgp_nexthop_lookup): When IBGP nexthop is
2148 changed, refresh it.
2149
21502001-01-04 Kunihiro Ishiguro <kunihiro@zebra.org>
2151
2152 * bgp_route.h (struct bgp_info_tag): Add as_selected to
2153 bgp_info_tag.
2154
21552001-01-03 Kunihiro Ishiguro <kunihiro@zebra.org>
2156
2157 * bgp_route.h (struct bgp_info_tag): Add damped and bgp_damp_info
2158 member for BGP flap dampening.
2159
2160 * bgp_damp.c: New file is added.
2161
2162 * bgp_damp.h: Likewise.
2163
21642001-01-01 Kunihiro Ishiguro <kunihiro@zebra.org>
2165
2166 * bgpd.h (BGP_VTYSH_PATH): Change "/tmp/bgpd" to "/tmp/.bgpd".
2167
21682000-12-29 Kunihiro Ishiguro <kunihiro@zebra.org>
2169
2170 * bgp_nexthop.c (zlookup_connect): Change to use UNIX domain
2171 socket for zebra communication.
2172
21732000-12-29 Akihiro Mizutani <mizutani@dml.com>
2174
2175 * bgp_route.c (bgp_process): Fix "bgp deterministic-med" process.
2176
21772000-12-27 Akihiro Mizutani <mizutani@dml.com>
2178
2179 * bgp_route.c (bgp_process): Add "bgp deterministic-med" process.
2180
21812000-12-25 Akihiro Mizutani <mizutani@dml.com>
2182
2183 * bgp_route.c (bgp_info_cmp): Use ntohl comparing router ID.
2184
21852000-12-18 Akihiro Mizutani <mizutani@dml.com>
2186
2187 * bgp_route.c (bgp_info_cmp): When over three same prefix exit,
2188 withdrawing best prefix perform router ID comparison.
2189
21902000-12-15 Akihiro Mizutani <mizutani@dml.com>
2191
2192 * bgp_route.c (bgp_info_cmp): Do not compare router ID when the
2193 routes comes from EBGP peer. When originator ID is same, take
2194 shorter cluster-list route. If cluster-list is same take smaller
2195 IP address neighbor's route.
2196
2197 * bgpd.c (bgp_bestpath_aspath_ignore): Add "bgp bestpath as-path
2198 ignore" command. When this option is set, do not concider AS path
2199 length when route selection.
2200 (bgp_bestpath_compare_router_id): Add "bgp bestpath
2201 compare-routerid". When this option is set, compare router ID
2202 when the routes comes from EBGP peer.
2203
22042000-12-15 Akihiro Mizutani <mizutani@dml.com>
2205
2206 * bgp_route.c (bgp_info_cmp): Compare originator ID when it is
2207 available.
2208
22092000-12-14 Akihiro Mizutani <mizutani@dml.com>
2210
2211 * bgp_packet.c (bgp_notify_receive): Disply received Notify data
2212 information.
2213
22142000-12-14 Kunihiro Ishiguro <kunihiro@zebra.org>
2215
2216 * bgp_filter.c (as_filter_free): Use MTYPE_AS_FILTER_STR to make
2217 it sure the memory is freed.
2218
2219 * bgp_route.c (route_vty_out_detail): Do not use AF_INET6 outside
2220 HAVE_IPV6.
2221
22222000-12-08 Akihiro Mizutani <mizutani@dml.com>
2223
2224 * bgp_packet.c (bgp_notify_send_with_data): Store BGP notification
2225 data part.
2226
2227 * bgp_network.c (bgp_accept): When BGP connection comes from
2228 unconfigured IP address, close socket immediately.
2229
2230 * bgpd.c: Fix some display format.
2231
22322000-11-29 Kunihiro Ishiguro <kunihiro@zebra.org>
2233
2234 * bgp_packet.c (bgp_keepalive_send): Delete duplicate
2235 bgp_packet_set_size () call.
2236
22372000-11-28 Kunihiro Ishiguro <kunihiro@zebra.org>
2238
2239 * bgp_packet.c (bgp_read_packet): Remove debug codes.
2240
22412000-11-27 Kunihiro Ishiguro <kunihiro@zebra.org>
2242
2243 * bgp_snmp.c (write_bgpPeerTable): Add SNMP set method routine.
2244
2245 * bgp_fsm.c (bgp_stop): Use fsm_change_status to change peer's
2246 status.
2247 (bgp_establish): Likewise.
2248
22492000-11-26 Akihiro Mizutani <mizutani@dml.com>
2250
2251 * bgp_open.c: Fix error messages.
2252
22532000-11-25 Kunihiro Ishiguro <kunihiro@zebra.org>
2254
2255 * bgp_fsm.c (bgp_establish): Call BGP trap when the peer is
2256 established.
2257 (bgp_stop): Call BGP trap when the peer is dropped.
2258
22592000-11-24 Kunihiro Ishiguro <kunihiro@zebra.org>
2260
2261 * bgp_snmp.c (bgp4PathAttrTable): Return BGP path attribute table.
2262
2263 * bgpd.h (struct peer): Add update_time for track last update
2264 received time.
2265
2266 * bgp_packet.c (bgp_notify_receive): Preserv notify code and sub
2267 code in any case.
2268
2269 * bgp_snmp.c (bgpPeerTable): Return remote router ID instead of
2270 peering IP address.
2271 (bgpPeerTable): Return actual BGP version number.
2272
22732000-11-22 Akihiro Mizutani <mizutani@dml.com>
2274
2275 * bgp_debug.c (bgp_notify_print): Notify data length display bug
2276 is fixed.
2277
22782000-11-16 Kunihiro Ishiguro <kunihiro@zebra.org>
2279
2280 * bgp_nexthop.c (zlookup_connect): When UNIX domain connection to
2281 zebra is enabled, use the method.
2282
22832000-11-16 Akihiro Mizutani <mizutani@dml.com>
2284
2285 * bgpd.c: Revise debug message output.
2286
22872000-11-15 Akihiro Mizutani <mizutani@dml.com>
2288
2289 * bgp_clist.c (ip_community_list): Fix bug of string comparison.
2290
22912000-11-14 Akihiro Mizutani <mizutani@dml.com>
2292
2293 * bgp_community.c (community_match): Fix bug of memcmp return
2294 value check.
2295
22962000-11-07 Kunihiro Ishiguro <kunihiro@zebra.org>
2297
2298 * bgp_clist.c (community_list_match_exact): Add check for
2299 entry->style is COMMUNITY_LIST.
2300 (community_match_regexp): Apply new com_nthval macro.
2301
23022000-11-07 Rick Payne <rickp@rossfell.co.uk>
2303
2304 * bgp_routemap.c (route_set_community_delete): "set
2305 community-delete COMMUNITY-LIST" is added.
2306
2307 * bgp_community.c (community_del_val): Delete one community.
2308 (community_delete): Delete all community included in list.
2309 (community_match): Fix bug of matching community value.
2310
2311 * bgp_clist.c (community_entry_free): Free community regular
2312 expression.
2313 (community_entry_make): Default style is COMMUNITY_LIST.
2314 (community_entry_lookup): Make it sure style is COMMUNITY_LIST.
2315 (community_entry_regexp_lookup): New function for community
2316 regular expression lookup.
2317 (community_match_regexp): New function.
2318 (community_delete_regexp): New function.
2319 (community_list_delete_entries): New function.
2320 (community_list_match): Add COMMUNITY_REGEXP treatment.
2321 (community_list_match_exact): Likewise.
2322 (config_write_community): Write community list according to
2323 entry->style.
2324
23252000-11-07 Rick Payne <rickp@rossfell.co.uk>
2326
2327 * bgp_attr.c (bgp_attr_aspath): AS path first AS check.
2328
2329 * bgp_clist.c (struct community_entry): Add style, regexp, reg to
2330 community_entry.
2331
23322000-11-06 Rick Payne <rickp@rossfell.co.uk>
2333
2334 * bgp_aspath.c (aspath_firstas_check): AS path first AS check.
2335
2336 * bgpd.c (bgp_enforce_first_as): New command "bgp
2337 enforce-first-as".
2338
2339 * bgpd.h (BGP_CONFIG_ENFORCE_FIRST_AS): Add new flag.
2340
23412000-11-06 Kunihiro Ishiguro <kunihiro@zebra.org>
2342
2343 * bgp_community.c (community_compare): Copy byte stream data to
2344 actual value instead of using type casting hack.
2345 (community_add_val): Likewise.
2346 (community_uniq_sort): Likewise.
2347 (community_print): Likewise.
2348 (community_print_vty): Likewise.
2349 (community_include): Use memcmp to compare community value.
2350
2351 * bgp_community.h (com_lastval): com_lastval and com_nthval macro
2352 return pointer.
2353
23542000-11-06 Akihiro Mizutani <mizutani@dml.com>
2355
2356 * bgpd.h (struct peer): Add established and dropped member for
2357 count peering up/down statistics.
2358
2359 * bgpd.c (bgp_show_peer): Display peering up/down statistics.
2360
2361 * bgp_fsm.c (bgp_establish): Increment established count.
2362 (bgp_stop): Increment dropped count.
2363
2364 * bgp_packet.c (bgp_notify_receive): Increament notify count.
2365
23662000-11-1 Akihiro Mizutani <mizutani@dml.com>
2367
2368 * bgp_fsm.c: Fix bug of holdtimer is not reset when bgp cleared.
2369
23702000-10-31 Kunihiro Ishiguro <kunihiro@zebra.org>
2371
2372 * bgpd.h: Static bit flag is set by (1 << DIGIT).
2373
23742000-10-24 Akihiro Mizutani <mizutani@dml.com>
2375
2376 * bgp_ecommunity.c (ecommunity_dup): Extended community display
2377 format fix.
2378
23792000-10-24 Arkadiusz Miskiewicz <misiek@pld.org.pl>
2380
2381 * bgp_network.c (bgp_serv_sock_addrinfo): Use gai_strerror.
2382 (bgp_serv_sock_addrinfo): Check address family.
2383
23842000-10-23 Jochen Friedrich <jochen@scram.de>
2385
2386 * bgp_snmp.c: bgp_oid and bgpd_oid are used in smux_open after it
2387 is registered. So those variables must be static.
2388
23892000-10-23 Akihiro Mizutani <mizutani@dml.com>
2390
2391 * bgp_routemap.c (route_match_ip_next_hop): Change "match ip
2392 next-hop" argument from IP address to access-list name.
2393 Remove zebra-0.88 compatibility commands.
2394 "match ip prefix-list WORD"
2395 "match ipv6 prefix-list WORD"
2396
23972000-10-23 Kunihiro Ishiguro <kunihiro@zebra.org>
2398
2399 * bgp_routemap.c (route_match_ipv6_next_hop_compile): Fix bug of
2400 passing the pointer to the pointer of struct in6_addr instead of
2401 the pointer of struct in6_addr in "match ipv6 next-hop" command.
2402
2403 * bgp_route.c (bgp_announce_check): Enclose IPv6 part with
2404 HAVE_IPV6.
2405
24062000-10-20 Jasper Wallace <jasper@ivision.co.uk>
2407
2408 * bgp_snmp.c (bgpPeerTable): ntohs missing bug is fixed. Change
2409 to use linklist.c. Define COUNTER32 as ASN_COUNTER.
2410
24112000-10-18 Kunihiro Ishiguro <kunihiro@zebra.org>
2412
2413 * bgp_route.c (bgp_announce_check): attr->nexthop empty check
2414 should be done by attr->nexthop.s_addr instead of strcmp.
2415
24162000-10-18 Akihiro Mizutani <mizutani@dml.com>
2417
2418 * bgp_zebra.c (zebra_read_ipv4): Pass nexthop value to
2419 bgp_redistribute_add().
2420
2421 * bgp_nexthop.c (bgp_multiaccess_check_v4): New function for
2422 checking IPv4 multiaccess nexthop.
2423
2424 * bgp_route.c (bgp_announce_check): In case of the nexthop is
2425 reachable on multiaccess media, do not change nexthop.
2426 (bgp_redistribute_add): Set nexthop when the value is passed.
2427
24282000-10-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2429
2430 * bgp_fsm.c (bgp_timer_set): If peer is passive mode, do not set
2431 connect timer.
2432 (bgp_start): If the peer is passive mode, force to move to Active
2433 mode.
2434
24352000-10-17 Horms <horms@vergenet.net>
2436
2437 * bgp_debug.c (debug_bgp_fsm): Fix typo.
2438
24392000-10-17 Akihiro Mizutani <mizutani@dml.com>
2440
2441 * bgp_route.c: "show ipv6 bgp" route display improvement.
2442
24432000-10-03 Kunihiro Ishiguro <kunihiro@zebra.org>
2444
2445 * bgp_route.c (neighbor_routes): Allocate sockunion for callback
2446 function.
2447 (bgp_show_neighbor_route): Remove static declaration for union
2448 sockunion.
2449
2450 * bgpd.c (peer_update_source_set): Clean previously allocated
2451 memory before allocate new one.
2452
24532000-10-03 Akihiro Mizutani <mizutani@dml.com>
2454
2455 * bgp_route.c (neighbor_routes): Add show neighbor's routes
2456 command.
2457 "show ip bgp neighbors (A.B.C.D|X:X::X:X) routes"
2458 "show ip bgp ipv4 (unicast|multicast) neighbors (A.B.C.D|X:X::X:X) routes"
2459 "show ipv6 bgp neighbors (A.B.C.D|X:X::X:X) routes"
2460 "show ipv6 mbgp neighbors (A.B.C.D|X:X::X:X) routes"
2461
24622000-10-02 Kunihiro Ishiguro <kunihiro@zebra.org>
2463
2464 * zebra-0.89 is released.
2465
24662000-10-02 Akihiro Mizutani <mizutani@dml.com>
2467
2468 * bgpd.c: "bgp deterministic-med" command is added.
2469
24702000-10-02 Kunihiro Ishiguro <kunihiro@zebra.org>
2471
2472 * bgp_nexthop.c (bgp_connected_add): Apply mask for connected
2473 route addition and deletion.
2474
24752000-09-29 Kunihiro Ishiguro <kunihiro@zebra.org>
2476
2477 * bgp_aspath.c (aspath_cmp_left): Skip confederation AS segment
2478 when comparing leftmost AS number.
2479
24802000-09-29 Akihiro Mizutani <mizutani@dml.com>
2481
2482 * bgpd.c (peer_route_reflector): Route reflector can be set for
2483 IBGP peer.
2484 (bgp_distribute_set): Fix bug of string check for (in|out).
2485 (bgp_show_summary): Display total neighbor count.
2486
24872000-09-28 Akihiro Mizutani <mizutani@dml.com>
2488
2489 * bgp_attr.c (bgp_packet_attribute): Only add cluster_list and
2490 originator for clinet to client routes.
2491 (bgp_packet_attribute): Add new cluster_list to the beginning of
2492 existing cluster_list.
2493 (bgp_packet_attribute): Fix bug of originator is rewritten even
2494 when originator is already set.
2495
24962000-09-27 Kunihiro Ishiguro <kunihiro@zebra.org>
2497
2498 * bgpd.c (bgp_client_to_client_reflection): Add new command.
2499 "no bgp client-to-client reflection"
2500 "bgp client-to-client reflection"
2501
2502 * bgpd.h (BGP_CONFIG_NO_CLIENT_TO_CLIENT): Add new definition.
2503
25042000-09-26 Kunihiro Ishiguro <kunihiro@zebra.org>
2505
2506 * bgp_packet.c (bgp_read): Make BGP packet read to non-blocking
2507 read.
2508 (bgp_read_packet): Likewise.
2509 (bgp_read_packet): When errono is EAGAIN, try to read it again.
2510
2511 * bgp_fsm.c (bgp_stop): Clear packet size and read buffer.
2512
25132000-09-26 Akihiro Mizutani <mizutani@dml.com>
2514
2515 * bgp_routemap.c: Configuration of prefix-list match is shown as
2516 "match ip address prefix-list <WORD>". Old configuration "match
2517 ip prefix-list <WORD>" is left for compatibilitty.
2518
25192000-09-25 Akihiro Mizutani <mizutani@dml.com>
2520
2521 * bgpd.h (BGP_CONFIG_MED_MISSING_AS_WORST): Changed from
2522 BGP_CONFIG_MISSING_AS_WORST.
2523
2524 * bgpd.c (bgp_bestpath_med): Change missing-as-worst syntax.
2525 Old "bgp bestpath missing-as-worst"
2526 New "bgp bestpath med missing-as-worst"
2527
25282000-09-24 Akihiro Mizutani <mizutani@dml.com>
2529
2530 * bgp_route.c: Compare MED properly in case of CONFED-IBGP.
2531
25322000-09-21 steve@Watt.COM (Steve Watt)
2533
2534 * bgp_debug.h: Do not declare debug variables conf_bgp_debug_* and
2535 term_bgp_debug_*.
2536
2537 * bgp_debug.c: Declare variables here.
2538
25392000-09-21 Akihiro Mizutani <mizutani@dml.com>
2540
2541 * bgpd.c: MBGP soft-reconfiguration command is added.
2542 clear ip bgp x.x.x.x ipv4 (unicast|multicast) in
2543 clear ip bgp x.x.x.x ipv4 (unicast|multicast) out
2544 clear ip bgp x.x.x.x ipv4 (unicast|multicast) soft
2545 clear ip bgp <1-65535> ipv4 (unicast|multicast) in
2546 clear ip bgp <1-65535> ipv4 (unicast|multicast) out
2547 clear ip bgp <1-65535> ipv4 (unicast|multicast) soft
2548 clear ip bgp * ipv4 (unicast|multicast) in
2549 clear ip bgp * ipv4 (unicast|multicast) out
2550 clear ip bgp * ipv4 (unicast|multicast) soft
2551
2552 Change "clear ip bgp vpnv4 x.x.x.x soft" command to
2553 "clear ip bgp x.x.x.x vpnv4 unicast soft".
2554
2555 "bgp bestpath med confed" command is added.
2556
2557 * bgpd.h (BGP_CONFIG_MED_CONFED): Add New definition.
2558
25592000-09-18 Rick Payne <rickp@rossfell.co.uk>
2560
2561 * bgpd.c (bgp_show_peer): Fix misplaced #endif.
2562
25632000-09-12 Akihiro Mizutani <mizutani@dml.com>
2564
2565 * bgpd.c (bgp_default_local_preference): Add "bgp default
2566 local-preference" command.
2567
2568 * bgp_nexthop.c (no_bgp_scan_time): Add "no bgp scan-time"
2569 command.
2570
25712000-09-10 Kunihiro Ishiguro <kunihiro@zebra.org>
2572
2573 * bgp_zebra.c (bgp_zebra_announce): BGP confederation peer's routes
2574 are passed to zebra like IBGP route.
2575
25762000-09-10 Akihiro Mizutani <mizutani@dml.com>
2577
2578 * bgpd.c (bgp_config_write_peer): Make it consistent passive
2579 configuration.
2580
2581 * bgp_route.c: Community match command is added.
2582 "show ip bgp community <val>"
2583 "show ip bgp community <val> exact-match"
2584
25852000-09-08 Kunihiro Ishiguro <kunihiro@zebra.org>
2586
2587 * bgp_nexthop.c (bgp_nexthop_lookup): ebgp-multihop routes are
2588 treated as IBGP routes.
2589
25902000-09-08 Akihiro Mizutani <mizutani@dml.com>
2591
2592 * bgp_route.c (bgp_show_route): When local-AS community route is
2593 selected, display "not advertised outside local AS" to "show ip
2594 route A.B.C.D" output.
2595 (show_ip_bgp_ipv4_filter_list): Add below four commands.
2596 "show ip bgp ipv4 (unicast|multicast) filter-list WORD"
2597 "show ip bgp ipv4 (unicast|multicast) community"
2598 "show ip bgp ipv4 (unicast|multicast) community-list WORD"
2599 "show ip bgp ipv4 (unicast|multicast) community-list WORD exact-match"
2600
2601 * bgp_clist.c (community_list_match_exact): Community exact match
2602 function.
2603
26042000-09-07 Kunihiro Ishiguro <kunihiro@zebra.org>
2605
2606 * bgp_route.c (bgp_update): Add peer's ttl check.
2607
2608 * bgpd.h (struct peer): Structure member refresh is renamed to
2609 refresh_adv.
2610
2611 * bgpd.c (clear_bgp_soft_in): Check PEER_FLAG_ROUTE_REFRESH flag
2612 when soft reconfiguration is performed.
2613
2614 * bgp_zebra.c (bgp_zebra_announce): When the peer is EBGP and
2615 ebgp-multiphop is set, set ZEBRA_FLAG_INTERNAL for nexthop lookup.
2616
2617 * bgp_route.h (struct bgp_info_tag): Add valid flag.
2618
26192000-08-25 Akihiro Mizutani <mizutani@dml.com>
2620
2621 * bgpd.c: Add AS base BGP soft reconfiguration.
2622
2623 * bgp_route.c: When no-advertise or no-export route is selected,
2624 "show ip bgp" display "not advertised to EBGP peer" or "not
2625 advertised to any peer" message.
2626
26272000-08-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2628
2629 * zebra-0.88 is released.
2630
2631 * bgp_dump.c (dump_bgp_routes): Change "dump bgp routes" to "dump
2632 bgp route-mrt" to support MRT specific dump format.
2633
2634 * bgpd.c (bgp_init): "clear ip bgp vpnv4 soft {in,out}" command is
2635 added.
2636
2637 * bgp_route.c (bgp_update): Currently nexthop check is only works
2638 for IPv4.
2639
26402000-08-17 Akihiro Mizutani <mizutani@dml.com>
2641
2642 * bgpd. (clear_ip_bgp_all_soft): Add "clear ip bgp * soft" for
2643 both inbound and outbound soft reconfiguration.
2644
26452000-08-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2646
2647 * bgpd.c (clear_ip_bgp_peer_soft_out): Add soft-reconfiguration
2648 outbound.
2649 (peer_new): Set route-refresh flag.
2650
26512000-08-16 Akihiro Mizutani <mizutani@dml.com>
2652
2653 * bgpd.c: "no bgp router-id A.B.C.D" alias is added. "no bgp
2654 cluster-id A.B.C.D" alias is added. " bgp cluster-id
2655 <1-4294967295>" alias is added. "clear ip bgp * soft in" command
2656 is added. "clear ip bgp A.B.C.D in" alias is added. "clear ip
2657 bgp * in" alias is added.
2658
26592000-08-16 Kunihiro Ishiguro <kunihiro@zebra.org>
2660
2661 * bgp_route.c (bgp_update): Add soft_reconfig flag. When the flag
2662 is set do not install the route into Adj-RIBs-In.
2663 (bgp_update): Perform implicit withdraw before filtering of the
2664 route.
2665
2666 * bgp_packet.c (bgp_read): draft-ietf-idr-bgp-route-refresh-01.txt
2667 capability code and BGP message can be accepted.
2668
2669 * bgp_open.c (bgp_capability_parse): Likewise.
2670
2671 * bgp_route.c (bgp_refresh_table): New function for route refresh.
2672 (bgp_refresh_rib): Likewise.
2673
2674 * bgpd.c (bgp_show_peer): Display route refresh status.
2675
2676 * bgp_route.c (bgp_aggregate_add): Add check for the route
2677 validness.
2678 (bgp_aggregate_delete): Likewise.
2679
26802000-08-15 Kunihiro Ishiguro <kunihiro@zebra.org>
2681
2682 * bgp_nexthop.c (bgp_scan): Care for aggregate route when the
2683 route become inaccessible.
2684
26852000-08-15 Akihiro Mizutani <mizutani@dml.com>
2686
2687 * bgp_route.c (show_ip_bgp_prefix): "show ip bgp A.B.C.D/M"
2688 command is added.
2689
26902000-08-15 Kunihiro Ishiguro <kunihiro@zebra.org>
2691
2692 * bgp_zebra.c (bgp_interface_up): Register connected route.
2693 (bgp_interface_down): Unregister connected route.
2694
26952000-08-14 Kunihiro Ishiguro <kunihiro@zebra.org>
2696
2697 * bgp_route.h (struct bgp_info): Add distance to the structure.
2698
2699 * bgp_route.c (bgp_aggregate_increment): Aggregate route only
2700 match to smaller prefixlen route not match same prefixlen route.
2701 (bgp_aggregate_decrement): Likewise.
2702 (bgp_aggregate_add): Likewise.
2703 (bgp_aggregate_delete): Likewise.
2704 (bgp_network_backdoor): Add backdoor network configuration.
2705
2706 * bgpd.h (struct bgp ): Add distance_{ebgp,ibgp,local} for store
2707 configuration distance value.
2708
2709 * bgp_route.c (bgp_update): Filter EBGP route which has non
2710 connected nexthop.
2711
2712 * bgp_attr.c (bgp_attr_aggregate_intern): New function for
2713 aggregate route. Set origin to IGP. Set atomic aggregate flag.
2714 Set aggregator AS and address.
2715 (bgp_attr_aggregate_intern): Check BGP_CONFIG_CONFEDERATION when
2716 filling aggregator_as.
2717
2718 * bgp_route.c (bgp_process): Delete suppress check for install
2719 suppressed route into local routing table.
2720 (bgp_aggregate_increment): Use bgp_attr_aggregate_intern() instead
2721 of bgp_attr_default_intern ().
2722 (bgp_aggregate_add): Likewise.
2723
2724 * bgpd.c (bgp_get): Call bgp_if_update_all() after BGP instance is
2725 created. This is for avoid 0.0.0.0 router-id.
2726
27272000-08-13 Akihiro Mizutani <mizutani@dml.com>
2728
2729 * bgp_route.c (route_vty_out_detail): Display "valid" when the
2730 route is valied. Display "aggregated" when the route is
2731 aggregated. "Advertisements suppressed by an aggregate" is
2732 displayed when the route is suppressed.
2733 (bgp_info_cmp): Prefer EBGP than Confed-EBGP.
2734
27352000-08-10 Akihiro Mizutani <mizutani@dml.com>
2736
2737 * bgp_route.c (route_vty_out_detail): Display format change.
2738
27392000-08-06 Kunihiro Ishiguro <kunihiro@zebra.org>
2740
2741 * bgp_route.c (bgp_update): Only AFI_IP nexthop check is enabled.
2742
2743 * bgpd.c (bgp_delete): Delete static route before delete peer
2744 configuration.
2745
27462000-08-02 Kunihiro Ishiguro <kunihiro@zebra.org>
2747
2748 * bgpd.c: Include bgpd/bgp_nexthop.h.
2749
27502000-07-31 Akihiro Mizutani <mizutani@dml.com>
2751
2752 * bgpd.c (bgp_show_summary): "show ip bgp summary" shows own BGP
2753 identifier. And status is changed like below.
2754
2755 State/Pref -> State/PfxRcd
2756 Shutdown -> Idle (Admin)
2757 PrefixOvflw -> Idle (PfxCt)
2758
2759 * bgp_route.c (route_vty_out): Show internal route as "i".
2760
27612000-07-13 Jim Bowen <jimb@zereau.net>
2762
2763 * bgp_snmp.c: Add BGP peer MIB implementation.
2764
27652000-07-12 Akihiro Mizutani <mizutani@dml.com>
2766
2767 * bgpd.c (bgp_show_peer): Fix typo.
2768
27692000-07-11 Akihiro Mizutani <mizutani@dml.com>
2770
2771 * bgp_routemap.c: Add commands for deleting set without argument.
2772
27732000-07-03 Akihiro Mizutani <mizutani@dml.com>
2774
2775 * bgp_zebra.c: Fix redistribute help strings.
2776
27772000-07-01 Kunihiro Ishiguro <kunihiro@zebra.org>
2778
2779 * bgp_route.c (bgp_show): When bgpd works as vtysh server send all
2780 output to vty at once.
2781
27822000-06-13 Kunihiro Ishiguro <kunihiro@zebra.org>
2783
2784 * bgp_mplsvpn.c (no_vpnv4_network): "no network A.B.C.D/M rd WORD
2785 tag WORD" command is added.
2786
2787 * bgp_ecommunity.c (ecommunity_vty_out): New function added.
2788
27892000-06-12 Kunihiro Ishiguro <kunihiro@zebra.org>
2790
2791 * bgp_route.c (bgp_show): Fix total number of prefix count bug.
2792
2793 * bgpd.c (bgp_show_peer): Display VPNv4 unicast configuration and
2794 negotiation result in "show ip bgp neighbors".
2795
27962000-06-12 Akihiro Mizutani <mizutani@dml.com>
2797
2798 * bgpd.c: Fix help strings.
2799
2800 * bgpd.h: Likewise.
2801
28022000-06-11 Kunihiro Ishiguro <kunihiro@zebra.org>
2803
2804 * bgp_route.c (bgp_aggregate_unset): Fix bug of checking rn->info
2805 instead of rn. Reported by Akihiro Mizutani <mizutani@dml.com>.
2806
2807 * bgp_mplsvpn.c (vpnv4_network): For testing purpose, "network
2808 A.B.C.D rd RD" is added to address-family vpnv4 unicast node.
2809
2810 * bgp_route.c (bgp_static_set): Set safi to p.safi.
2811
28122000-06-10 Kunihiro Ishiguro <kunihiro@zebra.org>
2813
2814 * bgp_route.c (bgp_show_prefix_list): Change to use bgp_show().
2815 (bgp_show_regexp): Change to use bgp_show().
2816 (show_adj_route): Change to display header.
2817
2818 * bgpd.c (clear_bgp): Set peer->v_start to default value when peer
2819 is cleared manually.
2820
2821 * bgp_route.c (bgp_show_route): New function which display
2822 specific BGP route. Divided from bgp_show().
2823 (bgp_static_delete): Delete all static route.
2824
28252000-06-09 NOGUCHI Kay <kay@v6.access.co.jp>
2826
2827 * bgp_route.c (show_ipv6_bgp): "show ipv6 bgp" is broken with
2828 invalid privious fix. Now show_ipv6_bgp and show_ipv6_bgp_route
2829 take care of "show ipv6 bgp [X:X::X:X]". Same change for "show ip
2830 mbgp" and "show ipv6 mbgp".
2831
28322000-06-07 Akihiro Mizutani <mizutani@dml.com>
2833
2834 * bgp_route.c: Fix help strings and command arguments.
2835
28362000-06-06 Kunihiro Ishiguro <kunihiro@zebra.org>
2837
2838 * bgp_ecommunity.c: Include prefix.h
2839
28402000-06-05 Kunihiro Ishiguro <kunihiro@zebra.org>
2841
2842 * bgp_route.h (struct bgp_info_tag): New structure to hold tag
2843 value.
2844
2845 * bgp_route.c (bgp_adj_set): table NULL check is added.
2846 (bgp_adj_unset): Likewise.
2847 (bgp_adj_lookup): Likewise.
2848 (bgp_adj_clear): Likewise.
2849 (route_vty_out): Add SAFI check for nexthop display.
2850 (bgp_withdraw): Add SAFI check for withdraw route.
2851
2852 * Remove all #ifdef MPLS_VPN then include it as default.
2853
2854 * bgpd.c: Temporary disable peer-group command until the
2855 implementation is completed.
2856
2857 * bgp_routemap.c (bgp_route_map_init): Install
2858 route_metric_match_cmd.
2859 (route_match_metric_compile): MED value compile using strtoul.
2860
28612000-06-05 Akihiro Mizutani <mizutani@dml.com>
2862
2863 * bgp_filter.c: Fix help strings. Change REGEXP to LINE. Change
2864 NAME to WORD.
2865
2866 * Change command argument to more comprehensive.
2867
2868 METRIC -> <0-4294967295>
2869 WEIGHT -> <0-4294967295>
2870 LOCAL_PREF -> <0-4294967295>
2871 IP_ADDR -> A.B.C.D
2872 AS -> <1-65535>
2873 AS-PATH-NAME -> WORD
2874 ACCESS_LIST -> WORD
2875 PREFIX_LIST -> WORD
2876 COMMUNITY -> AA:NN
2877 EXT_COMMUNITY -> ASN:nn_or_IP-address:nn
2878 IPv6_ADDR -> X:X::X:X
2879
2880 * bgp_clist.c: Fix help strings.
2881
28822000-06-03 Kunihiro Ishiguro <kunihiro@zebra.org>
2883
2884 * bgpd.c (peer_active): Add new function for check the peer is
2885 active or not.
2886 (neighbor_activate): New command "neighbor PEER activate" and "no
2887 neighbor PEER activate" are added.
2888
2889 * bgp_packet.c: Include bgpd/bgp_mplsvpn.h.
2890
28912000-06-02 Akihiro Mizutani <mizutani@dml.com>
2892
2893 * bgp_clist.c: Fix commuity-list help strings.
2894
2895 * bgp_routemap.c: Fix "set community" help strings. Add #define
2896 SET_STR. Use (unicast|multicast) argument for "set nlri" command.
2897
28982000-06-01 Kunihiro Ishiguro <kunihiro@zebra.org>
2899
2900 * bgp_routemap.c (route_set_community_none_cmd): "set community
2901 none" command is added to route-map.
2902
29032000-06-01 Akihiro Mizutani <mizutani@dml.com>
2904
2905 * bgp_debug.c: Change "show debug" to "show debugging". Now "show
2906 debugging" is not used in VIEW_NODE.
2907
29082000-05-30 Kunihiro Ishiguro <kunihiro@zebra.org>
2909
2910 * bgp_fsm.c (bgp_timer_set): Add check for shutdown flag. This
2911 fix unconditional BGP connection.
2912
2913 * bgpd.c (peer_shutdown): Replace peer_shutdown() with
2914 peer_change_flag_with_reset().
2915
29162000-05-26 Kunihiro Ishiguro <kunihiro@zebra.org>
2917
2918 * bgpd.c (no_bgp_default_ipv4_unicast): Add "no bgp default
2919 ipv4-unicast" command.
2920
2921 * bgpd.h (BGP_CONFIG_NO_DEFAULT_IPV4): Add new definition.
2922
2923 * bgp_filter.c (as_list_delete): Free all AS filter.
2924
2925 * bgp_clist.c (community_list_delete): Free all community entry.
2926
2927 * bgp_filter.c (no_ip_as_path_all): New DEFUN for "no ip as-path
2928 access-list NAME".
2929
2930 * bgp_clist.c (no_ip_community_list_all): New DEFUN for "no ip
2931 community-list NAME".
2932
29332000-05-19 Kunihiro Ishiguro <kunihiro@zebra.org>
2934
2935 * bgp_route.c (ipv6_mbgp_neighbor_routes): Change "show ip bgp PEER
2936 routes" to "show ip bgp PEER received-routes"
2937
29382000-05-14 Kunihiro Ishiguro <kunihiro@zebra.org>
2939
2940 * bgp_ecommunity.c (ecommunity_parse): New file for Extended
2941 Communities attribute.
2942 * bgp_ecommunity.h: Likewise.
2943
29442000-05-11 Kunihiro Ishiguro <kunihiro@zebra.org>
2945
2946 * bgp_mplsvpn.h: New file for MPLS-VPN.
2947 * bgp_mplsvpn.c: Likewise.
2948
2949 * bgpd.c (bgp_delete): Fix bug of "no router bgp" crush.
2950
29512000-05-10 Kunihiro Ishiguro <kunihiro@zebra.org>
2952
2953 * bgpd.c (bgp_bestpath_missing_as_worst): Add "bgp bestpath
2954 missing-as-worst".
2955
29562000-05-08 Kunihiro Ishiguro <kunihiro@zebra.org>
2957
2958 * bgp_routemap.c (match_community): Clarify help of "match
2959 community".
2960
29612000-05-02 Kunihiro Ishiguro <kunihiro@zebra.org>
2962
2963 * bgp_aspath.c (aspath_cmp_left): Remove debug code.
2964
29652000-04-27 Kunihiro Ishiguro <kunihiro@zebra.org>
2966
2967 * bgp_route.c (bgp_info_cmp): Compare MED only both routes comes
2968 from same neighboring AS.
2969
2970 * bgp_aspath.c (aspath_cmp_left): Compare leftmost AS value.
2971
2972 * bgp_route.c (bgp_info_cmp): Fix misused htonl() to ntohl().
2973
29742000-04-26 Kunihiro Ishiguro <kunihiro@zebra.org>
2975
2976 * bgp_route.c (bgp_output_filter): When distribute-list's
2977 corresponding access-list does not exist, filter all routes.
2978 (bgp_input_filter): Likewise.
2979
29802000-04-19 Kunihiro Ishiguro <kunihiro@zebra.org>
2981
2982 * bgp_attr.c (bgp_packet_attribute): Propagate MED to IBGP peer.
2983
2984 * bgp_route.c (bgp_info_cmp): Add evaluation of local preference.
2985
29862000-04-18 Kunihiro Ishiguro <kunihiro@zebra.org>
2987
2988 * bgpd.c (bgp_distribute_update): Add struct access_list *
2989 argument.
2990
29912000-04-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2992
2993 * bgp_clist.c (community_list_dup_check): Add duplicate insertion
2994 check.
2995
2996 * bgp_filter.c (as_list_dup_check): Add duplicate insertion check.
2997
2998 * bgp_route.c (bgp_show): Fix undeclared write variable.
2999
30002000-04-13 Kunihiro Ishiguro <kunihiro@zebra.org>
3001
3002 * bgp_routemap.c: Add "match ip address prefix-list".
3003
30042000-03-29 Rick Payne <rickp@rossfell.co.uk>
3005
3006 * bgp_aspath.c (aspath_strip_confed): Fix realloc problem.
3007
30082000-03-16 Kunihiro Ishiguro <kunihiro@zebra.org>
3009
3010 * bgp_fsm.c (bgp_reconnect): Connect retry timer is expired when
3011 the peer status is Connect.
3012
30132000-03-03 Kunihiro Ishiguro <kunihiro@zebra.org>
3014
3015 * Fix bug of rewritten originator-id.
3016
30172000-01-27 Rick Payne <rickp@rossfell.co.uk>
3018
3019 * bgp_aspath.c (aspath_delimiter_char): New function. Instead of
3020 directly referencing array, search proper AS path delimiter.
3021 (aspath_strip_confed): Strip the confederation stuff from the
3022 front of an AS path.
3023 (aspath_add_left_confed): New function for adding specified AS to
3024 the leftmost AS_CONFED_SEQUENCE.
3025
3026 * bgp_aspath.h: Change AS_CONFED_SEQUENCE and AS_CONFED_SET value
3027 to Cisco compatible.
3028
3029 * bgpd.c (bgp_confederation_id_set): Confederation configuration.
3030 (bgp_confederation_id_unset): Likewise.
3031 (bgp_confederation_peers_check): Likewise.
3032 (bgp_confederation_peers_add): Likewise.
3033 (bgp_confederation_peers_remove): Likewise.
3034 (bgp_confederation_peers_set): Likewise.
3035 (bgp_confederation_peers_unset): Likewise.
3036 (bgp_confederation_peers_print): Likewise.
3037
30382000-01-16 Kunihiro Ishiguro <kunihiro@zebra.org>
3039
3040 * bgpd.c: Introduce peer_change_flag_with_reset() fucntion.
3041
30422000-01-17 Kunihiro Ishiguro <kunihiro@zebra.org>
3043
3044 * bgp_open.c (bgp_open_option_parse): When there is no common
3045 capability send Unsupported Capability error to the peer.
3046
30472000-01-14 Kunihiro Ishiguro <kunihiro@zebra.org>
3048
3049 * bgp_open.c (bgp_capability_mp): Fix bug of mis-negotiation about
3050 IPv6 unicast.
3051
3052 * bgpd.c (bgp_init): Add "soft-reconfiguration inbound" command.
3053
30542000-01-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3055
3056 * bgpd.c (neighbor_strict_capability): Add
3057 "strict-capability-match" command.
3058
3059 * bgp_zebra.c (bgp_if_update): Ignore NET127 determining
3060 router-id.
3061
3062 * bgpd.c (peer_override_capability): Add "override-capability"
3063 command.
3064
30651999-12-16 Kunihiro Ishiguro <kunihiro@zebra.org>
3066
3067 * bgp_packet.c (bgp_write): Change status to Idle and set timer
3068 after write failed.
3069
30701999-12-14 Kunihiro Ishiguro <kunihiro@zebra.org>
3071
3072 * bgp_zebra.c (bgp_zebra_announce): Add info->selected check.
3073
30741999-12-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3075
3076 * bgp_route.c (nlri_unfeasible): nlri_unfeasible() is merged with
3077 nlri_parse().
3078
30791999-12-10 Kunihiro Ishiguro <kunihiro@zebra.org>
3080
3081 * bgp_fsm.h (BGP_EVENT_DELETE): Macro added.
3082
3083 * bgp_fsm.c (bgp_stop): Clear all event threads of the peer when
3084 the peer is cleared.
3085
3086 * bgp_zebra.c (bgp_nexthop_set): Clear interface index of
3087 link-local address. This is KAME specific problem.
3088
30891999-12-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3090
3091 * bgp_attr.c (bgp_mp_reach_parse): Comment out previous code for a
3092 while. We don't completely detect the link is shared or not at
3093 this moment.
3094
3095 * bgp_packet.c (bgp_notify_send): Make shortcut call of
3096 bgp_write() and bgp_stop().
3097
3098 * bgp_attr.c (bgp_mp_reach_parse): Fix serious bug when getting
3099 global and link-local address.
3100
31011999-12-05 Kunihiro Ishiguro <kunihiro@zebra.org>
3102
3103 * bgpd.c (no_neighbor_port): New command added.
3104 (peer_new): Set send_community.
3105
31061999-12-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3107
3108 * bgpd.c (show_ip_bgp_summary): Changed to use bgp_show_summary().
3109 (show_ip_mbgp_summary): Likewise.
3110 (show_ipv6_bgp_summary): Likewise.
3111 (show_ipv6_mbgp_summary): Add new command.
3112 (peer_free): Free peer->host.
3113 (peer_lookup_by_su): Delete function.
3114 (ipv6_bgp_neighbor): Changed to use peer_remote_as().
3115 (sockunion_vty_out): Function deleted.
3116 (vty_clear_bgp): Use afi instead of family.
3117 Delete old list bgp_list. Use struct newlist *bgplist.
3118 (peer_lookup_by_host): Function deleted.
3119
31201999-12-03 Kunihiro Ishiguro <kunihiro@zebra.org>
3121
3122 * bgpd.h (struct peer_group): New structure added.
3123 (struct peer_conf): New structure added.
3124 (struct peer): Change all prefix_count to unsigned long.
3125
3126 * bgpd.c: Reconstruct all of VTY commands reflect internal
3127 structure change.
3128 Use bgplist instead of bgp_list.
3129 Use peerlist intstead of peer_list.
3130
3131 * bgp_attr.c (bgp_mp_reach_parse): If nlri_parse return -1, stop
3132 parsing then return immediately.
3133
3134 * bgp_route.c (nlri_parse): When NLRI parse error occured, return
3135 -1.
3136 (nlri_process): Use pcount_v4_{unicast,multicast}.
3137 (nlri_delete): Likewise.
3138
31391999-11-25 Robert Olsson <Robert.Olsson@data.slu.se>
3140
3141 * bgp_routemap.c (route_match_nlri): `match nlri
3142 unicast|multicast' and `set nlri unicast|multicast' command are
3143 added.
3144
31451999-11-22 Robert Olsson <Robert.Olsson@data.slu.se>
3146
3147 * bgpd.c: Add translate-update support.
3148
3149 * bgpd.h (TRANSLATE_UPDATE_OFF): Add translate-update definition.
3150
31511999-11-19 Robert.Olsson@data.slu.se
3152
3153 * bgp_route.c (bgp_peer_delete): Add MBGP peer clear codes.
3154
31551999-11-14 Kunihiro Ishiguro <kunihiro@zebra.org>
3156
3157 * bgp_open.c (bgp_capability_mp): Temporary comment out
3158 SAFI_UNICAST_MULTICAST handling until we know the meanings.
3159
31601999-11-13 Kunihiro Ishiguro <kunihiro@zebra.org>
3161
3162 * bgp_btoa.c: New file added.
3163
31641999-11-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3165
3166 * bgpd.h (struct peer): Add dont_capability flag.
3167 (struct peer): Add override_capability flag.
3168
3169 * bgpd.c (neighbor_dont_capability_negotiation): `neighbor PEER
3170 dont-capability-negotiation' added.
3171
31721999-11-12 Bill Sommerfeld <sommerfeld@orchard.arlington.ma.us>
3173
3174 * bgp_attr.c (bgp_mp_reach_parse): Ignore link-local addresses
3175 attribute from non-shared-network peers.
3176
31771999-11-10 Kunihiro Ishiguro <kunihiro@zebra.org>
3178
3179 * bgp_snmp.c: New file added.
3180
3181 * BGP4-MIB.txt: Updated to the latest Internet-Draft
3182 draft-ietf-idr-bgp4-mib-04.txt.
3183
31841999-11-09 Kunihiro Ishiguro <kunihiro@zebra.org>
3185
3186 * bgp_route.c (bgp_route_init): Add `show ipv6 bgp prefix-list'.
3187
3188 * bgp_attr.c (bgp_mp_unreach_parse): Enclose safi setup with
3189 #ifdef HAVE_MBGPV4.
3190
31911999-11-08 Kunihiro Ishiguro <kunihiro@zebra.org>
3192
3193 * bgp_dump.c (no_dump_bgp_all): Add [PATH] and [INTERVAL] to no
3194 dump bgp commands.
3195 (config_write_bgp_dump): Write interval value to the
3196 configuration.
3197
31981999-11-07 Kunihiro Ishiguro <kunihiro@zebra.org>
3199
3200 * bgp_zebra.c: Redistribute route-map support is added.
3201
3202 * bgp_zebra.h: New file added.
3203
32041999-11-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3205
3206 * bgp_dump.c: BGP packet dump routine compatible with MRT.
3207 * bgp_dump.h: BGP packet dump routine compatible with MRT.
3208
3209 * bgp_debug.c: Renamed from bgp_dump.c
3210 * bgp_debug.h: Renamed from bgp_dump.h
3211
32121999-10-27 Kunihiro Ishiguro <kunihiro@zebra.org>
3213
3214 * BGP4-MIB.txt: New file added. Edited version of RFC1657.
3215
32161999-10-25 Bill Sommerfeld <sommerfeld@orchard.arlington.ma.us>
3217
3218 * bgp_route.c (bgp_announce): If we're not on a shared network
3219 with the peer and we don't have a link-local next hop, but the
3220 inbound next-hop has a link-local address, don't readvertise it to
3221 our peer.
3222
32231999-10-25 Marc Boucher <marc@mbsi.ca>
3224
3225 * bgp_zebra.c: Add redistribute kernel command.
3226
32271999-10-25 Kunihiro Ishiguro <kunihiro@zebra.org>
3228
3229 * bgp_route.c (bgp_reset): New function added.
3230
3231 * bgpd.conf.sample2: Add IPv6 configuration sample.
3232
32331999-10-24 Bill Sommerfeld <sommerfeld@orchard.arlington.ma.us>
3234
3235 * bgp_route.c (ipv6_aggregate_address): Function added.
3236
32371999-10-21 Kunihiro Ishiguro <kunihiro@zebra.org>
3238
3239 * bgp_packet.c (bgp_update): Unintern aspath, community, cluster
3240 list after parsing BGP update packet.
3241
3242 * bgp_attr.c (bgp_attr_aspath): Intern parsed aspath.
3243 (bgp_attr_community): Intern parsed community.
3244 (bgp_attr_cluster_list): Intern parsed cluster list.
3245
3246 * bgp_routemap.c: Add `set community-additive' command.
3247
32481999-10-21 Alexandr D. Kanevskiy <kad@blackcatlinux.com>
3249
3250 * bgp_routemap.c (route_set_local_pref): Fix bug of setting
3251 attribute flag.
3252
32531999-10-21 Bill Sommerfeld <sommerfeld@orchard.arlington.ma.us>
3254
3255 * bgp_route.c (bgp_announce): Add check of IPv6 default route
3256 announcement.
3257
3258 * bgp_packet.c (bgp_update_send): Add BGP announcement logging.
3259
32601999-10-15 Kunihiro Ishiguro <kunihiro@zebra.org>
3261
3262 * `show ip[v6] bgp PREFIX' show uptime of the route.
3263
32641999-10-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3265
3266 * bgpd.c (bgp_filter_set): Delete PEER_FAMILY_{IPV4,IPV6}. instead
3267 of that use AF_INET and AF_INET6 directly.
3268 (vty_clear_bgp): Add new function to support various clear ip bgp
3269 method.
3270
32711999-10-04 Lars Fenneberg <lf@elemental.net>
3272
3273 * bgpd.c (clear_ip_bgp): Add `clear ip bgp ASN'.
3274
32751999-10-03 Kunihiro Ishiguro <kunihiro@zebra.org>
3276
3277 * bgp_routemap.c: Add `match ip prefix-list' and `match ipv6
3278 prefix-list'.
3279
32801999-09-28 Kunihiro Ishiguro <kunihiro@zebra.org>
3281
3282 * bgpd.c (bgp_collision_detect): Add BGP collision detection
3283 function.
3284
32851999-09-26 Blake Meike <bmeike@adero.com>
3286
3287 * bgpd.c (neighbor_port): New command `neighbor PEER port PORT' is
3288 added.
3289
32901999-08-24 Kunihiro Ishiguro <kunihiro@zebra.org>
3291
3292 * bgpd.c (no_neighbor_timers_keepalive): Change MIN to min. Add
3293 min() macro.
3294
32951999-08-19 Rick Payne <rickp@rossfell.co.uk>
3296
3297 * bgp_packet.c (bgp_open): BGP holdtimer bug is fixed. Make BGP
3298 keepalive timer configurable.
3299
33001999-08-15 Kunihiro Ishiguro <kunihiro@zebra.org>
3301
3302 * bgp_zebra.c (bgp_redistribute_set): Fix redistribute bug.
3303
33041999-08-13 Kunihiro Ishiguro <kunihiro@zebra.org>
3305
3306 * bgpd.c (bgp_peer_display): show ip bgp neighbors PEER only list
3307 the peer not all of them.
3308
33091999-08-11 Rick Payne <rickp@rossfell.co.uk>
3310
3311 * bgp_route.c (bgp_announce): Remove MED if its an EBGP peer -
3312 will get overwritten by route-maps.
3313
33141999-08-08 Rick Payne <rickp@rossfell.co.uk>
3315
3316 * bgp_routemap.c: Multi protocol route-map modification.
3317
33181999-08-01 Kunihiro Ishiguro <kunihiro@zebra.org>
3319
3320 * bgp_route.c: Set network statement route's origin attribute as
3321 igp.
3322
3323 * bgp_zebra.c: Set redistribute route's origin attribute as
3324 incomplete.
3325
3326 * bgp_route.c (bgp_info_cmp): Add attribute existance check,
3327 origin attribute check, BGP peer type check.
3328
33291999-07-30 Kunihiro Ishiguro <kunihiro@zebra.org>
3330
3331 * bgp_route.c (bgp_peer_delete): Reselect of IPv6 route.
3332
33331999-07-29 Rick Payne <rickp@rossfell.co.uk>
3334
3335 * Changed route-maps to behave in a more cisco-like fashion
3336
33371999-07-27 Kunihiro Ishiguro <kunihiro@zebra.org>
3338
3339 * bgp_fsm.c (bgp_stop): Very serious bug of bgp_stop () is fixed.
3340 When multiple route to the same destination exist, bgpd try to
3341 announce the information to stopped peer. Then add orphan write
3342 thread is added. This cause many strange behavior of bgpd.
3343 Reported by Georg Hitsch <georg@atnet.at>.
3344
33451999-07-23 Kunihiro Ishiguro <kunihiro@zebra.org>
3346
3347 * bgpd.c: Change peer's A.B.C.D to PEER.
3348
33491999-07-22 Kunihiro Ishiguro <kunihiro@zebra.org>
3350
3351 * bgp_route.c (bgp_announce): Add hack for link-local nexthop.
3352
3353 * bgp_zebra.c (bgp_zebra_announce): Fill in nexthop address from
3354 local address.
3355
33561999-07-21 Kunihiro Ishiguro <kunihiro@zebra.org>
3357
3358 * bgp_packet.c (bgp_open): Holdtime fetch bug is fixed. Reported
3359 by Yuji SEKIYA <sekiya@sfc.wide.ad.jp>.
3360
33611999-07-15 Kunihiro Ishiguro <kunihiro@zebra.org>
3362
3363 * bgp_fsm.c (fsm_holdtime): Don't close file descriptor in
3364 fsm_holdtime ().
3365
33661999-07-11 Kunihiro Ishiguro <kunihiro@zebra.org>
3367
3368 * bgp_routemap.c: Add `set atomic-aggregate' command.
3369
33701999-07-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3371
3372 * bgp_routemap.c (route_set_ip_nexthop_cmd): Change "ip nexthop"
3373 to "ip next-hop".
3374
33751999-07-02 Kunihiro Ishiguro <kunihiro@zebra.org>
3376
3377 * bgp_route.c (show_ipv6_bgp_regexp): `show ipv6 bgp regexp'
3378 added.
3379
33801999-07-01 Rick Payne <rickp@rossfell.co.uk>
3381
3382 * bgp_zebra.c (zebra_init): Install standard commands to
3383 ZEBRA_NODE.
3384
33851999-06-28 Rick Payne <rickp@rossfell.co.uk>
3386
3387 * bgpd.c (bgp_delete): bgp peer deletion bug is fixed.
3388
33891999-06-25 Kunihiro Ishiguro <kunihiro@zebra.org>
3390
3391 * bgpd.c: Add neighbor update-source command as ALIAS to
3392 neighbor_interface.
3393
33941999-06-19 Kunihiro Ishiguro <kunihiro@zebra.org>
3395
3396 * bgp_attr.c (bgp_packet_attribute): Send community attribute when
3397 send_community flag is set.
3398
3399 * bgpd.h (struct peer): Add send_community flag.
3400
34011999-06-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3402
3403 * bgpd.c (router_bgp): router bgp's argument changed from AS_NO to
3404 <1-65535>.
3405
34061999-06-08 Kunihiro Ishiguro <kunihiro@zebra.org>
3407
3408 * bgp_route.h (struct bgp_info): Add subtype for BGP route type.
3409
34101999-06-07 Kunihiro Ishiguro <kunihiro@zebra.org>
3411
3412 * bgp_community.c (community_merge): Function added.
3413
34141999-06-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3415
3416 * bgp_clist.c: New file.
3417 * bgp_clist.h: New file.
3418
3419 * bgp_community.h (COMMUNITY_LOCAL_AS): Added for Cisco
3420 compatibility.
3421 (COMMUNITY_NO_ADVERTISE): Fix typo.
3422
34231999-05-30 Kunihiro Ishiguro <kunihiro@zebra.org>
3424
3425 * bgp_routemap.c: Add `set weight WEIGHT' command.
3426
3427 * bgpd.c: Remove all_digit_check function. Instead of that use
3428 all_digit function in lib/prefix.c.
3429
3430 * bgp_routemap.c (bgp_route_map_init): Install
3431 no_set_ipv6_nexthop_global_cmd and no_set_ipv6_nexthop_local_cmd
3432 element to the RMAP_NODE.
3433
34341999-05-28 Kunihiro Ishiguro <kunihiro@zebra.org>
3435
3436 * bgp_aspath.c (aspath_make_str): Declare aspath_delimiter_char
3437 inside aspath_make_str function.
3438 (aspath_prepend): New function is added for AS path prepend.
3439 (aspath_make_str_count): Renamed from aspath_make_str. AS path
3440 count is set to the structure.
3441 (aspath_merge): New function.
3442
34431999-05-22 Kunihiro Ishiguro <kunihiro@zebra.org>
3444
3445 * bgp_zebra.c (redistribute_bgp): Add new DEFUN.
3446 (no_redistribute_bgp): Likewise.
3447 (router_zebra): Semantics changed. Now 'router zebra' is default
3448 behavior of bgpd.
3449
34501999-05-14 Kunihiro Ishiguro <kunihiro@zebra.org>
3451
3452 * bgp_routemap.c: Add some commands to bgp route-map.
3453 match ip next-hop: New command.
3454 match metric: New command.
3455 set metric: Doc fix.
3456 set local-preference: Add DEFUN.
3457
34581999-05-14 Stephen R. van den Berg <srb@cuci.nl>
3459
3460 * bgp_main.c (signal_init): SIGTERM call sigint.
3461 (sigint): Loggging more better message.
3462
34631999-05-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3464
3465 * bgp_attr.c (bgp_packet_attribute): AS path attribute extended
3466 length bit check is added.
3467
34681999-05-11 Kunihiro Ishiguro <kunihiro@zebra.org>
3469
3470 * bgp_routemap.c (bgp_route_map_init): Call route_map_install_set
3471 function with route_set_local_pref_cmd argument.
3472 (no_match_aspath): Function added.
3473 (route_set_metric): Set attribute flag bit.
3474
3475 * bgp_attr.c (bgp_packet_attribute): MULTI_EXIT_DISC is now in BGP
3476 packet.
3477
34781999-05-07 Kunihiro Ishiguro <kunihiro@zebra.org>
3479
3480 * bgpd.c (no_neighbor_timers_holdtime): `no neighbor PEER timers
3481 holdtime' command is added.
3482
3483 * bgpd.h (BGP_DEFAULT_HOLDTIME_BIG): Delete define.
3484
3485 * bgpd.c (bgp_prefix_list_set): New function added.
3486 (bgp_prefix_list_unset): Likewise.
3487 (bgp_prefix_list_update): Likewise.
3488 (show_ip_bgp_neighbors): prefix-list information display.
3489
34901999-05-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3491
3492 * bgpd.c (bgp_delete): Function added for `no router bgp'.
3493
34941999-05-05 Kunihiro Ishiguro <kunihiro@zebra.org>
3495
3496 * bgp_dump.c (bgp_dump_attr): Add originator_id display.
3497
3498 * bgpd.c (bgp_router_id): Even when address is malformed set the
3499 value to configuration bug fixed.
3500 (no_bgp_router_id): New function.
3501 (no_bgp_cluster_id): New function.
3502
35031999-05-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3504
3505 * bgpd.h (BGP_ATTR_ORIGINATOR_ID): Changed from BGP_ATTR_ORIGINATOR.
3506
35071999-05-02 Kunihiro Ishiguro <kunihiro@zebra.org>
3508
3509 * bgp_route.c (bgp_announce): Add route reflector check.
3510
35111999-05-01 Kunihiro Ishiguro <kunihiro@zebra.org>
3512
3513 * bgpd.c (bgp_cluster_id): Add function for route reflector.
3514 (neighbor_route_reflector_client): Likewise.
3515 (no_neighbor_route_reflector_client): Likewise.
3516
3517 * bgpd.h (struct bgp ): Add cluster for route reflector.
3518
3519 * bgp_route.c (show_ip_bgp_prefix_list): New command is added.
3520
35211999-04-24 Kunihiro Ishiguro <kunihiro@zebra.org>
3522
3523 * Makefile.am (noinst_HEADERS): Add bgp_filter.h
3524
3525 * bgp_aspath.c (aspath_undup): Function deleted. aspath_free ()
3526 has same functionality.
3527
3528 * bgp_filter.h: New file.
3529
3530 * bgp_aspath.c (aspath_unintern): Rename aspath_free () to
3531 aspath_unintern ()
3532 (aspath_free): New function.
3533
35341999-04-23 Kunihiro Ishiguro <kunihiro@zebra.org>
3535
3536 * bgp_aspath.c (aspath_aggregate): Function added.
3537
3538 * bgp_aspath.h (aspath_aggregate): Prototype added.
3539
3540 * bgp_aspath.c (aspath_empty_aspath): New argument
3541 gated_dont_eat_flag is added.
3542
35431999-04-18 Kunihiro Ishiguro <kunihiro@zebra.org>
3544
3545 * bgp_route.c: Add bgp_aggregate_ipv4 and bgp_aggregate_ipv6.
3546
35471999-04-17 Kunihiro Ishiguro <kunihiro@zebra.org>
3548
3549 * bgp_route.c (aggregate_address): Function added.
3550
3551 * bgp_zebra.c (zebra_read): Change log to zlog.
3552
35531999-04-15 Kunihiro Ishiguro <kunihiro@zebra.org>
3554
3555 * Makefile.am (noninst_HEADERS): Added for make dist.
3556
35571999-04-09 Kunihiro Ishiguro <kunihiro@zebra.org>
3558
3559 * aspath_regex.c: Removed from distribution.
3560
35611999-04-07 Kunihiro Ishiguro <kunihiro@zebra.org>
3562
3563 * bgp_attr.c (bgp_packet_attribute): Old draft-00 packet treatment
3564 bug fixed.
3565
35661999-04-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3567
3568 * bgp_aspath.c (aspath_add_left): Fix empty aspath bug. Reported
3569 by kad@gibson.skif.net.
3570
3571 * bgp_regex.[ch]: New file added.
3572
3573
35741999-04-05 Kunihiro Ishiguro <kunihiro@zebra.org>
3575
3576 * bgp_filter.c: New file added.
3577
35781999-04-01 Kunihiro Ishiguro <kunihiro@zebra.org>
3579
3580 * bgp_aspath.c (aspath_empty_aspath): Change for peering with
3581 gated.
3582
35831999-03-24 Kunihiro Ishiguro <kunihiro@zebra.org>
3584
3585 * bgp_main.c (main): Default loggin method changed from syslog to
3586 stdout.
3587
35881999-03-05 Kunihiro Ishiguro <kunihiro@zebra.org>
3589
3590 * bgp_route.c: Delete obsolete default attribute DEFUN.
3591
35921999-03-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3593
3594 * bgp_attr.c: Make attribute structure put into attribute hash.
3595
35961999-03-02 Kunihiro Ishiguro <kunihiro@zebra.org>
3597
3598 * bgp_view.c : Delete file.
3599
36001999-02-25 Kunihiro Ishiguro <kunihiro@zebra.org>
3601
3602 * bgp_routemap.c (bgp_apply_route_map): Add prefix argument.
3603
3604 * bgp_route.h (struct bgp_info): Add bgp_info structre. I'll
3605 replace bgp_route with this.
3606
3607 * bgp_routemap.c (route_match_ip_address): Fix bug of passing non
3608 prefix value to access_list_apply().
3609
3610 * bgpd.conf.sample: Add route-map sample.
3611 Delete obsolete default-attr statements.
3612
3613 * bgp_packet.c: Use stream_fifo for packet queueing.
3614
36151999-02-24 Kunihiro Ishiguro <kunihiro@zebra.org>
3616
3617 * bgp_aspath.c (aspath_add_left): add non empty aspath treatment.
3618
3619 * bgp_main.c: include unistd.h for daemon().
3620
3621 * bgp_route.c (nlri_process): add IPv6 table lookup.
3622
3623 * bgp_attr.c (route_parse_ipv6): call nlri_process().
3624 (attr_make): Obsolete function attr_make deleted.
3625
36261999-02-22 Kunihiro Ishiguro <kunihiro@zebra.org>
3627
3628 * bgp_aspath.c (aspath_add_left): change function name from
3629 aspath_add_leftmost_as().
3630
36311999-02-21 Kunihiro Ishiguro <kunihiro@zebra.org>
3632
3633 * bgp_aspath.c: add aspath_add_leftmost_as ().
3634
36351999-02-18 Peter Galbavy <Peter.Galbavy@knowledge.com>
3636
3637 * syslog support added
3638
36391999-01-26 Kunihiro Ishiguro <kunihiro@zebra.org>
3640
3641 * bgpd.c: DEFUN (neighbor_nexthop): deleted.
3642 DEFUN (neighbor_distribute_list): added.
3643
36441999-01-19 Kunihiro Ishiguro <kunihiro@zebra.org>
3645
3646 * bgpd.h (struct peer ): header_buf and read_buf is removed.
3647
3648 * bgp_peer.[ch]: Deleted. Peer related functions are merged to
3649 bgpd.c
3650
3651 * bgp_network.c: New file.
3652 * bgp_network.h: New file.
3653
3654 * bgp_packet.h: New file.
3655
36561999-01-11 Kunihiro Ishiguro <kunihiro@zebra.org>
3657
3658 * bgp_packet.c (bgp_keepalive_send): Now BGP keepalive packet is
3659 buffered.
3660
36611999-01-08 Kunihiro Ishiguro <kunihiro@zebra.org>
3662
3663 * bgp_packet.c: New file.
3664
36651998-12-22 Kunihiro Ishiguro <kunihiro@zebra.org>
3666
3667 * bgp_zebra.c (zebra_client): Use zebra_connect() in lib/client.c.
3668
3669 * `show ip bgp' bug fixed.
3670 * aspath_log (): Remove argument logfp.
3671
36721998-12-15 Kunihiro Ishiguro <kunihiro@zebra.org>
3673
3674 * bgp_fsm.h: New file.
3675
36761998-12-15 Magnus Ahltorp <map@stacken.kth.se>
3677
3678 * bgp_attr.c, bgp_community.h, bgp_dump.c, bgp_fsm.c, bgp_open.c
3679 bgp_peer.c, bgp_peer.h, bgp_route.c, bgp_route.h, bgp_view.c
3680 bgpd.c, bgpd.h, bgp_attr.c, bgp_community.h, bgp_dump.c,
3681 bgp_fsm.c, bgp_open.c, bgp_peer.c, bgp_peer.h: Prototype fixes.
3682
36831998-12-09 Kunihiro Ishiguro <kunihiro@zebra.org>
3684
3685 * bgpd.c (bgp_config_write): Delete vector v argument.
3686
36871998-12-07 Kunihiro Ishiguro <kunihiro@zebra.org>
3688
3689 * bgpd.h: Delete annoying ld_[124]byte and st_[124]byte macros.
3690
36911998-11-23 Kunihiro Ishiguro <kunihiro@zebra.org>
3692
3693 * bgp_radix.[ch]: removed.
3694
36951998-09-15 HEO SeonMeyong <seirios@matrix.iri.co.jp>
3696
3697 * bgp_main.c: ifdef HYDRANGEA -> ifdef KAME
3698
36991998-08-13 Kunihiro Ishiguro <kunihiro@zebra.org>
3700
3701 * bgp_dump.c: delete nroute().
3702
37031998-05-19 Yamshita TAKAO <jargon@lares.dti.ne.jp>
3704
3705 * bgp_aspath.c: HAVE_CONFIG_H typo :-)
3706 * bgpd.h: Modify for compile on Solaris.
3707 * bgp_aspath.h: likewize
3708 * bgp_community.h: likewize
3709 * bgp_routemap.c: likewize
3710
37111998-05-18 Yamshita TAKAO <jargon@lares.dti.ne.jp>
3712
3713 * bgpd.h: Modify for compile on Solaris.
3714 * bgp_aspath.h: likewize
3715
37161998-05-08 Kunihiro Ishiguro <kunihiro@zebra.org>
3717
3718 * routemap.[ch]: move to ../lib directory.
3719
37201998-05-07 Kunihiro Ishiguro <kunihiro@zebra.org>
3721
3722 * routemap.c (route_map_apply): add function.
3723
37241998-05-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3725
3726 * routemap.h: add file.
3727
3728 * bgp_peer.h (enum ): change PEER_{IBGP,EBGP} to BGP_PEER_{IBGP,EBGP}
3729
37301998-05-03 Kunihiro Ishiguro <kunihiro@zebra.org>
3731
3732 * Makefile.am: sysconfdir_DATA added.
3733
37341998-05-02 Kunihiro Ishiguro <kunihiro@zebra.org>
3735
3736 * bgp_dump.c: add `debug bgp fsm'
3737 add `no debug bgp fsm'
3738 add `show debug bgp'
3739 * bgp_open.c: File added.
3740
37411998-05-01 Kunihiro Ishiguro <kunihiro@zebra.org>
3742
3743 * .cvsignore: File added.
3744
37451998-04-30 Kunihiro Ishiguro <kunihiro@zebra.org>
3746
3747 * bgp_community.[ch]: File added.
3748
37491998-03-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3750
3751 * bgpd now use lib/thread.[ch].
3752
37531998-01-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3754
3755 * bgpd.c (show_ip_bgp_neighbors): add 'show ip bgp neighbors' command.
3756
3757 * bgpd.h (BGP_DEFAULT_START_TIMER): change from 1 to 30.
3758
37591997-12-30 Kunihiro Ishiguro <kunihiro@zebra.org>
3760
3761 * bgp_vty.c: bgp_vty.c deleted.
3762
3763 * bgpd.c (config_write_neighbor): add ebgp-multihop command.
3764
37651997-12-29 Kunihiro Ishiguro <kunihiro@zebra.org>
3766
3767 * bgp_fsm.c: [-p bgp_port] and [-P vty_port] works
3768
37691997-12-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3770
3771 * bgp_vty.c: new file.
3772
3773 * bgp_attr.c: add new logging system.
3774
37751997-11-23 Kunihiro Ishiguro <kunihiro@zebra.org>
3776
3777 * Change all inet_addr call into inet_aton.
3778
37791997-11-10 Kunihiro Ishiguro <kunihiro@zebra.org>
3780
3781 * bgp_radix.c: change radix_peer_delete
3782
37831997-10-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3784
3785 * bgp_aspath.c: move AS_TOKEN_??? definition from header to c source.
3786
37871997-09-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3788
3789 * bgp_dump.c (bgp_log_route): add dump_attr function
3790
37911997-09-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3792
3793 * bgp_aspath.c (aspath_test): change AS_SET brace from '[' to '{'
3794 * bgp_dump.c (bgp_log_route): change logfile format.
3795
37961997-08-19 Kunihiro Ishiguro <kunihiro@zebra.org>
3797
3798 * bgp_open.c (bgp_open): move bgp_open function from bgpd.c
3799 * bgp_attr.c (community_str2com): add community value generation
3800 * bgp_attr.h: add SAFI definition for BGP-4+
3801
38021997-08-18 Kunihiro Ishiguro <kunihiro@zebra.org>
3803
3804 * bgpd.h: add BGP_OPEN_OPT_CAP for Capabilities Optional Parameter
3805 * Makefile.in: add bgp_open.o, delete bgp_loop.o
3806 * bgp_open.c: newfile which manages BGP Open message
3807 * bgp_loop.c: this file is merged with bgp_fsm.c
3808 * bgp_radix.c (radix_add): radix_add() now return route_t instead
3809 of int
3810 (bgp_sim): now we can read update & withdraw from file
3811 * bgp_route.c: add route_free() call into route_parse etc.
3812
38131997-08-17 Kunihiro Ishiguro <kunihiro@zebra.org>
3814
3815 * bgp_radix.c: Radix code is completely rewritten. It has better
3816 memory treatment than old one.
3817
38181997-08-14 Kunihiro Ishiguro <kunihiro@zebra.org>
3819
3820 * bgp_route.c: route_alloc for route struct allocation statistics.
3821 * bgpd.c (bgp_make_update): now we cann announce MED attribute.
3822 * bgp_aspath.c (aspath_print_all): change aspath_print_all output
3823 format.
3824
38251997-08-13 Kunihiro Ishiguro <kunihiro@zebra.org>
3826
3827 * bgp_term.c (term_parse): add command : show asstat, show ashash
3828 * bgp_aspath.c: aspath_cmp bug fix
3829 (aspath_print_all): add aspath_print_all ();
3830 * bgp_peer.h: delete rlist element from struct peer.
3831
38321997-08-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3833
3834 * bgp_aspath.c: completely rewritten.
3835 * bgp_aspath.h: completely rewritten.
3836 add AsPath, AsSegment structure
3837 add AS_SET treatment
3838 change Hash codes
3839
38401997-08-09 Kunihiro Ishiguro <kunihiro@zebra.org>
3841
3842 * bgp_attr.h: add Attribute flags defines
3843 * bgp_route.c: delete rlist related functions
3844 * bgp_aspath.c (as_origin): add as_origin function
3845 (aspath_print): move from bgp_dump.c and add support of AS_SET
3846 change Hash related function names.
3847
38481997-08-08 Kunihiro Ishiguro <kunihiro@zebra.org>
3849
3850 * bgp_aspath.h: add next entry, delete rlist entry from struct aspath
3851
38521997-08-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3853
3854 * bgp_aspath.c (as_sort): add function as_sort
3855 * bgp_aspath.h: add IBGP, EBGP
3856