blob: c1f12d67761ca9d08259c78200c88ea439938512 [file] [log] [blame]
Paul Jakma7e992e92007-11-13 09:32:23 +000012007-11-13 Paul Jakma <paul.jakma@sun.com>
2
3 * bgp_main.c: Small fix, format string parameters should never
4 be NULL - it's not strictly valid and some libc's don't let
5 you away with.
6
Paul Jakma3a02d1f2007-11-01 14:29:11 +000072007-10-30 Nick Hilliard <nick@inex.ie>
8
9 * bgp_main.c: Add 'listenon' argument, to pass address to bind
10 to.
11 * bgp_network.c: (bgp_socket) Extend to take bind address.
12 * bgpd.c: (bgp_init) Pass stored address.
13 * bgpd.h: (struct bgp_master) storage for bind address
14
Paul Jakma0b2aa3a2007-10-14 22:32:21 +0000152007-09-27 Paul Jakma <paul.jakma@sun.com>
16
17 * bgp_aspath.c: (assegment_normalise) remove duplicates from
18 from sets.
19 (aspath_reconcile_as4) disregard a broken part of the RFC around
20 error handling in path reconciliation.
21
222007-09-25 Paul Jakma <paul.jakma@sun.com>
23
24 * bgp_open.c: (peek_for_as4_capability) Fix to work.
25 * bgp_packet.c: (bgp_open_receive) Fix sanity check of as4.
26
272007-09-18 Paul Jakma <paul.jakma@sun.com>
28
29 * bgp_open.c: (bgp_capability_as4) debug printf inline with others.
30 (peek_for_as4_capability) There's no need to signal failure, as
31 failure is better dealt with through full capability parser -
32 just return the AS4, simpler.
33 * bgp_packet.c: (bgp_open_receive) Update to match
34 peek_for_as4_capability change.
35 Allow use of BGP_AS_TRANS by 2b speakers.
36 Use NOTIFY_OPEN_ERR rather than CEASE for OPEN parsing errors.
37 (bgp_capability_msg_parse) missing argument to debug print
38 (bgp_capability_receive) missing return values.
39
40
412007-07-25 Paul Jakma <paul.jakma@sun.com>
42
43 * Remove 2-byte size macros, just make existing macros take
44 argument to indicate which size to use.
45 Adjust all users - typically they want '1'.
46 * bgp_aspath.c: (aspath_has_as4) New, return 1 if there are any
47 as4's in a path.
48 (aspath_put) Return the number of bytes actually written, to
49 fix the bug Juergen noted: Splitting of segments will change
50 the number of bytes written from that already written to the
51 AS_PATH header.
52 (aspath_snmp_pathseg) Pass 2-byte flag to aspath_put. SNMP
53 is still defined as 2b.
54 (aspath_aggregate) fix latent bug.
55 (aspath_reconcile_as4) AS_PATH+NEW_AS_PATH reconciliation
56 function.
57 (aspath_key_make) Hash the AS_PATH string, rather than
58 just taking the addition of assegment ASes as the hash value,
59 hopefully sligthly more collision resistant.
60 (bgp_attr_munge_as4_attrs) Collide the NEW_ attributes
61 together with the OLD 2-byte forms, code Juergen
62 had in bgp_attr_parse but re-organised a bit.
63 (bgp_attr_parse) Bunch of code from Juergen moves
64 to previous function.
65 (bgp_packet_attribute) Compact significantly by
66 just /always/ using extended-length attr header.
67 Fix bug Juergen noted, by using aspath_put's
68 (new) returned size value for the attr header rather
69 than the (guesstimate) of aspath_size() - the two could
70 differ when aspath_put had to split large segments, unlikely
71 this bug was ever hit in the 'wild'.
72 (bgp_dump_routes_attr) Always use extended-len and
73 use aspath_put return for header length. Output 4b ASN
74 for AS_PATH and AGGREGATOR.
75 * bgp_ecommunity.c: (ecommunity_{hash_make,cmp}) fix
76 hash callback declarations to match prototypes.
77 (ecommunity_gettoken) Updated for ECOMMUNITY_ENCODE_AS4,
78 complete rewrite of Juergen's changes (no asdot support)
79 * bgp_open.c: (bgp_capability_as4) New, does what it says
80 on the tin.
81 (peek_for_as4_capability) Rewritten to use streams and
82 bgp_capability_as4.
83 * bgp_packet.c: (bgp_open_send) minor edit
84 checked (in the abstract at least) with Juergen.
85 Changes are to be more accepting, e.g, allow AS_TRANS on
86 a 2-byte session.
87 * (general) Update all commands to use CMD_AS_RANGE.
88 * bgp_vty.c: (bgp_clear) Fix return vals to use CMD_..
89 Remove stuff replicated by VTY_GET_LONG
90 (bgp_clear_vty) Return bgp_clear directly to vty.
91
92
932007-07-25 Juergen Kammer <j.kammer@eurodata.de>
94
95 * (general) AS4 support.
96 * bgpd.h: as_t changes to 4-bytes.
97 * bgp_aspath.h: Add BGP_AS4_MAX and BGP_AS_TRANS defines.
98 * bgp_aspath.c: AS_VALUE_SIZE becomes 4-byte, AS16_VALUE_SIZE
99 added for 2-byte.
100 Add AS16 versions of length calc macros.
101 (aspath_count_numas) New, count number of ASes.
102 (aspath_has_as4) New, return 1 if there are any as4's in a
103 path.
104 (assegments_parse) Interpret assegment as 4 or 2 byte,
105 according to how the caller instructs us, with a new
106 argument.
107 (aspath_parse) Add use32bit argument to pass to
108 assegments_parse. Adjust all its callers to pass 1, unless
109 otherwise noted.
110 (assegment_data_put) Adjust to be able to write 2 or 4 byte
111 AS, according to new use32bit argument.
112 (aspath_put) Adjust to write 2 or 4.
113 (aspath_gettoken) Use a long for passed in asno.
114 * bgp_attr.c: (attr_str) Add BGP_ATTR_AS4_PATH and
115 BGP_ATTR_AS4_AGGREGATOR.
116 (bgp_attr_aspath) Call aspath_parse with right 2/4 arg, as
117 determined by received-capability flag.
118 (bgp_attr_aspath_check) New, code previously in attr_aspath
119 but moved to new func so it can be run after NEW_AS_PATH
120 reconciliation.
121 (bgp_attr_as4_path) New, handle NEW_AS_PATH.
122 (bgp_attr_aggregator) Adjust to cope with 2/4 byte ASes.
123 (bgp_attr_as4_aggregator) New, read NEW_AGGREGATOR.
124 (bgp_attr_parse) Add handoffs to previous parsers for the two
125 new AS4 NEW_ attributes.
126 Various checks added for NEW/OLD reconciliation.
127 (bgp_packet_attribute) Support 2/4 for AS_PATH and
128 AGGREGATOR, detect when NEW_ attrs need to be sent.
129 * bgp_debug.{c,h}: Add 'debug bgp as4'.
130 * bgp_dump.c: MRTv2 support, unconditionally enabled, which
131 supports AS4. Based on patches from Erik (RIPE?).
132 * bgp_ecommunity.c: (ecommunity_ecom2str) ECOMMUNITY_ENCODE_AS4
133 support.
134 * bgp_open.c: (peek_for_as4_capability) New, peek for AS4
135 capability prior to full capability parsing, so we know which
136 ASN to use for struct peer lookup.
137 (bgp_open_capability) Always send AS4 capability.
138 * bgp_packet.c: (bgp_open_send) AS4 handling for AS field
139 (bgp_open_receive) Peek for AS4 capability first, and figure
140 out which AS to believe.
141 * bgp_vty.c: (bgp_show_peer) Print AS4 cap
142
Paul Jakmae08286b2007-09-18 12:11:26 +00001432007-09-17 Paul Jakma <paul.jakma@sun.com>
144
145 * bgp_open.c: (bgp_capability_mp) We were setting
146 afc_nego[safi][safi] rather than afc_nego[afi][safi], thus
147 failling to announce any non-IPv4 prefixes. Remove the extra,
148 typo-ed character.
149
Paul Jakmab2ceea12007-09-07 14:24:55 +00001502007-09-07 Paul Jakma <paul.jakma@sun.com>
151
152 * (general) bgpd can be made crash by remote peers if debug
153 bgp updates is set, due to NULL pointer dereference.
154 Reported by "Mu Security Research Team",
155 <security@musecurity.com>.
156 * bgp_attr.c: (bgp_attr_community) If community length is 0,
157 don't set the community-present attribute bit, just return
158 early.
159 * bgp_debug.c: (community_str,community_com2str) Check com
160 pointer before dereferencing.
161
Paul Jakma9eda90c2007-08-30 13:36:17 +00001622007-08-27 Paul Jakma <paul.jakma@sun.com>
163
164 * bgp_route.c: (bgp_announce_check) Fix bug #398, slight
165 modification of Vladimir Ivanov's suggested fix - to keep
166 memory alloc conditional.
167 (bgp_process_announce_selected) Don't take struct attr as
168 argument, none of the callers need it and it needlessly
169 distances allocation from use.
170 Free the extended attr, the attr itself is on the stack.
171 Fix bad indentation.
172 * bgp_attr.c: (bgp_packet_attribute) Remove incorrect assert,
173 and adjust conditional to test attr->extra, diagnosis by
174 Vladimir Ivanov in bug #398.
175
1762007-08-27 Vladimir Ivanov <wawa@yandex-team.ru>
177
178 * bgp_route.c: (bgp_announce_check_rsclient) copy of
179 ri->attr is no longer deep enough, due to addition of
180 attr->extra. It should use bgp_attr_dup, as
181 bgp_announce_check() does.
182
Paul Jakma6d134fb2007-08-23 23:22:02 +00001832007-08-23 Paul Jakma <paul.jakma@sun.com>
184
185 * bgp_regex.c: (bgp_regcomp) Pass NOSUB flag to regcomp to
186 prevent parsing of substitutions, which can have profound
187 performance effects on bgpd and are of no use to the CLI
188 anyway. How much it helps depends on the regex
189 implementation.
190
Paul Jakma41367172007-08-06 15:24:51 +00001912007-07-31 Paul Jakma <paul.jakma@sun.com>
192
193 * (general) Support for draft-ietf-idr-as-pathlimit-03.
194 * bgp_attr.h: (struct attr) Add pathlimit struct
195 bgp_attr.c: (attr_str) Add BGP_ATTR_AS_PATHLIMIT string.
196 (attrhash_key_make) tally pathlimit too
197 (attrhash_cmp) cmp pathlimit attr
198 (bgp_attr_aspathlimit) New, parse AS_PATHLIMIT attr.
199 (bgp_attr_parse) ditto
200 (bgp_packet_attribute) Write out AS_PATHLIMIT when set
201 (bgp_dump_routes_attr) ditto
202 * bgp_route.h: (struct bgp_static) Add TTL field
203 * bgp_route.c: (bgp_announce_check) Drop paths that are over
204 their hop-count TTL before sending via EBGP.
205 Mangle ASN in pathlimit for confeds/private as best we can.
206 (bgp_static_update_{rsclient,main}) Add any configure pathlimit
207 information.
208 (bgp_pathlimit_update_parents) New, update atomic-aggr setting for
209 parents of an aspathlimit'ed static.
210 (bgp_static_set) Add TTL argument, for all the 'bgp network'
211 commands.
212 Call previous for TTL changed statics.
213 (bgp_static_unset) Call pathlimit_update_parents.
214 (various bgp network commands) Add 'pathlimit <0-255>' qualifier
215 to all the various forms, bar route-map - which can set ttl
216 itself.
217 * bgp_routemap.c: (general) Add support for 'set pathlimit ttl' and
218 'match pathlimit as'.
219
Paul Jakma6d582722007-08-06 15:21:45 +00002202007-07-26 Paul Jakma <paul.jakma@sun.com>
221
222 * (general) Clean up and compact capability parsing slightly.
223 Consolidate validation of length and logging of generic TLV, and
224 memcpy of capability data, thus removing such from cap specifc
225 code (not always present or correct).
226 * bgp_open.h: Add structures for the generic capability TLV header
227 and for the data formats of the various specific capabilities we
228 support. Hence remove the badly named, or else misdefined, struct
229 capability.
230 * bgp_open.c: (bgp_capability_vty_out) Use struct capability_mp_data.
231 Do the length checks *before* memcpy()'ing based on that length
232 (stored capability - should have been validated anyway on input,
233 but..).
234 (bgp_afi_safi_valid_indices) new function to validate (afi,safi)
235 which is about to be used as index into arrays, consolidates
236 several instances of same, at least one of which appeared to be
237 incomplete..
238 (bgp_capability_mp) Much condensed.
239 (bgp_capability_orf_entry) New, process one ORF entry
240 (bgp_capability_orf) Condensed. Fixed to process all ORF entries.
241 (bgp_capability_restart) Condensed, and fixed to use a
242 cap-specific type, rather than abusing capability_mp.
243 (struct message capcode_str) added to aid generic logging.
244 (size_t cap_minsizes[]) added to aid generic validation of
245 capability length field.
246 (bgp_capability_parse) Generic logging and validation of TLV
247 consolidated here. Code compacted as much as possible.
248 * bgp_packet.c: (bgp_open_receive) Capability parsers now use
249 streams, so no more need here to manually fudge the input stream
250 getp.
251 (bgp_capability_msg_parse) use struct capability_mp_data. Validate
252 lengths /before/ memcpy. Use bgp_afi_safi_valid_indices.
253 (bgp_capability_receive) Exported for use by test harness.
254 * bgp_vty.c: (bgp_show_summary) fix conversion warning
255 (bgp_show_peer) ditto
256 * bgp_debug.h: Fix storage 'extern' after type 'const'.
257
Paul Jakma45ad5922007-07-31 17:35:36 +00002582007-07-31 Lorenzo Colitti <lorenzo@colitti.com>
259
260 * bgp_dump.c: (general) Add comments to code.
261 (bgp_dump_interval_add) remove some redundant lines.
262 (bgp_dump_set) Use enum for type argument.
263 Avoid scheduling dump twice if exact same command
264 is given twice..
265
Paul Jakma536792c2007-06-22 19:11:14 +00002662007-06-22 Paul Jakma <paul.jakma@sun.com>
267
268 * bgp_fsm.c: (struct FSM) Bug #368. TCP Errors during OpenSent
269 should cycle to Active, not to Idle or else peer bringup can
270 race and cycle Idle<->Active. Reported and fix tested by
271 Mukesh Agrawal.
272
Paul Jakmab2497022007-06-14 11:17:58 +00002732007-05-25 Paul Jakma <paul.jakma@sun.com>
274
275 * bgp_route.c: (bgp_default_originate) Sanity check added
276 previously was broken and always failed, thus this function
277 never could run, bug #370.
278
Paul Jakmafb982c22007-05-04 20:15:47 +00002792007-05-03 Paul Jakma <paul.jakma@sun.com>
Paul Jakma923de652007-04-29 18:25:17 +0000280
Paul Jakmafb982c22007-05-04 20:15:47 +0000281 * bgp_route.h: (struct info) Move less frequently used
282 fields to a lazily allocated struct info_extra.
283 Export bgp_info_extra_get
284 * bgp_route.c: (bgp_info_extra_new) allocate extra
285 (bgp_info_extra_free) Free damp info and the info_extra.
286 (bgp_info_extra_get) Retrieve the info_extra of a struct
287 info, allocating as required.
288 (generally) adjust to use info->extra
289 * bgp_damp.c: (generally) use bgp_info_extra_get to access
290 dampinfo
291 * bgp_attr.h: Move rarely allocated attributes from struct attr
292 to a struct attr_extra, for a substantial saving in size of
293 struct attr.
294 * bgp_attr.c: (bgp_attr_extra_{new,free}), new, self-explanatory.
295 (bgp_attr_extra_get) Get the attr_extra for a given struct
296 attr, allocating it if needs be.
297 (bgp_attr_dup) Shallow copy the struct attr and its attr_extra.
298 (generally) adjust to know about attr->extra.
299 * bgp_debug.c: (bgp_dump_attr) ditto
300 * bgp_vty.c: (show_bgp_memory) print attr and info extra sizes.
301 * bgp_nexthop.c: (generally) adjust to know about attr->extra
302 and info->extra.
303 * bgp_{packet,routemap,snmp,zebra}.c: ditto
304
3052007-04-22 Sebastien Tandel <sebastien@tandel.be>
Paul Jakma923de652007-04-29 18:25:17 +0000306 * bgp_advertise.c : (baa_hash_alloc, baa_hash_key, baa_hash_cmp)
307 conforms to quagga hash API. Defines _hash_[alloc|key|cmp] with
308 void * arguments as defined by the API.
309 * bgp_aspath.c,h : (aspath_key_make) conforms to quagga hash API.
310 Defines _hash_[alloc|key|cmp] with void * arguments as defined by
311 the API.
312 * bgp_attr.c,h : (cluster_hash_alloc, cluster_hash_key_make,
313 cluster_hash_cmp, transit_hash_alloc, transit_hash_key_make,
314 transit_hash_cmp, attrhash_key_make, attrhash_cmp,
315 bgp_attr_hash_alloc) conforms to quagga hash API. Defines
316 _hash_[alloc|key|cmp] with void * arguments as defined by the API.
Paul Jakma03e214c2007-04-29 18:31:07 +0000317 * bgp_attr.h : Definition of BGP_ATTR_DEFAULT_WEIGHT.
318 * bgp_attr.c : (bgp_attr_default_intern) now uses
319 bgp_attr_default_set instead of duplicating the same code.
320 (general) Use of BGP_ATTR_DEFAULT_WEIGHT. Replace two 16 by
321 IPV6_MAX_BYTELEN.
Paul Jakma923de652007-04-29 18:25:17 +0000322
Andrew J. Schorr93c17492007-04-15 19:17:24 +00003232007-04-15 Sebastien Tandel <sebastien@tandel.be>
324
325 * bgp_aspath.c: (aspath_as_add, aspath_segment_add) Minor performance
326 optimization: while loop should test one pointer instead of two.
327
Paul Jakma16d2e242007-04-10 19:32:10 +00003282007-04-08 Paul Jakma <paul.jakma@sun.com>
329
330 * bgp_route.c: (general) Same bug as fixed on 2006-11-28 by ajs for
331 bgp static routes, but for main BGP RIB: Quick 'flap' of routes
332 can cause bgpd to mistake a new route for a duplicate route,
333 due to presence of removed, but not yet processed BGP RIB entry.
334 (bgp_update_rsclient) Ignore REMOVED bgp_info for duplicate,
335 restore route instead.
336 (bgp_update_main) Ditto.
Paul Jakma6e4ab122007-04-10 19:36:48 +0000337 * bgp_attr.c: (general) Bug #354: parsing of MP_REACH_NLRI and
338 MP_UNREACH_NLRI does not take sufficient care to ensure reads
339 from stream buffer stay in-bounds. Hence bgpd may attempt to read
340 beyond end of stream, if given a crafted packet. As it uses the
341 stream access methods to do so, this will typically result in
342 assert() being hit in stream.c. Where code is compiled without
343 assert() enabled, result is unknown.
344 (struct message attr_str) should be static.
345 (bgp_mp_reach_parse) Carefully check length remaining in stream
346 against amount desired to read from stream, prior to each read,
347 particularly where lengths are conditional on data obtained from
348 stream - using STREAM_READABLE.
349 Remove code to parse SNPA-number, it's a defunct field and changed
350 to a fixed size in latest BGP MP update RFC - log warning if
351 SNPA-number is not 0.
352 (bgp_mp_unreach_parse) Check withdraw_length carefully against
353 STREAM_READABLE.
354 (bgp_attr_parse) If attribute-parser function returns error, log
355 warning.
356 Log attribute type on mismatch.
Paul Jakma16d2e242007-04-10 19:32:10 +0000357
Paul Jakma37a217a2007-04-10 19:20:29 +00003582007-04-07 Paul Jakma <paul.jakma@sun.com>
359
360 * bgpd.c: (general) Fix bug #352
361 (bgp_config_write_family_header) write ipv6/multicast
362 address family header.
363 (bgp_config_write) write out ipv6 multicast AF config.
364
Paul Jakmaf2c31ac2007-02-22 17:48:42 +00003652007-02-22 Paul Jakma <paul.jakma@sun.com>
366
367 * bgp_fsm.c: (bgp_fsm_change_status) Handle state change into
368 clearing or greater here. Simpler.
369 (bgp_event) Clearing state change work moved to previous
370 * bgp_route.c: (bgp_clear_route_node) Clearing adj-in here
371 is too late, as it leaves a race between a peer being deleted
372 and an identical peer being configured before clearing
373 completes, leading to a crash.
374 Simplest fix is to clean peers Adj-in up-front, rather than
375 queueing such work.
376 (bgp_clear_route_table) Clear peer's Adj-In and Adj-Out
377 up-front here, rather than queueing such work.
378 Extensive comment added on the various bits of indexed data
379 that exist and how they need to be dealt with.
380 (bgp_clear_route) Update comment.
381
Andrew J. Schorre4529632006-12-12 19:18:21 +00003822006-12-12 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
383
384 * bgp_nexthop.c: (bgp_connected_add, bgp_connected_delete)
385 Simplify logic by using new CONNECTED_PREFIX macro.
386
Paul Jakma95fdcd82006-12-08 00:31:22 +00003872006-12-07 Paul Jakma <paul.jakma@sun.com>
388
389 * bgp_fsm.c: Bug #302 fix, diagnosis, suggestions and testing
390 by Juergen Kammer <j.kammer@eurodata.de>. Fix follows from
391 his suggested fix, just made in a slightly different way.
392 (bgp_event) Transitions into Clearing always must call
393 bgp_clear_route_all().
394 (bgp_stop) No need to clear routes here, BGP FSM should do
395 it.
396
Andrew J. Schorra39275d2006-11-30 16:36:57 +00003972006-11-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
398
399 * bgp_debug.h: Declare new bgp_debug_zebra conf and term flags,
400 and define BGP_DEBUG_ZEBRA.
401 * bgp_debug.c: Declare conf_bgp_debug_zebra and term_bgp_debug_zebra.
402 (debug_bgp_zebra, no_debug_bgp_zebra, undebug_bgp_zebra) New
403 functions to enable/disable bgp zebra debugging.
404 (no_debug_bgp_all) Turn off zebra debugging.
405 (show_debugging_bgp) Show whether zebra debugging is on.
406 (bgp_config_write_debug) Add 'debug bgp zebra' if configured.
407 (bgp_debug_init) Add new zebra debugging commands.
408 * bgp_zebra.c: (bgp_router_id_update, bgp_interface_add,
409 bgp_interface_delete, bgp_interface_up, bgp_interface_down,
410 bgp_interface_address_add, bgp_interface_address_delete,
411 zebra_read_ipv4, zebra_read_ipv6, bgp_zebra_announce,
412 bgp_zebra_withdraw, bgp_redistribute_set, bgp_redistribute_unset)
413 If zebra debugging is enabled, log an appropriate debug message.
414
Andrew J. Schorr8d452102006-11-28 19:50:46 +00004152006-11-28 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
416
417 * bgp_route.c: (bgp_info_restore) New function that undoes
418 the effects of a previous call to bgp_info_delete. This is
419 used when a route is deleted and quickly re-added before the
420 deletion has been processed.
421 (bgp_static_update_rsclient, bgp_static_update_main,
422 bgp_redistribute_add) Check whether a pre-existing route
423 has the BGP_INFO_REMOVED set, and, if so, we need to call
424 bgp_info_restore to resurrect it.
425
Paul Jakma56395af2006-10-27 16:58:20 +00004262006-10-27 Paul Jakma <paul.jakma@sun.com>
427
428 * bgp_route.c: (bgp_table_stats) oops, u_intXX_t should be
429 uintXX_t
430
Paul Jakma6f585442006-10-22 19:13:07 +00004312006-10-19 Paul Jakma <paul.jakma@sun.com>
432
433 * bgpd.c: (peer_new) bgp element of peer absolutely must be
434 filled in, make peer_new() require it as argument and update
435 all callers. Fixes a crash reported by Jan 'yanek' Bortl and
436 Andrew Schorr where bgpd would crash in bgp_pcount_adjust
437 trying to dereference the bgp member of bgp->peer_self,
438 triggered through redistribution.
439 * bgp_route.c: (bgp_pcount_adjust) assert sanity of arguments.
440
Paul Jakma53d9f672006-10-15 23:41:16 +00004412006-10-15 Paul Jakma <paul.jakma@sun.com>
442
443 * bgp_route.c: (bgp_table_stats_walker) NULL deref if table is
444 empty, bgp_table_top may return NULL, Coverity CID#73.
Paul Jakmaed3ebfa2006-10-15 23:50:16 +0000445 * bgp_packet.c: (bgp_update_packet) adv->rn can not be NULL,
446 check is bogus - changed to assert(), CID#64.
447 binfo is checked for NULL, but then dereferenced
448 unconditionally, fix, CID #63.
449 (bgp_withdraw_packet) Assert adv->rn is valid, as with
450 bgp_update_packet().
Paul Jakma53d9f672006-10-15 23:41:16 +0000451
Paul Jakmadcdf3992006-10-15 23:39:59 +00004522006-10-14 Paul Jakma <paul.jakma@sun.com>
453
454 * bgp_fsm.h: Remove BGP_EVENT_FLUSH_ADD, dangerous and not
455 needed.
456 * bgp_fsm.c: (bgp_stop) Move BGP_EVENT_FLUSH to the top of the
457 of the function, otherwise it could flush a ClearingCompleted
458 event, bug #302.
459 * bgp_packet.c: Replace all BGP_EVENT_FLUSH_ADD with
460 BGP_EVENT_ADD, fixing bug #302.
461
Andrew J. Schorr0cd1c322006-09-19 18:51:53 +00004622006-09-19 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
463
464 * bgpd.c: (peer_uptime) Fix printf format/arg mismatch in
465 zlog_warn message (%ld/size_t -> %lu/u_long).
466
Paul Jakmaca058a32006-09-14 02:58:49 +00004672006-09-14 Paul Jakma <paul.jakma@sun.com>
468
Paul Jakma8383a9b2006-09-14 03:06:54 +0000469 * bgp_route.c: (bgp_table_stats_walker) Address space announced
470 should only count top-level unaggregateable prefixes, to
471 avoid falling afoul of anti-dodgy-accounting regulations
472 in various jurisdictions.. ;)
Paul Jakma09dd5612006-09-14 03:38:16 +0000473 (bgp_process_queue_init) process queue hold time too high,
474 adds extra memory load. Change to be much lower, until such
475 time as it's made configurable.
Paul Jakma8383a9b2006-09-14 03:06:54 +0000476
4772006-09-14 Paul Jakma <paul.jakma@sun.com>
478
Paul Jakma9fde6622006-09-14 03:02:02 +0000479 * (general) fix the peer refcount issue exposed by previous, by
480 just removing refcounting of peer threads, which is mostly
481 senseless as they're references leading from struct peer,
482 which peer_free cancels anyway. No need to muck around..
483 * bgp_fsm.h: Just remove the refcounting from the various
484 TIMER/READ/WRITE/EVENT ON/OFF/ADD macros.
485 * bgp_fsm.c: (bgp_stop) use BGP_EVENT_FLUSH, no refcounts attached
486 to events anymore.
487 (bgp_event) remove peer_unlock, events not refcounted.
488 * bgpd.c: (peer_free) flush events before free.
489
4902006-09-14 Paul Jakma <paul.jakma@sun.com>
491
Paul Jakmaca058a32006-09-14 02:58:49 +0000492 * (general) Fix some niggly issues around 'shutdown' and clearing
493 by adding a Clearing FSM wait-state and a hidden 'Deleted'
494 FSM state, to allow deleted peers to 'cool off' and hit 0
495 references. This introduces a slow memory leak of struct peer,
496 however that's more a testament to the fragility of the
497 reference counting than a bug in this patch, cleanup of
498 reference counting to fix this is to follow.
499 * bgpd.h: Add Clearing, Deleted states and Clearing_Completed
500 and event.
501 * bgp_debug.c: (bgp_status_msg[]) Add strings for Clearing and
502 Deleted.
503 * bgp_fsm.h: Don't allow timer/event threads to set anything
504 for Deleted peers.
505 * bgp_fsm.c: (bgp_timer_set) Add Clearing and Deleted. Deleted
506 needs to stop everything.
507 (bgp_stop) Remove explicit fsm_change_status call, the
508 general framework handles the transition.
509 (bgp_start) Log a warning if a start is attempted on a peer
510 that should stay down, trying to start a peer.
511 (struct .. FSM) Add Clearing_Completed
512 events, has little influence except when in state
513 Clearing to signal wait-state can end.
514 Add Clearing and Deleted states, former is a wait-state,
515 latter is a placeholder state to allow peers to disappear
516 quietly once refcounts settle.
517 (bgp_event) Try reduce verbosity of FSM state-change debug,
518 changes to same state are not interesting (Established->Established)
519 Allow NULL action functions in FSM.
520 * bgp_packet.c: (bgp_write) Use FSM events, rather than trying
521 to twiddle directly with FSM state behind the back of FSM.
522 (bgp_write_notify) ditto.
523 (bgp_read) Remove the vague ACCEPT_PEER peer_unlock, or else
524 this patch crashes, now it leaks instead.
525 * bgp_route.c: (bgp_clear_node_complete) Clearing_Completed
526 event, to end clearing.
527 (bgp_clear_route) See extensive comments.
528 * bgpd.c: (peer_free) should only be called while in Deleted,
529 peer refcounting controls when peer_free is called.
530 bgp_sync_delete should be here, not in peer_delete.
531 (peer_delete) Initiate delete.
532 Transition to Deleted state manually.
533 When removing peer from indices that provide visibility of it,
534 take great care to be idempotent wrt the reference counting
535 of struct peer through those indices.
536 Use bgp_timer_set, rather than replicating.
537 Call to bgp_sync_delete isn't appropriate here, sync can be
538 referenced while shutting down and finishing deletion.
539 (peer_group_bind) Take care to be idempotent wrt list references
540 indexing peers.
541
Paul Jakma2815e612006-09-14 02:56:07 +00005422006-09-13 Paul Jakma <paul.jakma@sun.com>
543
544 * bgp_aspath.c: (aspath_highest) new, return highest ASN in an
545 aspath.
546 * bgp_route.c: (bgp_peer_count_walker) new, do the walk done
547 in bgp_peer_counts as a thread.
548 (bgp_peer_counts) move walk to previous and call it via
549 thread_execute so this RIB walk shows up in thread stats.
550 (bgp_table_stats) New, gather some statistics for a given
551 RIB.
552 (bgp_table_stats_walker) New, RIB walker thread for former.
553 (bgp_table_stats_vty) Parsing front-end for 'show bgp ...',
554 useful model for future rationalisation of 'show ... bgp'.
555 (bgp_route_init) Add new RIB stats commands.
556
Paul Jakma1a392d42006-09-07 00:24:49 +00005572006-09-06 Paul Jakma <paul.jakma@sun.com>
558
559 * (general) Squash any and all prefix-count issues by
560 abstracting route flag changes, and maintaining count as and
561 when flags are modified (rather than relying on explicit
562 modifications of count being sprinkled in just the right
563 places throughout the code).
564 * bgp_route.c: (bgp_pcount_{dec,inc}rement) removed.
565 (bgp_pcount_adjust) new, update prefix count as
566 needed for a given route.
567 (bgp_info_{uns,s}et_flag) set/unset a BGP_INFO route status
568 flag, calling previous function when appropriate.
569 (general) Update all set/unsets of flags to use previous.
570 Remove pcount_{dec,inc}rement calls.
571 No need to unset BGP_INFO_VALID in places where
572 bgp_info_delete is called, it does that anyway.
573 * bgp_{damp,nexthop}.c: Update to use bgp_info_{un,}set_flag.
574 * bgp_route.h: Export bgp_info_{un,}set_flag.
575 Add a 'meta' BGP_INFO flag, BGP_INFO_UNUSEABLE.
576 Move BGP_INFO_HOLDDOWN macro to here from bgpd.h
577
Paul Jakmaff7924f2006-09-04 01:10:36 +00005782006-09-03 Paul Jakma <paul.jakma@sun.com>
579
580 * bgp_route.c: Add 'show ... bgp ... <neighbour> prefix-count'
581 commands, to provide detailed counts of prefixes for a peer.
582 Informative, and should help pin down to pfxcnt drift
583 problems.
584
Paul Jakma9f906c72006-08-27 06:57:47 +00005852006-08-27 Paul Jakma <paul.jakma@sun.com>
586
587 * bgp_advertise.c: (bgp_sync_delete) fix mtype in XFREE.
588 NULL out peer->hash after free, to be sure.
589
Paul Jakma1f742f22006-08-06 15:52:11 +00005902006-08-06 Paul Jakma <paul.jakma@sun.com>
591
592 * bgp_aspath.c: (aspath_loop_check) Fix the typo-bug which
593 essentially had disabled this check. Problem reported by
594 Bartek Kania <mrbk@gnarf.org> in [quagga-users 7388].
595
Paul Jakma18937402006-07-27 19:05:12 +00005962006-07-27 Paul Jakma <paul.jakma@sun.com>
597
598 * bgpd.c: (peer_delete) Ensure freed buffers can not be
599 accidently reused. A potential fix for bug #287.
600
Paul Jakma33d5ab92006-07-02 11:01:50 +00006012006-07-02 Paul Jakma <paul.jakma@sun.com>
602
603 * bgp_fsm.c: (bgp_{stop,start}) Move clear/free of certain
604 bits of state from stop to start, as they may be used via
605 peer references on clearing queues..
606
Paul Jakma369688c2006-05-23 22:27:55 +00006072006-05-23 Paul Jakma <paul.jakma@sun.com>
608
609 * bgp_vty.c: (neighbor_update_source_cmd) Expand tab completion
610 to make it clear it takes both address and ifname.
611
Paul Jakma34c3f812006-05-12 23:25:37 +00006122006-05-12 Paul Jakma <paul.jakma@sun.com>
613
614 * bgp_attr.c: (bgp_packet_attribute) Remove dead code, Coverity
615 CID #1
Paul Jakmab2518c12006-05-12 23:48:40 +0000616 * bgp_aspath.{c,h}: (aspath_print_vty) take a format string,
617 so as to reduce burden on callers, all in bgp_route.c
Paul Jakmadd8103a2006-05-12 23:27:30 +0000618 * bgp_route.c: (bgp_static_update_main) Remove useless NULL
619 check, code already assumes bgp_static can not be NULL,
620 fixes CID #7.
Paul Jakma06e110f2006-05-12 23:29:22 +0000621 (bgp_static_update_rsclient) ditto, CID #6
Paul Jakmab2518c12006-05-12 23:48:40 +0000622 (route_vty_out{,tmp}) Update to match aspath_print_vty,
623 simplifying checks needed to get spacing right. CID #4,#5.
624 ({damp,flap}_route_vty_out) Ditto, CID #9, #10
Paul Jakma34c3f812006-05-12 23:25:37 +0000625
Paul Jakma542bcb72006-05-08 14:25:09 +00006262006-05-08 Paul Jakma <paul.jakma@sun.com>
627
628 * bgp_community.c: (community_str2com) Coverity CID#62, fix
629 double-free, use-after-free.
Paul Jakmada5b30f2006-05-08 14:37:17 +0000630 * bgp_route.c: (bgp_afi_node_get) given table should never be
631 NULL, check/assert this.
632 (bgp_static_update) Bug #240. Rsclients should only be passed
633 the static update if they are configured for the afi,safi.
Paul Jakma542bcb72006-05-08 14:25:09 +0000634
Paul Jakmaa3b6ea52006-05-04 07:52:12 +00006352006-05-04 Paul Jakma <paul.jakma@sun.com>
636
637 * (general) VPNv4 fixes. Certain VPNv4 code was not enabled.
638 See bug #210.
639 * bgp_attr.{c,h}: (bgp_packet_{withdraw,attribute}) Tag should be
640 u_char really.
641 * bgp_packet.c: (bgp_{update,withdraw}_packet) Enable some
642 VPNv4 code which inexplicably was ifdef'd out. comments from
643 a tester on IRC suggest this fixes bug #210.
Paul Jakma65ca75e2006-05-04 08:08:15 +0000644 * bgp_route.c: (general) Fix logical bug in clearing, noted
645 by Chris Caputo in [quagga-users 6728] - clearing depended on
646 at least one route being added to workqueue, in order for
647 workqueue completion function to restart FSM. However, if no
648 routes are cleared, then the completion function never is
649 called, it needs to be called manually if the workqueue
650 didn't get scheduled.
651 Finally, clearing is per-peer-session, not per AFI/SAFI, so
652 the FSM synchronisation should be in bgp_clear_route_table.
653 (bgp_clear_route_table) Wrong place for FSM/clearing
654 synchronisation, move to..
655 (bgp_clear_route) FSM/clearing synchronisation should be
656 here.
657 If no routes were cleared, no workqueue scheduled, call
658 the completion func to ensure FSM kicks off again.
Paul Jakmaa3b6ea52006-05-04 07:52:12 +0000659
Paul Jakma15aa6a12006-03-30 14:39:35 +00006602006-03-30 Paul Jakma <paul.jakma@sun.com>
661
662 * bgp_community.c: (community_gettoken) Unknown token should
663 return NULL, to give a strong indication to callers that
664 the token no longer can be parsed, otherwise callers looping
665 on this function may have a hard time ending their loop.
666 (community_str2com) While loop around community_gettoken appears
667 to have been coded thinking that break statement would break
668 from the while{}, hence it could never exit for unknown token
669 case. Fix it to do..while, so it can use the NULL result from
670 community_gettoken easily.
671
Paul Jakmaa625ca32006-03-30 14:12:38 +00006722006-03-22 Paul Jakma <paul.jakma@sun.com>
673
674 * bgpd.c: (peer_free) release the per-peer workqueue when
675 freeing the peer.
676
Paul Jakma5304cb52006-03-30 14:01:14 +00006772006-03-19 Paul Jakma <paul.jakma@sun.com>
678
Paul Jakma4bf6a362006-03-30 14:05:23 +0000679 * bgpd/bgp_vty.c: Add includes to get several structs we want
680 to provide usage statistics on.
681 (show_bgp_memory_cmd) Show memory usage stats for various
682 notable fixed size objects. Using mtype_stats_alloc and
683 mtype_memstr recently added to memory.c.
684 (bgp_show_summary) Report some additional stats specific to
685 the given BGP instance and/or AFI/SAFI such as table counts,
686 peers, rsclients and peer-groups.
687 (bgp_vty_init) Install show_bgp_memory_cmd.
Paul Jakma5304cb52006-03-30 14:01:14 +0000688 * bgp_nexthop.h: Include if.h as a dependent header, for struct
689 connected.
Paul Jakmab51f1262006-03-30 14:09:38 +0000690 * bgp_advertise.c: Use a distinct memory type for struct
691 bgp_synchronize.
Paul Jakma5304cb52006-03-30 14:01:14 +0000692
Paul Jakmacbdfbaa2006-03-30 13:20:48 +00006932006-03-12 Paul Jakma <paul.jakma@sun.com>
694
695 * bgp_attr.h: (struct attr) rearrange fields to avoid
696 wasted padding between them as much as possible.
697 (attr_count,attr_unknown_count) export new functions to
698 return number of counts of cached attributes.
699 * bgp_attr.c: (attr_count,attr_unknown_count) new functions to
700 return number of counts of cached attributes.
701 * bgp_route.h: (struct bgp_info) rearrange fields to avoid
702 wasted padding.
703 * bgp_table.h: (struct bgp_table) Add a count field, of number
704 of nodes in the table.
705 (struct bgp_node) rearrange fields to avoid
706 wasted padding between them, though I don't think there
707 was any in this case.
708 * bgp_table.c: (bgp_node_{delete,get}) Maintain the table node count.
709 (bgp_table_count) new function to access the table count.
710
Paul Jakma3e0c78e2006-03-06 18:06:53 +00007112006-03-03 Paul Jakma <paul.jakma@sun.com>
712
713 * bgp_route.c: (bgp_clear_node_complete) Doh. When clearing
714 is complete we need to kick off FSM again.
715
Paul Jakma64e580a2006-02-21 01:09:01 +00007162006-02-21 Paul Jakma <paul.jakma@sun.com>
717
718 * bgpd.h: move the clear_node_queue to be peer specific.
719 Add a new peer status flag, PEER_STATUS_CLEARING.
720 * bgp_table.h: (struct bgp_table) Add fields to record afi,
721 safi of the table.
722 (bgp_table_init) Take afi and safi to create table for.
723 * bgp_table.c: (bgp_table_init) record the afi and safi.
724 * bgp_nexthop.c: Update all calls to bgp_table_init.
725 * bgp_vty.c: ditto.
726 * bgpd.c: ditto.
727 * bgp_fsm.c: (bgp_timer_set) dont bring up a session which is
728 clearing.
729 * bgp_route.c: (general) Update all bgp_table_init calls.
730 (bgp_process_{rsclient,main}) clear_node is serialised
731 via PEER_STATUS_CLEARING and fsm now.
732 (struct bgp_clear_node_queue) can be removed. struct bgp_node
733 can be the queue item data directly, as struct peer can be
734 kept in the new wq global user data and afi/safi can be
735 retrieved via bgp_node -> bgp_table.
736 (bgp_clear_route_node) fix to get peer via wq->spec.data,
737 afi/safi via bgp_node->bgp_table.
738 (bgp_clear_node_queue_del) no more item data to delete, only
739 unlock the bgp_node.
740 (bgp_clear_node_complete) only need to unset CLEARING flag
741 and unlock struct peer.
742 (bgp_clear_node_queue_init) queue attaches to struct peer
743 now. record peer name as queue name.
744 (bgp_clear_route_table) If queue transitions to active,
745 serialise clearing by setting PEER_STATUS_CLEARING rather
746 than plugging process queue, and lock peer while queue
747 active.
748 Update to pass only bgp_node as per-queue-item specific data.
Paul Jakma6a419732006-02-21 01:14:13 +0000749 * bgp_vty.c: (bgp_show_summary) Add a 'Clrng' sub-description
750 to state of peer while it's suppressed due to clearing.
Paul Jakma64e580a2006-02-21 01:09:01 +0000751
Paul Jakmaaa94ca82006-02-18 10:49:04 +00007522006-02-18 Paul Jakma <paul.jakma@sun.com>
753
754 * bgp_routemap.c: (route_set_community) Quick, very hacky, fix
755 for the set-community leak, bug #89. True fix will be to
756 detangle the web of *_intern caching and provide saner object
757 caching for Quagga, future work.
Paul Jakma7c7fa1b2006-02-18 10:52:09 +0000758 * bgp_route.c: (bgp_announce_check) trivial, move declaration
759 of two local variables into the only block where they are
760 used, to aid the reader.
Paul Jakmaaa94ca82006-02-18 10:49:04 +0000761
paul902212c2006-02-05 17:51:19 +00007622006-02-05 Paul Jakma <paul.jakma@sun.com>
763
764 * bgp_route.h: Add BGP_INFO_COUNTED to track whether
765 prefix has been counted or not.
766 * bgp_route.c: (bgp_pcount_{inc,dec}rement) new helpers, to
767 centralise inc/dec of prefix-count,
768 (bgp_rib_remove) Remove pcount decrement, use helper.
769 (bgp_rib_withdraw) ditto, additionally use previous function
770 too.
771 (bgp_update_main) Use pcount helpers.
772 (bgp_clear_route_node) ditto, aslo REMOVED routes don't need
773 clearing.
paul3fff6ff2006-02-05 17:55:35 +0000774 * bgp_aspath.c: (aspath_gettoken) fix gcc warning about
775 possible uninitialised usage.
paul902212c2006-02-05 17:51:19 +0000776
paul306d8892006-02-02 17:50:19 +00007772006-02-02 Paul Jakma <paul.jakma@sun.com>
778
779 * bgp_route.c: (bgp_{clear_node,process}_queue_init) delay
780 field is removed from workqueue spec.
781
paule8e19462006-01-19 20:16:55 +00007822006-01-19 Paul Jakma <paul.jakma@sun.com>
783
784 * (general) various miscellaneous compiler warning fixes.
785 Remove redundant break statements from switch clauses
786 which return.
787 return from main, not exit, cause it annoys SOS.
788 Remove stray semi-colons which cause empty-statement
789 warnings.
790
pauld3092e72006-01-17 17:33:46 +00007912006-01-17 Paul Jakma <paul.jakma@sun.com>
792
793 * bgp_nexthop.c: (zlookup_read*) convert to new Zserv format.
794 (zlookup_query_ipv6) ditto.
795 (bgp_import_check) ditto.
796
paul02335422006-01-16 11:13:27 +00007972006-01-16 Paul Jakma <paul.jakma@sun.com>
798
799 * bgp_aspath.c: (assegment_append_asns) XREALLOC can return
800 NULL theoretically, take care not to lose the allocated data.
801 (aspath_hash_alloc) aspath_dup already set the aspath
802 string - fix leak.
803 (aspath_parse) aspath_hash_alloc dupes the entire aspath,
804 including segments, but we forgot to free the temporary
805 assegment.
paul8fdc32a2006-01-16 12:01:29 +0000806 (aspath_snmp_pathseg) move the static stream pointer out to
807 file scope, so it can be freed.
808 (aspath_finish) new function, free aspath resources.
809 * bgp_aspath.h: (aspath_finish) export.
paul02335422006-01-16 11:13:27 +0000810
paul37c38302006-01-10 22:15:45 +00008112006-01-10 Juris Kalnins <juris@mt.lv>
812
813 * bgpd.h: (bgp_router_id_unset) ex-function, remove.
814
paulad727402005-11-23 02:47:02 +00008152005-11-23 Paul Jakma <paul.jakma@sun.com>
816
817 * bgp_aspath.c: (assegments_parse) should be static
818
8192005-11-23 Juergen Kammer <j.kammer@eurodata.de>
820
821 * bgp_aspath.c: (aspath_cmp_left_confed) fix SEGV for case
822 where one or both paths are empty.
823
paul0fb58d52005-11-14 14:31:49 +00008242005-11-14 Paul Jakma <paul.jakma@sun.com>
825
826 * bgp_route.c: (bgp_process_rsclient) convert to new workqueue
827 specs and shut up gcc, which complains about cast from void
828 via function parameters, for some dumb reason. Do the cast
829 inside the function instead.
830 (bgp_process_main,bgp_processq_del) ditto.
831 (bgp_clear_route_node) ditto.
832 (bgp_clear_node_queue_del) ditto.
833
paul41200852005-11-03 12:52:18 +00008342005-11-03 Paul Jakma <paul.jakma@sun.com>
835
836 * bgp_damp.c: (bgp_reuse_timer) struct bgp can be retrieved via
837 the struct bgp_damp_info, no need to guess by using
838 bgp_get_default().
839
ajsf52d13c2005-10-01 17:38:06 +00008402005-10-01 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
841
842 * bgp_vty.c: (bgp_config_write_redistribute) Use new library function
843 zebra_route_string instead of a local hard-coded table.
844
jardin2d74db52005-10-01 00:07:50 +00008452005-09-30 Vincent Jardin <vincent.jardin@6wind.com>
846
847 * bgp_packet.c: fix compilation when DEBUG is used.
848
paul1f8ae702005-09-09 23:49:49 +00008492005-09-10 Paul Jakma <paul.jakma@sun.com>
850
paulfe69a502005-09-10 16:55:02 +0000851 * Makefile.am: bgpd shouldn't list libgp's sources as its own.
852 Use LDADD.
853 * bgp_aspath.h:
854 (struct assegment) New struct, abstract representation of a
855 list of AS_PATH segments and the contained ASNs.
856 (struct aspath) Remove the raw-data related
857 fields, reference the abstract struct assegment instead.
858 Remove several other computed fields, it's just a
859 headache to maintain them and they're cheap to compute from
860 struct assegment.
861 (aspath_parse) parse a stream, not a pointer to raw data.
862 (aspath_count_{hops,confeds,size}) helpers to access
863 information formerly directly contained in struct aspath.
864 (aspath_snmp_pathseg) Helper for SNMP, BGP MIB wants
865 to be able to output hex representation of raw data.
866 * bgp_aspath.c: (general) partial-rewrite. Store aspath data
867 as an abstract singly-linked list of abstract segments,
868 rather than storing the raw data, and parsing it each and
869 every time. Remove several count/size fields which are cheap
870 to compute from the abstract segment structure.
871 (global) Include stream.h, needed for aspath_parse, and
872 others. Couple of helper macros added.
873 (struct assegment_header) Just the header, and only the
874 header.
875 (assegment_data_{new,free}) convenience functions for
876 AS_SEG_DATA allocation, the dynamic, per-segment array of
877 ASNs.
878 (assegment_{new,free,free_all,dup,dup_all}) convenience
879 functions for creating struct assegments. The _all forms will
880 follow the entire chain of segments from the given segment.
881 (assegment_prepend_asns) new function, prepend an ASN N times
882 to segment.
883 (assegment_append_asns) Append a list (array) of ASNs to
884 segment.
885 (int_cmp) convenience function for the aspath hash.
886 (assegment_normalise) new function. Normalise the given
887 segment chain to meet expectations of Quagga, and to
888 eliminate differing raw representations of the same paths.
889 Merge 'runs' of SEQUENCEs into one segment as our internal
890 segment is not limited by the protocol AS_PATH segment
891 length. Sort ASNs in SETs.
892 (aspath_new) Take void argument to quell warnings. Use the
893 assegment convenience functions.
894 (assegment_count_{asns,confeds,hops}) new functions to
895 compute at runtime values previously held in struct aspath.
896 (aspath_size) ditto.
897 (aspath_make_str_count) rewritten to stringify new
898 representation, and to be slightly easier to understand
899 hopefully.
900 (aspath_str_update) convenience function, update the aspath
901 str. Should investigate removing maintained string from
902 struct aspath, just run-time compute it, as per other fields.
903 It's just a maintenance headache, would save noticeable
904 amount of RAM with possibly not much extra run-time cost.
905 (aspath_dup) use the assegment dup functions.
906 (aspath_hash_alloc) Take void * argument to satisfy gcc. Use
907 the proper helper functions to dup data.
908 (assegments_parse) new function. parse raw AS_PATH data into
909 struct assegments. Normalise and return the head of the list.
910 (aspath_parse) Parse a stream, not pointer to raw data and
911 use assegments_parse to do it.
912 (assegment_data_put) Write out a single segment data in protocol
913 form to stream.
914 (assegment_header_put) ditto but for segment header.
915 (aspath_put) new function. As per previous but for an entire
916 struct aspath.
917 (aspath_snmp_pathseg) wrapper around aspath_put for
918 bgp_snmp.c. Uses a static buffer sadly.
919 (aspath_aggregate_as_set_add) rewritten to use assegments.
920 (aspath_aggregate) ditto
921 (aspath_{firstas,loop,private_as}_check) ditto
922 (aspath_{merge,prepend,add_one_as}) ditto
923 (aspath_cmp_left{_confed}) ditto
924 (aspath_delete_confed_seq) ditto, plus fixed to properly
925 delete all leading confed segments.
926 (aspath_as_add) Just use assegment_append_asns.
927 (aspath_segment_add) updated to use assegments.
928 (enum as_token) Add values for confeds
929 (aspath_gettoken) Add support for confeds
930 (aspath_str2aspath) ditto
931 (aspath_key_make) updated to use as_segments. Also, add
932 segment type into the hash value as appropriate.
933 (aspath_cmp) updated to use as_segments.
934 (aspath_print) don't segfault on NULL argument.
935 * bgp_attr.c: (bgp_attr_aspath) aspath_parse wants the stream
936 now. No need for manual forwarding of stream.
937 (bgp_packet_attribute) empty aspath is now denoted by NULL
938 segment field, length is gone.
939 Use aspath_size() to determine size.
940 (bgp_attr_init) Fix declaration, explicitely specify void
941 arg.
942 (bgp_dump_routes_attr) Use aspath_size() to determine size.
943 * bgp_route.c: (bgp_info_cmp) use the aspath_count_* functions.
944 (bgp_rib_withdraw) remove unused variable. Use
945 aspath_count_hops.
946 * bgp_snmp.c: (bgp4PathAttrTable) raw data is gone, use
947 aspath_snmp_pathseg to get the representation.
948
9492005-09-10 Paul Jakma <paul.jakma@sun.com>
950
paul1f8ae702005-09-09 23:49:49 +0000951 * bgp_vty.c: (bgp_vty_init) gcc 4 compile fix. static
952 function declarations shouldn't be inside functions.
953 * bgp_dump.c: (bgp_dump_interval_add) ditto.
954
hassob7395792005-08-26 12:58:38 +00009552005-08-26 Hasso Tepper <hasso at quagga.net>
956
957 * bgp_route.c: Third (?) attempt to fix best selection breakage
958 introduced long time ago with route server patch. Hopefully
959 it's last case to fix - route-server client not in peer group.
960
paul25ffbdc2005-08-22 22:42:08 +00009612005-08-22 Hugo Santos <hsantos@av.it.pt>
962
963 * bgp_vty.c: (general) Add support for BGP IPv6 Multicast SAFI
964 commands and BGP_IPV6M_NODE.
965
paulb40d9392005-08-22 22:34:41 +00009662005-08-22 Paul Jakma <paul.jakma@sun.com>
967
968 * bgp_route.h: (struct bgp_info) add a new flag, BGP_INFO_REMOVED.
969 BGP_INFO_VALID is already overloaded, don't care to do same thing
970 to STALE or HISTORY.
971 * bgpd.h: (BGP_INFO_HOLDDOWN) Add INFO_REMOVED to the macro, as a
972 route which should generally be ignored.
973 * bgp_route.c: (bgp_info_delete) Just set the REMOVE flag, rather
974 than doing actual work, so that bgp_process (called directly,
975 or indirectly via the scanner) can catch withdrawn routes.
976 (bgp_info_reap) Actually remove the route, what bgp_info_delete
977 used to do, only for use by bgp_process.
978 (bgp_best_selection) reap any REMOVED routes, other than the old
979 selected route.
980 (bgp_process_rsclient) reap the old-selected route, if appropriate
981 (bgp_process_main) ditto
982 (bgp_rib_withdraw, bgp_rib_remove) make them more consistent with
983 each other. Don't play games with the VALID flag, bgp_process
984 is async now, so it didn't make a difference anyway.
985 Remove the 'force' argument from bgp_rib_withdraw, withdraw+force
986 is equivalent to bgp_rib_remove. Update all its callers.
987 (bgp_update_rsclient) bgp_rib_withdraw and force set is same as
988 bgp_rib_remove.
989 (route_vty_short_status_out) new helper to print the leading
990 route-status string used in many command outputs. Consolidate.
991 (route_vty_out, route_vty_out_tag, damp_route_vty_out,
992 flap_route_vty_out) use route_vty_short_status_out rather than
993 duplicate.
994 (route_vty_out_detail) print state of REMOVED flag.
995 (BGP_SHOW_SCODE_HEADER) update for Removed flag.
996
hassoe279c7a2005-08-03 17:23:20 +00009972005-08-03 Hasso Tepper <hasso at quagga.net>
998
999 * bgp_routemap.c: Revert part of leaking communities fix commited in
1000 2005-05-27. While ecommunity fix seems to be correct, community case
1001 isn't.
1002
paul94f2b392005-06-28 12:44:16 +000010032005-06-28 Paul Jakma <paul.jakma@sun.com>
1004
1005 * (global) The great bgpd extern and static'ification.
1006 * bgp_routemap.c: remove unused ROUTE_MATCH_ASPATH_OLD code
1007 (route_set_metric_compile) fix u_int32_t to ULONG_MAX comparison
1008 warnings.
1009 * bgp_route.h: (bgp_process, bgp_withdraw, bgp_update) export these
1010 used by various files which had their own private declarations,
1011 in the case of mplsvpn - incorrect.
1012
paule210cf92005-06-15 19:15:35 +000010132005-06-15 Paul Jakma <paul.jakma@sun.com>
1014
1015 * bgpd.c: (bgp_terminate) workqueue's are lazy allocated and its
1016 possible to terminate bgpd before workqueues were setup, causing
1017 an abort/crash. Reported by Ashish Mehta of Sun.
1018
paul200df112005-06-01 11:17:05 +000010192005-06-01 Paul Jakma <paul.jakma@sun.com>
1020
1021 * (general) refcount struct peer and bgp_info, hence allowing us
1022 add work_queues for bgp_process.
1023 * bgp_route.h: (struct bgp_info) Add 'lock' field for refcount.
1024 Add bgp_info_{lock,unlock} helper functions.
1025 Add bgp_info_{add,delete} helpers, to remove need for
1026 users managing locking/freeing of bgp_info and bgp_node's.
1027 * bgp_table.h: (struct bgp_node) Add a flags field, and
1028 BGP_NODE_PROCESS_SCHEDULED to merge redundant processing of
1029 nodes.
1030 * bgp_fsm.h: Make the ON/OFF/ADD/REMOVE macros lock and unlock
1031 peer reference as appropriate.
1032 * bgp_damp.c: Remove its internal prototypes for
1033 bgp_info_delete/free. Just use bgp_info_delete.
1034 * bgpd.h: (struct bgp_master) Add work_queue pointers.
1035 (struct peer) Add reference count 'lock'
1036 (peer_lock,peer_unlock) New helpers to take/release reference
1037 on struct peer.
1038 * bgp_advertise.c: (general) Add peer and bgp_info refcounting
1039 and balance how references are taken and released.
1040 (bgp_advertise_free) release bgp_info reference, if appropriate
1041 (bgp_adj_out_free) unlock peer
1042 (bgp_advertise_clean) leave the adv references alone, or else
1043 call bgp_advertise_free cant unlock them.
1044 (bgp_adj_out_set) lock the peer on new adj's, leave the reference
1045 alone otherwise. lock the new bgp_info reference.
1046 (bgp_adj_in_set) lock the peer reference
1047 (bgp_adj_in_remove) and unlock it here
1048 (bgp_sync_delete) make hash_free on peer conditional, just in
1049 case.
1050 * bgp_fsm.c: (general) document that the timers depend on
1051 bgp_event to release a peer reference.
1052 (bgp_fsm_change_status) moved up the file, unchanged.
1053 (bgp_stop) Decrement peer lock as many times as cancel_event
1054 canceled - shouldnt be needed but just in case.
1055 stream_fifo_clean of obuf made conditional, just in case.
1056 (bgp_event) always unlock the peer, regardless of return value
1057 of bgp_fsm_change_status.
1058 * bgp_packet.c: (general) change several bgp_stop's to BGP_EVENT's.
1059 (bgp_read) Add a mysterious extra peer_unlock for ACCEPT_PEERs
1060 along with a comment on it.
1061 * bgp_route.c: (general) Add refcounting of bgp_info, cleanup
1062 some of the resource management around bgp_info. Refcount peer.
1063 Add workqueues for bgp_process and clear_table.
1064 (bgp_info_new) make static
1065 (bgp_info_free) Ditto, and unlock the peer reference.
1066 (bgp_info_lock,bgp_info_unlock) new exported functions
1067 (bgp_info_add) Add a bgp_info to a bgp_node in correct fashion,
1068 taking care of reference counts.
1069 (bgp_info_delete) do the opposite of bgp_info_add.
1070 (bgp_process_rsclient) Converted into a work_queue work function.
1071 (bgp_process_main) ditto.
1072 (bgp_processq_del) process work queue item deconstructor
1073 (bgp_process_queue_init) process work queue init
1074 (bgp_process) call init function if required, set up queue item
1075 and add to queue, rather than calling process functions directly.
1076 (bgp_rib_remove) let bgp_info_delete manage bgp_info refcounts
1077 (bgp_rib_withdraw) ditto
1078 (bgp_update_rsclient) let bgp_info_add manage refcounts
1079 (bgp_update_main) ditto
1080 (bgp_clear_route_node) clear_node_queue work function, does
1081 per-node aspects of what bgp_clear_route_table did previously
1082 (bgp_clear_node_queue_del) clear_node_queue item delete function
1083 (bgp_clear_node_complete) clear_node_queue completion function,
1084 it unplugs the process queues, which have to be blocked while
1085 clear_node_queue is being processed to prevent a race.
1086 (bgp_clear_node_queue_init) init function for clear_node_queue
1087 work queues
1088 (bgp_clear_route_table) Sets up items onto a workqueue now, rather
1089 than clearing each node directly. Plugs both process queues to
1090 avoid potential race.
1091 (bgp_static_withdraw_rsclient) let bgp_info_{add,delete} manage
1092 bgp_info refcounts.
1093 (bgp_static_update_rsclient) ditto
1094 (bgp_static_update_main) ditto
1095 (bgp_static_update_vpnv4) ditto, remove unneeded cast.
1096 (bgp_static_withdraw) see bgp_static_withdraw_rsclient
1097 (bgp_static_withdraw_vpnv4) ditto
1098 (bgp_aggregate_{route,add,delete}) ditto
1099 (bgp_redistribute_{add,delete,withdraw}) ditto
1100 * bgp_vty.c: (peer_rsclient_set_vty) lock rsclient list peer
1101 reference
1102 (peer_rsclient_unset_vty) ditto, but unlock same reference
1103 * bgpd.c: (peer_free) handle frees of info to be kept for lifetime
1104 of struct peer.
1105 (peer_lock,peer_unlock) peer refcount helpers
1106 (peer_new) add initial refcounts
1107 (peer_create,peer_create_accept) lock peer as appropriate
1108 (peer_delete) unlock as appropriate, move out some free's to
1109 peer_free.
1110 (peer_group_bind,peer_group_unbind) peer refcounting as
1111 appropriate.
1112 (bgp_create) check CALLOC return value.
1113 (bgp_terminate) free workqueues too.
1114
hasso033e8612005-05-28 04:50:54 +000011152005-05-28 Hasso Tepper <hasso at quagga.net>
1116
1117 * bgp_routemap.c: Sync set_metric_addsub_cmd with ripd.
1118
hasso54a6ed32005-05-26 22:12:33 +000011192005-05-27 Hasso Tepper <hasso at quagga.net>
1120
hasso70601e02005-05-27 03:26:57 +00001121 * bgp_routemap.c: Stop leaking communities.
1122
11232005-05-27 Hasso Tepper <hasso at quagga.net>
1124
hasso54a6ed32005-05-26 22:12:33 +00001125 * bgpd.c: Deleting bgp->rsclient list needs fix similar to pree-groups
1126 deleting fix. Avoid leaking bgp->group, bgp->peer and bgp->rsclient
1127 lists.
1128
11292005-05-26 Hasso Tepper <hasso at quagga.net>
hassob6b7cff2005-05-26 08:29:07 +00001130
1131 * bgpd.c: Don't crash while deleting list of peer-groups.
1132
hassob5f29602005-05-25 21:00:28 +000011332005-05-25 Hasso Tepper <hasso at quagga.net>
1134
1135 * bgpd.c: Fix obvious (routeserver patch) merge error. This makes "no
1136 neighbor x.x.x.x routemap [export|import] commands work again.
1137
paula94feb32005-05-23 13:17:29 +000011382005-05-23 Paul Jakma <paul@dishone.st>
1139
1140 * bgp_routemap.c: add semi-colons to VTY_GET_* to match vty.h change
paul00d252c2005-05-23 14:19:54 +00001141 * bgp_fsm.h: Add extern qualifier to exported functions
1142 * bgp_nexthop.c: add static to nexthop specific globals
1143 * *.h: Add guard defines
paula94feb32005-05-23 13:17:29 +00001144
paul22db9de2005-05-19 01:50:11 +000011452005-05-19 Paul Jakma <paul@dishone.st>
1146
1147 * bgp_fsm.c: (bgp_stop) use sockunion_free, not XFREE..
1148 * bgp_network.c: (bgp_getsockname) ditto
paule83e2082005-05-19 02:12:25 +00001149 (bgp_accept) use XSTRDUP
paul22db9de2005-05-19 01:50:11 +00001150 * bgp_routemap.c: (route_match_peer) ditto, als use a ret value and
1151 remove one sockunion_free.
paule83e2082005-05-19 02:12:25 +00001152 * bgpd.c: (peer_delete) ditto.
1153 XFREE the correct memtype, not free.
1154 (peer_create) use XSTRDUP
1155 * bgp_packet.c: (bgp_stream_dup) deleted, stream_dup should be used
1156 (various) update -> s/bgp_stream_dup/stream_dup
1157
paul22db9de2005-05-19 01:50:11 +00001158
ajs634f9ea2005-04-11 15:51:40 +000011592005-04-11 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1160
1161 * bgp_zebra.c (bgp_redistribute_set, bgp_redistribute_unset):
1162 The 2nd arg to zebra_redistribute_send is now zclient instead of
1163 zclient->sock.
1164
hassoa8a80d52005-04-09 13:07:47 +000011652005-04-09 Akihiro Mizutani <mizutani@net-chef.net>
1166
1167 * bgp_vty.c: Make "exit-address-family" work in IPv4 unicast address
1168 family node.
1169
hasso68118452005-04-08 15:40:36 +000011702005-04-08 Martin Ling <martin-quagga@earth.li>
1171
1172 * bgp_aspath.[ch], bgp_route.c, bgp_vty.c, bgpd.[ch]: Allow to enable
1173 the length of confederation path segments to be included during the
1174 as-path length check in the best path decision.
1175
ajsd2fc8892005-04-02 18:38:43 +000011762005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1177
1178 * bgp_zebra.c: (bgp_interface_delete) After deleting, set ifp->ifindex
1179 to IFINDEX_INTERNAL.
1180
hasso6cf159b2005-03-21 10:28:14 +000011812005-03-21 Hasso Tepper <hasso at quagga.net>
1182
1183 * bgp_route.c: Don't crash while clearing route tables if there is
1184 no particular afi/safi configured.
1185
hasso338b3422005-02-23 14:27:24 +000011862005-02-23 Hasso Tepper <hasso at quagga.net>
1187
1188 * bgp_route.c: Make reannouncing prefixes with changed attributes
1189 work again.
1190
hasso6ffd2072005-02-02 14:50:11 +000011912005-02-02 Akihiro Mizutani <mizutani@net-chef.net>
1192
hassodd4c5932005-02-02 17:15:34 +00001193 * bgp_vty.c: Deprecate "neighbor transparent-as" and "neighbor
1194 transparent-nexthop" commands.
1195
11962005-02-02 Akihiro Mizutani <mizutani@net-chef.net>
1197
hassoc1643bb2005-02-02 16:43:17 +00001198 * bgp_routemap.c: New route-map command - "match ip route-source".
1199
12002005-02-02 Akihiro Mizutani <mizutani@net-chef.net>
1201
hassofee6e4e2005-02-02 16:29:31 +00001202 * bgp_clist.[ch], bgp_route.c, bgp_routemap.c, bgp_vty.c:
1203 community-list cleanup.
1204
12052005-02-02 Akihiro Mizutani <mizutani@net-chef.net>
1206
hasso6ffd2072005-02-02 14:50:11 +00001207 * bgp_route.c, bgp_vty.c, bgp_zebra.c, bgpd.[ch]: "enforce-multihop"
1208 -> "disable-connected-check".
1209
12102005-02-02 Akihiro Mizutani <mizutani@net-chef.net>
hasso93406d82005-02-02 14:40:33 +00001211
1212 * bgp_fsm.c, bgp_open.c, bgp_packet.c, bgp_route.[ch], bgp_vty.c,
1213 bgpd.[ch]: Add BGP_INFO_STALE flag and end-of-rib support. "bgp
1214 graceful-restart" commands added. Show numbers of individual
1215 messages in "show ip bgp neighbor" command. Final pieces of graceful
1216 restart.
1217
hassof4184462005-02-01 20:13:16 +000012182005-02-01 Akihiro Mizutani <mizutani@net-chef.net>
1219
hassoc9502432005-02-01 22:01:48 +00001220 * bgp_open.c, bgp_packet.c, bgp_vty.c, bgpd.[ch]: Remove "no neighbor
1221 capability route-refresh" commands. Route refresh capability is sent
1222 anyway now. Preserve dummy deprecated commands.
1223
12242005-02-01 Akihiro Mizutani <mizutani@net-chef.net>
1225
hasso3d515fd2005-02-01 21:30:04 +00001226 * bgp_attr.c, bgp_snmp.c, bgp_vty.c, bgpd.[ch]: Remove support for old
1227 draft - ie. "neighbor version 4-" commands. Preserve dummy "neighbor
1228 version" command as deprecated.
1229
12302005-02-01 Akihiro Mizutani <mizutani@net-chef.net>
1231
hasso0a486e52005-02-01 20:57:17 +00001232 * bgpd.[ch], bgp_vty.c, bgp_route.c: "Restart session after
1233 maximum-prefix limit" feature support.
1234
12352005-02-01 Akihiro Mizutani <mizutani@net-chef.net>
1236
hassof4184462005-02-01 20:13:16 +00001237 * bgp_nexthop.c: Improve debug.
1238 * bgpd.[ch], bgp_nexthop.c, bgp_snmp.c: Remove useless bgp_get_master()
1239 function.
1240 * bgp_packet.c: MP AFI_IP update and withdraw parsing.
1241 * bgp_fsm.c: Reset peer synctime in bgp_stop(). bgp_fsm_change_status()
1242 is better place to log about peer status change than bgp_event().
1243 Log in bgp_connect_success().
1244 * bgp_vty.c: Fix typo in comment.
1245 * bgp_attr.c: Better log about unknown attribute.
1246
ajs3b8b1852005-01-29 18:19:13 +000012472005-01-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1248
1249 * bgp_filter.c: (ip_as_path,no_ip_as_path) Use argv_concat instead
1250 of buffer_getstr.
1251 * bgp_route.c: (bgp_show_regexp) Fix memory leak: need to free string
1252 returned by buffer_getstr.
1253 (bgp_show_community) Must use XFREE instead of free on string
1254 returned by buffer_getstr.
1255 * bgp_routemap.c: (set_community) Must use XFREE instead of free
1256 on string returned by buffer_getstr.
1257 * bgp_vty.c: (neighbor_description) Use argv_concat instead of
1258 buffer_getstr.
1259
hasso6d694292005-01-24 09:29:42 +000012602005-01-24 Hasso Tepper <hasso at quagga.net>
1261
1262 * bgp_route.c: Fix showstopper bug. New route must be selected also
1263 if old one is flaged as BGP_INFO_ATTR_CHANGED.
1264
hassof1271652005-01-17 11:04:32 +000012652005-01-17 Hasso Tepper <hasso at quagga.net>
1266
1267 * bgp_route.c: Clear peer's routing table regardless whether it's
1268 configured or not. Being not configured is even better reason to
1269 do it.
1270
paula24a7e12005-01-05 08:14:13 +000012712005-01-05 Paul Jakma <paul@dishone.st>
1272
1273 * bgp_packet.c: (bgp_write) set socket to nonblock while writing
1274 this should be generalised. See bugzilla #102. Fix supplied by
1275 wawa@yandex-team.ru (Vladimir Ivanov).
1276
ajsd2c1f162004-12-08 21:10:20 +000012772004-12-08 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1278
1279 * *.c: Change level of debug messages to LOG_DEBUG.
1280
ajs274a4a42004-12-07 15:39:31 +000012812004-12-07 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1282
1283 * bgp_main.c: (main) The 2nd argument to openzlog has been removed.
1284
ajs887c44a2004-12-03 16:36:46 +000012852004-12-03 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1286
1287 * bgp_main.c: (sigint) Use zlog_notice for termination message.
1288 (main) Use zlog_notice for startup announcement.
1289
hassoc0652302004-11-25 19:33:48 +000012902004-11-25 Hasso Tepper <hasso at quagga.net>
1291
1292 * bgp_main.c: Make group to run as configurable.
1293
paul59320202004-11-09 01:54:03 +000012942004-11-09 Paul Jakma <paul@dishone.st>
1295
1296 * bgp_nexthop.c: collapse bgp_connected_ipvX, bgp_nexthop_cache_ipvX
1297 and cache{1,2}.. into arrays of tables and hence collapse
1298 bgp_scan_ipv{4,6} into a single bgp_scan function. Tested, though
1299 a long time ago (and this change was hand-merged).
1300
ajs5a646652004-11-05 01:25:55 +000013012004-11-04 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1302
1303 * bgp_route.c: Remove all code related to VTY_CONTINUE; this feature
1304 is deprecated because the output did not represent a single point
1305 in time. All output needs to be generated inline and buffered
1306 by the library code.
1307 (route_vty_out,route_vty_out_tag,damp_route_vty_out,
1308 flap_route_vty_out) Remove code to count number of lines of output,
1309 since this was only useful for VTY_CONTINUE behavior.
1310 (bgp_show_callback,vty_calc_line) Removed.
1311 (bgp_show_table) Remove hooks for VTY_CONTINUE callback support.
1312 As a result, there's a new output_arg argument to this function.
1313 Make function static.
1314 (bgp_show) Make function static and add a new output_arg argument.
1315 Change all functions that call bgp_show or bgp_show_table to
1316 pass the new output_arg argument (that used to be passed inside
1317 vty->output_arg).
1318 * bgp_mplsvpn.c: Remove declarations of functions defined in
1319 bgp_route.c; these declarations belong in bgp_route.h.
1320 * bgp_route.h: Declare 3 global functions used in both bgp_route.c
1321 and in bgp_mplsvpn.c.
1322
paula2b1ecd2004-10-31 18:58:09 +000013232004-10-31 Paul Jakma <paul@dishone.st>
1324
1325 * {bgpd,bgp_attr}.c: size_t printf format should be ld.
1326
paul98f51632004-10-25 14:19:15 +000013272004-10-25 Paul Jakma <paul@dishone.st>
1328
1329 * Update with fix in debian bug id 222930.
1330 * bgp_main.c: Add ZCAP_RAW, needed to bind to interfaces.
1331 bgp_network.c: (....) raise/lower privs around call to
1332 SO_BINDTODEVICE sockopt.
1333
hasso3fb9cd62004-10-19 19:44:43 +000013342004-10-19 Andrew J. Schorr <aschorr@telemetry-investments.com>
1335
1336 * bgp_nexthop.c: (bgp_connected_add) Connected destination pointer
1337 may be NULL.
1338 (bgp_connected_delete) ditto.
1339
hasso501ba492004-10-13 21:32:46 +000013402004-10-14 Hasso Tepper <hasso at quagga.net>
1341
1342 * bgp_dump.c: Make dump configuration appear in vtysh.
1343
hassoc75105a2004-10-13 10:33:26 +000013442004-10-13 Hasso Tepper <hasso at quagga.net>
1345
1346 * bgp_snmp.c: Remove defaults used to initialize smux connection to
1347 snmpd. Connection is initialized only if smux peer is configured.
hasso8b3126b2004-10-13 20:59:04 +00001348 * bgp_view.c: It's dead file. Reomved.
hassoc75105a2004-10-13 10:33:26 +00001349
paulfd79ac92004-10-13 05:06:08 +000013502004-10-13 Paul Jakma <paul@dishone.st>
1351
1352 * (global) more const'ification and fixups of types to clean up code.
1353 * bgp_mplsvpn.{c,h}: (str2tag) fix abuse. Still not perfect,
1354 should use something like the VTY_GET_INTEGER macro, but without
1355 the vty_out bits..
1356 * bgp_routemap.c: (set_aggregator_as) use VTY_GET_INTEGER_RANGE
1357 (no_set_aggregator_as) ditto.
1358 * bgpd.c: (peer_uptime) fix unlikely bug, where no buffer is
1359 returned, add comments about troublesome return value.
1360
hasso18a6dce2004-10-03 18:18:34 +000013612004-10-03 James R. Leu <jleu at mindspring.com>
1362
1363 * bgp_vty.c: Router id from zebra can be manually overriden.
1364 * bgp_zebra.c: Read router id related messages from zebra daemon.
1365 Remove own code related with router id selection.
1366 * bgpd.c, bgpd.h: Remove own router id selection code. Use the one
1367 from zebra daemon if it isn't manually overriden.
1368
hassoc9e52be2004-09-26 16:09:34 +000013692004-09-26 Hasso Tepper <hasso at quagga.net>
1370
1371 * bgp_aspath.c, bgp_packet.c, bgp_vty.c: Fix compiler warnings.
1372
hasso52dc7ee2004-09-23 19:18:23 +000013732004-09-23 Hasso Tepper <hasso at quagga.net>
1374
1375 * *.[c|h]: list -> struct list *, listnode -> struct listnode *.
1376
paule01f9cb2004-07-09 17:48:53 +000013772004-07-09 Paul Jakma <paul@dishone.st>
1378
1379 * Merge of GNU Zebra cvs2svn changesets r799, r800 and r807.
1380 * bgp_dump.c: (bgp_dump_attr) cleanup. return status code. check
1381 attributes present before printing.
1382 * bgp_dump.c: update bgp_dump_attr prototype.
1383 * bgp_packet.c: (bgp_update_receive) init attrstr. check status
1384 of bgp_dump_attr. Log end-of-rib UPDATEs.
1385
paulf5ba3872004-07-09 12:11:31 +000013862004-07-09 Sowmini Varadhan <sowmini.varadhan@sun.com>
1387
1388 * bgp_packet.c: (bgp_collision_detect) Send NOTIFY on new socket
1389 if that is connection we're closing.
1390 (bgp_read) invalid marker check applies to KEEPALIVE too.
1391 * bgp_route.c: Ignore multicast NRLI, dont send NOTIFY.
1392
paul5228ad22004-06-04 17:58:18 +000013932004-06-04 Paul Jakma <paul@dishone.st>
1394
1395 * type mismatch fixes
1396
hasso538621f2004-05-21 09:31:30 +000013972004-05-21 Akihiro Mizutani <mizutani@net-chef.net>
1398
1399 * bgpd.h, bgp_open.[ch], bgp_debug.c, bgp_vty.[ch], bgp_fsm.c:
1400 Graceful restart capability display.
1401
hasso3950fda2004-05-20 10:22:49 +000014022005-05-20 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1403
1404 * bgp_debug.c: Cosmetical fixes and log neighbor changes.
1405
hasso4372df72004-05-20 10:20:02 +000014062004-05-20 Akihiro Mizutani <mizutani@net-chef.net>
1407
1408 * bgp_ecommunity.c: Transit ecommunity support.
1409 * bgp_ecommunity.c: Fix for unknown community crush.
1410
hassoe0701b72004-05-20 09:19:34 +000014112005-05-20 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1412
1413 * *: Maximum prefix threshold support.
1414 * *: Reset notification fixups.
1415
paul0a589352004-05-08 11:48:26 +000014162004-05-08 Paul Jakma <paul@dishone.st>
1417
1418 * bgp_zebra.c: (bgp_interface_address_add) sync to zclient changes
1419 (bgp_interface_address_delete) ditto.
1420 (bgp_zebra_announce) ditto.
1421 (bgp_zebra_withdraw) ditto.
1422
paulc5317402004-05-03 13:25:06 +000014232004-05-03 Daniel Roesen <dr@cluenet.de>
1424
1425 * bgp_fsm.c: (bgp_stop) Reset uptime only on transition from
1426 Established so that it reflects true downtime (rather time
1427 since last transition, eg Active->Idle)
1428
paul35be31b2004-05-01 18:17:04 +000014292004-05-01 rivo nurges <rix@estpak.ee>
1430
1431 * bgp_route.c: fix UNH IOL BGP-4.1.12f
1432
pauleb821182004-05-01 08:44:08 +000014332004-05-01 Paul Jakma <paul@dishone.st>
1434
1435 * Revert the attempted clean-up of the dummy peer hack, reverts
1436 patchsets 435 (see 2004-02-17 below) and 456.
1437
paul545acaf2004-04-20 15:13:15 +000014382004-04-16 rivo nurges <rix@estpak.ee>
1439
hasso9b87e412004-04-20 16:54:49 +00001440 * bgpd.h, bgp_debug.c: update cease subcodes to
1441 draft-ietf-idr-cease-subcode-05
paul545acaf2004-04-20 15:13:15 +00001442 * bgpd.h, bgpd.c, bgp_route.c, bgp_route.h: fix UNH IOL BGP-4.1.6a
1443
paul6ad23f02004-02-17 19:45:10 +000014442004-02-17 Paul Jakma <paul@dishone.st>
1445
1446 * bgpd.h: (bgp_peer) add fd_local and fd_accept
1447 file descriptor's, fd becomes a pointer to one of these.
1448 * bgpd.c: (global) adjust for fact that fd is now a pointer.
1449 (peer_create_accept) removed.
1450 * bgp_route.c: (global) adjust for change of peer fd to pointer
1451 * bgp_packet.c: (bgp_collision_detect) adjust and remove the
1452 "replace with other peer" hack.
1453 * bgp_network.c: (bgp_accept) Remove the dummy peer hack.
1454 Update peer->fd_accept instead.
1455 (global) Adjust fd references - now a pointer.
1456 * bgp_fsm.c: (global) adjust peer fd to pointer.
1457 (bgp_connection_stop) new function, to stop connection.
1458 (global) adjust everything which closed peer fd to use
1459 bgp_connection_stop().
1460
gdt10d60ad2003-12-23 17:34:39 +000014612003-12-23 Krzysztof Oledzki <oleq@ans.pl>
1462
1463 * bgp_network.c: drop privs on error cases
1464
paul6ad23f02004-02-17 19:45:10 +000014652003-08-11 kunihiro <kunihiro@zebra.org>
paulac41b2a2003-08-12 05:32:27 +00001466
1467 * bgp_route{,map}.c: Extend 'set ip next-hop' in route-maps with
1468 ability to specify 'peer-address' rather than IP.
1469
paul9238b1e2003-06-11 08:03:08 +000014702003-06-09 Paul Jakma <paul@dishone.st>
1471
1472 * bgp_clist.c (community_list_delete): honour deny statements
1473
paul445f1432003-05-16 19:00:31 +000014742003-04-19 Hasso Tepper <hasso@estpak.ee>
1475
1476 * rip_routemap.c: sync daemon's route-map commands to have same
1477 syntax
1478
14792003-01-09 Akihiro Mizutani <mizutani@net-chef.net>
1480
1481 * bgp_routemap.c: Add match extcommunity command.
1482
paul718e3742002-12-13 20:15:29 +000014832002-10-23 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1484
1485 * bgp_aspath.c (aspath_init): Extend hash size from default to
1486 32767.
1487 (aspath_key_make): Use unsigned shoft for making hash. Suggested
1488 by: Marc Evans <Marc@SoftwareHackery.Com>
1489
14902002-08-19 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1491
1492 * bgp_clist.c (community_entry_free): Fix memory leak of standard
1493 extcommunity-list config string.
1494
14952002-08-19 Akihiro Mizutani <mizutani@net-chef.net>
1496
1497 * bgp_route.c (route_vty_out_detail): Fix bug of router-id display
1498 when multiple instance is used.
1499
15002002-08-18 Akihiro Mizutani <mizutani@net-chef.net>
1501
1502 * bgpd.c: Make "default-originate" and "maximum-prefix" commands
1503 available in peer-group configuration.
1504
15052002-08-13 Akihiro Mizutani <mizutani@net-chef.net>
1506
1507 * bgp_packet.c (bgp_open_send): Put Opt Parm Len 0 when last
1508 capability packet cause error or dont-capability-negotiate option
1509 is specified.
1510
15112002-07-07 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1512
1513 * zebra-0.93 released.
1514
15152001-10-28 Kunihiro Ishiguro <kunihiro@zebra.org>
1516
1517 * bgpd.c (bgp_vty_init): Translate update commands are removed.
1518
15192001-10-10 Kunihiro Ishiguro <kunihiro@zebra.org>
1520
1521 * bgp_route.c (bgp_static_set): Add workaround for BGP static
1522 route announcement when there is no zebra running.
1523
15242001-10-08 Kunihiro Ishiguro <kunihiro@zebra.org>
1525
1526 * bgpd.c (neighbor_remote_as_unicast): Remove "remote-as nlri
1527 unicast multicast" commands.
1528
15292001-09-14 Akihiro Mizutani <mizutani@dml.com>
1530
1531 * bgp_open.c: When we receive capability route-refresh, we should
1532 check we send the capability not we receive the capability.
1533
1534 * bgp_route.c (bgp_network_mask_natural_route_map): network
1535 statement route-map is added.
1536
15372001-08-31 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1538
1539 * bgp_advertise.c (bgp_advertise_intern): attr must be interned
1540 before looking up hash table.
1541
15422001-08-30 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1543
1544 * bgpd.h (struct peer): BGP filter is moved from peer_conf to
1545 peer.
1546
15472001-08-28 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1548
1549 * bgp_nexthop.c (bnc_nexthop_free): Fix next pointer bug.
1550 Suggested by: "Hong-Sung Kim" <hoskim@lanbird.co.kr>.
1551
15522001-08-26 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1553
1554 * bgp_table.c (bgp_node_create): Clearn memory before use it.
1555
15562001-08-24 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1557
1558 * Change to use bgp_table.[ch].
1559
15602001-08-23 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1561
1562 * bgpd.c (bgp_init): Add "transparent-as" and
1563 "transparent-nexthop" for old version compatibility.
1564
15652001-08-23 Akihiro Mizutani <mizutani@dml.com>
1566
1567 * bgpd.h (struct peer): default-originate route-map is added.
1568
1569 * bgp_route.c: When self originated route is advertised with
1570 attrubute-unchanged, nexthop was not properly set. This bug is
1571 fixed.
1572
15732001-08-22 Akihiro Mizutani <mizutani@dml.com>
1574
1575 * bgpd.c (neighbor_attr_unchanged): transparent-as and
1576 transparent-next-hop commands are restructured. Instead of
1577 current transparent-* commands, attribute-unchanged command is
1578 introduced.
1579
1580 neighbor A.B.C.D attribute-unchanged [as-path|next-hop|med]
1581
1582 (neighbor_default_originate): "default-originate" configuration
1583 announce default route even 0.0.0.0/0 does not exists in BGP RIB.
1584
15852001-08-19 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1586
1587 * zebra-0.92a released.
1588
15892001-08-19 Akihiro Mizutani <mizutani@dml.com>
1590
1591 * bgpd.c: AF specific soft-reconfiguration inbound commands are
1592 added.
1593
15942001-08-17 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1595
1596 * bgp_route.c (bgp_show_callback): Do not do community NULL check.
1597
1598 * bgp_community.c (community_cmp): Add check for commnunity NULL
1599 check.
1600
1601 * bgp_routemap.c (route_match_community): Do not check comunity is
1602 NULL. It may match to community-list "^$".
1603
1604 * bgp_community.c (community_match): Add check for community is
1605 NULL case.
1606
16072001-08-17 Akihiro Mizutani <mizutani@dml.com>
1608
1609 * bgpd.c: AF specific route-reflector-client and
1610 route-server-client configuration are added.
1611
16122001-08-17 Rick Payne <rickp@ayrnetworks.com>
1613
1614 * bgp_clist.c (community_match_regexp): Check special ^$ case.
1615
16162001-08-17 Akihiro Mizutani <mizutani@dml.com>
1617
1618 * bgp_clist.c (community_list_match): Fix bug of community list
1619 permit and deny check.
1620
16212001-08-16 Akihiro Mizutani <mizutani@dml.com>
1622
1623 * bgp_mplsvpn.c (bgp_mplsvpn_init): Add AF specific "nexthop-self"
1624 command.
1625
16262001-08-15 Akihiro Mizutani <mizutani@dml.com>
1627
1628 * bgpd.h (PEER_FLAG_SEND_COMMUNITY): Per AF based configuration
1629 flag is introduced.
1630
1631 * bgp_mplsvpn.c (bgp_mplsvpn_init): VPNv4 filtering is added.
1632
16332001-08-15 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1634
1635 * zebra-0.92 released.
1636
16372001-08-13 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1638
1639 * bgpd.c (bgp_delete): "no router bgp" free static, aggregate, rib
1640 table properly.
1641
16422001-08-12 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1643
1644 * bgp_route.c (bgp_node_safi): Return SAFI of current node.
1645 (bgp_config_write_network_vpnv4): VPNv4 static configuration
1646 display.
1647
16482001-08-11 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1649
1650 * bgpd.c (no_bgp_ipv4_multicast_route_map): Add IPv4 multicast
1651 node filter commands.
1652
16532001-08-11 Kunihiro Ishiguro <kunihiro@zebra.org>
1654
1655 * bgpd.h (PEER_FLAG_IGNORE_LINK_LOCAL_NEXTHOP): Add
1656 "ignore-link-local-nexthop" flag for ignore link-local nexthop for
1657 IPv6.
1658
16592001-08-07 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1660
1661 * bgpd.c (address_family_ipv4_multicast): "address-family ipv4
1662 multicast" is added.
1663 (address_family_ipv6_unicast): "address-family ipv6 unicast" is
1664 added.
1665
16662001-08-07 Akihiro Mizutani <mizutani@dml.com>
1667
1668 * bgp_route.c (bgp_process): Use flag instead of as_selected
1669 memeber in struct bgp_info.
1670
1671 * bgp_route.h (struct bgp_info): Remove as_selected memeber from
1672 struct bgp_info.
1673
16742001-07-31 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1675
1676 * bgp_route.c (bgp_announce_check): Enclose sending time AS loop
1677 check code with #ifdef BGP_SEND_ASPATH_CHECK.
1678
16792001-07-29 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1680
1681 * bgp_packet.c (bgp_withdraw_send): Simplify address family check.
1682
1683 * bgpd.h (BGP_INFO_HOLDDOWN): Introduce new macro to check BGP
1684 information is alive or not.
1685
1686 * bgp_community.c: Use community_val_get() on all OS.
1687
16882001-07-24 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1689
1690 * bgp_route.c (bgp_announce_check): Simplify set next-hop self
1691 check.
1692
16932001-07-24 Akihiro Mizutani <mizutani@dml.com>
1694
1695 * bgp_route.c (bgp_announce_check): To route server clients, we
1696 announce AS path, MED and nexthop transparently.
1697
16982001-06-21 Kunihiro Ishiguro <kunihiro@zebra.org>
1699
1700 * bgp_routemap.c (route_set_atomic_aggregate_free): Do not call
1701 XFREE. No memory is allocated in
1702 route_set_atomic_aggregate_compile().
1703
17042001-06-21 Kunihiro Ishiguro <kunihiro@zebra.org>
1705
1706 * bgp_routemap.c (bgp_route_map_init): `match nlri` and `set nlri`
1707 are replaced by `address-family ipv4` and `address-family vpnvr'.
1708
17092001-06-19 Kunihiro Ishiguro <kunihiro@zebra.org>
1710
1711 * bgp_route.c (bgp_withdraw): Add check for BGP_PEER_CONFED.
1712 Reported by Rick Payne <rickp@rossfell.co.uk>.
1713
17142001-06-17 Kunihiro Ishiguro <kunihiro@zebra.org>
1715
1716 * bgp_zebra.c (bgp_zebra_announce): When global IPv6 nexthop is
1717 empty, use socket's remote address for the nexthop.
1718
17192001-06-04 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1720
1721 * bgpd.c (peer_delete): Fix memory leak. Reported by Yosi Yarchi
1722 <Yosi_Yarchi@KereniX.com>
1723
17242001-06-01 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1725
1726 * bgpd.c (bgp_delete): Fix memory leak. Reported by Yosi Yarchi
1727 <Yosi_Yarchi@KereniX.com>
1728
17292001-05-27 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1730
1731 * bgp_route.c (bgp_route_clear_with_afi_vpnv4): Use next instead
1732 of ri->next.
1733
1734 * bgp_packet.c (bgp_withdraw_send): MPLS/VPN withdraw takes effect
1735 when HAVE_IPV6 is not defined.
1736
17372001-03-07 "Akihiro Mizutani" <mizutani@dml.com>
1738
1739 * bgpd.c (peer_timers_set): Adjust keepalive timer to fit less
1740 than holdtime / 3.
1741 (bgp_confederation_peers_unset): Only set peer->local_as when
1742 confederation is enabled.
1743 (bgp_timers): Add "timers bgp <0-65535> <0-65535>" command.
1744
1745 * bgp_route.c (bgp_announce_check): Set med of redistributed route
1746 when it is announced to EBGP peer.
1747
17482001-03-06 "Akihiro Mizutani" <mizutani@dml.com>
1749
1750 * bgp_nexthop.c (bgp_scan_ipv4): bgp_scan() call bgp_process() for
1751 all prefixes.
1752
17532001-03-06 Kunihiro Ishiguro <kunihiro@zebra.org>
1754
1755 * bgp_attr.c (bgp_attr_origin): When bgpd send NOTIFICATION with
1756 erroneous attribute (type, length and value), it does include
1757 attribute flags field.
1758
17592001-02-21 "Akihiro Mizutani" <mizutani@dml.com>
1760
1761 * bgp_route.c (bgp_announce_check): The route reflector is not
1762 allowed to modify the attributes of the reflected IBGP routes.
1763
17642001-02-20 "Akihiro Mizutani" <mizutani@dml.com>
1765
1766 * bgp_route.c (bgp_info_cmp): During path seleciton, BGP
1767 confederation peer is treated as same as IBGP peer.
1768
17692001-02-19 Kunihiro Ishiguro <kunihiro@zebra.org>
1770
1771 * bgp_route.c (bgp_redistribute_add): Initialize attr_new with
1772 attr. Call aspath_unintern when return from this function.
1773
17742001-02-19 "Akihiro Mizutani" <mizutani@dml.com>
1775
1776 * bgpd.c (bgp_router_id_set): Reset BGP peer when router-id is
1777 changed.
1778
17792001-02-18 "Akihiro Mizutani" <mizutani@dml.com>
1780
1781 * bgp_packet.c (bgp_open_receive): When user configure holdtimer,
1782 do not refrect the value to current session.
1783
17842001-02-16 Kunihiro Ishiguro <kunihiro@zebra.org>
1785
1786 * bgp_route.c (bgp_aggregate_delete): Set BGP_INFO_ATTR_CHANGE to
1787 suppress route withdraw.
1788
1789 * bgp_damp.c (bgp_damp_init): Fix bug of flap dampening.
1790
17912001-02-16 "Akihiro Mizutani" <mizutani@dml.com>
1792
1793 * bgp_aspath.c (aspath_make_str_count): Use ',' for separator for
1794 AS_SET and AS_CONFED_SET.
1795
17962001-02-15 Kunihiro Ishiguro <kunihiro@zebra.org>
1797
1798 * bgp_route.c (bgp_process): Do not consider suppress route.
1799
1800 * bgp_aspath.c (aspath_aggregate_as_set_add): Reset asset when
1801 aspath->data is realloced.
1802
18032001-02-15 "Akihiro Mizutani" <mizutani@dml.com>
1804
1805 * bgp_attr.c (bgp_attr_aggregate_intern): Do not set atomic
1806 aggregate when using as-set.
1807
18082001-02-14 "Akihiro Mizutani" <mizutani@dml.com>
1809
1810 * bgpd.c (bgp_confederation_peers_unset): Set peer's local-as
1811 correctly.
1812
1813 * bgp_route.c (bgp_update): Just ignore AS path loop for
1814 confederation peer.
1815
18162001-02-10 Kunihiro Ishiguro <kunihiro@zebra.org>
1817
1818 * bgp_route.c (bgp_aggregate_set): Add as_set argument.
1819 (bgp_aggregate_unset): Remove summary_only argument.
1820 (aggregate_address_as_set): New commands.
1821 "aggregate-address A.B.C.D/M as-set"
1822 "no aggregate-address A.B.C.D/M as-set"
1823
18242001-02-08 "Akihiro Mizutani" <mizutani@dml.com>
1825
1826 * bgp_route.c (bgp_announce_check): Do not modify nexthop when the
1827 route is passed by route reflector.
1828
18292001-02-08 Kunihiro Ishiguro <kunihiro@zebra.org>
1830
1831 * bgp_route.c: "no bgp dampening" with argument.
1832 (bgp_announce_check): Do not modify nexthop when the route is
1833 passed by route reflector.
1834
18352001-02-07 "Akihiro Mizutani" <mizutani@dml.com>
1836
1837 * bgpd.c (neighbor_passive): Change "neighbor NEIGHBOR remote-as
1838 ASN passive" to "neighbor NEIGHBOR passive".
1839 (bgp_announce_check): Check well-known community attribute even
1840 when "no neighbor send-community" is set.
1841
18422001-02-03 Kunihiro Ishiguro <kunihiro@zebra.org>
1843
1844 * bgp_fsm.c (bgp_establish): Do not send keepalive at established
1845 time when keepalive timer is configured as zero.
1846
18472001-02-01 Kunihiro Ishiguro <kunihiro@zebra.org>
1848
1849 * bgp_attr.c (bgp_attr_check): When peer is IBGP peer, local
1850 preference is well-known attribute.
1851
18522001-01-30 Kunihiro Ishiguro <kunihiro@zebra.org>
1853
1854 * zebra-0.91 is released.
1855
1856 * bgp_attr.h (struct attr): Comment out DPA value.
1857 (struct attr): Change refcnt type from int to unsinged long.
1858
1859 * bgp_attr.c (attrhash_key_make): Likewise.
1860 (attrhash_cmp): Likewise.
1861 (bgp_attr_dpa): Likewise.
1862
18632001-01-30 "Akihiro Mizutani" <mizutani@dml.com>
1864
1865 * bgp_route.c (bgp_info_cmp): Make route selection completely same
1866 as Cisco's.
1867
18682001-01-30 Kunihiro Ishiguro <kunihiro@zebra.org>
1869
1870 * bgp_attr.h (BGP_ATTR_FLAG_OPTIONAL): Rename old ATTR_FLAG_* to
1871 BGP_ATTR_FLAG_* to clarify meenings.
1872
18732001-01-30 "Akihiro Mizutani" <mizutani@dml.com>
1874
1875 * bgp_route.c (route_vty_out): Display argument to suppress same
1876 prefix information display.
1877 (route_vty_out_route): Don't display mask information for
1878 classfull network.
1879
18802001-01-30 Kunihiro Ishiguro <kunihiro@zebra.org>
1881
1882 * bgp_attr.h (SET_BITMAP): Simple bitmapping macros.
1883
1884 * bgp_attr.c (bgp_attr_parse): Use bitmap for attribute type
1885 check.
1886
18872001-01-29 Kunihiro Ishiguro <kunihiro@zebra.org>
1888
1889 * bgp_attr.c (bgp_mp_reach_parse): Enclose loggin with BGP_DEBUG.
1890 (bgp_attr_parse): Comment out well-known attribute check.
1891
18922001-01-28 Kunihiro Ishiguro <kunihiro@zebra.org>
1893
1894 * bgp_route.c (bgp_static_unset): Link-local IPv6 address can't be
1895 used for network advertisement.
1896 (nlri_parse): When link-local IPv6 address NLRI comes from
1897 remote-peer, log the information then simply ignore it.
1898
1899 * bgp_zebra.c (zebra_read_ipv6): Link-local IPv6 address is not
1900 redistributed.
1901
1902 * bgp_route.c (bgp_update): Check IPv6 global nexthop
1903 reachability.
1904
19052001-01-26 Kunihiro Ishiguro <kunihiro@zebra.org>
1906
1907 * bgp_route.c (bgp_update): Check nexthop points local address or
1908 not.
1909 (bgp_static_update_vpnv4): Set valid flag.
1910
1911 * bgp_attr.c (bgp_attr_parse): Duplicate attribute check.
1912 (bgp_attr_parse): Well-known attribute check.
1913
1914 * bgp_open.c (bgp_auth_parse): Authentication is not yet supported.
1915
1916 * bgp_packet.c (bgp_valid_marker): Check marker is synchronized.
1917
1918 * bgpd.c (clear_bgp): Send NOTIFICATION Cease when SEND_CEASE is
1919 defined.
1920
1921 * bgp_snmp.c (bgp4PathAttrTable): Fix compile error.
1922
19232001-01-24 Kunihiro Ishiguro <kunihiro@zebra.org>
1924
1925 * bgpd.c (bgp_network_import_check): New command for IGP network
1926 check.
1927
19282001-01-23 Kunihiro Ishiguro <kunihiro@zebra.org>
1929
1930 * bgp_nexthop.c (bgp_scan): Run bgp_process when IGP metric is
1931 changed. Call bgp_process once for each node.
1932
19332001-01-23 "Akihiro Mizutani" <mizutani@dml.com>
1934
1935 * bgp_route.c (bgp_info_cmp): Add IGP metric comparison.
1936
19372001-01-23 Kunihiro Ishiguro <kunihiro@zebra.org>
1938
1939 * bgp_route.c (bgp_info_cmp): Add IGP metric comparison.
1940
1941 * bgp_nexthop.c (bgp_nexthop_lookup): Set IGP metric for valid
1942 IBGP route.
1943
19442001-01-23 "Akihiro Mizutani" <mizutani@dml.com>
1945
1946 * bgp_route.c (show_ip_bgp_prefix_longer): Add new commands.
1947 "show ip bgp A.B.C.D/M longer-prefixes"
1948 "show ip bgp ipv4 (unicast|multicast) A.B.C.D/M longer-prefixes"
1949 "show ipv6 bgp X:X::X:X/M longer-prefixes"
1950 "show ipv6 mbgp X:X::X:X/M longer-prefixes"
1951
19522001-01-20 "Akihiro Mizutani" <mizutani@dml.com>
1953
1954 * bgp_route.c (show_ip_bgp_cidr_only): Add new commands.
1955 "show ip bgp cidr-only"
1956 "show ip bgp ipv4 (unicast|multicast) cidr-only"
1957
19582001-01-18 "Akihiro Mizutani" <mizutani@dml.com>
1959
1960 * bgp_route.c (bgp_update): AS path lookup check is done in
1961 bgp_update() not in attr_parse().
1962
19632001-01-18 Kunihiro Ishiguro <kunihiro@zebra.org>
1964
1965 * bgp_route.c (bgp_update): Call bgp_aggregate_decrement() just
1966 before bgp_attr_unintern().
1967
19682001-01-17 Kunihiro Ishiguro <kunihiro@zebra.org>
1969
1970 * bgp_route.c (bgp_update): Now intern is performed very last part
1971 of the BGP packet update procedure.
1972
19732001-01-17 "Akihiro Mizutani" <mizutani@dml.com>
1974
1975 * bgp_route.c (bgp_update): When implicit withdraw occur, reuse
1976 existing bgp_info structure.
1977
19782001-01-17 Kunihiro Ishiguro <kunihiro@zebra.org>
1979
1980 * bgp_route.c (bgp_aggregate_decrement): Fix bug of aggregate
1981 address matching method.
1982 (bgp_update):
1983
1984 * bgp_nexthop.c (bgp_nexthop_onlink): Separate EBGP nexthop onlink
1985 check and IBGP nexthop route check.
1986
19872001-01-16 "Akihiro Mizutani" <mizutani@dml.com>
1988
1989 * bgp_route.h (BGP_INFO_ATRR_CHANGED): Added for track attribute
1990 change.
1991
19922001-01-16 Kunihiro Ishiguro <kunihiro@zebra.org>
1993
1994 * bgp_route.h (struct bgp_info): Remove selected flag. Use
1995 BGP_INFO_SELECTED for flags instead.
1996 (struct bgp_info): Remove valid flag. Use BGP_INFO_VALID for
1997 flags instead.
1998 (struct bgp_info): Add igpmetric for IBGP route nexthop IGP
1999 metric.
2000 (struct bgp_info_tab): Struct bgp_info_tag is integrated into
2001 struct bgp_info.
2002 (BGP_INFO_ATRR_CHANGED): Added for track attribute change.
2003
2004 * bgp_community.c (community_val_get): gcc-2.95 on
2005 sparc-sun-solaris cause crush. This function is for avoid the
2006 crush.
2007
20082001-01-15 Kunihiro Ishiguro <kunihiro@zebra.org>
2009
2010 * bgp_packet.c (bgp_open_receive): Translated peer's packet_size
2011 clear bug is fixed.
2012
20132001-01-14 "Akihiro Mizutani" <mizutani@dml.com>
2014
2015 * bgp_packet.c (bgp_open_receive): Return notification with
2016 supported version number.
2017
20182001-01-13 Kunihiro Ishiguro <kunihiro@zebra.org>
2019
2020 * bgpd.c (bgp_show_summary): Display AS path and community
2021 entries. Suggested by: "Matt Ranney" <mjr@ranney.com>.
2022
2023 * bgp_packet.c (bgp_read_packet): Fix bug of unblocking BGP socket
2024 read. When BGP packet read is partial, we must get size and type
2025 from packet again.
2026
20272001-01-12 "Akihiro Mizutani" <mizutani@dml.com>
2028
2029 * bgp_route.c (bgp_update): Do not unset BGP_INFO_HISTORY flag.
2030 (bgp_update): When there is a history entry increment route count.
2031 (bgp_damp_set): Check BGP_CONFIG_DAMPENING flag.
2032
2033 * bgp_damp.c (bgp_damp_withdraw): Set status to
2034 BGP_DAMP_DISCONTINUE.
2035
20362001-01-11 Kunihiro Ishiguro <kunihiro@zebra.org>
2037
2038 * bgp_attr.c (bgp_mp_reach_parse): Fix warning code when second
2039 IPv6 nexthop is not link-local addresss.
2040
20412001-01-11 "Akihiro Mizutani" <mizutani@dml.com>
2042
2043 * bgp_damp.c (bgp_config_write_damp): Smart flap dampening
2044 configuration display.
2045 (bgp_damp_info_print): Display elapsed time from flap started.
2046
2047 * bgp_damp.h (struct bgp_damp_info): Add flap start time.
2048
2049 * bgpd.c (peer_create): Set last read time.
2050 (bgp_show_peer): Display last read time.
2051 (bgp_show_summary): Use BGP_CONFIG_DAMPENING flag to check
2052 configuration.
2053
2054 * bgpd.h (BGP_CONFIG_DAMPENING): Add new configuration option.
2055 (struct peer): Add last read time member.
2056 (BGP_VERSION_MP_4): Remove obsolete definition.
2057
20582001-01-10 Kunihiro Ishiguro <kunihiro@zebra.org>
2059
2060 * bgp_nexthop.c: Remove OLD_RIB codes.
2061
2062 * bgp_route.c (bgp_process): Likewise.
2063
2064 * zebra-0.90 is released.
2065
2066 * bgp_route.h (BGP_INFO_HISTORY): Remove damped member from struct
2067 bgp_info. Instead of that use BGP_INFO_DAMPED flag.
2068 (struct bgp_info): Remove invalid member from struct bgp_info.
2069 Instead of that use BGP_INFO_HISTORY flag.
2070
20712001-01-10 "Akihiro Mizutani" <mizutani@dml.com>
2072
2073 * bgp_damp.c (bgp_damp_info_print): New function to display
2074 dampening status.
2075 (DEFAULT_HARF_LIFE): Define default value.
2076 (DEFAULT_REUSE): Likewise.
2077 (DEFAULT_SUPPRESS): Likewise.
2078 (bgp_config_write_damp): When config value is same as default
2079 value, simply display "bgp dampening" to configuration.
2080
2081 * bgp_damp.h (struct bgp_damp_info): Add flap member.
2082
2083 * bgp_route.h (struct bgp_info): Added for BGP flap dampening
2084 history status.
2085
20862001-01-10 Kunihiro Ishiguro <kunihiro@zebra.org>
2087
2088 * bgp_nexthop.c (bgp_connected_add): Point-to-point connected
2089 address is properly handled.
2090 (bgp_connected_delete): Likewise.
2091
2092 * bgp_route.c (bgp_route_init): Turn off BGP Flap dampening code
2093 until it works fine.
2094
20952001-01-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2096
2097 * bgpd.c (bgp_show_summary): Add BGP_VERSION_MP_4 case.
2098
2099 * bgp_route.c (bgp_update): When this is not damped route, clear
2100 ri pointer.
2101
21022001-01-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2103
2104 * bgp_main.c: Add "-n" no_kernel option to not install route to
2105 kernel. Suggested by: "Matt Ranney" <mjr@ranney.com>
2106
21072001-01-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2108
2109 * bgp_nexthop.c (bgp_connected_add): Revert point-to-point
2110 connected route patch. Reported by ruud@ruud.org (Ruud de Rooij)
2111
2112 * bgp_damp.c (bgp_config_write_damp): Add configuration display
2113 function.
2114
2115 * bgp_route.c (bgp_info_free): Set NULL to BGP dampening
2116 information when BGP info structure is freed.
2117 (bgp_info_cmp): Check damped flag.
2118 (bgp_announce_check): Damped route is not announced.
2119
21202001-01-09 "Akihiro Mizutani" <mizutani@dml.com>
2121
2122 * bgpd.c (neighbor_capability_route_refresh): Change "neighbor
2123 route-refresh" command to "neighbor capability route-refresh".
2124 (clear_bgp_soft_in): Change soft-reconfig method.
2125
2126 clear ip bgp <neighbor> soft in
2127 --------------------------------------
2128 Try stored cache first then route-refresh
2129
2130 clear ip bgp <neighbor> in
2131 ---------------------------------
2132 Try route-refresh first then try to use stored cache
2133
21342001-01-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2135
2136 * bgp_nexthop.c (bgp_connected_add): Check point-to-point
2137 connected route. Reported by ruud@ruud.org (Ruud de Rooij)
2138
21392001-01-08 Kunihiro Ishiguro <kunihiro@zebra.org>
2140
2141 * bgp_nexthop.c (bgp_nexthop_lookup): When IBGP nexthop is
2142 changed, refresh it.
2143
21442001-01-04 Kunihiro Ishiguro <kunihiro@zebra.org>
2145
2146 * bgp_route.h (struct bgp_info_tag): Add as_selected to
2147 bgp_info_tag.
2148
21492001-01-03 Kunihiro Ishiguro <kunihiro@zebra.org>
2150
2151 * bgp_route.h (struct bgp_info_tag): Add damped and bgp_damp_info
2152 member for BGP flap dampening.
2153
2154 * bgp_damp.c: New file is added.
2155
2156 * bgp_damp.h: Likewise.
2157
21582001-01-01 Kunihiro Ishiguro <kunihiro@zebra.org>
2159
2160 * bgpd.h (BGP_VTYSH_PATH): Change "/tmp/bgpd" to "/tmp/.bgpd".
2161
21622000-12-29 Kunihiro Ishiguro <kunihiro@zebra.org>
2163
2164 * bgp_nexthop.c (zlookup_connect): Change to use UNIX domain
2165 socket for zebra communication.
2166
21672000-12-29 Akihiro Mizutani <mizutani@dml.com>
2168
2169 * bgp_route.c (bgp_process): Fix "bgp deterministic-med" process.
2170
21712000-12-27 Akihiro Mizutani <mizutani@dml.com>
2172
2173 * bgp_route.c (bgp_process): Add "bgp deterministic-med" process.
2174
21752000-12-25 Akihiro Mizutani <mizutani@dml.com>
2176
2177 * bgp_route.c (bgp_info_cmp): Use ntohl comparing router ID.
2178
21792000-12-18 Akihiro Mizutani <mizutani@dml.com>
2180
2181 * bgp_route.c (bgp_info_cmp): When over three same prefix exit,
2182 withdrawing best prefix perform router ID comparison.
2183
21842000-12-15 Akihiro Mizutani <mizutani@dml.com>
2185
2186 * bgp_route.c (bgp_info_cmp): Do not compare router ID when the
2187 routes comes from EBGP peer. When originator ID is same, take
2188 shorter cluster-list route. If cluster-list is same take smaller
2189 IP address neighbor's route.
2190
2191 * bgpd.c (bgp_bestpath_aspath_ignore): Add "bgp bestpath as-path
2192 ignore" command. When this option is set, do not concider AS path
2193 length when route selection.
2194 (bgp_bestpath_compare_router_id): Add "bgp bestpath
2195 compare-routerid". When this option is set, compare router ID
2196 when the routes comes from EBGP peer.
2197
21982000-12-15 Akihiro Mizutani <mizutani@dml.com>
2199
2200 * bgp_route.c (bgp_info_cmp): Compare originator ID when it is
2201 available.
2202
22032000-12-14 Akihiro Mizutani <mizutani@dml.com>
2204
2205 * bgp_packet.c (bgp_notify_receive): Disply received Notify data
2206 information.
2207
22082000-12-14 Kunihiro Ishiguro <kunihiro@zebra.org>
2209
2210 * bgp_filter.c (as_filter_free): Use MTYPE_AS_FILTER_STR to make
2211 it sure the memory is freed.
2212
2213 * bgp_route.c (route_vty_out_detail): Do not use AF_INET6 outside
2214 HAVE_IPV6.
2215
22162000-12-08 Akihiro Mizutani <mizutani@dml.com>
2217
2218 * bgp_packet.c (bgp_notify_send_with_data): Store BGP notification
2219 data part.
2220
2221 * bgp_network.c (bgp_accept): When BGP connection comes from
2222 unconfigured IP address, close socket immediately.
2223
2224 * bgpd.c: Fix some display format.
2225
22262000-11-29 Kunihiro Ishiguro <kunihiro@zebra.org>
2227
2228 * bgp_packet.c (bgp_keepalive_send): Delete duplicate
2229 bgp_packet_set_size () call.
2230
22312000-11-28 Kunihiro Ishiguro <kunihiro@zebra.org>
2232
2233 * bgp_packet.c (bgp_read_packet): Remove debug codes.
2234
22352000-11-27 Kunihiro Ishiguro <kunihiro@zebra.org>
2236
2237 * bgp_snmp.c (write_bgpPeerTable): Add SNMP set method routine.
2238
2239 * bgp_fsm.c (bgp_stop): Use fsm_change_status to change peer's
2240 status.
2241 (bgp_establish): Likewise.
2242
22432000-11-26 Akihiro Mizutani <mizutani@dml.com>
2244
2245 * bgp_open.c: Fix error messages.
2246
22472000-11-25 Kunihiro Ishiguro <kunihiro@zebra.org>
2248
2249 * bgp_fsm.c (bgp_establish): Call BGP trap when the peer is
2250 established.
2251 (bgp_stop): Call BGP trap when the peer is dropped.
2252
22532000-11-24 Kunihiro Ishiguro <kunihiro@zebra.org>
2254
2255 * bgp_snmp.c (bgp4PathAttrTable): Return BGP path attribute table.
2256
2257 * bgpd.h (struct peer): Add update_time for track last update
2258 received time.
2259
2260 * bgp_packet.c (bgp_notify_receive): Preserv notify code and sub
2261 code in any case.
2262
2263 * bgp_snmp.c (bgpPeerTable): Return remote router ID instead of
2264 peering IP address.
2265 (bgpPeerTable): Return actual BGP version number.
2266
22672000-11-22 Akihiro Mizutani <mizutani@dml.com>
2268
2269 * bgp_debug.c (bgp_notify_print): Notify data length display bug
2270 is fixed.
2271
22722000-11-16 Kunihiro Ishiguro <kunihiro@zebra.org>
2273
2274 * bgp_nexthop.c (zlookup_connect): When UNIX domain connection to
2275 zebra is enabled, use the method.
2276
22772000-11-16 Akihiro Mizutani <mizutani@dml.com>
2278
2279 * bgpd.c: Revise debug message output.
2280
22812000-11-15 Akihiro Mizutani <mizutani@dml.com>
2282
2283 * bgp_clist.c (ip_community_list): Fix bug of string comparison.
2284
22852000-11-14 Akihiro Mizutani <mizutani@dml.com>
2286
2287 * bgp_community.c (community_match): Fix bug of memcmp return
2288 value check.
2289
22902000-11-07 Kunihiro Ishiguro <kunihiro@zebra.org>
2291
2292 * bgp_clist.c (community_list_match_exact): Add check for
2293 entry->style is COMMUNITY_LIST.
2294 (community_match_regexp): Apply new com_nthval macro.
2295
22962000-11-07 Rick Payne <rickp@rossfell.co.uk>
2297
2298 * bgp_routemap.c (route_set_community_delete): "set
2299 community-delete COMMUNITY-LIST" is added.
2300
2301 * bgp_community.c (community_del_val): Delete one community.
2302 (community_delete): Delete all community included in list.
2303 (community_match): Fix bug of matching community value.
2304
2305 * bgp_clist.c (community_entry_free): Free community regular
2306 expression.
2307 (community_entry_make): Default style is COMMUNITY_LIST.
2308 (community_entry_lookup): Make it sure style is COMMUNITY_LIST.
2309 (community_entry_regexp_lookup): New function for community
2310 regular expression lookup.
2311 (community_match_regexp): New function.
2312 (community_delete_regexp): New function.
2313 (community_list_delete_entries): New function.
2314 (community_list_match): Add COMMUNITY_REGEXP treatment.
2315 (community_list_match_exact): Likewise.
2316 (config_write_community): Write community list according to
2317 entry->style.
2318
23192000-11-07 Rick Payne <rickp@rossfell.co.uk>
2320
2321 * bgp_attr.c (bgp_attr_aspath): AS path first AS check.
2322
2323 * bgp_clist.c (struct community_entry): Add style, regexp, reg to
2324 community_entry.
2325
23262000-11-06 Rick Payne <rickp@rossfell.co.uk>
2327
2328 * bgp_aspath.c (aspath_firstas_check): AS path first AS check.
2329
2330 * bgpd.c (bgp_enforce_first_as): New command "bgp
2331 enforce-first-as".
2332
2333 * bgpd.h (BGP_CONFIG_ENFORCE_FIRST_AS): Add new flag.
2334
23352000-11-06 Kunihiro Ishiguro <kunihiro@zebra.org>
2336
2337 * bgp_community.c (community_compare): Copy byte stream data to
2338 actual value instead of using type casting hack.
2339 (community_add_val): Likewise.
2340 (community_uniq_sort): Likewise.
2341 (community_print): Likewise.
2342 (community_print_vty): Likewise.
2343 (community_include): Use memcmp to compare community value.
2344
2345 * bgp_community.h (com_lastval): com_lastval and com_nthval macro
2346 return pointer.
2347
23482000-11-06 Akihiro Mizutani <mizutani@dml.com>
2349
2350 * bgpd.h (struct peer): Add established and dropped member for
2351 count peering up/down statistics.
2352
2353 * bgpd.c (bgp_show_peer): Display peering up/down statistics.
2354
2355 * bgp_fsm.c (bgp_establish): Increment established count.
2356 (bgp_stop): Increment dropped count.
2357
2358 * bgp_packet.c (bgp_notify_receive): Increament notify count.
2359
23602000-11-1 Akihiro Mizutani <mizutani@dml.com>
2361
2362 * bgp_fsm.c: Fix bug of holdtimer is not reset when bgp cleared.
2363
23642000-10-31 Kunihiro Ishiguro <kunihiro@zebra.org>
2365
2366 * bgpd.h: Static bit flag is set by (1 << DIGIT).
2367
23682000-10-24 Akihiro Mizutani <mizutani@dml.com>
2369
2370 * bgp_ecommunity.c (ecommunity_dup): Extended community display
2371 format fix.
2372
23732000-10-24 Arkadiusz Miskiewicz <misiek@pld.org.pl>
2374
2375 * bgp_network.c (bgp_serv_sock_addrinfo): Use gai_strerror.
2376 (bgp_serv_sock_addrinfo): Check address family.
2377
23782000-10-23 Jochen Friedrich <jochen@scram.de>
2379
2380 * bgp_snmp.c: bgp_oid and bgpd_oid are used in smux_open after it
2381 is registered. So those variables must be static.
2382
23832000-10-23 Akihiro Mizutani <mizutani@dml.com>
2384
2385 * bgp_routemap.c (route_match_ip_next_hop): Change "match ip
2386 next-hop" argument from IP address to access-list name.
2387 Remove zebra-0.88 compatibility commands.
2388 "match ip prefix-list WORD"
2389 "match ipv6 prefix-list WORD"
2390
23912000-10-23 Kunihiro Ishiguro <kunihiro@zebra.org>
2392
2393 * bgp_routemap.c (route_match_ipv6_next_hop_compile): Fix bug of
2394 passing the pointer to the pointer of struct in6_addr instead of
2395 the pointer of struct in6_addr in "match ipv6 next-hop" command.
2396
2397 * bgp_route.c (bgp_announce_check): Enclose IPv6 part with
2398 HAVE_IPV6.
2399
24002000-10-20 Jasper Wallace <jasper@ivision.co.uk>
2401
2402 * bgp_snmp.c (bgpPeerTable): ntohs missing bug is fixed. Change
2403 to use linklist.c. Define COUNTER32 as ASN_COUNTER.
2404
24052000-10-18 Kunihiro Ishiguro <kunihiro@zebra.org>
2406
2407 * bgp_route.c (bgp_announce_check): attr->nexthop empty check
2408 should be done by attr->nexthop.s_addr instead of strcmp.
2409
24102000-10-18 Akihiro Mizutani <mizutani@dml.com>
2411
2412 * bgp_zebra.c (zebra_read_ipv4): Pass nexthop value to
2413 bgp_redistribute_add().
2414
2415 * bgp_nexthop.c (bgp_multiaccess_check_v4): New function for
2416 checking IPv4 multiaccess nexthop.
2417
2418 * bgp_route.c (bgp_announce_check): In case of the nexthop is
2419 reachable on multiaccess media, do not change nexthop.
2420 (bgp_redistribute_add): Set nexthop when the value is passed.
2421
24222000-10-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2423
2424 * bgp_fsm.c (bgp_timer_set): If peer is passive mode, do not set
2425 connect timer.
2426 (bgp_start): If the peer is passive mode, force to move to Active
2427 mode.
2428
24292000-10-17 Horms <horms@vergenet.net>
2430
2431 * bgp_debug.c (debug_bgp_fsm): Fix typo.
2432
24332000-10-17 Akihiro Mizutani <mizutani@dml.com>
2434
2435 * bgp_route.c: "show ipv6 bgp" route display improvement.
2436
24372000-10-03 Kunihiro Ishiguro <kunihiro@zebra.org>
2438
2439 * bgp_route.c (neighbor_routes): Allocate sockunion for callback
2440 function.
2441 (bgp_show_neighbor_route): Remove static declaration for union
2442 sockunion.
2443
2444 * bgpd.c (peer_update_source_set): Clean previously allocated
2445 memory before allocate new one.
2446
24472000-10-03 Akihiro Mizutani <mizutani@dml.com>
2448
2449 * bgp_route.c (neighbor_routes): Add show neighbor's routes
2450 command.
2451 "show ip bgp neighbors (A.B.C.D|X:X::X:X) routes"
2452 "show ip bgp ipv4 (unicast|multicast) neighbors (A.B.C.D|X:X::X:X) routes"
2453 "show ipv6 bgp neighbors (A.B.C.D|X:X::X:X) routes"
2454 "show ipv6 mbgp neighbors (A.B.C.D|X:X::X:X) routes"
2455
24562000-10-02 Kunihiro Ishiguro <kunihiro@zebra.org>
2457
2458 * zebra-0.89 is released.
2459
24602000-10-02 Akihiro Mizutani <mizutani@dml.com>
2461
2462 * bgpd.c: "bgp deterministic-med" command is added.
2463
24642000-10-02 Kunihiro Ishiguro <kunihiro@zebra.org>
2465
2466 * bgp_nexthop.c (bgp_connected_add): Apply mask for connected
2467 route addition and deletion.
2468
24692000-09-29 Kunihiro Ishiguro <kunihiro@zebra.org>
2470
2471 * bgp_aspath.c (aspath_cmp_left): Skip confederation AS segment
2472 when comparing leftmost AS number.
2473
24742000-09-29 Akihiro Mizutani <mizutani@dml.com>
2475
2476 * bgpd.c (peer_route_reflector): Route reflector can be set for
2477 IBGP peer.
2478 (bgp_distribute_set): Fix bug of string check for (in|out).
2479 (bgp_show_summary): Display total neighbor count.
2480
24812000-09-28 Akihiro Mizutani <mizutani@dml.com>
2482
2483 * bgp_attr.c (bgp_packet_attribute): Only add cluster_list and
2484 originator for clinet to client routes.
2485 (bgp_packet_attribute): Add new cluster_list to the beginning of
2486 existing cluster_list.
2487 (bgp_packet_attribute): Fix bug of originator is rewritten even
2488 when originator is already set.
2489
24902000-09-27 Kunihiro Ishiguro <kunihiro@zebra.org>
2491
2492 * bgpd.c (bgp_client_to_client_reflection): Add new command.
2493 "no bgp client-to-client reflection"
2494 "bgp client-to-client reflection"
2495
2496 * bgpd.h (BGP_CONFIG_NO_CLIENT_TO_CLIENT): Add new definition.
2497
24982000-09-26 Kunihiro Ishiguro <kunihiro@zebra.org>
2499
2500 * bgp_packet.c (bgp_read): Make BGP packet read to non-blocking
2501 read.
2502 (bgp_read_packet): Likewise.
2503 (bgp_read_packet): When errono is EAGAIN, try to read it again.
2504
2505 * bgp_fsm.c (bgp_stop): Clear packet size and read buffer.
2506
25072000-09-26 Akihiro Mizutani <mizutani@dml.com>
2508
2509 * bgp_routemap.c: Configuration of prefix-list match is shown as
2510 "match ip address prefix-list <WORD>". Old configuration "match
2511 ip prefix-list <WORD>" is left for compatibilitty.
2512
25132000-09-25 Akihiro Mizutani <mizutani@dml.com>
2514
2515 * bgpd.h (BGP_CONFIG_MED_MISSING_AS_WORST): Changed from
2516 BGP_CONFIG_MISSING_AS_WORST.
2517
2518 * bgpd.c (bgp_bestpath_med): Change missing-as-worst syntax.
2519 Old "bgp bestpath missing-as-worst"
2520 New "bgp bestpath med missing-as-worst"
2521
25222000-09-24 Akihiro Mizutani <mizutani@dml.com>
2523
2524 * bgp_route.c: Compare MED properly in case of CONFED-IBGP.
2525
25262000-09-21 steve@Watt.COM (Steve Watt)
2527
2528 * bgp_debug.h: Do not declare debug variables conf_bgp_debug_* and
2529 term_bgp_debug_*.
2530
2531 * bgp_debug.c: Declare variables here.
2532
25332000-09-21 Akihiro Mizutani <mizutani@dml.com>
2534
2535 * bgpd.c: MBGP soft-reconfiguration command is added.
2536 clear ip bgp x.x.x.x ipv4 (unicast|multicast) in
2537 clear ip bgp x.x.x.x ipv4 (unicast|multicast) out
2538 clear ip bgp x.x.x.x ipv4 (unicast|multicast) soft
2539 clear ip bgp <1-65535> ipv4 (unicast|multicast) in
2540 clear ip bgp <1-65535> ipv4 (unicast|multicast) out
2541 clear ip bgp <1-65535> ipv4 (unicast|multicast) soft
2542 clear ip bgp * ipv4 (unicast|multicast) in
2543 clear ip bgp * ipv4 (unicast|multicast) out
2544 clear ip bgp * ipv4 (unicast|multicast) soft
2545
2546 Change "clear ip bgp vpnv4 x.x.x.x soft" command to
2547 "clear ip bgp x.x.x.x vpnv4 unicast soft".
2548
2549 "bgp bestpath med confed" command is added.
2550
2551 * bgpd.h (BGP_CONFIG_MED_CONFED): Add New definition.
2552
25532000-09-18 Rick Payne <rickp@rossfell.co.uk>
2554
2555 * bgpd.c (bgp_show_peer): Fix misplaced #endif.
2556
25572000-09-12 Akihiro Mizutani <mizutani@dml.com>
2558
2559 * bgpd.c (bgp_default_local_preference): Add "bgp default
2560 local-preference" command.
2561
2562 * bgp_nexthop.c (no_bgp_scan_time): Add "no bgp scan-time"
2563 command.
2564
25652000-09-10 Kunihiro Ishiguro <kunihiro@zebra.org>
2566
2567 * bgp_zebra.c (bgp_zebra_announce): BGP confederation peer's routes
2568 are passed to zebra like IBGP route.
2569
25702000-09-10 Akihiro Mizutani <mizutani@dml.com>
2571
2572 * bgpd.c (bgp_config_write_peer): Make it consistent passive
2573 configuration.
2574
2575 * bgp_route.c: Community match command is added.
2576 "show ip bgp community <val>"
2577 "show ip bgp community <val> exact-match"
2578
25792000-09-08 Kunihiro Ishiguro <kunihiro@zebra.org>
2580
2581 * bgp_nexthop.c (bgp_nexthop_lookup): ebgp-multihop routes are
2582 treated as IBGP routes.
2583
25842000-09-08 Akihiro Mizutani <mizutani@dml.com>
2585
2586 * bgp_route.c (bgp_show_route): When local-AS community route is
2587 selected, display "not advertised outside local AS" to "show ip
2588 route A.B.C.D" output.
2589 (show_ip_bgp_ipv4_filter_list): Add below four commands.
2590 "show ip bgp ipv4 (unicast|multicast) filter-list WORD"
2591 "show ip bgp ipv4 (unicast|multicast) community"
2592 "show ip bgp ipv4 (unicast|multicast) community-list WORD"
2593 "show ip bgp ipv4 (unicast|multicast) community-list WORD exact-match"
2594
2595 * bgp_clist.c (community_list_match_exact): Community exact match
2596 function.
2597
25982000-09-07 Kunihiro Ishiguro <kunihiro@zebra.org>
2599
2600 * bgp_route.c (bgp_update): Add peer's ttl check.
2601
2602 * bgpd.h (struct peer): Structure member refresh is renamed to
2603 refresh_adv.
2604
2605 * bgpd.c (clear_bgp_soft_in): Check PEER_FLAG_ROUTE_REFRESH flag
2606 when soft reconfiguration is performed.
2607
2608 * bgp_zebra.c (bgp_zebra_announce): When the peer is EBGP and
2609 ebgp-multiphop is set, set ZEBRA_FLAG_INTERNAL for nexthop lookup.
2610
2611 * bgp_route.h (struct bgp_info_tag): Add valid flag.
2612
26132000-08-25 Akihiro Mizutani <mizutani@dml.com>
2614
2615 * bgpd.c: Add AS base BGP soft reconfiguration.
2616
2617 * bgp_route.c: When no-advertise or no-export route is selected,
2618 "show ip bgp" display "not advertised to EBGP peer" or "not
2619 advertised to any peer" message.
2620
26212000-08-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2622
2623 * zebra-0.88 is released.
2624
2625 * bgp_dump.c (dump_bgp_routes): Change "dump bgp routes" to "dump
2626 bgp route-mrt" to support MRT specific dump format.
2627
2628 * bgpd.c (bgp_init): "clear ip bgp vpnv4 soft {in,out}" command is
2629 added.
2630
2631 * bgp_route.c (bgp_update): Currently nexthop check is only works
2632 for IPv4.
2633
26342000-08-17 Akihiro Mizutani <mizutani@dml.com>
2635
2636 * bgpd. (clear_ip_bgp_all_soft): Add "clear ip bgp * soft" for
2637 both inbound and outbound soft reconfiguration.
2638
26392000-08-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2640
2641 * bgpd.c (clear_ip_bgp_peer_soft_out): Add soft-reconfiguration
2642 outbound.
2643 (peer_new): Set route-refresh flag.
2644
26452000-08-16 Akihiro Mizutani <mizutani@dml.com>
2646
2647 * bgpd.c: "no bgp router-id A.B.C.D" alias is added. "no bgp
2648 cluster-id A.B.C.D" alias is added. " bgp cluster-id
2649 <1-4294967295>" alias is added. "clear ip bgp * soft in" command
2650 is added. "clear ip bgp A.B.C.D in" alias is added. "clear ip
2651 bgp * in" alias is added.
2652
26532000-08-16 Kunihiro Ishiguro <kunihiro@zebra.org>
2654
2655 * bgp_route.c (bgp_update): Add soft_reconfig flag. When the flag
2656 is set do not install the route into Adj-RIBs-In.
2657 (bgp_update): Perform implicit withdraw before filtering of the
2658 route.
2659
2660 * bgp_packet.c (bgp_read): draft-ietf-idr-bgp-route-refresh-01.txt
2661 capability code and BGP message can be accepted.
2662
2663 * bgp_open.c (bgp_capability_parse): Likewise.
2664
2665 * bgp_route.c (bgp_refresh_table): New function for route refresh.
2666 (bgp_refresh_rib): Likewise.
2667
2668 * bgpd.c (bgp_show_peer): Display route refresh status.
2669
2670 * bgp_route.c (bgp_aggregate_add): Add check for the route
2671 validness.
2672 (bgp_aggregate_delete): Likewise.
2673
26742000-08-15 Kunihiro Ishiguro <kunihiro@zebra.org>
2675
2676 * bgp_nexthop.c (bgp_scan): Care for aggregate route when the
2677 route become inaccessible.
2678
26792000-08-15 Akihiro Mizutani <mizutani@dml.com>
2680
2681 * bgp_route.c (show_ip_bgp_prefix): "show ip bgp A.B.C.D/M"
2682 command is added.
2683
26842000-08-15 Kunihiro Ishiguro <kunihiro@zebra.org>
2685
2686 * bgp_zebra.c (bgp_interface_up): Register connected route.
2687 (bgp_interface_down): Unregister connected route.
2688
26892000-08-14 Kunihiro Ishiguro <kunihiro@zebra.org>
2690
2691 * bgp_route.h (struct bgp_info): Add distance to the structure.
2692
2693 * bgp_route.c (bgp_aggregate_increment): Aggregate route only
2694 match to smaller prefixlen route not match same prefixlen route.
2695 (bgp_aggregate_decrement): Likewise.
2696 (bgp_aggregate_add): Likewise.
2697 (bgp_aggregate_delete): Likewise.
2698 (bgp_network_backdoor): Add backdoor network configuration.
2699
2700 * bgpd.h (struct bgp ): Add distance_{ebgp,ibgp,local} for store
2701 configuration distance value.
2702
2703 * bgp_route.c (bgp_update): Filter EBGP route which has non
2704 connected nexthop.
2705
2706 * bgp_attr.c (bgp_attr_aggregate_intern): New function for
2707 aggregate route. Set origin to IGP. Set atomic aggregate flag.
2708 Set aggregator AS and address.
2709 (bgp_attr_aggregate_intern): Check BGP_CONFIG_CONFEDERATION when
2710 filling aggregator_as.
2711
2712 * bgp_route.c (bgp_process): Delete suppress check for install
2713 suppressed route into local routing table.
2714 (bgp_aggregate_increment): Use bgp_attr_aggregate_intern() instead
2715 of bgp_attr_default_intern ().
2716 (bgp_aggregate_add): Likewise.
2717
2718 * bgpd.c (bgp_get): Call bgp_if_update_all() after BGP instance is
2719 created. This is for avoid 0.0.0.0 router-id.
2720
27212000-08-13 Akihiro Mizutani <mizutani@dml.com>
2722
2723 * bgp_route.c (route_vty_out_detail): Display "valid" when the
2724 route is valied. Display "aggregated" when the route is
2725 aggregated. "Advertisements suppressed by an aggregate" is
2726 displayed when the route is suppressed.
2727 (bgp_info_cmp): Prefer EBGP than Confed-EBGP.
2728
27292000-08-10 Akihiro Mizutani <mizutani@dml.com>
2730
2731 * bgp_route.c (route_vty_out_detail): Display format change.
2732
27332000-08-06 Kunihiro Ishiguro <kunihiro@zebra.org>
2734
2735 * bgp_route.c (bgp_update): Only AFI_IP nexthop check is enabled.
2736
2737 * bgpd.c (bgp_delete): Delete static route before delete peer
2738 configuration.
2739
27402000-08-02 Kunihiro Ishiguro <kunihiro@zebra.org>
2741
2742 * bgpd.c: Include bgpd/bgp_nexthop.h.
2743
27442000-07-31 Akihiro Mizutani <mizutani@dml.com>
2745
2746 * bgpd.c (bgp_show_summary): "show ip bgp summary" shows own BGP
2747 identifier. And status is changed like below.
2748
2749 State/Pref -> State/PfxRcd
2750 Shutdown -> Idle (Admin)
2751 PrefixOvflw -> Idle (PfxCt)
2752
2753 * bgp_route.c (route_vty_out): Show internal route as "i".
2754
27552000-07-13 Jim Bowen <jimb@zereau.net>
2756
2757 * bgp_snmp.c: Add BGP peer MIB implementation.
2758
27592000-07-12 Akihiro Mizutani <mizutani@dml.com>
2760
2761 * bgpd.c (bgp_show_peer): Fix typo.
2762
27632000-07-11 Akihiro Mizutani <mizutani@dml.com>
2764
2765 * bgp_routemap.c: Add commands for deleting set without argument.
2766
27672000-07-03 Akihiro Mizutani <mizutani@dml.com>
2768
2769 * bgp_zebra.c: Fix redistribute help strings.
2770
27712000-07-01 Kunihiro Ishiguro <kunihiro@zebra.org>
2772
2773 * bgp_route.c (bgp_show): When bgpd works as vtysh server send all
2774 output to vty at once.
2775
27762000-06-13 Kunihiro Ishiguro <kunihiro@zebra.org>
2777
2778 * bgp_mplsvpn.c (no_vpnv4_network): "no network A.B.C.D/M rd WORD
2779 tag WORD" command is added.
2780
2781 * bgp_ecommunity.c (ecommunity_vty_out): New function added.
2782
27832000-06-12 Kunihiro Ishiguro <kunihiro@zebra.org>
2784
2785 * bgp_route.c (bgp_show): Fix total number of prefix count bug.
2786
2787 * bgpd.c (bgp_show_peer): Display VPNv4 unicast configuration and
2788 negotiation result in "show ip bgp neighbors".
2789
27902000-06-12 Akihiro Mizutani <mizutani@dml.com>
2791
2792 * bgpd.c: Fix help strings.
2793
2794 * bgpd.h: Likewise.
2795
27962000-06-11 Kunihiro Ishiguro <kunihiro@zebra.org>
2797
2798 * bgp_route.c (bgp_aggregate_unset): Fix bug of checking rn->info
2799 instead of rn. Reported by Akihiro Mizutani <mizutani@dml.com>.
2800
2801 * bgp_mplsvpn.c (vpnv4_network): For testing purpose, "network
2802 A.B.C.D rd RD" is added to address-family vpnv4 unicast node.
2803
2804 * bgp_route.c (bgp_static_set): Set safi to p.safi.
2805
28062000-06-10 Kunihiro Ishiguro <kunihiro@zebra.org>
2807
2808 * bgp_route.c (bgp_show_prefix_list): Change to use bgp_show().
2809 (bgp_show_regexp): Change to use bgp_show().
2810 (show_adj_route): Change to display header.
2811
2812 * bgpd.c (clear_bgp): Set peer->v_start to default value when peer
2813 is cleared manually.
2814
2815 * bgp_route.c (bgp_show_route): New function which display
2816 specific BGP route. Divided from bgp_show().
2817 (bgp_static_delete): Delete all static route.
2818
28192000-06-09 NOGUCHI Kay <kay@v6.access.co.jp>
2820
2821 * bgp_route.c (show_ipv6_bgp): "show ipv6 bgp" is broken with
2822 invalid privious fix. Now show_ipv6_bgp and show_ipv6_bgp_route
2823 take care of "show ipv6 bgp [X:X::X:X]". Same change for "show ip
2824 mbgp" and "show ipv6 mbgp".
2825
28262000-06-07 Akihiro Mizutani <mizutani@dml.com>
2827
2828 * bgp_route.c: Fix help strings and command arguments.
2829
28302000-06-06 Kunihiro Ishiguro <kunihiro@zebra.org>
2831
2832 * bgp_ecommunity.c: Include prefix.h
2833
28342000-06-05 Kunihiro Ishiguro <kunihiro@zebra.org>
2835
2836 * bgp_route.h (struct bgp_info_tag): New structure to hold tag
2837 value.
2838
2839 * bgp_route.c (bgp_adj_set): table NULL check is added.
2840 (bgp_adj_unset): Likewise.
2841 (bgp_adj_lookup): Likewise.
2842 (bgp_adj_clear): Likewise.
2843 (route_vty_out): Add SAFI check for nexthop display.
2844 (bgp_withdraw): Add SAFI check for withdraw route.
2845
2846 * Remove all #ifdef MPLS_VPN then include it as default.
2847
2848 * bgpd.c: Temporary disable peer-group command until the
2849 implementation is completed.
2850
2851 * bgp_routemap.c (bgp_route_map_init): Install
2852 route_metric_match_cmd.
2853 (route_match_metric_compile): MED value compile using strtoul.
2854
28552000-06-05 Akihiro Mizutani <mizutani@dml.com>
2856
2857 * bgp_filter.c: Fix help strings. Change REGEXP to LINE. Change
2858 NAME to WORD.
2859
2860 * Change command argument to more comprehensive.
2861
2862 METRIC -> <0-4294967295>
2863 WEIGHT -> <0-4294967295>
2864 LOCAL_PREF -> <0-4294967295>
2865 IP_ADDR -> A.B.C.D
2866 AS -> <1-65535>
2867 AS-PATH-NAME -> WORD
2868 ACCESS_LIST -> WORD
2869 PREFIX_LIST -> WORD
2870 COMMUNITY -> AA:NN
2871 EXT_COMMUNITY -> ASN:nn_or_IP-address:nn
2872 IPv6_ADDR -> X:X::X:X
2873
2874 * bgp_clist.c: Fix help strings.
2875
28762000-06-03 Kunihiro Ishiguro <kunihiro@zebra.org>
2877
2878 * bgpd.c (peer_active): Add new function for check the peer is
2879 active or not.
2880 (neighbor_activate): New command "neighbor PEER activate" and "no
2881 neighbor PEER activate" are added.
2882
2883 * bgp_packet.c: Include bgpd/bgp_mplsvpn.h.
2884
28852000-06-02 Akihiro Mizutani <mizutani@dml.com>
2886
2887 * bgp_clist.c: Fix commuity-list help strings.
2888
2889 * bgp_routemap.c: Fix "set community" help strings. Add #define
2890 SET_STR. Use (unicast|multicast) argument for "set nlri" command.
2891
28922000-06-01 Kunihiro Ishiguro <kunihiro@zebra.org>
2893
2894 * bgp_routemap.c (route_set_community_none_cmd): "set community
2895 none" command is added to route-map.
2896
28972000-06-01 Akihiro Mizutani <mizutani@dml.com>
2898
2899 * bgp_debug.c: Change "show debug" to "show debugging". Now "show
2900 debugging" is not used in VIEW_NODE.
2901
29022000-05-30 Kunihiro Ishiguro <kunihiro@zebra.org>
2903
2904 * bgp_fsm.c (bgp_timer_set): Add check for shutdown flag. This
2905 fix unconditional BGP connection.
2906
2907 * bgpd.c (peer_shutdown): Replace peer_shutdown() with
2908 peer_change_flag_with_reset().
2909
29102000-05-26 Kunihiro Ishiguro <kunihiro@zebra.org>
2911
2912 * bgpd.c (no_bgp_default_ipv4_unicast): Add "no bgp default
2913 ipv4-unicast" command.
2914
2915 * bgpd.h (BGP_CONFIG_NO_DEFAULT_IPV4): Add new definition.
2916
2917 * bgp_filter.c (as_list_delete): Free all AS filter.
2918
2919 * bgp_clist.c (community_list_delete): Free all community entry.
2920
2921 * bgp_filter.c (no_ip_as_path_all): New DEFUN for "no ip as-path
2922 access-list NAME".
2923
2924 * bgp_clist.c (no_ip_community_list_all): New DEFUN for "no ip
2925 community-list NAME".
2926
29272000-05-19 Kunihiro Ishiguro <kunihiro@zebra.org>
2928
2929 * bgp_route.c (ipv6_mbgp_neighbor_routes): Change "show ip bgp PEER
2930 routes" to "show ip bgp PEER received-routes"
2931
29322000-05-14 Kunihiro Ishiguro <kunihiro@zebra.org>
2933
2934 * bgp_ecommunity.c (ecommunity_parse): New file for Extended
2935 Communities attribute.
2936 * bgp_ecommunity.h: Likewise.
2937
29382000-05-11 Kunihiro Ishiguro <kunihiro@zebra.org>
2939
2940 * bgp_mplsvpn.h: New file for MPLS-VPN.
2941 * bgp_mplsvpn.c: Likewise.
2942
2943 * bgpd.c (bgp_delete): Fix bug of "no router bgp" crush.
2944
29452000-05-10 Kunihiro Ishiguro <kunihiro@zebra.org>
2946
2947 * bgpd.c (bgp_bestpath_missing_as_worst): Add "bgp bestpath
2948 missing-as-worst".
2949
29502000-05-08 Kunihiro Ishiguro <kunihiro@zebra.org>
2951
2952 * bgp_routemap.c (match_community): Clarify help of "match
2953 community".
2954
29552000-05-02 Kunihiro Ishiguro <kunihiro@zebra.org>
2956
2957 * bgp_aspath.c (aspath_cmp_left): Remove debug code.
2958
29592000-04-27 Kunihiro Ishiguro <kunihiro@zebra.org>
2960
2961 * bgp_route.c (bgp_info_cmp): Compare MED only both routes comes
2962 from same neighboring AS.
2963
2964 * bgp_aspath.c (aspath_cmp_left): Compare leftmost AS value.
2965
2966 * bgp_route.c (bgp_info_cmp): Fix misused htonl() to ntohl().
2967
29682000-04-26 Kunihiro Ishiguro <kunihiro@zebra.org>
2969
2970 * bgp_route.c (bgp_output_filter): When distribute-list's
2971 corresponding access-list does not exist, filter all routes.
2972 (bgp_input_filter): Likewise.
2973
29742000-04-19 Kunihiro Ishiguro <kunihiro@zebra.org>
2975
2976 * bgp_attr.c (bgp_packet_attribute): Propagate MED to IBGP peer.
2977
2978 * bgp_route.c (bgp_info_cmp): Add evaluation of local preference.
2979
29802000-04-18 Kunihiro Ishiguro <kunihiro@zebra.org>
2981
2982 * bgpd.c (bgp_distribute_update): Add struct access_list *
2983 argument.
2984
29852000-04-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2986
2987 * bgp_clist.c (community_list_dup_check): Add duplicate insertion
2988 check.
2989
2990 * bgp_filter.c (as_list_dup_check): Add duplicate insertion check.
2991
2992 * bgp_route.c (bgp_show): Fix undeclared write variable.
2993
29942000-04-13 Kunihiro Ishiguro <kunihiro@zebra.org>
2995
2996 * bgp_routemap.c: Add "match ip address prefix-list".
2997
29982000-03-29 Rick Payne <rickp@rossfell.co.uk>
2999
3000 * bgp_aspath.c (aspath_strip_confed): Fix realloc problem.
3001
30022000-03-16 Kunihiro Ishiguro <kunihiro@zebra.org>
3003
3004 * bgp_fsm.c (bgp_reconnect): Connect retry timer is expired when
3005 the peer status is Connect.
3006
30072000-03-03 Kunihiro Ishiguro <kunihiro@zebra.org>
3008
3009 * Fix bug of rewritten originator-id.
3010
30112000-01-27 Rick Payne <rickp@rossfell.co.uk>
3012
3013 * bgp_aspath.c (aspath_delimiter_char): New function. Instead of
3014 directly referencing array, search proper AS path delimiter.
3015 (aspath_strip_confed): Strip the confederation stuff from the
3016 front of an AS path.
3017 (aspath_add_left_confed): New function for adding specified AS to
3018 the leftmost AS_CONFED_SEQUENCE.
3019
3020 * bgp_aspath.h: Change AS_CONFED_SEQUENCE and AS_CONFED_SET value
3021 to Cisco compatible.
3022
3023 * bgpd.c (bgp_confederation_id_set): Confederation configuration.
3024 (bgp_confederation_id_unset): Likewise.
3025 (bgp_confederation_peers_check): Likewise.
3026 (bgp_confederation_peers_add): Likewise.
3027 (bgp_confederation_peers_remove): Likewise.
3028 (bgp_confederation_peers_set): Likewise.
3029 (bgp_confederation_peers_unset): Likewise.
3030 (bgp_confederation_peers_print): Likewise.
3031
30322000-01-16 Kunihiro Ishiguro <kunihiro@zebra.org>
3033
3034 * bgpd.c: Introduce peer_change_flag_with_reset() fucntion.
3035
30362000-01-17 Kunihiro Ishiguro <kunihiro@zebra.org>
3037
3038 * bgp_open.c (bgp_open_option_parse): When there is no common
3039 capability send Unsupported Capability error to the peer.
3040
30412000-01-14 Kunihiro Ishiguro <kunihiro@zebra.org>
3042
3043 * bgp_open.c (bgp_capability_mp): Fix bug of mis-negotiation about
3044 IPv6 unicast.
3045
3046 * bgpd.c (bgp_init): Add "soft-reconfiguration inbound" command.
3047
30482000-01-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3049
3050 * bgpd.c (neighbor_strict_capability): Add
3051 "strict-capability-match" command.
3052
3053 * bgp_zebra.c (bgp_if_update): Ignore NET127 determining
3054 router-id.
3055
3056 * bgpd.c (peer_override_capability): Add "override-capability"
3057 command.
3058
30591999-12-16 Kunihiro Ishiguro <kunihiro@zebra.org>
3060
3061 * bgp_packet.c (bgp_write): Change status to Idle and set timer
3062 after write failed.
3063
30641999-12-14 Kunihiro Ishiguro <kunihiro@zebra.org>
3065
3066 * bgp_zebra.c (bgp_zebra_announce): Add info->selected check.
3067
30681999-12-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3069
3070 * bgp_route.c (nlri_unfeasible): nlri_unfeasible() is merged with
3071 nlri_parse().
3072
30731999-12-10 Kunihiro Ishiguro <kunihiro@zebra.org>
3074
3075 * bgp_fsm.h (BGP_EVENT_DELETE): Macro added.
3076
3077 * bgp_fsm.c (bgp_stop): Clear all event threads of the peer when
3078 the peer is cleared.
3079
3080 * bgp_zebra.c (bgp_nexthop_set): Clear interface index of
3081 link-local address. This is KAME specific problem.
3082
30831999-12-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3084
3085 * bgp_attr.c (bgp_mp_reach_parse): Comment out previous code for a
3086 while. We don't completely detect the link is shared or not at
3087 this moment.
3088
3089 * bgp_packet.c (bgp_notify_send): Make shortcut call of
3090 bgp_write() and bgp_stop().
3091
3092 * bgp_attr.c (bgp_mp_reach_parse): Fix serious bug when getting
3093 global and link-local address.
3094
30951999-12-05 Kunihiro Ishiguro <kunihiro@zebra.org>
3096
3097 * bgpd.c (no_neighbor_port): New command added.
3098 (peer_new): Set send_community.
3099
31001999-12-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3101
3102 * bgpd.c (show_ip_bgp_summary): Changed to use bgp_show_summary().
3103 (show_ip_mbgp_summary): Likewise.
3104 (show_ipv6_bgp_summary): Likewise.
3105 (show_ipv6_mbgp_summary): Add new command.
3106 (peer_free): Free peer->host.
3107 (peer_lookup_by_su): Delete function.
3108 (ipv6_bgp_neighbor): Changed to use peer_remote_as().
3109 (sockunion_vty_out): Function deleted.
3110 (vty_clear_bgp): Use afi instead of family.
3111 Delete old list bgp_list. Use struct newlist *bgplist.
3112 (peer_lookup_by_host): Function deleted.
3113
31141999-12-03 Kunihiro Ishiguro <kunihiro@zebra.org>
3115
3116 * bgpd.h (struct peer_group): New structure added.
3117 (struct peer_conf): New structure added.
3118 (struct peer): Change all prefix_count to unsigned long.
3119
3120 * bgpd.c: Reconstruct all of VTY commands reflect internal
3121 structure change.
3122 Use bgplist instead of bgp_list.
3123 Use peerlist intstead of peer_list.
3124
3125 * bgp_attr.c (bgp_mp_reach_parse): If nlri_parse return -1, stop
3126 parsing then return immediately.
3127
3128 * bgp_route.c (nlri_parse): When NLRI parse error occured, return
3129 -1.
3130 (nlri_process): Use pcount_v4_{unicast,multicast}.
3131 (nlri_delete): Likewise.
3132
31331999-11-25 Robert Olsson <Robert.Olsson@data.slu.se>
3134
3135 * bgp_routemap.c (route_match_nlri): `match nlri
3136 unicast|multicast' and `set nlri unicast|multicast' command are
3137 added.
3138
31391999-11-22 Robert Olsson <Robert.Olsson@data.slu.se>
3140
3141 * bgpd.c: Add translate-update support.
3142
3143 * bgpd.h (TRANSLATE_UPDATE_OFF): Add translate-update definition.
3144
31451999-11-19 Robert.Olsson@data.slu.se
3146
3147 * bgp_route.c (bgp_peer_delete): Add MBGP peer clear codes.
3148
31491999-11-14 Kunihiro Ishiguro <kunihiro@zebra.org>
3150
3151 * bgp_open.c (bgp_capability_mp): Temporary comment out
3152 SAFI_UNICAST_MULTICAST handling until we know the meanings.
3153
31541999-11-13 Kunihiro Ishiguro <kunihiro@zebra.org>
3155
3156 * bgp_btoa.c: New file added.
3157
31581999-11-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3159
3160 * bgpd.h (struct peer): Add dont_capability flag.
3161 (struct peer): Add override_capability flag.
3162
3163 * bgpd.c (neighbor_dont_capability_negotiation): `neighbor PEER
3164 dont-capability-negotiation' added.
3165
31661999-11-12 Bill Sommerfeld <sommerfeld@orchard.arlington.ma.us>
3167
3168 * bgp_attr.c (bgp_mp_reach_parse): Ignore link-local addresses
3169 attribute from non-shared-network peers.
3170
31711999-11-10 Kunihiro Ishiguro <kunihiro@zebra.org>
3172
3173 * bgp_snmp.c: New file added.
3174
3175 * BGP4-MIB.txt: Updated to the latest Internet-Draft
3176 draft-ietf-idr-bgp4-mib-04.txt.
3177
31781999-11-09 Kunihiro Ishiguro <kunihiro@zebra.org>
3179
3180 * bgp_route.c (bgp_route_init): Add `show ipv6 bgp prefix-list'.
3181
3182 * bgp_attr.c (bgp_mp_unreach_parse): Enclose safi setup with
3183 #ifdef HAVE_MBGPV4.
3184
31851999-11-08 Kunihiro Ishiguro <kunihiro@zebra.org>
3186
3187 * bgp_dump.c (no_dump_bgp_all): Add [PATH] and [INTERVAL] to no
3188 dump bgp commands.
3189 (config_write_bgp_dump): Write interval value to the
3190 configuration.
3191
31921999-11-07 Kunihiro Ishiguro <kunihiro@zebra.org>
3193
3194 * bgp_zebra.c: Redistribute route-map support is added.
3195
3196 * bgp_zebra.h: New file added.
3197
31981999-11-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3199
3200 * bgp_dump.c: BGP packet dump routine compatible with MRT.
3201 * bgp_dump.h: BGP packet dump routine compatible with MRT.
3202
3203 * bgp_debug.c: Renamed from bgp_dump.c
3204 * bgp_debug.h: Renamed from bgp_dump.h
3205
32061999-10-27 Kunihiro Ishiguro <kunihiro@zebra.org>
3207
3208 * BGP4-MIB.txt: New file added. Edited version of RFC1657.
3209
32101999-10-25 Bill Sommerfeld <sommerfeld@orchard.arlington.ma.us>
3211
3212 * bgp_route.c (bgp_announce): If we're not on a shared network
3213 with the peer and we don't have a link-local next hop, but the
3214 inbound next-hop has a link-local address, don't readvertise it to
3215 our peer.
3216
32171999-10-25 Marc Boucher <marc@mbsi.ca>
3218
3219 * bgp_zebra.c: Add redistribute kernel command.
3220
32211999-10-25 Kunihiro Ishiguro <kunihiro@zebra.org>
3222
3223 * bgp_route.c (bgp_reset): New function added.
3224
3225 * bgpd.conf.sample2: Add IPv6 configuration sample.
3226
32271999-10-24 Bill Sommerfeld <sommerfeld@orchard.arlington.ma.us>
3228
3229 * bgp_route.c (ipv6_aggregate_address): Function added.
3230
32311999-10-21 Kunihiro Ishiguro <kunihiro@zebra.org>
3232
3233 * bgp_packet.c (bgp_update): Unintern aspath, community, cluster
3234 list after parsing BGP update packet.
3235
3236 * bgp_attr.c (bgp_attr_aspath): Intern parsed aspath.
3237 (bgp_attr_community): Intern parsed community.
3238 (bgp_attr_cluster_list): Intern parsed cluster list.
3239
3240 * bgp_routemap.c: Add `set community-additive' command.
3241
32421999-10-21 Alexandr D. Kanevskiy <kad@blackcatlinux.com>
3243
3244 * bgp_routemap.c (route_set_local_pref): Fix bug of setting
3245 attribute flag.
3246
32471999-10-21 Bill Sommerfeld <sommerfeld@orchard.arlington.ma.us>
3248
3249 * bgp_route.c (bgp_announce): Add check of IPv6 default route
3250 announcement.
3251
3252 * bgp_packet.c (bgp_update_send): Add BGP announcement logging.
3253
32541999-10-15 Kunihiro Ishiguro <kunihiro@zebra.org>
3255
3256 * `show ip[v6] bgp PREFIX' show uptime of the route.
3257
32581999-10-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3259
3260 * bgpd.c (bgp_filter_set): Delete PEER_FAMILY_{IPV4,IPV6}. instead
3261 of that use AF_INET and AF_INET6 directly.
3262 (vty_clear_bgp): Add new function to support various clear ip bgp
3263 method.
3264
32651999-10-04 Lars Fenneberg <lf@elemental.net>
3266
3267 * bgpd.c (clear_ip_bgp): Add `clear ip bgp ASN'.
3268
32691999-10-03 Kunihiro Ishiguro <kunihiro@zebra.org>
3270
3271 * bgp_routemap.c: Add `match ip prefix-list' and `match ipv6
3272 prefix-list'.
3273
32741999-09-28 Kunihiro Ishiguro <kunihiro@zebra.org>
3275
3276 * bgpd.c (bgp_collision_detect): Add BGP collision detection
3277 function.
3278
32791999-09-26 Blake Meike <bmeike@adero.com>
3280
3281 * bgpd.c (neighbor_port): New command `neighbor PEER port PORT' is
3282 added.
3283
32841999-08-24 Kunihiro Ishiguro <kunihiro@zebra.org>
3285
3286 * bgpd.c (no_neighbor_timers_keepalive): Change MIN to min. Add
3287 min() macro.
3288
32891999-08-19 Rick Payne <rickp@rossfell.co.uk>
3290
3291 * bgp_packet.c (bgp_open): BGP holdtimer bug is fixed. Make BGP
3292 keepalive timer configurable.
3293
32941999-08-15 Kunihiro Ishiguro <kunihiro@zebra.org>
3295
3296 * bgp_zebra.c (bgp_redistribute_set): Fix redistribute bug.
3297
32981999-08-13 Kunihiro Ishiguro <kunihiro@zebra.org>
3299
3300 * bgpd.c (bgp_peer_display): show ip bgp neighbors PEER only list
3301 the peer not all of them.
3302
33031999-08-11 Rick Payne <rickp@rossfell.co.uk>
3304
3305 * bgp_route.c (bgp_announce): Remove MED if its an EBGP peer -
3306 will get overwritten by route-maps.
3307
33081999-08-08 Rick Payne <rickp@rossfell.co.uk>
3309
3310 * bgp_routemap.c: Multi protocol route-map modification.
3311
33121999-08-01 Kunihiro Ishiguro <kunihiro@zebra.org>
3313
3314 * bgp_route.c: Set network statement route's origin attribute as
3315 igp.
3316
3317 * bgp_zebra.c: Set redistribute route's origin attribute as
3318 incomplete.
3319
3320 * bgp_route.c (bgp_info_cmp): Add attribute existance check,
3321 origin attribute check, BGP peer type check.
3322
33231999-07-30 Kunihiro Ishiguro <kunihiro@zebra.org>
3324
3325 * bgp_route.c (bgp_peer_delete): Reselect of IPv6 route.
3326
33271999-07-29 Rick Payne <rickp@rossfell.co.uk>
3328
3329 * Changed route-maps to behave in a more cisco-like fashion
3330
33311999-07-27 Kunihiro Ishiguro <kunihiro@zebra.org>
3332
3333 * bgp_fsm.c (bgp_stop): Very serious bug of bgp_stop () is fixed.
3334 When multiple route to the same destination exist, bgpd try to
3335 announce the information to stopped peer. Then add orphan write
3336 thread is added. This cause many strange behavior of bgpd.
3337 Reported by Georg Hitsch <georg@atnet.at>.
3338
33391999-07-23 Kunihiro Ishiguro <kunihiro@zebra.org>
3340
3341 * bgpd.c: Change peer's A.B.C.D to PEER.
3342
33431999-07-22 Kunihiro Ishiguro <kunihiro@zebra.org>
3344
3345 * bgp_route.c (bgp_announce): Add hack for link-local nexthop.
3346
3347 * bgp_zebra.c (bgp_zebra_announce): Fill in nexthop address from
3348 local address.
3349
33501999-07-21 Kunihiro Ishiguro <kunihiro@zebra.org>
3351
3352 * bgp_packet.c (bgp_open): Holdtime fetch bug is fixed. Reported
3353 by Yuji SEKIYA <sekiya@sfc.wide.ad.jp>.
3354
33551999-07-15 Kunihiro Ishiguro <kunihiro@zebra.org>
3356
3357 * bgp_fsm.c (fsm_holdtime): Don't close file descriptor in
3358 fsm_holdtime ().
3359
33601999-07-11 Kunihiro Ishiguro <kunihiro@zebra.org>
3361
3362 * bgp_routemap.c: Add `set atomic-aggregate' command.
3363
33641999-07-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3365
3366 * bgp_routemap.c (route_set_ip_nexthop_cmd): Change "ip nexthop"
3367 to "ip next-hop".
3368
33691999-07-02 Kunihiro Ishiguro <kunihiro@zebra.org>
3370
3371 * bgp_route.c (show_ipv6_bgp_regexp): `show ipv6 bgp regexp'
3372 added.
3373
33741999-07-01 Rick Payne <rickp@rossfell.co.uk>
3375
3376 * bgp_zebra.c (zebra_init): Install standard commands to
3377 ZEBRA_NODE.
3378
33791999-06-28 Rick Payne <rickp@rossfell.co.uk>
3380
3381 * bgpd.c (bgp_delete): bgp peer deletion bug is fixed.
3382
33831999-06-25 Kunihiro Ishiguro <kunihiro@zebra.org>
3384
3385 * bgpd.c: Add neighbor update-source command as ALIAS to
3386 neighbor_interface.
3387
33881999-06-19 Kunihiro Ishiguro <kunihiro@zebra.org>
3389
3390 * bgp_attr.c (bgp_packet_attribute): Send community attribute when
3391 send_community flag is set.
3392
3393 * bgpd.h (struct peer): Add send_community flag.
3394
33951999-06-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3396
3397 * bgpd.c (router_bgp): router bgp's argument changed from AS_NO to
3398 <1-65535>.
3399
34001999-06-08 Kunihiro Ishiguro <kunihiro@zebra.org>
3401
3402 * bgp_route.h (struct bgp_info): Add subtype for BGP route type.
3403
34041999-06-07 Kunihiro Ishiguro <kunihiro@zebra.org>
3405
3406 * bgp_community.c (community_merge): Function added.
3407
34081999-06-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3409
3410 * bgp_clist.c: New file.
3411 * bgp_clist.h: New file.
3412
3413 * bgp_community.h (COMMUNITY_LOCAL_AS): Added for Cisco
3414 compatibility.
3415 (COMMUNITY_NO_ADVERTISE): Fix typo.
3416
34171999-05-30 Kunihiro Ishiguro <kunihiro@zebra.org>
3418
3419 * bgp_routemap.c: Add `set weight WEIGHT' command.
3420
3421 * bgpd.c: Remove all_digit_check function. Instead of that use
3422 all_digit function in lib/prefix.c.
3423
3424 * bgp_routemap.c (bgp_route_map_init): Install
3425 no_set_ipv6_nexthop_global_cmd and no_set_ipv6_nexthop_local_cmd
3426 element to the RMAP_NODE.
3427
34281999-05-28 Kunihiro Ishiguro <kunihiro@zebra.org>
3429
3430 * bgp_aspath.c (aspath_make_str): Declare aspath_delimiter_char
3431 inside aspath_make_str function.
3432 (aspath_prepend): New function is added for AS path prepend.
3433 (aspath_make_str_count): Renamed from aspath_make_str. AS path
3434 count is set to the structure.
3435 (aspath_merge): New function.
3436
34371999-05-22 Kunihiro Ishiguro <kunihiro@zebra.org>
3438
3439 * bgp_zebra.c (redistribute_bgp): Add new DEFUN.
3440 (no_redistribute_bgp): Likewise.
3441 (router_zebra): Semantics changed. Now 'router zebra' is default
3442 behavior of bgpd.
3443
34441999-05-14 Kunihiro Ishiguro <kunihiro@zebra.org>
3445
3446 * bgp_routemap.c: Add some commands to bgp route-map.
3447 match ip next-hop: New command.
3448 match metric: New command.
3449 set metric: Doc fix.
3450 set local-preference: Add DEFUN.
3451
34521999-05-14 Stephen R. van den Berg <srb@cuci.nl>
3453
3454 * bgp_main.c (signal_init): SIGTERM call sigint.
3455 (sigint): Loggging more better message.
3456
34571999-05-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3458
3459 * bgp_attr.c (bgp_packet_attribute): AS path attribute extended
3460 length bit check is added.
3461
34621999-05-11 Kunihiro Ishiguro <kunihiro@zebra.org>
3463
3464 * bgp_routemap.c (bgp_route_map_init): Call route_map_install_set
3465 function with route_set_local_pref_cmd argument.
3466 (no_match_aspath): Function added.
3467 (route_set_metric): Set attribute flag bit.
3468
3469 * bgp_attr.c (bgp_packet_attribute): MULTI_EXIT_DISC is now in BGP
3470 packet.
3471
34721999-05-07 Kunihiro Ishiguro <kunihiro@zebra.org>
3473
3474 * bgpd.c (no_neighbor_timers_holdtime): `no neighbor PEER timers
3475 holdtime' command is added.
3476
3477 * bgpd.h (BGP_DEFAULT_HOLDTIME_BIG): Delete define.
3478
3479 * bgpd.c (bgp_prefix_list_set): New function added.
3480 (bgp_prefix_list_unset): Likewise.
3481 (bgp_prefix_list_update): Likewise.
3482 (show_ip_bgp_neighbors): prefix-list information display.
3483
34841999-05-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3485
3486 * bgpd.c (bgp_delete): Function added for `no router bgp'.
3487
34881999-05-05 Kunihiro Ishiguro <kunihiro@zebra.org>
3489
3490 * bgp_dump.c (bgp_dump_attr): Add originator_id display.
3491
3492 * bgpd.c (bgp_router_id): Even when address is malformed set the
3493 value to configuration bug fixed.
3494 (no_bgp_router_id): New function.
3495 (no_bgp_cluster_id): New function.
3496
34971999-05-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3498
3499 * bgpd.h (BGP_ATTR_ORIGINATOR_ID): Changed from BGP_ATTR_ORIGINATOR.
3500
35011999-05-02 Kunihiro Ishiguro <kunihiro@zebra.org>
3502
3503 * bgp_route.c (bgp_announce): Add route reflector check.
3504
35051999-05-01 Kunihiro Ishiguro <kunihiro@zebra.org>
3506
3507 * bgpd.c (bgp_cluster_id): Add function for route reflector.
3508 (neighbor_route_reflector_client): Likewise.
3509 (no_neighbor_route_reflector_client): Likewise.
3510
3511 * bgpd.h (struct bgp ): Add cluster for route reflector.
3512
3513 * bgp_route.c (show_ip_bgp_prefix_list): New command is added.
3514
35151999-04-24 Kunihiro Ishiguro <kunihiro@zebra.org>
3516
3517 * Makefile.am (noinst_HEADERS): Add bgp_filter.h
3518
3519 * bgp_aspath.c (aspath_undup): Function deleted. aspath_free ()
3520 has same functionality.
3521
3522 * bgp_filter.h: New file.
3523
3524 * bgp_aspath.c (aspath_unintern): Rename aspath_free () to
3525 aspath_unintern ()
3526 (aspath_free): New function.
3527
35281999-04-23 Kunihiro Ishiguro <kunihiro@zebra.org>
3529
3530 * bgp_aspath.c (aspath_aggregate): Function added.
3531
3532 * bgp_aspath.h (aspath_aggregate): Prototype added.
3533
3534 * bgp_aspath.c (aspath_empty_aspath): New argument
3535 gated_dont_eat_flag is added.
3536
35371999-04-18 Kunihiro Ishiguro <kunihiro@zebra.org>
3538
3539 * bgp_route.c: Add bgp_aggregate_ipv4 and bgp_aggregate_ipv6.
3540
35411999-04-17 Kunihiro Ishiguro <kunihiro@zebra.org>
3542
3543 * bgp_route.c (aggregate_address): Function added.
3544
3545 * bgp_zebra.c (zebra_read): Change log to zlog.
3546
35471999-04-15 Kunihiro Ishiguro <kunihiro@zebra.org>
3548
3549 * Makefile.am (noninst_HEADERS): Added for make dist.
3550
35511999-04-09 Kunihiro Ishiguro <kunihiro@zebra.org>
3552
3553 * aspath_regex.c: Removed from distribution.
3554
35551999-04-07 Kunihiro Ishiguro <kunihiro@zebra.org>
3556
3557 * bgp_attr.c (bgp_packet_attribute): Old draft-00 packet treatment
3558 bug fixed.
3559
35601999-04-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3561
3562 * bgp_aspath.c (aspath_add_left): Fix empty aspath bug. Reported
3563 by kad@gibson.skif.net.
3564
3565 * bgp_regex.[ch]: New file added.
3566
3567
35681999-04-05 Kunihiro Ishiguro <kunihiro@zebra.org>
3569
3570 * bgp_filter.c: New file added.
3571
35721999-04-01 Kunihiro Ishiguro <kunihiro@zebra.org>
3573
3574 * bgp_aspath.c (aspath_empty_aspath): Change for peering with
3575 gated.
3576
35771999-03-24 Kunihiro Ishiguro <kunihiro@zebra.org>
3578
3579 * bgp_main.c (main): Default loggin method changed from syslog to
3580 stdout.
3581
35821999-03-05 Kunihiro Ishiguro <kunihiro@zebra.org>
3583
3584 * bgp_route.c: Delete obsolete default attribute DEFUN.
3585
35861999-03-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3587
3588 * bgp_attr.c: Make attribute structure put into attribute hash.
3589
35901999-03-02 Kunihiro Ishiguro <kunihiro@zebra.org>
3591
3592 * bgp_view.c : Delete file.
3593
35941999-02-25 Kunihiro Ishiguro <kunihiro@zebra.org>
3595
3596 * bgp_routemap.c (bgp_apply_route_map): Add prefix argument.
3597
3598 * bgp_route.h (struct bgp_info): Add bgp_info structre. I'll
3599 replace bgp_route with this.
3600
3601 * bgp_routemap.c (route_match_ip_address): Fix bug of passing non
3602 prefix value to access_list_apply().
3603
3604 * bgpd.conf.sample: Add route-map sample.
3605 Delete obsolete default-attr statements.
3606
3607 * bgp_packet.c: Use stream_fifo for packet queueing.
3608
36091999-02-24 Kunihiro Ishiguro <kunihiro@zebra.org>
3610
3611 * bgp_aspath.c (aspath_add_left): add non empty aspath treatment.
3612
3613 * bgp_main.c: include unistd.h for daemon().
3614
3615 * bgp_route.c (nlri_process): add IPv6 table lookup.
3616
3617 * bgp_attr.c (route_parse_ipv6): call nlri_process().
3618 (attr_make): Obsolete function attr_make deleted.
3619
36201999-02-22 Kunihiro Ishiguro <kunihiro@zebra.org>
3621
3622 * bgp_aspath.c (aspath_add_left): change function name from
3623 aspath_add_leftmost_as().
3624
36251999-02-21 Kunihiro Ishiguro <kunihiro@zebra.org>
3626
3627 * bgp_aspath.c: add aspath_add_leftmost_as ().
3628
36291999-02-18 Peter Galbavy <Peter.Galbavy@knowledge.com>
3630
3631 * syslog support added
3632
36331999-01-26 Kunihiro Ishiguro <kunihiro@zebra.org>
3634
3635 * bgpd.c: DEFUN (neighbor_nexthop): deleted.
3636 DEFUN (neighbor_distribute_list): added.
3637
36381999-01-19 Kunihiro Ishiguro <kunihiro@zebra.org>
3639
3640 * bgpd.h (struct peer ): header_buf and read_buf is removed.
3641
3642 * bgp_peer.[ch]: Deleted. Peer related functions are merged to
3643 bgpd.c
3644
3645 * bgp_network.c: New file.
3646 * bgp_network.h: New file.
3647
3648 * bgp_packet.h: New file.
3649
36501999-01-11 Kunihiro Ishiguro <kunihiro@zebra.org>
3651
3652 * bgp_packet.c (bgp_keepalive_send): Now BGP keepalive packet is
3653 buffered.
3654
36551999-01-08 Kunihiro Ishiguro <kunihiro@zebra.org>
3656
3657 * bgp_packet.c: New file.
3658
36591998-12-22 Kunihiro Ishiguro <kunihiro@zebra.org>
3660
3661 * bgp_zebra.c (zebra_client): Use zebra_connect() in lib/client.c.
3662
3663 * `show ip bgp' bug fixed.
3664 * aspath_log (): Remove argument logfp.
3665
36661998-12-15 Kunihiro Ishiguro <kunihiro@zebra.org>
3667
3668 * bgp_fsm.h: New file.
3669
36701998-12-15 Magnus Ahltorp <map@stacken.kth.se>
3671
3672 * bgp_attr.c, bgp_community.h, bgp_dump.c, bgp_fsm.c, bgp_open.c
3673 bgp_peer.c, bgp_peer.h, bgp_route.c, bgp_route.h, bgp_view.c
3674 bgpd.c, bgpd.h, bgp_attr.c, bgp_community.h, bgp_dump.c,
3675 bgp_fsm.c, bgp_open.c, bgp_peer.c, bgp_peer.h: Prototype fixes.
3676
36771998-12-09 Kunihiro Ishiguro <kunihiro@zebra.org>
3678
3679 * bgpd.c (bgp_config_write): Delete vector v argument.
3680
36811998-12-07 Kunihiro Ishiguro <kunihiro@zebra.org>
3682
3683 * bgpd.h: Delete annoying ld_[124]byte and st_[124]byte macros.
3684
36851998-11-23 Kunihiro Ishiguro <kunihiro@zebra.org>
3686
3687 * bgp_radix.[ch]: removed.
3688
36891998-09-15 HEO SeonMeyong <seirios@matrix.iri.co.jp>
3690
3691 * bgp_main.c: ifdef HYDRANGEA -> ifdef KAME
3692
36931998-08-13 Kunihiro Ishiguro <kunihiro@zebra.org>
3694
3695 * bgp_dump.c: delete nroute().
3696
36971998-05-19 Yamshita TAKAO <jargon@lares.dti.ne.jp>
3698
3699 * bgp_aspath.c: HAVE_CONFIG_H typo :-)
3700 * bgpd.h: Modify for compile on Solaris.
3701 * bgp_aspath.h: likewize
3702 * bgp_community.h: likewize
3703 * bgp_routemap.c: likewize
3704
37051998-05-18 Yamshita TAKAO <jargon@lares.dti.ne.jp>
3706
3707 * bgpd.h: Modify for compile on Solaris.
3708 * bgp_aspath.h: likewize
3709
37101998-05-08 Kunihiro Ishiguro <kunihiro@zebra.org>
3711
3712 * routemap.[ch]: move to ../lib directory.
3713
37141998-05-07 Kunihiro Ishiguro <kunihiro@zebra.org>
3715
3716 * routemap.c (route_map_apply): add function.
3717
37181998-05-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3719
3720 * routemap.h: add file.
3721
3722 * bgp_peer.h (enum ): change PEER_{IBGP,EBGP} to BGP_PEER_{IBGP,EBGP}
3723
37241998-05-03 Kunihiro Ishiguro <kunihiro@zebra.org>
3725
3726 * Makefile.am: sysconfdir_DATA added.
3727
37281998-05-02 Kunihiro Ishiguro <kunihiro@zebra.org>
3729
3730 * bgp_dump.c: add `debug bgp fsm'
3731 add `no debug bgp fsm'
3732 add `show debug bgp'
3733 * bgp_open.c: File added.
3734
37351998-05-01 Kunihiro Ishiguro <kunihiro@zebra.org>
3736
3737 * .cvsignore: File added.
3738
37391998-04-30 Kunihiro Ishiguro <kunihiro@zebra.org>
3740
3741 * bgp_community.[ch]: File added.
3742
37431998-03-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3744
3745 * bgpd now use lib/thread.[ch].
3746
37471998-01-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3748
3749 * bgpd.c (show_ip_bgp_neighbors): add 'show ip bgp neighbors' command.
3750
3751 * bgpd.h (BGP_DEFAULT_START_TIMER): change from 1 to 30.
3752
37531997-12-30 Kunihiro Ishiguro <kunihiro@zebra.org>
3754
3755 * bgp_vty.c: bgp_vty.c deleted.
3756
3757 * bgpd.c (config_write_neighbor): add ebgp-multihop command.
3758
37591997-12-29 Kunihiro Ishiguro <kunihiro@zebra.org>
3760
3761 * bgp_fsm.c: [-p bgp_port] and [-P vty_port] works
3762
37631997-12-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3764
3765 * bgp_vty.c: new file.
3766
3767 * bgp_attr.c: add new logging system.
3768
37691997-11-23 Kunihiro Ishiguro <kunihiro@zebra.org>
3770
3771 * Change all inet_addr call into inet_aton.
3772
37731997-11-10 Kunihiro Ishiguro <kunihiro@zebra.org>
3774
3775 * bgp_radix.c: change radix_peer_delete
3776
37771997-10-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3778
3779 * bgp_aspath.c: move AS_TOKEN_??? definition from header to c source.
3780
37811997-09-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3782
3783 * bgp_dump.c (bgp_log_route): add dump_attr function
3784
37851997-09-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3786
3787 * bgp_aspath.c (aspath_test): change AS_SET brace from '[' to '{'
3788 * bgp_dump.c (bgp_log_route): change logfile format.
3789
37901997-08-19 Kunihiro Ishiguro <kunihiro@zebra.org>
3791
3792 * bgp_open.c (bgp_open): move bgp_open function from bgpd.c
3793 * bgp_attr.c (community_str2com): add community value generation
3794 * bgp_attr.h: add SAFI definition for BGP-4+
3795
37961997-08-18 Kunihiro Ishiguro <kunihiro@zebra.org>
3797
3798 * bgpd.h: add BGP_OPEN_OPT_CAP for Capabilities Optional Parameter
3799 * Makefile.in: add bgp_open.o, delete bgp_loop.o
3800 * bgp_open.c: newfile which manages BGP Open message
3801 * bgp_loop.c: this file is merged with bgp_fsm.c
3802 * bgp_radix.c (radix_add): radix_add() now return route_t instead
3803 of int
3804 (bgp_sim): now we can read update & withdraw from file
3805 * bgp_route.c: add route_free() call into route_parse etc.
3806
38071997-08-17 Kunihiro Ishiguro <kunihiro@zebra.org>
3808
3809 * bgp_radix.c: Radix code is completely rewritten. It has better
3810 memory treatment than old one.
3811
38121997-08-14 Kunihiro Ishiguro <kunihiro@zebra.org>
3813
3814 * bgp_route.c: route_alloc for route struct allocation statistics.
3815 * bgpd.c (bgp_make_update): now we cann announce MED attribute.
3816 * bgp_aspath.c (aspath_print_all): change aspath_print_all output
3817 format.
3818
38191997-08-13 Kunihiro Ishiguro <kunihiro@zebra.org>
3820
3821 * bgp_term.c (term_parse): add command : show asstat, show ashash
3822 * bgp_aspath.c: aspath_cmp bug fix
3823 (aspath_print_all): add aspath_print_all ();
3824 * bgp_peer.h: delete rlist element from struct peer.
3825
38261997-08-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3827
3828 * bgp_aspath.c: completely rewritten.
3829 * bgp_aspath.h: completely rewritten.
3830 add AsPath, AsSegment structure
3831 add AS_SET treatment
3832 change Hash codes
3833
38341997-08-09 Kunihiro Ishiguro <kunihiro@zebra.org>
3835
3836 * bgp_attr.h: add Attribute flags defines
3837 * bgp_route.c: delete rlist related functions
3838 * bgp_aspath.c (as_origin): add as_origin function
3839 (aspath_print): move from bgp_dump.c and add support of AS_SET
3840 change Hash related function names.
3841
38421997-08-08 Kunihiro Ishiguro <kunihiro@zebra.org>
3843
3844 * bgp_aspath.h: add next entry, delete rlist entry from struct aspath
3845
38461997-08-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3847
3848 * bgp_aspath.c (as_sort): add function as_sort
3849 * bgp_aspath.h: add IBGP, EBGP
3850