blob: 1c6c136e9cd91ee5fd329bc13b2a0476ec30c333 [file] [log] [blame]
Andrew J. Schorr56b3ea02007-03-14 20:21:43 +000012007-03-14 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
2
Andrew J. Schorrad81f8c2007-03-14 22:05:18 +00003 * ospf_snmp.c: (ospf_snmp_neighbor_state) New function to
4 map internal quagga neighbor states to SNMP standard values.
5 (ospfNbrEntry) Call new ospf_snmp_neighbor_state function.
6
72007-03-14 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
8
Andrew J. Schorr56b3ea02007-03-14 20:21:43 +00009 * ospf_zebra.c: (ospf_zebra_add, ospf_zebra_delete) Fix bug
10 where inet_ntoa was used twice in the same debug message,
11 which doesn't work because there's a single shared buffer
12 for the returned string. The fix is to use inet_ntop.
13
Andrew J. Schorr4056a542007-02-27 13:55:46 +0000142007-02-27 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
15
16 * ospfd.c: (ospf_terminate) Exit immediately if ospf is not
17 actually running (e.g. the config file was empty). Fixes
18 bug where SIGTERM would not kill ospfd.
19
Paul Jakmabd34fb32007-02-26 17:14:48 +0000202007-02-26 Paul Jakma <paul.jakma@sun.com>
21
22 * ospf_spf.c: Fix regression introduced with bug #330 fix: The
23 cost update added to ospf_spf_add_parent only handled PtP
24 case, differing from same functionality in higher-level
25 ospf_spf_next. Regression diagnosed by Anders Pedersen,
26 mailnews+router-quagga-dev@news.cohaesio.com.
27 (ospf_vertex_new) Initialise vertices to max-cost.
28 (ospf_spf_init) Root vertex always creates with 0 cost.
29 (ospf_spf_add_parent) Remove the buggy V->W cost calculating
30 code, instead take the new distance as a parameter.
31 (ospf_nexthop_calculation) Take distance as parameter, so it
32 can be passed down to add_parent.
33 (ospf_spf_next) Dont initialise candiate vertex distance,
34 vertex_new does so already. Pass distance down to
35 nexthop_calculation (see above).
36
Paul Jakmabc20c1a2007-01-24 14:51:51 +0000372007-01-24 Paul Jakma <paul.jakma@sun.com>
38
39 * ospf_spf.c: Bug #330: Nexthop calculation sometimes may fail,
40 and it needs to indicate this result to SPF.
41 (ospf_spf_add_parent) Flush of parent list needs to be done here,
42 for simplicity.
43 (ospf_nexthop_calculation) Caller needs to know whether
44 nexthop calculation succeeded. Every return statement must
45 correctly indicate such.
46 (ospf_spf_next) Queueing/prioritisation of vertices in SPF
47 must take into account whether nexthop_calculation succeeded,
48 or SPF may fail to find best paths.
49
Andrew J. Schorre4529632006-12-12 19:18:21 +0000502006-12-12 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
51
52 * ospf_interface.c: (ospf_if_is_configured, ospf_if_lookup_by_prefix,
53 ospf_if_lookup_recv_if) Simplify logic using new CONNECTED_PREFIX
54 macro.
55 * ospf_lsa.c: (lsa_link_ptop_set) Using the new CONNECTED_PREFIX
56 macro, both options collapse into the same code.
57 * ospf_snmp.c: (ospf_snmp_if_update) Simplify logic using new
58 CONNECTED_ID macro.
59 (ospf_snmp_is_if_have_addr) Simplify logic using new CONNECTED_PREFIX
60 macro.
61 * ospf_vty.c: (show_ip_ospf_interface_sub) Use new CONNECTED_PEER macro
62 instead of testing the IFF_POINTOPOINT flag.
63 * ospfd.c: (ospf_network_match_iface) Use new CONNECTED_PEER macro
64 instead of testing with if_is_pointopoint. And add commented-out
65 code to implement alternative (in my opinion) more elegant behavior
66 that has no special-case treatment for PtP addresses.
67 (ospf_network_run) Use new CONNECTED_ID macro to simplify logic.
68
Andrew J. Schorred589c12006-12-04 18:26:37 +0000692006-12-04 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
70
71 * ospfd.c: (ospf_network_run) Remove an offending 'break' statement.
72 Previously, after creating a single ospf_interface on a given
73 network interface, the code would skip to the next interface
74 without considering other connected addresses on the interface.
75 After removing the 'break', we now consider all connected addresses.
76
Andrew J. Schorr7f643eb2006-11-30 16:17:02 +0000772006-11-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
78
79 * ospf_zebra.c: (ospf_router_id_update_zebra,
80 ospf_interface_address_add, ospf_interface_address_delete)
81 If (IS_DEBUG_OSPF (zebra, ZEBRA_INTERFACE)) is enabled, then
82 add a debug message about what Zebra is telling us.
83 (ospf_zebra_add_discard) Add a debug message matching the one
84 already in ospf_zebra_delete_discard.
85
Andrew J. Schorr43540882006-11-28 16:36:39 +0000862006-11-28 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
87
88 * ospf_vty.c: (ospf_passive_interface_default) Take additional
89 'newval' arg so we can update ospf->passive_interface_default inside
90 this function. More importantly, we now call ospf_if_set_multicast
91 on all ospf_interfaces.
92 (ospf_passive_interface, no_ospf_passive_interface) Fix bug:
93 for 'default' case, argv[0] is undefined, so we must test for
94 (argc == 0) before using argv[0]. And since
95 ospf_passive_interface_default now calls ospf_if_set_multicast as
96 needed, we can just return after calling
97 ospf_passive_interface_default.
98
Andrew J. Schorr8fb8a502006-10-24 19:04:26 +0000992006-10-24 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
100
101 * ospf_zebra.c: (ospf_redistribute_default_set) Fix bug where
102 a new value for ospf->default_originate was being ignored
103 if a previous 'default-information originate' command
104 had already been processed.
105
Paul Jakma7ffa8fa2006-10-22 20:07:53 +00001062006-10-22 Yar Tikhiy <yar@comp.chem.msu.su>
107
108 * (general) Add support for passive-interface default (with
109 minor edits by Paul Jakma).
110 * ospf_interface.h: Add OSPF_IF_PASSIVE_STATUS macro, looking
111 at configured value, or the global 'default' value, as
112 required.
113 * ospf_interface.c: (ospf_if_new_hook) Leave passive
114 unconfigured per default, allowing global 'default' to
115 take effect for unconfigured interfaces.
116 * ospf_packet.c: (various) use OSPF_IF_PASSIVE_STATUS
117 * ospf_vty.c: (ospf_passive_interface_default) new function,
118 unset passive from all interfaces if default is enabled, as
119 the per-iface settings become redundant.
120 (ospf_passive_interface_update) new func, update passive
121 setting taking global default into account.
122 ({no,}ospf_passive_interface_addr_cmd) Add support for
123 'default' variant of command.
124 (show_ip_ospf_interface_sub) Update to take global
125 default into account when printing passive status.
126 (ospf_config_write) ditto.
127 * ospfd.c: (ospf_new) set global passive-interface default.
128 * ospfd.h: (struct ospf) Add field for global
129 passive-interface.
130
Andrew J. Schorr08c83672006-09-25 13:26:14 +00001312006-09-25 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
132
133 * ospf_packet.c: (ospf_packet_dup, ospf_make_md5_digest)
134 Fix zlog_warn messages to eliminate compiler warnings.
135 (ospf_hello) Improve warning messages to show why we
136 are complaining.
137
Paul Jakmab5aeb442006-08-30 18:47:37 +00001382006-08-28 Andy Gay <andy@andynet.net>
139
140 * ospf_packet.c: (ospf_make_db_desc) Assert added with More-bit
141 fixes does not hold up with addition of Ogier DB-Exchange
142 optimisation, which can empty the db-summary list in between
143 sent DD packets. Remove assert, update More-bit always when
144 in Exchange.
145
Paul Jakma29b5a042006-08-27 08:01:20 +00001462006-08-27 J.J. Krabbendam <jkrabbendam@aimsys.nl>
147
148 * ospfd.c: (ospf_finish_final) default redistribute should be
149 unset too, fixes bug where reconfiguring ospfd completely
150 can no longer enable default redistribution.
151
Paul Jakma2518efd2006-08-27 06:49:29 +00001522006-08-25 Paul Jakma <paul.jakma@sun.com>
153
154 * (general) Bug #134. Be more robust to backward time changes,
155 use the newly added libzebra time functions.
156 In most cases: recent_time -> recent_relative_time()
157 gettimeofday -> quagga_gettime (QUAGGA_CLK_MONOTONIC, ..)
158 time -> quagga_time.
159 (ospf_make_md5_digest) time() call deliberately not changed.
160 (ospf_external_lsa_refresh) remove useless gettimeofday, LSA
161 tv_orig time was already set in ospf_lsa_new, called via
162 ospf_external_lsa_new.
163
Paul Jakmaba122e72006-08-27 06:24:34 +00001642006-08-04 Paul Jakma <paul.jakma@sun.com>
165
166 * ospf_lsdb.c: (ospf_lsdb_delete_entry) new function, consolidate
167 exact same functionality replicated in other functions.
168 (ospf_lsdb_add) Strip out code by using ospf_lsdb_delete_entry.
169 (ospf_lsdb_delete) ditto.
170 (ospf_lsdb_delete_all) ditto.
171
Paul Jakma8dd24ee2006-08-27 06:29:30 +00001722006-08-03 Paul Jakma <paul.jakma@sun.com>
173
174 * ospf_packet.c: (ospf_make_db_desc) Unset the DD More bit
175 after constructing the packet, if appropriate.
176 (ospf_db_desc_proc) Speed up Exchange, slave should raise
177 ExchangeDone earlier, as RFC mandates, by forming its reply
178 before deciding whether both sides are done, avoids a
179 needless round of empty DD packet exchanges at the end of
180 Exchange, hence speeding up ExchangeDone.
Paul Jakmaf0894cf2006-08-27 06:40:04 +0000181 Implement draft-ogier-ospf-dbex-opt DB-exchange optimisation.
Paul Jakma8dd24ee2006-08-27 06:29:30 +0000182 (ospf_db_desc) use UNSET_FLAG macro.
183
Andrew J. Schorr16700082006-07-27 22:29:06 +00001842006-07-27 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
185
186 * ospfd.c: (ospf_router_id_update) Fix and document the algorithm for
187 selecting the router ID: if there is not a statically configured ID,
188 then stick to the most recent value to avoid disruptive changes.
189 This should fix bug #288.
190
Paul Jakma1fe6ed32006-07-26 09:37:26 +00001912006-07-26 Paul Jakma <paul.jakma@sun.com>
192
193 * ospf_lsa.{c,h}: (ospf_lsa_unlock) Change to take a double pointer
194 to the LSA to be 'unlocked', so that, if the LSA is freed, the
195 callers pointer to the LSA can be NULLed out, allowing any further
196 use of that pointer to provoke a crash sooner rather than later.
197 * ospf_*.c: (general) Adjust callers of ospf_lsa_unlock to match
198 previous. Try annotate 'locking' somewhat to show which 'locks'
199 are protecting what LSA reference, if not obvious.
200 * ospf_opaque.c: (ospf_opaque_lsa_install) Trivial: remove useless
201 goto, replace with return.
202 * ospf_packet.c: (ospf_make_ls_ack) Trivial: merge two list loops,
203 the dual-loop predated the delete-safe list-loop macro.
204
Paul Jakma3fed4162006-07-25 20:44:12 +00002052006-07-25 Paul Jakma <paul.jakma@sun.com>
206
207 * ospf_neigbor.h: (struct ospf_neighbor) Add some additional
208 neighbour state statistics fields, timestamps for progressive
209 and regressive state changes, and pointer to event string
210 for the latter state change.
211 * ospf_nsm.c: (nsm_notice_state_change) Update new state changs
212 history as required.
213 * ospf_vty.c: (show_ip_ospf_neighbor_detail_sub) Print out above
214 new per-neighbour state change stats.
215
Paul Jakma539e1522006-07-11 17:49:22 +00002162006-07-10 Paul Jakma <paul.jakma@sun.com>
217
218 * ospf_nsm.c: (nsm_change_state) call nsm_clear_adj for all
219 adjacency losses, hence removing need for nsm_reset_nbr.
220 (nsm_reset_nbr) kill it, clear_adj in previous does fine.
221 (nsm_kill_nbr,nsm_start) remove nsm_reset_nbr call.
222 (ospf_nsm_event) Allow NSM function to be NULL, this along with
223 removal of nsm_reset_nbr, allows a bunch of now useless functiosn
224 to be removed.
225 Remove some useless variables.
226 (nsm_ignore) now useless, remove.
227 (nsm_bad_ls_req) ditto
228 (nsm_seq_number_mismatch) "
229 (nsm_oneway_received) "
230 (nsm_inactivity_timer) "
231 (nsm_ll_down) "
232 (NSM) replace removed action functions with NULL.
Paul Jakma3d63f382006-07-11 17:52:53 +0000233 (nsm_notice_state_changes) Move state change logging code to new
234 func to declutter nsm_change_state and ospf_nsm_event.
235 Log event with AdjChange, it's useful to know.
236 (nsm_change_state) move adjchange and snmp logging to previous.
237 (ospf_nsm_event) call nsm_notice_state_changes from here.
238 Move the debug message to entry of function, so it gets out
239 even if something goes wrong.
Paul Jakma90c33172006-07-11 17:57:25 +0000240 Record state change timestamp and event in nbr struct.
241 * ospf_neighbor.h: (struct ospf_neighbor) Add fields to record
242 timestamp of last NSM change and event.
243 * ospf_vty.c: (show_ip_ospf_neighbor_detail_sub) Print
244 last state change timestamp and event, if available.
Paul Jakma539e1522006-07-11 17:49:22 +0000245
Andrew J. Schorr13cd3dc2006-07-11 01:50:30 +00002462006-07-10 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
247
248 * ospf_packet.c: (ospf_hello) Improve NetworkMask mismatch warning
249 message to include interface name and conflicting prefix lengths.
250
Paul Jakma1f2c2742006-07-10 07:45:13 +00002512006-07-07 Paul Jakma <paul.jakma@sun.com>
252
253 * ospf_nsm.h: Add a NSM_Deleted neighbour state, to act as dummy
254 state indicating the neighbour is to be deleted.
255 * ospf_nsm.c: (general) Use the NSM_Deleted state to delete
256 neighbours, thus allowing code to be slightly more obvious
257 in its flow.
258 (nsm_timer_set) Add NSM_Deleted. Add another timer the code
259 missed.
260 (nsm_kill_nbr) No need for special case call to nsm_change_state
261 anymore.
262 Make the assert and error-handling for same case more readable
263 (Andrew Schorr)
264 Remove the call to ospf_nbr_delete, nsm_change_state can do
265 this generally now via NSM_Deleted.
266 (struct ... NSM) Add the dummy NSM_Deleted state, the 3 events
267 that can lead to nsm_kill_nbr all now transition the NBR to
268 NSM_Deleted and the general change_state function can be left
269 to do the work.
270 (ospf_nsm_event) Special casing of events and early-return can
271 be removed now.
272 On transition into Deleted, delete the nbr.
273 * ospf_dump.c: (ospf_nsm_state_msg) Add Deleted.
274
Paul Jakmaaa2737a2006-07-06 11:12:39 +00002752006-07-06 Paul Jakma <paul.jakma@sun.com>
276
277 * ospf_nsm.c: (ospf_nsm_event) LLDown event also results in nbr
278 being deleted, requires early-return too. Likely explains
279 some crash reports after interface events.
280
Paul Jakmaf7a76ab2006-07-04 13:57:49 +00002812006-07-04 Paul Jakma <paul.jakma@sun.com>
282
283 * ospf_nsm.c: (general) Various small cleanups from Andrew's
284 review of last set of patches.
285 (nsm_timer_set) Loading, Full and default can share
286 same code too.
287 (nsm_should_adj) Can just be one big OR.
288 (nsm_twoway_received) Collapse into return statement.
289
Paul Jakmad7b0fb62006-07-04 13:35:24 +00002902006-07-02 Paul Jakma <paul.jakma@sun.com>
291
292 * ospf_nsm.c: (nsm_should_adj) New function, just consolidate the
293 10.4 adjacency check from nsm_twoway_received/nsm_adj_ok.
294 (nsm_twoway_received/nsm_adj_ok) Use former.
Paul Jakmad1b1cd82006-07-04 13:50:44 +0000295 (nsm_clear_adj) clear adjacency related state for a
296 neighbour, needed for some state changes from > ExStart down
297 to ExStart or less, which need not go through nsm_reset_nbr.
298 (nsm_reset_nbr) move code to former. Should be static.
Paul Jakmaba0beb42006-07-04 13:44:19 +0000299 (ospf_nsm_event) Don't allow action functions to change
300 next_state if the NSM tables do not indicate next_state is
301 conditional, log warning if one tries - existing code
302 appears fine though.
Paul Jakmad1b1cd82006-07-04 13:50:44 +0000303 Remove long dead code.
304 Use nsm_clear_adj for state changes that take down
305 adjacencies to TwoWay/ExStart.
Paul Jakmae55dd532006-07-04 13:46:14 +0000306 (nsm_timer_set) ls_req timer should be OFF in early states.
307 Compact several identical sections.
308 Set inactivity timer to OFF for Down, for documentary
309 purposes.
Paul Jakmad1b1cd82006-07-04 13:50:44 +0000310 (nsm_kill_nbr) Oops, action function shouldn't try return
311 1 for error.
Paul Jakma5db95bc2006-07-04 13:52:29 +0000312 * ospf_lsa.c: (ospf_translated_nssa_refresh) CID #13.
Paul Jakmad7b0fb62006-07-04 13:35:24 +0000313
Andrew J. Schorr1c066bf2006-06-30 16:53:47 +00003142006-06-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
315
316 * ospf_vty.c: (show_ip_ospf_neighbor_id) Should show all instances
317 of that neighbor (since it may appear on multiple interfaces)
318 instead of bailing out after showing the first match.
319
Andrew J. Schorr76947872006-06-30 03:21:05 +00003202006-06-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
321
322 * ospf_nsm.c: (nsm_twoway_received) When deciding whether to
323 change from state Init to ExStart, the test for whether the
324 neighboring router is DR or BDR should be against the
325 local router's notion of DR/BDR, not the neighbor's view.
326
Andrew J. Schorrd7e60dd2006-06-29 20:20:52 +00003272006-06-28 Erik Muller <erikm@internap.com>
328
329 * ospfd.h: Define 2 new struct ospf config flags:
330 OSPF_LOG_ADJACENCY_CHANGES and OSPF_LOG_ADJACENCY_DETAIL
331 * ospf_nsm.c (nsm_change_state): Log adjacency changes if
332 requested.
333 * ospf_vty.c (ospf_log_adjacency_changes): New command function
334 to implement ospf subcommand "log-adjacency-changes [detail]".
335 (no_ospf_log_adjacency_changes) Turn off log-adjacency-changes.
336 (show_ip_ospf) Show whether adjacency changes are logged.
337 (ospf_config_write) Add "log-adjacency-changes [detail]" to config.
338 (ospf_vty_init) Add ospf_log_adjacency_changes and
339 no_ospf_log_adjacency_changes.
340
Paul Jakma9560fa82006-06-26 12:50:06 +00003412006-06-26 Paul Jakma <paul.jakma@sun.com>
342
343 * ospf_abr.c: (general) NSSA translate-candidate ABRs need to
344 be ASBRs, or other routers may rightfully refuse to install
345 translated type-5s LSAs. reported by dendroot@gmail.com.
346 (ospf_abr_nssa_check_status) Detect change in translator
347 state when ABR, and inc/dec redistribute count as when we
348 leave/enter the disabled state - so that translate-enabled
349 ABR properly sets ASBR bit on non-NSSA areas.
350 Run the resulting function through indent to clean it up.
351 * ospf_lsa.c: (router_lsa_flags) For purposes of ASBR bit,
352 NSSA area is same as stub area.
353
Andrew J. Schorr0ffb7092006-06-24 19:40:13 +00003542006-06-24 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
355
Andrew J. Schorr9aecfae2006-06-24 20:05:02 +0000356 * ospf_snmp.c: (ospfTrapNbrStateChange, ospfTrapIfStateChange) Improve
357 info log message to indicate why the trap is being sent.
358
3592006-06-24 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
360
Andrew J. Schorr0ffb7092006-06-24 19:40:13 +0000361 * ospf_dump.c: (config_write_debug) Fix typo to show debug ospf nsm
362 status properly (not ism status).
363
Andrew J. Schorr6e72cb62006-06-18 00:45:48 +00003642006-06-17 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
365
366 * ospf_vty.c: ({no_,}ospf_passive_interface) Replace if_lookup_by_name
367 with a call to if_get_by_name -- if the interface does not exist
368 already, it should be created. And remove the obsolete warning
369 message.
370
Paul Jakma429ac782006-06-15 18:40:49 +00003712006-06-15 Paul Jakma <paul.jakma@sun.com>
372
373 * ospf_interface.h: (struct ospf_if_info) Add reference counts
374 for multicast group memberships. Add various macros to help
375 manipulate/check membership state.
376 * ospf_interface.c: (ospf_if_set_multicast) Maintain the
377 ospf_if_info reference counts, and only actually drop
378 memberships if it hits 0, to avoid losing membership when
379 OSPF is disabled on an interface with multiple active OSPF
380 interfaces.
381 * ospf_packet.c: (ospf_{hello,read}) Use the new macros to
382 check/set
383 multicast membership.
384 * ospf_vty.c: (show_ip_ospf_interface_sub) ditto.
385
Paul Jakmaac904de2006-06-15 12:04:57 +00003862006-05-31 Paul Jakma <paul.jakma@sun.com>
387
388 * ospf_lsdb.c: (ospf_lsdb_delete) robustify against NULL arguments,
389 print warning.
390 * ospf_lsa.c: (ospf_discard_from_db) ditto.
391 (ospf_maxage_lsa_remover) Check lsa->lsdb for validity, possible
392 mitigation (but not solution) for bug #269.
393
Paul Jakma88871b12006-06-15 11:41:19 +00003942006-05-30 Paul Jakma <paul.jakma@sun.com>
395
396 * ospf_packet.c: (ospf_read) Debug message about packets
397 received on unenabled interfaces should be conditional on
398 debug being set.
399
Paul Jakmad1c65c22006-06-27 08:01:43 +00004002006-05-23 Paul Jakma <paul.jakma@sun.com>
401
402 * ospf_vty.c: (general) Replace in-place route redistribution
403 command and help strings with the new auto-generated defines
404 from lib/route_types.h
405
Paul Jakmaae128052006-05-12 23:15:30 +00004062006-05-13 Paul Jakma <paul.jakma@sun.com>
407
408 * ospf_lsa.c: (ospf_translated_nssa_refresh) fix the sanity
409 check to match the assert, small error in CID #13 fix.
410
Paul Jakma70461d72006-05-12 22:57:57 +00004112006-05-12 Paul Jakma <paul.jakma@sun.com>
412
413 * ospf_lsa.c: (ospf_lsa_action) Get rid of the ospf_lookup
414 call, which is not checked for NULL return, by stripping out
415 functionality which is never used, hence fixing Coverity CID
416 #29.
417 (struct lsa_action) remove unused member.
Paul Jakmae54e6e52006-05-12 23:11:14 +0000418 (ospf_translated_nssa_refresh) Add non-assert sanity check,
419 in case DEBUG isn't defined.
420 Debug message when no type7 exists should print the ID from
421 the type5, not the type7, fixes CID #13.
422 * ospf_interface.c: (ospf_if_exists) Fix missing NULL return
Paul Jakmae43be0e2006-05-12 23:00:06 +0000423 check on ospf_lookup, CID #27.
Paul Jakma6db3a6f2006-05-12 23:02:46 +0000424 * ospf_asbr.c: (ospf_redistribute_withdraw) remove ospf_lookup
425 call by taking the struct ospf * as argument, which the
426 caller has, fixing CID #28.
427 * ospf_asbr.h: (ospf_redistribute_withdraw) update declaration
428 * ospf_zebra.c: (ospf_redistribute_unset) update call to
429 ospf_redistribute_withdraw to match.
Paul Jakmabfd7c7d2006-05-12 23:04:45 +0000430 * ospf_ia.c: (ospf_update_router_route) ospf->backbone could be
431 NULL when passed to ospf_find_asbr_route_through_area,
432 check for NULL first, CID #14.
Paul Jakmadeb15612006-05-12 23:07:27 +0000433 * ospf_ism.c: (ism_change_state) NULL check on oi->area is
434 useless, it's always valid. Only possibility where it
435 couldn't be is if there is a race between abr_task and
436 cleaning up oi's, in which case a NULL check here isn't going
437 to do anything. Fixes CID #15.
Paul Jakma70461d72006-05-12 22:57:57 +0000438
Paul Jakmacac3b5c2006-05-11 13:31:11 +00004392006-05-11 Paul Jakma <paul.jakma@sun.com>
440
441 * ospf_vty.c: (general) Audit ospf_lookup calls in commands,
442 ensure check for NULL result, make vty messages consistent.
443 (show_ip_ospf_interface) Missing NULL check on ospf_lookup
444 result, fixes Coverity CID #70.
Paul Jakma1a8ec2b2006-05-11 13:34:08 +0000445 (no_ospf_area_filter_list) Check NULL result from
446 ospf_area_lookup_by_area_id, fixes Coverity CID #69
Paul Jakma894f8b62006-05-12 22:50:40 +0000447 * ospf_route.c: (ospf_route_delete_same_ext) Fix deref before
448 NULL check by moving into check-protected block, fix CID #49.
Paul Jakma214a4452006-05-12 22:51:49 +0000449 * ospf_abr.c: (ospf_area_range_cost_set) Shouldn't create a new
450 range, should just lookup to see if one exists, the new range
451 is just leaked. Fixes CID #46.
Paul Jakma4021b602006-05-12 22:55:41 +0000452 * ospf_lsa.c: (ospf_default_originate_timer) Let the thread
453 take (struct ospf *) as thread argument, rather than (struct
454 ospf *)->default_originate, thus avoiding having to call
455 ospf_lookup.
456 * ospf_zebra.c: (ospf_redistribute_default_set) change setup
457 of ospf_default_originate_timer thread to match.
458 * ospfd.c: (ospf_router_id_update) ditto.
Paul Jakmacac3b5c2006-05-11 13:31:11 +0000459
Paul Jakma9c27ef92006-05-04 07:32:57 +00004602006-04-24 Paul Jakma <paul.jakma@sun.com>
461
462 * (general) More Virtual-link fixes, again with much help in
463 testing / debug from Juergen Kammer. Primarily in SPF.
464 * ospf_spf.h: Add guard. ospf_interface.h will include this
465 header.
466 * ospf_interface.h: Modify ospf_vl_lookup definition to take
467 struct ospf as argument, so as to allow for NULL area
468 argument.
469 (struct ospf_vl_data) Remove out_oi, instead add a struct
470 vertex_nexthop, to use as initial nexthop for backbone paths
471 through a vlink.
472 * ospf_interface.c: (ospf_vl_lookup) Modified to allow
473 NULL area to be passed to indicate "any" (first) area.
474 Add extra debug.
475 (ospf_vl_set_params) vl_oi -> nexthop. Add extra debug.
476 (ospf_vl_up_check) Fix debug, inet_ntoa returns a static
477 buffer..
478 * ospf_route.c: (ospf_intra_add_router) Vlinks dont go through
479 backbone, don't bother checking.
480 * ospf_spf.c: (static struct list vertex_list) Record vertices
481 that will need to be freed.
482 (cmp) Order network before router vertices, as required,
483 wasn't implemented.
484 (vertex_nexthop_free) Mild additional robustness check.
485 (vertex_parent_free) Take void argument, as this function
486 is passed as list deconstructor for vertex parent list.
487 (ospf_vertex_new) More debug. Set deconstructor for parent
488 list. Track allocated vertices on the vertex_list.
489 (ospf_vertex_free) Get rid of the tricky recursive cleanup of
490 vertices. Now frees only the given vertex.
491 (ospf_vertex_add_parent) Fix assert.
492 (ospf_nexthop_calculation) Fix calculation of nexthop for
493 VLink vertices, lookup the vl_data and use its previously
494 recorded nexthop information.
495 (ospf_spf_calculate) Vertices are freed simply by deleting
496 vertex_list nodes and letting ospf_vertex_free as deconstructor
497 work per-node.
498 (ospf_spf_calculate_timer) Trivial optimisation, leave
499 backbone SPF calculation till last to reduce SPF churn on
500 VLink updates.
501 * ospf_vty.c: (ospf_find_vl_data) update call to ospf_vl_lookup
502 (no_ospf_area_vlink_cmd) ditto.
503 (show_ip_ospf_interface_sub) For Vlinks, the peer address is
504 more interesting than the output interface.
505
Paul Jakma478aab92006-04-03 21:25:32 +00005062006-04-03 Paul Jakma <paul.jakma@sun.com>
507
508 * (general) Fix issues with handling of Vlinks and entries
509 in the nbrs route-table which were highlighted by the
510 nsm/nbr_self fixes from bug #234. Many thanks to Juergen
511 Kammer for his help and efforts in testing out debug patches to
512 pinpoint the issue.
513 * ospf_interface.c: (ospf_vl_new) Add nbr_self for Vlink.
514 * ospf_neighbor.c: (ospf_nbr_key) new static function, helper
515 to create key in nbrs table for a given nbr.
516 (ospf_nbr_delete) Use ospf_nbr_key. Add an assert() to
517 document an expected state.
518 (ospf_nbr_add_self) Ditto.
519 (ospf_nbr_lookup_by_addr) Add an assert.
520 * ospf_nsm.c: (nsm_kill_nbr) Can never kill the nbr_self
521 psuedo-neighbour.
522
Paul Jakma075c2012006-03-30 14:34:31 +00005232006-03-27 Paul Jakma <paul.jakma@sun.com>
524
525 * ospf_lsa.c: (ospf_lsa_checksum) Add an explicit cast to avoid
526 the ambiguities of ANSI and C99 C with respect to type
527 conversion. Detailed problem report and test case with
528 example data supplied by Dmitry Ivanov <dimss@telecentrs.lv>.
529
Paul Jakma1a8ee0e2006-03-30 14:20:00 +00005302006-03-25 Paul Jakma <paul.jakma@sun.com>
531
532 * ospf_interface.c: (ospf_if_lookup_recv_if) Ignore loopbacks,
533 we can never ever receive packets on those. Should fix
534 case where CARP is run with address in same subnet as real
535 interface. Problem report and diagnosis thanks to:
536 Landon Fuller <landonf@opendarwin.org>.
537 However, ospf_read() still can't deal deterministically with
538 multiple interfaces in same subnet.
539
Paul Jakmac2b478d2006-03-30 14:16:11 +00005402006-03-23 Steve Lawson <steve.lawson@aheadcomusa.com>
541
542 * ospf_lsa.c: (ospf_lsa_install) Fix incorrect byte-order
543 conversion of OSPF_MAX_SEQUENCE_NUMBER
544
paule8e19462006-01-19 20:16:55 +00005452006-01-19 Paul Jakma <paul.jakma@sun.com>
546
547 * (general) various miscellaneous compiler warning fixes.
548 Remove redundant break statements from switch clauses
549 which return.
550 return from main, not exit, cause it annoys SOS.
551 Remove stray semi-colons which cause empty-statement
552 warnings.
553
paul779adb02006-01-18 15:07:38 +00005542006-01-18 Juergen Kammer <j.kammer@eurodata.de>
555
556 * ospf_lsa.c: (ospf_router_lsa_new) dont take reference to the
557 stream data until it is constructed, data reference is
558 volatile due to the potential resize in link_info_set
559
5602006-01-18 Paul Jakma <paul.jakma@sun.com>
561
562 * ospf_lsa.c: (link_info_set) Resize the stream if required and
563 possible. Return number of links added.
564 (lsa_link_*_set) use return value from previous.
565 * ospf_lsa.h: Add OSPF_ROUTER_LSA_LINK_SIZE define.
566
paulc6371712006-01-17 17:49:53 +00005672006-01-17 Paul Jakma <paul.jakma@sun.com>
568
569 * ospf_packet.c: (ospf_verify_header) print out the types
570 involved if there's a mismatch.
571 * ospf_zebra.c: (ospf_zebra_add) Adjust to new zserv format.
572
paul818e56c2006-01-10 23:27:05 +00005732006-01-10 Len Sorensen <lennartsorensen@ruggedcom.com>
574
575 * (general) Bug #234, see also [quagga-dev 3902].
576 Fix problem with nbr_self not being properly reinitialised
577 when an interface comes up, after having been down.
paul1a643f82006-01-11 01:08:19 +0000578 Some re-arrangement done by Paul Jakma, any bugs introduced
579 on top of Len's suggested changes are his.
paul818e56c2006-01-10 23:27:05 +0000580 * ospf_neighbor.c: (ospf_nbr_add_self) centralise
581 initialisation of nbr_self parameters here.
582 * ospf_interface.c: (ospf_if_new) deleting initialisation of
583 parameters of nbr_self, just rely on call to
584 ospf_nbr_add_self.
585 (ospf_if_cleanup) ditto.
586 * ospfd.c: (ospf_network_run) ditto.
587
paul98429f62006-01-10 22:11:54 +00005882006-01-10 Juris Kalnins <juris@mt.lv>
589
590 * ospf_zebra.c: (ospf_interface_address_delete) fix rare leak of
591 struct connected in an error case.
paul818e56c2006-01-10 23:27:05 +0000592 * ospf_packet.c: (ospf_make_md5_digest) fix odd, if not
593 undefined effect, assignment of an increment expression.
paul98429f62006-01-10 22:11:54 +0000594
paul86752842006-01-10 20:34:46 +00005952006-01-10 Paul Jakma <paul.jakma@sun.com>
596
597 * ospfd.c: (ospf_network_run) checking to see if router-id
598 is set should be on ospf->router_id, not router_id_static.
599 This was causing ospfd to not start if router-id had not
600 been configured statically.
601 (ospf_if_update) ditto.
paulc42c1772006-01-10 20:36:49 +0000602 * ospf_vty.c: (config_write_ospf_distribute) trim down
603 redundant strings.
paul86752842006-01-10 20:34:46 +0000604
paul00c290e2005-11-26 09:21:43 +00006052005-11-26 Paul Jakma <paul.jakma@sun.com>
606
607 * ospf_api.c: (struct opaque_lsa) change from gcc zero-length
608 array to C99 incomplete type array.
paulc9c93d52005-11-26 13:31:11 +0000609 * (general) s/graceful/deferred/ in all files, the former term
610 is confusing wrt OSPF Graceful-Restart.
611 * ospfd.c: (ospf_deferred_shutdown_check) dont return
612 a function which returns void. SOS complains about this.
613 (ospf_finish)
paul00c290e2005-11-26 09:21:43 +0000614
paulb29800a2005-11-20 14:50:45 +00006152005-11-20 Paul Jakma <paul.jakma@sun.com>
616
617 * ospfd.h: remove the OSPF_ROUTER_ID_UPDATE_DELAY define
618 (struct ospf) remove the router_id timer thread.
619 remove export of ospf_router_id_update_timer.
620 * ospfd.c: (ospf_router_id_update) call ospf_if_update to
621 poke interfaces into action after ID has been configured.
622 (ospf_router_id_update_timer) removed.
623 (ospf_finish_final) t_router_id_update timer is gone.
624 (ospf_network_run) router-id update timer gone.
625 call ospf_router_id_update directly if ID not configured.
626 In the per-iface loop, don't ospf_if_up interfaces if
627 ID is still not configured. The update function will call
628 ospf_if_update anyway.
629 (ospf_if_update) ID update timer is gone. Just return if no
630 ID is set.
631 * ospf_vty.c: (ospf_router_id) call ospf_router_id_update, no
632 timer needed.
633 * ospf_zebra.c: (ospf_router_id_update_zebra) call
634 ospf_router_id_update directly, not via timer.
paulc24d6022005-11-20 14:54:12 +0000635 * ospf_abr.c: (ospf_abr_announce_network_to_area) check
636 returned LSA of ospf_summary_lsa_refresh and print warning if
637 it failed.
638 (ospf_abr_announce_network_to_area) similar
639 (ospf_abr_announce_rtr_to_area) similar
640 * ospf_lsa.c: (ospf_router_lsa_new) check LSA returned is valid.
641 (ospf_router_lsa_originate) similar
642 (ospf_router_lsa_refresh, ospf_network_lsa_new) similar
643 (ospf_summary_lsa_new) Check ID is valid.
644 (ospf_summary_lsa_originate) ditto, and check returned LSA from
645 previous function is !NULL.
646 (ospf_summary_lsa_refresh) check ospf_summary_lsa_new return
647 is !NULL.
648 (ospf_summary_asbr_lsa_new) ID valid check.
649 (ospf_summary_asbr_lsa_originate) similar.
paulb29800a2005-11-20 14:50:45 +0000650
ajs70cd3472005-11-16 19:33:22 +00006512005-11-16 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
652
ajs649654a2005-11-16 20:17:52 +0000653 * ospf_dump.h: Define OSPF_TIME_DUMP_SIZE as appropriate buffer size
654 for use with ospf_timer_dump and ospf_timeval_dump.
655 * ospf_vty.c: Change all buffer sizes used with ospf_timer_dump and
656 ospf_timeval_dump to have size OSPF_TIME_DUMP_SIZE.
657 (show_ip_ospf_interface_sub) Fix possible buffer overflow in
658 call to ospf_timer_dump.
659
6602005-11-16 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
661
ajs70cd3472005-11-16 19:33:22 +0000662 * ospf_ism.h: (OSPF_ISM_TIMER_OFF) Improve macro syntax by enclosing
663 in 'do {...} while(0)'.
664
paul31a59762005-11-14 11:11:11 +00006652005-11-14 Paul Jakma <paul.jakma@sun.com>
666
667 * ospfd.c: (ospf_new) stub-shutdown should just default to
668 unconfigured, too strange otherwise.
669 (ospf_finish_final) t_opaque_lsa_self TIMER_OFF should be
670 preprocessor conditional on HAVE_OPAQUE_LSA.
671 * ospfd.h: (struct ospf) remove the SHUTDOWN_DEFAULT define.
672 no longer used, plus it wasn't in range that the command
673 accepted.
674 * ospf_zebra.h: Depends on vty.h, include it.
675
paul58e1bef2005-11-11 12:10:03 +00006762005-11-11 Paul Jakma <paul.jakma@sun.com>
677
678 * ospf_spf.c: (ospf_canonical_nexthops_free) Free only
679 the nexthops pointing to the root vertex. We may visit a
680 vertex twice or the vertex may have some inherited nexthops,
681 if we free other nexthops we could crash.
682
paulc8c15212005-11-04 12:31:39 +00006832005-11-04 Paul Jakma <paul.jakma@sun.com>
684
685 * ospf_{dump,spf,vty}.c: Oops, use the internal tv_sub
686 function rather than unportable timersub.
687
paul484315f2005-11-03 09:08:29 +00006882005-11-03 Paul Jakma <paul.jakma@sun.com>
689
690 * ospf_apiserver.c: (apiserver_sync_callback) stray semi-colon
691 * ospf_packet.c: include checksum.h, remove the in_cksum extern
692 * prototypes.
693 * ospf_te.h: Add braces, quell warning.
paul6d452762005-11-03 11:15:44 +0000694 * ospf_packet.c: Change level of some warnings to
695 informational.
paulc8c15212005-11-04 12:31:39 +0000696
paul88d6cf32005-10-29 12:50:09 +00006972005-10-29 Paul Jakma <paul.jakma@sun.com>
698
699 * (general) RFC3137 stub-router support
700 * ospfd.h: Add OSPF_OUTPUT_COST_INFINITE define.
701 (struct ospf_master) Add a OSPF_MASTER_SHUTDOWN flag for
702 options, to allow shutdown to distinguish between complete
703 shutdown and shutdown of a subset of ospf instances.
704 (struct ospf)
705 Add stub_router_{startup,shutdown_}time, configuration of startup
706 and shutdown time for stub-router.
707 Add t_graceful_shutdown struct thread, timer for graceful
708 shutdown, if needed.
709 (struct ospf_area) Add stub_router_state - run time state of
710 stub-router for an area. Add flags for ADMIN, IS and WAS
711 states.
712 Add t_stub_router, timer thread to resend router-lsa for an
713 area.
714 * ospf_lsa.c: (ospf_link_cost) new simple function to spit out
715 either the given lnks cost or infinite cost if stub-router is
716 in effect.
717 (lsa_link_{ptop,broadcast,virtuallink,ptomp}_set) use
718 previous function for transit-links.
719 (ospf_stub_router_timer) timer thread for end of startup stub
720 router. Change state as required for the area and setup
721 re-origination of router-lsa.
722 (ospf_stub_router_check) Check/do whether stub-router should be
723 enabled, and whether it requires timer to be setup.
724 (ospf_router_lsa_new) call previous function at top.
725 (ospf_router_lsa_originate) no external callers, made static.
726 * ospf_lsa.h: (ospf_router_lsa_originate) removed.
727 * ospf_main.c: (sigint) make static.
728 remove call to exit, as ospf_terminate now deals with
729 exiting.
730 * ospf_route.c: (ospf_terminate) removed, now in ospfd.c.
731 * ospf_vty.c: (show_ip_ospf_area) print out state of
732 stub-router, if active.
733 (show_ip_ospf) print out configuration of stub-router
734 support, and details of graceful-shutdown if the timer is
735 active.
736 ((no)?ospf_max_metric_router_lsa_{admin,startup,shutdown}) new
737 commands to (de-)?configure stub-router support.
738 (config_write_stub_router) write out config of stub-router.
739 (ospf_config_write) call previous.
740 (ospf_vty_init) install the new stub-router commands.
741 * ospfd.c: various functions made static.
742 (ospf_new) Set defaults for stub-router. Graceful shutdown
743 is made to default on, just to be adventerous.
744 (ospf_graceful_shutdown_finish) new function, final part of
745 shutdown.
746 (ospf_graceful_shutdown_timer) timer thread wrapper for
747 graceful-shutdown.
748 (ospf_graceful_shutdown_check) check whether to setup timer
749 for shutdown or proceed directly to final shutdown.
750 (ospf_terminate) moved here from ospf_route.c, call
751 ospf_finish for each instance.
752 (ospf_finish) renamed to ospf_finish_final and made static.
753 (ospf_finish) new function, exported wrapper around
754 ospf_graceful_shutdown_check.
755 (ospf_finish_final) complete shutdown of an instance.
756 Add missing TIMER_OFF's of two timer threads.
757 (ospf_area_free) opaque self lsa timer should be turned off.
758
paulb8ad39d2005-10-23 15:23:05 +00007592005-10-23 Paul Jakma <paul.jakma@sun.com>
760
paule029d442005-10-23 15:26:24 +0000761 * ospf_apiserver.c: (ospf_apiserver_term) This function should
762 not have side-effects (eg segv) if no apiserver instances are
763 active, ie be robust.
paulb8ad39d2005-10-23 15:23:05 +0000764 * ospf_vty.c: (show_ip_ospf) fix display of SPF timer if it
765 has not yet been run.
766
paulf9ad9372005-10-21 00:45:17 +00007672005-10-21 Paul Jakma <paul.jakma@sun.com>
768
paulea4ffc92005-10-21 20:04:41 +0000769 * ospf_dump.c: (ospf_timeval_dump) fix ms adjustment, thanks to
770 Andrew Schorr.
771 * ospf_vty.c: (ospf_config_write) fix write out of spf timers
772 configuration.
773
7742005-10-21 Paul Jakma <paul.jakma@sun.com>
775
pauld24f6e22005-10-21 09:23:12 +0000776 * (general) SPF millisecond resolution timer with adaptive,
777 linear back-off holdtime. Prettification of ospf_timer_dump.
778 * ospf_dump.c: (ospf_timeval_dump) new function. The guts of
779 ospf_timer_dump, but made to be more dynamic in printing out
780 the relative timeval, sliding the precision printed out
781 according to the value.
782 (ospf_timer_dump) guts moved to ospf_timeval_dump.
783 * ospf_dump.h: export ospf_timeval_dump.
784 * ospf_flood.c: (ospf_flood) remove gettimeofday, use
785 the libzebra exported recent_time instead, as it's not
786 terribly critical to have time exactly right - the dropped
787 LSA will be retransmited to us if we don't ACK it.
788 * ospf_packet.c: (ospf_ls_upd_timer) Ditto, but here we're
789 not transmitting, just putting LSA back on update transmit list.
790 * ospfd.h: delay and holdtimes should be unsigned.
791 Add spf_max_holdtime and spf_hold_multiplier.
792 Update default defines for delay and hold time to be in msec.
793 (struct ospf) change the SPF timestamp to a struct timeval.
794 Remove ospf_timers_spf_(un)?set.
795 * ospfd.c: (ospf_timers_spf_{set,unset}) removed.
796 (ospf_new) initialise spf_max_holdtime and spf_hold_multiplier
797 * ospf_spf.c: (ospf_spf_calculate) SPF timestamp is a timeval
798 now, update with gettimeofday.
799 (ospf_spf_calculate_schedule) Change SPF timers to millisecond
800 resolution.
801 Make the holdtime be adaptive, with a linear increase in
802 holdtime ever consecutive SPF run which occurs within holdtime
803 of previous SPF, bounded by spf_max_holdtime.
804 * ospf_vty.c: Update spf timers commands.
805 (ospf_timers_spf_set) trivial helper.
806 (ospf_timers_throttle_spf_cmd) new command to set SPF delay,
807 initial hold and max hold times with millisecond resolution.
808 (ospf_timers_spf_cmd) Deprecated. Accept the old values,
809 convert to msec, truncate to new limits.
810 (no_ospf_timers_throttle_spf_cmd) set timers to defaults.
811 (no_ospf_timers_spf_cmd) deprecated form, same as previous.
812 (show_ip_ospf_cmd) Display SPF parameters and times.
813 (show_ip_ospf_neighbour_header) Centralise the 'sh ip os ne'
814 header.
815 (show_ip_ospf_neighbor_sub) Fix the field widths. Get rid of
816 the multiple spaces which were making the lines even longer.
817 (show_ip_ospf_neighbor_cmd) Use show_ip_ospf_neighbour_header
818 (show_ip_ospf_neighbor_all_cmd) ditto and fix the field
819 widths for NBMA neighbours.
820 (show_ip_ospf_neighbor_int) Use header function.
821 (show_ip_ospf_nbr_nbma_detail_sub) use sizeof for timebuf,
822 local array - safer.
823 (show_ip_ospf_neighbor_detail_sub) ditto
824 (ospf_vty_init) install the new SPF throttle timer commands.
825
8262005-10-21 Paul Jakma <paul.jakma@sun.com>
827
paulf9ad9372005-10-21 00:45:17 +0000828 * (general) OSPF fast, sub-second hello and 1s dead-interval
829 support.
830 * ospf_dump.c: (ospf_timer_dump) Print out milliseconds too.
831 Callers typically specify a length of 9, so most see
832 millisecs unless they specify the additional length.
833 * ospf_interface.h: (struct ospf_interface) new interface param,
834 fast_hello.
835 * ospf_interface.c: (ospf_if_table_lookup) add brackets,
836 gcc warning fix.
837 (ospf_new_if_params) Initialise fast_hello param.
838 (ospf_free_if_params) Check whether fast_hello is configured.
839 (ospf_if_new_hook) set fast_hello to default.
840 * ospf_ism.h: Wrap OSPF_ISM_TIMER_ON inside do {} while (0) to
841 prevent funny side-effects from its if statement when this
842 macro is used conditionally by other macros.
843 (OSPF_ISM_TIMER_MSEC_ON) new macro, set in milliseconds.
844 (OSPF_HELLO_TIMER_ON) new macro to set hello timer according
845 to whether fast_hello is set.
846 * ospf_ism.c: Update all setting of the hello timer to use
847 either OSPF_ISM_TIMER_MSEC_ON or OSPF_HELLO_TIMER_ON. The
848 former is used when hello is to be sent immediately.
849 * ospf_nsm.c: ditto
850 * ospf_packet.c: (ospf_hello) hello-interval is not checked
851 for mismatch if fast_hello is set.
852 (ospf_read) Annoying nit, fix "no ospf_interface" to be debug
853 rather than a warning, as it can be perfectly normal to
854 receive packets when logical subnets are used.
855 (ospf_make_hello) Set hello-interval to 0 if fast-hellos are
856 configured.
857 * ospf_vty.c: (ospf_auto_cost_reference_bandwidth) annoying
858 nit, don't vty_out if this command is given, it gets tired
859 quick.
860 (show_ip_ospf_interface_sub) Print the hello-interval
861 according to whether fast-hello is set or not.
862 Print the extra 5 millisec characters from (ospf_timer_dump)
863 if fast-hello is configured.
864 (ospf_vty_dead_interval_set) new function, common to all
865 forms of dead-interval command, to set dead-interval and
866 fast-hello correctly. If a dead-interval is given, unset
867 fast-hello, else if a hello-multiplier is set, set
868 dead-interval to 1 and fast-hello to given multiplier.
869 (ip_ospf_dead_interval_addr_cmd) use
870 ospf_vty_dead_interval_set().
871 (ip_ospf_dead_interval_minimal_addr_cmd) ditto.
872 (no_ip_ospf_dead_interval) Unset fast-hello.
873 (no_ip_ospf_hello_interval) Bug-fix, unset of hello-interval
874 should set it to OSPF_HELLO_INTERVAL_DEFAULT, not
875 OSPF_ROUTER_DEAD_INTERVAL_DEFAULT.
876 (config_write_interface) Write out fast-hello.
877 (ospf_config_write) Write a comment about
878 "auto-cost reference-bandwidth" having to be equal on all
879 routers. Hopefully just as noticeable as old practice of
880 writing to vty, but less annoying.
881 (ospf_vty_if_init) install the two new dead-interval
882 commands.
883 * ospfd.h: Add defines for OSPF_ROUTER_DEAD_INTERVAL_MINIMAL
884 and OSPF_FAST_HELLO_DEFAULT.
885
pauleb3da6d2005-10-18 04:20:33 +00008862005-10-18 Paul Jakma <paul.jakma@sun.com>
887
888 * (general) SPF memory management cleanup and fix for rare
889 double-free bug.
890 * ospf_spf.h: (struct vertex_parent) New struct to hold parent
891 specific data, eg the backlink and the parent vertex pointer,
892 and point to the appropriate general struct vertex_nexthop.
893 (struct vertex_nexthop) remove parent vertex pointer, so
894 this struct can be shared across vertices.
895 (struct vertex) rename list child to list children. Remove
896 list of nexthops, replace with list of vertex_parents.
897 * ospf_spf.c: (update_stat) trivial, remove cast from void *.
898 (vertex_nexthop_new) remove init of parent - field is gone
899 from struct vertex_nexthop.
900 (ospf_canonical_nexthops_free) Remove the canonical
901 vertex_nexthop memory objects. These are the vertex_nexthops
902 attached to the first level of router vertices from the root.
903 (vertex_parent_new) new function, create a vertex_parent.
904 (vertex_parent_free) ditto, but free it.
905 (ospf_vertex_new) Update to match changes to struct vertex.
906 (ospf_vertex_free) Recursively free a struct vertex and its
907 children. The parent list is used as a reference count.
908 vertex_nexthops must be free seperately, if required.
909 (ospf_vertex_dump) update to match struct vertex changes.
910 Print out backlink of parents too.
911 (ospf_vertex_add_parent) ditto.
912 (ospf_lsa_has_link) update comment.
913 (ospf_nexthop_add_unique) removed, not needed anymore.
914 (ospf_nexthop_merge) ditto.
915 (ospf_spf_consider_nexthop) renamed to ospf_spf_add_parent.
916 Simplified to just create vertex_parent and add it.
917 (ospf_spf_flush_parents) new function, flush out the parent
918 list.
919 (ospf_nexthop_calculation) Take the relevant route_lsa_link
920 as an argument, which simplifies things and removes the need
921 for the hack in ospf_nexthop_add_unique - ospf_spf_next
922 already knew exactly which link the cost calculated was for.
923 Update to match struct vertex changes too.
924 (ospf_spf_next) Don't create a vertex for W unnecessarily, if
925 it's there's a vertex already created for W, use it, and
926 hence there's no need to free it either.
927 Update some manipulation/comparisons of distance to match.
928 Flush the parent list if a lower cost path is found.
929 (ospf_spf_route_free) unused, removed.
930 (ospf_spf_dump) match the struct vertex changes, and dump the
931 ifname if possible.
932 (ospf_spf_calculate) At end of SPF, free the canonical nexthops
933 and call ospf_vertex_free on the root vertex to free the
934 entire tree.
935 * ospf_interface.c: (ospf_vl_set_params) match struct vertex
936 changes.
937 * ospf_route.c: (ospf_intra_route_add) ditto
938 (ospf_route_copy_nexthops_from_vertex) ditto
939
paul36238142005-10-11 04:12:54 +00009402005-10-11 Paul Jakma <paul.jakma@sun.com>
941
942 * ospf_api.c: sign warnings.
943 * ospf_apiserver.c: sign warning and convert all the struct
944 in_addr initialisations so as not to make assumptions about
945 how this struct is organised, initialise the s_addr member
946 explicitely.
947 * ospf_packet.c: Add const qualifier to auth_key.
948
vincent77df1f72005-10-06 07:46:22 +00009492005-10-06 Alain Ritoux <alain.ritoux@6wind.com>
950
951 * ospf_snmp.c: Avoid mixing interface and ospf_interface objects
952 which now allows snmpwalk to work with ospfIfTable and
953 also with ospfIfMetricTable
954
ajsf52d13c2005-10-01 17:38:06 +00009552005-10-01 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
956
957 * ospf_dump.c: Remove local hard-coded table ospf_redistributed_proto.
958 (ospf_redist_string) New function implemented using new library
959 function zebra_route_string(). Note that there are a few differences
960 in the output that will result: the new function returns strings
961 that are lower-case, whereas the old table was mixed case. Also,
962 the old table mapped ZEBRA_ROUTE_OSPF6 to "OSPFv3", whereas the
963 new function returns "ospf6".
964 * ospfd.h: Remove extern struct message ospf_redistributed_proto[],
965 and add extern const char *ospf_redist_string(u_int route_type)
966 instead.
967 * ospf_asbr.c: (ospf_external_info_add) In two messages, use
968 ospf_redist_string instead of LOOKUP(ospf_redistributed_proto).
969 * ospf_vty.c: Remove local hard-coded table distribute_str.
970 (config_write_ospf_redistribute,config_write_ospf_distribute): Use
971 new library function zebra_route_string() instead of distribute_str[].
972 * ospf_zebra.c: (ospf_redistribute_set,ospf_redistribute_unset,
973 ospf_redistribute_default_set,ospf_redistribute_check)
974 In debug messages, use ospf_redist_string() instead of
975 LOOKUP(ospf_redistributed_proto).
976
jardin6638c1a2005-10-01 00:08:54 +00009772005-09-30 Vincent Jardin <vincent.jardin@6wind.com>
978
979 * ospf_dump.c, ospf_ia.c, ospf_spf.c, ospf_ase.c:
980 remove unused DEBUG
981
vincentba682532005-09-29 13:52:57 +00009822005-09-29 Alain Ritoux <alain.ritoux@6wind.com>
983
vincent5e4914c2005-09-29 16:34:30 +0000984 * ospf_ism.c: generate SNMP traps on Interface state change
985 * ospf_nsm.c: generate SNMP traps on Neighbour state change
986 * ospf_snmp.[ch]: support for SNMP traps for interface and neighbours.
987
9882005-09-29 Alain Ritoux <alain.ritoux@6wind.com>
989
vincentba682532005-09-29 13:52:57 +0000990 * ospf_vty.c: forece default route LSA to be re_issued whenever
991 cost is changed ( [no] ip ospf area XXX default-cost YYY)
992 Support ignore-mtu option
993 * ospfd.h: define OSPF_MTU_IGNORE_DEFAULT
994 * ospf_packet.c: support ignore-mtu option
995 * ospf_interface.h: field added for skipping MTU check
996 * ospf_interface.c: fix memory leak in ospf_crypt_key_delete()
997 Set mtu_ignore field to default value
998 * ospf_abr.[ch]: export ospf_abr_announce_network_to_area()
999 * ospf_ism.h: add MACRO to convert internal ISM status into SNMP
1000 correct values
1001 * ospf_snmp.c: add sanity check on LSA type in lsdb_lookup_next()
1002 convert OSPFIFSTATE internal status into SNMP values
1003
vincentc1a03d42005-09-28 15:47:44 +000010042005-09-28 Alain Ritoux <alain.ritoux@6wind.com>
1005
1006 * ospf_packet.c: use new md5 API
1007
ajs5339cfd2005-09-19 13:28:05 +000010082005-09-19 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1009
1010 * ospf_lsa.h: (ospf_external_lsa_flush) Comment out the 5th argument
1011 (nexthop) since it is not used in the function (except inside
1012 some commented-out code).
1013 * ospf_lsa.c: (ospf_external_lsa_flush,ospf_external_lsa_refresh)
1014 Comment out the 5th argument to ospf_external_lsa_flush.
1015 * ospf_asbr.c: (ospf_redistribute_withdraw) Comment out 5th arg
1016 to ospf_external_lsa_flush.
1017 * ospf_vty.c: (no_ospf_default_information_originate) Eliminate 5th
1018 uninitialized nexthop arg to ospf_external_lsa_flush.
1019 * ospf_zebra.c: (ospf_zebra_read_ipv4) Comment out 5th arg
1020 to ospf_external_lsa_flush.
1021 * ospfd.c: (ospf_network_set) Comment out 5th arg
1022 to ospf_external_lsa_flush.
1023
ajse6a0bf92005-09-17 18:53:38 +000010242005-09-17 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1025
1026 * ospf_opaque.c:
1027 (ospf_opaque_lsa_refresh_schedule,ospf_opaque_lsa_flush_schedule)
1028 No need to call ospf_lookup(), just use lsa0->area->ospf instead.
1029
hassobb5b7552005-08-21 20:01:15 +000010302005-08-21 Hasso Tepper <hasso at quagga.net>
1031
1032 * ospf_vty.c: Make "show ip ospf neighbor xxx" commands work.
1033 Interface should be specified by name now.
1034
hasso54bedb52005-08-17 13:31:47 +000010352005-08-17 Hasso Tepper <hasso at quagga.net>
1036
1037 * ospf_vty.c: Check carefully if interface exists before trying to
1038 print info about it.
1039
hasso01018ce2005-08-05 07:40:15 +000010402005-08-05 Hasso Tepper <hasso at quagga.net>
1041
1042 * ospf_zebra.c: Don't assert/stop before type == ZEBRA_ROUTE_MAX if
1043 dealing with routemaps. There is ospf->route_map[ZEBRA_ROUTE_MAX]
1044 for default-information.
1045
paulc8987752005-07-26 06:07:22 +000010462005-07-26 Paul Jakma <paul.jakma@sun.com>
1047
1048 * ospf_abr.c: (ospf_abr_announce_network_to_area) SET_FLAG
1049 should be on lsa not old, which may be freed for one thing,
1050 obviously.
1051
pauld57834f2005-07-12 20:04:22 +000010522005-07-12 Paul Jakma <paul.jakma@sun.com>
1053
1054 * ospfd.h: add OSPF_ABR_DEFAULT for convenience, make
1055 OSPF_ABR_CISCO be the default ABR type.
1056 * ospfd.c: (ospf_new) initialise abr_type to OSPF_ABR_DEFAULT
1057 * ospf_vty.c: (no_ospf_abr_type_cmd) add standard as a negatable
1058 abr_type. default abr_type should be OSPF_ABR_DEFAULT.
1059 (ospf_config_write) test whether default abr_type against
1060 OSPF_ABR_DEFAULT, rather than any specific ABR_TYPE.
1061
hasso8469bd72005-06-20 20:50:10 +000010622005-06-20 Hasso Tepper <hasso at quagga.net>
hassof4833e92005-06-20 20:42:26 +00001063
1064 * ospf_nsm.c: Make database exchange for NSSA database work.
1065
paul7461d452005-06-13 13:57:16 +000010662005-06-13 Paul Jakma <paul.jakma@sun.com>
1067
1068 * ospf_spf.c: Try get more information on a SEGV under
1069 ospf_spf_vertex_add_parent.
1070 (ospf_vertex_free) NULL out the child and nexthop lists
1071 (ospf_vertex_add_parent) nexthop and child can not be NULL
1072 vertex_nexthop's parent->child list can not be NULL
1073 (ospf_spf_next) w and cw are per-loop iteration variables, move
1074 declarations into loop body.
1075
hasso1ddd7292005-06-07 19:54:04 +000010762005-06-07 Hasso Tepper <hasso at quagga.net>
1077
1078 * ospf_apiserver.c: Fix obvious error in notifying clients about ISM
1079 changes - oi->ifp->status doesn't give to us info about ISM,
1080 oi->state does.
1081
paul7e440862005-06-01 11:20:51 +000010822005-06-01 Akihiro Mizutani <mizutani@net-chef.net>
1083
1084 * ospf_ism.c (ospf_elect_bdr/ospf_elect_dr): Fix DR election bug.
1085
paul500e4182005-05-26 17:11:13 +000010862005-05-26 Paul Jakma <paul.jakma@sun.com>
1087
1088 * ospf_abr.c: (ospf_abr_update_aggregate) Fix comment, cost bug itself
1089 had been fixed long ago by Sowmini.
1090
paula3387a42005-05-18 23:29:57 +000010912005-05-19 Paul Jakma <paul.jakma@sun.com>
1092
1093 * ospf_interface.c: (ospf_if_table_lookup) Fix a serious bug
1094 a less serious one.
1095 1: this function is supposed to lookup
1096 entries in the oifs ospf_interface route_table and return either
1097 an existing oi or NULL to indicate not found, its caller depends
1098 on this, yet this function uses route_node_get which /always/
1099 returns a route_node - one is created if none exists. Use
1100 route_node_lookup instead. This should fix root cause of the
1101 reports of the (ospf_add_to_if) assert being hit.
1102 2: oi's are inserted into this table with prefixlength set to
1103 /32 (indeed, it should be a hash table, not a route_table),
1104 however prefixlength to lookup was not changed, if no valid entry
1105 can be inserted other than /32, then nothng but /32 should be
1106 looked up. This possibly only worked by fluke..
1107 Fix confirmed by 2 reporters (one list, one IRC), definitely a
1108 backport candidate once it has been incubated in HEAD for a while.
1109 Thanks to Patrick Friedel and Ivan Warren for testing.
1110
paul69310a62005-05-11 18:09:59 +000011112005-05-11 Paul Jakma <paul.jakma@sun.com>
1112
1113 * (general) Fix memory leaks in opaque AS-scope LSAs, reported and
1114 with much debugging done by by scott collins <scollins@agile.tv>.
1115 * ospf_lsa.c: (ospf_discard_from_db) dont call
1116 ospf_ase_unregister_external_lsa for opaque-lsa's, opaques are
1117 never registered with ase in the first place.
1118 * ospf_packet.c: (general) Disabuse opaque related code of its
1119 tendency to try gather up things into temporary lists.
1120 (ospf_ls_upd) remove the temporary lists opaque uses, call
1121 opaque functions inline, just like all other types.
1122 (ospf_ls_ack) ditto.
1123 (ospf_recv_packet) fixup sign warning.
1124 * ospf_opaque.c: (general) fix the unneeded use of lists, and
1125 untwist some of the logic.
1126 (ospf_opaque_self_originated_lsa_received) take a single LSA
1127 as argument, not a list of them. Remove the list loop. Logic
1128 otherwise unchanged.
1129 (ospf_opaque_ls_ack_received) Mostly ditto. But untwist the logic,
1130 move the actions up into the switch block, remove the goto's and
1131 sanitise the logic near the end a bit.
1132 * ospf_opaque.h: Adjust definitions of aforementioned functions
1133 in ospf_opaque.c to match.
1134
paul42c98192005-05-07 02:22:51 +000011352005-05-07 Yar Tikhiy <yar@comp.chem.msu.su>
1136
1137 * ospf_network.c: Log ifindex on multicast membership leave/join
1138 events.
1139
paul4dadc292005-05-06 21:37:42 +000011402005-05-06 Paul Jakma <paul.jakma@sun.com>
1141
1142 * (general) extern and static qualifiers added.
1143 unspecified arguments in definitions fixed, typically they should
1144 be 'void'.
1145 function casts added for callbacks.
1146 Guards added to headers which lacked them.
1147 Proper headers included rather than relying on incomplete
1148 definitions.
1149 gcc noreturn function attribute where appropriate.
1150 * ospf_opaque.c: remove the private definition of ospf_lsa's
1151 ospf_lsa_refresh_delay.
1152 * ospf_lsa.h: export ospf_lsa_refresh_delay
1153 * ospf_packet.c: (ospf_make_md5_digest) make *auth_key const,
1154 correct thing to do - removes need for the casts later.
1155 * ospf_vty.c: Use vty.h's VTY_GET_INTEGER rather than ospf_vty's
1156 home-brewed versions, shuts up several warnings.
1157 * ospf_vty.h: remove VTY_GET_UINT32. VTY_GET_IPV4_ADDRESS and
1158 VTY_GET_IPV4_PREFIX moved to lib/vty.h.
1159 * ospf_zebra.c: (ospf_distribute_list_update_timer) hacky
1160 overloading of the THREAD_ARG pointer should at least use
1161 uintptr_t.
1162
paul9e67dc22005-04-15 12:10:17 +000011632005-04-15 Zhipeng Gong <zpgong@cdc.3upsystems.com>
1164
1165 * ospf_abr.c: (ospf_abr_announce_network_to_area) dont forget
1166 to approve LSAs for the case where metric has changed, lsa gets
1167 flushed otherwise. (backport candidate).
1168
ajs634f9ea2005-04-11 15:51:40 +000011692005-04-11 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1170
1171 * ospf_zebra.c (ospf_zebra_add): Call zclient_send_message instead
1172 of writen.
1173
ajsd2fc8892005-04-02 18:38:43 +000011742005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1175
ajse4319de2005-04-02 23:23:55 +00001176 * ospf_interface.h: (ospf_if_lookup_by_name) Remove declaration of a
1177 function that does not exist.
1178
11792005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1180
ajs21fefa92005-04-02 23:16:41 +00001181 * ospf_zebra.c: (zebra_interface_if_lookup) Must use
1182 if_lookup_by_name_len.
1183
11842005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1185
ajsa3491982005-04-02 22:50:38 +00001186 * ospf_interface.c: (ospf_vl_new) Use strnlen to fix call to if_create.
1187
11882005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1189
ajsd2fc8892005-04-02 18:38:43 +00001190 * ospf_vty.c: (show_ip_ospf_interface_sub) Show ifindex and interface
1191 flags to help with debugging.
1192 * ospf_zebra.c: (ospf_interface_delete) After deleting, set ifp->ifindex
1193 to IFINDEX_INTERNAL.
1194 (zebra_interface_if_lookup) Make function static. Tighten up code.
1195
ajsaca72fd2005-03-31 15:18:21 +000011962005-03-31 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1197
1198 * ospf_dump.c: (show_debugging_ospf) Show if ospf event debugging
1199 is turned on.
1200
ajsfd651fa2005-03-29 16:08:16 +000012012005-03-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1202
ajsa608bbf2005-03-29 17:03:49 +00001203 * ospf_zebra.c: (ospf_interface_state_up) If the MTU of an operative
1204 interface changes, print a debug message and call ospf_if_reset()
1205 to simulate down/up on the interface.
1206 * ospf_interface.h: Declare new function ospf_if_reset().
1207 * ospf_interface.c: (ospf_if_reset) New function to call ospf_if_down
1208 and ospf_if_up for all ospf interfaces attached to an interface.
1209
12102005-03-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1211
ajs5dcbdf82005-03-29 16:13:49 +00001212 * ospf_packet.c: (ospf_write_frags) Enhance error message to
1213 show MTU. Also make function static.
1214 (ospf_write) Enhance error message to show interface name and MTU.
1215 Also make function static.
1216
12172005-03-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1218
1219 * ospf_vty.c: (show_ip_ospf_interface_sub) Display interface MTU and
1220 bandwidth; this is useful for debugging problems. Also, the function
1221 should be static.
ajsfd651fa2005-03-29 16:08:16 +00001222
hasso1b639042005-03-27 13:32:25 +000012232005-03-27 Hasso Tepper <hasso at quagga.net>
1224
1225 * ospf_snmp.c: Don't crash in snmp query if ospf instance doesn't
1226 exist at all.
1227
hasso343f5cc2005-03-25 19:48:40 +000012282005-03-25 Hasso Tepper <hasso at quagga.net>
1229
1230 * ospfd.h: Include log.h, fixes compile with gcc-4.0.
1231
ajs9dbc7972005-03-13 19:27:22 +000012322005-03-13 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1233
1234 * ospf_lsa.c: (ospf_lsa_refresh_walker) If the system clock jumps
1235 backward, then current time may be less than
1236 ospf->lsa_refresher_started. This was causing invalid values
1237 for ospf->lsa_refresh_queue.index resulting in infinite loops.
1238 Problem fixed by casting the expression to unsigned before taking
1239 the modulus.
1240
ajs5c333492005-02-23 15:43:01 +000012412005-02-23 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1242
1243 * ospfd.h: Add new field struct stream *ibuf to struct ospf.
1244 * ospfd.c: (ospf_new) Check return code from ospf_sock_init.
1245 Allocate ibuf using stream_new(OSPF_MAX_PACKET_SIZE+1).
1246 (ospf_finish) Call stream_free(ospf->ibuf.
1247 * ospf_packet.c: (ospf_read) Call stream_reset(ospf->ibuf) and then
1248 pass it to ospf_recv_packet for use in receiving the packet
1249 (instead of allocating a new stream for each packet received).
1250 Eliminate all calls to stream_free(ibuf).
1251 (ospf_recv_packet) The struct stream *ibuf is now passed in as
1252 an argument. No need to use recvfrom to peek at the packet
1253 header (to see how big it is), just use ospf->ibuf which is
1254 always large enough (this eliminates a system call to recvfrom).
1255 Therefore, no need to allocate a stream just for this packet,
1256 and no need to free it when done.
1257
hasso462f20d2005-02-23 11:29:02 +000012582005-02-23 Vincenzo Eramo <eramo at infocom.ing.uniroma1.it>
1259
1260 * ospf_lsa.h: New flag to the LSA structure for the SPF calculation.
1261 * ospf_lsdb.h: Export ospf_lsdb_clean_stat() function.
1262 * ospf_spf.h: Add link to the LSA stat structure into vertex.
1263 * ospf_spf.c: New functions cmp() and update_stat() to manage
1264 candidates. Remove ospf_spf_has_vertex(), ospf_vertex_lookup(),
1265 ospf_install_candidate() and ospf_spf_register() functions not needed
1266 any more. Update ospf_vertex_new(), ospf_spf_next() and
1267 ospf_spf_calculate() functions to use pqueue instead of linked list.
1268
hassoe40dcce2005-02-21 14:58:42 +000012692005-02-21 Hasso Tepper <hasso at quagga.net>
1270
1271 * ospf_ase.c: Don't show messages related to the ase calculations if
1272 we are not debugging.
1273
hasso306541b2005-02-19 17:58:40 +000012742005-02-19 Hasso Tepper <hasso at quagga.net>
1275
1276 * ospf_api.h: char isn't always signed, but it has to be it here.
1277
paulfa81b712005-02-19 01:19:20 +000012782005-02-19 Paul Jakma <paul.jakma@sun.com>
1279
1280 * ospf_packet.c: (ospf_stream_copy) remove
1281 (ospf_packet_dup) use stream_copy instead of ospf_stream_copy
1282
ajs038163f2005-02-17 19:55:59 +000012832005-02-17 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1284
1285 * ospf_packet.c: (ospf_recv_packet) If there is somehow a runt
1286 packet in the queue, it must be discarded. Improve warning messages.
1287 Fix scope to static.
1288 (ospf_read) Fix bug: should reset the read thread in all cases
1289 to make sure we continue to get incoming messages.
1290
paul658b03a2005-02-15 10:10:55 +000012912005-02-15 Paul Jakma <paul.jakma@sun.com>
1292
1293 * ospf_packet.c: (ospf_recv_packet) Fix silly error wrt allocating
1294 ibuf. Thanks Andrew.
1295
paulbfdc44a2005-02-14 23:48:42 +000012962005-02-14 Paul Jakma <paul.jakma@sun.com>
1297
1298 * ospf_packet.c: (ospf_recv_packet) use stream_recvmsg.
1299
hasso082253f2005-02-11 08:31:54 +000013002005-02-11 Hasso Tepper <hasso at quagga.net>
1301
1302 * ospf_lsdb.c: Fix sum of checksums calculation.
1303
ajs083ee9d2005-02-09 15:35:50 +000013042005-02-09 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1305
1306 * ospf_packet.c: (ospf_write) If sendmsg fails, give more info in the
1307 error message.
1308
ajsba6454e2005-02-08 15:37:30 +000013092005-02-08 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1310
ajs8cfde372005-02-08 15:59:16 +00001311 * ospf_interface.h: Reduce structure padding by putting new u_char
1312 field multicast_memberships in a better spot (grouped with
1313 other u_char fields type and state).
1314
13152005-02-08 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1316
ajsba6454e2005-02-08 15:37:30 +00001317 * ospf_interface.h: Improve passive_interface comment. Add new
1318 multicast_memberships bitmask to struct ospf_interface to track
1319 active multicast subscriptions. Declare new function
1320 ospf_if_set_multicast.
1321 * ospf_interface.c: (ospf_if_set_multicast) New function to configure
1322 multicast memberships properly based on the current
1323 multicast_memberships status and the current values of the
1324 ospf_interface state, type, and passive_interface status.
1325 (ospf_if_up) Remove call to ospf_if_add_allspfrouters (this is
1326 now handled by ism_change_state's call to ospf_if_set_multicast).
1327 (ospf_if_down) Remove call to ospf_if_drop_allspfrouters (now
1328 handled by ism_change_state).
1329 * ospf_ism.c: (ospf_dr_election) Remove logic to join or leave
1330 the DRouters multicast group (now handled by ism_change_state's call
1331 to ospf_if_set_multicast).
1332 (ism_change_state) Add call to ospf_if_set_multicast to change
1333 multicast memberships as necessary to reflect the new interface state.
1334 * ospf_packet.c: (ospf_hello) When a Hello packet is received on a
1335 passive interface: 1. Increase the severity of the error message
1336 from LOG_INFO to LOG_WARNING; 2. Add more information to the error
1337 message (packet destination address and interface address);
1338 and 3. If the packet was sent to ospf-all-routers, then try
1339 to fix the multicast group memberships.
1340 (ospf_read) When a packet is received on an interface whose state
1341 is ISM_Down, enhance the warning message to show the packet
1342 destination address, and try to update/fix the multicast group
1343 memberships if the packet was sent to a multicast address.
1344 When a packet is received for ospf-designated-routers, but the
1345 current interface state is not DR or BDR, then increase the
1346 severity level of the error message from LOG_INFO to LOG_WARNING,
1347 and try to fix the multicast group memberships.
1348 * ospf_vty.c: (ospf_passive_interface) Call ospf_if_set_multicast for
1349 any ospf interface that may have changed from active to passive.
1350 (no_ospf_passive_interface) Call ospf_if_set_multicast for
1351 any ospf interface that may have changed from passive to active.
1352 (show_ip_ospf_interface_sub) Show multicast group memberships.
1353
paul3a9eb092005-02-08 11:29:41 +000013542005-02-08 Paul Jakma <paul@dishone.st>
1355
1356 * ospf_packet.c: (various) Remove unneeded stream_set_putp abuse.
1357
ajs847947f2005-02-02 18:38:48 +000013582005-02-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1359
1360 * ospf_packet.c: (ospf_read) Fix bug: must check for state ISM_Down,
1361 not for event ISM_InterfaceDown. And improve the message by
1362 adding the interface flags.
1363
ajs0b7d97d2005-01-30 17:24:02 +000013642005-01-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1365
1366 * ospf_network.c: (ospf_sock_init) Save errno before calling
1367 ospfd_privs.change.
1368
ajsc3eab872005-01-29 15:52:07 +000013692005-01-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1370
1371 * ospf_packet.c: (ospf_packet_add) If oi->obuf is NULL, print
1372 an error message and return.
1373 (ospf_read) If the interface state is ISM_InterfaceDown, issue
1374 a warning message and ignore the packet.
1375
gdt86f1fd92005-01-10 14:20:43 +000013762005-01-10 Greg Troxel <gdt@fnord.ir.bbn.com>
1377
1378 * ospf_packet.h: Remove commented out definition of
1379 OSPF_MAX_PACKET; neither it or the uncommented one are used any more.
1380
1381 * ospf_packet.c (ospf_make_ls_upd): Leave room for authentication
1382 when deciding if an update will fit.
1383 (ospf_packet_authspace): Factor out calculation of size required
1384 for authentication.
1385 (ospf_make_db_desc): Use ospf_max_packet, not OSPF_MAX_PACKET.
1386 Don't confuse readers that there is a macro.
1387
ajs3dc56b52004-12-30 15:11:19 +000013882004-12-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1389
1390 * ospf_network.c: Improve all setsockopt error messages to give detailed
1391 information on the arguments.
1392
ajsb87f7722004-12-29 20:41:26 +000013932004-12-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1394
ajs17eaa722004-12-29 21:04:48 +00001395 * ospf_packet.c: (ospf_db_desc) Reduce severity of "Negotiation done"
1396 messages from LOG_WARNING to LOG_INFO, since this seems to be
1397 normal.
1398
13992004-12-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1400
ajsb87f7722004-12-29 20:41:26 +00001401 * ospf_packet.c: (ospf_read) Always look up the interface if
1402 ospf_recv_packet returns NULL ifp, since some platforms such
1403 as Solaris 8 appear to support ifindex retrieval but don't.
1404
hasso1d806282004-12-22 09:43:20 +000014052004-12-22 Hasso Tepper <hasso at quagga.net>
1406
1407 * ospf_dump.c: Show debug configuration in vtysh.
hassoc6b87812004-12-22 13:09:59 +00001408 * ospf_vty.c: Fix "show ip ospf" output. Router can't be elected in
1409 any case if it's configured as "translate-never".
hassofe71a972004-12-22 16:16:02 +00001410 * ospf_lsdb.[ch]: New function to calculate sum of checksums.
1411 * ospf_vty.c: Bugfix to show really number of AS external LSAs, not
1412 number of all LSAs with AS scope, this includes opaque as LSAs as
1413 well, show this number separately. Show numbers and sums of
1414 checksums for each type of LSAs.
1415 * ospf_lsa.c: Calculate checksum before putting LSA into database.
hasso1d806282004-12-22 09:43:20 +00001416
ajsbc18d612004-12-15 15:07:19 +000014172004-12-15 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1418
1419 * ospf_interface.h: Declare new function ospf_default_iftype.
1420 * ospf_interface.c: (ospf_default_iftype) New function to centralize
1421 this logic in one place.
1422 * ospf_zebra.c: (ospf_interface_add) Use new function
1423 ospf_default_iftype.
1424 * ospf_vty.c: (no_ip_ospf_network,config_write_interface) Fix logic
1425 by using new function ospf_default_iftype.
1426
ajs3aa8d5f2004-12-11 18:00:06 +000014272004-12-11 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1428
1429 * ospf_packet.c: (ospf_db_desc) Should be static, not global.
1430 (ospf_hello,ospf_db_desc,ospf_ls_upd,ospf_ls_ack) Improve warning
1431 messages to include identifying information (e.g. router id).
1432 * ospf_nsm.c: (nsm_change_state) Improve info message to include
1433 router id and state names.
1434
gdt91f3e522004-12-09 14:51:03 +000014352004-12-09 Greg Troxel <gdt@fnord.ir.bbn.com>
1436
gdt3fb9de72004-12-09 16:30:04 +00001437 * ospf_apiserver.c (ospf_apiserver_term): Obtain struct
1438 ospf_apiserver * from listnode. Remove unused variables. Follows
1439 suggestion from Jay Fenlason.
gdt91f3e522004-12-09 14:51:03 +00001440
ajs9b0e25c2004-12-08 19:06:51 +000014412004-12-08 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1442
1443 * *.c: Change level of debug messages to LOG_DEBUG.
1444
ajs274a4a42004-12-07 15:39:31 +000014452004-12-07 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1446
1447 * ospf_main.c: (main) The 2nd argument to openzlog has been removed.
1448
ajs887c44a2004-12-03 16:36:46 +000014492004-12-03 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1450
ajs1210fa62004-12-03 16:43:24 +00001451 * ospf_packet.c: (ospf_db_desc) Reduce priority on a debug message
1452 from LOG_NOTICE to LOG_DEBUG.
1453
14542004-12-03 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1455
ajs887c44a2004-12-03 16:36:46 +00001456 * ospf_main.c: (sigint) Use zlog_notice for termination message.
1457 (main) Issue a startup announcement using zlog_notice.
1458
ajsbec595a2004-11-30 22:38:43 +000014592004-11-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1460
1461 * ospf_packet.c: (ospf_db_desc_proc) Fix spelling of packet in warning
1462 message and in comment.
1463 (ospf_db_desc) Warning message that a packet is being discarded
1464 should give the router id of the packet source. Fix spelling
1465 of packet in two warning messages.
1466 (ospf_ls_req) Warning message that a link state request is being
1467 discarded should give the router id of the neighbor that sent it.
1468
ajs5b85fac2004-11-26 19:36:42 +000014692004-11-26 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1470
1471 * ospf_main.c: Remove #include "debug.h" (was not being used, and
1472 lib/debug.h has now been deleted).
1473
hassoc0652302004-11-25 19:33:48 +000014742004-11-25 Hasso Tepper <hasso at quagga.net>
1475
1476 * ospf_main.c: Make group to run as configurable.
1477
gdt69e13252004-11-15 18:51:15 +000014782004-11-15 Greg Troxel <gdt@fnord.ir.bbn.com>
1479
1480 * ospf_packet.c (ospf_recv_packet): Assume CMSG_SPACE is present
1481 and works (lib/zebra.h provides if OS doesn't).
1482
paul788dab12004-11-15 11:48:37 +000014832004-11-15 Paul Jakma <paul@dishone.st>
1484
1485 * ospf_{apiserver,te}.c: ospf_lsa_free's should be ospf_lsa_unlock.
1486
paul05e85fa2004-11-12 10:52:19 +000014872004-11-12 Paul Jakma <paul@dishone.st>
1488
1489 * ospf_ia.c: (process_summary_lsa) Only an ABR has any reason to
1490 ignore stub area summary default. Even so it seems a strange
1491 check, add a comment to that effect.
1492
paulf3ae74c2004-11-04 20:35:31 +000014932004-11-04 Paul Jakma <paul@dishone.st>
1494
1495 * ospfd.c: (ospf_network_match_iface) revert to previous network
1496 statement match behaviour.
1497
paul62d8e962004-11-02 20:26:45 +000014982004-11-02 Paul Jakma <paul@dishone.st>
1499
1500 * ospf_packet.c: (ospf_write_frags) remove iov arg, msg already points
1501 to it. Add convenience pointer to msg->msg_iov[1], and use this,
1502 fixing the unfortunate borkenness introduced in moving of this code
1503 to a function.
1504 (ospf_write) remove iovp and fix up call to previous.
1505 (ospf_ls_upd_packet_new) cast size to long int - unfortunately
1506 glibc's size_t format modifier is not portable.
1507
paul37ccfa32004-10-31 11:24:51 +000015082004-10-31 Paul Jakma <paul@dishone.st>
1509
1510 * ospf_packet.c: (ospf_write_frags) Add debug output
1511 (ospf_write) set type early, so we can pass it to
1512 ospf_write_frags.
1513 (ospf_ls_upd_packet_new) print size in debug output when too large
1514 packet is encountered.
paul64511f32004-10-31 18:01:13 +00001515 * ospf_zebra.c: (ospf_distribute_list_update_timer) Ugly misuse of
1516 THREAD_ARG to store an integer, but it should at least use same
1517 same type to retrieve the value. Assert value is sane.
paul37ccfa32004-10-31 11:24:51 +00001518
paulac191232004-10-22 12:05:17 +000015192004-10-22 Paul Jakma <paul@dishone.st>
1520
1521 * ospf_network.c: (ospf_sock_init) call neutral setsock_ifindex()
1522 function.
1523 * ospf_packet.c: (ospf_read) manually look up ifindex
paul4ccb2c42004-10-22 22:52:33 +00001524 if system could not have returned one, eg openbsd, thanks to Rivo
1525 Nurges for highlighting problem and fix.
paul06f953f2004-10-22 17:00:38 +00001526 Change setsockopt_pktinfo to setsockopt_ifindex.
paulac191232004-10-22 12:05:17 +00001527
hasso3fb9cd62004-10-19 19:44:43 +000015282004-10-19 Andrew J. Schorr <aschorr@telemetry-investments.com>
1529
1530 * ospf_snmp.c: (ospf_snmp_if_update) Fix logic to handle PtP links
1531 with dedicated subnets properly.
1532 * ospf_lsa.c: (lsa_link_ptop_set) ditto.
1533 * ospfd.c: (ospf_network_match_iface) ditto.
1534 (ospf_network_run) ditto.
1535 * ospf_interface.c: (ospf_if_is_configured) ditto.
1536 (ospf_if_lookup_by_prefix) ditto.
1537 (ospf_if_lookup_recv_if) ditto.
1538 * ospf_vty.c: (show_ip_ospf_interface_sub) Display the peer or
1539 broadcast address if present.
1540
hassod68614d2004-10-13 09:32:48 +000015412004-10-13 Hasso Tepper <hasso at quagga.net>
1542
1543 * ospf_main.c: Unbreak compilation with ospfapi disabled.
hassoc75105a2004-10-13 10:33:26 +00001544 * ospf_snmp.c: Remove defaults used to initialize smux connection to
1545 snmpd. Connection is initialized only if smux peer is configured.
hassod68614d2004-10-13 09:32:48 +00001546
hassof4d58ce2004-10-12 06:13:54 +000015472004-10-12 Hasso Tepper <hasso at quagga.net>
1548
1549 * ospf_main.c, ospf_opaque.c: Unbreak ospfclient compilation - move
1550 static variable from ospf_main.c into ospf_opaque.c.
1551
hassoc3abdb72004-10-11 16:27:03 +000015522004-10-11 Hasso Tepper <hasso at quagga.net>
1553
1554 * ospf_main.c, ospf_opaque.c: Disable ospfapi init by default. New
1555 command line switch to enable it.
1556
paul6b333612004-10-11 10:11:25 +000015572004-10-11 Paul Jakma <paul@dishone.st>
1558
1559 * ospf_dump.c: (ospf_ip_header_dump) Assume header is in host order
1560 remove ntohs that should have dissappeared. Take struct ip
1561 as argument, caller has to know there's an IP header at start of
1562 stream anyway.
1563 * ospf_dump.h: update declaration of ospf_ip_header_dump.
1564 * ospf_packet.c: (ospf_write) correct call to
1565 sockopt_iphdrincl_swab_htosys which was munging the header.
1566 (ospf_recv_packet) ip_len is needed for old OpenBSD fixup.
1567 (ospf_read) sockopt_iphdrincl_swab_systoh ip header as soon as
1568 we have it.
paul6c835672004-10-11 11:00:30 +00001569 * (global) Const char update and signed/unsigned fixes.
1570 * (various headers) size defines should be unsigned.
1571 * ospf_interface.h: remove duplicated defines, include the
1572 authoritative header - though, these defines should probably
1573 be moved to a dedicated header, or ospfd.h.
1574 * ospf_lsa.h: (struct lsa) ls_seqnum should be unsigned.
1575 * ospf_packet.c: (ospf_write) cast result of shift to unsigned.
paul6b333612004-10-11 10:11:25 +00001576
hassoeb1ce602004-10-08 08:17:22 +000015772004-10-08 Hasso Tepper <hasso at quagga.net>
1578
1579 * *.[c|h]: Fix compiler warnings: make some strings const, signed ->
1580 unsigned, remove unused variables etc.
1581
gdt54ade992004-10-07 19:38:20 +000015822004-10-07 Greg Troxel <gdt@claude.ir.bbn.com>
1583
1584 * ospf_apiserver.c (ospf_apiserver_unregister_opaque_type): Don't
1585 use of variable names 'node' and 'nextnode' to avoid possible
1586 conflict with list macros. Move variable declaration inside for
1587 loop after a statement to top of function.
1588
paulaa20c6f2004-10-07 14:19:36 +000015892004-10-07 Paul Jakma <paul@dishone.st>
1590
1591 * ospf_snmp.c: Missed list typedef update
1592 * ospf_dump.c: Include sockopt.h for header swab functions.
1593
paul18b12c32004-10-05 14:38:29 +000015942004-10-05 Paul Jakma <paul@dishone.st>
1595
1596 * ospf_packet.c: replace ospf_swap_iph_to... with
1597 sockopt_iphdrincl_swab_...
1598
hasso18a6dce2004-10-03 18:18:34 +000015992004-10-03 James R. Leu <jleu at mindspring.com>
1600
1601 * ospf_zebra.c: Read router id related messages from zebra daemon.
1602 Schedule router-id update thread if it's changed.
1603 * ospfd.c: Remove own router-id selection function. Use router id from
1604 zebra daemon if it isn't manually overriden in configuration.
1605
paul68defd62004-09-27 07:27:13 +000016062004-09-27 Paul Jakma <paul@dishone.st>
1607
paul6a99f832004-09-27 12:56:30 +00001608 * ospf_dump.c: (ospf_ip_header_dump) Use HAVE_IP_HDRINCL_BSD_ORDER
1609 Apply to offset too. Print ip_cksum, lets not worry about
1610 possible 2.0.37 compile problems.
1611 * ospf_packet.c: (ospf_swap_iph_to{n,h}) Use
1612 HAVE_IP_HDRINCL_BSD_ORDER.
1613 (ospf_recv_packet) ditto.
1614 (ospf_write) Fixup iov argument to ospf_write_frags.
1615 (struct msghdr).msg_name is caddr_t on most platforms.
paul68defd62004-09-27 07:27:13 +00001616 (ospf_recv_packet) ditto. And msg_flags is not always there
1617 memset struct then set fields we care about rather than
1618 initialise all fields individually.
1619
hassoc9e52be2004-09-26 16:09:34 +000016202004-09-26 Hasso Tepper <hasso at quagga.net>
1621
1622 * ospf_abr.c, ospf_dump.c, ospf_lsa.c, ospf_packet.c, ospf_vty.c,
1623 ospf_zebra.c: Fix compiler warnings.
1624
paul87d6f872004-09-24 08:01:38 +000016252004-09-24 Paul Jakma <paul@dishone.st>
1626
1627 * ospf_apiserver.{c,h}: lists typedef removal cleanup.
1628 update some list loops to LIST_LOOP. some miscellaneous indent
1629 fixups.
1630 (ospf_apiserver_unregister_opaque_type) fix listnode_delete of
1631 referenced node in loop.
paul1603c062004-09-24 08:23:24 +00001632 (ospf_apiserver_term) loops calling ospf_apiserver_free, which
1633 deletes referenced nodes from apiserver_list, fixed.
paul87d6f872004-09-24 08:01:38 +00001634 * ospf_interface.h: lists typedef removal cleanup.
1635 * ospf_opaque.{c,h}: lists typedef removal cleanup. update some list
1636 loops to LIST_LOOP. miscellaneous style and indent fixups.
1637 * ospf_te.{c,h}: ditto
1638 * ospf_packet.c: lists typedef removal cleanup.
paula2570682004-09-24 08:09:57 +00001639 (ospf_write) ifdef fragmentation support. move actual
1640 fragmentation out to a new, similarly ifdefed, function.
1641 (ospf_write_frags) fragmented write support, moved from previous.
paul87d6f872004-09-24 08:01:38 +00001642
hasso52dc7ee2004-09-23 19:18:23 +000016432004-09-23 Hasso Tepper <hasso at quagga.net>
1644
1645 * *.[c|h]: list -> struct list *, listnode -> struct listnode *.
1646
paul68b73392004-09-12 14:21:37 +000016472004-09-12 Paul Jakma <paul@dishone.st>
1648
1649 * ospf_packet.c: Fix bugzilla #107
1650 (ospf_packet_max) get rid of the magic 88 constant
1651 (ospf_swab_iph_ton) new function. set ip header to network order,
1652 taking BSDisms into account.
1653 (ospf_swab_iph_toh) the inverse.
1654 (ospf_write) Add support for IP fragmentation, will only work on
1655 linux though, other kernels make it impossible. get rid of the
1656 magic 4 constant.
1657 (ospf_make_ls_upd) Bound check to end of stream, not to
1658 interface mtu.
1659 (ospf_ls_upd_packet_new) New function, allocate upd packet
1660 taking oversized LSAs into account.
1661 (ospf_ls_upd_queue_send) use ospf_ls_upd_packet_new to allocate,
1662 rather than statically allocating mtu sized packet buffer, which
1663 actually was wrong - it didnt take ip header into account, which
1664 should not be included in packet buffer.
1665 (ospf_ls_upd_send_queue_event) minor tweaks and remove
1666 TODO comment.
1667
gdt630e4802004-08-31 17:28:41 +000016682004-08-31 David Wiggins <dwiggins@bbn.com>
1669
1670 * ospf_spf.c (ospf_spf_calculate): Many more comments and debug
1671 print statements. New function ospf_vertex_dump used in debugging.
1672
16732004-08-31 David Wiggins <dwiggins@bbn.com>
1674
1675 * ospf_spf.h (struct vertex): Comments for flags and structure members.
1676
16772004-08-31 David Wiggins <dwiggins@bbn.com>
1678
1679 * ospf_route.c: When finding an alternate route, log cost as well.
1680
16812004-08-31 David Wiggins <dwiggins@bbn.com>
1682
1683 * ospf_interface.c (ospf_lookup_if_params): Initialize af in
1684 struct prefix allocated on stack.
1685
16862004-08-31 David Wiggins <dwiggins@bbn.com>
1687
1688 * ospf_packet.c (ospf_ls_ack_send_delayed): In p2mp mode, send
1689 acks to AllSPFRouters, rather than All-DR.
1690
hasso7b901432004-08-31 13:37:42 +000016912004-08-27 Hasso Tepper <hasso at quagga.net>
1692
1693 * ospf_vty.c: Don't print ospf network type under interface only
1694 if interface is in broadcast mode and interface type really is
1695 broadcast. Fixes Bugzilla #108.
1696
gdtd7d93992004-08-27 12:03:42 +000016972004-08-27 David Wiggins <dwiggins@bbn.com>
1698
1699 * ospf_spf.c (ospf_nexthop_calculation): Initialize address family
1700 in on-stack struct prefix_ipv4. Fixes point-to-multipoint SPF
1701 calculation.
1702
gdtd0deca62004-08-26 13:14:07 +000017032004-08-26 Greg Troxel <gdt@fnord.ir.bbn.com>
1704
1705 * ospf_packet.c (ospf_recv_packet): adjust size declaration of
gdtd7d93992004-08-27 12:03:42 +00001706 buffer used to get interface index so that it compiles on other
1707 than Linux and includes the required alignment space. Probably
1708 this was only working on sparc/sparc64 because most of
1709 sockaddr_dl was not being written.
gdtd0deca62004-08-26 13:14:07 +00001710
paul863082d2004-08-19 04:43:43 +000017112004-08-19 Paul Jakma <paul@dishone.st>
1712
1713 * ospf_packet.c: update to match sockopt renames.
1714
paul75ee0b82004-08-05 09:10:31 +000017152004-08-04 Paul Jakma <paul@dishone.st>
1716
1717 * ospf_spf.c: (ospf_spf_consider_nexthop) Add comment about issue.
1718 Compare only against list head - all nexthops must be same cost
1719 anyway, fixes a reference-listnode-after-delete bug noted by
1720 Kir Kostuchenko.
1721 (ospf_nexthop_calculation) Use ospf_spf_consider_nexthop for all
1722 candidates attached to root.
1723
paul36c64ef2004-07-27 11:19:11 +000017242004-07-27 Paul Jakma <paul@dishone.st>
1725
paul48fe13b2004-07-27 17:40:44 +00001726 * ospf_packet.c: (ospf_ls_upd_send_queue_event) fix thinko from
1727 last fix for ospfd wedging due to oversize LSAs: dont list loop on
1728 ospf_ls_upd_queue_send() - guaranteed segfault.
1729
17302004-07-27 Paul Jakma <paul@dishone.st>
1731
paul36c64ef2004-07-27 11:19:11 +00001732 * ospf_opaque.c: (ospf_opaque_lsa_flush_schedule) do not NULL out
1733 the LSA as then free_opaque_info_per_id() can never unlock (and
1734 free) the LSA. Reported by Gunnar Stigen.
1735
paul2dd8bb42004-07-23 15:13:48 +000017362004-07-23 Paul Jakma <paul@dishone.st>
1737
1738 * ospf_network.c: Replace PKTINFO/RECVIF with call to
1739 setsockopt_pktinfo
1740 * ospf_packet.c: Use getsockopt_pktinfo_ifindex and
1741 SOPT_SIZE_CMSG_PKTINFO_IPV4.
1742
paul59ea14c2004-07-14 20:50:36 +000017432004-07-14 Paul Jakma <paul@dishone.st>
1744
1745 * ospf_packet.c: (ospf_ls_upd_send_queue_event) Partial fix for
1746 problem reported by Peter Frost amongst others, where function
1747 will spin indefinitely if update list contains LSAs greater than
1748 MTU-headers or other condition leading to update list never being
1749 cleared. Problem of what to do with these LSAs remains.
1750 (ospf_make_ls_upd) add comment about large LSA problem,
1751 indentation cleanup.
1752
gdtb2c1b282004-07-01 12:35:36 +000017532004-07-01 Greg Troxel <gdt@fnord.ir.bbn.com>
1754
1755 * Makefile.am (lib_LTLIBRARIES): make libospf shared
1756
gdt87efd642004-06-30 17:36:11 +000017572004-06-30 Greg Troxel <gdt@poblano.ir.bbn.com>
1758
1759 * Makefile.am: Add shlib support.
1760
hassobeebba72004-06-20 21:00:27 +000017612004-06-10 Hasso Tepper <hasso@estpak.ee>
1762
1763 * *: Removed ifdefs HAVE_NSSA.
1764
paul553ff112004-06-06 09:41:00 +000017652004-06-06 Paul Jakma <paul@dishone.st>
1766
1767 * ospf_dump.c,ospf_lsa.c: Fix typos of merge of previous.
1768 ospf_flood.c: (ospf_process_self_originated_lsa) fix zlog format
1769
paul0c2be262004-05-31 14:16:54 +000017702004-05-31 Sagun Shakya <sagun.shakya@sun.com>
1771
1772 * ospf_dump.c: (ospf_lsa_header_dump) LOOKUP can return null if
1773 index is out of range.
1774 ospf_flood.c: endianness fix
1775 ospf_lsa.c: Missing ntohl's on (struct lsa *)->data->ls_seqnum
1776 in various places.
1777
hassodd669bb2004-05-10 07:43:59 +000017782004-05-10 Hasso Tepper <hasso@estpak.ee>
1779
1780 * ospf_zebra.c, ospfd.c: Move ospf_prefix_list_update() function
1781 to ospf_zebra.c from ospfd.c and add redistribution updates if
1782 route-map is used in redistribution.
1783 * ospf_main.c: Remove now useless call to ospf_init().
1784
paul0a589352004-05-08 11:48:26 +000017852004-05-08 Paul Jakma <paul@dishone.st>
1786
1787 * ospf_zebra.c: Sync with lib/zclient changes
1788
pauld3f0d622004-05-05 15:27:15 +000017892004-05-05 Paul Jakma <paul@dishone.st>
1790
paul5bd41892004-05-05 17:29:24 +00001791 * ospf_network.c: (ospf_sock_init) Check whether IP_HDRINCL is
1792 defined. Warn at compile and runtime. Use
1793 IPTOS_PREC_INTERNETCONTROL otherwise.
pauld3f0d622004-05-05 15:27:15 +00001794 * ospf_packet.c: (ospf_associate_packet_vl) cleanup, move
1795 some of the checks up to ospf_read, return either a
1796 virtual link oi, or NULL.
1797 (ospf_read) Cleanup, make it responsible for checks. Remove
1798 the nbr lookup - moved to ospf_neighbor. Adjust all nbr
1799 lookups to use new wrappers exported by ospf_neighbor.
1800 * ospf_neighbor.h: Add ospf_neigbour_get and ospf_nbr_lookup.
1801 * ospf_neighbor.c: (ospf_neigbour_get) Index ospf_interface
1802 neighbour table by router-id for virtual-link ospf_interfaces,
1803 not by peer_addr (which breaks for asymmetric vlinks)
1804 (ospf_nbr_lookup) add a wrapper for nbr lookups to deal with
1805 above.
paulcd59da62004-05-05 17:26:55 +00001806 * ospf_interface.c: (ospf_vl_set_params) Catch changes of interface
1807 address for either end of a virtual-link, and hence potential cost
1808 changes.
1809
hassoa0a39762004-04-23 08:51:10 +000018102004-04-22 Hasso Tepper <hasso@estpak.ee>
1811
1812 * ospf_zebra.c: Don't ignore reject/bh routes, it's the only way
1813 to "summarize" routes in ASBR at the moment.
1814
hasso8585d4e2004-04-20 17:25:12 +000018152004-04-20 Hasso Tepper <hasso@estpak.ee>
1816
1817 * ospfd.c: Unset NP flag if area is going to be normal or stub.
1818 Fixes UNH OSPF_NSSA.1.2a comment.
1819 * ospf_abr.c: Originate default into stub/nssa area even if
1820 summaries are disabled.
1821 * ospf_zebra.c: Don't attempt to redistribute 127.0.0.0/8.
1822
hassoc266ac72004-04-19 17:31:00 +000018232004-04-19 Hasso Tepper <hasso@estpak.ee>
1824
1825 * ospf_vty.c: Don't warn that export- and import-list can't be
1826 configured to backbone area if they are applied and are working
1827 fine.
1828
hasso128d31d2004-04-04 12:52:33 +000018292004-02-19 Sowmini Varadhan <sowmini.varadhan@sun.com>
1830
1831 * ospf_packet.c: Don't drop packets in Solaris x86.
1832 [quagga-dev 1005].
1833
hasso0d85b992004-03-18 19:18:33 +000018342004-03-18 Amir Guindehi <amir@datacore.ch>
1835
1836 * ospf_opaque.c: Attempt to correct the incorrect behavior of
1837 Quagga's ospfd in the special situation that a node's opaque
1838 capability has changed as "ON -> OFF -> ON". [quagga-dev 843].
1839
paul7f352b82004-02-19 19:37:47 +000018402004-02-19 Sowmini Varadhan <sowmini.varadhan@sun.com>
1841
1842 * ospf_abr.c: (ospf_abr_update_aggregate) UNH 3.12b,c, address range
1843 should be configured with the highest cost path within the range,
1844 not lowest.
1845
paul940b01a2004-02-17 20:07:30 +000018462004-02-17 Paul Jakma <paul@dishone.st>
1847
1848 * ospf_zebra.c: (ospf_interface_delete) Do not delete the interface
1849 params, nor the interface structure, if an interface delete
1850 message is received from zebra.
1851 * ospf_interface.c: (ospf_if_delete_hook) Delete the interface
1852 params and interface, ie that which was previously removed in
1853 (ospf_interface_delete) above.
1854
hasso2db3d052004-02-11 21:52:13 +000018552004-02-11 Hasso Tepper <hasso@estpak.ee>
1856 * ospf_interface.c, ospf_zebra.c: Don't attempt to read path->oi->ifp
1857 if oi doesn't exist any more.
1858
hassocb05eb22004-02-11 21:10:19 +000018592004-02-11 Vadim Suraev <vadim.suraev@terayon.com>
1860 * ospf_packet.c (ospf_ls_upd): Router should flush received network
1861 LSA if it was originated with older router-id ([zebra 14710] #6).
1862
18632003-12-08 Mattias Amnefelt <mattiasa@kth.se>
paul239aecc2003-12-08 10:34:54 +00001864
1865 * ospf_packet.c: (ospf_recv_packet) OpenBSD now leaves iph.ip_len
1866 network byte order.
1867
gdt8f40e892003-12-05 14:01:43 +000018682003-12-05 Greg Troxel <gdt@poblano.ir.bbn.com>
1869
1870 * ospfd.c (ospf_network_match_iface): Rewrite code for clarity
1871 while trying not to change semantics. Add ifdefed-out code to
1872 avoid matching ppp interfaces whose destination address does not
1873 also match the prefix under consideration, to help out people with
1874 problems due to as-yet-unfixed bugs with p2p interfaces coming and
1875 going.
1876
paul736d3442003-07-24 23:22:57 +000018772003-07-25 kamatchi soundaram <kamatchi@tdd.sj.nec.com>
1878
1879 * ospf_packet.c (ospf_ls_upd_send_queue_event): get next route
1880 node in body of the loop to avoid chance that route node
1881 is unlocked and deleted before the next iteration tries to
1882 get next route node.
1883
paul0a825c72003-05-24 13:48:16 +000018842003-05-24 Kenji Yabuuchi
1885
1886 * ospf_interface.c(ospf_if_lookup_recv_if): Use the most specific
1887 match for interface lookup.
1888
paul551a8972003-05-18 15:22:55 +000018892003-05-18 Hasso Tepper <hasso@estpak.ee>
paul445f1432003-05-16 19:00:31 +00001890
paul551a8972003-05-18 15:22:55 +00001891 * ospf_vty.c: Show NSSA LSA route info in "show ip ospf database"
1892 output
paul445f1432003-05-16 19:00:31 +00001893
pauld7480322003-05-16 17:31:51 +000018942003-05-16 Hasso Tepper <hasso@estpak.ee>
1895
1896 * ospf_lsa.c: Fix handling of NSSA
1897
paul551a8972003-05-18 15:22:55 +000018982003-04-23 Hasso Tepper <hasso@estpak.ee>
1899
1900 * ospf_vty.c: fix "router xxx" node commands in vtysh
1901
paul445f1432003-05-16 19:00:31 +000019022003-04-19 Hasso Tepper <hasso@estpak.ee>
1903
1904 * {ospf_abr,ospfd}.c: area id's DECIMAL -> ADDRESS
1905 * ospf_routemap.c: sync daemon's route-map commands to have same
1906 syntax.
1907
19082003-04-19 Sergey Vyshnevetskiy <serg@vostok.net>
1909
1910 * ospf_packet.c: Add missing param to zlog
1911 * ospf_flood.c: remove unused vars
1912
19132003-04-17 Denis Ovsienko <zebra@pilot.org.ua>
1914
1915 * ospf_interface.c: fix incorrect memset
1916
paul28a13842003-05-16 20:30:37 +000019172003-04-10 Amir Guindehi <amir@datacore.ch>
paul445f1432003-05-16 19:00:31 +00001918
1919 * ospf_lsa.[ch]: opaque LSA fix, use ospf_lookup.
1920
19212003-04-03 David Watson <dwatson@eecs.umich.edu>
1922
1923 * ospf_lsa.c: byte order fix
1924
paul07661cb2003-03-18 00:03:05 +000019252002-03-17 Amir Guindehi <amir@datacore.ch>
1926
1927 * ospf_apiserver.[ch]: Merge Ralph Keller's OSPFAPI support.
1928 * ospf_api.[ch]: Merge Ralph Keller's OSPFAPI support.
1929 * ospfclient: OSPFAPI demonstration client.
1930
19312003-01-23 Masahiko Endo <endo@suri.co.jp>
1932
1933 * ospf_ism.c: NSM event schedule bug fix.
1934
19352002-10-30 Greg Troxel <gdt@ir.bbn.com>
1936
1937 * ospf_packet.c (ospf_make_md5_digest): MD5 length fix.
1938
paul718e3742002-12-13 20:15:29 +000019392002-10-23 endo@suri.co.jp (Masahiko Endo)
1940
1941 * ospf_opaque.c: Update Opaque LSA patch.
1942
19432002-10-23 Ralph Keller <keller@tik.ee.ethz.ch>
1944
1945 * ospf_vty.c (show_ip_ospf_database): Fix CLI parse.
1946
19472002-10-23 Juris Kalnins <juris@mt.lv>
1948
1949 * ospf_interface.c (ospf_if_stream_unset): When write queue
1950 becomes empty stop write timer.
1951
19522002-10-10 Greg Troxel <gdt@ir.bbn.com>
1953
1954 * ospf_packet.c (ospf_check_md5_digest): Change >= to > to make it
1955 conform to RFC.
1956
19572002-07-07 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1958
1959 * zebra-0.93 released.
1960
19612002-06-19 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1962
1963 * ospf_spf.c (ospf_nexthop_calculation): Add NULL set to oi and
1964 check of l2. Reported by: Daniel Drown <dan-zebra@drown.org>
1965 (ospf_lsa_has_link): LSA Length calculation fix. Reported by:
1966 Paul Jakma <paulj@alphyra.ie>.
1967
1968 * ospfd.c (ospf_if_update): Fix nextnode reference bug. Reported
1969 by: juris@mt.lv.
1970
19712002-01-21 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1972
1973 * ospfd.c: Merge [zebra 11445] Masahiko ENDO's Opaque-LSA support.
1974
19752001-08-27 Kunihiro Ishiguro <kunihiro@zebra.org>
1976
1977 * ospf_interface.c (ospf_add_to_if): Use /32 address to register
1978 OSPF interface information.
1979 (ospf_delete_from_if): Likewise.
1980
1981 * ospf_zebra.c (ospf_interface_address_delete): Likewise.
1982
19832001-08-23 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1984
1985 * ospf_zebra.c (ospf_redistribute_unset): When redistribute type
1986 is OSPF, do not unset redistribute flag.
1987
19882001-08-19 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1989
1990 * zebra-0.92a released.
1991
19922001-08-15 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1993
1994 * zebra-0.92 released.
1995
19962001-08-12 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1997
1998 * ospfd.c (ospf_config_write): auto-cost reference-bandwidth
1999 configuration display.
2000
20012001-07-24 David Watson <dwatson@eecs.umich.edu>
2002
2003 * ospf_spf.c (ospf_spf_next): Modify ospf_vertex_add_parent to
2004 check for an existing link before connecting the parent and child.
2005 ospf_nexthop_calculation is also modified to check for duplicate
2006 entries when copying from the parent. Finally, ospf_spf_next
2007 removes duplicates when it merges two equal cost candidates.
2008
20092001-07-23 itojun@iijlab.net
2010
2011 * ospfd.c (show_ip_ospf_neighbor): Check ospf_top before use it
2012 [zebra 8549].
2013
20142001-07-23 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
2015
2016 * ospf_packet.c (ospf_write): Remove defined(__OpenBSD__) to make
2017 it work on OpenBSD.
2018
20192001-06-26 Kunihiro Ishiguro <kunihiro@zebra.org>
2020
2021 * ospf_zebra.c (config_write_ospf_default_metric): Display
2022 default-metric configuration.
2023
20242001-06-18 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
2025
2026 * ospf_ia.h (OSPF_EXAMINE_SUMMARIES_ALL): Remove old macros.
2027
20282001-05-28 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
2029
2030 * ospf_snmp.c (ospfIfEntry): Fix interface lookup bug to avoid
2031 crush.
2032 (ospfIfMetricEntry): Likewise.
2033
20342001-03-18 Kunihiro Ishiguro <kunihiro@zebra.org>
2035
2036 * ospf_packet.c (ospf_read): Fix typo. Reported by: "Jen B
2037 Lin'Kova" <jen@stack.net>.
2038
20392001-03-15 Gleb Natapov <gleb@nbase.co.il>
2040
2041 * ospf_interface.c (ip_ospf_network): Set interface parameter.
2042 (interface_config_write): Add check for OSPF_IFTYPE_LOOPBACK.
2043
2044 * ospf_zebra.c (ospf_interface_add): Set interface parameter.
2045
20462001-02-21 Kunihiro Ishiguro <kunihiro@zebra.org>
2047
2048 * ospf_packet.c (ospf_recv_packet): Solaris also need to add
2049 (iph.ip_hl << 2) to iph.ip_len.
2050
20512001-02-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2052
2053 * ospfd.h (OSPF_LS_REFRESH_TIME): Fix OSPF_LS_REFRESH_TIME value.
2054 Suggested by: David Watson <dwatson@eecs.umich.edu>.
2055
2056 * ospf_zebra.c (zebra_init): Remove zebra node.
2057
2058 * ospfd.c (ospf_area_range_set): Function name is changed from
2059 ospf_ara_range_cmd.
2060 (ospf_area_range_unset): New function which separated from DEFUN.
2061 New commands are added:
2062 "no area A.B.C.D range A.B.C.D/M advertise"
2063 "no area <0-4294967295> range A.B.C.D/M advertise"
2064 "no area A.B.C.D range A.B.C.D/M not-advertise"
2065 "no area <0-4294967295> range A.B.C.D/M not-advertise"
2066
2067 * ospf_lsa.c (ospf_lsa_more_recent): Fix previous change.
2068
20692001-02-08 Matthew Grant <grantma@anathoth.gen.nz>
2070
2071 * ospf_network.c (ospf_if_add_allspfrouters): Use
2072 setsockopt_multicast_ipv4.
2073 (ospf_if_drop_allspfrouters): Likewise.
2074
2075 * ospf_lsa.c (ospf_router_lsa_install): Add rt_recalc flag.
2076 (ospf_network_lsa_install): Likewise.
2077 (ospf_summary_lsa_install): Likewise.
2078 (ospf_summary_asbr_lsa_install): Likewise.
2079 (ospf_external_lsa_install): Likewise.
2080 (ospf_lsa_install): Call ospf_lsa_different to check this LSA is
2081 new one or not.
2082
20832001-02-08 Kunihiro Ishiguro <kunihiro@zebra.org>
2084
2085 * ospf_zebra.c (ospf_interface_delete): Do not free interface
2086 structure when ospfd receive interface delete message to support
2087 pseudo interface.
2088
20892001-02-01 Dick Glasspool <dick@ipinfusion.com>
2090
2091 * ospfd.c (area_range_notadvertise): Change area range "suppress"
2092 command to "not-advertise".
2093
2094 * ospfd.h (OSPF_LS_REFRESH_TIME): Change OSPF_LS_REFRESH_TIME from
2095 1800 to 60.
2096
2097 * ospf_abr.c (ospf_abr_update_aggregate): When update_aggregate is
2098 updating the area-range, the lowest cost is now saved.
2099
2100 * ospf_lsa.c (ospf_lsa_more_recent): Routing to compare sequence
2101 numbers rather than creating overflow during calculation.
2102
21032001-02-01 Kunihiro Ishiguro <kunihiro@zebra.org>
2104
2105 * zebra-0.91 is released.
2106
21072001-01-31 Kunihiro Ishiguro <kunihiro@zebra.org>
2108
2109 * ospf_packet.c (ospf_db_desc_proc): Do not continue process when
2110 NSM_SeqNumberMismatch is scheduled.
2111 (ospf_ls_req): Free ls_upd when return from this function.
2112 (ospf_ls_upd_timer): When update list is empty do not call
2113 ospf_ls_upd_send(). Suggested by: endo@suri.co.jp (Masahiko
2114 Endo).
2115
21162001-01-26 Kunihiro Ishiguro <kunihiro@zebra.org>
2117
2118 * ospf_lsa.c (ospf_maxage_flood): Flood LSA when it reaches
2119 MaxAge. RFC2328 Section 14.
2120 (ospf_maxage_lsa_remover): Call above function during removing
2121 MaxAge LSA.
2122
21232001-01-26 Dick Glasspool <dick@ipinfusion.com>
2124
2125 * ospf_flood.c (ospf_flood_through_as): Function is updated for
2126 NSSA Translations now done at ospf_abr.c with no change in P-bit.
2127
2128 * ospf_lsa.c (ospf_get_nssa_ip): Get 1st IP connection for Forward
2129 Addr.
2130 (ospf_install_flood_nssa): Leave Type-7 LSA at Lock Count = 2.
2131
2132 * ospf_ase.c (ospf_ase_calculate_route): Add debug codes.
2133
2134 * ospf_abr.c (ospf_abr_translate_nssa): Recalculate LSA checksum.
2135
2136 * ospf_packet.h (OSPF_SEND_PACKET_LOOP): Added for test packet.
2137
2138 * ospf_dump.c (ospf_lsa_type_msg): Add OSPF_GROUP_MEMBER_LSA and
2139 OSPF_AS_NSSA_LSA.
2140
2141 * ospfd.c (data_injection): Function to inject LSA. This is
2142 debugging command.
2143
21442001-01-11 Kunihiro Ishiguro <kunihiro@zebra.org>
2145
2146 * ospf_route.c (ospf_route_match_same): Remove function.
2147 (ospf_route_match_same_new): Renamed to ospf_route_match_same.
2148
2149 * ospf_zebra.c (ospf_interface_address_delete): Add check for
2150 oi->address. Suggested by Matthew Grant
2151 <grantma@anathoth.gen.nz>.
2152 (ospf_zebra_add): Remove function.
2153 (ospf_zebra_add_multipath): Rename to ospf_zebra_add.
2154
2155 * ospf_interface.c: Remove HAVE_IF_PSEUDO part.
2156
2157 * ospf_zebra.c: Likewise.
2158
21592001-01-10 Kunihiro Ishiguro <kunihiro@zebra.org>
2160
2161 * ospf_ase.c: Remove OLD_RIB part.
2162
2163 * ospf_route.c: Likewise.
2164
2165 * zebra-0.90 is released.
2166
2167 * ospf_packet.c (ospf_recv_packet): Use ip_len adjestment code to
2168 NetBSD.
2169
21702001-01-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2171
2172 * ospf_route.c (ospf_route_delete): Use
2173 ospf_zebra_delete_multipath.
2174
21752001-01-09 Matthew Grant <grantma@anathoth.gen.nz>
2176
2177 * ospf_interface.c (ospf_if_cleanup): Function name is renamed
2178 from ospf_if_free(). Rewrite whole procudure to support primary
2179 address deletion.
2180
2181 * ospf_zebra.c (ospf_interface_address_delete): Add primary
2182 address deletion process.
2183
21842001-01-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2185
2186 * ospf_packet.c (ospf_recv_packet): OpenBSD has same ip_len
2187 treatment like FreeBSD.
2188
21892001-01-09 endo@suri.co.jp (Masahiko Endo)
2190
2191 * ospf_packet.c (ospf_recv_packet): FreeBSD kernel network code
2192 strips IP header size from receiving IP Packet. So we adjust
2193 ip_len to whole IP packet size by adding IP header size.
2194
21952001-01-08 endo@suri.co.jp (Masahiko Endo)
2196
2197 * ospf_network.c (ospf_serv_sock): When socket() is failed return
2198 immediately.
2199 (ospf_serv_sock): Close socket when it is not used.
2200
2201 * ospf_packet.c (ospf_write): Set sin_len when HAVE_SIN_LEN is
2202 defined.
2203 (ospf_write): When bind is fined, close sock.
2204
22052001-01-07 Gleb Natapov <gleb@nbase.co.il>
2206
2207 * ospf_zebra.c (ospf_interface_state_up): Fixes coredump that
2208 appears when you try to configure bandwidth on the ppp interface
2209 that is not yet configured in ospfd.
2210
22112001-01-07 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2212
2213 * ospf_route.c (show_ip_ospf_route_external): "show ip ospf route"
2214 will print nexthops for AS-external routes.
2215
2216 * ospf_ase.c (ospf_ase_route_match_same): New function to compare
2217 ASE route under multipath environment.
2218 (ospf_ase_compare_tables): Likewise.
2219
22202001-01-01 Kunihiro Ishiguro <kunihiro@zebra.org>
2221
2222 * ospfd.h (OSPF_VTYSH_PATH): Change "/tmp/ospfd" to "/tmp/.ospfd".
2223
22242000-12-28 Kunihiro Ishiguro <kunihiro@zebra.org>
2225
2226 * ospf_route.c (ospf_route_install): Install multipath information
2227 to zebra daemon.
2228
2229 * ospf_zebra.c (ospf_zebra_add_multipath): Function for passing
2230 multipath information to zebra daemon.
2231
22322000-12-25 Dick Glasspool <dick@ipinfusion.com>
2233
2234 * ospf_packet.c (ospf_write): Call ospf_packet_delete when sendto
2235 fail.
2236 (DISCARD_LSA): Add argument N for logging point of DISCARD_LSA is
2237 called.
2238
2239 * ospf_lsa.c (ospf_external_lsa_refresh): NSSA install_flood will
2240 leave Type-7 LSA at Lock Count = 2.
2241
2242 * ospf_flood.c (ospf_flood_through): Flood_though_as updated for
2243 NSSA no P-bit off during Area flooding, but P-bit is turned off
2244 for mulitple NSSA AS flooding.
2245
2246 * ospf_ase.c (ospf_ase_calculate_timer): Added calculations for
2247 Type-7 LSDB.
2248
2249 * ospf_abr.c (ospf_abr_translate_nssa): Removed one unlock call.
2250 (ospf_abr_announce_nssa_defaults): Corrected Debug from EVENT to
2251 NSSA.
2252
22532000-12-25 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2254
2255 * ospf_zebra.c (ospf_zebra_read_ipv4): Checking the age of the
2256 found LSA and if the LSA is MAXAGE we should call refresh instead
2257 of originate.
2258
22592000-12-18 Dick Glasspool <dick@ipinfusion.com>
2260
2261 * ospf_abr.c: Removed redundant "...flood" in
2262 announce_network_to_area(). Repaired nssa Unlock by using
2263 discard.
2264
2265 * ospf_packet.c: Removed old NSSA translate during mk_ls_update.
2266
2267 * ospfd.c: Free up all data bases including NSSA.
2268
2269 * ospf_lsa.c: Now allow removal of XLATE LSA's Check in
2270 discard_callback. Added routine to get ip addr from within the
2271 ifp.
2272
2273 * ospf_flood.c: Now set Forward Address for outgoing Type-7.
2274
2275 * ospf_lsa.h: Added prototype for the below. struct in_addr
2276 ospf_get_ip_from_ifp (struct interface *ifp).
2277
22782000-12-14 Gleb Natapov <gleb@nbase.co.il>
2279
2280 * ospf_packet.c (ospf_recv_packet): New OSPF pakcet read method.
2281 Now maximum packet length may be 65535 bytes (maximum IP packet
2282 length).
2283
2284 * ospf_interface.c (ospf_if_stream_set): Don't make input buffer.
2285
2286 * ospfd.c (config_write_network_area): Remove unnecessary area
2287 lookup code.
2288
22892000-12-13 Kunihiro Ishiguro <kunihiro@zebra.org>
2290
2291 * ospf_packet.c (ospf_read): Accept packet bigger than MTU value.
2292
22932000-12-13 Gleb Natapov <gleb@nbase.co.il>
2294
2295 * ospfd.c (config_write_network_area): Fix bug in
2296 config_write_network_area function.
2297
22982000-12-12 Gleb Natapov <gleb@nbase.co.il>
2299
2300 * ospf_abr.c (ospf_abr_announce_network_to_area): Make Summary
2301 LSA's origination and refreshment as same as other type of LSA.
2302
2303 * ospf_lsa.c (ospf_summary_lsa_refresh): Return struct ospf_lsa *.
2304
2305 * ospf_lsa.c (ospf_summary_asbr_lsa_refresh): Likewise.
2306
23072000-12-08 Dick Glasspool <dick@ipinfusion.com>
2308
2309 The bulk of NSSA changes are contained herein; This version will
2310 require manual setting of "always" for NSSA Translator, and will
2311 not perform aggregation yet.
2312
2313 * ospf_dump.c: "debug ospf nssa" is added.
2314
2315 * ospf_dump.h: Likewise.
2316
2317 * ospf_packet.c (ospf_hello): Display router ID on Bad NSSA Hello.
2318
2319 * ospfd.c: Discard_LSA to stay away from LOCAL_XLT Process NSSA
2320 'never, candidate, always'. Change "suppress" to "not-advertise".
2321
2322 * ospfd.h: Add TranslatorRole to struct ospf_area. Add anyNSSA to
2323 struct ospf.
2324
2325 * ospf_ase.c (ospf_ase_calculate_route): External to stay away
2326 from LOCAL_XLT
2327
2328 * ospf_nsm.c (ospf_db_summary_add): External to stay away from
2329 LOCAL_XLT
2330
2331 * ospf_abr.c: Major logic added for abr_nssa_task(). If ABR, and
2332 NSSA translator, then do it. Approve the global list, and flush
2333 any unapproved.
2334
2335 * ospf_lsa.h: New LSA flag OSPF_LSA_LOCAL_XLT to indicate that the
2336 Type-5 resulted from a Local Type-7 translation; not used for
2337 flooding, but used for flushing.
2338
2339 * ospf_flood.c: New NSSA flooding.
2340
23412000-12-08 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2342
2343 * ospfd.c (ospf_find_vl_data): New function for looking up virtual
2344 link data.
2345 (ospf_vl_set_security): Virtual link configuration with
2346 authentication.
2347 (ospf_vl_set_timers): Set timers for virtual link.
2348
2349 * New commands are added.
2350 "area A.B.C.D virtual-link A.B.C.D"
2351 "area A.B.C.D virtual-link A.B.C.D hello-interval <1-65535> retransmit-interval <3-65535> transmit-delay <1-65535> dead-interval <1-65535>"
2352 "area A.B.C.D virtual-link A.B.C.D hello-interval <1-65535> retransmit-interval <3-65535> transmit-delay <1-65535> dead-interval <1-65535> authentication-key AUTH_KEY"
2353 "area A.B.C.D virtual-link A.B.C.D authentication-key AUTH_KEY"
2354 "area A.B.C.D virtual-link A.B.C.D hello-interval <1-65535> retransmit-interval <3-65535> transmit-delay <1-65535> dead-interval <1-65535> message-digest-key <1-255> md5 KEY"
2355 "area A.B.C.D virtual-link A.B.C.D message-digest-key <1-255> md5 KEY"
2356
2357 * ospf_packet.c (ospf_check_md5_digest): Add neighbor's
2358 cryptographic sequence number treatment.
2359 (ospf_check_auth): OSPF input buffer is added to argument.
2360 (ospf_read): Save neighbor's cryptographic sequence number.
2361
2362 * ospf_nsm.c (nsm_change_status): Clear cryptographic sequence
2363 number when neighbor status is changed to NSM down.
2364
2365 * ospf_neighbor.c (ospf_nbr_new): Set zero to crypt_seqnum.
2366
2367 * ospf_neighbor.h (struct ospf_neighbor): Add cryptographic
2368 sequence number to neighbor structure.
2369
23702000-11-29 Kunihiro Ishiguro <kunihiro@zebra.org>
2371
2372 * ospf_snmp.c (ospfIfLookup): OSPF MIB updates.
2373 (ospfExtLsdbEntry): Add OspfExtLsdbTable treatment.
2374
23752000-11-28 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2376
2377 * ospfd.c (ospf_interface_down): Clear a ls_upd_queue queue of the
2378 interface.
2379 (ospf_ls_upd_queue_empty): New function to empty ls update queue
2380 of the OSPF interface.
2381 (no_router_ospf): 'no router ospf' unregister redistribution
2382 requests from zebra.
2383
23842000-11-28 Kunihiro Ishiguro <kunihiro@zebra.org>
2385
2386 * ospf_ism.c (ism_change_status): Increment status change number.
2387
2388 * ospf_interface.h (struct ospf_interface): Add new member for
2389 status change statistics.
2390
2391 * Makefile.am: Update dependencies.
2392
2393 * ospf_zebra.c (ospf_interface_add): OSPF SNMP interface update.
2394 (ospf_interface_delete): OSPF SNMP interface delete.
2395
2396 * ospf_snmp.h: New file is added.
2397
23982000-11-23 Dick Glasspool <dick@ipinfusion.com>
2399
2400 * ospfd.h: Add new ospf_area structure member for
2401 NSSATranslatorRole and NSSATranslator state.
2402
2403 * ospfd.c: Provided for eventual commands to specify NSSA
2404 elections for "translator- ALWAYS/NEVER/CANDIDATE". Provided for
2405 decimal integer version of area-suppress.
2406
2407 * ospf_flood.c: Flood Type-7's only into NSSA (not AS).
2408
2409 * ospf_lsa.c: Undo some previous changes for NSSA. If NSSA
2410 translator, advertise Nt bit.
2411
2412 * ospf_route.c: 1st version of "sh ip os border-routers".
2413
24142000-11-23 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2415
2416 * ospfd.c (area_vlink): Virtual link can not configured in stub
2417 area.
2418
24192000-11-23 Gleb Natapov <gleb@nbase.co.il>
2420
2421 * ospf_packet.c (ospf_db_desc): In states Loading and Full the
2422 slave must resend its last Database Description packet in response
2423 to duplicate Database Description packets received from the
2424 master. For this reason the slave must wait RouterDeadInterval
2425 seconds before freeing the last Database Description packet.
2426 Reception of a Database Description packet from the master after
2427 this interval will generate a SeqNumberMismatch neighbor
2428 event. RFC2328 Section 10.8
2429 (ospf_make_db_desc): DD Master flag treatment.
2430
2431 * ospf_nsm.c (nsm_twoway_received): Move DD related procedure to
2432 nsm_change_status().
2433 (nsm_bad_ls_req): Likewise.
2434 (nsm_adj_ok): Likewise.
2435 (nsm_seq_number_mismatch): Likewise.
2436 (nsm_oneway_received): Likewise.
2437
2438 * ospf_neighbor.h (struct ospf_neighbor): New structure member
2439 last_send_ts for timestemp when last Database Description packet
2440 was sent.
2441
2442 * ospf_nsm.c (ospf_db_desc_timer): Make it sure nbr->last_send is
2443 there. Call ospf_db_desc_resend() in any case.
2444
24452000-11-16 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2446
2447 * ospf_lsa.c (lsa_link_broadcast_set): When there is no DR on
2448 network (suppose you have only one router with interface priority
2449 0). It's router LSA does not contain the link information about
2450 this network.
2451
2452 * ospf_nsm.c (nsm_timer_set): When you change a priority of
2453 interface from/to 0 ISM_NeighborChange event should be scheduled
2454 in order to elect new DR/BDR on the network.
2455
2456 * ospf_interface.c (ip_ospf_priority): Likewise.
2457
2458 * ospf_flood.c (ospf_ls_retransmit_add): When we add some LSA into
2459 retransmit list we need to check whether the present old LSA in
2460 retransmit list is not more recent than the new
2461 one.
2462
24632000-11-09 Dick Glasspool <dick@ipinfusion.com>
2464
2465 * ospf_packet.c: Allows for NSSA Type-7 LSA's throughout the NSSA
2466 area. Any that exit the NSSA area are translated to type-5 LSA's.
2467 The instantiated image is restored after translation.
2468 (ospf_ls_upd_send_list): Renamed to ospf_ls_upd_queu_send().
2469 (ospf_ls_upd_send): Old function which enclosed by #ifdef 0 is
2470 removed.
2471 (ospf_ls_ack_send): Likewise.
2472
2473 * ospf_flood.c: NSSA-LSA's without P-bit will be restricted to
2474 local area. Otherwise they are allowed out the area to be
2475 translated by ospf_packet.c.
2476
2477 * ospf_lsa.c: Undo some previous changes for NSSA.
2478
2479 * ospf_lsdb.h: New access for type 7.
2480
24812000-11-07 Kunihiro Ishiguro <kunihiro@zebra.org>
2482
2483 * ospf_route.c (ospf_path_exist): New function to check nexthop
2484 and interface are in current OSPF path or not.
2485 (ospf_route_copy_nexthops_from_vertex): Add nexthop to OSPF path
2486 when it is not there. Reported by Michael Rozhavsky
2487 <mrozhavsky@opticalaccess.com>
2488
24892000-11-06 Kunihiro Ishiguro <kunihiro@zebra.org>
2490
2491 * ospf_dump.c (config_write_debug): Add seventh string "detail" is
2492 added for flag is OSPF_DEBUG_SEND | OSPF_DEBUG_RECV |
2493 OSPF_DEBUG_DETAIL.
2494
24952000-11-06 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2496
2497 * ospf_lsa.c (router_lsa_flags): ASBR can't exit in stub area.
2498
24992000-11-06 Kunihiro Ishiguro <kunihiro@zebra.org>
2500
2501 * ospf_lsa.c (ospf_router_lsa_originate): Reduce unconditional
2502 logging.
2503
25042000-11-06 Dick Glasspool <dick@ipinfusion.com>
2505
2506 * ospfd.h: Add ait_ntoa function prototype.
2507
2508 * ospfd.c (ait_ntoa): New function for displaying area ID and
2509 Stub/NSSA status.
2510 (show_ip_ospf_interface_sub): Use ait_ntoa.
2511 (show_ip_ospf_nbr_static_detail_sub): Likewise.
2512 (show_ip_ospf_neighbor_detail_sub): Likewise.
2513
2514 * ospf_route.c (ospf_intra_route_add): Set external routing type
2515 to ospf route.
2516 (ospf_intra_add_router): Likewise.
2517 (ospf_intra_add_transit): Likewise.
2518 (ospf_intra_add_stub): Likewise.
2519 (ospf_add_discard_route): Likewise.
2520 (show_ip_ospf_route_network): Use ait_ntoa.
2521 (show_ip_ospf_route_network): Likewise.
2522 (show_ip_ospf_route_router): Likewise.
2523
2524 * ospf_lsa.c (show_lsa_detail): Use ait_ntoa.
2525 (show_lsa_detail_adv_router): Likewise.
2526 (show_ip_ospf_database_summary): Likewise.
2527
2528 * ospf_route.h (struct route_standard): Add new member
2529 external_routing.
2530
2531 * ospf_ia.c (process_summary_lsa): Set external routing tyep to ospf
2532 route.
2533 (ospf_update_network_route): Likewise.
2534 (ospf_update_router_route): Likewise.
2535
25362000-11-04 Kunihiro Ishiguro <kunihiro@zebra.org>
2537
2538 * ospf_flood.c (ospf_process_self_originated_lsa): Enclose
2539 OSPF_AS_NSSA_LSA treatment with #ifdef HAVE_NSSA.
2540
25412000-11-03 Kunihiro Ishiguro <kunihiro@zebra.org>
2542
2543 * Unconditional logging is enclosed with if (IS_DEBUG_OSPF_EVENT).
2544 Please specify "debug ospf event" for enable logging.
2545
2546 * ospf_ism.c: Do not extern debug flag varible. It is done by
2547 ospf_debug.h
2548 * ospf_asbr.c: Likewise.
2549 * ospf_lsa.c: Likewise.
2550 * ospf_nsm.c: Likewise.
2551 * ospf_zebra.c: Likewise.
2552
2553 * ospf_dump.c (debug_ospf_event): New command "debug ospf event"
2554 is added.
2555
2556 * ospfd.c (router_ospf): Change logging from vty_out() to
2557 zlog_info().
2558 (ospf_area_stub_cmd): Likewise.
2559
2560 * ospf_dump.h: Extern term_debug flags.
2561 (OSPF_DEBUG_EVENT): Add new flag.
2562 (IS_DEBUG_OSPF_EVENT): Add new macro.
2563
25642000-11-03 Dick Glasspool <dick@ipinfusion.com>
2565
2566 * ospf_flood.c (ospf_process_self_originated_lsa):
2567 OSPF_AS_NSSA_LSA is treated as same as OSPF_AS_EXTERNAL_LSA.
2568 (ospf_flood): Type-5's have no change. Type-7's can be received,
2569 and will Flood the AS as Type-5's They will also flood the local
2570 NSSA Area as Type-7's. The LSDB will be updated as Type-5's, and
2571 during re-fresh will be converted back to Type-7's (if within an
2572 NSSA).
2573 (ospf_flood_through): Incoming Type-7's were allowed here if our
2574 neighbor was an NSSA. So Flood our area with the Type-7 and also
2575 if we are an ABR, flood thru AS as Type-5.
2576
2577 * ospf_lsa.c (ospf_external_lsa_refresh): Flood NSSA both NSSA
2578 area and other area.
2579
2580 * ospf_packet.c (ospf_db_desc_proc): When AS External LSA is
2581 exists in DD packet, make it sure that this area is not stub.
2582 (ospf_ls_upd_list_lsa): When LSA type is NSSA then set lsa's area
2583 to NULL.
2584 (ospf_ls_upd): If the LSA is AS External LSA and the area is stub
2585 then discard the lsa. If the LSA is NSSA LSA and the area is not
2586 NSSA then discard the lsa.
2587
25882000-11-03 Kunihiro Ishiguro <kunihiro@zebra.org>
2589
2590 * ospfd.c (ospf_interface_run): Fix bug of Hello packet's option
2591 is not properly set when interface comes up.
2592
25932000-11-02 Kunihiro Ishiguro <kunihiro@zebra.org>
2594
2595 * ospfd.h (OSPF_OPTION_O): Add new hello header option.
2596
25972000-11-01 Dick Glasspool <dick@ipinfusion.com>
2598
2599 * ospf_lsa.h: Define OSPF_MAX_LSA to 8 when HAVE_NSSA is enabled.
2600 (OSPF_GROUP_MEMBER_LSA): Define OSPF_GROUP_MEMBER_LSA.
2601
2602 * ospf_lsa.c (show_database_desc): Add "Group Membership LSA"
2603 string.
2604
26052000-10-31 Dick Glasspool <dick@ipinfusion.com>
2606
2607 * ospf_lsa.h (OSPF_AS_NSSA_LSA): Define OSPF_AS_NSSA_LSA.
2608
2609 * ospf_lsa.c (show_ip_ospf_database): NSSA database display
2610 function is added. ALIASES which have "show ip ospf database
2611 nssa-external" is added.
2612 (show_ip_ospf_border_routers): New command "show ip ospf
2613 border-routers" is added.
2614
26152000-10-30 Dick Glasspool <dick@ipinfusion.com>
2616
2617 * ospfd.c (router_ospf): NSSA Enabled message is added for
2618 testing.
2619 (ospf_area_type_set): Are type set for NSSA area.
2620 (ospf_area_stub_cmd): Special translation of no_summary into NSSA
2621 and summary information. If NSSA is enabled pass the information
2622 to ospf_area_type_set().
2623 (area_nssa): New commands are added:
2624 "area A.B.C.D nssa"
2625 "area <0-4294967295> nssa"
2626 "area A.B.C.D nssa no-summary"
2627 "area <0-4294967295> nssa no-summary"
2628 (ospf_no_area_stub_cmd): Special translation of no_summary into
2629 NSSA and summary information. If external_routing is
2630 OSPF_AREA_NSSA unset area with ospf_area_type_set (area,
2631 OSPF_AREA_DEFAULT).
2632 (show_ip_ospf_area): Display NSSA status.
2633 (config_write_ospf_area): Show NSSA configuration.
2634
2635 * ospf_packet.c (ospf_hello): For NSSA support, ensure that NP is
2636 on and E is off.
2637
26382000-10-26 Gleb Natapov <gleb@nbase.co.il>
2639
2640 * ospf_lsa.c (ospf_network_lsa_body_set): The network-LSA lists
2641 those routers that are fully adjacent to the Designated Router;
2642 each fully adjacent router is identified by its OSPF Router ID.
2643 The Designated Router includes itself in this list. RFC2328,
2644 Section 12.4.2.
2645
26462000-10-23 Jochen Friedrich <jochen@scram.de>
2647
2648 * ospf_snmp.c: ospf_oid and ospfd_oid are used in smux_open after
2649 it is registered. So those variables must be static.
2650
26512000-10-18 K N Sridhar <sridhar@euler.ece.iisc.ernet.in>
2652
2653 * ospfd.c: Add area_default_cost_decimal_cmd and
2654 no_area_default_cost_decimal_cmd alias.
2655
26562000-10-05 Gleb Natapov <gleb@nbase.co.il>
2657
2658 * ospfd.c (ospf_network_new): Fix setting area format.
2659 (no_router_ospf): Check area existance when calling
2660 ospf_interface_down().
2661
2662 * ospf_flood.c (ospf_external_info_check): Fix bug of refreshing
2663 default route.
2664
26652000-10-02 Kunihiro Ishiguro <kunihiro@zebra.org>
2666
2667 * zebra-0.89 is released.
2668
26692000-09-29 Kunihiro Ishiguro <kunihiro@zebra.org>
2670
2671 * ospf_snmp.c (ospfHostEntry): OSPF Host MIB is implemented.
2672
2673 * ospfd.c (ospf_nbr_static_cmp): OSPF neighbor is sorted by it's
2674 address.
2675
26762000-09-28 Michael Rozhavsky <mike@nbase.co.il>
2677
2678 * ospf_interface.c (ospf_if_free): Fix deleting self neighbor twice.
2679
26802000-09-27 Kunihiro Ishiguro <kunihiro@zebra.org>
2681
2682 * ospf_packet.c (ospf_read): Solaris on x86 has ip_len with host
2683 byte order.
2684
26852000-09-25 Toshiaki Takada <takada@zebra.org>
2686
2687 * ospfd.c (ospf_compatible_rfc1583), (no_ospf_compatible_rfc1583):
2688 Add CISCO compatible command.
2689
26902000-09-25 Kunihiro Ishiguro <kunihiro@zebra.org>
2691
2692 * ospf_abr.c (ospf_area_range_lookup): New function is added for
2693 area range lookup in OSPF-MIB.
2694 (ospf_area_range_lookup_next): Likewise.
2695
26962000-09-22 Kunihiro Ishiguro <kunihiro@zebra.org>
2697
2698 * ospfd.c (no_router_ospf): Delete virtual link before deleting
2699 area structure.
2700
2701 * ospf_lsa.c (ospf_external_lsa_refresh_type): Check
2702 EXTERNAL_INFO(type).
2703
2704 * ospfd.c (no_router_ospf): Call ospf_vl_delete() instead of
2705 ospf_vl_data_free().
2706
2707 * ospf_interface.c (ospf_vl_shutdown): Execute ISM_InterfaceDown
2708 when ospf_vl_shutdown is called.
2709 (ospf_vl_delete): Call ospf_vl_shutdown() to delete virtual link
2710 interface's thread.
2711
27122000-09-21 Gleb Natapov <gleb@nbase.co.il>
2713
2714 * ospf_lsa.c: New implementation of OSPF refresh.
2715
27162000-09-20 Kunihiro Ishiguro <kunihiro@zebra.org>
2717
2718 * ospf_snmp.c (ospfLsdbLookup): Add LSDB MIB implementation.
2719
27202000-09-18 Kunihiro Ishiguro <kunihiro@zebra.org>
2721
2722 * ospf_snmp.c (ospfStubAreaEntry): Add OSPF stub area MIB.
2723
27242000-09-18 Gleb Natapov <gleb@nbase.co.il>
2725
2726 * ospf_route.h (route_standard): Change member from `struct area'
2727 to area_id.
2728
2729 * ospf_abr.c (ospf_abr_announce_network), (ospf_abr_should_announce),
2730 (ospf_abr_process_network_rt), (ospf_abr_announce_rtr),
2731 (ospf_abr_process_router_rt):
2732 * ospf_ase.c (ospf_find_asbr_route),
2733 (ospf_find_asbr_router_through_area),
2734 * ospf_ia.c (ospf_find_abr_route), (ospf_ia_router_route),
2735 (process_summary_lsa), (ospf_update_network_route),
2736 (ospf_update_router_route):
2737 * ospf_route.c (ospf_intra_route_add), (ospf_intra_add_router),
2738 (ospf_intra_add_transit), (ospf_intra_add_stub),
2739 (ospf_route_table_dump), (show_ip_ospf_route_network),
2740 (show_ip_ospf_route_router), (ospf_asbr_route_cmp),
2741 (ospf_prune_unreachable_routers):
2742 * ospf_spf.c (ospf_rtrs_print):
2743 * ospfd.c (ospf_rtrs_free): Fix the struct change above.
2744
27452000-09-14 Kunihiro Ishiguro <kunihiro@zebra.org>
2746
2747 * ospf_network.c (ospf_serv_sock_init): Enclose SO_BINDTODEVICE
2748 with ifdef.
2749
27502000-09-13 Gleb Natapov <gleb@nbase.co.il>
2751
2752 * ospf_ism.c (ospf_elect_dr), (ospf_elect_bdr): Fix DR election.
2753
2754 * ospf_network.c (ospf_serv_sock_init): Add socket option
2755 SO_BINDTODEVICE on read socket.
2756
2757 * ospf_packet.c (ospf_hello): Ignore Hello packet if E-bit does
2758 not match.
2759
2760 * ospfd.c (ospf_area_check_free), (ospf_area_get),
2761 (ospf_area_add_if): New function added.
2762
27632000-09-13 Kunihiro Ishiguro <kunihiro@zebra.org>
2764
2765 * ospf_route.c (ospf_intra_add_router): Update ABR and ASBR router
2766 count.
2767
2768 * ospf_spf.c (ospf_spf_init): Rest ABR and ASBR router count
2769 starting SPF calculation.
2770
2771 * ospfd.h (struct ospf_area): Add ABR and ASBR router count.
2772
27732000-09-12 Kunihiro Ishiguro <kunihiro@zebra.org>
2774
2775 * ospfd.c (ospf_area_id_cmp): New area structure is sorted by area
2776 ID.
2777
2778 * ospf_lsa.c (ospf_router_lsa_originate): For OSPF MIB update
2779 lsa_originate_count.
2780 (ospf_network_lsa_originate): Likewise.
2781 (ospf_summary_lsa_originate): Likewise.
2782 (ospf_summary_asbr_lsa_originate): Likewise.
2783 (ospf_external_lsa_originate): Likewise.
2784
27852000-09-11 Kunihiro Ishiguro <kunihiro@zebra.org>
2786
2787 * ospf_snmp.c (ospf_variables): ospfRouterID's type RouterID
2788 syntax is IpAddress.
2789 (ospf_admin_stat): New function for OSPF administrative status
2790 check.
2791
27922000-09-10 Jochen Friedrich <jochen@scram.de>
2793
2794 * ospf_snmp.c: Implement OSPF MIB skeleton.
2795
27962000-09-08 Kunihiro Ishiguro <kunihiro@zebra.org>
2797
2798 * ospf_snmp.c: New file is added.
2799
28002000-09-07 David Lipovkov <davidl@nbase.co.il>
2801
2802 * ospf_zebra.c (ospf_interface_delete): Add pseudo interface
2803 treatment.
2804
2805 * ospf_interface.c (interface_config_write): Likewise.
2806
28072000-08-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2808
2809 * zebra-0.88 is released.
2810
28112000-08-17 Michael Rozhavsky <mike@nbase.co.il>
2812
2813 * ospfd.c (ospf_area_free): Remove virtual link configuration only
2814 when Area is removed.
2815
28162000-08-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2817
2818 * ospfd.c (network_area): Revert check for EXTERNAL_INFO
2819 (ZEBRA_ROUTE_CONNECT).
2820 (no_network_area): Likewise.
2821
28222000-08-16 Kunihiro Ishiguro <kunihiro@zebra.org>
2823
2824 * ospfd.h (struct ospf): Add distance_table and
2825 distance_{all,intra,inter,external}.
2826
2827 * ospf_zebra.c: Add OSPF distance related functions.
2828
28292000-08-15 Gleb Natapov <gleb@nbase.co.il>
2830
2831 * ospf_asbr.c (ospf_external_info_find_lsa): New function added.
2832
2833 * ospf_lsa.c (ospf_default_external_info),
2834 (ospf_default_originate_timer), (ospf_external_lsa_refresh_default):
2835 New function added.
2836
2837 * ospf_zebra.c
2838 (ospf_default_information_originate_metric_type_routemap),
2839 (ospf_default_information_originate_always_metric_type_routemap):
2840 Change name and add route-map function.
2841 (ospf_default_information_originate_metric_routemap),
2842 (ospf_default_information_originate_routemap),
2843 (ospf_default_information_originate_type_metric_routemap):
2844 New DEFUN added.
2845
28462000-08-14 Kunihiro Ishiguro <kunihiro@zebra.org>
2847
2848 * ospf_zebra.c (zebra_interface_if_set_value): Change ifindex
2849 restore size from two octet to four.
2850
28512000-08-14 Michael Rozhavsky <mike@nbase.co.il>
2852
2853 * ospf_ase.c (ospf_ase_incremental_update): Implement incremental
2854 AS-external-LSA in 16.6 of RFC2328.
2855
28562000-08-14 Matthew Grant <grantma@anathoth.gen.nz>
2857
2858 * ospf_interface.c (ospf_if_get_output_cost): Change cost
2859 calculation algorithm.
2860
2861 * ospf_packet (ospf_ls_upd): Fix problem of LSA retransmitting.
2862
28632000-08-11 Michael Rozhavsky <mike@nbase.co.il>
2864
2865 * ospf_lsa.c (ospf_maxage_lsa_remover): Fix maxage remover for
2866 AS-external-LSAs.
2867
28682000-08-10 Toshiaki Takada <takada@zebra.org>
2869
2870 * ospfd.c (auto_cost_reference_bandwidth): New DEFUN added.
2871 `auto-cost reference-bandwidth' OSPF router command added.
2872
28732000-08-08 Gleb Natapov <gleb@nbase.co.il>
2874
2875 * ospf_routemap.c (ospf_route_map_update): New function added.
2876 Add route-map event hook.
2877
28782000-08-08 Toshiaki Takada <takada@zebra.org>
2879
2880 * ospf_zebra.c (ospf_distribute_check_connected): If redistribute
2881 prefix is connected route on OSPF enabled interface, suppress to
2882 announce it.
2883
28842000-08-08 Matthew Grant <grantma@anathoth.gen.nz>
2885
2886 * ospf_interface.c (ospf_if_get_output_cost):
2887 New function added. Handle bandwidth parameter for cost
2888 calculation.
2889
28902000-08-08 Michael Rozhavsky <mike@nbase.co.il>
2891
2892 * ospf_interface.c (interface_config_write): Show interface
2893 configuration regardless interface is down.
2894
2895 * ospf_ase.c (ospf_ase_caocluate_route): Whole rewritten external
2896 route calculate function.
2897
28982000-08-08 Gleb Natapov <gleb@nbase.co.il>
2899
2900 * ospf_routemap.c: New file added.
2901
2902 * ospf_asbr.c (ospf_reset_route_map_set_values),
2903 (ospf_route_map_set_compare): New function added.
2904
2905 * ospf_lsa.c (ospf_external_lsa_body_set): Set routemap metric
2906 with AS-external-LSA.
2907
29082000-08-05 Kunihiro Ishiguro <kunihiro@zebra.org>
2909
2910 * ospf_ase.c (ospf_ase_calculate_route_add): Pass new->cost to
2911 ospf_zebra_add as metric.
2912 (ospf_ase_calculate_route_add): Likewise.
2913
2914 * ospf_route.c (ospf_route_install): Pass or->cost to
2915 ospf_zebra_add as metric.
2916
2917 * ospf_zebra.c (ospf_zebra_add): Add metric arguemnt.
2918 (ospf_zebra_delete): Likewise.
2919
29202000-08-03 Matthew Grant <grantma@anathoth.gen.nz>
2921
2922 * ospf_flood.c (ospf_flood_delayed_lsa_ack): New function added.
2923 Dispatch delayed-ACK with flooding AS-external-LSA across virtual
2924 link.
2925
29262000-07-31 Matthew Grant <grantma@anathoth.gen.nz>
2927
2928 * ospfd.c (show_ip_ospf_area): Fix lack of VTY_NEWLINE when
2929 `show ip ospf'.
2930
2931 * ospf_interface.c (ospf_if_free): Fix bug of crash with
2932 Point-to-Point interface.
2933
29342000-07-27 Michael Rozhavsky <mike@nbase.co.il>
2935
2936 * ospf_flood.c (ospf_process_self_originated_lsa):
2937 Make sure to clear LSA->param (redistributed external information)
2938 before refreshment.
2939
29402000-07-27 Gleb Natapov <gleb@nbase.co.il>
2941
2942 * ospfd.c (refresh_group_limit), (refresh_per_slice),
2943 (refresh_age_diff): New defun added. Refresher related parameter
2944 can be configurable.
2945
29462000-07-27 Akihiro Mizutani <mizutani@dml.com>
2947
2948 * ospf_interface.c (interface_config_write): Print `description'
2949 config directive to work.
2950
29512000-07-24 Akihiro Mizutani <mizutani@dml.com>
2952
2953 * ospf_interface.c (ospf_if_init): Use install_default for
2954 INTERFACE_NODE.
2955
29562000-07-24 Gleb Natapov <gleb@nbase.co.il>
2957
2958 * ospf_packet.c (ospf_ls_upd_send_list), (ospf_ls_upd_send_event),
2959 (ospf_ls_ack_send_list), (ospf_ls_ack_send_event): New function added.
2960 This make sending always as many LS update/Ack combined in one ospf
2961 packet.
2962
29632000-07-24 Gleb Natapov <gleb@nbase.co.il>
2964
2965 * ospf_packet.c (ospf_ls_upd_list_lsa): Set NULL to lsa->area if
2966 LSA is AS-external-LSA.
2967
2968 * ospf_nsm.c (nsm_reset_nbr): Do not cancel Inactivity timer.
2969
29702000-07-21 Toshiaki Takada <takada@zebra.org>
2971
2972 * ospf_zebra.c (ospf_default_originate_timer): Set timer for
2973 `default-information originate'. Fix some default originate
2974 related functions.
2975
29762000-07-12 Toshiaki Takada <takada@zebra.org>
2977
2978 * ospf_lsa.c (stream_put_ospf_metric): New function added.
2979
29802000-07-12 Toshiaki Takada <takada@zebra.org>
2981
2982 * ospf_lsa.c (show_ip_ospf_database_router),
2983 (show_ip_ospf_database_network), (show_ip_ospf_database_summary),
2984 (show_ip_ospf_database_summary_asbr), (show_ip_ospf_database_externel),
2985 (show_router_lsa), (show_any_lsa), (show_router_lsa_self),
2986 (show_any_lsa_self): Functions removed.
2987
2988 (show_lsa_prefix_set), (show_lsa_detail_proc), (show_lsa_detail),
2989 (show_lsa_detail_adv_router_proc), (show_lsa_detail_adv_router):
2990 New functions added. Replace above functions.
2991
2992 (show_ip_ospf_database_all), (show_ip_ospf_database_self_originated):
2993 Functions removed.
2994 (show_ip_ospf_database_summary): New functions added. Replace
2995 above functions.
2996
2997 (show_ip_ospf_database_cmd): DEFUN rearranged.
2998 (show_ip_ospf_database_type_id_cmd),
2999 (show_ip_ospf_database_type_id_adv_router_cmd),
3000 (show_ip_ospf_database_type_is_self_cmd): New ALIASes added.
3001 (show_ip_ospf_database_type_adv_rotuer_cmd): New DEFUN added.
3002 (show_ip_ospf_database_type_self_cmd): New ALIAS added.
3003
30042000-07-11 Toshiaki Takada <takada@zebra.org>
3005
3006 * ospf_asbr.c (ospf_external_info_new),
3007 (ospf_external_info_free): New functions added.
3008
3009 * ospf_lsa.h (ospf_lsa): Add new member `void *param' to set
3010 origination parameter for external-LSA.
3011 Remove member `redistribute'.
3012
3013 * ospf_zebra.c (ospf_redistirbute_set): When `redistribute'
3014 command executed, metric and metric-type values are overridden.
3015 If one of those is changed refresh AS-external-LSAs for appropriate
3016 type.
3017
30182000-07-11 Michael Rozhavsky <mike@nbase.co.il>
3019
3020 * ospf_lsa.c (ospf_summary_lsa_refresh),
3021 (ospf_summary_asbr_lsa_refresh): Make sure to refresh summary-LSAs.
3022
3023 * ospf_abr.c (set_metric): New function added.
3024
30252000-07-07 Toshiaki Takada <takada@zebra.org>
3026
3027 * ospf_zebra.c (ospf_default_information_originate_metric_type),
3028 (ospf_default_information_originate_type_metric): New defun added.
3029 Metic and Metric type can be set to default route.
3030 (ospf_default_information_originate_always_metric_type):
3031 (ospf_default_information_originate_always_type_metric):
3032 New defun added. Metric and Metric type can be set to default
3033 always route.
3034
3035 * ospf_zebra.c (ospf_default_metric), (no_ospf_default_metric):
3036 New defun added.
3037
30382000-07-06 Gleb Natapov <gleb@nbase.co.il>
3039
3040 * ospf_flood.c (ospf_flood_through_area): Fix bug of considering
3041 on the same interface the LSA was received from.
3042
30432000-07-06 Michael Rozhavsky <mike@nbase.co.il>
3044
3045 * ospfd.c (ospf_config_write): Fix bug of printing `area stub'
3046 command with `write mem'.
3047
3048 * ospfd.c (no_router_ospf): Remove installed routes from zebra.
3049
3050 * ospf_zebra.c (ospf_interface_delete): Fix function to handle
3051 zebra interface delete event.
3052
30532000-07-06 Toshiaki Takada <takada@zebra.org>
3054
3055 * ospf_zebra.c (ospf_default_information_originate),
3056 (ospf_default_information_originate_always): New DEFUN added.
3057
30582000-07-05 Michael Rozhavsky <mike@nbase.co.il>
3059
3060 * ospf_route.c (ospf_terminate): Make sure to remove external route
3061 when SIGINT received.
3062
30632000-07-03 Gleb Natapov <gleb@nbase.co.il>
3064
3065 * ospf_flood.c, ospf_ism.c, ospf_lsa,c, ospfd.c: Make sure to free
3066 many structure with `no router ospf'.
3067
30682000-06-30 Gleb Natapov <gleb@nbase.co.il>
3069
3070 * ospf_neighbor.c (ospf_nbr_new),
3071 ospf_nsm.c (nsm_timer_set): Start LS update timer only
3072 when neighbor enters Exchange state.
3073
30742000-06-29 Gleb Natapov <gleb@nbase.co.il>
3075
3076 * ospf_nsm.c (nsm_timer_set), (nsm_exchange_done),
3077 ospf_packet.c (ospf_db_desc_proc):
3078 Do not cancel DD retransmit timer when Master.
3079
30802000-06-29 Gleb Natapov <gleb@nbase.co.il>
3081
3082 * ospf_abr.c (ospf_abr_announce_network_to_area),
3083 (ospf_abr_announce_rtr_to_area)
3084 ospf_ase.c (ospf_ase_rtrs_register_lsa),
3085 ospf_flood.c (ospf_process_self_originated_lsa),
3086 (ospf_flood_through_area), (ospf_ls_request_delete),
3087 ospf_interface.c (ospf_if_free),
3088 ospf_ism.c (ism_change_status),
3089 ospf_lsa.c (ospf_router_lsa_update_timer),
3090 (ospf_router_lsa_install), (ospf_network_lsa_install),
3091 (ospf_lsa_maxage_delete), (ospf_lsa_action),
3092 (ospf_schedule_lsa_flood_area),
3093 ospf_nsm.c (nsm_change_status),
3094 ospf_packet.c (ospf_make_ls_req_func), (ospf_make_ls_ack):
3095 Use ospf_lsa_{lock,unlock} for all looking-up of LSA.
3096
3097 * ospf_flood.c (ospf_ls_request_free): Function deleted.
3098
3099 * ospf_lsa.c (ospf_discard_from_db): New function added.
3100
31012000-06-26 Toshiaki Takada <takada@zebra.org>
3102
3103 * ospfd.h (ospf): struct member `external_lsa' name changed to
3104 `lsdb'.
3105
31062000-06-26 Toshiaki Takada <takada@zebra.org>
3107
3108 * ospf_lsa.c (ospf_lsa_install), (ospf_router_lsa_install),
3109 (ospf_network_lsa_install), (ospf_summary_lsa_install),
3110 (ospf_summary_asbr_lsa_install), (ospf_external_lsa_install):
3111 Functions re-arranged.
3112
3113 * ospf_lsa.c (IS_LSA_MAXAGE), (IS_LSA_SELF): Macro added.
3114
31152000-06-20 Michael Rozhavsky <mike@nbase.co.il>
3116
3117 * ospf_packet.c (ospf_ls_req), (ospf_ls_upd), (ospf_ls_ack): Add
3118 verification of LS type.
3119
31202000-06-20 Gleb Natapov <gleb@nbase.co.il>
3121
3122 * ospf_ase.c (ospf_ase_calculate_timer): Add more sanity check
3123 whether rn->info is NULL.
3124
31252000-06-20 Toshiaki Takada <takada@zebra.org>
3126
3127 * ospfd.c (show_ip_ospf_interface_sub): Show Router-ID of both
3128 DR and Backup correctly with `show ip ospf interface' command.
3129
31302000-06-20 Toshiaki Takada <takada@zebra.org>
3131
3132 * ospf_lsa.c (ospf_lsa_lock), (ospf_lsa_unlock),
3133 (ospf_lsa_discard): These functions are used for avoiding
3134 unexpected reference to freed LSAs.
3135
31362000-06-13 Kunihiro Ishiguro <kunihiro@zebra.org>
3137
3138 * ospf_packet.c (ospf_ls_upd): Initialize lsa by NULL to avoid
3139 warning.
3140
31412000-06-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3142
3143 * ospf_ase.h (ospf_ase_rtrs_register_lsa): Add prototype.
3144
31452000-06-12 Toshiaki Takada <takada@zebra.org>
3146
3147 * ospf_lsa.c (ospf_external_lsa_install): Make sure to register
3148 LSA to rtrs_external when replacing AS-external-LSAs in LSDB.
3149 Fix core dump.
3150
31512000-06-10 Toshiaki Takada <takada@zebra.org>
3152
3153 * ospf_lsdb.c (id_to_prefix), (ospf_lsdb_hash_key),
3154 (ospf_lsdb_hash_cmp), (ospf_lsdb_new), (ospf_lsdb_iterator),
3155 (lsdb_free), (ospf_lsdb_free), (ospf_lsdb_add), (ospf_lsdb_delete),
3156 (find_lsa), (ospf_lsdb_lookup), (find_by_id),
3157 (ospf_lsdb_lookup_by_id), (ospf_lsdb_lookup_by_header): Functinos
3158 removed for migration to new_lsdb.
3159
3160 * ospf_lsa.c (ospf_summary_lsa_install),
3161 (ospf_summary_asbr_lsa_install), (ospf_maxage_lsa_remover),
3162 (ospf_lsa_maxage_walker), (ospf_lsa_lookup),
3163 (ospf_lsa_lookup_by_id): Use new_lsdb instead of ospf_lsdb.
3164 (count_lsa), (ospf_lsa_count_table), (ospf_lsa_count),
3165 (ospf_get_free_id_for_prefix): Funcitions removed.
3166
31672000-06-09 Gleb Natapov <gleb@nbase.co.il>
3168
3169 * ospf_ism.c (ism_interface_down): Prevent some unneeded DR changes.
3170
3171 * ospf_packet.c (ospf_db_desc_proc): Fix memory leak.
3172 (ospf_hello): Always copy router-ID when hello is received.
3173
31742000-06-08 Gleb Natapov <gleb@nbase.co.il>
3175
3176 * ospf_lsa.h (struct ospf_lsa): Add member of pointer to struct
3177 ospf_area.
3178
31792000-06-08 Michael Rozhavsky <mike@nbase.co.il>
3180
3181 * ospf_ase.c (ospf_asbr_route_same): New function added.
3182 This function makes sure external route calculation more
3183 precisely.
3184
31852000-06-07 Michael Rozhavsky <mike@nbase.co.il>
3186
3187 * ospf_ism.c (ism_change_status): Use ospf_lsa_flush_area for
3188 network-LSA deletion instead of using ospf_lsdb_delete.
3189 Also cancel network-LSA origination timer.
3190
31912000-06-07 Levi Harper <lharper@kennedytech.com>
3192
3193 * ospf_interface.c (ospf_if_down): Close read fd when an interface
3194 goes down.
3195
31962000-06-05 Kunihiro Ishiguro <kunihiro@zebra.org>
3197
3198 * ospf_asbr.c (ospf_external_info_lookup): Add explicit brace for
3199 avoid ambiguous else.
3200
3201 * ospf_flood.c (ospf_external_info_check): Likewise.
3202
32032000-06-05 Toshiaki Takada <takada@zebra.org>
3204
3205 * ospf_nsm.c (nsm_adj_ok): Fix bug of DR election.
3206
32072000-06-04 Toshiaki Takada <takada@zebra.org>
3208
3209 * ospf_zebra.c (ospf_default_information_originate),
3210 (no_ospf_default_information_originate): New DEFUN added.
3211
32122000-06-03 Toshiaki Takada <takada@zebra.org>
3213
3214 * ospf_lsa.h, ospf_asbr.h (external_info): Struct moved from
3215 ospf_lsa.h to ospf_asbr.h.
3216
3217 * ospf_lsa.c, ospf_asbr.c (ospf_external_info_add),
3218 (ospf_external_info_delete): Function moved from ospf_lsa.c
3219 to ospf_asbr.c.
3220
32212000-06-03 Toshiaki Takada <takada@zebra.org>
3222
3223 * ospf_flood.c (ospf_external_info_check): New function added.
3224 (ospf_process_self_orignated_lsa): Make sure to flush
3225 self-originated AS-external-LSA, when router reboot and no longer
3226 originate those AS-external-LSA.
3227
32282000-06-02 Toshiaki Takada <takada@zebra.org>
3229
3230 * ospf_network.c (ospf_serv_sock): Remove SO_DONTROUTE
3231 socket option.
3232
3233 * ospf_packet.c (ospf_write): Set MSG_DONTROUTE flag for
3234 unicast destination packets.
3235
32362000-06-02 Toshiaki Takada <takada@zebra.org>
3237
3238 * ospf_lsdb.c (new_lsdb_delete): Delete entry from LSDB only when
3239 specified LSA matches.
3240
32412000-06-02 Gleb Natapov <gleb@nbase.co.il>
3242
3243 * ospf_network.c (ospf_serv_sock): Set SO_DONTROUTE
3244 socket option.
3245
32462000-06-01 Akihiro Mizutani <mizutani@dml.com>
3247
3248 * ospf_dump.c: Replace string `Debugging functions\n' with DEBUG_STR.
3249 Replace string `OSPF information\n' with OSPF_STR.
3250
32512000-06-01 Toshiaki Takada <takada@zebra.org>
3252
3253 * ospf_lsdb.[ch]: Use new_lsdb struct for network-LSA instead of
3254 ospf_lsdb.
3255
32562000-06-01 Toshiaki Takada <takada@zebra.org>
3257
3258 * ospf_dump.c (config_debug_ospf_packet), (config_debug_ospf_event),
3259 (config_debug_ospf_ism), (config_debug_ospf_nsm),
3260 (config_debug_ospf_lsa), (config_debug_ospf_zebra),
3261 (term_debug_ospf_packet), (term_debug_ospf_event),
3262 (term_debug_ospf_ism), (term_debug_ospf_nsm),
3263 (term_debug_ospf_lsa), (term_debug_ospf_zebra): Repalce debug_ospf_*
3264 variable to use for debug option flags.
3265
3266 (debug_ospf_packet), (debug_ospf_ism), (debug_ospf_nsm),
3267 (debug_ospf_lsa), (debug_ospf_zebra): Set {config,term}_debug_*
3268 flags when vty->node is CONFIG_NODE, otherwise set only term_debug_*
3269 flags.
3270
3271 * ospf_dump.h (CONF_DEBUG_PACKET_ON), (CONF_DEBUG_PACKET_OFF),
3272 (TERM_DEBUG_PACKET_ON), (TERM_DEBUG_PACKET_OFF),
3273 (CONF_DEBUG_ON), (CONF_DEBUG_OFF), (IS_CONF_DEBUG_OSPF_PACKET),
3274 (IS_CONF_DEBUG_OSPF): New Macro added.
3275
32762000-05-31 Toshiaki Takada <takada@zebra.org>
3277
3278 * ospfd.c (clear_ip_ospf_neighbor): New DEFUN added.
3279 Currently this command is used for only debugging.
3280
3281 * ospf_nsm.c (nsm_change_status): Make sure thread cancellation
3282 for network-LSA when DR has no full neighbors.
3283
3284 * ospf_nsm.c (ospf_db_summary_clear): New function added.
3285
32862000-05-30 Toshiaki Takada <takada@zebra.org>
3287
3288 * ospf_lsdb.c (new_lsdb_insert): LSAs are always freed by
3289 maxage_lsa_remover when LSA is replaced.
3290
32912000-05-25 Gleb Natapov <gleb@nbase.co.il>
3292
3293 * ospf_flood.c (ospf_ls_retransmit_delete_nbr_all): Add argument
3294 `struct ospf_area' to remove LSA from Link State retransmission list
3295 of neighbor from only one Area.
3296
32972000-05-24 Michael Rozhavsky <mike@nbase.co.il>
3298
3299 * ospf_lsdb.c (ospf_lsdb_add): Preserve flags field when
3300 overriting old LSA with new LSA.
3301
33022000-05-24 Gleb Natapov <gleb@nbase.co.il>
3303
3304 * ospf_lsa.c (ospf_router_lsa_body_set): Fix bug of router-LSA
3305 size calculation.
3306
33072000-05-22 Michael Rozhavsky <mike@nbase.co.il>
3308
3309 * ospf_route.c (ospf_intra_add_stub):
3310 * ospf_spf.h (struct vertex): Use u_int32_t for distance (cost)
3311 value instead of u_int16_t.
3312
33132000-05-22 Axel Gerlach <agerlach@datus.datus.com>
3314
3315 * ospf_ia.c (ospf_ia_network_route): Fix bug of Inter-area route
3316 equal cost path calculation.
3317
33182000-05-21 Toshiaki Takada <takada@zebra.org>
3319
3320 * ospf_ase.c (ospf_ase_calculate_route_delete): New function added.
3321 Make sure, when rotuer route is deleted, related external routes
3322 are also deleted.
3323
33242000-05-20 Toshiaki Takada <takada@zebra.org>
3325
3326 * ospfd.c (ospf_interface_down): Make sure interface flag is disable
3327 and set fd to -1.
3328
33292000-05-16 Toshiaki Takada <takada@zebra.org>
3330
3331 * ospf_asbr.c (ospf_asbr_should_announce), (ospf_asbr_route_remove):
3332 Functions removed.
3333
3334 * ospfd.h (EXTERNAL_INFO): Macro added.
3335 Substitute `ospf_top->external_info[type]' with it.
3336
33372000-05-16 Toshiaki Takada <takada@zebra.org>
3338
3339 * ospf_lsa.c (ospf_rtrs_external_remove): New function added.
3340
33412000-05-14 Gleb Natapov <gleb@nbase.co.il>
3342
3343 * ospf_flood.c (ospf_ls_retransmit_delete_nbr_all)
3344 * ospf_lsdb.c (new_lsdb_insert)
3345 * ospf_packet.c (ospf_ls_ack): Fix database synchonization problem.
3346
33472000-05-14 Gleb Natapov <gleb@nbase.co.il>
3348
3349 * ospf_lsa.h (tv_adjust), (tv_ceil), (tv_floor), (int2tv),
3350 (tv_add), (tv_sub), (tv_cmp): Prototype definition added.
3351
3352 * ospf_nsm.h (ospf_db_summary_delete_all): Prototype definition added.
3353
33542000-05-13 Toshiaki Takada <takada@zebra.org>
3355
3356 * ospf_lsa.[ch] (ospf_lsa): struct timestamp type is changed from
3357 time_t to struct timeval.
3358 (tv_adjust), (tv_ceil), (tv_floor), (int2tv), (tv_add),
3359 (tv_sub), (tv_cmp): timeval utillity functions added.
3360
33612000-05-12 Toshiaki Takada <takada@zebra.org>
3362
3363 * ospf_lsa.[ch] (ospf_schedule_update_router_lsas): Delete function.
3364 Change to use macro OSPF_LSA_UPDATE_TIMER instead of using
3365 this function.
3366 router-LSA refresh timer related stuff is re-organized.
3367
33682000-05-10 Gleb Natapov <gleb@nbase.co.il>
3369
3370 * ospf_interface.c (ospf_vl_set_params):
3371 * ospf_packet.c (ospf_check_network_mask):
3372 * ospf_spf.[ch] (ospf_spf_next):
3373 Remove field address from `struct vertex', and search for peer
3374 address of virtual link in function `ospf_vl_set_params' instead.
3375
33762000-05-10 Gleb Natapov <gleb@nbase.co.il>
3377
3378 * ospf_packet.c (ospf_ls_upd): Fix some memory leak related LSA.
3379
33802000-05-08 Thomas Molkenbur <tmo@datus.com>
3381
3382 * ospf_packet.c (ospf_packet_dup): Replace ospf_steram_copy()
3383 with ospf_stream_dup() to fix memory leak.
3384
33852000-05-08 Michael Rozhavsky <mike@nbase.co.il>
3386
3387 * ospf_flood.c (ospf_flood_through_area): Fix the problem of
3388 LSA update without DROther.
3389
33902000-05-04 Gleb Natapov <gleb@nbase.co.il>
3391
3392 * ospf_spf.c (ospf_vertex_free): Fix memory leak of SPF calculation.
3393
33942000-05-03 Toshiaki Takada <takada@zebra.org>
3395
3396 * ospf_neighbor.c (ospf_db_summary_add): Use new_lsdb struct
3397 instead linked-list.
3398 (ospf_db_summary_count), (ospf_db_summary_isempty):
3399 New function added.
3400
3401 * ospf_lsa.c (ospf_rotuer_lsa): Re-arrange and divide functions.
3402
34032000-05-02 Gleb Natapov <gleb@nbase.co.il>
3404
3405 * ospf_lsdb.c (new_lsdb_cleanup): Fix memory leak. When LSDB are
3406 not needed any more, then free them.
3407
34082000-05-02 Toshiaki Takada <takada@zebra.org>
3409
3410 * ospfd.c (timers_spf), (no_timers_spf): New defun added.
3411 SPF calculation timers related stuff is rearranged.
3412
3413 * ospf_spf.c (ospf_spf_calculate_timer_add): Function removed.
3414 SPF timer is scheduled by SPF calculation delay and holdtime
3415 configuration variable.
3416
3417 * ospf_lsa.c (ospf_external_lsa_nexthop_get): Set AS-external-LSA's
3418 forwarding address when nexthop learned by other protocols is
3419 in the OSPF domain.
3420
3421 * ospf_zebra.c (ospf_redistribute_source_metric_type),
3422 (ospf_redistribute_source_type_metric): Re-arrange DEFUNs and
3423 ALIASes.
3424
34252000-05-01 Toshiaki Takada <takada@zebra.org>
3426
3427 * ospf_flood.c (ospf_ls_retransmit_count),
3428 (ospf_ls_retransmit_isempty): New function added.
3429
3430 (ospf_ls_retransmit_add), (ospf_ls_retransmit_delete),
3431 (ospf_ls_retransmit_clear), (ospf_ls_retransmit_lookup),
3432 (ospf_ls_retransmit_delete_all), (ospf_ls_retransmit_delete_nbr_all),
3433 (ospf_ls_retransmit_add_nbr_all): Replace these functions to use
3434 new_lsdb.
3435
34362000-04-29 Toshiaki Takada <takada@zebra.org>
3437
3438 * ospfd.c (no_network_area): Add check Area-ID whether specified
3439 Area-ID with prefix matches config.
3440
34412000-04-27 Toshiaki Takada <takada@zebra.org>
3442
3443 * ospf_lsa.c (ospf_maxage_lsa_remover): Fix problem of
3444 remaining withdrawn routes on zebra.
3445
34462000-04-25 Michael Rozhavsky <mike@nbase.co.il>
3447
3448 * ospf_nsm.c (nsm_kill_nbr), (nsm_ll_down), (nsm_change_status),
3449 (ospf_nsm_event): Fix network-LSA re-origination problem.
3450
34512000-04-24 Toshiaki Takada <takada@zebra.org>
3452
3453 * ospf_nsm.c (ospf_db_desc_timer): Fix bug of segmentation fault
3454 with DD retransmission.
3455
3456 * ospf_nsm.c (nsm_kill_nbr): Fix bug of re-origination when
3457 a neighbor disappears.
3458
34592000-04-23 Michael Rozhavsky <mike@nbase.co.il>
3460
3461 * ospf_abr.c (ospf_abr_announce_network_to_area): Fix bug of
3462 summary-LSAs reorigination. Correctly copy OSPF_LSA_APPROVED
3463 flag to new LSA. when summary-LSA is reoriginatd.
3464
3465 * ospf_flood.c (ospf_flood_through_area): Fix bug of flooding
3466 procedure. Change the condition of interface selection.
3467
34682000-04-21 Toshiaki Takada <takada@zebra.org>
3469
3470 * ospf_lsa.c (ospf_refresher_register_lsa): Fix bug of refresh never
3471 occurs.
3472
3473 * ospfd.c (show_ip_ospf_neighbor_id): New defun added.
3474 `show ip ospf neighbor' related commands are re-arranged.
3475
34762000-04-20 Toshiaki Takada <takada@zebra.org>
3477
3478 * ospf_dump.c (debug_ospf_zebra): New defun added.
3479 Suppress zebra related debug information.
3480
34812000-04-19 Toshiaki Takada <takada@zebra.org>
3482
3483 * ospf_zebra.c (ospf_distribute_list_update_timer),
3484 (ospf_distribute_list_update), (ospf_filter_update):
3485 New function added. Re-organize `distribute-list' router ospf
3486 command.
3487
34882000-04-13 Michael Rozhavsky <mike@nbase.co.il>
3489
3490 * ospf_packet.c (ospf_make_ls_upd): Add check for MAX_AGE.
3491
34922000-04-14 Michael Rozhavsky <mike@nbase.co.il>
3493
3494 * ospf_packet.c (ospf_make_ls_upd): Increment LS age by configured
3495 interface transmit_delay.
3496
34972000-04-14 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3498
3499 * ospf_interface.c (ip_ospf_cost), (no_ip_ospf_cost):
3500 Add to schedule router_lsa origination when the interface cost changes.
3501
35022000-04-12 Toshiaki Takada <takada@zebra.org>
3503
3504 * ospf_lsa.c (ospf_refresher_register_lsa),
3505 (ospf_refresher_unregister_lsa): Fix bug of core dumped.
3506
3507 * ospfd.c (no_router_ospf): Fix bug of core dumped.
3508
35092000-03-29 Toshiaki Takada <takada@zebra.org>
3510
3511 * ospf_nsm.c (nsm_oneway_received): Fix bug of MS flag unset.
3512
35132000-03-29 Michael Rozhavsky <mike@nbase.co.il>
3514
3515 * ospf_lsa.c (ospf_network_lsa):
3516 * ospf_nsm.c (ospf_nsm_event): Fix bug of Network-LSA originated
3517 in stub network.
3518
35192000-03-28 Toshiaki Takada <takada@zebra.org>
3520
3521 * ospf_nsm.c (nsm_bad_ls_req), (nsm_seq_number_mismatch),
3522 (nsm_oneway_received): Fix bug of NSM state flapping between
3523 ExStart and Exchange.
3524
35252000-03-28 Toshiaki Takada <takada@zebra.org>
3526
3527 * ospf_packet.h (strcut ospf_header): Fix the size of ospf_header,
3528 change u_int8_t to u_char.
3529
35302000-03-27 Toshiaki Takada <takada@zebra.org>
3531
3532 * ospf_lsa.c (ospf_lsa_checksum): Take care of BIGENDIAN architecture.
3533
35342000-03-27 Toshiaki Takada <takada@zebra.org>
3535
3536 * ospfd.c (ospf_interface_run): Make sure Address family matches.
3537
35382000-03-26 Love <lha@s3.kth.se>
3539
3540 * ospf_packet.c (ospf_write): Chack result of sendto().
3541
35422000-03-26 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3543
3544 * ospf_nsm.c (nsm_oneway_received): Fix bug of 1-WayReceived in NSM.
3545
35462000-03-23 Libor Pechacek <farco@clnet.cz>
3547
3548 * ospf_lsa.c (ospf_network_lsa)
3549 * ospf_lsdb.c (new_lsdb_insert): Fix bug of accessing to
3550 unallocated memory.
3551
35522000-03-23 Toshiaki Takada <takada@zebra.org>
3553
3554 * ospfd.c (ospf_config_write): Fix bug of duplicate line for
3555 `area A.B.C.D authentication'.
3556
35572000-03-22 Toshiaki Takada <takada@zebra.org>
3558
3559 * ospf_debug.c (debug_ospf_lsa), (no_debug_ospf_lsa): Defun added.
3560 Suppress all zlog related to LSAs with this config option.
3561
35622000-03-21 Kunihiro Ishiguro <kunihiro@zebra.org>
3563
3564 * ospf_nsm.c (ospf_nsm_event): Add check for NSM_InactivityTimer.
3565
35662000-03-21 Toshiaki Takada <takada@zebra.org>
3567
3568 * ospf_packet.c (ospf_ls_upd_timer), (ospf_ls_req):
3569 Fix bug of memory leak about linklist.
3570
3571 * ospf_flood.c (ospf_flood_through_area): Likewise.
3572
35732000-03-18 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3574
3575 * ospf_flood.c (ospf_ls_retransmit_lookup): Add checksum comparison
3576 to identify LSA uniquely. This fix routes lost.
3577
35782000-03-18 Toshiaki Takada <takada@zebra.org>
3579
3580 * ospf_ase.c (ospf_find_asbr_route): Add sanity check with router
3581 routing table.
3582
35832000-03-17 Alex Zinin <zinin@amt.ru>
3584
3585 * ospf_spf.[ch]: Bug fix.
3586 The 2nd stage of Dijkstra could consider one vertex
3587 more than once if there is more than one link
3588 between the routers, thus adding extra CPU overhead
3589 and extra next-hops.
3590 Fixed.
3591
35922000-03-15 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3593
3594 * ospf_nsm.c (nsm_inactivity_timer): Changed to call nsm_kill_nbr().
3595
35962000-03-14 Toshiaki Takada <takada@zebra.org>
3597
3598 * ospf_route.c (ospf_route_copy_nexthops): Fix bug of memory leak of
3599 ospf_path. Actually ignore merging ospf_route with completely same
3600 paths.
3601
36022000-03-12 Toshiaki Takada <takada@zebra.org>
3603
3604 * ospf_lsa.c (show_as_external_lsa_detail): fix bug of
3605 external route tag byte order.
3606
36072000-03-11 Toshiaki Takada <takada@zebra.org>
3608
3609 * ospf_lsdb.c (ospf_lsdb_insert): New function added.
3610
36112000-03-09 Toshiaki Takada <takada@zebra.org>
3612
3613 * ospf_lsa.c (ospf_external_lsa_install),
3614 (ospf_lsa_lookup), (show_ip_ospf_database_all),
3615 (show_ip_ospf_database_self_originate): Use struct new_lsdb for
3616 LSDB of AS-external-LSAs instead of ospf_lsdb.
3617
3618 * ospf_lsa.c (ospf_lsa_unique_id): New function added.
3619 Use for assigning Unique Link State ID instead of
3620 ospf_get_free_id_for_prefix().
3621
36222000-03-09 Toshiaki Takada <takada@zebra.org>
3623
3624 * ospf_ase.c (ospf_ase_calculate_timer): Fix bug of segmentation
3625 fault reported by George Bonser <george@siteROCK.com>.
3626
36272000-03-07 Libor Pechacek <farco@clnet.cz>
3628
3629 * ospfd.c (ospf_interface_down): Fix bug of segmentation fault.
3630
36312000-03-06 Toshiaki Takada <takada@zebra.org>
3632
3633 * ospf_route.c (ospf_route_cmp): Change meaning of return values.
3634
36352000-03-02 Alex Zinin <zinin@amt.ru>
3636 * ospfd.h, ospf_ia.h
3637 New Shortcut ABR code. Now area's flag can be configured
3638 with Default, Enable, and Disable values.
3639 More info will be in the new ver of I-D soon (see IETF web).
3640
36412000-02-25 Toshiaki Takada <takada@zebra.org>
3642
3643 * ospf_lsa.c (ospf_lsa_header_set), (ospf_external_lsa_body_set),
3644 (osfp_external_lsa_originate), (ospf_external_lsa_queue),
3645 (ospf_external_lsa_originate_from_queue): New function added.
3646 (ospf_external_lsa): Function removed.
3647
3648 * ospf_zebra.c (ospf_zebra_read_ipv4): Originate AS-external-LSA
3649 when listen a route from Zebra, instead creating external route.
3650
3651 * ospf_asbr.c (ospf_asbr_route_add_flood_lsa),
3652 (ospf_asbr_route_add_queue_lsa),
3653 (ospf_asbr_route_install_lsa), (ospf_asbr_route_add):
3654 Functions removed.
3655
3656 * ospf_ase.c (process_ase_lsa): Function will not be used.
3657 (ospf_ase_calculate), (ospf_ase_calculate_route_add),
3658 (ospf_ase_calculate_new_route), (ospf_ase_caluculate_asbr_route):
3659 process_ase_lsa () is separated to these functions.
3660
3661 OSPF AS-external-LSA origination is whole re-organized.
3662
36632000-02-18 Toshiaki Takada <takada@zebra.org>
3664
3665 * ospf_packet.c (ospf_ls_upd): Fix bug of OSPF LSA memory leak.
3666
3667 * ospf_asbr.c (ospf_asbr_route_add_flood_lsa),
3668 (ospf_asbr_route_add_queue_lsa): Fix bug of OSPF external route
3669 memory leak.
3670
36712000-02-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3672
3673 * ospf_asbr.c (ospf_asbr_route_install_lsa): Re-calculate LSA
3674 checksum after change Advertised Router field.
3675
36762000-02-09 Toshiaki Takada <takada@zebra.org>
3677
3678 * ospf_asbr.c (ospf_external_route_lookup): Add new function.
3679
36802000-02-08 Toshiaki Takada <takada@zebra.org>
3681
3682 * ospfd.c (ospf_router_id_get), (ospf_router_id_update),
3683 (ospf_router_id_update_timer): Router ID decision algorithm is changed.
3684 Router ID is chosen from all of eligible interface addresses even if
3685 it is not enable to OSPF.
3686
36872000-02-08 Toshiaki Takada <takada@zebra.org>
3688
3689 * ospf_asbr.c (ospf_asbr_route_add): Function divided to
3690 ospf_asbr_route_add_flood_lsa, ospf_asbr_route_add_queue_lsa and
3691 ospf_asbr_route_install_lsa. If Router-ID is not set, then LSA is
3692 waited to install to LSDB.
3693 `0.0.0.0 adv_router' AS-external-LSA origination bug was fixed.
3694
36952000-02-01 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3696
3697 * ospf_flood.c (ospf_ls_retransmit_lookup): Compare LS seqnum
3698 in the ACK before deleting.
3699
3700 * ospf_packet.c (ospf_hello): Reset the flags after a shutdown
3701 and no shutdown of the interface.
3702
37032000-01-31 Toshiaki Takada <takada@zebra.org>
3704
3705 * ospf_packet.c (ospf_ls_req): Send multiple Link State Update
3706 packets respond to a Link State Request packet.
3707
3708 * ospfd.c (show_ip_ospf_neighbor_detail_sub): Show thread state.
3709
3710 * ospf_interface.c (ospf_vl_new): Crash when backbone area
3711 is not configured and set virtual-link to no-backbone area,
3712 bug fixed.
3713
37142000-01-30 Kunihiro Ishiguro <kunihiro@zebra.org>
3715
3716 * ospf_neighbor.h (struct ospf_neighbor): Add pointer to last send
3717 LS Request LSA.
3718
3719 * ospf_packet.c (ospf_ls_upd): Comment out LS request list
3720 treatment. That should be done in OSPF flooding procedure.
3721
3722 * ospf_flood.c (ospf_flood_through_area): Enclose
3723 ospf_check_nbr_loding inside if-else close.
3724
37252000-01-31 Toshiaki Takada <takada@zebra.org>
3726
3727 * ospf_packet.c (ospf_make_ls_upd): Fix bug of #LSAs counting.
3728
37292000-01-29 Toshiaki Takada <takada@zebra.org>
3730
3731 * ospf_packet.c (ospf_make_md5_digest): Fix bug of md5 authentication.
3732
37332000-01-28 Toshiaki Takada <takada@zebra.org>
3734
3735 * ospfd.c (show_ip_ospf): Show Number of ASE-LSAs.
3736
37372000-01-27 Kunihiro Ishiguro <kunihiro@zebra.org>
3738
3739 * ospf_packet.c (ospf_make_db_desc): Don't use rm_list for
3740 removing LSA from nbr->db_summary.
3741
37422000-01-27 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3743
3744 * ospf_packet.c (ospf_ls_upd_send): Set AllSPFRouters to
3745 destination when the link is point-to-point.
3746 (ospf_ls_ack_send_delayed): Likewise.
3747
37482000-01-27 Kunihiro Ishiguro <kunihiro@zebra.org>
3749
3750 * ospf_flood.c (ospf_ls_request_delete_all): Fix bug of next
3751 pointer lookup after the node is freed.
3752
37532000-01-26 Kunihiro Ishiguro <kunihiro@zebra.org>
3754
3755 * ospf_asbr.c (ospf_asbr_route_add): Instead of scanning all AS
3756 external route, use ospf_top->external_self.
3757
37582000-01-27 Toshiaki Takada <takada@zebra.org>
3759
3760 * ospf_lsa.c (ospf_forward_address_get): New function added.
3761
3762 * ospf_asbr.c (ospf_asbr_check_lsas): Originate AS-external-LSA
3763 only when it should be replaced.
3764
37652000-01-25 Kunihiro Ishiguro <kunihiro@zebra.org>
3766
3767 * ospf_flood.c (ospf_ls_retransmit_clear): Delete list node.
3768
3769 * ospf_lsa.c (ospf_lsa_free): Reduce logging message using
3770 ospf_zlog value.
3771
3772 * ospf_ism.c (ism_change_status): Fix bug of DR -> non DR status
3773 change. Self originated LSA is freed but not deleted from lsdb.
3774
37752000-01-24 Kunihiro Ishiguro <kunihiro@zebra.org>
3776
3777 * ospf_ism.c (ism_interface_down): Don't use router_id for
3778 detecting self neighbor structure. Instead of that compare
3779 pointer itself.
3780
3781 * ospf_neighbor.c (ospf_nbr_free): Cancel all timer when neighbor
3782 is deleted.
3783 (ospf_nbr_free): Free last send packet.
3784
3785 * ospf_neighbor.h (struct ospf_neighbor): Remove host strucutre.
3786 Instead of that src is introduced.
3787
3788 * ospf_nsm.h: Enclose macro defenition with do {} while (0).
3789
37902000-01-17 Kunihiro Ishiguro <kunihiro@zebra.org>
3791
3792 * ospfd.c: Change part of passive interface implementation. For
3793 passive interface just disabling sending/receiving Hello on the
3794 interface.
3795
37962000-01-16 Kai Bankett <kai.bankett@vew-telnet.net>
3797
3798 * ospf_interface.h (OSPF_IF_PASSIVE): Add passive flag.
3799 * ospf_interface.c (ospf_if_lookup_by_name): Add new function.
3800 * ospf_lsa.c (ospf_router_lsa): Skip passive interface.
3801 * ospfd.c (passive_interface): New command passive-interface is
3802 added.
3803 (ospf_config_write): Print passive interface.
3804
38052000-01-15 Toshiaki Takada <takada@zebra.org>
3806
3807 * ospf_interface.h (crypt_key): New struct added to store
3808 multiple cryptographic autheitication keys.
3809 (ospf_interface): struct changed.
3810
3811 * ospf_interface.c: ospf_crypt_key_new, ospf_crypt_key_add,
3812 ospf_crypt_key_lookup, ospf_crypt_key_delete: new functions added.
3813
3814 * ospf_packet.c (ip_ospf_message_digest_key): Changed to store
3815 multiple cryptographic authentication keys.
3816
38172000-01-14 Toshiaki Takada <takada@zebra.org>
3818
3819 * ospf_interface.c: DEFUN (if_ospf_*) commands changed name to
3820 ip_ospf_* ().
3821 Old notation `ospf *' still remains backward compatibility.
3822
38231999-12-29 Alex Zinin <zinin@amt.ru>
3824 * ospf_lsa.c: ospf_lsa_more_recent() bug fix
3825 * ospf_nsm.c, ospf_packet.c: remove nbr data struct when
3826 int goes down, also check DD flags correctly (bug fix)
3827
38281999-12-28 Alex Zinin <zinin@amt.ru>
3829 * "redistribute <source> metric-type (1|2) metric <XXX>" added
3830
38311999-12-23 Alex Zinin <zinin@amt.ru>
3832 * added RFC1583Compatibility flag
3833 * added dynamic interface up/down functionality
3834
38351999-11-19 Toshiaki Takada <takada@zebra.org>
3836
3837 * ospf_neighbor.h (struct ospf_neighbor): Add member state_change
3838 for NSM state change statistics.
3839
38401999-11-19 Toshiaki Takada <takada@zebra.org>
3841
3842 * ospfd.c (show_ip_ospf_neighbor_detail),
3843 (show_ip_ospf_neighbor_int_detail): DEFUN Added.
3844
38451999-11-14 Kunihiro Ishiguro <kunihiro@zebra.org>
3846
3847 * ospf_asbr.c (ospf_asbr_check_lsas): Add check of
3848 lsa->refresh_list.
3849
38501999-11-11 Toshiaki Takada <takada@zebra.org>
3851
3852 * ospf_ia.[ch] (OSPF_EXAMINE_SUMMARIES_ALL): Macro added.
3853 This macro is expanded to ospf_examine_summaries ()
3854 for SUMMARY_LSA and SUMMARY_LSA_ASBR.
3855 (OSPF_EXAMINE_TRANSIT_SUMMARIES_ALL): Macro added.
3856 This macro is expanded to ospf_examine_transit_summaries ()
3857 for SUMMARY_LSA and SUMMARY_LSA_ASBR.
3858
38591999-11-11 Toshiaki Takada <takada@zebra.org>
3860
3861 * ospf_lsa.[ch] (ospf_find_self_summary_lsa_by_prefix): Changed to
3862 macro OSPF_SUMMARY_LSA_SELF_FIND_BY_PREFIX.
3863 (ospf_find_self_summary_asbr_lsa_by_prefix): Changed to
3864 macro OSPF_SUMMARY_ASBR_LSA_SELF_FIND_BY_PREFIX.
3865 (ospf_find_self_external_lsa_by_prefix): Changed to
3866 macro OSPF_EXTERNAL_LSA_SELF_FIND_BY_PREFIX.
3867
38681999-11-11 Toshiaki Takada <takada@zebra.org>
3869
3870 * ospfd.c (ospf_abr_type): ospf_abr_type_cisco, ospf_abr_type_ibm,
3871 ospf_abr_type_shortcut and ospf_abr_type_standard DEFUNs are
3872 combined.
3873 * ospfd.c (no_ospf_abr_type): no_ospf_abr_type_cisco,
3874 no_ospf_abr_type_ibm and no_ospf_abr_type_shortcut DEFUNS are
3875 combined.
3876
38771999-11-10 Toshiaki Takada <takada@zebra.org>
3878
3879 * ospf_route.c (ospf_lookup_int_by_prefix): Move function to
3880 ospf_interface.c and change name to ospf_if_lookup_by_prefix ().
3881
38821999-11-01 Alex Zinin <zinin@amt.ru>
3883 * ospf_packet.c
3884 some correction to LSU processing
3885
3886 * ospf_lsa.c ospfd.h
3887 randomize initial LSA refreshment interval
3888 and limit the size of LSA-group to 10
3889 to let randomization work more effectively.
3890
38911999-10-31 Alex Zinin <zinin@amt.ru>
3892 * ospf_interface.c
3893 cancel t_network_lsa_self
3894 when freeing int structure
3895
3896 * ospf_abr.c ospf_asbr.c ospf_flood.c ospf_lsa.c
3897 ospf_lsa.h ospf_lsdb.h ospfd.c ospfd.h
3898
3899 Summary and ASE LSA refreshment functions
3900 added---LSA refreshment is paced to 70 LSAs
3901 per sec to avoid link overflow. Refreshment events
3902 are further randomized within a 10 sec interval
3903 to avoid syncing.
3904
3905 Also the sigfault of memcmp() in ospf_lsa_is_different()
3906 is fixed.
3907
39081999-10-30 Alex Zinin <zinin@amt.ru>
3909 * ospf_nsm.c
3910 Fix the bug where MAX_AGE LSAs
3911 are included into the DB summary.
3912
3913 * ospf_interface.c
3914 allocate 2*MTU input buffer instead of just MTU
3915 for the cases when the other router mistakenly
3916 sends larger packets thus causing fragmentation, etc.
3917
3918 * ospf_nsm.c
3919 in nsm_reset_nbr() lists should be freed
3920 not when they are empty.
3921
39221999-10-29 Kunihiro Ishiguro <kunihiro@zebra.org>
3923
3924 * ospf_zebra.c (ospf_acl_hook): Move OSPF_IS_ASBR and OSPF_IS_ABR
3925 check inside of if (ospf_top).
3926
39271999-10-29 Alex Zinin <zinin@amt.ru>
3928 * ospf_lsa.c ospf_lsdb.c :
3929 add assertion in lsa and lsa->data alloc functions,
3930 as well as in lsdb_add for new->data
3931
3932 * ospf_lsdb.c: free hash table correctly
3933
39341999-10-28 John Capo <jc@irbs.com>
3935
3936 * ospf_packet.h (OSPF_PACKET_MAX): Correct MAX packet length
3937 calculation
3938
39391999-10-27 Kunihiro Ishiguro <kunihiro@zebra.org>
3940
3941 * OSPF-TRAP-MIB.txt: New file added. Edited version of RFC1850.
3942
3943 * OSPF-MIB.txt: New file added. Edited version of RFC1850.
3944
39451999-10-27 Alex Zinin <zinin@amt.ru>
3946 * ospfd, ospf_zebra, ospf_abr
3947 "area import-list" command is added.
3948 This command allows to filter the inter-area routes
3949 injected into an area. Access list hook function
3950 extended to invalidate area exp/imp lists.
3951
39521999-10-25 Yoshinobu Inoue <shin@nd.net.fujitsu.co.jp>
3953
3954 * ospfd.c (ospf_interface_run): Enable to detect P2P network
3955 on an OSPF interface.
3956
39571999-10-19 Jordan Mendelson <jordy@wserv.com>
3958
3959 * ospf_lsdb.c (ospf_lsdb_add): Fix bug of crash
3960 in ospf_ls_retransmit_lookup ().
3961
39621999-10-19 Vladimir B. Grebenschikov <vova@express.ru>
3963
3964 * ospf_route.c: Workaround about installation of OSPF routes into
3965 the zebra daemon. Add checking of existance routes. Free
3966 ospf_top->old_table if it exists.
3967
39681999-10-15 Jordan Mendelson <jordy@wserv.com>
3969
3970 * Add support for MD5 authentication.
3971
39721999-10-12 Alex Zinin <zinin@amt.ru>
3973 * ospfd.c, ospfd.h, ospf_abr.c:
3974 a new command "area export-list" was added, it allows
3975 the admin. to control which intra-area routes are
3976 announced to other areas by the ABR
3977
39781999-10-12 Alex Zinin <zinin@amt.ru>
3979 * ospf_asbr.c (ospf_asbr_check_lsas): Fix bug of coredump
3980 when "no redistribute" is used after a distribute list
3981 denying some networks was used
3982
39831999-10-05 Toshiaki Takada <takada@zebra.org>
3984
3985 * ospf_route.c (ospf_path_dup): New function added.
3986
39871999-10-05 Toshiaki Takada <takada@zebra.org>
3988
3989 * ospf_interface.[ch]: Some of VL related funciton name changed.
3990
39911999-09-27 Alex Zinin <zinin@amt.ru>
3992
3993 * ospf_zebra.c: Distribute-list functionality added
3994
39951999-09-27 Toshiaki Takada <takada@zebra.org>
3996
3997 * ospfd.c (show_ip_ospf): Fix bug of segmentation fault when no ospf
3998 instance exists.
3999
40001999-09-25 Kunihiro Ishiguro <kunihiro@zebra.org>
4001
4002 * ospfd.c (ospf_interface_down): Fix bug of misusing nextnode()
4003 instead of node->next. Reported by Hiroki Ishibashi
4004 <ishibasi@dcd.abk.nec.co.jp>.
4005
4006 * ospf_route.c (show_ip_ospf_route): Add check for ospf is enabled
4007 or not.
4008
40091999-09-23 Alex Zinin <zinin@amt.ru>
4010
4011 * stub area support added
4012
40131999-09-23 Alex Zinin <zinin@amt.ru>
4014
4015 * fwd_addr in ASE-LSAs is now set correctly
4016 * ASE routing changed to check the fwd_addr
4017 and skip the route if the addr points to one
4018 of our interfaces to avoid loops.
4019
40201999-09-22 Alex Zinin <zinin@amt.ru>
4021
4022 * ospf_interface:
4023 ospf_vls_in_area() added, it returns
4024 the number of VLs configured through the area
4025
4026 * ospf_interface.c ospf_lsa.c ospf_lsdb.c ospfd.c
4027 honor correct mem alloc
4028
40291999-09-22 Alex Zinin <zinin@amt.ru>
4030
4031 * memory.[ch]:
4032 Some OSPF mem types added,
4033 plus more info in "show mem"
4034
40351999-09-21 Alex Zinin <zinin@amt.ru>
4036
4037 * ospfd.c:
4038 "area range substitute" added.
4039 It can be used on NAT-enabled (IP-masquarade)
4040 routers to announce private networks
4041 from an area as public ones into the outside
4042 world (not in the RFC, btw :)
4043
40441999-09-21 Alex Zinin <zinin@amt.ru>
4045
4046 * ospfd.c:
4047 "area range suppress" added.
4048 This command allows to instruct the router
4049 to be silent about specific ranges, i.e.,
4050 it is a method of route filtering on area
4051 borders
4052
40531999-09-21 Alex Zinin <zinin@amt.ru>
4054
4055 * ospfd.c VLs removed when "no network area" executed
4056
40571999-09-20 Alex Zinin <zinin@amt.ru>
4058
4059 * ospf_ase.c bug fix for not-zero fwd_addr
4060 and directly connected routes.
4061
40621999-09-20 Yon Uriarte <yon@plannet.de>
4063
4064 * ospf_packet.c (ospf_make_ls_req): Introduce delta value for
4065 checking the length of OSPF packet exceeds MTU or not.
4066
4067 * ospf_lsa.c (ospf_lsa_different): Apply ntohs for checking
4068 l1->data->length.
4069
40701999-09-18 Alex Zinin <zinin@amt.ru>
4071
4072 * ospf_lsa.c bug fix for ospf_network_lsa() to
4073 include itself into the RID list
4074
40751999-09-10 Alex Zinin <zinin@amt.ru>
4076
4077 * Alternative ABR behaviors IBM/Cisco/Shortcut
4078 implemented
4079
40801999-09-10 Alex Zinin <zinin@amt.ru>
4081
4082 * router and network-LSA origination
4083 changed to honor MinLSInterval
4084
40851999-09-08 Alex Zinin <zinin@amt.ru>
4086
4087 * modified ABR behavior to honor VLs and transit
4088 areas
4089
40901999-09-07 Alex Zinin <zinin@amt.ru>
4091
4092 * completed VL functionality
4093
40941999-09-06 Kunihiro Ishiguro <kunihiro@zebra.org>
4095
4096 * ospf_asbr.c: New file.
4097 ospf_asbr.h: New file.
4098
4099 * ospf_zebra.c (ospf_redistribute_connected): Add redistribute
4100 related stuff.
4101
41021999-09-05 Kunihiro Ishiguro <kunihiro@zebra.org>
4103
4104 * ospfd.h (OSPF_FLAG_VIRTUAL_LINK): Change OSPF_FLAG_VEND to
4105 OSPF_FLAG_VIRTUAL_LINK for comprehensiveness.
4106
41071999-09-03 Kunihiro Ishiguro <kunihiro@zebra.org>
4108
4109 * ospf_spf.c (ospf_spf_register): Change name from
4110 ospf_spf_route_add() to ospf_spf_register().
4111 Include "ospfd/ospf_abr.h" for ospf_abr_task() prototype.
4112
41131999-09-02 Kunihiro Ishiguro <kunihiro@zebra.org>
4114
4115 * ospf_lsa.c (ospf_external_lsa_install): Change to update
4116 lsa->data rather than install new one, when same id lsa is already
4117 installed.
4118
41191999-09-01 Kunihiro Ishiguro <kunihiro@zebra.org>
4120
4121 * ospf_lsa.c (ospf_router_lsa_install): Return lsa value.
4122 (ospf_network_lsa_install): Likewise.
4123 (ospf_summary_lsa_install): Likewise.
4124 (ospf_summary_asbr_lsa_install): Likewise.
4125 (ospf_external_lsa_install): Likewise.
4126
4127 * ospf_spf.c (ospf_spf_calculate): Comment out debug function
4128 ospf_rtrs_print().
4129
41301999-08-31 Kunihiro Ishiguro <kunihiro@zebra.org>
4131
4132 * ospf_spf.c (ospf_rtrs_free): Add ospf_spf_calculate() for
4133 freeing rtrs.
4134
41351999-08-31 Toshiaki Takada <takada@zebra.org>
4136
4137 * ospf_lsa.c (show_ip_ospf_database_summary),
4138 (show_ip_ospf_database_summary_asbr),
4139 (show_ip_ospf_database_external): New function added.
4140 `show ip ospf database summary',
4141 `show ip ospf database asbr-summary'
4142 `show ip ospf database external' command can be used.
4143
4144 * ospf_lsa.c (ospf_lsa_count_table): New function added.
4145 (show_ip_ospf_database_all): show nothing if a type of LSA
4146 does not exist.
4147
41481999-08-31 Kunihiro Ishiguro <kunihiro@zebra.org>
4149
4150 * ospf_lsa.c (ospf_maxage_lsa_remover): Preserve next pointer when
4151 the node is deleted.
4152
41531999-08-31 Toshiaki Takada <takada@zebra.org>
4154
4155 * ospf_flood.c (ospf_ls_retransmit_lookup): change to return
4156 struct ospf_lsa *.
4157 (ospf_ls_request_new), (ospf_ls_request_free),
4158 (ospf_ls_request_add), (ospf_ls_request_delete),
4159 (ospf_ls_request_delete_all), (ospf_ls_request_lookup):
4160 New function added.
4161
4162 * ospf_packet.c (ospf_ls_upd_send_lsa): New function added.
4163
4164 * ospf_lsa.h (LS_AGE): Slightly change macro definition.
4165
4166 * ospf_lsa.c (ospf_lsa_more_recent), (ospf_lsa_diffrent):
4167 Use LS_AGE macro.
4168
41691999-08-30 Alex Zinin <zinin@amt.ru>
4170
4171 * ospfd.c
4172 fix a bug with area range config write
4173 added "show ip ospf" command, it will be enhanced later on
4174
41751999-08-30 Alex Zinin <zinin@amt.ru>
4176
4177 * ospf_lsa.c
4178 updated ospf_router_lsa() to honor flags (B-bit)
4179
41801999-08-30 Alex Zinin <zinin@amt.ru>
4181
4182 * ospf_abr.c
4183 wrote major functions implementing ABR activity
4184
41851999-08-30 Alex Zinin <zinin@amt.ru>
4186
4187 * ospf_ia.c ospf_route.c ospf_route.h
4188 fixed the bug with ospf_route.origin field.
4189 Now it holds pointer to lsa_header
4190
41911999-08-30 Alex Zinin <zinin@amt.ru>
4192
4193 * ospf_flood.c ospf_flood.h:
4194 transformed ospf_flood_if_select into ospf_flood_through_area()
4195 added new ospf_flood_if_select() and ospf_flood_through_as()
4196
41971999-08-30 Toshiaki Takada <takada@zebra.org>
4198
4199 * ospf_flood.[ch]: New file added.
4200
4201 * ospf_packet.c (ospf_lsa_flooding),
4202 (ospf_lsa_flooding_select_if): functions move to ospf_flood.c
4203
4204 * ospf_neighbor.c (ospf_put_lsa_on_retransm_list),
4205 (ospf_remove_lsa_from_retransm_list),
4206 (ospf_nbr_remove_all_lsas_from_retransm_list),
4207 (ospf_lsa_remove_from_ls_retransmit):
4208 (ospf_lsa_retransmit): functions move to
4209 ospf_flood.c, and change function's name:
4210
4211 ospf_put_lsa_on_retransm_list ()
4212 -> ospf_ls_retransmit_add ()
4213 ospf_remove_lsa_from_retransm_list ()
4214 -> ospf_ls_retransmit_delete ()
4215 ospf_nbr_remove_all_lsas_from_retransm_list ()
4216 -> ospf_ls_retransmit_clear ()
4217 ospf_lsa_remove_from_ls_retransmit ()
4218 -> ospf_ls_retransmit_delete_nbr_all ()
4219 ospf_lsa_retransmit ()
4220 -> ospf_ls_retransmit_add_nbr_all ()
4221
4222 * ospf_lsa.c (ospf_lsa_lookup_from_list): function move to
4223 ospf_flood.c, and change name to ospf_ls_retransmit_lookup ().
4224
42251999-08-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4226
4227 * ospf_neighbor.c (ospf_nbr_lookup_by_addr): Use
4228 route_node_lookup() instead of route_node_get().
4229
4230 * ospf_packet.c (ospf_ls_upd): Temporary comment out (6) check.
4231
42321999-08-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4233
4234 * ospf_route.c (ospf_lookup_int_by_prefix): Add check of
4235 oi->address.
4236
42371999-08-29 Alex Zinin <zinin@amt.ru>
4238 * ospf_lsa.c
4239 MaxAge LSA deletion functions added.
4240
42411999-08-29 Alex Zinin <zinin@amt.ru>
4242 * ospf_neighbor.c
4243 ospf_nbr_lookup_by_addr(): added route_unlock_node()
4244 when function returns NULL if (rn->info == NULL)
4245
42461999-08-29 Alex Zinin <zinin@amt.ru>
4247 * ospfd.c
4248 added a hack for area range deletion
4249
42501999-08-29 Alex Zinin <zinin@amt.ru>
4251 * ospf_lsa.h
4252 included lsdb field into struct ospf_lsa, to find
4253 LSDB easier when removing MaxAge LSAs.
4254
42551999-08-29 Alex Zinin <zinin@amt.ru>
4256 * ospf_lsa.c ospf_neighbor.c ospf_nsm.c
4257 ospf_packet.c changed to honor new retransmit list
4258 management functions
4259
42601999-08-29 Alex Zinin <zinin@amt.ru>
4261 * ospf_neighbor.c , .h added new retransmit list functions.
4262
42631999-08-29 Alex Zinin <zinin@amt.ru>
4264 * Makefile.in
4265 added ospf_ase, ospf_abr, ospf_ia
4266
42671999-08-29 Alex Zinin <zinin@amt.ru>
4268 * ospf_spf.c:
4269 - changed ospf_next_hop_calculation() to include interface
4270 and nexthop addr for directly connected routers---more informative
4271 and solves problem with route installation into the kernel
4272 - changed ospf_nexthop_out_if_addr() to support routers, not only
4273 transit networks
4274 - added ospf_process_stubs();
4275
42761999-08-29 Alex Zinin <zinin@amt.ru>
4277 * ospf_lsa.c:
4278 - changed ospf_router_lsa() to provide correct links
4279 for p-t-p interfaces;
4280 - changed ospf_summary_lsa_install() to support table
4281 of self-originated summary-LSAs;
4282 - added ospf_summary_asbr_lsa_install() and ospf_external_lsa_install()
4283 - changed ospf_lsa_install() accordingly
4284 - changed show_ip_ospf_database_router_links() to support p-t-p
4285
42861999-08-29 Kunihiro Ishiguro <kunihiro@zebra.org>
4287
4288 * ospf_packet.c (ospf_make_db_desc): Only master can clear more
4289 flag.
4290
42911999-08-29 Kunihiro Ishiguro <kunihiro@zebra.org>
4292
4293 * ospf_packet.c (ospf_read): Add check of IP src address.
4294
42951999-08-28 Alex Zinin <zinin@amt.ru>
4296 * ospf_neighbor.h
4297 added ospf_nbr_lookup_by_routerid()
4298
42991999-08-28 Alex Zinin <zinin@amt.ru>
4300 * ospfd.h
4301 added ABR/ASBR flag definitions and fields;
4302 added iflist field to area structure;
4303 summary_lsa_self and summary_lsa_asbr_self are changed
4304 to be route tables;
4305 added ranges field---configured area ranges;
4306 A separate Routers RT added;
4307 area range config commands and config write added
4308
4309
43101999-08-28 Alex Zinin <zinin@amt.ru>
4311 * ospf_route.c :
4312 ospf_route_free()--added code to free the list of paths;
4313 The following functions added:
4314 ospf_intra_add_router();
4315 ospf_intra_add_transit();
4316 ospf_intra_add_stub();
4317 the last function uses new ospf_int_lookup_by_prefix();
4318 show_ip_ospf_route_cmd()--changed to support new RT structure;
4319 added ospf_cmp_routes()--general route comparision function;
4320 added ospf_route_copy_nexthops() and ospf_route_copy_nexthops_from_vertex()
4321 they are used in ASE and IA routing;
4322 added ospf_subst_route() and ospf_add_route();
4323
43241999-08-28 Alex Zinin <zinin@amt.ru>
4325 * ospf_route.h :
4326 changed struct ospf_path to include output interface,
4327 changed struct ospf_route to support IA and ASE routing.
4328 added prototypes of the function used in IA and ASE modules.
4329
43301999-08-28 Alex Zinin <zinin@amt.ru>
4331 * ospf_lsa.h ospf_lsa.c :
4332 added ospf_my_lsa(), an interface independent version of
4333 ospf_lsa_is_self_originated(), it will be used in ASE and IA-routing.
4334
43351999-08-27 Kunihiro Ishiguro <kunihiro@zebra.org>
4336
4337 * ospf_interface.c (interface_config_write): Add check for
4338 oi->nbr_self.
4339
43401999-08-25 Toshiaki Takada <takada@zebra.org>
4341
4342 * ospf_lsa.c (ospf_lsa_dup): New function added.
4343
4344 * ospf_packet.c (ospf_write), (ospf_read): Print send/recv
4345 interface in debug message.
4346
43471999-08-25 Toshiaki Takada <takada@zebra.org>
4348
4349 * ospf_packet.c (ospf_ls_ack_send): The name is changed from
4350 `ospf_ls_ack_send'.
4351 (ospf_ls_ack_send_delayed) (ospf_ls_ack_timer): New function added.
4352 Delayed Link State Acknowledgment is scheduled by timer.
4353
43541999-08-25 Alex Zinin <zinin@amt.ru>
4355
4356 * ospf_lsa.c (ospf_router_lsa): Incorrectly included link to
4357 a stub network instead of link to a transit network into
4358 originated router-LSA, bug fixed.
4359
43601999-08-24 Toshiaki Takada <takada@zebra.org>
4361
4362 * ospfd.c (ospf_update_router_id): New function added.
4363
4364 * ospf_network.c (ospf_write): Create new socket per transmission.
4365 And select outgoing interface whether dst is unicast or multicast.
4366
4367 * ospf_packet.c: LSA flooding will work.
4368
43691999-08-24 VOP <vop@unity.net>
4370
4371 * ospf_route.c: Include "sockunion.h"
4372
43731999-08-24 Kunihiro Ishiguro <kunihiro@zebra.org>
4374
4375 * ospf_network.c (ospf_serv_sock_init): Enclose
4376 IPTOS_PREC_INTERNETCONTROL setting with #ifdef for OS which does
4377 not have the definition.
4378
43791999-08-23 Toshiaki Takada <takada@zebra.org>
4380
4381 * ospf_packet.c: Fix bug of DD processing.
4382
43831999-08-18 Toshiaki Takada <takada@zebra.org>
4384
4385 * ospf_lsa.c (show_ip_ospf_database): Show actual `LS age'.
4386
43871999-08-17 Toshiaki Takada <takada@zebra.org>
4388
4389 * ospf_lsa.h (OSPF_MAX_LSA): The value of OSPF_MAX_LSA is
4390 corrected. The bug of `mes_lookup' is fixed.
4391 This had been reported by Poul-Henning Kamp <phk@freebsd.org>.
4392
4393 * ospf_lsa.c (ospf_router_lsa_install): The name is changed from
4394 `ospf_add_router_lsa'.
4395 (ospf_network_lsa_install): The name is changed from
4396 `ospf_add_network_lsa'.
4397
4398 * ospf_interface.h (ospf_interface): Add member `nbr_self'.
4399
4400 * ospf_interface.c (ospf_if_is_enable): New function added.
4401
44021999-08-16 Toshiaki Takada <takada@zebra.org>
4403
4404 * ospf_lsa.h (struct lsa_header): The name is changed from
4405 `struct ospf_lsa'.
4406 (struct ospf_lsa): New struct added to control each LSA's aging
4407 and timers.
4408
4409 * ospf_lsa.c (ospf_lsa_data_free): The name is change from
4410 `ospf_lsa_free'.
4411 (ospf_lsa_data_new), (ospf_lsa_new), (ospf_lsa_free),
4412 (ospf_lsa_different), (ospf_lsa_install): New function added.
4413
4414 * ospf_packet.c (ospf_ls_upd_list_lsa): New function added.
4415
44161999-08-12 Toshiaki Takada <takada@zebra.org>
4417
4418 * ospf_nsm.c (nsm_reset_nbr): New function added.
4419 KillNbr and LLDown neighbor event call this function.
4420
44211999-08-10 Toshiaki Takada <takada@zebra.org>
4422
4423 * ospf_packet.c (ospf_ls_retransmit)
4424 (ospf_ls_upd_timer): New function added.
4425 Set retransmission timer for Link State Update.
4426
44271999-07-29 Toshiaki Takada <takada@zebra.org>
4428
4429 * ospf_ism.c (ospf_dr_election): Fix bug of DR election.
4430
44311999-07-28 Toshiaki Takada <takada@zebra.org>
4432
4433 * ospf_network.c (ospf_serv_sock_init): Set IP precedence field
4434 with IPTOS_PREC_INTERNET_CONTROL.
4435
4436 * ospf_nsm.c (nsm_change_status): Schedule NeighborChange event
4437 if NSM status change.
4438
4439 * ospf_packet.c (ospf_make_hello): Never include a neighbor in
4440 Hello packet, when the neighbor goes down.
4441
44421999-07-26 Kunihiro Ishiguro <kunihiro@zebra.org>
4443
4444 * Makefile.am (noinst_HEADERS): Add ospf_route.h.
4445
4446 * ospf_route.c (show_ip_ospf_route): Add `show ip ospf route'
4447 command.
4448
44491999-07-25 Toshiaki Takada <takada@zebra.org>
4450
4451 * ospf_lsa.c (ospf_router_lsa): Fix bug of LS sequence number
4452 assignement.
4453
44541999-07-25 Kunihiro Ishiguro <kunihiro@zebra.org>
4455
4456 * ospf_route.c (ospf_route_table_free): New function added.
4457
4458 * ospf_spf.c (ospf_spf_next): Free vertex w when cw's and w's
4459 distance is same.
4460
4461 * ospfd.h (struct ospf): Add old_table.
4462
4463 * ospf_main.c (sighup): Call of log_rotate () removed.
4464
4465 * ospf_lsa.c (ospf_lsa_is_self_originated): Fix bug of checking
4466 area->lsa as self LSA. This should be area->lsa_self.
4467
44681999-07-24 Kunihiro Ishiguro <kunihiro@zebra.org>
4469
4470 * ospf_zebra.c (ospf_zebra_add): ospf_zebra_add
4471 (),ospf_zebra_delete () added.
4472
4473 * ospf_spf.c (ospf_spf_calculate): Call ospf_intra_route_add ().
4474
44751999-07-24 Toshiaki Takada <takada@zebra.org>
4476
4477 * ospf_lsa.c: Change LS sequence number treatment.
4478 (ospf_lsa_is_self_originated): New function added.
4479 (show_ip_ospf_database_self_originated): New DEFUN added.
4480
44811999-07-23 Kunihiro Ishiguro <kunihiro@zebra.org>
4482
4483 * ospf_interface.c (ospf_if_lookup_by_addr): Add loopback check.
4484
44851999-07-22 Toshiaki Takada <takada@zebra.org>
4486
4487 * ospf_spf.c (ospf_nexthop_new), (ospf_nexthop_free),
4488 (ospf_nexthop_dup): function added.
4489 (ospf_nexthop_calculation): function changed.
4490
4491 * ospf_interface.c (ospf_if_lookup_by_addr): function added.
4492
44931999-07-21 Toshiaki Takada <takada@zebra.org>
4494
4495 * ospf_spf.c (ospf_spf_closest_vertex): function removed.
4496
44971999-07-21 Kunihiro Ishiguro <kunihiro@zebra.org>
4498
4499 * ospf_spf.c (ospf_spf_next): Apply ntohs for fetching metric.
4500
45011999-07-21 Toshiaki Takada <takada@zebra.org>
4502
4503 * ospf_neighbor.c (ospf_nbr_lookup_by_router_id): fundtion removed.
4504
4505 * ospf_lsa.c (show_ip_ospf_database_router): describe each
4506 connected link.
4507
45081999-07-21 Kunihiro Ishiguro <kunihiro@zebra.org>
4509
4510 * ospf_spf.c (ospf_spf_next): V is router LSA or network LSA so
4511 change behavior according to LSA type.
4512 (ospf_lsa_has_link): Link check function is added.
4513
45141999-07-20 Kunihiro Ishiguro <kunihiro@zebra.org>
4515
4516 * ospf_spf.c (ospf_spf_calculate_schedule): Add new function for
4517 SPF calcultion schedule addtition.
4518 (ospf_spf_calculate_timer_add): Rough 30 sec interval SPF calc
4519 timer is added.
4520 (ospf_spf_next_router): Delete ospf_spf_next_network ().
4521
4522 * ospf_lsa.c (show_ip_ospf_database_all): Network-LSA display
4523 header typo correction. Display of router LSA's #link added.
4524
45251999-07-19 Toshiaki Takada <takada@zebra.org>
4526
4527 * ospf_packet.c (ospf_check_network_mask): Added new function for
4528 receiving Raw IP packet on an appropriate interface.
4529
45301999-07-16 Toshiaki Takada <takada@zebra.org>
4531
4532 * ospfd.c (ospf_router_id): new DEFUN added.
4533
45341999-07-15 Toshiaki Takada <takada@zebra.org>
4535
4536 * ospf_spf.c (ospf_spf_init), (ospf_spf_free),
4537 (ospf_spf_has_vertex), (ospf_vertex_lookup),
4538 (ospf_spf_next_router), (ospf_spf_next_network),
4539 (ospf_spf_closest_vertex), (ospf_spf_calculate):
4540 function added.
4541
45421999-07-13 Toshiaki Takada <takada@zebra.org>
4543
4544 * ospf_ism.c: fix bug of DR Election.
4545
4546 * ospf_nsm.c: fix bug of adjacency forming.
4547
45481999-07-05 Kunihiro Ishiguro <kunihiro@zebra.org>
4549
4550 * ospfd.c (ospf_init): Change to use install_default.
4551
45521999-07-01 Rick Payne <rickp@rossfell.co.uk>
4553
4554 * ospf_zebra.c (zebra_init): Install standard commands to
4555 ZEBRA_NODE.
4556
45571999-06-30 Toshiaki Takada <takada@zebra.org>
4558
4559 * ospf_dump.c: Whole debug command is improved.
4560 (ISM|NSM) (events|status|timers) debug option added.
4561 (show_debugging_ospf): new DEFUN added.
4562
45631999-06-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4564
4565 * ospf_lsa.c (ospf_lsa_lookup_from_list): Change !IPV4_ADDR_CMP to
4566 IPV4_ADDR_SAME.
4567
45681999-06-29 Toshiaki Takada <takada@zebra.org>
4569
4570 * ospf_dump.c (ospf_summary_lsa_dump): Add summary-LSA dump routine.
4571 (ospf_as_external_lsa_dump): Add AS-external-LSA dump routine.
4572
4573 * ospf_nsm.c (nsm_twoway_received): fix condtion of adjacnet.
4574
4575 * ospf_ism.c (ospf_dr_election): fix DR Election.
4576
4577 * ospf_dump.c (ospf_nbr_state_message): fix `show ip ospf neighbor'
4578 command's state.
4579
45801999-06-29 Kunihiro Ishiguro <kunihiro@zebra.org>
4581
4582 * ospf_dump.c (ospf_router_lsa_dump): Add router-LSA dump routine.
4583
45841999-06-28 Toshiaki Takada <takada@zebra.org>
4585
4586 * ospf_lsa.c (show_ip_ospf_database_network): fix bug of
4587 `show ip ospf database network' command output.
4588
4589 * ospf_nsm.c (nsm_inactivity_timer): Clear list of Link State
4590 Retransmission, Database Summary and Link State Request.
4591
4592 * ospf_packet.c (ospf_ls_req_timer): New function added.
4593 Set Link State Request retransmission timer.
4594
45951999-06-27 Kunihiro Ishiguro <kunihiro@zebra.org>
4596
4597 * ospf_main.c (main): Change default output from ZLOG_SYSLOG to
4598 ZLOG_STDOUT.
4599
4600 * ospfd.c (ospf_init): Register show_ip_ospf_interface_cmd and
4601 show_ip_ospf_neighbor_cmd to VIEW_NODE.
4602
4603 * ospf_lsa.c (ospf_lsa_init): Register show_ip_ospf_database_cmd
4604 and show_ip_ospf_database_type_cmd to VIEW_NODE.
4605
46061999-06-25 Toshiaki Takada <takada@zebra.org>
4607
4608 * ospf_packet.c: fix bug of DD making.
4609 fix bug of LS-Update reading.
4610
46111999-06-23 Toshiaki Takada <takada@zebra.org>
4612
4613 * ospf_packet.c: All type of packets are changed to use
4614 fifo queue structure.
4615 (ospf_fill_header) function added.
4616
46171999-06-22 Toshiaki Takada <takada@zebra.org>
4618
4619 * ospf_packet.c (ospf_packet_new): New function added to handle
4620 sending ospf packet by fifo queue structure.
4621 (ospf_packet_free), (ospf_fifo_new), (ospf_fifo_push),
4622 (ospf_fifo_pop), (ospf_fifo_head), (ospf_fifo_flush),
4623 (ospf_fifo_free): Likewise.
4624
46251999-06-21 Toshiaki Takada <takada@zebra.org>
4626
4627 * ospf_nsm.c (ospf_db_desc_timer): function added.
4628 (nsm_timer_set) function added.
4629 * ospf_dump.c (ospf_option_dump): function added.
4630 * ospf_packet.c (ospf_ls_req) (ospf_make_ls_req): function added.
4631
46321999-06-20 Toshiaki Takada <takada@zebra.org>
4633
4634 * ospf_lsa.c (ospf_lsa_more_recent): function added.
4635 * ospf_neighbor.h (struct ospf_neighbor): Change member ms_flag
4636 to dd_flags.
4637
46381999-06-19 Toshiaki Takada <takada@zebra.org>
4639
4640 * ospf_lsa.c: DEFUN (show_ip_ospf_database) Added.
4641 * ospf_interface.c (if_ospf_cost), (if_ospf_dead_interval),
4642 (if_ospf_hello_interval), (if_ospf_priority),
4643 (if_ospf_retransmit_interval), (if_ospf_transmit_delay)
4644 argument changed from NUMBER to <range>.
4645 DEFUN (if_ospf_network_broadcast),
4646 DEFUN (if_ospf_network_non_broadcast),
4647 DEFUN (if_ospf_network_point_to_multipoint),
4648 DEFUN (if_ospf_network_point_to_point) functions are combined to
4649 DEFUN (if_ospf_network).
4650
46511999-06-18 Toshiaki Takada <takada@zebra.org>
4652
4653 * ospf_lsa.c: ospf_add_router_lsa (), ospf_add_network_lsa (),
4654 ospf_lsa_lookup (), ospf_lsa_count () Added.
4655
46561999-06-15 Toshiaki Takada <takada@zebra.org>
4657
4658 * DEFUN (ospf_debug_ism), DEFUN (ospf_debug_nsm),
4659 DEFUN (no_ospf_debug_ism), DEFUN (no_ospf_debug_nsm) Added.
4660 `debug ospf ism' command shows debug message.
4661 `debuf ospf nsm' command shows debug message.
4662
46631999-06-14 Toshiaki Takada <takada@zebra.org>
4664
4665 * ospf_lsa.c: ospf_network_lsa () Added.
4666 ospf_lsa_checksum () Added.
4667 * DEFUN (ospf_debug_packet), DEFUN (no_ospf_debug_packet) Added.
4668 `debug ospf packet' command shows debug message.
4669
46701999-06-13 Toshiaki Takada <takada@zebra.org>
4671
4672 * ospf_packet.h: Remove struct ospf_ls_req {}, ospf_ls_upd {},
4673 ospf_ls_ack {}.
4674
46751999-06-11 Toshiaki Takada <takada@zebra.org>
4676
4677 * ospf_dump.c: fix IP packet length treatment.
4678
46791999-06-10 Toshiaki Takada <takada@zebra.org>
4680
4681 * ospf_ism.h: Add OSPF_ISM_EVENT_EXECUTE() Macro Added.
4682 * ospf_nsm.h: Add OSPF_NSM_EVENT_EXECUTE() Macro Added.
4683
4684 * ospf_packet.c: ospf_db_desc (), ospf_db_desc_send () Added.
4685 ospf_make_hello (), ospf_make_db_desc () Added.
4686 ospf_db_desc_proc () Added.n
4687
4688 * Database Description packet can be processed.
4689
46901999-06-08 Toshiaki Takada <takada@zebra.org>
4691
4692 * ospf_lsa.c: New file.
4693
46941999-06-07 Toshiaki Takada <takada@zebra.org>
4695
4696 * ospf_neighbor.c: ospf_fully_adjacent_count () Added.
4697
46981999-06-07 Kunihiro Ishiguro <kunihiro@zebra.org>
4699
4700 * ospf_spf.[ch]: New file.
4701
47021999-05-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4703
4704 * ospf_zebra.c: Changed to use lib/zclient.c routines.
4705
4706 * ospf_zebra.h (zebra_start): Remove struct zebra.
4707
47081999-05-29 Kunihiro Ishiguro <kunihiro@zebra.org>
4709
4710 * ospfd.c (ospf_config_write): Add cast (unsigned long int) to
4711 ntohl for sprintf warning.
4712
47131999-05-19 Toshiaki Takada <takada@zebra.org>
4714
4715 * ospf_ism.c (ospf_dr_election): Join AllDRouters Multicast group
4716 if interface state changes to DR or BDR.
4717
47181999-05-14 Stephen R. van den Berg <srb@cuci.nl>
4719
4720 * ospf_main.c (signal_init): SIGTERM call sigint.
4721 (sigint): Logging more better message.
4722
47231999-05-12 Toshiaki Takada <takada@zebra.org>
4724
4725 * ospfd.c: Fix bug of `no router ospf' statement, it will work.
4726
47271999-05-11 Toshiaki Takada <takada@zebra.org>
4728
4729 * ospf_neighbor.c: ospf_nbr_free () Added.
4730
47311999-05-10 Toshiaki Takada <takada@zebra.org>
4732
4733 * ospfd.h: struct ospf_area { }, struct ospf_network { } Changed.
4734 * Fix bug of `no network' statement, it will work.
4735
47361999-05-07 Toshiaki Takada <takada@zebra.org>
4737
4738 * ospf_interface.c, ospf_zebra.c: Fix bug of last interface is not
4739 updated by ospf_if_update ().
4740
47411999-04-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4742
4743 * Makefile.am (noinst_HEADERS): Add ospf_lsa.h for distribution.
4744
47451999-04-25 Toshiaki Takada <takada@zebra.org>
4746
4747 * ospf_interface.c: DEFUN (no_if_ospf_cost),
4748 DEFUN (no_if_ospf_dead_interval),
4749 DEFUN (no_if_ospf_hello_interval),
4750 DEFUN (no_if_ospf_priority),
4751 DEFUN (no_if_ospf_retransmit_interval),
4752 DEFUN (no_if_ospf_transmit_delay) Added.
4753
4754 interface_config_write () suppress showing interface
4755 default values.
4756
47571999-04-25 Kunihiro Ishiguro <kunihiro@zebra.org>
4758
4759 * ospf_dump.c (ospf_timer_dump): If thread is NULL return "inactive".
4760
4761 * ospfd.c (ospf_if_update): Fix bug of using ospf_area { } instead
4762 of ospf_network { }. So `router ospf' statement in ospfd.conf
4763 works again.
4764 (ospf_if_update): Call ospf_get_router_id for updating router ID.
4765
47661999-04-25 Toshiaki Takada <takada@zebra.org>
4767
4768 * ospf_interface.c: DEFUN (if_ospf_network) deleted.
4769 DEFUN (if_ospf_network_broadcast),
4770 DEFUN (if_ospf_network_non_broadcast),
4771 DEFUN (if_ospf_network_point_to_multipoint),
4772 DEFUN (if_ospf_network_point_to_point),
4773 DEFUN (no_if_ospf_network) Added.
4774
47751999-04-23 Toshiaki Takada <takada@zebra.org>
4776
4777 * ospfd.h: struct area { } changed to struct ospf_network { }.
4778 Add struct ospf_area { }.
4779 * ospfd.c: Add ospf_area_lookup_by_area_id (), ospf_network_new (),
4780 and ospf_network_free ().
4781 DEFUN (area_authentication), DEFUN (no_area_authentication) Added.
4782
47831999-04-22 Toshiaki Takada <takada@zebra.org>
4784
4785 * ospf_lsa.h: New file.
4786 * ospf_packet.h: LSA related struct definition are moved to
4787 ospf_lsa.h.
4788 * ospf_packet.c: ospf_verify_header () Added.
4789
47901999-04-21 Toshiaki Takada <takada@zebra.org>
4791
4792 * ospf_ism.c: ospf_elect_dr () and related function is changed.
4793 DR Election bug fixed.
4794 * ospf_dump.c: ospf_nbr_state_message (), ospf_timer_dump () Added.
4795 * ospfd.c: DEFUN (show_ip_ospf_neighbor) Added.
4796
47971999-04-19 Kunihiro Ishiguro <kunihiro@zebra.org>
4798
4799 * ospf_main.c (main): access_list_init () is added for vty
4800 connection filtering.
4801
48021999-04-16 Toshiaki Takada <takada@zebra.org>
4803
4804 * ospfd.c: DEFUN (show_ip_ospf_interface) Added.
4805 * ospf_neighbor.c: ospf_nbr_count () Added.
4806
48071999-04-15 Toshiaki Takada <takada@zebra.org>
4808
4809 * ospfd.h: struct ospf { } Changed.
4810 * ospfd.c: ospf_lookup_by_process_id () Deleted.
4811 * ospf_ism.c: ospf_wait_timer () Added. WaitTimer will work.
4812
48131999-04-14 Toshiaki Takada <takada@zebra.org>
4814
4815 * ospf_ism.c: ospf_elect_dr () Added.
4816 * ospf_network.c: ospf_if_ipmulticast () Added.
4817
48181999-04-11 Toshiaki Takada <takada@zebra.org>
4819
4820 * ospf_interface.c: interface_config_write (),
4821 DEFUN (if_ip_ospf_cost),
4822 DEFUN (if_ip_ospf_dead_interval),
4823 DEFUN (if_ip_ospf_hello_interval),
4824 DEFUN (if_ip_ospf_priority),
4825 DEFUN (if_ip_ospf_retransmit_interval) and
4826 DEFUN (if_ip_ospf_transmit_delay) Added.
4827
48281999-04-08 Toshiaki Takada <takada@zebra.org>
4829
4830 * ospf_dump.c: ospf_packet_db_desc_dump () Added.
4831 * ospf_neighbor.c: ospf_nbr_bidirectional () Added.
4832 * ospf_nsm.c: nsm_twoway_received () Added.
4833
48341999-04-02 Toshiaki Takada <takada@zebra.org>
4835
4836 * ospf_neighbor.c: New file.
4837 * ospf_neighbor.h: New file.
4838 * ospf_nsm.c: New file.
4839 * ospf_nsm.h: New file.
4840 * ospf_packet.c: Add ospf_make_header (), ospf_hello () and
4841 ospf_hello_send (). Now OSPFd can receive Hello and send Hello.
4842
48431999-03-27 Kunihiro Ishiguro <kunihiro@zebra.org>
4844
4845 * ospf_packet.c: Add ospf_recv_packet (). Now OSPF Hello can receive.
4846
48471999-03-19 Toshiaki Takada <takada@zebra.org>
4848
4849 * ospf_packet.c: New file.
4850 * ospf_packet.h: New file.
4851 * ospf_network.c: New file.
4852 * ospf_network.h: New file.
4853 * ospfd.h: move OSPF message structure has moved to ospf_packet.h.
4854
48551999-03-17 Kunihiro Ishiguro <kunihiro@zebra.org>
4856
4857 * ospf_zebra.c (ospf_zebra_get_interface): Fix for IPv6 interface
4858 address.
4859
4860 * Makefile.am (install-sysconfDATA): Overwrite install-sysconfDATA
4861 for install ospfd.conf.sample as owner read only file.
4862
4863 * ospf_main.c (usage): Change to use ZEBRA_BUG_ADDRESS.
4864
48651999-03-15 Toshiaki Takada <takada@zebra.org>
4866
4867 * ospf_ism.c: New file.
4868 * ospf_ism.h: New file.
4869 * ospf_dump.c: New file.
4870 * ospf_dump.h: New file.
4871
4872 * ospfd.h: Add (struct ospf), (struct config_network),
4873 (struct message) structure.
4874
4875 * ospf_interface.c: Add ospf_if_match_network ().
4876 * ospf_interface.h (struct ospf_interface): Change struct members.
4877
4878 * ospfd.c: ospf_lookup_by_process_id (), ospf_network_new (),
4879 DEFUN (network_area): Added.
4880
4881 * ospfd.conf.sample: Change sample configuration.
4882
48831999-03-05 Toshiaki Takada <takada@zebra.org>
4884
4885 * ospf_interface.c: New file.
4886 * ospf_interface.h: New file.
4887 * ospf_zebra.h: New file.
4888 * ospf_zebra.c: Add interface function for zebra daemon.
4889 * ospfd.c: New file.
4890
48911999-02-23 Kunihiro Ishiguro <kunihiro@zebra.org>
4892
4893 * Move IPv6 codes and files to ospf6d directory.
4894
48951999-02-18 Peter Galbavy <Peter.Galbavy@knowledge.com>
4896
4897 * syslog support added
4898
48991998-12-22 Toshiaki Takada <takada@zebra.org>
4900
4901 * ospfd.h: New file.
4902 * ospf_lsa.h: New file.
4903
49041998-12-15 Kunihiro Ishiguro <kunihiro@zebra.org>
4905
4906 * Makefile.am: New file.
4907 * ospf_main.c: New file.
4908