blob: 191288e7c692d256008151d3cf75d65290949f27 [file] [log] [blame]
Andrew J. Schorr4056a542007-02-27 13:55:46 +000012007-02-27 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
2
3 * ospfd.c: (ospf_terminate) Exit immediately if ospf is not
4 actually running (e.g. the config file was empty). Fixes
5 bug where SIGTERM would not kill ospfd.
6
Paul Jakmabd34fb32007-02-26 17:14:48 +000072007-02-26 Paul Jakma <paul.jakma@sun.com>
8
9 * ospf_spf.c: Fix regression introduced with bug #330 fix: The
10 cost update added to ospf_spf_add_parent only handled PtP
11 case, differing from same functionality in higher-level
12 ospf_spf_next. Regression diagnosed by Anders Pedersen,
13 mailnews+router-quagga-dev@news.cohaesio.com.
14 (ospf_vertex_new) Initialise vertices to max-cost.
15 (ospf_spf_init) Root vertex always creates with 0 cost.
16 (ospf_spf_add_parent) Remove the buggy V->W cost calculating
17 code, instead take the new distance as a parameter.
18 (ospf_nexthop_calculation) Take distance as parameter, so it
19 can be passed down to add_parent.
20 (ospf_spf_next) Dont initialise candiate vertex distance,
21 vertex_new does so already. Pass distance down to
22 nexthop_calculation (see above).
23
Paul Jakmabc20c1a2007-01-24 14:51:51 +0000242007-01-24 Paul Jakma <paul.jakma@sun.com>
25
26 * ospf_spf.c: Bug #330: Nexthop calculation sometimes may fail,
27 and it needs to indicate this result to SPF.
28 (ospf_spf_add_parent) Flush of parent list needs to be done here,
29 for simplicity.
30 (ospf_nexthop_calculation) Caller needs to know whether
31 nexthop calculation succeeded. Every return statement must
32 correctly indicate such.
33 (ospf_spf_next) Queueing/prioritisation of vertices in SPF
34 must take into account whether nexthop_calculation succeeded,
35 or SPF may fail to find best paths.
36
Andrew J. Schorre4529632006-12-12 19:18:21 +0000372006-12-12 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
38
39 * ospf_interface.c: (ospf_if_is_configured, ospf_if_lookup_by_prefix,
40 ospf_if_lookup_recv_if) Simplify logic using new CONNECTED_PREFIX
41 macro.
42 * ospf_lsa.c: (lsa_link_ptop_set) Using the new CONNECTED_PREFIX
43 macro, both options collapse into the same code.
44 * ospf_snmp.c: (ospf_snmp_if_update) Simplify logic using new
45 CONNECTED_ID macro.
46 (ospf_snmp_is_if_have_addr) Simplify logic using new CONNECTED_PREFIX
47 macro.
48 * ospf_vty.c: (show_ip_ospf_interface_sub) Use new CONNECTED_PEER macro
49 instead of testing the IFF_POINTOPOINT flag.
50 * ospfd.c: (ospf_network_match_iface) Use new CONNECTED_PEER macro
51 instead of testing with if_is_pointopoint. And add commented-out
52 code to implement alternative (in my opinion) more elegant behavior
53 that has no special-case treatment for PtP addresses.
54 (ospf_network_run) Use new CONNECTED_ID macro to simplify logic.
55
Andrew J. Schorred589c12006-12-04 18:26:37 +0000562006-12-04 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
57
58 * ospfd.c: (ospf_network_run) Remove an offending 'break' statement.
59 Previously, after creating a single ospf_interface on a given
60 network interface, the code would skip to the next interface
61 without considering other connected addresses on the interface.
62 After removing the 'break', we now consider all connected addresses.
63
Andrew J. Schorr7f643eb2006-11-30 16:17:02 +0000642006-11-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
65
66 * ospf_zebra.c: (ospf_router_id_update_zebra,
67 ospf_interface_address_add, ospf_interface_address_delete)
68 If (IS_DEBUG_OSPF (zebra, ZEBRA_INTERFACE)) is enabled, then
69 add a debug message about what Zebra is telling us.
70 (ospf_zebra_add_discard) Add a debug message matching the one
71 already in ospf_zebra_delete_discard.
72
Andrew J. Schorr43540882006-11-28 16:36:39 +0000732006-11-28 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
74
75 * ospf_vty.c: (ospf_passive_interface_default) Take additional
76 'newval' arg so we can update ospf->passive_interface_default inside
77 this function. More importantly, we now call ospf_if_set_multicast
78 on all ospf_interfaces.
79 (ospf_passive_interface, no_ospf_passive_interface) Fix bug:
80 for 'default' case, argv[0] is undefined, so we must test for
81 (argc == 0) before using argv[0]. And since
82 ospf_passive_interface_default now calls ospf_if_set_multicast as
83 needed, we can just return after calling
84 ospf_passive_interface_default.
85
Andrew J. Schorr8fb8a502006-10-24 19:04:26 +0000862006-10-24 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
87
88 * ospf_zebra.c: (ospf_redistribute_default_set) Fix bug where
89 a new value for ospf->default_originate was being ignored
90 if a previous 'default-information originate' command
91 had already been processed.
92
Paul Jakma7ffa8fa2006-10-22 20:07:53 +0000932006-10-22 Yar Tikhiy <yar@comp.chem.msu.su>
94
95 * (general) Add support for passive-interface default (with
96 minor edits by Paul Jakma).
97 * ospf_interface.h: Add OSPF_IF_PASSIVE_STATUS macro, looking
98 at configured value, or the global 'default' value, as
99 required.
100 * ospf_interface.c: (ospf_if_new_hook) Leave passive
101 unconfigured per default, allowing global 'default' to
102 take effect for unconfigured interfaces.
103 * ospf_packet.c: (various) use OSPF_IF_PASSIVE_STATUS
104 * ospf_vty.c: (ospf_passive_interface_default) new function,
105 unset passive from all interfaces if default is enabled, as
106 the per-iface settings become redundant.
107 (ospf_passive_interface_update) new func, update passive
108 setting taking global default into account.
109 ({no,}ospf_passive_interface_addr_cmd) Add support for
110 'default' variant of command.
111 (show_ip_ospf_interface_sub) Update to take global
112 default into account when printing passive status.
113 (ospf_config_write) ditto.
114 * ospfd.c: (ospf_new) set global passive-interface default.
115 * ospfd.h: (struct ospf) Add field for global
116 passive-interface.
117
Andrew J. Schorr08c83672006-09-25 13:26:14 +00001182006-09-25 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
119
120 * ospf_packet.c: (ospf_packet_dup, ospf_make_md5_digest)
121 Fix zlog_warn messages to eliminate compiler warnings.
122 (ospf_hello) Improve warning messages to show why we
123 are complaining.
124
Paul Jakmab5aeb442006-08-30 18:47:37 +00001252006-08-28 Andy Gay <andy@andynet.net>
126
127 * ospf_packet.c: (ospf_make_db_desc) Assert added with More-bit
128 fixes does not hold up with addition of Ogier DB-Exchange
129 optimisation, which can empty the db-summary list in between
130 sent DD packets. Remove assert, update More-bit always when
131 in Exchange.
132
Paul Jakma29b5a042006-08-27 08:01:20 +00001332006-08-27 J.J. Krabbendam <jkrabbendam@aimsys.nl>
134
135 * ospfd.c: (ospf_finish_final) default redistribute should be
136 unset too, fixes bug where reconfiguring ospfd completely
137 can no longer enable default redistribution.
138
Paul Jakma2518efd2006-08-27 06:49:29 +00001392006-08-25 Paul Jakma <paul.jakma@sun.com>
140
141 * (general) Bug #134. Be more robust to backward time changes,
142 use the newly added libzebra time functions.
143 In most cases: recent_time -> recent_relative_time()
144 gettimeofday -> quagga_gettime (QUAGGA_CLK_MONOTONIC, ..)
145 time -> quagga_time.
146 (ospf_make_md5_digest) time() call deliberately not changed.
147 (ospf_external_lsa_refresh) remove useless gettimeofday, LSA
148 tv_orig time was already set in ospf_lsa_new, called via
149 ospf_external_lsa_new.
150
Paul Jakmaba122e72006-08-27 06:24:34 +00001512006-08-04 Paul Jakma <paul.jakma@sun.com>
152
153 * ospf_lsdb.c: (ospf_lsdb_delete_entry) new function, consolidate
154 exact same functionality replicated in other functions.
155 (ospf_lsdb_add) Strip out code by using ospf_lsdb_delete_entry.
156 (ospf_lsdb_delete) ditto.
157 (ospf_lsdb_delete_all) ditto.
158
Paul Jakma8dd24ee2006-08-27 06:29:30 +00001592006-08-03 Paul Jakma <paul.jakma@sun.com>
160
161 * ospf_packet.c: (ospf_make_db_desc) Unset the DD More bit
162 after constructing the packet, if appropriate.
163 (ospf_db_desc_proc) Speed up Exchange, slave should raise
164 ExchangeDone earlier, as RFC mandates, by forming its reply
165 before deciding whether both sides are done, avoids a
166 needless round of empty DD packet exchanges at the end of
167 Exchange, hence speeding up ExchangeDone.
Paul Jakmaf0894cf2006-08-27 06:40:04 +0000168 Implement draft-ogier-ospf-dbex-opt DB-exchange optimisation.
Paul Jakma8dd24ee2006-08-27 06:29:30 +0000169 (ospf_db_desc) use UNSET_FLAG macro.
170
Andrew J. Schorr16700082006-07-27 22:29:06 +00001712006-07-27 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
172
173 * ospfd.c: (ospf_router_id_update) Fix and document the algorithm for
174 selecting the router ID: if there is not a statically configured ID,
175 then stick to the most recent value to avoid disruptive changes.
176 This should fix bug #288.
177
Paul Jakma1fe6ed32006-07-26 09:37:26 +00001782006-07-26 Paul Jakma <paul.jakma@sun.com>
179
180 * ospf_lsa.{c,h}: (ospf_lsa_unlock) Change to take a double pointer
181 to the LSA to be 'unlocked', so that, if the LSA is freed, the
182 callers pointer to the LSA can be NULLed out, allowing any further
183 use of that pointer to provoke a crash sooner rather than later.
184 * ospf_*.c: (general) Adjust callers of ospf_lsa_unlock to match
185 previous. Try annotate 'locking' somewhat to show which 'locks'
186 are protecting what LSA reference, if not obvious.
187 * ospf_opaque.c: (ospf_opaque_lsa_install) Trivial: remove useless
188 goto, replace with return.
189 * ospf_packet.c: (ospf_make_ls_ack) Trivial: merge two list loops,
190 the dual-loop predated the delete-safe list-loop macro.
191
Paul Jakma3fed4162006-07-25 20:44:12 +00001922006-07-25 Paul Jakma <paul.jakma@sun.com>
193
194 * ospf_neigbor.h: (struct ospf_neighbor) Add some additional
195 neighbour state statistics fields, timestamps for progressive
196 and regressive state changes, and pointer to event string
197 for the latter state change.
198 * ospf_nsm.c: (nsm_notice_state_change) Update new state changs
199 history as required.
200 * ospf_vty.c: (show_ip_ospf_neighbor_detail_sub) Print out above
201 new per-neighbour state change stats.
202
Paul Jakma539e1522006-07-11 17:49:22 +00002032006-07-10 Paul Jakma <paul.jakma@sun.com>
204
205 * ospf_nsm.c: (nsm_change_state) call nsm_clear_adj for all
206 adjacency losses, hence removing need for nsm_reset_nbr.
207 (nsm_reset_nbr) kill it, clear_adj in previous does fine.
208 (nsm_kill_nbr,nsm_start) remove nsm_reset_nbr call.
209 (ospf_nsm_event) Allow NSM function to be NULL, this along with
210 removal of nsm_reset_nbr, allows a bunch of now useless functiosn
211 to be removed.
212 Remove some useless variables.
213 (nsm_ignore) now useless, remove.
214 (nsm_bad_ls_req) ditto
215 (nsm_seq_number_mismatch) "
216 (nsm_oneway_received) "
217 (nsm_inactivity_timer) "
218 (nsm_ll_down) "
219 (NSM) replace removed action functions with NULL.
Paul Jakma3d63f382006-07-11 17:52:53 +0000220 (nsm_notice_state_changes) Move state change logging code to new
221 func to declutter nsm_change_state and ospf_nsm_event.
222 Log event with AdjChange, it's useful to know.
223 (nsm_change_state) move adjchange and snmp logging to previous.
224 (ospf_nsm_event) call nsm_notice_state_changes from here.
225 Move the debug message to entry of function, so it gets out
226 even if something goes wrong.
Paul Jakma90c33172006-07-11 17:57:25 +0000227 Record state change timestamp and event in nbr struct.
228 * ospf_neighbor.h: (struct ospf_neighbor) Add fields to record
229 timestamp of last NSM change and event.
230 * ospf_vty.c: (show_ip_ospf_neighbor_detail_sub) Print
231 last state change timestamp and event, if available.
Paul Jakma539e1522006-07-11 17:49:22 +0000232
Andrew J. Schorr13cd3dc2006-07-11 01:50:30 +00002332006-07-10 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
234
235 * ospf_packet.c: (ospf_hello) Improve NetworkMask mismatch warning
236 message to include interface name and conflicting prefix lengths.
237
Paul Jakma1f2c2742006-07-10 07:45:13 +00002382006-07-07 Paul Jakma <paul.jakma@sun.com>
239
240 * ospf_nsm.h: Add a NSM_Deleted neighbour state, to act as dummy
241 state indicating the neighbour is to be deleted.
242 * ospf_nsm.c: (general) Use the NSM_Deleted state to delete
243 neighbours, thus allowing code to be slightly more obvious
244 in its flow.
245 (nsm_timer_set) Add NSM_Deleted. Add another timer the code
246 missed.
247 (nsm_kill_nbr) No need for special case call to nsm_change_state
248 anymore.
249 Make the assert and error-handling for same case more readable
250 (Andrew Schorr)
251 Remove the call to ospf_nbr_delete, nsm_change_state can do
252 this generally now via NSM_Deleted.
253 (struct ... NSM) Add the dummy NSM_Deleted state, the 3 events
254 that can lead to nsm_kill_nbr all now transition the NBR to
255 NSM_Deleted and the general change_state function can be left
256 to do the work.
257 (ospf_nsm_event) Special casing of events and early-return can
258 be removed now.
259 On transition into Deleted, delete the nbr.
260 * ospf_dump.c: (ospf_nsm_state_msg) Add Deleted.
261
Paul Jakmaaa2737a2006-07-06 11:12:39 +00002622006-07-06 Paul Jakma <paul.jakma@sun.com>
263
264 * ospf_nsm.c: (ospf_nsm_event) LLDown event also results in nbr
265 being deleted, requires early-return too. Likely explains
266 some crash reports after interface events.
267
Paul Jakmaf7a76ab2006-07-04 13:57:49 +00002682006-07-04 Paul Jakma <paul.jakma@sun.com>
269
270 * ospf_nsm.c: (general) Various small cleanups from Andrew's
271 review of last set of patches.
272 (nsm_timer_set) Loading, Full and default can share
273 same code too.
274 (nsm_should_adj) Can just be one big OR.
275 (nsm_twoway_received) Collapse into return statement.
276
Paul Jakmad7b0fb62006-07-04 13:35:24 +00002772006-07-02 Paul Jakma <paul.jakma@sun.com>
278
279 * ospf_nsm.c: (nsm_should_adj) New function, just consolidate the
280 10.4 adjacency check from nsm_twoway_received/nsm_adj_ok.
281 (nsm_twoway_received/nsm_adj_ok) Use former.
Paul Jakmad1b1cd82006-07-04 13:50:44 +0000282 (nsm_clear_adj) clear adjacency related state for a
283 neighbour, needed for some state changes from > ExStart down
284 to ExStart or less, which need not go through nsm_reset_nbr.
285 (nsm_reset_nbr) move code to former. Should be static.
Paul Jakmaba0beb42006-07-04 13:44:19 +0000286 (ospf_nsm_event) Don't allow action functions to change
287 next_state if the NSM tables do not indicate next_state is
288 conditional, log warning if one tries - existing code
289 appears fine though.
Paul Jakmad1b1cd82006-07-04 13:50:44 +0000290 Remove long dead code.
291 Use nsm_clear_adj for state changes that take down
292 adjacencies to TwoWay/ExStart.
Paul Jakmae55dd532006-07-04 13:46:14 +0000293 (nsm_timer_set) ls_req timer should be OFF in early states.
294 Compact several identical sections.
295 Set inactivity timer to OFF for Down, for documentary
296 purposes.
Paul Jakmad1b1cd82006-07-04 13:50:44 +0000297 (nsm_kill_nbr) Oops, action function shouldn't try return
298 1 for error.
Paul Jakma5db95bc2006-07-04 13:52:29 +0000299 * ospf_lsa.c: (ospf_translated_nssa_refresh) CID #13.
Paul Jakmad7b0fb62006-07-04 13:35:24 +0000300
Andrew J. Schorr1c066bf2006-06-30 16:53:47 +00003012006-06-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
302
303 * ospf_vty.c: (show_ip_ospf_neighbor_id) Should show all instances
304 of that neighbor (since it may appear on multiple interfaces)
305 instead of bailing out after showing the first match.
306
Andrew J. Schorr76947872006-06-30 03:21:05 +00003072006-06-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
308
309 * ospf_nsm.c: (nsm_twoway_received) When deciding whether to
310 change from state Init to ExStart, the test for whether the
311 neighboring router is DR or BDR should be against the
312 local router's notion of DR/BDR, not the neighbor's view.
313
Andrew J. Schorrd7e60dd2006-06-29 20:20:52 +00003142006-06-28 Erik Muller <erikm@internap.com>
315
316 * ospfd.h: Define 2 new struct ospf config flags:
317 OSPF_LOG_ADJACENCY_CHANGES and OSPF_LOG_ADJACENCY_DETAIL
318 * ospf_nsm.c (nsm_change_state): Log adjacency changes if
319 requested.
320 * ospf_vty.c (ospf_log_adjacency_changes): New command function
321 to implement ospf subcommand "log-adjacency-changes [detail]".
322 (no_ospf_log_adjacency_changes) Turn off log-adjacency-changes.
323 (show_ip_ospf) Show whether adjacency changes are logged.
324 (ospf_config_write) Add "log-adjacency-changes [detail]" to config.
325 (ospf_vty_init) Add ospf_log_adjacency_changes and
326 no_ospf_log_adjacency_changes.
327
Paul Jakma9560fa82006-06-26 12:50:06 +00003282006-06-26 Paul Jakma <paul.jakma@sun.com>
329
330 * ospf_abr.c: (general) NSSA translate-candidate ABRs need to
331 be ASBRs, or other routers may rightfully refuse to install
332 translated type-5s LSAs. reported by dendroot@gmail.com.
333 (ospf_abr_nssa_check_status) Detect change in translator
334 state when ABR, and inc/dec redistribute count as when we
335 leave/enter the disabled state - so that translate-enabled
336 ABR properly sets ASBR bit on non-NSSA areas.
337 Run the resulting function through indent to clean it up.
338 * ospf_lsa.c: (router_lsa_flags) For purposes of ASBR bit,
339 NSSA area is same as stub area.
340
Andrew J. Schorr0ffb7092006-06-24 19:40:13 +00003412006-06-24 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
342
Andrew J. Schorr9aecfae2006-06-24 20:05:02 +0000343 * ospf_snmp.c: (ospfTrapNbrStateChange, ospfTrapIfStateChange) Improve
344 info log message to indicate why the trap is being sent.
345
3462006-06-24 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
347
Andrew J. Schorr0ffb7092006-06-24 19:40:13 +0000348 * ospf_dump.c: (config_write_debug) Fix typo to show debug ospf nsm
349 status properly (not ism status).
350
Andrew J. Schorr6e72cb62006-06-18 00:45:48 +00003512006-06-17 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
352
353 * ospf_vty.c: ({no_,}ospf_passive_interface) Replace if_lookup_by_name
354 with a call to if_get_by_name -- if the interface does not exist
355 already, it should be created. And remove the obsolete warning
356 message.
357
Paul Jakma429ac782006-06-15 18:40:49 +00003582006-06-15 Paul Jakma <paul.jakma@sun.com>
359
360 * ospf_interface.h: (struct ospf_if_info) Add reference counts
361 for multicast group memberships. Add various macros to help
362 manipulate/check membership state.
363 * ospf_interface.c: (ospf_if_set_multicast) Maintain the
364 ospf_if_info reference counts, and only actually drop
365 memberships if it hits 0, to avoid losing membership when
366 OSPF is disabled on an interface with multiple active OSPF
367 interfaces.
368 * ospf_packet.c: (ospf_{hello,read}) Use the new macros to
369 check/set
370 multicast membership.
371 * ospf_vty.c: (show_ip_ospf_interface_sub) ditto.
372
Paul Jakmaac904de2006-06-15 12:04:57 +00003732006-05-31 Paul Jakma <paul.jakma@sun.com>
374
375 * ospf_lsdb.c: (ospf_lsdb_delete) robustify against NULL arguments,
376 print warning.
377 * ospf_lsa.c: (ospf_discard_from_db) ditto.
378 (ospf_maxage_lsa_remover) Check lsa->lsdb for validity, possible
379 mitigation (but not solution) for bug #269.
380
Paul Jakma88871b12006-06-15 11:41:19 +00003812006-05-30 Paul Jakma <paul.jakma@sun.com>
382
383 * ospf_packet.c: (ospf_read) Debug message about packets
384 received on unenabled interfaces should be conditional on
385 debug being set.
386
Paul Jakmad1c65c22006-06-27 08:01:43 +00003872006-05-23 Paul Jakma <paul.jakma@sun.com>
388
389 * ospf_vty.c: (general) Replace in-place route redistribution
390 command and help strings with the new auto-generated defines
391 from lib/route_types.h
392
Paul Jakmaae128052006-05-12 23:15:30 +00003932006-05-13 Paul Jakma <paul.jakma@sun.com>
394
395 * ospf_lsa.c: (ospf_translated_nssa_refresh) fix the sanity
396 check to match the assert, small error in CID #13 fix.
397
Paul Jakma70461d72006-05-12 22:57:57 +00003982006-05-12 Paul Jakma <paul.jakma@sun.com>
399
400 * ospf_lsa.c: (ospf_lsa_action) Get rid of the ospf_lookup
401 call, which is not checked for NULL return, by stripping out
402 functionality which is never used, hence fixing Coverity CID
403 #29.
404 (struct lsa_action) remove unused member.
Paul Jakmae54e6e52006-05-12 23:11:14 +0000405 (ospf_translated_nssa_refresh) Add non-assert sanity check,
406 in case DEBUG isn't defined.
407 Debug message when no type7 exists should print the ID from
408 the type5, not the type7, fixes CID #13.
409 * ospf_interface.c: (ospf_if_exists) Fix missing NULL return
Paul Jakmae43be0e2006-05-12 23:00:06 +0000410 check on ospf_lookup, CID #27.
Paul Jakma6db3a6f2006-05-12 23:02:46 +0000411 * ospf_asbr.c: (ospf_redistribute_withdraw) remove ospf_lookup
412 call by taking the struct ospf * as argument, which the
413 caller has, fixing CID #28.
414 * ospf_asbr.h: (ospf_redistribute_withdraw) update declaration
415 * ospf_zebra.c: (ospf_redistribute_unset) update call to
416 ospf_redistribute_withdraw to match.
Paul Jakmabfd7c7d2006-05-12 23:04:45 +0000417 * ospf_ia.c: (ospf_update_router_route) ospf->backbone could be
418 NULL when passed to ospf_find_asbr_route_through_area,
419 check for NULL first, CID #14.
Paul Jakmadeb15612006-05-12 23:07:27 +0000420 * ospf_ism.c: (ism_change_state) NULL check on oi->area is
421 useless, it's always valid. Only possibility where it
422 couldn't be is if there is a race between abr_task and
423 cleaning up oi's, in which case a NULL check here isn't going
424 to do anything. Fixes CID #15.
Paul Jakma70461d72006-05-12 22:57:57 +0000425
Paul Jakmacac3b5c2006-05-11 13:31:11 +00004262006-05-11 Paul Jakma <paul.jakma@sun.com>
427
428 * ospf_vty.c: (general) Audit ospf_lookup calls in commands,
429 ensure check for NULL result, make vty messages consistent.
430 (show_ip_ospf_interface) Missing NULL check on ospf_lookup
431 result, fixes Coverity CID #70.
Paul Jakma1a8ec2b2006-05-11 13:34:08 +0000432 (no_ospf_area_filter_list) Check NULL result from
433 ospf_area_lookup_by_area_id, fixes Coverity CID #69
Paul Jakma894f8b62006-05-12 22:50:40 +0000434 * ospf_route.c: (ospf_route_delete_same_ext) Fix deref before
435 NULL check by moving into check-protected block, fix CID #49.
Paul Jakma214a4452006-05-12 22:51:49 +0000436 * ospf_abr.c: (ospf_area_range_cost_set) Shouldn't create a new
437 range, should just lookup to see if one exists, the new range
438 is just leaked. Fixes CID #46.
Paul Jakma4021b602006-05-12 22:55:41 +0000439 * ospf_lsa.c: (ospf_default_originate_timer) Let the thread
440 take (struct ospf *) as thread argument, rather than (struct
441 ospf *)->default_originate, thus avoiding having to call
442 ospf_lookup.
443 * ospf_zebra.c: (ospf_redistribute_default_set) change setup
444 of ospf_default_originate_timer thread to match.
445 * ospfd.c: (ospf_router_id_update) ditto.
Paul Jakmacac3b5c2006-05-11 13:31:11 +0000446
Paul Jakma9c27ef92006-05-04 07:32:57 +00004472006-04-24 Paul Jakma <paul.jakma@sun.com>
448
449 * (general) More Virtual-link fixes, again with much help in
450 testing / debug from Juergen Kammer. Primarily in SPF.
451 * ospf_spf.h: Add guard. ospf_interface.h will include this
452 header.
453 * ospf_interface.h: Modify ospf_vl_lookup definition to take
454 struct ospf as argument, so as to allow for NULL area
455 argument.
456 (struct ospf_vl_data) Remove out_oi, instead add a struct
457 vertex_nexthop, to use as initial nexthop for backbone paths
458 through a vlink.
459 * ospf_interface.c: (ospf_vl_lookup) Modified to allow
460 NULL area to be passed to indicate "any" (first) area.
461 Add extra debug.
462 (ospf_vl_set_params) vl_oi -> nexthop. Add extra debug.
463 (ospf_vl_up_check) Fix debug, inet_ntoa returns a static
464 buffer..
465 * ospf_route.c: (ospf_intra_add_router) Vlinks dont go through
466 backbone, don't bother checking.
467 * ospf_spf.c: (static struct list vertex_list) Record vertices
468 that will need to be freed.
469 (cmp) Order network before router vertices, as required,
470 wasn't implemented.
471 (vertex_nexthop_free) Mild additional robustness check.
472 (vertex_parent_free) Take void argument, as this function
473 is passed as list deconstructor for vertex parent list.
474 (ospf_vertex_new) More debug. Set deconstructor for parent
475 list. Track allocated vertices on the vertex_list.
476 (ospf_vertex_free) Get rid of the tricky recursive cleanup of
477 vertices. Now frees only the given vertex.
478 (ospf_vertex_add_parent) Fix assert.
479 (ospf_nexthop_calculation) Fix calculation of nexthop for
480 VLink vertices, lookup the vl_data and use its previously
481 recorded nexthop information.
482 (ospf_spf_calculate) Vertices are freed simply by deleting
483 vertex_list nodes and letting ospf_vertex_free as deconstructor
484 work per-node.
485 (ospf_spf_calculate_timer) Trivial optimisation, leave
486 backbone SPF calculation till last to reduce SPF churn on
487 VLink updates.
488 * ospf_vty.c: (ospf_find_vl_data) update call to ospf_vl_lookup
489 (no_ospf_area_vlink_cmd) ditto.
490 (show_ip_ospf_interface_sub) For Vlinks, the peer address is
491 more interesting than the output interface.
492
Paul Jakma478aab92006-04-03 21:25:32 +00004932006-04-03 Paul Jakma <paul.jakma@sun.com>
494
495 * (general) Fix issues with handling of Vlinks and entries
496 in the nbrs route-table which were highlighted by the
497 nsm/nbr_self fixes from bug #234. Many thanks to Juergen
498 Kammer for his help and efforts in testing out debug patches to
499 pinpoint the issue.
500 * ospf_interface.c: (ospf_vl_new) Add nbr_self for Vlink.
501 * ospf_neighbor.c: (ospf_nbr_key) new static function, helper
502 to create key in nbrs table for a given nbr.
503 (ospf_nbr_delete) Use ospf_nbr_key. Add an assert() to
504 document an expected state.
505 (ospf_nbr_add_self) Ditto.
506 (ospf_nbr_lookup_by_addr) Add an assert.
507 * ospf_nsm.c: (nsm_kill_nbr) Can never kill the nbr_self
508 psuedo-neighbour.
509
Paul Jakma075c2012006-03-30 14:34:31 +00005102006-03-27 Paul Jakma <paul.jakma@sun.com>
511
512 * ospf_lsa.c: (ospf_lsa_checksum) Add an explicit cast to avoid
513 the ambiguities of ANSI and C99 C with respect to type
514 conversion. Detailed problem report and test case with
515 example data supplied by Dmitry Ivanov <dimss@telecentrs.lv>.
516
Paul Jakma1a8ee0e2006-03-30 14:20:00 +00005172006-03-25 Paul Jakma <paul.jakma@sun.com>
518
519 * ospf_interface.c: (ospf_if_lookup_recv_if) Ignore loopbacks,
520 we can never ever receive packets on those. Should fix
521 case where CARP is run with address in same subnet as real
522 interface. Problem report and diagnosis thanks to:
523 Landon Fuller <landonf@opendarwin.org>.
524 However, ospf_read() still can't deal deterministically with
525 multiple interfaces in same subnet.
526
Paul Jakmac2b478d2006-03-30 14:16:11 +00005272006-03-23 Steve Lawson <steve.lawson@aheadcomusa.com>
528
529 * ospf_lsa.c: (ospf_lsa_install) Fix incorrect byte-order
530 conversion of OSPF_MAX_SEQUENCE_NUMBER
531
paule8e19462006-01-19 20:16:55 +00005322006-01-19 Paul Jakma <paul.jakma@sun.com>
533
534 * (general) various miscellaneous compiler warning fixes.
535 Remove redundant break statements from switch clauses
536 which return.
537 return from main, not exit, cause it annoys SOS.
538 Remove stray semi-colons which cause empty-statement
539 warnings.
540
paul779adb02006-01-18 15:07:38 +00005412006-01-18 Juergen Kammer <j.kammer@eurodata.de>
542
543 * ospf_lsa.c: (ospf_router_lsa_new) dont take reference to the
544 stream data until it is constructed, data reference is
545 volatile due to the potential resize in link_info_set
546
5472006-01-18 Paul Jakma <paul.jakma@sun.com>
548
549 * ospf_lsa.c: (link_info_set) Resize the stream if required and
550 possible. Return number of links added.
551 (lsa_link_*_set) use return value from previous.
552 * ospf_lsa.h: Add OSPF_ROUTER_LSA_LINK_SIZE define.
553
paulc6371712006-01-17 17:49:53 +00005542006-01-17 Paul Jakma <paul.jakma@sun.com>
555
556 * ospf_packet.c: (ospf_verify_header) print out the types
557 involved if there's a mismatch.
558 * ospf_zebra.c: (ospf_zebra_add) Adjust to new zserv format.
559
paul818e56c2006-01-10 23:27:05 +00005602006-01-10 Len Sorensen <lennartsorensen@ruggedcom.com>
561
562 * (general) Bug #234, see also [quagga-dev 3902].
563 Fix problem with nbr_self not being properly reinitialised
564 when an interface comes up, after having been down.
paul1a643f82006-01-11 01:08:19 +0000565 Some re-arrangement done by Paul Jakma, any bugs introduced
566 on top of Len's suggested changes are his.
paul818e56c2006-01-10 23:27:05 +0000567 * ospf_neighbor.c: (ospf_nbr_add_self) centralise
568 initialisation of nbr_self parameters here.
569 * ospf_interface.c: (ospf_if_new) deleting initialisation of
570 parameters of nbr_self, just rely on call to
571 ospf_nbr_add_self.
572 (ospf_if_cleanup) ditto.
573 * ospfd.c: (ospf_network_run) ditto.
574
paul98429f62006-01-10 22:11:54 +00005752006-01-10 Juris Kalnins <juris@mt.lv>
576
577 * ospf_zebra.c: (ospf_interface_address_delete) fix rare leak of
578 struct connected in an error case.
paul818e56c2006-01-10 23:27:05 +0000579 * ospf_packet.c: (ospf_make_md5_digest) fix odd, if not
580 undefined effect, assignment of an increment expression.
paul98429f62006-01-10 22:11:54 +0000581
paul86752842006-01-10 20:34:46 +00005822006-01-10 Paul Jakma <paul.jakma@sun.com>
583
584 * ospfd.c: (ospf_network_run) checking to see if router-id
585 is set should be on ospf->router_id, not router_id_static.
586 This was causing ospfd to not start if router-id had not
587 been configured statically.
588 (ospf_if_update) ditto.
paulc42c1772006-01-10 20:36:49 +0000589 * ospf_vty.c: (config_write_ospf_distribute) trim down
590 redundant strings.
paul86752842006-01-10 20:34:46 +0000591
paul00c290e2005-11-26 09:21:43 +00005922005-11-26 Paul Jakma <paul.jakma@sun.com>
593
594 * ospf_api.c: (struct opaque_lsa) change from gcc zero-length
595 array to C99 incomplete type array.
paulc9c93d52005-11-26 13:31:11 +0000596 * (general) s/graceful/deferred/ in all files, the former term
597 is confusing wrt OSPF Graceful-Restart.
598 * ospfd.c: (ospf_deferred_shutdown_check) dont return
599 a function which returns void. SOS complains about this.
600 (ospf_finish)
paul00c290e2005-11-26 09:21:43 +0000601
paulb29800a2005-11-20 14:50:45 +00006022005-11-20 Paul Jakma <paul.jakma@sun.com>
603
604 * ospfd.h: remove the OSPF_ROUTER_ID_UPDATE_DELAY define
605 (struct ospf) remove the router_id timer thread.
606 remove export of ospf_router_id_update_timer.
607 * ospfd.c: (ospf_router_id_update) call ospf_if_update to
608 poke interfaces into action after ID has been configured.
609 (ospf_router_id_update_timer) removed.
610 (ospf_finish_final) t_router_id_update timer is gone.
611 (ospf_network_run) router-id update timer gone.
612 call ospf_router_id_update directly if ID not configured.
613 In the per-iface loop, don't ospf_if_up interfaces if
614 ID is still not configured. The update function will call
615 ospf_if_update anyway.
616 (ospf_if_update) ID update timer is gone. Just return if no
617 ID is set.
618 * ospf_vty.c: (ospf_router_id) call ospf_router_id_update, no
619 timer needed.
620 * ospf_zebra.c: (ospf_router_id_update_zebra) call
621 ospf_router_id_update directly, not via timer.
paulc24d6022005-11-20 14:54:12 +0000622 * ospf_abr.c: (ospf_abr_announce_network_to_area) check
623 returned LSA of ospf_summary_lsa_refresh and print warning if
624 it failed.
625 (ospf_abr_announce_network_to_area) similar
626 (ospf_abr_announce_rtr_to_area) similar
627 * ospf_lsa.c: (ospf_router_lsa_new) check LSA returned is valid.
628 (ospf_router_lsa_originate) similar
629 (ospf_router_lsa_refresh, ospf_network_lsa_new) similar
630 (ospf_summary_lsa_new) Check ID is valid.
631 (ospf_summary_lsa_originate) ditto, and check returned LSA from
632 previous function is !NULL.
633 (ospf_summary_lsa_refresh) check ospf_summary_lsa_new return
634 is !NULL.
635 (ospf_summary_asbr_lsa_new) ID valid check.
636 (ospf_summary_asbr_lsa_originate) similar.
paulb29800a2005-11-20 14:50:45 +0000637
ajs70cd3472005-11-16 19:33:22 +00006382005-11-16 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
639
ajs649654a2005-11-16 20:17:52 +0000640 * ospf_dump.h: Define OSPF_TIME_DUMP_SIZE as appropriate buffer size
641 for use with ospf_timer_dump and ospf_timeval_dump.
642 * ospf_vty.c: Change all buffer sizes used with ospf_timer_dump and
643 ospf_timeval_dump to have size OSPF_TIME_DUMP_SIZE.
644 (show_ip_ospf_interface_sub) Fix possible buffer overflow in
645 call to ospf_timer_dump.
646
6472005-11-16 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
648
ajs70cd3472005-11-16 19:33:22 +0000649 * ospf_ism.h: (OSPF_ISM_TIMER_OFF) Improve macro syntax by enclosing
650 in 'do {...} while(0)'.
651
paul31a59762005-11-14 11:11:11 +00006522005-11-14 Paul Jakma <paul.jakma@sun.com>
653
654 * ospfd.c: (ospf_new) stub-shutdown should just default to
655 unconfigured, too strange otherwise.
656 (ospf_finish_final) t_opaque_lsa_self TIMER_OFF should be
657 preprocessor conditional on HAVE_OPAQUE_LSA.
658 * ospfd.h: (struct ospf) remove the SHUTDOWN_DEFAULT define.
659 no longer used, plus it wasn't in range that the command
660 accepted.
661 * ospf_zebra.h: Depends on vty.h, include it.
662
paul58e1bef2005-11-11 12:10:03 +00006632005-11-11 Paul Jakma <paul.jakma@sun.com>
664
665 * ospf_spf.c: (ospf_canonical_nexthops_free) Free only
666 the nexthops pointing to the root vertex. We may visit a
667 vertex twice or the vertex may have some inherited nexthops,
668 if we free other nexthops we could crash.
669
paulc8c15212005-11-04 12:31:39 +00006702005-11-04 Paul Jakma <paul.jakma@sun.com>
671
672 * ospf_{dump,spf,vty}.c: Oops, use the internal tv_sub
673 function rather than unportable timersub.
674
paul484315f2005-11-03 09:08:29 +00006752005-11-03 Paul Jakma <paul.jakma@sun.com>
676
677 * ospf_apiserver.c: (apiserver_sync_callback) stray semi-colon
678 * ospf_packet.c: include checksum.h, remove the in_cksum extern
679 * prototypes.
680 * ospf_te.h: Add braces, quell warning.
paul6d452762005-11-03 11:15:44 +0000681 * ospf_packet.c: Change level of some warnings to
682 informational.
paulc8c15212005-11-04 12:31:39 +0000683
paul88d6cf32005-10-29 12:50:09 +00006842005-10-29 Paul Jakma <paul.jakma@sun.com>
685
686 * (general) RFC3137 stub-router support
687 * ospfd.h: Add OSPF_OUTPUT_COST_INFINITE define.
688 (struct ospf_master) Add a OSPF_MASTER_SHUTDOWN flag for
689 options, to allow shutdown to distinguish between complete
690 shutdown and shutdown of a subset of ospf instances.
691 (struct ospf)
692 Add stub_router_{startup,shutdown_}time, configuration of startup
693 and shutdown time for stub-router.
694 Add t_graceful_shutdown struct thread, timer for graceful
695 shutdown, if needed.
696 (struct ospf_area) Add stub_router_state - run time state of
697 stub-router for an area. Add flags for ADMIN, IS and WAS
698 states.
699 Add t_stub_router, timer thread to resend router-lsa for an
700 area.
701 * ospf_lsa.c: (ospf_link_cost) new simple function to spit out
702 either the given lnks cost or infinite cost if stub-router is
703 in effect.
704 (lsa_link_{ptop,broadcast,virtuallink,ptomp}_set) use
705 previous function for transit-links.
706 (ospf_stub_router_timer) timer thread for end of startup stub
707 router. Change state as required for the area and setup
708 re-origination of router-lsa.
709 (ospf_stub_router_check) Check/do whether stub-router should be
710 enabled, and whether it requires timer to be setup.
711 (ospf_router_lsa_new) call previous function at top.
712 (ospf_router_lsa_originate) no external callers, made static.
713 * ospf_lsa.h: (ospf_router_lsa_originate) removed.
714 * ospf_main.c: (sigint) make static.
715 remove call to exit, as ospf_terminate now deals with
716 exiting.
717 * ospf_route.c: (ospf_terminate) removed, now in ospfd.c.
718 * ospf_vty.c: (show_ip_ospf_area) print out state of
719 stub-router, if active.
720 (show_ip_ospf) print out configuration of stub-router
721 support, and details of graceful-shutdown if the timer is
722 active.
723 ((no)?ospf_max_metric_router_lsa_{admin,startup,shutdown}) new
724 commands to (de-)?configure stub-router support.
725 (config_write_stub_router) write out config of stub-router.
726 (ospf_config_write) call previous.
727 (ospf_vty_init) install the new stub-router commands.
728 * ospfd.c: various functions made static.
729 (ospf_new) Set defaults for stub-router. Graceful shutdown
730 is made to default on, just to be adventerous.
731 (ospf_graceful_shutdown_finish) new function, final part of
732 shutdown.
733 (ospf_graceful_shutdown_timer) timer thread wrapper for
734 graceful-shutdown.
735 (ospf_graceful_shutdown_check) check whether to setup timer
736 for shutdown or proceed directly to final shutdown.
737 (ospf_terminate) moved here from ospf_route.c, call
738 ospf_finish for each instance.
739 (ospf_finish) renamed to ospf_finish_final and made static.
740 (ospf_finish) new function, exported wrapper around
741 ospf_graceful_shutdown_check.
742 (ospf_finish_final) complete shutdown of an instance.
743 Add missing TIMER_OFF's of two timer threads.
744 (ospf_area_free) opaque self lsa timer should be turned off.
745
paulb8ad39d2005-10-23 15:23:05 +00007462005-10-23 Paul Jakma <paul.jakma@sun.com>
747
paule029d442005-10-23 15:26:24 +0000748 * ospf_apiserver.c: (ospf_apiserver_term) This function should
749 not have side-effects (eg segv) if no apiserver instances are
750 active, ie be robust.
paulb8ad39d2005-10-23 15:23:05 +0000751 * ospf_vty.c: (show_ip_ospf) fix display of SPF timer if it
752 has not yet been run.
753
paulf9ad9372005-10-21 00:45:17 +00007542005-10-21 Paul Jakma <paul.jakma@sun.com>
755
paulea4ffc92005-10-21 20:04:41 +0000756 * ospf_dump.c: (ospf_timeval_dump) fix ms adjustment, thanks to
757 Andrew Schorr.
758 * ospf_vty.c: (ospf_config_write) fix write out of spf timers
759 configuration.
760
7612005-10-21 Paul Jakma <paul.jakma@sun.com>
762
pauld24f6e22005-10-21 09:23:12 +0000763 * (general) SPF millisecond resolution timer with adaptive,
764 linear back-off holdtime. Prettification of ospf_timer_dump.
765 * ospf_dump.c: (ospf_timeval_dump) new function. The guts of
766 ospf_timer_dump, but made to be more dynamic in printing out
767 the relative timeval, sliding the precision printed out
768 according to the value.
769 (ospf_timer_dump) guts moved to ospf_timeval_dump.
770 * ospf_dump.h: export ospf_timeval_dump.
771 * ospf_flood.c: (ospf_flood) remove gettimeofday, use
772 the libzebra exported recent_time instead, as it's not
773 terribly critical to have time exactly right - the dropped
774 LSA will be retransmited to us if we don't ACK it.
775 * ospf_packet.c: (ospf_ls_upd_timer) Ditto, but here we're
776 not transmitting, just putting LSA back on update transmit list.
777 * ospfd.h: delay and holdtimes should be unsigned.
778 Add spf_max_holdtime and spf_hold_multiplier.
779 Update default defines for delay and hold time to be in msec.
780 (struct ospf) change the SPF timestamp to a struct timeval.
781 Remove ospf_timers_spf_(un)?set.
782 * ospfd.c: (ospf_timers_spf_{set,unset}) removed.
783 (ospf_new) initialise spf_max_holdtime and spf_hold_multiplier
784 * ospf_spf.c: (ospf_spf_calculate) SPF timestamp is a timeval
785 now, update with gettimeofday.
786 (ospf_spf_calculate_schedule) Change SPF timers to millisecond
787 resolution.
788 Make the holdtime be adaptive, with a linear increase in
789 holdtime ever consecutive SPF run which occurs within holdtime
790 of previous SPF, bounded by spf_max_holdtime.
791 * ospf_vty.c: Update spf timers commands.
792 (ospf_timers_spf_set) trivial helper.
793 (ospf_timers_throttle_spf_cmd) new command to set SPF delay,
794 initial hold and max hold times with millisecond resolution.
795 (ospf_timers_spf_cmd) Deprecated. Accept the old values,
796 convert to msec, truncate to new limits.
797 (no_ospf_timers_throttle_spf_cmd) set timers to defaults.
798 (no_ospf_timers_spf_cmd) deprecated form, same as previous.
799 (show_ip_ospf_cmd) Display SPF parameters and times.
800 (show_ip_ospf_neighbour_header) Centralise the 'sh ip os ne'
801 header.
802 (show_ip_ospf_neighbor_sub) Fix the field widths. Get rid of
803 the multiple spaces which were making the lines even longer.
804 (show_ip_ospf_neighbor_cmd) Use show_ip_ospf_neighbour_header
805 (show_ip_ospf_neighbor_all_cmd) ditto and fix the field
806 widths for NBMA neighbours.
807 (show_ip_ospf_neighbor_int) Use header function.
808 (show_ip_ospf_nbr_nbma_detail_sub) use sizeof for timebuf,
809 local array - safer.
810 (show_ip_ospf_neighbor_detail_sub) ditto
811 (ospf_vty_init) install the new SPF throttle timer commands.
812
8132005-10-21 Paul Jakma <paul.jakma@sun.com>
814
paulf9ad9372005-10-21 00:45:17 +0000815 * (general) OSPF fast, sub-second hello and 1s dead-interval
816 support.
817 * ospf_dump.c: (ospf_timer_dump) Print out milliseconds too.
818 Callers typically specify a length of 9, so most see
819 millisecs unless they specify the additional length.
820 * ospf_interface.h: (struct ospf_interface) new interface param,
821 fast_hello.
822 * ospf_interface.c: (ospf_if_table_lookup) add brackets,
823 gcc warning fix.
824 (ospf_new_if_params) Initialise fast_hello param.
825 (ospf_free_if_params) Check whether fast_hello is configured.
826 (ospf_if_new_hook) set fast_hello to default.
827 * ospf_ism.h: Wrap OSPF_ISM_TIMER_ON inside do {} while (0) to
828 prevent funny side-effects from its if statement when this
829 macro is used conditionally by other macros.
830 (OSPF_ISM_TIMER_MSEC_ON) new macro, set in milliseconds.
831 (OSPF_HELLO_TIMER_ON) new macro to set hello timer according
832 to whether fast_hello is set.
833 * ospf_ism.c: Update all setting of the hello timer to use
834 either OSPF_ISM_TIMER_MSEC_ON or OSPF_HELLO_TIMER_ON. The
835 former is used when hello is to be sent immediately.
836 * ospf_nsm.c: ditto
837 * ospf_packet.c: (ospf_hello) hello-interval is not checked
838 for mismatch if fast_hello is set.
839 (ospf_read) Annoying nit, fix "no ospf_interface" to be debug
840 rather than a warning, as it can be perfectly normal to
841 receive packets when logical subnets are used.
842 (ospf_make_hello) Set hello-interval to 0 if fast-hellos are
843 configured.
844 * ospf_vty.c: (ospf_auto_cost_reference_bandwidth) annoying
845 nit, don't vty_out if this command is given, it gets tired
846 quick.
847 (show_ip_ospf_interface_sub) Print the hello-interval
848 according to whether fast-hello is set or not.
849 Print the extra 5 millisec characters from (ospf_timer_dump)
850 if fast-hello is configured.
851 (ospf_vty_dead_interval_set) new function, common to all
852 forms of dead-interval command, to set dead-interval and
853 fast-hello correctly. If a dead-interval is given, unset
854 fast-hello, else if a hello-multiplier is set, set
855 dead-interval to 1 and fast-hello to given multiplier.
856 (ip_ospf_dead_interval_addr_cmd) use
857 ospf_vty_dead_interval_set().
858 (ip_ospf_dead_interval_minimal_addr_cmd) ditto.
859 (no_ip_ospf_dead_interval) Unset fast-hello.
860 (no_ip_ospf_hello_interval) Bug-fix, unset of hello-interval
861 should set it to OSPF_HELLO_INTERVAL_DEFAULT, not
862 OSPF_ROUTER_DEAD_INTERVAL_DEFAULT.
863 (config_write_interface) Write out fast-hello.
864 (ospf_config_write) Write a comment about
865 "auto-cost reference-bandwidth" having to be equal on all
866 routers. Hopefully just as noticeable as old practice of
867 writing to vty, but less annoying.
868 (ospf_vty_if_init) install the two new dead-interval
869 commands.
870 * ospfd.h: Add defines for OSPF_ROUTER_DEAD_INTERVAL_MINIMAL
871 and OSPF_FAST_HELLO_DEFAULT.
872
pauleb3da6d2005-10-18 04:20:33 +00008732005-10-18 Paul Jakma <paul.jakma@sun.com>
874
875 * (general) SPF memory management cleanup and fix for rare
876 double-free bug.
877 * ospf_spf.h: (struct vertex_parent) New struct to hold parent
878 specific data, eg the backlink and the parent vertex pointer,
879 and point to the appropriate general struct vertex_nexthop.
880 (struct vertex_nexthop) remove parent vertex pointer, so
881 this struct can be shared across vertices.
882 (struct vertex) rename list child to list children. Remove
883 list of nexthops, replace with list of vertex_parents.
884 * ospf_spf.c: (update_stat) trivial, remove cast from void *.
885 (vertex_nexthop_new) remove init of parent - field is gone
886 from struct vertex_nexthop.
887 (ospf_canonical_nexthops_free) Remove the canonical
888 vertex_nexthop memory objects. These are the vertex_nexthops
889 attached to the first level of router vertices from the root.
890 (vertex_parent_new) new function, create a vertex_parent.
891 (vertex_parent_free) ditto, but free it.
892 (ospf_vertex_new) Update to match changes to struct vertex.
893 (ospf_vertex_free) Recursively free a struct vertex and its
894 children. The parent list is used as a reference count.
895 vertex_nexthops must be free seperately, if required.
896 (ospf_vertex_dump) update to match struct vertex changes.
897 Print out backlink of parents too.
898 (ospf_vertex_add_parent) ditto.
899 (ospf_lsa_has_link) update comment.
900 (ospf_nexthop_add_unique) removed, not needed anymore.
901 (ospf_nexthop_merge) ditto.
902 (ospf_spf_consider_nexthop) renamed to ospf_spf_add_parent.
903 Simplified to just create vertex_parent and add it.
904 (ospf_spf_flush_parents) new function, flush out the parent
905 list.
906 (ospf_nexthop_calculation) Take the relevant route_lsa_link
907 as an argument, which simplifies things and removes the need
908 for the hack in ospf_nexthop_add_unique - ospf_spf_next
909 already knew exactly which link the cost calculated was for.
910 Update to match struct vertex changes too.
911 (ospf_spf_next) Don't create a vertex for W unnecessarily, if
912 it's there's a vertex already created for W, use it, and
913 hence there's no need to free it either.
914 Update some manipulation/comparisons of distance to match.
915 Flush the parent list if a lower cost path is found.
916 (ospf_spf_route_free) unused, removed.
917 (ospf_spf_dump) match the struct vertex changes, and dump the
918 ifname if possible.
919 (ospf_spf_calculate) At end of SPF, free the canonical nexthops
920 and call ospf_vertex_free on the root vertex to free the
921 entire tree.
922 * ospf_interface.c: (ospf_vl_set_params) match struct vertex
923 changes.
924 * ospf_route.c: (ospf_intra_route_add) ditto
925 (ospf_route_copy_nexthops_from_vertex) ditto
926
paul36238142005-10-11 04:12:54 +00009272005-10-11 Paul Jakma <paul.jakma@sun.com>
928
929 * ospf_api.c: sign warnings.
930 * ospf_apiserver.c: sign warning and convert all the struct
931 in_addr initialisations so as not to make assumptions about
932 how this struct is organised, initialise the s_addr member
933 explicitely.
934 * ospf_packet.c: Add const qualifier to auth_key.
935
vincent77df1f72005-10-06 07:46:22 +00009362005-10-06 Alain Ritoux <alain.ritoux@6wind.com>
937
938 * ospf_snmp.c: Avoid mixing interface and ospf_interface objects
939 which now allows snmpwalk to work with ospfIfTable and
940 also with ospfIfMetricTable
941
ajsf52d13c2005-10-01 17:38:06 +00009422005-10-01 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
943
944 * ospf_dump.c: Remove local hard-coded table ospf_redistributed_proto.
945 (ospf_redist_string) New function implemented using new library
946 function zebra_route_string(). Note that there are a few differences
947 in the output that will result: the new function returns strings
948 that are lower-case, whereas the old table was mixed case. Also,
949 the old table mapped ZEBRA_ROUTE_OSPF6 to "OSPFv3", whereas the
950 new function returns "ospf6".
951 * ospfd.h: Remove extern struct message ospf_redistributed_proto[],
952 and add extern const char *ospf_redist_string(u_int route_type)
953 instead.
954 * ospf_asbr.c: (ospf_external_info_add) In two messages, use
955 ospf_redist_string instead of LOOKUP(ospf_redistributed_proto).
956 * ospf_vty.c: Remove local hard-coded table distribute_str.
957 (config_write_ospf_redistribute,config_write_ospf_distribute): Use
958 new library function zebra_route_string() instead of distribute_str[].
959 * ospf_zebra.c: (ospf_redistribute_set,ospf_redistribute_unset,
960 ospf_redistribute_default_set,ospf_redistribute_check)
961 In debug messages, use ospf_redist_string() instead of
962 LOOKUP(ospf_redistributed_proto).
963
jardin6638c1a2005-10-01 00:08:54 +00009642005-09-30 Vincent Jardin <vincent.jardin@6wind.com>
965
966 * ospf_dump.c, ospf_ia.c, ospf_spf.c, ospf_ase.c:
967 remove unused DEBUG
968
vincentba682532005-09-29 13:52:57 +00009692005-09-29 Alain Ritoux <alain.ritoux@6wind.com>
970
vincent5e4914c2005-09-29 16:34:30 +0000971 * ospf_ism.c: generate SNMP traps on Interface state change
972 * ospf_nsm.c: generate SNMP traps on Neighbour state change
973 * ospf_snmp.[ch]: support for SNMP traps for interface and neighbours.
974
9752005-09-29 Alain Ritoux <alain.ritoux@6wind.com>
976
vincentba682532005-09-29 13:52:57 +0000977 * ospf_vty.c: forece default route LSA to be re_issued whenever
978 cost is changed ( [no] ip ospf area XXX default-cost YYY)
979 Support ignore-mtu option
980 * ospfd.h: define OSPF_MTU_IGNORE_DEFAULT
981 * ospf_packet.c: support ignore-mtu option
982 * ospf_interface.h: field added for skipping MTU check
983 * ospf_interface.c: fix memory leak in ospf_crypt_key_delete()
984 Set mtu_ignore field to default value
985 * ospf_abr.[ch]: export ospf_abr_announce_network_to_area()
986 * ospf_ism.h: add MACRO to convert internal ISM status into SNMP
987 correct values
988 * ospf_snmp.c: add sanity check on LSA type in lsdb_lookup_next()
989 convert OSPFIFSTATE internal status into SNMP values
990
vincentc1a03d42005-09-28 15:47:44 +00009912005-09-28 Alain Ritoux <alain.ritoux@6wind.com>
992
993 * ospf_packet.c: use new md5 API
994
ajs5339cfd2005-09-19 13:28:05 +00009952005-09-19 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
996
997 * ospf_lsa.h: (ospf_external_lsa_flush) Comment out the 5th argument
998 (nexthop) since it is not used in the function (except inside
999 some commented-out code).
1000 * ospf_lsa.c: (ospf_external_lsa_flush,ospf_external_lsa_refresh)
1001 Comment out the 5th argument to ospf_external_lsa_flush.
1002 * ospf_asbr.c: (ospf_redistribute_withdraw) Comment out 5th arg
1003 to ospf_external_lsa_flush.
1004 * ospf_vty.c: (no_ospf_default_information_originate) Eliminate 5th
1005 uninitialized nexthop arg to ospf_external_lsa_flush.
1006 * ospf_zebra.c: (ospf_zebra_read_ipv4) Comment out 5th arg
1007 to ospf_external_lsa_flush.
1008 * ospfd.c: (ospf_network_set) Comment out 5th arg
1009 to ospf_external_lsa_flush.
1010
ajse6a0bf92005-09-17 18:53:38 +000010112005-09-17 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1012
1013 * ospf_opaque.c:
1014 (ospf_opaque_lsa_refresh_schedule,ospf_opaque_lsa_flush_schedule)
1015 No need to call ospf_lookup(), just use lsa0->area->ospf instead.
1016
hassobb5b7552005-08-21 20:01:15 +000010172005-08-21 Hasso Tepper <hasso at quagga.net>
1018
1019 * ospf_vty.c: Make "show ip ospf neighbor xxx" commands work.
1020 Interface should be specified by name now.
1021
hasso54bedb52005-08-17 13:31:47 +000010222005-08-17 Hasso Tepper <hasso at quagga.net>
1023
1024 * ospf_vty.c: Check carefully if interface exists before trying to
1025 print info about it.
1026
hasso01018ce2005-08-05 07:40:15 +000010272005-08-05 Hasso Tepper <hasso at quagga.net>
1028
1029 * ospf_zebra.c: Don't assert/stop before type == ZEBRA_ROUTE_MAX if
1030 dealing with routemaps. There is ospf->route_map[ZEBRA_ROUTE_MAX]
1031 for default-information.
1032
paulc8987752005-07-26 06:07:22 +000010332005-07-26 Paul Jakma <paul.jakma@sun.com>
1034
1035 * ospf_abr.c: (ospf_abr_announce_network_to_area) SET_FLAG
1036 should be on lsa not old, which may be freed for one thing,
1037 obviously.
1038
pauld57834f2005-07-12 20:04:22 +000010392005-07-12 Paul Jakma <paul.jakma@sun.com>
1040
1041 * ospfd.h: add OSPF_ABR_DEFAULT for convenience, make
1042 OSPF_ABR_CISCO be the default ABR type.
1043 * ospfd.c: (ospf_new) initialise abr_type to OSPF_ABR_DEFAULT
1044 * ospf_vty.c: (no_ospf_abr_type_cmd) add standard as a negatable
1045 abr_type. default abr_type should be OSPF_ABR_DEFAULT.
1046 (ospf_config_write) test whether default abr_type against
1047 OSPF_ABR_DEFAULT, rather than any specific ABR_TYPE.
1048
hasso8469bd72005-06-20 20:50:10 +000010492005-06-20 Hasso Tepper <hasso at quagga.net>
hassof4833e92005-06-20 20:42:26 +00001050
1051 * ospf_nsm.c: Make database exchange for NSSA database work.
1052
paul7461d452005-06-13 13:57:16 +000010532005-06-13 Paul Jakma <paul.jakma@sun.com>
1054
1055 * ospf_spf.c: Try get more information on a SEGV under
1056 ospf_spf_vertex_add_parent.
1057 (ospf_vertex_free) NULL out the child and nexthop lists
1058 (ospf_vertex_add_parent) nexthop and child can not be NULL
1059 vertex_nexthop's parent->child list can not be NULL
1060 (ospf_spf_next) w and cw are per-loop iteration variables, move
1061 declarations into loop body.
1062
hasso1ddd7292005-06-07 19:54:04 +000010632005-06-07 Hasso Tepper <hasso at quagga.net>
1064
1065 * ospf_apiserver.c: Fix obvious error in notifying clients about ISM
1066 changes - oi->ifp->status doesn't give to us info about ISM,
1067 oi->state does.
1068
paul7e440862005-06-01 11:20:51 +000010692005-06-01 Akihiro Mizutani <mizutani@net-chef.net>
1070
1071 * ospf_ism.c (ospf_elect_bdr/ospf_elect_dr): Fix DR election bug.
1072
paul500e4182005-05-26 17:11:13 +000010732005-05-26 Paul Jakma <paul.jakma@sun.com>
1074
1075 * ospf_abr.c: (ospf_abr_update_aggregate) Fix comment, cost bug itself
1076 had been fixed long ago by Sowmini.
1077
paula3387a42005-05-18 23:29:57 +000010782005-05-19 Paul Jakma <paul.jakma@sun.com>
1079
1080 * ospf_interface.c: (ospf_if_table_lookup) Fix a serious bug
1081 a less serious one.
1082 1: this function is supposed to lookup
1083 entries in the oifs ospf_interface route_table and return either
1084 an existing oi or NULL to indicate not found, its caller depends
1085 on this, yet this function uses route_node_get which /always/
1086 returns a route_node - one is created if none exists. Use
1087 route_node_lookup instead. This should fix root cause of the
1088 reports of the (ospf_add_to_if) assert being hit.
1089 2: oi's are inserted into this table with prefixlength set to
1090 /32 (indeed, it should be a hash table, not a route_table),
1091 however prefixlength to lookup was not changed, if no valid entry
1092 can be inserted other than /32, then nothng but /32 should be
1093 looked up. This possibly only worked by fluke..
1094 Fix confirmed by 2 reporters (one list, one IRC), definitely a
1095 backport candidate once it has been incubated in HEAD for a while.
1096 Thanks to Patrick Friedel and Ivan Warren for testing.
1097
paul69310a62005-05-11 18:09:59 +000010982005-05-11 Paul Jakma <paul.jakma@sun.com>
1099
1100 * (general) Fix memory leaks in opaque AS-scope LSAs, reported and
1101 with much debugging done by by scott collins <scollins@agile.tv>.
1102 * ospf_lsa.c: (ospf_discard_from_db) dont call
1103 ospf_ase_unregister_external_lsa for opaque-lsa's, opaques are
1104 never registered with ase in the first place.
1105 * ospf_packet.c: (general) Disabuse opaque related code of its
1106 tendency to try gather up things into temporary lists.
1107 (ospf_ls_upd) remove the temporary lists opaque uses, call
1108 opaque functions inline, just like all other types.
1109 (ospf_ls_ack) ditto.
1110 (ospf_recv_packet) fixup sign warning.
1111 * ospf_opaque.c: (general) fix the unneeded use of lists, and
1112 untwist some of the logic.
1113 (ospf_opaque_self_originated_lsa_received) take a single LSA
1114 as argument, not a list of them. Remove the list loop. Logic
1115 otherwise unchanged.
1116 (ospf_opaque_ls_ack_received) Mostly ditto. But untwist the logic,
1117 move the actions up into the switch block, remove the goto's and
1118 sanitise the logic near the end a bit.
1119 * ospf_opaque.h: Adjust definitions of aforementioned functions
1120 in ospf_opaque.c to match.
1121
paul42c98192005-05-07 02:22:51 +000011222005-05-07 Yar Tikhiy <yar@comp.chem.msu.su>
1123
1124 * ospf_network.c: Log ifindex on multicast membership leave/join
1125 events.
1126
paul4dadc292005-05-06 21:37:42 +000011272005-05-06 Paul Jakma <paul.jakma@sun.com>
1128
1129 * (general) extern and static qualifiers added.
1130 unspecified arguments in definitions fixed, typically they should
1131 be 'void'.
1132 function casts added for callbacks.
1133 Guards added to headers which lacked them.
1134 Proper headers included rather than relying on incomplete
1135 definitions.
1136 gcc noreturn function attribute where appropriate.
1137 * ospf_opaque.c: remove the private definition of ospf_lsa's
1138 ospf_lsa_refresh_delay.
1139 * ospf_lsa.h: export ospf_lsa_refresh_delay
1140 * ospf_packet.c: (ospf_make_md5_digest) make *auth_key const,
1141 correct thing to do - removes need for the casts later.
1142 * ospf_vty.c: Use vty.h's VTY_GET_INTEGER rather than ospf_vty's
1143 home-brewed versions, shuts up several warnings.
1144 * ospf_vty.h: remove VTY_GET_UINT32. VTY_GET_IPV4_ADDRESS and
1145 VTY_GET_IPV4_PREFIX moved to lib/vty.h.
1146 * ospf_zebra.c: (ospf_distribute_list_update_timer) hacky
1147 overloading of the THREAD_ARG pointer should at least use
1148 uintptr_t.
1149
paul9e67dc22005-04-15 12:10:17 +000011502005-04-15 Zhipeng Gong <zpgong@cdc.3upsystems.com>
1151
1152 * ospf_abr.c: (ospf_abr_announce_network_to_area) dont forget
1153 to approve LSAs for the case where metric has changed, lsa gets
1154 flushed otherwise. (backport candidate).
1155
ajs634f9ea2005-04-11 15:51:40 +000011562005-04-11 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1157
1158 * ospf_zebra.c (ospf_zebra_add): Call zclient_send_message instead
1159 of writen.
1160
ajsd2fc8892005-04-02 18:38:43 +000011612005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1162
ajse4319de2005-04-02 23:23:55 +00001163 * ospf_interface.h: (ospf_if_lookup_by_name) Remove declaration of a
1164 function that does not exist.
1165
11662005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1167
ajs21fefa92005-04-02 23:16:41 +00001168 * ospf_zebra.c: (zebra_interface_if_lookup) Must use
1169 if_lookup_by_name_len.
1170
11712005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1172
ajsa3491982005-04-02 22:50:38 +00001173 * ospf_interface.c: (ospf_vl_new) Use strnlen to fix call to if_create.
1174
11752005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1176
ajsd2fc8892005-04-02 18:38:43 +00001177 * ospf_vty.c: (show_ip_ospf_interface_sub) Show ifindex and interface
1178 flags to help with debugging.
1179 * ospf_zebra.c: (ospf_interface_delete) After deleting, set ifp->ifindex
1180 to IFINDEX_INTERNAL.
1181 (zebra_interface_if_lookup) Make function static. Tighten up code.
1182
ajsaca72fd2005-03-31 15:18:21 +000011832005-03-31 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1184
1185 * ospf_dump.c: (show_debugging_ospf) Show if ospf event debugging
1186 is turned on.
1187
ajsfd651fa2005-03-29 16:08:16 +000011882005-03-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1189
ajsa608bbf2005-03-29 17:03:49 +00001190 * ospf_zebra.c: (ospf_interface_state_up) If the MTU of an operative
1191 interface changes, print a debug message and call ospf_if_reset()
1192 to simulate down/up on the interface.
1193 * ospf_interface.h: Declare new function ospf_if_reset().
1194 * ospf_interface.c: (ospf_if_reset) New function to call ospf_if_down
1195 and ospf_if_up for all ospf interfaces attached to an interface.
1196
11972005-03-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1198
ajs5dcbdf82005-03-29 16:13:49 +00001199 * ospf_packet.c: (ospf_write_frags) Enhance error message to
1200 show MTU. Also make function static.
1201 (ospf_write) Enhance error message to show interface name and MTU.
1202 Also make function static.
1203
12042005-03-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1205
1206 * ospf_vty.c: (show_ip_ospf_interface_sub) Display interface MTU and
1207 bandwidth; this is useful for debugging problems. Also, the function
1208 should be static.
ajsfd651fa2005-03-29 16:08:16 +00001209
hasso1b639042005-03-27 13:32:25 +000012102005-03-27 Hasso Tepper <hasso at quagga.net>
1211
1212 * ospf_snmp.c: Don't crash in snmp query if ospf instance doesn't
1213 exist at all.
1214
hasso343f5cc2005-03-25 19:48:40 +000012152005-03-25 Hasso Tepper <hasso at quagga.net>
1216
1217 * ospfd.h: Include log.h, fixes compile with gcc-4.0.
1218
ajs9dbc7972005-03-13 19:27:22 +000012192005-03-13 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1220
1221 * ospf_lsa.c: (ospf_lsa_refresh_walker) If the system clock jumps
1222 backward, then current time may be less than
1223 ospf->lsa_refresher_started. This was causing invalid values
1224 for ospf->lsa_refresh_queue.index resulting in infinite loops.
1225 Problem fixed by casting the expression to unsigned before taking
1226 the modulus.
1227
ajs5c333492005-02-23 15:43:01 +000012282005-02-23 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1229
1230 * ospfd.h: Add new field struct stream *ibuf to struct ospf.
1231 * ospfd.c: (ospf_new) Check return code from ospf_sock_init.
1232 Allocate ibuf using stream_new(OSPF_MAX_PACKET_SIZE+1).
1233 (ospf_finish) Call stream_free(ospf->ibuf.
1234 * ospf_packet.c: (ospf_read) Call stream_reset(ospf->ibuf) and then
1235 pass it to ospf_recv_packet for use in receiving the packet
1236 (instead of allocating a new stream for each packet received).
1237 Eliminate all calls to stream_free(ibuf).
1238 (ospf_recv_packet) The struct stream *ibuf is now passed in as
1239 an argument. No need to use recvfrom to peek at the packet
1240 header (to see how big it is), just use ospf->ibuf which is
1241 always large enough (this eliminates a system call to recvfrom).
1242 Therefore, no need to allocate a stream just for this packet,
1243 and no need to free it when done.
1244
hasso462f20d2005-02-23 11:29:02 +000012452005-02-23 Vincenzo Eramo <eramo at infocom.ing.uniroma1.it>
1246
1247 * ospf_lsa.h: New flag to the LSA structure for the SPF calculation.
1248 * ospf_lsdb.h: Export ospf_lsdb_clean_stat() function.
1249 * ospf_spf.h: Add link to the LSA stat structure into vertex.
1250 * ospf_spf.c: New functions cmp() and update_stat() to manage
1251 candidates. Remove ospf_spf_has_vertex(), ospf_vertex_lookup(),
1252 ospf_install_candidate() and ospf_spf_register() functions not needed
1253 any more. Update ospf_vertex_new(), ospf_spf_next() and
1254 ospf_spf_calculate() functions to use pqueue instead of linked list.
1255
hassoe40dcce2005-02-21 14:58:42 +000012562005-02-21 Hasso Tepper <hasso at quagga.net>
1257
1258 * ospf_ase.c: Don't show messages related to the ase calculations if
1259 we are not debugging.
1260
hasso306541b2005-02-19 17:58:40 +000012612005-02-19 Hasso Tepper <hasso at quagga.net>
1262
1263 * ospf_api.h: char isn't always signed, but it has to be it here.
1264
paulfa81b712005-02-19 01:19:20 +000012652005-02-19 Paul Jakma <paul.jakma@sun.com>
1266
1267 * ospf_packet.c: (ospf_stream_copy) remove
1268 (ospf_packet_dup) use stream_copy instead of ospf_stream_copy
1269
ajs038163f2005-02-17 19:55:59 +000012702005-02-17 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1271
1272 * ospf_packet.c: (ospf_recv_packet) If there is somehow a runt
1273 packet in the queue, it must be discarded. Improve warning messages.
1274 Fix scope to static.
1275 (ospf_read) Fix bug: should reset the read thread in all cases
1276 to make sure we continue to get incoming messages.
1277
paul658b03a2005-02-15 10:10:55 +000012782005-02-15 Paul Jakma <paul.jakma@sun.com>
1279
1280 * ospf_packet.c: (ospf_recv_packet) Fix silly error wrt allocating
1281 ibuf. Thanks Andrew.
1282
paulbfdc44a2005-02-14 23:48:42 +000012832005-02-14 Paul Jakma <paul.jakma@sun.com>
1284
1285 * ospf_packet.c: (ospf_recv_packet) use stream_recvmsg.
1286
hasso082253f2005-02-11 08:31:54 +000012872005-02-11 Hasso Tepper <hasso at quagga.net>
1288
1289 * ospf_lsdb.c: Fix sum of checksums calculation.
1290
ajs083ee9d2005-02-09 15:35:50 +000012912005-02-09 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1292
1293 * ospf_packet.c: (ospf_write) If sendmsg fails, give more info in the
1294 error message.
1295
ajsba6454e2005-02-08 15:37:30 +000012962005-02-08 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1297
ajs8cfde372005-02-08 15:59:16 +00001298 * ospf_interface.h: Reduce structure padding by putting new u_char
1299 field multicast_memberships in a better spot (grouped with
1300 other u_char fields type and state).
1301
13022005-02-08 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1303
ajsba6454e2005-02-08 15:37:30 +00001304 * ospf_interface.h: Improve passive_interface comment. Add new
1305 multicast_memberships bitmask to struct ospf_interface to track
1306 active multicast subscriptions. Declare new function
1307 ospf_if_set_multicast.
1308 * ospf_interface.c: (ospf_if_set_multicast) New function to configure
1309 multicast memberships properly based on the current
1310 multicast_memberships status and the current values of the
1311 ospf_interface state, type, and passive_interface status.
1312 (ospf_if_up) Remove call to ospf_if_add_allspfrouters (this is
1313 now handled by ism_change_state's call to ospf_if_set_multicast).
1314 (ospf_if_down) Remove call to ospf_if_drop_allspfrouters (now
1315 handled by ism_change_state).
1316 * ospf_ism.c: (ospf_dr_election) Remove logic to join or leave
1317 the DRouters multicast group (now handled by ism_change_state's call
1318 to ospf_if_set_multicast).
1319 (ism_change_state) Add call to ospf_if_set_multicast to change
1320 multicast memberships as necessary to reflect the new interface state.
1321 * ospf_packet.c: (ospf_hello) When a Hello packet is received on a
1322 passive interface: 1. Increase the severity of the error message
1323 from LOG_INFO to LOG_WARNING; 2. Add more information to the error
1324 message (packet destination address and interface address);
1325 and 3. If the packet was sent to ospf-all-routers, then try
1326 to fix the multicast group memberships.
1327 (ospf_read) When a packet is received on an interface whose state
1328 is ISM_Down, enhance the warning message to show the packet
1329 destination address, and try to update/fix the multicast group
1330 memberships if the packet was sent to a multicast address.
1331 When a packet is received for ospf-designated-routers, but the
1332 current interface state is not DR or BDR, then increase the
1333 severity level of the error message from LOG_INFO to LOG_WARNING,
1334 and try to fix the multicast group memberships.
1335 * ospf_vty.c: (ospf_passive_interface) Call ospf_if_set_multicast for
1336 any ospf interface that may have changed from active to passive.
1337 (no_ospf_passive_interface) Call ospf_if_set_multicast for
1338 any ospf interface that may have changed from passive to active.
1339 (show_ip_ospf_interface_sub) Show multicast group memberships.
1340
paul3a9eb092005-02-08 11:29:41 +000013412005-02-08 Paul Jakma <paul@dishone.st>
1342
1343 * ospf_packet.c: (various) Remove unneeded stream_set_putp abuse.
1344
ajs847947f2005-02-02 18:38:48 +000013452005-02-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1346
1347 * ospf_packet.c: (ospf_read) Fix bug: must check for state ISM_Down,
1348 not for event ISM_InterfaceDown. And improve the message by
1349 adding the interface flags.
1350
ajs0b7d97d2005-01-30 17:24:02 +000013512005-01-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1352
1353 * ospf_network.c: (ospf_sock_init) Save errno before calling
1354 ospfd_privs.change.
1355
ajsc3eab872005-01-29 15:52:07 +000013562005-01-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1357
1358 * ospf_packet.c: (ospf_packet_add) If oi->obuf is NULL, print
1359 an error message and return.
1360 (ospf_read) If the interface state is ISM_InterfaceDown, issue
1361 a warning message and ignore the packet.
1362
gdt86f1fd92005-01-10 14:20:43 +000013632005-01-10 Greg Troxel <gdt@fnord.ir.bbn.com>
1364
1365 * ospf_packet.h: Remove commented out definition of
1366 OSPF_MAX_PACKET; neither it or the uncommented one are used any more.
1367
1368 * ospf_packet.c (ospf_make_ls_upd): Leave room for authentication
1369 when deciding if an update will fit.
1370 (ospf_packet_authspace): Factor out calculation of size required
1371 for authentication.
1372 (ospf_make_db_desc): Use ospf_max_packet, not OSPF_MAX_PACKET.
1373 Don't confuse readers that there is a macro.
1374
ajs3dc56b52004-12-30 15:11:19 +000013752004-12-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1376
1377 * ospf_network.c: Improve all setsockopt error messages to give detailed
1378 information on the arguments.
1379
ajsb87f7722004-12-29 20:41:26 +000013802004-12-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1381
ajs17eaa722004-12-29 21:04:48 +00001382 * ospf_packet.c: (ospf_db_desc) Reduce severity of "Negotiation done"
1383 messages from LOG_WARNING to LOG_INFO, since this seems to be
1384 normal.
1385
13862004-12-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1387
ajsb87f7722004-12-29 20:41:26 +00001388 * ospf_packet.c: (ospf_read) Always look up the interface if
1389 ospf_recv_packet returns NULL ifp, since some platforms such
1390 as Solaris 8 appear to support ifindex retrieval but don't.
1391
hasso1d806282004-12-22 09:43:20 +000013922004-12-22 Hasso Tepper <hasso at quagga.net>
1393
1394 * ospf_dump.c: Show debug configuration in vtysh.
hassoc6b87812004-12-22 13:09:59 +00001395 * ospf_vty.c: Fix "show ip ospf" output. Router can't be elected in
1396 any case if it's configured as "translate-never".
hassofe71a972004-12-22 16:16:02 +00001397 * ospf_lsdb.[ch]: New function to calculate sum of checksums.
1398 * ospf_vty.c: Bugfix to show really number of AS external LSAs, not
1399 number of all LSAs with AS scope, this includes opaque as LSAs as
1400 well, show this number separately. Show numbers and sums of
1401 checksums for each type of LSAs.
1402 * ospf_lsa.c: Calculate checksum before putting LSA into database.
hasso1d806282004-12-22 09:43:20 +00001403
ajsbc18d612004-12-15 15:07:19 +000014042004-12-15 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1405
1406 * ospf_interface.h: Declare new function ospf_default_iftype.
1407 * ospf_interface.c: (ospf_default_iftype) New function to centralize
1408 this logic in one place.
1409 * ospf_zebra.c: (ospf_interface_add) Use new function
1410 ospf_default_iftype.
1411 * ospf_vty.c: (no_ip_ospf_network,config_write_interface) Fix logic
1412 by using new function ospf_default_iftype.
1413
ajs3aa8d5f2004-12-11 18:00:06 +000014142004-12-11 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1415
1416 * ospf_packet.c: (ospf_db_desc) Should be static, not global.
1417 (ospf_hello,ospf_db_desc,ospf_ls_upd,ospf_ls_ack) Improve warning
1418 messages to include identifying information (e.g. router id).
1419 * ospf_nsm.c: (nsm_change_state) Improve info message to include
1420 router id and state names.
1421
gdt91f3e522004-12-09 14:51:03 +000014222004-12-09 Greg Troxel <gdt@fnord.ir.bbn.com>
1423
gdt3fb9de72004-12-09 16:30:04 +00001424 * ospf_apiserver.c (ospf_apiserver_term): Obtain struct
1425 ospf_apiserver * from listnode. Remove unused variables. Follows
1426 suggestion from Jay Fenlason.
gdt91f3e522004-12-09 14:51:03 +00001427
ajs9b0e25c2004-12-08 19:06:51 +000014282004-12-08 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1429
1430 * *.c: Change level of debug messages to LOG_DEBUG.
1431
ajs274a4a42004-12-07 15:39:31 +000014322004-12-07 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1433
1434 * ospf_main.c: (main) The 2nd argument to openzlog has been removed.
1435
ajs887c44a2004-12-03 16:36:46 +000014362004-12-03 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1437
ajs1210fa62004-12-03 16:43:24 +00001438 * ospf_packet.c: (ospf_db_desc) Reduce priority on a debug message
1439 from LOG_NOTICE to LOG_DEBUG.
1440
14412004-12-03 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1442
ajs887c44a2004-12-03 16:36:46 +00001443 * ospf_main.c: (sigint) Use zlog_notice for termination message.
1444 (main) Issue a startup announcement using zlog_notice.
1445
ajsbec595a2004-11-30 22:38:43 +000014462004-11-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1447
1448 * ospf_packet.c: (ospf_db_desc_proc) Fix spelling of packet in warning
1449 message and in comment.
1450 (ospf_db_desc) Warning message that a packet is being discarded
1451 should give the router id of the packet source. Fix spelling
1452 of packet in two warning messages.
1453 (ospf_ls_req) Warning message that a link state request is being
1454 discarded should give the router id of the neighbor that sent it.
1455
ajs5b85fac2004-11-26 19:36:42 +000014562004-11-26 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1457
1458 * ospf_main.c: Remove #include "debug.h" (was not being used, and
1459 lib/debug.h has now been deleted).
1460
hassoc0652302004-11-25 19:33:48 +000014612004-11-25 Hasso Tepper <hasso at quagga.net>
1462
1463 * ospf_main.c: Make group to run as configurable.
1464
gdt69e13252004-11-15 18:51:15 +000014652004-11-15 Greg Troxel <gdt@fnord.ir.bbn.com>
1466
1467 * ospf_packet.c (ospf_recv_packet): Assume CMSG_SPACE is present
1468 and works (lib/zebra.h provides if OS doesn't).
1469
paul788dab12004-11-15 11:48:37 +000014702004-11-15 Paul Jakma <paul@dishone.st>
1471
1472 * ospf_{apiserver,te}.c: ospf_lsa_free's should be ospf_lsa_unlock.
1473
paul05e85fa2004-11-12 10:52:19 +000014742004-11-12 Paul Jakma <paul@dishone.st>
1475
1476 * ospf_ia.c: (process_summary_lsa) Only an ABR has any reason to
1477 ignore stub area summary default. Even so it seems a strange
1478 check, add a comment to that effect.
1479
paulf3ae74c2004-11-04 20:35:31 +000014802004-11-04 Paul Jakma <paul@dishone.st>
1481
1482 * ospfd.c: (ospf_network_match_iface) revert to previous network
1483 statement match behaviour.
1484
paul62d8e962004-11-02 20:26:45 +000014852004-11-02 Paul Jakma <paul@dishone.st>
1486
1487 * ospf_packet.c: (ospf_write_frags) remove iov arg, msg already points
1488 to it. Add convenience pointer to msg->msg_iov[1], and use this,
1489 fixing the unfortunate borkenness introduced in moving of this code
1490 to a function.
1491 (ospf_write) remove iovp and fix up call to previous.
1492 (ospf_ls_upd_packet_new) cast size to long int - unfortunately
1493 glibc's size_t format modifier is not portable.
1494
paul37ccfa32004-10-31 11:24:51 +000014952004-10-31 Paul Jakma <paul@dishone.st>
1496
1497 * ospf_packet.c: (ospf_write_frags) Add debug output
1498 (ospf_write) set type early, so we can pass it to
1499 ospf_write_frags.
1500 (ospf_ls_upd_packet_new) print size in debug output when too large
1501 packet is encountered.
paul64511f32004-10-31 18:01:13 +00001502 * ospf_zebra.c: (ospf_distribute_list_update_timer) Ugly misuse of
1503 THREAD_ARG to store an integer, but it should at least use same
1504 same type to retrieve the value. Assert value is sane.
paul37ccfa32004-10-31 11:24:51 +00001505
paulac191232004-10-22 12:05:17 +000015062004-10-22 Paul Jakma <paul@dishone.st>
1507
1508 * ospf_network.c: (ospf_sock_init) call neutral setsock_ifindex()
1509 function.
1510 * ospf_packet.c: (ospf_read) manually look up ifindex
paul4ccb2c42004-10-22 22:52:33 +00001511 if system could not have returned one, eg openbsd, thanks to Rivo
1512 Nurges for highlighting problem and fix.
paul06f953f2004-10-22 17:00:38 +00001513 Change setsockopt_pktinfo to setsockopt_ifindex.
paulac191232004-10-22 12:05:17 +00001514
hasso3fb9cd62004-10-19 19:44:43 +000015152004-10-19 Andrew J. Schorr <aschorr@telemetry-investments.com>
1516
1517 * ospf_snmp.c: (ospf_snmp_if_update) Fix logic to handle PtP links
1518 with dedicated subnets properly.
1519 * ospf_lsa.c: (lsa_link_ptop_set) ditto.
1520 * ospfd.c: (ospf_network_match_iface) ditto.
1521 (ospf_network_run) ditto.
1522 * ospf_interface.c: (ospf_if_is_configured) ditto.
1523 (ospf_if_lookup_by_prefix) ditto.
1524 (ospf_if_lookup_recv_if) ditto.
1525 * ospf_vty.c: (show_ip_ospf_interface_sub) Display the peer or
1526 broadcast address if present.
1527
hassod68614d2004-10-13 09:32:48 +000015282004-10-13 Hasso Tepper <hasso at quagga.net>
1529
1530 * ospf_main.c: Unbreak compilation with ospfapi disabled.
hassoc75105a2004-10-13 10:33:26 +00001531 * ospf_snmp.c: Remove defaults used to initialize smux connection to
1532 snmpd. Connection is initialized only if smux peer is configured.
hassod68614d2004-10-13 09:32:48 +00001533
hassof4d58ce2004-10-12 06:13:54 +000015342004-10-12 Hasso Tepper <hasso at quagga.net>
1535
1536 * ospf_main.c, ospf_opaque.c: Unbreak ospfclient compilation - move
1537 static variable from ospf_main.c into ospf_opaque.c.
1538
hassoc3abdb72004-10-11 16:27:03 +000015392004-10-11 Hasso Tepper <hasso at quagga.net>
1540
1541 * ospf_main.c, ospf_opaque.c: Disable ospfapi init by default. New
1542 command line switch to enable it.
1543
paul6b333612004-10-11 10:11:25 +000015442004-10-11 Paul Jakma <paul@dishone.st>
1545
1546 * ospf_dump.c: (ospf_ip_header_dump) Assume header is in host order
1547 remove ntohs that should have dissappeared. Take struct ip
1548 as argument, caller has to know there's an IP header at start of
1549 stream anyway.
1550 * ospf_dump.h: update declaration of ospf_ip_header_dump.
1551 * ospf_packet.c: (ospf_write) correct call to
1552 sockopt_iphdrincl_swab_htosys which was munging the header.
1553 (ospf_recv_packet) ip_len is needed for old OpenBSD fixup.
1554 (ospf_read) sockopt_iphdrincl_swab_systoh ip header as soon as
1555 we have it.
paul6c835672004-10-11 11:00:30 +00001556 * (global) Const char update and signed/unsigned fixes.
1557 * (various headers) size defines should be unsigned.
1558 * ospf_interface.h: remove duplicated defines, include the
1559 authoritative header - though, these defines should probably
1560 be moved to a dedicated header, or ospfd.h.
1561 * ospf_lsa.h: (struct lsa) ls_seqnum should be unsigned.
1562 * ospf_packet.c: (ospf_write) cast result of shift to unsigned.
paul6b333612004-10-11 10:11:25 +00001563
hassoeb1ce602004-10-08 08:17:22 +000015642004-10-08 Hasso Tepper <hasso at quagga.net>
1565
1566 * *.[c|h]: Fix compiler warnings: make some strings const, signed ->
1567 unsigned, remove unused variables etc.
1568
gdt54ade992004-10-07 19:38:20 +000015692004-10-07 Greg Troxel <gdt@claude.ir.bbn.com>
1570
1571 * ospf_apiserver.c (ospf_apiserver_unregister_opaque_type): Don't
1572 use of variable names 'node' and 'nextnode' to avoid possible
1573 conflict with list macros. Move variable declaration inside for
1574 loop after a statement to top of function.
1575
paulaa20c6f2004-10-07 14:19:36 +000015762004-10-07 Paul Jakma <paul@dishone.st>
1577
1578 * ospf_snmp.c: Missed list typedef update
1579 * ospf_dump.c: Include sockopt.h for header swab functions.
1580
paul18b12c32004-10-05 14:38:29 +000015812004-10-05 Paul Jakma <paul@dishone.st>
1582
1583 * ospf_packet.c: replace ospf_swap_iph_to... with
1584 sockopt_iphdrincl_swab_...
1585
hasso18a6dce2004-10-03 18:18:34 +000015862004-10-03 James R. Leu <jleu at mindspring.com>
1587
1588 * ospf_zebra.c: Read router id related messages from zebra daemon.
1589 Schedule router-id update thread if it's changed.
1590 * ospfd.c: Remove own router-id selection function. Use router id from
1591 zebra daemon if it isn't manually overriden in configuration.
1592
paul68defd62004-09-27 07:27:13 +000015932004-09-27 Paul Jakma <paul@dishone.st>
1594
paul6a99f832004-09-27 12:56:30 +00001595 * ospf_dump.c: (ospf_ip_header_dump) Use HAVE_IP_HDRINCL_BSD_ORDER
1596 Apply to offset too. Print ip_cksum, lets not worry about
1597 possible 2.0.37 compile problems.
1598 * ospf_packet.c: (ospf_swap_iph_to{n,h}) Use
1599 HAVE_IP_HDRINCL_BSD_ORDER.
1600 (ospf_recv_packet) ditto.
1601 (ospf_write) Fixup iov argument to ospf_write_frags.
1602 (struct msghdr).msg_name is caddr_t on most platforms.
paul68defd62004-09-27 07:27:13 +00001603 (ospf_recv_packet) ditto. And msg_flags is not always there
1604 memset struct then set fields we care about rather than
1605 initialise all fields individually.
1606
hassoc9e52be2004-09-26 16:09:34 +000016072004-09-26 Hasso Tepper <hasso at quagga.net>
1608
1609 * ospf_abr.c, ospf_dump.c, ospf_lsa.c, ospf_packet.c, ospf_vty.c,
1610 ospf_zebra.c: Fix compiler warnings.
1611
paul87d6f872004-09-24 08:01:38 +000016122004-09-24 Paul Jakma <paul@dishone.st>
1613
1614 * ospf_apiserver.{c,h}: lists typedef removal cleanup.
1615 update some list loops to LIST_LOOP. some miscellaneous indent
1616 fixups.
1617 (ospf_apiserver_unregister_opaque_type) fix listnode_delete of
1618 referenced node in loop.
paul1603c062004-09-24 08:23:24 +00001619 (ospf_apiserver_term) loops calling ospf_apiserver_free, which
1620 deletes referenced nodes from apiserver_list, fixed.
paul87d6f872004-09-24 08:01:38 +00001621 * ospf_interface.h: lists typedef removal cleanup.
1622 * ospf_opaque.{c,h}: lists typedef removal cleanup. update some list
1623 loops to LIST_LOOP. miscellaneous style and indent fixups.
1624 * ospf_te.{c,h}: ditto
1625 * ospf_packet.c: lists typedef removal cleanup.
paula2570682004-09-24 08:09:57 +00001626 (ospf_write) ifdef fragmentation support. move actual
1627 fragmentation out to a new, similarly ifdefed, function.
1628 (ospf_write_frags) fragmented write support, moved from previous.
paul87d6f872004-09-24 08:01:38 +00001629
hasso52dc7ee2004-09-23 19:18:23 +000016302004-09-23 Hasso Tepper <hasso at quagga.net>
1631
1632 * *.[c|h]: list -> struct list *, listnode -> struct listnode *.
1633
paul68b73392004-09-12 14:21:37 +000016342004-09-12 Paul Jakma <paul@dishone.st>
1635
1636 * ospf_packet.c: Fix bugzilla #107
1637 (ospf_packet_max) get rid of the magic 88 constant
1638 (ospf_swab_iph_ton) new function. set ip header to network order,
1639 taking BSDisms into account.
1640 (ospf_swab_iph_toh) the inverse.
1641 (ospf_write) Add support for IP fragmentation, will only work on
1642 linux though, other kernels make it impossible. get rid of the
1643 magic 4 constant.
1644 (ospf_make_ls_upd) Bound check to end of stream, not to
1645 interface mtu.
1646 (ospf_ls_upd_packet_new) New function, allocate upd packet
1647 taking oversized LSAs into account.
1648 (ospf_ls_upd_queue_send) use ospf_ls_upd_packet_new to allocate,
1649 rather than statically allocating mtu sized packet buffer, which
1650 actually was wrong - it didnt take ip header into account, which
1651 should not be included in packet buffer.
1652 (ospf_ls_upd_send_queue_event) minor tweaks and remove
1653 TODO comment.
1654
gdt630e4802004-08-31 17:28:41 +000016552004-08-31 David Wiggins <dwiggins@bbn.com>
1656
1657 * ospf_spf.c (ospf_spf_calculate): Many more comments and debug
1658 print statements. New function ospf_vertex_dump used in debugging.
1659
16602004-08-31 David Wiggins <dwiggins@bbn.com>
1661
1662 * ospf_spf.h (struct vertex): Comments for flags and structure members.
1663
16642004-08-31 David Wiggins <dwiggins@bbn.com>
1665
1666 * ospf_route.c: When finding an alternate route, log cost as well.
1667
16682004-08-31 David Wiggins <dwiggins@bbn.com>
1669
1670 * ospf_interface.c (ospf_lookup_if_params): Initialize af in
1671 struct prefix allocated on stack.
1672
16732004-08-31 David Wiggins <dwiggins@bbn.com>
1674
1675 * ospf_packet.c (ospf_ls_ack_send_delayed): In p2mp mode, send
1676 acks to AllSPFRouters, rather than All-DR.
1677
hasso7b901432004-08-31 13:37:42 +000016782004-08-27 Hasso Tepper <hasso at quagga.net>
1679
1680 * ospf_vty.c: Don't print ospf network type under interface only
1681 if interface is in broadcast mode and interface type really is
1682 broadcast. Fixes Bugzilla #108.
1683
gdtd7d93992004-08-27 12:03:42 +000016842004-08-27 David Wiggins <dwiggins@bbn.com>
1685
1686 * ospf_spf.c (ospf_nexthop_calculation): Initialize address family
1687 in on-stack struct prefix_ipv4. Fixes point-to-multipoint SPF
1688 calculation.
1689
gdtd0deca62004-08-26 13:14:07 +000016902004-08-26 Greg Troxel <gdt@fnord.ir.bbn.com>
1691
1692 * ospf_packet.c (ospf_recv_packet): adjust size declaration of
gdtd7d93992004-08-27 12:03:42 +00001693 buffer used to get interface index so that it compiles on other
1694 than Linux and includes the required alignment space. Probably
1695 this was only working on sparc/sparc64 because most of
1696 sockaddr_dl was not being written.
gdtd0deca62004-08-26 13:14:07 +00001697
paul863082d2004-08-19 04:43:43 +000016982004-08-19 Paul Jakma <paul@dishone.st>
1699
1700 * ospf_packet.c: update to match sockopt renames.
1701
paul75ee0b82004-08-05 09:10:31 +000017022004-08-04 Paul Jakma <paul@dishone.st>
1703
1704 * ospf_spf.c: (ospf_spf_consider_nexthop) Add comment about issue.
1705 Compare only against list head - all nexthops must be same cost
1706 anyway, fixes a reference-listnode-after-delete bug noted by
1707 Kir Kostuchenko.
1708 (ospf_nexthop_calculation) Use ospf_spf_consider_nexthop for all
1709 candidates attached to root.
1710
paul36c64ef2004-07-27 11:19:11 +000017112004-07-27 Paul Jakma <paul@dishone.st>
1712
paul48fe13b2004-07-27 17:40:44 +00001713 * ospf_packet.c: (ospf_ls_upd_send_queue_event) fix thinko from
1714 last fix for ospfd wedging due to oversize LSAs: dont list loop on
1715 ospf_ls_upd_queue_send() - guaranteed segfault.
1716
17172004-07-27 Paul Jakma <paul@dishone.st>
1718
paul36c64ef2004-07-27 11:19:11 +00001719 * ospf_opaque.c: (ospf_opaque_lsa_flush_schedule) do not NULL out
1720 the LSA as then free_opaque_info_per_id() can never unlock (and
1721 free) the LSA. Reported by Gunnar Stigen.
1722
paul2dd8bb42004-07-23 15:13:48 +000017232004-07-23 Paul Jakma <paul@dishone.st>
1724
1725 * ospf_network.c: Replace PKTINFO/RECVIF with call to
1726 setsockopt_pktinfo
1727 * ospf_packet.c: Use getsockopt_pktinfo_ifindex and
1728 SOPT_SIZE_CMSG_PKTINFO_IPV4.
1729
paul59ea14c2004-07-14 20:50:36 +000017302004-07-14 Paul Jakma <paul@dishone.st>
1731
1732 * ospf_packet.c: (ospf_ls_upd_send_queue_event) Partial fix for
1733 problem reported by Peter Frost amongst others, where function
1734 will spin indefinitely if update list contains LSAs greater than
1735 MTU-headers or other condition leading to update list never being
1736 cleared. Problem of what to do with these LSAs remains.
1737 (ospf_make_ls_upd) add comment about large LSA problem,
1738 indentation cleanup.
1739
gdtb2c1b282004-07-01 12:35:36 +000017402004-07-01 Greg Troxel <gdt@fnord.ir.bbn.com>
1741
1742 * Makefile.am (lib_LTLIBRARIES): make libospf shared
1743
gdt87efd642004-06-30 17:36:11 +000017442004-06-30 Greg Troxel <gdt@poblano.ir.bbn.com>
1745
1746 * Makefile.am: Add shlib support.
1747
hassobeebba72004-06-20 21:00:27 +000017482004-06-10 Hasso Tepper <hasso@estpak.ee>
1749
1750 * *: Removed ifdefs HAVE_NSSA.
1751
paul553ff112004-06-06 09:41:00 +000017522004-06-06 Paul Jakma <paul@dishone.st>
1753
1754 * ospf_dump.c,ospf_lsa.c: Fix typos of merge of previous.
1755 ospf_flood.c: (ospf_process_self_originated_lsa) fix zlog format
1756
paul0c2be262004-05-31 14:16:54 +000017572004-05-31 Sagun Shakya <sagun.shakya@sun.com>
1758
1759 * ospf_dump.c: (ospf_lsa_header_dump) LOOKUP can return null if
1760 index is out of range.
1761 ospf_flood.c: endianness fix
1762 ospf_lsa.c: Missing ntohl's on (struct lsa *)->data->ls_seqnum
1763 in various places.
1764
hassodd669bb2004-05-10 07:43:59 +000017652004-05-10 Hasso Tepper <hasso@estpak.ee>
1766
1767 * ospf_zebra.c, ospfd.c: Move ospf_prefix_list_update() function
1768 to ospf_zebra.c from ospfd.c and add redistribution updates if
1769 route-map is used in redistribution.
1770 * ospf_main.c: Remove now useless call to ospf_init().
1771
paul0a589352004-05-08 11:48:26 +000017722004-05-08 Paul Jakma <paul@dishone.st>
1773
1774 * ospf_zebra.c: Sync with lib/zclient changes
1775
pauld3f0d622004-05-05 15:27:15 +000017762004-05-05 Paul Jakma <paul@dishone.st>
1777
paul5bd41892004-05-05 17:29:24 +00001778 * ospf_network.c: (ospf_sock_init) Check whether IP_HDRINCL is
1779 defined. Warn at compile and runtime. Use
1780 IPTOS_PREC_INTERNETCONTROL otherwise.
pauld3f0d622004-05-05 15:27:15 +00001781 * ospf_packet.c: (ospf_associate_packet_vl) cleanup, move
1782 some of the checks up to ospf_read, return either a
1783 virtual link oi, or NULL.
1784 (ospf_read) Cleanup, make it responsible for checks. Remove
1785 the nbr lookup - moved to ospf_neighbor. Adjust all nbr
1786 lookups to use new wrappers exported by ospf_neighbor.
1787 * ospf_neighbor.h: Add ospf_neigbour_get and ospf_nbr_lookup.
1788 * ospf_neighbor.c: (ospf_neigbour_get) Index ospf_interface
1789 neighbour table by router-id for virtual-link ospf_interfaces,
1790 not by peer_addr (which breaks for asymmetric vlinks)
1791 (ospf_nbr_lookup) add a wrapper for nbr lookups to deal with
1792 above.
paulcd59da62004-05-05 17:26:55 +00001793 * ospf_interface.c: (ospf_vl_set_params) Catch changes of interface
1794 address for either end of a virtual-link, and hence potential cost
1795 changes.
1796
hassoa0a39762004-04-23 08:51:10 +000017972004-04-22 Hasso Tepper <hasso@estpak.ee>
1798
1799 * ospf_zebra.c: Don't ignore reject/bh routes, it's the only way
1800 to "summarize" routes in ASBR at the moment.
1801
hasso8585d4e2004-04-20 17:25:12 +000018022004-04-20 Hasso Tepper <hasso@estpak.ee>
1803
1804 * ospfd.c: Unset NP flag if area is going to be normal or stub.
1805 Fixes UNH OSPF_NSSA.1.2a comment.
1806 * ospf_abr.c: Originate default into stub/nssa area even if
1807 summaries are disabled.
1808 * ospf_zebra.c: Don't attempt to redistribute 127.0.0.0/8.
1809
hassoc266ac72004-04-19 17:31:00 +000018102004-04-19 Hasso Tepper <hasso@estpak.ee>
1811
1812 * ospf_vty.c: Don't warn that export- and import-list can't be
1813 configured to backbone area if they are applied and are working
1814 fine.
1815
hasso128d31d2004-04-04 12:52:33 +000018162004-02-19 Sowmini Varadhan <sowmini.varadhan@sun.com>
1817
1818 * ospf_packet.c: Don't drop packets in Solaris x86.
1819 [quagga-dev 1005].
1820
hasso0d85b992004-03-18 19:18:33 +000018212004-03-18 Amir Guindehi <amir@datacore.ch>
1822
1823 * ospf_opaque.c: Attempt to correct the incorrect behavior of
1824 Quagga's ospfd in the special situation that a node's opaque
1825 capability has changed as "ON -> OFF -> ON". [quagga-dev 843].
1826
paul7f352b82004-02-19 19:37:47 +000018272004-02-19 Sowmini Varadhan <sowmini.varadhan@sun.com>
1828
1829 * ospf_abr.c: (ospf_abr_update_aggregate) UNH 3.12b,c, address range
1830 should be configured with the highest cost path within the range,
1831 not lowest.
1832
paul940b01a2004-02-17 20:07:30 +000018332004-02-17 Paul Jakma <paul@dishone.st>
1834
1835 * ospf_zebra.c: (ospf_interface_delete) Do not delete the interface
1836 params, nor the interface structure, if an interface delete
1837 message is received from zebra.
1838 * ospf_interface.c: (ospf_if_delete_hook) Delete the interface
1839 params and interface, ie that which was previously removed in
1840 (ospf_interface_delete) above.
1841
hasso2db3d052004-02-11 21:52:13 +000018422004-02-11 Hasso Tepper <hasso@estpak.ee>
1843 * ospf_interface.c, ospf_zebra.c: Don't attempt to read path->oi->ifp
1844 if oi doesn't exist any more.
1845
hassocb05eb22004-02-11 21:10:19 +000018462004-02-11 Vadim Suraev <vadim.suraev@terayon.com>
1847 * ospf_packet.c (ospf_ls_upd): Router should flush received network
1848 LSA if it was originated with older router-id ([zebra 14710] #6).
1849
18502003-12-08 Mattias Amnefelt <mattiasa@kth.se>
paul239aecc2003-12-08 10:34:54 +00001851
1852 * ospf_packet.c: (ospf_recv_packet) OpenBSD now leaves iph.ip_len
1853 network byte order.
1854
gdt8f40e892003-12-05 14:01:43 +000018552003-12-05 Greg Troxel <gdt@poblano.ir.bbn.com>
1856
1857 * ospfd.c (ospf_network_match_iface): Rewrite code for clarity
1858 while trying not to change semantics. Add ifdefed-out code to
1859 avoid matching ppp interfaces whose destination address does not
1860 also match the prefix under consideration, to help out people with
1861 problems due to as-yet-unfixed bugs with p2p interfaces coming and
1862 going.
1863
paul736d3442003-07-24 23:22:57 +000018642003-07-25 kamatchi soundaram <kamatchi@tdd.sj.nec.com>
1865
1866 * ospf_packet.c (ospf_ls_upd_send_queue_event): get next route
1867 node in body of the loop to avoid chance that route node
1868 is unlocked and deleted before the next iteration tries to
1869 get next route node.
1870
paul0a825c72003-05-24 13:48:16 +000018712003-05-24 Kenji Yabuuchi
1872
1873 * ospf_interface.c(ospf_if_lookup_recv_if): Use the most specific
1874 match for interface lookup.
1875
paul551a8972003-05-18 15:22:55 +000018762003-05-18 Hasso Tepper <hasso@estpak.ee>
paul445f1432003-05-16 19:00:31 +00001877
paul551a8972003-05-18 15:22:55 +00001878 * ospf_vty.c: Show NSSA LSA route info in "show ip ospf database"
1879 output
paul445f1432003-05-16 19:00:31 +00001880
pauld7480322003-05-16 17:31:51 +000018812003-05-16 Hasso Tepper <hasso@estpak.ee>
1882
1883 * ospf_lsa.c: Fix handling of NSSA
1884
paul551a8972003-05-18 15:22:55 +000018852003-04-23 Hasso Tepper <hasso@estpak.ee>
1886
1887 * ospf_vty.c: fix "router xxx" node commands in vtysh
1888
paul445f1432003-05-16 19:00:31 +000018892003-04-19 Hasso Tepper <hasso@estpak.ee>
1890
1891 * {ospf_abr,ospfd}.c: area id's DECIMAL -> ADDRESS
1892 * ospf_routemap.c: sync daemon's route-map commands to have same
1893 syntax.
1894
18952003-04-19 Sergey Vyshnevetskiy <serg@vostok.net>
1896
1897 * ospf_packet.c: Add missing param to zlog
1898 * ospf_flood.c: remove unused vars
1899
19002003-04-17 Denis Ovsienko <zebra@pilot.org.ua>
1901
1902 * ospf_interface.c: fix incorrect memset
1903
paul28a13842003-05-16 20:30:37 +000019042003-04-10 Amir Guindehi <amir@datacore.ch>
paul445f1432003-05-16 19:00:31 +00001905
1906 * ospf_lsa.[ch]: opaque LSA fix, use ospf_lookup.
1907
19082003-04-03 David Watson <dwatson@eecs.umich.edu>
1909
1910 * ospf_lsa.c: byte order fix
1911
paul07661cb2003-03-18 00:03:05 +000019122002-03-17 Amir Guindehi <amir@datacore.ch>
1913
1914 * ospf_apiserver.[ch]: Merge Ralph Keller's OSPFAPI support.
1915 * ospf_api.[ch]: Merge Ralph Keller's OSPFAPI support.
1916 * ospfclient: OSPFAPI demonstration client.
1917
19182003-01-23 Masahiko Endo <endo@suri.co.jp>
1919
1920 * ospf_ism.c: NSM event schedule bug fix.
1921
19222002-10-30 Greg Troxel <gdt@ir.bbn.com>
1923
1924 * ospf_packet.c (ospf_make_md5_digest): MD5 length fix.
1925
paul718e3742002-12-13 20:15:29 +000019262002-10-23 endo@suri.co.jp (Masahiko Endo)
1927
1928 * ospf_opaque.c: Update Opaque LSA patch.
1929
19302002-10-23 Ralph Keller <keller@tik.ee.ethz.ch>
1931
1932 * ospf_vty.c (show_ip_ospf_database): Fix CLI parse.
1933
19342002-10-23 Juris Kalnins <juris@mt.lv>
1935
1936 * ospf_interface.c (ospf_if_stream_unset): When write queue
1937 becomes empty stop write timer.
1938
19392002-10-10 Greg Troxel <gdt@ir.bbn.com>
1940
1941 * ospf_packet.c (ospf_check_md5_digest): Change >= to > to make it
1942 conform to RFC.
1943
19442002-07-07 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1945
1946 * zebra-0.93 released.
1947
19482002-06-19 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1949
1950 * ospf_spf.c (ospf_nexthop_calculation): Add NULL set to oi and
1951 check of l2. Reported by: Daniel Drown <dan-zebra@drown.org>
1952 (ospf_lsa_has_link): LSA Length calculation fix. Reported by:
1953 Paul Jakma <paulj@alphyra.ie>.
1954
1955 * ospfd.c (ospf_if_update): Fix nextnode reference bug. Reported
1956 by: juris@mt.lv.
1957
19582002-01-21 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1959
1960 * ospfd.c: Merge [zebra 11445] Masahiko ENDO's Opaque-LSA support.
1961
19622001-08-27 Kunihiro Ishiguro <kunihiro@zebra.org>
1963
1964 * ospf_interface.c (ospf_add_to_if): Use /32 address to register
1965 OSPF interface information.
1966 (ospf_delete_from_if): Likewise.
1967
1968 * ospf_zebra.c (ospf_interface_address_delete): Likewise.
1969
19702001-08-23 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1971
1972 * ospf_zebra.c (ospf_redistribute_unset): When redistribute type
1973 is OSPF, do not unset redistribute flag.
1974
19752001-08-19 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1976
1977 * zebra-0.92a released.
1978
19792001-08-15 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1980
1981 * zebra-0.92 released.
1982
19832001-08-12 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1984
1985 * ospfd.c (ospf_config_write): auto-cost reference-bandwidth
1986 configuration display.
1987
19882001-07-24 David Watson <dwatson@eecs.umich.edu>
1989
1990 * ospf_spf.c (ospf_spf_next): Modify ospf_vertex_add_parent to
1991 check for an existing link before connecting the parent and child.
1992 ospf_nexthop_calculation is also modified to check for duplicate
1993 entries when copying from the parent. Finally, ospf_spf_next
1994 removes duplicates when it merges two equal cost candidates.
1995
19962001-07-23 itojun@iijlab.net
1997
1998 * ospfd.c (show_ip_ospf_neighbor): Check ospf_top before use it
1999 [zebra 8549].
2000
20012001-07-23 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
2002
2003 * ospf_packet.c (ospf_write): Remove defined(__OpenBSD__) to make
2004 it work on OpenBSD.
2005
20062001-06-26 Kunihiro Ishiguro <kunihiro@zebra.org>
2007
2008 * ospf_zebra.c (config_write_ospf_default_metric): Display
2009 default-metric configuration.
2010
20112001-06-18 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
2012
2013 * ospf_ia.h (OSPF_EXAMINE_SUMMARIES_ALL): Remove old macros.
2014
20152001-05-28 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
2016
2017 * ospf_snmp.c (ospfIfEntry): Fix interface lookup bug to avoid
2018 crush.
2019 (ospfIfMetricEntry): Likewise.
2020
20212001-03-18 Kunihiro Ishiguro <kunihiro@zebra.org>
2022
2023 * ospf_packet.c (ospf_read): Fix typo. Reported by: "Jen B
2024 Lin'Kova" <jen@stack.net>.
2025
20262001-03-15 Gleb Natapov <gleb@nbase.co.il>
2027
2028 * ospf_interface.c (ip_ospf_network): Set interface parameter.
2029 (interface_config_write): Add check for OSPF_IFTYPE_LOOPBACK.
2030
2031 * ospf_zebra.c (ospf_interface_add): Set interface parameter.
2032
20332001-02-21 Kunihiro Ishiguro <kunihiro@zebra.org>
2034
2035 * ospf_packet.c (ospf_recv_packet): Solaris also need to add
2036 (iph.ip_hl << 2) to iph.ip_len.
2037
20382001-02-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2039
2040 * ospfd.h (OSPF_LS_REFRESH_TIME): Fix OSPF_LS_REFRESH_TIME value.
2041 Suggested by: David Watson <dwatson@eecs.umich.edu>.
2042
2043 * ospf_zebra.c (zebra_init): Remove zebra node.
2044
2045 * ospfd.c (ospf_area_range_set): Function name is changed from
2046 ospf_ara_range_cmd.
2047 (ospf_area_range_unset): New function which separated from DEFUN.
2048 New commands are added:
2049 "no area A.B.C.D range A.B.C.D/M advertise"
2050 "no area <0-4294967295> range A.B.C.D/M advertise"
2051 "no area A.B.C.D range A.B.C.D/M not-advertise"
2052 "no area <0-4294967295> range A.B.C.D/M not-advertise"
2053
2054 * ospf_lsa.c (ospf_lsa_more_recent): Fix previous change.
2055
20562001-02-08 Matthew Grant <grantma@anathoth.gen.nz>
2057
2058 * ospf_network.c (ospf_if_add_allspfrouters): Use
2059 setsockopt_multicast_ipv4.
2060 (ospf_if_drop_allspfrouters): Likewise.
2061
2062 * ospf_lsa.c (ospf_router_lsa_install): Add rt_recalc flag.
2063 (ospf_network_lsa_install): Likewise.
2064 (ospf_summary_lsa_install): Likewise.
2065 (ospf_summary_asbr_lsa_install): Likewise.
2066 (ospf_external_lsa_install): Likewise.
2067 (ospf_lsa_install): Call ospf_lsa_different to check this LSA is
2068 new one or not.
2069
20702001-02-08 Kunihiro Ishiguro <kunihiro@zebra.org>
2071
2072 * ospf_zebra.c (ospf_interface_delete): Do not free interface
2073 structure when ospfd receive interface delete message to support
2074 pseudo interface.
2075
20762001-02-01 Dick Glasspool <dick@ipinfusion.com>
2077
2078 * ospfd.c (area_range_notadvertise): Change area range "suppress"
2079 command to "not-advertise".
2080
2081 * ospfd.h (OSPF_LS_REFRESH_TIME): Change OSPF_LS_REFRESH_TIME from
2082 1800 to 60.
2083
2084 * ospf_abr.c (ospf_abr_update_aggregate): When update_aggregate is
2085 updating the area-range, the lowest cost is now saved.
2086
2087 * ospf_lsa.c (ospf_lsa_more_recent): Routing to compare sequence
2088 numbers rather than creating overflow during calculation.
2089
20902001-02-01 Kunihiro Ishiguro <kunihiro@zebra.org>
2091
2092 * zebra-0.91 is released.
2093
20942001-01-31 Kunihiro Ishiguro <kunihiro@zebra.org>
2095
2096 * ospf_packet.c (ospf_db_desc_proc): Do not continue process when
2097 NSM_SeqNumberMismatch is scheduled.
2098 (ospf_ls_req): Free ls_upd when return from this function.
2099 (ospf_ls_upd_timer): When update list is empty do not call
2100 ospf_ls_upd_send(). Suggested by: endo@suri.co.jp (Masahiko
2101 Endo).
2102
21032001-01-26 Kunihiro Ishiguro <kunihiro@zebra.org>
2104
2105 * ospf_lsa.c (ospf_maxage_flood): Flood LSA when it reaches
2106 MaxAge. RFC2328 Section 14.
2107 (ospf_maxage_lsa_remover): Call above function during removing
2108 MaxAge LSA.
2109
21102001-01-26 Dick Glasspool <dick@ipinfusion.com>
2111
2112 * ospf_flood.c (ospf_flood_through_as): Function is updated for
2113 NSSA Translations now done at ospf_abr.c with no change in P-bit.
2114
2115 * ospf_lsa.c (ospf_get_nssa_ip): Get 1st IP connection for Forward
2116 Addr.
2117 (ospf_install_flood_nssa): Leave Type-7 LSA at Lock Count = 2.
2118
2119 * ospf_ase.c (ospf_ase_calculate_route): Add debug codes.
2120
2121 * ospf_abr.c (ospf_abr_translate_nssa): Recalculate LSA checksum.
2122
2123 * ospf_packet.h (OSPF_SEND_PACKET_LOOP): Added for test packet.
2124
2125 * ospf_dump.c (ospf_lsa_type_msg): Add OSPF_GROUP_MEMBER_LSA and
2126 OSPF_AS_NSSA_LSA.
2127
2128 * ospfd.c (data_injection): Function to inject LSA. This is
2129 debugging command.
2130
21312001-01-11 Kunihiro Ishiguro <kunihiro@zebra.org>
2132
2133 * ospf_route.c (ospf_route_match_same): Remove function.
2134 (ospf_route_match_same_new): Renamed to ospf_route_match_same.
2135
2136 * ospf_zebra.c (ospf_interface_address_delete): Add check for
2137 oi->address. Suggested by Matthew Grant
2138 <grantma@anathoth.gen.nz>.
2139 (ospf_zebra_add): Remove function.
2140 (ospf_zebra_add_multipath): Rename to ospf_zebra_add.
2141
2142 * ospf_interface.c: Remove HAVE_IF_PSEUDO part.
2143
2144 * ospf_zebra.c: Likewise.
2145
21462001-01-10 Kunihiro Ishiguro <kunihiro@zebra.org>
2147
2148 * ospf_ase.c: Remove OLD_RIB part.
2149
2150 * ospf_route.c: Likewise.
2151
2152 * zebra-0.90 is released.
2153
2154 * ospf_packet.c (ospf_recv_packet): Use ip_len adjestment code to
2155 NetBSD.
2156
21572001-01-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2158
2159 * ospf_route.c (ospf_route_delete): Use
2160 ospf_zebra_delete_multipath.
2161
21622001-01-09 Matthew Grant <grantma@anathoth.gen.nz>
2163
2164 * ospf_interface.c (ospf_if_cleanup): Function name is renamed
2165 from ospf_if_free(). Rewrite whole procudure to support primary
2166 address deletion.
2167
2168 * ospf_zebra.c (ospf_interface_address_delete): Add primary
2169 address deletion process.
2170
21712001-01-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2172
2173 * ospf_packet.c (ospf_recv_packet): OpenBSD has same ip_len
2174 treatment like FreeBSD.
2175
21762001-01-09 endo@suri.co.jp (Masahiko Endo)
2177
2178 * ospf_packet.c (ospf_recv_packet): FreeBSD kernel network code
2179 strips IP header size from receiving IP Packet. So we adjust
2180 ip_len to whole IP packet size by adding IP header size.
2181
21822001-01-08 endo@suri.co.jp (Masahiko Endo)
2183
2184 * ospf_network.c (ospf_serv_sock): When socket() is failed return
2185 immediately.
2186 (ospf_serv_sock): Close socket when it is not used.
2187
2188 * ospf_packet.c (ospf_write): Set sin_len when HAVE_SIN_LEN is
2189 defined.
2190 (ospf_write): When bind is fined, close sock.
2191
21922001-01-07 Gleb Natapov <gleb@nbase.co.il>
2193
2194 * ospf_zebra.c (ospf_interface_state_up): Fixes coredump that
2195 appears when you try to configure bandwidth on the ppp interface
2196 that is not yet configured in ospfd.
2197
21982001-01-07 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2199
2200 * ospf_route.c (show_ip_ospf_route_external): "show ip ospf route"
2201 will print nexthops for AS-external routes.
2202
2203 * ospf_ase.c (ospf_ase_route_match_same): New function to compare
2204 ASE route under multipath environment.
2205 (ospf_ase_compare_tables): Likewise.
2206
22072001-01-01 Kunihiro Ishiguro <kunihiro@zebra.org>
2208
2209 * ospfd.h (OSPF_VTYSH_PATH): Change "/tmp/ospfd" to "/tmp/.ospfd".
2210
22112000-12-28 Kunihiro Ishiguro <kunihiro@zebra.org>
2212
2213 * ospf_route.c (ospf_route_install): Install multipath information
2214 to zebra daemon.
2215
2216 * ospf_zebra.c (ospf_zebra_add_multipath): Function for passing
2217 multipath information to zebra daemon.
2218
22192000-12-25 Dick Glasspool <dick@ipinfusion.com>
2220
2221 * ospf_packet.c (ospf_write): Call ospf_packet_delete when sendto
2222 fail.
2223 (DISCARD_LSA): Add argument N for logging point of DISCARD_LSA is
2224 called.
2225
2226 * ospf_lsa.c (ospf_external_lsa_refresh): NSSA install_flood will
2227 leave Type-7 LSA at Lock Count = 2.
2228
2229 * ospf_flood.c (ospf_flood_through): Flood_though_as updated for
2230 NSSA no P-bit off during Area flooding, but P-bit is turned off
2231 for mulitple NSSA AS flooding.
2232
2233 * ospf_ase.c (ospf_ase_calculate_timer): Added calculations for
2234 Type-7 LSDB.
2235
2236 * ospf_abr.c (ospf_abr_translate_nssa): Removed one unlock call.
2237 (ospf_abr_announce_nssa_defaults): Corrected Debug from EVENT to
2238 NSSA.
2239
22402000-12-25 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2241
2242 * ospf_zebra.c (ospf_zebra_read_ipv4): Checking the age of the
2243 found LSA and if the LSA is MAXAGE we should call refresh instead
2244 of originate.
2245
22462000-12-18 Dick Glasspool <dick@ipinfusion.com>
2247
2248 * ospf_abr.c: Removed redundant "...flood" in
2249 announce_network_to_area(). Repaired nssa Unlock by using
2250 discard.
2251
2252 * ospf_packet.c: Removed old NSSA translate during mk_ls_update.
2253
2254 * ospfd.c: Free up all data bases including NSSA.
2255
2256 * ospf_lsa.c: Now allow removal of XLATE LSA's Check in
2257 discard_callback. Added routine to get ip addr from within the
2258 ifp.
2259
2260 * ospf_flood.c: Now set Forward Address for outgoing Type-7.
2261
2262 * ospf_lsa.h: Added prototype for the below. struct in_addr
2263 ospf_get_ip_from_ifp (struct interface *ifp).
2264
22652000-12-14 Gleb Natapov <gleb@nbase.co.il>
2266
2267 * ospf_packet.c (ospf_recv_packet): New OSPF pakcet read method.
2268 Now maximum packet length may be 65535 bytes (maximum IP packet
2269 length).
2270
2271 * ospf_interface.c (ospf_if_stream_set): Don't make input buffer.
2272
2273 * ospfd.c (config_write_network_area): Remove unnecessary area
2274 lookup code.
2275
22762000-12-13 Kunihiro Ishiguro <kunihiro@zebra.org>
2277
2278 * ospf_packet.c (ospf_read): Accept packet bigger than MTU value.
2279
22802000-12-13 Gleb Natapov <gleb@nbase.co.il>
2281
2282 * ospfd.c (config_write_network_area): Fix bug in
2283 config_write_network_area function.
2284
22852000-12-12 Gleb Natapov <gleb@nbase.co.il>
2286
2287 * ospf_abr.c (ospf_abr_announce_network_to_area): Make Summary
2288 LSA's origination and refreshment as same as other type of LSA.
2289
2290 * ospf_lsa.c (ospf_summary_lsa_refresh): Return struct ospf_lsa *.
2291
2292 * ospf_lsa.c (ospf_summary_asbr_lsa_refresh): Likewise.
2293
22942000-12-08 Dick Glasspool <dick@ipinfusion.com>
2295
2296 The bulk of NSSA changes are contained herein; This version will
2297 require manual setting of "always" for NSSA Translator, and will
2298 not perform aggregation yet.
2299
2300 * ospf_dump.c: "debug ospf nssa" is added.
2301
2302 * ospf_dump.h: Likewise.
2303
2304 * ospf_packet.c (ospf_hello): Display router ID on Bad NSSA Hello.
2305
2306 * ospfd.c: Discard_LSA to stay away from LOCAL_XLT Process NSSA
2307 'never, candidate, always'. Change "suppress" to "not-advertise".
2308
2309 * ospfd.h: Add TranslatorRole to struct ospf_area. Add anyNSSA to
2310 struct ospf.
2311
2312 * ospf_ase.c (ospf_ase_calculate_route): External to stay away
2313 from LOCAL_XLT
2314
2315 * ospf_nsm.c (ospf_db_summary_add): External to stay away from
2316 LOCAL_XLT
2317
2318 * ospf_abr.c: Major logic added for abr_nssa_task(). If ABR, and
2319 NSSA translator, then do it. Approve the global list, and flush
2320 any unapproved.
2321
2322 * ospf_lsa.h: New LSA flag OSPF_LSA_LOCAL_XLT to indicate that the
2323 Type-5 resulted from a Local Type-7 translation; not used for
2324 flooding, but used for flushing.
2325
2326 * ospf_flood.c: New NSSA flooding.
2327
23282000-12-08 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2329
2330 * ospfd.c (ospf_find_vl_data): New function for looking up virtual
2331 link data.
2332 (ospf_vl_set_security): Virtual link configuration with
2333 authentication.
2334 (ospf_vl_set_timers): Set timers for virtual link.
2335
2336 * New commands are added.
2337 "area A.B.C.D virtual-link A.B.C.D"
2338 "area A.B.C.D virtual-link A.B.C.D hello-interval <1-65535> retransmit-interval <3-65535> transmit-delay <1-65535> dead-interval <1-65535>"
2339 "area A.B.C.D virtual-link A.B.C.D hello-interval <1-65535> retransmit-interval <3-65535> transmit-delay <1-65535> dead-interval <1-65535> authentication-key AUTH_KEY"
2340 "area A.B.C.D virtual-link A.B.C.D authentication-key AUTH_KEY"
2341 "area A.B.C.D virtual-link A.B.C.D hello-interval <1-65535> retransmit-interval <3-65535> transmit-delay <1-65535> dead-interval <1-65535> message-digest-key <1-255> md5 KEY"
2342 "area A.B.C.D virtual-link A.B.C.D message-digest-key <1-255> md5 KEY"
2343
2344 * ospf_packet.c (ospf_check_md5_digest): Add neighbor's
2345 cryptographic sequence number treatment.
2346 (ospf_check_auth): OSPF input buffer is added to argument.
2347 (ospf_read): Save neighbor's cryptographic sequence number.
2348
2349 * ospf_nsm.c (nsm_change_status): Clear cryptographic sequence
2350 number when neighbor status is changed to NSM down.
2351
2352 * ospf_neighbor.c (ospf_nbr_new): Set zero to crypt_seqnum.
2353
2354 * ospf_neighbor.h (struct ospf_neighbor): Add cryptographic
2355 sequence number to neighbor structure.
2356
23572000-11-29 Kunihiro Ishiguro <kunihiro@zebra.org>
2358
2359 * ospf_snmp.c (ospfIfLookup): OSPF MIB updates.
2360 (ospfExtLsdbEntry): Add OspfExtLsdbTable treatment.
2361
23622000-11-28 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2363
2364 * ospfd.c (ospf_interface_down): Clear a ls_upd_queue queue of the
2365 interface.
2366 (ospf_ls_upd_queue_empty): New function to empty ls update queue
2367 of the OSPF interface.
2368 (no_router_ospf): 'no router ospf' unregister redistribution
2369 requests from zebra.
2370
23712000-11-28 Kunihiro Ishiguro <kunihiro@zebra.org>
2372
2373 * ospf_ism.c (ism_change_status): Increment status change number.
2374
2375 * ospf_interface.h (struct ospf_interface): Add new member for
2376 status change statistics.
2377
2378 * Makefile.am: Update dependencies.
2379
2380 * ospf_zebra.c (ospf_interface_add): OSPF SNMP interface update.
2381 (ospf_interface_delete): OSPF SNMP interface delete.
2382
2383 * ospf_snmp.h: New file is added.
2384
23852000-11-23 Dick Glasspool <dick@ipinfusion.com>
2386
2387 * ospfd.h: Add new ospf_area structure member for
2388 NSSATranslatorRole and NSSATranslator state.
2389
2390 * ospfd.c: Provided for eventual commands to specify NSSA
2391 elections for "translator- ALWAYS/NEVER/CANDIDATE". Provided for
2392 decimal integer version of area-suppress.
2393
2394 * ospf_flood.c: Flood Type-7's only into NSSA (not AS).
2395
2396 * ospf_lsa.c: Undo some previous changes for NSSA. If NSSA
2397 translator, advertise Nt bit.
2398
2399 * ospf_route.c: 1st version of "sh ip os border-routers".
2400
24012000-11-23 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2402
2403 * ospfd.c (area_vlink): Virtual link can not configured in stub
2404 area.
2405
24062000-11-23 Gleb Natapov <gleb@nbase.co.il>
2407
2408 * ospf_packet.c (ospf_db_desc): In states Loading and Full the
2409 slave must resend its last Database Description packet in response
2410 to duplicate Database Description packets received from the
2411 master. For this reason the slave must wait RouterDeadInterval
2412 seconds before freeing the last Database Description packet.
2413 Reception of a Database Description packet from the master after
2414 this interval will generate a SeqNumberMismatch neighbor
2415 event. RFC2328 Section 10.8
2416 (ospf_make_db_desc): DD Master flag treatment.
2417
2418 * ospf_nsm.c (nsm_twoway_received): Move DD related procedure to
2419 nsm_change_status().
2420 (nsm_bad_ls_req): Likewise.
2421 (nsm_adj_ok): Likewise.
2422 (nsm_seq_number_mismatch): Likewise.
2423 (nsm_oneway_received): Likewise.
2424
2425 * ospf_neighbor.h (struct ospf_neighbor): New structure member
2426 last_send_ts for timestemp when last Database Description packet
2427 was sent.
2428
2429 * ospf_nsm.c (ospf_db_desc_timer): Make it sure nbr->last_send is
2430 there. Call ospf_db_desc_resend() in any case.
2431
24322000-11-16 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2433
2434 * ospf_lsa.c (lsa_link_broadcast_set): When there is no DR on
2435 network (suppose you have only one router with interface priority
2436 0). It's router LSA does not contain the link information about
2437 this network.
2438
2439 * ospf_nsm.c (nsm_timer_set): When you change a priority of
2440 interface from/to 0 ISM_NeighborChange event should be scheduled
2441 in order to elect new DR/BDR on the network.
2442
2443 * ospf_interface.c (ip_ospf_priority): Likewise.
2444
2445 * ospf_flood.c (ospf_ls_retransmit_add): When we add some LSA into
2446 retransmit list we need to check whether the present old LSA in
2447 retransmit list is not more recent than the new
2448 one.
2449
24502000-11-09 Dick Glasspool <dick@ipinfusion.com>
2451
2452 * ospf_packet.c: Allows for NSSA Type-7 LSA's throughout the NSSA
2453 area. Any that exit the NSSA area are translated to type-5 LSA's.
2454 The instantiated image is restored after translation.
2455 (ospf_ls_upd_send_list): Renamed to ospf_ls_upd_queu_send().
2456 (ospf_ls_upd_send): Old function which enclosed by #ifdef 0 is
2457 removed.
2458 (ospf_ls_ack_send): Likewise.
2459
2460 * ospf_flood.c: NSSA-LSA's without P-bit will be restricted to
2461 local area. Otherwise they are allowed out the area to be
2462 translated by ospf_packet.c.
2463
2464 * ospf_lsa.c: Undo some previous changes for NSSA.
2465
2466 * ospf_lsdb.h: New access for type 7.
2467
24682000-11-07 Kunihiro Ishiguro <kunihiro@zebra.org>
2469
2470 * ospf_route.c (ospf_path_exist): New function to check nexthop
2471 and interface are in current OSPF path or not.
2472 (ospf_route_copy_nexthops_from_vertex): Add nexthop to OSPF path
2473 when it is not there. Reported by Michael Rozhavsky
2474 <mrozhavsky@opticalaccess.com>
2475
24762000-11-06 Kunihiro Ishiguro <kunihiro@zebra.org>
2477
2478 * ospf_dump.c (config_write_debug): Add seventh string "detail" is
2479 added for flag is OSPF_DEBUG_SEND | OSPF_DEBUG_RECV |
2480 OSPF_DEBUG_DETAIL.
2481
24822000-11-06 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2483
2484 * ospf_lsa.c (router_lsa_flags): ASBR can't exit in stub area.
2485
24862000-11-06 Kunihiro Ishiguro <kunihiro@zebra.org>
2487
2488 * ospf_lsa.c (ospf_router_lsa_originate): Reduce unconditional
2489 logging.
2490
24912000-11-06 Dick Glasspool <dick@ipinfusion.com>
2492
2493 * ospfd.h: Add ait_ntoa function prototype.
2494
2495 * ospfd.c (ait_ntoa): New function for displaying area ID and
2496 Stub/NSSA status.
2497 (show_ip_ospf_interface_sub): Use ait_ntoa.
2498 (show_ip_ospf_nbr_static_detail_sub): Likewise.
2499 (show_ip_ospf_neighbor_detail_sub): Likewise.
2500
2501 * ospf_route.c (ospf_intra_route_add): Set external routing type
2502 to ospf route.
2503 (ospf_intra_add_router): Likewise.
2504 (ospf_intra_add_transit): Likewise.
2505 (ospf_intra_add_stub): Likewise.
2506 (ospf_add_discard_route): Likewise.
2507 (show_ip_ospf_route_network): Use ait_ntoa.
2508 (show_ip_ospf_route_network): Likewise.
2509 (show_ip_ospf_route_router): Likewise.
2510
2511 * ospf_lsa.c (show_lsa_detail): Use ait_ntoa.
2512 (show_lsa_detail_adv_router): Likewise.
2513 (show_ip_ospf_database_summary): Likewise.
2514
2515 * ospf_route.h (struct route_standard): Add new member
2516 external_routing.
2517
2518 * ospf_ia.c (process_summary_lsa): Set external routing tyep to ospf
2519 route.
2520 (ospf_update_network_route): Likewise.
2521 (ospf_update_router_route): Likewise.
2522
25232000-11-04 Kunihiro Ishiguro <kunihiro@zebra.org>
2524
2525 * ospf_flood.c (ospf_process_self_originated_lsa): Enclose
2526 OSPF_AS_NSSA_LSA treatment with #ifdef HAVE_NSSA.
2527
25282000-11-03 Kunihiro Ishiguro <kunihiro@zebra.org>
2529
2530 * Unconditional logging is enclosed with if (IS_DEBUG_OSPF_EVENT).
2531 Please specify "debug ospf event" for enable logging.
2532
2533 * ospf_ism.c: Do not extern debug flag varible. It is done by
2534 ospf_debug.h
2535 * ospf_asbr.c: Likewise.
2536 * ospf_lsa.c: Likewise.
2537 * ospf_nsm.c: Likewise.
2538 * ospf_zebra.c: Likewise.
2539
2540 * ospf_dump.c (debug_ospf_event): New command "debug ospf event"
2541 is added.
2542
2543 * ospfd.c (router_ospf): Change logging from vty_out() to
2544 zlog_info().
2545 (ospf_area_stub_cmd): Likewise.
2546
2547 * ospf_dump.h: Extern term_debug flags.
2548 (OSPF_DEBUG_EVENT): Add new flag.
2549 (IS_DEBUG_OSPF_EVENT): Add new macro.
2550
25512000-11-03 Dick Glasspool <dick@ipinfusion.com>
2552
2553 * ospf_flood.c (ospf_process_self_originated_lsa):
2554 OSPF_AS_NSSA_LSA is treated as same as OSPF_AS_EXTERNAL_LSA.
2555 (ospf_flood): Type-5's have no change. Type-7's can be received,
2556 and will Flood the AS as Type-5's They will also flood the local
2557 NSSA Area as Type-7's. The LSDB will be updated as Type-5's, and
2558 during re-fresh will be converted back to Type-7's (if within an
2559 NSSA).
2560 (ospf_flood_through): Incoming Type-7's were allowed here if our
2561 neighbor was an NSSA. So Flood our area with the Type-7 and also
2562 if we are an ABR, flood thru AS as Type-5.
2563
2564 * ospf_lsa.c (ospf_external_lsa_refresh): Flood NSSA both NSSA
2565 area and other area.
2566
2567 * ospf_packet.c (ospf_db_desc_proc): When AS External LSA is
2568 exists in DD packet, make it sure that this area is not stub.
2569 (ospf_ls_upd_list_lsa): When LSA type is NSSA then set lsa's area
2570 to NULL.
2571 (ospf_ls_upd): If the LSA is AS External LSA and the area is stub
2572 then discard the lsa. If the LSA is NSSA LSA and the area is not
2573 NSSA then discard the lsa.
2574
25752000-11-03 Kunihiro Ishiguro <kunihiro@zebra.org>
2576
2577 * ospfd.c (ospf_interface_run): Fix bug of Hello packet's option
2578 is not properly set when interface comes up.
2579
25802000-11-02 Kunihiro Ishiguro <kunihiro@zebra.org>
2581
2582 * ospfd.h (OSPF_OPTION_O): Add new hello header option.
2583
25842000-11-01 Dick Glasspool <dick@ipinfusion.com>
2585
2586 * ospf_lsa.h: Define OSPF_MAX_LSA to 8 when HAVE_NSSA is enabled.
2587 (OSPF_GROUP_MEMBER_LSA): Define OSPF_GROUP_MEMBER_LSA.
2588
2589 * ospf_lsa.c (show_database_desc): Add "Group Membership LSA"
2590 string.
2591
25922000-10-31 Dick Glasspool <dick@ipinfusion.com>
2593
2594 * ospf_lsa.h (OSPF_AS_NSSA_LSA): Define OSPF_AS_NSSA_LSA.
2595
2596 * ospf_lsa.c (show_ip_ospf_database): NSSA database display
2597 function is added. ALIASES which have "show ip ospf database
2598 nssa-external" is added.
2599 (show_ip_ospf_border_routers): New command "show ip ospf
2600 border-routers" is added.
2601
26022000-10-30 Dick Glasspool <dick@ipinfusion.com>
2603
2604 * ospfd.c (router_ospf): NSSA Enabled message is added for
2605 testing.
2606 (ospf_area_type_set): Are type set for NSSA area.
2607 (ospf_area_stub_cmd): Special translation of no_summary into NSSA
2608 and summary information. If NSSA is enabled pass the information
2609 to ospf_area_type_set().
2610 (area_nssa): New commands are added:
2611 "area A.B.C.D nssa"
2612 "area <0-4294967295> nssa"
2613 "area A.B.C.D nssa no-summary"
2614 "area <0-4294967295> nssa no-summary"
2615 (ospf_no_area_stub_cmd): Special translation of no_summary into
2616 NSSA and summary information. If external_routing is
2617 OSPF_AREA_NSSA unset area with ospf_area_type_set (area,
2618 OSPF_AREA_DEFAULT).
2619 (show_ip_ospf_area): Display NSSA status.
2620 (config_write_ospf_area): Show NSSA configuration.
2621
2622 * ospf_packet.c (ospf_hello): For NSSA support, ensure that NP is
2623 on and E is off.
2624
26252000-10-26 Gleb Natapov <gleb@nbase.co.il>
2626
2627 * ospf_lsa.c (ospf_network_lsa_body_set): The network-LSA lists
2628 those routers that are fully adjacent to the Designated Router;
2629 each fully adjacent router is identified by its OSPF Router ID.
2630 The Designated Router includes itself in this list. RFC2328,
2631 Section 12.4.2.
2632
26332000-10-23 Jochen Friedrich <jochen@scram.de>
2634
2635 * ospf_snmp.c: ospf_oid and ospfd_oid are used in smux_open after
2636 it is registered. So those variables must be static.
2637
26382000-10-18 K N Sridhar <sridhar@euler.ece.iisc.ernet.in>
2639
2640 * ospfd.c: Add area_default_cost_decimal_cmd and
2641 no_area_default_cost_decimal_cmd alias.
2642
26432000-10-05 Gleb Natapov <gleb@nbase.co.il>
2644
2645 * ospfd.c (ospf_network_new): Fix setting area format.
2646 (no_router_ospf): Check area existance when calling
2647 ospf_interface_down().
2648
2649 * ospf_flood.c (ospf_external_info_check): Fix bug of refreshing
2650 default route.
2651
26522000-10-02 Kunihiro Ishiguro <kunihiro@zebra.org>
2653
2654 * zebra-0.89 is released.
2655
26562000-09-29 Kunihiro Ishiguro <kunihiro@zebra.org>
2657
2658 * ospf_snmp.c (ospfHostEntry): OSPF Host MIB is implemented.
2659
2660 * ospfd.c (ospf_nbr_static_cmp): OSPF neighbor is sorted by it's
2661 address.
2662
26632000-09-28 Michael Rozhavsky <mike@nbase.co.il>
2664
2665 * ospf_interface.c (ospf_if_free): Fix deleting self neighbor twice.
2666
26672000-09-27 Kunihiro Ishiguro <kunihiro@zebra.org>
2668
2669 * ospf_packet.c (ospf_read): Solaris on x86 has ip_len with host
2670 byte order.
2671
26722000-09-25 Toshiaki Takada <takada@zebra.org>
2673
2674 * ospfd.c (ospf_compatible_rfc1583), (no_ospf_compatible_rfc1583):
2675 Add CISCO compatible command.
2676
26772000-09-25 Kunihiro Ishiguro <kunihiro@zebra.org>
2678
2679 * ospf_abr.c (ospf_area_range_lookup): New function is added for
2680 area range lookup in OSPF-MIB.
2681 (ospf_area_range_lookup_next): Likewise.
2682
26832000-09-22 Kunihiro Ishiguro <kunihiro@zebra.org>
2684
2685 * ospfd.c (no_router_ospf): Delete virtual link before deleting
2686 area structure.
2687
2688 * ospf_lsa.c (ospf_external_lsa_refresh_type): Check
2689 EXTERNAL_INFO(type).
2690
2691 * ospfd.c (no_router_ospf): Call ospf_vl_delete() instead of
2692 ospf_vl_data_free().
2693
2694 * ospf_interface.c (ospf_vl_shutdown): Execute ISM_InterfaceDown
2695 when ospf_vl_shutdown is called.
2696 (ospf_vl_delete): Call ospf_vl_shutdown() to delete virtual link
2697 interface's thread.
2698
26992000-09-21 Gleb Natapov <gleb@nbase.co.il>
2700
2701 * ospf_lsa.c: New implementation of OSPF refresh.
2702
27032000-09-20 Kunihiro Ishiguro <kunihiro@zebra.org>
2704
2705 * ospf_snmp.c (ospfLsdbLookup): Add LSDB MIB implementation.
2706
27072000-09-18 Kunihiro Ishiguro <kunihiro@zebra.org>
2708
2709 * ospf_snmp.c (ospfStubAreaEntry): Add OSPF stub area MIB.
2710
27112000-09-18 Gleb Natapov <gleb@nbase.co.il>
2712
2713 * ospf_route.h (route_standard): Change member from `struct area'
2714 to area_id.
2715
2716 * ospf_abr.c (ospf_abr_announce_network), (ospf_abr_should_announce),
2717 (ospf_abr_process_network_rt), (ospf_abr_announce_rtr),
2718 (ospf_abr_process_router_rt):
2719 * ospf_ase.c (ospf_find_asbr_route),
2720 (ospf_find_asbr_router_through_area),
2721 * ospf_ia.c (ospf_find_abr_route), (ospf_ia_router_route),
2722 (process_summary_lsa), (ospf_update_network_route),
2723 (ospf_update_router_route):
2724 * ospf_route.c (ospf_intra_route_add), (ospf_intra_add_router),
2725 (ospf_intra_add_transit), (ospf_intra_add_stub),
2726 (ospf_route_table_dump), (show_ip_ospf_route_network),
2727 (show_ip_ospf_route_router), (ospf_asbr_route_cmp),
2728 (ospf_prune_unreachable_routers):
2729 * ospf_spf.c (ospf_rtrs_print):
2730 * ospfd.c (ospf_rtrs_free): Fix the struct change above.
2731
27322000-09-14 Kunihiro Ishiguro <kunihiro@zebra.org>
2733
2734 * ospf_network.c (ospf_serv_sock_init): Enclose SO_BINDTODEVICE
2735 with ifdef.
2736
27372000-09-13 Gleb Natapov <gleb@nbase.co.il>
2738
2739 * ospf_ism.c (ospf_elect_dr), (ospf_elect_bdr): Fix DR election.
2740
2741 * ospf_network.c (ospf_serv_sock_init): Add socket option
2742 SO_BINDTODEVICE on read socket.
2743
2744 * ospf_packet.c (ospf_hello): Ignore Hello packet if E-bit does
2745 not match.
2746
2747 * ospfd.c (ospf_area_check_free), (ospf_area_get),
2748 (ospf_area_add_if): New function added.
2749
27502000-09-13 Kunihiro Ishiguro <kunihiro@zebra.org>
2751
2752 * ospf_route.c (ospf_intra_add_router): Update ABR and ASBR router
2753 count.
2754
2755 * ospf_spf.c (ospf_spf_init): Rest ABR and ASBR router count
2756 starting SPF calculation.
2757
2758 * ospfd.h (struct ospf_area): Add ABR and ASBR router count.
2759
27602000-09-12 Kunihiro Ishiguro <kunihiro@zebra.org>
2761
2762 * ospfd.c (ospf_area_id_cmp): New area structure is sorted by area
2763 ID.
2764
2765 * ospf_lsa.c (ospf_router_lsa_originate): For OSPF MIB update
2766 lsa_originate_count.
2767 (ospf_network_lsa_originate): Likewise.
2768 (ospf_summary_lsa_originate): Likewise.
2769 (ospf_summary_asbr_lsa_originate): Likewise.
2770 (ospf_external_lsa_originate): Likewise.
2771
27722000-09-11 Kunihiro Ishiguro <kunihiro@zebra.org>
2773
2774 * ospf_snmp.c (ospf_variables): ospfRouterID's type RouterID
2775 syntax is IpAddress.
2776 (ospf_admin_stat): New function for OSPF administrative status
2777 check.
2778
27792000-09-10 Jochen Friedrich <jochen@scram.de>
2780
2781 * ospf_snmp.c: Implement OSPF MIB skeleton.
2782
27832000-09-08 Kunihiro Ishiguro <kunihiro@zebra.org>
2784
2785 * ospf_snmp.c: New file is added.
2786
27872000-09-07 David Lipovkov <davidl@nbase.co.il>
2788
2789 * ospf_zebra.c (ospf_interface_delete): Add pseudo interface
2790 treatment.
2791
2792 * ospf_interface.c (interface_config_write): Likewise.
2793
27942000-08-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2795
2796 * zebra-0.88 is released.
2797
27982000-08-17 Michael Rozhavsky <mike@nbase.co.il>
2799
2800 * ospfd.c (ospf_area_free): Remove virtual link configuration only
2801 when Area is removed.
2802
28032000-08-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2804
2805 * ospfd.c (network_area): Revert check for EXTERNAL_INFO
2806 (ZEBRA_ROUTE_CONNECT).
2807 (no_network_area): Likewise.
2808
28092000-08-16 Kunihiro Ishiguro <kunihiro@zebra.org>
2810
2811 * ospfd.h (struct ospf): Add distance_table and
2812 distance_{all,intra,inter,external}.
2813
2814 * ospf_zebra.c: Add OSPF distance related functions.
2815
28162000-08-15 Gleb Natapov <gleb@nbase.co.il>
2817
2818 * ospf_asbr.c (ospf_external_info_find_lsa): New function added.
2819
2820 * ospf_lsa.c (ospf_default_external_info),
2821 (ospf_default_originate_timer), (ospf_external_lsa_refresh_default):
2822 New function added.
2823
2824 * ospf_zebra.c
2825 (ospf_default_information_originate_metric_type_routemap),
2826 (ospf_default_information_originate_always_metric_type_routemap):
2827 Change name and add route-map function.
2828 (ospf_default_information_originate_metric_routemap),
2829 (ospf_default_information_originate_routemap),
2830 (ospf_default_information_originate_type_metric_routemap):
2831 New DEFUN added.
2832
28332000-08-14 Kunihiro Ishiguro <kunihiro@zebra.org>
2834
2835 * ospf_zebra.c (zebra_interface_if_set_value): Change ifindex
2836 restore size from two octet to four.
2837
28382000-08-14 Michael Rozhavsky <mike@nbase.co.il>
2839
2840 * ospf_ase.c (ospf_ase_incremental_update): Implement incremental
2841 AS-external-LSA in 16.6 of RFC2328.
2842
28432000-08-14 Matthew Grant <grantma@anathoth.gen.nz>
2844
2845 * ospf_interface.c (ospf_if_get_output_cost): Change cost
2846 calculation algorithm.
2847
2848 * ospf_packet (ospf_ls_upd): Fix problem of LSA retransmitting.
2849
28502000-08-11 Michael Rozhavsky <mike@nbase.co.il>
2851
2852 * ospf_lsa.c (ospf_maxage_lsa_remover): Fix maxage remover for
2853 AS-external-LSAs.
2854
28552000-08-10 Toshiaki Takada <takada@zebra.org>
2856
2857 * ospfd.c (auto_cost_reference_bandwidth): New DEFUN added.
2858 `auto-cost reference-bandwidth' OSPF router command added.
2859
28602000-08-08 Gleb Natapov <gleb@nbase.co.il>
2861
2862 * ospf_routemap.c (ospf_route_map_update): New function added.
2863 Add route-map event hook.
2864
28652000-08-08 Toshiaki Takada <takada@zebra.org>
2866
2867 * ospf_zebra.c (ospf_distribute_check_connected): If redistribute
2868 prefix is connected route on OSPF enabled interface, suppress to
2869 announce it.
2870
28712000-08-08 Matthew Grant <grantma@anathoth.gen.nz>
2872
2873 * ospf_interface.c (ospf_if_get_output_cost):
2874 New function added. Handle bandwidth parameter for cost
2875 calculation.
2876
28772000-08-08 Michael Rozhavsky <mike@nbase.co.il>
2878
2879 * ospf_interface.c (interface_config_write): Show interface
2880 configuration regardless interface is down.
2881
2882 * ospf_ase.c (ospf_ase_caocluate_route): Whole rewritten external
2883 route calculate function.
2884
28852000-08-08 Gleb Natapov <gleb@nbase.co.il>
2886
2887 * ospf_routemap.c: New file added.
2888
2889 * ospf_asbr.c (ospf_reset_route_map_set_values),
2890 (ospf_route_map_set_compare): New function added.
2891
2892 * ospf_lsa.c (ospf_external_lsa_body_set): Set routemap metric
2893 with AS-external-LSA.
2894
28952000-08-05 Kunihiro Ishiguro <kunihiro@zebra.org>
2896
2897 * ospf_ase.c (ospf_ase_calculate_route_add): Pass new->cost to
2898 ospf_zebra_add as metric.
2899 (ospf_ase_calculate_route_add): Likewise.
2900
2901 * ospf_route.c (ospf_route_install): Pass or->cost to
2902 ospf_zebra_add as metric.
2903
2904 * ospf_zebra.c (ospf_zebra_add): Add metric arguemnt.
2905 (ospf_zebra_delete): Likewise.
2906
29072000-08-03 Matthew Grant <grantma@anathoth.gen.nz>
2908
2909 * ospf_flood.c (ospf_flood_delayed_lsa_ack): New function added.
2910 Dispatch delayed-ACK with flooding AS-external-LSA across virtual
2911 link.
2912
29132000-07-31 Matthew Grant <grantma@anathoth.gen.nz>
2914
2915 * ospfd.c (show_ip_ospf_area): Fix lack of VTY_NEWLINE when
2916 `show ip ospf'.
2917
2918 * ospf_interface.c (ospf_if_free): Fix bug of crash with
2919 Point-to-Point interface.
2920
29212000-07-27 Michael Rozhavsky <mike@nbase.co.il>
2922
2923 * ospf_flood.c (ospf_process_self_originated_lsa):
2924 Make sure to clear LSA->param (redistributed external information)
2925 before refreshment.
2926
29272000-07-27 Gleb Natapov <gleb@nbase.co.il>
2928
2929 * ospfd.c (refresh_group_limit), (refresh_per_slice),
2930 (refresh_age_diff): New defun added. Refresher related parameter
2931 can be configurable.
2932
29332000-07-27 Akihiro Mizutani <mizutani@dml.com>
2934
2935 * ospf_interface.c (interface_config_write): Print `description'
2936 config directive to work.
2937
29382000-07-24 Akihiro Mizutani <mizutani@dml.com>
2939
2940 * ospf_interface.c (ospf_if_init): Use install_default for
2941 INTERFACE_NODE.
2942
29432000-07-24 Gleb Natapov <gleb@nbase.co.il>
2944
2945 * ospf_packet.c (ospf_ls_upd_send_list), (ospf_ls_upd_send_event),
2946 (ospf_ls_ack_send_list), (ospf_ls_ack_send_event): New function added.
2947 This make sending always as many LS update/Ack combined in one ospf
2948 packet.
2949
29502000-07-24 Gleb Natapov <gleb@nbase.co.il>
2951
2952 * ospf_packet.c (ospf_ls_upd_list_lsa): Set NULL to lsa->area if
2953 LSA is AS-external-LSA.
2954
2955 * ospf_nsm.c (nsm_reset_nbr): Do not cancel Inactivity timer.
2956
29572000-07-21 Toshiaki Takada <takada@zebra.org>
2958
2959 * ospf_zebra.c (ospf_default_originate_timer): Set timer for
2960 `default-information originate'. Fix some default originate
2961 related functions.
2962
29632000-07-12 Toshiaki Takada <takada@zebra.org>
2964
2965 * ospf_lsa.c (stream_put_ospf_metric): New function added.
2966
29672000-07-12 Toshiaki Takada <takada@zebra.org>
2968
2969 * ospf_lsa.c (show_ip_ospf_database_router),
2970 (show_ip_ospf_database_network), (show_ip_ospf_database_summary),
2971 (show_ip_ospf_database_summary_asbr), (show_ip_ospf_database_externel),
2972 (show_router_lsa), (show_any_lsa), (show_router_lsa_self),
2973 (show_any_lsa_self): Functions removed.
2974
2975 (show_lsa_prefix_set), (show_lsa_detail_proc), (show_lsa_detail),
2976 (show_lsa_detail_adv_router_proc), (show_lsa_detail_adv_router):
2977 New functions added. Replace above functions.
2978
2979 (show_ip_ospf_database_all), (show_ip_ospf_database_self_originated):
2980 Functions removed.
2981 (show_ip_ospf_database_summary): New functions added. Replace
2982 above functions.
2983
2984 (show_ip_ospf_database_cmd): DEFUN rearranged.
2985 (show_ip_ospf_database_type_id_cmd),
2986 (show_ip_ospf_database_type_id_adv_router_cmd),
2987 (show_ip_ospf_database_type_is_self_cmd): New ALIASes added.
2988 (show_ip_ospf_database_type_adv_rotuer_cmd): New DEFUN added.
2989 (show_ip_ospf_database_type_self_cmd): New ALIAS added.
2990
29912000-07-11 Toshiaki Takada <takada@zebra.org>
2992
2993 * ospf_asbr.c (ospf_external_info_new),
2994 (ospf_external_info_free): New functions added.
2995
2996 * ospf_lsa.h (ospf_lsa): Add new member `void *param' to set
2997 origination parameter for external-LSA.
2998 Remove member `redistribute'.
2999
3000 * ospf_zebra.c (ospf_redistirbute_set): When `redistribute'
3001 command executed, metric and metric-type values are overridden.
3002 If one of those is changed refresh AS-external-LSAs for appropriate
3003 type.
3004
30052000-07-11 Michael Rozhavsky <mike@nbase.co.il>
3006
3007 * ospf_lsa.c (ospf_summary_lsa_refresh),
3008 (ospf_summary_asbr_lsa_refresh): Make sure to refresh summary-LSAs.
3009
3010 * ospf_abr.c (set_metric): New function added.
3011
30122000-07-07 Toshiaki Takada <takada@zebra.org>
3013
3014 * ospf_zebra.c (ospf_default_information_originate_metric_type),
3015 (ospf_default_information_originate_type_metric): New defun added.
3016 Metic and Metric type can be set to default route.
3017 (ospf_default_information_originate_always_metric_type):
3018 (ospf_default_information_originate_always_type_metric):
3019 New defun added. Metric and Metric type can be set to default
3020 always route.
3021
3022 * ospf_zebra.c (ospf_default_metric), (no_ospf_default_metric):
3023 New defun added.
3024
30252000-07-06 Gleb Natapov <gleb@nbase.co.il>
3026
3027 * ospf_flood.c (ospf_flood_through_area): Fix bug of considering
3028 on the same interface the LSA was received from.
3029
30302000-07-06 Michael Rozhavsky <mike@nbase.co.il>
3031
3032 * ospfd.c (ospf_config_write): Fix bug of printing `area stub'
3033 command with `write mem'.
3034
3035 * ospfd.c (no_router_ospf): Remove installed routes from zebra.
3036
3037 * ospf_zebra.c (ospf_interface_delete): Fix function to handle
3038 zebra interface delete event.
3039
30402000-07-06 Toshiaki Takada <takada@zebra.org>
3041
3042 * ospf_zebra.c (ospf_default_information_originate),
3043 (ospf_default_information_originate_always): New DEFUN added.
3044
30452000-07-05 Michael Rozhavsky <mike@nbase.co.il>
3046
3047 * ospf_route.c (ospf_terminate): Make sure to remove external route
3048 when SIGINT received.
3049
30502000-07-03 Gleb Natapov <gleb@nbase.co.il>
3051
3052 * ospf_flood.c, ospf_ism.c, ospf_lsa,c, ospfd.c: Make sure to free
3053 many structure with `no router ospf'.
3054
30552000-06-30 Gleb Natapov <gleb@nbase.co.il>
3056
3057 * ospf_neighbor.c (ospf_nbr_new),
3058 ospf_nsm.c (nsm_timer_set): Start LS update timer only
3059 when neighbor enters Exchange state.
3060
30612000-06-29 Gleb Natapov <gleb@nbase.co.il>
3062
3063 * ospf_nsm.c (nsm_timer_set), (nsm_exchange_done),
3064 ospf_packet.c (ospf_db_desc_proc):
3065 Do not cancel DD retransmit timer when Master.
3066
30672000-06-29 Gleb Natapov <gleb@nbase.co.il>
3068
3069 * ospf_abr.c (ospf_abr_announce_network_to_area),
3070 (ospf_abr_announce_rtr_to_area)
3071 ospf_ase.c (ospf_ase_rtrs_register_lsa),
3072 ospf_flood.c (ospf_process_self_originated_lsa),
3073 (ospf_flood_through_area), (ospf_ls_request_delete),
3074 ospf_interface.c (ospf_if_free),
3075 ospf_ism.c (ism_change_status),
3076 ospf_lsa.c (ospf_router_lsa_update_timer),
3077 (ospf_router_lsa_install), (ospf_network_lsa_install),
3078 (ospf_lsa_maxage_delete), (ospf_lsa_action),
3079 (ospf_schedule_lsa_flood_area),
3080 ospf_nsm.c (nsm_change_status),
3081 ospf_packet.c (ospf_make_ls_req_func), (ospf_make_ls_ack):
3082 Use ospf_lsa_{lock,unlock} for all looking-up of LSA.
3083
3084 * ospf_flood.c (ospf_ls_request_free): Function deleted.
3085
3086 * ospf_lsa.c (ospf_discard_from_db): New function added.
3087
30882000-06-26 Toshiaki Takada <takada@zebra.org>
3089
3090 * ospfd.h (ospf): struct member `external_lsa' name changed to
3091 `lsdb'.
3092
30932000-06-26 Toshiaki Takada <takada@zebra.org>
3094
3095 * ospf_lsa.c (ospf_lsa_install), (ospf_router_lsa_install),
3096 (ospf_network_lsa_install), (ospf_summary_lsa_install),
3097 (ospf_summary_asbr_lsa_install), (ospf_external_lsa_install):
3098 Functions re-arranged.
3099
3100 * ospf_lsa.c (IS_LSA_MAXAGE), (IS_LSA_SELF): Macro added.
3101
31022000-06-20 Michael Rozhavsky <mike@nbase.co.il>
3103
3104 * ospf_packet.c (ospf_ls_req), (ospf_ls_upd), (ospf_ls_ack): Add
3105 verification of LS type.
3106
31072000-06-20 Gleb Natapov <gleb@nbase.co.il>
3108
3109 * ospf_ase.c (ospf_ase_calculate_timer): Add more sanity check
3110 whether rn->info is NULL.
3111
31122000-06-20 Toshiaki Takada <takada@zebra.org>
3113
3114 * ospfd.c (show_ip_ospf_interface_sub): Show Router-ID of both
3115 DR and Backup correctly with `show ip ospf interface' command.
3116
31172000-06-20 Toshiaki Takada <takada@zebra.org>
3118
3119 * ospf_lsa.c (ospf_lsa_lock), (ospf_lsa_unlock),
3120 (ospf_lsa_discard): These functions are used for avoiding
3121 unexpected reference to freed LSAs.
3122
31232000-06-13 Kunihiro Ishiguro <kunihiro@zebra.org>
3124
3125 * ospf_packet.c (ospf_ls_upd): Initialize lsa by NULL to avoid
3126 warning.
3127
31282000-06-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3129
3130 * ospf_ase.h (ospf_ase_rtrs_register_lsa): Add prototype.
3131
31322000-06-12 Toshiaki Takada <takada@zebra.org>
3133
3134 * ospf_lsa.c (ospf_external_lsa_install): Make sure to register
3135 LSA to rtrs_external when replacing AS-external-LSAs in LSDB.
3136 Fix core dump.
3137
31382000-06-10 Toshiaki Takada <takada@zebra.org>
3139
3140 * ospf_lsdb.c (id_to_prefix), (ospf_lsdb_hash_key),
3141 (ospf_lsdb_hash_cmp), (ospf_lsdb_new), (ospf_lsdb_iterator),
3142 (lsdb_free), (ospf_lsdb_free), (ospf_lsdb_add), (ospf_lsdb_delete),
3143 (find_lsa), (ospf_lsdb_lookup), (find_by_id),
3144 (ospf_lsdb_lookup_by_id), (ospf_lsdb_lookup_by_header): Functinos
3145 removed for migration to new_lsdb.
3146
3147 * ospf_lsa.c (ospf_summary_lsa_install),
3148 (ospf_summary_asbr_lsa_install), (ospf_maxage_lsa_remover),
3149 (ospf_lsa_maxage_walker), (ospf_lsa_lookup),
3150 (ospf_lsa_lookup_by_id): Use new_lsdb instead of ospf_lsdb.
3151 (count_lsa), (ospf_lsa_count_table), (ospf_lsa_count),
3152 (ospf_get_free_id_for_prefix): Funcitions removed.
3153
31542000-06-09 Gleb Natapov <gleb@nbase.co.il>
3155
3156 * ospf_ism.c (ism_interface_down): Prevent some unneeded DR changes.
3157
3158 * ospf_packet.c (ospf_db_desc_proc): Fix memory leak.
3159 (ospf_hello): Always copy router-ID when hello is received.
3160
31612000-06-08 Gleb Natapov <gleb@nbase.co.il>
3162
3163 * ospf_lsa.h (struct ospf_lsa): Add member of pointer to struct
3164 ospf_area.
3165
31662000-06-08 Michael Rozhavsky <mike@nbase.co.il>
3167
3168 * ospf_ase.c (ospf_asbr_route_same): New function added.
3169 This function makes sure external route calculation more
3170 precisely.
3171
31722000-06-07 Michael Rozhavsky <mike@nbase.co.il>
3173
3174 * ospf_ism.c (ism_change_status): Use ospf_lsa_flush_area for
3175 network-LSA deletion instead of using ospf_lsdb_delete.
3176 Also cancel network-LSA origination timer.
3177
31782000-06-07 Levi Harper <lharper@kennedytech.com>
3179
3180 * ospf_interface.c (ospf_if_down): Close read fd when an interface
3181 goes down.
3182
31832000-06-05 Kunihiro Ishiguro <kunihiro@zebra.org>
3184
3185 * ospf_asbr.c (ospf_external_info_lookup): Add explicit brace for
3186 avoid ambiguous else.
3187
3188 * ospf_flood.c (ospf_external_info_check): Likewise.
3189
31902000-06-05 Toshiaki Takada <takada@zebra.org>
3191
3192 * ospf_nsm.c (nsm_adj_ok): Fix bug of DR election.
3193
31942000-06-04 Toshiaki Takada <takada@zebra.org>
3195
3196 * ospf_zebra.c (ospf_default_information_originate),
3197 (no_ospf_default_information_originate): New DEFUN added.
3198
31992000-06-03 Toshiaki Takada <takada@zebra.org>
3200
3201 * ospf_lsa.h, ospf_asbr.h (external_info): Struct moved from
3202 ospf_lsa.h to ospf_asbr.h.
3203
3204 * ospf_lsa.c, ospf_asbr.c (ospf_external_info_add),
3205 (ospf_external_info_delete): Function moved from ospf_lsa.c
3206 to ospf_asbr.c.
3207
32082000-06-03 Toshiaki Takada <takada@zebra.org>
3209
3210 * ospf_flood.c (ospf_external_info_check): New function added.
3211 (ospf_process_self_orignated_lsa): Make sure to flush
3212 self-originated AS-external-LSA, when router reboot and no longer
3213 originate those AS-external-LSA.
3214
32152000-06-02 Toshiaki Takada <takada@zebra.org>
3216
3217 * ospf_network.c (ospf_serv_sock): Remove SO_DONTROUTE
3218 socket option.
3219
3220 * ospf_packet.c (ospf_write): Set MSG_DONTROUTE flag for
3221 unicast destination packets.
3222
32232000-06-02 Toshiaki Takada <takada@zebra.org>
3224
3225 * ospf_lsdb.c (new_lsdb_delete): Delete entry from LSDB only when
3226 specified LSA matches.
3227
32282000-06-02 Gleb Natapov <gleb@nbase.co.il>
3229
3230 * ospf_network.c (ospf_serv_sock): Set SO_DONTROUTE
3231 socket option.
3232
32332000-06-01 Akihiro Mizutani <mizutani@dml.com>
3234
3235 * ospf_dump.c: Replace string `Debugging functions\n' with DEBUG_STR.
3236 Replace string `OSPF information\n' with OSPF_STR.
3237
32382000-06-01 Toshiaki Takada <takada@zebra.org>
3239
3240 * ospf_lsdb.[ch]: Use new_lsdb struct for network-LSA instead of
3241 ospf_lsdb.
3242
32432000-06-01 Toshiaki Takada <takada@zebra.org>
3244
3245 * ospf_dump.c (config_debug_ospf_packet), (config_debug_ospf_event),
3246 (config_debug_ospf_ism), (config_debug_ospf_nsm),
3247 (config_debug_ospf_lsa), (config_debug_ospf_zebra),
3248 (term_debug_ospf_packet), (term_debug_ospf_event),
3249 (term_debug_ospf_ism), (term_debug_ospf_nsm),
3250 (term_debug_ospf_lsa), (term_debug_ospf_zebra): Repalce debug_ospf_*
3251 variable to use for debug option flags.
3252
3253 (debug_ospf_packet), (debug_ospf_ism), (debug_ospf_nsm),
3254 (debug_ospf_lsa), (debug_ospf_zebra): Set {config,term}_debug_*
3255 flags when vty->node is CONFIG_NODE, otherwise set only term_debug_*
3256 flags.
3257
3258 * ospf_dump.h (CONF_DEBUG_PACKET_ON), (CONF_DEBUG_PACKET_OFF),
3259 (TERM_DEBUG_PACKET_ON), (TERM_DEBUG_PACKET_OFF),
3260 (CONF_DEBUG_ON), (CONF_DEBUG_OFF), (IS_CONF_DEBUG_OSPF_PACKET),
3261 (IS_CONF_DEBUG_OSPF): New Macro added.
3262
32632000-05-31 Toshiaki Takada <takada@zebra.org>
3264
3265 * ospfd.c (clear_ip_ospf_neighbor): New DEFUN added.
3266 Currently this command is used for only debugging.
3267
3268 * ospf_nsm.c (nsm_change_status): Make sure thread cancellation
3269 for network-LSA when DR has no full neighbors.
3270
3271 * ospf_nsm.c (ospf_db_summary_clear): New function added.
3272
32732000-05-30 Toshiaki Takada <takada@zebra.org>
3274
3275 * ospf_lsdb.c (new_lsdb_insert): LSAs are always freed by
3276 maxage_lsa_remover when LSA is replaced.
3277
32782000-05-25 Gleb Natapov <gleb@nbase.co.il>
3279
3280 * ospf_flood.c (ospf_ls_retransmit_delete_nbr_all): Add argument
3281 `struct ospf_area' to remove LSA from Link State retransmission list
3282 of neighbor from only one Area.
3283
32842000-05-24 Michael Rozhavsky <mike@nbase.co.il>
3285
3286 * ospf_lsdb.c (ospf_lsdb_add): Preserve flags field when
3287 overriting old LSA with new LSA.
3288
32892000-05-24 Gleb Natapov <gleb@nbase.co.il>
3290
3291 * ospf_lsa.c (ospf_router_lsa_body_set): Fix bug of router-LSA
3292 size calculation.
3293
32942000-05-22 Michael Rozhavsky <mike@nbase.co.il>
3295
3296 * ospf_route.c (ospf_intra_add_stub):
3297 * ospf_spf.h (struct vertex): Use u_int32_t for distance (cost)
3298 value instead of u_int16_t.
3299
33002000-05-22 Axel Gerlach <agerlach@datus.datus.com>
3301
3302 * ospf_ia.c (ospf_ia_network_route): Fix bug of Inter-area route
3303 equal cost path calculation.
3304
33052000-05-21 Toshiaki Takada <takada@zebra.org>
3306
3307 * ospf_ase.c (ospf_ase_calculate_route_delete): New function added.
3308 Make sure, when rotuer route is deleted, related external routes
3309 are also deleted.
3310
33112000-05-20 Toshiaki Takada <takada@zebra.org>
3312
3313 * ospfd.c (ospf_interface_down): Make sure interface flag is disable
3314 and set fd to -1.
3315
33162000-05-16 Toshiaki Takada <takada@zebra.org>
3317
3318 * ospf_asbr.c (ospf_asbr_should_announce), (ospf_asbr_route_remove):
3319 Functions removed.
3320
3321 * ospfd.h (EXTERNAL_INFO): Macro added.
3322 Substitute `ospf_top->external_info[type]' with it.
3323
33242000-05-16 Toshiaki Takada <takada@zebra.org>
3325
3326 * ospf_lsa.c (ospf_rtrs_external_remove): New function added.
3327
33282000-05-14 Gleb Natapov <gleb@nbase.co.il>
3329
3330 * ospf_flood.c (ospf_ls_retransmit_delete_nbr_all)
3331 * ospf_lsdb.c (new_lsdb_insert)
3332 * ospf_packet.c (ospf_ls_ack): Fix database synchonization problem.
3333
33342000-05-14 Gleb Natapov <gleb@nbase.co.il>
3335
3336 * ospf_lsa.h (tv_adjust), (tv_ceil), (tv_floor), (int2tv),
3337 (tv_add), (tv_sub), (tv_cmp): Prototype definition added.
3338
3339 * ospf_nsm.h (ospf_db_summary_delete_all): Prototype definition added.
3340
33412000-05-13 Toshiaki Takada <takada@zebra.org>
3342
3343 * ospf_lsa.[ch] (ospf_lsa): struct timestamp type is changed from
3344 time_t to struct timeval.
3345 (tv_adjust), (tv_ceil), (tv_floor), (int2tv), (tv_add),
3346 (tv_sub), (tv_cmp): timeval utillity functions added.
3347
33482000-05-12 Toshiaki Takada <takada@zebra.org>
3349
3350 * ospf_lsa.[ch] (ospf_schedule_update_router_lsas): Delete function.
3351 Change to use macro OSPF_LSA_UPDATE_TIMER instead of using
3352 this function.
3353 router-LSA refresh timer related stuff is re-organized.
3354
33552000-05-10 Gleb Natapov <gleb@nbase.co.il>
3356
3357 * ospf_interface.c (ospf_vl_set_params):
3358 * ospf_packet.c (ospf_check_network_mask):
3359 * ospf_spf.[ch] (ospf_spf_next):
3360 Remove field address from `struct vertex', and search for peer
3361 address of virtual link in function `ospf_vl_set_params' instead.
3362
33632000-05-10 Gleb Natapov <gleb@nbase.co.il>
3364
3365 * ospf_packet.c (ospf_ls_upd): Fix some memory leak related LSA.
3366
33672000-05-08 Thomas Molkenbur <tmo@datus.com>
3368
3369 * ospf_packet.c (ospf_packet_dup): Replace ospf_steram_copy()
3370 with ospf_stream_dup() to fix memory leak.
3371
33722000-05-08 Michael Rozhavsky <mike@nbase.co.il>
3373
3374 * ospf_flood.c (ospf_flood_through_area): Fix the problem of
3375 LSA update without DROther.
3376
33772000-05-04 Gleb Natapov <gleb@nbase.co.il>
3378
3379 * ospf_spf.c (ospf_vertex_free): Fix memory leak of SPF calculation.
3380
33812000-05-03 Toshiaki Takada <takada@zebra.org>
3382
3383 * ospf_neighbor.c (ospf_db_summary_add): Use new_lsdb struct
3384 instead linked-list.
3385 (ospf_db_summary_count), (ospf_db_summary_isempty):
3386 New function added.
3387
3388 * ospf_lsa.c (ospf_rotuer_lsa): Re-arrange and divide functions.
3389
33902000-05-02 Gleb Natapov <gleb@nbase.co.il>
3391
3392 * ospf_lsdb.c (new_lsdb_cleanup): Fix memory leak. When LSDB are
3393 not needed any more, then free them.
3394
33952000-05-02 Toshiaki Takada <takada@zebra.org>
3396
3397 * ospfd.c (timers_spf), (no_timers_spf): New defun added.
3398 SPF calculation timers related stuff is rearranged.
3399
3400 * ospf_spf.c (ospf_spf_calculate_timer_add): Function removed.
3401 SPF timer is scheduled by SPF calculation delay and holdtime
3402 configuration variable.
3403
3404 * ospf_lsa.c (ospf_external_lsa_nexthop_get): Set AS-external-LSA's
3405 forwarding address when nexthop learned by other protocols is
3406 in the OSPF domain.
3407
3408 * ospf_zebra.c (ospf_redistribute_source_metric_type),
3409 (ospf_redistribute_source_type_metric): Re-arrange DEFUNs and
3410 ALIASes.
3411
34122000-05-01 Toshiaki Takada <takada@zebra.org>
3413
3414 * ospf_flood.c (ospf_ls_retransmit_count),
3415 (ospf_ls_retransmit_isempty): New function added.
3416
3417 (ospf_ls_retransmit_add), (ospf_ls_retransmit_delete),
3418 (ospf_ls_retransmit_clear), (ospf_ls_retransmit_lookup),
3419 (ospf_ls_retransmit_delete_all), (ospf_ls_retransmit_delete_nbr_all),
3420 (ospf_ls_retransmit_add_nbr_all): Replace these functions to use
3421 new_lsdb.
3422
34232000-04-29 Toshiaki Takada <takada@zebra.org>
3424
3425 * ospfd.c (no_network_area): Add check Area-ID whether specified
3426 Area-ID with prefix matches config.
3427
34282000-04-27 Toshiaki Takada <takada@zebra.org>
3429
3430 * ospf_lsa.c (ospf_maxage_lsa_remover): Fix problem of
3431 remaining withdrawn routes on zebra.
3432
34332000-04-25 Michael Rozhavsky <mike@nbase.co.il>
3434
3435 * ospf_nsm.c (nsm_kill_nbr), (nsm_ll_down), (nsm_change_status),
3436 (ospf_nsm_event): Fix network-LSA re-origination problem.
3437
34382000-04-24 Toshiaki Takada <takada@zebra.org>
3439
3440 * ospf_nsm.c (ospf_db_desc_timer): Fix bug of segmentation fault
3441 with DD retransmission.
3442
3443 * ospf_nsm.c (nsm_kill_nbr): Fix bug of re-origination when
3444 a neighbor disappears.
3445
34462000-04-23 Michael Rozhavsky <mike@nbase.co.il>
3447
3448 * ospf_abr.c (ospf_abr_announce_network_to_area): Fix bug of
3449 summary-LSAs reorigination. Correctly copy OSPF_LSA_APPROVED
3450 flag to new LSA. when summary-LSA is reoriginatd.
3451
3452 * ospf_flood.c (ospf_flood_through_area): Fix bug of flooding
3453 procedure. Change the condition of interface selection.
3454
34552000-04-21 Toshiaki Takada <takada@zebra.org>
3456
3457 * ospf_lsa.c (ospf_refresher_register_lsa): Fix bug of refresh never
3458 occurs.
3459
3460 * ospfd.c (show_ip_ospf_neighbor_id): New defun added.
3461 `show ip ospf neighbor' related commands are re-arranged.
3462
34632000-04-20 Toshiaki Takada <takada@zebra.org>
3464
3465 * ospf_dump.c (debug_ospf_zebra): New defun added.
3466 Suppress zebra related debug information.
3467
34682000-04-19 Toshiaki Takada <takada@zebra.org>
3469
3470 * ospf_zebra.c (ospf_distribute_list_update_timer),
3471 (ospf_distribute_list_update), (ospf_filter_update):
3472 New function added. Re-organize `distribute-list' router ospf
3473 command.
3474
34752000-04-13 Michael Rozhavsky <mike@nbase.co.il>
3476
3477 * ospf_packet.c (ospf_make_ls_upd): Add check for MAX_AGE.
3478
34792000-04-14 Michael Rozhavsky <mike@nbase.co.il>
3480
3481 * ospf_packet.c (ospf_make_ls_upd): Increment LS age by configured
3482 interface transmit_delay.
3483
34842000-04-14 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3485
3486 * ospf_interface.c (ip_ospf_cost), (no_ip_ospf_cost):
3487 Add to schedule router_lsa origination when the interface cost changes.
3488
34892000-04-12 Toshiaki Takada <takada@zebra.org>
3490
3491 * ospf_lsa.c (ospf_refresher_register_lsa),
3492 (ospf_refresher_unregister_lsa): Fix bug of core dumped.
3493
3494 * ospfd.c (no_router_ospf): Fix bug of core dumped.
3495
34962000-03-29 Toshiaki Takada <takada@zebra.org>
3497
3498 * ospf_nsm.c (nsm_oneway_received): Fix bug of MS flag unset.
3499
35002000-03-29 Michael Rozhavsky <mike@nbase.co.il>
3501
3502 * ospf_lsa.c (ospf_network_lsa):
3503 * ospf_nsm.c (ospf_nsm_event): Fix bug of Network-LSA originated
3504 in stub network.
3505
35062000-03-28 Toshiaki Takada <takada@zebra.org>
3507
3508 * ospf_nsm.c (nsm_bad_ls_req), (nsm_seq_number_mismatch),
3509 (nsm_oneway_received): Fix bug of NSM state flapping between
3510 ExStart and Exchange.
3511
35122000-03-28 Toshiaki Takada <takada@zebra.org>
3513
3514 * ospf_packet.h (strcut ospf_header): Fix the size of ospf_header,
3515 change u_int8_t to u_char.
3516
35172000-03-27 Toshiaki Takada <takada@zebra.org>
3518
3519 * ospf_lsa.c (ospf_lsa_checksum): Take care of BIGENDIAN architecture.
3520
35212000-03-27 Toshiaki Takada <takada@zebra.org>
3522
3523 * ospfd.c (ospf_interface_run): Make sure Address family matches.
3524
35252000-03-26 Love <lha@s3.kth.se>
3526
3527 * ospf_packet.c (ospf_write): Chack result of sendto().
3528
35292000-03-26 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3530
3531 * ospf_nsm.c (nsm_oneway_received): Fix bug of 1-WayReceived in NSM.
3532
35332000-03-23 Libor Pechacek <farco@clnet.cz>
3534
3535 * ospf_lsa.c (ospf_network_lsa)
3536 * ospf_lsdb.c (new_lsdb_insert): Fix bug of accessing to
3537 unallocated memory.
3538
35392000-03-23 Toshiaki Takada <takada@zebra.org>
3540
3541 * ospfd.c (ospf_config_write): Fix bug of duplicate line for
3542 `area A.B.C.D authentication'.
3543
35442000-03-22 Toshiaki Takada <takada@zebra.org>
3545
3546 * ospf_debug.c (debug_ospf_lsa), (no_debug_ospf_lsa): Defun added.
3547 Suppress all zlog related to LSAs with this config option.
3548
35492000-03-21 Kunihiro Ishiguro <kunihiro@zebra.org>
3550
3551 * ospf_nsm.c (ospf_nsm_event): Add check for NSM_InactivityTimer.
3552
35532000-03-21 Toshiaki Takada <takada@zebra.org>
3554
3555 * ospf_packet.c (ospf_ls_upd_timer), (ospf_ls_req):
3556 Fix bug of memory leak about linklist.
3557
3558 * ospf_flood.c (ospf_flood_through_area): Likewise.
3559
35602000-03-18 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3561
3562 * ospf_flood.c (ospf_ls_retransmit_lookup): Add checksum comparison
3563 to identify LSA uniquely. This fix routes lost.
3564
35652000-03-18 Toshiaki Takada <takada@zebra.org>
3566
3567 * ospf_ase.c (ospf_find_asbr_route): Add sanity check with router
3568 routing table.
3569
35702000-03-17 Alex Zinin <zinin@amt.ru>
3571
3572 * ospf_spf.[ch]: Bug fix.
3573 The 2nd stage of Dijkstra could consider one vertex
3574 more than once if there is more than one link
3575 between the routers, thus adding extra CPU overhead
3576 and extra next-hops.
3577 Fixed.
3578
35792000-03-15 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3580
3581 * ospf_nsm.c (nsm_inactivity_timer): Changed to call nsm_kill_nbr().
3582
35832000-03-14 Toshiaki Takada <takada@zebra.org>
3584
3585 * ospf_route.c (ospf_route_copy_nexthops): Fix bug of memory leak of
3586 ospf_path. Actually ignore merging ospf_route with completely same
3587 paths.
3588
35892000-03-12 Toshiaki Takada <takada@zebra.org>
3590
3591 * ospf_lsa.c (show_as_external_lsa_detail): fix bug of
3592 external route tag byte order.
3593
35942000-03-11 Toshiaki Takada <takada@zebra.org>
3595
3596 * ospf_lsdb.c (ospf_lsdb_insert): New function added.
3597
35982000-03-09 Toshiaki Takada <takada@zebra.org>
3599
3600 * ospf_lsa.c (ospf_external_lsa_install),
3601 (ospf_lsa_lookup), (show_ip_ospf_database_all),
3602 (show_ip_ospf_database_self_originate): Use struct new_lsdb for
3603 LSDB of AS-external-LSAs instead of ospf_lsdb.
3604
3605 * ospf_lsa.c (ospf_lsa_unique_id): New function added.
3606 Use for assigning Unique Link State ID instead of
3607 ospf_get_free_id_for_prefix().
3608
36092000-03-09 Toshiaki Takada <takada@zebra.org>
3610
3611 * ospf_ase.c (ospf_ase_calculate_timer): Fix bug of segmentation
3612 fault reported by George Bonser <george@siteROCK.com>.
3613
36142000-03-07 Libor Pechacek <farco@clnet.cz>
3615
3616 * ospfd.c (ospf_interface_down): Fix bug of segmentation fault.
3617
36182000-03-06 Toshiaki Takada <takada@zebra.org>
3619
3620 * ospf_route.c (ospf_route_cmp): Change meaning of return values.
3621
36222000-03-02 Alex Zinin <zinin@amt.ru>
3623 * ospfd.h, ospf_ia.h
3624 New Shortcut ABR code. Now area's flag can be configured
3625 with Default, Enable, and Disable values.
3626 More info will be in the new ver of I-D soon (see IETF web).
3627
36282000-02-25 Toshiaki Takada <takada@zebra.org>
3629
3630 * ospf_lsa.c (ospf_lsa_header_set), (ospf_external_lsa_body_set),
3631 (osfp_external_lsa_originate), (ospf_external_lsa_queue),
3632 (ospf_external_lsa_originate_from_queue): New function added.
3633 (ospf_external_lsa): Function removed.
3634
3635 * ospf_zebra.c (ospf_zebra_read_ipv4): Originate AS-external-LSA
3636 when listen a route from Zebra, instead creating external route.
3637
3638 * ospf_asbr.c (ospf_asbr_route_add_flood_lsa),
3639 (ospf_asbr_route_add_queue_lsa),
3640 (ospf_asbr_route_install_lsa), (ospf_asbr_route_add):
3641 Functions removed.
3642
3643 * ospf_ase.c (process_ase_lsa): Function will not be used.
3644 (ospf_ase_calculate), (ospf_ase_calculate_route_add),
3645 (ospf_ase_calculate_new_route), (ospf_ase_caluculate_asbr_route):
3646 process_ase_lsa () is separated to these functions.
3647
3648 OSPF AS-external-LSA origination is whole re-organized.
3649
36502000-02-18 Toshiaki Takada <takada@zebra.org>
3651
3652 * ospf_packet.c (ospf_ls_upd): Fix bug of OSPF LSA memory leak.
3653
3654 * ospf_asbr.c (ospf_asbr_route_add_flood_lsa),
3655 (ospf_asbr_route_add_queue_lsa): Fix bug of OSPF external route
3656 memory leak.
3657
36582000-02-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3659
3660 * ospf_asbr.c (ospf_asbr_route_install_lsa): Re-calculate LSA
3661 checksum after change Advertised Router field.
3662
36632000-02-09 Toshiaki Takada <takada@zebra.org>
3664
3665 * ospf_asbr.c (ospf_external_route_lookup): Add new function.
3666
36672000-02-08 Toshiaki Takada <takada@zebra.org>
3668
3669 * ospfd.c (ospf_router_id_get), (ospf_router_id_update),
3670 (ospf_router_id_update_timer): Router ID decision algorithm is changed.
3671 Router ID is chosen from all of eligible interface addresses even if
3672 it is not enable to OSPF.
3673
36742000-02-08 Toshiaki Takada <takada@zebra.org>
3675
3676 * ospf_asbr.c (ospf_asbr_route_add): Function divided to
3677 ospf_asbr_route_add_flood_lsa, ospf_asbr_route_add_queue_lsa and
3678 ospf_asbr_route_install_lsa. If Router-ID is not set, then LSA is
3679 waited to install to LSDB.
3680 `0.0.0.0 adv_router' AS-external-LSA origination bug was fixed.
3681
36822000-02-01 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3683
3684 * ospf_flood.c (ospf_ls_retransmit_lookup): Compare LS seqnum
3685 in the ACK before deleting.
3686
3687 * ospf_packet.c (ospf_hello): Reset the flags after a shutdown
3688 and no shutdown of the interface.
3689
36902000-01-31 Toshiaki Takada <takada@zebra.org>
3691
3692 * ospf_packet.c (ospf_ls_req): Send multiple Link State Update
3693 packets respond to a Link State Request packet.
3694
3695 * ospfd.c (show_ip_ospf_neighbor_detail_sub): Show thread state.
3696
3697 * ospf_interface.c (ospf_vl_new): Crash when backbone area
3698 is not configured and set virtual-link to no-backbone area,
3699 bug fixed.
3700
37012000-01-30 Kunihiro Ishiguro <kunihiro@zebra.org>
3702
3703 * ospf_neighbor.h (struct ospf_neighbor): Add pointer to last send
3704 LS Request LSA.
3705
3706 * ospf_packet.c (ospf_ls_upd): Comment out LS request list
3707 treatment. That should be done in OSPF flooding procedure.
3708
3709 * ospf_flood.c (ospf_flood_through_area): Enclose
3710 ospf_check_nbr_loding inside if-else close.
3711
37122000-01-31 Toshiaki Takada <takada@zebra.org>
3713
3714 * ospf_packet.c (ospf_make_ls_upd): Fix bug of #LSAs counting.
3715
37162000-01-29 Toshiaki Takada <takada@zebra.org>
3717
3718 * ospf_packet.c (ospf_make_md5_digest): Fix bug of md5 authentication.
3719
37202000-01-28 Toshiaki Takada <takada@zebra.org>
3721
3722 * ospfd.c (show_ip_ospf): Show Number of ASE-LSAs.
3723
37242000-01-27 Kunihiro Ishiguro <kunihiro@zebra.org>
3725
3726 * ospf_packet.c (ospf_make_db_desc): Don't use rm_list for
3727 removing LSA from nbr->db_summary.
3728
37292000-01-27 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3730
3731 * ospf_packet.c (ospf_ls_upd_send): Set AllSPFRouters to
3732 destination when the link is point-to-point.
3733 (ospf_ls_ack_send_delayed): Likewise.
3734
37352000-01-27 Kunihiro Ishiguro <kunihiro@zebra.org>
3736
3737 * ospf_flood.c (ospf_ls_request_delete_all): Fix bug of next
3738 pointer lookup after the node is freed.
3739
37402000-01-26 Kunihiro Ishiguro <kunihiro@zebra.org>
3741
3742 * ospf_asbr.c (ospf_asbr_route_add): Instead of scanning all AS
3743 external route, use ospf_top->external_self.
3744
37452000-01-27 Toshiaki Takada <takada@zebra.org>
3746
3747 * ospf_lsa.c (ospf_forward_address_get): New function added.
3748
3749 * ospf_asbr.c (ospf_asbr_check_lsas): Originate AS-external-LSA
3750 only when it should be replaced.
3751
37522000-01-25 Kunihiro Ishiguro <kunihiro@zebra.org>
3753
3754 * ospf_flood.c (ospf_ls_retransmit_clear): Delete list node.
3755
3756 * ospf_lsa.c (ospf_lsa_free): Reduce logging message using
3757 ospf_zlog value.
3758
3759 * ospf_ism.c (ism_change_status): Fix bug of DR -> non DR status
3760 change. Self originated LSA is freed but not deleted from lsdb.
3761
37622000-01-24 Kunihiro Ishiguro <kunihiro@zebra.org>
3763
3764 * ospf_ism.c (ism_interface_down): Don't use router_id for
3765 detecting self neighbor structure. Instead of that compare
3766 pointer itself.
3767
3768 * ospf_neighbor.c (ospf_nbr_free): Cancel all timer when neighbor
3769 is deleted.
3770 (ospf_nbr_free): Free last send packet.
3771
3772 * ospf_neighbor.h (struct ospf_neighbor): Remove host strucutre.
3773 Instead of that src is introduced.
3774
3775 * ospf_nsm.h: Enclose macro defenition with do {} while (0).
3776
37772000-01-17 Kunihiro Ishiguro <kunihiro@zebra.org>
3778
3779 * ospfd.c: Change part of passive interface implementation. For
3780 passive interface just disabling sending/receiving Hello on the
3781 interface.
3782
37832000-01-16 Kai Bankett <kai.bankett@vew-telnet.net>
3784
3785 * ospf_interface.h (OSPF_IF_PASSIVE): Add passive flag.
3786 * ospf_interface.c (ospf_if_lookup_by_name): Add new function.
3787 * ospf_lsa.c (ospf_router_lsa): Skip passive interface.
3788 * ospfd.c (passive_interface): New command passive-interface is
3789 added.
3790 (ospf_config_write): Print passive interface.
3791
37922000-01-15 Toshiaki Takada <takada@zebra.org>
3793
3794 * ospf_interface.h (crypt_key): New struct added to store
3795 multiple cryptographic autheitication keys.
3796 (ospf_interface): struct changed.
3797
3798 * ospf_interface.c: ospf_crypt_key_new, ospf_crypt_key_add,
3799 ospf_crypt_key_lookup, ospf_crypt_key_delete: new functions added.
3800
3801 * ospf_packet.c (ip_ospf_message_digest_key): Changed to store
3802 multiple cryptographic authentication keys.
3803
38042000-01-14 Toshiaki Takada <takada@zebra.org>
3805
3806 * ospf_interface.c: DEFUN (if_ospf_*) commands changed name to
3807 ip_ospf_* ().
3808 Old notation `ospf *' still remains backward compatibility.
3809
38101999-12-29 Alex Zinin <zinin@amt.ru>
3811 * ospf_lsa.c: ospf_lsa_more_recent() bug fix
3812 * ospf_nsm.c, ospf_packet.c: remove nbr data struct when
3813 int goes down, also check DD flags correctly (bug fix)
3814
38151999-12-28 Alex Zinin <zinin@amt.ru>
3816 * "redistribute <source> metric-type (1|2) metric <XXX>" added
3817
38181999-12-23 Alex Zinin <zinin@amt.ru>
3819 * added RFC1583Compatibility flag
3820 * added dynamic interface up/down functionality
3821
38221999-11-19 Toshiaki Takada <takada@zebra.org>
3823
3824 * ospf_neighbor.h (struct ospf_neighbor): Add member state_change
3825 for NSM state change statistics.
3826
38271999-11-19 Toshiaki Takada <takada@zebra.org>
3828
3829 * ospfd.c (show_ip_ospf_neighbor_detail),
3830 (show_ip_ospf_neighbor_int_detail): DEFUN Added.
3831
38321999-11-14 Kunihiro Ishiguro <kunihiro@zebra.org>
3833
3834 * ospf_asbr.c (ospf_asbr_check_lsas): Add check of
3835 lsa->refresh_list.
3836
38371999-11-11 Toshiaki Takada <takada@zebra.org>
3838
3839 * ospf_ia.[ch] (OSPF_EXAMINE_SUMMARIES_ALL): Macro added.
3840 This macro is expanded to ospf_examine_summaries ()
3841 for SUMMARY_LSA and SUMMARY_LSA_ASBR.
3842 (OSPF_EXAMINE_TRANSIT_SUMMARIES_ALL): Macro added.
3843 This macro is expanded to ospf_examine_transit_summaries ()
3844 for SUMMARY_LSA and SUMMARY_LSA_ASBR.
3845
38461999-11-11 Toshiaki Takada <takada@zebra.org>
3847
3848 * ospf_lsa.[ch] (ospf_find_self_summary_lsa_by_prefix): Changed to
3849 macro OSPF_SUMMARY_LSA_SELF_FIND_BY_PREFIX.
3850 (ospf_find_self_summary_asbr_lsa_by_prefix): Changed to
3851 macro OSPF_SUMMARY_ASBR_LSA_SELF_FIND_BY_PREFIX.
3852 (ospf_find_self_external_lsa_by_prefix): Changed to
3853 macro OSPF_EXTERNAL_LSA_SELF_FIND_BY_PREFIX.
3854
38551999-11-11 Toshiaki Takada <takada@zebra.org>
3856
3857 * ospfd.c (ospf_abr_type): ospf_abr_type_cisco, ospf_abr_type_ibm,
3858 ospf_abr_type_shortcut and ospf_abr_type_standard DEFUNs are
3859 combined.
3860 * ospfd.c (no_ospf_abr_type): no_ospf_abr_type_cisco,
3861 no_ospf_abr_type_ibm and no_ospf_abr_type_shortcut DEFUNS are
3862 combined.
3863
38641999-11-10 Toshiaki Takada <takada@zebra.org>
3865
3866 * ospf_route.c (ospf_lookup_int_by_prefix): Move function to
3867 ospf_interface.c and change name to ospf_if_lookup_by_prefix ().
3868
38691999-11-01 Alex Zinin <zinin@amt.ru>
3870 * ospf_packet.c
3871 some correction to LSU processing
3872
3873 * ospf_lsa.c ospfd.h
3874 randomize initial LSA refreshment interval
3875 and limit the size of LSA-group to 10
3876 to let randomization work more effectively.
3877
38781999-10-31 Alex Zinin <zinin@amt.ru>
3879 * ospf_interface.c
3880 cancel t_network_lsa_self
3881 when freeing int structure
3882
3883 * ospf_abr.c ospf_asbr.c ospf_flood.c ospf_lsa.c
3884 ospf_lsa.h ospf_lsdb.h ospfd.c ospfd.h
3885
3886 Summary and ASE LSA refreshment functions
3887 added---LSA refreshment is paced to 70 LSAs
3888 per sec to avoid link overflow. Refreshment events
3889 are further randomized within a 10 sec interval
3890 to avoid syncing.
3891
3892 Also the sigfault of memcmp() in ospf_lsa_is_different()
3893 is fixed.
3894
38951999-10-30 Alex Zinin <zinin@amt.ru>
3896 * ospf_nsm.c
3897 Fix the bug where MAX_AGE LSAs
3898 are included into the DB summary.
3899
3900 * ospf_interface.c
3901 allocate 2*MTU input buffer instead of just MTU
3902 for the cases when the other router mistakenly
3903 sends larger packets thus causing fragmentation, etc.
3904
3905 * ospf_nsm.c
3906 in nsm_reset_nbr() lists should be freed
3907 not when they are empty.
3908
39091999-10-29 Kunihiro Ishiguro <kunihiro@zebra.org>
3910
3911 * ospf_zebra.c (ospf_acl_hook): Move OSPF_IS_ASBR and OSPF_IS_ABR
3912 check inside of if (ospf_top).
3913
39141999-10-29 Alex Zinin <zinin@amt.ru>
3915 * ospf_lsa.c ospf_lsdb.c :
3916 add assertion in lsa and lsa->data alloc functions,
3917 as well as in lsdb_add for new->data
3918
3919 * ospf_lsdb.c: free hash table correctly
3920
39211999-10-28 John Capo <jc@irbs.com>
3922
3923 * ospf_packet.h (OSPF_PACKET_MAX): Correct MAX packet length
3924 calculation
3925
39261999-10-27 Kunihiro Ishiguro <kunihiro@zebra.org>
3927
3928 * OSPF-TRAP-MIB.txt: New file added. Edited version of RFC1850.
3929
3930 * OSPF-MIB.txt: New file added. Edited version of RFC1850.
3931
39321999-10-27 Alex Zinin <zinin@amt.ru>
3933 * ospfd, ospf_zebra, ospf_abr
3934 "area import-list" command is added.
3935 This command allows to filter the inter-area routes
3936 injected into an area. Access list hook function
3937 extended to invalidate area exp/imp lists.
3938
39391999-10-25 Yoshinobu Inoue <shin@nd.net.fujitsu.co.jp>
3940
3941 * ospfd.c (ospf_interface_run): Enable to detect P2P network
3942 on an OSPF interface.
3943
39441999-10-19 Jordan Mendelson <jordy@wserv.com>
3945
3946 * ospf_lsdb.c (ospf_lsdb_add): Fix bug of crash
3947 in ospf_ls_retransmit_lookup ().
3948
39491999-10-19 Vladimir B. Grebenschikov <vova@express.ru>
3950
3951 * ospf_route.c: Workaround about installation of OSPF routes into
3952 the zebra daemon. Add checking of existance routes. Free
3953 ospf_top->old_table if it exists.
3954
39551999-10-15 Jordan Mendelson <jordy@wserv.com>
3956
3957 * Add support for MD5 authentication.
3958
39591999-10-12 Alex Zinin <zinin@amt.ru>
3960 * ospfd.c, ospfd.h, ospf_abr.c:
3961 a new command "area export-list" was added, it allows
3962 the admin. to control which intra-area routes are
3963 announced to other areas by the ABR
3964
39651999-10-12 Alex Zinin <zinin@amt.ru>
3966 * ospf_asbr.c (ospf_asbr_check_lsas): Fix bug of coredump
3967 when "no redistribute" is used after a distribute list
3968 denying some networks was used
3969
39701999-10-05 Toshiaki Takada <takada@zebra.org>
3971
3972 * ospf_route.c (ospf_path_dup): New function added.
3973
39741999-10-05 Toshiaki Takada <takada@zebra.org>
3975
3976 * ospf_interface.[ch]: Some of VL related funciton name changed.
3977
39781999-09-27 Alex Zinin <zinin@amt.ru>
3979
3980 * ospf_zebra.c: Distribute-list functionality added
3981
39821999-09-27 Toshiaki Takada <takada@zebra.org>
3983
3984 * ospfd.c (show_ip_ospf): Fix bug of segmentation fault when no ospf
3985 instance exists.
3986
39871999-09-25 Kunihiro Ishiguro <kunihiro@zebra.org>
3988
3989 * ospfd.c (ospf_interface_down): Fix bug of misusing nextnode()
3990 instead of node->next. Reported by Hiroki Ishibashi
3991 <ishibasi@dcd.abk.nec.co.jp>.
3992
3993 * ospf_route.c (show_ip_ospf_route): Add check for ospf is enabled
3994 or not.
3995
39961999-09-23 Alex Zinin <zinin@amt.ru>
3997
3998 * stub area support added
3999
40001999-09-23 Alex Zinin <zinin@amt.ru>
4001
4002 * fwd_addr in ASE-LSAs is now set correctly
4003 * ASE routing changed to check the fwd_addr
4004 and skip the route if the addr points to one
4005 of our interfaces to avoid loops.
4006
40071999-09-22 Alex Zinin <zinin@amt.ru>
4008
4009 * ospf_interface:
4010 ospf_vls_in_area() added, it returns
4011 the number of VLs configured through the area
4012
4013 * ospf_interface.c ospf_lsa.c ospf_lsdb.c ospfd.c
4014 honor correct mem alloc
4015
40161999-09-22 Alex Zinin <zinin@amt.ru>
4017
4018 * memory.[ch]:
4019 Some OSPF mem types added,
4020 plus more info in "show mem"
4021
40221999-09-21 Alex Zinin <zinin@amt.ru>
4023
4024 * ospfd.c:
4025 "area range substitute" added.
4026 It can be used on NAT-enabled (IP-masquarade)
4027 routers to announce private networks
4028 from an area as public ones into the outside
4029 world (not in the RFC, btw :)
4030
40311999-09-21 Alex Zinin <zinin@amt.ru>
4032
4033 * ospfd.c:
4034 "area range suppress" added.
4035 This command allows to instruct the router
4036 to be silent about specific ranges, i.e.,
4037 it is a method of route filtering on area
4038 borders
4039
40401999-09-21 Alex Zinin <zinin@amt.ru>
4041
4042 * ospfd.c VLs removed when "no network area" executed
4043
40441999-09-20 Alex Zinin <zinin@amt.ru>
4045
4046 * ospf_ase.c bug fix for not-zero fwd_addr
4047 and directly connected routes.
4048
40491999-09-20 Yon Uriarte <yon@plannet.de>
4050
4051 * ospf_packet.c (ospf_make_ls_req): Introduce delta value for
4052 checking the length of OSPF packet exceeds MTU or not.
4053
4054 * ospf_lsa.c (ospf_lsa_different): Apply ntohs for checking
4055 l1->data->length.
4056
40571999-09-18 Alex Zinin <zinin@amt.ru>
4058
4059 * ospf_lsa.c bug fix for ospf_network_lsa() to
4060 include itself into the RID list
4061
40621999-09-10 Alex Zinin <zinin@amt.ru>
4063
4064 * Alternative ABR behaviors IBM/Cisco/Shortcut
4065 implemented
4066
40671999-09-10 Alex Zinin <zinin@amt.ru>
4068
4069 * router and network-LSA origination
4070 changed to honor MinLSInterval
4071
40721999-09-08 Alex Zinin <zinin@amt.ru>
4073
4074 * modified ABR behavior to honor VLs and transit
4075 areas
4076
40771999-09-07 Alex Zinin <zinin@amt.ru>
4078
4079 * completed VL functionality
4080
40811999-09-06 Kunihiro Ishiguro <kunihiro@zebra.org>
4082
4083 * ospf_asbr.c: New file.
4084 ospf_asbr.h: New file.
4085
4086 * ospf_zebra.c (ospf_redistribute_connected): Add redistribute
4087 related stuff.
4088
40891999-09-05 Kunihiro Ishiguro <kunihiro@zebra.org>
4090
4091 * ospfd.h (OSPF_FLAG_VIRTUAL_LINK): Change OSPF_FLAG_VEND to
4092 OSPF_FLAG_VIRTUAL_LINK for comprehensiveness.
4093
40941999-09-03 Kunihiro Ishiguro <kunihiro@zebra.org>
4095
4096 * ospf_spf.c (ospf_spf_register): Change name from
4097 ospf_spf_route_add() to ospf_spf_register().
4098 Include "ospfd/ospf_abr.h" for ospf_abr_task() prototype.
4099
41001999-09-02 Kunihiro Ishiguro <kunihiro@zebra.org>
4101
4102 * ospf_lsa.c (ospf_external_lsa_install): Change to update
4103 lsa->data rather than install new one, when same id lsa is already
4104 installed.
4105
41061999-09-01 Kunihiro Ishiguro <kunihiro@zebra.org>
4107
4108 * ospf_lsa.c (ospf_router_lsa_install): Return lsa value.
4109 (ospf_network_lsa_install): Likewise.
4110 (ospf_summary_lsa_install): Likewise.
4111 (ospf_summary_asbr_lsa_install): Likewise.
4112 (ospf_external_lsa_install): Likewise.
4113
4114 * ospf_spf.c (ospf_spf_calculate): Comment out debug function
4115 ospf_rtrs_print().
4116
41171999-08-31 Kunihiro Ishiguro <kunihiro@zebra.org>
4118
4119 * ospf_spf.c (ospf_rtrs_free): Add ospf_spf_calculate() for
4120 freeing rtrs.
4121
41221999-08-31 Toshiaki Takada <takada@zebra.org>
4123
4124 * ospf_lsa.c (show_ip_ospf_database_summary),
4125 (show_ip_ospf_database_summary_asbr),
4126 (show_ip_ospf_database_external): New function added.
4127 `show ip ospf database summary',
4128 `show ip ospf database asbr-summary'
4129 `show ip ospf database external' command can be used.
4130
4131 * ospf_lsa.c (ospf_lsa_count_table): New function added.
4132 (show_ip_ospf_database_all): show nothing if a type of LSA
4133 does not exist.
4134
41351999-08-31 Kunihiro Ishiguro <kunihiro@zebra.org>
4136
4137 * ospf_lsa.c (ospf_maxage_lsa_remover): Preserve next pointer when
4138 the node is deleted.
4139
41401999-08-31 Toshiaki Takada <takada@zebra.org>
4141
4142 * ospf_flood.c (ospf_ls_retransmit_lookup): change to return
4143 struct ospf_lsa *.
4144 (ospf_ls_request_new), (ospf_ls_request_free),
4145 (ospf_ls_request_add), (ospf_ls_request_delete),
4146 (ospf_ls_request_delete_all), (ospf_ls_request_lookup):
4147 New function added.
4148
4149 * ospf_packet.c (ospf_ls_upd_send_lsa): New function added.
4150
4151 * ospf_lsa.h (LS_AGE): Slightly change macro definition.
4152
4153 * ospf_lsa.c (ospf_lsa_more_recent), (ospf_lsa_diffrent):
4154 Use LS_AGE macro.
4155
41561999-08-30 Alex Zinin <zinin@amt.ru>
4157
4158 * ospfd.c
4159 fix a bug with area range config write
4160 added "show ip ospf" command, it will be enhanced later on
4161
41621999-08-30 Alex Zinin <zinin@amt.ru>
4163
4164 * ospf_lsa.c
4165 updated ospf_router_lsa() to honor flags (B-bit)
4166
41671999-08-30 Alex Zinin <zinin@amt.ru>
4168
4169 * ospf_abr.c
4170 wrote major functions implementing ABR activity
4171
41721999-08-30 Alex Zinin <zinin@amt.ru>
4173
4174 * ospf_ia.c ospf_route.c ospf_route.h
4175 fixed the bug with ospf_route.origin field.
4176 Now it holds pointer to lsa_header
4177
41781999-08-30 Alex Zinin <zinin@amt.ru>
4179
4180 * ospf_flood.c ospf_flood.h:
4181 transformed ospf_flood_if_select into ospf_flood_through_area()
4182 added new ospf_flood_if_select() and ospf_flood_through_as()
4183
41841999-08-30 Toshiaki Takada <takada@zebra.org>
4185
4186 * ospf_flood.[ch]: New file added.
4187
4188 * ospf_packet.c (ospf_lsa_flooding),
4189 (ospf_lsa_flooding_select_if): functions move to ospf_flood.c
4190
4191 * ospf_neighbor.c (ospf_put_lsa_on_retransm_list),
4192 (ospf_remove_lsa_from_retransm_list),
4193 (ospf_nbr_remove_all_lsas_from_retransm_list),
4194 (ospf_lsa_remove_from_ls_retransmit):
4195 (ospf_lsa_retransmit): functions move to
4196 ospf_flood.c, and change function's name:
4197
4198 ospf_put_lsa_on_retransm_list ()
4199 -> ospf_ls_retransmit_add ()
4200 ospf_remove_lsa_from_retransm_list ()
4201 -> ospf_ls_retransmit_delete ()
4202 ospf_nbr_remove_all_lsas_from_retransm_list ()
4203 -> ospf_ls_retransmit_clear ()
4204 ospf_lsa_remove_from_ls_retransmit ()
4205 -> ospf_ls_retransmit_delete_nbr_all ()
4206 ospf_lsa_retransmit ()
4207 -> ospf_ls_retransmit_add_nbr_all ()
4208
4209 * ospf_lsa.c (ospf_lsa_lookup_from_list): function move to
4210 ospf_flood.c, and change name to ospf_ls_retransmit_lookup ().
4211
42121999-08-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4213
4214 * ospf_neighbor.c (ospf_nbr_lookup_by_addr): Use
4215 route_node_lookup() instead of route_node_get().
4216
4217 * ospf_packet.c (ospf_ls_upd): Temporary comment out (6) check.
4218
42191999-08-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4220
4221 * ospf_route.c (ospf_lookup_int_by_prefix): Add check of
4222 oi->address.
4223
42241999-08-29 Alex Zinin <zinin@amt.ru>
4225 * ospf_lsa.c
4226 MaxAge LSA deletion functions added.
4227
42281999-08-29 Alex Zinin <zinin@amt.ru>
4229 * ospf_neighbor.c
4230 ospf_nbr_lookup_by_addr(): added route_unlock_node()
4231 when function returns NULL if (rn->info == NULL)
4232
42331999-08-29 Alex Zinin <zinin@amt.ru>
4234 * ospfd.c
4235 added a hack for area range deletion
4236
42371999-08-29 Alex Zinin <zinin@amt.ru>
4238 * ospf_lsa.h
4239 included lsdb field into struct ospf_lsa, to find
4240 LSDB easier when removing MaxAge LSAs.
4241
42421999-08-29 Alex Zinin <zinin@amt.ru>
4243 * ospf_lsa.c ospf_neighbor.c ospf_nsm.c
4244 ospf_packet.c changed to honor new retransmit list
4245 management functions
4246
42471999-08-29 Alex Zinin <zinin@amt.ru>
4248 * ospf_neighbor.c , .h added new retransmit list functions.
4249
42501999-08-29 Alex Zinin <zinin@amt.ru>
4251 * Makefile.in
4252 added ospf_ase, ospf_abr, ospf_ia
4253
42541999-08-29 Alex Zinin <zinin@amt.ru>
4255 * ospf_spf.c:
4256 - changed ospf_next_hop_calculation() to include interface
4257 and nexthop addr for directly connected routers---more informative
4258 and solves problem with route installation into the kernel
4259 - changed ospf_nexthop_out_if_addr() to support routers, not only
4260 transit networks
4261 - added ospf_process_stubs();
4262
42631999-08-29 Alex Zinin <zinin@amt.ru>
4264 * ospf_lsa.c:
4265 - changed ospf_router_lsa() to provide correct links
4266 for p-t-p interfaces;
4267 - changed ospf_summary_lsa_install() to support table
4268 of self-originated summary-LSAs;
4269 - added ospf_summary_asbr_lsa_install() and ospf_external_lsa_install()
4270 - changed ospf_lsa_install() accordingly
4271 - changed show_ip_ospf_database_router_links() to support p-t-p
4272
42731999-08-29 Kunihiro Ishiguro <kunihiro@zebra.org>
4274
4275 * ospf_packet.c (ospf_make_db_desc): Only master can clear more
4276 flag.
4277
42781999-08-29 Kunihiro Ishiguro <kunihiro@zebra.org>
4279
4280 * ospf_packet.c (ospf_read): Add check of IP src address.
4281
42821999-08-28 Alex Zinin <zinin@amt.ru>
4283 * ospf_neighbor.h
4284 added ospf_nbr_lookup_by_routerid()
4285
42861999-08-28 Alex Zinin <zinin@amt.ru>
4287 * ospfd.h
4288 added ABR/ASBR flag definitions and fields;
4289 added iflist field to area structure;
4290 summary_lsa_self and summary_lsa_asbr_self are changed
4291 to be route tables;
4292 added ranges field---configured area ranges;
4293 A separate Routers RT added;
4294 area range config commands and config write added
4295
4296
42971999-08-28 Alex Zinin <zinin@amt.ru>
4298 * ospf_route.c :
4299 ospf_route_free()--added code to free the list of paths;
4300 The following functions added:
4301 ospf_intra_add_router();
4302 ospf_intra_add_transit();
4303 ospf_intra_add_stub();
4304 the last function uses new ospf_int_lookup_by_prefix();
4305 show_ip_ospf_route_cmd()--changed to support new RT structure;
4306 added ospf_cmp_routes()--general route comparision function;
4307 added ospf_route_copy_nexthops() and ospf_route_copy_nexthops_from_vertex()
4308 they are used in ASE and IA routing;
4309 added ospf_subst_route() and ospf_add_route();
4310
43111999-08-28 Alex Zinin <zinin@amt.ru>
4312 * ospf_route.h :
4313 changed struct ospf_path to include output interface,
4314 changed struct ospf_route to support IA and ASE routing.
4315 added prototypes of the function used in IA and ASE modules.
4316
43171999-08-28 Alex Zinin <zinin@amt.ru>
4318 * ospf_lsa.h ospf_lsa.c :
4319 added ospf_my_lsa(), an interface independent version of
4320 ospf_lsa_is_self_originated(), it will be used in ASE and IA-routing.
4321
43221999-08-27 Kunihiro Ishiguro <kunihiro@zebra.org>
4323
4324 * ospf_interface.c (interface_config_write): Add check for
4325 oi->nbr_self.
4326
43271999-08-25 Toshiaki Takada <takada@zebra.org>
4328
4329 * ospf_lsa.c (ospf_lsa_dup): New function added.
4330
4331 * ospf_packet.c (ospf_write), (ospf_read): Print send/recv
4332 interface in debug message.
4333
43341999-08-25 Toshiaki Takada <takada@zebra.org>
4335
4336 * ospf_packet.c (ospf_ls_ack_send): The name is changed from
4337 `ospf_ls_ack_send'.
4338 (ospf_ls_ack_send_delayed) (ospf_ls_ack_timer): New function added.
4339 Delayed Link State Acknowledgment is scheduled by timer.
4340
43411999-08-25 Alex Zinin <zinin@amt.ru>
4342
4343 * ospf_lsa.c (ospf_router_lsa): Incorrectly included link to
4344 a stub network instead of link to a transit network into
4345 originated router-LSA, bug fixed.
4346
43471999-08-24 Toshiaki Takada <takada@zebra.org>
4348
4349 * ospfd.c (ospf_update_router_id): New function added.
4350
4351 * ospf_network.c (ospf_write): Create new socket per transmission.
4352 And select outgoing interface whether dst is unicast or multicast.
4353
4354 * ospf_packet.c: LSA flooding will work.
4355
43561999-08-24 VOP <vop@unity.net>
4357
4358 * ospf_route.c: Include "sockunion.h"
4359
43601999-08-24 Kunihiro Ishiguro <kunihiro@zebra.org>
4361
4362 * ospf_network.c (ospf_serv_sock_init): Enclose
4363 IPTOS_PREC_INTERNETCONTROL setting with #ifdef for OS which does
4364 not have the definition.
4365
43661999-08-23 Toshiaki Takada <takada@zebra.org>
4367
4368 * ospf_packet.c: Fix bug of DD processing.
4369
43701999-08-18 Toshiaki Takada <takada@zebra.org>
4371
4372 * ospf_lsa.c (show_ip_ospf_database): Show actual `LS age'.
4373
43741999-08-17 Toshiaki Takada <takada@zebra.org>
4375
4376 * ospf_lsa.h (OSPF_MAX_LSA): The value of OSPF_MAX_LSA is
4377 corrected. The bug of `mes_lookup' is fixed.
4378 This had been reported by Poul-Henning Kamp <phk@freebsd.org>.
4379
4380 * ospf_lsa.c (ospf_router_lsa_install): The name is changed from
4381 `ospf_add_router_lsa'.
4382 (ospf_network_lsa_install): The name is changed from
4383 `ospf_add_network_lsa'.
4384
4385 * ospf_interface.h (ospf_interface): Add member `nbr_self'.
4386
4387 * ospf_interface.c (ospf_if_is_enable): New function added.
4388
43891999-08-16 Toshiaki Takada <takada@zebra.org>
4390
4391 * ospf_lsa.h (struct lsa_header): The name is changed from
4392 `struct ospf_lsa'.
4393 (struct ospf_lsa): New struct added to control each LSA's aging
4394 and timers.
4395
4396 * ospf_lsa.c (ospf_lsa_data_free): The name is change from
4397 `ospf_lsa_free'.
4398 (ospf_lsa_data_new), (ospf_lsa_new), (ospf_lsa_free),
4399 (ospf_lsa_different), (ospf_lsa_install): New function added.
4400
4401 * ospf_packet.c (ospf_ls_upd_list_lsa): New function added.
4402
44031999-08-12 Toshiaki Takada <takada@zebra.org>
4404
4405 * ospf_nsm.c (nsm_reset_nbr): New function added.
4406 KillNbr and LLDown neighbor event call this function.
4407
44081999-08-10 Toshiaki Takada <takada@zebra.org>
4409
4410 * ospf_packet.c (ospf_ls_retransmit)
4411 (ospf_ls_upd_timer): New function added.
4412 Set retransmission timer for Link State Update.
4413
44141999-07-29 Toshiaki Takada <takada@zebra.org>
4415
4416 * ospf_ism.c (ospf_dr_election): Fix bug of DR election.
4417
44181999-07-28 Toshiaki Takada <takada@zebra.org>
4419
4420 * ospf_network.c (ospf_serv_sock_init): Set IP precedence field
4421 with IPTOS_PREC_INTERNET_CONTROL.
4422
4423 * ospf_nsm.c (nsm_change_status): Schedule NeighborChange event
4424 if NSM status change.
4425
4426 * ospf_packet.c (ospf_make_hello): Never include a neighbor in
4427 Hello packet, when the neighbor goes down.
4428
44291999-07-26 Kunihiro Ishiguro <kunihiro@zebra.org>
4430
4431 * Makefile.am (noinst_HEADERS): Add ospf_route.h.
4432
4433 * ospf_route.c (show_ip_ospf_route): Add `show ip ospf route'
4434 command.
4435
44361999-07-25 Toshiaki Takada <takada@zebra.org>
4437
4438 * ospf_lsa.c (ospf_router_lsa): Fix bug of LS sequence number
4439 assignement.
4440
44411999-07-25 Kunihiro Ishiguro <kunihiro@zebra.org>
4442
4443 * ospf_route.c (ospf_route_table_free): New function added.
4444
4445 * ospf_spf.c (ospf_spf_next): Free vertex w when cw's and w's
4446 distance is same.
4447
4448 * ospfd.h (struct ospf): Add old_table.
4449
4450 * ospf_main.c (sighup): Call of log_rotate () removed.
4451
4452 * ospf_lsa.c (ospf_lsa_is_self_originated): Fix bug of checking
4453 area->lsa as self LSA. This should be area->lsa_self.
4454
44551999-07-24 Kunihiro Ishiguro <kunihiro@zebra.org>
4456
4457 * ospf_zebra.c (ospf_zebra_add): ospf_zebra_add
4458 (),ospf_zebra_delete () added.
4459
4460 * ospf_spf.c (ospf_spf_calculate): Call ospf_intra_route_add ().
4461
44621999-07-24 Toshiaki Takada <takada@zebra.org>
4463
4464 * ospf_lsa.c: Change LS sequence number treatment.
4465 (ospf_lsa_is_self_originated): New function added.
4466 (show_ip_ospf_database_self_originated): New DEFUN added.
4467
44681999-07-23 Kunihiro Ishiguro <kunihiro@zebra.org>
4469
4470 * ospf_interface.c (ospf_if_lookup_by_addr): Add loopback check.
4471
44721999-07-22 Toshiaki Takada <takada@zebra.org>
4473
4474 * ospf_spf.c (ospf_nexthop_new), (ospf_nexthop_free),
4475 (ospf_nexthop_dup): function added.
4476 (ospf_nexthop_calculation): function changed.
4477
4478 * ospf_interface.c (ospf_if_lookup_by_addr): function added.
4479
44801999-07-21 Toshiaki Takada <takada@zebra.org>
4481
4482 * ospf_spf.c (ospf_spf_closest_vertex): function removed.
4483
44841999-07-21 Kunihiro Ishiguro <kunihiro@zebra.org>
4485
4486 * ospf_spf.c (ospf_spf_next): Apply ntohs for fetching metric.
4487
44881999-07-21 Toshiaki Takada <takada@zebra.org>
4489
4490 * ospf_neighbor.c (ospf_nbr_lookup_by_router_id): fundtion removed.
4491
4492 * ospf_lsa.c (show_ip_ospf_database_router): describe each
4493 connected link.
4494
44951999-07-21 Kunihiro Ishiguro <kunihiro@zebra.org>
4496
4497 * ospf_spf.c (ospf_spf_next): V is router LSA or network LSA so
4498 change behavior according to LSA type.
4499 (ospf_lsa_has_link): Link check function is added.
4500
45011999-07-20 Kunihiro Ishiguro <kunihiro@zebra.org>
4502
4503 * ospf_spf.c (ospf_spf_calculate_schedule): Add new function for
4504 SPF calcultion schedule addtition.
4505 (ospf_spf_calculate_timer_add): Rough 30 sec interval SPF calc
4506 timer is added.
4507 (ospf_spf_next_router): Delete ospf_spf_next_network ().
4508
4509 * ospf_lsa.c (show_ip_ospf_database_all): Network-LSA display
4510 header typo correction. Display of router LSA's #link added.
4511
45121999-07-19 Toshiaki Takada <takada@zebra.org>
4513
4514 * ospf_packet.c (ospf_check_network_mask): Added new function for
4515 receiving Raw IP packet on an appropriate interface.
4516
45171999-07-16 Toshiaki Takada <takada@zebra.org>
4518
4519 * ospfd.c (ospf_router_id): new DEFUN added.
4520
45211999-07-15 Toshiaki Takada <takada@zebra.org>
4522
4523 * ospf_spf.c (ospf_spf_init), (ospf_spf_free),
4524 (ospf_spf_has_vertex), (ospf_vertex_lookup),
4525 (ospf_spf_next_router), (ospf_spf_next_network),
4526 (ospf_spf_closest_vertex), (ospf_spf_calculate):
4527 function added.
4528
45291999-07-13 Toshiaki Takada <takada@zebra.org>
4530
4531 * ospf_ism.c: fix bug of DR Election.
4532
4533 * ospf_nsm.c: fix bug of adjacency forming.
4534
45351999-07-05 Kunihiro Ishiguro <kunihiro@zebra.org>
4536
4537 * ospfd.c (ospf_init): Change to use install_default.
4538
45391999-07-01 Rick Payne <rickp@rossfell.co.uk>
4540
4541 * ospf_zebra.c (zebra_init): Install standard commands to
4542 ZEBRA_NODE.
4543
45441999-06-30 Toshiaki Takada <takada@zebra.org>
4545
4546 * ospf_dump.c: Whole debug command is improved.
4547 (ISM|NSM) (events|status|timers) debug option added.
4548 (show_debugging_ospf): new DEFUN added.
4549
45501999-06-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4551
4552 * ospf_lsa.c (ospf_lsa_lookup_from_list): Change !IPV4_ADDR_CMP to
4553 IPV4_ADDR_SAME.
4554
45551999-06-29 Toshiaki Takada <takada@zebra.org>
4556
4557 * ospf_dump.c (ospf_summary_lsa_dump): Add summary-LSA dump routine.
4558 (ospf_as_external_lsa_dump): Add AS-external-LSA dump routine.
4559
4560 * ospf_nsm.c (nsm_twoway_received): fix condtion of adjacnet.
4561
4562 * ospf_ism.c (ospf_dr_election): fix DR Election.
4563
4564 * ospf_dump.c (ospf_nbr_state_message): fix `show ip ospf neighbor'
4565 command's state.
4566
45671999-06-29 Kunihiro Ishiguro <kunihiro@zebra.org>
4568
4569 * ospf_dump.c (ospf_router_lsa_dump): Add router-LSA dump routine.
4570
45711999-06-28 Toshiaki Takada <takada@zebra.org>
4572
4573 * ospf_lsa.c (show_ip_ospf_database_network): fix bug of
4574 `show ip ospf database network' command output.
4575
4576 * ospf_nsm.c (nsm_inactivity_timer): Clear list of Link State
4577 Retransmission, Database Summary and Link State Request.
4578
4579 * ospf_packet.c (ospf_ls_req_timer): New function added.
4580 Set Link State Request retransmission timer.
4581
45821999-06-27 Kunihiro Ishiguro <kunihiro@zebra.org>
4583
4584 * ospf_main.c (main): Change default output from ZLOG_SYSLOG to
4585 ZLOG_STDOUT.
4586
4587 * ospfd.c (ospf_init): Register show_ip_ospf_interface_cmd and
4588 show_ip_ospf_neighbor_cmd to VIEW_NODE.
4589
4590 * ospf_lsa.c (ospf_lsa_init): Register show_ip_ospf_database_cmd
4591 and show_ip_ospf_database_type_cmd to VIEW_NODE.
4592
45931999-06-25 Toshiaki Takada <takada@zebra.org>
4594
4595 * ospf_packet.c: fix bug of DD making.
4596 fix bug of LS-Update reading.
4597
45981999-06-23 Toshiaki Takada <takada@zebra.org>
4599
4600 * ospf_packet.c: All type of packets are changed to use
4601 fifo queue structure.
4602 (ospf_fill_header) function added.
4603
46041999-06-22 Toshiaki Takada <takada@zebra.org>
4605
4606 * ospf_packet.c (ospf_packet_new): New function added to handle
4607 sending ospf packet by fifo queue structure.
4608 (ospf_packet_free), (ospf_fifo_new), (ospf_fifo_push),
4609 (ospf_fifo_pop), (ospf_fifo_head), (ospf_fifo_flush),
4610 (ospf_fifo_free): Likewise.
4611
46121999-06-21 Toshiaki Takada <takada@zebra.org>
4613
4614 * ospf_nsm.c (ospf_db_desc_timer): function added.
4615 (nsm_timer_set) function added.
4616 * ospf_dump.c (ospf_option_dump): function added.
4617 * ospf_packet.c (ospf_ls_req) (ospf_make_ls_req): function added.
4618
46191999-06-20 Toshiaki Takada <takada@zebra.org>
4620
4621 * ospf_lsa.c (ospf_lsa_more_recent): function added.
4622 * ospf_neighbor.h (struct ospf_neighbor): Change member ms_flag
4623 to dd_flags.
4624
46251999-06-19 Toshiaki Takada <takada@zebra.org>
4626
4627 * ospf_lsa.c: DEFUN (show_ip_ospf_database) Added.
4628 * ospf_interface.c (if_ospf_cost), (if_ospf_dead_interval),
4629 (if_ospf_hello_interval), (if_ospf_priority),
4630 (if_ospf_retransmit_interval), (if_ospf_transmit_delay)
4631 argument changed from NUMBER to <range>.
4632 DEFUN (if_ospf_network_broadcast),
4633 DEFUN (if_ospf_network_non_broadcast),
4634 DEFUN (if_ospf_network_point_to_multipoint),
4635 DEFUN (if_ospf_network_point_to_point) functions are combined to
4636 DEFUN (if_ospf_network).
4637
46381999-06-18 Toshiaki Takada <takada@zebra.org>
4639
4640 * ospf_lsa.c: ospf_add_router_lsa (), ospf_add_network_lsa (),
4641 ospf_lsa_lookup (), ospf_lsa_count () Added.
4642
46431999-06-15 Toshiaki Takada <takada@zebra.org>
4644
4645 * DEFUN (ospf_debug_ism), DEFUN (ospf_debug_nsm),
4646 DEFUN (no_ospf_debug_ism), DEFUN (no_ospf_debug_nsm) Added.
4647 `debug ospf ism' command shows debug message.
4648 `debuf ospf nsm' command shows debug message.
4649
46501999-06-14 Toshiaki Takada <takada@zebra.org>
4651
4652 * ospf_lsa.c: ospf_network_lsa () Added.
4653 ospf_lsa_checksum () Added.
4654 * DEFUN (ospf_debug_packet), DEFUN (no_ospf_debug_packet) Added.
4655 `debug ospf packet' command shows debug message.
4656
46571999-06-13 Toshiaki Takada <takada@zebra.org>
4658
4659 * ospf_packet.h: Remove struct ospf_ls_req {}, ospf_ls_upd {},
4660 ospf_ls_ack {}.
4661
46621999-06-11 Toshiaki Takada <takada@zebra.org>
4663
4664 * ospf_dump.c: fix IP packet length treatment.
4665
46661999-06-10 Toshiaki Takada <takada@zebra.org>
4667
4668 * ospf_ism.h: Add OSPF_ISM_EVENT_EXECUTE() Macro Added.
4669 * ospf_nsm.h: Add OSPF_NSM_EVENT_EXECUTE() Macro Added.
4670
4671 * ospf_packet.c: ospf_db_desc (), ospf_db_desc_send () Added.
4672 ospf_make_hello (), ospf_make_db_desc () Added.
4673 ospf_db_desc_proc () Added.n
4674
4675 * Database Description packet can be processed.
4676
46771999-06-08 Toshiaki Takada <takada@zebra.org>
4678
4679 * ospf_lsa.c: New file.
4680
46811999-06-07 Toshiaki Takada <takada@zebra.org>
4682
4683 * ospf_neighbor.c: ospf_fully_adjacent_count () Added.
4684
46851999-06-07 Kunihiro Ishiguro <kunihiro@zebra.org>
4686
4687 * ospf_spf.[ch]: New file.
4688
46891999-05-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4690
4691 * ospf_zebra.c: Changed to use lib/zclient.c routines.
4692
4693 * ospf_zebra.h (zebra_start): Remove struct zebra.
4694
46951999-05-29 Kunihiro Ishiguro <kunihiro@zebra.org>
4696
4697 * ospfd.c (ospf_config_write): Add cast (unsigned long int) to
4698 ntohl for sprintf warning.
4699
47001999-05-19 Toshiaki Takada <takada@zebra.org>
4701
4702 * ospf_ism.c (ospf_dr_election): Join AllDRouters Multicast group
4703 if interface state changes to DR or BDR.
4704
47051999-05-14 Stephen R. van den Berg <srb@cuci.nl>
4706
4707 * ospf_main.c (signal_init): SIGTERM call sigint.
4708 (sigint): Logging more better message.
4709
47101999-05-12 Toshiaki Takada <takada@zebra.org>
4711
4712 * ospfd.c: Fix bug of `no router ospf' statement, it will work.
4713
47141999-05-11 Toshiaki Takada <takada@zebra.org>
4715
4716 * ospf_neighbor.c: ospf_nbr_free () Added.
4717
47181999-05-10 Toshiaki Takada <takada@zebra.org>
4719
4720 * ospfd.h: struct ospf_area { }, struct ospf_network { } Changed.
4721 * Fix bug of `no network' statement, it will work.
4722
47231999-05-07 Toshiaki Takada <takada@zebra.org>
4724
4725 * ospf_interface.c, ospf_zebra.c: Fix bug of last interface is not
4726 updated by ospf_if_update ().
4727
47281999-04-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4729
4730 * Makefile.am (noinst_HEADERS): Add ospf_lsa.h for distribution.
4731
47321999-04-25 Toshiaki Takada <takada@zebra.org>
4733
4734 * ospf_interface.c: DEFUN (no_if_ospf_cost),
4735 DEFUN (no_if_ospf_dead_interval),
4736 DEFUN (no_if_ospf_hello_interval),
4737 DEFUN (no_if_ospf_priority),
4738 DEFUN (no_if_ospf_retransmit_interval),
4739 DEFUN (no_if_ospf_transmit_delay) Added.
4740
4741 interface_config_write () suppress showing interface
4742 default values.
4743
47441999-04-25 Kunihiro Ishiguro <kunihiro@zebra.org>
4745
4746 * ospf_dump.c (ospf_timer_dump): If thread is NULL return "inactive".
4747
4748 * ospfd.c (ospf_if_update): Fix bug of using ospf_area { } instead
4749 of ospf_network { }. So `router ospf' statement in ospfd.conf
4750 works again.
4751 (ospf_if_update): Call ospf_get_router_id for updating router ID.
4752
47531999-04-25 Toshiaki Takada <takada@zebra.org>
4754
4755 * ospf_interface.c: DEFUN (if_ospf_network) deleted.
4756 DEFUN (if_ospf_network_broadcast),
4757 DEFUN (if_ospf_network_non_broadcast),
4758 DEFUN (if_ospf_network_point_to_multipoint),
4759 DEFUN (if_ospf_network_point_to_point),
4760 DEFUN (no_if_ospf_network) Added.
4761
47621999-04-23 Toshiaki Takada <takada@zebra.org>
4763
4764 * ospfd.h: struct area { } changed to struct ospf_network { }.
4765 Add struct ospf_area { }.
4766 * ospfd.c: Add ospf_area_lookup_by_area_id (), ospf_network_new (),
4767 and ospf_network_free ().
4768 DEFUN (area_authentication), DEFUN (no_area_authentication) Added.
4769
47701999-04-22 Toshiaki Takada <takada@zebra.org>
4771
4772 * ospf_lsa.h: New file.
4773 * ospf_packet.h: LSA related struct definition are moved to
4774 ospf_lsa.h.
4775 * ospf_packet.c: ospf_verify_header () Added.
4776
47771999-04-21 Toshiaki Takada <takada@zebra.org>
4778
4779 * ospf_ism.c: ospf_elect_dr () and related function is changed.
4780 DR Election bug fixed.
4781 * ospf_dump.c: ospf_nbr_state_message (), ospf_timer_dump () Added.
4782 * ospfd.c: DEFUN (show_ip_ospf_neighbor) Added.
4783
47841999-04-19 Kunihiro Ishiguro <kunihiro@zebra.org>
4785
4786 * ospf_main.c (main): access_list_init () is added for vty
4787 connection filtering.
4788
47891999-04-16 Toshiaki Takada <takada@zebra.org>
4790
4791 * ospfd.c: DEFUN (show_ip_ospf_interface) Added.
4792 * ospf_neighbor.c: ospf_nbr_count () Added.
4793
47941999-04-15 Toshiaki Takada <takada@zebra.org>
4795
4796 * ospfd.h: struct ospf { } Changed.
4797 * ospfd.c: ospf_lookup_by_process_id () Deleted.
4798 * ospf_ism.c: ospf_wait_timer () Added. WaitTimer will work.
4799
48001999-04-14 Toshiaki Takada <takada@zebra.org>
4801
4802 * ospf_ism.c: ospf_elect_dr () Added.
4803 * ospf_network.c: ospf_if_ipmulticast () Added.
4804
48051999-04-11 Toshiaki Takada <takada@zebra.org>
4806
4807 * ospf_interface.c: interface_config_write (),
4808 DEFUN (if_ip_ospf_cost),
4809 DEFUN (if_ip_ospf_dead_interval),
4810 DEFUN (if_ip_ospf_hello_interval),
4811 DEFUN (if_ip_ospf_priority),
4812 DEFUN (if_ip_ospf_retransmit_interval) and
4813 DEFUN (if_ip_ospf_transmit_delay) Added.
4814
48151999-04-08 Toshiaki Takada <takada@zebra.org>
4816
4817 * ospf_dump.c: ospf_packet_db_desc_dump () Added.
4818 * ospf_neighbor.c: ospf_nbr_bidirectional () Added.
4819 * ospf_nsm.c: nsm_twoway_received () Added.
4820
48211999-04-02 Toshiaki Takada <takada@zebra.org>
4822
4823 * ospf_neighbor.c: New file.
4824 * ospf_neighbor.h: New file.
4825 * ospf_nsm.c: New file.
4826 * ospf_nsm.h: New file.
4827 * ospf_packet.c: Add ospf_make_header (), ospf_hello () and
4828 ospf_hello_send (). Now OSPFd can receive Hello and send Hello.
4829
48301999-03-27 Kunihiro Ishiguro <kunihiro@zebra.org>
4831
4832 * ospf_packet.c: Add ospf_recv_packet (). Now OSPF Hello can receive.
4833
48341999-03-19 Toshiaki Takada <takada@zebra.org>
4835
4836 * ospf_packet.c: New file.
4837 * ospf_packet.h: New file.
4838 * ospf_network.c: New file.
4839 * ospf_network.h: New file.
4840 * ospfd.h: move OSPF message structure has moved to ospf_packet.h.
4841
48421999-03-17 Kunihiro Ishiguro <kunihiro@zebra.org>
4843
4844 * ospf_zebra.c (ospf_zebra_get_interface): Fix for IPv6 interface
4845 address.
4846
4847 * Makefile.am (install-sysconfDATA): Overwrite install-sysconfDATA
4848 for install ospfd.conf.sample as owner read only file.
4849
4850 * ospf_main.c (usage): Change to use ZEBRA_BUG_ADDRESS.
4851
48521999-03-15 Toshiaki Takada <takada@zebra.org>
4853
4854 * ospf_ism.c: New file.
4855 * ospf_ism.h: New file.
4856 * ospf_dump.c: New file.
4857 * ospf_dump.h: New file.
4858
4859 * ospfd.h: Add (struct ospf), (struct config_network),
4860 (struct message) structure.
4861
4862 * ospf_interface.c: Add ospf_if_match_network ().
4863 * ospf_interface.h (struct ospf_interface): Change struct members.
4864
4865 * ospfd.c: ospf_lookup_by_process_id (), ospf_network_new (),
4866 DEFUN (network_area): Added.
4867
4868 * ospfd.conf.sample: Change sample configuration.
4869
48701999-03-05 Toshiaki Takada <takada@zebra.org>
4871
4872 * ospf_interface.c: New file.
4873 * ospf_interface.h: New file.
4874 * ospf_zebra.h: New file.
4875 * ospf_zebra.c: Add interface function for zebra daemon.
4876 * ospfd.c: New file.
4877
48781999-02-23 Kunihiro Ishiguro <kunihiro@zebra.org>
4879
4880 * Move IPv6 codes and files to ospf6d directory.
4881
48821999-02-18 Peter Galbavy <Peter.Galbavy@knowledge.com>
4883
4884 * syslog support added
4885
48861998-12-22 Toshiaki Takada <takada@zebra.org>
4887
4888 * ospfd.h: New file.
4889 * ospf_lsa.h: New file.
4890
48911998-12-15 Kunihiro Ishiguro <kunihiro@zebra.org>
4892
4893 * Makefile.am: New file.
4894 * ospf_main.c: New file.
4895