blob: d026bf88485c13cda8735e32fddf62ab3fb8a161 [file] [log] [blame]
Paul Jakmabc20c1a2007-01-24 14:51:51 +000012007-01-24 Paul Jakma <paul.jakma@sun.com>
2
3 * ospf_spf.c: Bug #330: Nexthop calculation sometimes may fail,
4 and it needs to indicate this result to SPF.
5 (ospf_spf_add_parent) Flush of parent list needs to be done here,
6 for simplicity.
7 (ospf_nexthop_calculation) Caller needs to know whether
8 nexthop calculation succeeded. Every return statement must
9 correctly indicate such.
10 (ospf_spf_next) Queueing/prioritisation of vertices in SPF
11 must take into account whether nexthop_calculation succeeded,
12 or SPF may fail to find best paths.
13
Andrew J. Schorre4529632006-12-12 19:18:21 +0000142006-12-12 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
15
16 * ospf_interface.c: (ospf_if_is_configured, ospf_if_lookup_by_prefix,
17 ospf_if_lookup_recv_if) Simplify logic using new CONNECTED_PREFIX
18 macro.
19 * ospf_lsa.c: (lsa_link_ptop_set) Using the new CONNECTED_PREFIX
20 macro, both options collapse into the same code.
21 * ospf_snmp.c: (ospf_snmp_if_update) Simplify logic using new
22 CONNECTED_ID macro.
23 (ospf_snmp_is_if_have_addr) Simplify logic using new CONNECTED_PREFIX
24 macro.
25 * ospf_vty.c: (show_ip_ospf_interface_sub) Use new CONNECTED_PEER macro
26 instead of testing the IFF_POINTOPOINT flag.
27 * ospfd.c: (ospf_network_match_iface) Use new CONNECTED_PEER macro
28 instead of testing with if_is_pointopoint. And add commented-out
29 code to implement alternative (in my opinion) more elegant behavior
30 that has no special-case treatment for PtP addresses.
31 (ospf_network_run) Use new CONNECTED_ID macro to simplify logic.
32
Andrew J. Schorred589c12006-12-04 18:26:37 +0000332006-12-04 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
34
35 * ospfd.c: (ospf_network_run) Remove an offending 'break' statement.
36 Previously, after creating a single ospf_interface on a given
37 network interface, the code would skip to the next interface
38 without considering other connected addresses on the interface.
39 After removing the 'break', we now consider all connected addresses.
40
Andrew J. Schorr7f643eb2006-11-30 16:17:02 +0000412006-11-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
42
43 * ospf_zebra.c: (ospf_router_id_update_zebra,
44 ospf_interface_address_add, ospf_interface_address_delete)
45 If (IS_DEBUG_OSPF (zebra, ZEBRA_INTERFACE)) is enabled, then
46 add a debug message about what Zebra is telling us.
47 (ospf_zebra_add_discard) Add a debug message matching the one
48 already in ospf_zebra_delete_discard.
49
Andrew J. Schorr43540882006-11-28 16:36:39 +0000502006-11-28 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
51
52 * ospf_vty.c: (ospf_passive_interface_default) Take additional
53 'newval' arg so we can update ospf->passive_interface_default inside
54 this function. More importantly, we now call ospf_if_set_multicast
55 on all ospf_interfaces.
56 (ospf_passive_interface, no_ospf_passive_interface) Fix bug:
57 for 'default' case, argv[0] is undefined, so we must test for
58 (argc == 0) before using argv[0]. And since
59 ospf_passive_interface_default now calls ospf_if_set_multicast as
60 needed, we can just return after calling
61 ospf_passive_interface_default.
62
Andrew J. Schorr8fb8a502006-10-24 19:04:26 +0000632006-10-24 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
64
65 * ospf_zebra.c: (ospf_redistribute_default_set) Fix bug where
66 a new value for ospf->default_originate was being ignored
67 if a previous 'default-information originate' command
68 had already been processed.
69
Paul Jakma7ffa8fa2006-10-22 20:07:53 +0000702006-10-22 Yar Tikhiy <yar@comp.chem.msu.su>
71
72 * (general) Add support for passive-interface default (with
73 minor edits by Paul Jakma).
74 * ospf_interface.h: Add OSPF_IF_PASSIVE_STATUS macro, looking
75 at configured value, or the global 'default' value, as
76 required.
77 * ospf_interface.c: (ospf_if_new_hook) Leave passive
78 unconfigured per default, allowing global 'default' to
79 take effect for unconfigured interfaces.
80 * ospf_packet.c: (various) use OSPF_IF_PASSIVE_STATUS
81 * ospf_vty.c: (ospf_passive_interface_default) new function,
82 unset passive from all interfaces if default is enabled, as
83 the per-iface settings become redundant.
84 (ospf_passive_interface_update) new func, update passive
85 setting taking global default into account.
86 ({no,}ospf_passive_interface_addr_cmd) Add support for
87 'default' variant of command.
88 (show_ip_ospf_interface_sub) Update to take global
89 default into account when printing passive status.
90 (ospf_config_write) ditto.
91 * ospfd.c: (ospf_new) set global passive-interface default.
92 * ospfd.h: (struct ospf) Add field for global
93 passive-interface.
94
Andrew J. Schorr08c83672006-09-25 13:26:14 +0000952006-09-25 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
96
97 * ospf_packet.c: (ospf_packet_dup, ospf_make_md5_digest)
98 Fix zlog_warn messages to eliminate compiler warnings.
99 (ospf_hello) Improve warning messages to show why we
100 are complaining.
101
Paul Jakmab5aeb442006-08-30 18:47:37 +00001022006-08-28 Andy Gay <andy@andynet.net>
103
104 * ospf_packet.c: (ospf_make_db_desc) Assert added with More-bit
105 fixes does not hold up with addition of Ogier DB-Exchange
106 optimisation, which can empty the db-summary list in between
107 sent DD packets. Remove assert, update More-bit always when
108 in Exchange.
109
Paul Jakma29b5a042006-08-27 08:01:20 +00001102006-08-27 J.J. Krabbendam <jkrabbendam@aimsys.nl>
111
112 * ospfd.c: (ospf_finish_final) default redistribute should be
113 unset too, fixes bug where reconfiguring ospfd completely
114 can no longer enable default redistribution.
115
Paul Jakma2518efd2006-08-27 06:49:29 +00001162006-08-25 Paul Jakma <paul.jakma@sun.com>
117
118 * (general) Bug #134. Be more robust to backward time changes,
119 use the newly added libzebra time functions.
120 In most cases: recent_time -> recent_relative_time()
121 gettimeofday -> quagga_gettime (QUAGGA_CLK_MONOTONIC, ..)
122 time -> quagga_time.
123 (ospf_make_md5_digest) time() call deliberately not changed.
124 (ospf_external_lsa_refresh) remove useless gettimeofday, LSA
125 tv_orig time was already set in ospf_lsa_new, called via
126 ospf_external_lsa_new.
127
Paul Jakmaba122e72006-08-27 06:24:34 +00001282006-08-04 Paul Jakma <paul.jakma@sun.com>
129
130 * ospf_lsdb.c: (ospf_lsdb_delete_entry) new function, consolidate
131 exact same functionality replicated in other functions.
132 (ospf_lsdb_add) Strip out code by using ospf_lsdb_delete_entry.
133 (ospf_lsdb_delete) ditto.
134 (ospf_lsdb_delete_all) ditto.
135
Paul Jakma8dd24ee2006-08-27 06:29:30 +00001362006-08-03 Paul Jakma <paul.jakma@sun.com>
137
138 * ospf_packet.c: (ospf_make_db_desc) Unset the DD More bit
139 after constructing the packet, if appropriate.
140 (ospf_db_desc_proc) Speed up Exchange, slave should raise
141 ExchangeDone earlier, as RFC mandates, by forming its reply
142 before deciding whether both sides are done, avoids a
143 needless round of empty DD packet exchanges at the end of
144 Exchange, hence speeding up ExchangeDone.
Paul Jakmaf0894cf2006-08-27 06:40:04 +0000145 Implement draft-ogier-ospf-dbex-opt DB-exchange optimisation.
Paul Jakma8dd24ee2006-08-27 06:29:30 +0000146 (ospf_db_desc) use UNSET_FLAG macro.
147
Andrew J. Schorr16700082006-07-27 22:29:06 +00001482006-07-27 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
149
150 * ospfd.c: (ospf_router_id_update) Fix and document the algorithm for
151 selecting the router ID: if there is not a statically configured ID,
152 then stick to the most recent value to avoid disruptive changes.
153 This should fix bug #288.
154
Paul Jakma1fe6ed32006-07-26 09:37:26 +00001552006-07-26 Paul Jakma <paul.jakma@sun.com>
156
157 * ospf_lsa.{c,h}: (ospf_lsa_unlock) Change to take a double pointer
158 to the LSA to be 'unlocked', so that, if the LSA is freed, the
159 callers pointer to the LSA can be NULLed out, allowing any further
160 use of that pointer to provoke a crash sooner rather than later.
161 * ospf_*.c: (general) Adjust callers of ospf_lsa_unlock to match
162 previous. Try annotate 'locking' somewhat to show which 'locks'
163 are protecting what LSA reference, if not obvious.
164 * ospf_opaque.c: (ospf_opaque_lsa_install) Trivial: remove useless
165 goto, replace with return.
166 * ospf_packet.c: (ospf_make_ls_ack) Trivial: merge two list loops,
167 the dual-loop predated the delete-safe list-loop macro.
168
Paul Jakma3fed4162006-07-25 20:44:12 +00001692006-07-25 Paul Jakma <paul.jakma@sun.com>
170
171 * ospf_neigbor.h: (struct ospf_neighbor) Add some additional
172 neighbour state statistics fields, timestamps for progressive
173 and regressive state changes, and pointer to event string
174 for the latter state change.
175 * ospf_nsm.c: (nsm_notice_state_change) Update new state changs
176 history as required.
177 * ospf_vty.c: (show_ip_ospf_neighbor_detail_sub) Print out above
178 new per-neighbour state change stats.
179
Paul Jakma539e1522006-07-11 17:49:22 +00001802006-07-10 Paul Jakma <paul.jakma@sun.com>
181
182 * ospf_nsm.c: (nsm_change_state) call nsm_clear_adj for all
183 adjacency losses, hence removing need for nsm_reset_nbr.
184 (nsm_reset_nbr) kill it, clear_adj in previous does fine.
185 (nsm_kill_nbr,nsm_start) remove nsm_reset_nbr call.
186 (ospf_nsm_event) Allow NSM function to be NULL, this along with
187 removal of nsm_reset_nbr, allows a bunch of now useless functiosn
188 to be removed.
189 Remove some useless variables.
190 (nsm_ignore) now useless, remove.
191 (nsm_bad_ls_req) ditto
192 (nsm_seq_number_mismatch) "
193 (nsm_oneway_received) "
194 (nsm_inactivity_timer) "
195 (nsm_ll_down) "
196 (NSM) replace removed action functions with NULL.
Paul Jakma3d63f382006-07-11 17:52:53 +0000197 (nsm_notice_state_changes) Move state change logging code to new
198 func to declutter nsm_change_state and ospf_nsm_event.
199 Log event with AdjChange, it's useful to know.
200 (nsm_change_state) move adjchange and snmp logging to previous.
201 (ospf_nsm_event) call nsm_notice_state_changes from here.
202 Move the debug message to entry of function, so it gets out
203 even if something goes wrong.
Paul Jakma90c33172006-07-11 17:57:25 +0000204 Record state change timestamp and event in nbr struct.
205 * ospf_neighbor.h: (struct ospf_neighbor) Add fields to record
206 timestamp of last NSM change and event.
207 * ospf_vty.c: (show_ip_ospf_neighbor_detail_sub) Print
208 last state change timestamp and event, if available.
Paul Jakma539e1522006-07-11 17:49:22 +0000209
Andrew J. Schorr13cd3dc2006-07-11 01:50:30 +00002102006-07-10 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
211
212 * ospf_packet.c: (ospf_hello) Improve NetworkMask mismatch warning
213 message to include interface name and conflicting prefix lengths.
214
Paul Jakma1f2c2742006-07-10 07:45:13 +00002152006-07-07 Paul Jakma <paul.jakma@sun.com>
216
217 * ospf_nsm.h: Add a NSM_Deleted neighbour state, to act as dummy
218 state indicating the neighbour is to be deleted.
219 * ospf_nsm.c: (general) Use the NSM_Deleted state to delete
220 neighbours, thus allowing code to be slightly more obvious
221 in its flow.
222 (nsm_timer_set) Add NSM_Deleted. Add another timer the code
223 missed.
224 (nsm_kill_nbr) No need for special case call to nsm_change_state
225 anymore.
226 Make the assert and error-handling for same case more readable
227 (Andrew Schorr)
228 Remove the call to ospf_nbr_delete, nsm_change_state can do
229 this generally now via NSM_Deleted.
230 (struct ... NSM) Add the dummy NSM_Deleted state, the 3 events
231 that can lead to nsm_kill_nbr all now transition the NBR to
232 NSM_Deleted and the general change_state function can be left
233 to do the work.
234 (ospf_nsm_event) Special casing of events and early-return can
235 be removed now.
236 On transition into Deleted, delete the nbr.
237 * ospf_dump.c: (ospf_nsm_state_msg) Add Deleted.
238
Paul Jakmaaa2737a2006-07-06 11:12:39 +00002392006-07-06 Paul Jakma <paul.jakma@sun.com>
240
241 * ospf_nsm.c: (ospf_nsm_event) LLDown event also results in nbr
242 being deleted, requires early-return too. Likely explains
243 some crash reports after interface events.
244
Paul Jakmaf7a76ab2006-07-04 13:57:49 +00002452006-07-04 Paul Jakma <paul.jakma@sun.com>
246
247 * ospf_nsm.c: (general) Various small cleanups from Andrew's
248 review of last set of patches.
249 (nsm_timer_set) Loading, Full and default can share
250 same code too.
251 (nsm_should_adj) Can just be one big OR.
252 (nsm_twoway_received) Collapse into return statement.
253
Paul Jakmad7b0fb62006-07-04 13:35:24 +00002542006-07-02 Paul Jakma <paul.jakma@sun.com>
255
256 * ospf_nsm.c: (nsm_should_adj) New function, just consolidate the
257 10.4 adjacency check from nsm_twoway_received/nsm_adj_ok.
258 (nsm_twoway_received/nsm_adj_ok) Use former.
Paul Jakmad1b1cd82006-07-04 13:50:44 +0000259 (nsm_clear_adj) clear adjacency related state for a
260 neighbour, needed for some state changes from > ExStart down
261 to ExStart or less, which need not go through nsm_reset_nbr.
262 (nsm_reset_nbr) move code to former. Should be static.
Paul Jakmaba0beb42006-07-04 13:44:19 +0000263 (ospf_nsm_event) Don't allow action functions to change
264 next_state if the NSM tables do not indicate next_state is
265 conditional, log warning if one tries - existing code
266 appears fine though.
Paul Jakmad1b1cd82006-07-04 13:50:44 +0000267 Remove long dead code.
268 Use nsm_clear_adj for state changes that take down
269 adjacencies to TwoWay/ExStart.
Paul Jakmae55dd532006-07-04 13:46:14 +0000270 (nsm_timer_set) ls_req timer should be OFF in early states.
271 Compact several identical sections.
272 Set inactivity timer to OFF for Down, for documentary
273 purposes.
Paul Jakmad1b1cd82006-07-04 13:50:44 +0000274 (nsm_kill_nbr) Oops, action function shouldn't try return
275 1 for error.
Paul Jakma5db95bc2006-07-04 13:52:29 +0000276 * ospf_lsa.c: (ospf_translated_nssa_refresh) CID #13.
Paul Jakmad7b0fb62006-07-04 13:35:24 +0000277
Andrew J. Schorr1c066bf2006-06-30 16:53:47 +00002782006-06-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
279
280 * ospf_vty.c: (show_ip_ospf_neighbor_id) Should show all instances
281 of that neighbor (since it may appear on multiple interfaces)
282 instead of bailing out after showing the first match.
283
Andrew J. Schorr76947872006-06-30 03:21:05 +00002842006-06-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
285
286 * ospf_nsm.c: (nsm_twoway_received) When deciding whether to
287 change from state Init to ExStart, the test for whether the
288 neighboring router is DR or BDR should be against the
289 local router's notion of DR/BDR, not the neighbor's view.
290
Andrew J. Schorrd7e60dd2006-06-29 20:20:52 +00002912006-06-28 Erik Muller <erikm@internap.com>
292
293 * ospfd.h: Define 2 new struct ospf config flags:
294 OSPF_LOG_ADJACENCY_CHANGES and OSPF_LOG_ADJACENCY_DETAIL
295 * ospf_nsm.c (nsm_change_state): Log adjacency changes if
296 requested.
297 * ospf_vty.c (ospf_log_adjacency_changes): New command function
298 to implement ospf subcommand "log-adjacency-changes [detail]".
299 (no_ospf_log_adjacency_changes) Turn off log-adjacency-changes.
300 (show_ip_ospf) Show whether adjacency changes are logged.
301 (ospf_config_write) Add "log-adjacency-changes [detail]" to config.
302 (ospf_vty_init) Add ospf_log_adjacency_changes and
303 no_ospf_log_adjacency_changes.
304
Paul Jakma9560fa82006-06-26 12:50:06 +00003052006-06-26 Paul Jakma <paul.jakma@sun.com>
306
307 * ospf_abr.c: (general) NSSA translate-candidate ABRs need to
308 be ASBRs, or other routers may rightfully refuse to install
309 translated type-5s LSAs. reported by dendroot@gmail.com.
310 (ospf_abr_nssa_check_status) Detect change in translator
311 state when ABR, and inc/dec redistribute count as when we
312 leave/enter the disabled state - so that translate-enabled
313 ABR properly sets ASBR bit on non-NSSA areas.
314 Run the resulting function through indent to clean it up.
315 * ospf_lsa.c: (router_lsa_flags) For purposes of ASBR bit,
316 NSSA area is same as stub area.
317
Andrew J. Schorr0ffb7092006-06-24 19:40:13 +00003182006-06-24 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
319
Andrew J. Schorr9aecfae2006-06-24 20:05:02 +0000320 * ospf_snmp.c: (ospfTrapNbrStateChange, ospfTrapIfStateChange) Improve
321 info log message to indicate why the trap is being sent.
322
3232006-06-24 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
324
Andrew J. Schorr0ffb7092006-06-24 19:40:13 +0000325 * ospf_dump.c: (config_write_debug) Fix typo to show debug ospf nsm
326 status properly (not ism status).
327
Andrew J. Schorr6e72cb62006-06-18 00:45:48 +00003282006-06-17 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
329
330 * ospf_vty.c: ({no_,}ospf_passive_interface) Replace if_lookup_by_name
331 with a call to if_get_by_name -- if the interface does not exist
332 already, it should be created. And remove the obsolete warning
333 message.
334
Paul Jakma429ac782006-06-15 18:40:49 +00003352006-06-15 Paul Jakma <paul.jakma@sun.com>
336
337 * ospf_interface.h: (struct ospf_if_info) Add reference counts
338 for multicast group memberships. Add various macros to help
339 manipulate/check membership state.
340 * ospf_interface.c: (ospf_if_set_multicast) Maintain the
341 ospf_if_info reference counts, and only actually drop
342 memberships if it hits 0, to avoid losing membership when
343 OSPF is disabled on an interface with multiple active OSPF
344 interfaces.
345 * ospf_packet.c: (ospf_{hello,read}) Use the new macros to
346 check/set
347 multicast membership.
348 * ospf_vty.c: (show_ip_ospf_interface_sub) ditto.
349
Paul Jakmaac904de2006-06-15 12:04:57 +00003502006-05-31 Paul Jakma <paul.jakma@sun.com>
351
352 * ospf_lsdb.c: (ospf_lsdb_delete) robustify against NULL arguments,
353 print warning.
354 * ospf_lsa.c: (ospf_discard_from_db) ditto.
355 (ospf_maxage_lsa_remover) Check lsa->lsdb for validity, possible
356 mitigation (but not solution) for bug #269.
357
Paul Jakma88871b12006-06-15 11:41:19 +00003582006-05-30 Paul Jakma <paul.jakma@sun.com>
359
360 * ospf_packet.c: (ospf_read) Debug message about packets
361 received on unenabled interfaces should be conditional on
362 debug being set.
363
Paul Jakmad1c65c22006-06-27 08:01:43 +00003642006-05-23 Paul Jakma <paul.jakma@sun.com>
365
366 * ospf_vty.c: (general) Replace in-place route redistribution
367 command and help strings with the new auto-generated defines
368 from lib/route_types.h
369
Paul Jakmaae128052006-05-12 23:15:30 +00003702006-05-13 Paul Jakma <paul.jakma@sun.com>
371
372 * ospf_lsa.c: (ospf_translated_nssa_refresh) fix the sanity
373 check to match the assert, small error in CID #13 fix.
374
Paul Jakma70461d72006-05-12 22:57:57 +00003752006-05-12 Paul Jakma <paul.jakma@sun.com>
376
377 * ospf_lsa.c: (ospf_lsa_action) Get rid of the ospf_lookup
378 call, which is not checked for NULL return, by stripping out
379 functionality which is never used, hence fixing Coverity CID
380 #29.
381 (struct lsa_action) remove unused member.
Paul Jakmae54e6e52006-05-12 23:11:14 +0000382 (ospf_translated_nssa_refresh) Add non-assert sanity check,
383 in case DEBUG isn't defined.
384 Debug message when no type7 exists should print the ID from
385 the type5, not the type7, fixes CID #13.
386 * ospf_interface.c: (ospf_if_exists) Fix missing NULL return
Paul Jakmae43be0e2006-05-12 23:00:06 +0000387 check on ospf_lookup, CID #27.
Paul Jakma6db3a6f2006-05-12 23:02:46 +0000388 * ospf_asbr.c: (ospf_redistribute_withdraw) remove ospf_lookup
389 call by taking the struct ospf * as argument, which the
390 caller has, fixing CID #28.
391 * ospf_asbr.h: (ospf_redistribute_withdraw) update declaration
392 * ospf_zebra.c: (ospf_redistribute_unset) update call to
393 ospf_redistribute_withdraw to match.
Paul Jakmabfd7c7d2006-05-12 23:04:45 +0000394 * ospf_ia.c: (ospf_update_router_route) ospf->backbone could be
395 NULL when passed to ospf_find_asbr_route_through_area,
396 check for NULL first, CID #14.
Paul Jakmadeb15612006-05-12 23:07:27 +0000397 * ospf_ism.c: (ism_change_state) NULL check on oi->area is
398 useless, it's always valid. Only possibility where it
399 couldn't be is if there is a race between abr_task and
400 cleaning up oi's, in which case a NULL check here isn't going
401 to do anything. Fixes CID #15.
Paul Jakma70461d72006-05-12 22:57:57 +0000402
Paul Jakmacac3b5c2006-05-11 13:31:11 +00004032006-05-11 Paul Jakma <paul.jakma@sun.com>
404
405 * ospf_vty.c: (general) Audit ospf_lookup calls in commands,
406 ensure check for NULL result, make vty messages consistent.
407 (show_ip_ospf_interface) Missing NULL check on ospf_lookup
408 result, fixes Coverity CID #70.
Paul Jakma1a8ec2b2006-05-11 13:34:08 +0000409 (no_ospf_area_filter_list) Check NULL result from
410 ospf_area_lookup_by_area_id, fixes Coverity CID #69
Paul Jakma894f8b62006-05-12 22:50:40 +0000411 * ospf_route.c: (ospf_route_delete_same_ext) Fix deref before
412 NULL check by moving into check-protected block, fix CID #49.
Paul Jakma214a4452006-05-12 22:51:49 +0000413 * ospf_abr.c: (ospf_area_range_cost_set) Shouldn't create a new
414 range, should just lookup to see if one exists, the new range
415 is just leaked. Fixes CID #46.
Paul Jakma4021b602006-05-12 22:55:41 +0000416 * ospf_lsa.c: (ospf_default_originate_timer) Let the thread
417 take (struct ospf *) as thread argument, rather than (struct
418 ospf *)->default_originate, thus avoiding having to call
419 ospf_lookup.
420 * ospf_zebra.c: (ospf_redistribute_default_set) change setup
421 of ospf_default_originate_timer thread to match.
422 * ospfd.c: (ospf_router_id_update) ditto.
Paul Jakmacac3b5c2006-05-11 13:31:11 +0000423
Paul Jakma9c27ef92006-05-04 07:32:57 +00004242006-04-24 Paul Jakma <paul.jakma@sun.com>
425
426 * (general) More Virtual-link fixes, again with much help in
427 testing / debug from Juergen Kammer. Primarily in SPF.
428 * ospf_spf.h: Add guard. ospf_interface.h will include this
429 header.
430 * ospf_interface.h: Modify ospf_vl_lookup definition to take
431 struct ospf as argument, so as to allow for NULL area
432 argument.
433 (struct ospf_vl_data) Remove out_oi, instead add a struct
434 vertex_nexthop, to use as initial nexthop for backbone paths
435 through a vlink.
436 * ospf_interface.c: (ospf_vl_lookup) Modified to allow
437 NULL area to be passed to indicate "any" (first) area.
438 Add extra debug.
439 (ospf_vl_set_params) vl_oi -> nexthop. Add extra debug.
440 (ospf_vl_up_check) Fix debug, inet_ntoa returns a static
441 buffer..
442 * ospf_route.c: (ospf_intra_add_router) Vlinks dont go through
443 backbone, don't bother checking.
444 * ospf_spf.c: (static struct list vertex_list) Record vertices
445 that will need to be freed.
446 (cmp) Order network before router vertices, as required,
447 wasn't implemented.
448 (vertex_nexthop_free) Mild additional robustness check.
449 (vertex_parent_free) Take void argument, as this function
450 is passed as list deconstructor for vertex parent list.
451 (ospf_vertex_new) More debug. Set deconstructor for parent
452 list. Track allocated vertices on the vertex_list.
453 (ospf_vertex_free) Get rid of the tricky recursive cleanup of
454 vertices. Now frees only the given vertex.
455 (ospf_vertex_add_parent) Fix assert.
456 (ospf_nexthop_calculation) Fix calculation of nexthop for
457 VLink vertices, lookup the vl_data and use its previously
458 recorded nexthop information.
459 (ospf_spf_calculate) Vertices are freed simply by deleting
460 vertex_list nodes and letting ospf_vertex_free as deconstructor
461 work per-node.
462 (ospf_spf_calculate_timer) Trivial optimisation, leave
463 backbone SPF calculation till last to reduce SPF churn on
464 VLink updates.
465 * ospf_vty.c: (ospf_find_vl_data) update call to ospf_vl_lookup
466 (no_ospf_area_vlink_cmd) ditto.
467 (show_ip_ospf_interface_sub) For Vlinks, the peer address is
468 more interesting than the output interface.
469
Paul Jakma478aab92006-04-03 21:25:32 +00004702006-04-03 Paul Jakma <paul.jakma@sun.com>
471
472 * (general) Fix issues with handling of Vlinks and entries
473 in the nbrs route-table which were highlighted by the
474 nsm/nbr_self fixes from bug #234. Many thanks to Juergen
475 Kammer for his help and efforts in testing out debug patches to
476 pinpoint the issue.
477 * ospf_interface.c: (ospf_vl_new) Add nbr_self for Vlink.
478 * ospf_neighbor.c: (ospf_nbr_key) new static function, helper
479 to create key in nbrs table for a given nbr.
480 (ospf_nbr_delete) Use ospf_nbr_key. Add an assert() to
481 document an expected state.
482 (ospf_nbr_add_self) Ditto.
483 (ospf_nbr_lookup_by_addr) Add an assert.
484 * ospf_nsm.c: (nsm_kill_nbr) Can never kill the nbr_self
485 psuedo-neighbour.
486
Paul Jakma075c2012006-03-30 14:34:31 +00004872006-03-27 Paul Jakma <paul.jakma@sun.com>
488
489 * ospf_lsa.c: (ospf_lsa_checksum) Add an explicit cast to avoid
490 the ambiguities of ANSI and C99 C with respect to type
491 conversion. Detailed problem report and test case with
492 example data supplied by Dmitry Ivanov <dimss@telecentrs.lv>.
493
Paul Jakma1a8ee0e2006-03-30 14:20:00 +00004942006-03-25 Paul Jakma <paul.jakma@sun.com>
495
496 * ospf_interface.c: (ospf_if_lookup_recv_if) Ignore loopbacks,
497 we can never ever receive packets on those. Should fix
498 case where CARP is run with address in same subnet as real
499 interface. Problem report and diagnosis thanks to:
500 Landon Fuller <landonf@opendarwin.org>.
501 However, ospf_read() still can't deal deterministically with
502 multiple interfaces in same subnet.
503
Paul Jakmac2b478d2006-03-30 14:16:11 +00005042006-03-23 Steve Lawson <steve.lawson@aheadcomusa.com>
505
506 * ospf_lsa.c: (ospf_lsa_install) Fix incorrect byte-order
507 conversion of OSPF_MAX_SEQUENCE_NUMBER
508
paule8e19462006-01-19 20:16:55 +00005092006-01-19 Paul Jakma <paul.jakma@sun.com>
510
511 * (general) various miscellaneous compiler warning fixes.
512 Remove redundant break statements from switch clauses
513 which return.
514 return from main, not exit, cause it annoys SOS.
515 Remove stray semi-colons which cause empty-statement
516 warnings.
517
paul779adb02006-01-18 15:07:38 +00005182006-01-18 Juergen Kammer <j.kammer@eurodata.de>
519
520 * ospf_lsa.c: (ospf_router_lsa_new) dont take reference to the
521 stream data until it is constructed, data reference is
522 volatile due to the potential resize in link_info_set
523
5242006-01-18 Paul Jakma <paul.jakma@sun.com>
525
526 * ospf_lsa.c: (link_info_set) Resize the stream if required and
527 possible. Return number of links added.
528 (lsa_link_*_set) use return value from previous.
529 * ospf_lsa.h: Add OSPF_ROUTER_LSA_LINK_SIZE define.
530
paulc6371712006-01-17 17:49:53 +00005312006-01-17 Paul Jakma <paul.jakma@sun.com>
532
533 * ospf_packet.c: (ospf_verify_header) print out the types
534 involved if there's a mismatch.
535 * ospf_zebra.c: (ospf_zebra_add) Adjust to new zserv format.
536
paul818e56c2006-01-10 23:27:05 +00005372006-01-10 Len Sorensen <lennartsorensen@ruggedcom.com>
538
539 * (general) Bug #234, see also [quagga-dev 3902].
540 Fix problem with nbr_self not being properly reinitialised
541 when an interface comes up, after having been down.
paul1a643f82006-01-11 01:08:19 +0000542 Some re-arrangement done by Paul Jakma, any bugs introduced
543 on top of Len's suggested changes are his.
paul818e56c2006-01-10 23:27:05 +0000544 * ospf_neighbor.c: (ospf_nbr_add_self) centralise
545 initialisation of nbr_self parameters here.
546 * ospf_interface.c: (ospf_if_new) deleting initialisation of
547 parameters of nbr_self, just rely on call to
548 ospf_nbr_add_self.
549 (ospf_if_cleanup) ditto.
550 * ospfd.c: (ospf_network_run) ditto.
551
paul98429f62006-01-10 22:11:54 +00005522006-01-10 Juris Kalnins <juris@mt.lv>
553
554 * ospf_zebra.c: (ospf_interface_address_delete) fix rare leak of
555 struct connected in an error case.
paul818e56c2006-01-10 23:27:05 +0000556 * ospf_packet.c: (ospf_make_md5_digest) fix odd, if not
557 undefined effect, assignment of an increment expression.
paul98429f62006-01-10 22:11:54 +0000558
paul86752842006-01-10 20:34:46 +00005592006-01-10 Paul Jakma <paul.jakma@sun.com>
560
561 * ospfd.c: (ospf_network_run) checking to see if router-id
562 is set should be on ospf->router_id, not router_id_static.
563 This was causing ospfd to not start if router-id had not
564 been configured statically.
565 (ospf_if_update) ditto.
paulc42c1772006-01-10 20:36:49 +0000566 * ospf_vty.c: (config_write_ospf_distribute) trim down
567 redundant strings.
paul86752842006-01-10 20:34:46 +0000568
paul00c290e2005-11-26 09:21:43 +00005692005-11-26 Paul Jakma <paul.jakma@sun.com>
570
571 * ospf_api.c: (struct opaque_lsa) change from gcc zero-length
572 array to C99 incomplete type array.
paulc9c93d52005-11-26 13:31:11 +0000573 * (general) s/graceful/deferred/ in all files, the former term
574 is confusing wrt OSPF Graceful-Restart.
575 * ospfd.c: (ospf_deferred_shutdown_check) dont return
576 a function which returns void. SOS complains about this.
577 (ospf_finish)
paul00c290e2005-11-26 09:21:43 +0000578
paulb29800a2005-11-20 14:50:45 +00005792005-11-20 Paul Jakma <paul.jakma@sun.com>
580
581 * ospfd.h: remove the OSPF_ROUTER_ID_UPDATE_DELAY define
582 (struct ospf) remove the router_id timer thread.
583 remove export of ospf_router_id_update_timer.
584 * ospfd.c: (ospf_router_id_update) call ospf_if_update to
585 poke interfaces into action after ID has been configured.
586 (ospf_router_id_update_timer) removed.
587 (ospf_finish_final) t_router_id_update timer is gone.
588 (ospf_network_run) router-id update timer gone.
589 call ospf_router_id_update directly if ID not configured.
590 In the per-iface loop, don't ospf_if_up interfaces if
591 ID is still not configured. The update function will call
592 ospf_if_update anyway.
593 (ospf_if_update) ID update timer is gone. Just return if no
594 ID is set.
595 * ospf_vty.c: (ospf_router_id) call ospf_router_id_update, no
596 timer needed.
597 * ospf_zebra.c: (ospf_router_id_update_zebra) call
598 ospf_router_id_update directly, not via timer.
paulc24d6022005-11-20 14:54:12 +0000599 * ospf_abr.c: (ospf_abr_announce_network_to_area) check
600 returned LSA of ospf_summary_lsa_refresh and print warning if
601 it failed.
602 (ospf_abr_announce_network_to_area) similar
603 (ospf_abr_announce_rtr_to_area) similar
604 * ospf_lsa.c: (ospf_router_lsa_new) check LSA returned is valid.
605 (ospf_router_lsa_originate) similar
606 (ospf_router_lsa_refresh, ospf_network_lsa_new) similar
607 (ospf_summary_lsa_new) Check ID is valid.
608 (ospf_summary_lsa_originate) ditto, and check returned LSA from
609 previous function is !NULL.
610 (ospf_summary_lsa_refresh) check ospf_summary_lsa_new return
611 is !NULL.
612 (ospf_summary_asbr_lsa_new) ID valid check.
613 (ospf_summary_asbr_lsa_originate) similar.
paulb29800a2005-11-20 14:50:45 +0000614
ajs70cd3472005-11-16 19:33:22 +00006152005-11-16 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
616
ajs649654a2005-11-16 20:17:52 +0000617 * ospf_dump.h: Define OSPF_TIME_DUMP_SIZE as appropriate buffer size
618 for use with ospf_timer_dump and ospf_timeval_dump.
619 * ospf_vty.c: Change all buffer sizes used with ospf_timer_dump and
620 ospf_timeval_dump to have size OSPF_TIME_DUMP_SIZE.
621 (show_ip_ospf_interface_sub) Fix possible buffer overflow in
622 call to ospf_timer_dump.
623
6242005-11-16 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
625
ajs70cd3472005-11-16 19:33:22 +0000626 * ospf_ism.h: (OSPF_ISM_TIMER_OFF) Improve macro syntax by enclosing
627 in 'do {...} while(0)'.
628
paul31a59762005-11-14 11:11:11 +00006292005-11-14 Paul Jakma <paul.jakma@sun.com>
630
631 * ospfd.c: (ospf_new) stub-shutdown should just default to
632 unconfigured, too strange otherwise.
633 (ospf_finish_final) t_opaque_lsa_self TIMER_OFF should be
634 preprocessor conditional on HAVE_OPAQUE_LSA.
635 * ospfd.h: (struct ospf) remove the SHUTDOWN_DEFAULT define.
636 no longer used, plus it wasn't in range that the command
637 accepted.
638 * ospf_zebra.h: Depends on vty.h, include it.
639
paul58e1bef2005-11-11 12:10:03 +00006402005-11-11 Paul Jakma <paul.jakma@sun.com>
641
642 * ospf_spf.c: (ospf_canonical_nexthops_free) Free only
643 the nexthops pointing to the root vertex. We may visit a
644 vertex twice or the vertex may have some inherited nexthops,
645 if we free other nexthops we could crash.
646
paulc8c15212005-11-04 12:31:39 +00006472005-11-04 Paul Jakma <paul.jakma@sun.com>
648
649 * ospf_{dump,spf,vty}.c: Oops, use the internal tv_sub
650 function rather than unportable timersub.
651
paul484315f2005-11-03 09:08:29 +00006522005-11-03 Paul Jakma <paul.jakma@sun.com>
653
654 * ospf_apiserver.c: (apiserver_sync_callback) stray semi-colon
655 * ospf_packet.c: include checksum.h, remove the in_cksum extern
656 * prototypes.
657 * ospf_te.h: Add braces, quell warning.
paul6d452762005-11-03 11:15:44 +0000658 * ospf_packet.c: Change level of some warnings to
659 informational.
paulc8c15212005-11-04 12:31:39 +0000660
paul88d6cf32005-10-29 12:50:09 +00006612005-10-29 Paul Jakma <paul.jakma@sun.com>
662
663 * (general) RFC3137 stub-router support
664 * ospfd.h: Add OSPF_OUTPUT_COST_INFINITE define.
665 (struct ospf_master) Add a OSPF_MASTER_SHUTDOWN flag for
666 options, to allow shutdown to distinguish between complete
667 shutdown and shutdown of a subset of ospf instances.
668 (struct ospf)
669 Add stub_router_{startup,shutdown_}time, configuration of startup
670 and shutdown time for stub-router.
671 Add t_graceful_shutdown struct thread, timer for graceful
672 shutdown, if needed.
673 (struct ospf_area) Add stub_router_state - run time state of
674 stub-router for an area. Add flags for ADMIN, IS and WAS
675 states.
676 Add t_stub_router, timer thread to resend router-lsa for an
677 area.
678 * ospf_lsa.c: (ospf_link_cost) new simple function to spit out
679 either the given lnks cost or infinite cost if stub-router is
680 in effect.
681 (lsa_link_{ptop,broadcast,virtuallink,ptomp}_set) use
682 previous function for transit-links.
683 (ospf_stub_router_timer) timer thread for end of startup stub
684 router. Change state as required for the area and setup
685 re-origination of router-lsa.
686 (ospf_stub_router_check) Check/do whether stub-router should be
687 enabled, and whether it requires timer to be setup.
688 (ospf_router_lsa_new) call previous function at top.
689 (ospf_router_lsa_originate) no external callers, made static.
690 * ospf_lsa.h: (ospf_router_lsa_originate) removed.
691 * ospf_main.c: (sigint) make static.
692 remove call to exit, as ospf_terminate now deals with
693 exiting.
694 * ospf_route.c: (ospf_terminate) removed, now in ospfd.c.
695 * ospf_vty.c: (show_ip_ospf_area) print out state of
696 stub-router, if active.
697 (show_ip_ospf) print out configuration of stub-router
698 support, and details of graceful-shutdown if the timer is
699 active.
700 ((no)?ospf_max_metric_router_lsa_{admin,startup,shutdown}) new
701 commands to (de-)?configure stub-router support.
702 (config_write_stub_router) write out config of stub-router.
703 (ospf_config_write) call previous.
704 (ospf_vty_init) install the new stub-router commands.
705 * ospfd.c: various functions made static.
706 (ospf_new) Set defaults for stub-router. Graceful shutdown
707 is made to default on, just to be adventerous.
708 (ospf_graceful_shutdown_finish) new function, final part of
709 shutdown.
710 (ospf_graceful_shutdown_timer) timer thread wrapper for
711 graceful-shutdown.
712 (ospf_graceful_shutdown_check) check whether to setup timer
713 for shutdown or proceed directly to final shutdown.
714 (ospf_terminate) moved here from ospf_route.c, call
715 ospf_finish for each instance.
716 (ospf_finish) renamed to ospf_finish_final and made static.
717 (ospf_finish) new function, exported wrapper around
718 ospf_graceful_shutdown_check.
719 (ospf_finish_final) complete shutdown of an instance.
720 Add missing TIMER_OFF's of two timer threads.
721 (ospf_area_free) opaque self lsa timer should be turned off.
722
paulb8ad39d2005-10-23 15:23:05 +00007232005-10-23 Paul Jakma <paul.jakma@sun.com>
724
paule029d442005-10-23 15:26:24 +0000725 * ospf_apiserver.c: (ospf_apiserver_term) This function should
726 not have side-effects (eg segv) if no apiserver instances are
727 active, ie be robust.
paulb8ad39d2005-10-23 15:23:05 +0000728 * ospf_vty.c: (show_ip_ospf) fix display of SPF timer if it
729 has not yet been run.
730
paulf9ad9372005-10-21 00:45:17 +00007312005-10-21 Paul Jakma <paul.jakma@sun.com>
732
paulea4ffc92005-10-21 20:04:41 +0000733 * ospf_dump.c: (ospf_timeval_dump) fix ms adjustment, thanks to
734 Andrew Schorr.
735 * ospf_vty.c: (ospf_config_write) fix write out of spf timers
736 configuration.
737
7382005-10-21 Paul Jakma <paul.jakma@sun.com>
739
pauld24f6e22005-10-21 09:23:12 +0000740 * (general) SPF millisecond resolution timer with adaptive,
741 linear back-off holdtime. Prettification of ospf_timer_dump.
742 * ospf_dump.c: (ospf_timeval_dump) new function. The guts of
743 ospf_timer_dump, but made to be more dynamic in printing out
744 the relative timeval, sliding the precision printed out
745 according to the value.
746 (ospf_timer_dump) guts moved to ospf_timeval_dump.
747 * ospf_dump.h: export ospf_timeval_dump.
748 * ospf_flood.c: (ospf_flood) remove gettimeofday, use
749 the libzebra exported recent_time instead, as it's not
750 terribly critical to have time exactly right - the dropped
751 LSA will be retransmited to us if we don't ACK it.
752 * ospf_packet.c: (ospf_ls_upd_timer) Ditto, but here we're
753 not transmitting, just putting LSA back on update transmit list.
754 * ospfd.h: delay and holdtimes should be unsigned.
755 Add spf_max_holdtime and spf_hold_multiplier.
756 Update default defines for delay and hold time to be in msec.
757 (struct ospf) change the SPF timestamp to a struct timeval.
758 Remove ospf_timers_spf_(un)?set.
759 * ospfd.c: (ospf_timers_spf_{set,unset}) removed.
760 (ospf_new) initialise spf_max_holdtime and spf_hold_multiplier
761 * ospf_spf.c: (ospf_spf_calculate) SPF timestamp is a timeval
762 now, update with gettimeofday.
763 (ospf_spf_calculate_schedule) Change SPF timers to millisecond
764 resolution.
765 Make the holdtime be adaptive, with a linear increase in
766 holdtime ever consecutive SPF run which occurs within holdtime
767 of previous SPF, bounded by spf_max_holdtime.
768 * ospf_vty.c: Update spf timers commands.
769 (ospf_timers_spf_set) trivial helper.
770 (ospf_timers_throttle_spf_cmd) new command to set SPF delay,
771 initial hold and max hold times with millisecond resolution.
772 (ospf_timers_spf_cmd) Deprecated. Accept the old values,
773 convert to msec, truncate to new limits.
774 (no_ospf_timers_throttle_spf_cmd) set timers to defaults.
775 (no_ospf_timers_spf_cmd) deprecated form, same as previous.
776 (show_ip_ospf_cmd) Display SPF parameters and times.
777 (show_ip_ospf_neighbour_header) Centralise the 'sh ip os ne'
778 header.
779 (show_ip_ospf_neighbor_sub) Fix the field widths. Get rid of
780 the multiple spaces which were making the lines even longer.
781 (show_ip_ospf_neighbor_cmd) Use show_ip_ospf_neighbour_header
782 (show_ip_ospf_neighbor_all_cmd) ditto and fix the field
783 widths for NBMA neighbours.
784 (show_ip_ospf_neighbor_int) Use header function.
785 (show_ip_ospf_nbr_nbma_detail_sub) use sizeof for timebuf,
786 local array - safer.
787 (show_ip_ospf_neighbor_detail_sub) ditto
788 (ospf_vty_init) install the new SPF throttle timer commands.
789
7902005-10-21 Paul Jakma <paul.jakma@sun.com>
791
paulf9ad9372005-10-21 00:45:17 +0000792 * (general) OSPF fast, sub-second hello and 1s dead-interval
793 support.
794 * ospf_dump.c: (ospf_timer_dump) Print out milliseconds too.
795 Callers typically specify a length of 9, so most see
796 millisecs unless they specify the additional length.
797 * ospf_interface.h: (struct ospf_interface) new interface param,
798 fast_hello.
799 * ospf_interface.c: (ospf_if_table_lookup) add brackets,
800 gcc warning fix.
801 (ospf_new_if_params) Initialise fast_hello param.
802 (ospf_free_if_params) Check whether fast_hello is configured.
803 (ospf_if_new_hook) set fast_hello to default.
804 * ospf_ism.h: Wrap OSPF_ISM_TIMER_ON inside do {} while (0) to
805 prevent funny side-effects from its if statement when this
806 macro is used conditionally by other macros.
807 (OSPF_ISM_TIMER_MSEC_ON) new macro, set in milliseconds.
808 (OSPF_HELLO_TIMER_ON) new macro to set hello timer according
809 to whether fast_hello is set.
810 * ospf_ism.c: Update all setting of the hello timer to use
811 either OSPF_ISM_TIMER_MSEC_ON or OSPF_HELLO_TIMER_ON. The
812 former is used when hello is to be sent immediately.
813 * ospf_nsm.c: ditto
814 * ospf_packet.c: (ospf_hello) hello-interval is not checked
815 for mismatch if fast_hello is set.
816 (ospf_read) Annoying nit, fix "no ospf_interface" to be debug
817 rather than a warning, as it can be perfectly normal to
818 receive packets when logical subnets are used.
819 (ospf_make_hello) Set hello-interval to 0 if fast-hellos are
820 configured.
821 * ospf_vty.c: (ospf_auto_cost_reference_bandwidth) annoying
822 nit, don't vty_out if this command is given, it gets tired
823 quick.
824 (show_ip_ospf_interface_sub) Print the hello-interval
825 according to whether fast-hello is set or not.
826 Print the extra 5 millisec characters from (ospf_timer_dump)
827 if fast-hello is configured.
828 (ospf_vty_dead_interval_set) new function, common to all
829 forms of dead-interval command, to set dead-interval and
830 fast-hello correctly. If a dead-interval is given, unset
831 fast-hello, else if a hello-multiplier is set, set
832 dead-interval to 1 and fast-hello to given multiplier.
833 (ip_ospf_dead_interval_addr_cmd) use
834 ospf_vty_dead_interval_set().
835 (ip_ospf_dead_interval_minimal_addr_cmd) ditto.
836 (no_ip_ospf_dead_interval) Unset fast-hello.
837 (no_ip_ospf_hello_interval) Bug-fix, unset of hello-interval
838 should set it to OSPF_HELLO_INTERVAL_DEFAULT, not
839 OSPF_ROUTER_DEAD_INTERVAL_DEFAULT.
840 (config_write_interface) Write out fast-hello.
841 (ospf_config_write) Write a comment about
842 "auto-cost reference-bandwidth" having to be equal on all
843 routers. Hopefully just as noticeable as old practice of
844 writing to vty, but less annoying.
845 (ospf_vty_if_init) install the two new dead-interval
846 commands.
847 * ospfd.h: Add defines for OSPF_ROUTER_DEAD_INTERVAL_MINIMAL
848 and OSPF_FAST_HELLO_DEFAULT.
849
pauleb3da6d2005-10-18 04:20:33 +00008502005-10-18 Paul Jakma <paul.jakma@sun.com>
851
852 * (general) SPF memory management cleanup and fix for rare
853 double-free bug.
854 * ospf_spf.h: (struct vertex_parent) New struct to hold parent
855 specific data, eg the backlink and the parent vertex pointer,
856 and point to the appropriate general struct vertex_nexthop.
857 (struct vertex_nexthop) remove parent vertex pointer, so
858 this struct can be shared across vertices.
859 (struct vertex) rename list child to list children. Remove
860 list of nexthops, replace with list of vertex_parents.
861 * ospf_spf.c: (update_stat) trivial, remove cast from void *.
862 (vertex_nexthop_new) remove init of parent - field is gone
863 from struct vertex_nexthop.
864 (ospf_canonical_nexthops_free) Remove the canonical
865 vertex_nexthop memory objects. These are the vertex_nexthops
866 attached to the first level of router vertices from the root.
867 (vertex_parent_new) new function, create a vertex_parent.
868 (vertex_parent_free) ditto, but free it.
869 (ospf_vertex_new) Update to match changes to struct vertex.
870 (ospf_vertex_free) Recursively free a struct vertex and its
871 children. The parent list is used as a reference count.
872 vertex_nexthops must be free seperately, if required.
873 (ospf_vertex_dump) update to match struct vertex changes.
874 Print out backlink of parents too.
875 (ospf_vertex_add_parent) ditto.
876 (ospf_lsa_has_link) update comment.
877 (ospf_nexthop_add_unique) removed, not needed anymore.
878 (ospf_nexthop_merge) ditto.
879 (ospf_spf_consider_nexthop) renamed to ospf_spf_add_parent.
880 Simplified to just create vertex_parent and add it.
881 (ospf_spf_flush_parents) new function, flush out the parent
882 list.
883 (ospf_nexthop_calculation) Take the relevant route_lsa_link
884 as an argument, which simplifies things and removes the need
885 for the hack in ospf_nexthop_add_unique - ospf_spf_next
886 already knew exactly which link the cost calculated was for.
887 Update to match struct vertex changes too.
888 (ospf_spf_next) Don't create a vertex for W unnecessarily, if
889 it's there's a vertex already created for W, use it, and
890 hence there's no need to free it either.
891 Update some manipulation/comparisons of distance to match.
892 Flush the parent list if a lower cost path is found.
893 (ospf_spf_route_free) unused, removed.
894 (ospf_spf_dump) match the struct vertex changes, and dump the
895 ifname if possible.
896 (ospf_spf_calculate) At end of SPF, free the canonical nexthops
897 and call ospf_vertex_free on the root vertex to free the
898 entire tree.
899 * ospf_interface.c: (ospf_vl_set_params) match struct vertex
900 changes.
901 * ospf_route.c: (ospf_intra_route_add) ditto
902 (ospf_route_copy_nexthops_from_vertex) ditto
903
paul36238142005-10-11 04:12:54 +00009042005-10-11 Paul Jakma <paul.jakma@sun.com>
905
906 * ospf_api.c: sign warnings.
907 * ospf_apiserver.c: sign warning and convert all the struct
908 in_addr initialisations so as not to make assumptions about
909 how this struct is organised, initialise the s_addr member
910 explicitely.
911 * ospf_packet.c: Add const qualifier to auth_key.
912
vincent77df1f72005-10-06 07:46:22 +00009132005-10-06 Alain Ritoux <alain.ritoux@6wind.com>
914
915 * ospf_snmp.c: Avoid mixing interface and ospf_interface objects
916 which now allows snmpwalk to work with ospfIfTable and
917 also with ospfIfMetricTable
918
ajsf52d13c2005-10-01 17:38:06 +00009192005-10-01 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
920
921 * ospf_dump.c: Remove local hard-coded table ospf_redistributed_proto.
922 (ospf_redist_string) New function implemented using new library
923 function zebra_route_string(). Note that there are a few differences
924 in the output that will result: the new function returns strings
925 that are lower-case, whereas the old table was mixed case. Also,
926 the old table mapped ZEBRA_ROUTE_OSPF6 to "OSPFv3", whereas the
927 new function returns "ospf6".
928 * ospfd.h: Remove extern struct message ospf_redistributed_proto[],
929 and add extern const char *ospf_redist_string(u_int route_type)
930 instead.
931 * ospf_asbr.c: (ospf_external_info_add) In two messages, use
932 ospf_redist_string instead of LOOKUP(ospf_redistributed_proto).
933 * ospf_vty.c: Remove local hard-coded table distribute_str.
934 (config_write_ospf_redistribute,config_write_ospf_distribute): Use
935 new library function zebra_route_string() instead of distribute_str[].
936 * ospf_zebra.c: (ospf_redistribute_set,ospf_redistribute_unset,
937 ospf_redistribute_default_set,ospf_redistribute_check)
938 In debug messages, use ospf_redist_string() instead of
939 LOOKUP(ospf_redistributed_proto).
940
jardin6638c1a2005-10-01 00:08:54 +00009412005-09-30 Vincent Jardin <vincent.jardin@6wind.com>
942
943 * ospf_dump.c, ospf_ia.c, ospf_spf.c, ospf_ase.c:
944 remove unused DEBUG
945
vincentba682532005-09-29 13:52:57 +00009462005-09-29 Alain Ritoux <alain.ritoux@6wind.com>
947
vincent5e4914c2005-09-29 16:34:30 +0000948 * ospf_ism.c: generate SNMP traps on Interface state change
949 * ospf_nsm.c: generate SNMP traps on Neighbour state change
950 * ospf_snmp.[ch]: support for SNMP traps for interface and neighbours.
951
9522005-09-29 Alain Ritoux <alain.ritoux@6wind.com>
953
vincentba682532005-09-29 13:52:57 +0000954 * ospf_vty.c: forece default route LSA to be re_issued whenever
955 cost is changed ( [no] ip ospf area XXX default-cost YYY)
956 Support ignore-mtu option
957 * ospfd.h: define OSPF_MTU_IGNORE_DEFAULT
958 * ospf_packet.c: support ignore-mtu option
959 * ospf_interface.h: field added for skipping MTU check
960 * ospf_interface.c: fix memory leak in ospf_crypt_key_delete()
961 Set mtu_ignore field to default value
962 * ospf_abr.[ch]: export ospf_abr_announce_network_to_area()
963 * ospf_ism.h: add MACRO to convert internal ISM status into SNMP
964 correct values
965 * ospf_snmp.c: add sanity check on LSA type in lsdb_lookup_next()
966 convert OSPFIFSTATE internal status into SNMP values
967
vincentc1a03d42005-09-28 15:47:44 +00009682005-09-28 Alain Ritoux <alain.ritoux@6wind.com>
969
970 * ospf_packet.c: use new md5 API
971
ajs5339cfd2005-09-19 13:28:05 +00009722005-09-19 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
973
974 * ospf_lsa.h: (ospf_external_lsa_flush) Comment out the 5th argument
975 (nexthop) since it is not used in the function (except inside
976 some commented-out code).
977 * ospf_lsa.c: (ospf_external_lsa_flush,ospf_external_lsa_refresh)
978 Comment out the 5th argument to ospf_external_lsa_flush.
979 * ospf_asbr.c: (ospf_redistribute_withdraw) Comment out 5th arg
980 to ospf_external_lsa_flush.
981 * ospf_vty.c: (no_ospf_default_information_originate) Eliminate 5th
982 uninitialized nexthop arg to ospf_external_lsa_flush.
983 * ospf_zebra.c: (ospf_zebra_read_ipv4) Comment out 5th arg
984 to ospf_external_lsa_flush.
985 * ospfd.c: (ospf_network_set) Comment out 5th arg
986 to ospf_external_lsa_flush.
987
ajse6a0bf92005-09-17 18:53:38 +00009882005-09-17 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
989
990 * ospf_opaque.c:
991 (ospf_opaque_lsa_refresh_schedule,ospf_opaque_lsa_flush_schedule)
992 No need to call ospf_lookup(), just use lsa0->area->ospf instead.
993
hassobb5b7552005-08-21 20:01:15 +00009942005-08-21 Hasso Tepper <hasso at quagga.net>
995
996 * ospf_vty.c: Make "show ip ospf neighbor xxx" commands work.
997 Interface should be specified by name now.
998
hasso54bedb52005-08-17 13:31:47 +00009992005-08-17 Hasso Tepper <hasso at quagga.net>
1000
1001 * ospf_vty.c: Check carefully if interface exists before trying to
1002 print info about it.
1003
hasso01018ce2005-08-05 07:40:15 +000010042005-08-05 Hasso Tepper <hasso at quagga.net>
1005
1006 * ospf_zebra.c: Don't assert/stop before type == ZEBRA_ROUTE_MAX if
1007 dealing with routemaps. There is ospf->route_map[ZEBRA_ROUTE_MAX]
1008 for default-information.
1009
paulc8987752005-07-26 06:07:22 +000010102005-07-26 Paul Jakma <paul.jakma@sun.com>
1011
1012 * ospf_abr.c: (ospf_abr_announce_network_to_area) SET_FLAG
1013 should be on lsa not old, which may be freed for one thing,
1014 obviously.
1015
pauld57834f2005-07-12 20:04:22 +000010162005-07-12 Paul Jakma <paul.jakma@sun.com>
1017
1018 * ospfd.h: add OSPF_ABR_DEFAULT for convenience, make
1019 OSPF_ABR_CISCO be the default ABR type.
1020 * ospfd.c: (ospf_new) initialise abr_type to OSPF_ABR_DEFAULT
1021 * ospf_vty.c: (no_ospf_abr_type_cmd) add standard as a negatable
1022 abr_type. default abr_type should be OSPF_ABR_DEFAULT.
1023 (ospf_config_write) test whether default abr_type against
1024 OSPF_ABR_DEFAULT, rather than any specific ABR_TYPE.
1025
hasso8469bd72005-06-20 20:50:10 +000010262005-06-20 Hasso Tepper <hasso at quagga.net>
hassof4833e92005-06-20 20:42:26 +00001027
1028 * ospf_nsm.c: Make database exchange for NSSA database work.
1029
paul7461d452005-06-13 13:57:16 +000010302005-06-13 Paul Jakma <paul.jakma@sun.com>
1031
1032 * ospf_spf.c: Try get more information on a SEGV under
1033 ospf_spf_vertex_add_parent.
1034 (ospf_vertex_free) NULL out the child and nexthop lists
1035 (ospf_vertex_add_parent) nexthop and child can not be NULL
1036 vertex_nexthop's parent->child list can not be NULL
1037 (ospf_spf_next) w and cw are per-loop iteration variables, move
1038 declarations into loop body.
1039
hasso1ddd7292005-06-07 19:54:04 +000010402005-06-07 Hasso Tepper <hasso at quagga.net>
1041
1042 * ospf_apiserver.c: Fix obvious error in notifying clients about ISM
1043 changes - oi->ifp->status doesn't give to us info about ISM,
1044 oi->state does.
1045
paul7e440862005-06-01 11:20:51 +000010462005-06-01 Akihiro Mizutani <mizutani@net-chef.net>
1047
1048 * ospf_ism.c (ospf_elect_bdr/ospf_elect_dr): Fix DR election bug.
1049
paul500e4182005-05-26 17:11:13 +000010502005-05-26 Paul Jakma <paul.jakma@sun.com>
1051
1052 * ospf_abr.c: (ospf_abr_update_aggregate) Fix comment, cost bug itself
1053 had been fixed long ago by Sowmini.
1054
paula3387a42005-05-18 23:29:57 +000010552005-05-19 Paul Jakma <paul.jakma@sun.com>
1056
1057 * ospf_interface.c: (ospf_if_table_lookup) Fix a serious bug
1058 a less serious one.
1059 1: this function is supposed to lookup
1060 entries in the oifs ospf_interface route_table and return either
1061 an existing oi or NULL to indicate not found, its caller depends
1062 on this, yet this function uses route_node_get which /always/
1063 returns a route_node - one is created if none exists. Use
1064 route_node_lookup instead. This should fix root cause of the
1065 reports of the (ospf_add_to_if) assert being hit.
1066 2: oi's are inserted into this table with prefixlength set to
1067 /32 (indeed, it should be a hash table, not a route_table),
1068 however prefixlength to lookup was not changed, if no valid entry
1069 can be inserted other than /32, then nothng but /32 should be
1070 looked up. This possibly only worked by fluke..
1071 Fix confirmed by 2 reporters (one list, one IRC), definitely a
1072 backport candidate once it has been incubated in HEAD for a while.
1073 Thanks to Patrick Friedel and Ivan Warren for testing.
1074
paul69310a62005-05-11 18:09:59 +000010752005-05-11 Paul Jakma <paul.jakma@sun.com>
1076
1077 * (general) Fix memory leaks in opaque AS-scope LSAs, reported and
1078 with much debugging done by by scott collins <scollins@agile.tv>.
1079 * ospf_lsa.c: (ospf_discard_from_db) dont call
1080 ospf_ase_unregister_external_lsa for opaque-lsa's, opaques are
1081 never registered with ase in the first place.
1082 * ospf_packet.c: (general) Disabuse opaque related code of its
1083 tendency to try gather up things into temporary lists.
1084 (ospf_ls_upd) remove the temporary lists opaque uses, call
1085 opaque functions inline, just like all other types.
1086 (ospf_ls_ack) ditto.
1087 (ospf_recv_packet) fixup sign warning.
1088 * ospf_opaque.c: (general) fix the unneeded use of lists, and
1089 untwist some of the logic.
1090 (ospf_opaque_self_originated_lsa_received) take a single LSA
1091 as argument, not a list of them. Remove the list loop. Logic
1092 otherwise unchanged.
1093 (ospf_opaque_ls_ack_received) Mostly ditto. But untwist the logic,
1094 move the actions up into the switch block, remove the goto's and
1095 sanitise the logic near the end a bit.
1096 * ospf_opaque.h: Adjust definitions of aforementioned functions
1097 in ospf_opaque.c to match.
1098
paul42c98192005-05-07 02:22:51 +000010992005-05-07 Yar Tikhiy <yar@comp.chem.msu.su>
1100
1101 * ospf_network.c: Log ifindex on multicast membership leave/join
1102 events.
1103
paul4dadc292005-05-06 21:37:42 +000011042005-05-06 Paul Jakma <paul.jakma@sun.com>
1105
1106 * (general) extern and static qualifiers added.
1107 unspecified arguments in definitions fixed, typically they should
1108 be 'void'.
1109 function casts added for callbacks.
1110 Guards added to headers which lacked them.
1111 Proper headers included rather than relying on incomplete
1112 definitions.
1113 gcc noreturn function attribute where appropriate.
1114 * ospf_opaque.c: remove the private definition of ospf_lsa's
1115 ospf_lsa_refresh_delay.
1116 * ospf_lsa.h: export ospf_lsa_refresh_delay
1117 * ospf_packet.c: (ospf_make_md5_digest) make *auth_key const,
1118 correct thing to do - removes need for the casts later.
1119 * ospf_vty.c: Use vty.h's VTY_GET_INTEGER rather than ospf_vty's
1120 home-brewed versions, shuts up several warnings.
1121 * ospf_vty.h: remove VTY_GET_UINT32. VTY_GET_IPV4_ADDRESS and
1122 VTY_GET_IPV4_PREFIX moved to lib/vty.h.
1123 * ospf_zebra.c: (ospf_distribute_list_update_timer) hacky
1124 overloading of the THREAD_ARG pointer should at least use
1125 uintptr_t.
1126
paul9e67dc22005-04-15 12:10:17 +000011272005-04-15 Zhipeng Gong <zpgong@cdc.3upsystems.com>
1128
1129 * ospf_abr.c: (ospf_abr_announce_network_to_area) dont forget
1130 to approve LSAs for the case where metric has changed, lsa gets
1131 flushed otherwise. (backport candidate).
1132
ajs634f9ea2005-04-11 15:51:40 +000011332005-04-11 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1134
1135 * ospf_zebra.c (ospf_zebra_add): Call zclient_send_message instead
1136 of writen.
1137
ajsd2fc8892005-04-02 18:38:43 +000011382005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1139
ajse4319de2005-04-02 23:23:55 +00001140 * ospf_interface.h: (ospf_if_lookup_by_name) Remove declaration of a
1141 function that does not exist.
1142
11432005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1144
ajs21fefa92005-04-02 23:16:41 +00001145 * ospf_zebra.c: (zebra_interface_if_lookup) Must use
1146 if_lookup_by_name_len.
1147
11482005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1149
ajsa3491982005-04-02 22:50:38 +00001150 * ospf_interface.c: (ospf_vl_new) Use strnlen to fix call to if_create.
1151
11522005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1153
ajsd2fc8892005-04-02 18:38:43 +00001154 * ospf_vty.c: (show_ip_ospf_interface_sub) Show ifindex and interface
1155 flags to help with debugging.
1156 * ospf_zebra.c: (ospf_interface_delete) After deleting, set ifp->ifindex
1157 to IFINDEX_INTERNAL.
1158 (zebra_interface_if_lookup) Make function static. Tighten up code.
1159
ajsaca72fd2005-03-31 15:18:21 +000011602005-03-31 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1161
1162 * ospf_dump.c: (show_debugging_ospf) Show if ospf event debugging
1163 is turned on.
1164
ajsfd651fa2005-03-29 16:08:16 +000011652005-03-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1166
ajsa608bbf2005-03-29 17:03:49 +00001167 * ospf_zebra.c: (ospf_interface_state_up) If the MTU of an operative
1168 interface changes, print a debug message and call ospf_if_reset()
1169 to simulate down/up on the interface.
1170 * ospf_interface.h: Declare new function ospf_if_reset().
1171 * ospf_interface.c: (ospf_if_reset) New function to call ospf_if_down
1172 and ospf_if_up for all ospf interfaces attached to an interface.
1173
11742005-03-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1175
ajs5dcbdf82005-03-29 16:13:49 +00001176 * ospf_packet.c: (ospf_write_frags) Enhance error message to
1177 show MTU. Also make function static.
1178 (ospf_write) Enhance error message to show interface name and MTU.
1179 Also make function static.
1180
11812005-03-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1182
1183 * ospf_vty.c: (show_ip_ospf_interface_sub) Display interface MTU and
1184 bandwidth; this is useful for debugging problems. Also, the function
1185 should be static.
ajsfd651fa2005-03-29 16:08:16 +00001186
hasso1b639042005-03-27 13:32:25 +000011872005-03-27 Hasso Tepper <hasso at quagga.net>
1188
1189 * ospf_snmp.c: Don't crash in snmp query if ospf instance doesn't
1190 exist at all.
1191
hasso343f5cc2005-03-25 19:48:40 +000011922005-03-25 Hasso Tepper <hasso at quagga.net>
1193
1194 * ospfd.h: Include log.h, fixes compile with gcc-4.0.
1195
ajs9dbc7972005-03-13 19:27:22 +000011962005-03-13 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1197
1198 * ospf_lsa.c: (ospf_lsa_refresh_walker) If the system clock jumps
1199 backward, then current time may be less than
1200 ospf->lsa_refresher_started. This was causing invalid values
1201 for ospf->lsa_refresh_queue.index resulting in infinite loops.
1202 Problem fixed by casting the expression to unsigned before taking
1203 the modulus.
1204
ajs5c333492005-02-23 15:43:01 +000012052005-02-23 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1206
1207 * ospfd.h: Add new field struct stream *ibuf to struct ospf.
1208 * ospfd.c: (ospf_new) Check return code from ospf_sock_init.
1209 Allocate ibuf using stream_new(OSPF_MAX_PACKET_SIZE+1).
1210 (ospf_finish) Call stream_free(ospf->ibuf.
1211 * ospf_packet.c: (ospf_read) Call stream_reset(ospf->ibuf) and then
1212 pass it to ospf_recv_packet for use in receiving the packet
1213 (instead of allocating a new stream for each packet received).
1214 Eliminate all calls to stream_free(ibuf).
1215 (ospf_recv_packet) The struct stream *ibuf is now passed in as
1216 an argument. No need to use recvfrom to peek at the packet
1217 header (to see how big it is), just use ospf->ibuf which is
1218 always large enough (this eliminates a system call to recvfrom).
1219 Therefore, no need to allocate a stream just for this packet,
1220 and no need to free it when done.
1221
hasso462f20d2005-02-23 11:29:02 +000012222005-02-23 Vincenzo Eramo <eramo at infocom.ing.uniroma1.it>
1223
1224 * ospf_lsa.h: New flag to the LSA structure for the SPF calculation.
1225 * ospf_lsdb.h: Export ospf_lsdb_clean_stat() function.
1226 * ospf_spf.h: Add link to the LSA stat structure into vertex.
1227 * ospf_spf.c: New functions cmp() and update_stat() to manage
1228 candidates. Remove ospf_spf_has_vertex(), ospf_vertex_lookup(),
1229 ospf_install_candidate() and ospf_spf_register() functions not needed
1230 any more. Update ospf_vertex_new(), ospf_spf_next() and
1231 ospf_spf_calculate() functions to use pqueue instead of linked list.
1232
hassoe40dcce2005-02-21 14:58:42 +000012332005-02-21 Hasso Tepper <hasso at quagga.net>
1234
1235 * ospf_ase.c: Don't show messages related to the ase calculations if
1236 we are not debugging.
1237
hasso306541b2005-02-19 17:58:40 +000012382005-02-19 Hasso Tepper <hasso at quagga.net>
1239
1240 * ospf_api.h: char isn't always signed, but it has to be it here.
1241
paulfa81b712005-02-19 01:19:20 +000012422005-02-19 Paul Jakma <paul.jakma@sun.com>
1243
1244 * ospf_packet.c: (ospf_stream_copy) remove
1245 (ospf_packet_dup) use stream_copy instead of ospf_stream_copy
1246
ajs038163f2005-02-17 19:55:59 +000012472005-02-17 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1248
1249 * ospf_packet.c: (ospf_recv_packet) If there is somehow a runt
1250 packet in the queue, it must be discarded. Improve warning messages.
1251 Fix scope to static.
1252 (ospf_read) Fix bug: should reset the read thread in all cases
1253 to make sure we continue to get incoming messages.
1254
paul658b03a2005-02-15 10:10:55 +000012552005-02-15 Paul Jakma <paul.jakma@sun.com>
1256
1257 * ospf_packet.c: (ospf_recv_packet) Fix silly error wrt allocating
1258 ibuf. Thanks Andrew.
1259
paulbfdc44a2005-02-14 23:48:42 +000012602005-02-14 Paul Jakma <paul.jakma@sun.com>
1261
1262 * ospf_packet.c: (ospf_recv_packet) use stream_recvmsg.
1263
hasso082253f2005-02-11 08:31:54 +000012642005-02-11 Hasso Tepper <hasso at quagga.net>
1265
1266 * ospf_lsdb.c: Fix sum of checksums calculation.
1267
ajs083ee9d2005-02-09 15:35:50 +000012682005-02-09 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1269
1270 * ospf_packet.c: (ospf_write) If sendmsg fails, give more info in the
1271 error message.
1272
ajsba6454e2005-02-08 15:37:30 +000012732005-02-08 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1274
ajs8cfde372005-02-08 15:59:16 +00001275 * ospf_interface.h: Reduce structure padding by putting new u_char
1276 field multicast_memberships in a better spot (grouped with
1277 other u_char fields type and state).
1278
12792005-02-08 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1280
ajsba6454e2005-02-08 15:37:30 +00001281 * ospf_interface.h: Improve passive_interface comment. Add new
1282 multicast_memberships bitmask to struct ospf_interface to track
1283 active multicast subscriptions. Declare new function
1284 ospf_if_set_multicast.
1285 * ospf_interface.c: (ospf_if_set_multicast) New function to configure
1286 multicast memberships properly based on the current
1287 multicast_memberships status and the current values of the
1288 ospf_interface state, type, and passive_interface status.
1289 (ospf_if_up) Remove call to ospf_if_add_allspfrouters (this is
1290 now handled by ism_change_state's call to ospf_if_set_multicast).
1291 (ospf_if_down) Remove call to ospf_if_drop_allspfrouters (now
1292 handled by ism_change_state).
1293 * ospf_ism.c: (ospf_dr_election) Remove logic to join or leave
1294 the DRouters multicast group (now handled by ism_change_state's call
1295 to ospf_if_set_multicast).
1296 (ism_change_state) Add call to ospf_if_set_multicast to change
1297 multicast memberships as necessary to reflect the new interface state.
1298 * ospf_packet.c: (ospf_hello) When a Hello packet is received on a
1299 passive interface: 1. Increase the severity of the error message
1300 from LOG_INFO to LOG_WARNING; 2. Add more information to the error
1301 message (packet destination address and interface address);
1302 and 3. If the packet was sent to ospf-all-routers, then try
1303 to fix the multicast group memberships.
1304 (ospf_read) When a packet is received on an interface whose state
1305 is ISM_Down, enhance the warning message to show the packet
1306 destination address, and try to update/fix the multicast group
1307 memberships if the packet was sent to a multicast address.
1308 When a packet is received for ospf-designated-routers, but the
1309 current interface state is not DR or BDR, then increase the
1310 severity level of the error message from LOG_INFO to LOG_WARNING,
1311 and try to fix the multicast group memberships.
1312 * ospf_vty.c: (ospf_passive_interface) Call ospf_if_set_multicast for
1313 any ospf interface that may have changed from active to passive.
1314 (no_ospf_passive_interface) Call ospf_if_set_multicast for
1315 any ospf interface that may have changed from passive to active.
1316 (show_ip_ospf_interface_sub) Show multicast group memberships.
1317
paul3a9eb092005-02-08 11:29:41 +000013182005-02-08 Paul Jakma <paul@dishone.st>
1319
1320 * ospf_packet.c: (various) Remove unneeded stream_set_putp abuse.
1321
ajs847947f2005-02-02 18:38:48 +000013222005-02-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1323
1324 * ospf_packet.c: (ospf_read) Fix bug: must check for state ISM_Down,
1325 not for event ISM_InterfaceDown. And improve the message by
1326 adding the interface flags.
1327
ajs0b7d97d2005-01-30 17:24:02 +000013282005-01-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1329
1330 * ospf_network.c: (ospf_sock_init) Save errno before calling
1331 ospfd_privs.change.
1332
ajsc3eab872005-01-29 15:52:07 +000013332005-01-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1334
1335 * ospf_packet.c: (ospf_packet_add) If oi->obuf is NULL, print
1336 an error message and return.
1337 (ospf_read) If the interface state is ISM_InterfaceDown, issue
1338 a warning message and ignore the packet.
1339
gdt86f1fd92005-01-10 14:20:43 +000013402005-01-10 Greg Troxel <gdt@fnord.ir.bbn.com>
1341
1342 * ospf_packet.h: Remove commented out definition of
1343 OSPF_MAX_PACKET; neither it or the uncommented one are used any more.
1344
1345 * ospf_packet.c (ospf_make_ls_upd): Leave room for authentication
1346 when deciding if an update will fit.
1347 (ospf_packet_authspace): Factor out calculation of size required
1348 for authentication.
1349 (ospf_make_db_desc): Use ospf_max_packet, not OSPF_MAX_PACKET.
1350 Don't confuse readers that there is a macro.
1351
ajs3dc56b52004-12-30 15:11:19 +000013522004-12-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1353
1354 * ospf_network.c: Improve all setsockopt error messages to give detailed
1355 information on the arguments.
1356
ajsb87f7722004-12-29 20:41:26 +000013572004-12-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1358
ajs17eaa722004-12-29 21:04:48 +00001359 * ospf_packet.c: (ospf_db_desc) Reduce severity of "Negotiation done"
1360 messages from LOG_WARNING to LOG_INFO, since this seems to be
1361 normal.
1362
13632004-12-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1364
ajsb87f7722004-12-29 20:41:26 +00001365 * ospf_packet.c: (ospf_read) Always look up the interface if
1366 ospf_recv_packet returns NULL ifp, since some platforms such
1367 as Solaris 8 appear to support ifindex retrieval but don't.
1368
hasso1d806282004-12-22 09:43:20 +000013692004-12-22 Hasso Tepper <hasso at quagga.net>
1370
1371 * ospf_dump.c: Show debug configuration in vtysh.
hassoc6b87812004-12-22 13:09:59 +00001372 * ospf_vty.c: Fix "show ip ospf" output. Router can't be elected in
1373 any case if it's configured as "translate-never".
hassofe71a972004-12-22 16:16:02 +00001374 * ospf_lsdb.[ch]: New function to calculate sum of checksums.
1375 * ospf_vty.c: Bugfix to show really number of AS external LSAs, not
1376 number of all LSAs with AS scope, this includes opaque as LSAs as
1377 well, show this number separately. Show numbers and sums of
1378 checksums for each type of LSAs.
1379 * ospf_lsa.c: Calculate checksum before putting LSA into database.
hasso1d806282004-12-22 09:43:20 +00001380
ajsbc18d612004-12-15 15:07:19 +000013812004-12-15 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1382
1383 * ospf_interface.h: Declare new function ospf_default_iftype.
1384 * ospf_interface.c: (ospf_default_iftype) New function to centralize
1385 this logic in one place.
1386 * ospf_zebra.c: (ospf_interface_add) Use new function
1387 ospf_default_iftype.
1388 * ospf_vty.c: (no_ip_ospf_network,config_write_interface) Fix logic
1389 by using new function ospf_default_iftype.
1390
ajs3aa8d5f2004-12-11 18:00:06 +000013912004-12-11 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1392
1393 * ospf_packet.c: (ospf_db_desc) Should be static, not global.
1394 (ospf_hello,ospf_db_desc,ospf_ls_upd,ospf_ls_ack) Improve warning
1395 messages to include identifying information (e.g. router id).
1396 * ospf_nsm.c: (nsm_change_state) Improve info message to include
1397 router id and state names.
1398
gdt91f3e522004-12-09 14:51:03 +000013992004-12-09 Greg Troxel <gdt@fnord.ir.bbn.com>
1400
gdt3fb9de72004-12-09 16:30:04 +00001401 * ospf_apiserver.c (ospf_apiserver_term): Obtain struct
1402 ospf_apiserver * from listnode. Remove unused variables. Follows
1403 suggestion from Jay Fenlason.
gdt91f3e522004-12-09 14:51:03 +00001404
ajs9b0e25c2004-12-08 19:06:51 +000014052004-12-08 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1406
1407 * *.c: Change level of debug messages to LOG_DEBUG.
1408
ajs274a4a42004-12-07 15:39:31 +000014092004-12-07 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1410
1411 * ospf_main.c: (main) The 2nd argument to openzlog has been removed.
1412
ajs887c44a2004-12-03 16:36:46 +000014132004-12-03 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1414
ajs1210fa62004-12-03 16:43:24 +00001415 * ospf_packet.c: (ospf_db_desc) Reduce priority on a debug message
1416 from LOG_NOTICE to LOG_DEBUG.
1417
14182004-12-03 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1419
ajs887c44a2004-12-03 16:36:46 +00001420 * ospf_main.c: (sigint) Use zlog_notice for termination message.
1421 (main) Issue a startup announcement using zlog_notice.
1422
ajsbec595a2004-11-30 22:38:43 +000014232004-11-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1424
1425 * ospf_packet.c: (ospf_db_desc_proc) Fix spelling of packet in warning
1426 message and in comment.
1427 (ospf_db_desc) Warning message that a packet is being discarded
1428 should give the router id of the packet source. Fix spelling
1429 of packet in two warning messages.
1430 (ospf_ls_req) Warning message that a link state request is being
1431 discarded should give the router id of the neighbor that sent it.
1432
ajs5b85fac2004-11-26 19:36:42 +000014332004-11-26 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1434
1435 * ospf_main.c: Remove #include "debug.h" (was not being used, and
1436 lib/debug.h has now been deleted).
1437
hassoc0652302004-11-25 19:33:48 +000014382004-11-25 Hasso Tepper <hasso at quagga.net>
1439
1440 * ospf_main.c: Make group to run as configurable.
1441
gdt69e13252004-11-15 18:51:15 +000014422004-11-15 Greg Troxel <gdt@fnord.ir.bbn.com>
1443
1444 * ospf_packet.c (ospf_recv_packet): Assume CMSG_SPACE is present
1445 and works (lib/zebra.h provides if OS doesn't).
1446
paul788dab12004-11-15 11:48:37 +000014472004-11-15 Paul Jakma <paul@dishone.st>
1448
1449 * ospf_{apiserver,te}.c: ospf_lsa_free's should be ospf_lsa_unlock.
1450
paul05e85fa2004-11-12 10:52:19 +000014512004-11-12 Paul Jakma <paul@dishone.st>
1452
1453 * ospf_ia.c: (process_summary_lsa) Only an ABR has any reason to
1454 ignore stub area summary default. Even so it seems a strange
1455 check, add a comment to that effect.
1456
paulf3ae74c2004-11-04 20:35:31 +000014572004-11-04 Paul Jakma <paul@dishone.st>
1458
1459 * ospfd.c: (ospf_network_match_iface) revert to previous network
1460 statement match behaviour.
1461
paul62d8e962004-11-02 20:26:45 +000014622004-11-02 Paul Jakma <paul@dishone.st>
1463
1464 * ospf_packet.c: (ospf_write_frags) remove iov arg, msg already points
1465 to it. Add convenience pointer to msg->msg_iov[1], and use this,
1466 fixing the unfortunate borkenness introduced in moving of this code
1467 to a function.
1468 (ospf_write) remove iovp and fix up call to previous.
1469 (ospf_ls_upd_packet_new) cast size to long int - unfortunately
1470 glibc's size_t format modifier is not portable.
1471
paul37ccfa32004-10-31 11:24:51 +000014722004-10-31 Paul Jakma <paul@dishone.st>
1473
1474 * ospf_packet.c: (ospf_write_frags) Add debug output
1475 (ospf_write) set type early, so we can pass it to
1476 ospf_write_frags.
1477 (ospf_ls_upd_packet_new) print size in debug output when too large
1478 packet is encountered.
paul64511f32004-10-31 18:01:13 +00001479 * ospf_zebra.c: (ospf_distribute_list_update_timer) Ugly misuse of
1480 THREAD_ARG to store an integer, but it should at least use same
1481 same type to retrieve the value. Assert value is sane.
paul37ccfa32004-10-31 11:24:51 +00001482
paulac191232004-10-22 12:05:17 +000014832004-10-22 Paul Jakma <paul@dishone.st>
1484
1485 * ospf_network.c: (ospf_sock_init) call neutral setsock_ifindex()
1486 function.
1487 * ospf_packet.c: (ospf_read) manually look up ifindex
paul4ccb2c42004-10-22 22:52:33 +00001488 if system could not have returned one, eg openbsd, thanks to Rivo
1489 Nurges for highlighting problem and fix.
paul06f953f2004-10-22 17:00:38 +00001490 Change setsockopt_pktinfo to setsockopt_ifindex.
paulac191232004-10-22 12:05:17 +00001491
hasso3fb9cd62004-10-19 19:44:43 +000014922004-10-19 Andrew J. Schorr <aschorr@telemetry-investments.com>
1493
1494 * ospf_snmp.c: (ospf_snmp_if_update) Fix logic to handle PtP links
1495 with dedicated subnets properly.
1496 * ospf_lsa.c: (lsa_link_ptop_set) ditto.
1497 * ospfd.c: (ospf_network_match_iface) ditto.
1498 (ospf_network_run) ditto.
1499 * ospf_interface.c: (ospf_if_is_configured) ditto.
1500 (ospf_if_lookup_by_prefix) ditto.
1501 (ospf_if_lookup_recv_if) ditto.
1502 * ospf_vty.c: (show_ip_ospf_interface_sub) Display the peer or
1503 broadcast address if present.
1504
hassod68614d2004-10-13 09:32:48 +000015052004-10-13 Hasso Tepper <hasso at quagga.net>
1506
1507 * ospf_main.c: Unbreak compilation with ospfapi disabled.
hassoc75105a2004-10-13 10:33:26 +00001508 * ospf_snmp.c: Remove defaults used to initialize smux connection to
1509 snmpd. Connection is initialized only if smux peer is configured.
hassod68614d2004-10-13 09:32:48 +00001510
hassof4d58ce2004-10-12 06:13:54 +000015112004-10-12 Hasso Tepper <hasso at quagga.net>
1512
1513 * ospf_main.c, ospf_opaque.c: Unbreak ospfclient compilation - move
1514 static variable from ospf_main.c into ospf_opaque.c.
1515
hassoc3abdb72004-10-11 16:27:03 +000015162004-10-11 Hasso Tepper <hasso at quagga.net>
1517
1518 * ospf_main.c, ospf_opaque.c: Disable ospfapi init by default. New
1519 command line switch to enable it.
1520
paul6b333612004-10-11 10:11:25 +000015212004-10-11 Paul Jakma <paul@dishone.st>
1522
1523 * ospf_dump.c: (ospf_ip_header_dump) Assume header is in host order
1524 remove ntohs that should have dissappeared. Take struct ip
1525 as argument, caller has to know there's an IP header at start of
1526 stream anyway.
1527 * ospf_dump.h: update declaration of ospf_ip_header_dump.
1528 * ospf_packet.c: (ospf_write) correct call to
1529 sockopt_iphdrincl_swab_htosys which was munging the header.
1530 (ospf_recv_packet) ip_len is needed for old OpenBSD fixup.
1531 (ospf_read) sockopt_iphdrincl_swab_systoh ip header as soon as
1532 we have it.
paul6c835672004-10-11 11:00:30 +00001533 * (global) Const char update and signed/unsigned fixes.
1534 * (various headers) size defines should be unsigned.
1535 * ospf_interface.h: remove duplicated defines, include the
1536 authoritative header - though, these defines should probably
1537 be moved to a dedicated header, or ospfd.h.
1538 * ospf_lsa.h: (struct lsa) ls_seqnum should be unsigned.
1539 * ospf_packet.c: (ospf_write) cast result of shift to unsigned.
paul6b333612004-10-11 10:11:25 +00001540
hassoeb1ce602004-10-08 08:17:22 +000015412004-10-08 Hasso Tepper <hasso at quagga.net>
1542
1543 * *.[c|h]: Fix compiler warnings: make some strings const, signed ->
1544 unsigned, remove unused variables etc.
1545
gdt54ade992004-10-07 19:38:20 +000015462004-10-07 Greg Troxel <gdt@claude.ir.bbn.com>
1547
1548 * ospf_apiserver.c (ospf_apiserver_unregister_opaque_type): Don't
1549 use of variable names 'node' and 'nextnode' to avoid possible
1550 conflict with list macros. Move variable declaration inside for
1551 loop after a statement to top of function.
1552
paulaa20c6f2004-10-07 14:19:36 +000015532004-10-07 Paul Jakma <paul@dishone.st>
1554
1555 * ospf_snmp.c: Missed list typedef update
1556 * ospf_dump.c: Include sockopt.h for header swab functions.
1557
paul18b12c32004-10-05 14:38:29 +000015582004-10-05 Paul Jakma <paul@dishone.st>
1559
1560 * ospf_packet.c: replace ospf_swap_iph_to... with
1561 sockopt_iphdrincl_swab_...
1562
hasso18a6dce2004-10-03 18:18:34 +000015632004-10-03 James R. Leu <jleu at mindspring.com>
1564
1565 * ospf_zebra.c: Read router id related messages from zebra daemon.
1566 Schedule router-id update thread if it's changed.
1567 * ospfd.c: Remove own router-id selection function. Use router id from
1568 zebra daemon if it isn't manually overriden in configuration.
1569
paul68defd62004-09-27 07:27:13 +000015702004-09-27 Paul Jakma <paul@dishone.st>
1571
paul6a99f832004-09-27 12:56:30 +00001572 * ospf_dump.c: (ospf_ip_header_dump) Use HAVE_IP_HDRINCL_BSD_ORDER
1573 Apply to offset too. Print ip_cksum, lets not worry about
1574 possible 2.0.37 compile problems.
1575 * ospf_packet.c: (ospf_swap_iph_to{n,h}) Use
1576 HAVE_IP_HDRINCL_BSD_ORDER.
1577 (ospf_recv_packet) ditto.
1578 (ospf_write) Fixup iov argument to ospf_write_frags.
1579 (struct msghdr).msg_name is caddr_t on most platforms.
paul68defd62004-09-27 07:27:13 +00001580 (ospf_recv_packet) ditto. And msg_flags is not always there
1581 memset struct then set fields we care about rather than
1582 initialise all fields individually.
1583
hassoc9e52be2004-09-26 16:09:34 +000015842004-09-26 Hasso Tepper <hasso at quagga.net>
1585
1586 * ospf_abr.c, ospf_dump.c, ospf_lsa.c, ospf_packet.c, ospf_vty.c,
1587 ospf_zebra.c: Fix compiler warnings.
1588
paul87d6f872004-09-24 08:01:38 +000015892004-09-24 Paul Jakma <paul@dishone.st>
1590
1591 * ospf_apiserver.{c,h}: lists typedef removal cleanup.
1592 update some list loops to LIST_LOOP. some miscellaneous indent
1593 fixups.
1594 (ospf_apiserver_unregister_opaque_type) fix listnode_delete of
1595 referenced node in loop.
paul1603c062004-09-24 08:23:24 +00001596 (ospf_apiserver_term) loops calling ospf_apiserver_free, which
1597 deletes referenced nodes from apiserver_list, fixed.
paul87d6f872004-09-24 08:01:38 +00001598 * ospf_interface.h: lists typedef removal cleanup.
1599 * ospf_opaque.{c,h}: lists typedef removal cleanup. update some list
1600 loops to LIST_LOOP. miscellaneous style and indent fixups.
1601 * ospf_te.{c,h}: ditto
1602 * ospf_packet.c: lists typedef removal cleanup.
paula2570682004-09-24 08:09:57 +00001603 (ospf_write) ifdef fragmentation support. move actual
1604 fragmentation out to a new, similarly ifdefed, function.
1605 (ospf_write_frags) fragmented write support, moved from previous.
paul87d6f872004-09-24 08:01:38 +00001606
hasso52dc7ee2004-09-23 19:18:23 +000016072004-09-23 Hasso Tepper <hasso at quagga.net>
1608
1609 * *.[c|h]: list -> struct list *, listnode -> struct listnode *.
1610
paul68b73392004-09-12 14:21:37 +000016112004-09-12 Paul Jakma <paul@dishone.st>
1612
1613 * ospf_packet.c: Fix bugzilla #107
1614 (ospf_packet_max) get rid of the magic 88 constant
1615 (ospf_swab_iph_ton) new function. set ip header to network order,
1616 taking BSDisms into account.
1617 (ospf_swab_iph_toh) the inverse.
1618 (ospf_write) Add support for IP fragmentation, will only work on
1619 linux though, other kernels make it impossible. get rid of the
1620 magic 4 constant.
1621 (ospf_make_ls_upd) Bound check to end of stream, not to
1622 interface mtu.
1623 (ospf_ls_upd_packet_new) New function, allocate upd packet
1624 taking oversized LSAs into account.
1625 (ospf_ls_upd_queue_send) use ospf_ls_upd_packet_new to allocate,
1626 rather than statically allocating mtu sized packet buffer, which
1627 actually was wrong - it didnt take ip header into account, which
1628 should not be included in packet buffer.
1629 (ospf_ls_upd_send_queue_event) minor tweaks and remove
1630 TODO comment.
1631
gdt630e4802004-08-31 17:28:41 +000016322004-08-31 David Wiggins <dwiggins@bbn.com>
1633
1634 * ospf_spf.c (ospf_spf_calculate): Many more comments and debug
1635 print statements. New function ospf_vertex_dump used in debugging.
1636
16372004-08-31 David Wiggins <dwiggins@bbn.com>
1638
1639 * ospf_spf.h (struct vertex): Comments for flags and structure members.
1640
16412004-08-31 David Wiggins <dwiggins@bbn.com>
1642
1643 * ospf_route.c: When finding an alternate route, log cost as well.
1644
16452004-08-31 David Wiggins <dwiggins@bbn.com>
1646
1647 * ospf_interface.c (ospf_lookup_if_params): Initialize af in
1648 struct prefix allocated on stack.
1649
16502004-08-31 David Wiggins <dwiggins@bbn.com>
1651
1652 * ospf_packet.c (ospf_ls_ack_send_delayed): In p2mp mode, send
1653 acks to AllSPFRouters, rather than All-DR.
1654
hasso7b901432004-08-31 13:37:42 +000016552004-08-27 Hasso Tepper <hasso at quagga.net>
1656
1657 * ospf_vty.c: Don't print ospf network type under interface only
1658 if interface is in broadcast mode and interface type really is
1659 broadcast. Fixes Bugzilla #108.
1660
gdtd7d93992004-08-27 12:03:42 +000016612004-08-27 David Wiggins <dwiggins@bbn.com>
1662
1663 * ospf_spf.c (ospf_nexthop_calculation): Initialize address family
1664 in on-stack struct prefix_ipv4. Fixes point-to-multipoint SPF
1665 calculation.
1666
gdtd0deca62004-08-26 13:14:07 +000016672004-08-26 Greg Troxel <gdt@fnord.ir.bbn.com>
1668
1669 * ospf_packet.c (ospf_recv_packet): adjust size declaration of
gdtd7d93992004-08-27 12:03:42 +00001670 buffer used to get interface index so that it compiles on other
1671 than Linux and includes the required alignment space. Probably
1672 this was only working on sparc/sparc64 because most of
1673 sockaddr_dl was not being written.
gdtd0deca62004-08-26 13:14:07 +00001674
paul863082d2004-08-19 04:43:43 +000016752004-08-19 Paul Jakma <paul@dishone.st>
1676
1677 * ospf_packet.c: update to match sockopt renames.
1678
paul75ee0b82004-08-05 09:10:31 +000016792004-08-04 Paul Jakma <paul@dishone.st>
1680
1681 * ospf_spf.c: (ospf_spf_consider_nexthop) Add comment about issue.
1682 Compare only against list head - all nexthops must be same cost
1683 anyway, fixes a reference-listnode-after-delete bug noted by
1684 Kir Kostuchenko.
1685 (ospf_nexthop_calculation) Use ospf_spf_consider_nexthop for all
1686 candidates attached to root.
1687
paul36c64ef2004-07-27 11:19:11 +000016882004-07-27 Paul Jakma <paul@dishone.st>
1689
paul48fe13b2004-07-27 17:40:44 +00001690 * ospf_packet.c: (ospf_ls_upd_send_queue_event) fix thinko from
1691 last fix for ospfd wedging due to oversize LSAs: dont list loop on
1692 ospf_ls_upd_queue_send() - guaranteed segfault.
1693
16942004-07-27 Paul Jakma <paul@dishone.st>
1695
paul36c64ef2004-07-27 11:19:11 +00001696 * ospf_opaque.c: (ospf_opaque_lsa_flush_schedule) do not NULL out
1697 the LSA as then free_opaque_info_per_id() can never unlock (and
1698 free) the LSA. Reported by Gunnar Stigen.
1699
paul2dd8bb42004-07-23 15:13:48 +000017002004-07-23 Paul Jakma <paul@dishone.st>
1701
1702 * ospf_network.c: Replace PKTINFO/RECVIF with call to
1703 setsockopt_pktinfo
1704 * ospf_packet.c: Use getsockopt_pktinfo_ifindex and
1705 SOPT_SIZE_CMSG_PKTINFO_IPV4.
1706
paul59ea14c2004-07-14 20:50:36 +000017072004-07-14 Paul Jakma <paul@dishone.st>
1708
1709 * ospf_packet.c: (ospf_ls_upd_send_queue_event) Partial fix for
1710 problem reported by Peter Frost amongst others, where function
1711 will spin indefinitely if update list contains LSAs greater than
1712 MTU-headers or other condition leading to update list never being
1713 cleared. Problem of what to do with these LSAs remains.
1714 (ospf_make_ls_upd) add comment about large LSA problem,
1715 indentation cleanup.
1716
gdtb2c1b282004-07-01 12:35:36 +000017172004-07-01 Greg Troxel <gdt@fnord.ir.bbn.com>
1718
1719 * Makefile.am (lib_LTLIBRARIES): make libospf shared
1720
gdt87efd642004-06-30 17:36:11 +000017212004-06-30 Greg Troxel <gdt@poblano.ir.bbn.com>
1722
1723 * Makefile.am: Add shlib support.
1724
hassobeebba72004-06-20 21:00:27 +000017252004-06-10 Hasso Tepper <hasso@estpak.ee>
1726
1727 * *: Removed ifdefs HAVE_NSSA.
1728
paul553ff112004-06-06 09:41:00 +000017292004-06-06 Paul Jakma <paul@dishone.st>
1730
1731 * ospf_dump.c,ospf_lsa.c: Fix typos of merge of previous.
1732 ospf_flood.c: (ospf_process_self_originated_lsa) fix zlog format
1733
paul0c2be262004-05-31 14:16:54 +000017342004-05-31 Sagun Shakya <sagun.shakya@sun.com>
1735
1736 * ospf_dump.c: (ospf_lsa_header_dump) LOOKUP can return null if
1737 index is out of range.
1738 ospf_flood.c: endianness fix
1739 ospf_lsa.c: Missing ntohl's on (struct lsa *)->data->ls_seqnum
1740 in various places.
1741
hassodd669bb2004-05-10 07:43:59 +000017422004-05-10 Hasso Tepper <hasso@estpak.ee>
1743
1744 * ospf_zebra.c, ospfd.c: Move ospf_prefix_list_update() function
1745 to ospf_zebra.c from ospfd.c and add redistribution updates if
1746 route-map is used in redistribution.
1747 * ospf_main.c: Remove now useless call to ospf_init().
1748
paul0a589352004-05-08 11:48:26 +000017492004-05-08 Paul Jakma <paul@dishone.st>
1750
1751 * ospf_zebra.c: Sync with lib/zclient changes
1752
pauld3f0d622004-05-05 15:27:15 +000017532004-05-05 Paul Jakma <paul@dishone.st>
1754
paul5bd41892004-05-05 17:29:24 +00001755 * ospf_network.c: (ospf_sock_init) Check whether IP_HDRINCL is
1756 defined. Warn at compile and runtime. Use
1757 IPTOS_PREC_INTERNETCONTROL otherwise.
pauld3f0d622004-05-05 15:27:15 +00001758 * ospf_packet.c: (ospf_associate_packet_vl) cleanup, move
1759 some of the checks up to ospf_read, return either a
1760 virtual link oi, or NULL.
1761 (ospf_read) Cleanup, make it responsible for checks. Remove
1762 the nbr lookup - moved to ospf_neighbor. Adjust all nbr
1763 lookups to use new wrappers exported by ospf_neighbor.
1764 * ospf_neighbor.h: Add ospf_neigbour_get and ospf_nbr_lookup.
1765 * ospf_neighbor.c: (ospf_neigbour_get) Index ospf_interface
1766 neighbour table by router-id for virtual-link ospf_interfaces,
1767 not by peer_addr (which breaks for asymmetric vlinks)
1768 (ospf_nbr_lookup) add a wrapper for nbr lookups to deal with
1769 above.
paulcd59da62004-05-05 17:26:55 +00001770 * ospf_interface.c: (ospf_vl_set_params) Catch changes of interface
1771 address for either end of a virtual-link, and hence potential cost
1772 changes.
1773
hassoa0a39762004-04-23 08:51:10 +000017742004-04-22 Hasso Tepper <hasso@estpak.ee>
1775
1776 * ospf_zebra.c: Don't ignore reject/bh routes, it's the only way
1777 to "summarize" routes in ASBR at the moment.
1778
hasso8585d4e2004-04-20 17:25:12 +000017792004-04-20 Hasso Tepper <hasso@estpak.ee>
1780
1781 * ospfd.c: Unset NP flag if area is going to be normal or stub.
1782 Fixes UNH OSPF_NSSA.1.2a comment.
1783 * ospf_abr.c: Originate default into stub/nssa area even if
1784 summaries are disabled.
1785 * ospf_zebra.c: Don't attempt to redistribute 127.0.0.0/8.
1786
hassoc266ac72004-04-19 17:31:00 +000017872004-04-19 Hasso Tepper <hasso@estpak.ee>
1788
1789 * ospf_vty.c: Don't warn that export- and import-list can't be
1790 configured to backbone area if they are applied and are working
1791 fine.
1792
hasso128d31d2004-04-04 12:52:33 +000017932004-02-19 Sowmini Varadhan <sowmini.varadhan@sun.com>
1794
1795 * ospf_packet.c: Don't drop packets in Solaris x86.
1796 [quagga-dev 1005].
1797
hasso0d85b992004-03-18 19:18:33 +000017982004-03-18 Amir Guindehi <amir@datacore.ch>
1799
1800 * ospf_opaque.c: Attempt to correct the incorrect behavior of
1801 Quagga's ospfd in the special situation that a node's opaque
1802 capability has changed as "ON -> OFF -> ON". [quagga-dev 843].
1803
paul7f352b82004-02-19 19:37:47 +000018042004-02-19 Sowmini Varadhan <sowmini.varadhan@sun.com>
1805
1806 * ospf_abr.c: (ospf_abr_update_aggregate) UNH 3.12b,c, address range
1807 should be configured with the highest cost path within the range,
1808 not lowest.
1809
paul940b01a2004-02-17 20:07:30 +000018102004-02-17 Paul Jakma <paul@dishone.st>
1811
1812 * ospf_zebra.c: (ospf_interface_delete) Do not delete the interface
1813 params, nor the interface structure, if an interface delete
1814 message is received from zebra.
1815 * ospf_interface.c: (ospf_if_delete_hook) Delete the interface
1816 params and interface, ie that which was previously removed in
1817 (ospf_interface_delete) above.
1818
hasso2db3d052004-02-11 21:52:13 +000018192004-02-11 Hasso Tepper <hasso@estpak.ee>
1820 * ospf_interface.c, ospf_zebra.c: Don't attempt to read path->oi->ifp
1821 if oi doesn't exist any more.
1822
hassocb05eb22004-02-11 21:10:19 +000018232004-02-11 Vadim Suraev <vadim.suraev@terayon.com>
1824 * ospf_packet.c (ospf_ls_upd): Router should flush received network
1825 LSA if it was originated with older router-id ([zebra 14710] #6).
1826
18272003-12-08 Mattias Amnefelt <mattiasa@kth.se>
paul239aecc2003-12-08 10:34:54 +00001828
1829 * ospf_packet.c: (ospf_recv_packet) OpenBSD now leaves iph.ip_len
1830 network byte order.
1831
gdt8f40e892003-12-05 14:01:43 +000018322003-12-05 Greg Troxel <gdt@poblano.ir.bbn.com>
1833
1834 * ospfd.c (ospf_network_match_iface): Rewrite code for clarity
1835 while trying not to change semantics. Add ifdefed-out code to
1836 avoid matching ppp interfaces whose destination address does not
1837 also match the prefix under consideration, to help out people with
1838 problems due to as-yet-unfixed bugs with p2p interfaces coming and
1839 going.
1840
paul736d3442003-07-24 23:22:57 +000018412003-07-25 kamatchi soundaram <kamatchi@tdd.sj.nec.com>
1842
1843 * ospf_packet.c (ospf_ls_upd_send_queue_event): get next route
1844 node in body of the loop to avoid chance that route node
1845 is unlocked and deleted before the next iteration tries to
1846 get next route node.
1847
paul0a825c72003-05-24 13:48:16 +000018482003-05-24 Kenji Yabuuchi
1849
1850 * ospf_interface.c(ospf_if_lookup_recv_if): Use the most specific
1851 match for interface lookup.
1852
paul551a8972003-05-18 15:22:55 +000018532003-05-18 Hasso Tepper <hasso@estpak.ee>
paul445f1432003-05-16 19:00:31 +00001854
paul551a8972003-05-18 15:22:55 +00001855 * ospf_vty.c: Show NSSA LSA route info in "show ip ospf database"
1856 output
paul445f1432003-05-16 19:00:31 +00001857
pauld7480322003-05-16 17:31:51 +000018582003-05-16 Hasso Tepper <hasso@estpak.ee>
1859
1860 * ospf_lsa.c: Fix handling of NSSA
1861
paul551a8972003-05-18 15:22:55 +000018622003-04-23 Hasso Tepper <hasso@estpak.ee>
1863
1864 * ospf_vty.c: fix "router xxx" node commands in vtysh
1865
paul445f1432003-05-16 19:00:31 +000018662003-04-19 Hasso Tepper <hasso@estpak.ee>
1867
1868 * {ospf_abr,ospfd}.c: area id's DECIMAL -> ADDRESS
1869 * ospf_routemap.c: sync daemon's route-map commands to have same
1870 syntax.
1871
18722003-04-19 Sergey Vyshnevetskiy <serg@vostok.net>
1873
1874 * ospf_packet.c: Add missing param to zlog
1875 * ospf_flood.c: remove unused vars
1876
18772003-04-17 Denis Ovsienko <zebra@pilot.org.ua>
1878
1879 * ospf_interface.c: fix incorrect memset
1880
paul28a13842003-05-16 20:30:37 +000018812003-04-10 Amir Guindehi <amir@datacore.ch>
paul445f1432003-05-16 19:00:31 +00001882
1883 * ospf_lsa.[ch]: opaque LSA fix, use ospf_lookup.
1884
18852003-04-03 David Watson <dwatson@eecs.umich.edu>
1886
1887 * ospf_lsa.c: byte order fix
1888
paul07661cb2003-03-18 00:03:05 +000018892002-03-17 Amir Guindehi <amir@datacore.ch>
1890
1891 * ospf_apiserver.[ch]: Merge Ralph Keller's OSPFAPI support.
1892 * ospf_api.[ch]: Merge Ralph Keller's OSPFAPI support.
1893 * ospfclient: OSPFAPI demonstration client.
1894
18952003-01-23 Masahiko Endo <endo@suri.co.jp>
1896
1897 * ospf_ism.c: NSM event schedule bug fix.
1898
18992002-10-30 Greg Troxel <gdt@ir.bbn.com>
1900
1901 * ospf_packet.c (ospf_make_md5_digest): MD5 length fix.
1902
paul718e3742002-12-13 20:15:29 +000019032002-10-23 endo@suri.co.jp (Masahiko Endo)
1904
1905 * ospf_opaque.c: Update Opaque LSA patch.
1906
19072002-10-23 Ralph Keller <keller@tik.ee.ethz.ch>
1908
1909 * ospf_vty.c (show_ip_ospf_database): Fix CLI parse.
1910
19112002-10-23 Juris Kalnins <juris@mt.lv>
1912
1913 * ospf_interface.c (ospf_if_stream_unset): When write queue
1914 becomes empty stop write timer.
1915
19162002-10-10 Greg Troxel <gdt@ir.bbn.com>
1917
1918 * ospf_packet.c (ospf_check_md5_digest): Change >= to > to make it
1919 conform to RFC.
1920
19212002-07-07 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1922
1923 * zebra-0.93 released.
1924
19252002-06-19 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1926
1927 * ospf_spf.c (ospf_nexthop_calculation): Add NULL set to oi and
1928 check of l2. Reported by: Daniel Drown <dan-zebra@drown.org>
1929 (ospf_lsa_has_link): LSA Length calculation fix. Reported by:
1930 Paul Jakma <paulj@alphyra.ie>.
1931
1932 * ospfd.c (ospf_if_update): Fix nextnode reference bug. Reported
1933 by: juris@mt.lv.
1934
19352002-01-21 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1936
1937 * ospfd.c: Merge [zebra 11445] Masahiko ENDO's Opaque-LSA support.
1938
19392001-08-27 Kunihiro Ishiguro <kunihiro@zebra.org>
1940
1941 * ospf_interface.c (ospf_add_to_if): Use /32 address to register
1942 OSPF interface information.
1943 (ospf_delete_from_if): Likewise.
1944
1945 * ospf_zebra.c (ospf_interface_address_delete): Likewise.
1946
19472001-08-23 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1948
1949 * ospf_zebra.c (ospf_redistribute_unset): When redistribute type
1950 is OSPF, do not unset redistribute flag.
1951
19522001-08-19 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1953
1954 * zebra-0.92a released.
1955
19562001-08-15 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1957
1958 * zebra-0.92 released.
1959
19602001-08-12 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1961
1962 * ospfd.c (ospf_config_write): auto-cost reference-bandwidth
1963 configuration display.
1964
19652001-07-24 David Watson <dwatson@eecs.umich.edu>
1966
1967 * ospf_spf.c (ospf_spf_next): Modify ospf_vertex_add_parent to
1968 check for an existing link before connecting the parent and child.
1969 ospf_nexthop_calculation is also modified to check for duplicate
1970 entries when copying from the parent. Finally, ospf_spf_next
1971 removes duplicates when it merges two equal cost candidates.
1972
19732001-07-23 itojun@iijlab.net
1974
1975 * ospfd.c (show_ip_ospf_neighbor): Check ospf_top before use it
1976 [zebra 8549].
1977
19782001-07-23 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1979
1980 * ospf_packet.c (ospf_write): Remove defined(__OpenBSD__) to make
1981 it work on OpenBSD.
1982
19832001-06-26 Kunihiro Ishiguro <kunihiro@zebra.org>
1984
1985 * ospf_zebra.c (config_write_ospf_default_metric): Display
1986 default-metric configuration.
1987
19882001-06-18 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1989
1990 * ospf_ia.h (OSPF_EXAMINE_SUMMARIES_ALL): Remove old macros.
1991
19922001-05-28 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1993
1994 * ospf_snmp.c (ospfIfEntry): Fix interface lookup bug to avoid
1995 crush.
1996 (ospfIfMetricEntry): Likewise.
1997
19982001-03-18 Kunihiro Ishiguro <kunihiro@zebra.org>
1999
2000 * ospf_packet.c (ospf_read): Fix typo. Reported by: "Jen B
2001 Lin'Kova" <jen@stack.net>.
2002
20032001-03-15 Gleb Natapov <gleb@nbase.co.il>
2004
2005 * ospf_interface.c (ip_ospf_network): Set interface parameter.
2006 (interface_config_write): Add check for OSPF_IFTYPE_LOOPBACK.
2007
2008 * ospf_zebra.c (ospf_interface_add): Set interface parameter.
2009
20102001-02-21 Kunihiro Ishiguro <kunihiro@zebra.org>
2011
2012 * ospf_packet.c (ospf_recv_packet): Solaris also need to add
2013 (iph.ip_hl << 2) to iph.ip_len.
2014
20152001-02-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2016
2017 * ospfd.h (OSPF_LS_REFRESH_TIME): Fix OSPF_LS_REFRESH_TIME value.
2018 Suggested by: David Watson <dwatson@eecs.umich.edu>.
2019
2020 * ospf_zebra.c (zebra_init): Remove zebra node.
2021
2022 * ospfd.c (ospf_area_range_set): Function name is changed from
2023 ospf_ara_range_cmd.
2024 (ospf_area_range_unset): New function which separated from DEFUN.
2025 New commands are added:
2026 "no area A.B.C.D range A.B.C.D/M advertise"
2027 "no area <0-4294967295> range A.B.C.D/M advertise"
2028 "no area A.B.C.D range A.B.C.D/M not-advertise"
2029 "no area <0-4294967295> range A.B.C.D/M not-advertise"
2030
2031 * ospf_lsa.c (ospf_lsa_more_recent): Fix previous change.
2032
20332001-02-08 Matthew Grant <grantma@anathoth.gen.nz>
2034
2035 * ospf_network.c (ospf_if_add_allspfrouters): Use
2036 setsockopt_multicast_ipv4.
2037 (ospf_if_drop_allspfrouters): Likewise.
2038
2039 * ospf_lsa.c (ospf_router_lsa_install): Add rt_recalc flag.
2040 (ospf_network_lsa_install): Likewise.
2041 (ospf_summary_lsa_install): Likewise.
2042 (ospf_summary_asbr_lsa_install): Likewise.
2043 (ospf_external_lsa_install): Likewise.
2044 (ospf_lsa_install): Call ospf_lsa_different to check this LSA is
2045 new one or not.
2046
20472001-02-08 Kunihiro Ishiguro <kunihiro@zebra.org>
2048
2049 * ospf_zebra.c (ospf_interface_delete): Do not free interface
2050 structure when ospfd receive interface delete message to support
2051 pseudo interface.
2052
20532001-02-01 Dick Glasspool <dick@ipinfusion.com>
2054
2055 * ospfd.c (area_range_notadvertise): Change area range "suppress"
2056 command to "not-advertise".
2057
2058 * ospfd.h (OSPF_LS_REFRESH_TIME): Change OSPF_LS_REFRESH_TIME from
2059 1800 to 60.
2060
2061 * ospf_abr.c (ospf_abr_update_aggregate): When update_aggregate is
2062 updating the area-range, the lowest cost is now saved.
2063
2064 * ospf_lsa.c (ospf_lsa_more_recent): Routing to compare sequence
2065 numbers rather than creating overflow during calculation.
2066
20672001-02-01 Kunihiro Ishiguro <kunihiro@zebra.org>
2068
2069 * zebra-0.91 is released.
2070
20712001-01-31 Kunihiro Ishiguro <kunihiro@zebra.org>
2072
2073 * ospf_packet.c (ospf_db_desc_proc): Do not continue process when
2074 NSM_SeqNumberMismatch is scheduled.
2075 (ospf_ls_req): Free ls_upd when return from this function.
2076 (ospf_ls_upd_timer): When update list is empty do not call
2077 ospf_ls_upd_send(). Suggested by: endo@suri.co.jp (Masahiko
2078 Endo).
2079
20802001-01-26 Kunihiro Ishiguro <kunihiro@zebra.org>
2081
2082 * ospf_lsa.c (ospf_maxage_flood): Flood LSA when it reaches
2083 MaxAge. RFC2328 Section 14.
2084 (ospf_maxage_lsa_remover): Call above function during removing
2085 MaxAge LSA.
2086
20872001-01-26 Dick Glasspool <dick@ipinfusion.com>
2088
2089 * ospf_flood.c (ospf_flood_through_as): Function is updated for
2090 NSSA Translations now done at ospf_abr.c with no change in P-bit.
2091
2092 * ospf_lsa.c (ospf_get_nssa_ip): Get 1st IP connection for Forward
2093 Addr.
2094 (ospf_install_flood_nssa): Leave Type-7 LSA at Lock Count = 2.
2095
2096 * ospf_ase.c (ospf_ase_calculate_route): Add debug codes.
2097
2098 * ospf_abr.c (ospf_abr_translate_nssa): Recalculate LSA checksum.
2099
2100 * ospf_packet.h (OSPF_SEND_PACKET_LOOP): Added for test packet.
2101
2102 * ospf_dump.c (ospf_lsa_type_msg): Add OSPF_GROUP_MEMBER_LSA and
2103 OSPF_AS_NSSA_LSA.
2104
2105 * ospfd.c (data_injection): Function to inject LSA. This is
2106 debugging command.
2107
21082001-01-11 Kunihiro Ishiguro <kunihiro@zebra.org>
2109
2110 * ospf_route.c (ospf_route_match_same): Remove function.
2111 (ospf_route_match_same_new): Renamed to ospf_route_match_same.
2112
2113 * ospf_zebra.c (ospf_interface_address_delete): Add check for
2114 oi->address. Suggested by Matthew Grant
2115 <grantma@anathoth.gen.nz>.
2116 (ospf_zebra_add): Remove function.
2117 (ospf_zebra_add_multipath): Rename to ospf_zebra_add.
2118
2119 * ospf_interface.c: Remove HAVE_IF_PSEUDO part.
2120
2121 * ospf_zebra.c: Likewise.
2122
21232001-01-10 Kunihiro Ishiguro <kunihiro@zebra.org>
2124
2125 * ospf_ase.c: Remove OLD_RIB part.
2126
2127 * ospf_route.c: Likewise.
2128
2129 * zebra-0.90 is released.
2130
2131 * ospf_packet.c (ospf_recv_packet): Use ip_len adjestment code to
2132 NetBSD.
2133
21342001-01-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2135
2136 * ospf_route.c (ospf_route_delete): Use
2137 ospf_zebra_delete_multipath.
2138
21392001-01-09 Matthew Grant <grantma@anathoth.gen.nz>
2140
2141 * ospf_interface.c (ospf_if_cleanup): Function name is renamed
2142 from ospf_if_free(). Rewrite whole procudure to support primary
2143 address deletion.
2144
2145 * ospf_zebra.c (ospf_interface_address_delete): Add primary
2146 address deletion process.
2147
21482001-01-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2149
2150 * ospf_packet.c (ospf_recv_packet): OpenBSD has same ip_len
2151 treatment like FreeBSD.
2152
21532001-01-09 endo@suri.co.jp (Masahiko Endo)
2154
2155 * ospf_packet.c (ospf_recv_packet): FreeBSD kernel network code
2156 strips IP header size from receiving IP Packet. So we adjust
2157 ip_len to whole IP packet size by adding IP header size.
2158
21592001-01-08 endo@suri.co.jp (Masahiko Endo)
2160
2161 * ospf_network.c (ospf_serv_sock): When socket() is failed return
2162 immediately.
2163 (ospf_serv_sock): Close socket when it is not used.
2164
2165 * ospf_packet.c (ospf_write): Set sin_len when HAVE_SIN_LEN is
2166 defined.
2167 (ospf_write): When bind is fined, close sock.
2168
21692001-01-07 Gleb Natapov <gleb@nbase.co.il>
2170
2171 * ospf_zebra.c (ospf_interface_state_up): Fixes coredump that
2172 appears when you try to configure bandwidth on the ppp interface
2173 that is not yet configured in ospfd.
2174
21752001-01-07 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2176
2177 * ospf_route.c (show_ip_ospf_route_external): "show ip ospf route"
2178 will print nexthops for AS-external routes.
2179
2180 * ospf_ase.c (ospf_ase_route_match_same): New function to compare
2181 ASE route under multipath environment.
2182 (ospf_ase_compare_tables): Likewise.
2183
21842001-01-01 Kunihiro Ishiguro <kunihiro@zebra.org>
2185
2186 * ospfd.h (OSPF_VTYSH_PATH): Change "/tmp/ospfd" to "/tmp/.ospfd".
2187
21882000-12-28 Kunihiro Ishiguro <kunihiro@zebra.org>
2189
2190 * ospf_route.c (ospf_route_install): Install multipath information
2191 to zebra daemon.
2192
2193 * ospf_zebra.c (ospf_zebra_add_multipath): Function for passing
2194 multipath information to zebra daemon.
2195
21962000-12-25 Dick Glasspool <dick@ipinfusion.com>
2197
2198 * ospf_packet.c (ospf_write): Call ospf_packet_delete when sendto
2199 fail.
2200 (DISCARD_LSA): Add argument N for logging point of DISCARD_LSA is
2201 called.
2202
2203 * ospf_lsa.c (ospf_external_lsa_refresh): NSSA install_flood will
2204 leave Type-7 LSA at Lock Count = 2.
2205
2206 * ospf_flood.c (ospf_flood_through): Flood_though_as updated for
2207 NSSA no P-bit off during Area flooding, but P-bit is turned off
2208 for mulitple NSSA AS flooding.
2209
2210 * ospf_ase.c (ospf_ase_calculate_timer): Added calculations for
2211 Type-7 LSDB.
2212
2213 * ospf_abr.c (ospf_abr_translate_nssa): Removed one unlock call.
2214 (ospf_abr_announce_nssa_defaults): Corrected Debug from EVENT to
2215 NSSA.
2216
22172000-12-25 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2218
2219 * ospf_zebra.c (ospf_zebra_read_ipv4): Checking the age of the
2220 found LSA and if the LSA is MAXAGE we should call refresh instead
2221 of originate.
2222
22232000-12-18 Dick Glasspool <dick@ipinfusion.com>
2224
2225 * ospf_abr.c: Removed redundant "...flood" in
2226 announce_network_to_area(). Repaired nssa Unlock by using
2227 discard.
2228
2229 * ospf_packet.c: Removed old NSSA translate during mk_ls_update.
2230
2231 * ospfd.c: Free up all data bases including NSSA.
2232
2233 * ospf_lsa.c: Now allow removal of XLATE LSA's Check in
2234 discard_callback. Added routine to get ip addr from within the
2235 ifp.
2236
2237 * ospf_flood.c: Now set Forward Address for outgoing Type-7.
2238
2239 * ospf_lsa.h: Added prototype for the below. struct in_addr
2240 ospf_get_ip_from_ifp (struct interface *ifp).
2241
22422000-12-14 Gleb Natapov <gleb@nbase.co.il>
2243
2244 * ospf_packet.c (ospf_recv_packet): New OSPF pakcet read method.
2245 Now maximum packet length may be 65535 bytes (maximum IP packet
2246 length).
2247
2248 * ospf_interface.c (ospf_if_stream_set): Don't make input buffer.
2249
2250 * ospfd.c (config_write_network_area): Remove unnecessary area
2251 lookup code.
2252
22532000-12-13 Kunihiro Ishiguro <kunihiro@zebra.org>
2254
2255 * ospf_packet.c (ospf_read): Accept packet bigger than MTU value.
2256
22572000-12-13 Gleb Natapov <gleb@nbase.co.il>
2258
2259 * ospfd.c (config_write_network_area): Fix bug in
2260 config_write_network_area function.
2261
22622000-12-12 Gleb Natapov <gleb@nbase.co.il>
2263
2264 * ospf_abr.c (ospf_abr_announce_network_to_area): Make Summary
2265 LSA's origination and refreshment as same as other type of LSA.
2266
2267 * ospf_lsa.c (ospf_summary_lsa_refresh): Return struct ospf_lsa *.
2268
2269 * ospf_lsa.c (ospf_summary_asbr_lsa_refresh): Likewise.
2270
22712000-12-08 Dick Glasspool <dick@ipinfusion.com>
2272
2273 The bulk of NSSA changes are contained herein; This version will
2274 require manual setting of "always" for NSSA Translator, and will
2275 not perform aggregation yet.
2276
2277 * ospf_dump.c: "debug ospf nssa" is added.
2278
2279 * ospf_dump.h: Likewise.
2280
2281 * ospf_packet.c (ospf_hello): Display router ID on Bad NSSA Hello.
2282
2283 * ospfd.c: Discard_LSA to stay away from LOCAL_XLT Process NSSA
2284 'never, candidate, always'. Change "suppress" to "not-advertise".
2285
2286 * ospfd.h: Add TranslatorRole to struct ospf_area. Add anyNSSA to
2287 struct ospf.
2288
2289 * ospf_ase.c (ospf_ase_calculate_route): External to stay away
2290 from LOCAL_XLT
2291
2292 * ospf_nsm.c (ospf_db_summary_add): External to stay away from
2293 LOCAL_XLT
2294
2295 * ospf_abr.c: Major logic added for abr_nssa_task(). If ABR, and
2296 NSSA translator, then do it. Approve the global list, and flush
2297 any unapproved.
2298
2299 * ospf_lsa.h: New LSA flag OSPF_LSA_LOCAL_XLT to indicate that the
2300 Type-5 resulted from a Local Type-7 translation; not used for
2301 flooding, but used for flushing.
2302
2303 * ospf_flood.c: New NSSA flooding.
2304
23052000-12-08 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2306
2307 * ospfd.c (ospf_find_vl_data): New function for looking up virtual
2308 link data.
2309 (ospf_vl_set_security): Virtual link configuration with
2310 authentication.
2311 (ospf_vl_set_timers): Set timers for virtual link.
2312
2313 * New commands are added.
2314 "area A.B.C.D virtual-link A.B.C.D"
2315 "area A.B.C.D virtual-link A.B.C.D hello-interval <1-65535> retransmit-interval <3-65535> transmit-delay <1-65535> dead-interval <1-65535>"
2316 "area A.B.C.D virtual-link A.B.C.D hello-interval <1-65535> retransmit-interval <3-65535> transmit-delay <1-65535> dead-interval <1-65535> authentication-key AUTH_KEY"
2317 "area A.B.C.D virtual-link A.B.C.D authentication-key AUTH_KEY"
2318 "area A.B.C.D virtual-link A.B.C.D hello-interval <1-65535> retransmit-interval <3-65535> transmit-delay <1-65535> dead-interval <1-65535> message-digest-key <1-255> md5 KEY"
2319 "area A.B.C.D virtual-link A.B.C.D message-digest-key <1-255> md5 KEY"
2320
2321 * ospf_packet.c (ospf_check_md5_digest): Add neighbor's
2322 cryptographic sequence number treatment.
2323 (ospf_check_auth): OSPF input buffer is added to argument.
2324 (ospf_read): Save neighbor's cryptographic sequence number.
2325
2326 * ospf_nsm.c (nsm_change_status): Clear cryptographic sequence
2327 number when neighbor status is changed to NSM down.
2328
2329 * ospf_neighbor.c (ospf_nbr_new): Set zero to crypt_seqnum.
2330
2331 * ospf_neighbor.h (struct ospf_neighbor): Add cryptographic
2332 sequence number to neighbor structure.
2333
23342000-11-29 Kunihiro Ishiguro <kunihiro@zebra.org>
2335
2336 * ospf_snmp.c (ospfIfLookup): OSPF MIB updates.
2337 (ospfExtLsdbEntry): Add OspfExtLsdbTable treatment.
2338
23392000-11-28 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2340
2341 * ospfd.c (ospf_interface_down): Clear a ls_upd_queue queue of the
2342 interface.
2343 (ospf_ls_upd_queue_empty): New function to empty ls update queue
2344 of the OSPF interface.
2345 (no_router_ospf): 'no router ospf' unregister redistribution
2346 requests from zebra.
2347
23482000-11-28 Kunihiro Ishiguro <kunihiro@zebra.org>
2349
2350 * ospf_ism.c (ism_change_status): Increment status change number.
2351
2352 * ospf_interface.h (struct ospf_interface): Add new member for
2353 status change statistics.
2354
2355 * Makefile.am: Update dependencies.
2356
2357 * ospf_zebra.c (ospf_interface_add): OSPF SNMP interface update.
2358 (ospf_interface_delete): OSPF SNMP interface delete.
2359
2360 * ospf_snmp.h: New file is added.
2361
23622000-11-23 Dick Glasspool <dick@ipinfusion.com>
2363
2364 * ospfd.h: Add new ospf_area structure member for
2365 NSSATranslatorRole and NSSATranslator state.
2366
2367 * ospfd.c: Provided for eventual commands to specify NSSA
2368 elections for "translator- ALWAYS/NEVER/CANDIDATE". Provided for
2369 decimal integer version of area-suppress.
2370
2371 * ospf_flood.c: Flood Type-7's only into NSSA (not AS).
2372
2373 * ospf_lsa.c: Undo some previous changes for NSSA. If NSSA
2374 translator, advertise Nt bit.
2375
2376 * ospf_route.c: 1st version of "sh ip os border-routers".
2377
23782000-11-23 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2379
2380 * ospfd.c (area_vlink): Virtual link can not configured in stub
2381 area.
2382
23832000-11-23 Gleb Natapov <gleb@nbase.co.il>
2384
2385 * ospf_packet.c (ospf_db_desc): In states Loading and Full the
2386 slave must resend its last Database Description packet in response
2387 to duplicate Database Description packets received from the
2388 master. For this reason the slave must wait RouterDeadInterval
2389 seconds before freeing the last Database Description packet.
2390 Reception of a Database Description packet from the master after
2391 this interval will generate a SeqNumberMismatch neighbor
2392 event. RFC2328 Section 10.8
2393 (ospf_make_db_desc): DD Master flag treatment.
2394
2395 * ospf_nsm.c (nsm_twoway_received): Move DD related procedure to
2396 nsm_change_status().
2397 (nsm_bad_ls_req): Likewise.
2398 (nsm_adj_ok): Likewise.
2399 (nsm_seq_number_mismatch): Likewise.
2400 (nsm_oneway_received): Likewise.
2401
2402 * ospf_neighbor.h (struct ospf_neighbor): New structure member
2403 last_send_ts for timestemp when last Database Description packet
2404 was sent.
2405
2406 * ospf_nsm.c (ospf_db_desc_timer): Make it sure nbr->last_send is
2407 there. Call ospf_db_desc_resend() in any case.
2408
24092000-11-16 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2410
2411 * ospf_lsa.c (lsa_link_broadcast_set): When there is no DR on
2412 network (suppose you have only one router with interface priority
2413 0). It's router LSA does not contain the link information about
2414 this network.
2415
2416 * ospf_nsm.c (nsm_timer_set): When you change a priority of
2417 interface from/to 0 ISM_NeighborChange event should be scheduled
2418 in order to elect new DR/BDR on the network.
2419
2420 * ospf_interface.c (ip_ospf_priority): Likewise.
2421
2422 * ospf_flood.c (ospf_ls_retransmit_add): When we add some LSA into
2423 retransmit list we need to check whether the present old LSA in
2424 retransmit list is not more recent than the new
2425 one.
2426
24272000-11-09 Dick Glasspool <dick@ipinfusion.com>
2428
2429 * ospf_packet.c: Allows for NSSA Type-7 LSA's throughout the NSSA
2430 area. Any that exit the NSSA area are translated to type-5 LSA's.
2431 The instantiated image is restored after translation.
2432 (ospf_ls_upd_send_list): Renamed to ospf_ls_upd_queu_send().
2433 (ospf_ls_upd_send): Old function which enclosed by #ifdef 0 is
2434 removed.
2435 (ospf_ls_ack_send): Likewise.
2436
2437 * ospf_flood.c: NSSA-LSA's without P-bit will be restricted to
2438 local area. Otherwise they are allowed out the area to be
2439 translated by ospf_packet.c.
2440
2441 * ospf_lsa.c: Undo some previous changes for NSSA.
2442
2443 * ospf_lsdb.h: New access for type 7.
2444
24452000-11-07 Kunihiro Ishiguro <kunihiro@zebra.org>
2446
2447 * ospf_route.c (ospf_path_exist): New function to check nexthop
2448 and interface are in current OSPF path or not.
2449 (ospf_route_copy_nexthops_from_vertex): Add nexthop to OSPF path
2450 when it is not there. Reported by Michael Rozhavsky
2451 <mrozhavsky@opticalaccess.com>
2452
24532000-11-06 Kunihiro Ishiguro <kunihiro@zebra.org>
2454
2455 * ospf_dump.c (config_write_debug): Add seventh string "detail" is
2456 added for flag is OSPF_DEBUG_SEND | OSPF_DEBUG_RECV |
2457 OSPF_DEBUG_DETAIL.
2458
24592000-11-06 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2460
2461 * ospf_lsa.c (router_lsa_flags): ASBR can't exit in stub area.
2462
24632000-11-06 Kunihiro Ishiguro <kunihiro@zebra.org>
2464
2465 * ospf_lsa.c (ospf_router_lsa_originate): Reduce unconditional
2466 logging.
2467
24682000-11-06 Dick Glasspool <dick@ipinfusion.com>
2469
2470 * ospfd.h: Add ait_ntoa function prototype.
2471
2472 * ospfd.c (ait_ntoa): New function for displaying area ID and
2473 Stub/NSSA status.
2474 (show_ip_ospf_interface_sub): Use ait_ntoa.
2475 (show_ip_ospf_nbr_static_detail_sub): Likewise.
2476 (show_ip_ospf_neighbor_detail_sub): Likewise.
2477
2478 * ospf_route.c (ospf_intra_route_add): Set external routing type
2479 to ospf route.
2480 (ospf_intra_add_router): Likewise.
2481 (ospf_intra_add_transit): Likewise.
2482 (ospf_intra_add_stub): Likewise.
2483 (ospf_add_discard_route): Likewise.
2484 (show_ip_ospf_route_network): Use ait_ntoa.
2485 (show_ip_ospf_route_network): Likewise.
2486 (show_ip_ospf_route_router): Likewise.
2487
2488 * ospf_lsa.c (show_lsa_detail): Use ait_ntoa.
2489 (show_lsa_detail_adv_router): Likewise.
2490 (show_ip_ospf_database_summary): Likewise.
2491
2492 * ospf_route.h (struct route_standard): Add new member
2493 external_routing.
2494
2495 * ospf_ia.c (process_summary_lsa): Set external routing tyep to ospf
2496 route.
2497 (ospf_update_network_route): Likewise.
2498 (ospf_update_router_route): Likewise.
2499
25002000-11-04 Kunihiro Ishiguro <kunihiro@zebra.org>
2501
2502 * ospf_flood.c (ospf_process_self_originated_lsa): Enclose
2503 OSPF_AS_NSSA_LSA treatment with #ifdef HAVE_NSSA.
2504
25052000-11-03 Kunihiro Ishiguro <kunihiro@zebra.org>
2506
2507 * Unconditional logging is enclosed with if (IS_DEBUG_OSPF_EVENT).
2508 Please specify "debug ospf event" for enable logging.
2509
2510 * ospf_ism.c: Do not extern debug flag varible. It is done by
2511 ospf_debug.h
2512 * ospf_asbr.c: Likewise.
2513 * ospf_lsa.c: Likewise.
2514 * ospf_nsm.c: Likewise.
2515 * ospf_zebra.c: Likewise.
2516
2517 * ospf_dump.c (debug_ospf_event): New command "debug ospf event"
2518 is added.
2519
2520 * ospfd.c (router_ospf): Change logging from vty_out() to
2521 zlog_info().
2522 (ospf_area_stub_cmd): Likewise.
2523
2524 * ospf_dump.h: Extern term_debug flags.
2525 (OSPF_DEBUG_EVENT): Add new flag.
2526 (IS_DEBUG_OSPF_EVENT): Add new macro.
2527
25282000-11-03 Dick Glasspool <dick@ipinfusion.com>
2529
2530 * ospf_flood.c (ospf_process_self_originated_lsa):
2531 OSPF_AS_NSSA_LSA is treated as same as OSPF_AS_EXTERNAL_LSA.
2532 (ospf_flood): Type-5's have no change. Type-7's can be received,
2533 and will Flood the AS as Type-5's They will also flood the local
2534 NSSA Area as Type-7's. The LSDB will be updated as Type-5's, and
2535 during re-fresh will be converted back to Type-7's (if within an
2536 NSSA).
2537 (ospf_flood_through): Incoming Type-7's were allowed here if our
2538 neighbor was an NSSA. So Flood our area with the Type-7 and also
2539 if we are an ABR, flood thru AS as Type-5.
2540
2541 * ospf_lsa.c (ospf_external_lsa_refresh): Flood NSSA both NSSA
2542 area and other area.
2543
2544 * ospf_packet.c (ospf_db_desc_proc): When AS External LSA is
2545 exists in DD packet, make it sure that this area is not stub.
2546 (ospf_ls_upd_list_lsa): When LSA type is NSSA then set lsa's area
2547 to NULL.
2548 (ospf_ls_upd): If the LSA is AS External LSA and the area is stub
2549 then discard the lsa. If the LSA is NSSA LSA and the area is not
2550 NSSA then discard the lsa.
2551
25522000-11-03 Kunihiro Ishiguro <kunihiro@zebra.org>
2553
2554 * ospfd.c (ospf_interface_run): Fix bug of Hello packet's option
2555 is not properly set when interface comes up.
2556
25572000-11-02 Kunihiro Ishiguro <kunihiro@zebra.org>
2558
2559 * ospfd.h (OSPF_OPTION_O): Add new hello header option.
2560
25612000-11-01 Dick Glasspool <dick@ipinfusion.com>
2562
2563 * ospf_lsa.h: Define OSPF_MAX_LSA to 8 when HAVE_NSSA is enabled.
2564 (OSPF_GROUP_MEMBER_LSA): Define OSPF_GROUP_MEMBER_LSA.
2565
2566 * ospf_lsa.c (show_database_desc): Add "Group Membership LSA"
2567 string.
2568
25692000-10-31 Dick Glasspool <dick@ipinfusion.com>
2570
2571 * ospf_lsa.h (OSPF_AS_NSSA_LSA): Define OSPF_AS_NSSA_LSA.
2572
2573 * ospf_lsa.c (show_ip_ospf_database): NSSA database display
2574 function is added. ALIASES which have "show ip ospf database
2575 nssa-external" is added.
2576 (show_ip_ospf_border_routers): New command "show ip ospf
2577 border-routers" is added.
2578
25792000-10-30 Dick Glasspool <dick@ipinfusion.com>
2580
2581 * ospfd.c (router_ospf): NSSA Enabled message is added for
2582 testing.
2583 (ospf_area_type_set): Are type set for NSSA area.
2584 (ospf_area_stub_cmd): Special translation of no_summary into NSSA
2585 and summary information. If NSSA is enabled pass the information
2586 to ospf_area_type_set().
2587 (area_nssa): New commands are added:
2588 "area A.B.C.D nssa"
2589 "area <0-4294967295> nssa"
2590 "area A.B.C.D nssa no-summary"
2591 "area <0-4294967295> nssa no-summary"
2592 (ospf_no_area_stub_cmd): Special translation of no_summary into
2593 NSSA and summary information. If external_routing is
2594 OSPF_AREA_NSSA unset area with ospf_area_type_set (area,
2595 OSPF_AREA_DEFAULT).
2596 (show_ip_ospf_area): Display NSSA status.
2597 (config_write_ospf_area): Show NSSA configuration.
2598
2599 * ospf_packet.c (ospf_hello): For NSSA support, ensure that NP is
2600 on and E is off.
2601
26022000-10-26 Gleb Natapov <gleb@nbase.co.il>
2603
2604 * ospf_lsa.c (ospf_network_lsa_body_set): The network-LSA lists
2605 those routers that are fully adjacent to the Designated Router;
2606 each fully adjacent router is identified by its OSPF Router ID.
2607 The Designated Router includes itself in this list. RFC2328,
2608 Section 12.4.2.
2609
26102000-10-23 Jochen Friedrich <jochen@scram.de>
2611
2612 * ospf_snmp.c: ospf_oid and ospfd_oid are used in smux_open after
2613 it is registered. So those variables must be static.
2614
26152000-10-18 K N Sridhar <sridhar@euler.ece.iisc.ernet.in>
2616
2617 * ospfd.c: Add area_default_cost_decimal_cmd and
2618 no_area_default_cost_decimal_cmd alias.
2619
26202000-10-05 Gleb Natapov <gleb@nbase.co.il>
2621
2622 * ospfd.c (ospf_network_new): Fix setting area format.
2623 (no_router_ospf): Check area existance when calling
2624 ospf_interface_down().
2625
2626 * ospf_flood.c (ospf_external_info_check): Fix bug of refreshing
2627 default route.
2628
26292000-10-02 Kunihiro Ishiguro <kunihiro@zebra.org>
2630
2631 * zebra-0.89 is released.
2632
26332000-09-29 Kunihiro Ishiguro <kunihiro@zebra.org>
2634
2635 * ospf_snmp.c (ospfHostEntry): OSPF Host MIB is implemented.
2636
2637 * ospfd.c (ospf_nbr_static_cmp): OSPF neighbor is sorted by it's
2638 address.
2639
26402000-09-28 Michael Rozhavsky <mike@nbase.co.il>
2641
2642 * ospf_interface.c (ospf_if_free): Fix deleting self neighbor twice.
2643
26442000-09-27 Kunihiro Ishiguro <kunihiro@zebra.org>
2645
2646 * ospf_packet.c (ospf_read): Solaris on x86 has ip_len with host
2647 byte order.
2648
26492000-09-25 Toshiaki Takada <takada@zebra.org>
2650
2651 * ospfd.c (ospf_compatible_rfc1583), (no_ospf_compatible_rfc1583):
2652 Add CISCO compatible command.
2653
26542000-09-25 Kunihiro Ishiguro <kunihiro@zebra.org>
2655
2656 * ospf_abr.c (ospf_area_range_lookup): New function is added for
2657 area range lookup in OSPF-MIB.
2658 (ospf_area_range_lookup_next): Likewise.
2659
26602000-09-22 Kunihiro Ishiguro <kunihiro@zebra.org>
2661
2662 * ospfd.c (no_router_ospf): Delete virtual link before deleting
2663 area structure.
2664
2665 * ospf_lsa.c (ospf_external_lsa_refresh_type): Check
2666 EXTERNAL_INFO(type).
2667
2668 * ospfd.c (no_router_ospf): Call ospf_vl_delete() instead of
2669 ospf_vl_data_free().
2670
2671 * ospf_interface.c (ospf_vl_shutdown): Execute ISM_InterfaceDown
2672 when ospf_vl_shutdown is called.
2673 (ospf_vl_delete): Call ospf_vl_shutdown() to delete virtual link
2674 interface's thread.
2675
26762000-09-21 Gleb Natapov <gleb@nbase.co.il>
2677
2678 * ospf_lsa.c: New implementation of OSPF refresh.
2679
26802000-09-20 Kunihiro Ishiguro <kunihiro@zebra.org>
2681
2682 * ospf_snmp.c (ospfLsdbLookup): Add LSDB MIB implementation.
2683
26842000-09-18 Kunihiro Ishiguro <kunihiro@zebra.org>
2685
2686 * ospf_snmp.c (ospfStubAreaEntry): Add OSPF stub area MIB.
2687
26882000-09-18 Gleb Natapov <gleb@nbase.co.il>
2689
2690 * ospf_route.h (route_standard): Change member from `struct area'
2691 to area_id.
2692
2693 * ospf_abr.c (ospf_abr_announce_network), (ospf_abr_should_announce),
2694 (ospf_abr_process_network_rt), (ospf_abr_announce_rtr),
2695 (ospf_abr_process_router_rt):
2696 * ospf_ase.c (ospf_find_asbr_route),
2697 (ospf_find_asbr_router_through_area),
2698 * ospf_ia.c (ospf_find_abr_route), (ospf_ia_router_route),
2699 (process_summary_lsa), (ospf_update_network_route),
2700 (ospf_update_router_route):
2701 * ospf_route.c (ospf_intra_route_add), (ospf_intra_add_router),
2702 (ospf_intra_add_transit), (ospf_intra_add_stub),
2703 (ospf_route_table_dump), (show_ip_ospf_route_network),
2704 (show_ip_ospf_route_router), (ospf_asbr_route_cmp),
2705 (ospf_prune_unreachable_routers):
2706 * ospf_spf.c (ospf_rtrs_print):
2707 * ospfd.c (ospf_rtrs_free): Fix the struct change above.
2708
27092000-09-14 Kunihiro Ishiguro <kunihiro@zebra.org>
2710
2711 * ospf_network.c (ospf_serv_sock_init): Enclose SO_BINDTODEVICE
2712 with ifdef.
2713
27142000-09-13 Gleb Natapov <gleb@nbase.co.il>
2715
2716 * ospf_ism.c (ospf_elect_dr), (ospf_elect_bdr): Fix DR election.
2717
2718 * ospf_network.c (ospf_serv_sock_init): Add socket option
2719 SO_BINDTODEVICE on read socket.
2720
2721 * ospf_packet.c (ospf_hello): Ignore Hello packet if E-bit does
2722 not match.
2723
2724 * ospfd.c (ospf_area_check_free), (ospf_area_get),
2725 (ospf_area_add_if): New function added.
2726
27272000-09-13 Kunihiro Ishiguro <kunihiro@zebra.org>
2728
2729 * ospf_route.c (ospf_intra_add_router): Update ABR and ASBR router
2730 count.
2731
2732 * ospf_spf.c (ospf_spf_init): Rest ABR and ASBR router count
2733 starting SPF calculation.
2734
2735 * ospfd.h (struct ospf_area): Add ABR and ASBR router count.
2736
27372000-09-12 Kunihiro Ishiguro <kunihiro@zebra.org>
2738
2739 * ospfd.c (ospf_area_id_cmp): New area structure is sorted by area
2740 ID.
2741
2742 * ospf_lsa.c (ospf_router_lsa_originate): For OSPF MIB update
2743 lsa_originate_count.
2744 (ospf_network_lsa_originate): Likewise.
2745 (ospf_summary_lsa_originate): Likewise.
2746 (ospf_summary_asbr_lsa_originate): Likewise.
2747 (ospf_external_lsa_originate): Likewise.
2748
27492000-09-11 Kunihiro Ishiguro <kunihiro@zebra.org>
2750
2751 * ospf_snmp.c (ospf_variables): ospfRouterID's type RouterID
2752 syntax is IpAddress.
2753 (ospf_admin_stat): New function for OSPF administrative status
2754 check.
2755
27562000-09-10 Jochen Friedrich <jochen@scram.de>
2757
2758 * ospf_snmp.c: Implement OSPF MIB skeleton.
2759
27602000-09-08 Kunihiro Ishiguro <kunihiro@zebra.org>
2761
2762 * ospf_snmp.c: New file is added.
2763
27642000-09-07 David Lipovkov <davidl@nbase.co.il>
2765
2766 * ospf_zebra.c (ospf_interface_delete): Add pseudo interface
2767 treatment.
2768
2769 * ospf_interface.c (interface_config_write): Likewise.
2770
27712000-08-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2772
2773 * zebra-0.88 is released.
2774
27752000-08-17 Michael Rozhavsky <mike@nbase.co.il>
2776
2777 * ospfd.c (ospf_area_free): Remove virtual link configuration only
2778 when Area is removed.
2779
27802000-08-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2781
2782 * ospfd.c (network_area): Revert check for EXTERNAL_INFO
2783 (ZEBRA_ROUTE_CONNECT).
2784 (no_network_area): Likewise.
2785
27862000-08-16 Kunihiro Ishiguro <kunihiro@zebra.org>
2787
2788 * ospfd.h (struct ospf): Add distance_table and
2789 distance_{all,intra,inter,external}.
2790
2791 * ospf_zebra.c: Add OSPF distance related functions.
2792
27932000-08-15 Gleb Natapov <gleb@nbase.co.il>
2794
2795 * ospf_asbr.c (ospf_external_info_find_lsa): New function added.
2796
2797 * ospf_lsa.c (ospf_default_external_info),
2798 (ospf_default_originate_timer), (ospf_external_lsa_refresh_default):
2799 New function added.
2800
2801 * ospf_zebra.c
2802 (ospf_default_information_originate_metric_type_routemap),
2803 (ospf_default_information_originate_always_metric_type_routemap):
2804 Change name and add route-map function.
2805 (ospf_default_information_originate_metric_routemap),
2806 (ospf_default_information_originate_routemap),
2807 (ospf_default_information_originate_type_metric_routemap):
2808 New DEFUN added.
2809
28102000-08-14 Kunihiro Ishiguro <kunihiro@zebra.org>
2811
2812 * ospf_zebra.c (zebra_interface_if_set_value): Change ifindex
2813 restore size from two octet to four.
2814
28152000-08-14 Michael Rozhavsky <mike@nbase.co.il>
2816
2817 * ospf_ase.c (ospf_ase_incremental_update): Implement incremental
2818 AS-external-LSA in 16.6 of RFC2328.
2819
28202000-08-14 Matthew Grant <grantma@anathoth.gen.nz>
2821
2822 * ospf_interface.c (ospf_if_get_output_cost): Change cost
2823 calculation algorithm.
2824
2825 * ospf_packet (ospf_ls_upd): Fix problem of LSA retransmitting.
2826
28272000-08-11 Michael Rozhavsky <mike@nbase.co.il>
2828
2829 * ospf_lsa.c (ospf_maxage_lsa_remover): Fix maxage remover for
2830 AS-external-LSAs.
2831
28322000-08-10 Toshiaki Takada <takada@zebra.org>
2833
2834 * ospfd.c (auto_cost_reference_bandwidth): New DEFUN added.
2835 `auto-cost reference-bandwidth' OSPF router command added.
2836
28372000-08-08 Gleb Natapov <gleb@nbase.co.il>
2838
2839 * ospf_routemap.c (ospf_route_map_update): New function added.
2840 Add route-map event hook.
2841
28422000-08-08 Toshiaki Takada <takada@zebra.org>
2843
2844 * ospf_zebra.c (ospf_distribute_check_connected): If redistribute
2845 prefix is connected route on OSPF enabled interface, suppress to
2846 announce it.
2847
28482000-08-08 Matthew Grant <grantma@anathoth.gen.nz>
2849
2850 * ospf_interface.c (ospf_if_get_output_cost):
2851 New function added. Handle bandwidth parameter for cost
2852 calculation.
2853
28542000-08-08 Michael Rozhavsky <mike@nbase.co.il>
2855
2856 * ospf_interface.c (interface_config_write): Show interface
2857 configuration regardless interface is down.
2858
2859 * ospf_ase.c (ospf_ase_caocluate_route): Whole rewritten external
2860 route calculate function.
2861
28622000-08-08 Gleb Natapov <gleb@nbase.co.il>
2863
2864 * ospf_routemap.c: New file added.
2865
2866 * ospf_asbr.c (ospf_reset_route_map_set_values),
2867 (ospf_route_map_set_compare): New function added.
2868
2869 * ospf_lsa.c (ospf_external_lsa_body_set): Set routemap metric
2870 with AS-external-LSA.
2871
28722000-08-05 Kunihiro Ishiguro <kunihiro@zebra.org>
2873
2874 * ospf_ase.c (ospf_ase_calculate_route_add): Pass new->cost to
2875 ospf_zebra_add as metric.
2876 (ospf_ase_calculate_route_add): Likewise.
2877
2878 * ospf_route.c (ospf_route_install): Pass or->cost to
2879 ospf_zebra_add as metric.
2880
2881 * ospf_zebra.c (ospf_zebra_add): Add metric arguemnt.
2882 (ospf_zebra_delete): Likewise.
2883
28842000-08-03 Matthew Grant <grantma@anathoth.gen.nz>
2885
2886 * ospf_flood.c (ospf_flood_delayed_lsa_ack): New function added.
2887 Dispatch delayed-ACK with flooding AS-external-LSA across virtual
2888 link.
2889
28902000-07-31 Matthew Grant <grantma@anathoth.gen.nz>
2891
2892 * ospfd.c (show_ip_ospf_area): Fix lack of VTY_NEWLINE when
2893 `show ip ospf'.
2894
2895 * ospf_interface.c (ospf_if_free): Fix bug of crash with
2896 Point-to-Point interface.
2897
28982000-07-27 Michael Rozhavsky <mike@nbase.co.il>
2899
2900 * ospf_flood.c (ospf_process_self_originated_lsa):
2901 Make sure to clear LSA->param (redistributed external information)
2902 before refreshment.
2903
29042000-07-27 Gleb Natapov <gleb@nbase.co.il>
2905
2906 * ospfd.c (refresh_group_limit), (refresh_per_slice),
2907 (refresh_age_diff): New defun added. Refresher related parameter
2908 can be configurable.
2909
29102000-07-27 Akihiro Mizutani <mizutani@dml.com>
2911
2912 * ospf_interface.c (interface_config_write): Print `description'
2913 config directive to work.
2914
29152000-07-24 Akihiro Mizutani <mizutani@dml.com>
2916
2917 * ospf_interface.c (ospf_if_init): Use install_default for
2918 INTERFACE_NODE.
2919
29202000-07-24 Gleb Natapov <gleb@nbase.co.il>
2921
2922 * ospf_packet.c (ospf_ls_upd_send_list), (ospf_ls_upd_send_event),
2923 (ospf_ls_ack_send_list), (ospf_ls_ack_send_event): New function added.
2924 This make sending always as many LS update/Ack combined in one ospf
2925 packet.
2926
29272000-07-24 Gleb Natapov <gleb@nbase.co.il>
2928
2929 * ospf_packet.c (ospf_ls_upd_list_lsa): Set NULL to lsa->area if
2930 LSA is AS-external-LSA.
2931
2932 * ospf_nsm.c (nsm_reset_nbr): Do not cancel Inactivity timer.
2933
29342000-07-21 Toshiaki Takada <takada@zebra.org>
2935
2936 * ospf_zebra.c (ospf_default_originate_timer): Set timer for
2937 `default-information originate'. Fix some default originate
2938 related functions.
2939
29402000-07-12 Toshiaki Takada <takada@zebra.org>
2941
2942 * ospf_lsa.c (stream_put_ospf_metric): New function added.
2943
29442000-07-12 Toshiaki Takada <takada@zebra.org>
2945
2946 * ospf_lsa.c (show_ip_ospf_database_router),
2947 (show_ip_ospf_database_network), (show_ip_ospf_database_summary),
2948 (show_ip_ospf_database_summary_asbr), (show_ip_ospf_database_externel),
2949 (show_router_lsa), (show_any_lsa), (show_router_lsa_self),
2950 (show_any_lsa_self): Functions removed.
2951
2952 (show_lsa_prefix_set), (show_lsa_detail_proc), (show_lsa_detail),
2953 (show_lsa_detail_adv_router_proc), (show_lsa_detail_adv_router):
2954 New functions added. Replace above functions.
2955
2956 (show_ip_ospf_database_all), (show_ip_ospf_database_self_originated):
2957 Functions removed.
2958 (show_ip_ospf_database_summary): New functions added. Replace
2959 above functions.
2960
2961 (show_ip_ospf_database_cmd): DEFUN rearranged.
2962 (show_ip_ospf_database_type_id_cmd),
2963 (show_ip_ospf_database_type_id_adv_router_cmd),
2964 (show_ip_ospf_database_type_is_self_cmd): New ALIASes added.
2965 (show_ip_ospf_database_type_adv_rotuer_cmd): New DEFUN added.
2966 (show_ip_ospf_database_type_self_cmd): New ALIAS added.
2967
29682000-07-11 Toshiaki Takada <takada@zebra.org>
2969
2970 * ospf_asbr.c (ospf_external_info_new),
2971 (ospf_external_info_free): New functions added.
2972
2973 * ospf_lsa.h (ospf_lsa): Add new member `void *param' to set
2974 origination parameter for external-LSA.
2975 Remove member `redistribute'.
2976
2977 * ospf_zebra.c (ospf_redistirbute_set): When `redistribute'
2978 command executed, metric and metric-type values are overridden.
2979 If one of those is changed refresh AS-external-LSAs for appropriate
2980 type.
2981
29822000-07-11 Michael Rozhavsky <mike@nbase.co.il>
2983
2984 * ospf_lsa.c (ospf_summary_lsa_refresh),
2985 (ospf_summary_asbr_lsa_refresh): Make sure to refresh summary-LSAs.
2986
2987 * ospf_abr.c (set_metric): New function added.
2988
29892000-07-07 Toshiaki Takada <takada@zebra.org>
2990
2991 * ospf_zebra.c (ospf_default_information_originate_metric_type),
2992 (ospf_default_information_originate_type_metric): New defun added.
2993 Metic and Metric type can be set to default route.
2994 (ospf_default_information_originate_always_metric_type):
2995 (ospf_default_information_originate_always_type_metric):
2996 New defun added. Metric and Metric type can be set to default
2997 always route.
2998
2999 * ospf_zebra.c (ospf_default_metric), (no_ospf_default_metric):
3000 New defun added.
3001
30022000-07-06 Gleb Natapov <gleb@nbase.co.il>
3003
3004 * ospf_flood.c (ospf_flood_through_area): Fix bug of considering
3005 on the same interface the LSA was received from.
3006
30072000-07-06 Michael Rozhavsky <mike@nbase.co.il>
3008
3009 * ospfd.c (ospf_config_write): Fix bug of printing `area stub'
3010 command with `write mem'.
3011
3012 * ospfd.c (no_router_ospf): Remove installed routes from zebra.
3013
3014 * ospf_zebra.c (ospf_interface_delete): Fix function to handle
3015 zebra interface delete event.
3016
30172000-07-06 Toshiaki Takada <takada@zebra.org>
3018
3019 * ospf_zebra.c (ospf_default_information_originate),
3020 (ospf_default_information_originate_always): New DEFUN added.
3021
30222000-07-05 Michael Rozhavsky <mike@nbase.co.il>
3023
3024 * ospf_route.c (ospf_terminate): Make sure to remove external route
3025 when SIGINT received.
3026
30272000-07-03 Gleb Natapov <gleb@nbase.co.il>
3028
3029 * ospf_flood.c, ospf_ism.c, ospf_lsa,c, ospfd.c: Make sure to free
3030 many structure with `no router ospf'.
3031
30322000-06-30 Gleb Natapov <gleb@nbase.co.il>
3033
3034 * ospf_neighbor.c (ospf_nbr_new),
3035 ospf_nsm.c (nsm_timer_set): Start LS update timer only
3036 when neighbor enters Exchange state.
3037
30382000-06-29 Gleb Natapov <gleb@nbase.co.il>
3039
3040 * ospf_nsm.c (nsm_timer_set), (nsm_exchange_done),
3041 ospf_packet.c (ospf_db_desc_proc):
3042 Do not cancel DD retransmit timer when Master.
3043
30442000-06-29 Gleb Natapov <gleb@nbase.co.il>
3045
3046 * ospf_abr.c (ospf_abr_announce_network_to_area),
3047 (ospf_abr_announce_rtr_to_area)
3048 ospf_ase.c (ospf_ase_rtrs_register_lsa),
3049 ospf_flood.c (ospf_process_self_originated_lsa),
3050 (ospf_flood_through_area), (ospf_ls_request_delete),
3051 ospf_interface.c (ospf_if_free),
3052 ospf_ism.c (ism_change_status),
3053 ospf_lsa.c (ospf_router_lsa_update_timer),
3054 (ospf_router_lsa_install), (ospf_network_lsa_install),
3055 (ospf_lsa_maxage_delete), (ospf_lsa_action),
3056 (ospf_schedule_lsa_flood_area),
3057 ospf_nsm.c (nsm_change_status),
3058 ospf_packet.c (ospf_make_ls_req_func), (ospf_make_ls_ack):
3059 Use ospf_lsa_{lock,unlock} for all looking-up of LSA.
3060
3061 * ospf_flood.c (ospf_ls_request_free): Function deleted.
3062
3063 * ospf_lsa.c (ospf_discard_from_db): New function added.
3064
30652000-06-26 Toshiaki Takada <takada@zebra.org>
3066
3067 * ospfd.h (ospf): struct member `external_lsa' name changed to
3068 `lsdb'.
3069
30702000-06-26 Toshiaki Takada <takada@zebra.org>
3071
3072 * ospf_lsa.c (ospf_lsa_install), (ospf_router_lsa_install),
3073 (ospf_network_lsa_install), (ospf_summary_lsa_install),
3074 (ospf_summary_asbr_lsa_install), (ospf_external_lsa_install):
3075 Functions re-arranged.
3076
3077 * ospf_lsa.c (IS_LSA_MAXAGE), (IS_LSA_SELF): Macro added.
3078
30792000-06-20 Michael Rozhavsky <mike@nbase.co.il>
3080
3081 * ospf_packet.c (ospf_ls_req), (ospf_ls_upd), (ospf_ls_ack): Add
3082 verification of LS type.
3083
30842000-06-20 Gleb Natapov <gleb@nbase.co.il>
3085
3086 * ospf_ase.c (ospf_ase_calculate_timer): Add more sanity check
3087 whether rn->info is NULL.
3088
30892000-06-20 Toshiaki Takada <takada@zebra.org>
3090
3091 * ospfd.c (show_ip_ospf_interface_sub): Show Router-ID of both
3092 DR and Backup correctly with `show ip ospf interface' command.
3093
30942000-06-20 Toshiaki Takada <takada@zebra.org>
3095
3096 * ospf_lsa.c (ospf_lsa_lock), (ospf_lsa_unlock),
3097 (ospf_lsa_discard): These functions are used for avoiding
3098 unexpected reference to freed LSAs.
3099
31002000-06-13 Kunihiro Ishiguro <kunihiro@zebra.org>
3101
3102 * ospf_packet.c (ospf_ls_upd): Initialize lsa by NULL to avoid
3103 warning.
3104
31052000-06-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3106
3107 * ospf_ase.h (ospf_ase_rtrs_register_lsa): Add prototype.
3108
31092000-06-12 Toshiaki Takada <takada@zebra.org>
3110
3111 * ospf_lsa.c (ospf_external_lsa_install): Make sure to register
3112 LSA to rtrs_external when replacing AS-external-LSAs in LSDB.
3113 Fix core dump.
3114
31152000-06-10 Toshiaki Takada <takada@zebra.org>
3116
3117 * ospf_lsdb.c (id_to_prefix), (ospf_lsdb_hash_key),
3118 (ospf_lsdb_hash_cmp), (ospf_lsdb_new), (ospf_lsdb_iterator),
3119 (lsdb_free), (ospf_lsdb_free), (ospf_lsdb_add), (ospf_lsdb_delete),
3120 (find_lsa), (ospf_lsdb_lookup), (find_by_id),
3121 (ospf_lsdb_lookup_by_id), (ospf_lsdb_lookup_by_header): Functinos
3122 removed for migration to new_lsdb.
3123
3124 * ospf_lsa.c (ospf_summary_lsa_install),
3125 (ospf_summary_asbr_lsa_install), (ospf_maxage_lsa_remover),
3126 (ospf_lsa_maxage_walker), (ospf_lsa_lookup),
3127 (ospf_lsa_lookup_by_id): Use new_lsdb instead of ospf_lsdb.
3128 (count_lsa), (ospf_lsa_count_table), (ospf_lsa_count),
3129 (ospf_get_free_id_for_prefix): Funcitions removed.
3130
31312000-06-09 Gleb Natapov <gleb@nbase.co.il>
3132
3133 * ospf_ism.c (ism_interface_down): Prevent some unneeded DR changes.
3134
3135 * ospf_packet.c (ospf_db_desc_proc): Fix memory leak.
3136 (ospf_hello): Always copy router-ID when hello is received.
3137
31382000-06-08 Gleb Natapov <gleb@nbase.co.il>
3139
3140 * ospf_lsa.h (struct ospf_lsa): Add member of pointer to struct
3141 ospf_area.
3142
31432000-06-08 Michael Rozhavsky <mike@nbase.co.il>
3144
3145 * ospf_ase.c (ospf_asbr_route_same): New function added.
3146 This function makes sure external route calculation more
3147 precisely.
3148
31492000-06-07 Michael Rozhavsky <mike@nbase.co.il>
3150
3151 * ospf_ism.c (ism_change_status): Use ospf_lsa_flush_area for
3152 network-LSA deletion instead of using ospf_lsdb_delete.
3153 Also cancel network-LSA origination timer.
3154
31552000-06-07 Levi Harper <lharper@kennedytech.com>
3156
3157 * ospf_interface.c (ospf_if_down): Close read fd when an interface
3158 goes down.
3159
31602000-06-05 Kunihiro Ishiguro <kunihiro@zebra.org>
3161
3162 * ospf_asbr.c (ospf_external_info_lookup): Add explicit brace for
3163 avoid ambiguous else.
3164
3165 * ospf_flood.c (ospf_external_info_check): Likewise.
3166
31672000-06-05 Toshiaki Takada <takada@zebra.org>
3168
3169 * ospf_nsm.c (nsm_adj_ok): Fix bug of DR election.
3170
31712000-06-04 Toshiaki Takada <takada@zebra.org>
3172
3173 * ospf_zebra.c (ospf_default_information_originate),
3174 (no_ospf_default_information_originate): New DEFUN added.
3175
31762000-06-03 Toshiaki Takada <takada@zebra.org>
3177
3178 * ospf_lsa.h, ospf_asbr.h (external_info): Struct moved from
3179 ospf_lsa.h to ospf_asbr.h.
3180
3181 * ospf_lsa.c, ospf_asbr.c (ospf_external_info_add),
3182 (ospf_external_info_delete): Function moved from ospf_lsa.c
3183 to ospf_asbr.c.
3184
31852000-06-03 Toshiaki Takada <takada@zebra.org>
3186
3187 * ospf_flood.c (ospf_external_info_check): New function added.
3188 (ospf_process_self_orignated_lsa): Make sure to flush
3189 self-originated AS-external-LSA, when router reboot and no longer
3190 originate those AS-external-LSA.
3191
31922000-06-02 Toshiaki Takada <takada@zebra.org>
3193
3194 * ospf_network.c (ospf_serv_sock): Remove SO_DONTROUTE
3195 socket option.
3196
3197 * ospf_packet.c (ospf_write): Set MSG_DONTROUTE flag for
3198 unicast destination packets.
3199
32002000-06-02 Toshiaki Takada <takada@zebra.org>
3201
3202 * ospf_lsdb.c (new_lsdb_delete): Delete entry from LSDB only when
3203 specified LSA matches.
3204
32052000-06-02 Gleb Natapov <gleb@nbase.co.il>
3206
3207 * ospf_network.c (ospf_serv_sock): Set SO_DONTROUTE
3208 socket option.
3209
32102000-06-01 Akihiro Mizutani <mizutani@dml.com>
3211
3212 * ospf_dump.c: Replace string `Debugging functions\n' with DEBUG_STR.
3213 Replace string `OSPF information\n' with OSPF_STR.
3214
32152000-06-01 Toshiaki Takada <takada@zebra.org>
3216
3217 * ospf_lsdb.[ch]: Use new_lsdb struct for network-LSA instead of
3218 ospf_lsdb.
3219
32202000-06-01 Toshiaki Takada <takada@zebra.org>
3221
3222 * ospf_dump.c (config_debug_ospf_packet), (config_debug_ospf_event),
3223 (config_debug_ospf_ism), (config_debug_ospf_nsm),
3224 (config_debug_ospf_lsa), (config_debug_ospf_zebra),
3225 (term_debug_ospf_packet), (term_debug_ospf_event),
3226 (term_debug_ospf_ism), (term_debug_ospf_nsm),
3227 (term_debug_ospf_lsa), (term_debug_ospf_zebra): Repalce debug_ospf_*
3228 variable to use for debug option flags.
3229
3230 (debug_ospf_packet), (debug_ospf_ism), (debug_ospf_nsm),
3231 (debug_ospf_lsa), (debug_ospf_zebra): Set {config,term}_debug_*
3232 flags when vty->node is CONFIG_NODE, otherwise set only term_debug_*
3233 flags.
3234
3235 * ospf_dump.h (CONF_DEBUG_PACKET_ON), (CONF_DEBUG_PACKET_OFF),
3236 (TERM_DEBUG_PACKET_ON), (TERM_DEBUG_PACKET_OFF),
3237 (CONF_DEBUG_ON), (CONF_DEBUG_OFF), (IS_CONF_DEBUG_OSPF_PACKET),
3238 (IS_CONF_DEBUG_OSPF): New Macro added.
3239
32402000-05-31 Toshiaki Takada <takada@zebra.org>
3241
3242 * ospfd.c (clear_ip_ospf_neighbor): New DEFUN added.
3243 Currently this command is used for only debugging.
3244
3245 * ospf_nsm.c (nsm_change_status): Make sure thread cancellation
3246 for network-LSA when DR has no full neighbors.
3247
3248 * ospf_nsm.c (ospf_db_summary_clear): New function added.
3249
32502000-05-30 Toshiaki Takada <takada@zebra.org>
3251
3252 * ospf_lsdb.c (new_lsdb_insert): LSAs are always freed by
3253 maxage_lsa_remover when LSA is replaced.
3254
32552000-05-25 Gleb Natapov <gleb@nbase.co.il>
3256
3257 * ospf_flood.c (ospf_ls_retransmit_delete_nbr_all): Add argument
3258 `struct ospf_area' to remove LSA from Link State retransmission list
3259 of neighbor from only one Area.
3260
32612000-05-24 Michael Rozhavsky <mike@nbase.co.il>
3262
3263 * ospf_lsdb.c (ospf_lsdb_add): Preserve flags field when
3264 overriting old LSA with new LSA.
3265
32662000-05-24 Gleb Natapov <gleb@nbase.co.il>
3267
3268 * ospf_lsa.c (ospf_router_lsa_body_set): Fix bug of router-LSA
3269 size calculation.
3270
32712000-05-22 Michael Rozhavsky <mike@nbase.co.il>
3272
3273 * ospf_route.c (ospf_intra_add_stub):
3274 * ospf_spf.h (struct vertex): Use u_int32_t for distance (cost)
3275 value instead of u_int16_t.
3276
32772000-05-22 Axel Gerlach <agerlach@datus.datus.com>
3278
3279 * ospf_ia.c (ospf_ia_network_route): Fix bug of Inter-area route
3280 equal cost path calculation.
3281
32822000-05-21 Toshiaki Takada <takada@zebra.org>
3283
3284 * ospf_ase.c (ospf_ase_calculate_route_delete): New function added.
3285 Make sure, when rotuer route is deleted, related external routes
3286 are also deleted.
3287
32882000-05-20 Toshiaki Takada <takada@zebra.org>
3289
3290 * ospfd.c (ospf_interface_down): Make sure interface flag is disable
3291 and set fd to -1.
3292
32932000-05-16 Toshiaki Takada <takada@zebra.org>
3294
3295 * ospf_asbr.c (ospf_asbr_should_announce), (ospf_asbr_route_remove):
3296 Functions removed.
3297
3298 * ospfd.h (EXTERNAL_INFO): Macro added.
3299 Substitute `ospf_top->external_info[type]' with it.
3300
33012000-05-16 Toshiaki Takada <takada@zebra.org>
3302
3303 * ospf_lsa.c (ospf_rtrs_external_remove): New function added.
3304
33052000-05-14 Gleb Natapov <gleb@nbase.co.il>
3306
3307 * ospf_flood.c (ospf_ls_retransmit_delete_nbr_all)
3308 * ospf_lsdb.c (new_lsdb_insert)
3309 * ospf_packet.c (ospf_ls_ack): Fix database synchonization problem.
3310
33112000-05-14 Gleb Natapov <gleb@nbase.co.il>
3312
3313 * ospf_lsa.h (tv_adjust), (tv_ceil), (tv_floor), (int2tv),
3314 (tv_add), (tv_sub), (tv_cmp): Prototype definition added.
3315
3316 * ospf_nsm.h (ospf_db_summary_delete_all): Prototype definition added.
3317
33182000-05-13 Toshiaki Takada <takada@zebra.org>
3319
3320 * ospf_lsa.[ch] (ospf_lsa): struct timestamp type is changed from
3321 time_t to struct timeval.
3322 (tv_adjust), (tv_ceil), (tv_floor), (int2tv), (tv_add),
3323 (tv_sub), (tv_cmp): timeval utillity functions added.
3324
33252000-05-12 Toshiaki Takada <takada@zebra.org>
3326
3327 * ospf_lsa.[ch] (ospf_schedule_update_router_lsas): Delete function.
3328 Change to use macro OSPF_LSA_UPDATE_TIMER instead of using
3329 this function.
3330 router-LSA refresh timer related stuff is re-organized.
3331
33322000-05-10 Gleb Natapov <gleb@nbase.co.il>
3333
3334 * ospf_interface.c (ospf_vl_set_params):
3335 * ospf_packet.c (ospf_check_network_mask):
3336 * ospf_spf.[ch] (ospf_spf_next):
3337 Remove field address from `struct vertex', and search for peer
3338 address of virtual link in function `ospf_vl_set_params' instead.
3339
33402000-05-10 Gleb Natapov <gleb@nbase.co.il>
3341
3342 * ospf_packet.c (ospf_ls_upd): Fix some memory leak related LSA.
3343
33442000-05-08 Thomas Molkenbur <tmo@datus.com>
3345
3346 * ospf_packet.c (ospf_packet_dup): Replace ospf_steram_copy()
3347 with ospf_stream_dup() to fix memory leak.
3348
33492000-05-08 Michael Rozhavsky <mike@nbase.co.il>
3350
3351 * ospf_flood.c (ospf_flood_through_area): Fix the problem of
3352 LSA update without DROther.
3353
33542000-05-04 Gleb Natapov <gleb@nbase.co.il>
3355
3356 * ospf_spf.c (ospf_vertex_free): Fix memory leak of SPF calculation.
3357
33582000-05-03 Toshiaki Takada <takada@zebra.org>
3359
3360 * ospf_neighbor.c (ospf_db_summary_add): Use new_lsdb struct
3361 instead linked-list.
3362 (ospf_db_summary_count), (ospf_db_summary_isempty):
3363 New function added.
3364
3365 * ospf_lsa.c (ospf_rotuer_lsa): Re-arrange and divide functions.
3366
33672000-05-02 Gleb Natapov <gleb@nbase.co.il>
3368
3369 * ospf_lsdb.c (new_lsdb_cleanup): Fix memory leak. When LSDB are
3370 not needed any more, then free them.
3371
33722000-05-02 Toshiaki Takada <takada@zebra.org>
3373
3374 * ospfd.c (timers_spf), (no_timers_spf): New defun added.
3375 SPF calculation timers related stuff is rearranged.
3376
3377 * ospf_spf.c (ospf_spf_calculate_timer_add): Function removed.
3378 SPF timer is scheduled by SPF calculation delay and holdtime
3379 configuration variable.
3380
3381 * ospf_lsa.c (ospf_external_lsa_nexthop_get): Set AS-external-LSA's
3382 forwarding address when nexthop learned by other protocols is
3383 in the OSPF domain.
3384
3385 * ospf_zebra.c (ospf_redistribute_source_metric_type),
3386 (ospf_redistribute_source_type_metric): Re-arrange DEFUNs and
3387 ALIASes.
3388
33892000-05-01 Toshiaki Takada <takada@zebra.org>
3390
3391 * ospf_flood.c (ospf_ls_retransmit_count),
3392 (ospf_ls_retransmit_isempty): New function added.
3393
3394 (ospf_ls_retransmit_add), (ospf_ls_retransmit_delete),
3395 (ospf_ls_retransmit_clear), (ospf_ls_retransmit_lookup),
3396 (ospf_ls_retransmit_delete_all), (ospf_ls_retransmit_delete_nbr_all),
3397 (ospf_ls_retransmit_add_nbr_all): Replace these functions to use
3398 new_lsdb.
3399
34002000-04-29 Toshiaki Takada <takada@zebra.org>
3401
3402 * ospfd.c (no_network_area): Add check Area-ID whether specified
3403 Area-ID with prefix matches config.
3404
34052000-04-27 Toshiaki Takada <takada@zebra.org>
3406
3407 * ospf_lsa.c (ospf_maxage_lsa_remover): Fix problem of
3408 remaining withdrawn routes on zebra.
3409
34102000-04-25 Michael Rozhavsky <mike@nbase.co.il>
3411
3412 * ospf_nsm.c (nsm_kill_nbr), (nsm_ll_down), (nsm_change_status),
3413 (ospf_nsm_event): Fix network-LSA re-origination problem.
3414
34152000-04-24 Toshiaki Takada <takada@zebra.org>
3416
3417 * ospf_nsm.c (ospf_db_desc_timer): Fix bug of segmentation fault
3418 with DD retransmission.
3419
3420 * ospf_nsm.c (nsm_kill_nbr): Fix bug of re-origination when
3421 a neighbor disappears.
3422
34232000-04-23 Michael Rozhavsky <mike@nbase.co.il>
3424
3425 * ospf_abr.c (ospf_abr_announce_network_to_area): Fix bug of
3426 summary-LSAs reorigination. Correctly copy OSPF_LSA_APPROVED
3427 flag to new LSA. when summary-LSA is reoriginatd.
3428
3429 * ospf_flood.c (ospf_flood_through_area): Fix bug of flooding
3430 procedure. Change the condition of interface selection.
3431
34322000-04-21 Toshiaki Takada <takada@zebra.org>
3433
3434 * ospf_lsa.c (ospf_refresher_register_lsa): Fix bug of refresh never
3435 occurs.
3436
3437 * ospfd.c (show_ip_ospf_neighbor_id): New defun added.
3438 `show ip ospf neighbor' related commands are re-arranged.
3439
34402000-04-20 Toshiaki Takada <takada@zebra.org>
3441
3442 * ospf_dump.c (debug_ospf_zebra): New defun added.
3443 Suppress zebra related debug information.
3444
34452000-04-19 Toshiaki Takada <takada@zebra.org>
3446
3447 * ospf_zebra.c (ospf_distribute_list_update_timer),
3448 (ospf_distribute_list_update), (ospf_filter_update):
3449 New function added. Re-organize `distribute-list' router ospf
3450 command.
3451
34522000-04-13 Michael Rozhavsky <mike@nbase.co.il>
3453
3454 * ospf_packet.c (ospf_make_ls_upd): Add check for MAX_AGE.
3455
34562000-04-14 Michael Rozhavsky <mike@nbase.co.il>
3457
3458 * ospf_packet.c (ospf_make_ls_upd): Increment LS age by configured
3459 interface transmit_delay.
3460
34612000-04-14 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3462
3463 * ospf_interface.c (ip_ospf_cost), (no_ip_ospf_cost):
3464 Add to schedule router_lsa origination when the interface cost changes.
3465
34662000-04-12 Toshiaki Takada <takada@zebra.org>
3467
3468 * ospf_lsa.c (ospf_refresher_register_lsa),
3469 (ospf_refresher_unregister_lsa): Fix bug of core dumped.
3470
3471 * ospfd.c (no_router_ospf): Fix bug of core dumped.
3472
34732000-03-29 Toshiaki Takada <takada@zebra.org>
3474
3475 * ospf_nsm.c (nsm_oneway_received): Fix bug of MS flag unset.
3476
34772000-03-29 Michael Rozhavsky <mike@nbase.co.il>
3478
3479 * ospf_lsa.c (ospf_network_lsa):
3480 * ospf_nsm.c (ospf_nsm_event): Fix bug of Network-LSA originated
3481 in stub network.
3482
34832000-03-28 Toshiaki Takada <takada@zebra.org>
3484
3485 * ospf_nsm.c (nsm_bad_ls_req), (nsm_seq_number_mismatch),
3486 (nsm_oneway_received): Fix bug of NSM state flapping between
3487 ExStart and Exchange.
3488
34892000-03-28 Toshiaki Takada <takada@zebra.org>
3490
3491 * ospf_packet.h (strcut ospf_header): Fix the size of ospf_header,
3492 change u_int8_t to u_char.
3493
34942000-03-27 Toshiaki Takada <takada@zebra.org>
3495
3496 * ospf_lsa.c (ospf_lsa_checksum): Take care of BIGENDIAN architecture.
3497
34982000-03-27 Toshiaki Takada <takada@zebra.org>
3499
3500 * ospfd.c (ospf_interface_run): Make sure Address family matches.
3501
35022000-03-26 Love <lha@s3.kth.se>
3503
3504 * ospf_packet.c (ospf_write): Chack result of sendto().
3505
35062000-03-26 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3507
3508 * ospf_nsm.c (nsm_oneway_received): Fix bug of 1-WayReceived in NSM.
3509
35102000-03-23 Libor Pechacek <farco@clnet.cz>
3511
3512 * ospf_lsa.c (ospf_network_lsa)
3513 * ospf_lsdb.c (new_lsdb_insert): Fix bug of accessing to
3514 unallocated memory.
3515
35162000-03-23 Toshiaki Takada <takada@zebra.org>
3517
3518 * ospfd.c (ospf_config_write): Fix bug of duplicate line for
3519 `area A.B.C.D authentication'.
3520
35212000-03-22 Toshiaki Takada <takada@zebra.org>
3522
3523 * ospf_debug.c (debug_ospf_lsa), (no_debug_ospf_lsa): Defun added.
3524 Suppress all zlog related to LSAs with this config option.
3525
35262000-03-21 Kunihiro Ishiguro <kunihiro@zebra.org>
3527
3528 * ospf_nsm.c (ospf_nsm_event): Add check for NSM_InactivityTimer.
3529
35302000-03-21 Toshiaki Takada <takada@zebra.org>
3531
3532 * ospf_packet.c (ospf_ls_upd_timer), (ospf_ls_req):
3533 Fix bug of memory leak about linklist.
3534
3535 * ospf_flood.c (ospf_flood_through_area): Likewise.
3536
35372000-03-18 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3538
3539 * ospf_flood.c (ospf_ls_retransmit_lookup): Add checksum comparison
3540 to identify LSA uniquely. This fix routes lost.
3541
35422000-03-18 Toshiaki Takada <takada@zebra.org>
3543
3544 * ospf_ase.c (ospf_find_asbr_route): Add sanity check with router
3545 routing table.
3546
35472000-03-17 Alex Zinin <zinin@amt.ru>
3548
3549 * ospf_spf.[ch]: Bug fix.
3550 The 2nd stage of Dijkstra could consider one vertex
3551 more than once if there is more than one link
3552 between the routers, thus adding extra CPU overhead
3553 and extra next-hops.
3554 Fixed.
3555
35562000-03-15 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3557
3558 * ospf_nsm.c (nsm_inactivity_timer): Changed to call nsm_kill_nbr().
3559
35602000-03-14 Toshiaki Takada <takada@zebra.org>
3561
3562 * ospf_route.c (ospf_route_copy_nexthops): Fix bug of memory leak of
3563 ospf_path. Actually ignore merging ospf_route with completely same
3564 paths.
3565
35662000-03-12 Toshiaki Takada <takada@zebra.org>
3567
3568 * ospf_lsa.c (show_as_external_lsa_detail): fix bug of
3569 external route tag byte order.
3570
35712000-03-11 Toshiaki Takada <takada@zebra.org>
3572
3573 * ospf_lsdb.c (ospf_lsdb_insert): New function added.
3574
35752000-03-09 Toshiaki Takada <takada@zebra.org>
3576
3577 * ospf_lsa.c (ospf_external_lsa_install),
3578 (ospf_lsa_lookup), (show_ip_ospf_database_all),
3579 (show_ip_ospf_database_self_originate): Use struct new_lsdb for
3580 LSDB of AS-external-LSAs instead of ospf_lsdb.
3581
3582 * ospf_lsa.c (ospf_lsa_unique_id): New function added.
3583 Use for assigning Unique Link State ID instead of
3584 ospf_get_free_id_for_prefix().
3585
35862000-03-09 Toshiaki Takada <takada@zebra.org>
3587
3588 * ospf_ase.c (ospf_ase_calculate_timer): Fix bug of segmentation
3589 fault reported by George Bonser <george@siteROCK.com>.
3590
35912000-03-07 Libor Pechacek <farco@clnet.cz>
3592
3593 * ospfd.c (ospf_interface_down): Fix bug of segmentation fault.
3594
35952000-03-06 Toshiaki Takada <takada@zebra.org>
3596
3597 * ospf_route.c (ospf_route_cmp): Change meaning of return values.
3598
35992000-03-02 Alex Zinin <zinin@amt.ru>
3600 * ospfd.h, ospf_ia.h
3601 New Shortcut ABR code. Now area's flag can be configured
3602 with Default, Enable, and Disable values.
3603 More info will be in the new ver of I-D soon (see IETF web).
3604
36052000-02-25 Toshiaki Takada <takada@zebra.org>
3606
3607 * ospf_lsa.c (ospf_lsa_header_set), (ospf_external_lsa_body_set),
3608 (osfp_external_lsa_originate), (ospf_external_lsa_queue),
3609 (ospf_external_lsa_originate_from_queue): New function added.
3610 (ospf_external_lsa): Function removed.
3611
3612 * ospf_zebra.c (ospf_zebra_read_ipv4): Originate AS-external-LSA
3613 when listen a route from Zebra, instead creating external route.
3614
3615 * ospf_asbr.c (ospf_asbr_route_add_flood_lsa),
3616 (ospf_asbr_route_add_queue_lsa),
3617 (ospf_asbr_route_install_lsa), (ospf_asbr_route_add):
3618 Functions removed.
3619
3620 * ospf_ase.c (process_ase_lsa): Function will not be used.
3621 (ospf_ase_calculate), (ospf_ase_calculate_route_add),
3622 (ospf_ase_calculate_new_route), (ospf_ase_caluculate_asbr_route):
3623 process_ase_lsa () is separated to these functions.
3624
3625 OSPF AS-external-LSA origination is whole re-organized.
3626
36272000-02-18 Toshiaki Takada <takada@zebra.org>
3628
3629 * ospf_packet.c (ospf_ls_upd): Fix bug of OSPF LSA memory leak.
3630
3631 * ospf_asbr.c (ospf_asbr_route_add_flood_lsa),
3632 (ospf_asbr_route_add_queue_lsa): Fix bug of OSPF external route
3633 memory leak.
3634
36352000-02-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3636
3637 * ospf_asbr.c (ospf_asbr_route_install_lsa): Re-calculate LSA
3638 checksum after change Advertised Router field.
3639
36402000-02-09 Toshiaki Takada <takada@zebra.org>
3641
3642 * ospf_asbr.c (ospf_external_route_lookup): Add new function.
3643
36442000-02-08 Toshiaki Takada <takada@zebra.org>
3645
3646 * ospfd.c (ospf_router_id_get), (ospf_router_id_update),
3647 (ospf_router_id_update_timer): Router ID decision algorithm is changed.
3648 Router ID is chosen from all of eligible interface addresses even if
3649 it is not enable to OSPF.
3650
36512000-02-08 Toshiaki Takada <takada@zebra.org>
3652
3653 * ospf_asbr.c (ospf_asbr_route_add): Function divided to
3654 ospf_asbr_route_add_flood_lsa, ospf_asbr_route_add_queue_lsa and
3655 ospf_asbr_route_install_lsa. If Router-ID is not set, then LSA is
3656 waited to install to LSDB.
3657 `0.0.0.0 adv_router' AS-external-LSA origination bug was fixed.
3658
36592000-02-01 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3660
3661 * ospf_flood.c (ospf_ls_retransmit_lookup): Compare LS seqnum
3662 in the ACK before deleting.
3663
3664 * ospf_packet.c (ospf_hello): Reset the flags after a shutdown
3665 and no shutdown of the interface.
3666
36672000-01-31 Toshiaki Takada <takada@zebra.org>
3668
3669 * ospf_packet.c (ospf_ls_req): Send multiple Link State Update
3670 packets respond to a Link State Request packet.
3671
3672 * ospfd.c (show_ip_ospf_neighbor_detail_sub): Show thread state.
3673
3674 * ospf_interface.c (ospf_vl_new): Crash when backbone area
3675 is not configured and set virtual-link to no-backbone area,
3676 bug fixed.
3677
36782000-01-30 Kunihiro Ishiguro <kunihiro@zebra.org>
3679
3680 * ospf_neighbor.h (struct ospf_neighbor): Add pointer to last send
3681 LS Request LSA.
3682
3683 * ospf_packet.c (ospf_ls_upd): Comment out LS request list
3684 treatment. That should be done in OSPF flooding procedure.
3685
3686 * ospf_flood.c (ospf_flood_through_area): Enclose
3687 ospf_check_nbr_loding inside if-else close.
3688
36892000-01-31 Toshiaki Takada <takada@zebra.org>
3690
3691 * ospf_packet.c (ospf_make_ls_upd): Fix bug of #LSAs counting.
3692
36932000-01-29 Toshiaki Takada <takada@zebra.org>
3694
3695 * ospf_packet.c (ospf_make_md5_digest): Fix bug of md5 authentication.
3696
36972000-01-28 Toshiaki Takada <takada@zebra.org>
3698
3699 * ospfd.c (show_ip_ospf): Show Number of ASE-LSAs.
3700
37012000-01-27 Kunihiro Ishiguro <kunihiro@zebra.org>
3702
3703 * ospf_packet.c (ospf_make_db_desc): Don't use rm_list for
3704 removing LSA from nbr->db_summary.
3705
37062000-01-27 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3707
3708 * ospf_packet.c (ospf_ls_upd_send): Set AllSPFRouters to
3709 destination when the link is point-to-point.
3710 (ospf_ls_ack_send_delayed): Likewise.
3711
37122000-01-27 Kunihiro Ishiguro <kunihiro@zebra.org>
3713
3714 * ospf_flood.c (ospf_ls_request_delete_all): Fix bug of next
3715 pointer lookup after the node is freed.
3716
37172000-01-26 Kunihiro Ishiguro <kunihiro@zebra.org>
3718
3719 * ospf_asbr.c (ospf_asbr_route_add): Instead of scanning all AS
3720 external route, use ospf_top->external_self.
3721
37222000-01-27 Toshiaki Takada <takada@zebra.org>
3723
3724 * ospf_lsa.c (ospf_forward_address_get): New function added.
3725
3726 * ospf_asbr.c (ospf_asbr_check_lsas): Originate AS-external-LSA
3727 only when it should be replaced.
3728
37292000-01-25 Kunihiro Ishiguro <kunihiro@zebra.org>
3730
3731 * ospf_flood.c (ospf_ls_retransmit_clear): Delete list node.
3732
3733 * ospf_lsa.c (ospf_lsa_free): Reduce logging message using
3734 ospf_zlog value.
3735
3736 * ospf_ism.c (ism_change_status): Fix bug of DR -> non DR status
3737 change. Self originated LSA is freed but not deleted from lsdb.
3738
37392000-01-24 Kunihiro Ishiguro <kunihiro@zebra.org>
3740
3741 * ospf_ism.c (ism_interface_down): Don't use router_id for
3742 detecting self neighbor structure. Instead of that compare
3743 pointer itself.
3744
3745 * ospf_neighbor.c (ospf_nbr_free): Cancel all timer when neighbor
3746 is deleted.
3747 (ospf_nbr_free): Free last send packet.
3748
3749 * ospf_neighbor.h (struct ospf_neighbor): Remove host strucutre.
3750 Instead of that src is introduced.
3751
3752 * ospf_nsm.h: Enclose macro defenition with do {} while (0).
3753
37542000-01-17 Kunihiro Ishiguro <kunihiro@zebra.org>
3755
3756 * ospfd.c: Change part of passive interface implementation. For
3757 passive interface just disabling sending/receiving Hello on the
3758 interface.
3759
37602000-01-16 Kai Bankett <kai.bankett@vew-telnet.net>
3761
3762 * ospf_interface.h (OSPF_IF_PASSIVE): Add passive flag.
3763 * ospf_interface.c (ospf_if_lookup_by_name): Add new function.
3764 * ospf_lsa.c (ospf_router_lsa): Skip passive interface.
3765 * ospfd.c (passive_interface): New command passive-interface is
3766 added.
3767 (ospf_config_write): Print passive interface.
3768
37692000-01-15 Toshiaki Takada <takada@zebra.org>
3770
3771 * ospf_interface.h (crypt_key): New struct added to store
3772 multiple cryptographic autheitication keys.
3773 (ospf_interface): struct changed.
3774
3775 * ospf_interface.c: ospf_crypt_key_new, ospf_crypt_key_add,
3776 ospf_crypt_key_lookup, ospf_crypt_key_delete: new functions added.
3777
3778 * ospf_packet.c (ip_ospf_message_digest_key): Changed to store
3779 multiple cryptographic authentication keys.
3780
37812000-01-14 Toshiaki Takada <takada@zebra.org>
3782
3783 * ospf_interface.c: DEFUN (if_ospf_*) commands changed name to
3784 ip_ospf_* ().
3785 Old notation `ospf *' still remains backward compatibility.
3786
37871999-12-29 Alex Zinin <zinin@amt.ru>
3788 * ospf_lsa.c: ospf_lsa_more_recent() bug fix
3789 * ospf_nsm.c, ospf_packet.c: remove nbr data struct when
3790 int goes down, also check DD flags correctly (bug fix)
3791
37921999-12-28 Alex Zinin <zinin@amt.ru>
3793 * "redistribute <source> metric-type (1|2) metric <XXX>" added
3794
37951999-12-23 Alex Zinin <zinin@amt.ru>
3796 * added RFC1583Compatibility flag
3797 * added dynamic interface up/down functionality
3798
37991999-11-19 Toshiaki Takada <takada@zebra.org>
3800
3801 * ospf_neighbor.h (struct ospf_neighbor): Add member state_change
3802 for NSM state change statistics.
3803
38041999-11-19 Toshiaki Takada <takada@zebra.org>
3805
3806 * ospfd.c (show_ip_ospf_neighbor_detail),
3807 (show_ip_ospf_neighbor_int_detail): DEFUN Added.
3808
38091999-11-14 Kunihiro Ishiguro <kunihiro@zebra.org>
3810
3811 * ospf_asbr.c (ospf_asbr_check_lsas): Add check of
3812 lsa->refresh_list.
3813
38141999-11-11 Toshiaki Takada <takada@zebra.org>
3815
3816 * ospf_ia.[ch] (OSPF_EXAMINE_SUMMARIES_ALL): Macro added.
3817 This macro is expanded to ospf_examine_summaries ()
3818 for SUMMARY_LSA and SUMMARY_LSA_ASBR.
3819 (OSPF_EXAMINE_TRANSIT_SUMMARIES_ALL): Macro added.
3820 This macro is expanded to ospf_examine_transit_summaries ()
3821 for SUMMARY_LSA and SUMMARY_LSA_ASBR.
3822
38231999-11-11 Toshiaki Takada <takada@zebra.org>
3824
3825 * ospf_lsa.[ch] (ospf_find_self_summary_lsa_by_prefix): Changed to
3826 macro OSPF_SUMMARY_LSA_SELF_FIND_BY_PREFIX.
3827 (ospf_find_self_summary_asbr_lsa_by_prefix): Changed to
3828 macro OSPF_SUMMARY_ASBR_LSA_SELF_FIND_BY_PREFIX.
3829 (ospf_find_self_external_lsa_by_prefix): Changed to
3830 macro OSPF_EXTERNAL_LSA_SELF_FIND_BY_PREFIX.
3831
38321999-11-11 Toshiaki Takada <takada@zebra.org>
3833
3834 * ospfd.c (ospf_abr_type): ospf_abr_type_cisco, ospf_abr_type_ibm,
3835 ospf_abr_type_shortcut and ospf_abr_type_standard DEFUNs are
3836 combined.
3837 * ospfd.c (no_ospf_abr_type): no_ospf_abr_type_cisco,
3838 no_ospf_abr_type_ibm and no_ospf_abr_type_shortcut DEFUNS are
3839 combined.
3840
38411999-11-10 Toshiaki Takada <takada@zebra.org>
3842
3843 * ospf_route.c (ospf_lookup_int_by_prefix): Move function to
3844 ospf_interface.c and change name to ospf_if_lookup_by_prefix ().
3845
38461999-11-01 Alex Zinin <zinin@amt.ru>
3847 * ospf_packet.c
3848 some correction to LSU processing
3849
3850 * ospf_lsa.c ospfd.h
3851 randomize initial LSA refreshment interval
3852 and limit the size of LSA-group to 10
3853 to let randomization work more effectively.
3854
38551999-10-31 Alex Zinin <zinin@amt.ru>
3856 * ospf_interface.c
3857 cancel t_network_lsa_self
3858 when freeing int structure
3859
3860 * ospf_abr.c ospf_asbr.c ospf_flood.c ospf_lsa.c
3861 ospf_lsa.h ospf_lsdb.h ospfd.c ospfd.h
3862
3863 Summary and ASE LSA refreshment functions
3864 added---LSA refreshment is paced to 70 LSAs
3865 per sec to avoid link overflow. Refreshment events
3866 are further randomized within a 10 sec interval
3867 to avoid syncing.
3868
3869 Also the sigfault of memcmp() in ospf_lsa_is_different()
3870 is fixed.
3871
38721999-10-30 Alex Zinin <zinin@amt.ru>
3873 * ospf_nsm.c
3874 Fix the bug where MAX_AGE LSAs
3875 are included into the DB summary.
3876
3877 * ospf_interface.c
3878 allocate 2*MTU input buffer instead of just MTU
3879 for the cases when the other router mistakenly
3880 sends larger packets thus causing fragmentation, etc.
3881
3882 * ospf_nsm.c
3883 in nsm_reset_nbr() lists should be freed
3884 not when they are empty.
3885
38861999-10-29 Kunihiro Ishiguro <kunihiro@zebra.org>
3887
3888 * ospf_zebra.c (ospf_acl_hook): Move OSPF_IS_ASBR and OSPF_IS_ABR
3889 check inside of if (ospf_top).
3890
38911999-10-29 Alex Zinin <zinin@amt.ru>
3892 * ospf_lsa.c ospf_lsdb.c :
3893 add assertion in lsa and lsa->data alloc functions,
3894 as well as in lsdb_add for new->data
3895
3896 * ospf_lsdb.c: free hash table correctly
3897
38981999-10-28 John Capo <jc@irbs.com>
3899
3900 * ospf_packet.h (OSPF_PACKET_MAX): Correct MAX packet length
3901 calculation
3902
39031999-10-27 Kunihiro Ishiguro <kunihiro@zebra.org>
3904
3905 * OSPF-TRAP-MIB.txt: New file added. Edited version of RFC1850.
3906
3907 * OSPF-MIB.txt: New file added. Edited version of RFC1850.
3908
39091999-10-27 Alex Zinin <zinin@amt.ru>
3910 * ospfd, ospf_zebra, ospf_abr
3911 "area import-list" command is added.
3912 This command allows to filter the inter-area routes
3913 injected into an area. Access list hook function
3914 extended to invalidate area exp/imp lists.
3915
39161999-10-25 Yoshinobu Inoue <shin@nd.net.fujitsu.co.jp>
3917
3918 * ospfd.c (ospf_interface_run): Enable to detect P2P network
3919 on an OSPF interface.
3920
39211999-10-19 Jordan Mendelson <jordy@wserv.com>
3922
3923 * ospf_lsdb.c (ospf_lsdb_add): Fix bug of crash
3924 in ospf_ls_retransmit_lookup ().
3925
39261999-10-19 Vladimir B. Grebenschikov <vova@express.ru>
3927
3928 * ospf_route.c: Workaround about installation of OSPF routes into
3929 the zebra daemon. Add checking of existance routes. Free
3930 ospf_top->old_table if it exists.
3931
39321999-10-15 Jordan Mendelson <jordy@wserv.com>
3933
3934 * Add support for MD5 authentication.
3935
39361999-10-12 Alex Zinin <zinin@amt.ru>
3937 * ospfd.c, ospfd.h, ospf_abr.c:
3938 a new command "area export-list" was added, it allows
3939 the admin. to control which intra-area routes are
3940 announced to other areas by the ABR
3941
39421999-10-12 Alex Zinin <zinin@amt.ru>
3943 * ospf_asbr.c (ospf_asbr_check_lsas): Fix bug of coredump
3944 when "no redistribute" is used after a distribute list
3945 denying some networks was used
3946
39471999-10-05 Toshiaki Takada <takada@zebra.org>
3948
3949 * ospf_route.c (ospf_path_dup): New function added.
3950
39511999-10-05 Toshiaki Takada <takada@zebra.org>
3952
3953 * ospf_interface.[ch]: Some of VL related funciton name changed.
3954
39551999-09-27 Alex Zinin <zinin@amt.ru>
3956
3957 * ospf_zebra.c: Distribute-list functionality added
3958
39591999-09-27 Toshiaki Takada <takada@zebra.org>
3960
3961 * ospfd.c (show_ip_ospf): Fix bug of segmentation fault when no ospf
3962 instance exists.
3963
39641999-09-25 Kunihiro Ishiguro <kunihiro@zebra.org>
3965
3966 * ospfd.c (ospf_interface_down): Fix bug of misusing nextnode()
3967 instead of node->next. Reported by Hiroki Ishibashi
3968 <ishibasi@dcd.abk.nec.co.jp>.
3969
3970 * ospf_route.c (show_ip_ospf_route): Add check for ospf is enabled
3971 or not.
3972
39731999-09-23 Alex Zinin <zinin@amt.ru>
3974
3975 * stub area support added
3976
39771999-09-23 Alex Zinin <zinin@amt.ru>
3978
3979 * fwd_addr in ASE-LSAs is now set correctly
3980 * ASE routing changed to check the fwd_addr
3981 and skip the route if the addr points to one
3982 of our interfaces to avoid loops.
3983
39841999-09-22 Alex Zinin <zinin@amt.ru>
3985
3986 * ospf_interface:
3987 ospf_vls_in_area() added, it returns
3988 the number of VLs configured through the area
3989
3990 * ospf_interface.c ospf_lsa.c ospf_lsdb.c ospfd.c
3991 honor correct mem alloc
3992
39931999-09-22 Alex Zinin <zinin@amt.ru>
3994
3995 * memory.[ch]:
3996 Some OSPF mem types added,
3997 plus more info in "show mem"
3998
39991999-09-21 Alex Zinin <zinin@amt.ru>
4000
4001 * ospfd.c:
4002 "area range substitute" added.
4003 It can be used on NAT-enabled (IP-masquarade)
4004 routers to announce private networks
4005 from an area as public ones into the outside
4006 world (not in the RFC, btw :)
4007
40081999-09-21 Alex Zinin <zinin@amt.ru>
4009
4010 * ospfd.c:
4011 "area range suppress" added.
4012 This command allows to instruct the router
4013 to be silent about specific ranges, i.e.,
4014 it is a method of route filtering on area
4015 borders
4016
40171999-09-21 Alex Zinin <zinin@amt.ru>
4018
4019 * ospfd.c VLs removed when "no network area" executed
4020
40211999-09-20 Alex Zinin <zinin@amt.ru>
4022
4023 * ospf_ase.c bug fix for not-zero fwd_addr
4024 and directly connected routes.
4025
40261999-09-20 Yon Uriarte <yon@plannet.de>
4027
4028 * ospf_packet.c (ospf_make_ls_req): Introduce delta value for
4029 checking the length of OSPF packet exceeds MTU or not.
4030
4031 * ospf_lsa.c (ospf_lsa_different): Apply ntohs for checking
4032 l1->data->length.
4033
40341999-09-18 Alex Zinin <zinin@amt.ru>
4035
4036 * ospf_lsa.c bug fix for ospf_network_lsa() to
4037 include itself into the RID list
4038
40391999-09-10 Alex Zinin <zinin@amt.ru>
4040
4041 * Alternative ABR behaviors IBM/Cisco/Shortcut
4042 implemented
4043
40441999-09-10 Alex Zinin <zinin@amt.ru>
4045
4046 * router and network-LSA origination
4047 changed to honor MinLSInterval
4048
40491999-09-08 Alex Zinin <zinin@amt.ru>
4050
4051 * modified ABR behavior to honor VLs and transit
4052 areas
4053
40541999-09-07 Alex Zinin <zinin@amt.ru>
4055
4056 * completed VL functionality
4057
40581999-09-06 Kunihiro Ishiguro <kunihiro@zebra.org>
4059
4060 * ospf_asbr.c: New file.
4061 ospf_asbr.h: New file.
4062
4063 * ospf_zebra.c (ospf_redistribute_connected): Add redistribute
4064 related stuff.
4065
40661999-09-05 Kunihiro Ishiguro <kunihiro@zebra.org>
4067
4068 * ospfd.h (OSPF_FLAG_VIRTUAL_LINK): Change OSPF_FLAG_VEND to
4069 OSPF_FLAG_VIRTUAL_LINK for comprehensiveness.
4070
40711999-09-03 Kunihiro Ishiguro <kunihiro@zebra.org>
4072
4073 * ospf_spf.c (ospf_spf_register): Change name from
4074 ospf_spf_route_add() to ospf_spf_register().
4075 Include "ospfd/ospf_abr.h" for ospf_abr_task() prototype.
4076
40771999-09-02 Kunihiro Ishiguro <kunihiro@zebra.org>
4078
4079 * ospf_lsa.c (ospf_external_lsa_install): Change to update
4080 lsa->data rather than install new one, when same id lsa is already
4081 installed.
4082
40831999-09-01 Kunihiro Ishiguro <kunihiro@zebra.org>
4084
4085 * ospf_lsa.c (ospf_router_lsa_install): Return lsa value.
4086 (ospf_network_lsa_install): Likewise.
4087 (ospf_summary_lsa_install): Likewise.
4088 (ospf_summary_asbr_lsa_install): Likewise.
4089 (ospf_external_lsa_install): Likewise.
4090
4091 * ospf_spf.c (ospf_spf_calculate): Comment out debug function
4092 ospf_rtrs_print().
4093
40941999-08-31 Kunihiro Ishiguro <kunihiro@zebra.org>
4095
4096 * ospf_spf.c (ospf_rtrs_free): Add ospf_spf_calculate() for
4097 freeing rtrs.
4098
40991999-08-31 Toshiaki Takada <takada@zebra.org>
4100
4101 * ospf_lsa.c (show_ip_ospf_database_summary),
4102 (show_ip_ospf_database_summary_asbr),
4103 (show_ip_ospf_database_external): New function added.
4104 `show ip ospf database summary',
4105 `show ip ospf database asbr-summary'
4106 `show ip ospf database external' command can be used.
4107
4108 * ospf_lsa.c (ospf_lsa_count_table): New function added.
4109 (show_ip_ospf_database_all): show nothing if a type of LSA
4110 does not exist.
4111
41121999-08-31 Kunihiro Ishiguro <kunihiro@zebra.org>
4113
4114 * ospf_lsa.c (ospf_maxage_lsa_remover): Preserve next pointer when
4115 the node is deleted.
4116
41171999-08-31 Toshiaki Takada <takada@zebra.org>
4118
4119 * ospf_flood.c (ospf_ls_retransmit_lookup): change to return
4120 struct ospf_lsa *.
4121 (ospf_ls_request_new), (ospf_ls_request_free),
4122 (ospf_ls_request_add), (ospf_ls_request_delete),
4123 (ospf_ls_request_delete_all), (ospf_ls_request_lookup):
4124 New function added.
4125
4126 * ospf_packet.c (ospf_ls_upd_send_lsa): New function added.
4127
4128 * ospf_lsa.h (LS_AGE): Slightly change macro definition.
4129
4130 * ospf_lsa.c (ospf_lsa_more_recent), (ospf_lsa_diffrent):
4131 Use LS_AGE macro.
4132
41331999-08-30 Alex Zinin <zinin@amt.ru>
4134
4135 * ospfd.c
4136 fix a bug with area range config write
4137 added "show ip ospf" command, it will be enhanced later on
4138
41391999-08-30 Alex Zinin <zinin@amt.ru>
4140
4141 * ospf_lsa.c
4142 updated ospf_router_lsa() to honor flags (B-bit)
4143
41441999-08-30 Alex Zinin <zinin@amt.ru>
4145
4146 * ospf_abr.c
4147 wrote major functions implementing ABR activity
4148
41491999-08-30 Alex Zinin <zinin@amt.ru>
4150
4151 * ospf_ia.c ospf_route.c ospf_route.h
4152 fixed the bug with ospf_route.origin field.
4153 Now it holds pointer to lsa_header
4154
41551999-08-30 Alex Zinin <zinin@amt.ru>
4156
4157 * ospf_flood.c ospf_flood.h:
4158 transformed ospf_flood_if_select into ospf_flood_through_area()
4159 added new ospf_flood_if_select() and ospf_flood_through_as()
4160
41611999-08-30 Toshiaki Takada <takada@zebra.org>
4162
4163 * ospf_flood.[ch]: New file added.
4164
4165 * ospf_packet.c (ospf_lsa_flooding),
4166 (ospf_lsa_flooding_select_if): functions move to ospf_flood.c
4167
4168 * ospf_neighbor.c (ospf_put_lsa_on_retransm_list),
4169 (ospf_remove_lsa_from_retransm_list),
4170 (ospf_nbr_remove_all_lsas_from_retransm_list),
4171 (ospf_lsa_remove_from_ls_retransmit):
4172 (ospf_lsa_retransmit): functions move to
4173 ospf_flood.c, and change function's name:
4174
4175 ospf_put_lsa_on_retransm_list ()
4176 -> ospf_ls_retransmit_add ()
4177 ospf_remove_lsa_from_retransm_list ()
4178 -> ospf_ls_retransmit_delete ()
4179 ospf_nbr_remove_all_lsas_from_retransm_list ()
4180 -> ospf_ls_retransmit_clear ()
4181 ospf_lsa_remove_from_ls_retransmit ()
4182 -> ospf_ls_retransmit_delete_nbr_all ()
4183 ospf_lsa_retransmit ()
4184 -> ospf_ls_retransmit_add_nbr_all ()
4185
4186 * ospf_lsa.c (ospf_lsa_lookup_from_list): function move to
4187 ospf_flood.c, and change name to ospf_ls_retransmit_lookup ().
4188
41891999-08-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4190
4191 * ospf_neighbor.c (ospf_nbr_lookup_by_addr): Use
4192 route_node_lookup() instead of route_node_get().
4193
4194 * ospf_packet.c (ospf_ls_upd): Temporary comment out (6) check.
4195
41961999-08-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4197
4198 * ospf_route.c (ospf_lookup_int_by_prefix): Add check of
4199 oi->address.
4200
42011999-08-29 Alex Zinin <zinin@amt.ru>
4202 * ospf_lsa.c
4203 MaxAge LSA deletion functions added.
4204
42051999-08-29 Alex Zinin <zinin@amt.ru>
4206 * ospf_neighbor.c
4207 ospf_nbr_lookup_by_addr(): added route_unlock_node()
4208 when function returns NULL if (rn->info == NULL)
4209
42101999-08-29 Alex Zinin <zinin@amt.ru>
4211 * ospfd.c
4212 added a hack for area range deletion
4213
42141999-08-29 Alex Zinin <zinin@amt.ru>
4215 * ospf_lsa.h
4216 included lsdb field into struct ospf_lsa, to find
4217 LSDB easier when removing MaxAge LSAs.
4218
42191999-08-29 Alex Zinin <zinin@amt.ru>
4220 * ospf_lsa.c ospf_neighbor.c ospf_nsm.c
4221 ospf_packet.c changed to honor new retransmit list
4222 management functions
4223
42241999-08-29 Alex Zinin <zinin@amt.ru>
4225 * ospf_neighbor.c , .h added new retransmit list functions.
4226
42271999-08-29 Alex Zinin <zinin@amt.ru>
4228 * Makefile.in
4229 added ospf_ase, ospf_abr, ospf_ia
4230
42311999-08-29 Alex Zinin <zinin@amt.ru>
4232 * ospf_spf.c:
4233 - changed ospf_next_hop_calculation() to include interface
4234 and nexthop addr for directly connected routers---more informative
4235 and solves problem with route installation into the kernel
4236 - changed ospf_nexthop_out_if_addr() to support routers, not only
4237 transit networks
4238 - added ospf_process_stubs();
4239
42401999-08-29 Alex Zinin <zinin@amt.ru>
4241 * ospf_lsa.c:
4242 - changed ospf_router_lsa() to provide correct links
4243 for p-t-p interfaces;
4244 - changed ospf_summary_lsa_install() to support table
4245 of self-originated summary-LSAs;
4246 - added ospf_summary_asbr_lsa_install() and ospf_external_lsa_install()
4247 - changed ospf_lsa_install() accordingly
4248 - changed show_ip_ospf_database_router_links() to support p-t-p
4249
42501999-08-29 Kunihiro Ishiguro <kunihiro@zebra.org>
4251
4252 * ospf_packet.c (ospf_make_db_desc): Only master can clear more
4253 flag.
4254
42551999-08-29 Kunihiro Ishiguro <kunihiro@zebra.org>
4256
4257 * ospf_packet.c (ospf_read): Add check of IP src address.
4258
42591999-08-28 Alex Zinin <zinin@amt.ru>
4260 * ospf_neighbor.h
4261 added ospf_nbr_lookup_by_routerid()
4262
42631999-08-28 Alex Zinin <zinin@amt.ru>
4264 * ospfd.h
4265 added ABR/ASBR flag definitions and fields;
4266 added iflist field to area structure;
4267 summary_lsa_self and summary_lsa_asbr_self are changed
4268 to be route tables;
4269 added ranges field---configured area ranges;
4270 A separate Routers RT added;
4271 area range config commands and config write added
4272
4273
42741999-08-28 Alex Zinin <zinin@amt.ru>
4275 * ospf_route.c :
4276 ospf_route_free()--added code to free the list of paths;
4277 The following functions added:
4278 ospf_intra_add_router();
4279 ospf_intra_add_transit();
4280 ospf_intra_add_stub();
4281 the last function uses new ospf_int_lookup_by_prefix();
4282 show_ip_ospf_route_cmd()--changed to support new RT structure;
4283 added ospf_cmp_routes()--general route comparision function;
4284 added ospf_route_copy_nexthops() and ospf_route_copy_nexthops_from_vertex()
4285 they are used in ASE and IA routing;
4286 added ospf_subst_route() and ospf_add_route();
4287
42881999-08-28 Alex Zinin <zinin@amt.ru>
4289 * ospf_route.h :
4290 changed struct ospf_path to include output interface,
4291 changed struct ospf_route to support IA and ASE routing.
4292 added prototypes of the function used in IA and ASE modules.
4293
42941999-08-28 Alex Zinin <zinin@amt.ru>
4295 * ospf_lsa.h ospf_lsa.c :
4296 added ospf_my_lsa(), an interface independent version of
4297 ospf_lsa_is_self_originated(), it will be used in ASE and IA-routing.
4298
42991999-08-27 Kunihiro Ishiguro <kunihiro@zebra.org>
4300
4301 * ospf_interface.c (interface_config_write): Add check for
4302 oi->nbr_self.
4303
43041999-08-25 Toshiaki Takada <takada@zebra.org>
4305
4306 * ospf_lsa.c (ospf_lsa_dup): New function added.
4307
4308 * ospf_packet.c (ospf_write), (ospf_read): Print send/recv
4309 interface in debug message.
4310
43111999-08-25 Toshiaki Takada <takada@zebra.org>
4312
4313 * ospf_packet.c (ospf_ls_ack_send): The name is changed from
4314 `ospf_ls_ack_send'.
4315 (ospf_ls_ack_send_delayed) (ospf_ls_ack_timer): New function added.
4316 Delayed Link State Acknowledgment is scheduled by timer.
4317
43181999-08-25 Alex Zinin <zinin@amt.ru>
4319
4320 * ospf_lsa.c (ospf_router_lsa): Incorrectly included link to
4321 a stub network instead of link to a transit network into
4322 originated router-LSA, bug fixed.
4323
43241999-08-24 Toshiaki Takada <takada@zebra.org>
4325
4326 * ospfd.c (ospf_update_router_id): New function added.
4327
4328 * ospf_network.c (ospf_write): Create new socket per transmission.
4329 And select outgoing interface whether dst is unicast or multicast.
4330
4331 * ospf_packet.c: LSA flooding will work.
4332
43331999-08-24 VOP <vop@unity.net>
4334
4335 * ospf_route.c: Include "sockunion.h"
4336
43371999-08-24 Kunihiro Ishiguro <kunihiro@zebra.org>
4338
4339 * ospf_network.c (ospf_serv_sock_init): Enclose
4340 IPTOS_PREC_INTERNETCONTROL setting with #ifdef for OS which does
4341 not have the definition.
4342
43431999-08-23 Toshiaki Takada <takada@zebra.org>
4344
4345 * ospf_packet.c: Fix bug of DD processing.
4346
43471999-08-18 Toshiaki Takada <takada@zebra.org>
4348
4349 * ospf_lsa.c (show_ip_ospf_database): Show actual `LS age'.
4350
43511999-08-17 Toshiaki Takada <takada@zebra.org>
4352
4353 * ospf_lsa.h (OSPF_MAX_LSA): The value of OSPF_MAX_LSA is
4354 corrected. The bug of `mes_lookup' is fixed.
4355 This had been reported by Poul-Henning Kamp <phk@freebsd.org>.
4356
4357 * ospf_lsa.c (ospf_router_lsa_install): The name is changed from
4358 `ospf_add_router_lsa'.
4359 (ospf_network_lsa_install): The name is changed from
4360 `ospf_add_network_lsa'.
4361
4362 * ospf_interface.h (ospf_interface): Add member `nbr_self'.
4363
4364 * ospf_interface.c (ospf_if_is_enable): New function added.
4365
43661999-08-16 Toshiaki Takada <takada@zebra.org>
4367
4368 * ospf_lsa.h (struct lsa_header): The name is changed from
4369 `struct ospf_lsa'.
4370 (struct ospf_lsa): New struct added to control each LSA's aging
4371 and timers.
4372
4373 * ospf_lsa.c (ospf_lsa_data_free): The name is change from
4374 `ospf_lsa_free'.
4375 (ospf_lsa_data_new), (ospf_lsa_new), (ospf_lsa_free),
4376 (ospf_lsa_different), (ospf_lsa_install): New function added.
4377
4378 * ospf_packet.c (ospf_ls_upd_list_lsa): New function added.
4379
43801999-08-12 Toshiaki Takada <takada@zebra.org>
4381
4382 * ospf_nsm.c (nsm_reset_nbr): New function added.
4383 KillNbr and LLDown neighbor event call this function.
4384
43851999-08-10 Toshiaki Takada <takada@zebra.org>
4386
4387 * ospf_packet.c (ospf_ls_retransmit)
4388 (ospf_ls_upd_timer): New function added.
4389 Set retransmission timer for Link State Update.
4390
43911999-07-29 Toshiaki Takada <takada@zebra.org>
4392
4393 * ospf_ism.c (ospf_dr_election): Fix bug of DR election.
4394
43951999-07-28 Toshiaki Takada <takada@zebra.org>
4396
4397 * ospf_network.c (ospf_serv_sock_init): Set IP precedence field
4398 with IPTOS_PREC_INTERNET_CONTROL.
4399
4400 * ospf_nsm.c (nsm_change_status): Schedule NeighborChange event
4401 if NSM status change.
4402
4403 * ospf_packet.c (ospf_make_hello): Never include a neighbor in
4404 Hello packet, when the neighbor goes down.
4405
44061999-07-26 Kunihiro Ishiguro <kunihiro@zebra.org>
4407
4408 * Makefile.am (noinst_HEADERS): Add ospf_route.h.
4409
4410 * ospf_route.c (show_ip_ospf_route): Add `show ip ospf route'
4411 command.
4412
44131999-07-25 Toshiaki Takada <takada@zebra.org>
4414
4415 * ospf_lsa.c (ospf_router_lsa): Fix bug of LS sequence number
4416 assignement.
4417
44181999-07-25 Kunihiro Ishiguro <kunihiro@zebra.org>
4419
4420 * ospf_route.c (ospf_route_table_free): New function added.
4421
4422 * ospf_spf.c (ospf_spf_next): Free vertex w when cw's and w's
4423 distance is same.
4424
4425 * ospfd.h (struct ospf): Add old_table.
4426
4427 * ospf_main.c (sighup): Call of log_rotate () removed.
4428
4429 * ospf_lsa.c (ospf_lsa_is_self_originated): Fix bug of checking
4430 area->lsa as self LSA. This should be area->lsa_self.
4431
44321999-07-24 Kunihiro Ishiguro <kunihiro@zebra.org>
4433
4434 * ospf_zebra.c (ospf_zebra_add): ospf_zebra_add
4435 (),ospf_zebra_delete () added.
4436
4437 * ospf_spf.c (ospf_spf_calculate): Call ospf_intra_route_add ().
4438
44391999-07-24 Toshiaki Takada <takada@zebra.org>
4440
4441 * ospf_lsa.c: Change LS sequence number treatment.
4442 (ospf_lsa_is_self_originated): New function added.
4443 (show_ip_ospf_database_self_originated): New DEFUN added.
4444
44451999-07-23 Kunihiro Ishiguro <kunihiro@zebra.org>
4446
4447 * ospf_interface.c (ospf_if_lookup_by_addr): Add loopback check.
4448
44491999-07-22 Toshiaki Takada <takada@zebra.org>
4450
4451 * ospf_spf.c (ospf_nexthop_new), (ospf_nexthop_free),
4452 (ospf_nexthop_dup): function added.
4453 (ospf_nexthop_calculation): function changed.
4454
4455 * ospf_interface.c (ospf_if_lookup_by_addr): function added.
4456
44571999-07-21 Toshiaki Takada <takada@zebra.org>
4458
4459 * ospf_spf.c (ospf_spf_closest_vertex): function removed.
4460
44611999-07-21 Kunihiro Ishiguro <kunihiro@zebra.org>
4462
4463 * ospf_spf.c (ospf_spf_next): Apply ntohs for fetching metric.
4464
44651999-07-21 Toshiaki Takada <takada@zebra.org>
4466
4467 * ospf_neighbor.c (ospf_nbr_lookup_by_router_id): fundtion removed.
4468
4469 * ospf_lsa.c (show_ip_ospf_database_router): describe each
4470 connected link.
4471
44721999-07-21 Kunihiro Ishiguro <kunihiro@zebra.org>
4473
4474 * ospf_spf.c (ospf_spf_next): V is router LSA or network LSA so
4475 change behavior according to LSA type.
4476 (ospf_lsa_has_link): Link check function is added.
4477
44781999-07-20 Kunihiro Ishiguro <kunihiro@zebra.org>
4479
4480 * ospf_spf.c (ospf_spf_calculate_schedule): Add new function for
4481 SPF calcultion schedule addtition.
4482 (ospf_spf_calculate_timer_add): Rough 30 sec interval SPF calc
4483 timer is added.
4484 (ospf_spf_next_router): Delete ospf_spf_next_network ().
4485
4486 * ospf_lsa.c (show_ip_ospf_database_all): Network-LSA display
4487 header typo correction. Display of router LSA's #link added.
4488
44891999-07-19 Toshiaki Takada <takada@zebra.org>
4490
4491 * ospf_packet.c (ospf_check_network_mask): Added new function for
4492 receiving Raw IP packet on an appropriate interface.
4493
44941999-07-16 Toshiaki Takada <takada@zebra.org>
4495
4496 * ospfd.c (ospf_router_id): new DEFUN added.
4497
44981999-07-15 Toshiaki Takada <takada@zebra.org>
4499
4500 * ospf_spf.c (ospf_spf_init), (ospf_spf_free),
4501 (ospf_spf_has_vertex), (ospf_vertex_lookup),
4502 (ospf_spf_next_router), (ospf_spf_next_network),
4503 (ospf_spf_closest_vertex), (ospf_spf_calculate):
4504 function added.
4505
45061999-07-13 Toshiaki Takada <takada@zebra.org>
4507
4508 * ospf_ism.c: fix bug of DR Election.
4509
4510 * ospf_nsm.c: fix bug of adjacency forming.
4511
45121999-07-05 Kunihiro Ishiguro <kunihiro@zebra.org>
4513
4514 * ospfd.c (ospf_init): Change to use install_default.
4515
45161999-07-01 Rick Payne <rickp@rossfell.co.uk>
4517
4518 * ospf_zebra.c (zebra_init): Install standard commands to
4519 ZEBRA_NODE.
4520
45211999-06-30 Toshiaki Takada <takada@zebra.org>
4522
4523 * ospf_dump.c: Whole debug command is improved.
4524 (ISM|NSM) (events|status|timers) debug option added.
4525 (show_debugging_ospf): new DEFUN added.
4526
45271999-06-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4528
4529 * ospf_lsa.c (ospf_lsa_lookup_from_list): Change !IPV4_ADDR_CMP to
4530 IPV4_ADDR_SAME.
4531
45321999-06-29 Toshiaki Takada <takada@zebra.org>
4533
4534 * ospf_dump.c (ospf_summary_lsa_dump): Add summary-LSA dump routine.
4535 (ospf_as_external_lsa_dump): Add AS-external-LSA dump routine.
4536
4537 * ospf_nsm.c (nsm_twoway_received): fix condtion of adjacnet.
4538
4539 * ospf_ism.c (ospf_dr_election): fix DR Election.
4540
4541 * ospf_dump.c (ospf_nbr_state_message): fix `show ip ospf neighbor'
4542 command's state.
4543
45441999-06-29 Kunihiro Ishiguro <kunihiro@zebra.org>
4545
4546 * ospf_dump.c (ospf_router_lsa_dump): Add router-LSA dump routine.
4547
45481999-06-28 Toshiaki Takada <takada@zebra.org>
4549
4550 * ospf_lsa.c (show_ip_ospf_database_network): fix bug of
4551 `show ip ospf database network' command output.
4552
4553 * ospf_nsm.c (nsm_inactivity_timer): Clear list of Link State
4554 Retransmission, Database Summary and Link State Request.
4555
4556 * ospf_packet.c (ospf_ls_req_timer): New function added.
4557 Set Link State Request retransmission timer.
4558
45591999-06-27 Kunihiro Ishiguro <kunihiro@zebra.org>
4560
4561 * ospf_main.c (main): Change default output from ZLOG_SYSLOG to
4562 ZLOG_STDOUT.
4563
4564 * ospfd.c (ospf_init): Register show_ip_ospf_interface_cmd and
4565 show_ip_ospf_neighbor_cmd to VIEW_NODE.
4566
4567 * ospf_lsa.c (ospf_lsa_init): Register show_ip_ospf_database_cmd
4568 and show_ip_ospf_database_type_cmd to VIEW_NODE.
4569
45701999-06-25 Toshiaki Takada <takada@zebra.org>
4571
4572 * ospf_packet.c: fix bug of DD making.
4573 fix bug of LS-Update reading.
4574
45751999-06-23 Toshiaki Takada <takada@zebra.org>
4576
4577 * ospf_packet.c: All type of packets are changed to use
4578 fifo queue structure.
4579 (ospf_fill_header) function added.
4580
45811999-06-22 Toshiaki Takada <takada@zebra.org>
4582
4583 * ospf_packet.c (ospf_packet_new): New function added to handle
4584 sending ospf packet by fifo queue structure.
4585 (ospf_packet_free), (ospf_fifo_new), (ospf_fifo_push),
4586 (ospf_fifo_pop), (ospf_fifo_head), (ospf_fifo_flush),
4587 (ospf_fifo_free): Likewise.
4588
45891999-06-21 Toshiaki Takada <takada@zebra.org>
4590
4591 * ospf_nsm.c (ospf_db_desc_timer): function added.
4592 (nsm_timer_set) function added.
4593 * ospf_dump.c (ospf_option_dump): function added.
4594 * ospf_packet.c (ospf_ls_req) (ospf_make_ls_req): function added.
4595
45961999-06-20 Toshiaki Takada <takada@zebra.org>
4597
4598 * ospf_lsa.c (ospf_lsa_more_recent): function added.
4599 * ospf_neighbor.h (struct ospf_neighbor): Change member ms_flag
4600 to dd_flags.
4601
46021999-06-19 Toshiaki Takada <takada@zebra.org>
4603
4604 * ospf_lsa.c: DEFUN (show_ip_ospf_database) Added.
4605 * ospf_interface.c (if_ospf_cost), (if_ospf_dead_interval),
4606 (if_ospf_hello_interval), (if_ospf_priority),
4607 (if_ospf_retransmit_interval), (if_ospf_transmit_delay)
4608 argument changed from NUMBER to <range>.
4609 DEFUN (if_ospf_network_broadcast),
4610 DEFUN (if_ospf_network_non_broadcast),
4611 DEFUN (if_ospf_network_point_to_multipoint),
4612 DEFUN (if_ospf_network_point_to_point) functions are combined to
4613 DEFUN (if_ospf_network).
4614
46151999-06-18 Toshiaki Takada <takada@zebra.org>
4616
4617 * ospf_lsa.c: ospf_add_router_lsa (), ospf_add_network_lsa (),
4618 ospf_lsa_lookup (), ospf_lsa_count () Added.
4619
46201999-06-15 Toshiaki Takada <takada@zebra.org>
4621
4622 * DEFUN (ospf_debug_ism), DEFUN (ospf_debug_nsm),
4623 DEFUN (no_ospf_debug_ism), DEFUN (no_ospf_debug_nsm) Added.
4624 `debug ospf ism' command shows debug message.
4625 `debuf ospf nsm' command shows debug message.
4626
46271999-06-14 Toshiaki Takada <takada@zebra.org>
4628
4629 * ospf_lsa.c: ospf_network_lsa () Added.
4630 ospf_lsa_checksum () Added.
4631 * DEFUN (ospf_debug_packet), DEFUN (no_ospf_debug_packet) Added.
4632 `debug ospf packet' command shows debug message.
4633
46341999-06-13 Toshiaki Takada <takada@zebra.org>
4635
4636 * ospf_packet.h: Remove struct ospf_ls_req {}, ospf_ls_upd {},
4637 ospf_ls_ack {}.
4638
46391999-06-11 Toshiaki Takada <takada@zebra.org>
4640
4641 * ospf_dump.c: fix IP packet length treatment.
4642
46431999-06-10 Toshiaki Takada <takada@zebra.org>
4644
4645 * ospf_ism.h: Add OSPF_ISM_EVENT_EXECUTE() Macro Added.
4646 * ospf_nsm.h: Add OSPF_NSM_EVENT_EXECUTE() Macro Added.
4647
4648 * ospf_packet.c: ospf_db_desc (), ospf_db_desc_send () Added.
4649 ospf_make_hello (), ospf_make_db_desc () Added.
4650 ospf_db_desc_proc () Added.n
4651
4652 * Database Description packet can be processed.
4653
46541999-06-08 Toshiaki Takada <takada@zebra.org>
4655
4656 * ospf_lsa.c: New file.
4657
46581999-06-07 Toshiaki Takada <takada@zebra.org>
4659
4660 * ospf_neighbor.c: ospf_fully_adjacent_count () Added.
4661
46621999-06-07 Kunihiro Ishiguro <kunihiro@zebra.org>
4663
4664 * ospf_spf.[ch]: New file.
4665
46661999-05-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4667
4668 * ospf_zebra.c: Changed to use lib/zclient.c routines.
4669
4670 * ospf_zebra.h (zebra_start): Remove struct zebra.
4671
46721999-05-29 Kunihiro Ishiguro <kunihiro@zebra.org>
4673
4674 * ospfd.c (ospf_config_write): Add cast (unsigned long int) to
4675 ntohl for sprintf warning.
4676
46771999-05-19 Toshiaki Takada <takada@zebra.org>
4678
4679 * ospf_ism.c (ospf_dr_election): Join AllDRouters Multicast group
4680 if interface state changes to DR or BDR.
4681
46821999-05-14 Stephen R. van den Berg <srb@cuci.nl>
4683
4684 * ospf_main.c (signal_init): SIGTERM call sigint.
4685 (sigint): Logging more better message.
4686
46871999-05-12 Toshiaki Takada <takada@zebra.org>
4688
4689 * ospfd.c: Fix bug of `no router ospf' statement, it will work.
4690
46911999-05-11 Toshiaki Takada <takada@zebra.org>
4692
4693 * ospf_neighbor.c: ospf_nbr_free () Added.
4694
46951999-05-10 Toshiaki Takada <takada@zebra.org>
4696
4697 * ospfd.h: struct ospf_area { }, struct ospf_network { } Changed.
4698 * Fix bug of `no network' statement, it will work.
4699
47001999-05-07 Toshiaki Takada <takada@zebra.org>
4701
4702 * ospf_interface.c, ospf_zebra.c: Fix bug of last interface is not
4703 updated by ospf_if_update ().
4704
47051999-04-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4706
4707 * Makefile.am (noinst_HEADERS): Add ospf_lsa.h for distribution.
4708
47091999-04-25 Toshiaki Takada <takada@zebra.org>
4710
4711 * ospf_interface.c: DEFUN (no_if_ospf_cost),
4712 DEFUN (no_if_ospf_dead_interval),
4713 DEFUN (no_if_ospf_hello_interval),
4714 DEFUN (no_if_ospf_priority),
4715 DEFUN (no_if_ospf_retransmit_interval),
4716 DEFUN (no_if_ospf_transmit_delay) Added.
4717
4718 interface_config_write () suppress showing interface
4719 default values.
4720
47211999-04-25 Kunihiro Ishiguro <kunihiro@zebra.org>
4722
4723 * ospf_dump.c (ospf_timer_dump): If thread is NULL return "inactive".
4724
4725 * ospfd.c (ospf_if_update): Fix bug of using ospf_area { } instead
4726 of ospf_network { }. So `router ospf' statement in ospfd.conf
4727 works again.
4728 (ospf_if_update): Call ospf_get_router_id for updating router ID.
4729
47301999-04-25 Toshiaki Takada <takada@zebra.org>
4731
4732 * ospf_interface.c: DEFUN (if_ospf_network) deleted.
4733 DEFUN (if_ospf_network_broadcast),
4734 DEFUN (if_ospf_network_non_broadcast),
4735 DEFUN (if_ospf_network_point_to_multipoint),
4736 DEFUN (if_ospf_network_point_to_point),
4737 DEFUN (no_if_ospf_network) Added.
4738
47391999-04-23 Toshiaki Takada <takada@zebra.org>
4740
4741 * ospfd.h: struct area { } changed to struct ospf_network { }.
4742 Add struct ospf_area { }.
4743 * ospfd.c: Add ospf_area_lookup_by_area_id (), ospf_network_new (),
4744 and ospf_network_free ().
4745 DEFUN (area_authentication), DEFUN (no_area_authentication) Added.
4746
47471999-04-22 Toshiaki Takada <takada@zebra.org>
4748
4749 * ospf_lsa.h: New file.
4750 * ospf_packet.h: LSA related struct definition are moved to
4751 ospf_lsa.h.
4752 * ospf_packet.c: ospf_verify_header () Added.
4753
47541999-04-21 Toshiaki Takada <takada@zebra.org>
4755
4756 * ospf_ism.c: ospf_elect_dr () and related function is changed.
4757 DR Election bug fixed.
4758 * ospf_dump.c: ospf_nbr_state_message (), ospf_timer_dump () Added.
4759 * ospfd.c: DEFUN (show_ip_ospf_neighbor) Added.
4760
47611999-04-19 Kunihiro Ishiguro <kunihiro@zebra.org>
4762
4763 * ospf_main.c (main): access_list_init () is added for vty
4764 connection filtering.
4765
47661999-04-16 Toshiaki Takada <takada@zebra.org>
4767
4768 * ospfd.c: DEFUN (show_ip_ospf_interface) Added.
4769 * ospf_neighbor.c: ospf_nbr_count () Added.
4770
47711999-04-15 Toshiaki Takada <takada@zebra.org>
4772
4773 * ospfd.h: struct ospf { } Changed.
4774 * ospfd.c: ospf_lookup_by_process_id () Deleted.
4775 * ospf_ism.c: ospf_wait_timer () Added. WaitTimer will work.
4776
47771999-04-14 Toshiaki Takada <takada@zebra.org>
4778
4779 * ospf_ism.c: ospf_elect_dr () Added.
4780 * ospf_network.c: ospf_if_ipmulticast () Added.
4781
47821999-04-11 Toshiaki Takada <takada@zebra.org>
4783
4784 * ospf_interface.c: interface_config_write (),
4785 DEFUN (if_ip_ospf_cost),
4786 DEFUN (if_ip_ospf_dead_interval),
4787 DEFUN (if_ip_ospf_hello_interval),
4788 DEFUN (if_ip_ospf_priority),
4789 DEFUN (if_ip_ospf_retransmit_interval) and
4790 DEFUN (if_ip_ospf_transmit_delay) Added.
4791
47921999-04-08 Toshiaki Takada <takada@zebra.org>
4793
4794 * ospf_dump.c: ospf_packet_db_desc_dump () Added.
4795 * ospf_neighbor.c: ospf_nbr_bidirectional () Added.
4796 * ospf_nsm.c: nsm_twoway_received () Added.
4797
47981999-04-02 Toshiaki Takada <takada@zebra.org>
4799
4800 * ospf_neighbor.c: New file.
4801 * ospf_neighbor.h: New file.
4802 * ospf_nsm.c: New file.
4803 * ospf_nsm.h: New file.
4804 * ospf_packet.c: Add ospf_make_header (), ospf_hello () and
4805 ospf_hello_send (). Now OSPFd can receive Hello and send Hello.
4806
48071999-03-27 Kunihiro Ishiguro <kunihiro@zebra.org>
4808
4809 * ospf_packet.c: Add ospf_recv_packet (). Now OSPF Hello can receive.
4810
48111999-03-19 Toshiaki Takada <takada@zebra.org>
4812
4813 * ospf_packet.c: New file.
4814 * ospf_packet.h: New file.
4815 * ospf_network.c: New file.
4816 * ospf_network.h: New file.
4817 * ospfd.h: move OSPF message structure has moved to ospf_packet.h.
4818
48191999-03-17 Kunihiro Ishiguro <kunihiro@zebra.org>
4820
4821 * ospf_zebra.c (ospf_zebra_get_interface): Fix for IPv6 interface
4822 address.
4823
4824 * Makefile.am (install-sysconfDATA): Overwrite install-sysconfDATA
4825 for install ospfd.conf.sample as owner read only file.
4826
4827 * ospf_main.c (usage): Change to use ZEBRA_BUG_ADDRESS.
4828
48291999-03-15 Toshiaki Takada <takada@zebra.org>
4830
4831 * ospf_ism.c: New file.
4832 * ospf_ism.h: New file.
4833 * ospf_dump.c: New file.
4834 * ospf_dump.h: New file.
4835
4836 * ospfd.h: Add (struct ospf), (struct config_network),
4837 (struct message) structure.
4838
4839 * ospf_interface.c: Add ospf_if_match_network ().
4840 * ospf_interface.h (struct ospf_interface): Change struct members.
4841
4842 * ospfd.c: ospf_lookup_by_process_id (), ospf_network_new (),
4843 DEFUN (network_area): Added.
4844
4845 * ospfd.conf.sample: Change sample configuration.
4846
48471999-03-05 Toshiaki Takada <takada@zebra.org>
4848
4849 * ospf_interface.c: New file.
4850 * ospf_interface.h: New file.
4851 * ospf_zebra.h: New file.
4852 * ospf_zebra.c: Add interface function for zebra daemon.
4853 * ospfd.c: New file.
4854
48551999-02-23 Kunihiro Ishiguro <kunihiro@zebra.org>
4856
4857 * Move IPv6 codes and files to ospf6d directory.
4858
48591999-02-18 Peter Galbavy <Peter.Galbavy@knowledge.com>
4860
4861 * syslog support added
4862
48631998-12-22 Toshiaki Takada <takada@zebra.org>
4864
4865 * ospfd.h: New file.
4866 * ospf_lsa.h: New file.
4867
48681998-12-15 Kunihiro Ishiguro <kunihiro@zebra.org>
4869
4870 * Makefile.am: New file.
4871 * ospf_main.c: New file.
4872