blob: 654c31a231a0d0f19cbcc40814133864b7b6538d [file] [log] [blame]
Paul Jakmab75ae992007-03-23 11:17:28 +000012007-03-23 Paul Jakma <paul.jakma@sun.com>
2
3 * ospf_spf.c: (various) Add more debug statements.
Paul Jakma85ef7842007-03-23 11:19:08 +00004 (ospf_nexthop_calculation) Fix silly regression causing ospfd
5 to fail to calculate paths past networks not attached to root
6 vertex, introduced with bug #330 fixes.
Paul Jakmab75ae992007-03-23 11:17:28 +00007
Andrew J. Schorr56b3ea02007-03-14 20:21:43 +000082007-03-14 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
9
Andrew J. Schorrad81f8c2007-03-14 22:05:18 +000010 * ospf_snmp.c: (ospf_snmp_neighbor_state) New function to
11 map internal quagga neighbor states to SNMP standard values.
12 (ospfNbrEntry) Call new ospf_snmp_neighbor_state function.
13
142007-03-14 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
15
Andrew J. Schorr56b3ea02007-03-14 20:21:43 +000016 * ospf_zebra.c: (ospf_zebra_add, ospf_zebra_delete) Fix bug
17 where inet_ntoa was used twice in the same debug message,
18 which doesn't work because there's a single shared buffer
19 for the returned string. The fix is to use inet_ntop.
20
Andrew J. Schorr4056a542007-02-27 13:55:46 +0000212007-02-27 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
22
23 * ospfd.c: (ospf_terminate) Exit immediately if ospf is not
24 actually running (e.g. the config file was empty). Fixes
25 bug where SIGTERM would not kill ospfd.
26
Paul Jakmabd34fb32007-02-26 17:14:48 +0000272007-02-26 Paul Jakma <paul.jakma@sun.com>
28
29 * ospf_spf.c: Fix regression introduced with bug #330 fix: The
30 cost update added to ospf_spf_add_parent only handled PtP
31 case, differing from same functionality in higher-level
32 ospf_spf_next. Regression diagnosed by Anders Pedersen,
33 mailnews+router-quagga-dev@news.cohaesio.com.
34 (ospf_vertex_new) Initialise vertices to max-cost.
35 (ospf_spf_init) Root vertex always creates with 0 cost.
36 (ospf_spf_add_parent) Remove the buggy V->W cost calculating
37 code, instead take the new distance as a parameter.
38 (ospf_nexthop_calculation) Take distance as parameter, so it
39 can be passed down to add_parent.
40 (ospf_spf_next) Dont initialise candiate vertex distance,
41 vertex_new does so already. Pass distance down to
42 nexthop_calculation (see above).
43
Paul Jakmabc20c1a2007-01-24 14:51:51 +0000442007-01-24 Paul Jakma <paul.jakma@sun.com>
45
46 * ospf_spf.c: Bug #330: Nexthop calculation sometimes may fail,
47 and it needs to indicate this result to SPF.
48 (ospf_spf_add_parent) Flush of parent list needs to be done here,
49 for simplicity.
50 (ospf_nexthop_calculation) Caller needs to know whether
51 nexthop calculation succeeded. Every return statement must
52 correctly indicate such.
53 (ospf_spf_next) Queueing/prioritisation of vertices in SPF
54 must take into account whether nexthop_calculation succeeded,
55 or SPF may fail to find best paths.
56
Andrew J. Schorre4529632006-12-12 19:18:21 +0000572006-12-12 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
58
59 * ospf_interface.c: (ospf_if_is_configured, ospf_if_lookup_by_prefix,
60 ospf_if_lookup_recv_if) Simplify logic using new CONNECTED_PREFIX
61 macro.
62 * ospf_lsa.c: (lsa_link_ptop_set) Using the new CONNECTED_PREFIX
63 macro, both options collapse into the same code.
64 * ospf_snmp.c: (ospf_snmp_if_update) Simplify logic using new
65 CONNECTED_ID macro.
66 (ospf_snmp_is_if_have_addr) Simplify logic using new CONNECTED_PREFIX
67 macro.
68 * ospf_vty.c: (show_ip_ospf_interface_sub) Use new CONNECTED_PEER macro
69 instead of testing the IFF_POINTOPOINT flag.
70 * ospfd.c: (ospf_network_match_iface) Use new CONNECTED_PEER macro
71 instead of testing with if_is_pointopoint. And add commented-out
72 code to implement alternative (in my opinion) more elegant behavior
73 that has no special-case treatment for PtP addresses.
74 (ospf_network_run) Use new CONNECTED_ID macro to simplify logic.
75
Andrew J. Schorred589c12006-12-04 18:26:37 +0000762006-12-04 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
77
78 * ospfd.c: (ospf_network_run) Remove an offending 'break' statement.
79 Previously, after creating a single ospf_interface on a given
80 network interface, the code would skip to the next interface
81 without considering other connected addresses on the interface.
82 After removing the 'break', we now consider all connected addresses.
83
Andrew J. Schorr7f643eb2006-11-30 16:17:02 +0000842006-11-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
85
86 * ospf_zebra.c: (ospf_router_id_update_zebra,
87 ospf_interface_address_add, ospf_interface_address_delete)
88 If (IS_DEBUG_OSPF (zebra, ZEBRA_INTERFACE)) is enabled, then
89 add a debug message about what Zebra is telling us.
90 (ospf_zebra_add_discard) Add a debug message matching the one
91 already in ospf_zebra_delete_discard.
92
Andrew J. Schorr43540882006-11-28 16:36:39 +0000932006-11-28 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
94
95 * ospf_vty.c: (ospf_passive_interface_default) Take additional
96 'newval' arg so we can update ospf->passive_interface_default inside
97 this function. More importantly, we now call ospf_if_set_multicast
98 on all ospf_interfaces.
99 (ospf_passive_interface, no_ospf_passive_interface) Fix bug:
100 for 'default' case, argv[0] is undefined, so we must test for
101 (argc == 0) before using argv[0]. And since
102 ospf_passive_interface_default now calls ospf_if_set_multicast as
103 needed, we can just return after calling
104 ospf_passive_interface_default.
105
Andrew J. Schorr8fb8a502006-10-24 19:04:26 +00001062006-10-24 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
107
108 * ospf_zebra.c: (ospf_redistribute_default_set) Fix bug where
109 a new value for ospf->default_originate was being ignored
110 if a previous 'default-information originate' command
111 had already been processed.
112
Paul Jakma7ffa8fa2006-10-22 20:07:53 +00001132006-10-22 Yar Tikhiy <yar@comp.chem.msu.su>
114
115 * (general) Add support for passive-interface default (with
116 minor edits by Paul Jakma).
117 * ospf_interface.h: Add OSPF_IF_PASSIVE_STATUS macro, looking
118 at configured value, or the global 'default' value, as
119 required.
120 * ospf_interface.c: (ospf_if_new_hook) Leave passive
121 unconfigured per default, allowing global 'default' to
122 take effect for unconfigured interfaces.
123 * ospf_packet.c: (various) use OSPF_IF_PASSIVE_STATUS
124 * ospf_vty.c: (ospf_passive_interface_default) new function,
125 unset passive from all interfaces if default is enabled, as
126 the per-iface settings become redundant.
127 (ospf_passive_interface_update) new func, update passive
128 setting taking global default into account.
129 ({no,}ospf_passive_interface_addr_cmd) Add support for
130 'default' variant of command.
131 (show_ip_ospf_interface_sub) Update to take global
132 default into account when printing passive status.
133 (ospf_config_write) ditto.
134 * ospfd.c: (ospf_new) set global passive-interface default.
135 * ospfd.h: (struct ospf) Add field for global
136 passive-interface.
137
Andrew J. Schorr08c83672006-09-25 13:26:14 +00001382006-09-25 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
139
140 * ospf_packet.c: (ospf_packet_dup, ospf_make_md5_digest)
141 Fix zlog_warn messages to eliminate compiler warnings.
142 (ospf_hello) Improve warning messages to show why we
143 are complaining.
144
Paul Jakmab5aeb442006-08-30 18:47:37 +00001452006-08-28 Andy Gay <andy@andynet.net>
146
147 * ospf_packet.c: (ospf_make_db_desc) Assert added with More-bit
148 fixes does not hold up with addition of Ogier DB-Exchange
149 optimisation, which can empty the db-summary list in between
150 sent DD packets. Remove assert, update More-bit always when
151 in Exchange.
152
Paul Jakma29b5a042006-08-27 08:01:20 +00001532006-08-27 J.J. Krabbendam <jkrabbendam@aimsys.nl>
154
155 * ospfd.c: (ospf_finish_final) default redistribute should be
156 unset too, fixes bug where reconfiguring ospfd completely
157 can no longer enable default redistribution.
158
Paul Jakma2518efd2006-08-27 06:49:29 +00001592006-08-25 Paul Jakma <paul.jakma@sun.com>
160
161 * (general) Bug #134. Be more robust to backward time changes,
162 use the newly added libzebra time functions.
163 In most cases: recent_time -> recent_relative_time()
164 gettimeofday -> quagga_gettime (QUAGGA_CLK_MONOTONIC, ..)
165 time -> quagga_time.
166 (ospf_make_md5_digest) time() call deliberately not changed.
167 (ospf_external_lsa_refresh) remove useless gettimeofday, LSA
168 tv_orig time was already set in ospf_lsa_new, called via
169 ospf_external_lsa_new.
170
Paul Jakmaba122e72006-08-27 06:24:34 +00001712006-08-04 Paul Jakma <paul.jakma@sun.com>
172
173 * ospf_lsdb.c: (ospf_lsdb_delete_entry) new function, consolidate
174 exact same functionality replicated in other functions.
175 (ospf_lsdb_add) Strip out code by using ospf_lsdb_delete_entry.
176 (ospf_lsdb_delete) ditto.
177 (ospf_lsdb_delete_all) ditto.
178
Paul Jakma8dd24ee2006-08-27 06:29:30 +00001792006-08-03 Paul Jakma <paul.jakma@sun.com>
180
181 * ospf_packet.c: (ospf_make_db_desc) Unset the DD More bit
182 after constructing the packet, if appropriate.
183 (ospf_db_desc_proc) Speed up Exchange, slave should raise
184 ExchangeDone earlier, as RFC mandates, by forming its reply
185 before deciding whether both sides are done, avoids a
186 needless round of empty DD packet exchanges at the end of
187 Exchange, hence speeding up ExchangeDone.
Paul Jakmaf0894cf2006-08-27 06:40:04 +0000188 Implement draft-ogier-ospf-dbex-opt DB-exchange optimisation.
Paul Jakma8dd24ee2006-08-27 06:29:30 +0000189 (ospf_db_desc) use UNSET_FLAG macro.
190
Andrew J. Schorr16700082006-07-27 22:29:06 +00001912006-07-27 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
192
193 * ospfd.c: (ospf_router_id_update) Fix and document the algorithm for
194 selecting the router ID: if there is not a statically configured ID,
195 then stick to the most recent value to avoid disruptive changes.
196 This should fix bug #288.
197
Paul Jakma1fe6ed32006-07-26 09:37:26 +00001982006-07-26 Paul Jakma <paul.jakma@sun.com>
199
200 * ospf_lsa.{c,h}: (ospf_lsa_unlock) Change to take a double pointer
201 to the LSA to be 'unlocked', so that, if the LSA is freed, the
202 callers pointer to the LSA can be NULLed out, allowing any further
203 use of that pointer to provoke a crash sooner rather than later.
204 * ospf_*.c: (general) Adjust callers of ospf_lsa_unlock to match
205 previous. Try annotate 'locking' somewhat to show which 'locks'
206 are protecting what LSA reference, if not obvious.
207 * ospf_opaque.c: (ospf_opaque_lsa_install) Trivial: remove useless
208 goto, replace with return.
209 * ospf_packet.c: (ospf_make_ls_ack) Trivial: merge two list loops,
210 the dual-loop predated the delete-safe list-loop macro.
211
Paul Jakma3fed4162006-07-25 20:44:12 +00002122006-07-25 Paul Jakma <paul.jakma@sun.com>
213
214 * ospf_neigbor.h: (struct ospf_neighbor) Add some additional
215 neighbour state statistics fields, timestamps for progressive
216 and regressive state changes, and pointer to event string
217 for the latter state change.
218 * ospf_nsm.c: (nsm_notice_state_change) Update new state changs
219 history as required.
220 * ospf_vty.c: (show_ip_ospf_neighbor_detail_sub) Print out above
221 new per-neighbour state change stats.
222
Paul Jakma539e1522006-07-11 17:49:22 +00002232006-07-10 Paul Jakma <paul.jakma@sun.com>
224
225 * ospf_nsm.c: (nsm_change_state) call nsm_clear_adj for all
226 adjacency losses, hence removing need for nsm_reset_nbr.
227 (nsm_reset_nbr) kill it, clear_adj in previous does fine.
228 (nsm_kill_nbr,nsm_start) remove nsm_reset_nbr call.
229 (ospf_nsm_event) Allow NSM function to be NULL, this along with
230 removal of nsm_reset_nbr, allows a bunch of now useless functiosn
231 to be removed.
232 Remove some useless variables.
233 (nsm_ignore) now useless, remove.
234 (nsm_bad_ls_req) ditto
235 (nsm_seq_number_mismatch) "
236 (nsm_oneway_received) "
237 (nsm_inactivity_timer) "
238 (nsm_ll_down) "
239 (NSM) replace removed action functions with NULL.
Paul Jakma3d63f382006-07-11 17:52:53 +0000240 (nsm_notice_state_changes) Move state change logging code to new
241 func to declutter nsm_change_state and ospf_nsm_event.
242 Log event with AdjChange, it's useful to know.
243 (nsm_change_state) move adjchange and snmp logging to previous.
244 (ospf_nsm_event) call nsm_notice_state_changes from here.
245 Move the debug message to entry of function, so it gets out
246 even if something goes wrong.
Paul Jakma90c33172006-07-11 17:57:25 +0000247 Record state change timestamp and event in nbr struct.
248 * ospf_neighbor.h: (struct ospf_neighbor) Add fields to record
249 timestamp of last NSM change and event.
250 * ospf_vty.c: (show_ip_ospf_neighbor_detail_sub) Print
251 last state change timestamp and event, if available.
Paul Jakma539e1522006-07-11 17:49:22 +0000252
Andrew J. Schorr13cd3dc2006-07-11 01:50:30 +00002532006-07-10 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
254
255 * ospf_packet.c: (ospf_hello) Improve NetworkMask mismatch warning
256 message to include interface name and conflicting prefix lengths.
257
Paul Jakma1f2c2742006-07-10 07:45:13 +00002582006-07-07 Paul Jakma <paul.jakma@sun.com>
259
260 * ospf_nsm.h: Add a NSM_Deleted neighbour state, to act as dummy
261 state indicating the neighbour is to be deleted.
262 * ospf_nsm.c: (general) Use the NSM_Deleted state to delete
263 neighbours, thus allowing code to be slightly more obvious
264 in its flow.
265 (nsm_timer_set) Add NSM_Deleted. Add another timer the code
266 missed.
267 (nsm_kill_nbr) No need for special case call to nsm_change_state
268 anymore.
269 Make the assert and error-handling for same case more readable
270 (Andrew Schorr)
271 Remove the call to ospf_nbr_delete, nsm_change_state can do
272 this generally now via NSM_Deleted.
273 (struct ... NSM) Add the dummy NSM_Deleted state, the 3 events
274 that can lead to nsm_kill_nbr all now transition the NBR to
275 NSM_Deleted and the general change_state function can be left
276 to do the work.
277 (ospf_nsm_event) Special casing of events and early-return can
278 be removed now.
279 On transition into Deleted, delete the nbr.
280 * ospf_dump.c: (ospf_nsm_state_msg) Add Deleted.
281
Paul Jakmaaa2737a2006-07-06 11:12:39 +00002822006-07-06 Paul Jakma <paul.jakma@sun.com>
283
284 * ospf_nsm.c: (ospf_nsm_event) LLDown event also results in nbr
285 being deleted, requires early-return too. Likely explains
286 some crash reports after interface events.
287
Paul Jakmaf7a76ab2006-07-04 13:57:49 +00002882006-07-04 Paul Jakma <paul.jakma@sun.com>
289
290 * ospf_nsm.c: (general) Various small cleanups from Andrew's
291 review of last set of patches.
292 (nsm_timer_set) Loading, Full and default can share
293 same code too.
294 (nsm_should_adj) Can just be one big OR.
295 (nsm_twoway_received) Collapse into return statement.
296
Paul Jakmad7b0fb62006-07-04 13:35:24 +00002972006-07-02 Paul Jakma <paul.jakma@sun.com>
298
299 * ospf_nsm.c: (nsm_should_adj) New function, just consolidate the
300 10.4 adjacency check from nsm_twoway_received/nsm_adj_ok.
301 (nsm_twoway_received/nsm_adj_ok) Use former.
Paul Jakmad1b1cd82006-07-04 13:50:44 +0000302 (nsm_clear_adj) clear adjacency related state for a
303 neighbour, needed for some state changes from > ExStart down
304 to ExStart or less, which need not go through nsm_reset_nbr.
305 (nsm_reset_nbr) move code to former. Should be static.
Paul Jakmaba0beb42006-07-04 13:44:19 +0000306 (ospf_nsm_event) Don't allow action functions to change
307 next_state if the NSM tables do not indicate next_state is
308 conditional, log warning if one tries - existing code
309 appears fine though.
Paul Jakmad1b1cd82006-07-04 13:50:44 +0000310 Remove long dead code.
311 Use nsm_clear_adj for state changes that take down
312 adjacencies to TwoWay/ExStart.
Paul Jakmae55dd532006-07-04 13:46:14 +0000313 (nsm_timer_set) ls_req timer should be OFF in early states.
314 Compact several identical sections.
315 Set inactivity timer to OFF for Down, for documentary
316 purposes.
Paul Jakmad1b1cd82006-07-04 13:50:44 +0000317 (nsm_kill_nbr) Oops, action function shouldn't try return
318 1 for error.
Paul Jakma5db95bc2006-07-04 13:52:29 +0000319 * ospf_lsa.c: (ospf_translated_nssa_refresh) CID #13.
Paul Jakmad7b0fb62006-07-04 13:35:24 +0000320
Andrew J. Schorr1c066bf2006-06-30 16:53:47 +00003212006-06-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
322
323 * ospf_vty.c: (show_ip_ospf_neighbor_id) Should show all instances
324 of that neighbor (since it may appear on multiple interfaces)
325 instead of bailing out after showing the first match.
326
Andrew J. Schorr76947872006-06-30 03:21:05 +00003272006-06-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
328
329 * ospf_nsm.c: (nsm_twoway_received) When deciding whether to
330 change from state Init to ExStart, the test for whether the
331 neighboring router is DR or BDR should be against the
332 local router's notion of DR/BDR, not the neighbor's view.
333
Andrew J. Schorrd7e60dd2006-06-29 20:20:52 +00003342006-06-28 Erik Muller <erikm@internap.com>
335
336 * ospfd.h: Define 2 new struct ospf config flags:
337 OSPF_LOG_ADJACENCY_CHANGES and OSPF_LOG_ADJACENCY_DETAIL
338 * ospf_nsm.c (nsm_change_state): Log adjacency changes if
339 requested.
340 * ospf_vty.c (ospf_log_adjacency_changes): New command function
341 to implement ospf subcommand "log-adjacency-changes [detail]".
342 (no_ospf_log_adjacency_changes) Turn off log-adjacency-changes.
343 (show_ip_ospf) Show whether adjacency changes are logged.
344 (ospf_config_write) Add "log-adjacency-changes [detail]" to config.
345 (ospf_vty_init) Add ospf_log_adjacency_changes and
346 no_ospf_log_adjacency_changes.
347
Paul Jakma9560fa82006-06-26 12:50:06 +00003482006-06-26 Paul Jakma <paul.jakma@sun.com>
349
350 * ospf_abr.c: (general) NSSA translate-candidate ABRs need to
351 be ASBRs, or other routers may rightfully refuse to install
352 translated type-5s LSAs. reported by dendroot@gmail.com.
353 (ospf_abr_nssa_check_status) Detect change in translator
354 state when ABR, and inc/dec redistribute count as when we
355 leave/enter the disabled state - so that translate-enabled
356 ABR properly sets ASBR bit on non-NSSA areas.
357 Run the resulting function through indent to clean it up.
358 * ospf_lsa.c: (router_lsa_flags) For purposes of ASBR bit,
359 NSSA area is same as stub area.
360
Andrew J. Schorr0ffb7092006-06-24 19:40:13 +00003612006-06-24 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
362
Andrew J. Schorr9aecfae2006-06-24 20:05:02 +0000363 * ospf_snmp.c: (ospfTrapNbrStateChange, ospfTrapIfStateChange) Improve
364 info log message to indicate why the trap is being sent.
365
3662006-06-24 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
367
Andrew J. Schorr0ffb7092006-06-24 19:40:13 +0000368 * ospf_dump.c: (config_write_debug) Fix typo to show debug ospf nsm
369 status properly (not ism status).
370
Andrew J. Schorr6e72cb62006-06-18 00:45:48 +00003712006-06-17 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
372
373 * ospf_vty.c: ({no_,}ospf_passive_interface) Replace if_lookup_by_name
374 with a call to if_get_by_name -- if the interface does not exist
375 already, it should be created. And remove the obsolete warning
376 message.
377
Paul Jakma429ac782006-06-15 18:40:49 +00003782006-06-15 Paul Jakma <paul.jakma@sun.com>
379
380 * ospf_interface.h: (struct ospf_if_info) Add reference counts
381 for multicast group memberships. Add various macros to help
382 manipulate/check membership state.
383 * ospf_interface.c: (ospf_if_set_multicast) Maintain the
384 ospf_if_info reference counts, and only actually drop
385 memberships if it hits 0, to avoid losing membership when
386 OSPF is disabled on an interface with multiple active OSPF
387 interfaces.
388 * ospf_packet.c: (ospf_{hello,read}) Use the new macros to
389 check/set
390 multicast membership.
391 * ospf_vty.c: (show_ip_ospf_interface_sub) ditto.
392
Paul Jakmaac904de2006-06-15 12:04:57 +00003932006-05-31 Paul Jakma <paul.jakma@sun.com>
394
395 * ospf_lsdb.c: (ospf_lsdb_delete) robustify against NULL arguments,
396 print warning.
397 * ospf_lsa.c: (ospf_discard_from_db) ditto.
398 (ospf_maxage_lsa_remover) Check lsa->lsdb for validity, possible
399 mitigation (but not solution) for bug #269.
400
Paul Jakma88871b12006-06-15 11:41:19 +00004012006-05-30 Paul Jakma <paul.jakma@sun.com>
402
403 * ospf_packet.c: (ospf_read) Debug message about packets
404 received on unenabled interfaces should be conditional on
405 debug being set.
406
Paul Jakmad1c65c22006-06-27 08:01:43 +00004072006-05-23 Paul Jakma <paul.jakma@sun.com>
408
409 * ospf_vty.c: (general) Replace in-place route redistribution
410 command and help strings with the new auto-generated defines
411 from lib/route_types.h
412
Paul Jakmaae128052006-05-12 23:15:30 +00004132006-05-13 Paul Jakma <paul.jakma@sun.com>
414
415 * ospf_lsa.c: (ospf_translated_nssa_refresh) fix the sanity
416 check to match the assert, small error in CID #13 fix.
417
Paul Jakma70461d72006-05-12 22:57:57 +00004182006-05-12 Paul Jakma <paul.jakma@sun.com>
419
420 * ospf_lsa.c: (ospf_lsa_action) Get rid of the ospf_lookup
421 call, which is not checked for NULL return, by stripping out
422 functionality which is never used, hence fixing Coverity CID
423 #29.
424 (struct lsa_action) remove unused member.
Paul Jakmae54e6e52006-05-12 23:11:14 +0000425 (ospf_translated_nssa_refresh) Add non-assert sanity check,
426 in case DEBUG isn't defined.
427 Debug message when no type7 exists should print the ID from
428 the type5, not the type7, fixes CID #13.
429 * ospf_interface.c: (ospf_if_exists) Fix missing NULL return
Paul Jakmae43be0e2006-05-12 23:00:06 +0000430 check on ospf_lookup, CID #27.
Paul Jakma6db3a6f2006-05-12 23:02:46 +0000431 * ospf_asbr.c: (ospf_redistribute_withdraw) remove ospf_lookup
432 call by taking the struct ospf * as argument, which the
433 caller has, fixing CID #28.
434 * ospf_asbr.h: (ospf_redistribute_withdraw) update declaration
435 * ospf_zebra.c: (ospf_redistribute_unset) update call to
436 ospf_redistribute_withdraw to match.
Paul Jakmabfd7c7d2006-05-12 23:04:45 +0000437 * ospf_ia.c: (ospf_update_router_route) ospf->backbone could be
438 NULL when passed to ospf_find_asbr_route_through_area,
439 check for NULL first, CID #14.
Paul Jakmadeb15612006-05-12 23:07:27 +0000440 * ospf_ism.c: (ism_change_state) NULL check on oi->area is
441 useless, it's always valid. Only possibility where it
442 couldn't be is if there is a race between abr_task and
443 cleaning up oi's, in which case a NULL check here isn't going
444 to do anything. Fixes CID #15.
Paul Jakma70461d72006-05-12 22:57:57 +0000445
Paul Jakmacac3b5c2006-05-11 13:31:11 +00004462006-05-11 Paul Jakma <paul.jakma@sun.com>
447
448 * ospf_vty.c: (general) Audit ospf_lookup calls in commands,
449 ensure check for NULL result, make vty messages consistent.
450 (show_ip_ospf_interface) Missing NULL check on ospf_lookup
451 result, fixes Coverity CID #70.
Paul Jakma1a8ec2b2006-05-11 13:34:08 +0000452 (no_ospf_area_filter_list) Check NULL result from
453 ospf_area_lookup_by_area_id, fixes Coverity CID #69
Paul Jakma894f8b62006-05-12 22:50:40 +0000454 * ospf_route.c: (ospf_route_delete_same_ext) Fix deref before
455 NULL check by moving into check-protected block, fix CID #49.
Paul Jakma214a4452006-05-12 22:51:49 +0000456 * ospf_abr.c: (ospf_area_range_cost_set) Shouldn't create a new
457 range, should just lookup to see if one exists, the new range
458 is just leaked. Fixes CID #46.
Paul Jakma4021b602006-05-12 22:55:41 +0000459 * ospf_lsa.c: (ospf_default_originate_timer) Let the thread
460 take (struct ospf *) as thread argument, rather than (struct
461 ospf *)->default_originate, thus avoiding having to call
462 ospf_lookup.
463 * ospf_zebra.c: (ospf_redistribute_default_set) change setup
464 of ospf_default_originate_timer thread to match.
465 * ospfd.c: (ospf_router_id_update) ditto.
Paul Jakmacac3b5c2006-05-11 13:31:11 +0000466
Paul Jakma9c27ef92006-05-04 07:32:57 +00004672006-04-24 Paul Jakma <paul.jakma@sun.com>
468
469 * (general) More Virtual-link fixes, again with much help in
470 testing / debug from Juergen Kammer. Primarily in SPF.
471 * ospf_spf.h: Add guard. ospf_interface.h will include this
472 header.
473 * ospf_interface.h: Modify ospf_vl_lookup definition to take
474 struct ospf as argument, so as to allow for NULL area
475 argument.
476 (struct ospf_vl_data) Remove out_oi, instead add a struct
477 vertex_nexthop, to use as initial nexthop for backbone paths
478 through a vlink.
479 * ospf_interface.c: (ospf_vl_lookup) Modified to allow
480 NULL area to be passed to indicate "any" (first) area.
481 Add extra debug.
482 (ospf_vl_set_params) vl_oi -> nexthop. Add extra debug.
483 (ospf_vl_up_check) Fix debug, inet_ntoa returns a static
484 buffer..
485 * ospf_route.c: (ospf_intra_add_router) Vlinks dont go through
486 backbone, don't bother checking.
487 * ospf_spf.c: (static struct list vertex_list) Record vertices
488 that will need to be freed.
489 (cmp) Order network before router vertices, as required,
490 wasn't implemented.
491 (vertex_nexthop_free) Mild additional robustness check.
492 (vertex_parent_free) Take void argument, as this function
493 is passed as list deconstructor for vertex parent list.
494 (ospf_vertex_new) More debug. Set deconstructor for parent
495 list. Track allocated vertices on the vertex_list.
496 (ospf_vertex_free) Get rid of the tricky recursive cleanup of
497 vertices. Now frees only the given vertex.
498 (ospf_vertex_add_parent) Fix assert.
499 (ospf_nexthop_calculation) Fix calculation of nexthop for
500 VLink vertices, lookup the vl_data and use its previously
501 recorded nexthop information.
502 (ospf_spf_calculate) Vertices are freed simply by deleting
503 vertex_list nodes and letting ospf_vertex_free as deconstructor
504 work per-node.
505 (ospf_spf_calculate_timer) Trivial optimisation, leave
506 backbone SPF calculation till last to reduce SPF churn on
507 VLink updates.
508 * ospf_vty.c: (ospf_find_vl_data) update call to ospf_vl_lookup
509 (no_ospf_area_vlink_cmd) ditto.
510 (show_ip_ospf_interface_sub) For Vlinks, the peer address is
511 more interesting than the output interface.
512
Paul Jakma478aab92006-04-03 21:25:32 +00005132006-04-03 Paul Jakma <paul.jakma@sun.com>
514
515 * (general) Fix issues with handling of Vlinks and entries
516 in the nbrs route-table which were highlighted by the
517 nsm/nbr_self fixes from bug #234. Many thanks to Juergen
518 Kammer for his help and efforts in testing out debug patches to
519 pinpoint the issue.
520 * ospf_interface.c: (ospf_vl_new) Add nbr_self for Vlink.
521 * ospf_neighbor.c: (ospf_nbr_key) new static function, helper
522 to create key in nbrs table for a given nbr.
523 (ospf_nbr_delete) Use ospf_nbr_key. Add an assert() to
524 document an expected state.
525 (ospf_nbr_add_self) Ditto.
526 (ospf_nbr_lookup_by_addr) Add an assert.
527 * ospf_nsm.c: (nsm_kill_nbr) Can never kill the nbr_self
528 psuedo-neighbour.
529
Paul Jakma075c2012006-03-30 14:34:31 +00005302006-03-27 Paul Jakma <paul.jakma@sun.com>
531
532 * ospf_lsa.c: (ospf_lsa_checksum) Add an explicit cast to avoid
533 the ambiguities of ANSI and C99 C with respect to type
534 conversion. Detailed problem report and test case with
535 example data supplied by Dmitry Ivanov <dimss@telecentrs.lv>.
536
Paul Jakma1a8ee0e2006-03-30 14:20:00 +00005372006-03-25 Paul Jakma <paul.jakma@sun.com>
538
539 * ospf_interface.c: (ospf_if_lookup_recv_if) Ignore loopbacks,
540 we can never ever receive packets on those. Should fix
541 case where CARP is run with address in same subnet as real
542 interface. Problem report and diagnosis thanks to:
543 Landon Fuller <landonf@opendarwin.org>.
544 However, ospf_read() still can't deal deterministically with
545 multiple interfaces in same subnet.
546
Paul Jakmac2b478d2006-03-30 14:16:11 +00005472006-03-23 Steve Lawson <steve.lawson@aheadcomusa.com>
548
549 * ospf_lsa.c: (ospf_lsa_install) Fix incorrect byte-order
550 conversion of OSPF_MAX_SEQUENCE_NUMBER
551
paule8e19462006-01-19 20:16:55 +00005522006-01-19 Paul Jakma <paul.jakma@sun.com>
553
554 * (general) various miscellaneous compiler warning fixes.
555 Remove redundant break statements from switch clauses
556 which return.
557 return from main, not exit, cause it annoys SOS.
558 Remove stray semi-colons which cause empty-statement
559 warnings.
560
paul779adb02006-01-18 15:07:38 +00005612006-01-18 Juergen Kammer <j.kammer@eurodata.de>
562
563 * ospf_lsa.c: (ospf_router_lsa_new) dont take reference to the
564 stream data until it is constructed, data reference is
565 volatile due to the potential resize in link_info_set
566
5672006-01-18 Paul Jakma <paul.jakma@sun.com>
568
569 * ospf_lsa.c: (link_info_set) Resize the stream if required and
570 possible. Return number of links added.
571 (lsa_link_*_set) use return value from previous.
572 * ospf_lsa.h: Add OSPF_ROUTER_LSA_LINK_SIZE define.
573
paulc6371712006-01-17 17:49:53 +00005742006-01-17 Paul Jakma <paul.jakma@sun.com>
575
576 * ospf_packet.c: (ospf_verify_header) print out the types
577 involved if there's a mismatch.
578 * ospf_zebra.c: (ospf_zebra_add) Adjust to new zserv format.
579
paul818e56c2006-01-10 23:27:05 +00005802006-01-10 Len Sorensen <lennartsorensen@ruggedcom.com>
581
582 * (general) Bug #234, see also [quagga-dev 3902].
583 Fix problem with nbr_self not being properly reinitialised
584 when an interface comes up, after having been down.
paul1a643f82006-01-11 01:08:19 +0000585 Some re-arrangement done by Paul Jakma, any bugs introduced
586 on top of Len's suggested changes are his.
paul818e56c2006-01-10 23:27:05 +0000587 * ospf_neighbor.c: (ospf_nbr_add_self) centralise
588 initialisation of nbr_self parameters here.
589 * ospf_interface.c: (ospf_if_new) deleting initialisation of
590 parameters of nbr_self, just rely on call to
591 ospf_nbr_add_self.
592 (ospf_if_cleanup) ditto.
593 * ospfd.c: (ospf_network_run) ditto.
594
paul98429f62006-01-10 22:11:54 +00005952006-01-10 Juris Kalnins <juris@mt.lv>
596
597 * ospf_zebra.c: (ospf_interface_address_delete) fix rare leak of
598 struct connected in an error case.
paul818e56c2006-01-10 23:27:05 +0000599 * ospf_packet.c: (ospf_make_md5_digest) fix odd, if not
600 undefined effect, assignment of an increment expression.
paul98429f62006-01-10 22:11:54 +0000601
paul86752842006-01-10 20:34:46 +00006022006-01-10 Paul Jakma <paul.jakma@sun.com>
603
604 * ospfd.c: (ospf_network_run) checking to see if router-id
605 is set should be on ospf->router_id, not router_id_static.
606 This was causing ospfd to not start if router-id had not
607 been configured statically.
608 (ospf_if_update) ditto.
paulc42c1772006-01-10 20:36:49 +0000609 * ospf_vty.c: (config_write_ospf_distribute) trim down
610 redundant strings.
paul86752842006-01-10 20:34:46 +0000611
paul00c290e2005-11-26 09:21:43 +00006122005-11-26 Paul Jakma <paul.jakma@sun.com>
613
614 * ospf_api.c: (struct opaque_lsa) change from gcc zero-length
615 array to C99 incomplete type array.
paulc9c93d52005-11-26 13:31:11 +0000616 * (general) s/graceful/deferred/ in all files, the former term
617 is confusing wrt OSPF Graceful-Restart.
618 * ospfd.c: (ospf_deferred_shutdown_check) dont return
619 a function which returns void. SOS complains about this.
620 (ospf_finish)
paul00c290e2005-11-26 09:21:43 +0000621
paulb29800a2005-11-20 14:50:45 +00006222005-11-20 Paul Jakma <paul.jakma@sun.com>
623
624 * ospfd.h: remove the OSPF_ROUTER_ID_UPDATE_DELAY define
625 (struct ospf) remove the router_id timer thread.
626 remove export of ospf_router_id_update_timer.
627 * ospfd.c: (ospf_router_id_update) call ospf_if_update to
628 poke interfaces into action after ID has been configured.
629 (ospf_router_id_update_timer) removed.
630 (ospf_finish_final) t_router_id_update timer is gone.
631 (ospf_network_run) router-id update timer gone.
632 call ospf_router_id_update directly if ID not configured.
633 In the per-iface loop, don't ospf_if_up interfaces if
634 ID is still not configured. The update function will call
635 ospf_if_update anyway.
636 (ospf_if_update) ID update timer is gone. Just return if no
637 ID is set.
638 * ospf_vty.c: (ospf_router_id) call ospf_router_id_update, no
639 timer needed.
640 * ospf_zebra.c: (ospf_router_id_update_zebra) call
641 ospf_router_id_update directly, not via timer.
paulc24d6022005-11-20 14:54:12 +0000642 * ospf_abr.c: (ospf_abr_announce_network_to_area) check
643 returned LSA of ospf_summary_lsa_refresh and print warning if
644 it failed.
645 (ospf_abr_announce_network_to_area) similar
646 (ospf_abr_announce_rtr_to_area) similar
647 * ospf_lsa.c: (ospf_router_lsa_new) check LSA returned is valid.
648 (ospf_router_lsa_originate) similar
649 (ospf_router_lsa_refresh, ospf_network_lsa_new) similar
650 (ospf_summary_lsa_new) Check ID is valid.
651 (ospf_summary_lsa_originate) ditto, and check returned LSA from
652 previous function is !NULL.
653 (ospf_summary_lsa_refresh) check ospf_summary_lsa_new return
654 is !NULL.
655 (ospf_summary_asbr_lsa_new) ID valid check.
656 (ospf_summary_asbr_lsa_originate) similar.
paulb29800a2005-11-20 14:50:45 +0000657
ajs70cd3472005-11-16 19:33:22 +00006582005-11-16 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
659
ajs649654a2005-11-16 20:17:52 +0000660 * ospf_dump.h: Define OSPF_TIME_DUMP_SIZE as appropriate buffer size
661 for use with ospf_timer_dump and ospf_timeval_dump.
662 * ospf_vty.c: Change all buffer sizes used with ospf_timer_dump and
663 ospf_timeval_dump to have size OSPF_TIME_DUMP_SIZE.
664 (show_ip_ospf_interface_sub) Fix possible buffer overflow in
665 call to ospf_timer_dump.
666
6672005-11-16 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
668
ajs70cd3472005-11-16 19:33:22 +0000669 * ospf_ism.h: (OSPF_ISM_TIMER_OFF) Improve macro syntax by enclosing
670 in 'do {...} while(0)'.
671
paul31a59762005-11-14 11:11:11 +00006722005-11-14 Paul Jakma <paul.jakma@sun.com>
673
674 * ospfd.c: (ospf_new) stub-shutdown should just default to
675 unconfigured, too strange otherwise.
676 (ospf_finish_final) t_opaque_lsa_self TIMER_OFF should be
677 preprocessor conditional on HAVE_OPAQUE_LSA.
678 * ospfd.h: (struct ospf) remove the SHUTDOWN_DEFAULT define.
679 no longer used, plus it wasn't in range that the command
680 accepted.
681 * ospf_zebra.h: Depends on vty.h, include it.
682
paul58e1bef2005-11-11 12:10:03 +00006832005-11-11 Paul Jakma <paul.jakma@sun.com>
684
685 * ospf_spf.c: (ospf_canonical_nexthops_free) Free only
686 the nexthops pointing to the root vertex. We may visit a
687 vertex twice or the vertex may have some inherited nexthops,
688 if we free other nexthops we could crash.
689
paulc8c15212005-11-04 12:31:39 +00006902005-11-04 Paul Jakma <paul.jakma@sun.com>
691
692 * ospf_{dump,spf,vty}.c: Oops, use the internal tv_sub
693 function rather than unportable timersub.
694
paul484315f2005-11-03 09:08:29 +00006952005-11-03 Paul Jakma <paul.jakma@sun.com>
696
697 * ospf_apiserver.c: (apiserver_sync_callback) stray semi-colon
698 * ospf_packet.c: include checksum.h, remove the in_cksum extern
699 * prototypes.
700 * ospf_te.h: Add braces, quell warning.
paul6d452762005-11-03 11:15:44 +0000701 * ospf_packet.c: Change level of some warnings to
702 informational.
paulc8c15212005-11-04 12:31:39 +0000703
paul88d6cf32005-10-29 12:50:09 +00007042005-10-29 Paul Jakma <paul.jakma@sun.com>
705
706 * (general) RFC3137 stub-router support
707 * ospfd.h: Add OSPF_OUTPUT_COST_INFINITE define.
708 (struct ospf_master) Add a OSPF_MASTER_SHUTDOWN flag for
709 options, to allow shutdown to distinguish between complete
710 shutdown and shutdown of a subset of ospf instances.
711 (struct ospf)
712 Add stub_router_{startup,shutdown_}time, configuration of startup
713 and shutdown time for stub-router.
714 Add t_graceful_shutdown struct thread, timer for graceful
715 shutdown, if needed.
716 (struct ospf_area) Add stub_router_state - run time state of
717 stub-router for an area. Add flags for ADMIN, IS and WAS
718 states.
719 Add t_stub_router, timer thread to resend router-lsa for an
720 area.
721 * ospf_lsa.c: (ospf_link_cost) new simple function to spit out
722 either the given lnks cost or infinite cost if stub-router is
723 in effect.
724 (lsa_link_{ptop,broadcast,virtuallink,ptomp}_set) use
725 previous function for transit-links.
726 (ospf_stub_router_timer) timer thread for end of startup stub
727 router. Change state as required for the area and setup
728 re-origination of router-lsa.
729 (ospf_stub_router_check) Check/do whether stub-router should be
730 enabled, and whether it requires timer to be setup.
731 (ospf_router_lsa_new) call previous function at top.
732 (ospf_router_lsa_originate) no external callers, made static.
733 * ospf_lsa.h: (ospf_router_lsa_originate) removed.
734 * ospf_main.c: (sigint) make static.
735 remove call to exit, as ospf_terminate now deals with
736 exiting.
737 * ospf_route.c: (ospf_terminate) removed, now in ospfd.c.
738 * ospf_vty.c: (show_ip_ospf_area) print out state of
739 stub-router, if active.
740 (show_ip_ospf) print out configuration of stub-router
741 support, and details of graceful-shutdown if the timer is
742 active.
743 ((no)?ospf_max_metric_router_lsa_{admin,startup,shutdown}) new
744 commands to (de-)?configure stub-router support.
745 (config_write_stub_router) write out config of stub-router.
746 (ospf_config_write) call previous.
747 (ospf_vty_init) install the new stub-router commands.
748 * ospfd.c: various functions made static.
749 (ospf_new) Set defaults for stub-router. Graceful shutdown
750 is made to default on, just to be adventerous.
751 (ospf_graceful_shutdown_finish) new function, final part of
752 shutdown.
753 (ospf_graceful_shutdown_timer) timer thread wrapper for
754 graceful-shutdown.
755 (ospf_graceful_shutdown_check) check whether to setup timer
756 for shutdown or proceed directly to final shutdown.
757 (ospf_terminate) moved here from ospf_route.c, call
758 ospf_finish for each instance.
759 (ospf_finish) renamed to ospf_finish_final and made static.
760 (ospf_finish) new function, exported wrapper around
761 ospf_graceful_shutdown_check.
762 (ospf_finish_final) complete shutdown of an instance.
763 Add missing TIMER_OFF's of two timer threads.
764 (ospf_area_free) opaque self lsa timer should be turned off.
765
paulb8ad39d2005-10-23 15:23:05 +00007662005-10-23 Paul Jakma <paul.jakma@sun.com>
767
paule029d442005-10-23 15:26:24 +0000768 * ospf_apiserver.c: (ospf_apiserver_term) This function should
769 not have side-effects (eg segv) if no apiserver instances are
770 active, ie be robust.
paulb8ad39d2005-10-23 15:23:05 +0000771 * ospf_vty.c: (show_ip_ospf) fix display of SPF timer if it
772 has not yet been run.
773
paulf9ad9372005-10-21 00:45:17 +00007742005-10-21 Paul Jakma <paul.jakma@sun.com>
775
paulea4ffc92005-10-21 20:04:41 +0000776 * ospf_dump.c: (ospf_timeval_dump) fix ms adjustment, thanks to
777 Andrew Schorr.
778 * ospf_vty.c: (ospf_config_write) fix write out of spf timers
779 configuration.
780
7812005-10-21 Paul Jakma <paul.jakma@sun.com>
782
pauld24f6e22005-10-21 09:23:12 +0000783 * (general) SPF millisecond resolution timer with adaptive,
784 linear back-off holdtime. Prettification of ospf_timer_dump.
785 * ospf_dump.c: (ospf_timeval_dump) new function. The guts of
786 ospf_timer_dump, but made to be more dynamic in printing out
787 the relative timeval, sliding the precision printed out
788 according to the value.
789 (ospf_timer_dump) guts moved to ospf_timeval_dump.
790 * ospf_dump.h: export ospf_timeval_dump.
791 * ospf_flood.c: (ospf_flood) remove gettimeofday, use
792 the libzebra exported recent_time instead, as it's not
793 terribly critical to have time exactly right - the dropped
794 LSA will be retransmited to us if we don't ACK it.
795 * ospf_packet.c: (ospf_ls_upd_timer) Ditto, but here we're
796 not transmitting, just putting LSA back on update transmit list.
797 * ospfd.h: delay and holdtimes should be unsigned.
798 Add spf_max_holdtime and spf_hold_multiplier.
799 Update default defines for delay and hold time to be in msec.
800 (struct ospf) change the SPF timestamp to a struct timeval.
801 Remove ospf_timers_spf_(un)?set.
802 * ospfd.c: (ospf_timers_spf_{set,unset}) removed.
803 (ospf_new) initialise spf_max_holdtime and spf_hold_multiplier
804 * ospf_spf.c: (ospf_spf_calculate) SPF timestamp is a timeval
805 now, update with gettimeofday.
806 (ospf_spf_calculate_schedule) Change SPF timers to millisecond
807 resolution.
808 Make the holdtime be adaptive, with a linear increase in
809 holdtime ever consecutive SPF run which occurs within holdtime
810 of previous SPF, bounded by spf_max_holdtime.
811 * ospf_vty.c: Update spf timers commands.
812 (ospf_timers_spf_set) trivial helper.
813 (ospf_timers_throttle_spf_cmd) new command to set SPF delay,
814 initial hold and max hold times with millisecond resolution.
815 (ospf_timers_spf_cmd) Deprecated. Accept the old values,
816 convert to msec, truncate to new limits.
817 (no_ospf_timers_throttle_spf_cmd) set timers to defaults.
818 (no_ospf_timers_spf_cmd) deprecated form, same as previous.
819 (show_ip_ospf_cmd) Display SPF parameters and times.
820 (show_ip_ospf_neighbour_header) Centralise the 'sh ip os ne'
821 header.
822 (show_ip_ospf_neighbor_sub) Fix the field widths. Get rid of
823 the multiple spaces which were making the lines even longer.
824 (show_ip_ospf_neighbor_cmd) Use show_ip_ospf_neighbour_header
825 (show_ip_ospf_neighbor_all_cmd) ditto and fix the field
826 widths for NBMA neighbours.
827 (show_ip_ospf_neighbor_int) Use header function.
828 (show_ip_ospf_nbr_nbma_detail_sub) use sizeof for timebuf,
829 local array - safer.
830 (show_ip_ospf_neighbor_detail_sub) ditto
831 (ospf_vty_init) install the new SPF throttle timer commands.
832
8332005-10-21 Paul Jakma <paul.jakma@sun.com>
834
paulf9ad9372005-10-21 00:45:17 +0000835 * (general) OSPF fast, sub-second hello and 1s dead-interval
836 support.
837 * ospf_dump.c: (ospf_timer_dump) Print out milliseconds too.
838 Callers typically specify a length of 9, so most see
839 millisecs unless they specify the additional length.
840 * ospf_interface.h: (struct ospf_interface) new interface param,
841 fast_hello.
842 * ospf_interface.c: (ospf_if_table_lookup) add brackets,
843 gcc warning fix.
844 (ospf_new_if_params) Initialise fast_hello param.
845 (ospf_free_if_params) Check whether fast_hello is configured.
846 (ospf_if_new_hook) set fast_hello to default.
847 * ospf_ism.h: Wrap OSPF_ISM_TIMER_ON inside do {} while (0) to
848 prevent funny side-effects from its if statement when this
849 macro is used conditionally by other macros.
850 (OSPF_ISM_TIMER_MSEC_ON) new macro, set in milliseconds.
851 (OSPF_HELLO_TIMER_ON) new macro to set hello timer according
852 to whether fast_hello is set.
853 * ospf_ism.c: Update all setting of the hello timer to use
854 either OSPF_ISM_TIMER_MSEC_ON or OSPF_HELLO_TIMER_ON. The
855 former is used when hello is to be sent immediately.
856 * ospf_nsm.c: ditto
857 * ospf_packet.c: (ospf_hello) hello-interval is not checked
858 for mismatch if fast_hello is set.
859 (ospf_read) Annoying nit, fix "no ospf_interface" to be debug
860 rather than a warning, as it can be perfectly normal to
861 receive packets when logical subnets are used.
862 (ospf_make_hello) Set hello-interval to 0 if fast-hellos are
863 configured.
864 * ospf_vty.c: (ospf_auto_cost_reference_bandwidth) annoying
865 nit, don't vty_out if this command is given, it gets tired
866 quick.
867 (show_ip_ospf_interface_sub) Print the hello-interval
868 according to whether fast-hello is set or not.
869 Print the extra 5 millisec characters from (ospf_timer_dump)
870 if fast-hello is configured.
871 (ospf_vty_dead_interval_set) new function, common to all
872 forms of dead-interval command, to set dead-interval and
873 fast-hello correctly. If a dead-interval is given, unset
874 fast-hello, else if a hello-multiplier is set, set
875 dead-interval to 1 and fast-hello to given multiplier.
876 (ip_ospf_dead_interval_addr_cmd) use
877 ospf_vty_dead_interval_set().
878 (ip_ospf_dead_interval_minimal_addr_cmd) ditto.
879 (no_ip_ospf_dead_interval) Unset fast-hello.
880 (no_ip_ospf_hello_interval) Bug-fix, unset of hello-interval
881 should set it to OSPF_HELLO_INTERVAL_DEFAULT, not
882 OSPF_ROUTER_DEAD_INTERVAL_DEFAULT.
883 (config_write_interface) Write out fast-hello.
884 (ospf_config_write) Write a comment about
885 "auto-cost reference-bandwidth" having to be equal on all
886 routers. Hopefully just as noticeable as old practice of
887 writing to vty, but less annoying.
888 (ospf_vty_if_init) install the two new dead-interval
889 commands.
890 * ospfd.h: Add defines for OSPF_ROUTER_DEAD_INTERVAL_MINIMAL
891 and OSPF_FAST_HELLO_DEFAULT.
892
pauleb3da6d2005-10-18 04:20:33 +00008932005-10-18 Paul Jakma <paul.jakma@sun.com>
894
895 * (general) SPF memory management cleanup and fix for rare
896 double-free bug.
897 * ospf_spf.h: (struct vertex_parent) New struct to hold parent
898 specific data, eg the backlink and the parent vertex pointer,
899 and point to the appropriate general struct vertex_nexthop.
900 (struct vertex_nexthop) remove parent vertex pointer, so
901 this struct can be shared across vertices.
902 (struct vertex) rename list child to list children. Remove
903 list of nexthops, replace with list of vertex_parents.
904 * ospf_spf.c: (update_stat) trivial, remove cast from void *.
905 (vertex_nexthop_new) remove init of parent - field is gone
906 from struct vertex_nexthop.
907 (ospf_canonical_nexthops_free) Remove the canonical
908 vertex_nexthop memory objects. These are the vertex_nexthops
909 attached to the first level of router vertices from the root.
910 (vertex_parent_new) new function, create a vertex_parent.
911 (vertex_parent_free) ditto, but free it.
912 (ospf_vertex_new) Update to match changes to struct vertex.
913 (ospf_vertex_free) Recursively free a struct vertex and its
914 children. The parent list is used as a reference count.
915 vertex_nexthops must be free seperately, if required.
916 (ospf_vertex_dump) update to match struct vertex changes.
917 Print out backlink of parents too.
918 (ospf_vertex_add_parent) ditto.
919 (ospf_lsa_has_link) update comment.
920 (ospf_nexthop_add_unique) removed, not needed anymore.
921 (ospf_nexthop_merge) ditto.
922 (ospf_spf_consider_nexthop) renamed to ospf_spf_add_parent.
923 Simplified to just create vertex_parent and add it.
924 (ospf_spf_flush_parents) new function, flush out the parent
925 list.
926 (ospf_nexthop_calculation) Take the relevant route_lsa_link
927 as an argument, which simplifies things and removes the need
928 for the hack in ospf_nexthop_add_unique - ospf_spf_next
929 already knew exactly which link the cost calculated was for.
930 Update to match struct vertex changes too.
931 (ospf_spf_next) Don't create a vertex for W unnecessarily, if
932 it's there's a vertex already created for W, use it, and
933 hence there's no need to free it either.
934 Update some manipulation/comparisons of distance to match.
935 Flush the parent list if a lower cost path is found.
936 (ospf_spf_route_free) unused, removed.
937 (ospf_spf_dump) match the struct vertex changes, and dump the
938 ifname if possible.
939 (ospf_spf_calculate) At end of SPF, free the canonical nexthops
940 and call ospf_vertex_free on the root vertex to free the
941 entire tree.
942 * ospf_interface.c: (ospf_vl_set_params) match struct vertex
943 changes.
944 * ospf_route.c: (ospf_intra_route_add) ditto
945 (ospf_route_copy_nexthops_from_vertex) ditto
946
paul36238142005-10-11 04:12:54 +00009472005-10-11 Paul Jakma <paul.jakma@sun.com>
948
949 * ospf_api.c: sign warnings.
950 * ospf_apiserver.c: sign warning and convert all the struct
951 in_addr initialisations so as not to make assumptions about
952 how this struct is organised, initialise the s_addr member
953 explicitely.
954 * ospf_packet.c: Add const qualifier to auth_key.
955
vincent77df1f72005-10-06 07:46:22 +00009562005-10-06 Alain Ritoux <alain.ritoux@6wind.com>
957
958 * ospf_snmp.c: Avoid mixing interface and ospf_interface objects
959 which now allows snmpwalk to work with ospfIfTable and
960 also with ospfIfMetricTable
961
ajsf52d13c2005-10-01 17:38:06 +00009622005-10-01 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
963
964 * ospf_dump.c: Remove local hard-coded table ospf_redistributed_proto.
965 (ospf_redist_string) New function implemented using new library
966 function zebra_route_string(). Note that there are a few differences
967 in the output that will result: the new function returns strings
968 that are lower-case, whereas the old table was mixed case. Also,
969 the old table mapped ZEBRA_ROUTE_OSPF6 to "OSPFv3", whereas the
970 new function returns "ospf6".
971 * ospfd.h: Remove extern struct message ospf_redistributed_proto[],
972 and add extern const char *ospf_redist_string(u_int route_type)
973 instead.
974 * ospf_asbr.c: (ospf_external_info_add) In two messages, use
975 ospf_redist_string instead of LOOKUP(ospf_redistributed_proto).
976 * ospf_vty.c: Remove local hard-coded table distribute_str.
977 (config_write_ospf_redistribute,config_write_ospf_distribute): Use
978 new library function zebra_route_string() instead of distribute_str[].
979 * ospf_zebra.c: (ospf_redistribute_set,ospf_redistribute_unset,
980 ospf_redistribute_default_set,ospf_redistribute_check)
981 In debug messages, use ospf_redist_string() instead of
982 LOOKUP(ospf_redistributed_proto).
983
jardin6638c1a2005-10-01 00:08:54 +00009842005-09-30 Vincent Jardin <vincent.jardin@6wind.com>
985
986 * ospf_dump.c, ospf_ia.c, ospf_spf.c, ospf_ase.c:
987 remove unused DEBUG
988
vincentba682532005-09-29 13:52:57 +00009892005-09-29 Alain Ritoux <alain.ritoux@6wind.com>
990
vincent5e4914c2005-09-29 16:34:30 +0000991 * ospf_ism.c: generate SNMP traps on Interface state change
992 * ospf_nsm.c: generate SNMP traps on Neighbour state change
993 * ospf_snmp.[ch]: support for SNMP traps for interface and neighbours.
994
9952005-09-29 Alain Ritoux <alain.ritoux@6wind.com>
996
vincentba682532005-09-29 13:52:57 +0000997 * ospf_vty.c: forece default route LSA to be re_issued whenever
998 cost is changed ( [no] ip ospf area XXX default-cost YYY)
999 Support ignore-mtu option
1000 * ospfd.h: define OSPF_MTU_IGNORE_DEFAULT
1001 * ospf_packet.c: support ignore-mtu option
1002 * ospf_interface.h: field added for skipping MTU check
1003 * ospf_interface.c: fix memory leak in ospf_crypt_key_delete()
1004 Set mtu_ignore field to default value
1005 * ospf_abr.[ch]: export ospf_abr_announce_network_to_area()
1006 * ospf_ism.h: add MACRO to convert internal ISM status into SNMP
1007 correct values
1008 * ospf_snmp.c: add sanity check on LSA type in lsdb_lookup_next()
1009 convert OSPFIFSTATE internal status into SNMP values
1010
vincentc1a03d42005-09-28 15:47:44 +000010112005-09-28 Alain Ritoux <alain.ritoux@6wind.com>
1012
1013 * ospf_packet.c: use new md5 API
1014
ajs5339cfd2005-09-19 13:28:05 +000010152005-09-19 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1016
1017 * ospf_lsa.h: (ospf_external_lsa_flush) Comment out the 5th argument
1018 (nexthop) since it is not used in the function (except inside
1019 some commented-out code).
1020 * ospf_lsa.c: (ospf_external_lsa_flush,ospf_external_lsa_refresh)
1021 Comment out the 5th argument to ospf_external_lsa_flush.
1022 * ospf_asbr.c: (ospf_redistribute_withdraw) Comment out 5th arg
1023 to ospf_external_lsa_flush.
1024 * ospf_vty.c: (no_ospf_default_information_originate) Eliminate 5th
1025 uninitialized nexthop arg to ospf_external_lsa_flush.
1026 * ospf_zebra.c: (ospf_zebra_read_ipv4) Comment out 5th arg
1027 to ospf_external_lsa_flush.
1028 * ospfd.c: (ospf_network_set) Comment out 5th arg
1029 to ospf_external_lsa_flush.
1030
ajse6a0bf92005-09-17 18:53:38 +000010312005-09-17 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1032
1033 * ospf_opaque.c:
1034 (ospf_opaque_lsa_refresh_schedule,ospf_opaque_lsa_flush_schedule)
1035 No need to call ospf_lookup(), just use lsa0->area->ospf instead.
1036
hassobb5b7552005-08-21 20:01:15 +000010372005-08-21 Hasso Tepper <hasso at quagga.net>
1038
1039 * ospf_vty.c: Make "show ip ospf neighbor xxx" commands work.
1040 Interface should be specified by name now.
1041
hasso54bedb52005-08-17 13:31:47 +000010422005-08-17 Hasso Tepper <hasso at quagga.net>
1043
1044 * ospf_vty.c: Check carefully if interface exists before trying to
1045 print info about it.
1046
hasso01018ce2005-08-05 07:40:15 +000010472005-08-05 Hasso Tepper <hasso at quagga.net>
1048
1049 * ospf_zebra.c: Don't assert/stop before type == ZEBRA_ROUTE_MAX if
1050 dealing with routemaps. There is ospf->route_map[ZEBRA_ROUTE_MAX]
1051 for default-information.
1052
paulc8987752005-07-26 06:07:22 +000010532005-07-26 Paul Jakma <paul.jakma@sun.com>
1054
1055 * ospf_abr.c: (ospf_abr_announce_network_to_area) SET_FLAG
1056 should be on lsa not old, which may be freed for one thing,
1057 obviously.
1058
pauld57834f2005-07-12 20:04:22 +000010592005-07-12 Paul Jakma <paul.jakma@sun.com>
1060
1061 * ospfd.h: add OSPF_ABR_DEFAULT for convenience, make
1062 OSPF_ABR_CISCO be the default ABR type.
1063 * ospfd.c: (ospf_new) initialise abr_type to OSPF_ABR_DEFAULT
1064 * ospf_vty.c: (no_ospf_abr_type_cmd) add standard as a negatable
1065 abr_type. default abr_type should be OSPF_ABR_DEFAULT.
1066 (ospf_config_write) test whether default abr_type against
1067 OSPF_ABR_DEFAULT, rather than any specific ABR_TYPE.
1068
hasso8469bd72005-06-20 20:50:10 +000010692005-06-20 Hasso Tepper <hasso at quagga.net>
hassof4833e92005-06-20 20:42:26 +00001070
1071 * ospf_nsm.c: Make database exchange for NSSA database work.
1072
paul7461d452005-06-13 13:57:16 +000010732005-06-13 Paul Jakma <paul.jakma@sun.com>
1074
1075 * ospf_spf.c: Try get more information on a SEGV under
1076 ospf_spf_vertex_add_parent.
1077 (ospf_vertex_free) NULL out the child and nexthop lists
1078 (ospf_vertex_add_parent) nexthop and child can not be NULL
1079 vertex_nexthop's parent->child list can not be NULL
1080 (ospf_spf_next) w and cw are per-loop iteration variables, move
1081 declarations into loop body.
1082
hasso1ddd7292005-06-07 19:54:04 +000010832005-06-07 Hasso Tepper <hasso at quagga.net>
1084
1085 * ospf_apiserver.c: Fix obvious error in notifying clients about ISM
1086 changes - oi->ifp->status doesn't give to us info about ISM,
1087 oi->state does.
1088
paul7e440862005-06-01 11:20:51 +000010892005-06-01 Akihiro Mizutani <mizutani@net-chef.net>
1090
1091 * ospf_ism.c (ospf_elect_bdr/ospf_elect_dr): Fix DR election bug.
1092
paul500e4182005-05-26 17:11:13 +000010932005-05-26 Paul Jakma <paul.jakma@sun.com>
1094
1095 * ospf_abr.c: (ospf_abr_update_aggregate) Fix comment, cost bug itself
1096 had been fixed long ago by Sowmini.
1097
paula3387a42005-05-18 23:29:57 +000010982005-05-19 Paul Jakma <paul.jakma@sun.com>
1099
1100 * ospf_interface.c: (ospf_if_table_lookup) Fix a serious bug
1101 a less serious one.
1102 1: this function is supposed to lookup
1103 entries in the oifs ospf_interface route_table and return either
1104 an existing oi or NULL to indicate not found, its caller depends
1105 on this, yet this function uses route_node_get which /always/
1106 returns a route_node - one is created if none exists. Use
1107 route_node_lookup instead. This should fix root cause of the
1108 reports of the (ospf_add_to_if) assert being hit.
1109 2: oi's are inserted into this table with prefixlength set to
1110 /32 (indeed, it should be a hash table, not a route_table),
1111 however prefixlength to lookup was not changed, if no valid entry
1112 can be inserted other than /32, then nothng but /32 should be
1113 looked up. This possibly only worked by fluke..
1114 Fix confirmed by 2 reporters (one list, one IRC), definitely a
1115 backport candidate once it has been incubated in HEAD for a while.
1116 Thanks to Patrick Friedel and Ivan Warren for testing.
1117
paul69310a62005-05-11 18:09:59 +000011182005-05-11 Paul Jakma <paul.jakma@sun.com>
1119
1120 * (general) Fix memory leaks in opaque AS-scope LSAs, reported and
1121 with much debugging done by by scott collins <scollins@agile.tv>.
1122 * ospf_lsa.c: (ospf_discard_from_db) dont call
1123 ospf_ase_unregister_external_lsa for opaque-lsa's, opaques are
1124 never registered with ase in the first place.
1125 * ospf_packet.c: (general) Disabuse opaque related code of its
1126 tendency to try gather up things into temporary lists.
1127 (ospf_ls_upd) remove the temporary lists opaque uses, call
1128 opaque functions inline, just like all other types.
1129 (ospf_ls_ack) ditto.
1130 (ospf_recv_packet) fixup sign warning.
1131 * ospf_opaque.c: (general) fix the unneeded use of lists, and
1132 untwist some of the logic.
1133 (ospf_opaque_self_originated_lsa_received) take a single LSA
1134 as argument, not a list of them. Remove the list loop. Logic
1135 otherwise unchanged.
1136 (ospf_opaque_ls_ack_received) Mostly ditto. But untwist the logic,
1137 move the actions up into the switch block, remove the goto's and
1138 sanitise the logic near the end a bit.
1139 * ospf_opaque.h: Adjust definitions of aforementioned functions
1140 in ospf_opaque.c to match.
1141
paul42c98192005-05-07 02:22:51 +000011422005-05-07 Yar Tikhiy <yar@comp.chem.msu.su>
1143
1144 * ospf_network.c: Log ifindex on multicast membership leave/join
1145 events.
1146
paul4dadc292005-05-06 21:37:42 +000011472005-05-06 Paul Jakma <paul.jakma@sun.com>
1148
1149 * (general) extern and static qualifiers added.
1150 unspecified arguments in definitions fixed, typically they should
1151 be 'void'.
1152 function casts added for callbacks.
1153 Guards added to headers which lacked them.
1154 Proper headers included rather than relying on incomplete
1155 definitions.
1156 gcc noreturn function attribute where appropriate.
1157 * ospf_opaque.c: remove the private definition of ospf_lsa's
1158 ospf_lsa_refresh_delay.
1159 * ospf_lsa.h: export ospf_lsa_refresh_delay
1160 * ospf_packet.c: (ospf_make_md5_digest) make *auth_key const,
1161 correct thing to do - removes need for the casts later.
1162 * ospf_vty.c: Use vty.h's VTY_GET_INTEGER rather than ospf_vty's
1163 home-brewed versions, shuts up several warnings.
1164 * ospf_vty.h: remove VTY_GET_UINT32. VTY_GET_IPV4_ADDRESS and
1165 VTY_GET_IPV4_PREFIX moved to lib/vty.h.
1166 * ospf_zebra.c: (ospf_distribute_list_update_timer) hacky
1167 overloading of the THREAD_ARG pointer should at least use
1168 uintptr_t.
1169
paul9e67dc22005-04-15 12:10:17 +000011702005-04-15 Zhipeng Gong <zpgong@cdc.3upsystems.com>
1171
1172 * ospf_abr.c: (ospf_abr_announce_network_to_area) dont forget
1173 to approve LSAs for the case where metric has changed, lsa gets
1174 flushed otherwise. (backport candidate).
1175
ajs634f9ea2005-04-11 15:51:40 +000011762005-04-11 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1177
1178 * ospf_zebra.c (ospf_zebra_add): Call zclient_send_message instead
1179 of writen.
1180
ajsd2fc8892005-04-02 18:38:43 +000011812005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1182
ajse4319de2005-04-02 23:23:55 +00001183 * ospf_interface.h: (ospf_if_lookup_by_name) Remove declaration of a
1184 function that does not exist.
1185
11862005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1187
ajs21fefa92005-04-02 23:16:41 +00001188 * ospf_zebra.c: (zebra_interface_if_lookup) Must use
1189 if_lookup_by_name_len.
1190
11912005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1192
ajsa3491982005-04-02 22:50:38 +00001193 * ospf_interface.c: (ospf_vl_new) Use strnlen to fix call to if_create.
1194
11952005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1196
ajsd2fc8892005-04-02 18:38:43 +00001197 * ospf_vty.c: (show_ip_ospf_interface_sub) Show ifindex and interface
1198 flags to help with debugging.
1199 * ospf_zebra.c: (ospf_interface_delete) After deleting, set ifp->ifindex
1200 to IFINDEX_INTERNAL.
1201 (zebra_interface_if_lookup) Make function static. Tighten up code.
1202
ajsaca72fd2005-03-31 15:18:21 +000012032005-03-31 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1204
1205 * ospf_dump.c: (show_debugging_ospf) Show if ospf event debugging
1206 is turned on.
1207
ajsfd651fa2005-03-29 16:08:16 +000012082005-03-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1209
ajsa608bbf2005-03-29 17:03:49 +00001210 * ospf_zebra.c: (ospf_interface_state_up) If the MTU of an operative
1211 interface changes, print a debug message and call ospf_if_reset()
1212 to simulate down/up on the interface.
1213 * ospf_interface.h: Declare new function ospf_if_reset().
1214 * ospf_interface.c: (ospf_if_reset) New function to call ospf_if_down
1215 and ospf_if_up for all ospf interfaces attached to an interface.
1216
12172005-03-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1218
ajs5dcbdf82005-03-29 16:13:49 +00001219 * ospf_packet.c: (ospf_write_frags) Enhance error message to
1220 show MTU. Also make function static.
1221 (ospf_write) Enhance error message to show interface name and MTU.
1222 Also make function static.
1223
12242005-03-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1225
1226 * ospf_vty.c: (show_ip_ospf_interface_sub) Display interface MTU and
1227 bandwidth; this is useful for debugging problems. Also, the function
1228 should be static.
ajsfd651fa2005-03-29 16:08:16 +00001229
hasso1b639042005-03-27 13:32:25 +000012302005-03-27 Hasso Tepper <hasso at quagga.net>
1231
1232 * ospf_snmp.c: Don't crash in snmp query if ospf instance doesn't
1233 exist at all.
1234
hasso343f5cc2005-03-25 19:48:40 +000012352005-03-25 Hasso Tepper <hasso at quagga.net>
1236
1237 * ospfd.h: Include log.h, fixes compile with gcc-4.0.
1238
ajs9dbc7972005-03-13 19:27:22 +000012392005-03-13 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1240
1241 * ospf_lsa.c: (ospf_lsa_refresh_walker) If the system clock jumps
1242 backward, then current time may be less than
1243 ospf->lsa_refresher_started. This was causing invalid values
1244 for ospf->lsa_refresh_queue.index resulting in infinite loops.
1245 Problem fixed by casting the expression to unsigned before taking
1246 the modulus.
1247
ajs5c333492005-02-23 15:43:01 +000012482005-02-23 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1249
1250 * ospfd.h: Add new field struct stream *ibuf to struct ospf.
1251 * ospfd.c: (ospf_new) Check return code from ospf_sock_init.
1252 Allocate ibuf using stream_new(OSPF_MAX_PACKET_SIZE+1).
1253 (ospf_finish) Call stream_free(ospf->ibuf.
1254 * ospf_packet.c: (ospf_read) Call stream_reset(ospf->ibuf) and then
1255 pass it to ospf_recv_packet for use in receiving the packet
1256 (instead of allocating a new stream for each packet received).
1257 Eliminate all calls to stream_free(ibuf).
1258 (ospf_recv_packet) The struct stream *ibuf is now passed in as
1259 an argument. No need to use recvfrom to peek at the packet
1260 header (to see how big it is), just use ospf->ibuf which is
1261 always large enough (this eliminates a system call to recvfrom).
1262 Therefore, no need to allocate a stream just for this packet,
1263 and no need to free it when done.
1264
hasso462f20d2005-02-23 11:29:02 +000012652005-02-23 Vincenzo Eramo <eramo at infocom.ing.uniroma1.it>
1266
1267 * ospf_lsa.h: New flag to the LSA structure for the SPF calculation.
1268 * ospf_lsdb.h: Export ospf_lsdb_clean_stat() function.
1269 * ospf_spf.h: Add link to the LSA stat structure into vertex.
1270 * ospf_spf.c: New functions cmp() and update_stat() to manage
1271 candidates. Remove ospf_spf_has_vertex(), ospf_vertex_lookup(),
1272 ospf_install_candidate() and ospf_spf_register() functions not needed
1273 any more. Update ospf_vertex_new(), ospf_spf_next() and
1274 ospf_spf_calculate() functions to use pqueue instead of linked list.
1275
hassoe40dcce2005-02-21 14:58:42 +000012762005-02-21 Hasso Tepper <hasso at quagga.net>
1277
1278 * ospf_ase.c: Don't show messages related to the ase calculations if
1279 we are not debugging.
1280
hasso306541b2005-02-19 17:58:40 +000012812005-02-19 Hasso Tepper <hasso at quagga.net>
1282
1283 * ospf_api.h: char isn't always signed, but it has to be it here.
1284
paulfa81b712005-02-19 01:19:20 +000012852005-02-19 Paul Jakma <paul.jakma@sun.com>
1286
1287 * ospf_packet.c: (ospf_stream_copy) remove
1288 (ospf_packet_dup) use stream_copy instead of ospf_stream_copy
1289
ajs038163f2005-02-17 19:55:59 +000012902005-02-17 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1291
1292 * ospf_packet.c: (ospf_recv_packet) If there is somehow a runt
1293 packet in the queue, it must be discarded. Improve warning messages.
1294 Fix scope to static.
1295 (ospf_read) Fix bug: should reset the read thread in all cases
1296 to make sure we continue to get incoming messages.
1297
paul658b03a2005-02-15 10:10:55 +000012982005-02-15 Paul Jakma <paul.jakma@sun.com>
1299
1300 * ospf_packet.c: (ospf_recv_packet) Fix silly error wrt allocating
1301 ibuf. Thanks Andrew.
1302
paulbfdc44a2005-02-14 23:48:42 +000013032005-02-14 Paul Jakma <paul.jakma@sun.com>
1304
1305 * ospf_packet.c: (ospf_recv_packet) use stream_recvmsg.
1306
hasso082253f2005-02-11 08:31:54 +000013072005-02-11 Hasso Tepper <hasso at quagga.net>
1308
1309 * ospf_lsdb.c: Fix sum of checksums calculation.
1310
ajs083ee9d2005-02-09 15:35:50 +000013112005-02-09 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1312
1313 * ospf_packet.c: (ospf_write) If sendmsg fails, give more info in the
1314 error message.
1315
ajsba6454e2005-02-08 15:37:30 +000013162005-02-08 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1317
ajs8cfde372005-02-08 15:59:16 +00001318 * ospf_interface.h: Reduce structure padding by putting new u_char
1319 field multicast_memberships in a better spot (grouped with
1320 other u_char fields type and state).
1321
13222005-02-08 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1323
ajsba6454e2005-02-08 15:37:30 +00001324 * ospf_interface.h: Improve passive_interface comment. Add new
1325 multicast_memberships bitmask to struct ospf_interface to track
1326 active multicast subscriptions. Declare new function
1327 ospf_if_set_multicast.
1328 * ospf_interface.c: (ospf_if_set_multicast) New function to configure
1329 multicast memberships properly based on the current
1330 multicast_memberships status and the current values of the
1331 ospf_interface state, type, and passive_interface status.
1332 (ospf_if_up) Remove call to ospf_if_add_allspfrouters (this is
1333 now handled by ism_change_state's call to ospf_if_set_multicast).
1334 (ospf_if_down) Remove call to ospf_if_drop_allspfrouters (now
1335 handled by ism_change_state).
1336 * ospf_ism.c: (ospf_dr_election) Remove logic to join or leave
1337 the DRouters multicast group (now handled by ism_change_state's call
1338 to ospf_if_set_multicast).
1339 (ism_change_state) Add call to ospf_if_set_multicast to change
1340 multicast memberships as necessary to reflect the new interface state.
1341 * ospf_packet.c: (ospf_hello) When a Hello packet is received on a
1342 passive interface: 1. Increase the severity of the error message
1343 from LOG_INFO to LOG_WARNING; 2. Add more information to the error
1344 message (packet destination address and interface address);
1345 and 3. If the packet was sent to ospf-all-routers, then try
1346 to fix the multicast group memberships.
1347 (ospf_read) When a packet is received on an interface whose state
1348 is ISM_Down, enhance the warning message to show the packet
1349 destination address, and try to update/fix the multicast group
1350 memberships if the packet was sent to a multicast address.
1351 When a packet is received for ospf-designated-routers, but the
1352 current interface state is not DR or BDR, then increase the
1353 severity level of the error message from LOG_INFO to LOG_WARNING,
1354 and try to fix the multicast group memberships.
1355 * ospf_vty.c: (ospf_passive_interface) Call ospf_if_set_multicast for
1356 any ospf interface that may have changed from active to passive.
1357 (no_ospf_passive_interface) Call ospf_if_set_multicast for
1358 any ospf interface that may have changed from passive to active.
1359 (show_ip_ospf_interface_sub) Show multicast group memberships.
1360
paul3a9eb092005-02-08 11:29:41 +000013612005-02-08 Paul Jakma <paul@dishone.st>
1362
1363 * ospf_packet.c: (various) Remove unneeded stream_set_putp abuse.
1364
ajs847947f2005-02-02 18:38:48 +000013652005-02-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1366
1367 * ospf_packet.c: (ospf_read) Fix bug: must check for state ISM_Down,
1368 not for event ISM_InterfaceDown. And improve the message by
1369 adding the interface flags.
1370
ajs0b7d97d2005-01-30 17:24:02 +000013712005-01-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1372
1373 * ospf_network.c: (ospf_sock_init) Save errno before calling
1374 ospfd_privs.change.
1375
ajsc3eab872005-01-29 15:52:07 +000013762005-01-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1377
1378 * ospf_packet.c: (ospf_packet_add) If oi->obuf is NULL, print
1379 an error message and return.
1380 (ospf_read) If the interface state is ISM_InterfaceDown, issue
1381 a warning message and ignore the packet.
1382
gdt86f1fd92005-01-10 14:20:43 +000013832005-01-10 Greg Troxel <gdt@fnord.ir.bbn.com>
1384
1385 * ospf_packet.h: Remove commented out definition of
1386 OSPF_MAX_PACKET; neither it or the uncommented one are used any more.
1387
1388 * ospf_packet.c (ospf_make_ls_upd): Leave room for authentication
1389 when deciding if an update will fit.
1390 (ospf_packet_authspace): Factor out calculation of size required
1391 for authentication.
1392 (ospf_make_db_desc): Use ospf_max_packet, not OSPF_MAX_PACKET.
1393 Don't confuse readers that there is a macro.
1394
ajs3dc56b52004-12-30 15:11:19 +000013952004-12-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1396
1397 * ospf_network.c: Improve all setsockopt error messages to give detailed
1398 information on the arguments.
1399
ajsb87f7722004-12-29 20:41:26 +000014002004-12-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1401
ajs17eaa722004-12-29 21:04:48 +00001402 * ospf_packet.c: (ospf_db_desc) Reduce severity of "Negotiation done"
1403 messages from LOG_WARNING to LOG_INFO, since this seems to be
1404 normal.
1405
14062004-12-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1407
ajsb87f7722004-12-29 20:41:26 +00001408 * ospf_packet.c: (ospf_read) Always look up the interface if
1409 ospf_recv_packet returns NULL ifp, since some platforms such
1410 as Solaris 8 appear to support ifindex retrieval but don't.
1411
hasso1d806282004-12-22 09:43:20 +000014122004-12-22 Hasso Tepper <hasso at quagga.net>
1413
1414 * ospf_dump.c: Show debug configuration in vtysh.
hassoc6b87812004-12-22 13:09:59 +00001415 * ospf_vty.c: Fix "show ip ospf" output. Router can't be elected in
1416 any case if it's configured as "translate-never".
hassofe71a972004-12-22 16:16:02 +00001417 * ospf_lsdb.[ch]: New function to calculate sum of checksums.
1418 * ospf_vty.c: Bugfix to show really number of AS external LSAs, not
1419 number of all LSAs with AS scope, this includes opaque as LSAs as
1420 well, show this number separately. Show numbers and sums of
1421 checksums for each type of LSAs.
1422 * ospf_lsa.c: Calculate checksum before putting LSA into database.
hasso1d806282004-12-22 09:43:20 +00001423
ajsbc18d612004-12-15 15:07:19 +000014242004-12-15 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1425
1426 * ospf_interface.h: Declare new function ospf_default_iftype.
1427 * ospf_interface.c: (ospf_default_iftype) New function to centralize
1428 this logic in one place.
1429 * ospf_zebra.c: (ospf_interface_add) Use new function
1430 ospf_default_iftype.
1431 * ospf_vty.c: (no_ip_ospf_network,config_write_interface) Fix logic
1432 by using new function ospf_default_iftype.
1433
ajs3aa8d5f2004-12-11 18:00:06 +000014342004-12-11 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1435
1436 * ospf_packet.c: (ospf_db_desc) Should be static, not global.
1437 (ospf_hello,ospf_db_desc,ospf_ls_upd,ospf_ls_ack) Improve warning
1438 messages to include identifying information (e.g. router id).
1439 * ospf_nsm.c: (nsm_change_state) Improve info message to include
1440 router id and state names.
1441
gdt91f3e522004-12-09 14:51:03 +000014422004-12-09 Greg Troxel <gdt@fnord.ir.bbn.com>
1443
gdt3fb9de72004-12-09 16:30:04 +00001444 * ospf_apiserver.c (ospf_apiserver_term): Obtain struct
1445 ospf_apiserver * from listnode. Remove unused variables. Follows
1446 suggestion from Jay Fenlason.
gdt91f3e522004-12-09 14:51:03 +00001447
ajs9b0e25c2004-12-08 19:06:51 +000014482004-12-08 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1449
1450 * *.c: Change level of debug messages to LOG_DEBUG.
1451
ajs274a4a42004-12-07 15:39:31 +000014522004-12-07 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1453
1454 * ospf_main.c: (main) The 2nd argument to openzlog has been removed.
1455
ajs887c44a2004-12-03 16:36:46 +000014562004-12-03 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1457
ajs1210fa62004-12-03 16:43:24 +00001458 * ospf_packet.c: (ospf_db_desc) Reduce priority on a debug message
1459 from LOG_NOTICE to LOG_DEBUG.
1460
14612004-12-03 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1462
ajs887c44a2004-12-03 16:36:46 +00001463 * ospf_main.c: (sigint) Use zlog_notice for termination message.
1464 (main) Issue a startup announcement using zlog_notice.
1465
ajsbec595a2004-11-30 22:38:43 +000014662004-11-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1467
1468 * ospf_packet.c: (ospf_db_desc_proc) Fix spelling of packet in warning
1469 message and in comment.
1470 (ospf_db_desc) Warning message that a packet is being discarded
1471 should give the router id of the packet source. Fix spelling
1472 of packet in two warning messages.
1473 (ospf_ls_req) Warning message that a link state request is being
1474 discarded should give the router id of the neighbor that sent it.
1475
ajs5b85fac2004-11-26 19:36:42 +000014762004-11-26 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1477
1478 * ospf_main.c: Remove #include "debug.h" (was not being used, and
1479 lib/debug.h has now been deleted).
1480
hassoc0652302004-11-25 19:33:48 +000014812004-11-25 Hasso Tepper <hasso at quagga.net>
1482
1483 * ospf_main.c: Make group to run as configurable.
1484
gdt69e13252004-11-15 18:51:15 +000014852004-11-15 Greg Troxel <gdt@fnord.ir.bbn.com>
1486
1487 * ospf_packet.c (ospf_recv_packet): Assume CMSG_SPACE is present
1488 and works (lib/zebra.h provides if OS doesn't).
1489
paul788dab12004-11-15 11:48:37 +000014902004-11-15 Paul Jakma <paul@dishone.st>
1491
1492 * ospf_{apiserver,te}.c: ospf_lsa_free's should be ospf_lsa_unlock.
1493
paul05e85fa2004-11-12 10:52:19 +000014942004-11-12 Paul Jakma <paul@dishone.st>
1495
1496 * ospf_ia.c: (process_summary_lsa) Only an ABR has any reason to
1497 ignore stub area summary default. Even so it seems a strange
1498 check, add a comment to that effect.
1499
paulf3ae74c2004-11-04 20:35:31 +000015002004-11-04 Paul Jakma <paul@dishone.st>
1501
1502 * ospfd.c: (ospf_network_match_iface) revert to previous network
1503 statement match behaviour.
1504
paul62d8e962004-11-02 20:26:45 +000015052004-11-02 Paul Jakma <paul@dishone.st>
1506
1507 * ospf_packet.c: (ospf_write_frags) remove iov arg, msg already points
1508 to it. Add convenience pointer to msg->msg_iov[1], and use this,
1509 fixing the unfortunate borkenness introduced in moving of this code
1510 to a function.
1511 (ospf_write) remove iovp and fix up call to previous.
1512 (ospf_ls_upd_packet_new) cast size to long int - unfortunately
1513 glibc's size_t format modifier is not portable.
1514
paul37ccfa32004-10-31 11:24:51 +000015152004-10-31 Paul Jakma <paul@dishone.st>
1516
1517 * ospf_packet.c: (ospf_write_frags) Add debug output
1518 (ospf_write) set type early, so we can pass it to
1519 ospf_write_frags.
1520 (ospf_ls_upd_packet_new) print size in debug output when too large
1521 packet is encountered.
paul64511f32004-10-31 18:01:13 +00001522 * ospf_zebra.c: (ospf_distribute_list_update_timer) Ugly misuse of
1523 THREAD_ARG to store an integer, but it should at least use same
1524 same type to retrieve the value. Assert value is sane.
paul37ccfa32004-10-31 11:24:51 +00001525
paulac191232004-10-22 12:05:17 +000015262004-10-22 Paul Jakma <paul@dishone.st>
1527
1528 * ospf_network.c: (ospf_sock_init) call neutral setsock_ifindex()
1529 function.
1530 * ospf_packet.c: (ospf_read) manually look up ifindex
paul4ccb2c42004-10-22 22:52:33 +00001531 if system could not have returned one, eg openbsd, thanks to Rivo
1532 Nurges for highlighting problem and fix.
paul06f953f2004-10-22 17:00:38 +00001533 Change setsockopt_pktinfo to setsockopt_ifindex.
paulac191232004-10-22 12:05:17 +00001534
hasso3fb9cd62004-10-19 19:44:43 +000015352004-10-19 Andrew J. Schorr <aschorr@telemetry-investments.com>
1536
1537 * ospf_snmp.c: (ospf_snmp_if_update) Fix logic to handle PtP links
1538 with dedicated subnets properly.
1539 * ospf_lsa.c: (lsa_link_ptop_set) ditto.
1540 * ospfd.c: (ospf_network_match_iface) ditto.
1541 (ospf_network_run) ditto.
1542 * ospf_interface.c: (ospf_if_is_configured) ditto.
1543 (ospf_if_lookup_by_prefix) ditto.
1544 (ospf_if_lookup_recv_if) ditto.
1545 * ospf_vty.c: (show_ip_ospf_interface_sub) Display the peer or
1546 broadcast address if present.
1547
hassod68614d2004-10-13 09:32:48 +000015482004-10-13 Hasso Tepper <hasso at quagga.net>
1549
1550 * ospf_main.c: Unbreak compilation with ospfapi disabled.
hassoc75105a2004-10-13 10:33:26 +00001551 * ospf_snmp.c: Remove defaults used to initialize smux connection to
1552 snmpd. Connection is initialized only if smux peer is configured.
hassod68614d2004-10-13 09:32:48 +00001553
hassof4d58ce2004-10-12 06:13:54 +000015542004-10-12 Hasso Tepper <hasso at quagga.net>
1555
1556 * ospf_main.c, ospf_opaque.c: Unbreak ospfclient compilation - move
1557 static variable from ospf_main.c into ospf_opaque.c.
1558
hassoc3abdb72004-10-11 16:27:03 +000015592004-10-11 Hasso Tepper <hasso at quagga.net>
1560
1561 * ospf_main.c, ospf_opaque.c: Disable ospfapi init by default. New
1562 command line switch to enable it.
1563
paul6b333612004-10-11 10:11:25 +000015642004-10-11 Paul Jakma <paul@dishone.st>
1565
1566 * ospf_dump.c: (ospf_ip_header_dump) Assume header is in host order
1567 remove ntohs that should have dissappeared. Take struct ip
1568 as argument, caller has to know there's an IP header at start of
1569 stream anyway.
1570 * ospf_dump.h: update declaration of ospf_ip_header_dump.
1571 * ospf_packet.c: (ospf_write) correct call to
1572 sockopt_iphdrincl_swab_htosys which was munging the header.
1573 (ospf_recv_packet) ip_len is needed for old OpenBSD fixup.
1574 (ospf_read) sockopt_iphdrincl_swab_systoh ip header as soon as
1575 we have it.
paul6c835672004-10-11 11:00:30 +00001576 * (global) Const char update and signed/unsigned fixes.
1577 * (various headers) size defines should be unsigned.
1578 * ospf_interface.h: remove duplicated defines, include the
1579 authoritative header - though, these defines should probably
1580 be moved to a dedicated header, or ospfd.h.
1581 * ospf_lsa.h: (struct lsa) ls_seqnum should be unsigned.
1582 * ospf_packet.c: (ospf_write) cast result of shift to unsigned.
paul6b333612004-10-11 10:11:25 +00001583
hassoeb1ce602004-10-08 08:17:22 +000015842004-10-08 Hasso Tepper <hasso at quagga.net>
1585
1586 * *.[c|h]: Fix compiler warnings: make some strings const, signed ->
1587 unsigned, remove unused variables etc.
1588
gdt54ade992004-10-07 19:38:20 +000015892004-10-07 Greg Troxel <gdt@claude.ir.bbn.com>
1590
1591 * ospf_apiserver.c (ospf_apiserver_unregister_opaque_type): Don't
1592 use of variable names 'node' and 'nextnode' to avoid possible
1593 conflict with list macros. Move variable declaration inside for
1594 loop after a statement to top of function.
1595
paulaa20c6f2004-10-07 14:19:36 +000015962004-10-07 Paul Jakma <paul@dishone.st>
1597
1598 * ospf_snmp.c: Missed list typedef update
1599 * ospf_dump.c: Include sockopt.h for header swab functions.
1600
paul18b12c32004-10-05 14:38:29 +000016012004-10-05 Paul Jakma <paul@dishone.st>
1602
1603 * ospf_packet.c: replace ospf_swap_iph_to... with
1604 sockopt_iphdrincl_swab_...
1605
hasso18a6dce2004-10-03 18:18:34 +000016062004-10-03 James R. Leu <jleu at mindspring.com>
1607
1608 * ospf_zebra.c: Read router id related messages from zebra daemon.
1609 Schedule router-id update thread if it's changed.
1610 * ospfd.c: Remove own router-id selection function. Use router id from
1611 zebra daemon if it isn't manually overriden in configuration.
1612
paul68defd62004-09-27 07:27:13 +000016132004-09-27 Paul Jakma <paul@dishone.st>
1614
paul6a99f832004-09-27 12:56:30 +00001615 * ospf_dump.c: (ospf_ip_header_dump) Use HAVE_IP_HDRINCL_BSD_ORDER
1616 Apply to offset too. Print ip_cksum, lets not worry about
1617 possible 2.0.37 compile problems.
1618 * ospf_packet.c: (ospf_swap_iph_to{n,h}) Use
1619 HAVE_IP_HDRINCL_BSD_ORDER.
1620 (ospf_recv_packet) ditto.
1621 (ospf_write) Fixup iov argument to ospf_write_frags.
1622 (struct msghdr).msg_name is caddr_t on most platforms.
paul68defd62004-09-27 07:27:13 +00001623 (ospf_recv_packet) ditto. And msg_flags is not always there
1624 memset struct then set fields we care about rather than
1625 initialise all fields individually.
1626
hassoc9e52be2004-09-26 16:09:34 +000016272004-09-26 Hasso Tepper <hasso at quagga.net>
1628
1629 * ospf_abr.c, ospf_dump.c, ospf_lsa.c, ospf_packet.c, ospf_vty.c,
1630 ospf_zebra.c: Fix compiler warnings.
1631
paul87d6f872004-09-24 08:01:38 +000016322004-09-24 Paul Jakma <paul@dishone.st>
1633
1634 * ospf_apiserver.{c,h}: lists typedef removal cleanup.
1635 update some list loops to LIST_LOOP. some miscellaneous indent
1636 fixups.
1637 (ospf_apiserver_unregister_opaque_type) fix listnode_delete of
1638 referenced node in loop.
paul1603c062004-09-24 08:23:24 +00001639 (ospf_apiserver_term) loops calling ospf_apiserver_free, which
1640 deletes referenced nodes from apiserver_list, fixed.
paul87d6f872004-09-24 08:01:38 +00001641 * ospf_interface.h: lists typedef removal cleanup.
1642 * ospf_opaque.{c,h}: lists typedef removal cleanup. update some list
1643 loops to LIST_LOOP. miscellaneous style and indent fixups.
1644 * ospf_te.{c,h}: ditto
1645 * ospf_packet.c: lists typedef removal cleanup.
paula2570682004-09-24 08:09:57 +00001646 (ospf_write) ifdef fragmentation support. move actual
1647 fragmentation out to a new, similarly ifdefed, function.
1648 (ospf_write_frags) fragmented write support, moved from previous.
paul87d6f872004-09-24 08:01:38 +00001649
hasso52dc7ee2004-09-23 19:18:23 +000016502004-09-23 Hasso Tepper <hasso at quagga.net>
1651
1652 * *.[c|h]: list -> struct list *, listnode -> struct listnode *.
1653
paul68b73392004-09-12 14:21:37 +000016542004-09-12 Paul Jakma <paul@dishone.st>
1655
1656 * ospf_packet.c: Fix bugzilla #107
1657 (ospf_packet_max) get rid of the magic 88 constant
1658 (ospf_swab_iph_ton) new function. set ip header to network order,
1659 taking BSDisms into account.
1660 (ospf_swab_iph_toh) the inverse.
1661 (ospf_write) Add support for IP fragmentation, will only work on
1662 linux though, other kernels make it impossible. get rid of the
1663 magic 4 constant.
1664 (ospf_make_ls_upd) Bound check to end of stream, not to
1665 interface mtu.
1666 (ospf_ls_upd_packet_new) New function, allocate upd packet
1667 taking oversized LSAs into account.
1668 (ospf_ls_upd_queue_send) use ospf_ls_upd_packet_new to allocate,
1669 rather than statically allocating mtu sized packet buffer, which
1670 actually was wrong - it didnt take ip header into account, which
1671 should not be included in packet buffer.
1672 (ospf_ls_upd_send_queue_event) minor tweaks and remove
1673 TODO comment.
1674
gdt630e4802004-08-31 17:28:41 +000016752004-08-31 David Wiggins <dwiggins@bbn.com>
1676
1677 * ospf_spf.c (ospf_spf_calculate): Many more comments and debug
1678 print statements. New function ospf_vertex_dump used in debugging.
1679
16802004-08-31 David Wiggins <dwiggins@bbn.com>
1681
1682 * ospf_spf.h (struct vertex): Comments for flags and structure members.
1683
16842004-08-31 David Wiggins <dwiggins@bbn.com>
1685
1686 * ospf_route.c: When finding an alternate route, log cost as well.
1687
16882004-08-31 David Wiggins <dwiggins@bbn.com>
1689
1690 * ospf_interface.c (ospf_lookup_if_params): Initialize af in
1691 struct prefix allocated on stack.
1692
16932004-08-31 David Wiggins <dwiggins@bbn.com>
1694
1695 * ospf_packet.c (ospf_ls_ack_send_delayed): In p2mp mode, send
1696 acks to AllSPFRouters, rather than All-DR.
1697
hasso7b901432004-08-31 13:37:42 +000016982004-08-27 Hasso Tepper <hasso at quagga.net>
1699
1700 * ospf_vty.c: Don't print ospf network type under interface only
1701 if interface is in broadcast mode and interface type really is
1702 broadcast. Fixes Bugzilla #108.
1703
gdtd7d93992004-08-27 12:03:42 +000017042004-08-27 David Wiggins <dwiggins@bbn.com>
1705
1706 * ospf_spf.c (ospf_nexthop_calculation): Initialize address family
1707 in on-stack struct prefix_ipv4. Fixes point-to-multipoint SPF
1708 calculation.
1709
gdtd0deca62004-08-26 13:14:07 +000017102004-08-26 Greg Troxel <gdt@fnord.ir.bbn.com>
1711
1712 * ospf_packet.c (ospf_recv_packet): adjust size declaration of
gdtd7d93992004-08-27 12:03:42 +00001713 buffer used to get interface index so that it compiles on other
1714 than Linux and includes the required alignment space. Probably
1715 this was only working on sparc/sparc64 because most of
1716 sockaddr_dl was not being written.
gdtd0deca62004-08-26 13:14:07 +00001717
paul863082d2004-08-19 04:43:43 +000017182004-08-19 Paul Jakma <paul@dishone.st>
1719
1720 * ospf_packet.c: update to match sockopt renames.
1721
paul75ee0b82004-08-05 09:10:31 +000017222004-08-04 Paul Jakma <paul@dishone.st>
1723
1724 * ospf_spf.c: (ospf_spf_consider_nexthop) Add comment about issue.
1725 Compare only against list head - all nexthops must be same cost
1726 anyway, fixes a reference-listnode-after-delete bug noted by
1727 Kir Kostuchenko.
1728 (ospf_nexthop_calculation) Use ospf_spf_consider_nexthop for all
1729 candidates attached to root.
1730
paul36c64ef2004-07-27 11:19:11 +000017312004-07-27 Paul Jakma <paul@dishone.st>
1732
paul48fe13b2004-07-27 17:40:44 +00001733 * ospf_packet.c: (ospf_ls_upd_send_queue_event) fix thinko from
1734 last fix for ospfd wedging due to oversize LSAs: dont list loop on
1735 ospf_ls_upd_queue_send() - guaranteed segfault.
1736
17372004-07-27 Paul Jakma <paul@dishone.st>
1738
paul36c64ef2004-07-27 11:19:11 +00001739 * ospf_opaque.c: (ospf_opaque_lsa_flush_schedule) do not NULL out
1740 the LSA as then free_opaque_info_per_id() can never unlock (and
1741 free) the LSA. Reported by Gunnar Stigen.
1742
paul2dd8bb42004-07-23 15:13:48 +000017432004-07-23 Paul Jakma <paul@dishone.st>
1744
1745 * ospf_network.c: Replace PKTINFO/RECVIF with call to
1746 setsockopt_pktinfo
1747 * ospf_packet.c: Use getsockopt_pktinfo_ifindex and
1748 SOPT_SIZE_CMSG_PKTINFO_IPV4.
1749
paul59ea14c2004-07-14 20:50:36 +000017502004-07-14 Paul Jakma <paul@dishone.st>
1751
1752 * ospf_packet.c: (ospf_ls_upd_send_queue_event) Partial fix for
1753 problem reported by Peter Frost amongst others, where function
1754 will spin indefinitely if update list contains LSAs greater than
1755 MTU-headers or other condition leading to update list never being
1756 cleared. Problem of what to do with these LSAs remains.
1757 (ospf_make_ls_upd) add comment about large LSA problem,
1758 indentation cleanup.
1759
gdtb2c1b282004-07-01 12:35:36 +000017602004-07-01 Greg Troxel <gdt@fnord.ir.bbn.com>
1761
1762 * Makefile.am (lib_LTLIBRARIES): make libospf shared
1763
gdt87efd642004-06-30 17:36:11 +000017642004-06-30 Greg Troxel <gdt@poblano.ir.bbn.com>
1765
1766 * Makefile.am: Add shlib support.
1767
hassobeebba72004-06-20 21:00:27 +000017682004-06-10 Hasso Tepper <hasso@estpak.ee>
1769
1770 * *: Removed ifdefs HAVE_NSSA.
1771
paul553ff112004-06-06 09:41:00 +000017722004-06-06 Paul Jakma <paul@dishone.st>
1773
1774 * ospf_dump.c,ospf_lsa.c: Fix typos of merge of previous.
1775 ospf_flood.c: (ospf_process_self_originated_lsa) fix zlog format
1776
paul0c2be262004-05-31 14:16:54 +000017772004-05-31 Sagun Shakya <sagun.shakya@sun.com>
1778
1779 * ospf_dump.c: (ospf_lsa_header_dump) LOOKUP can return null if
1780 index is out of range.
1781 ospf_flood.c: endianness fix
1782 ospf_lsa.c: Missing ntohl's on (struct lsa *)->data->ls_seqnum
1783 in various places.
1784
hassodd669bb2004-05-10 07:43:59 +000017852004-05-10 Hasso Tepper <hasso@estpak.ee>
1786
1787 * ospf_zebra.c, ospfd.c: Move ospf_prefix_list_update() function
1788 to ospf_zebra.c from ospfd.c and add redistribution updates if
1789 route-map is used in redistribution.
1790 * ospf_main.c: Remove now useless call to ospf_init().
1791
paul0a589352004-05-08 11:48:26 +000017922004-05-08 Paul Jakma <paul@dishone.st>
1793
1794 * ospf_zebra.c: Sync with lib/zclient changes
1795
pauld3f0d622004-05-05 15:27:15 +000017962004-05-05 Paul Jakma <paul@dishone.st>
1797
paul5bd41892004-05-05 17:29:24 +00001798 * ospf_network.c: (ospf_sock_init) Check whether IP_HDRINCL is
1799 defined. Warn at compile and runtime. Use
1800 IPTOS_PREC_INTERNETCONTROL otherwise.
pauld3f0d622004-05-05 15:27:15 +00001801 * ospf_packet.c: (ospf_associate_packet_vl) cleanup, move
1802 some of the checks up to ospf_read, return either a
1803 virtual link oi, or NULL.
1804 (ospf_read) Cleanup, make it responsible for checks. Remove
1805 the nbr lookup - moved to ospf_neighbor. Adjust all nbr
1806 lookups to use new wrappers exported by ospf_neighbor.
1807 * ospf_neighbor.h: Add ospf_neigbour_get and ospf_nbr_lookup.
1808 * ospf_neighbor.c: (ospf_neigbour_get) Index ospf_interface
1809 neighbour table by router-id for virtual-link ospf_interfaces,
1810 not by peer_addr (which breaks for asymmetric vlinks)
1811 (ospf_nbr_lookup) add a wrapper for nbr lookups to deal with
1812 above.
paulcd59da62004-05-05 17:26:55 +00001813 * ospf_interface.c: (ospf_vl_set_params) Catch changes of interface
1814 address for either end of a virtual-link, and hence potential cost
1815 changes.
1816
hassoa0a39762004-04-23 08:51:10 +000018172004-04-22 Hasso Tepper <hasso@estpak.ee>
1818
1819 * ospf_zebra.c: Don't ignore reject/bh routes, it's the only way
1820 to "summarize" routes in ASBR at the moment.
1821
hasso8585d4e2004-04-20 17:25:12 +000018222004-04-20 Hasso Tepper <hasso@estpak.ee>
1823
1824 * ospfd.c: Unset NP flag if area is going to be normal or stub.
1825 Fixes UNH OSPF_NSSA.1.2a comment.
1826 * ospf_abr.c: Originate default into stub/nssa area even if
1827 summaries are disabled.
1828 * ospf_zebra.c: Don't attempt to redistribute 127.0.0.0/8.
1829
hassoc266ac72004-04-19 17:31:00 +000018302004-04-19 Hasso Tepper <hasso@estpak.ee>
1831
1832 * ospf_vty.c: Don't warn that export- and import-list can't be
1833 configured to backbone area if they are applied and are working
1834 fine.
1835
hasso128d31d2004-04-04 12:52:33 +000018362004-02-19 Sowmini Varadhan <sowmini.varadhan@sun.com>
1837
1838 * ospf_packet.c: Don't drop packets in Solaris x86.
1839 [quagga-dev 1005].
1840
hasso0d85b992004-03-18 19:18:33 +000018412004-03-18 Amir Guindehi <amir@datacore.ch>
1842
1843 * ospf_opaque.c: Attempt to correct the incorrect behavior of
1844 Quagga's ospfd in the special situation that a node's opaque
1845 capability has changed as "ON -> OFF -> ON". [quagga-dev 843].
1846
paul7f352b82004-02-19 19:37:47 +000018472004-02-19 Sowmini Varadhan <sowmini.varadhan@sun.com>
1848
1849 * ospf_abr.c: (ospf_abr_update_aggregate) UNH 3.12b,c, address range
1850 should be configured with the highest cost path within the range,
1851 not lowest.
1852
paul940b01a2004-02-17 20:07:30 +000018532004-02-17 Paul Jakma <paul@dishone.st>
1854
1855 * ospf_zebra.c: (ospf_interface_delete) Do not delete the interface
1856 params, nor the interface structure, if an interface delete
1857 message is received from zebra.
1858 * ospf_interface.c: (ospf_if_delete_hook) Delete the interface
1859 params and interface, ie that which was previously removed in
1860 (ospf_interface_delete) above.
1861
hasso2db3d052004-02-11 21:52:13 +000018622004-02-11 Hasso Tepper <hasso@estpak.ee>
1863 * ospf_interface.c, ospf_zebra.c: Don't attempt to read path->oi->ifp
1864 if oi doesn't exist any more.
1865
hassocb05eb22004-02-11 21:10:19 +000018662004-02-11 Vadim Suraev <vadim.suraev@terayon.com>
1867 * ospf_packet.c (ospf_ls_upd): Router should flush received network
1868 LSA if it was originated with older router-id ([zebra 14710] #6).
1869
18702003-12-08 Mattias Amnefelt <mattiasa@kth.se>
paul239aecc2003-12-08 10:34:54 +00001871
1872 * ospf_packet.c: (ospf_recv_packet) OpenBSD now leaves iph.ip_len
1873 network byte order.
1874
gdt8f40e892003-12-05 14:01:43 +000018752003-12-05 Greg Troxel <gdt@poblano.ir.bbn.com>
1876
1877 * ospfd.c (ospf_network_match_iface): Rewrite code for clarity
1878 while trying not to change semantics. Add ifdefed-out code to
1879 avoid matching ppp interfaces whose destination address does not
1880 also match the prefix under consideration, to help out people with
1881 problems due to as-yet-unfixed bugs with p2p interfaces coming and
1882 going.
1883
paul736d3442003-07-24 23:22:57 +000018842003-07-25 kamatchi soundaram <kamatchi@tdd.sj.nec.com>
1885
1886 * ospf_packet.c (ospf_ls_upd_send_queue_event): get next route
1887 node in body of the loop to avoid chance that route node
1888 is unlocked and deleted before the next iteration tries to
1889 get next route node.
1890
paul0a825c72003-05-24 13:48:16 +000018912003-05-24 Kenji Yabuuchi
1892
1893 * ospf_interface.c(ospf_if_lookup_recv_if): Use the most specific
1894 match for interface lookup.
1895
paul551a8972003-05-18 15:22:55 +000018962003-05-18 Hasso Tepper <hasso@estpak.ee>
paul445f1432003-05-16 19:00:31 +00001897
paul551a8972003-05-18 15:22:55 +00001898 * ospf_vty.c: Show NSSA LSA route info in "show ip ospf database"
1899 output
paul445f1432003-05-16 19:00:31 +00001900
pauld7480322003-05-16 17:31:51 +000019012003-05-16 Hasso Tepper <hasso@estpak.ee>
1902
1903 * ospf_lsa.c: Fix handling of NSSA
1904
paul551a8972003-05-18 15:22:55 +000019052003-04-23 Hasso Tepper <hasso@estpak.ee>
1906
1907 * ospf_vty.c: fix "router xxx" node commands in vtysh
1908
paul445f1432003-05-16 19:00:31 +000019092003-04-19 Hasso Tepper <hasso@estpak.ee>
1910
1911 * {ospf_abr,ospfd}.c: area id's DECIMAL -> ADDRESS
1912 * ospf_routemap.c: sync daemon's route-map commands to have same
1913 syntax.
1914
19152003-04-19 Sergey Vyshnevetskiy <serg@vostok.net>
1916
1917 * ospf_packet.c: Add missing param to zlog
1918 * ospf_flood.c: remove unused vars
1919
19202003-04-17 Denis Ovsienko <zebra@pilot.org.ua>
1921
1922 * ospf_interface.c: fix incorrect memset
1923
paul28a13842003-05-16 20:30:37 +000019242003-04-10 Amir Guindehi <amir@datacore.ch>
paul445f1432003-05-16 19:00:31 +00001925
1926 * ospf_lsa.[ch]: opaque LSA fix, use ospf_lookup.
1927
19282003-04-03 David Watson <dwatson@eecs.umich.edu>
1929
1930 * ospf_lsa.c: byte order fix
1931
paul07661cb2003-03-18 00:03:05 +000019322002-03-17 Amir Guindehi <amir@datacore.ch>
1933
1934 * ospf_apiserver.[ch]: Merge Ralph Keller's OSPFAPI support.
1935 * ospf_api.[ch]: Merge Ralph Keller's OSPFAPI support.
1936 * ospfclient: OSPFAPI demonstration client.
1937
19382003-01-23 Masahiko Endo <endo@suri.co.jp>
1939
1940 * ospf_ism.c: NSM event schedule bug fix.
1941
19422002-10-30 Greg Troxel <gdt@ir.bbn.com>
1943
1944 * ospf_packet.c (ospf_make_md5_digest): MD5 length fix.
1945
paul718e3742002-12-13 20:15:29 +000019462002-10-23 endo@suri.co.jp (Masahiko Endo)
1947
1948 * ospf_opaque.c: Update Opaque LSA patch.
1949
19502002-10-23 Ralph Keller <keller@tik.ee.ethz.ch>
1951
1952 * ospf_vty.c (show_ip_ospf_database): Fix CLI parse.
1953
19542002-10-23 Juris Kalnins <juris@mt.lv>
1955
1956 * ospf_interface.c (ospf_if_stream_unset): When write queue
1957 becomes empty stop write timer.
1958
19592002-10-10 Greg Troxel <gdt@ir.bbn.com>
1960
1961 * ospf_packet.c (ospf_check_md5_digest): Change >= to > to make it
1962 conform to RFC.
1963
19642002-07-07 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1965
1966 * zebra-0.93 released.
1967
19682002-06-19 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1969
1970 * ospf_spf.c (ospf_nexthop_calculation): Add NULL set to oi and
1971 check of l2. Reported by: Daniel Drown <dan-zebra@drown.org>
1972 (ospf_lsa_has_link): LSA Length calculation fix. Reported by:
1973 Paul Jakma <paulj@alphyra.ie>.
1974
1975 * ospfd.c (ospf_if_update): Fix nextnode reference bug. Reported
1976 by: juris@mt.lv.
1977
19782002-01-21 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1979
1980 * ospfd.c: Merge [zebra 11445] Masahiko ENDO's Opaque-LSA support.
1981
19822001-08-27 Kunihiro Ishiguro <kunihiro@zebra.org>
1983
1984 * ospf_interface.c (ospf_add_to_if): Use /32 address to register
1985 OSPF interface information.
1986 (ospf_delete_from_if): Likewise.
1987
1988 * ospf_zebra.c (ospf_interface_address_delete): Likewise.
1989
19902001-08-23 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1991
1992 * ospf_zebra.c (ospf_redistribute_unset): When redistribute type
1993 is OSPF, do not unset redistribute flag.
1994
19952001-08-19 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1996
1997 * zebra-0.92a released.
1998
19992001-08-15 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
2000
2001 * zebra-0.92 released.
2002
20032001-08-12 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
2004
2005 * ospfd.c (ospf_config_write): auto-cost reference-bandwidth
2006 configuration display.
2007
20082001-07-24 David Watson <dwatson@eecs.umich.edu>
2009
2010 * ospf_spf.c (ospf_spf_next): Modify ospf_vertex_add_parent to
2011 check for an existing link before connecting the parent and child.
2012 ospf_nexthop_calculation is also modified to check for duplicate
2013 entries when copying from the parent. Finally, ospf_spf_next
2014 removes duplicates when it merges two equal cost candidates.
2015
20162001-07-23 itojun@iijlab.net
2017
2018 * ospfd.c (show_ip_ospf_neighbor): Check ospf_top before use it
2019 [zebra 8549].
2020
20212001-07-23 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
2022
2023 * ospf_packet.c (ospf_write): Remove defined(__OpenBSD__) to make
2024 it work on OpenBSD.
2025
20262001-06-26 Kunihiro Ishiguro <kunihiro@zebra.org>
2027
2028 * ospf_zebra.c (config_write_ospf_default_metric): Display
2029 default-metric configuration.
2030
20312001-06-18 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
2032
2033 * ospf_ia.h (OSPF_EXAMINE_SUMMARIES_ALL): Remove old macros.
2034
20352001-05-28 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
2036
2037 * ospf_snmp.c (ospfIfEntry): Fix interface lookup bug to avoid
2038 crush.
2039 (ospfIfMetricEntry): Likewise.
2040
20412001-03-18 Kunihiro Ishiguro <kunihiro@zebra.org>
2042
2043 * ospf_packet.c (ospf_read): Fix typo. Reported by: "Jen B
2044 Lin'Kova" <jen@stack.net>.
2045
20462001-03-15 Gleb Natapov <gleb@nbase.co.il>
2047
2048 * ospf_interface.c (ip_ospf_network): Set interface parameter.
2049 (interface_config_write): Add check for OSPF_IFTYPE_LOOPBACK.
2050
2051 * ospf_zebra.c (ospf_interface_add): Set interface parameter.
2052
20532001-02-21 Kunihiro Ishiguro <kunihiro@zebra.org>
2054
2055 * ospf_packet.c (ospf_recv_packet): Solaris also need to add
2056 (iph.ip_hl << 2) to iph.ip_len.
2057
20582001-02-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2059
2060 * ospfd.h (OSPF_LS_REFRESH_TIME): Fix OSPF_LS_REFRESH_TIME value.
2061 Suggested by: David Watson <dwatson@eecs.umich.edu>.
2062
2063 * ospf_zebra.c (zebra_init): Remove zebra node.
2064
2065 * ospfd.c (ospf_area_range_set): Function name is changed from
2066 ospf_ara_range_cmd.
2067 (ospf_area_range_unset): New function which separated from DEFUN.
2068 New commands are added:
2069 "no area A.B.C.D range A.B.C.D/M advertise"
2070 "no area <0-4294967295> range A.B.C.D/M advertise"
2071 "no area A.B.C.D range A.B.C.D/M not-advertise"
2072 "no area <0-4294967295> range A.B.C.D/M not-advertise"
2073
2074 * ospf_lsa.c (ospf_lsa_more_recent): Fix previous change.
2075
20762001-02-08 Matthew Grant <grantma@anathoth.gen.nz>
2077
2078 * ospf_network.c (ospf_if_add_allspfrouters): Use
2079 setsockopt_multicast_ipv4.
2080 (ospf_if_drop_allspfrouters): Likewise.
2081
2082 * ospf_lsa.c (ospf_router_lsa_install): Add rt_recalc flag.
2083 (ospf_network_lsa_install): Likewise.
2084 (ospf_summary_lsa_install): Likewise.
2085 (ospf_summary_asbr_lsa_install): Likewise.
2086 (ospf_external_lsa_install): Likewise.
2087 (ospf_lsa_install): Call ospf_lsa_different to check this LSA is
2088 new one or not.
2089
20902001-02-08 Kunihiro Ishiguro <kunihiro@zebra.org>
2091
2092 * ospf_zebra.c (ospf_interface_delete): Do not free interface
2093 structure when ospfd receive interface delete message to support
2094 pseudo interface.
2095
20962001-02-01 Dick Glasspool <dick@ipinfusion.com>
2097
2098 * ospfd.c (area_range_notadvertise): Change area range "suppress"
2099 command to "not-advertise".
2100
2101 * ospfd.h (OSPF_LS_REFRESH_TIME): Change OSPF_LS_REFRESH_TIME from
2102 1800 to 60.
2103
2104 * ospf_abr.c (ospf_abr_update_aggregate): When update_aggregate is
2105 updating the area-range, the lowest cost is now saved.
2106
2107 * ospf_lsa.c (ospf_lsa_more_recent): Routing to compare sequence
2108 numbers rather than creating overflow during calculation.
2109
21102001-02-01 Kunihiro Ishiguro <kunihiro@zebra.org>
2111
2112 * zebra-0.91 is released.
2113
21142001-01-31 Kunihiro Ishiguro <kunihiro@zebra.org>
2115
2116 * ospf_packet.c (ospf_db_desc_proc): Do not continue process when
2117 NSM_SeqNumberMismatch is scheduled.
2118 (ospf_ls_req): Free ls_upd when return from this function.
2119 (ospf_ls_upd_timer): When update list is empty do not call
2120 ospf_ls_upd_send(). Suggested by: endo@suri.co.jp (Masahiko
2121 Endo).
2122
21232001-01-26 Kunihiro Ishiguro <kunihiro@zebra.org>
2124
2125 * ospf_lsa.c (ospf_maxage_flood): Flood LSA when it reaches
2126 MaxAge. RFC2328 Section 14.
2127 (ospf_maxage_lsa_remover): Call above function during removing
2128 MaxAge LSA.
2129
21302001-01-26 Dick Glasspool <dick@ipinfusion.com>
2131
2132 * ospf_flood.c (ospf_flood_through_as): Function is updated for
2133 NSSA Translations now done at ospf_abr.c with no change in P-bit.
2134
2135 * ospf_lsa.c (ospf_get_nssa_ip): Get 1st IP connection for Forward
2136 Addr.
2137 (ospf_install_flood_nssa): Leave Type-7 LSA at Lock Count = 2.
2138
2139 * ospf_ase.c (ospf_ase_calculate_route): Add debug codes.
2140
2141 * ospf_abr.c (ospf_abr_translate_nssa): Recalculate LSA checksum.
2142
2143 * ospf_packet.h (OSPF_SEND_PACKET_LOOP): Added for test packet.
2144
2145 * ospf_dump.c (ospf_lsa_type_msg): Add OSPF_GROUP_MEMBER_LSA and
2146 OSPF_AS_NSSA_LSA.
2147
2148 * ospfd.c (data_injection): Function to inject LSA. This is
2149 debugging command.
2150
21512001-01-11 Kunihiro Ishiguro <kunihiro@zebra.org>
2152
2153 * ospf_route.c (ospf_route_match_same): Remove function.
2154 (ospf_route_match_same_new): Renamed to ospf_route_match_same.
2155
2156 * ospf_zebra.c (ospf_interface_address_delete): Add check for
2157 oi->address. Suggested by Matthew Grant
2158 <grantma@anathoth.gen.nz>.
2159 (ospf_zebra_add): Remove function.
2160 (ospf_zebra_add_multipath): Rename to ospf_zebra_add.
2161
2162 * ospf_interface.c: Remove HAVE_IF_PSEUDO part.
2163
2164 * ospf_zebra.c: Likewise.
2165
21662001-01-10 Kunihiro Ishiguro <kunihiro@zebra.org>
2167
2168 * ospf_ase.c: Remove OLD_RIB part.
2169
2170 * ospf_route.c: Likewise.
2171
2172 * zebra-0.90 is released.
2173
2174 * ospf_packet.c (ospf_recv_packet): Use ip_len adjestment code to
2175 NetBSD.
2176
21772001-01-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2178
2179 * ospf_route.c (ospf_route_delete): Use
2180 ospf_zebra_delete_multipath.
2181
21822001-01-09 Matthew Grant <grantma@anathoth.gen.nz>
2183
2184 * ospf_interface.c (ospf_if_cleanup): Function name is renamed
2185 from ospf_if_free(). Rewrite whole procudure to support primary
2186 address deletion.
2187
2188 * ospf_zebra.c (ospf_interface_address_delete): Add primary
2189 address deletion process.
2190
21912001-01-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2192
2193 * ospf_packet.c (ospf_recv_packet): OpenBSD has same ip_len
2194 treatment like FreeBSD.
2195
21962001-01-09 endo@suri.co.jp (Masahiko Endo)
2197
2198 * ospf_packet.c (ospf_recv_packet): FreeBSD kernel network code
2199 strips IP header size from receiving IP Packet. So we adjust
2200 ip_len to whole IP packet size by adding IP header size.
2201
22022001-01-08 endo@suri.co.jp (Masahiko Endo)
2203
2204 * ospf_network.c (ospf_serv_sock): When socket() is failed return
2205 immediately.
2206 (ospf_serv_sock): Close socket when it is not used.
2207
2208 * ospf_packet.c (ospf_write): Set sin_len when HAVE_SIN_LEN is
2209 defined.
2210 (ospf_write): When bind is fined, close sock.
2211
22122001-01-07 Gleb Natapov <gleb@nbase.co.il>
2213
2214 * ospf_zebra.c (ospf_interface_state_up): Fixes coredump that
2215 appears when you try to configure bandwidth on the ppp interface
2216 that is not yet configured in ospfd.
2217
22182001-01-07 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2219
2220 * ospf_route.c (show_ip_ospf_route_external): "show ip ospf route"
2221 will print nexthops for AS-external routes.
2222
2223 * ospf_ase.c (ospf_ase_route_match_same): New function to compare
2224 ASE route under multipath environment.
2225 (ospf_ase_compare_tables): Likewise.
2226
22272001-01-01 Kunihiro Ishiguro <kunihiro@zebra.org>
2228
2229 * ospfd.h (OSPF_VTYSH_PATH): Change "/tmp/ospfd" to "/tmp/.ospfd".
2230
22312000-12-28 Kunihiro Ishiguro <kunihiro@zebra.org>
2232
2233 * ospf_route.c (ospf_route_install): Install multipath information
2234 to zebra daemon.
2235
2236 * ospf_zebra.c (ospf_zebra_add_multipath): Function for passing
2237 multipath information to zebra daemon.
2238
22392000-12-25 Dick Glasspool <dick@ipinfusion.com>
2240
2241 * ospf_packet.c (ospf_write): Call ospf_packet_delete when sendto
2242 fail.
2243 (DISCARD_LSA): Add argument N for logging point of DISCARD_LSA is
2244 called.
2245
2246 * ospf_lsa.c (ospf_external_lsa_refresh): NSSA install_flood will
2247 leave Type-7 LSA at Lock Count = 2.
2248
2249 * ospf_flood.c (ospf_flood_through): Flood_though_as updated for
2250 NSSA no P-bit off during Area flooding, but P-bit is turned off
2251 for mulitple NSSA AS flooding.
2252
2253 * ospf_ase.c (ospf_ase_calculate_timer): Added calculations for
2254 Type-7 LSDB.
2255
2256 * ospf_abr.c (ospf_abr_translate_nssa): Removed one unlock call.
2257 (ospf_abr_announce_nssa_defaults): Corrected Debug from EVENT to
2258 NSSA.
2259
22602000-12-25 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2261
2262 * ospf_zebra.c (ospf_zebra_read_ipv4): Checking the age of the
2263 found LSA and if the LSA is MAXAGE we should call refresh instead
2264 of originate.
2265
22662000-12-18 Dick Glasspool <dick@ipinfusion.com>
2267
2268 * ospf_abr.c: Removed redundant "...flood" in
2269 announce_network_to_area(). Repaired nssa Unlock by using
2270 discard.
2271
2272 * ospf_packet.c: Removed old NSSA translate during mk_ls_update.
2273
2274 * ospfd.c: Free up all data bases including NSSA.
2275
2276 * ospf_lsa.c: Now allow removal of XLATE LSA's Check in
2277 discard_callback. Added routine to get ip addr from within the
2278 ifp.
2279
2280 * ospf_flood.c: Now set Forward Address for outgoing Type-7.
2281
2282 * ospf_lsa.h: Added prototype for the below. struct in_addr
2283 ospf_get_ip_from_ifp (struct interface *ifp).
2284
22852000-12-14 Gleb Natapov <gleb@nbase.co.il>
2286
2287 * ospf_packet.c (ospf_recv_packet): New OSPF pakcet read method.
2288 Now maximum packet length may be 65535 bytes (maximum IP packet
2289 length).
2290
2291 * ospf_interface.c (ospf_if_stream_set): Don't make input buffer.
2292
2293 * ospfd.c (config_write_network_area): Remove unnecessary area
2294 lookup code.
2295
22962000-12-13 Kunihiro Ishiguro <kunihiro@zebra.org>
2297
2298 * ospf_packet.c (ospf_read): Accept packet bigger than MTU value.
2299
23002000-12-13 Gleb Natapov <gleb@nbase.co.il>
2301
2302 * ospfd.c (config_write_network_area): Fix bug in
2303 config_write_network_area function.
2304
23052000-12-12 Gleb Natapov <gleb@nbase.co.il>
2306
2307 * ospf_abr.c (ospf_abr_announce_network_to_area): Make Summary
2308 LSA's origination and refreshment as same as other type of LSA.
2309
2310 * ospf_lsa.c (ospf_summary_lsa_refresh): Return struct ospf_lsa *.
2311
2312 * ospf_lsa.c (ospf_summary_asbr_lsa_refresh): Likewise.
2313
23142000-12-08 Dick Glasspool <dick@ipinfusion.com>
2315
2316 The bulk of NSSA changes are contained herein; This version will
2317 require manual setting of "always" for NSSA Translator, and will
2318 not perform aggregation yet.
2319
2320 * ospf_dump.c: "debug ospf nssa" is added.
2321
2322 * ospf_dump.h: Likewise.
2323
2324 * ospf_packet.c (ospf_hello): Display router ID on Bad NSSA Hello.
2325
2326 * ospfd.c: Discard_LSA to stay away from LOCAL_XLT Process NSSA
2327 'never, candidate, always'. Change "suppress" to "not-advertise".
2328
2329 * ospfd.h: Add TranslatorRole to struct ospf_area. Add anyNSSA to
2330 struct ospf.
2331
2332 * ospf_ase.c (ospf_ase_calculate_route): External to stay away
2333 from LOCAL_XLT
2334
2335 * ospf_nsm.c (ospf_db_summary_add): External to stay away from
2336 LOCAL_XLT
2337
2338 * ospf_abr.c: Major logic added for abr_nssa_task(). If ABR, and
2339 NSSA translator, then do it. Approve the global list, and flush
2340 any unapproved.
2341
2342 * ospf_lsa.h: New LSA flag OSPF_LSA_LOCAL_XLT to indicate that the
2343 Type-5 resulted from a Local Type-7 translation; not used for
2344 flooding, but used for flushing.
2345
2346 * ospf_flood.c: New NSSA flooding.
2347
23482000-12-08 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2349
2350 * ospfd.c (ospf_find_vl_data): New function for looking up virtual
2351 link data.
2352 (ospf_vl_set_security): Virtual link configuration with
2353 authentication.
2354 (ospf_vl_set_timers): Set timers for virtual link.
2355
2356 * New commands are added.
2357 "area A.B.C.D virtual-link A.B.C.D"
2358 "area A.B.C.D virtual-link A.B.C.D hello-interval <1-65535> retransmit-interval <3-65535> transmit-delay <1-65535> dead-interval <1-65535>"
2359 "area A.B.C.D virtual-link A.B.C.D hello-interval <1-65535> retransmit-interval <3-65535> transmit-delay <1-65535> dead-interval <1-65535> authentication-key AUTH_KEY"
2360 "area A.B.C.D virtual-link A.B.C.D authentication-key AUTH_KEY"
2361 "area A.B.C.D virtual-link A.B.C.D hello-interval <1-65535> retransmit-interval <3-65535> transmit-delay <1-65535> dead-interval <1-65535> message-digest-key <1-255> md5 KEY"
2362 "area A.B.C.D virtual-link A.B.C.D message-digest-key <1-255> md5 KEY"
2363
2364 * ospf_packet.c (ospf_check_md5_digest): Add neighbor's
2365 cryptographic sequence number treatment.
2366 (ospf_check_auth): OSPF input buffer is added to argument.
2367 (ospf_read): Save neighbor's cryptographic sequence number.
2368
2369 * ospf_nsm.c (nsm_change_status): Clear cryptographic sequence
2370 number when neighbor status is changed to NSM down.
2371
2372 * ospf_neighbor.c (ospf_nbr_new): Set zero to crypt_seqnum.
2373
2374 * ospf_neighbor.h (struct ospf_neighbor): Add cryptographic
2375 sequence number to neighbor structure.
2376
23772000-11-29 Kunihiro Ishiguro <kunihiro@zebra.org>
2378
2379 * ospf_snmp.c (ospfIfLookup): OSPF MIB updates.
2380 (ospfExtLsdbEntry): Add OspfExtLsdbTable treatment.
2381
23822000-11-28 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2383
2384 * ospfd.c (ospf_interface_down): Clear a ls_upd_queue queue of the
2385 interface.
2386 (ospf_ls_upd_queue_empty): New function to empty ls update queue
2387 of the OSPF interface.
2388 (no_router_ospf): 'no router ospf' unregister redistribution
2389 requests from zebra.
2390
23912000-11-28 Kunihiro Ishiguro <kunihiro@zebra.org>
2392
2393 * ospf_ism.c (ism_change_status): Increment status change number.
2394
2395 * ospf_interface.h (struct ospf_interface): Add new member for
2396 status change statistics.
2397
2398 * Makefile.am: Update dependencies.
2399
2400 * ospf_zebra.c (ospf_interface_add): OSPF SNMP interface update.
2401 (ospf_interface_delete): OSPF SNMP interface delete.
2402
2403 * ospf_snmp.h: New file is added.
2404
24052000-11-23 Dick Glasspool <dick@ipinfusion.com>
2406
2407 * ospfd.h: Add new ospf_area structure member for
2408 NSSATranslatorRole and NSSATranslator state.
2409
2410 * ospfd.c: Provided for eventual commands to specify NSSA
2411 elections for "translator- ALWAYS/NEVER/CANDIDATE". Provided for
2412 decimal integer version of area-suppress.
2413
2414 * ospf_flood.c: Flood Type-7's only into NSSA (not AS).
2415
2416 * ospf_lsa.c: Undo some previous changes for NSSA. If NSSA
2417 translator, advertise Nt bit.
2418
2419 * ospf_route.c: 1st version of "sh ip os border-routers".
2420
24212000-11-23 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2422
2423 * ospfd.c (area_vlink): Virtual link can not configured in stub
2424 area.
2425
24262000-11-23 Gleb Natapov <gleb@nbase.co.il>
2427
2428 * ospf_packet.c (ospf_db_desc): In states Loading and Full the
2429 slave must resend its last Database Description packet in response
2430 to duplicate Database Description packets received from the
2431 master. For this reason the slave must wait RouterDeadInterval
2432 seconds before freeing the last Database Description packet.
2433 Reception of a Database Description packet from the master after
2434 this interval will generate a SeqNumberMismatch neighbor
2435 event. RFC2328 Section 10.8
2436 (ospf_make_db_desc): DD Master flag treatment.
2437
2438 * ospf_nsm.c (nsm_twoway_received): Move DD related procedure to
2439 nsm_change_status().
2440 (nsm_bad_ls_req): Likewise.
2441 (nsm_adj_ok): Likewise.
2442 (nsm_seq_number_mismatch): Likewise.
2443 (nsm_oneway_received): Likewise.
2444
2445 * ospf_neighbor.h (struct ospf_neighbor): New structure member
2446 last_send_ts for timestemp when last Database Description packet
2447 was sent.
2448
2449 * ospf_nsm.c (ospf_db_desc_timer): Make it sure nbr->last_send is
2450 there. Call ospf_db_desc_resend() in any case.
2451
24522000-11-16 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2453
2454 * ospf_lsa.c (lsa_link_broadcast_set): When there is no DR on
2455 network (suppose you have only one router with interface priority
2456 0). It's router LSA does not contain the link information about
2457 this network.
2458
2459 * ospf_nsm.c (nsm_timer_set): When you change a priority of
2460 interface from/to 0 ISM_NeighborChange event should be scheduled
2461 in order to elect new DR/BDR on the network.
2462
2463 * ospf_interface.c (ip_ospf_priority): Likewise.
2464
2465 * ospf_flood.c (ospf_ls_retransmit_add): When we add some LSA into
2466 retransmit list we need to check whether the present old LSA in
2467 retransmit list is not more recent than the new
2468 one.
2469
24702000-11-09 Dick Glasspool <dick@ipinfusion.com>
2471
2472 * ospf_packet.c: Allows for NSSA Type-7 LSA's throughout the NSSA
2473 area. Any that exit the NSSA area are translated to type-5 LSA's.
2474 The instantiated image is restored after translation.
2475 (ospf_ls_upd_send_list): Renamed to ospf_ls_upd_queu_send().
2476 (ospf_ls_upd_send): Old function which enclosed by #ifdef 0 is
2477 removed.
2478 (ospf_ls_ack_send): Likewise.
2479
2480 * ospf_flood.c: NSSA-LSA's without P-bit will be restricted to
2481 local area. Otherwise they are allowed out the area to be
2482 translated by ospf_packet.c.
2483
2484 * ospf_lsa.c: Undo some previous changes for NSSA.
2485
2486 * ospf_lsdb.h: New access for type 7.
2487
24882000-11-07 Kunihiro Ishiguro <kunihiro@zebra.org>
2489
2490 * ospf_route.c (ospf_path_exist): New function to check nexthop
2491 and interface are in current OSPF path or not.
2492 (ospf_route_copy_nexthops_from_vertex): Add nexthop to OSPF path
2493 when it is not there. Reported by Michael Rozhavsky
2494 <mrozhavsky@opticalaccess.com>
2495
24962000-11-06 Kunihiro Ishiguro <kunihiro@zebra.org>
2497
2498 * ospf_dump.c (config_write_debug): Add seventh string "detail" is
2499 added for flag is OSPF_DEBUG_SEND | OSPF_DEBUG_RECV |
2500 OSPF_DEBUG_DETAIL.
2501
25022000-11-06 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2503
2504 * ospf_lsa.c (router_lsa_flags): ASBR can't exit in stub area.
2505
25062000-11-06 Kunihiro Ishiguro <kunihiro@zebra.org>
2507
2508 * ospf_lsa.c (ospf_router_lsa_originate): Reduce unconditional
2509 logging.
2510
25112000-11-06 Dick Glasspool <dick@ipinfusion.com>
2512
2513 * ospfd.h: Add ait_ntoa function prototype.
2514
2515 * ospfd.c (ait_ntoa): New function for displaying area ID and
2516 Stub/NSSA status.
2517 (show_ip_ospf_interface_sub): Use ait_ntoa.
2518 (show_ip_ospf_nbr_static_detail_sub): Likewise.
2519 (show_ip_ospf_neighbor_detail_sub): Likewise.
2520
2521 * ospf_route.c (ospf_intra_route_add): Set external routing type
2522 to ospf route.
2523 (ospf_intra_add_router): Likewise.
2524 (ospf_intra_add_transit): Likewise.
2525 (ospf_intra_add_stub): Likewise.
2526 (ospf_add_discard_route): Likewise.
2527 (show_ip_ospf_route_network): Use ait_ntoa.
2528 (show_ip_ospf_route_network): Likewise.
2529 (show_ip_ospf_route_router): Likewise.
2530
2531 * ospf_lsa.c (show_lsa_detail): Use ait_ntoa.
2532 (show_lsa_detail_adv_router): Likewise.
2533 (show_ip_ospf_database_summary): Likewise.
2534
2535 * ospf_route.h (struct route_standard): Add new member
2536 external_routing.
2537
2538 * ospf_ia.c (process_summary_lsa): Set external routing tyep to ospf
2539 route.
2540 (ospf_update_network_route): Likewise.
2541 (ospf_update_router_route): Likewise.
2542
25432000-11-04 Kunihiro Ishiguro <kunihiro@zebra.org>
2544
2545 * ospf_flood.c (ospf_process_self_originated_lsa): Enclose
2546 OSPF_AS_NSSA_LSA treatment with #ifdef HAVE_NSSA.
2547
25482000-11-03 Kunihiro Ishiguro <kunihiro@zebra.org>
2549
2550 * Unconditional logging is enclosed with if (IS_DEBUG_OSPF_EVENT).
2551 Please specify "debug ospf event" for enable logging.
2552
2553 * ospf_ism.c: Do not extern debug flag varible. It is done by
2554 ospf_debug.h
2555 * ospf_asbr.c: Likewise.
2556 * ospf_lsa.c: Likewise.
2557 * ospf_nsm.c: Likewise.
2558 * ospf_zebra.c: Likewise.
2559
2560 * ospf_dump.c (debug_ospf_event): New command "debug ospf event"
2561 is added.
2562
2563 * ospfd.c (router_ospf): Change logging from vty_out() to
2564 zlog_info().
2565 (ospf_area_stub_cmd): Likewise.
2566
2567 * ospf_dump.h: Extern term_debug flags.
2568 (OSPF_DEBUG_EVENT): Add new flag.
2569 (IS_DEBUG_OSPF_EVENT): Add new macro.
2570
25712000-11-03 Dick Glasspool <dick@ipinfusion.com>
2572
2573 * ospf_flood.c (ospf_process_self_originated_lsa):
2574 OSPF_AS_NSSA_LSA is treated as same as OSPF_AS_EXTERNAL_LSA.
2575 (ospf_flood): Type-5's have no change. Type-7's can be received,
2576 and will Flood the AS as Type-5's They will also flood the local
2577 NSSA Area as Type-7's. The LSDB will be updated as Type-5's, and
2578 during re-fresh will be converted back to Type-7's (if within an
2579 NSSA).
2580 (ospf_flood_through): Incoming Type-7's were allowed here if our
2581 neighbor was an NSSA. So Flood our area with the Type-7 and also
2582 if we are an ABR, flood thru AS as Type-5.
2583
2584 * ospf_lsa.c (ospf_external_lsa_refresh): Flood NSSA both NSSA
2585 area and other area.
2586
2587 * ospf_packet.c (ospf_db_desc_proc): When AS External LSA is
2588 exists in DD packet, make it sure that this area is not stub.
2589 (ospf_ls_upd_list_lsa): When LSA type is NSSA then set lsa's area
2590 to NULL.
2591 (ospf_ls_upd): If the LSA is AS External LSA and the area is stub
2592 then discard the lsa. If the LSA is NSSA LSA and the area is not
2593 NSSA then discard the lsa.
2594
25952000-11-03 Kunihiro Ishiguro <kunihiro@zebra.org>
2596
2597 * ospfd.c (ospf_interface_run): Fix bug of Hello packet's option
2598 is not properly set when interface comes up.
2599
26002000-11-02 Kunihiro Ishiguro <kunihiro@zebra.org>
2601
2602 * ospfd.h (OSPF_OPTION_O): Add new hello header option.
2603
26042000-11-01 Dick Glasspool <dick@ipinfusion.com>
2605
2606 * ospf_lsa.h: Define OSPF_MAX_LSA to 8 when HAVE_NSSA is enabled.
2607 (OSPF_GROUP_MEMBER_LSA): Define OSPF_GROUP_MEMBER_LSA.
2608
2609 * ospf_lsa.c (show_database_desc): Add "Group Membership LSA"
2610 string.
2611
26122000-10-31 Dick Glasspool <dick@ipinfusion.com>
2613
2614 * ospf_lsa.h (OSPF_AS_NSSA_LSA): Define OSPF_AS_NSSA_LSA.
2615
2616 * ospf_lsa.c (show_ip_ospf_database): NSSA database display
2617 function is added. ALIASES which have "show ip ospf database
2618 nssa-external" is added.
2619 (show_ip_ospf_border_routers): New command "show ip ospf
2620 border-routers" is added.
2621
26222000-10-30 Dick Glasspool <dick@ipinfusion.com>
2623
2624 * ospfd.c (router_ospf): NSSA Enabled message is added for
2625 testing.
2626 (ospf_area_type_set): Are type set for NSSA area.
2627 (ospf_area_stub_cmd): Special translation of no_summary into NSSA
2628 and summary information. If NSSA is enabled pass the information
2629 to ospf_area_type_set().
2630 (area_nssa): New commands are added:
2631 "area A.B.C.D nssa"
2632 "area <0-4294967295> nssa"
2633 "area A.B.C.D nssa no-summary"
2634 "area <0-4294967295> nssa no-summary"
2635 (ospf_no_area_stub_cmd): Special translation of no_summary into
2636 NSSA and summary information. If external_routing is
2637 OSPF_AREA_NSSA unset area with ospf_area_type_set (area,
2638 OSPF_AREA_DEFAULT).
2639 (show_ip_ospf_area): Display NSSA status.
2640 (config_write_ospf_area): Show NSSA configuration.
2641
2642 * ospf_packet.c (ospf_hello): For NSSA support, ensure that NP is
2643 on and E is off.
2644
26452000-10-26 Gleb Natapov <gleb@nbase.co.il>
2646
2647 * ospf_lsa.c (ospf_network_lsa_body_set): The network-LSA lists
2648 those routers that are fully adjacent to the Designated Router;
2649 each fully adjacent router is identified by its OSPF Router ID.
2650 The Designated Router includes itself in this list. RFC2328,
2651 Section 12.4.2.
2652
26532000-10-23 Jochen Friedrich <jochen@scram.de>
2654
2655 * ospf_snmp.c: ospf_oid and ospfd_oid are used in smux_open after
2656 it is registered. So those variables must be static.
2657
26582000-10-18 K N Sridhar <sridhar@euler.ece.iisc.ernet.in>
2659
2660 * ospfd.c: Add area_default_cost_decimal_cmd and
2661 no_area_default_cost_decimal_cmd alias.
2662
26632000-10-05 Gleb Natapov <gleb@nbase.co.il>
2664
2665 * ospfd.c (ospf_network_new): Fix setting area format.
2666 (no_router_ospf): Check area existance when calling
2667 ospf_interface_down().
2668
2669 * ospf_flood.c (ospf_external_info_check): Fix bug of refreshing
2670 default route.
2671
26722000-10-02 Kunihiro Ishiguro <kunihiro@zebra.org>
2673
2674 * zebra-0.89 is released.
2675
26762000-09-29 Kunihiro Ishiguro <kunihiro@zebra.org>
2677
2678 * ospf_snmp.c (ospfHostEntry): OSPF Host MIB is implemented.
2679
2680 * ospfd.c (ospf_nbr_static_cmp): OSPF neighbor is sorted by it's
2681 address.
2682
26832000-09-28 Michael Rozhavsky <mike@nbase.co.il>
2684
2685 * ospf_interface.c (ospf_if_free): Fix deleting self neighbor twice.
2686
26872000-09-27 Kunihiro Ishiguro <kunihiro@zebra.org>
2688
2689 * ospf_packet.c (ospf_read): Solaris on x86 has ip_len with host
2690 byte order.
2691
26922000-09-25 Toshiaki Takada <takada@zebra.org>
2693
2694 * ospfd.c (ospf_compatible_rfc1583), (no_ospf_compatible_rfc1583):
2695 Add CISCO compatible command.
2696
26972000-09-25 Kunihiro Ishiguro <kunihiro@zebra.org>
2698
2699 * ospf_abr.c (ospf_area_range_lookup): New function is added for
2700 area range lookup in OSPF-MIB.
2701 (ospf_area_range_lookup_next): Likewise.
2702
27032000-09-22 Kunihiro Ishiguro <kunihiro@zebra.org>
2704
2705 * ospfd.c (no_router_ospf): Delete virtual link before deleting
2706 area structure.
2707
2708 * ospf_lsa.c (ospf_external_lsa_refresh_type): Check
2709 EXTERNAL_INFO(type).
2710
2711 * ospfd.c (no_router_ospf): Call ospf_vl_delete() instead of
2712 ospf_vl_data_free().
2713
2714 * ospf_interface.c (ospf_vl_shutdown): Execute ISM_InterfaceDown
2715 when ospf_vl_shutdown is called.
2716 (ospf_vl_delete): Call ospf_vl_shutdown() to delete virtual link
2717 interface's thread.
2718
27192000-09-21 Gleb Natapov <gleb@nbase.co.il>
2720
2721 * ospf_lsa.c: New implementation of OSPF refresh.
2722
27232000-09-20 Kunihiro Ishiguro <kunihiro@zebra.org>
2724
2725 * ospf_snmp.c (ospfLsdbLookup): Add LSDB MIB implementation.
2726
27272000-09-18 Kunihiro Ishiguro <kunihiro@zebra.org>
2728
2729 * ospf_snmp.c (ospfStubAreaEntry): Add OSPF stub area MIB.
2730
27312000-09-18 Gleb Natapov <gleb@nbase.co.il>
2732
2733 * ospf_route.h (route_standard): Change member from `struct area'
2734 to area_id.
2735
2736 * ospf_abr.c (ospf_abr_announce_network), (ospf_abr_should_announce),
2737 (ospf_abr_process_network_rt), (ospf_abr_announce_rtr),
2738 (ospf_abr_process_router_rt):
2739 * ospf_ase.c (ospf_find_asbr_route),
2740 (ospf_find_asbr_router_through_area),
2741 * ospf_ia.c (ospf_find_abr_route), (ospf_ia_router_route),
2742 (process_summary_lsa), (ospf_update_network_route),
2743 (ospf_update_router_route):
2744 * ospf_route.c (ospf_intra_route_add), (ospf_intra_add_router),
2745 (ospf_intra_add_transit), (ospf_intra_add_stub),
2746 (ospf_route_table_dump), (show_ip_ospf_route_network),
2747 (show_ip_ospf_route_router), (ospf_asbr_route_cmp),
2748 (ospf_prune_unreachable_routers):
2749 * ospf_spf.c (ospf_rtrs_print):
2750 * ospfd.c (ospf_rtrs_free): Fix the struct change above.
2751
27522000-09-14 Kunihiro Ishiguro <kunihiro@zebra.org>
2753
2754 * ospf_network.c (ospf_serv_sock_init): Enclose SO_BINDTODEVICE
2755 with ifdef.
2756
27572000-09-13 Gleb Natapov <gleb@nbase.co.il>
2758
2759 * ospf_ism.c (ospf_elect_dr), (ospf_elect_bdr): Fix DR election.
2760
2761 * ospf_network.c (ospf_serv_sock_init): Add socket option
2762 SO_BINDTODEVICE on read socket.
2763
2764 * ospf_packet.c (ospf_hello): Ignore Hello packet if E-bit does
2765 not match.
2766
2767 * ospfd.c (ospf_area_check_free), (ospf_area_get),
2768 (ospf_area_add_if): New function added.
2769
27702000-09-13 Kunihiro Ishiguro <kunihiro@zebra.org>
2771
2772 * ospf_route.c (ospf_intra_add_router): Update ABR and ASBR router
2773 count.
2774
2775 * ospf_spf.c (ospf_spf_init): Rest ABR and ASBR router count
2776 starting SPF calculation.
2777
2778 * ospfd.h (struct ospf_area): Add ABR and ASBR router count.
2779
27802000-09-12 Kunihiro Ishiguro <kunihiro@zebra.org>
2781
2782 * ospfd.c (ospf_area_id_cmp): New area structure is sorted by area
2783 ID.
2784
2785 * ospf_lsa.c (ospf_router_lsa_originate): For OSPF MIB update
2786 lsa_originate_count.
2787 (ospf_network_lsa_originate): Likewise.
2788 (ospf_summary_lsa_originate): Likewise.
2789 (ospf_summary_asbr_lsa_originate): Likewise.
2790 (ospf_external_lsa_originate): Likewise.
2791
27922000-09-11 Kunihiro Ishiguro <kunihiro@zebra.org>
2793
2794 * ospf_snmp.c (ospf_variables): ospfRouterID's type RouterID
2795 syntax is IpAddress.
2796 (ospf_admin_stat): New function for OSPF administrative status
2797 check.
2798
27992000-09-10 Jochen Friedrich <jochen@scram.de>
2800
2801 * ospf_snmp.c: Implement OSPF MIB skeleton.
2802
28032000-09-08 Kunihiro Ishiguro <kunihiro@zebra.org>
2804
2805 * ospf_snmp.c: New file is added.
2806
28072000-09-07 David Lipovkov <davidl@nbase.co.il>
2808
2809 * ospf_zebra.c (ospf_interface_delete): Add pseudo interface
2810 treatment.
2811
2812 * ospf_interface.c (interface_config_write): Likewise.
2813
28142000-08-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2815
2816 * zebra-0.88 is released.
2817
28182000-08-17 Michael Rozhavsky <mike@nbase.co.il>
2819
2820 * ospfd.c (ospf_area_free): Remove virtual link configuration only
2821 when Area is removed.
2822
28232000-08-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2824
2825 * ospfd.c (network_area): Revert check for EXTERNAL_INFO
2826 (ZEBRA_ROUTE_CONNECT).
2827 (no_network_area): Likewise.
2828
28292000-08-16 Kunihiro Ishiguro <kunihiro@zebra.org>
2830
2831 * ospfd.h (struct ospf): Add distance_table and
2832 distance_{all,intra,inter,external}.
2833
2834 * ospf_zebra.c: Add OSPF distance related functions.
2835
28362000-08-15 Gleb Natapov <gleb@nbase.co.il>
2837
2838 * ospf_asbr.c (ospf_external_info_find_lsa): New function added.
2839
2840 * ospf_lsa.c (ospf_default_external_info),
2841 (ospf_default_originate_timer), (ospf_external_lsa_refresh_default):
2842 New function added.
2843
2844 * ospf_zebra.c
2845 (ospf_default_information_originate_metric_type_routemap),
2846 (ospf_default_information_originate_always_metric_type_routemap):
2847 Change name and add route-map function.
2848 (ospf_default_information_originate_metric_routemap),
2849 (ospf_default_information_originate_routemap),
2850 (ospf_default_information_originate_type_metric_routemap):
2851 New DEFUN added.
2852
28532000-08-14 Kunihiro Ishiguro <kunihiro@zebra.org>
2854
2855 * ospf_zebra.c (zebra_interface_if_set_value): Change ifindex
2856 restore size from two octet to four.
2857
28582000-08-14 Michael Rozhavsky <mike@nbase.co.il>
2859
2860 * ospf_ase.c (ospf_ase_incremental_update): Implement incremental
2861 AS-external-LSA in 16.6 of RFC2328.
2862
28632000-08-14 Matthew Grant <grantma@anathoth.gen.nz>
2864
2865 * ospf_interface.c (ospf_if_get_output_cost): Change cost
2866 calculation algorithm.
2867
2868 * ospf_packet (ospf_ls_upd): Fix problem of LSA retransmitting.
2869
28702000-08-11 Michael Rozhavsky <mike@nbase.co.il>
2871
2872 * ospf_lsa.c (ospf_maxage_lsa_remover): Fix maxage remover for
2873 AS-external-LSAs.
2874
28752000-08-10 Toshiaki Takada <takada@zebra.org>
2876
2877 * ospfd.c (auto_cost_reference_bandwidth): New DEFUN added.
2878 `auto-cost reference-bandwidth' OSPF router command added.
2879
28802000-08-08 Gleb Natapov <gleb@nbase.co.il>
2881
2882 * ospf_routemap.c (ospf_route_map_update): New function added.
2883 Add route-map event hook.
2884
28852000-08-08 Toshiaki Takada <takada@zebra.org>
2886
2887 * ospf_zebra.c (ospf_distribute_check_connected): If redistribute
2888 prefix is connected route on OSPF enabled interface, suppress to
2889 announce it.
2890
28912000-08-08 Matthew Grant <grantma@anathoth.gen.nz>
2892
2893 * ospf_interface.c (ospf_if_get_output_cost):
2894 New function added. Handle bandwidth parameter for cost
2895 calculation.
2896
28972000-08-08 Michael Rozhavsky <mike@nbase.co.il>
2898
2899 * ospf_interface.c (interface_config_write): Show interface
2900 configuration regardless interface is down.
2901
2902 * ospf_ase.c (ospf_ase_caocluate_route): Whole rewritten external
2903 route calculate function.
2904
29052000-08-08 Gleb Natapov <gleb@nbase.co.il>
2906
2907 * ospf_routemap.c: New file added.
2908
2909 * ospf_asbr.c (ospf_reset_route_map_set_values),
2910 (ospf_route_map_set_compare): New function added.
2911
2912 * ospf_lsa.c (ospf_external_lsa_body_set): Set routemap metric
2913 with AS-external-LSA.
2914
29152000-08-05 Kunihiro Ishiguro <kunihiro@zebra.org>
2916
2917 * ospf_ase.c (ospf_ase_calculate_route_add): Pass new->cost to
2918 ospf_zebra_add as metric.
2919 (ospf_ase_calculate_route_add): Likewise.
2920
2921 * ospf_route.c (ospf_route_install): Pass or->cost to
2922 ospf_zebra_add as metric.
2923
2924 * ospf_zebra.c (ospf_zebra_add): Add metric arguemnt.
2925 (ospf_zebra_delete): Likewise.
2926
29272000-08-03 Matthew Grant <grantma@anathoth.gen.nz>
2928
2929 * ospf_flood.c (ospf_flood_delayed_lsa_ack): New function added.
2930 Dispatch delayed-ACK with flooding AS-external-LSA across virtual
2931 link.
2932
29332000-07-31 Matthew Grant <grantma@anathoth.gen.nz>
2934
2935 * ospfd.c (show_ip_ospf_area): Fix lack of VTY_NEWLINE when
2936 `show ip ospf'.
2937
2938 * ospf_interface.c (ospf_if_free): Fix bug of crash with
2939 Point-to-Point interface.
2940
29412000-07-27 Michael Rozhavsky <mike@nbase.co.il>
2942
2943 * ospf_flood.c (ospf_process_self_originated_lsa):
2944 Make sure to clear LSA->param (redistributed external information)
2945 before refreshment.
2946
29472000-07-27 Gleb Natapov <gleb@nbase.co.il>
2948
2949 * ospfd.c (refresh_group_limit), (refresh_per_slice),
2950 (refresh_age_diff): New defun added. Refresher related parameter
2951 can be configurable.
2952
29532000-07-27 Akihiro Mizutani <mizutani@dml.com>
2954
2955 * ospf_interface.c (interface_config_write): Print `description'
2956 config directive to work.
2957
29582000-07-24 Akihiro Mizutani <mizutani@dml.com>
2959
2960 * ospf_interface.c (ospf_if_init): Use install_default for
2961 INTERFACE_NODE.
2962
29632000-07-24 Gleb Natapov <gleb@nbase.co.il>
2964
2965 * ospf_packet.c (ospf_ls_upd_send_list), (ospf_ls_upd_send_event),
2966 (ospf_ls_ack_send_list), (ospf_ls_ack_send_event): New function added.
2967 This make sending always as many LS update/Ack combined in one ospf
2968 packet.
2969
29702000-07-24 Gleb Natapov <gleb@nbase.co.il>
2971
2972 * ospf_packet.c (ospf_ls_upd_list_lsa): Set NULL to lsa->area if
2973 LSA is AS-external-LSA.
2974
2975 * ospf_nsm.c (nsm_reset_nbr): Do not cancel Inactivity timer.
2976
29772000-07-21 Toshiaki Takada <takada@zebra.org>
2978
2979 * ospf_zebra.c (ospf_default_originate_timer): Set timer for
2980 `default-information originate'. Fix some default originate
2981 related functions.
2982
29832000-07-12 Toshiaki Takada <takada@zebra.org>
2984
2985 * ospf_lsa.c (stream_put_ospf_metric): New function added.
2986
29872000-07-12 Toshiaki Takada <takada@zebra.org>
2988
2989 * ospf_lsa.c (show_ip_ospf_database_router),
2990 (show_ip_ospf_database_network), (show_ip_ospf_database_summary),
2991 (show_ip_ospf_database_summary_asbr), (show_ip_ospf_database_externel),
2992 (show_router_lsa), (show_any_lsa), (show_router_lsa_self),
2993 (show_any_lsa_self): Functions removed.
2994
2995 (show_lsa_prefix_set), (show_lsa_detail_proc), (show_lsa_detail),
2996 (show_lsa_detail_adv_router_proc), (show_lsa_detail_adv_router):
2997 New functions added. Replace above functions.
2998
2999 (show_ip_ospf_database_all), (show_ip_ospf_database_self_originated):
3000 Functions removed.
3001 (show_ip_ospf_database_summary): New functions added. Replace
3002 above functions.
3003
3004 (show_ip_ospf_database_cmd): DEFUN rearranged.
3005 (show_ip_ospf_database_type_id_cmd),
3006 (show_ip_ospf_database_type_id_adv_router_cmd),
3007 (show_ip_ospf_database_type_is_self_cmd): New ALIASes added.
3008 (show_ip_ospf_database_type_adv_rotuer_cmd): New DEFUN added.
3009 (show_ip_ospf_database_type_self_cmd): New ALIAS added.
3010
30112000-07-11 Toshiaki Takada <takada@zebra.org>
3012
3013 * ospf_asbr.c (ospf_external_info_new),
3014 (ospf_external_info_free): New functions added.
3015
3016 * ospf_lsa.h (ospf_lsa): Add new member `void *param' to set
3017 origination parameter for external-LSA.
3018 Remove member `redistribute'.
3019
3020 * ospf_zebra.c (ospf_redistirbute_set): When `redistribute'
3021 command executed, metric and metric-type values are overridden.
3022 If one of those is changed refresh AS-external-LSAs for appropriate
3023 type.
3024
30252000-07-11 Michael Rozhavsky <mike@nbase.co.il>
3026
3027 * ospf_lsa.c (ospf_summary_lsa_refresh),
3028 (ospf_summary_asbr_lsa_refresh): Make sure to refresh summary-LSAs.
3029
3030 * ospf_abr.c (set_metric): New function added.
3031
30322000-07-07 Toshiaki Takada <takada@zebra.org>
3033
3034 * ospf_zebra.c (ospf_default_information_originate_metric_type),
3035 (ospf_default_information_originate_type_metric): New defun added.
3036 Metic and Metric type can be set to default route.
3037 (ospf_default_information_originate_always_metric_type):
3038 (ospf_default_information_originate_always_type_metric):
3039 New defun added. Metric and Metric type can be set to default
3040 always route.
3041
3042 * ospf_zebra.c (ospf_default_metric), (no_ospf_default_metric):
3043 New defun added.
3044
30452000-07-06 Gleb Natapov <gleb@nbase.co.il>
3046
3047 * ospf_flood.c (ospf_flood_through_area): Fix bug of considering
3048 on the same interface the LSA was received from.
3049
30502000-07-06 Michael Rozhavsky <mike@nbase.co.il>
3051
3052 * ospfd.c (ospf_config_write): Fix bug of printing `area stub'
3053 command with `write mem'.
3054
3055 * ospfd.c (no_router_ospf): Remove installed routes from zebra.
3056
3057 * ospf_zebra.c (ospf_interface_delete): Fix function to handle
3058 zebra interface delete event.
3059
30602000-07-06 Toshiaki Takada <takada@zebra.org>
3061
3062 * ospf_zebra.c (ospf_default_information_originate),
3063 (ospf_default_information_originate_always): New DEFUN added.
3064
30652000-07-05 Michael Rozhavsky <mike@nbase.co.il>
3066
3067 * ospf_route.c (ospf_terminate): Make sure to remove external route
3068 when SIGINT received.
3069
30702000-07-03 Gleb Natapov <gleb@nbase.co.il>
3071
3072 * ospf_flood.c, ospf_ism.c, ospf_lsa,c, ospfd.c: Make sure to free
3073 many structure with `no router ospf'.
3074
30752000-06-30 Gleb Natapov <gleb@nbase.co.il>
3076
3077 * ospf_neighbor.c (ospf_nbr_new),
3078 ospf_nsm.c (nsm_timer_set): Start LS update timer only
3079 when neighbor enters Exchange state.
3080
30812000-06-29 Gleb Natapov <gleb@nbase.co.il>
3082
3083 * ospf_nsm.c (nsm_timer_set), (nsm_exchange_done),
3084 ospf_packet.c (ospf_db_desc_proc):
3085 Do not cancel DD retransmit timer when Master.
3086
30872000-06-29 Gleb Natapov <gleb@nbase.co.il>
3088
3089 * ospf_abr.c (ospf_abr_announce_network_to_area),
3090 (ospf_abr_announce_rtr_to_area)
3091 ospf_ase.c (ospf_ase_rtrs_register_lsa),
3092 ospf_flood.c (ospf_process_self_originated_lsa),
3093 (ospf_flood_through_area), (ospf_ls_request_delete),
3094 ospf_interface.c (ospf_if_free),
3095 ospf_ism.c (ism_change_status),
3096 ospf_lsa.c (ospf_router_lsa_update_timer),
3097 (ospf_router_lsa_install), (ospf_network_lsa_install),
3098 (ospf_lsa_maxage_delete), (ospf_lsa_action),
3099 (ospf_schedule_lsa_flood_area),
3100 ospf_nsm.c (nsm_change_status),
3101 ospf_packet.c (ospf_make_ls_req_func), (ospf_make_ls_ack):
3102 Use ospf_lsa_{lock,unlock} for all looking-up of LSA.
3103
3104 * ospf_flood.c (ospf_ls_request_free): Function deleted.
3105
3106 * ospf_lsa.c (ospf_discard_from_db): New function added.
3107
31082000-06-26 Toshiaki Takada <takada@zebra.org>
3109
3110 * ospfd.h (ospf): struct member `external_lsa' name changed to
3111 `lsdb'.
3112
31132000-06-26 Toshiaki Takada <takada@zebra.org>
3114
3115 * ospf_lsa.c (ospf_lsa_install), (ospf_router_lsa_install),
3116 (ospf_network_lsa_install), (ospf_summary_lsa_install),
3117 (ospf_summary_asbr_lsa_install), (ospf_external_lsa_install):
3118 Functions re-arranged.
3119
3120 * ospf_lsa.c (IS_LSA_MAXAGE), (IS_LSA_SELF): Macro added.
3121
31222000-06-20 Michael Rozhavsky <mike@nbase.co.il>
3123
3124 * ospf_packet.c (ospf_ls_req), (ospf_ls_upd), (ospf_ls_ack): Add
3125 verification of LS type.
3126
31272000-06-20 Gleb Natapov <gleb@nbase.co.il>
3128
3129 * ospf_ase.c (ospf_ase_calculate_timer): Add more sanity check
3130 whether rn->info is NULL.
3131
31322000-06-20 Toshiaki Takada <takada@zebra.org>
3133
3134 * ospfd.c (show_ip_ospf_interface_sub): Show Router-ID of both
3135 DR and Backup correctly with `show ip ospf interface' command.
3136
31372000-06-20 Toshiaki Takada <takada@zebra.org>
3138
3139 * ospf_lsa.c (ospf_lsa_lock), (ospf_lsa_unlock),
3140 (ospf_lsa_discard): These functions are used for avoiding
3141 unexpected reference to freed LSAs.
3142
31432000-06-13 Kunihiro Ishiguro <kunihiro@zebra.org>
3144
3145 * ospf_packet.c (ospf_ls_upd): Initialize lsa by NULL to avoid
3146 warning.
3147
31482000-06-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3149
3150 * ospf_ase.h (ospf_ase_rtrs_register_lsa): Add prototype.
3151
31522000-06-12 Toshiaki Takada <takada@zebra.org>
3153
3154 * ospf_lsa.c (ospf_external_lsa_install): Make sure to register
3155 LSA to rtrs_external when replacing AS-external-LSAs in LSDB.
3156 Fix core dump.
3157
31582000-06-10 Toshiaki Takada <takada@zebra.org>
3159
3160 * ospf_lsdb.c (id_to_prefix), (ospf_lsdb_hash_key),
3161 (ospf_lsdb_hash_cmp), (ospf_lsdb_new), (ospf_lsdb_iterator),
3162 (lsdb_free), (ospf_lsdb_free), (ospf_lsdb_add), (ospf_lsdb_delete),
3163 (find_lsa), (ospf_lsdb_lookup), (find_by_id),
3164 (ospf_lsdb_lookup_by_id), (ospf_lsdb_lookup_by_header): Functinos
3165 removed for migration to new_lsdb.
3166
3167 * ospf_lsa.c (ospf_summary_lsa_install),
3168 (ospf_summary_asbr_lsa_install), (ospf_maxage_lsa_remover),
3169 (ospf_lsa_maxage_walker), (ospf_lsa_lookup),
3170 (ospf_lsa_lookup_by_id): Use new_lsdb instead of ospf_lsdb.
3171 (count_lsa), (ospf_lsa_count_table), (ospf_lsa_count),
3172 (ospf_get_free_id_for_prefix): Funcitions removed.
3173
31742000-06-09 Gleb Natapov <gleb@nbase.co.il>
3175
3176 * ospf_ism.c (ism_interface_down): Prevent some unneeded DR changes.
3177
3178 * ospf_packet.c (ospf_db_desc_proc): Fix memory leak.
3179 (ospf_hello): Always copy router-ID when hello is received.
3180
31812000-06-08 Gleb Natapov <gleb@nbase.co.il>
3182
3183 * ospf_lsa.h (struct ospf_lsa): Add member of pointer to struct
3184 ospf_area.
3185
31862000-06-08 Michael Rozhavsky <mike@nbase.co.il>
3187
3188 * ospf_ase.c (ospf_asbr_route_same): New function added.
3189 This function makes sure external route calculation more
3190 precisely.
3191
31922000-06-07 Michael Rozhavsky <mike@nbase.co.il>
3193
3194 * ospf_ism.c (ism_change_status): Use ospf_lsa_flush_area for
3195 network-LSA deletion instead of using ospf_lsdb_delete.
3196 Also cancel network-LSA origination timer.
3197
31982000-06-07 Levi Harper <lharper@kennedytech.com>
3199
3200 * ospf_interface.c (ospf_if_down): Close read fd when an interface
3201 goes down.
3202
32032000-06-05 Kunihiro Ishiguro <kunihiro@zebra.org>
3204
3205 * ospf_asbr.c (ospf_external_info_lookup): Add explicit brace for
3206 avoid ambiguous else.
3207
3208 * ospf_flood.c (ospf_external_info_check): Likewise.
3209
32102000-06-05 Toshiaki Takada <takada@zebra.org>
3211
3212 * ospf_nsm.c (nsm_adj_ok): Fix bug of DR election.
3213
32142000-06-04 Toshiaki Takada <takada@zebra.org>
3215
3216 * ospf_zebra.c (ospf_default_information_originate),
3217 (no_ospf_default_information_originate): New DEFUN added.
3218
32192000-06-03 Toshiaki Takada <takada@zebra.org>
3220
3221 * ospf_lsa.h, ospf_asbr.h (external_info): Struct moved from
3222 ospf_lsa.h to ospf_asbr.h.
3223
3224 * ospf_lsa.c, ospf_asbr.c (ospf_external_info_add),
3225 (ospf_external_info_delete): Function moved from ospf_lsa.c
3226 to ospf_asbr.c.
3227
32282000-06-03 Toshiaki Takada <takada@zebra.org>
3229
3230 * ospf_flood.c (ospf_external_info_check): New function added.
3231 (ospf_process_self_orignated_lsa): Make sure to flush
3232 self-originated AS-external-LSA, when router reboot and no longer
3233 originate those AS-external-LSA.
3234
32352000-06-02 Toshiaki Takada <takada@zebra.org>
3236
3237 * ospf_network.c (ospf_serv_sock): Remove SO_DONTROUTE
3238 socket option.
3239
3240 * ospf_packet.c (ospf_write): Set MSG_DONTROUTE flag for
3241 unicast destination packets.
3242
32432000-06-02 Toshiaki Takada <takada@zebra.org>
3244
3245 * ospf_lsdb.c (new_lsdb_delete): Delete entry from LSDB only when
3246 specified LSA matches.
3247
32482000-06-02 Gleb Natapov <gleb@nbase.co.il>
3249
3250 * ospf_network.c (ospf_serv_sock): Set SO_DONTROUTE
3251 socket option.
3252
32532000-06-01 Akihiro Mizutani <mizutani@dml.com>
3254
3255 * ospf_dump.c: Replace string `Debugging functions\n' with DEBUG_STR.
3256 Replace string `OSPF information\n' with OSPF_STR.
3257
32582000-06-01 Toshiaki Takada <takada@zebra.org>
3259
3260 * ospf_lsdb.[ch]: Use new_lsdb struct for network-LSA instead of
3261 ospf_lsdb.
3262
32632000-06-01 Toshiaki Takada <takada@zebra.org>
3264
3265 * ospf_dump.c (config_debug_ospf_packet), (config_debug_ospf_event),
3266 (config_debug_ospf_ism), (config_debug_ospf_nsm),
3267 (config_debug_ospf_lsa), (config_debug_ospf_zebra),
3268 (term_debug_ospf_packet), (term_debug_ospf_event),
3269 (term_debug_ospf_ism), (term_debug_ospf_nsm),
3270 (term_debug_ospf_lsa), (term_debug_ospf_zebra): Repalce debug_ospf_*
3271 variable to use for debug option flags.
3272
3273 (debug_ospf_packet), (debug_ospf_ism), (debug_ospf_nsm),
3274 (debug_ospf_lsa), (debug_ospf_zebra): Set {config,term}_debug_*
3275 flags when vty->node is CONFIG_NODE, otherwise set only term_debug_*
3276 flags.
3277
3278 * ospf_dump.h (CONF_DEBUG_PACKET_ON), (CONF_DEBUG_PACKET_OFF),
3279 (TERM_DEBUG_PACKET_ON), (TERM_DEBUG_PACKET_OFF),
3280 (CONF_DEBUG_ON), (CONF_DEBUG_OFF), (IS_CONF_DEBUG_OSPF_PACKET),
3281 (IS_CONF_DEBUG_OSPF): New Macro added.
3282
32832000-05-31 Toshiaki Takada <takada@zebra.org>
3284
3285 * ospfd.c (clear_ip_ospf_neighbor): New DEFUN added.
3286 Currently this command is used for only debugging.
3287
3288 * ospf_nsm.c (nsm_change_status): Make sure thread cancellation
3289 for network-LSA when DR has no full neighbors.
3290
3291 * ospf_nsm.c (ospf_db_summary_clear): New function added.
3292
32932000-05-30 Toshiaki Takada <takada@zebra.org>
3294
3295 * ospf_lsdb.c (new_lsdb_insert): LSAs are always freed by
3296 maxage_lsa_remover when LSA is replaced.
3297
32982000-05-25 Gleb Natapov <gleb@nbase.co.il>
3299
3300 * ospf_flood.c (ospf_ls_retransmit_delete_nbr_all): Add argument
3301 `struct ospf_area' to remove LSA from Link State retransmission list
3302 of neighbor from only one Area.
3303
33042000-05-24 Michael Rozhavsky <mike@nbase.co.il>
3305
3306 * ospf_lsdb.c (ospf_lsdb_add): Preserve flags field when
3307 overriting old LSA with new LSA.
3308
33092000-05-24 Gleb Natapov <gleb@nbase.co.il>
3310
3311 * ospf_lsa.c (ospf_router_lsa_body_set): Fix bug of router-LSA
3312 size calculation.
3313
33142000-05-22 Michael Rozhavsky <mike@nbase.co.il>
3315
3316 * ospf_route.c (ospf_intra_add_stub):
3317 * ospf_spf.h (struct vertex): Use u_int32_t for distance (cost)
3318 value instead of u_int16_t.
3319
33202000-05-22 Axel Gerlach <agerlach@datus.datus.com>
3321
3322 * ospf_ia.c (ospf_ia_network_route): Fix bug of Inter-area route
3323 equal cost path calculation.
3324
33252000-05-21 Toshiaki Takada <takada@zebra.org>
3326
3327 * ospf_ase.c (ospf_ase_calculate_route_delete): New function added.
3328 Make sure, when rotuer route is deleted, related external routes
3329 are also deleted.
3330
33312000-05-20 Toshiaki Takada <takada@zebra.org>
3332
3333 * ospfd.c (ospf_interface_down): Make sure interface flag is disable
3334 and set fd to -1.
3335
33362000-05-16 Toshiaki Takada <takada@zebra.org>
3337
3338 * ospf_asbr.c (ospf_asbr_should_announce), (ospf_asbr_route_remove):
3339 Functions removed.
3340
3341 * ospfd.h (EXTERNAL_INFO): Macro added.
3342 Substitute `ospf_top->external_info[type]' with it.
3343
33442000-05-16 Toshiaki Takada <takada@zebra.org>
3345
3346 * ospf_lsa.c (ospf_rtrs_external_remove): New function added.
3347
33482000-05-14 Gleb Natapov <gleb@nbase.co.il>
3349
3350 * ospf_flood.c (ospf_ls_retransmit_delete_nbr_all)
3351 * ospf_lsdb.c (new_lsdb_insert)
3352 * ospf_packet.c (ospf_ls_ack): Fix database synchonization problem.
3353
33542000-05-14 Gleb Natapov <gleb@nbase.co.il>
3355
3356 * ospf_lsa.h (tv_adjust), (tv_ceil), (tv_floor), (int2tv),
3357 (tv_add), (tv_sub), (tv_cmp): Prototype definition added.
3358
3359 * ospf_nsm.h (ospf_db_summary_delete_all): Prototype definition added.
3360
33612000-05-13 Toshiaki Takada <takada@zebra.org>
3362
3363 * ospf_lsa.[ch] (ospf_lsa): struct timestamp type is changed from
3364 time_t to struct timeval.
3365 (tv_adjust), (tv_ceil), (tv_floor), (int2tv), (tv_add),
3366 (tv_sub), (tv_cmp): timeval utillity functions added.
3367
33682000-05-12 Toshiaki Takada <takada@zebra.org>
3369
3370 * ospf_lsa.[ch] (ospf_schedule_update_router_lsas): Delete function.
3371 Change to use macro OSPF_LSA_UPDATE_TIMER instead of using
3372 this function.
3373 router-LSA refresh timer related stuff is re-organized.
3374
33752000-05-10 Gleb Natapov <gleb@nbase.co.il>
3376
3377 * ospf_interface.c (ospf_vl_set_params):
3378 * ospf_packet.c (ospf_check_network_mask):
3379 * ospf_spf.[ch] (ospf_spf_next):
3380 Remove field address from `struct vertex', and search for peer
3381 address of virtual link in function `ospf_vl_set_params' instead.
3382
33832000-05-10 Gleb Natapov <gleb@nbase.co.il>
3384
3385 * ospf_packet.c (ospf_ls_upd): Fix some memory leak related LSA.
3386
33872000-05-08 Thomas Molkenbur <tmo@datus.com>
3388
3389 * ospf_packet.c (ospf_packet_dup): Replace ospf_steram_copy()
3390 with ospf_stream_dup() to fix memory leak.
3391
33922000-05-08 Michael Rozhavsky <mike@nbase.co.il>
3393
3394 * ospf_flood.c (ospf_flood_through_area): Fix the problem of
3395 LSA update without DROther.
3396
33972000-05-04 Gleb Natapov <gleb@nbase.co.il>
3398
3399 * ospf_spf.c (ospf_vertex_free): Fix memory leak of SPF calculation.
3400
34012000-05-03 Toshiaki Takada <takada@zebra.org>
3402
3403 * ospf_neighbor.c (ospf_db_summary_add): Use new_lsdb struct
3404 instead linked-list.
3405 (ospf_db_summary_count), (ospf_db_summary_isempty):
3406 New function added.
3407
3408 * ospf_lsa.c (ospf_rotuer_lsa): Re-arrange and divide functions.
3409
34102000-05-02 Gleb Natapov <gleb@nbase.co.il>
3411
3412 * ospf_lsdb.c (new_lsdb_cleanup): Fix memory leak. When LSDB are
3413 not needed any more, then free them.
3414
34152000-05-02 Toshiaki Takada <takada@zebra.org>
3416
3417 * ospfd.c (timers_spf), (no_timers_spf): New defun added.
3418 SPF calculation timers related stuff is rearranged.
3419
3420 * ospf_spf.c (ospf_spf_calculate_timer_add): Function removed.
3421 SPF timer is scheduled by SPF calculation delay and holdtime
3422 configuration variable.
3423
3424 * ospf_lsa.c (ospf_external_lsa_nexthop_get): Set AS-external-LSA's
3425 forwarding address when nexthop learned by other protocols is
3426 in the OSPF domain.
3427
3428 * ospf_zebra.c (ospf_redistribute_source_metric_type),
3429 (ospf_redistribute_source_type_metric): Re-arrange DEFUNs and
3430 ALIASes.
3431
34322000-05-01 Toshiaki Takada <takada@zebra.org>
3433
3434 * ospf_flood.c (ospf_ls_retransmit_count),
3435 (ospf_ls_retransmit_isempty): New function added.
3436
3437 (ospf_ls_retransmit_add), (ospf_ls_retransmit_delete),
3438 (ospf_ls_retransmit_clear), (ospf_ls_retransmit_lookup),
3439 (ospf_ls_retransmit_delete_all), (ospf_ls_retransmit_delete_nbr_all),
3440 (ospf_ls_retransmit_add_nbr_all): Replace these functions to use
3441 new_lsdb.
3442
34432000-04-29 Toshiaki Takada <takada@zebra.org>
3444
3445 * ospfd.c (no_network_area): Add check Area-ID whether specified
3446 Area-ID with prefix matches config.
3447
34482000-04-27 Toshiaki Takada <takada@zebra.org>
3449
3450 * ospf_lsa.c (ospf_maxage_lsa_remover): Fix problem of
3451 remaining withdrawn routes on zebra.
3452
34532000-04-25 Michael Rozhavsky <mike@nbase.co.il>
3454
3455 * ospf_nsm.c (nsm_kill_nbr), (nsm_ll_down), (nsm_change_status),
3456 (ospf_nsm_event): Fix network-LSA re-origination problem.
3457
34582000-04-24 Toshiaki Takada <takada@zebra.org>
3459
3460 * ospf_nsm.c (ospf_db_desc_timer): Fix bug of segmentation fault
3461 with DD retransmission.
3462
3463 * ospf_nsm.c (nsm_kill_nbr): Fix bug of re-origination when
3464 a neighbor disappears.
3465
34662000-04-23 Michael Rozhavsky <mike@nbase.co.il>
3467
3468 * ospf_abr.c (ospf_abr_announce_network_to_area): Fix bug of
3469 summary-LSAs reorigination. Correctly copy OSPF_LSA_APPROVED
3470 flag to new LSA. when summary-LSA is reoriginatd.
3471
3472 * ospf_flood.c (ospf_flood_through_area): Fix bug of flooding
3473 procedure. Change the condition of interface selection.
3474
34752000-04-21 Toshiaki Takada <takada@zebra.org>
3476
3477 * ospf_lsa.c (ospf_refresher_register_lsa): Fix bug of refresh never
3478 occurs.
3479
3480 * ospfd.c (show_ip_ospf_neighbor_id): New defun added.
3481 `show ip ospf neighbor' related commands are re-arranged.
3482
34832000-04-20 Toshiaki Takada <takada@zebra.org>
3484
3485 * ospf_dump.c (debug_ospf_zebra): New defun added.
3486 Suppress zebra related debug information.
3487
34882000-04-19 Toshiaki Takada <takada@zebra.org>
3489
3490 * ospf_zebra.c (ospf_distribute_list_update_timer),
3491 (ospf_distribute_list_update), (ospf_filter_update):
3492 New function added. Re-organize `distribute-list' router ospf
3493 command.
3494
34952000-04-13 Michael Rozhavsky <mike@nbase.co.il>
3496
3497 * ospf_packet.c (ospf_make_ls_upd): Add check for MAX_AGE.
3498
34992000-04-14 Michael Rozhavsky <mike@nbase.co.il>
3500
3501 * ospf_packet.c (ospf_make_ls_upd): Increment LS age by configured
3502 interface transmit_delay.
3503
35042000-04-14 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3505
3506 * ospf_interface.c (ip_ospf_cost), (no_ip_ospf_cost):
3507 Add to schedule router_lsa origination when the interface cost changes.
3508
35092000-04-12 Toshiaki Takada <takada@zebra.org>
3510
3511 * ospf_lsa.c (ospf_refresher_register_lsa),
3512 (ospf_refresher_unregister_lsa): Fix bug of core dumped.
3513
3514 * ospfd.c (no_router_ospf): Fix bug of core dumped.
3515
35162000-03-29 Toshiaki Takada <takada@zebra.org>
3517
3518 * ospf_nsm.c (nsm_oneway_received): Fix bug of MS flag unset.
3519
35202000-03-29 Michael Rozhavsky <mike@nbase.co.il>
3521
3522 * ospf_lsa.c (ospf_network_lsa):
3523 * ospf_nsm.c (ospf_nsm_event): Fix bug of Network-LSA originated
3524 in stub network.
3525
35262000-03-28 Toshiaki Takada <takada@zebra.org>
3527
3528 * ospf_nsm.c (nsm_bad_ls_req), (nsm_seq_number_mismatch),
3529 (nsm_oneway_received): Fix bug of NSM state flapping between
3530 ExStart and Exchange.
3531
35322000-03-28 Toshiaki Takada <takada@zebra.org>
3533
3534 * ospf_packet.h (strcut ospf_header): Fix the size of ospf_header,
3535 change u_int8_t to u_char.
3536
35372000-03-27 Toshiaki Takada <takada@zebra.org>
3538
3539 * ospf_lsa.c (ospf_lsa_checksum): Take care of BIGENDIAN architecture.
3540
35412000-03-27 Toshiaki Takada <takada@zebra.org>
3542
3543 * ospfd.c (ospf_interface_run): Make sure Address family matches.
3544
35452000-03-26 Love <lha@s3.kth.se>
3546
3547 * ospf_packet.c (ospf_write): Chack result of sendto().
3548
35492000-03-26 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3550
3551 * ospf_nsm.c (nsm_oneway_received): Fix bug of 1-WayReceived in NSM.
3552
35532000-03-23 Libor Pechacek <farco@clnet.cz>
3554
3555 * ospf_lsa.c (ospf_network_lsa)
3556 * ospf_lsdb.c (new_lsdb_insert): Fix bug of accessing to
3557 unallocated memory.
3558
35592000-03-23 Toshiaki Takada <takada@zebra.org>
3560
3561 * ospfd.c (ospf_config_write): Fix bug of duplicate line for
3562 `area A.B.C.D authentication'.
3563
35642000-03-22 Toshiaki Takada <takada@zebra.org>
3565
3566 * ospf_debug.c (debug_ospf_lsa), (no_debug_ospf_lsa): Defun added.
3567 Suppress all zlog related to LSAs with this config option.
3568
35692000-03-21 Kunihiro Ishiguro <kunihiro@zebra.org>
3570
3571 * ospf_nsm.c (ospf_nsm_event): Add check for NSM_InactivityTimer.
3572
35732000-03-21 Toshiaki Takada <takada@zebra.org>
3574
3575 * ospf_packet.c (ospf_ls_upd_timer), (ospf_ls_req):
3576 Fix bug of memory leak about linklist.
3577
3578 * ospf_flood.c (ospf_flood_through_area): Likewise.
3579
35802000-03-18 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3581
3582 * ospf_flood.c (ospf_ls_retransmit_lookup): Add checksum comparison
3583 to identify LSA uniquely. This fix routes lost.
3584
35852000-03-18 Toshiaki Takada <takada@zebra.org>
3586
3587 * ospf_ase.c (ospf_find_asbr_route): Add sanity check with router
3588 routing table.
3589
35902000-03-17 Alex Zinin <zinin@amt.ru>
3591
3592 * ospf_spf.[ch]: Bug fix.
3593 The 2nd stage of Dijkstra could consider one vertex
3594 more than once if there is more than one link
3595 between the routers, thus adding extra CPU overhead
3596 and extra next-hops.
3597 Fixed.
3598
35992000-03-15 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3600
3601 * ospf_nsm.c (nsm_inactivity_timer): Changed to call nsm_kill_nbr().
3602
36032000-03-14 Toshiaki Takada <takada@zebra.org>
3604
3605 * ospf_route.c (ospf_route_copy_nexthops): Fix bug of memory leak of
3606 ospf_path. Actually ignore merging ospf_route with completely same
3607 paths.
3608
36092000-03-12 Toshiaki Takada <takada@zebra.org>
3610
3611 * ospf_lsa.c (show_as_external_lsa_detail): fix bug of
3612 external route tag byte order.
3613
36142000-03-11 Toshiaki Takada <takada@zebra.org>
3615
3616 * ospf_lsdb.c (ospf_lsdb_insert): New function added.
3617
36182000-03-09 Toshiaki Takada <takada@zebra.org>
3619
3620 * ospf_lsa.c (ospf_external_lsa_install),
3621 (ospf_lsa_lookup), (show_ip_ospf_database_all),
3622 (show_ip_ospf_database_self_originate): Use struct new_lsdb for
3623 LSDB of AS-external-LSAs instead of ospf_lsdb.
3624
3625 * ospf_lsa.c (ospf_lsa_unique_id): New function added.
3626 Use for assigning Unique Link State ID instead of
3627 ospf_get_free_id_for_prefix().
3628
36292000-03-09 Toshiaki Takada <takada@zebra.org>
3630
3631 * ospf_ase.c (ospf_ase_calculate_timer): Fix bug of segmentation
3632 fault reported by George Bonser <george@siteROCK.com>.
3633
36342000-03-07 Libor Pechacek <farco@clnet.cz>
3635
3636 * ospfd.c (ospf_interface_down): Fix bug of segmentation fault.
3637
36382000-03-06 Toshiaki Takada <takada@zebra.org>
3639
3640 * ospf_route.c (ospf_route_cmp): Change meaning of return values.
3641
36422000-03-02 Alex Zinin <zinin@amt.ru>
3643 * ospfd.h, ospf_ia.h
3644 New Shortcut ABR code. Now area's flag can be configured
3645 with Default, Enable, and Disable values.
3646 More info will be in the new ver of I-D soon (see IETF web).
3647
36482000-02-25 Toshiaki Takada <takada@zebra.org>
3649
3650 * ospf_lsa.c (ospf_lsa_header_set), (ospf_external_lsa_body_set),
3651 (osfp_external_lsa_originate), (ospf_external_lsa_queue),
3652 (ospf_external_lsa_originate_from_queue): New function added.
3653 (ospf_external_lsa): Function removed.
3654
3655 * ospf_zebra.c (ospf_zebra_read_ipv4): Originate AS-external-LSA
3656 when listen a route from Zebra, instead creating external route.
3657
3658 * ospf_asbr.c (ospf_asbr_route_add_flood_lsa),
3659 (ospf_asbr_route_add_queue_lsa),
3660 (ospf_asbr_route_install_lsa), (ospf_asbr_route_add):
3661 Functions removed.
3662
3663 * ospf_ase.c (process_ase_lsa): Function will not be used.
3664 (ospf_ase_calculate), (ospf_ase_calculate_route_add),
3665 (ospf_ase_calculate_new_route), (ospf_ase_caluculate_asbr_route):
3666 process_ase_lsa () is separated to these functions.
3667
3668 OSPF AS-external-LSA origination is whole re-organized.
3669
36702000-02-18 Toshiaki Takada <takada@zebra.org>
3671
3672 * ospf_packet.c (ospf_ls_upd): Fix bug of OSPF LSA memory leak.
3673
3674 * ospf_asbr.c (ospf_asbr_route_add_flood_lsa),
3675 (ospf_asbr_route_add_queue_lsa): Fix bug of OSPF external route
3676 memory leak.
3677
36782000-02-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3679
3680 * ospf_asbr.c (ospf_asbr_route_install_lsa): Re-calculate LSA
3681 checksum after change Advertised Router field.
3682
36832000-02-09 Toshiaki Takada <takada@zebra.org>
3684
3685 * ospf_asbr.c (ospf_external_route_lookup): Add new function.
3686
36872000-02-08 Toshiaki Takada <takada@zebra.org>
3688
3689 * ospfd.c (ospf_router_id_get), (ospf_router_id_update),
3690 (ospf_router_id_update_timer): Router ID decision algorithm is changed.
3691 Router ID is chosen from all of eligible interface addresses even if
3692 it is not enable to OSPF.
3693
36942000-02-08 Toshiaki Takada <takada@zebra.org>
3695
3696 * ospf_asbr.c (ospf_asbr_route_add): Function divided to
3697 ospf_asbr_route_add_flood_lsa, ospf_asbr_route_add_queue_lsa and
3698 ospf_asbr_route_install_lsa. If Router-ID is not set, then LSA is
3699 waited to install to LSDB.
3700 `0.0.0.0 adv_router' AS-external-LSA origination bug was fixed.
3701
37022000-02-01 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3703
3704 * ospf_flood.c (ospf_ls_retransmit_lookup): Compare LS seqnum
3705 in the ACK before deleting.
3706
3707 * ospf_packet.c (ospf_hello): Reset the flags after a shutdown
3708 and no shutdown of the interface.
3709
37102000-01-31 Toshiaki Takada <takada@zebra.org>
3711
3712 * ospf_packet.c (ospf_ls_req): Send multiple Link State Update
3713 packets respond to a Link State Request packet.
3714
3715 * ospfd.c (show_ip_ospf_neighbor_detail_sub): Show thread state.
3716
3717 * ospf_interface.c (ospf_vl_new): Crash when backbone area
3718 is not configured and set virtual-link to no-backbone area,
3719 bug fixed.
3720
37212000-01-30 Kunihiro Ishiguro <kunihiro@zebra.org>
3722
3723 * ospf_neighbor.h (struct ospf_neighbor): Add pointer to last send
3724 LS Request LSA.
3725
3726 * ospf_packet.c (ospf_ls_upd): Comment out LS request list
3727 treatment. That should be done in OSPF flooding procedure.
3728
3729 * ospf_flood.c (ospf_flood_through_area): Enclose
3730 ospf_check_nbr_loding inside if-else close.
3731
37322000-01-31 Toshiaki Takada <takada@zebra.org>
3733
3734 * ospf_packet.c (ospf_make_ls_upd): Fix bug of #LSAs counting.
3735
37362000-01-29 Toshiaki Takada <takada@zebra.org>
3737
3738 * ospf_packet.c (ospf_make_md5_digest): Fix bug of md5 authentication.
3739
37402000-01-28 Toshiaki Takada <takada@zebra.org>
3741
3742 * ospfd.c (show_ip_ospf): Show Number of ASE-LSAs.
3743
37442000-01-27 Kunihiro Ishiguro <kunihiro@zebra.org>
3745
3746 * ospf_packet.c (ospf_make_db_desc): Don't use rm_list for
3747 removing LSA from nbr->db_summary.
3748
37492000-01-27 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3750
3751 * ospf_packet.c (ospf_ls_upd_send): Set AllSPFRouters to
3752 destination when the link is point-to-point.
3753 (ospf_ls_ack_send_delayed): Likewise.
3754
37552000-01-27 Kunihiro Ishiguro <kunihiro@zebra.org>
3756
3757 * ospf_flood.c (ospf_ls_request_delete_all): Fix bug of next
3758 pointer lookup after the node is freed.
3759
37602000-01-26 Kunihiro Ishiguro <kunihiro@zebra.org>
3761
3762 * ospf_asbr.c (ospf_asbr_route_add): Instead of scanning all AS
3763 external route, use ospf_top->external_self.
3764
37652000-01-27 Toshiaki Takada <takada@zebra.org>
3766
3767 * ospf_lsa.c (ospf_forward_address_get): New function added.
3768
3769 * ospf_asbr.c (ospf_asbr_check_lsas): Originate AS-external-LSA
3770 only when it should be replaced.
3771
37722000-01-25 Kunihiro Ishiguro <kunihiro@zebra.org>
3773
3774 * ospf_flood.c (ospf_ls_retransmit_clear): Delete list node.
3775
3776 * ospf_lsa.c (ospf_lsa_free): Reduce logging message using
3777 ospf_zlog value.
3778
3779 * ospf_ism.c (ism_change_status): Fix bug of DR -> non DR status
3780 change. Self originated LSA is freed but not deleted from lsdb.
3781
37822000-01-24 Kunihiro Ishiguro <kunihiro@zebra.org>
3783
3784 * ospf_ism.c (ism_interface_down): Don't use router_id for
3785 detecting self neighbor structure. Instead of that compare
3786 pointer itself.
3787
3788 * ospf_neighbor.c (ospf_nbr_free): Cancel all timer when neighbor
3789 is deleted.
3790 (ospf_nbr_free): Free last send packet.
3791
3792 * ospf_neighbor.h (struct ospf_neighbor): Remove host strucutre.
3793 Instead of that src is introduced.
3794
3795 * ospf_nsm.h: Enclose macro defenition with do {} while (0).
3796
37972000-01-17 Kunihiro Ishiguro <kunihiro@zebra.org>
3798
3799 * ospfd.c: Change part of passive interface implementation. For
3800 passive interface just disabling sending/receiving Hello on the
3801 interface.
3802
38032000-01-16 Kai Bankett <kai.bankett@vew-telnet.net>
3804
3805 * ospf_interface.h (OSPF_IF_PASSIVE): Add passive flag.
3806 * ospf_interface.c (ospf_if_lookup_by_name): Add new function.
3807 * ospf_lsa.c (ospf_router_lsa): Skip passive interface.
3808 * ospfd.c (passive_interface): New command passive-interface is
3809 added.
3810 (ospf_config_write): Print passive interface.
3811
38122000-01-15 Toshiaki Takada <takada@zebra.org>
3813
3814 * ospf_interface.h (crypt_key): New struct added to store
3815 multiple cryptographic autheitication keys.
3816 (ospf_interface): struct changed.
3817
3818 * ospf_interface.c: ospf_crypt_key_new, ospf_crypt_key_add,
3819 ospf_crypt_key_lookup, ospf_crypt_key_delete: new functions added.
3820
3821 * ospf_packet.c (ip_ospf_message_digest_key): Changed to store
3822 multiple cryptographic authentication keys.
3823
38242000-01-14 Toshiaki Takada <takada@zebra.org>
3825
3826 * ospf_interface.c: DEFUN (if_ospf_*) commands changed name to
3827 ip_ospf_* ().
3828 Old notation `ospf *' still remains backward compatibility.
3829
38301999-12-29 Alex Zinin <zinin@amt.ru>
3831 * ospf_lsa.c: ospf_lsa_more_recent() bug fix
3832 * ospf_nsm.c, ospf_packet.c: remove nbr data struct when
3833 int goes down, also check DD flags correctly (bug fix)
3834
38351999-12-28 Alex Zinin <zinin@amt.ru>
3836 * "redistribute <source> metric-type (1|2) metric <XXX>" added
3837
38381999-12-23 Alex Zinin <zinin@amt.ru>
3839 * added RFC1583Compatibility flag
3840 * added dynamic interface up/down functionality
3841
38421999-11-19 Toshiaki Takada <takada@zebra.org>
3843
3844 * ospf_neighbor.h (struct ospf_neighbor): Add member state_change
3845 for NSM state change statistics.
3846
38471999-11-19 Toshiaki Takada <takada@zebra.org>
3848
3849 * ospfd.c (show_ip_ospf_neighbor_detail),
3850 (show_ip_ospf_neighbor_int_detail): DEFUN Added.
3851
38521999-11-14 Kunihiro Ishiguro <kunihiro@zebra.org>
3853
3854 * ospf_asbr.c (ospf_asbr_check_lsas): Add check of
3855 lsa->refresh_list.
3856
38571999-11-11 Toshiaki Takada <takada@zebra.org>
3858
3859 * ospf_ia.[ch] (OSPF_EXAMINE_SUMMARIES_ALL): Macro added.
3860 This macro is expanded to ospf_examine_summaries ()
3861 for SUMMARY_LSA and SUMMARY_LSA_ASBR.
3862 (OSPF_EXAMINE_TRANSIT_SUMMARIES_ALL): Macro added.
3863 This macro is expanded to ospf_examine_transit_summaries ()
3864 for SUMMARY_LSA and SUMMARY_LSA_ASBR.
3865
38661999-11-11 Toshiaki Takada <takada@zebra.org>
3867
3868 * ospf_lsa.[ch] (ospf_find_self_summary_lsa_by_prefix): Changed to
3869 macro OSPF_SUMMARY_LSA_SELF_FIND_BY_PREFIX.
3870 (ospf_find_self_summary_asbr_lsa_by_prefix): Changed to
3871 macro OSPF_SUMMARY_ASBR_LSA_SELF_FIND_BY_PREFIX.
3872 (ospf_find_self_external_lsa_by_prefix): Changed to
3873 macro OSPF_EXTERNAL_LSA_SELF_FIND_BY_PREFIX.
3874
38751999-11-11 Toshiaki Takada <takada@zebra.org>
3876
3877 * ospfd.c (ospf_abr_type): ospf_abr_type_cisco, ospf_abr_type_ibm,
3878 ospf_abr_type_shortcut and ospf_abr_type_standard DEFUNs are
3879 combined.
3880 * ospfd.c (no_ospf_abr_type): no_ospf_abr_type_cisco,
3881 no_ospf_abr_type_ibm and no_ospf_abr_type_shortcut DEFUNS are
3882 combined.
3883
38841999-11-10 Toshiaki Takada <takada@zebra.org>
3885
3886 * ospf_route.c (ospf_lookup_int_by_prefix): Move function to
3887 ospf_interface.c and change name to ospf_if_lookup_by_prefix ().
3888
38891999-11-01 Alex Zinin <zinin@amt.ru>
3890 * ospf_packet.c
3891 some correction to LSU processing
3892
3893 * ospf_lsa.c ospfd.h
3894 randomize initial LSA refreshment interval
3895 and limit the size of LSA-group to 10
3896 to let randomization work more effectively.
3897
38981999-10-31 Alex Zinin <zinin@amt.ru>
3899 * ospf_interface.c
3900 cancel t_network_lsa_self
3901 when freeing int structure
3902
3903 * ospf_abr.c ospf_asbr.c ospf_flood.c ospf_lsa.c
3904 ospf_lsa.h ospf_lsdb.h ospfd.c ospfd.h
3905
3906 Summary and ASE LSA refreshment functions
3907 added---LSA refreshment is paced to 70 LSAs
3908 per sec to avoid link overflow. Refreshment events
3909 are further randomized within a 10 sec interval
3910 to avoid syncing.
3911
3912 Also the sigfault of memcmp() in ospf_lsa_is_different()
3913 is fixed.
3914
39151999-10-30 Alex Zinin <zinin@amt.ru>
3916 * ospf_nsm.c
3917 Fix the bug where MAX_AGE LSAs
3918 are included into the DB summary.
3919
3920 * ospf_interface.c
3921 allocate 2*MTU input buffer instead of just MTU
3922 for the cases when the other router mistakenly
3923 sends larger packets thus causing fragmentation, etc.
3924
3925 * ospf_nsm.c
3926 in nsm_reset_nbr() lists should be freed
3927 not when they are empty.
3928
39291999-10-29 Kunihiro Ishiguro <kunihiro@zebra.org>
3930
3931 * ospf_zebra.c (ospf_acl_hook): Move OSPF_IS_ASBR and OSPF_IS_ABR
3932 check inside of if (ospf_top).
3933
39341999-10-29 Alex Zinin <zinin@amt.ru>
3935 * ospf_lsa.c ospf_lsdb.c :
3936 add assertion in lsa and lsa->data alloc functions,
3937 as well as in lsdb_add for new->data
3938
3939 * ospf_lsdb.c: free hash table correctly
3940
39411999-10-28 John Capo <jc@irbs.com>
3942
3943 * ospf_packet.h (OSPF_PACKET_MAX): Correct MAX packet length
3944 calculation
3945
39461999-10-27 Kunihiro Ishiguro <kunihiro@zebra.org>
3947
3948 * OSPF-TRAP-MIB.txt: New file added. Edited version of RFC1850.
3949
3950 * OSPF-MIB.txt: New file added. Edited version of RFC1850.
3951
39521999-10-27 Alex Zinin <zinin@amt.ru>
3953 * ospfd, ospf_zebra, ospf_abr
3954 "area import-list" command is added.
3955 This command allows to filter the inter-area routes
3956 injected into an area. Access list hook function
3957 extended to invalidate area exp/imp lists.
3958
39591999-10-25 Yoshinobu Inoue <shin@nd.net.fujitsu.co.jp>
3960
3961 * ospfd.c (ospf_interface_run): Enable to detect P2P network
3962 on an OSPF interface.
3963
39641999-10-19 Jordan Mendelson <jordy@wserv.com>
3965
3966 * ospf_lsdb.c (ospf_lsdb_add): Fix bug of crash
3967 in ospf_ls_retransmit_lookup ().
3968
39691999-10-19 Vladimir B. Grebenschikov <vova@express.ru>
3970
3971 * ospf_route.c: Workaround about installation of OSPF routes into
3972 the zebra daemon. Add checking of existance routes. Free
3973 ospf_top->old_table if it exists.
3974
39751999-10-15 Jordan Mendelson <jordy@wserv.com>
3976
3977 * Add support for MD5 authentication.
3978
39791999-10-12 Alex Zinin <zinin@amt.ru>
3980 * ospfd.c, ospfd.h, ospf_abr.c:
3981 a new command "area export-list" was added, it allows
3982 the admin. to control which intra-area routes are
3983 announced to other areas by the ABR
3984
39851999-10-12 Alex Zinin <zinin@amt.ru>
3986 * ospf_asbr.c (ospf_asbr_check_lsas): Fix bug of coredump
3987 when "no redistribute" is used after a distribute list
3988 denying some networks was used
3989
39901999-10-05 Toshiaki Takada <takada@zebra.org>
3991
3992 * ospf_route.c (ospf_path_dup): New function added.
3993
39941999-10-05 Toshiaki Takada <takada@zebra.org>
3995
3996 * ospf_interface.[ch]: Some of VL related funciton name changed.
3997
39981999-09-27 Alex Zinin <zinin@amt.ru>
3999
4000 * ospf_zebra.c: Distribute-list functionality added
4001
40021999-09-27 Toshiaki Takada <takada@zebra.org>
4003
4004 * ospfd.c (show_ip_ospf): Fix bug of segmentation fault when no ospf
4005 instance exists.
4006
40071999-09-25 Kunihiro Ishiguro <kunihiro@zebra.org>
4008
4009 * ospfd.c (ospf_interface_down): Fix bug of misusing nextnode()
4010 instead of node->next. Reported by Hiroki Ishibashi
4011 <ishibasi@dcd.abk.nec.co.jp>.
4012
4013 * ospf_route.c (show_ip_ospf_route): Add check for ospf is enabled
4014 or not.
4015
40161999-09-23 Alex Zinin <zinin@amt.ru>
4017
4018 * stub area support added
4019
40201999-09-23 Alex Zinin <zinin@amt.ru>
4021
4022 * fwd_addr in ASE-LSAs is now set correctly
4023 * ASE routing changed to check the fwd_addr
4024 and skip the route if the addr points to one
4025 of our interfaces to avoid loops.
4026
40271999-09-22 Alex Zinin <zinin@amt.ru>
4028
4029 * ospf_interface:
4030 ospf_vls_in_area() added, it returns
4031 the number of VLs configured through the area
4032
4033 * ospf_interface.c ospf_lsa.c ospf_lsdb.c ospfd.c
4034 honor correct mem alloc
4035
40361999-09-22 Alex Zinin <zinin@amt.ru>
4037
4038 * memory.[ch]:
4039 Some OSPF mem types added,
4040 plus more info in "show mem"
4041
40421999-09-21 Alex Zinin <zinin@amt.ru>
4043
4044 * ospfd.c:
4045 "area range substitute" added.
4046 It can be used on NAT-enabled (IP-masquarade)
4047 routers to announce private networks
4048 from an area as public ones into the outside
4049 world (not in the RFC, btw :)
4050
40511999-09-21 Alex Zinin <zinin@amt.ru>
4052
4053 * ospfd.c:
4054 "area range suppress" added.
4055 This command allows to instruct the router
4056 to be silent about specific ranges, i.e.,
4057 it is a method of route filtering on area
4058 borders
4059
40601999-09-21 Alex Zinin <zinin@amt.ru>
4061
4062 * ospfd.c VLs removed when "no network area" executed
4063
40641999-09-20 Alex Zinin <zinin@amt.ru>
4065
4066 * ospf_ase.c bug fix for not-zero fwd_addr
4067 and directly connected routes.
4068
40691999-09-20 Yon Uriarte <yon@plannet.de>
4070
4071 * ospf_packet.c (ospf_make_ls_req): Introduce delta value for
4072 checking the length of OSPF packet exceeds MTU or not.
4073
4074 * ospf_lsa.c (ospf_lsa_different): Apply ntohs for checking
4075 l1->data->length.
4076
40771999-09-18 Alex Zinin <zinin@amt.ru>
4078
4079 * ospf_lsa.c bug fix for ospf_network_lsa() to
4080 include itself into the RID list
4081
40821999-09-10 Alex Zinin <zinin@amt.ru>
4083
4084 * Alternative ABR behaviors IBM/Cisco/Shortcut
4085 implemented
4086
40871999-09-10 Alex Zinin <zinin@amt.ru>
4088
4089 * router and network-LSA origination
4090 changed to honor MinLSInterval
4091
40921999-09-08 Alex Zinin <zinin@amt.ru>
4093
4094 * modified ABR behavior to honor VLs and transit
4095 areas
4096
40971999-09-07 Alex Zinin <zinin@amt.ru>
4098
4099 * completed VL functionality
4100
41011999-09-06 Kunihiro Ishiguro <kunihiro@zebra.org>
4102
4103 * ospf_asbr.c: New file.
4104 ospf_asbr.h: New file.
4105
4106 * ospf_zebra.c (ospf_redistribute_connected): Add redistribute
4107 related stuff.
4108
41091999-09-05 Kunihiro Ishiguro <kunihiro@zebra.org>
4110
4111 * ospfd.h (OSPF_FLAG_VIRTUAL_LINK): Change OSPF_FLAG_VEND to
4112 OSPF_FLAG_VIRTUAL_LINK for comprehensiveness.
4113
41141999-09-03 Kunihiro Ishiguro <kunihiro@zebra.org>
4115
4116 * ospf_spf.c (ospf_spf_register): Change name from
4117 ospf_spf_route_add() to ospf_spf_register().
4118 Include "ospfd/ospf_abr.h" for ospf_abr_task() prototype.
4119
41201999-09-02 Kunihiro Ishiguro <kunihiro@zebra.org>
4121
4122 * ospf_lsa.c (ospf_external_lsa_install): Change to update
4123 lsa->data rather than install new one, when same id lsa is already
4124 installed.
4125
41261999-09-01 Kunihiro Ishiguro <kunihiro@zebra.org>
4127
4128 * ospf_lsa.c (ospf_router_lsa_install): Return lsa value.
4129 (ospf_network_lsa_install): Likewise.
4130 (ospf_summary_lsa_install): Likewise.
4131 (ospf_summary_asbr_lsa_install): Likewise.
4132 (ospf_external_lsa_install): Likewise.
4133
4134 * ospf_spf.c (ospf_spf_calculate): Comment out debug function
4135 ospf_rtrs_print().
4136
41371999-08-31 Kunihiro Ishiguro <kunihiro@zebra.org>
4138
4139 * ospf_spf.c (ospf_rtrs_free): Add ospf_spf_calculate() for
4140 freeing rtrs.
4141
41421999-08-31 Toshiaki Takada <takada@zebra.org>
4143
4144 * ospf_lsa.c (show_ip_ospf_database_summary),
4145 (show_ip_ospf_database_summary_asbr),
4146 (show_ip_ospf_database_external): New function added.
4147 `show ip ospf database summary',
4148 `show ip ospf database asbr-summary'
4149 `show ip ospf database external' command can be used.
4150
4151 * ospf_lsa.c (ospf_lsa_count_table): New function added.
4152 (show_ip_ospf_database_all): show nothing if a type of LSA
4153 does not exist.
4154
41551999-08-31 Kunihiro Ishiguro <kunihiro@zebra.org>
4156
4157 * ospf_lsa.c (ospf_maxage_lsa_remover): Preserve next pointer when
4158 the node is deleted.
4159
41601999-08-31 Toshiaki Takada <takada@zebra.org>
4161
4162 * ospf_flood.c (ospf_ls_retransmit_lookup): change to return
4163 struct ospf_lsa *.
4164 (ospf_ls_request_new), (ospf_ls_request_free),
4165 (ospf_ls_request_add), (ospf_ls_request_delete),
4166 (ospf_ls_request_delete_all), (ospf_ls_request_lookup):
4167 New function added.
4168
4169 * ospf_packet.c (ospf_ls_upd_send_lsa): New function added.
4170
4171 * ospf_lsa.h (LS_AGE): Slightly change macro definition.
4172
4173 * ospf_lsa.c (ospf_lsa_more_recent), (ospf_lsa_diffrent):
4174 Use LS_AGE macro.
4175
41761999-08-30 Alex Zinin <zinin@amt.ru>
4177
4178 * ospfd.c
4179 fix a bug with area range config write
4180 added "show ip ospf" command, it will be enhanced later on
4181
41821999-08-30 Alex Zinin <zinin@amt.ru>
4183
4184 * ospf_lsa.c
4185 updated ospf_router_lsa() to honor flags (B-bit)
4186
41871999-08-30 Alex Zinin <zinin@amt.ru>
4188
4189 * ospf_abr.c
4190 wrote major functions implementing ABR activity
4191
41921999-08-30 Alex Zinin <zinin@amt.ru>
4193
4194 * ospf_ia.c ospf_route.c ospf_route.h
4195 fixed the bug with ospf_route.origin field.
4196 Now it holds pointer to lsa_header
4197
41981999-08-30 Alex Zinin <zinin@amt.ru>
4199
4200 * ospf_flood.c ospf_flood.h:
4201 transformed ospf_flood_if_select into ospf_flood_through_area()
4202 added new ospf_flood_if_select() and ospf_flood_through_as()
4203
42041999-08-30 Toshiaki Takada <takada@zebra.org>
4205
4206 * ospf_flood.[ch]: New file added.
4207
4208 * ospf_packet.c (ospf_lsa_flooding),
4209 (ospf_lsa_flooding_select_if): functions move to ospf_flood.c
4210
4211 * ospf_neighbor.c (ospf_put_lsa_on_retransm_list),
4212 (ospf_remove_lsa_from_retransm_list),
4213 (ospf_nbr_remove_all_lsas_from_retransm_list),
4214 (ospf_lsa_remove_from_ls_retransmit):
4215 (ospf_lsa_retransmit): functions move to
4216 ospf_flood.c, and change function's name:
4217
4218 ospf_put_lsa_on_retransm_list ()
4219 -> ospf_ls_retransmit_add ()
4220 ospf_remove_lsa_from_retransm_list ()
4221 -> ospf_ls_retransmit_delete ()
4222 ospf_nbr_remove_all_lsas_from_retransm_list ()
4223 -> ospf_ls_retransmit_clear ()
4224 ospf_lsa_remove_from_ls_retransmit ()
4225 -> ospf_ls_retransmit_delete_nbr_all ()
4226 ospf_lsa_retransmit ()
4227 -> ospf_ls_retransmit_add_nbr_all ()
4228
4229 * ospf_lsa.c (ospf_lsa_lookup_from_list): function move to
4230 ospf_flood.c, and change name to ospf_ls_retransmit_lookup ().
4231
42321999-08-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4233
4234 * ospf_neighbor.c (ospf_nbr_lookup_by_addr): Use
4235 route_node_lookup() instead of route_node_get().
4236
4237 * ospf_packet.c (ospf_ls_upd): Temporary comment out (6) check.
4238
42391999-08-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4240
4241 * ospf_route.c (ospf_lookup_int_by_prefix): Add check of
4242 oi->address.
4243
42441999-08-29 Alex Zinin <zinin@amt.ru>
4245 * ospf_lsa.c
4246 MaxAge LSA deletion functions added.
4247
42481999-08-29 Alex Zinin <zinin@amt.ru>
4249 * ospf_neighbor.c
4250 ospf_nbr_lookup_by_addr(): added route_unlock_node()
4251 when function returns NULL if (rn->info == NULL)
4252
42531999-08-29 Alex Zinin <zinin@amt.ru>
4254 * ospfd.c
4255 added a hack for area range deletion
4256
42571999-08-29 Alex Zinin <zinin@amt.ru>
4258 * ospf_lsa.h
4259 included lsdb field into struct ospf_lsa, to find
4260 LSDB easier when removing MaxAge LSAs.
4261
42621999-08-29 Alex Zinin <zinin@amt.ru>
4263 * ospf_lsa.c ospf_neighbor.c ospf_nsm.c
4264 ospf_packet.c changed to honor new retransmit list
4265 management functions
4266
42671999-08-29 Alex Zinin <zinin@amt.ru>
4268 * ospf_neighbor.c , .h added new retransmit list functions.
4269
42701999-08-29 Alex Zinin <zinin@amt.ru>
4271 * Makefile.in
4272 added ospf_ase, ospf_abr, ospf_ia
4273
42741999-08-29 Alex Zinin <zinin@amt.ru>
4275 * ospf_spf.c:
4276 - changed ospf_next_hop_calculation() to include interface
4277 and nexthop addr for directly connected routers---more informative
4278 and solves problem with route installation into the kernel
4279 - changed ospf_nexthop_out_if_addr() to support routers, not only
4280 transit networks
4281 - added ospf_process_stubs();
4282
42831999-08-29 Alex Zinin <zinin@amt.ru>
4284 * ospf_lsa.c:
4285 - changed ospf_router_lsa() to provide correct links
4286 for p-t-p interfaces;
4287 - changed ospf_summary_lsa_install() to support table
4288 of self-originated summary-LSAs;
4289 - added ospf_summary_asbr_lsa_install() and ospf_external_lsa_install()
4290 - changed ospf_lsa_install() accordingly
4291 - changed show_ip_ospf_database_router_links() to support p-t-p
4292
42931999-08-29 Kunihiro Ishiguro <kunihiro@zebra.org>
4294
4295 * ospf_packet.c (ospf_make_db_desc): Only master can clear more
4296 flag.
4297
42981999-08-29 Kunihiro Ishiguro <kunihiro@zebra.org>
4299
4300 * ospf_packet.c (ospf_read): Add check of IP src address.
4301
43021999-08-28 Alex Zinin <zinin@amt.ru>
4303 * ospf_neighbor.h
4304 added ospf_nbr_lookup_by_routerid()
4305
43061999-08-28 Alex Zinin <zinin@amt.ru>
4307 * ospfd.h
4308 added ABR/ASBR flag definitions and fields;
4309 added iflist field to area structure;
4310 summary_lsa_self and summary_lsa_asbr_self are changed
4311 to be route tables;
4312 added ranges field---configured area ranges;
4313 A separate Routers RT added;
4314 area range config commands and config write added
4315
4316
43171999-08-28 Alex Zinin <zinin@amt.ru>
4318 * ospf_route.c :
4319 ospf_route_free()--added code to free the list of paths;
4320 The following functions added:
4321 ospf_intra_add_router();
4322 ospf_intra_add_transit();
4323 ospf_intra_add_stub();
4324 the last function uses new ospf_int_lookup_by_prefix();
4325 show_ip_ospf_route_cmd()--changed to support new RT structure;
4326 added ospf_cmp_routes()--general route comparision function;
4327 added ospf_route_copy_nexthops() and ospf_route_copy_nexthops_from_vertex()
4328 they are used in ASE and IA routing;
4329 added ospf_subst_route() and ospf_add_route();
4330
43311999-08-28 Alex Zinin <zinin@amt.ru>
4332 * ospf_route.h :
4333 changed struct ospf_path to include output interface,
4334 changed struct ospf_route to support IA and ASE routing.
4335 added prototypes of the function used in IA and ASE modules.
4336
43371999-08-28 Alex Zinin <zinin@amt.ru>
4338 * ospf_lsa.h ospf_lsa.c :
4339 added ospf_my_lsa(), an interface independent version of
4340 ospf_lsa_is_self_originated(), it will be used in ASE and IA-routing.
4341
43421999-08-27 Kunihiro Ishiguro <kunihiro@zebra.org>
4343
4344 * ospf_interface.c (interface_config_write): Add check for
4345 oi->nbr_self.
4346
43471999-08-25 Toshiaki Takada <takada@zebra.org>
4348
4349 * ospf_lsa.c (ospf_lsa_dup): New function added.
4350
4351 * ospf_packet.c (ospf_write), (ospf_read): Print send/recv
4352 interface in debug message.
4353
43541999-08-25 Toshiaki Takada <takada@zebra.org>
4355
4356 * ospf_packet.c (ospf_ls_ack_send): The name is changed from
4357 `ospf_ls_ack_send'.
4358 (ospf_ls_ack_send_delayed) (ospf_ls_ack_timer): New function added.
4359 Delayed Link State Acknowledgment is scheduled by timer.
4360
43611999-08-25 Alex Zinin <zinin@amt.ru>
4362
4363 * ospf_lsa.c (ospf_router_lsa): Incorrectly included link to
4364 a stub network instead of link to a transit network into
4365 originated router-LSA, bug fixed.
4366
43671999-08-24 Toshiaki Takada <takada@zebra.org>
4368
4369 * ospfd.c (ospf_update_router_id): New function added.
4370
4371 * ospf_network.c (ospf_write): Create new socket per transmission.
4372 And select outgoing interface whether dst is unicast or multicast.
4373
4374 * ospf_packet.c: LSA flooding will work.
4375
43761999-08-24 VOP <vop@unity.net>
4377
4378 * ospf_route.c: Include "sockunion.h"
4379
43801999-08-24 Kunihiro Ishiguro <kunihiro@zebra.org>
4381
4382 * ospf_network.c (ospf_serv_sock_init): Enclose
4383 IPTOS_PREC_INTERNETCONTROL setting with #ifdef for OS which does
4384 not have the definition.
4385
43861999-08-23 Toshiaki Takada <takada@zebra.org>
4387
4388 * ospf_packet.c: Fix bug of DD processing.
4389
43901999-08-18 Toshiaki Takada <takada@zebra.org>
4391
4392 * ospf_lsa.c (show_ip_ospf_database): Show actual `LS age'.
4393
43941999-08-17 Toshiaki Takada <takada@zebra.org>
4395
4396 * ospf_lsa.h (OSPF_MAX_LSA): The value of OSPF_MAX_LSA is
4397 corrected. The bug of `mes_lookup' is fixed.
4398 This had been reported by Poul-Henning Kamp <phk@freebsd.org>.
4399
4400 * ospf_lsa.c (ospf_router_lsa_install): The name is changed from
4401 `ospf_add_router_lsa'.
4402 (ospf_network_lsa_install): The name is changed from
4403 `ospf_add_network_lsa'.
4404
4405 * ospf_interface.h (ospf_interface): Add member `nbr_self'.
4406
4407 * ospf_interface.c (ospf_if_is_enable): New function added.
4408
44091999-08-16 Toshiaki Takada <takada@zebra.org>
4410
4411 * ospf_lsa.h (struct lsa_header): The name is changed from
4412 `struct ospf_lsa'.
4413 (struct ospf_lsa): New struct added to control each LSA's aging
4414 and timers.
4415
4416 * ospf_lsa.c (ospf_lsa_data_free): The name is change from
4417 `ospf_lsa_free'.
4418 (ospf_lsa_data_new), (ospf_lsa_new), (ospf_lsa_free),
4419 (ospf_lsa_different), (ospf_lsa_install): New function added.
4420
4421 * ospf_packet.c (ospf_ls_upd_list_lsa): New function added.
4422
44231999-08-12 Toshiaki Takada <takada@zebra.org>
4424
4425 * ospf_nsm.c (nsm_reset_nbr): New function added.
4426 KillNbr and LLDown neighbor event call this function.
4427
44281999-08-10 Toshiaki Takada <takada@zebra.org>
4429
4430 * ospf_packet.c (ospf_ls_retransmit)
4431 (ospf_ls_upd_timer): New function added.
4432 Set retransmission timer for Link State Update.
4433
44341999-07-29 Toshiaki Takada <takada@zebra.org>
4435
4436 * ospf_ism.c (ospf_dr_election): Fix bug of DR election.
4437
44381999-07-28 Toshiaki Takada <takada@zebra.org>
4439
4440 * ospf_network.c (ospf_serv_sock_init): Set IP precedence field
4441 with IPTOS_PREC_INTERNET_CONTROL.
4442
4443 * ospf_nsm.c (nsm_change_status): Schedule NeighborChange event
4444 if NSM status change.
4445
4446 * ospf_packet.c (ospf_make_hello): Never include a neighbor in
4447 Hello packet, when the neighbor goes down.
4448
44491999-07-26 Kunihiro Ishiguro <kunihiro@zebra.org>
4450
4451 * Makefile.am (noinst_HEADERS): Add ospf_route.h.
4452
4453 * ospf_route.c (show_ip_ospf_route): Add `show ip ospf route'
4454 command.
4455
44561999-07-25 Toshiaki Takada <takada@zebra.org>
4457
4458 * ospf_lsa.c (ospf_router_lsa): Fix bug of LS sequence number
4459 assignement.
4460
44611999-07-25 Kunihiro Ishiguro <kunihiro@zebra.org>
4462
4463 * ospf_route.c (ospf_route_table_free): New function added.
4464
4465 * ospf_spf.c (ospf_spf_next): Free vertex w when cw's and w's
4466 distance is same.
4467
4468 * ospfd.h (struct ospf): Add old_table.
4469
4470 * ospf_main.c (sighup): Call of log_rotate () removed.
4471
4472 * ospf_lsa.c (ospf_lsa_is_self_originated): Fix bug of checking
4473 area->lsa as self LSA. This should be area->lsa_self.
4474
44751999-07-24 Kunihiro Ishiguro <kunihiro@zebra.org>
4476
4477 * ospf_zebra.c (ospf_zebra_add): ospf_zebra_add
4478 (),ospf_zebra_delete () added.
4479
4480 * ospf_spf.c (ospf_spf_calculate): Call ospf_intra_route_add ().
4481
44821999-07-24 Toshiaki Takada <takada@zebra.org>
4483
4484 * ospf_lsa.c: Change LS sequence number treatment.
4485 (ospf_lsa_is_self_originated): New function added.
4486 (show_ip_ospf_database_self_originated): New DEFUN added.
4487
44881999-07-23 Kunihiro Ishiguro <kunihiro@zebra.org>
4489
4490 * ospf_interface.c (ospf_if_lookup_by_addr): Add loopback check.
4491
44921999-07-22 Toshiaki Takada <takada@zebra.org>
4493
4494 * ospf_spf.c (ospf_nexthop_new), (ospf_nexthop_free),
4495 (ospf_nexthop_dup): function added.
4496 (ospf_nexthop_calculation): function changed.
4497
4498 * ospf_interface.c (ospf_if_lookup_by_addr): function added.
4499
45001999-07-21 Toshiaki Takada <takada@zebra.org>
4501
4502 * ospf_spf.c (ospf_spf_closest_vertex): function removed.
4503
45041999-07-21 Kunihiro Ishiguro <kunihiro@zebra.org>
4505
4506 * ospf_spf.c (ospf_spf_next): Apply ntohs for fetching metric.
4507
45081999-07-21 Toshiaki Takada <takada@zebra.org>
4509
4510 * ospf_neighbor.c (ospf_nbr_lookup_by_router_id): fundtion removed.
4511
4512 * ospf_lsa.c (show_ip_ospf_database_router): describe each
4513 connected link.
4514
45151999-07-21 Kunihiro Ishiguro <kunihiro@zebra.org>
4516
4517 * ospf_spf.c (ospf_spf_next): V is router LSA or network LSA so
4518 change behavior according to LSA type.
4519 (ospf_lsa_has_link): Link check function is added.
4520
45211999-07-20 Kunihiro Ishiguro <kunihiro@zebra.org>
4522
4523 * ospf_spf.c (ospf_spf_calculate_schedule): Add new function for
4524 SPF calcultion schedule addtition.
4525 (ospf_spf_calculate_timer_add): Rough 30 sec interval SPF calc
4526 timer is added.
4527 (ospf_spf_next_router): Delete ospf_spf_next_network ().
4528
4529 * ospf_lsa.c (show_ip_ospf_database_all): Network-LSA display
4530 header typo correction. Display of router LSA's #link added.
4531
45321999-07-19 Toshiaki Takada <takada@zebra.org>
4533
4534 * ospf_packet.c (ospf_check_network_mask): Added new function for
4535 receiving Raw IP packet on an appropriate interface.
4536
45371999-07-16 Toshiaki Takada <takada@zebra.org>
4538
4539 * ospfd.c (ospf_router_id): new DEFUN added.
4540
45411999-07-15 Toshiaki Takada <takada@zebra.org>
4542
4543 * ospf_spf.c (ospf_spf_init), (ospf_spf_free),
4544 (ospf_spf_has_vertex), (ospf_vertex_lookup),
4545 (ospf_spf_next_router), (ospf_spf_next_network),
4546 (ospf_spf_closest_vertex), (ospf_spf_calculate):
4547 function added.
4548
45491999-07-13 Toshiaki Takada <takada@zebra.org>
4550
4551 * ospf_ism.c: fix bug of DR Election.
4552
4553 * ospf_nsm.c: fix bug of adjacency forming.
4554
45551999-07-05 Kunihiro Ishiguro <kunihiro@zebra.org>
4556
4557 * ospfd.c (ospf_init): Change to use install_default.
4558
45591999-07-01 Rick Payne <rickp@rossfell.co.uk>
4560
4561 * ospf_zebra.c (zebra_init): Install standard commands to
4562 ZEBRA_NODE.
4563
45641999-06-30 Toshiaki Takada <takada@zebra.org>
4565
4566 * ospf_dump.c: Whole debug command is improved.
4567 (ISM|NSM) (events|status|timers) debug option added.
4568 (show_debugging_ospf): new DEFUN added.
4569
45701999-06-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4571
4572 * ospf_lsa.c (ospf_lsa_lookup_from_list): Change !IPV4_ADDR_CMP to
4573 IPV4_ADDR_SAME.
4574
45751999-06-29 Toshiaki Takada <takada@zebra.org>
4576
4577 * ospf_dump.c (ospf_summary_lsa_dump): Add summary-LSA dump routine.
4578 (ospf_as_external_lsa_dump): Add AS-external-LSA dump routine.
4579
4580 * ospf_nsm.c (nsm_twoway_received): fix condtion of adjacnet.
4581
4582 * ospf_ism.c (ospf_dr_election): fix DR Election.
4583
4584 * ospf_dump.c (ospf_nbr_state_message): fix `show ip ospf neighbor'
4585 command's state.
4586
45871999-06-29 Kunihiro Ishiguro <kunihiro@zebra.org>
4588
4589 * ospf_dump.c (ospf_router_lsa_dump): Add router-LSA dump routine.
4590
45911999-06-28 Toshiaki Takada <takada@zebra.org>
4592
4593 * ospf_lsa.c (show_ip_ospf_database_network): fix bug of
4594 `show ip ospf database network' command output.
4595
4596 * ospf_nsm.c (nsm_inactivity_timer): Clear list of Link State
4597 Retransmission, Database Summary and Link State Request.
4598
4599 * ospf_packet.c (ospf_ls_req_timer): New function added.
4600 Set Link State Request retransmission timer.
4601
46021999-06-27 Kunihiro Ishiguro <kunihiro@zebra.org>
4603
4604 * ospf_main.c (main): Change default output from ZLOG_SYSLOG to
4605 ZLOG_STDOUT.
4606
4607 * ospfd.c (ospf_init): Register show_ip_ospf_interface_cmd and
4608 show_ip_ospf_neighbor_cmd to VIEW_NODE.
4609
4610 * ospf_lsa.c (ospf_lsa_init): Register show_ip_ospf_database_cmd
4611 and show_ip_ospf_database_type_cmd to VIEW_NODE.
4612
46131999-06-25 Toshiaki Takada <takada@zebra.org>
4614
4615 * ospf_packet.c: fix bug of DD making.
4616 fix bug of LS-Update reading.
4617
46181999-06-23 Toshiaki Takada <takada@zebra.org>
4619
4620 * ospf_packet.c: All type of packets are changed to use
4621 fifo queue structure.
4622 (ospf_fill_header) function added.
4623
46241999-06-22 Toshiaki Takada <takada@zebra.org>
4625
4626 * ospf_packet.c (ospf_packet_new): New function added to handle
4627 sending ospf packet by fifo queue structure.
4628 (ospf_packet_free), (ospf_fifo_new), (ospf_fifo_push),
4629 (ospf_fifo_pop), (ospf_fifo_head), (ospf_fifo_flush),
4630 (ospf_fifo_free): Likewise.
4631
46321999-06-21 Toshiaki Takada <takada@zebra.org>
4633
4634 * ospf_nsm.c (ospf_db_desc_timer): function added.
4635 (nsm_timer_set) function added.
4636 * ospf_dump.c (ospf_option_dump): function added.
4637 * ospf_packet.c (ospf_ls_req) (ospf_make_ls_req): function added.
4638
46391999-06-20 Toshiaki Takada <takada@zebra.org>
4640
4641 * ospf_lsa.c (ospf_lsa_more_recent): function added.
4642 * ospf_neighbor.h (struct ospf_neighbor): Change member ms_flag
4643 to dd_flags.
4644
46451999-06-19 Toshiaki Takada <takada@zebra.org>
4646
4647 * ospf_lsa.c: DEFUN (show_ip_ospf_database) Added.
4648 * ospf_interface.c (if_ospf_cost), (if_ospf_dead_interval),
4649 (if_ospf_hello_interval), (if_ospf_priority),
4650 (if_ospf_retransmit_interval), (if_ospf_transmit_delay)
4651 argument changed from NUMBER to <range>.
4652 DEFUN (if_ospf_network_broadcast),
4653 DEFUN (if_ospf_network_non_broadcast),
4654 DEFUN (if_ospf_network_point_to_multipoint),
4655 DEFUN (if_ospf_network_point_to_point) functions are combined to
4656 DEFUN (if_ospf_network).
4657
46581999-06-18 Toshiaki Takada <takada@zebra.org>
4659
4660 * ospf_lsa.c: ospf_add_router_lsa (), ospf_add_network_lsa (),
4661 ospf_lsa_lookup (), ospf_lsa_count () Added.
4662
46631999-06-15 Toshiaki Takada <takada@zebra.org>
4664
4665 * DEFUN (ospf_debug_ism), DEFUN (ospf_debug_nsm),
4666 DEFUN (no_ospf_debug_ism), DEFUN (no_ospf_debug_nsm) Added.
4667 `debug ospf ism' command shows debug message.
4668 `debuf ospf nsm' command shows debug message.
4669
46701999-06-14 Toshiaki Takada <takada@zebra.org>
4671
4672 * ospf_lsa.c: ospf_network_lsa () Added.
4673 ospf_lsa_checksum () Added.
4674 * DEFUN (ospf_debug_packet), DEFUN (no_ospf_debug_packet) Added.
4675 `debug ospf packet' command shows debug message.
4676
46771999-06-13 Toshiaki Takada <takada@zebra.org>
4678
4679 * ospf_packet.h: Remove struct ospf_ls_req {}, ospf_ls_upd {},
4680 ospf_ls_ack {}.
4681
46821999-06-11 Toshiaki Takada <takada@zebra.org>
4683
4684 * ospf_dump.c: fix IP packet length treatment.
4685
46861999-06-10 Toshiaki Takada <takada@zebra.org>
4687
4688 * ospf_ism.h: Add OSPF_ISM_EVENT_EXECUTE() Macro Added.
4689 * ospf_nsm.h: Add OSPF_NSM_EVENT_EXECUTE() Macro Added.
4690
4691 * ospf_packet.c: ospf_db_desc (), ospf_db_desc_send () Added.
4692 ospf_make_hello (), ospf_make_db_desc () Added.
4693 ospf_db_desc_proc () Added.n
4694
4695 * Database Description packet can be processed.
4696
46971999-06-08 Toshiaki Takada <takada@zebra.org>
4698
4699 * ospf_lsa.c: New file.
4700
47011999-06-07 Toshiaki Takada <takada@zebra.org>
4702
4703 * ospf_neighbor.c: ospf_fully_adjacent_count () Added.
4704
47051999-06-07 Kunihiro Ishiguro <kunihiro@zebra.org>
4706
4707 * ospf_spf.[ch]: New file.
4708
47091999-05-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4710
4711 * ospf_zebra.c: Changed to use lib/zclient.c routines.
4712
4713 * ospf_zebra.h (zebra_start): Remove struct zebra.
4714
47151999-05-29 Kunihiro Ishiguro <kunihiro@zebra.org>
4716
4717 * ospfd.c (ospf_config_write): Add cast (unsigned long int) to
4718 ntohl for sprintf warning.
4719
47201999-05-19 Toshiaki Takada <takada@zebra.org>
4721
4722 * ospf_ism.c (ospf_dr_election): Join AllDRouters Multicast group
4723 if interface state changes to DR or BDR.
4724
47251999-05-14 Stephen R. van den Berg <srb@cuci.nl>
4726
4727 * ospf_main.c (signal_init): SIGTERM call sigint.
4728 (sigint): Logging more better message.
4729
47301999-05-12 Toshiaki Takada <takada@zebra.org>
4731
4732 * ospfd.c: Fix bug of `no router ospf' statement, it will work.
4733
47341999-05-11 Toshiaki Takada <takada@zebra.org>
4735
4736 * ospf_neighbor.c: ospf_nbr_free () Added.
4737
47381999-05-10 Toshiaki Takada <takada@zebra.org>
4739
4740 * ospfd.h: struct ospf_area { }, struct ospf_network { } Changed.
4741 * Fix bug of `no network' statement, it will work.
4742
47431999-05-07 Toshiaki Takada <takada@zebra.org>
4744
4745 * ospf_interface.c, ospf_zebra.c: Fix bug of last interface is not
4746 updated by ospf_if_update ().
4747
47481999-04-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4749
4750 * Makefile.am (noinst_HEADERS): Add ospf_lsa.h for distribution.
4751
47521999-04-25 Toshiaki Takada <takada@zebra.org>
4753
4754 * ospf_interface.c: DEFUN (no_if_ospf_cost),
4755 DEFUN (no_if_ospf_dead_interval),
4756 DEFUN (no_if_ospf_hello_interval),
4757 DEFUN (no_if_ospf_priority),
4758 DEFUN (no_if_ospf_retransmit_interval),
4759 DEFUN (no_if_ospf_transmit_delay) Added.
4760
4761 interface_config_write () suppress showing interface
4762 default values.
4763
47641999-04-25 Kunihiro Ishiguro <kunihiro@zebra.org>
4765
4766 * ospf_dump.c (ospf_timer_dump): If thread is NULL return "inactive".
4767
4768 * ospfd.c (ospf_if_update): Fix bug of using ospf_area { } instead
4769 of ospf_network { }. So `router ospf' statement in ospfd.conf
4770 works again.
4771 (ospf_if_update): Call ospf_get_router_id for updating router ID.
4772
47731999-04-25 Toshiaki Takada <takada@zebra.org>
4774
4775 * ospf_interface.c: DEFUN (if_ospf_network) deleted.
4776 DEFUN (if_ospf_network_broadcast),
4777 DEFUN (if_ospf_network_non_broadcast),
4778 DEFUN (if_ospf_network_point_to_multipoint),
4779 DEFUN (if_ospf_network_point_to_point),
4780 DEFUN (no_if_ospf_network) Added.
4781
47821999-04-23 Toshiaki Takada <takada@zebra.org>
4783
4784 * ospfd.h: struct area { } changed to struct ospf_network { }.
4785 Add struct ospf_area { }.
4786 * ospfd.c: Add ospf_area_lookup_by_area_id (), ospf_network_new (),
4787 and ospf_network_free ().
4788 DEFUN (area_authentication), DEFUN (no_area_authentication) Added.
4789
47901999-04-22 Toshiaki Takada <takada@zebra.org>
4791
4792 * ospf_lsa.h: New file.
4793 * ospf_packet.h: LSA related struct definition are moved to
4794 ospf_lsa.h.
4795 * ospf_packet.c: ospf_verify_header () Added.
4796
47971999-04-21 Toshiaki Takada <takada@zebra.org>
4798
4799 * ospf_ism.c: ospf_elect_dr () and related function is changed.
4800 DR Election bug fixed.
4801 * ospf_dump.c: ospf_nbr_state_message (), ospf_timer_dump () Added.
4802 * ospfd.c: DEFUN (show_ip_ospf_neighbor) Added.
4803
48041999-04-19 Kunihiro Ishiguro <kunihiro@zebra.org>
4805
4806 * ospf_main.c (main): access_list_init () is added for vty
4807 connection filtering.
4808
48091999-04-16 Toshiaki Takada <takada@zebra.org>
4810
4811 * ospfd.c: DEFUN (show_ip_ospf_interface) Added.
4812 * ospf_neighbor.c: ospf_nbr_count () Added.
4813
48141999-04-15 Toshiaki Takada <takada@zebra.org>
4815
4816 * ospfd.h: struct ospf { } Changed.
4817 * ospfd.c: ospf_lookup_by_process_id () Deleted.
4818 * ospf_ism.c: ospf_wait_timer () Added. WaitTimer will work.
4819
48201999-04-14 Toshiaki Takada <takada@zebra.org>
4821
4822 * ospf_ism.c: ospf_elect_dr () Added.
4823 * ospf_network.c: ospf_if_ipmulticast () Added.
4824
48251999-04-11 Toshiaki Takada <takada@zebra.org>
4826
4827 * ospf_interface.c: interface_config_write (),
4828 DEFUN (if_ip_ospf_cost),
4829 DEFUN (if_ip_ospf_dead_interval),
4830 DEFUN (if_ip_ospf_hello_interval),
4831 DEFUN (if_ip_ospf_priority),
4832 DEFUN (if_ip_ospf_retransmit_interval) and
4833 DEFUN (if_ip_ospf_transmit_delay) Added.
4834
48351999-04-08 Toshiaki Takada <takada@zebra.org>
4836
4837 * ospf_dump.c: ospf_packet_db_desc_dump () Added.
4838 * ospf_neighbor.c: ospf_nbr_bidirectional () Added.
4839 * ospf_nsm.c: nsm_twoway_received () Added.
4840
48411999-04-02 Toshiaki Takada <takada@zebra.org>
4842
4843 * ospf_neighbor.c: New file.
4844 * ospf_neighbor.h: New file.
4845 * ospf_nsm.c: New file.
4846 * ospf_nsm.h: New file.
4847 * ospf_packet.c: Add ospf_make_header (), ospf_hello () and
4848 ospf_hello_send (). Now OSPFd can receive Hello and send Hello.
4849
48501999-03-27 Kunihiro Ishiguro <kunihiro@zebra.org>
4851
4852 * ospf_packet.c: Add ospf_recv_packet (). Now OSPF Hello can receive.
4853
48541999-03-19 Toshiaki Takada <takada@zebra.org>
4855
4856 * ospf_packet.c: New file.
4857 * ospf_packet.h: New file.
4858 * ospf_network.c: New file.
4859 * ospf_network.h: New file.
4860 * ospfd.h: move OSPF message structure has moved to ospf_packet.h.
4861
48621999-03-17 Kunihiro Ishiguro <kunihiro@zebra.org>
4863
4864 * ospf_zebra.c (ospf_zebra_get_interface): Fix for IPv6 interface
4865 address.
4866
4867 * Makefile.am (install-sysconfDATA): Overwrite install-sysconfDATA
4868 for install ospfd.conf.sample as owner read only file.
4869
4870 * ospf_main.c (usage): Change to use ZEBRA_BUG_ADDRESS.
4871
48721999-03-15 Toshiaki Takada <takada@zebra.org>
4873
4874 * ospf_ism.c: New file.
4875 * ospf_ism.h: New file.
4876 * ospf_dump.c: New file.
4877 * ospf_dump.h: New file.
4878
4879 * ospfd.h: Add (struct ospf), (struct config_network),
4880 (struct message) structure.
4881
4882 * ospf_interface.c: Add ospf_if_match_network ().
4883 * ospf_interface.h (struct ospf_interface): Change struct members.
4884
4885 * ospfd.c: ospf_lookup_by_process_id (), ospf_network_new (),
4886 DEFUN (network_area): Added.
4887
4888 * ospfd.conf.sample: Change sample configuration.
4889
48901999-03-05 Toshiaki Takada <takada@zebra.org>
4891
4892 * ospf_interface.c: New file.
4893 * ospf_interface.h: New file.
4894 * ospf_zebra.h: New file.
4895 * ospf_zebra.c: Add interface function for zebra daemon.
4896 * ospfd.c: New file.
4897
48981999-02-23 Kunihiro Ishiguro <kunihiro@zebra.org>
4899
4900 * Move IPv6 codes and files to ospf6d directory.
4901
49021999-02-18 Peter Galbavy <Peter.Galbavy@knowledge.com>
4903
4904 * syslog support added
4905
49061998-12-22 Toshiaki Takada <takada@zebra.org>
4907
4908 * ospfd.h: New file.
4909 * ospf_lsa.h: New file.
4910
49111998-12-15 Kunihiro Ishiguro <kunihiro@zebra.org>
4912
4913 * Makefile.am: New file.
4914 * ospf_main.c: New file.
4915