blob: d0a3fcf04b1489b576194a240d115f2095a44b80 [file] [log] [blame]
Paul Jakmab75ae992007-03-23 11:17:28 +000012007-03-23 Paul Jakma <paul.jakma@sun.com>
2
3 * ospf_spf.c: (various) Add more debug statements.
4
Andrew J. Schorr56b3ea02007-03-14 20:21:43 +000052007-03-14 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
6
Andrew J. Schorrad81f8c2007-03-14 22:05:18 +00007 * ospf_snmp.c: (ospf_snmp_neighbor_state) New function to
8 map internal quagga neighbor states to SNMP standard values.
9 (ospfNbrEntry) Call new ospf_snmp_neighbor_state function.
10
112007-03-14 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
12
Andrew J. Schorr56b3ea02007-03-14 20:21:43 +000013 * ospf_zebra.c: (ospf_zebra_add, ospf_zebra_delete) Fix bug
14 where inet_ntoa was used twice in the same debug message,
15 which doesn't work because there's a single shared buffer
16 for the returned string. The fix is to use inet_ntop.
17
Andrew J. Schorr4056a542007-02-27 13:55:46 +0000182007-02-27 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
19
20 * ospfd.c: (ospf_terminate) Exit immediately if ospf is not
21 actually running (e.g. the config file was empty). Fixes
22 bug where SIGTERM would not kill ospfd.
23
Paul Jakmabd34fb32007-02-26 17:14:48 +0000242007-02-26 Paul Jakma <paul.jakma@sun.com>
25
26 * ospf_spf.c: Fix regression introduced with bug #330 fix: The
27 cost update added to ospf_spf_add_parent only handled PtP
28 case, differing from same functionality in higher-level
29 ospf_spf_next. Regression diagnosed by Anders Pedersen,
30 mailnews+router-quagga-dev@news.cohaesio.com.
31 (ospf_vertex_new) Initialise vertices to max-cost.
32 (ospf_spf_init) Root vertex always creates with 0 cost.
33 (ospf_spf_add_parent) Remove the buggy V->W cost calculating
34 code, instead take the new distance as a parameter.
35 (ospf_nexthop_calculation) Take distance as parameter, so it
36 can be passed down to add_parent.
37 (ospf_spf_next) Dont initialise candiate vertex distance,
38 vertex_new does so already. Pass distance down to
39 nexthop_calculation (see above).
40
Paul Jakmabc20c1a2007-01-24 14:51:51 +0000412007-01-24 Paul Jakma <paul.jakma@sun.com>
42
43 * ospf_spf.c: Bug #330: Nexthop calculation sometimes may fail,
44 and it needs to indicate this result to SPF.
45 (ospf_spf_add_parent) Flush of parent list needs to be done here,
46 for simplicity.
47 (ospf_nexthop_calculation) Caller needs to know whether
48 nexthop calculation succeeded. Every return statement must
49 correctly indicate such.
50 (ospf_spf_next) Queueing/prioritisation of vertices in SPF
51 must take into account whether nexthop_calculation succeeded,
52 or SPF may fail to find best paths.
53
Andrew J. Schorre4529632006-12-12 19:18:21 +0000542006-12-12 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
55
56 * ospf_interface.c: (ospf_if_is_configured, ospf_if_lookup_by_prefix,
57 ospf_if_lookup_recv_if) Simplify logic using new CONNECTED_PREFIX
58 macro.
59 * ospf_lsa.c: (lsa_link_ptop_set) Using the new CONNECTED_PREFIX
60 macro, both options collapse into the same code.
61 * ospf_snmp.c: (ospf_snmp_if_update) Simplify logic using new
62 CONNECTED_ID macro.
63 (ospf_snmp_is_if_have_addr) Simplify logic using new CONNECTED_PREFIX
64 macro.
65 * ospf_vty.c: (show_ip_ospf_interface_sub) Use new CONNECTED_PEER macro
66 instead of testing the IFF_POINTOPOINT flag.
67 * ospfd.c: (ospf_network_match_iface) Use new CONNECTED_PEER macro
68 instead of testing with if_is_pointopoint. And add commented-out
69 code to implement alternative (in my opinion) more elegant behavior
70 that has no special-case treatment for PtP addresses.
71 (ospf_network_run) Use new CONNECTED_ID macro to simplify logic.
72
Andrew J. Schorred589c12006-12-04 18:26:37 +0000732006-12-04 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
74
75 * ospfd.c: (ospf_network_run) Remove an offending 'break' statement.
76 Previously, after creating a single ospf_interface on a given
77 network interface, the code would skip to the next interface
78 without considering other connected addresses on the interface.
79 After removing the 'break', we now consider all connected addresses.
80
Andrew J. Schorr7f643eb2006-11-30 16:17:02 +0000812006-11-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
82
83 * ospf_zebra.c: (ospf_router_id_update_zebra,
84 ospf_interface_address_add, ospf_interface_address_delete)
85 If (IS_DEBUG_OSPF (zebra, ZEBRA_INTERFACE)) is enabled, then
86 add a debug message about what Zebra is telling us.
87 (ospf_zebra_add_discard) Add a debug message matching the one
88 already in ospf_zebra_delete_discard.
89
Andrew J. Schorr43540882006-11-28 16:36:39 +0000902006-11-28 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
91
92 * ospf_vty.c: (ospf_passive_interface_default) Take additional
93 'newval' arg so we can update ospf->passive_interface_default inside
94 this function. More importantly, we now call ospf_if_set_multicast
95 on all ospf_interfaces.
96 (ospf_passive_interface, no_ospf_passive_interface) Fix bug:
97 for 'default' case, argv[0] is undefined, so we must test for
98 (argc == 0) before using argv[0]. And since
99 ospf_passive_interface_default now calls ospf_if_set_multicast as
100 needed, we can just return after calling
101 ospf_passive_interface_default.
102
Andrew J. Schorr8fb8a502006-10-24 19:04:26 +00001032006-10-24 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
104
105 * ospf_zebra.c: (ospf_redistribute_default_set) Fix bug where
106 a new value for ospf->default_originate was being ignored
107 if a previous 'default-information originate' command
108 had already been processed.
109
Paul Jakma7ffa8fa2006-10-22 20:07:53 +00001102006-10-22 Yar Tikhiy <yar@comp.chem.msu.su>
111
112 * (general) Add support for passive-interface default (with
113 minor edits by Paul Jakma).
114 * ospf_interface.h: Add OSPF_IF_PASSIVE_STATUS macro, looking
115 at configured value, or the global 'default' value, as
116 required.
117 * ospf_interface.c: (ospf_if_new_hook) Leave passive
118 unconfigured per default, allowing global 'default' to
119 take effect for unconfigured interfaces.
120 * ospf_packet.c: (various) use OSPF_IF_PASSIVE_STATUS
121 * ospf_vty.c: (ospf_passive_interface_default) new function,
122 unset passive from all interfaces if default is enabled, as
123 the per-iface settings become redundant.
124 (ospf_passive_interface_update) new func, update passive
125 setting taking global default into account.
126 ({no,}ospf_passive_interface_addr_cmd) Add support for
127 'default' variant of command.
128 (show_ip_ospf_interface_sub) Update to take global
129 default into account when printing passive status.
130 (ospf_config_write) ditto.
131 * ospfd.c: (ospf_new) set global passive-interface default.
132 * ospfd.h: (struct ospf) Add field for global
133 passive-interface.
134
Andrew J. Schorr08c83672006-09-25 13:26:14 +00001352006-09-25 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
136
137 * ospf_packet.c: (ospf_packet_dup, ospf_make_md5_digest)
138 Fix zlog_warn messages to eliminate compiler warnings.
139 (ospf_hello) Improve warning messages to show why we
140 are complaining.
141
Paul Jakmab5aeb442006-08-30 18:47:37 +00001422006-08-28 Andy Gay <andy@andynet.net>
143
144 * ospf_packet.c: (ospf_make_db_desc) Assert added with More-bit
145 fixes does not hold up with addition of Ogier DB-Exchange
146 optimisation, which can empty the db-summary list in between
147 sent DD packets. Remove assert, update More-bit always when
148 in Exchange.
149
Paul Jakma29b5a042006-08-27 08:01:20 +00001502006-08-27 J.J. Krabbendam <jkrabbendam@aimsys.nl>
151
152 * ospfd.c: (ospf_finish_final) default redistribute should be
153 unset too, fixes bug where reconfiguring ospfd completely
154 can no longer enable default redistribution.
155
Paul Jakma2518efd2006-08-27 06:49:29 +00001562006-08-25 Paul Jakma <paul.jakma@sun.com>
157
158 * (general) Bug #134. Be more robust to backward time changes,
159 use the newly added libzebra time functions.
160 In most cases: recent_time -> recent_relative_time()
161 gettimeofday -> quagga_gettime (QUAGGA_CLK_MONOTONIC, ..)
162 time -> quagga_time.
163 (ospf_make_md5_digest) time() call deliberately not changed.
164 (ospf_external_lsa_refresh) remove useless gettimeofday, LSA
165 tv_orig time was already set in ospf_lsa_new, called via
166 ospf_external_lsa_new.
167
Paul Jakmaba122e72006-08-27 06:24:34 +00001682006-08-04 Paul Jakma <paul.jakma@sun.com>
169
170 * ospf_lsdb.c: (ospf_lsdb_delete_entry) new function, consolidate
171 exact same functionality replicated in other functions.
172 (ospf_lsdb_add) Strip out code by using ospf_lsdb_delete_entry.
173 (ospf_lsdb_delete) ditto.
174 (ospf_lsdb_delete_all) ditto.
175
Paul Jakma8dd24ee2006-08-27 06:29:30 +00001762006-08-03 Paul Jakma <paul.jakma@sun.com>
177
178 * ospf_packet.c: (ospf_make_db_desc) Unset the DD More bit
179 after constructing the packet, if appropriate.
180 (ospf_db_desc_proc) Speed up Exchange, slave should raise
181 ExchangeDone earlier, as RFC mandates, by forming its reply
182 before deciding whether both sides are done, avoids a
183 needless round of empty DD packet exchanges at the end of
184 Exchange, hence speeding up ExchangeDone.
Paul Jakmaf0894cf2006-08-27 06:40:04 +0000185 Implement draft-ogier-ospf-dbex-opt DB-exchange optimisation.
Paul Jakma8dd24ee2006-08-27 06:29:30 +0000186 (ospf_db_desc) use UNSET_FLAG macro.
187
Andrew J. Schorr16700082006-07-27 22:29:06 +00001882006-07-27 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
189
190 * ospfd.c: (ospf_router_id_update) Fix and document the algorithm for
191 selecting the router ID: if there is not a statically configured ID,
192 then stick to the most recent value to avoid disruptive changes.
193 This should fix bug #288.
194
Paul Jakma1fe6ed32006-07-26 09:37:26 +00001952006-07-26 Paul Jakma <paul.jakma@sun.com>
196
197 * ospf_lsa.{c,h}: (ospf_lsa_unlock) Change to take a double pointer
198 to the LSA to be 'unlocked', so that, if the LSA is freed, the
199 callers pointer to the LSA can be NULLed out, allowing any further
200 use of that pointer to provoke a crash sooner rather than later.
201 * ospf_*.c: (general) Adjust callers of ospf_lsa_unlock to match
202 previous. Try annotate 'locking' somewhat to show which 'locks'
203 are protecting what LSA reference, if not obvious.
204 * ospf_opaque.c: (ospf_opaque_lsa_install) Trivial: remove useless
205 goto, replace with return.
206 * ospf_packet.c: (ospf_make_ls_ack) Trivial: merge two list loops,
207 the dual-loop predated the delete-safe list-loop macro.
208
Paul Jakma3fed4162006-07-25 20:44:12 +00002092006-07-25 Paul Jakma <paul.jakma@sun.com>
210
211 * ospf_neigbor.h: (struct ospf_neighbor) Add some additional
212 neighbour state statistics fields, timestamps for progressive
213 and regressive state changes, and pointer to event string
214 for the latter state change.
215 * ospf_nsm.c: (nsm_notice_state_change) Update new state changs
216 history as required.
217 * ospf_vty.c: (show_ip_ospf_neighbor_detail_sub) Print out above
218 new per-neighbour state change stats.
219
Paul Jakma539e1522006-07-11 17:49:22 +00002202006-07-10 Paul Jakma <paul.jakma@sun.com>
221
222 * ospf_nsm.c: (nsm_change_state) call nsm_clear_adj for all
223 adjacency losses, hence removing need for nsm_reset_nbr.
224 (nsm_reset_nbr) kill it, clear_adj in previous does fine.
225 (nsm_kill_nbr,nsm_start) remove nsm_reset_nbr call.
226 (ospf_nsm_event) Allow NSM function to be NULL, this along with
227 removal of nsm_reset_nbr, allows a bunch of now useless functiosn
228 to be removed.
229 Remove some useless variables.
230 (nsm_ignore) now useless, remove.
231 (nsm_bad_ls_req) ditto
232 (nsm_seq_number_mismatch) "
233 (nsm_oneway_received) "
234 (nsm_inactivity_timer) "
235 (nsm_ll_down) "
236 (NSM) replace removed action functions with NULL.
Paul Jakma3d63f382006-07-11 17:52:53 +0000237 (nsm_notice_state_changes) Move state change logging code to new
238 func to declutter nsm_change_state and ospf_nsm_event.
239 Log event with AdjChange, it's useful to know.
240 (nsm_change_state) move adjchange and snmp logging to previous.
241 (ospf_nsm_event) call nsm_notice_state_changes from here.
242 Move the debug message to entry of function, so it gets out
243 even if something goes wrong.
Paul Jakma90c33172006-07-11 17:57:25 +0000244 Record state change timestamp and event in nbr struct.
245 * ospf_neighbor.h: (struct ospf_neighbor) Add fields to record
246 timestamp of last NSM change and event.
247 * ospf_vty.c: (show_ip_ospf_neighbor_detail_sub) Print
248 last state change timestamp and event, if available.
Paul Jakma539e1522006-07-11 17:49:22 +0000249
Andrew J. Schorr13cd3dc2006-07-11 01:50:30 +00002502006-07-10 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
251
252 * ospf_packet.c: (ospf_hello) Improve NetworkMask mismatch warning
253 message to include interface name and conflicting prefix lengths.
254
Paul Jakma1f2c2742006-07-10 07:45:13 +00002552006-07-07 Paul Jakma <paul.jakma@sun.com>
256
257 * ospf_nsm.h: Add a NSM_Deleted neighbour state, to act as dummy
258 state indicating the neighbour is to be deleted.
259 * ospf_nsm.c: (general) Use the NSM_Deleted state to delete
260 neighbours, thus allowing code to be slightly more obvious
261 in its flow.
262 (nsm_timer_set) Add NSM_Deleted. Add another timer the code
263 missed.
264 (nsm_kill_nbr) No need for special case call to nsm_change_state
265 anymore.
266 Make the assert and error-handling for same case more readable
267 (Andrew Schorr)
268 Remove the call to ospf_nbr_delete, nsm_change_state can do
269 this generally now via NSM_Deleted.
270 (struct ... NSM) Add the dummy NSM_Deleted state, the 3 events
271 that can lead to nsm_kill_nbr all now transition the NBR to
272 NSM_Deleted and the general change_state function can be left
273 to do the work.
274 (ospf_nsm_event) Special casing of events and early-return can
275 be removed now.
276 On transition into Deleted, delete the nbr.
277 * ospf_dump.c: (ospf_nsm_state_msg) Add Deleted.
278
Paul Jakmaaa2737a2006-07-06 11:12:39 +00002792006-07-06 Paul Jakma <paul.jakma@sun.com>
280
281 * ospf_nsm.c: (ospf_nsm_event) LLDown event also results in nbr
282 being deleted, requires early-return too. Likely explains
283 some crash reports after interface events.
284
Paul Jakmaf7a76ab2006-07-04 13:57:49 +00002852006-07-04 Paul Jakma <paul.jakma@sun.com>
286
287 * ospf_nsm.c: (general) Various small cleanups from Andrew's
288 review of last set of patches.
289 (nsm_timer_set) Loading, Full and default can share
290 same code too.
291 (nsm_should_adj) Can just be one big OR.
292 (nsm_twoway_received) Collapse into return statement.
293
Paul Jakmad7b0fb62006-07-04 13:35:24 +00002942006-07-02 Paul Jakma <paul.jakma@sun.com>
295
296 * ospf_nsm.c: (nsm_should_adj) New function, just consolidate the
297 10.4 adjacency check from nsm_twoway_received/nsm_adj_ok.
298 (nsm_twoway_received/nsm_adj_ok) Use former.
Paul Jakmad1b1cd82006-07-04 13:50:44 +0000299 (nsm_clear_adj) clear adjacency related state for a
300 neighbour, needed for some state changes from > ExStart down
301 to ExStart or less, which need not go through nsm_reset_nbr.
302 (nsm_reset_nbr) move code to former. Should be static.
Paul Jakmaba0beb42006-07-04 13:44:19 +0000303 (ospf_nsm_event) Don't allow action functions to change
304 next_state if the NSM tables do not indicate next_state is
305 conditional, log warning if one tries - existing code
306 appears fine though.
Paul Jakmad1b1cd82006-07-04 13:50:44 +0000307 Remove long dead code.
308 Use nsm_clear_adj for state changes that take down
309 adjacencies to TwoWay/ExStart.
Paul Jakmae55dd532006-07-04 13:46:14 +0000310 (nsm_timer_set) ls_req timer should be OFF in early states.
311 Compact several identical sections.
312 Set inactivity timer to OFF for Down, for documentary
313 purposes.
Paul Jakmad1b1cd82006-07-04 13:50:44 +0000314 (nsm_kill_nbr) Oops, action function shouldn't try return
315 1 for error.
Paul Jakma5db95bc2006-07-04 13:52:29 +0000316 * ospf_lsa.c: (ospf_translated_nssa_refresh) CID #13.
Paul Jakmad7b0fb62006-07-04 13:35:24 +0000317
Andrew J. Schorr1c066bf2006-06-30 16:53:47 +00003182006-06-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
319
320 * ospf_vty.c: (show_ip_ospf_neighbor_id) Should show all instances
321 of that neighbor (since it may appear on multiple interfaces)
322 instead of bailing out after showing the first match.
323
Andrew J. Schorr76947872006-06-30 03:21:05 +00003242006-06-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
325
326 * ospf_nsm.c: (nsm_twoway_received) When deciding whether to
327 change from state Init to ExStart, the test for whether the
328 neighboring router is DR or BDR should be against the
329 local router's notion of DR/BDR, not the neighbor's view.
330
Andrew J. Schorrd7e60dd2006-06-29 20:20:52 +00003312006-06-28 Erik Muller <erikm@internap.com>
332
333 * ospfd.h: Define 2 new struct ospf config flags:
334 OSPF_LOG_ADJACENCY_CHANGES and OSPF_LOG_ADJACENCY_DETAIL
335 * ospf_nsm.c (nsm_change_state): Log adjacency changes if
336 requested.
337 * ospf_vty.c (ospf_log_adjacency_changes): New command function
338 to implement ospf subcommand "log-adjacency-changes [detail]".
339 (no_ospf_log_adjacency_changes) Turn off log-adjacency-changes.
340 (show_ip_ospf) Show whether adjacency changes are logged.
341 (ospf_config_write) Add "log-adjacency-changes [detail]" to config.
342 (ospf_vty_init) Add ospf_log_adjacency_changes and
343 no_ospf_log_adjacency_changes.
344
Paul Jakma9560fa82006-06-26 12:50:06 +00003452006-06-26 Paul Jakma <paul.jakma@sun.com>
346
347 * ospf_abr.c: (general) NSSA translate-candidate ABRs need to
348 be ASBRs, or other routers may rightfully refuse to install
349 translated type-5s LSAs. reported by dendroot@gmail.com.
350 (ospf_abr_nssa_check_status) Detect change in translator
351 state when ABR, and inc/dec redistribute count as when we
352 leave/enter the disabled state - so that translate-enabled
353 ABR properly sets ASBR bit on non-NSSA areas.
354 Run the resulting function through indent to clean it up.
355 * ospf_lsa.c: (router_lsa_flags) For purposes of ASBR bit,
356 NSSA area is same as stub area.
357
Andrew J. Schorr0ffb7092006-06-24 19:40:13 +00003582006-06-24 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
359
Andrew J. Schorr9aecfae2006-06-24 20:05:02 +0000360 * ospf_snmp.c: (ospfTrapNbrStateChange, ospfTrapIfStateChange) Improve
361 info log message to indicate why the trap is being sent.
362
3632006-06-24 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
364
Andrew J. Schorr0ffb7092006-06-24 19:40:13 +0000365 * ospf_dump.c: (config_write_debug) Fix typo to show debug ospf nsm
366 status properly (not ism status).
367
Andrew J. Schorr6e72cb62006-06-18 00:45:48 +00003682006-06-17 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
369
370 * ospf_vty.c: ({no_,}ospf_passive_interface) Replace if_lookup_by_name
371 with a call to if_get_by_name -- if the interface does not exist
372 already, it should be created. And remove the obsolete warning
373 message.
374
Paul Jakma429ac782006-06-15 18:40:49 +00003752006-06-15 Paul Jakma <paul.jakma@sun.com>
376
377 * ospf_interface.h: (struct ospf_if_info) Add reference counts
378 for multicast group memberships. Add various macros to help
379 manipulate/check membership state.
380 * ospf_interface.c: (ospf_if_set_multicast) Maintain the
381 ospf_if_info reference counts, and only actually drop
382 memberships if it hits 0, to avoid losing membership when
383 OSPF is disabled on an interface with multiple active OSPF
384 interfaces.
385 * ospf_packet.c: (ospf_{hello,read}) Use the new macros to
386 check/set
387 multicast membership.
388 * ospf_vty.c: (show_ip_ospf_interface_sub) ditto.
389
Paul Jakmaac904de2006-06-15 12:04:57 +00003902006-05-31 Paul Jakma <paul.jakma@sun.com>
391
392 * ospf_lsdb.c: (ospf_lsdb_delete) robustify against NULL arguments,
393 print warning.
394 * ospf_lsa.c: (ospf_discard_from_db) ditto.
395 (ospf_maxage_lsa_remover) Check lsa->lsdb for validity, possible
396 mitigation (but not solution) for bug #269.
397
Paul Jakma88871b12006-06-15 11:41:19 +00003982006-05-30 Paul Jakma <paul.jakma@sun.com>
399
400 * ospf_packet.c: (ospf_read) Debug message about packets
401 received on unenabled interfaces should be conditional on
402 debug being set.
403
Paul Jakmad1c65c22006-06-27 08:01:43 +00004042006-05-23 Paul Jakma <paul.jakma@sun.com>
405
406 * ospf_vty.c: (general) Replace in-place route redistribution
407 command and help strings with the new auto-generated defines
408 from lib/route_types.h
409
Paul Jakmaae128052006-05-12 23:15:30 +00004102006-05-13 Paul Jakma <paul.jakma@sun.com>
411
412 * ospf_lsa.c: (ospf_translated_nssa_refresh) fix the sanity
413 check to match the assert, small error in CID #13 fix.
414
Paul Jakma70461d72006-05-12 22:57:57 +00004152006-05-12 Paul Jakma <paul.jakma@sun.com>
416
417 * ospf_lsa.c: (ospf_lsa_action) Get rid of the ospf_lookup
418 call, which is not checked for NULL return, by stripping out
419 functionality which is never used, hence fixing Coverity CID
420 #29.
421 (struct lsa_action) remove unused member.
Paul Jakmae54e6e52006-05-12 23:11:14 +0000422 (ospf_translated_nssa_refresh) Add non-assert sanity check,
423 in case DEBUG isn't defined.
424 Debug message when no type7 exists should print the ID from
425 the type5, not the type7, fixes CID #13.
426 * ospf_interface.c: (ospf_if_exists) Fix missing NULL return
Paul Jakmae43be0e2006-05-12 23:00:06 +0000427 check on ospf_lookup, CID #27.
Paul Jakma6db3a6f2006-05-12 23:02:46 +0000428 * ospf_asbr.c: (ospf_redistribute_withdraw) remove ospf_lookup
429 call by taking the struct ospf * as argument, which the
430 caller has, fixing CID #28.
431 * ospf_asbr.h: (ospf_redistribute_withdraw) update declaration
432 * ospf_zebra.c: (ospf_redistribute_unset) update call to
433 ospf_redistribute_withdraw to match.
Paul Jakmabfd7c7d2006-05-12 23:04:45 +0000434 * ospf_ia.c: (ospf_update_router_route) ospf->backbone could be
435 NULL when passed to ospf_find_asbr_route_through_area,
436 check for NULL first, CID #14.
Paul Jakmadeb15612006-05-12 23:07:27 +0000437 * ospf_ism.c: (ism_change_state) NULL check on oi->area is
438 useless, it's always valid. Only possibility where it
439 couldn't be is if there is a race between abr_task and
440 cleaning up oi's, in which case a NULL check here isn't going
441 to do anything. Fixes CID #15.
Paul Jakma70461d72006-05-12 22:57:57 +0000442
Paul Jakmacac3b5c2006-05-11 13:31:11 +00004432006-05-11 Paul Jakma <paul.jakma@sun.com>
444
445 * ospf_vty.c: (general) Audit ospf_lookup calls in commands,
446 ensure check for NULL result, make vty messages consistent.
447 (show_ip_ospf_interface) Missing NULL check on ospf_lookup
448 result, fixes Coverity CID #70.
Paul Jakma1a8ec2b2006-05-11 13:34:08 +0000449 (no_ospf_area_filter_list) Check NULL result from
450 ospf_area_lookup_by_area_id, fixes Coverity CID #69
Paul Jakma894f8b62006-05-12 22:50:40 +0000451 * ospf_route.c: (ospf_route_delete_same_ext) Fix deref before
452 NULL check by moving into check-protected block, fix CID #49.
Paul Jakma214a4452006-05-12 22:51:49 +0000453 * ospf_abr.c: (ospf_area_range_cost_set) Shouldn't create a new
454 range, should just lookup to see if one exists, the new range
455 is just leaked. Fixes CID #46.
Paul Jakma4021b602006-05-12 22:55:41 +0000456 * ospf_lsa.c: (ospf_default_originate_timer) Let the thread
457 take (struct ospf *) as thread argument, rather than (struct
458 ospf *)->default_originate, thus avoiding having to call
459 ospf_lookup.
460 * ospf_zebra.c: (ospf_redistribute_default_set) change setup
461 of ospf_default_originate_timer thread to match.
462 * ospfd.c: (ospf_router_id_update) ditto.
Paul Jakmacac3b5c2006-05-11 13:31:11 +0000463
Paul Jakma9c27ef92006-05-04 07:32:57 +00004642006-04-24 Paul Jakma <paul.jakma@sun.com>
465
466 * (general) More Virtual-link fixes, again with much help in
467 testing / debug from Juergen Kammer. Primarily in SPF.
468 * ospf_spf.h: Add guard. ospf_interface.h will include this
469 header.
470 * ospf_interface.h: Modify ospf_vl_lookup definition to take
471 struct ospf as argument, so as to allow for NULL area
472 argument.
473 (struct ospf_vl_data) Remove out_oi, instead add a struct
474 vertex_nexthop, to use as initial nexthop for backbone paths
475 through a vlink.
476 * ospf_interface.c: (ospf_vl_lookup) Modified to allow
477 NULL area to be passed to indicate "any" (first) area.
478 Add extra debug.
479 (ospf_vl_set_params) vl_oi -> nexthop. Add extra debug.
480 (ospf_vl_up_check) Fix debug, inet_ntoa returns a static
481 buffer..
482 * ospf_route.c: (ospf_intra_add_router) Vlinks dont go through
483 backbone, don't bother checking.
484 * ospf_spf.c: (static struct list vertex_list) Record vertices
485 that will need to be freed.
486 (cmp) Order network before router vertices, as required,
487 wasn't implemented.
488 (vertex_nexthop_free) Mild additional robustness check.
489 (vertex_parent_free) Take void argument, as this function
490 is passed as list deconstructor for vertex parent list.
491 (ospf_vertex_new) More debug. Set deconstructor for parent
492 list. Track allocated vertices on the vertex_list.
493 (ospf_vertex_free) Get rid of the tricky recursive cleanup of
494 vertices. Now frees only the given vertex.
495 (ospf_vertex_add_parent) Fix assert.
496 (ospf_nexthop_calculation) Fix calculation of nexthop for
497 VLink vertices, lookup the vl_data and use its previously
498 recorded nexthop information.
499 (ospf_spf_calculate) Vertices are freed simply by deleting
500 vertex_list nodes and letting ospf_vertex_free as deconstructor
501 work per-node.
502 (ospf_spf_calculate_timer) Trivial optimisation, leave
503 backbone SPF calculation till last to reduce SPF churn on
504 VLink updates.
505 * ospf_vty.c: (ospf_find_vl_data) update call to ospf_vl_lookup
506 (no_ospf_area_vlink_cmd) ditto.
507 (show_ip_ospf_interface_sub) For Vlinks, the peer address is
508 more interesting than the output interface.
509
Paul Jakma478aab92006-04-03 21:25:32 +00005102006-04-03 Paul Jakma <paul.jakma@sun.com>
511
512 * (general) Fix issues with handling of Vlinks and entries
513 in the nbrs route-table which were highlighted by the
514 nsm/nbr_self fixes from bug #234. Many thanks to Juergen
515 Kammer for his help and efforts in testing out debug patches to
516 pinpoint the issue.
517 * ospf_interface.c: (ospf_vl_new) Add nbr_self for Vlink.
518 * ospf_neighbor.c: (ospf_nbr_key) new static function, helper
519 to create key in nbrs table for a given nbr.
520 (ospf_nbr_delete) Use ospf_nbr_key. Add an assert() to
521 document an expected state.
522 (ospf_nbr_add_self) Ditto.
523 (ospf_nbr_lookup_by_addr) Add an assert.
524 * ospf_nsm.c: (nsm_kill_nbr) Can never kill the nbr_self
525 psuedo-neighbour.
526
Paul Jakma075c2012006-03-30 14:34:31 +00005272006-03-27 Paul Jakma <paul.jakma@sun.com>
528
529 * ospf_lsa.c: (ospf_lsa_checksum) Add an explicit cast to avoid
530 the ambiguities of ANSI and C99 C with respect to type
531 conversion. Detailed problem report and test case with
532 example data supplied by Dmitry Ivanov <dimss@telecentrs.lv>.
533
Paul Jakma1a8ee0e2006-03-30 14:20:00 +00005342006-03-25 Paul Jakma <paul.jakma@sun.com>
535
536 * ospf_interface.c: (ospf_if_lookup_recv_if) Ignore loopbacks,
537 we can never ever receive packets on those. Should fix
538 case where CARP is run with address in same subnet as real
539 interface. Problem report and diagnosis thanks to:
540 Landon Fuller <landonf@opendarwin.org>.
541 However, ospf_read() still can't deal deterministically with
542 multiple interfaces in same subnet.
543
Paul Jakmac2b478d2006-03-30 14:16:11 +00005442006-03-23 Steve Lawson <steve.lawson@aheadcomusa.com>
545
546 * ospf_lsa.c: (ospf_lsa_install) Fix incorrect byte-order
547 conversion of OSPF_MAX_SEQUENCE_NUMBER
548
paule8e19462006-01-19 20:16:55 +00005492006-01-19 Paul Jakma <paul.jakma@sun.com>
550
551 * (general) various miscellaneous compiler warning fixes.
552 Remove redundant break statements from switch clauses
553 which return.
554 return from main, not exit, cause it annoys SOS.
555 Remove stray semi-colons which cause empty-statement
556 warnings.
557
paul779adb02006-01-18 15:07:38 +00005582006-01-18 Juergen Kammer <j.kammer@eurodata.de>
559
560 * ospf_lsa.c: (ospf_router_lsa_new) dont take reference to the
561 stream data until it is constructed, data reference is
562 volatile due to the potential resize in link_info_set
563
5642006-01-18 Paul Jakma <paul.jakma@sun.com>
565
566 * ospf_lsa.c: (link_info_set) Resize the stream if required and
567 possible. Return number of links added.
568 (lsa_link_*_set) use return value from previous.
569 * ospf_lsa.h: Add OSPF_ROUTER_LSA_LINK_SIZE define.
570
paulc6371712006-01-17 17:49:53 +00005712006-01-17 Paul Jakma <paul.jakma@sun.com>
572
573 * ospf_packet.c: (ospf_verify_header) print out the types
574 involved if there's a mismatch.
575 * ospf_zebra.c: (ospf_zebra_add) Adjust to new zserv format.
576
paul818e56c2006-01-10 23:27:05 +00005772006-01-10 Len Sorensen <lennartsorensen@ruggedcom.com>
578
579 * (general) Bug #234, see also [quagga-dev 3902].
580 Fix problem with nbr_self not being properly reinitialised
581 when an interface comes up, after having been down.
paul1a643f82006-01-11 01:08:19 +0000582 Some re-arrangement done by Paul Jakma, any bugs introduced
583 on top of Len's suggested changes are his.
paul818e56c2006-01-10 23:27:05 +0000584 * ospf_neighbor.c: (ospf_nbr_add_self) centralise
585 initialisation of nbr_self parameters here.
586 * ospf_interface.c: (ospf_if_new) deleting initialisation of
587 parameters of nbr_self, just rely on call to
588 ospf_nbr_add_self.
589 (ospf_if_cleanup) ditto.
590 * ospfd.c: (ospf_network_run) ditto.
591
paul98429f62006-01-10 22:11:54 +00005922006-01-10 Juris Kalnins <juris@mt.lv>
593
594 * ospf_zebra.c: (ospf_interface_address_delete) fix rare leak of
595 struct connected in an error case.
paul818e56c2006-01-10 23:27:05 +0000596 * ospf_packet.c: (ospf_make_md5_digest) fix odd, if not
597 undefined effect, assignment of an increment expression.
paul98429f62006-01-10 22:11:54 +0000598
paul86752842006-01-10 20:34:46 +00005992006-01-10 Paul Jakma <paul.jakma@sun.com>
600
601 * ospfd.c: (ospf_network_run) checking to see if router-id
602 is set should be on ospf->router_id, not router_id_static.
603 This was causing ospfd to not start if router-id had not
604 been configured statically.
605 (ospf_if_update) ditto.
paulc42c1772006-01-10 20:36:49 +0000606 * ospf_vty.c: (config_write_ospf_distribute) trim down
607 redundant strings.
paul86752842006-01-10 20:34:46 +0000608
paul00c290e2005-11-26 09:21:43 +00006092005-11-26 Paul Jakma <paul.jakma@sun.com>
610
611 * ospf_api.c: (struct opaque_lsa) change from gcc zero-length
612 array to C99 incomplete type array.
paulc9c93d52005-11-26 13:31:11 +0000613 * (general) s/graceful/deferred/ in all files, the former term
614 is confusing wrt OSPF Graceful-Restart.
615 * ospfd.c: (ospf_deferred_shutdown_check) dont return
616 a function which returns void. SOS complains about this.
617 (ospf_finish)
paul00c290e2005-11-26 09:21:43 +0000618
paulb29800a2005-11-20 14:50:45 +00006192005-11-20 Paul Jakma <paul.jakma@sun.com>
620
621 * ospfd.h: remove the OSPF_ROUTER_ID_UPDATE_DELAY define
622 (struct ospf) remove the router_id timer thread.
623 remove export of ospf_router_id_update_timer.
624 * ospfd.c: (ospf_router_id_update) call ospf_if_update to
625 poke interfaces into action after ID has been configured.
626 (ospf_router_id_update_timer) removed.
627 (ospf_finish_final) t_router_id_update timer is gone.
628 (ospf_network_run) router-id update timer gone.
629 call ospf_router_id_update directly if ID not configured.
630 In the per-iface loop, don't ospf_if_up interfaces if
631 ID is still not configured. The update function will call
632 ospf_if_update anyway.
633 (ospf_if_update) ID update timer is gone. Just return if no
634 ID is set.
635 * ospf_vty.c: (ospf_router_id) call ospf_router_id_update, no
636 timer needed.
637 * ospf_zebra.c: (ospf_router_id_update_zebra) call
638 ospf_router_id_update directly, not via timer.
paulc24d6022005-11-20 14:54:12 +0000639 * ospf_abr.c: (ospf_abr_announce_network_to_area) check
640 returned LSA of ospf_summary_lsa_refresh and print warning if
641 it failed.
642 (ospf_abr_announce_network_to_area) similar
643 (ospf_abr_announce_rtr_to_area) similar
644 * ospf_lsa.c: (ospf_router_lsa_new) check LSA returned is valid.
645 (ospf_router_lsa_originate) similar
646 (ospf_router_lsa_refresh, ospf_network_lsa_new) similar
647 (ospf_summary_lsa_new) Check ID is valid.
648 (ospf_summary_lsa_originate) ditto, and check returned LSA from
649 previous function is !NULL.
650 (ospf_summary_lsa_refresh) check ospf_summary_lsa_new return
651 is !NULL.
652 (ospf_summary_asbr_lsa_new) ID valid check.
653 (ospf_summary_asbr_lsa_originate) similar.
paulb29800a2005-11-20 14:50:45 +0000654
ajs70cd3472005-11-16 19:33:22 +00006552005-11-16 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
656
ajs649654a2005-11-16 20:17:52 +0000657 * ospf_dump.h: Define OSPF_TIME_DUMP_SIZE as appropriate buffer size
658 for use with ospf_timer_dump and ospf_timeval_dump.
659 * ospf_vty.c: Change all buffer sizes used with ospf_timer_dump and
660 ospf_timeval_dump to have size OSPF_TIME_DUMP_SIZE.
661 (show_ip_ospf_interface_sub) Fix possible buffer overflow in
662 call to ospf_timer_dump.
663
6642005-11-16 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
665
ajs70cd3472005-11-16 19:33:22 +0000666 * ospf_ism.h: (OSPF_ISM_TIMER_OFF) Improve macro syntax by enclosing
667 in 'do {...} while(0)'.
668
paul31a59762005-11-14 11:11:11 +00006692005-11-14 Paul Jakma <paul.jakma@sun.com>
670
671 * ospfd.c: (ospf_new) stub-shutdown should just default to
672 unconfigured, too strange otherwise.
673 (ospf_finish_final) t_opaque_lsa_self TIMER_OFF should be
674 preprocessor conditional on HAVE_OPAQUE_LSA.
675 * ospfd.h: (struct ospf) remove the SHUTDOWN_DEFAULT define.
676 no longer used, plus it wasn't in range that the command
677 accepted.
678 * ospf_zebra.h: Depends on vty.h, include it.
679
paul58e1bef2005-11-11 12:10:03 +00006802005-11-11 Paul Jakma <paul.jakma@sun.com>
681
682 * ospf_spf.c: (ospf_canonical_nexthops_free) Free only
683 the nexthops pointing to the root vertex. We may visit a
684 vertex twice or the vertex may have some inherited nexthops,
685 if we free other nexthops we could crash.
686
paulc8c15212005-11-04 12:31:39 +00006872005-11-04 Paul Jakma <paul.jakma@sun.com>
688
689 * ospf_{dump,spf,vty}.c: Oops, use the internal tv_sub
690 function rather than unportable timersub.
691
paul484315f2005-11-03 09:08:29 +00006922005-11-03 Paul Jakma <paul.jakma@sun.com>
693
694 * ospf_apiserver.c: (apiserver_sync_callback) stray semi-colon
695 * ospf_packet.c: include checksum.h, remove the in_cksum extern
696 * prototypes.
697 * ospf_te.h: Add braces, quell warning.
paul6d452762005-11-03 11:15:44 +0000698 * ospf_packet.c: Change level of some warnings to
699 informational.
paulc8c15212005-11-04 12:31:39 +0000700
paul88d6cf32005-10-29 12:50:09 +00007012005-10-29 Paul Jakma <paul.jakma@sun.com>
702
703 * (general) RFC3137 stub-router support
704 * ospfd.h: Add OSPF_OUTPUT_COST_INFINITE define.
705 (struct ospf_master) Add a OSPF_MASTER_SHUTDOWN flag for
706 options, to allow shutdown to distinguish between complete
707 shutdown and shutdown of a subset of ospf instances.
708 (struct ospf)
709 Add stub_router_{startup,shutdown_}time, configuration of startup
710 and shutdown time for stub-router.
711 Add t_graceful_shutdown struct thread, timer for graceful
712 shutdown, if needed.
713 (struct ospf_area) Add stub_router_state - run time state of
714 stub-router for an area. Add flags for ADMIN, IS and WAS
715 states.
716 Add t_stub_router, timer thread to resend router-lsa for an
717 area.
718 * ospf_lsa.c: (ospf_link_cost) new simple function to spit out
719 either the given lnks cost or infinite cost if stub-router is
720 in effect.
721 (lsa_link_{ptop,broadcast,virtuallink,ptomp}_set) use
722 previous function for transit-links.
723 (ospf_stub_router_timer) timer thread for end of startup stub
724 router. Change state as required for the area and setup
725 re-origination of router-lsa.
726 (ospf_stub_router_check) Check/do whether stub-router should be
727 enabled, and whether it requires timer to be setup.
728 (ospf_router_lsa_new) call previous function at top.
729 (ospf_router_lsa_originate) no external callers, made static.
730 * ospf_lsa.h: (ospf_router_lsa_originate) removed.
731 * ospf_main.c: (sigint) make static.
732 remove call to exit, as ospf_terminate now deals with
733 exiting.
734 * ospf_route.c: (ospf_terminate) removed, now in ospfd.c.
735 * ospf_vty.c: (show_ip_ospf_area) print out state of
736 stub-router, if active.
737 (show_ip_ospf) print out configuration of stub-router
738 support, and details of graceful-shutdown if the timer is
739 active.
740 ((no)?ospf_max_metric_router_lsa_{admin,startup,shutdown}) new
741 commands to (de-)?configure stub-router support.
742 (config_write_stub_router) write out config of stub-router.
743 (ospf_config_write) call previous.
744 (ospf_vty_init) install the new stub-router commands.
745 * ospfd.c: various functions made static.
746 (ospf_new) Set defaults for stub-router. Graceful shutdown
747 is made to default on, just to be adventerous.
748 (ospf_graceful_shutdown_finish) new function, final part of
749 shutdown.
750 (ospf_graceful_shutdown_timer) timer thread wrapper for
751 graceful-shutdown.
752 (ospf_graceful_shutdown_check) check whether to setup timer
753 for shutdown or proceed directly to final shutdown.
754 (ospf_terminate) moved here from ospf_route.c, call
755 ospf_finish for each instance.
756 (ospf_finish) renamed to ospf_finish_final and made static.
757 (ospf_finish) new function, exported wrapper around
758 ospf_graceful_shutdown_check.
759 (ospf_finish_final) complete shutdown of an instance.
760 Add missing TIMER_OFF's of two timer threads.
761 (ospf_area_free) opaque self lsa timer should be turned off.
762
paulb8ad39d2005-10-23 15:23:05 +00007632005-10-23 Paul Jakma <paul.jakma@sun.com>
764
paule029d442005-10-23 15:26:24 +0000765 * ospf_apiserver.c: (ospf_apiserver_term) This function should
766 not have side-effects (eg segv) if no apiserver instances are
767 active, ie be robust.
paulb8ad39d2005-10-23 15:23:05 +0000768 * ospf_vty.c: (show_ip_ospf) fix display of SPF timer if it
769 has not yet been run.
770
paulf9ad9372005-10-21 00:45:17 +00007712005-10-21 Paul Jakma <paul.jakma@sun.com>
772
paulea4ffc92005-10-21 20:04:41 +0000773 * ospf_dump.c: (ospf_timeval_dump) fix ms adjustment, thanks to
774 Andrew Schorr.
775 * ospf_vty.c: (ospf_config_write) fix write out of spf timers
776 configuration.
777
7782005-10-21 Paul Jakma <paul.jakma@sun.com>
779
pauld24f6e22005-10-21 09:23:12 +0000780 * (general) SPF millisecond resolution timer with adaptive,
781 linear back-off holdtime. Prettification of ospf_timer_dump.
782 * ospf_dump.c: (ospf_timeval_dump) new function. The guts of
783 ospf_timer_dump, but made to be more dynamic in printing out
784 the relative timeval, sliding the precision printed out
785 according to the value.
786 (ospf_timer_dump) guts moved to ospf_timeval_dump.
787 * ospf_dump.h: export ospf_timeval_dump.
788 * ospf_flood.c: (ospf_flood) remove gettimeofday, use
789 the libzebra exported recent_time instead, as it's not
790 terribly critical to have time exactly right - the dropped
791 LSA will be retransmited to us if we don't ACK it.
792 * ospf_packet.c: (ospf_ls_upd_timer) Ditto, but here we're
793 not transmitting, just putting LSA back on update transmit list.
794 * ospfd.h: delay and holdtimes should be unsigned.
795 Add spf_max_holdtime and spf_hold_multiplier.
796 Update default defines for delay and hold time to be in msec.
797 (struct ospf) change the SPF timestamp to a struct timeval.
798 Remove ospf_timers_spf_(un)?set.
799 * ospfd.c: (ospf_timers_spf_{set,unset}) removed.
800 (ospf_new) initialise spf_max_holdtime and spf_hold_multiplier
801 * ospf_spf.c: (ospf_spf_calculate) SPF timestamp is a timeval
802 now, update with gettimeofday.
803 (ospf_spf_calculate_schedule) Change SPF timers to millisecond
804 resolution.
805 Make the holdtime be adaptive, with a linear increase in
806 holdtime ever consecutive SPF run which occurs within holdtime
807 of previous SPF, bounded by spf_max_holdtime.
808 * ospf_vty.c: Update spf timers commands.
809 (ospf_timers_spf_set) trivial helper.
810 (ospf_timers_throttle_spf_cmd) new command to set SPF delay,
811 initial hold and max hold times with millisecond resolution.
812 (ospf_timers_spf_cmd) Deprecated. Accept the old values,
813 convert to msec, truncate to new limits.
814 (no_ospf_timers_throttle_spf_cmd) set timers to defaults.
815 (no_ospf_timers_spf_cmd) deprecated form, same as previous.
816 (show_ip_ospf_cmd) Display SPF parameters and times.
817 (show_ip_ospf_neighbour_header) Centralise the 'sh ip os ne'
818 header.
819 (show_ip_ospf_neighbor_sub) Fix the field widths. Get rid of
820 the multiple spaces which were making the lines even longer.
821 (show_ip_ospf_neighbor_cmd) Use show_ip_ospf_neighbour_header
822 (show_ip_ospf_neighbor_all_cmd) ditto and fix the field
823 widths for NBMA neighbours.
824 (show_ip_ospf_neighbor_int) Use header function.
825 (show_ip_ospf_nbr_nbma_detail_sub) use sizeof for timebuf,
826 local array - safer.
827 (show_ip_ospf_neighbor_detail_sub) ditto
828 (ospf_vty_init) install the new SPF throttle timer commands.
829
8302005-10-21 Paul Jakma <paul.jakma@sun.com>
831
paulf9ad9372005-10-21 00:45:17 +0000832 * (general) OSPF fast, sub-second hello and 1s dead-interval
833 support.
834 * ospf_dump.c: (ospf_timer_dump) Print out milliseconds too.
835 Callers typically specify a length of 9, so most see
836 millisecs unless they specify the additional length.
837 * ospf_interface.h: (struct ospf_interface) new interface param,
838 fast_hello.
839 * ospf_interface.c: (ospf_if_table_lookup) add brackets,
840 gcc warning fix.
841 (ospf_new_if_params) Initialise fast_hello param.
842 (ospf_free_if_params) Check whether fast_hello is configured.
843 (ospf_if_new_hook) set fast_hello to default.
844 * ospf_ism.h: Wrap OSPF_ISM_TIMER_ON inside do {} while (0) to
845 prevent funny side-effects from its if statement when this
846 macro is used conditionally by other macros.
847 (OSPF_ISM_TIMER_MSEC_ON) new macro, set in milliseconds.
848 (OSPF_HELLO_TIMER_ON) new macro to set hello timer according
849 to whether fast_hello is set.
850 * ospf_ism.c: Update all setting of the hello timer to use
851 either OSPF_ISM_TIMER_MSEC_ON or OSPF_HELLO_TIMER_ON. The
852 former is used when hello is to be sent immediately.
853 * ospf_nsm.c: ditto
854 * ospf_packet.c: (ospf_hello) hello-interval is not checked
855 for mismatch if fast_hello is set.
856 (ospf_read) Annoying nit, fix "no ospf_interface" to be debug
857 rather than a warning, as it can be perfectly normal to
858 receive packets when logical subnets are used.
859 (ospf_make_hello) Set hello-interval to 0 if fast-hellos are
860 configured.
861 * ospf_vty.c: (ospf_auto_cost_reference_bandwidth) annoying
862 nit, don't vty_out if this command is given, it gets tired
863 quick.
864 (show_ip_ospf_interface_sub) Print the hello-interval
865 according to whether fast-hello is set or not.
866 Print the extra 5 millisec characters from (ospf_timer_dump)
867 if fast-hello is configured.
868 (ospf_vty_dead_interval_set) new function, common to all
869 forms of dead-interval command, to set dead-interval and
870 fast-hello correctly. If a dead-interval is given, unset
871 fast-hello, else if a hello-multiplier is set, set
872 dead-interval to 1 and fast-hello to given multiplier.
873 (ip_ospf_dead_interval_addr_cmd) use
874 ospf_vty_dead_interval_set().
875 (ip_ospf_dead_interval_minimal_addr_cmd) ditto.
876 (no_ip_ospf_dead_interval) Unset fast-hello.
877 (no_ip_ospf_hello_interval) Bug-fix, unset of hello-interval
878 should set it to OSPF_HELLO_INTERVAL_DEFAULT, not
879 OSPF_ROUTER_DEAD_INTERVAL_DEFAULT.
880 (config_write_interface) Write out fast-hello.
881 (ospf_config_write) Write a comment about
882 "auto-cost reference-bandwidth" having to be equal on all
883 routers. Hopefully just as noticeable as old practice of
884 writing to vty, but less annoying.
885 (ospf_vty_if_init) install the two new dead-interval
886 commands.
887 * ospfd.h: Add defines for OSPF_ROUTER_DEAD_INTERVAL_MINIMAL
888 and OSPF_FAST_HELLO_DEFAULT.
889
pauleb3da6d2005-10-18 04:20:33 +00008902005-10-18 Paul Jakma <paul.jakma@sun.com>
891
892 * (general) SPF memory management cleanup and fix for rare
893 double-free bug.
894 * ospf_spf.h: (struct vertex_parent) New struct to hold parent
895 specific data, eg the backlink and the parent vertex pointer,
896 and point to the appropriate general struct vertex_nexthop.
897 (struct vertex_nexthop) remove parent vertex pointer, so
898 this struct can be shared across vertices.
899 (struct vertex) rename list child to list children. Remove
900 list of nexthops, replace with list of vertex_parents.
901 * ospf_spf.c: (update_stat) trivial, remove cast from void *.
902 (vertex_nexthop_new) remove init of parent - field is gone
903 from struct vertex_nexthop.
904 (ospf_canonical_nexthops_free) Remove the canonical
905 vertex_nexthop memory objects. These are the vertex_nexthops
906 attached to the first level of router vertices from the root.
907 (vertex_parent_new) new function, create a vertex_parent.
908 (vertex_parent_free) ditto, but free it.
909 (ospf_vertex_new) Update to match changes to struct vertex.
910 (ospf_vertex_free) Recursively free a struct vertex and its
911 children. The parent list is used as a reference count.
912 vertex_nexthops must be free seperately, if required.
913 (ospf_vertex_dump) update to match struct vertex changes.
914 Print out backlink of parents too.
915 (ospf_vertex_add_parent) ditto.
916 (ospf_lsa_has_link) update comment.
917 (ospf_nexthop_add_unique) removed, not needed anymore.
918 (ospf_nexthop_merge) ditto.
919 (ospf_spf_consider_nexthop) renamed to ospf_spf_add_parent.
920 Simplified to just create vertex_parent and add it.
921 (ospf_spf_flush_parents) new function, flush out the parent
922 list.
923 (ospf_nexthop_calculation) Take the relevant route_lsa_link
924 as an argument, which simplifies things and removes the need
925 for the hack in ospf_nexthop_add_unique - ospf_spf_next
926 already knew exactly which link the cost calculated was for.
927 Update to match struct vertex changes too.
928 (ospf_spf_next) Don't create a vertex for W unnecessarily, if
929 it's there's a vertex already created for W, use it, and
930 hence there's no need to free it either.
931 Update some manipulation/comparisons of distance to match.
932 Flush the parent list if a lower cost path is found.
933 (ospf_spf_route_free) unused, removed.
934 (ospf_spf_dump) match the struct vertex changes, and dump the
935 ifname if possible.
936 (ospf_spf_calculate) At end of SPF, free the canonical nexthops
937 and call ospf_vertex_free on the root vertex to free the
938 entire tree.
939 * ospf_interface.c: (ospf_vl_set_params) match struct vertex
940 changes.
941 * ospf_route.c: (ospf_intra_route_add) ditto
942 (ospf_route_copy_nexthops_from_vertex) ditto
943
paul36238142005-10-11 04:12:54 +00009442005-10-11 Paul Jakma <paul.jakma@sun.com>
945
946 * ospf_api.c: sign warnings.
947 * ospf_apiserver.c: sign warning and convert all the struct
948 in_addr initialisations so as not to make assumptions about
949 how this struct is organised, initialise the s_addr member
950 explicitely.
951 * ospf_packet.c: Add const qualifier to auth_key.
952
vincent77df1f72005-10-06 07:46:22 +00009532005-10-06 Alain Ritoux <alain.ritoux@6wind.com>
954
955 * ospf_snmp.c: Avoid mixing interface and ospf_interface objects
956 which now allows snmpwalk to work with ospfIfTable and
957 also with ospfIfMetricTable
958
ajsf52d13c2005-10-01 17:38:06 +00009592005-10-01 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
960
961 * ospf_dump.c: Remove local hard-coded table ospf_redistributed_proto.
962 (ospf_redist_string) New function implemented using new library
963 function zebra_route_string(). Note that there are a few differences
964 in the output that will result: the new function returns strings
965 that are lower-case, whereas the old table was mixed case. Also,
966 the old table mapped ZEBRA_ROUTE_OSPF6 to "OSPFv3", whereas the
967 new function returns "ospf6".
968 * ospfd.h: Remove extern struct message ospf_redistributed_proto[],
969 and add extern const char *ospf_redist_string(u_int route_type)
970 instead.
971 * ospf_asbr.c: (ospf_external_info_add) In two messages, use
972 ospf_redist_string instead of LOOKUP(ospf_redistributed_proto).
973 * ospf_vty.c: Remove local hard-coded table distribute_str.
974 (config_write_ospf_redistribute,config_write_ospf_distribute): Use
975 new library function zebra_route_string() instead of distribute_str[].
976 * ospf_zebra.c: (ospf_redistribute_set,ospf_redistribute_unset,
977 ospf_redistribute_default_set,ospf_redistribute_check)
978 In debug messages, use ospf_redist_string() instead of
979 LOOKUP(ospf_redistributed_proto).
980
jardin6638c1a2005-10-01 00:08:54 +00009812005-09-30 Vincent Jardin <vincent.jardin@6wind.com>
982
983 * ospf_dump.c, ospf_ia.c, ospf_spf.c, ospf_ase.c:
984 remove unused DEBUG
985
vincentba682532005-09-29 13:52:57 +00009862005-09-29 Alain Ritoux <alain.ritoux@6wind.com>
987
vincent5e4914c2005-09-29 16:34:30 +0000988 * ospf_ism.c: generate SNMP traps on Interface state change
989 * ospf_nsm.c: generate SNMP traps on Neighbour state change
990 * ospf_snmp.[ch]: support for SNMP traps for interface and neighbours.
991
9922005-09-29 Alain Ritoux <alain.ritoux@6wind.com>
993
vincentba682532005-09-29 13:52:57 +0000994 * ospf_vty.c: forece default route LSA to be re_issued whenever
995 cost is changed ( [no] ip ospf area XXX default-cost YYY)
996 Support ignore-mtu option
997 * ospfd.h: define OSPF_MTU_IGNORE_DEFAULT
998 * ospf_packet.c: support ignore-mtu option
999 * ospf_interface.h: field added for skipping MTU check
1000 * ospf_interface.c: fix memory leak in ospf_crypt_key_delete()
1001 Set mtu_ignore field to default value
1002 * ospf_abr.[ch]: export ospf_abr_announce_network_to_area()
1003 * ospf_ism.h: add MACRO to convert internal ISM status into SNMP
1004 correct values
1005 * ospf_snmp.c: add sanity check on LSA type in lsdb_lookup_next()
1006 convert OSPFIFSTATE internal status into SNMP values
1007
vincentc1a03d42005-09-28 15:47:44 +000010082005-09-28 Alain Ritoux <alain.ritoux@6wind.com>
1009
1010 * ospf_packet.c: use new md5 API
1011
ajs5339cfd2005-09-19 13:28:05 +000010122005-09-19 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1013
1014 * ospf_lsa.h: (ospf_external_lsa_flush) Comment out the 5th argument
1015 (nexthop) since it is not used in the function (except inside
1016 some commented-out code).
1017 * ospf_lsa.c: (ospf_external_lsa_flush,ospf_external_lsa_refresh)
1018 Comment out the 5th argument to ospf_external_lsa_flush.
1019 * ospf_asbr.c: (ospf_redistribute_withdraw) Comment out 5th arg
1020 to ospf_external_lsa_flush.
1021 * ospf_vty.c: (no_ospf_default_information_originate) Eliminate 5th
1022 uninitialized nexthop arg to ospf_external_lsa_flush.
1023 * ospf_zebra.c: (ospf_zebra_read_ipv4) Comment out 5th arg
1024 to ospf_external_lsa_flush.
1025 * ospfd.c: (ospf_network_set) Comment out 5th arg
1026 to ospf_external_lsa_flush.
1027
ajse6a0bf92005-09-17 18:53:38 +000010282005-09-17 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1029
1030 * ospf_opaque.c:
1031 (ospf_opaque_lsa_refresh_schedule,ospf_opaque_lsa_flush_schedule)
1032 No need to call ospf_lookup(), just use lsa0->area->ospf instead.
1033
hassobb5b7552005-08-21 20:01:15 +000010342005-08-21 Hasso Tepper <hasso at quagga.net>
1035
1036 * ospf_vty.c: Make "show ip ospf neighbor xxx" commands work.
1037 Interface should be specified by name now.
1038
hasso54bedb52005-08-17 13:31:47 +000010392005-08-17 Hasso Tepper <hasso at quagga.net>
1040
1041 * ospf_vty.c: Check carefully if interface exists before trying to
1042 print info about it.
1043
hasso01018ce2005-08-05 07:40:15 +000010442005-08-05 Hasso Tepper <hasso at quagga.net>
1045
1046 * ospf_zebra.c: Don't assert/stop before type == ZEBRA_ROUTE_MAX if
1047 dealing with routemaps. There is ospf->route_map[ZEBRA_ROUTE_MAX]
1048 for default-information.
1049
paulc8987752005-07-26 06:07:22 +000010502005-07-26 Paul Jakma <paul.jakma@sun.com>
1051
1052 * ospf_abr.c: (ospf_abr_announce_network_to_area) SET_FLAG
1053 should be on lsa not old, which may be freed for one thing,
1054 obviously.
1055
pauld57834f2005-07-12 20:04:22 +000010562005-07-12 Paul Jakma <paul.jakma@sun.com>
1057
1058 * ospfd.h: add OSPF_ABR_DEFAULT for convenience, make
1059 OSPF_ABR_CISCO be the default ABR type.
1060 * ospfd.c: (ospf_new) initialise abr_type to OSPF_ABR_DEFAULT
1061 * ospf_vty.c: (no_ospf_abr_type_cmd) add standard as a negatable
1062 abr_type. default abr_type should be OSPF_ABR_DEFAULT.
1063 (ospf_config_write) test whether default abr_type against
1064 OSPF_ABR_DEFAULT, rather than any specific ABR_TYPE.
1065
hasso8469bd72005-06-20 20:50:10 +000010662005-06-20 Hasso Tepper <hasso at quagga.net>
hassof4833e92005-06-20 20:42:26 +00001067
1068 * ospf_nsm.c: Make database exchange for NSSA database work.
1069
paul7461d452005-06-13 13:57:16 +000010702005-06-13 Paul Jakma <paul.jakma@sun.com>
1071
1072 * ospf_spf.c: Try get more information on a SEGV under
1073 ospf_spf_vertex_add_parent.
1074 (ospf_vertex_free) NULL out the child and nexthop lists
1075 (ospf_vertex_add_parent) nexthop and child can not be NULL
1076 vertex_nexthop's parent->child list can not be NULL
1077 (ospf_spf_next) w and cw are per-loop iteration variables, move
1078 declarations into loop body.
1079
hasso1ddd7292005-06-07 19:54:04 +000010802005-06-07 Hasso Tepper <hasso at quagga.net>
1081
1082 * ospf_apiserver.c: Fix obvious error in notifying clients about ISM
1083 changes - oi->ifp->status doesn't give to us info about ISM,
1084 oi->state does.
1085
paul7e440862005-06-01 11:20:51 +000010862005-06-01 Akihiro Mizutani <mizutani@net-chef.net>
1087
1088 * ospf_ism.c (ospf_elect_bdr/ospf_elect_dr): Fix DR election bug.
1089
paul500e4182005-05-26 17:11:13 +000010902005-05-26 Paul Jakma <paul.jakma@sun.com>
1091
1092 * ospf_abr.c: (ospf_abr_update_aggregate) Fix comment, cost bug itself
1093 had been fixed long ago by Sowmini.
1094
paula3387a42005-05-18 23:29:57 +000010952005-05-19 Paul Jakma <paul.jakma@sun.com>
1096
1097 * ospf_interface.c: (ospf_if_table_lookup) Fix a serious bug
1098 a less serious one.
1099 1: this function is supposed to lookup
1100 entries in the oifs ospf_interface route_table and return either
1101 an existing oi or NULL to indicate not found, its caller depends
1102 on this, yet this function uses route_node_get which /always/
1103 returns a route_node - one is created if none exists. Use
1104 route_node_lookup instead. This should fix root cause of the
1105 reports of the (ospf_add_to_if) assert being hit.
1106 2: oi's are inserted into this table with prefixlength set to
1107 /32 (indeed, it should be a hash table, not a route_table),
1108 however prefixlength to lookup was not changed, if no valid entry
1109 can be inserted other than /32, then nothng but /32 should be
1110 looked up. This possibly only worked by fluke..
1111 Fix confirmed by 2 reporters (one list, one IRC), definitely a
1112 backport candidate once it has been incubated in HEAD for a while.
1113 Thanks to Patrick Friedel and Ivan Warren for testing.
1114
paul69310a62005-05-11 18:09:59 +000011152005-05-11 Paul Jakma <paul.jakma@sun.com>
1116
1117 * (general) Fix memory leaks in opaque AS-scope LSAs, reported and
1118 with much debugging done by by scott collins <scollins@agile.tv>.
1119 * ospf_lsa.c: (ospf_discard_from_db) dont call
1120 ospf_ase_unregister_external_lsa for opaque-lsa's, opaques are
1121 never registered with ase in the first place.
1122 * ospf_packet.c: (general) Disabuse opaque related code of its
1123 tendency to try gather up things into temporary lists.
1124 (ospf_ls_upd) remove the temporary lists opaque uses, call
1125 opaque functions inline, just like all other types.
1126 (ospf_ls_ack) ditto.
1127 (ospf_recv_packet) fixup sign warning.
1128 * ospf_opaque.c: (general) fix the unneeded use of lists, and
1129 untwist some of the logic.
1130 (ospf_opaque_self_originated_lsa_received) take a single LSA
1131 as argument, not a list of them. Remove the list loop. Logic
1132 otherwise unchanged.
1133 (ospf_opaque_ls_ack_received) Mostly ditto. But untwist the logic,
1134 move the actions up into the switch block, remove the goto's and
1135 sanitise the logic near the end a bit.
1136 * ospf_opaque.h: Adjust definitions of aforementioned functions
1137 in ospf_opaque.c to match.
1138
paul42c98192005-05-07 02:22:51 +000011392005-05-07 Yar Tikhiy <yar@comp.chem.msu.su>
1140
1141 * ospf_network.c: Log ifindex on multicast membership leave/join
1142 events.
1143
paul4dadc292005-05-06 21:37:42 +000011442005-05-06 Paul Jakma <paul.jakma@sun.com>
1145
1146 * (general) extern and static qualifiers added.
1147 unspecified arguments in definitions fixed, typically they should
1148 be 'void'.
1149 function casts added for callbacks.
1150 Guards added to headers which lacked them.
1151 Proper headers included rather than relying on incomplete
1152 definitions.
1153 gcc noreturn function attribute where appropriate.
1154 * ospf_opaque.c: remove the private definition of ospf_lsa's
1155 ospf_lsa_refresh_delay.
1156 * ospf_lsa.h: export ospf_lsa_refresh_delay
1157 * ospf_packet.c: (ospf_make_md5_digest) make *auth_key const,
1158 correct thing to do - removes need for the casts later.
1159 * ospf_vty.c: Use vty.h's VTY_GET_INTEGER rather than ospf_vty's
1160 home-brewed versions, shuts up several warnings.
1161 * ospf_vty.h: remove VTY_GET_UINT32. VTY_GET_IPV4_ADDRESS and
1162 VTY_GET_IPV4_PREFIX moved to lib/vty.h.
1163 * ospf_zebra.c: (ospf_distribute_list_update_timer) hacky
1164 overloading of the THREAD_ARG pointer should at least use
1165 uintptr_t.
1166
paul9e67dc22005-04-15 12:10:17 +000011672005-04-15 Zhipeng Gong <zpgong@cdc.3upsystems.com>
1168
1169 * ospf_abr.c: (ospf_abr_announce_network_to_area) dont forget
1170 to approve LSAs for the case where metric has changed, lsa gets
1171 flushed otherwise. (backport candidate).
1172
ajs634f9ea2005-04-11 15:51:40 +000011732005-04-11 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1174
1175 * ospf_zebra.c (ospf_zebra_add): Call zclient_send_message instead
1176 of writen.
1177
ajsd2fc8892005-04-02 18:38:43 +000011782005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1179
ajse4319de2005-04-02 23:23:55 +00001180 * ospf_interface.h: (ospf_if_lookup_by_name) Remove declaration of a
1181 function that does not exist.
1182
11832005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1184
ajs21fefa92005-04-02 23:16:41 +00001185 * ospf_zebra.c: (zebra_interface_if_lookup) Must use
1186 if_lookup_by_name_len.
1187
11882005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1189
ajsa3491982005-04-02 22:50:38 +00001190 * ospf_interface.c: (ospf_vl_new) Use strnlen to fix call to if_create.
1191
11922005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1193
ajsd2fc8892005-04-02 18:38:43 +00001194 * ospf_vty.c: (show_ip_ospf_interface_sub) Show ifindex and interface
1195 flags to help with debugging.
1196 * ospf_zebra.c: (ospf_interface_delete) After deleting, set ifp->ifindex
1197 to IFINDEX_INTERNAL.
1198 (zebra_interface_if_lookup) Make function static. Tighten up code.
1199
ajsaca72fd2005-03-31 15:18:21 +000012002005-03-31 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1201
1202 * ospf_dump.c: (show_debugging_ospf) Show if ospf event debugging
1203 is turned on.
1204
ajsfd651fa2005-03-29 16:08:16 +000012052005-03-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1206
ajsa608bbf2005-03-29 17:03:49 +00001207 * ospf_zebra.c: (ospf_interface_state_up) If the MTU of an operative
1208 interface changes, print a debug message and call ospf_if_reset()
1209 to simulate down/up on the interface.
1210 * ospf_interface.h: Declare new function ospf_if_reset().
1211 * ospf_interface.c: (ospf_if_reset) New function to call ospf_if_down
1212 and ospf_if_up for all ospf interfaces attached to an interface.
1213
12142005-03-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1215
ajs5dcbdf82005-03-29 16:13:49 +00001216 * ospf_packet.c: (ospf_write_frags) Enhance error message to
1217 show MTU. Also make function static.
1218 (ospf_write) Enhance error message to show interface name and MTU.
1219 Also make function static.
1220
12212005-03-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1222
1223 * ospf_vty.c: (show_ip_ospf_interface_sub) Display interface MTU and
1224 bandwidth; this is useful for debugging problems. Also, the function
1225 should be static.
ajsfd651fa2005-03-29 16:08:16 +00001226
hasso1b639042005-03-27 13:32:25 +000012272005-03-27 Hasso Tepper <hasso at quagga.net>
1228
1229 * ospf_snmp.c: Don't crash in snmp query if ospf instance doesn't
1230 exist at all.
1231
hasso343f5cc2005-03-25 19:48:40 +000012322005-03-25 Hasso Tepper <hasso at quagga.net>
1233
1234 * ospfd.h: Include log.h, fixes compile with gcc-4.0.
1235
ajs9dbc7972005-03-13 19:27:22 +000012362005-03-13 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1237
1238 * ospf_lsa.c: (ospf_lsa_refresh_walker) If the system clock jumps
1239 backward, then current time may be less than
1240 ospf->lsa_refresher_started. This was causing invalid values
1241 for ospf->lsa_refresh_queue.index resulting in infinite loops.
1242 Problem fixed by casting the expression to unsigned before taking
1243 the modulus.
1244
ajs5c333492005-02-23 15:43:01 +000012452005-02-23 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1246
1247 * ospfd.h: Add new field struct stream *ibuf to struct ospf.
1248 * ospfd.c: (ospf_new) Check return code from ospf_sock_init.
1249 Allocate ibuf using stream_new(OSPF_MAX_PACKET_SIZE+1).
1250 (ospf_finish) Call stream_free(ospf->ibuf.
1251 * ospf_packet.c: (ospf_read) Call stream_reset(ospf->ibuf) and then
1252 pass it to ospf_recv_packet for use in receiving the packet
1253 (instead of allocating a new stream for each packet received).
1254 Eliminate all calls to stream_free(ibuf).
1255 (ospf_recv_packet) The struct stream *ibuf is now passed in as
1256 an argument. No need to use recvfrom to peek at the packet
1257 header (to see how big it is), just use ospf->ibuf which is
1258 always large enough (this eliminates a system call to recvfrom).
1259 Therefore, no need to allocate a stream just for this packet,
1260 and no need to free it when done.
1261
hasso462f20d2005-02-23 11:29:02 +000012622005-02-23 Vincenzo Eramo <eramo at infocom.ing.uniroma1.it>
1263
1264 * ospf_lsa.h: New flag to the LSA structure for the SPF calculation.
1265 * ospf_lsdb.h: Export ospf_lsdb_clean_stat() function.
1266 * ospf_spf.h: Add link to the LSA stat structure into vertex.
1267 * ospf_spf.c: New functions cmp() and update_stat() to manage
1268 candidates. Remove ospf_spf_has_vertex(), ospf_vertex_lookup(),
1269 ospf_install_candidate() and ospf_spf_register() functions not needed
1270 any more. Update ospf_vertex_new(), ospf_spf_next() and
1271 ospf_spf_calculate() functions to use pqueue instead of linked list.
1272
hassoe40dcce2005-02-21 14:58:42 +000012732005-02-21 Hasso Tepper <hasso at quagga.net>
1274
1275 * ospf_ase.c: Don't show messages related to the ase calculations if
1276 we are not debugging.
1277
hasso306541b2005-02-19 17:58:40 +000012782005-02-19 Hasso Tepper <hasso at quagga.net>
1279
1280 * ospf_api.h: char isn't always signed, but it has to be it here.
1281
paulfa81b712005-02-19 01:19:20 +000012822005-02-19 Paul Jakma <paul.jakma@sun.com>
1283
1284 * ospf_packet.c: (ospf_stream_copy) remove
1285 (ospf_packet_dup) use stream_copy instead of ospf_stream_copy
1286
ajs038163f2005-02-17 19:55:59 +000012872005-02-17 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1288
1289 * ospf_packet.c: (ospf_recv_packet) If there is somehow a runt
1290 packet in the queue, it must be discarded. Improve warning messages.
1291 Fix scope to static.
1292 (ospf_read) Fix bug: should reset the read thread in all cases
1293 to make sure we continue to get incoming messages.
1294
paul658b03a2005-02-15 10:10:55 +000012952005-02-15 Paul Jakma <paul.jakma@sun.com>
1296
1297 * ospf_packet.c: (ospf_recv_packet) Fix silly error wrt allocating
1298 ibuf. Thanks Andrew.
1299
paulbfdc44a2005-02-14 23:48:42 +000013002005-02-14 Paul Jakma <paul.jakma@sun.com>
1301
1302 * ospf_packet.c: (ospf_recv_packet) use stream_recvmsg.
1303
hasso082253f2005-02-11 08:31:54 +000013042005-02-11 Hasso Tepper <hasso at quagga.net>
1305
1306 * ospf_lsdb.c: Fix sum of checksums calculation.
1307
ajs083ee9d2005-02-09 15:35:50 +000013082005-02-09 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1309
1310 * ospf_packet.c: (ospf_write) If sendmsg fails, give more info in the
1311 error message.
1312
ajsba6454e2005-02-08 15:37:30 +000013132005-02-08 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1314
ajs8cfde372005-02-08 15:59:16 +00001315 * ospf_interface.h: Reduce structure padding by putting new u_char
1316 field multicast_memberships in a better spot (grouped with
1317 other u_char fields type and state).
1318
13192005-02-08 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1320
ajsba6454e2005-02-08 15:37:30 +00001321 * ospf_interface.h: Improve passive_interface comment. Add new
1322 multicast_memberships bitmask to struct ospf_interface to track
1323 active multicast subscriptions. Declare new function
1324 ospf_if_set_multicast.
1325 * ospf_interface.c: (ospf_if_set_multicast) New function to configure
1326 multicast memberships properly based on the current
1327 multicast_memberships status and the current values of the
1328 ospf_interface state, type, and passive_interface status.
1329 (ospf_if_up) Remove call to ospf_if_add_allspfrouters (this is
1330 now handled by ism_change_state's call to ospf_if_set_multicast).
1331 (ospf_if_down) Remove call to ospf_if_drop_allspfrouters (now
1332 handled by ism_change_state).
1333 * ospf_ism.c: (ospf_dr_election) Remove logic to join or leave
1334 the DRouters multicast group (now handled by ism_change_state's call
1335 to ospf_if_set_multicast).
1336 (ism_change_state) Add call to ospf_if_set_multicast to change
1337 multicast memberships as necessary to reflect the new interface state.
1338 * ospf_packet.c: (ospf_hello) When a Hello packet is received on a
1339 passive interface: 1. Increase the severity of the error message
1340 from LOG_INFO to LOG_WARNING; 2. Add more information to the error
1341 message (packet destination address and interface address);
1342 and 3. If the packet was sent to ospf-all-routers, then try
1343 to fix the multicast group memberships.
1344 (ospf_read) When a packet is received on an interface whose state
1345 is ISM_Down, enhance the warning message to show the packet
1346 destination address, and try to update/fix the multicast group
1347 memberships if the packet was sent to a multicast address.
1348 When a packet is received for ospf-designated-routers, but the
1349 current interface state is not DR or BDR, then increase the
1350 severity level of the error message from LOG_INFO to LOG_WARNING,
1351 and try to fix the multicast group memberships.
1352 * ospf_vty.c: (ospf_passive_interface) Call ospf_if_set_multicast for
1353 any ospf interface that may have changed from active to passive.
1354 (no_ospf_passive_interface) Call ospf_if_set_multicast for
1355 any ospf interface that may have changed from passive to active.
1356 (show_ip_ospf_interface_sub) Show multicast group memberships.
1357
paul3a9eb092005-02-08 11:29:41 +000013582005-02-08 Paul Jakma <paul@dishone.st>
1359
1360 * ospf_packet.c: (various) Remove unneeded stream_set_putp abuse.
1361
ajs847947f2005-02-02 18:38:48 +000013622005-02-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1363
1364 * ospf_packet.c: (ospf_read) Fix bug: must check for state ISM_Down,
1365 not for event ISM_InterfaceDown. And improve the message by
1366 adding the interface flags.
1367
ajs0b7d97d2005-01-30 17:24:02 +000013682005-01-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1369
1370 * ospf_network.c: (ospf_sock_init) Save errno before calling
1371 ospfd_privs.change.
1372
ajsc3eab872005-01-29 15:52:07 +000013732005-01-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1374
1375 * ospf_packet.c: (ospf_packet_add) If oi->obuf is NULL, print
1376 an error message and return.
1377 (ospf_read) If the interface state is ISM_InterfaceDown, issue
1378 a warning message and ignore the packet.
1379
gdt86f1fd92005-01-10 14:20:43 +000013802005-01-10 Greg Troxel <gdt@fnord.ir.bbn.com>
1381
1382 * ospf_packet.h: Remove commented out definition of
1383 OSPF_MAX_PACKET; neither it or the uncommented one are used any more.
1384
1385 * ospf_packet.c (ospf_make_ls_upd): Leave room for authentication
1386 when deciding if an update will fit.
1387 (ospf_packet_authspace): Factor out calculation of size required
1388 for authentication.
1389 (ospf_make_db_desc): Use ospf_max_packet, not OSPF_MAX_PACKET.
1390 Don't confuse readers that there is a macro.
1391
ajs3dc56b52004-12-30 15:11:19 +000013922004-12-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1393
1394 * ospf_network.c: Improve all setsockopt error messages to give detailed
1395 information on the arguments.
1396
ajsb87f7722004-12-29 20:41:26 +000013972004-12-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1398
ajs17eaa722004-12-29 21:04:48 +00001399 * ospf_packet.c: (ospf_db_desc) Reduce severity of "Negotiation done"
1400 messages from LOG_WARNING to LOG_INFO, since this seems to be
1401 normal.
1402
14032004-12-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1404
ajsb87f7722004-12-29 20:41:26 +00001405 * ospf_packet.c: (ospf_read) Always look up the interface if
1406 ospf_recv_packet returns NULL ifp, since some platforms such
1407 as Solaris 8 appear to support ifindex retrieval but don't.
1408
hasso1d806282004-12-22 09:43:20 +000014092004-12-22 Hasso Tepper <hasso at quagga.net>
1410
1411 * ospf_dump.c: Show debug configuration in vtysh.
hassoc6b87812004-12-22 13:09:59 +00001412 * ospf_vty.c: Fix "show ip ospf" output. Router can't be elected in
1413 any case if it's configured as "translate-never".
hassofe71a972004-12-22 16:16:02 +00001414 * ospf_lsdb.[ch]: New function to calculate sum of checksums.
1415 * ospf_vty.c: Bugfix to show really number of AS external LSAs, not
1416 number of all LSAs with AS scope, this includes opaque as LSAs as
1417 well, show this number separately. Show numbers and sums of
1418 checksums for each type of LSAs.
1419 * ospf_lsa.c: Calculate checksum before putting LSA into database.
hasso1d806282004-12-22 09:43:20 +00001420
ajsbc18d612004-12-15 15:07:19 +000014212004-12-15 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1422
1423 * ospf_interface.h: Declare new function ospf_default_iftype.
1424 * ospf_interface.c: (ospf_default_iftype) New function to centralize
1425 this logic in one place.
1426 * ospf_zebra.c: (ospf_interface_add) Use new function
1427 ospf_default_iftype.
1428 * ospf_vty.c: (no_ip_ospf_network,config_write_interface) Fix logic
1429 by using new function ospf_default_iftype.
1430
ajs3aa8d5f2004-12-11 18:00:06 +000014312004-12-11 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1432
1433 * ospf_packet.c: (ospf_db_desc) Should be static, not global.
1434 (ospf_hello,ospf_db_desc,ospf_ls_upd,ospf_ls_ack) Improve warning
1435 messages to include identifying information (e.g. router id).
1436 * ospf_nsm.c: (nsm_change_state) Improve info message to include
1437 router id and state names.
1438
gdt91f3e522004-12-09 14:51:03 +000014392004-12-09 Greg Troxel <gdt@fnord.ir.bbn.com>
1440
gdt3fb9de72004-12-09 16:30:04 +00001441 * ospf_apiserver.c (ospf_apiserver_term): Obtain struct
1442 ospf_apiserver * from listnode. Remove unused variables. Follows
1443 suggestion from Jay Fenlason.
gdt91f3e522004-12-09 14:51:03 +00001444
ajs9b0e25c2004-12-08 19:06:51 +000014452004-12-08 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1446
1447 * *.c: Change level of debug messages to LOG_DEBUG.
1448
ajs274a4a42004-12-07 15:39:31 +000014492004-12-07 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1450
1451 * ospf_main.c: (main) The 2nd argument to openzlog has been removed.
1452
ajs887c44a2004-12-03 16:36:46 +000014532004-12-03 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1454
ajs1210fa62004-12-03 16:43:24 +00001455 * ospf_packet.c: (ospf_db_desc) Reduce priority on a debug message
1456 from LOG_NOTICE to LOG_DEBUG.
1457
14582004-12-03 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1459
ajs887c44a2004-12-03 16:36:46 +00001460 * ospf_main.c: (sigint) Use zlog_notice for termination message.
1461 (main) Issue a startup announcement using zlog_notice.
1462
ajsbec595a2004-11-30 22:38:43 +000014632004-11-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1464
1465 * ospf_packet.c: (ospf_db_desc_proc) Fix spelling of packet in warning
1466 message and in comment.
1467 (ospf_db_desc) Warning message that a packet is being discarded
1468 should give the router id of the packet source. Fix spelling
1469 of packet in two warning messages.
1470 (ospf_ls_req) Warning message that a link state request is being
1471 discarded should give the router id of the neighbor that sent it.
1472
ajs5b85fac2004-11-26 19:36:42 +000014732004-11-26 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1474
1475 * ospf_main.c: Remove #include "debug.h" (was not being used, and
1476 lib/debug.h has now been deleted).
1477
hassoc0652302004-11-25 19:33:48 +000014782004-11-25 Hasso Tepper <hasso at quagga.net>
1479
1480 * ospf_main.c: Make group to run as configurable.
1481
gdt69e13252004-11-15 18:51:15 +000014822004-11-15 Greg Troxel <gdt@fnord.ir.bbn.com>
1483
1484 * ospf_packet.c (ospf_recv_packet): Assume CMSG_SPACE is present
1485 and works (lib/zebra.h provides if OS doesn't).
1486
paul788dab12004-11-15 11:48:37 +000014872004-11-15 Paul Jakma <paul@dishone.st>
1488
1489 * ospf_{apiserver,te}.c: ospf_lsa_free's should be ospf_lsa_unlock.
1490
paul05e85fa2004-11-12 10:52:19 +000014912004-11-12 Paul Jakma <paul@dishone.st>
1492
1493 * ospf_ia.c: (process_summary_lsa) Only an ABR has any reason to
1494 ignore stub area summary default. Even so it seems a strange
1495 check, add a comment to that effect.
1496
paulf3ae74c2004-11-04 20:35:31 +000014972004-11-04 Paul Jakma <paul@dishone.st>
1498
1499 * ospfd.c: (ospf_network_match_iface) revert to previous network
1500 statement match behaviour.
1501
paul62d8e962004-11-02 20:26:45 +000015022004-11-02 Paul Jakma <paul@dishone.st>
1503
1504 * ospf_packet.c: (ospf_write_frags) remove iov arg, msg already points
1505 to it. Add convenience pointer to msg->msg_iov[1], and use this,
1506 fixing the unfortunate borkenness introduced in moving of this code
1507 to a function.
1508 (ospf_write) remove iovp and fix up call to previous.
1509 (ospf_ls_upd_packet_new) cast size to long int - unfortunately
1510 glibc's size_t format modifier is not portable.
1511
paul37ccfa32004-10-31 11:24:51 +000015122004-10-31 Paul Jakma <paul@dishone.st>
1513
1514 * ospf_packet.c: (ospf_write_frags) Add debug output
1515 (ospf_write) set type early, so we can pass it to
1516 ospf_write_frags.
1517 (ospf_ls_upd_packet_new) print size in debug output when too large
1518 packet is encountered.
paul64511f32004-10-31 18:01:13 +00001519 * ospf_zebra.c: (ospf_distribute_list_update_timer) Ugly misuse of
1520 THREAD_ARG to store an integer, but it should at least use same
1521 same type to retrieve the value. Assert value is sane.
paul37ccfa32004-10-31 11:24:51 +00001522
paulac191232004-10-22 12:05:17 +000015232004-10-22 Paul Jakma <paul@dishone.st>
1524
1525 * ospf_network.c: (ospf_sock_init) call neutral setsock_ifindex()
1526 function.
1527 * ospf_packet.c: (ospf_read) manually look up ifindex
paul4ccb2c42004-10-22 22:52:33 +00001528 if system could not have returned one, eg openbsd, thanks to Rivo
1529 Nurges for highlighting problem and fix.
paul06f953f2004-10-22 17:00:38 +00001530 Change setsockopt_pktinfo to setsockopt_ifindex.
paulac191232004-10-22 12:05:17 +00001531
hasso3fb9cd62004-10-19 19:44:43 +000015322004-10-19 Andrew J. Schorr <aschorr@telemetry-investments.com>
1533
1534 * ospf_snmp.c: (ospf_snmp_if_update) Fix logic to handle PtP links
1535 with dedicated subnets properly.
1536 * ospf_lsa.c: (lsa_link_ptop_set) ditto.
1537 * ospfd.c: (ospf_network_match_iface) ditto.
1538 (ospf_network_run) ditto.
1539 * ospf_interface.c: (ospf_if_is_configured) ditto.
1540 (ospf_if_lookup_by_prefix) ditto.
1541 (ospf_if_lookup_recv_if) ditto.
1542 * ospf_vty.c: (show_ip_ospf_interface_sub) Display the peer or
1543 broadcast address if present.
1544
hassod68614d2004-10-13 09:32:48 +000015452004-10-13 Hasso Tepper <hasso at quagga.net>
1546
1547 * ospf_main.c: Unbreak compilation with ospfapi disabled.
hassoc75105a2004-10-13 10:33:26 +00001548 * ospf_snmp.c: Remove defaults used to initialize smux connection to
1549 snmpd. Connection is initialized only if smux peer is configured.
hassod68614d2004-10-13 09:32:48 +00001550
hassof4d58ce2004-10-12 06:13:54 +000015512004-10-12 Hasso Tepper <hasso at quagga.net>
1552
1553 * ospf_main.c, ospf_opaque.c: Unbreak ospfclient compilation - move
1554 static variable from ospf_main.c into ospf_opaque.c.
1555
hassoc3abdb72004-10-11 16:27:03 +000015562004-10-11 Hasso Tepper <hasso at quagga.net>
1557
1558 * ospf_main.c, ospf_opaque.c: Disable ospfapi init by default. New
1559 command line switch to enable it.
1560
paul6b333612004-10-11 10:11:25 +000015612004-10-11 Paul Jakma <paul@dishone.st>
1562
1563 * ospf_dump.c: (ospf_ip_header_dump) Assume header is in host order
1564 remove ntohs that should have dissappeared. Take struct ip
1565 as argument, caller has to know there's an IP header at start of
1566 stream anyway.
1567 * ospf_dump.h: update declaration of ospf_ip_header_dump.
1568 * ospf_packet.c: (ospf_write) correct call to
1569 sockopt_iphdrincl_swab_htosys which was munging the header.
1570 (ospf_recv_packet) ip_len is needed for old OpenBSD fixup.
1571 (ospf_read) sockopt_iphdrincl_swab_systoh ip header as soon as
1572 we have it.
paul6c835672004-10-11 11:00:30 +00001573 * (global) Const char update and signed/unsigned fixes.
1574 * (various headers) size defines should be unsigned.
1575 * ospf_interface.h: remove duplicated defines, include the
1576 authoritative header - though, these defines should probably
1577 be moved to a dedicated header, or ospfd.h.
1578 * ospf_lsa.h: (struct lsa) ls_seqnum should be unsigned.
1579 * ospf_packet.c: (ospf_write) cast result of shift to unsigned.
paul6b333612004-10-11 10:11:25 +00001580
hassoeb1ce602004-10-08 08:17:22 +000015812004-10-08 Hasso Tepper <hasso at quagga.net>
1582
1583 * *.[c|h]: Fix compiler warnings: make some strings const, signed ->
1584 unsigned, remove unused variables etc.
1585
gdt54ade992004-10-07 19:38:20 +000015862004-10-07 Greg Troxel <gdt@claude.ir.bbn.com>
1587
1588 * ospf_apiserver.c (ospf_apiserver_unregister_opaque_type): Don't
1589 use of variable names 'node' and 'nextnode' to avoid possible
1590 conflict with list macros. Move variable declaration inside for
1591 loop after a statement to top of function.
1592
paulaa20c6f2004-10-07 14:19:36 +000015932004-10-07 Paul Jakma <paul@dishone.st>
1594
1595 * ospf_snmp.c: Missed list typedef update
1596 * ospf_dump.c: Include sockopt.h for header swab functions.
1597
paul18b12c32004-10-05 14:38:29 +000015982004-10-05 Paul Jakma <paul@dishone.st>
1599
1600 * ospf_packet.c: replace ospf_swap_iph_to... with
1601 sockopt_iphdrincl_swab_...
1602
hasso18a6dce2004-10-03 18:18:34 +000016032004-10-03 James R. Leu <jleu at mindspring.com>
1604
1605 * ospf_zebra.c: Read router id related messages from zebra daemon.
1606 Schedule router-id update thread if it's changed.
1607 * ospfd.c: Remove own router-id selection function. Use router id from
1608 zebra daemon if it isn't manually overriden in configuration.
1609
paul68defd62004-09-27 07:27:13 +000016102004-09-27 Paul Jakma <paul@dishone.st>
1611
paul6a99f832004-09-27 12:56:30 +00001612 * ospf_dump.c: (ospf_ip_header_dump) Use HAVE_IP_HDRINCL_BSD_ORDER
1613 Apply to offset too. Print ip_cksum, lets not worry about
1614 possible 2.0.37 compile problems.
1615 * ospf_packet.c: (ospf_swap_iph_to{n,h}) Use
1616 HAVE_IP_HDRINCL_BSD_ORDER.
1617 (ospf_recv_packet) ditto.
1618 (ospf_write) Fixup iov argument to ospf_write_frags.
1619 (struct msghdr).msg_name is caddr_t on most platforms.
paul68defd62004-09-27 07:27:13 +00001620 (ospf_recv_packet) ditto. And msg_flags is not always there
1621 memset struct then set fields we care about rather than
1622 initialise all fields individually.
1623
hassoc9e52be2004-09-26 16:09:34 +000016242004-09-26 Hasso Tepper <hasso at quagga.net>
1625
1626 * ospf_abr.c, ospf_dump.c, ospf_lsa.c, ospf_packet.c, ospf_vty.c,
1627 ospf_zebra.c: Fix compiler warnings.
1628
paul87d6f872004-09-24 08:01:38 +000016292004-09-24 Paul Jakma <paul@dishone.st>
1630
1631 * ospf_apiserver.{c,h}: lists typedef removal cleanup.
1632 update some list loops to LIST_LOOP. some miscellaneous indent
1633 fixups.
1634 (ospf_apiserver_unregister_opaque_type) fix listnode_delete of
1635 referenced node in loop.
paul1603c062004-09-24 08:23:24 +00001636 (ospf_apiserver_term) loops calling ospf_apiserver_free, which
1637 deletes referenced nodes from apiserver_list, fixed.
paul87d6f872004-09-24 08:01:38 +00001638 * ospf_interface.h: lists typedef removal cleanup.
1639 * ospf_opaque.{c,h}: lists typedef removal cleanup. update some list
1640 loops to LIST_LOOP. miscellaneous style and indent fixups.
1641 * ospf_te.{c,h}: ditto
1642 * ospf_packet.c: lists typedef removal cleanup.
paula2570682004-09-24 08:09:57 +00001643 (ospf_write) ifdef fragmentation support. move actual
1644 fragmentation out to a new, similarly ifdefed, function.
1645 (ospf_write_frags) fragmented write support, moved from previous.
paul87d6f872004-09-24 08:01:38 +00001646
hasso52dc7ee2004-09-23 19:18:23 +000016472004-09-23 Hasso Tepper <hasso at quagga.net>
1648
1649 * *.[c|h]: list -> struct list *, listnode -> struct listnode *.
1650
paul68b73392004-09-12 14:21:37 +000016512004-09-12 Paul Jakma <paul@dishone.st>
1652
1653 * ospf_packet.c: Fix bugzilla #107
1654 (ospf_packet_max) get rid of the magic 88 constant
1655 (ospf_swab_iph_ton) new function. set ip header to network order,
1656 taking BSDisms into account.
1657 (ospf_swab_iph_toh) the inverse.
1658 (ospf_write) Add support for IP fragmentation, will only work on
1659 linux though, other kernels make it impossible. get rid of the
1660 magic 4 constant.
1661 (ospf_make_ls_upd) Bound check to end of stream, not to
1662 interface mtu.
1663 (ospf_ls_upd_packet_new) New function, allocate upd packet
1664 taking oversized LSAs into account.
1665 (ospf_ls_upd_queue_send) use ospf_ls_upd_packet_new to allocate,
1666 rather than statically allocating mtu sized packet buffer, which
1667 actually was wrong - it didnt take ip header into account, which
1668 should not be included in packet buffer.
1669 (ospf_ls_upd_send_queue_event) minor tweaks and remove
1670 TODO comment.
1671
gdt630e4802004-08-31 17:28:41 +000016722004-08-31 David Wiggins <dwiggins@bbn.com>
1673
1674 * ospf_spf.c (ospf_spf_calculate): Many more comments and debug
1675 print statements. New function ospf_vertex_dump used in debugging.
1676
16772004-08-31 David Wiggins <dwiggins@bbn.com>
1678
1679 * ospf_spf.h (struct vertex): Comments for flags and structure members.
1680
16812004-08-31 David Wiggins <dwiggins@bbn.com>
1682
1683 * ospf_route.c: When finding an alternate route, log cost as well.
1684
16852004-08-31 David Wiggins <dwiggins@bbn.com>
1686
1687 * ospf_interface.c (ospf_lookup_if_params): Initialize af in
1688 struct prefix allocated on stack.
1689
16902004-08-31 David Wiggins <dwiggins@bbn.com>
1691
1692 * ospf_packet.c (ospf_ls_ack_send_delayed): In p2mp mode, send
1693 acks to AllSPFRouters, rather than All-DR.
1694
hasso7b901432004-08-31 13:37:42 +000016952004-08-27 Hasso Tepper <hasso at quagga.net>
1696
1697 * ospf_vty.c: Don't print ospf network type under interface only
1698 if interface is in broadcast mode and interface type really is
1699 broadcast. Fixes Bugzilla #108.
1700
gdtd7d93992004-08-27 12:03:42 +000017012004-08-27 David Wiggins <dwiggins@bbn.com>
1702
1703 * ospf_spf.c (ospf_nexthop_calculation): Initialize address family
1704 in on-stack struct prefix_ipv4. Fixes point-to-multipoint SPF
1705 calculation.
1706
gdtd0deca62004-08-26 13:14:07 +000017072004-08-26 Greg Troxel <gdt@fnord.ir.bbn.com>
1708
1709 * ospf_packet.c (ospf_recv_packet): adjust size declaration of
gdtd7d93992004-08-27 12:03:42 +00001710 buffer used to get interface index so that it compiles on other
1711 than Linux and includes the required alignment space. Probably
1712 this was only working on sparc/sparc64 because most of
1713 sockaddr_dl was not being written.
gdtd0deca62004-08-26 13:14:07 +00001714
paul863082d2004-08-19 04:43:43 +000017152004-08-19 Paul Jakma <paul@dishone.st>
1716
1717 * ospf_packet.c: update to match sockopt renames.
1718
paul75ee0b82004-08-05 09:10:31 +000017192004-08-04 Paul Jakma <paul@dishone.st>
1720
1721 * ospf_spf.c: (ospf_spf_consider_nexthop) Add comment about issue.
1722 Compare only against list head - all nexthops must be same cost
1723 anyway, fixes a reference-listnode-after-delete bug noted by
1724 Kir Kostuchenko.
1725 (ospf_nexthop_calculation) Use ospf_spf_consider_nexthop for all
1726 candidates attached to root.
1727
paul36c64ef2004-07-27 11:19:11 +000017282004-07-27 Paul Jakma <paul@dishone.st>
1729
paul48fe13b2004-07-27 17:40:44 +00001730 * ospf_packet.c: (ospf_ls_upd_send_queue_event) fix thinko from
1731 last fix for ospfd wedging due to oversize LSAs: dont list loop on
1732 ospf_ls_upd_queue_send() - guaranteed segfault.
1733
17342004-07-27 Paul Jakma <paul@dishone.st>
1735
paul36c64ef2004-07-27 11:19:11 +00001736 * ospf_opaque.c: (ospf_opaque_lsa_flush_schedule) do not NULL out
1737 the LSA as then free_opaque_info_per_id() can never unlock (and
1738 free) the LSA. Reported by Gunnar Stigen.
1739
paul2dd8bb42004-07-23 15:13:48 +000017402004-07-23 Paul Jakma <paul@dishone.st>
1741
1742 * ospf_network.c: Replace PKTINFO/RECVIF with call to
1743 setsockopt_pktinfo
1744 * ospf_packet.c: Use getsockopt_pktinfo_ifindex and
1745 SOPT_SIZE_CMSG_PKTINFO_IPV4.
1746
paul59ea14c2004-07-14 20:50:36 +000017472004-07-14 Paul Jakma <paul@dishone.st>
1748
1749 * ospf_packet.c: (ospf_ls_upd_send_queue_event) Partial fix for
1750 problem reported by Peter Frost amongst others, where function
1751 will spin indefinitely if update list contains LSAs greater than
1752 MTU-headers or other condition leading to update list never being
1753 cleared. Problem of what to do with these LSAs remains.
1754 (ospf_make_ls_upd) add comment about large LSA problem,
1755 indentation cleanup.
1756
gdtb2c1b282004-07-01 12:35:36 +000017572004-07-01 Greg Troxel <gdt@fnord.ir.bbn.com>
1758
1759 * Makefile.am (lib_LTLIBRARIES): make libospf shared
1760
gdt87efd642004-06-30 17:36:11 +000017612004-06-30 Greg Troxel <gdt@poblano.ir.bbn.com>
1762
1763 * Makefile.am: Add shlib support.
1764
hassobeebba72004-06-20 21:00:27 +000017652004-06-10 Hasso Tepper <hasso@estpak.ee>
1766
1767 * *: Removed ifdefs HAVE_NSSA.
1768
paul553ff112004-06-06 09:41:00 +000017692004-06-06 Paul Jakma <paul@dishone.st>
1770
1771 * ospf_dump.c,ospf_lsa.c: Fix typos of merge of previous.
1772 ospf_flood.c: (ospf_process_self_originated_lsa) fix zlog format
1773
paul0c2be262004-05-31 14:16:54 +000017742004-05-31 Sagun Shakya <sagun.shakya@sun.com>
1775
1776 * ospf_dump.c: (ospf_lsa_header_dump) LOOKUP can return null if
1777 index is out of range.
1778 ospf_flood.c: endianness fix
1779 ospf_lsa.c: Missing ntohl's on (struct lsa *)->data->ls_seqnum
1780 in various places.
1781
hassodd669bb2004-05-10 07:43:59 +000017822004-05-10 Hasso Tepper <hasso@estpak.ee>
1783
1784 * ospf_zebra.c, ospfd.c: Move ospf_prefix_list_update() function
1785 to ospf_zebra.c from ospfd.c and add redistribution updates if
1786 route-map is used in redistribution.
1787 * ospf_main.c: Remove now useless call to ospf_init().
1788
paul0a589352004-05-08 11:48:26 +000017892004-05-08 Paul Jakma <paul@dishone.st>
1790
1791 * ospf_zebra.c: Sync with lib/zclient changes
1792
pauld3f0d622004-05-05 15:27:15 +000017932004-05-05 Paul Jakma <paul@dishone.st>
1794
paul5bd41892004-05-05 17:29:24 +00001795 * ospf_network.c: (ospf_sock_init) Check whether IP_HDRINCL is
1796 defined. Warn at compile and runtime. Use
1797 IPTOS_PREC_INTERNETCONTROL otherwise.
pauld3f0d622004-05-05 15:27:15 +00001798 * ospf_packet.c: (ospf_associate_packet_vl) cleanup, move
1799 some of the checks up to ospf_read, return either a
1800 virtual link oi, or NULL.
1801 (ospf_read) Cleanup, make it responsible for checks. Remove
1802 the nbr lookup - moved to ospf_neighbor. Adjust all nbr
1803 lookups to use new wrappers exported by ospf_neighbor.
1804 * ospf_neighbor.h: Add ospf_neigbour_get and ospf_nbr_lookup.
1805 * ospf_neighbor.c: (ospf_neigbour_get) Index ospf_interface
1806 neighbour table by router-id for virtual-link ospf_interfaces,
1807 not by peer_addr (which breaks for asymmetric vlinks)
1808 (ospf_nbr_lookup) add a wrapper for nbr lookups to deal with
1809 above.
paulcd59da62004-05-05 17:26:55 +00001810 * ospf_interface.c: (ospf_vl_set_params) Catch changes of interface
1811 address for either end of a virtual-link, and hence potential cost
1812 changes.
1813
hassoa0a39762004-04-23 08:51:10 +000018142004-04-22 Hasso Tepper <hasso@estpak.ee>
1815
1816 * ospf_zebra.c: Don't ignore reject/bh routes, it's the only way
1817 to "summarize" routes in ASBR at the moment.
1818
hasso8585d4e2004-04-20 17:25:12 +000018192004-04-20 Hasso Tepper <hasso@estpak.ee>
1820
1821 * ospfd.c: Unset NP flag if area is going to be normal or stub.
1822 Fixes UNH OSPF_NSSA.1.2a comment.
1823 * ospf_abr.c: Originate default into stub/nssa area even if
1824 summaries are disabled.
1825 * ospf_zebra.c: Don't attempt to redistribute 127.0.0.0/8.
1826
hassoc266ac72004-04-19 17:31:00 +000018272004-04-19 Hasso Tepper <hasso@estpak.ee>
1828
1829 * ospf_vty.c: Don't warn that export- and import-list can't be
1830 configured to backbone area if they are applied and are working
1831 fine.
1832
hasso128d31d2004-04-04 12:52:33 +000018332004-02-19 Sowmini Varadhan <sowmini.varadhan@sun.com>
1834
1835 * ospf_packet.c: Don't drop packets in Solaris x86.
1836 [quagga-dev 1005].
1837
hasso0d85b992004-03-18 19:18:33 +000018382004-03-18 Amir Guindehi <amir@datacore.ch>
1839
1840 * ospf_opaque.c: Attempt to correct the incorrect behavior of
1841 Quagga's ospfd in the special situation that a node's opaque
1842 capability has changed as "ON -> OFF -> ON". [quagga-dev 843].
1843
paul7f352b82004-02-19 19:37:47 +000018442004-02-19 Sowmini Varadhan <sowmini.varadhan@sun.com>
1845
1846 * ospf_abr.c: (ospf_abr_update_aggregate) UNH 3.12b,c, address range
1847 should be configured with the highest cost path within the range,
1848 not lowest.
1849
paul940b01a2004-02-17 20:07:30 +000018502004-02-17 Paul Jakma <paul@dishone.st>
1851
1852 * ospf_zebra.c: (ospf_interface_delete) Do not delete the interface
1853 params, nor the interface structure, if an interface delete
1854 message is received from zebra.
1855 * ospf_interface.c: (ospf_if_delete_hook) Delete the interface
1856 params and interface, ie that which was previously removed in
1857 (ospf_interface_delete) above.
1858
hasso2db3d052004-02-11 21:52:13 +000018592004-02-11 Hasso Tepper <hasso@estpak.ee>
1860 * ospf_interface.c, ospf_zebra.c: Don't attempt to read path->oi->ifp
1861 if oi doesn't exist any more.
1862
hassocb05eb22004-02-11 21:10:19 +000018632004-02-11 Vadim Suraev <vadim.suraev@terayon.com>
1864 * ospf_packet.c (ospf_ls_upd): Router should flush received network
1865 LSA if it was originated with older router-id ([zebra 14710] #6).
1866
18672003-12-08 Mattias Amnefelt <mattiasa@kth.se>
paul239aecc2003-12-08 10:34:54 +00001868
1869 * ospf_packet.c: (ospf_recv_packet) OpenBSD now leaves iph.ip_len
1870 network byte order.
1871
gdt8f40e892003-12-05 14:01:43 +000018722003-12-05 Greg Troxel <gdt@poblano.ir.bbn.com>
1873
1874 * ospfd.c (ospf_network_match_iface): Rewrite code for clarity
1875 while trying not to change semantics. Add ifdefed-out code to
1876 avoid matching ppp interfaces whose destination address does not
1877 also match the prefix under consideration, to help out people with
1878 problems due to as-yet-unfixed bugs with p2p interfaces coming and
1879 going.
1880
paul736d3442003-07-24 23:22:57 +000018812003-07-25 kamatchi soundaram <kamatchi@tdd.sj.nec.com>
1882
1883 * ospf_packet.c (ospf_ls_upd_send_queue_event): get next route
1884 node in body of the loop to avoid chance that route node
1885 is unlocked and deleted before the next iteration tries to
1886 get next route node.
1887
paul0a825c72003-05-24 13:48:16 +000018882003-05-24 Kenji Yabuuchi
1889
1890 * ospf_interface.c(ospf_if_lookup_recv_if): Use the most specific
1891 match for interface lookup.
1892
paul551a8972003-05-18 15:22:55 +000018932003-05-18 Hasso Tepper <hasso@estpak.ee>
paul445f1432003-05-16 19:00:31 +00001894
paul551a8972003-05-18 15:22:55 +00001895 * ospf_vty.c: Show NSSA LSA route info in "show ip ospf database"
1896 output
paul445f1432003-05-16 19:00:31 +00001897
pauld7480322003-05-16 17:31:51 +000018982003-05-16 Hasso Tepper <hasso@estpak.ee>
1899
1900 * ospf_lsa.c: Fix handling of NSSA
1901
paul551a8972003-05-18 15:22:55 +000019022003-04-23 Hasso Tepper <hasso@estpak.ee>
1903
1904 * ospf_vty.c: fix "router xxx" node commands in vtysh
1905
paul445f1432003-05-16 19:00:31 +000019062003-04-19 Hasso Tepper <hasso@estpak.ee>
1907
1908 * {ospf_abr,ospfd}.c: area id's DECIMAL -> ADDRESS
1909 * ospf_routemap.c: sync daemon's route-map commands to have same
1910 syntax.
1911
19122003-04-19 Sergey Vyshnevetskiy <serg@vostok.net>
1913
1914 * ospf_packet.c: Add missing param to zlog
1915 * ospf_flood.c: remove unused vars
1916
19172003-04-17 Denis Ovsienko <zebra@pilot.org.ua>
1918
1919 * ospf_interface.c: fix incorrect memset
1920
paul28a13842003-05-16 20:30:37 +000019212003-04-10 Amir Guindehi <amir@datacore.ch>
paul445f1432003-05-16 19:00:31 +00001922
1923 * ospf_lsa.[ch]: opaque LSA fix, use ospf_lookup.
1924
19252003-04-03 David Watson <dwatson@eecs.umich.edu>
1926
1927 * ospf_lsa.c: byte order fix
1928
paul07661cb2003-03-18 00:03:05 +000019292002-03-17 Amir Guindehi <amir@datacore.ch>
1930
1931 * ospf_apiserver.[ch]: Merge Ralph Keller's OSPFAPI support.
1932 * ospf_api.[ch]: Merge Ralph Keller's OSPFAPI support.
1933 * ospfclient: OSPFAPI demonstration client.
1934
19352003-01-23 Masahiko Endo <endo@suri.co.jp>
1936
1937 * ospf_ism.c: NSM event schedule bug fix.
1938
19392002-10-30 Greg Troxel <gdt@ir.bbn.com>
1940
1941 * ospf_packet.c (ospf_make_md5_digest): MD5 length fix.
1942
paul718e3742002-12-13 20:15:29 +000019432002-10-23 endo@suri.co.jp (Masahiko Endo)
1944
1945 * ospf_opaque.c: Update Opaque LSA patch.
1946
19472002-10-23 Ralph Keller <keller@tik.ee.ethz.ch>
1948
1949 * ospf_vty.c (show_ip_ospf_database): Fix CLI parse.
1950
19512002-10-23 Juris Kalnins <juris@mt.lv>
1952
1953 * ospf_interface.c (ospf_if_stream_unset): When write queue
1954 becomes empty stop write timer.
1955
19562002-10-10 Greg Troxel <gdt@ir.bbn.com>
1957
1958 * ospf_packet.c (ospf_check_md5_digest): Change >= to > to make it
1959 conform to RFC.
1960
19612002-07-07 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1962
1963 * zebra-0.93 released.
1964
19652002-06-19 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1966
1967 * ospf_spf.c (ospf_nexthop_calculation): Add NULL set to oi and
1968 check of l2. Reported by: Daniel Drown <dan-zebra@drown.org>
1969 (ospf_lsa_has_link): LSA Length calculation fix. Reported by:
1970 Paul Jakma <paulj@alphyra.ie>.
1971
1972 * ospfd.c (ospf_if_update): Fix nextnode reference bug. Reported
1973 by: juris@mt.lv.
1974
19752002-01-21 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1976
1977 * ospfd.c: Merge [zebra 11445] Masahiko ENDO's Opaque-LSA support.
1978
19792001-08-27 Kunihiro Ishiguro <kunihiro@zebra.org>
1980
1981 * ospf_interface.c (ospf_add_to_if): Use /32 address to register
1982 OSPF interface information.
1983 (ospf_delete_from_if): Likewise.
1984
1985 * ospf_zebra.c (ospf_interface_address_delete): Likewise.
1986
19872001-08-23 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1988
1989 * ospf_zebra.c (ospf_redistribute_unset): When redistribute type
1990 is OSPF, do not unset redistribute flag.
1991
19922001-08-19 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1993
1994 * zebra-0.92a released.
1995
19962001-08-15 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1997
1998 * zebra-0.92 released.
1999
20002001-08-12 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
2001
2002 * ospfd.c (ospf_config_write): auto-cost reference-bandwidth
2003 configuration display.
2004
20052001-07-24 David Watson <dwatson@eecs.umich.edu>
2006
2007 * ospf_spf.c (ospf_spf_next): Modify ospf_vertex_add_parent to
2008 check for an existing link before connecting the parent and child.
2009 ospf_nexthop_calculation is also modified to check for duplicate
2010 entries when copying from the parent. Finally, ospf_spf_next
2011 removes duplicates when it merges two equal cost candidates.
2012
20132001-07-23 itojun@iijlab.net
2014
2015 * ospfd.c (show_ip_ospf_neighbor): Check ospf_top before use it
2016 [zebra 8549].
2017
20182001-07-23 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
2019
2020 * ospf_packet.c (ospf_write): Remove defined(__OpenBSD__) to make
2021 it work on OpenBSD.
2022
20232001-06-26 Kunihiro Ishiguro <kunihiro@zebra.org>
2024
2025 * ospf_zebra.c (config_write_ospf_default_metric): Display
2026 default-metric configuration.
2027
20282001-06-18 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
2029
2030 * ospf_ia.h (OSPF_EXAMINE_SUMMARIES_ALL): Remove old macros.
2031
20322001-05-28 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
2033
2034 * ospf_snmp.c (ospfIfEntry): Fix interface lookup bug to avoid
2035 crush.
2036 (ospfIfMetricEntry): Likewise.
2037
20382001-03-18 Kunihiro Ishiguro <kunihiro@zebra.org>
2039
2040 * ospf_packet.c (ospf_read): Fix typo. Reported by: "Jen B
2041 Lin'Kova" <jen@stack.net>.
2042
20432001-03-15 Gleb Natapov <gleb@nbase.co.il>
2044
2045 * ospf_interface.c (ip_ospf_network): Set interface parameter.
2046 (interface_config_write): Add check for OSPF_IFTYPE_LOOPBACK.
2047
2048 * ospf_zebra.c (ospf_interface_add): Set interface parameter.
2049
20502001-02-21 Kunihiro Ishiguro <kunihiro@zebra.org>
2051
2052 * ospf_packet.c (ospf_recv_packet): Solaris also need to add
2053 (iph.ip_hl << 2) to iph.ip_len.
2054
20552001-02-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2056
2057 * ospfd.h (OSPF_LS_REFRESH_TIME): Fix OSPF_LS_REFRESH_TIME value.
2058 Suggested by: David Watson <dwatson@eecs.umich.edu>.
2059
2060 * ospf_zebra.c (zebra_init): Remove zebra node.
2061
2062 * ospfd.c (ospf_area_range_set): Function name is changed from
2063 ospf_ara_range_cmd.
2064 (ospf_area_range_unset): New function which separated from DEFUN.
2065 New commands are added:
2066 "no area A.B.C.D range A.B.C.D/M advertise"
2067 "no area <0-4294967295> range A.B.C.D/M advertise"
2068 "no area A.B.C.D range A.B.C.D/M not-advertise"
2069 "no area <0-4294967295> range A.B.C.D/M not-advertise"
2070
2071 * ospf_lsa.c (ospf_lsa_more_recent): Fix previous change.
2072
20732001-02-08 Matthew Grant <grantma@anathoth.gen.nz>
2074
2075 * ospf_network.c (ospf_if_add_allspfrouters): Use
2076 setsockopt_multicast_ipv4.
2077 (ospf_if_drop_allspfrouters): Likewise.
2078
2079 * ospf_lsa.c (ospf_router_lsa_install): Add rt_recalc flag.
2080 (ospf_network_lsa_install): Likewise.
2081 (ospf_summary_lsa_install): Likewise.
2082 (ospf_summary_asbr_lsa_install): Likewise.
2083 (ospf_external_lsa_install): Likewise.
2084 (ospf_lsa_install): Call ospf_lsa_different to check this LSA is
2085 new one or not.
2086
20872001-02-08 Kunihiro Ishiguro <kunihiro@zebra.org>
2088
2089 * ospf_zebra.c (ospf_interface_delete): Do not free interface
2090 structure when ospfd receive interface delete message to support
2091 pseudo interface.
2092
20932001-02-01 Dick Glasspool <dick@ipinfusion.com>
2094
2095 * ospfd.c (area_range_notadvertise): Change area range "suppress"
2096 command to "not-advertise".
2097
2098 * ospfd.h (OSPF_LS_REFRESH_TIME): Change OSPF_LS_REFRESH_TIME from
2099 1800 to 60.
2100
2101 * ospf_abr.c (ospf_abr_update_aggregate): When update_aggregate is
2102 updating the area-range, the lowest cost is now saved.
2103
2104 * ospf_lsa.c (ospf_lsa_more_recent): Routing to compare sequence
2105 numbers rather than creating overflow during calculation.
2106
21072001-02-01 Kunihiro Ishiguro <kunihiro@zebra.org>
2108
2109 * zebra-0.91 is released.
2110
21112001-01-31 Kunihiro Ishiguro <kunihiro@zebra.org>
2112
2113 * ospf_packet.c (ospf_db_desc_proc): Do not continue process when
2114 NSM_SeqNumberMismatch is scheduled.
2115 (ospf_ls_req): Free ls_upd when return from this function.
2116 (ospf_ls_upd_timer): When update list is empty do not call
2117 ospf_ls_upd_send(). Suggested by: endo@suri.co.jp (Masahiko
2118 Endo).
2119
21202001-01-26 Kunihiro Ishiguro <kunihiro@zebra.org>
2121
2122 * ospf_lsa.c (ospf_maxage_flood): Flood LSA when it reaches
2123 MaxAge. RFC2328 Section 14.
2124 (ospf_maxage_lsa_remover): Call above function during removing
2125 MaxAge LSA.
2126
21272001-01-26 Dick Glasspool <dick@ipinfusion.com>
2128
2129 * ospf_flood.c (ospf_flood_through_as): Function is updated for
2130 NSSA Translations now done at ospf_abr.c with no change in P-bit.
2131
2132 * ospf_lsa.c (ospf_get_nssa_ip): Get 1st IP connection for Forward
2133 Addr.
2134 (ospf_install_flood_nssa): Leave Type-7 LSA at Lock Count = 2.
2135
2136 * ospf_ase.c (ospf_ase_calculate_route): Add debug codes.
2137
2138 * ospf_abr.c (ospf_abr_translate_nssa): Recalculate LSA checksum.
2139
2140 * ospf_packet.h (OSPF_SEND_PACKET_LOOP): Added for test packet.
2141
2142 * ospf_dump.c (ospf_lsa_type_msg): Add OSPF_GROUP_MEMBER_LSA and
2143 OSPF_AS_NSSA_LSA.
2144
2145 * ospfd.c (data_injection): Function to inject LSA. This is
2146 debugging command.
2147
21482001-01-11 Kunihiro Ishiguro <kunihiro@zebra.org>
2149
2150 * ospf_route.c (ospf_route_match_same): Remove function.
2151 (ospf_route_match_same_new): Renamed to ospf_route_match_same.
2152
2153 * ospf_zebra.c (ospf_interface_address_delete): Add check for
2154 oi->address. Suggested by Matthew Grant
2155 <grantma@anathoth.gen.nz>.
2156 (ospf_zebra_add): Remove function.
2157 (ospf_zebra_add_multipath): Rename to ospf_zebra_add.
2158
2159 * ospf_interface.c: Remove HAVE_IF_PSEUDO part.
2160
2161 * ospf_zebra.c: Likewise.
2162
21632001-01-10 Kunihiro Ishiguro <kunihiro@zebra.org>
2164
2165 * ospf_ase.c: Remove OLD_RIB part.
2166
2167 * ospf_route.c: Likewise.
2168
2169 * zebra-0.90 is released.
2170
2171 * ospf_packet.c (ospf_recv_packet): Use ip_len adjestment code to
2172 NetBSD.
2173
21742001-01-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2175
2176 * ospf_route.c (ospf_route_delete): Use
2177 ospf_zebra_delete_multipath.
2178
21792001-01-09 Matthew Grant <grantma@anathoth.gen.nz>
2180
2181 * ospf_interface.c (ospf_if_cleanup): Function name is renamed
2182 from ospf_if_free(). Rewrite whole procudure to support primary
2183 address deletion.
2184
2185 * ospf_zebra.c (ospf_interface_address_delete): Add primary
2186 address deletion process.
2187
21882001-01-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2189
2190 * ospf_packet.c (ospf_recv_packet): OpenBSD has same ip_len
2191 treatment like FreeBSD.
2192
21932001-01-09 endo@suri.co.jp (Masahiko Endo)
2194
2195 * ospf_packet.c (ospf_recv_packet): FreeBSD kernel network code
2196 strips IP header size from receiving IP Packet. So we adjust
2197 ip_len to whole IP packet size by adding IP header size.
2198
21992001-01-08 endo@suri.co.jp (Masahiko Endo)
2200
2201 * ospf_network.c (ospf_serv_sock): When socket() is failed return
2202 immediately.
2203 (ospf_serv_sock): Close socket when it is not used.
2204
2205 * ospf_packet.c (ospf_write): Set sin_len when HAVE_SIN_LEN is
2206 defined.
2207 (ospf_write): When bind is fined, close sock.
2208
22092001-01-07 Gleb Natapov <gleb@nbase.co.il>
2210
2211 * ospf_zebra.c (ospf_interface_state_up): Fixes coredump that
2212 appears when you try to configure bandwidth on the ppp interface
2213 that is not yet configured in ospfd.
2214
22152001-01-07 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2216
2217 * ospf_route.c (show_ip_ospf_route_external): "show ip ospf route"
2218 will print nexthops for AS-external routes.
2219
2220 * ospf_ase.c (ospf_ase_route_match_same): New function to compare
2221 ASE route under multipath environment.
2222 (ospf_ase_compare_tables): Likewise.
2223
22242001-01-01 Kunihiro Ishiguro <kunihiro@zebra.org>
2225
2226 * ospfd.h (OSPF_VTYSH_PATH): Change "/tmp/ospfd" to "/tmp/.ospfd".
2227
22282000-12-28 Kunihiro Ishiguro <kunihiro@zebra.org>
2229
2230 * ospf_route.c (ospf_route_install): Install multipath information
2231 to zebra daemon.
2232
2233 * ospf_zebra.c (ospf_zebra_add_multipath): Function for passing
2234 multipath information to zebra daemon.
2235
22362000-12-25 Dick Glasspool <dick@ipinfusion.com>
2237
2238 * ospf_packet.c (ospf_write): Call ospf_packet_delete when sendto
2239 fail.
2240 (DISCARD_LSA): Add argument N for logging point of DISCARD_LSA is
2241 called.
2242
2243 * ospf_lsa.c (ospf_external_lsa_refresh): NSSA install_flood will
2244 leave Type-7 LSA at Lock Count = 2.
2245
2246 * ospf_flood.c (ospf_flood_through): Flood_though_as updated for
2247 NSSA no P-bit off during Area flooding, but P-bit is turned off
2248 for mulitple NSSA AS flooding.
2249
2250 * ospf_ase.c (ospf_ase_calculate_timer): Added calculations for
2251 Type-7 LSDB.
2252
2253 * ospf_abr.c (ospf_abr_translate_nssa): Removed one unlock call.
2254 (ospf_abr_announce_nssa_defaults): Corrected Debug from EVENT to
2255 NSSA.
2256
22572000-12-25 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2258
2259 * ospf_zebra.c (ospf_zebra_read_ipv4): Checking the age of the
2260 found LSA and if the LSA is MAXAGE we should call refresh instead
2261 of originate.
2262
22632000-12-18 Dick Glasspool <dick@ipinfusion.com>
2264
2265 * ospf_abr.c: Removed redundant "...flood" in
2266 announce_network_to_area(). Repaired nssa Unlock by using
2267 discard.
2268
2269 * ospf_packet.c: Removed old NSSA translate during mk_ls_update.
2270
2271 * ospfd.c: Free up all data bases including NSSA.
2272
2273 * ospf_lsa.c: Now allow removal of XLATE LSA's Check in
2274 discard_callback. Added routine to get ip addr from within the
2275 ifp.
2276
2277 * ospf_flood.c: Now set Forward Address for outgoing Type-7.
2278
2279 * ospf_lsa.h: Added prototype for the below. struct in_addr
2280 ospf_get_ip_from_ifp (struct interface *ifp).
2281
22822000-12-14 Gleb Natapov <gleb@nbase.co.il>
2283
2284 * ospf_packet.c (ospf_recv_packet): New OSPF pakcet read method.
2285 Now maximum packet length may be 65535 bytes (maximum IP packet
2286 length).
2287
2288 * ospf_interface.c (ospf_if_stream_set): Don't make input buffer.
2289
2290 * ospfd.c (config_write_network_area): Remove unnecessary area
2291 lookup code.
2292
22932000-12-13 Kunihiro Ishiguro <kunihiro@zebra.org>
2294
2295 * ospf_packet.c (ospf_read): Accept packet bigger than MTU value.
2296
22972000-12-13 Gleb Natapov <gleb@nbase.co.il>
2298
2299 * ospfd.c (config_write_network_area): Fix bug in
2300 config_write_network_area function.
2301
23022000-12-12 Gleb Natapov <gleb@nbase.co.il>
2303
2304 * ospf_abr.c (ospf_abr_announce_network_to_area): Make Summary
2305 LSA's origination and refreshment as same as other type of LSA.
2306
2307 * ospf_lsa.c (ospf_summary_lsa_refresh): Return struct ospf_lsa *.
2308
2309 * ospf_lsa.c (ospf_summary_asbr_lsa_refresh): Likewise.
2310
23112000-12-08 Dick Glasspool <dick@ipinfusion.com>
2312
2313 The bulk of NSSA changes are contained herein; This version will
2314 require manual setting of "always" for NSSA Translator, and will
2315 not perform aggregation yet.
2316
2317 * ospf_dump.c: "debug ospf nssa" is added.
2318
2319 * ospf_dump.h: Likewise.
2320
2321 * ospf_packet.c (ospf_hello): Display router ID on Bad NSSA Hello.
2322
2323 * ospfd.c: Discard_LSA to stay away from LOCAL_XLT Process NSSA
2324 'never, candidate, always'. Change "suppress" to "not-advertise".
2325
2326 * ospfd.h: Add TranslatorRole to struct ospf_area. Add anyNSSA to
2327 struct ospf.
2328
2329 * ospf_ase.c (ospf_ase_calculate_route): External to stay away
2330 from LOCAL_XLT
2331
2332 * ospf_nsm.c (ospf_db_summary_add): External to stay away from
2333 LOCAL_XLT
2334
2335 * ospf_abr.c: Major logic added for abr_nssa_task(). If ABR, and
2336 NSSA translator, then do it. Approve the global list, and flush
2337 any unapproved.
2338
2339 * ospf_lsa.h: New LSA flag OSPF_LSA_LOCAL_XLT to indicate that the
2340 Type-5 resulted from a Local Type-7 translation; not used for
2341 flooding, but used for flushing.
2342
2343 * ospf_flood.c: New NSSA flooding.
2344
23452000-12-08 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2346
2347 * ospfd.c (ospf_find_vl_data): New function for looking up virtual
2348 link data.
2349 (ospf_vl_set_security): Virtual link configuration with
2350 authentication.
2351 (ospf_vl_set_timers): Set timers for virtual link.
2352
2353 * New commands are added.
2354 "area A.B.C.D virtual-link A.B.C.D"
2355 "area A.B.C.D virtual-link A.B.C.D hello-interval <1-65535> retransmit-interval <3-65535> transmit-delay <1-65535> dead-interval <1-65535>"
2356 "area A.B.C.D virtual-link A.B.C.D hello-interval <1-65535> retransmit-interval <3-65535> transmit-delay <1-65535> dead-interval <1-65535> authentication-key AUTH_KEY"
2357 "area A.B.C.D virtual-link A.B.C.D authentication-key AUTH_KEY"
2358 "area A.B.C.D virtual-link A.B.C.D hello-interval <1-65535> retransmit-interval <3-65535> transmit-delay <1-65535> dead-interval <1-65535> message-digest-key <1-255> md5 KEY"
2359 "area A.B.C.D virtual-link A.B.C.D message-digest-key <1-255> md5 KEY"
2360
2361 * ospf_packet.c (ospf_check_md5_digest): Add neighbor's
2362 cryptographic sequence number treatment.
2363 (ospf_check_auth): OSPF input buffer is added to argument.
2364 (ospf_read): Save neighbor's cryptographic sequence number.
2365
2366 * ospf_nsm.c (nsm_change_status): Clear cryptographic sequence
2367 number when neighbor status is changed to NSM down.
2368
2369 * ospf_neighbor.c (ospf_nbr_new): Set zero to crypt_seqnum.
2370
2371 * ospf_neighbor.h (struct ospf_neighbor): Add cryptographic
2372 sequence number to neighbor structure.
2373
23742000-11-29 Kunihiro Ishiguro <kunihiro@zebra.org>
2375
2376 * ospf_snmp.c (ospfIfLookup): OSPF MIB updates.
2377 (ospfExtLsdbEntry): Add OspfExtLsdbTable treatment.
2378
23792000-11-28 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2380
2381 * ospfd.c (ospf_interface_down): Clear a ls_upd_queue queue of the
2382 interface.
2383 (ospf_ls_upd_queue_empty): New function to empty ls update queue
2384 of the OSPF interface.
2385 (no_router_ospf): 'no router ospf' unregister redistribution
2386 requests from zebra.
2387
23882000-11-28 Kunihiro Ishiguro <kunihiro@zebra.org>
2389
2390 * ospf_ism.c (ism_change_status): Increment status change number.
2391
2392 * ospf_interface.h (struct ospf_interface): Add new member for
2393 status change statistics.
2394
2395 * Makefile.am: Update dependencies.
2396
2397 * ospf_zebra.c (ospf_interface_add): OSPF SNMP interface update.
2398 (ospf_interface_delete): OSPF SNMP interface delete.
2399
2400 * ospf_snmp.h: New file is added.
2401
24022000-11-23 Dick Glasspool <dick@ipinfusion.com>
2403
2404 * ospfd.h: Add new ospf_area structure member for
2405 NSSATranslatorRole and NSSATranslator state.
2406
2407 * ospfd.c: Provided for eventual commands to specify NSSA
2408 elections for "translator- ALWAYS/NEVER/CANDIDATE". Provided for
2409 decimal integer version of area-suppress.
2410
2411 * ospf_flood.c: Flood Type-7's only into NSSA (not AS).
2412
2413 * ospf_lsa.c: Undo some previous changes for NSSA. If NSSA
2414 translator, advertise Nt bit.
2415
2416 * ospf_route.c: 1st version of "sh ip os border-routers".
2417
24182000-11-23 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2419
2420 * ospfd.c (area_vlink): Virtual link can not configured in stub
2421 area.
2422
24232000-11-23 Gleb Natapov <gleb@nbase.co.il>
2424
2425 * ospf_packet.c (ospf_db_desc): In states Loading and Full the
2426 slave must resend its last Database Description packet in response
2427 to duplicate Database Description packets received from the
2428 master. For this reason the slave must wait RouterDeadInterval
2429 seconds before freeing the last Database Description packet.
2430 Reception of a Database Description packet from the master after
2431 this interval will generate a SeqNumberMismatch neighbor
2432 event. RFC2328 Section 10.8
2433 (ospf_make_db_desc): DD Master flag treatment.
2434
2435 * ospf_nsm.c (nsm_twoway_received): Move DD related procedure to
2436 nsm_change_status().
2437 (nsm_bad_ls_req): Likewise.
2438 (nsm_adj_ok): Likewise.
2439 (nsm_seq_number_mismatch): Likewise.
2440 (nsm_oneway_received): Likewise.
2441
2442 * ospf_neighbor.h (struct ospf_neighbor): New structure member
2443 last_send_ts for timestemp when last Database Description packet
2444 was sent.
2445
2446 * ospf_nsm.c (ospf_db_desc_timer): Make it sure nbr->last_send is
2447 there. Call ospf_db_desc_resend() in any case.
2448
24492000-11-16 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2450
2451 * ospf_lsa.c (lsa_link_broadcast_set): When there is no DR on
2452 network (suppose you have only one router with interface priority
2453 0). It's router LSA does not contain the link information about
2454 this network.
2455
2456 * ospf_nsm.c (nsm_timer_set): When you change a priority of
2457 interface from/to 0 ISM_NeighborChange event should be scheduled
2458 in order to elect new DR/BDR on the network.
2459
2460 * ospf_interface.c (ip_ospf_priority): Likewise.
2461
2462 * ospf_flood.c (ospf_ls_retransmit_add): When we add some LSA into
2463 retransmit list we need to check whether the present old LSA in
2464 retransmit list is not more recent than the new
2465 one.
2466
24672000-11-09 Dick Glasspool <dick@ipinfusion.com>
2468
2469 * ospf_packet.c: Allows for NSSA Type-7 LSA's throughout the NSSA
2470 area. Any that exit the NSSA area are translated to type-5 LSA's.
2471 The instantiated image is restored after translation.
2472 (ospf_ls_upd_send_list): Renamed to ospf_ls_upd_queu_send().
2473 (ospf_ls_upd_send): Old function which enclosed by #ifdef 0 is
2474 removed.
2475 (ospf_ls_ack_send): Likewise.
2476
2477 * ospf_flood.c: NSSA-LSA's without P-bit will be restricted to
2478 local area. Otherwise they are allowed out the area to be
2479 translated by ospf_packet.c.
2480
2481 * ospf_lsa.c: Undo some previous changes for NSSA.
2482
2483 * ospf_lsdb.h: New access for type 7.
2484
24852000-11-07 Kunihiro Ishiguro <kunihiro@zebra.org>
2486
2487 * ospf_route.c (ospf_path_exist): New function to check nexthop
2488 and interface are in current OSPF path or not.
2489 (ospf_route_copy_nexthops_from_vertex): Add nexthop to OSPF path
2490 when it is not there. Reported by Michael Rozhavsky
2491 <mrozhavsky@opticalaccess.com>
2492
24932000-11-06 Kunihiro Ishiguro <kunihiro@zebra.org>
2494
2495 * ospf_dump.c (config_write_debug): Add seventh string "detail" is
2496 added for flag is OSPF_DEBUG_SEND | OSPF_DEBUG_RECV |
2497 OSPF_DEBUG_DETAIL.
2498
24992000-11-06 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2500
2501 * ospf_lsa.c (router_lsa_flags): ASBR can't exit in stub area.
2502
25032000-11-06 Kunihiro Ishiguro <kunihiro@zebra.org>
2504
2505 * ospf_lsa.c (ospf_router_lsa_originate): Reduce unconditional
2506 logging.
2507
25082000-11-06 Dick Glasspool <dick@ipinfusion.com>
2509
2510 * ospfd.h: Add ait_ntoa function prototype.
2511
2512 * ospfd.c (ait_ntoa): New function for displaying area ID and
2513 Stub/NSSA status.
2514 (show_ip_ospf_interface_sub): Use ait_ntoa.
2515 (show_ip_ospf_nbr_static_detail_sub): Likewise.
2516 (show_ip_ospf_neighbor_detail_sub): Likewise.
2517
2518 * ospf_route.c (ospf_intra_route_add): Set external routing type
2519 to ospf route.
2520 (ospf_intra_add_router): Likewise.
2521 (ospf_intra_add_transit): Likewise.
2522 (ospf_intra_add_stub): Likewise.
2523 (ospf_add_discard_route): Likewise.
2524 (show_ip_ospf_route_network): Use ait_ntoa.
2525 (show_ip_ospf_route_network): Likewise.
2526 (show_ip_ospf_route_router): Likewise.
2527
2528 * ospf_lsa.c (show_lsa_detail): Use ait_ntoa.
2529 (show_lsa_detail_adv_router): Likewise.
2530 (show_ip_ospf_database_summary): Likewise.
2531
2532 * ospf_route.h (struct route_standard): Add new member
2533 external_routing.
2534
2535 * ospf_ia.c (process_summary_lsa): Set external routing tyep to ospf
2536 route.
2537 (ospf_update_network_route): Likewise.
2538 (ospf_update_router_route): Likewise.
2539
25402000-11-04 Kunihiro Ishiguro <kunihiro@zebra.org>
2541
2542 * ospf_flood.c (ospf_process_self_originated_lsa): Enclose
2543 OSPF_AS_NSSA_LSA treatment with #ifdef HAVE_NSSA.
2544
25452000-11-03 Kunihiro Ishiguro <kunihiro@zebra.org>
2546
2547 * Unconditional logging is enclosed with if (IS_DEBUG_OSPF_EVENT).
2548 Please specify "debug ospf event" for enable logging.
2549
2550 * ospf_ism.c: Do not extern debug flag varible. It is done by
2551 ospf_debug.h
2552 * ospf_asbr.c: Likewise.
2553 * ospf_lsa.c: Likewise.
2554 * ospf_nsm.c: Likewise.
2555 * ospf_zebra.c: Likewise.
2556
2557 * ospf_dump.c (debug_ospf_event): New command "debug ospf event"
2558 is added.
2559
2560 * ospfd.c (router_ospf): Change logging from vty_out() to
2561 zlog_info().
2562 (ospf_area_stub_cmd): Likewise.
2563
2564 * ospf_dump.h: Extern term_debug flags.
2565 (OSPF_DEBUG_EVENT): Add new flag.
2566 (IS_DEBUG_OSPF_EVENT): Add new macro.
2567
25682000-11-03 Dick Glasspool <dick@ipinfusion.com>
2569
2570 * ospf_flood.c (ospf_process_self_originated_lsa):
2571 OSPF_AS_NSSA_LSA is treated as same as OSPF_AS_EXTERNAL_LSA.
2572 (ospf_flood): Type-5's have no change. Type-7's can be received,
2573 and will Flood the AS as Type-5's They will also flood the local
2574 NSSA Area as Type-7's. The LSDB will be updated as Type-5's, and
2575 during re-fresh will be converted back to Type-7's (if within an
2576 NSSA).
2577 (ospf_flood_through): Incoming Type-7's were allowed here if our
2578 neighbor was an NSSA. So Flood our area with the Type-7 and also
2579 if we are an ABR, flood thru AS as Type-5.
2580
2581 * ospf_lsa.c (ospf_external_lsa_refresh): Flood NSSA both NSSA
2582 area and other area.
2583
2584 * ospf_packet.c (ospf_db_desc_proc): When AS External LSA is
2585 exists in DD packet, make it sure that this area is not stub.
2586 (ospf_ls_upd_list_lsa): When LSA type is NSSA then set lsa's area
2587 to NULL.
2588 (ospf_ls_upd): If the LSA is AS External LSA and the area is stub
2589 then discard the lsa. If the LSA is NSSA LSA and the area is not
2590 NSSA then discard the lsa.
2591
25922000-11-03 Kunihiro Ishiguro <kunihiro@zebra.org>
2593
2594 * ospfd.c (ospf_interface_run): Fix bug of Hello packet's option
2595 is not properly set when interface comes up.
2596
25972000-11-02 Kunihiro Ishiguro <kunihiro@zebra.org>
2598
2599 * ospfd.h (OSPF_OPTION_O): Add new hello header option.
2600
26012000-11-01 Dick Glasspool <dick@ipinfusion.com>
2602
2603 * ospf_lsa.h: Define OSPF_MAX_LSA to 8 when HAVE_NSSA is enabled.
2604 (OSPF_GROUP_MEMBER_LSA): Define OSPF_GROUP_MEMBER_LSA.
2605
2606 * ospf_lsa.c (show_database_desc): Add "Group Membership LSA"
2607 string.
2608
26092000-10-31 Dick Glasspool <dick@ipinfusion.com>
2610
2611 * ospf_lsa.h (OSPF_AS_NSSA_LSA): Define OSPF_AS_NSSA_LSA.
2612
2613 * ospf_lsa.c (show_ip_ospf_database): NSSA database display
2614 function is added. ALIASES which have "show ip ospf database
2615 nssa-external" is added.
2616 (show_ip_ospf_border_routers): New command "show ip ospf
2617 border-routers" is added.
2618
26192000-10-30 Dick Glasspool <dick@ipinfusion.com>
2620
2621 * ospfd.c (router_ospf): NSSA Enabled message is added for
2622 testing.
2623 (ospf_area_type_set): Are type set for NSSA area.
2624 (ospf_area_stub_cmd): Special translation of no_summary into NSSA
2625 and summary information. If NSSA is enabled pass the information
2626 to ospf_area_type_set().
2627 (area_nssa): New commands are added:
2628 "area A.B.C.D nssa"
2629 "area <0-4294967295> nssa"
2630 "area A.B.C.D nssa no-summary"
2631 "area <0-4294967295> nssa no-summary"
2632 (ospf_no_area_stub_cmd): Special translation of no_summary into
2633 NSSA and summary information. If external_routing is
2634 OSPF_AREA_NSSA unset area with ospf_area_type_set (area,
2635 OSPF_AREA_DEFAULT).
2636 (show_ip_ospf_area): Display NSSA status.
2637 (config_write_ospf_area): Show NSSA configuration.
2638
2639 * ospf_packet.c (ospf_hello): For NSSA support, ensure that NP is
2640 on and E is off.
2641
26422000-10-26 Gleb Natapov <gleb@nbase.co.il>
2643
2644 * ospf_lsa.c (ospf_network_lsa_body_set): The network-LSA lists
2645 those routers that are fully adjacent to the Designated Router;
2646 each fully adjacent router is identified by its OSPF Router ID.
2647 The Designated Router includes itself in this list. RFC2328,
2648 Section 12.4.2.
2649
26502000-10-23 Jochen Friedrich <jochen@scram.de>
2651
2652 * ospf_snmp.c: ospf_oid and ospfd_oid are used in smux_open after
2653 it is registered. So those variables must be static.
2654
26552000-10-18 K N Sridhar <sridhar@euler.ece.iisc.ernet.in>
2656
2657 * ospfd.c: Add area_default_cost_decimal_cmd and
2658 no_area_default_cost_decimal_cmd alias.
2659
26602000-10-05 Gleb Natapov <gleb@nbase.co.il>
2661
2662 * ospfd.c (ospf_network_new): Fix setting area format.
2663 (no_router_ospf): Check area existance when calling
2664 ospf_interface_down().
2665
2666 * ospf_flood.c (ospf_external_info_check): Fix bug of refreshing
2667 default route.
2668
26692000-10-02 Kunihiro Ishiguro <kunihiro@zebra.org>
2670
2671 * zebra-0.89 is released.
2672
26732000-09-29 Kunihiro Ishiguro <kunihiro@zebra.org>
2674
2675 * ospf_snmp.c (ospfHostEntry): OSPF Host MIB is implemented.
2676
2677 * ospfd.c (ospf_nbr_static_cmp): OSPF neighbor is sorted by it's
2678 address.
2679
26802000-09-28 Michael Rozhavsky <mike@nbase.co.il>
2681
2682 * ospf_interface.c (ospf_if_free): Fix deleting self neighbor twice.
2683
26842000-09-27 Kunihiro Ishiguro <kunihiro@zebra.org>
2685
2686 * ospf_packet.c (ospf_read): Solaris on x86 has ip_len with host
2687 byte order.
2688
26892000-09-25 Toshiaki Takada <takada@zebra.org>
2690
2691 * ospfd.c (ospf_compatible_rfc1583), (no_ospf_compatible_rfc1583):
2692 Add CISCO compatible command.
2693
26942000-09-25 Kunihiro Ishiguro <kunihiro@zebra.org>
2695
2696 * ospf_abr.c (ospf_area_range_lookup): New function is added for
2697 area range lookup in OSPF-MIB.
2698 (ospf_area_range_lookup_next): Likewise.
2699
27002000-09-22 Kunihiro Ishiguro <kunihiro@zebra.org>
2701
2702 * ospfd.c (no_router_ospf): Delete virtual link before deleting
2703 area structure.
2704
2705 * ospf_lsa.c (ospf_external_lsa_refresh_type): Check
2706 EXTERNAL_INFO(type).
2707
2708 * ospfd.c (no_router_ospf): Call ospf_vl_delete() instead of
2709 ospf_vl_data_free().
2710
2711 * ospf_interface.c (ospf_vl_shutdown): Execute ISM_InterfaceDown
2712 when ospf_vl_shutdown is called.
2713 (ospf_vl_delete): Call ospf_vl_shutdown() to delete virtual link
2714 interface's thread.
2715
27162000-09-21 Gleb Natapov <gleb@nbase.co.il>
2717
2718 * ospf_lsa.c: New implementation of OSPF refresh.
2719
27202000-09-20 Kunihiro Ishiguro <kunihiro@zebra.org>
2721
2722 * ospf_snmp.c (ospfLsdbLookup): Add LSDB MIB implementation.
2723
27242000-09-18 Kunihiro Ishiguro <kunihiro@zebra.org>
2725
2726 * ospf_snmp.c (ospfStubAreaEntry): Add OSPF stub area MIB.
2727
27282000-09-18 Gleb Natapov <gleb@nbase.co.il>
2729
2730 * ospf_route.h (route_standard): Change member from `struct area'
2731 to area_id.
2732
2733 * ospf_abr.c (ospf_abr_announce_network), (ospf_abr_should_announce),
2734 (ospf_abr_process_network_rt), (ospf_abr_announce_rtr),
2735 (ospf_abr_process_router_rt):
2736 * ospf_ase.c (ospf_find_asbr_route),
2737 (ospf_find_asbr_router_through_area),
2738 * ospf_ia.c (ospf_find_abr_route), (ospf_ia_router_route),
2739 (process_summary_lsa), (ospf_update_network_route),
2740 (ospf_update_router_route):
2741 * ospf_route.c (ospf_intra_route_add), (ospf_intra_add_router),
2742 (ospf_intra_add_transit), (ospf_intra_add_stub),
2743 (ospf_route_table_dump), (show_ip_ospf_route_network),
2744 (show_ip_ospf_route_router), (ospf_asbr_route_cmp),
2745 (ospf_prune_unreachable_routers):
2746 * ospf_spf.c (ospf_rtrs_print):
2747 * ospfd.c (ospf_rtrs_free): Fix the struct change above.
2748
27492000-09-14 Kunihiro Ishiguro <kunihiro@zebra.org>
2750
2751 * ospf_network.c (ospf_serv_sock_init): Enclose SO_BINDTODEVICE
2752 with ifdef.
2753
27542000-09-13 Gleb Natapov <gleb@nbase.co.il>
2755
2756 * ospf_ism.c (ospf_elect_dr), (ospf_elect_bdr): Fix DR election.
2757
2758 * ospf_network.c (ospf_serv_sock_init): Add socket option
2759 SO_BINDTODEVICE on read socket.
2760
2761 * ospf_packet.c (ospf_hello): Ignore Hello packet if E-bit does
2762 not match.
2763
2764 * ospfd.c (ospf_area_check_free), (ospf_area_get),
2765 (ospf_area_add_if): New function added.
2766
27672000-09-13 Kunihiro Ishiguro <kunihiro@zebra.org>
2768
2769 * ospf_route.c (ospf_intra_add_router): Update ABR and ASBR router
2770 count.
2771
2772 * ospf_spf.c (ospf_spf_init): Rest ABR and ASBR router count
2773 starting SPF calculation.
2774
2775 * ospfd.h (struct ospf_area): Add ABR and ASBR router count.
2776
27772000-09-12 Kunihiro Ishiguro <kunihiro@zebra.org>
2778
2779 * ospfd.c (ospf_area_id_cmp): New area structure is sorted by area
2780 ID.
2781
2782 * ospf_lsa.c (ospf_router_lsa_originate): For OSPF MIB update
2783 lsa_originate_count.
2784 (ospf_network_lsa_originate): Likewise.
2785 (ospf_summary_lsa_originate): Likewise.
2786 (ospf_summary_asbr_lsa_originate): Likewise.
2787 (ospf_external_lsa_originate): Likewise.
2788
27892000-09-11 Kunihiro Ishiguro <kunihiro@zebra.org>
2790
2791 * ospf_snmp.c (ospf_variables): ospfRouterID's type RouterID
2792 syntax is IpAddress.
2793 (ospf_admin_stat): New function for OSPF administrative status
2794 check.
2795
27962000-09-10 Jochen Friedrich <jochen@scram.de>
2797
2798 * ospf_snmp.c: Implement OSPF MIB skeleton.
2799
28002000-09-08 Kunihiro Ishiguro <kunihiro@zebra.org>
2801
2802 * ospf_snmp.c: New file is added.
2803
28042000-09-07 David Lipovkov <davidl@nbase.co.il>
2805
2806 * ospf_zebra.c (ospf_interface_delete): Add pseudo interface
2807 treatment.
2808
2809 * ospf_interface.c (interface_config_write): Likewise.
2810
28112000-08-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2812
2813 * zebra-0.88 is released.
2814
28152000-08-17 Michael Rozhavsky <mike@nbase.co.il>
2816
2817 * ospfd.c (ospf_area_free): Remove virtual link configuration only
2818 when Area is removed.
2819
28202000-08-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2821
2822 * ospfd.c (network_area): Revert check for EXTERNAL_INFO
2823 (ZEBRA_ROUTE_CONNECT).
2824 (no_network_area): Likewise.
2825
28262000-08-16 Kunihiro Ishiguro <kunihiro@zebra.org>
2827
2828 * ospfd.h (struct ospf): Add distance_table and
2829 distance_{all,intra,inter,external}.
2830
2831 * ospf_zebra.c: Add OSPF distance related functions.
2832
28332000-08-15 Gleb Natapov <gleb@nbase.co.il>
2834
2835 * ospf_asbr.c (ospf_external_info_find_lsa): New function added.
2836
2837 * ospf_lsa.c (ospf_default_external_info),
2838 (ospf_default_originate_timer), (ospf_external_lsa_refresh_default):
2839 New function added.
2840
2841 * ospf_zebra.c
2842 (ospf_default_information_originate_metric_type_routemap),
2843 (ospf_default_information_originate_always_metric_type_routemap):
2844 Change name and add route-map function.
2845 (ospf_default_information_originate_metric_routemap),
2846 (ospf_default_information_originate_routemap),
2847 (ospf_default_information_originate_type_metric_routemap):
2848 New DEFUN added.
2849
28502000-08-14 Kunihiro Ishiguro <kunihiro@zebra.org>
2851
2852 * ospf_zebra.c (zebra_interface_if_set_value): Change ifindex
2853 restore size from two octet to four.
2854
28552000-08-14 Michael Rozhavsky <mike@nbase.co.il>
2856
2857 * ospf_ase.c (ospf_ase_incremental_update): Implement incremental
2858 AS-external-LSA in 16.6 of RFC2328.
2859
28602000-08-14 Matthew Grant <grantma@anathoth.gen.nz>
2861
2862 * ospf_interface.c (ospf_if_get_output_cost): Change cost
2863 calculation algorithm.
2864
2865 * ospf_packet (ospf_ls_upd): Fix problem of LSA retransmitting.
2866
28672000-08-11 Michael Rozhavsky <mike@nbase.co.il>
2868
2869 * ospf_lsa.c (ospf_maxage_lsa_remover): Fix maxage remover for
2870 AS-external-LSAs.
2871
28722000-08-10 Toshiaki Takada <takada@zebra.org>
2873
2874 * ospfd.c (auto_cost_reference_bandwidth): New DEFUN added.
2875 `auto-cost reference-bandwidth' OSPF router command added.
2876
28772000-08-08 Gleb Natapov <gleb@nbase.co.il>
2878
2879 * ospf_routemap.c (ospf_route_map_update): New function added.
2880 Add route-map event hook.
2881
28822000-08-08 Toshiaki Takada <takada@zebra.org>
2883
2884 * ospf_zebra.c (ospf_distribute_check_connected): If redistribute
2885 prefix is connected route on OSPF enabled interface, suppress to
2886 announce it.
2887
28882000-08-08 Matthew Grant <grantma@anathoth.gen.nz>
2889
2890 * ospf_interface.c (ospf_if_get_output_cost):
2891 New function added. Handle bandwidth parameter for cost
2892 calculation.
2893
28942000-08-08 Michael Rozhavsky <mike@nbase.co.il>
2895
2896 * ospf_interface.c (interface_config_write): Show interface
2897 configuration regardless interface is down.
2898
2899 * ospf_ase.c (ospf_ase_caocluate_route): Whole rewritten external
2900 route calculate function.
2901
29022000-08-08 Gleb Natapov <gleb@nbase.co.il>
2903
2904 * ospf_routemap.c: New file added.
2905
2906 * ospf_asbr.c (ospf_reset_route_map_set_values),
2907 (ospf_route_map_set_compare): New function added.
2908
2909 * ospf_lsa.c (ospf_external_lsa_body_set): Set routemap metric
2910 with AS-external-LSA.
2911
29122000-08-05 Kunihiro Ishiguro <kunihiro@zebra.org>
2913
2914 * ospf_ase.c (ospf_ase_calculate_route_add): Pass new->cost to
2915 ospf_zebra_add as metric.
2916 (ospf_ase_calculate_route_add): Likewise.
2917
2918 * ospf_route.c (ospf_route_install): Pass or->cost to
2919 ospf_zebra_add as metric.
2920
2921 * ospf_zebra.c (ospf_zebra_add): Add metric arguemnt.
2922 (ospf_zebra_delete): Likewise.
2923
29242000-08-03 Matthew Grant <grantma@anathoth.gen.nz>
2925
2926 * ospf_flood.c (ospf_flood_delayed_lsa_ack): New function added.
2927 Dispatch delayed-ACK with flooding AS-external-LSA across virtual
2928 link.
2929
29302000-07-31 Matthew Grant <grantma@anathoth.gen.nz>
2931
2932 * ospfd.c (show_ip_ospf_area): Fix lack of VTY_NEWLINE when
2933 `show ip ospf'.
2934
2935 * ospf_interface.c (ospf_if_free): Fix bug of crash with
2936 Point-to-Point interface.
2937
29382000-07-27 Michael Rozhavsky <mike@nbase.co.il>
2939
2940 * ospf_flood.c (ospf_process_self_originated_lsa):
2941 Make sure to clear LSA->param (redistributed external information)
2942 before refreshment.
2943
29442000-07-27 Gleb Natapov <gleb@nbase.co.il>
2945
2946 * ospfd.c (refresh_group_limit), (refresh_per_slice),
2947 (refresh_age_diff): New defun added. Refresher related parameter
2948 can be configurable.
2949
29502000-07-27 Akihiro Mizutani <mizutani@dml.com>
2951
2952 * ospf_interface.c (interface_config_write): Print `description'
2953 config directive to work.
2954
29552000-07-24 Akihiro Mizutani <mizutani@dml.com>
2956
2957 * ospf_interface.c (ospf_if_init): Use install_default for
2958 INTERFACE_NODE.
2959
29602000-07-24 Gleb Natapov <gleb@nbase.co.il>
2961
2962 * ospf_packet.c (ospf_ls_upd_send_list), (ospf_ls_upd_send_event),
2963 (ospf_ls_ack_send_list), (ospf_ls_ack_send_event): New function added.
2964 This make sending always as many LS update/Ack combined in one ospf
2965 packet.
2966
29672000-07-24 Gleb Natapov <gleb@nbase.co.il>
2968
2969 * ospf_packet.c (ospf_ls_upd_list_lsa): Set NULL to lsa->area if
2970 LSA is AS-external-LSA.
2971
2972 * ospf_nsm.c (nsm_reset_nbr): Do not cancel Inactivity timer.
2973
29742000-07-21 Toshiaki Takada <takada@zebra.org>
2975
2976 * ospf_zebra.c (ospf_default_originate_timer): Set timer for
2977 `default-information originate'. Fix some default originate
2978 related functions.
2979
29802000-07-12 Toshiaki Takada <takada@zebra.org>
2981
2982 * ospf_lsa.c (stream_put_ospf_metric): New function added.
2983
29842000-07-12 Toshiaki Takada <takada@zebra.org>
2985
2986 * ospf_lsa.c (show_ip_ospf_database_router),
2987 (show_ip_ospf_database_network), (show_ip_ospf_database_summary),
2988 (show_ip_ospf_database_summary_asbr), (show_ip_ospf_database_externel),
2989 (show_router_lsa), (show_any_lsa), (show_router_lsa_self),
2990 (show_any_lsa_self): Functions removed.
2991
2992 (show_lsa_prefix_set), (show_lsa_detail_proc), (show_lsa_detail),
2993 (show_lsa_detail_adv_router_proc), (show_lsa_detail_adv_router):
2994 New functions added. Replace above functions.
2995
2996 (show_ip_ospf_database_all), (show_ip_ospf_database_self_originated):
2997 Functions removed.
2998 (show_ip_ospf_database_summary): New functions added. Replace
2999 above functions.
3000
3001 (show_ip_ospf_database_cmd): DEFUN rearranged.
3002 (show_ip_ospf_database_type_id_cmd),
3003 (show_ip_ospf_database_type_id_adv_router_cmd),
3004 (show_ip_ospf_database_type_is_self_cmd): New ALIASes added.
3005 (show_ip_ospf_database_type_adv_rotuer_cmd): New DEFUN added.
3006 (show_ip_ospf_database_type_self_cmd): New ALIAS added.
3007
30082000-07-11 Toshiaki Takada <takada@zebra.org>
3009
3010 * ospf_asbr.c (ospf_external_info_new),
3011 (ospf_external_info_free): New functions added.
3012
3013 * ospf_lsa.h (ospf_lsa): Add new member `void *param' to set
3014 origination parameter for external-LSA.
3015 Remove member `redistribute'.
3016
3017 * ospf_zebra.c (ospf_redistirbute_set): When `redistribute'
3018 command executed, metric and metric-type values are overridden.
3019 If one of those is changed refresh AS-external-LSAs for appropriate
3020 type.
3021
30222000-07-11 Michael Rozhavsky <mike@nbase.co.il>
3023
3024 * ospf_lsa.c (ospf_summary_lsa_refresh),
3025 (ospf_summary_asbr_lsa_refresh): Make sure to refresh summary-LSAs.
3026
3027 * ospf_abr.c (set_metric): New function added.
3028
30292000-07-07 Toshiaki Takada <takada@zebra.org>
3030
3031 * ospf_zebra.c (ospf_default_information_originate_metric_type),
3032 (ospf_default_information_originate_type_metric): New defun added.
3033 Metic and Metric type can be set to default route.
3034 (ospf_default_information_originate_always_metric_type):
3035 (ospf_default_information_originate_always_type_metric):
3036 New defun added. Metric and Metric type can be set to default
3037 always route.
3038
3039 * ospf_zebra.c (ospf_default_metric), (no_ospf_default_metric):
3040 New defun added.
3041
30422000-07-06 Gleb Natapov <gleb@nbase.co.il>
3043
3044 * ospf_flood.c (ospf_flood_through_area): Fix bug of considering
3045 on the same interface the LSA was received from.
3046
30472000-07-06 Michael Rozhavsky <mike@nbase.co.il>
3048
3049 * ospfd.c (ospf_config_write): Fix bug of printing `area stub'
3050 command with `write mem'.
3051
3052 * ospfd.c (no_router_ospf): Remove installed routes from zebra.
3053
3054 * ospf_zebra.c (ospf_interface_delete): Fix function to handle
3055 zebra interface delete event.
3056
30572000-07-06 Toshiaki Takada <takada@zebra.org>
3058
3059 * ospf_zebra.c (ospf_default_information_originate),
3060 (ospf_default_information_originate_always): New DEFUN added.
3061
30622000-07-05 Michael Rozhavsky <mike@nbase.co.il>
3063
3064 * ospf_route.c (ospf_terminate): Make sure to remove external route
3065 when SIGINT received.
3066
30672000-07-03 Gleb Natapov <gleb@nbase.co.il>
3068
3069 * ospf_flood.c, ospf_ism.c, ospf_lsa,c, ospfd.c: Make sure to free
3070 many structure with `no router ospf'.
3071
30722000-06-30 Gleb Natapov <gleb@nbase.co.il>
3073
3074 * ospf_neighbor.c (ospf_nbr_new),
3075 ospf_nsm.c (nsm_timer_set): Start LS update timer only
3076 when neighbor enters Exchange state.
3077
30782000-06-29 Gleb Natapov <gleb@nbase.co.il>
3079
3080 * ospf_nsm.c (nsm_timer_set), (nsm_exchange_done),
3081 ospf_packet.c (ospf_db_desc_proc):
3082 Do not cancel DD retransmit timer when Master.
3083
30842000-06-29 Gleb Natapov <gleb@nbase.co.il>
3085
3086 * ospf_abr.c (ospf_abr_announce_network_to_area),
3087 (ospf_abr_announce_rtr_to_area)
3088 ospf_ase.c (ospf_ase_rtrs_register_lsa),
3089 ospf_flood.c (ospf_process_self_originated_lsa),
3090 (ospf_flood_through_area), (ospf_ls_request_delete),
3091 ospf_interface.c (ospf_if_free),
3092 ospf_ism.c (ism_change_status),
3093 ospf_lsa.c (ospf_router_lsa_update_timer),
3094 (ospf_router_lsa_install), (ospf_network_lsa_install),
3095 (ospf_lsa_maxage_delete), (ospf_lsa_action),
3096 (ospf_schedule_lsa_flood_area),
3097 ospf_nsm.c (nsm_change_status),
3098 ospf_packet.c (ospf_make_ls_req_func), (ospf_make_ls_ack):
3099 Use ospf_lsa_{lock,unlock} for all looking-up of LSA.
3100
3101 * ospf_flood.c (ospf_ls_request_free): Function deleted.
3102
3103 * ospf_lsa.c (ospf_discard_from_db): New function added.
3104
31052000-06-26 Toshiaki Takada <takada@zebra.org>
3106
3107 * ospfd.h (ospf): struct member `external_lsa' name changed to
3108 `lsdb'.
3109
31102000-06-26 Toshiaki Takada <takada@zebra.org>
3111
3112 * ospf_lsa.c (ospf_lsa_install), (ospf_router_lsa_install),
3113 (ospf_network_lsa_install), (ospf_summary_lsa_install),
3114 (ospf_summary_asbr_lsa_install), (ospf_external_lsa_install):
3115 Functions re-arranged.
3116
3117 * ospf_lsa.c (IS_LSA_MAXAGE), (IS_LSA_SELF): Macro added.
3118
31192000-06-20 Michael Rozhavsky <mike@nbase.co.il>
3120
3121 * ospf_packet.c (ospf_ls_req), (ospf_ls_upd), (ospf_ls_ack): Add
3122 verification of LS type.
3123
31242000-06-20 Gleb Natapov <gleb@nbase.co.il>
3125
3126 * ospf_ase.c (ospf_ase_calculate_timer): Add more sanity check
3127 whether rn->info is NULL.
3128
31292000-06-20 Toshiaki Takada <takada@zebra.org>
3130
3131 * ospfd.c (show_ip_ospf_interface_sub): Show Router-ID of both
3132 DR and Backup correctly with `show ip ospf interface' command.
3133
31342000-06-20 Toshiaki Takada <takada@zebra.org>
3135
3136 * ospf_lsa.c (ospf_lsa_lock), (ospf_lsa_unlock),
3137 (ospf_lsa_discard): These functions are used for avoiding
3138 unexpected reference to freed LSAs.
3139
31402000-06-13 Kunihiro Ishiguro <kunihiro@zebra.org>
3141
3142 * ospf_packet.c (ospf_ls_upd): Initialize lsa by NULL to avoid
3143 warning.
3144
31452000-06-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3146
3147 * ospf_ase.h (ospf_ase_rtrs_register_lsa): Add prototype.
3148
31492000-06-12 Toshiaki Takada <takada@zebra.org>
3150
3151 * ospf_lsa.c (ospf_external_lsa_install): Make sure to register
3152 LSA to rtrs_external when replacing AS-external-LSAs in LSDB.
3153 Fix core dump.
3154
31552000-06-10 Toshiaki Takada <takada@zebra.org>
3156
3157 * ospf_lsdb.c (id_to_prefix), (ospf_lsdb_hash_key),
3158 (ospf_lsdb_hash_cmp), (ospf_lsdb_new), (ospf_lsdb_iterator),
3159 (lsdb_free), (ospf_lsdb_free), (ospf_lsdb_add), (ospf_lsdb_delete),
3160 (find_lsa), (ospf_lsdb_lookup), (find_by_id),
3161 (ospf_lsdb_lookup_by_id), (ospf_lsdb_lookup_by_header): Functinos
3162 removed for migration to new_lsdb.
3163
3164 * ospf_lsa.c (ospf_summary_lsa_install),
3165 (ospf_summary_asbr_lsa_install), (ospf_maxage_lsa_remover),
3166 (ospf_lsa_maxage_walker), (ospf_lsa_lookup),
3167 (ospf_lsa_lookup_by_id): Use new_lsdb instead of ospf_lsdb.
3168 (count_lsa), (ospf_lsa_count_table), (ospf_lsa_count),
3169 (ospf_get_free_id_for_prefix): Funcitions removed.
3170
31712000-06-09 Gleb Natapov <gleb@nbase.co.il>
3172
3173 * ospf_ism.c (ism_interface_down): Prevent some unneeded DR changes.
3174
3175 * ospf_packet.c (ospf_db_desc_proc): Fix memory leak.
3176 (ospf_hello): Always copy router-ID when hello is received.
3177
31782000-06-08 Gleb Natapov <gleb@nbase.co.il>
3179
3180 * ospf_lsa.h (struct ospf_lsa): Add member of pointer to struct
3181 ospf_area.
3182
31832000-06-08 Michael Rozhavsky <mike@nbase.co.il>
3184
3185 * ospf_ase.c (ospf_asbr_route_same): New function added.
3186 This function makes sure external route calculation more
3187 precisely.
3188
31892000-06-07 Michael Rozhavsky <mike@nbase.co.il>
3190
3191 * ospf_ism.c (ism_change_status): Use ospf_lsa_flush_area for
3192 network-LSA deletion instead of using ospf_lsdb_delete.
3193 Also cancel network-LSA origination timer.
3194
31952000-06-07 Levi Harper <lharper@kennedytech.com>
3196
3197 * ospf_interface.c (ospf_if_down): Close read fd when an interface
3198 goes down.
3199
32002000-06-05 Kunihiro Ishiguro <kunihiro@zebra.org>
3201
3202 * ospf_asbr.c (ospf_external_info_lookup): Add explicit brace for
3203 avoid ambiguous else.
3204
3205 * ospf_flood.c (ospf_external_info_check): Likewise.
3206
32072000-06-05 Toshiaki Takada <takada@zebra.org>
3208
3209 * ospf_nsm.c (nsm_adj_ok): Fix bug of DR election.
3210
32112000-06-04 Toshiaki Takada <takada@zebra.org>
3212
3213 * ospf_zebra.c (ospf_default_information_originate),
3214 (no_ospf_default_information_originate): New DEFUN added.
3215
32162000-06-03 Toshiaki Takada <takada@zebra.org>
3217
3218 * ospf_lsa.h, ospf_asbr.h (external_info): Struct moved from
3219 ospf_lsa.h to ospf_asbr.h.
3220
3221 * ospf_lsa.c, ospf_asbr.c (ospf_external_info_add),
3222 (ospf_external_info_delete): Function moved from ospf_lsa.c
3223 to ospf_asbr.c.
3224
32252000-06-03 Toshiaki Takada <takada@zebra.org>
3226
3227 * ospf_flood.c (ospf_external_info_check): New function added.
3228 (ospf_process_self_orignated_lsa): Make sure to flush
3229 self-originated AS-external-LSA, when router reboot and no longer
3230 originate those AS-external-LSA.
3231
32322000-06-02 Toshiaki Takada <takada@zebra.org>
3233
3234 * ospf_network.c (ospf_serv_sock): Remove SO_DONTROUTE
3235 socket option.
3236
3237 * ospf_packet.c (ospf_write): Set MSG_DONTROUTE flag for
3238 unicast destination packets.
3239
32402000-06-02 Toshiaki Takada <takada@zebra.org>
3241
3242 * ospf_lsdb.c (new_lsdb_delete): Delete entry from LSDB only when
3243 specified LSA matches.
3244
32452000-06-02 Gleb Natapov <gleb@nbase.co.il>
3246
3247 * ospf_network.c (ospf_serv_sock): Set SO_DONTROUTE
3248 socket option.
3249
32502000-06-01 Akihiro Mizutani <mizutani@dml.com>
3251
3252 * ospf_dump.c: Replace string `Debugging functions\n' with DEBUG_STR.
3253 Replace string `OSPF information\n' with OSPF_STR.
3254
32552000-06-01 Toshiaki Takada <takada@zebra.org>
3256
3257 * ospf_lsdb.[ch]: Use new_lsdb struct for network-LSA instead of
3258 ospf_lsdb.
3259
32602000-06-01 Toshiaki Takada <takada@zebra.org>
3261
3262 * ospf_dump.c (config_debug_ospf_packet), (config_debug_ospf_event),
3263 (config_debug_ospf_ism), (config_debug_ospf_nsm),
3264 (config_debug_ospf_lsa), (config_debug_ospf_zebra),
3265 (term_debug_ospf_packet), (term_debug_ospf_event),
3266 (term_debug_ospf_ism), (term_debug_ospf_nsm),
3267 (term_debug_ospf_lsa), (term_debug_ospf_zebra): Repalce debug_ospf_*
3268 variable to use for debug option flags.
3269
3270 (debug_ospf_packet), (debug_ospf_ism), (debug_ospf_nsm),
3271 (debug_ospf_lsa), (debug_ospf_zebra): Set {config,term}_debug_*
3272 flags when vty->node is CONFIG_NODE, otherwise set only term_debug_*
3273 flags.
3274
3275 * ospf_dump.h (CONF_DEBUG_PACKET_ON), (CONF_DEBUG_PACKET_OFF),
3276 (TERM_DEBUG_PACKET_ON), (TERM_DEBUG_PACKET_OFF),
3277 (CONF_DEBUG_ON), (CONF_DEBUG_OFF), (IS_CONF_DEBUG_OSPF_PACKET),
3278 (IS_CONF_DEBUG_OSPF): New Macro added.
3279
32802000-05-31 Toshiaki Takada <takada@zebra.org>
3281
3282 * ospfd.c (clear_ip_ospf_neighbor): New DEFUN added.
3283 Currently this command is used for only debugging.
3284
3285 * ospf_nsm.c (nsm_change_status): Make sure thread cancellation
3286 for network-LSA when DR has no full neighbors.
3287
3288 * ospf_nsm.c (ospf_db_summary_clear): New function added.
3289
32902000-05-30 Toshiaki Takada <takada@zebra.org>
3291
3292 * ospf_lsdb.c (new_lsdb_insert): LSAs are always freed by
3293 maxage_lsa_remover when LSA is replaced.
3294
32952000-05-25 Gleb Natapov <gleb@nbase.co.il>
3296
3297 * ospf_flood.c (ospf_ls_retransmit_delete_nbr_all): Add argument
3298 `struct ospf_area' to remove LSA from Link State retransmission list
3299 of neighbor from only one Area.
3300
33012000-05-24 Michael Rozhavsky <mike@nbase.co.il>
3302
3303 * ospf_lsdb.c (ospf_lsdb_add): Preserve flags field when
3304 overriting old LSA with new LSA.
3305
33062000-05-24 Gleb Natapov <gleb@nbase.co.il>
3307
3308 * ospf_lsa.c (ospf_router_lsa_body_set): Fix bug of router-LSA
3309 size calculation.
3310
33112000-05-22 Michael Rozhavsky <mike@nbase.co.il>
3312
3313 * ospf_route.c (ospf_intra_add_stub):
3314 * ospf_spf.h (struct vertex): Use u_int32_t for distance (cost)
3315 value instead of u_int16_t.
3316
33172000-05-22 Axel Gerlach <agerlach@datus.datus.com>
3318
3319 * ospf_ia.c (ospf_ia_network_route): Fix bug of Inter-area route
3320 equal cost path calculation.
3321
33222000-05-21 Toshiaki Takada <takada@zebra.org>
3323
3324 * ospf_ase.c (ospf_ase_calculate_route_delete): New function added.
3325 Make sure, when rotuer route is deleted, related external routes
3326 are also deleted.
3327
33282000-05-20 Toshiaki Takada <takada@zebra.org>
3329
3330 * ospfd.c (ospf_interface_down): Make sure interface flag is disable
3331 and set fd to -1.
3332
33332000-05-16 Toshiaki Takada <takada@zebra.org>
3334
3335 * ospf_asbr.c (ospf_asbr_should_announce), (ospf_asbr_route_remove):
3336 Functions removed.
3337
3338 * ospfd.h (EXTERNAL_INFO): Macro added.
3339 Substitute `ospf_top->external_info[type]' with it.
3340
33412000-05-16 Toshiaki Takada <takada@zebra.org>
3342
3343 * ospf_lsa.c (ospf_rtrs_external_remove): New function added.
3344
33452000-05-14 Gleb Natapov <gleb@nbase.co.il>
3346
3347 * ospf_flood.c (ospf_ls_retransmit_delete_nbr_all)
3348 * ospf_lsdb.c (new_lsdb_insert)
3349 * ospf_packet.c (ospf_ls_ack): Fix database synchonization problem.
3350
33512000-05-14 Gleb Natapov <gleb@nbase.co.il>
3352
3353 * ospf_lsa.h (tv_adjust), (tv_ceil), (tv_floor), (int2tv),
3354 (tv_add), (tv_sub), (tv_cmp): Prototype definition added.
3355
3356 * ospf_nsm.h (ospf_db_summary_delete_all): Prototype definition added.
3357
33582000-05-13 Toshiaki Takada <takada@zebra.org>
3359
3360 * ospf_lsa.[ch] (ospf_lsa): struct timestamp type is changed from
3361 time_t to struct timeval.
3362 (tv_adjust), (tv_ceil), (tv_floor), (int2tv), (tv_add),
3363 (tv_sub), (tv_cmp): timeval utillity functions added.
3364
33652000-05-12 Toshiaki Takada <takada@zebra.org>
3366
3367 * ospf_lsa.[ch] (ospf_schedule_update_router_lsas): Delete function.
3368 Change to use macro OSPF_LSA_UPDATE_TIMER instead of using
3369 this function.
3370 router-LSA refresh timer related stuff is re-organized.
3371
33722000-05-10 Gleb Natapov <gleb@nbase.co.il>
3373
3374 * ospf_interface.c (ospf_vl_set_params):
3375 * ospf_packet.c (ospf_check_network_mask):
3376 * ospf_spf.[ch] (ospf_spf_next):
3377 Remove field address from `struct vertex', and search for peer
3378 address of virtual link in function `ospf_vl_set_params' instead.
3379
33802000-05-10 Gleb Natapov <gleb@nbase.co.il>
3381
3382 * ospf_packet.c (ospf_ls_upd): Fix some memory leak related LSA.
3383
33842000-05-08 Thomas Molkenbur <tmo@datus.com>
3385
3386 * ospf_packet.c (ospf_packet_dup): Replace ospf_steram_copy()
3387 with ospf_stream_dup() to fix memory leak.
3388
33892000-05-08 Michael Rozhavsky <mike@nbase.co.il>
3390
3391 * ospf_flood.c (ospf_flood_through_area): Fix the problem of
3392 LSA update without DROther.
3393
33942000-05-04 Gleb Natapov <gleb@nbase.co.il>
3395
3396 * ospf_spf.c (ospf_vertex_free): Fix memory leak of SPF calculation.
3397
33982000-05-03 Toshiaki Takada <takada@zebra.org>
3399
3400 * ospf_neighbor.c (ospf_db_summary_add): Use new_lsdb struct
3401 instead linked-list.
3402 (ospf_db_summary_count), (ospf_db_summary_isempty):
3403 New function added.
3404
3405 * ospf_lsa.c (ospf_rotuer_lsa): Re-arrange and divide functions.
3406
34072000-05-02 Gleb Natapov <gleb@nbase.co.il>
3408
3409 * ospf_lsdb.c (new_lsdb_cleanup): Fix memory leak. When LSDB are
3410 not needed any more, then free them.
3411
34122000-05-02 Toshiaki Takada <takada@zebra.org>
3413
3414 * ospfd.c (timers_spf), (no_timers_spf): New defun added.
3415 SPF calculation timers related stuff is rearranged.
3416
3417 * ospf_spf.c (ospf_spf_calculate_timer_add): Function removed.
3418 SPF timer is scheduled by SPF calculation delay and holdtime
3419 configuration variable.
3420
3421 * ospf_lsa.c (ospf_external_lsa_nexthop_get): Set AS-external-LSA's
3422 forwarding address when nexthop learned by other protocols is
3423 in the OSPF domain.
3424
3425 * ospf_zebra.c (ospf_redistribute_source_metric_type),
3426 (ospf_redistribute_source_type_metric): Re-arrange DEFUNs and
3427 ALIASes.
3428
34292000-05-01 Toshiaki Takada <takada@zebra.org>
3430
3431 * ospf_flood.c (ospf_ls_retransmit_count),
3432 (ospf_ls_retransmit_isempty): New function added.
3433
3434 (ospf_ls_retransmit_add), (ospf_ls_retransmit_delete),
3435 (ospf_ls_retransmit_clear), (ospf_ls_retransmit_lookup),
3436 (ospf_ls_retransmit_delete_all), (ospf_ls_retransmit_delete_nbr_all),
3437 (ospf_ls_retransmit_add_nbr_all): Replace these functions to use
3438 new_lsdb.
3439
34402000-04-29 Toshiaki Takada <takada@zebra.org>
3441
3442 * ospfd.c (no_network_area): Add check Area-ID whether specified
3443 Area-ID with prefix matches config.
3444
34452000-04-27 Toshiaki Takada <takada@zebra.org>
3446
3447 * ospf_lsa.c (ospf_maxage_lsa_remover): Fix problem of
3448 remaining withdrawn routes on zebra.
3449
34502000-04-25 Michael Rozhavsky <mike@nbase.co.il>
3451
3452 * ospf_nsm.c (nsm_kill_nbr), (nsm_ll_down), (nsm_change_status),
3453 (ospf_nsm_event): Fix network-LSA re-origination problem.
3454
34552000-04-24 Toshiaki Takada <takada@zebra.org>
3456
3457 * ospf_nsm.c (ospf_db_desc_timer): Fix bug of segmentation fault
3458 with DD retransmission.
3459
3460 * ospf_nsm.c (nsm_kill_nbr): Fix bug of re-origination when
3461 a neighbor disappears.
3462
34632000-04-23 Michael Rozhavsky <mike@nbase.co.il>
3464
3465 * ospf_abr.c (ospf_abr_announce_network_to_area): Fix bug of
3466 summary-LSAs reorigination. Correctly copy OSPF_LSA_APPROVED
3467 flag to new LSA. when summary-LSA is reoriginatd.
3468
3469 * ospf_flood.c (ospf_flood_through_area): Fix bug of flooding
3470 procedure. Change the condition of interface selection.
3471
34722000-04-21 Toshiaki Takada <takada@zebra.org>
3473
3474 * ospf_lsa.c (ospf_refresher_register_lsa): Fix bug of refresh never
3475 occurs.
3476
3477 * ospfd.c (show_ip_ospf_neighbor_id): New defun added.
3478 `show ip ospf neighbor' related commands are re-arranged.
3479
34802000-04-20 Toshiaki Takada <takada@zebra.org>
3481
3482 * ospf_dump.c (debug_ospf_zebra): New defun added.
3483 Suppress zebra related debug information.
3484
34852000-04-19 Toshiaki Takada <takada@zebra.org>
3486
3487 * ospf_zebra.c (ospf_distribute_list_update_timer),
3488 (ospf_distribute_list_update), (ospf_filter_update):
3489 New function added. Re-organize `distribute-list' router ospf
3490 command.
3491
34922000-04-13 Michael Rozhavsky <mike@nbase.co.il>
3493
3494 * ospf_packet.c (ospf_make_ls_upd): Add check for MAX_AGE.
3495
34962000-04-14 Michael Rozhavsky <mike@nbase.co.il>
3497
3498 * ospf_packet.c (ospf_make_ls_upd): Increment LS age by configured
3499 interface transmit_delay.
3500
35012000-04-14 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3502
3503 * ospf_interface.c (ip_ospf_cost), (no_ip_ospf_cost):
3504 Add to schedule router_lsa origination when the interface cost changes.
3505
35062000-04-12 Toshiaki Takada <takada@zebra.org>
3507
3508 * ospf_lsa.c (ospf_refresher_register_lsa),
3509 (ospf_refresher_unregister_lsa): Fix bug of core dumped.
3510
3511 * ospfd.c (no_router_ospf): Fix bug of core dumped.
3512
35132000-03-29 Toshiaki Takada <takada@zebra.org>
3514
3515 * ospf_nsm.c (nsm_oneway_received): Fix bug of MS flag unset.
3516
35172000-03-29 Michael Rozhavsky <mike@nbase.co.il>
3518
3519 * ospf_lsa.c (ospf_network_lsa):
3520 * ospf_nsm.c (ospf_nsm_event): Fix bug of Network-LSA originated
3521 in stub network.
3522
35232000-03-28 Toshiaki Takada <takada@zebra.org>
3524
3525 * ospf_nsm.c (nsm_bad_ls_req), (nsm_seq_number_mismatch),
3526 (nsm_oneway_received): Fix bug of NSM state flapping between
3527 ExStart and Exchange.
3528
35292000-03-28 Toshiaki Takada <takada@zebra.org>
3530
3531 * ospf_packet.h (strcut ospf_header): Fix the size of ospf_header,
3532 change u_int8_t to u_char.
3533
35342000-03-27 Toshiaki Takada <takada@zebra.org>
3535
3536 * ospf_lsa.c (ospf_lsa_checksum): Take care of BIGENDIAN architecture.
3537
35382000-03-27 Toshiaki Takada <takada@zebra.org>
3539
3540 * ospfd.c (ospf_interface_run): Make sure Address family matches.
3541
35422000-03-26 Love <lha@s3.kth.se>
3543
3544 * ospf_packet.c (ospf_write): Chack result of sendto().
3545
35462000-03-26 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3547
3548 * ospf_nsm.c (nsm_oneway_received): Fix bug of 1-WayReceived in NSM.
3549
35502000-03-23 Libor Pechacek <farco@clnet.cz>
3551
3552 * ospf_lsa.c (ospf_network_lsa)
3553 * ospf_lsdb.c (new_lsdb_insert): Fix bug of accessing to
3554 unallocated memory.
3555
35562000-03-23 Toshiaki Takada <takada@zebra.org>
3557
3558 * ospfd.c (ospf_config_write): Fix bug of duplicate line for
3559 `area A.B.C.D authentication'.
3560
35612000-03-22 Toshiaki Takada <takada@zebra.org>
3562
3563 * ospf_debug.c (debug_ospf_lsa), (no_debug_ospf_lsa): Defun added.
3564 Suppress all zlog related to LSAs with this config option.
3565
35662000-03-21 Kunihiro Ishiguro <kunihiro@zebra.org>
3567
3568 * ospf_nsm.c (ospf_nsm_event): Add check for NSM_InactivityTimer.
3569
35702000-03-21 Toshiaki Takada <takada@zebra.org>
3571
3572 * ospf_packet.c (ospf_ls_upd_timer), (ospf_ls_req):
3573 Fix bug of memory leak about linklist.
3574
3575 * ospf_flood.c (ospf_flood_through_area): Likewise.
3576
35772000-03-18 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3578
3579 * ospf_flood.c (ospf_ls_retransmit_lookup): Add checksum comparison
3580 to identify LSA uniquely. This fix routes lost.
3581
35822000-03-18 Toshiaki Takada <takada@zebra.org>
3583
3584 * ospf_ase.c (ospf_find_asbr_route): Add sanity check with router
3585 routing table.
3586
35872000-03-17 Alex Zinin <zinin@amt.ru>
3588
3589 * ospf_spf.[ch]: Bug fix.
3590 The 2nd stage of Dijkstra could consider one vertex
3591 more than once if there is more than one link
3592 between the routers, thus adding extra CPU overhead
3593 and extra next-hops.
3594 Fixed.
3595
35962000-03-15 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3597
3598 * ospf_nsm.c (nsm_inactivity_timer): Changed to call nsm_kill_nbr().
3599
36002000-03-14 Toshiaki Takada <takada@zebra.org>
3601
3602 * ospf_route.c (ospf_route_copy_nexthops): Fix bug of memory leak of
3603 ospf_path. Actually ignore merging ospf_route with completely same
3604 paths.
3605
36062000-03-12 Toshiaki Takada <takada@zebra.org>
3607
3608 * ospf_lsa.c (show_as_external_lsa_detail): fix bug of
3609 external route tag byte order.
3610
36112000-03-11 Toshiaki Takada <takada@zebra.org>
3612
3613 * ospf_lsdb.c (ospf_lsdb_insert): New function added.
3614
36152000-03-09 Toshiaki Takada <takada@zebra.org>
3616
3617 * ospf_lsa.c (ospf_external_lsa_install),
3618 (ospf_lsa_lookup), (show_ip_ospf_database_all),
3619 (show_ip_ospf_database_self_originate): Use struct new_lsdb for
3620 LSDB of AS-external-LSAs instead of ospf_lsdb.
3621
3622 * ospf_lsa.c (ospf_lsa_unique_id): New function added.
3623 Use for assigning Unique Link State ID instead of
3624 ospf_get_free_id_for_prefix().
3625
36262000-03-09 Toshiaki Takada <takada@zebra.org>
3627
3628 * ospf_ase.c (ospf_ase_calculate_timer): Fix bug of segmentation
3629 fault reported by George Bonser <george@siteROCK.com>.
3630
36312000-03-07 Libor Pechacek <farco@clnet.cz>
3632
3633 * ospfd.c (ospf_interface_down): Fix bug of segmentation fault.
3634
36352000-03-06 Toshiaki Takada <takada@zebra.org>
3636
3637 * ospf_route.c (ospf_route_cmp): Change meaning of return values.
3638
36392000-03-02 Alex Zinin <zinin@amt.ru>
3640 * ospfd.h, ospf_ia.h
3641 New Shortcut ABR code. Now area's flag can be configured
3642 with Default, Enable, and Disable values.
3643 More info will be in the new ver of I-D soon (see IETF web).
3644
36452000-02-25 Toshiaki Takada <takada@zebra.org>
3646
3647 * ospf_lsa.c (ospf_lsa_header_set), (ospf_external_lsa_body_set),
3648 (osfp_external_lsa_originate), (ospf_external_lsa_queue),
3649 (ospf_external_lsa_originate_from_queue): New function added.
3650 (ospf_external_lsa): Function removed.
3651
3652 * ospf_zebra.c (ospf_zebra_read_ipv4): Originate AS-external-LSA
3653 when listen a route from Zebra, instead creating external route.
3654
3655 * ospf_asbr.c (ospf_asbr_route_add_flood_lsa),
3656 (ospf_asbr_route_add_queue_lsa),
3657 (ospf_asbr_route_install_lsa), (ospf_asbr_route_add):
3658 Functions removed.
3659
3660 * ospf_ase.c (process_ase_lsa): Function will not be used.
3661 (ospf_ase_calculate), (ospf_ase_calculate_route_add),
3662 (ospf_ase_calculate_new_route), (ospf_ase_caluculate_asbr_route):
3663 process_ase_lsa () is separated to these functions.
3664
3665 OSPF AS-external-LSA origination is whole re-organized.
3666
36672000-02-18 Toshiaki Takada <takada@zebra.org>
3668
3669 * ospf_packet.c (ospf_ls_upd): Fix bug of OSPF LSA memory leak.
3670
3671 * ospf_asbr.c (ospf_asbr_route_add_flood_lsa),
3672 (ospf_asbr_route_add_queue_lsa): Fix bug of OSPF external route
3673 memory leak.
3674
36752000-02-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3676
3677 * ospf_asbr.c (ospf_asbr_route_install_lsa): Re-calculate LSA
3678 checksum after change Advertised Router field.
3679
36802000-02-09 Toshiaki Takada <takada@zebra.org>
3681
3682 * ospf_asbr.c (ospf_external_route_lookup): Add new function.
3683
36842000-02-08 Toshiaki Takada <takada@zebra.org>
3685
3686 * ospfd.c (ospf_router_id_get), (ospf_router_id_update),
3687 (ospf_router_id_update_timer): Router ID decision algorithm is changed.
3688 Router ID is chosen from all of eligible interface addresses even if
3689 it is not enable to OSPF.
3690
36912000-02-08 Toshiaki Takada <takada@zebra.org>
3692
3693 * ospf_asbr.c (ospf_asbr_route_add): Function divided to
3694 ospf_asbr_route_add_flood_lsa, ospf_asbr_route_add_queue_lsa and
3695 ospf_asbr_route_install_lsa. If Router-ID is not set, then LSA is
3696 waited to install to LSDB.
3697 `0.0.0.0 adv_router' AS-external-LSA origination bug was fixed.
3698
36992000-02-01 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3700
3701 * ospf_flood.c (ospf_ls_retransmit_lookup): Compare LS seqnum
3702 in the ACK before deleting.
3703
3704 * ospf_packet.c (ospf_hello): Reset the flags after a shutdown
3705 and no shutdown of the interface.
3706
37072000-01-31 Toshiaki Takada <takada@zebra.org>
3708
3709 * ospf_packet.c (ospf_ls_req): Send multiple Link State Update
3710 packets respond to a Link State Request packet.
3711
3712 * ospfd.c (show_ip_ospf_neighbor_detail_sub): Show thread state.
3713
3714 * ospf_interface.c (ospf_vl_new): Crash when backbone area
3715 is not configured and set virtual-link to no-backbone area,
3716 bug fixed.
3717
37182000-01-30 Kunihiro Ishiguro <kunihiro@zebra.org>
3719
3720 * ospf_neighbor.h (struct ospf_neighbor): Add pointer to last send
3721 LS Request LSA.
3722
3723 * ospf_packet.c (ospf_ls_upd): Comment out LS request list
3724 treatment. That should be done in OSPF flooding procedure.
3725
3726 * ospf_flood.c (ospf_flood_through_area): Enclose
3727 ospf_check_nbr_loding inside if-else close.
3728
37292000-01-31 Toshiaki Takada <takada@zebra.org>
3730
3731 * ospf_packet.c (ospf_make_ls_upd): Fix bug of #LSAs counting.
3732
37332000-01-29 Toshiaki Takada <takada@zebra.org>
3734
3735 * ospf_packet.c (ospf_make_md5_digest): Fix bug of md5 authentication.
3736
37372000-01-28 Toshiaki Takada <takada@zebra.org>
3738
3739 * ospfd.c (show_ip_ospf): Show Number of ASE-LSAs.
3740
37412000-01-27 Kunihiro Ishiguro <kunihiro@zebra.org>
3742
3743 * ospf_packet.c (ospf_make_db_desc): Don't use rm_list for
3744 removing LSA from nbr->db_summary.
3745
37462000-01-27 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3747
3748 * ospf_packet.c (ospf_ls_upd_send): Set AllSPFRouters to
3749 destination when the link is point-to-point.
3750 (ospf_ls_ack_send_delayed): Likewise.
3751
37522000-01-27 Kunihiro Ishiguro <kunihiro@zebra.org>
3753
3754 * ospf_flood.c (ospf_ls_request_delete_all): Fix bug of next
3755 pointer lookup after the node is freed.
3756
37572000-01-26 Kunihiro Ishiguro <kunihiro@zebra.org>
3758
3759 * ospf_asbr.c (ospf_asbr_route_add): Instead of scanning all AS
3760 external route, use ospf_top->external_self.
3761
37622000-01-27 Toshiaki Takada <takada@zebra.org>
3763
3764 * ospf_lsa.c (ospf_forward_address_get): New function added.
3765
3766 * ospf_asbr.c (ospf_asbr_check_lsas): Originate AS-external-LSA
3767 only when it should be replaced.
3768
37692000-01-25 Kunihiro Ishiguro <kunihiro@zebra.org>
3770
3771 * ospf_flood.c (ospf_ls_retransmit_clear): Delete list node.
3772
3773 * ospf_lsa.c (ospf_lsa_free): Reduce logging message using
3774 ospf_zlog value.
3775
3776 * ospf_ism.c (ism_change_status): Fix bug of DR -> non DR status
3777 change. Self originated LSA is freed but not deleted from lsdb.
3778
37792000-01-24 Kunihiro Ishiguro <kunihiro@zebra.org>
3780
3781 * ospf_ism.c (ism_interface_down): Don't use router_id for
3782 detecting self neighbor structure. Instead of that compare
3783 pointer itself.
3784
3785 * ospf_neighbor.c (ospf_nbr_free): Cancel all timer when neighbor
3786 is deleted.
3787 (ospf_nbr_free): Free last send packet.
3788
3789 * ospf_neighbor.h (struct ospf_neighbor): Remove host strucutre.
3790 Instead of that src is introduced.
3791
3792 * ospf_nsm.h: Enclose macro defenition with do {} while (0).
3793
37942000-01-17 Kunihiro Ishiguro <kunihiro@zebra.org>
3795
3796 * ospfd.c: Change part of passive interface implementation. For
3797 passive interface just disabling sending/receiving Hello on the
3798 interface.
3799
38002000-01-16 Kai Bankett <kai.bankett@vew-telnet.net>
3801
3802 * ospf_interface.h (OSPF_IF_PASSIVE): Add passive flag.
3803 * ospf_interface.c (ospf_if_lookup_by_name): Add new function.
3804 * ospf_lsa.c (ospf_router_lsa): Skip passive interface.
3805 * ospfd.c (passive_interface): New command passive-interface is
3806 added.
3807 (ospf_config_write): Print passive interface.
3808
38092000-01-15 Toshiaki Takada <takada@zebra.org>
3810
3811 * ospf_interface.h (crypt_key): New struct added to store
3812 multiple cryptographic autheitication keys.
3813 (ospf_interface): struct changed.
3814
3815 * ospf_interface.c: ospf_crypt_key_new, ospf_crypt_key_add,
3816 ospf_crypt_key_lookup, ospf_crypt_key_delete: new functions added.
3817
3818 * ospf_packet.c (ip_ospf_message_digest_key): Changed to store
3819 multiple cryptographic authentication keys.
3820
38212000-01-14 Toshiaki Takada <takada@zebra.org>
3822
3823 * ospf_interface.c: DEFUN (if_ospf_*) commands changed name to
3824 ip_ospf_* ().
3825 Old notation `ospf *' still remains backward compatibility.
3826
38271999-12-29 Alex Zinin <zinin@amt.ru>
3828 * ospf_lsa.c: ospf_lsa_more_recent() bug fix
3829 * ospf_nsm.c, ospf_packet.c: remove nbr data struct when
3830 int goes down, also check DD flags correctly (bug fix)
3831
38321999-12-28 Alex Zinin <zinin@amt.ru>
3833 * "redistribute <source> metric-type (1|2) metric <XXX>" added
3834
38351999-12-23 Alex Zinin <zinin@amt.ru>
3836 * added RFC1583Compatibility flag
3837 * added dynamic interface up/down functionality
3838
38391999-11-19 Toshiaki Takada <takada@zebra.org>
3840
3841 * ospf_neighbor.h (struct ospf_neighbor): Add member state_change
3842 for NSM state change statistics.
3843
38441999-11-19 Toshiaki Takada <takada@zebra.org>
3845
3846 * ospfd.c (show_ip_ospf_neighbor_detail),
3847 (show_ip_ospf_neighbor_int_detail): DEFUN Added.
3848
38491999-11-14 Kunihiro Ishiguro <kunihiro@zebra.org>
3850
3851 * ospf_asbr.c (ospf_asbr_check_lsas): Add check of
3852 lsa->refresh_list.
3853
38541999-11-11 Toshiaki Takada <takada@zebra.org>
3855
3856 * ospf_ia.[ch] (OSPF_EXAMINE_SUMMARIES_ALL): Macro added.
3857 This macro is expanded to ospf_examine_summaries ()
3858 for SUMMARY_LSA and SUMMARY_LSA_ASBR.
3859 (OSPF_EXAMINE_TRANSIT_SUMMARIES_ALL): Macro added.
3860 This macro is expanded to ospf_examine_transit_summaries ()
3861 for SUMMARY_LSA and SUMMARY_LSA_ASBR.
3862
38631999-11-11 Toshiaki Takada <takada@zebra.org>
3864
3865 * ospf_lsa.[ch] (ospf_find_self_summary_lsa_by_prefix): Changed to
3866 macro OSPF_SUMMARY_LSA_SELF_FIND_BY_PREFIX.
3867 (ospf_find_self_summary_asbr_lsa_by_prefix): Changed to
3868 macro OSPF_SUMMARY_ASBR_LSA_SELF_FIND_BY_PREFIX.
3869 (ospf_find_self_external_lsa_by_prefix): Changed to
3870 macro OSPF_EXTERNAL_LSA_SELF_FIND_BY_PREFIX.
3871
38721999-11-11 Toshiaki Takada <takada@zebra.org>
3873
3874 * ospfd.c (ospf_abr_type): ospf_abr_type_cisco, ospf_abr_type_ibm,
3875 ospf_abr_type_shortcut and ospf_abr_type_standard DEFUNs are
3876 combined.
3877 * ospfd.c (no_ospf_abr_type): no_ospf_abr_type_cisco,
3878 no_ospf_abr_type_ibm and no_ospf_abr_type_shortcut DEFUNS are
3879 combined.
3880
38811999-11-10 Toshiaki Takada <takada@zebra.org>
3882
3883 * ospf_route.c (ospf_lookup_int_by_prefix): Move function to
3884 ospf_interface.c and change name to ospf_if_lookup_by_prefix ().
3885
38861999-11-01 Alex Zinin <zinin@amt.ru>
3887 * ospf_packet.c
3888 some correction to LSU processing
3889
3890 * ospf_lsa.c ospfd.h
3891 randomize initial LSA refreshment interval
3892 and limit the size of LSA-group to 10
3893 to let randomization work more effectively.
3894
38951999-10-31 Alex Zinin <zinin@amt.ru>
3896 * ospf_interface.c
3897 cancel t_network_lsa_self
3898 when freeing int structure
3899
3900 * ospf_abr.c ospf_asbr.c ospf_flood.c ospf_lsa.c
3901 ospf_lsa.h ospf_lsdb.h ospfd.c ospfd.h
3902
3903 Summary and ASE LSA refreshment functions
3904 added---LSA refreshment is paced to 70 LSAs
3905 per sec to avoid link overflow. Refreshment events
3906 are further randomized within a 10 sec interval
3907 to avoid syncing.
3908
3909 Also the sigfault of memcmp() in ospf_lsa_is_different()
3910 is fixed.
3911
39121999-10-30 Alex Zinin <zinin@amt.ru>
3913 * ospf_nsm.c
3914 Fix the bug where MAX_AGE LSAs
3915 are included into the DB summary.
3916
3917 * ospf_interface.c
3918 allocate 2*MTU input buffer instead of just MTU
3919 for the cases when the other router mistakenly
3920 sends larger packets thus causing fragmentation, etc.
3921
3922 * ospf_nsm.c
3923 in nsm_reset_nbr() lists should be freed
3924 not when they are empty.
3925
39261999-10-29 Kunihiro Ishiguro <kunihiro@zebra.org>
3927
3928 * ospf_zebra.c (ospf_acl_hook): Move OSPF_IS_ASBR and OSPF_IS_ABR
3929 check inside of if (ospf_top).
3930
39311999-10-29 Alex Zinin <zinin@amt.ru>
3932 * ospf_lsa.c ospf_lsdb.c :
3933 add assertion in lsa and lsa->data alloc functions,
3934 as well as in lsdb_add for new->data
3935
3936 * ospf_lsdb.c: free hash table correctly
3937
39381999-10-28 John Capo <jc@irbs.com>
3939
3940 * ospf_packet.h (OSPF_PACKET_MAX): Correct MAX packet length
3941 calculation
3942
39431999-10-27 Kunihiro Ishiguro <kunihiro@zebra.org>
3944
3945 * OSPF-TRAP-MIB.txt: New file added. Edited version of RFC1850.
3946
3947 * OSPF-MIB.txt: New file added. Edited version of RFC1850.
3948
39491999-10-27 Alex Zinin <zinin@amt.ru>
3950 * ospfd, ospf_zebra, ospf_abr
3951 "area import-list" command is added.
3952 This command allows to filter the inter-area routes
3953 injected into an area. Access list hook function
3954 extended to invalidate area exp/imp lists.
3955
39561999-10-25 Yoshinobu Inoue <shin@nd.net.fujitsu.co.jp>
3957
3958 * ospfd.c (ospf_interface_run): Enable to detect P2P network
3959 on an OSPF interface.
3960
39611999-10-19 Jordan Mendelson <jordy@wserv.com>
3962
3963 * ospf_lsdb.c (ospf_lsdb_add): Fix bug of crash
3964 in ospf_ls_retransmit_lookup ().
3965
39661999-10-19 Vladimir B. Grebenschikov <vova@express.ru>
3967
3968 * ospf_route.c: Workaround about installation of OSPF routes into
3969 the zebra daemon. Add checking of existance routes. Free
3970 ospf_top->old_table if it exists.
3971
39721999-10-15 Jordan Mendelson <jordy@wserv.com>
3973
3974 * Add support for MD5 authentication.
3975
39761999-10-12 Alex Zinin <zinin@amt.ru>
3977 * ospfd.c, ospfd.h, ospf_abr.c:
3978 a new command "area export-list" was added, it allows
3979 the admin. to control which intra-area routes are
3980 announced to other areas by the ABR
3981
39821999-10-12 Alex Zinin <zinin@amt.ru>
3983 * ospf_asbr.c (ospf_asbr_check_lsas): Fix bug of coredump
3984 when "no redistribute" is used after a distribute list
3985 denying some networks was used
3986
39871999-10-05 Toshiaki Takada <takada@zebra.org>
3988
3989 * ospf_route.c (ospf_path_dup): New function added.
3990
39911999-10-05 Toshiaki Takada <takada@zebra.org>
3992
3993 * ospf_interface.[ch]: Some of VL related funciton name changed.
3994
39951999-09-27 Alex Zinin <zinin@amt.ru>
3996
3997 * ospf_zebra.c: Distribute-list functionality added
3998
39991999-09-27 Toshiaki Takada <takada@zebra.org>
4000
4001 * ospfd.c (show_ip_ospf): Fix bug of segmentation fault when no ospf
4002 instance exists.
4003
40041999-09-25 Kunihiro Ishiguro <kunihiro@zebra.org>
4005
4006 * ospfd.c (ospf_interface_down): Fix bug of misusing nextnode()
4007 instead of node->next. Reported by Hiroki Ishibashi
4008 <ishibasi@dcd.abk.nec.co.jp>.
4009
4010 * ospf_route.c (show_ip_ospf_route): Add check for ospf is enabled
4011 or not.
4012
40131999-09-23 Alex Zinin <zinin@amt.ru>
4014
4015 * stub area support added
4016
40171999-09-23 Alex Zinin <zinin@amt.ru>
4018
4019 * fwd_addr in ASE-LSAs is now set correctly
4020 * ASE routing changed to check the fwd_addr
4021 and skip the route if the addr points to one
4022 of our interfaces to avoid loops.
4023
40241999-09-22 Alex Zinin <zinin@amt.ru>
4025
4026 * ospf_interface:
4027 ospf_vls_in_area() added, it returns
4028 the number of VLs configured through the area
4029
4030 * ospf_interface.c ospf_lsa.c ospf_lsdb.c ospfd.c
4031 honor correct mem alloc
4032
40331999-09-22 Alex Zinin <zinin@amt.ru>
4034
4035 * memory.[ch]:
4036 Some OSPF mem types added,
4037 plus more info in "show mem"
4038
40391999-09-21 Alex Zinin <zinin@amt.ru>
4040
4041 * ospfd.c:
4042 "area range substitute" added.
4043 It can be used on NAT-enabled (IP-masquarade)
4044 routers to announce private networks
4045 from an area as public ones into the outside
4046 world (not in the RFC, btw :)
4047
40481999-09-21 Alex Zinin <zinin@amt.ru>
4049
4050 * ospfd.c:
4051 "area range suppress" added.
4052 This command allows to instruct the router
4053 to be silent about specific ranges, i.e.,
4054 it is a method of route filtering on area
4055 borders
4056
40571999-09-21 Alex Zinin <zinin@amt.ru>
4058
4059 * ospfd.c VLs removed when "no network area" executed
4060
40611999-09-20 Alex Zinin <zinin@amt.ru>
4062
4063 * ospf_ase.c bug fix for not-zero fwd_addr
4064 and directly connected routes.
4065
40661999-09-20 Yon Uriarte <yon@plannet.de>
4067
4068 * ospf_packet.c (ospf_make_ls_req): Introduce delta value for
4069 checking the length of OSPF packet exceeds MTU or not.
4070
4071 * ospf_lsa.c (ospf_lsa_different): Apply ntohs for checking
4072 l1->data->length.
4073
40741999-09-18 Alex Zinin <zinin@amt.ru>
4075
4076 * ospf_lsa.c bug fix for ospf_network_lsa() to
4077 include itself into the RID list
4078
40791999-09-10 Alex Zinin <zinin@amt.ru>
4080
4081 * Alternative ABR behaviors IBM/Cisco/Shortcut
4082 implemented
4083
40841999-09-10 Alex Zinin <zinin@amt.ru>
4085
4086 * router and network-LSA origination
4087 changed to honor MinLSInterval
4088
40891999-09-08 Alex Zinin <zinin@amt.ru>
4090
4091 * modified ABR behavior to honor VLs and transit
4092 areas
4093
40941999-09-07 Alex Zinin <zinin@amt.ru>
4095
4096 * completed VL functionality
4097
40981999-09-06 Kunihiro Ishiguro <kunihiro@zebra.org>
4099
4100 * ospf_asbr.c: New file.
4101 ospf_asbr.h: New file.
4102
4103 * ospf_zebra.c (ospf_redistribute_connected): Add redistribute
4104 related stuff.
4105
41061999-09-05 Kunihiro Ishiguro <kunihiro@zebra.org>
4107
4108 * ospfd.h (OSPF_FLAG_VIRTUAL_LINK): Change OSPF_FLAG_VEND to
4109 OSPF_FLAG_VIRTUAL_LINK for comprehensiveness.
4110
41111999-09-03 Kunihiro Ishiguro <kunihiro@zebra.org>
4112
4113 * ospf_spf.c (ospf_spf_register): Change name from
4114 ospf_spf_route_add() to ospf_spf_register().
4115 Include "ospfd/ospf_abr.h" for ospf_abr_task() prototype.
4116
41171999-09-02 Kunihiro Ishiguro <kunihiro@zebra.org>
4118
4119 * ospf_lsa.c (ospf_external_lsa_install): Change to update
4120 lsa->data rather than install new one, when same id lsa is already
4121 installed.
4122
41231999-09-01 Kunihiro Ishiguro <kunihiro@zebra.org>
4124
4125 * ospf_lsa.c (ospf_router_lsa_install): Return lsa value.
4126 (ospf_network_lsa_install): Likewise.
4127 (ospf_summary_lsa_install): Likewise.
4128 (ospf_summary_asbr_lsa_install): Likewise.
4129 (ospf_external_lsa_install): Likewise.
4130
4131 * ospf_spf.c (ospf_spf_calculate): Comment out debug function
4132 ospf_rtrs_print().
4133
41341999-08-31 Kunihiro Ishiguro <kunihiro@zebra.org>
4135
4136 * ospf_spf.c (ospf_rtrs_free): Add ospf_spf_calculate() for
4137 freeing rtrs.
4138
41391999-08-31 Toshiaki Takada <takada@zebra.org>
4140
4141 * ospf_lsa.c (show_ip_ospf_database_summary),
4142 (show_ip_ospf_database_summary_asbr),
4143 (show_ip_ospf_database_external): New function added.
4144 `show ip ospf database summary',
4145 `show ip ospf database asbr-summary'
4146 `show ip ospf database external' command can be used.
4147
4148 * ospf_lsa.c (ospf_lsa_count_table): New function added.
4149 (show_ip_ospf_database_all): show nothing if a type of LSA
4150 does not exist.
4151
41521999-08-31 Kunihiro Ishiguro <kunihiro@zebra.org>
4153
4154 * ospf_lsa.c (ospf_maxage_lsa_remover): Preserve next pointer when
4155 the node is deleted.
4156
41571999-08-31 Toshiaki Takada <takada@zebra.org>
4158
4159 * ospf_flood.c (ospf_ls_retransmit_lookup): change to return
4160 struct ospf_lsa *.
4161 (ospf_ls_request_new), (ospf_ls_request_free),
4162 (ospf_ls_request_add), (ospf_ls_request_delete),
4163 (ospf_ls_request_delete_all), (ospf_ls_request_lookup):
4164 New function added.
4165
4166 * ospf_packet.c (ospf_ls_upd_send_lsa): New function added.
4167
4168 * ospf_lsa.h (LS_AGE): Slightly change macro definition.
4169
4170 * ospf_lsa.c (ospf_lsa_more_recent), (ospf_lsa_diffrent):
4171 Use LS_AGE macro.
4172
41731999-08-30 Alex Zinin <zinin@amt.ru>
4174
4175 * ospfd.c
4176 fix a bug with area range config write
4177 added "show ip ospf" command, it will be enhanced later on
4178
41791999-08-30 Alex Zinin <zinin@amt.ru>
4180
4181 * ospf_lsa.c
4182 updated ospf_router_lsa() to honor flags (B-bit)
4183
41841999-08-30 Alex Zinin <zinin@amt.ru>
4185
4186 * ospf_abr.c
4187 wrote major functions implementing ABR activity
4188
41891999-08-30 Alex Zinin <zinin@amt.ru>
4190
4191 * ospf_ia.c ospf_route.c ospf_route.h
4192 fixed the bug with ospf_route.origin field.
4193 Now it holds pointer to lsa_header
4194
41951999-08-30 Alex Zinin <zinin@amt.ru>
4196
4197 * ospf_flood.c ospf_flood.h:
4198 transformed ospf_flood_if_select into ospf_flood_through_area()
4199 added new ospf_flood_if_select() and ospf_flood_through_as()
4200
42011999-08-30 Toshiaki Takada <takada@zebra.org>
4202
4203 * ospf_flood.[ch]: New file added.
4204
4205 * ospf_packet.c (ospf_lsa_flooding),
4206 (ospf_lsa_flooding_select_if): functions move to ospf_flood.c
4207
4208 * ospf_neighbor.c (ospf_put_lsa_on_retransm_list),
4209 (ospf_remove_lsa_from_retransm_list),
4210 (ospf_nbr_remove_all_lsas_from_retransm_list),
4211 (ospf_lsa_remove_from_ls_retransmit):
4212 (ospf_lsa_retransmit): functions move to
4213 ospf_flood.c, and change function's name:
4214
4215 ospf_put_lsa_on_retransm_list ()
4216 -> ospf_ls_retransmit_add ()
4217 ospf_remove_lsa_from_retransm_list ()
4218 -> ospf_ls_retransmit_delete ()
4219 ospf_nbr_remove_all_lsas_from_retransm_list ()
4220 -> ospf_ls_retransmit_clear ()
4221 ospf_lsa_remove_from_ls_retransmit ()
4222 -> ospf_ls_retransmit_delete_nbr_all ()
4223 ospf_lsa_retransmit ()
4224 -> ospf_ls_retransmit_add_nbr_all ()
4225
4226 * ospf_lsa.c (ospf_lsa_lookup_from_list): function move to
4227 ospf_flood.c, and change name to ospf_ls_retransmit_lookup ().
4228
42291999-08-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4230
4231 * ospf_neighbor.c (ospf_nbr_lookup_by_addr): Use
4232 route_node_lookup() instead of route_node_get().
4233
4234 * ospf_packet.c (ospf_ls_upd): Temporary comment out (6) check.
4235
42361999-08-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4237
4238 * ospf_route.c (ospf_lookup_int_by_prefix): Add check of
4239 oi->address.
4240
42411999-08-29 Alex Zinin <zinin@amt.ru>
4242 * ospf_lsa.c
4243 MaxAge LSA deletion functions added.
4244
42451999-08-29 Alex Zinin <zinin@amt.ru>
4246 * ospf_neighbor.c
4247 ospf_nbr_lookup_by_addr(): added route_unlock_node()
4248 when function returns NULL if (rn->info == NULL)
4249
42501999-08-29 Alex Zinin <zinin@amt.ru>
4251 * ospfd.c
4252 added a hack for area range deletion
4253
42541999-08-29 Alex Zinin <zinin@amt.ru>
4255 * ospf_lsa.h
4256 included lsdb field into struct ospf_lsa, to find
4257 LSDB easier when removing MaxAge LSAs.
4258
42591999-08-29 Alex Zinin <zinin@amt.ru>
4260 * ospf_lsa.c ospf_neighbor.c ospf_nsm.c
4261 ospf_packet.c changed to honor new retransmit list
4262 management functions
4263
42641999-08-29 Alex Zinin <zinin@amt.ru>
4265 * ospf_neighbor.c , .h added new retransmit list functions.
4266
42671999-08-29 Alex Zinin <zinin@amt.ru>
4268 * Makefile.in
4269 added ospf_ase, ospf_abr, ospf_ia
4270
42711999-08-29 Alex Zinin <zinin@amt.ru>
4272 * ospf_spf.c:
4273 - changed ospf_next_hop_calculation() to include interface
4274 and nexthop addr for directly connected routers---more informative
4275 and solves problem with route installation into the kernel
4276 - changed ospf_nexthop_out_if_addr() to support routers, not only
4277 transit networks
4278 - added ospf_process_stubs();
4279
42801999-08-29 Alex Zinin <zinin@amt.ru>
4281 * ospf_lsa.c:
4282 - changed ospf_router_lsa() to provide correct links
4283 for p-t-p interfaces;
4284 - changed ospf_summary_lsa_install() to support table
4285 of self-originated summary-LSAs;
4286 - added ospf_summary_asbr_lsa_install() and ospf_external_lsa_install()
4287 - changed ospf_lsa_install() accordingly
4288 - changed show_ip_ospf_database_router_links() to support p-t-p
4289
42901999-08-29 Kunihiro Ishiguro <kunihiro@zebra.org>
4291
4292 * ospf_packet.c (ospf_make_db_desc): Only master can clear more
4293 flag.
4294
42951999-08-29 Kunihiro Ishiguro <kunihiro@zebra.org>
4296
4297 * ospf_packet.c (ospf_read): Add check of IP src address.
4298
42991999-08-28 Alex Zinin <zinin@amt.ru>
4300 * ospf_neighbor.h
4301 added ospf_nbr_lookup_by_routerid()
4302
43031999-08-28 Alex Zinin <zinin@amt.ru>
4304 * ospfd.h
4305 added ABR/ASBR flag definitions and fields;
4306 added iflist field to area structure;
4307 summary_lsa_self and summary_lsa_asbr_self are changed
4308 to be route tables;
4309 added ranges field---configured area ranges;
4310 A separate Routers RT added;
4311 area range config commands and config write added
4312
4313
43141999-08-28 Alex Zinin <zinin@amt.ru>
4315 * ospf_route.c :
4316 ospf_route_free()--added code to free the list of paths;
4317 The following functions added:
4318 ospf_intra_add_router();
4319 ospf_intra_add_transit();
4320 ospf_intra_add_stub();
4321 the last function uses new ospf_int_lookup_by_prefix();
4322 show_ip_ospf_route_cmd()--changed to support new RT structure;
4323 added ospf_cmp_routes()--general route comparision function;
4324 added ospf_route_copy_nexthops() and ospf_route_copy_nexthops_from_vertex()
4325 they are used in ASE and IA routing;
4326 added ospf_subst_route() and ospf_add_route();
4327
43281999-08-28 Alex Zinin <zinin@amt.ru>
4329 * ospf_route.h :
4330 changed struct ospf_path to include output interface,
4331 changed struct ospf_route to support IA and ASE routing.
4332 added prototypes of the function used in IA and ASE modules.
4333
43341999-08-28 Alex Zinin <zinin@amt.ru>
4335 * ospf_lsa.h ospf_lsa.c :
4336 added ospf_my_lsa(), an interface independent version of
4337 ospf_lsa_is_self_originated(), it will be used in ASE and IA-routing.
4338
43391999-08-27 Kunihiro Ishiguro <kunihiro@zebra.org>
4340
4341 * ospf_interface.c (interface_config_write): Add check for
4342 oi->nbr_self.
4343
43441999-08-25 Toshiaki Takada <takada@zebra.org>
4345
4346 * ospf_lsa.c (ospf_lsa_dup): New function added.
4347
4348 * ospf_packet.c (ospf_write), (ospf_read): Print send/recv
4349 interface in debug message.
4350
43511999-08-25 Toshiaki Takada <takada@zebra.org>
4352
4353 * ospf_packet.c (ospf_ls_ack_send): The name is changed from
4354 `ospf_ls_ack_send'.
4355 (ospf_ls_ack_send_delayed) (ospf_ls_ack_timer): New function added.
4356 Delayed Link State Acknowledgment is scheduled by timer.
4357
43581999-08-25 Alex Zinin <zinin@amt.ru>
4359
4360 * ospf_lsa.c (ospf_router_lsa): Incorrectly included link to
4361 a stub network instead of link to a transit network into
4362 originated router-LSA, bug fixed.
4363
43641999-08-24 Toshiaki Takada <takada@zebra.org>
4365
4366 * ospfd.c (ospf_update_router_id): New function added.
4367
4368 * ospf_network.c (ospf_write): Create new socket per transmission.
4369 And select outgoing interface whether dst is unicast or multicast.
4370
4371 * ospf_packet.c: LSA flooding will work.
4372
43731999-08-24 VOP <vop@unity.net>
4374
4375 * ospf_route.c: Include "sockunion.h"
4376
43771999-08-24 Kunihiro Ishiguro <kunihiro@zebra.org>
4378
4379 * ospf_network.c (ospf_serv_sock_init): Enclose
4380 IPTOS_PREC_INTERNETCONTROL setting with #ifdef for OS which does
4381 not have the definition.
4382
43831999-08-23 Toshiaki Takada <takada@zebra.org>
4384
4385 * ospf_packet.c: Fix bug of DD processing.
4386
43871999-08-18 Toshiaki Takada <takada@zebra.org>
4388
4389 * ospf_lsa.c (show_ip_ospf_database): Show actual `LS age'.
4390
43911999-08-17 Toshiaki Takada <takada@zebra.org>
4392
4393 * ospf_lsa.h (OSPF_MAX_LSA): The value of OSPF_MAX_LSA is
4394 corrected. The bug of `mes_lookup' is fixed.
4395 This had been reported by Poul-Henning Kamp <phk@freebsd.org>.
4396
4397 * ospf_lsa.c (ospf_router_lsa_install): The name is changed from
4398 `ospf_add_router_lsa'.
4399 (ospf_network_lsa_install): The name is changed from
4400 `ospf_add_network_lsa'.
4401
4402 * ospf_interface.h (ospf_interface): Add member `nbr_self'.
4403
4404 * ospf_interface.c (ospf_if_is_enable): New function added.
4405
44061999-08-16 Toshiaki Takada <takada@zebra.org>
4407
4408 * ospf_lsa.h (struct lsa_header): The name is changed from
4409 `struct ospf_lsa'.
4410 (struct ospf_lsa): New struct added to control each LSA's aging
4411 and timers.
4412
4413 * ospf_lsa.c (ospf_lsa_data_free): The name is change from
4414 `ospf_lsa_free'.
4415 (ospf_lsa_data_new), (ospf_lsa_new), (ospf_lsa_free),
4416 (ospf_lsa_different), (ospf_lsa_install): New function added.
4417
4418 * ospf_packet.c (ospf_ls_upd_list_lsa): New function added.
4419
44201999-08-12 Toshiaki Takada <takada@zebra.org>
4421
4422 * ospf_nsm.c (nsm_reset_nbr): New function added.
4423 KillNbr and LLDown neighbor event call this function.
4424
44251999-08-10 Toshiaki Takada <takada@zebra.org>
4426
4427 * ospf_packet.c (ospf_ls_retransmit)
4428 (ospf_ls_upd_timer): New function added.
4429 Set retransmission timer for Link State Update.
4430
44311999-07-29 Toshiaki Takada <takada@zebra.org>
4432
4433 * ospf_ism.c (ospf_dr_election): Fix bug of DR election.
4434
44351999-07-28 Toshiaki Takada <takada@zebra.org>
4436
4437 * ospf_network.c (ospf_serv_sock_init): Set IP precedence field
4438 with IPTOS_PREC_INTERNET_CONTROL.
4439
4440 * ospf_nsm.c (nsm_change_status): Schedule NeighborChange event
4441 if NSM status change.
4442
4443 * ospf_packet.c (ospf_make_hello): Never include a neighbor in
4444 Hello packet, when the neighbor goes down.
4445
44461999-07-26 Kunihiro Ishiguro <kunihiro@zebra.org>
4447
4448 * Makefile.am (noinst_HEADERS): Add ospf_route.h.
4449
4450 * ospf_route.c (show_ip_ospf_route): Add `show ip ospf route'
4451 command.
4452
44531999-07-25 Toshiaki Takada <takada@zebra.org>
4454
4455 * ospf_lsa.c (ospf_router_lsa): Fix bug of LS sequence number
4456 assignement.
4457
44581999-07-25 Kunihiro Ishiguro <kunihiro@zebra.org>
4459
4460 * ospf_route.c (ospf_route_table_free): New function added.
4461
4462 * ospf_spf.c (ospf_spf_next): Free vertex w when cw's and w's
4463 distance is same.
4464
4465 * ospfd.h (struct ospf): Add old_table.
4466
4467 * ospf_main.c (sighup): Call of log_rotate () removed.
4468
4469 * ospf_lsa.c (ospf_lsa_is_self_originated): Fix bug of checking
4470 area->lsa as self LSA. This should be area->lsa_self.
4471
44721999-07-24 Kunihiro Ishiguro <kunihiro@zebra.org>
4473
4474 * ospf_zebra.c (ospf_zebra_add): ospf_zebra_add
4475 (),ospf_zebra_delete () added.
4476
4477 * ospf_spf.c (ospf_spf_calculate): Call ospf_intra_route_add ().
4478
44791999-07-24 Toshiaki Takada <takada@zebra.org>
4480
4481 * ospf_lsa.c: Change LS sequence number treatment.
4482 (ospf_lsa_is_self_originated): New function added.
4483 (show_ip_ospf_database_self_originated): New DEFUN added.
4484
44851999-07-23 Kunihiro Ishiguro <kunihiro@zebra.org>
4486
4487 * ospf_interface.c (ospf_if_lookup_by_addr): Add loopback check.
4488
44891999-07-22 Toshiaki Takada <takada@zebra.org>
4490
4491 * ospf_spf.c (ospf_nexthop_new), (ospf_nexthop_free),
4492 (ospf_nexthop_dup): function added.
4493 (ospf_nexthop_calculation): function changed.
4494
4495 * ospf_interface.c (ospf_if_lookup_by_addr): function added.
4496
44971999-07-21 Toshiaki Takada <takada@zebra.org>
4498
4499 * ospf_spf.c (ospf_spf_closest_vertex): function removed.
4500
45011999-07-21 Kunihiro Ishiguro <kunihiro@zebra.org>
4502
4503 * ospf_spf.c (ospf_spf_next): Apply ntohs for fetching metric.
4504
45051999-07-21 Toshiaki Takada <takada@zebra.org>
4506
4507 * ospf_neighbor.c (ospf_nbr_lookup_by_router_id): fundtion removed.
4508
4509 * ospf_lsa.c (show_ip_ospf_database_router): describe each
4510 connected link.
4511
45121999-07-21 Kunihiro Ishiguro <kunihiro@zebra.org>
4513
4514 * ospf_spf.c (ospf_spf_next): V is router LSA or network LSA so
4515 change behavior according to LSA type.
4516 (ospf_lsa_has_link): Link check function is added.
4517
45181999-07-20 Kunihiro Ishiguro <kunihiro@zebra.org>
4519
4520 * ospf_spf.c (ospf_spf_calculate_schedule): Add new function for
4521 SPF calcultion schedule addtition.
4522 (ospf_spf_calculate_timer_add): Rough 30 sec interval SPF calc
4523 timer is added.
4524 (ospf_spf_next_router): Delete ospf_spf_next_network ().
4525
4526 * ospf_lsa.c (show_ip_ospf_database_all): Network-LSA display
4527 header typo correction. Display of router LSA's #link added.
4528
45291999-07-19 Toshiaki Takada <takada@zebra.org>
4530
4531 * ospf_packet.c (ospf_check_network_mask): Added new function for
4532 receiving Raw IP packet on an appropriate interface.
4533
45341999-07-16 Toshiaki Takada <takada@zebra.org>
4535
4536 * ospfd.c (ospf_router_id): new DEFUN added.
4537
45381999-07-15 Toshiaki Takada <takada@zebra.org>
4539
4540 * ospf_spf.c (ospf_spf_init), (ospf_spf_free),
4541 (ospf_spf_has_vertex), (ospf_vertex_lookup),
4542 (ospf_spf_next_router), (ospf_spf_next_network),
4543 (ospf_spf_closest_vertex), (ospf_spf_calculate):
4544 function added.
4545
45461999-07-13 Toshiaki Takada <takada@zebra.org>
4547
4548 * ospf_ism.c: fix bug of DR Election.
4549
4550 * ospf_nsm.c: fix bug of adjacency forming.
4551
45521999-07-05 Kunihiro Ishiguro <kunihiro@zebra.org>
4553
4554 * ospfd.c (ospf_init): Change to use install_default.
4555
45561999-07-01 Rick Payne <rickp@rossfell.co.uk>
4557
4558 * ospf_zebra.c (zebra_init): Install standard commands to
4559 ZEBRA_NODE.
4560
45611999-06-30 Toshiaki Takada <takada@zebra.org>
4562
4563 * ospf_dump.c: Whole debug command is improved.
4564 (ISM|NSM) (events|status|timers) debug option added.
4565 (show_debugging_ospf): new DEFUN added.
4566
45671999-06-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4568
4569 * ospf_lsa.c (ospf_lsa_lookup_from_list): Change !IPV4_ADDR_CMP to
4570 IPV4_ADDR_SAME.
4571
45721999-06-29 Toshiaki Takada <takada@zebra.org>
4573
4574 * ospf_dump.c (ospf_summary_lsa_dump): Add summary-LSA dump routine.
4575 (ospf_as_external_lsa_dump): Add AS-external-LSA dump routine.
4576
4577 * ospf_nsm.c (nsm_twoway_received): fix condtion of adjacnet.
4578
4579 * ospf_ism.c (ospf_dr_election): fix DR Election.
4580
4581 * ospf_dump.c (ospf_nbr_state_message): fix `show ip ospf neighbor'
4582 command's state.
4583
45841999-06-29 Kunihiro Ishiguro <kunihiro@zebra.org>
4585
4586 * ospf_dump.c (ospf_router_lsa_dump): Add router-LSA dump routine.
4587
45881999-06-28 Toshiaki Takada <takada@zebra.org>
4589
4590 * ospf_lsa.c (show_ip_ospf_database_network): fix bug of
4591 `show ip ospf database network' command output.
4592
4593 * ospf_nsm.c (nsm_inactivity_timer): Clear list of Link State
4594 Retransmission, Database Summary and Link State Request.
4595
4596 * ospf_packet.c (ospf_ls_req_timer): New function added.
4597 Set Link State Request retransmission timer.
4598
45991999-06-27 Kunihiro Ishiguro <kunihiro@zebra.org>
4600
4601 * ospf_main.c (main): Change default output from ZLOG_SYSLOG to
4602 ZLOG_STDOUT.
4603
4604 * ospfd.c (ospf_init): Register show_ip_ospf_interface_cmd and
4605 show_ip_ospf_neighbor_cmd to VIEW_NODE.
4606
4607 * ospf_lsa.c (ospf_lsa_init): Register show_ip_ospf_database_cmd
4608 and show_ip_ospf_database_type_cmd to VIEW_NODE.
4609
46101999-06-25 Toshiaki Takada <takada@zebra.org>
4611
4612 * ospf_packet.c: fix bug of DD making.
4613 fix bug of LS-Update reading.
4614
46151999-06-23 Toshiaki Takada <takada@zebra.org>
4616
4617 * ospf_packet.c: All type of packets are changed to use
4618 fifo queue structure.
4619 (ospf_fill_header) function added.
4620
46211999-06-22 Toshiaki Takada <takada@zebra.org>
4622
4623 * ospf_packet.c (ospf_packet_new): New function added to handle
4624 sending ospf packet by fifo queue structure.
4625 (ospf_packet_free), (ospf_fifo_new), (ospf_fifo_push),
4626 (ospf_fifo_pop), (ospf_fifo_head), (ospf_fifo_flush),
4627 (ospf_fifo_free): Likewise.
4628
46291999-06-21 Toshiaki Takada <takada@zebra.org>
4630
4631 * ospf_nsm.c (ospf_db_desc_timer): function added.
4632 (nsm_timer_set) function added.
4633 * ospf_dump.c (ospf_option_dump): function added.
4634 * ospf_packet.c (ospf_ls_req) (ospf_make_ls_req): function added.
4635
46361999-06-20 Toshiaki Takada <takada@zebra.org>
4637
4638 * ospf_lsa.c (ospf_lsa_more_recent): function added.
4639 * ospf_neighbor.h (struct ospf_neighbor): Change member ms_flag
4640 to dd_flags.
4641
46421999-06-19 Toshiaki Takada <takada@zebra.org>
4643
4644 * ospf_lsa.c: DEFUN (show_ip_ospf_database) Added.
4645 * ospf_interface.c (if_ospf_cost), (if_ospf_dead_interval),
4646 (if_ospf_hello_interval), (if_ospf_priority),
4647 (if_ospf_retransmit_interval), (if_ospf_transmit_delay)
4648 argument changed from NUMBER to <range>.
4649 DEFUN (if_ospf_network_broadcast),
4650 DEFUN (if_ospf_network_non_broadcast),
4651 DEFUN (if_ospf_network_point_to_multipoint),
4652 DEFUN (if_ospf_network_point_to_point) functions are combined to
4653 DEFUN (if_ospf_network).
4654
46551999-06-18 Toshiaki Takada <takada@zebra.org>
4656
4657 * ospf_lsa.c: ospf_add_router_lsa (), ospf_add_network_lsa (),
4658 ospf_lsa_lookup (), ospf_lsa_count () Added.
4659
46601999-06-15 Toshiaki Takada <takada@zebra.org>
4661
4662 * DEFUN (ospf_debug_ism), DEFUN (ospf_debug_nsm),
4663 DEFUN (no_ospf_debug_ism), DEFUN (no_ospf_debug_nsm) Added.
4664 `debug ospf ism' command shows debug message.
4665 `debuf ospf nsm' command shows debug message.
4666
46671999-06-14 Toshiaki Takada <takada@zebra.org>
4668
4669 * ospf_lsa.c: ospf_network_lsa () Added.
4670 ospf_lsa_checksum () Added.
4671 * DEFUN (ospf_debug_packet), DEFUN (no_ospf_debug_packet) Added.
4672 `debug ospf packet' command shows debug message.
4673
46741999-06-13 Toshiaki Takada <takada@zebra.org>
4675
4676 * ospf_packet.h: Remove struct ospf_ls_req {}, ospf_ls_upd {},
4677 ospf_ls_ack {}.
4678
46791999-06-11 Toshiaki Takada <takada@zebra.org>
4680
4681 * ospf_dump.c: fix IP packet length treatment.
4682
46831999-06-10 Toshiaki Takada <takada@zebra.org>
4684
4685 * ospf_ism.h: Add OSPF_ISM_EVENT_EXECUTE() Macro Added.
4686 * ospf_nsm.h: Add OSPF_NSM_EVENT_EXECUTE() Macro Added.
4687
4688 * ospf_packet.c: ospf_db_desc (), ospf_db_desc_send () Added.
4689 ospf_make_hello (), ospf_make_db_desc () Added.
4690 ospf_db_desc_proc () Added.n
4691
4692 * Database Description packet can be processed.
4693
46941999-06-08 Toshiaki Takada <takada@zebra.org>
4695
4696 * ospf_lsa.c: New file.
4697
46981999-06-07 Toshiaki Takada <takada@zebra.org>
4699
4700 * ospf_neighbor.c: ospf_fully_adjacent_count () Added.
4701
47021999-06-07 Kunihiro Ishiguro <kunihiro@zebra.org>
4703
4704 * ospf_spf.[ch]: New file.
4705
47061999-05-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4707
4708 * ospf_zebra.c: Changed to use lib/zclient.c routines.
4709
4710 * ospf_zebra.h (zebra_start): Remove struct zebra.
4711
47121999-05-29 Kunihiro Ishiguro <kunihiro@zebra.org>
4713
4714 * ospfd.c (ospf_config_write): Add cast (unsigned long int) to
4715 ntohl for sprintf warning.
4716
47171999-05-19 Toshiaki Takada <takada@zebra.org>
4718
4719 * ospf_ism.c (ospf_dr_election): Join AllDRouters Multicast group
4720 if interface state changes to DR or BDR.
4721
47221999-05-14 Stephen R. van den Berg <srb@cuci.nl>
4723
4724 * ospf_main.c (signal_init): SIGTERM call sigint.
4725 (sigint): Logging more better message.
4726
47271999-05-12 Toshiaki Takada <takada@zebra.org>
4728
4729 * ospfd.c: Fix bug of `no router ospf' statement, it will work.
4730
47311999-05-11 Toshiaki Takada <takada@zebra.org>
4732
4733 * ospf_neighbor.c: ospf_nbr_free () Added.
4734
47351999-05-10 Toshiaki Takada <takada@zebra.org>
4736
4737 * ospfd.h: struct ospf_area { }, struct ospf_network { } Changed.
4738 * Fix bug of `no network' statement, it will work.
4739
47401999-05-07 Toshiaki Takada <takada@zebra.org>
4741
4742 * ospf_interface.c, ospf_zebra.c: Fix bug of last interface is not
4743 updated by ospf_if_update ().
4744
47451999-04-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4746
4747 * Makefile.am (noinst_HEADERS): Add ospf_lsa.h for distribution.
4748
47491999-04-25 Toshiaki Takada <takada@zebra.org>
4750
4751 * ospf_interface.c: DEFUN (no_if_ospf_cost),
4752 DEFUN (no_if_ospf_dead_interval),
4753 DEFUN (no_if_ospf_hello_interval),
4754 DEFUN (no_if_ospf_priority),
4755 DEFUN (no_if_ospf_retransmit_interval),
4756 DEFUN (no_if_ospf_transmit_delay) Added.
4757
4758 interface_config_write () suppress showing interface
4759 default values.
4760
47611999-04-25 Kunihiro Ishiguro <kunihiro@zebra.org>
4762
4763 * ospf_dump.c (ospf_timer_dump): If thread is NULL return "inactive".
4764
4765 * ospfd.c (ospf_if_update): Fix bug of using ospf_area { } instead
4766 of ospf_network { }. So `router ospf' statement in ospfd.conf
4767 works again.
4768 (ospf_if_update): Call ospf_get_router_id for updating router ID.
4769
47701999-04-25 Toshiaki Takada <takada@zebra.org>
4771
4772 * ospf_interface.c: DEFUN (if_ospf_network) deleted.
4773 DEFUN (if_ospf_network_broadcast),
4774 DEFUN (if_ospf_network_non_broadcast),
4775 DEFUN (if_ospf_network_point_to_multipoint),
4776 DEFUN (if_ospf_network_point_to_point),
4777 DEFUN (no_if_ospf_network) Added.
4778
47791999-04-23 Toshiaki Takada <takada@zebra.org>
4780
4781 * ospfd.h: struct area { } changed to struct ospf_network { }.
4782 Add struct ospf_area { }.
4783 * ospfd.c: Add ospf_area_lookup_by_area_id (), ospf_network_new (),
4784 and ospf_network_free ().
4785 DEFUN (area_authentication), DEFUN (no_area_authentication) Added.
4786
47871999-04-22 Toshiaki Takada <takada@zebra.org>
4788
4789 * ospf_lsa.h: New file.
4790 * ospf_packet.h: LSA related struct definition are moved to
4791 ospf_lsa.h.
4792 * ospf_packet.c: ospf_verify_header () Added.
4793
47941999-04-21 Toshiaki Takada <takada@zebra.org>
4795
4796 * ospf_ism.c: ospf_elect_dr () and related function is changed.
4797 DR Election bug fixed.
4798 * ospf_dump.c: ospf_nbr_state_message (), ospf_timer_dump () Added.
4799 * ospfd.c: DEFUN (show_ip_ospf_neighbor) Added.
4800
48011999-04-19 Kunihiro Ishiguro <kunihiro@zebra.org>
4802
4803 * ospf_main.c (main): access_list_init () is added for vty
4804 connection filtering.
4805
48061999-04-16 Toshiaki Takada <takada@zebra.org>
4807
4808 * ospfd.c: DEFUN (show_ip_ospf_interface) Added.
4809 * ospf_neighbor.c: ospf_nbr_count () Added.
4810
48111999-04-15 Toshiaki Takada <takada@zebra.org>
4812
4813 * ospfd.h: struct ospf { } Changed.
4814 * ospfd.c: ospf_lookup_by_process_id () Deleted.
4815 * ospf_ism.c: ospf_wait_timer () Added. WaitTimer will work.
4816
48171999-04-14 Toshiaki Takada <takada@zebra.org>
4818
4819 * ospf_ism.c: ospf_elect_dr () Added.
4820 * ospf_network.c: ospf_if_ipmulticast () Added.
4821
48221999-04-11 Toshiaki Takada <takada@zebra.org>
4823
4824 * ospf_interface.c: interface_config_write (),
4825 DEFUN (if_ip_ospf_cost),
4826 DEFUN (if_ip_ospf_dead_interval),
4827 DEFUN (if_ip_ospf_hello_interval),
4828 DEFUN (if_ip_ospf_priority),
4829 DEFUN (if_ip_ospf_retransmit_interval) and
4830 DEFUN (if_ip_ospf_transmit_delay) Added.
4831
48321999-04-08 Toshiaki Takada <takada@zebra.org>
4833
4834 * ospf_dump.c: ospf_packet_db_desc_dump () Added.
4835 * ospf_neighbor.c: ospf_nbr_bidirectional () Added.
4836 * ospf_nsm.c: nsm_twoway_received () Added.
4837
48381999-04-02 Toshiaki Takada <takada@zebra.org>
4839
4840 * ospf_neighbor.c: New file.
4841 * ospf_neighbor.h: New file.
4842 * ospf_nsm.c: New file.
4843 * ospf_nsm.h: New file.
4844 * ospf_packet.c: Add ospf_make_header (), ospf_hello () and
4845 ospf_hello_send (). Now OSPFd can receive Hello and send Hello.
4846
48471999-03-27 Kunihiro Ishiguro <kunihiro@zebra.org>
4848
4849 * ospf_packet.c: Add ospf_recv_packet (). Now OSPF Hello can receive.
4850
48511999-03-19 Toshiaki Takada <takada@zebra.org>
4852
4853 * ospf_packet.c: New file.
4854 * ospf_packet.h: New file.
4855 * ospf_network.c: New file.
4856 * ospf_network.h: New file.
4857 * ospfd.h: move OSPF message structure has moved to ospf_packet.h.
4858
48591999-03-17 Kunihiro Ishiguro <kunihiro@zebra.org>
4860
4861 * ospf_zebra.c (ospf_zebra_get_interface): Fix for IPv6 interface
4862 address.
4863
4864 * Makefile.am (install-sysconfDATA): Overwrite install-sysconfDATA
4865 for install ospfd.conf.sample as owner read only file.
4866
4867 * ospf_main.c (usage): Change to use ZEBRA_BUG_ADDRESS.
4868
48691999-03-15 Toshiaki Takada <takada@zebra.org>
4870
4871 * ospf_ism.c: New file.
4872 * ospf_ism.h: New file.
4873 * ospf_dump.c: New file.
4874 * ospf_dump.h: New file.
4875
4876 * ospfd.h: Add (struct ospf), (struct config_network),
4877 (struct message) structure.
4878
4879 * ospf_interface.c: Add ospf_if_match_network ().
4880 * ospf_interface.h (struct ospf_interface): Change struct members.
4881
4882 * ospfd.c: ospf_lookup_by_process_id (), ospf_network_new (),
4883 DEFUN (network_area): Added.
4884
4885 * ospfd.conf.sample: Change sample configuration.
4886
48871999-03-05 Toshiaki Takada <takada@zebra.org>
4888
4889 * ospf_interface.c: New file.
4890 * ospf_interface.h: New file.
4891 * ospf_zebra.h: New file.
4892 * ospf_zebra.c: Add interface function for zebra daemon.
4893 * ospfd.c: New file.
4894
48951999-02-23 Kunihiro Ishiguro <kunihiro@zebra.org>
4896
4897 * Move IPv6 codes and files to ospf6d directory.
4898
48991999-02-18 Peter Galbavy <Peter.Galbavy@knowledge.com>
4900
4901 * syslog support added
4902
49031998-12-22 Toshiaki Takada <takada@zebra.org>
4904
4905 * ospfd.h: New file.
4906 * ospf_lsa.h: New file.
4907
49081998-12-15 Kunihiro Ishiguro <kunihiro@zebra.org>
4909
4910 * Makefile.am: New file.
4911 * ospf_main.c: New file.
4912