blob: d329bfafefe573cb86cf11ff6803a3073884d2d0 [file] [log] [blame]
Andrew J. Schorrf0ec8322007-04-30 16:52:05 +000012007-04-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
2
3 * ospfd.c: (ospf_network_match_iface) Comment out
4 COMPATIBILITY_MODE. Going forward, the ospf "network" command
5 will use a simple test: does the network command prefix
6 contain the connected (destination) prefix of the interface?
7
Andrew J. Schorre8a56f02007-04-21 20:46:31 +000082007-04-21 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
9
10 * ospf_interface.c: (ospf_if_set_multicast) Fix bug: was testing
11 interface passive status improperly in light of the recent
12 'passive-interface default' patch. Now need to test
13 OSPF_IF_PASSIVE_STATUS(oi) instead of
14 OSPF_IF_PARAM(oi, passive_interface).
15
Paul Jakmab75ae992007-03-23 11:17:28 +0000162007-03-23 Paul Jakma <paul.jakma@sun.com>
17
18 * ospf_spf.c: (various) Add more debug statements.
Paul Jakma85ef7842007-03-23 11:19:08 +000019 (ospf_nexthop_calculation) Fix silly regression causing ospfd
20 to fail to calculate paths past networks not attached to root
21 vertex, introduced with bug #330 fixes.
Paul Jakmab75ae992007-03-23 11:17:28 +000022
Andrew J. Schorr56b3ea02007-03-14 20:21:43 +0000232007-03-14 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
24
Andrew J. Schorrad81f8c2007-03-14 22:05:18 +000025 * ospf_snmp.c: (ospf_snmp_neighbor_state) New function to
26 map internal quagga neighbor states to SNMP standard values.
27 (ospfNbrEntry) Call new ospf_snmp_neighbor_state function.
28
292007-03-14 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
30
Andrew J. Schorr56b3ea02007-03-14 20:21:43 +000031 * ospf_zebra.c: (ospf_zebra_add, ospf_zebra_delete) Fix bug
32 where inet_ntoa was used twice in the same debug message,
33 which doesn't work because there's a single shared buffer
34 for the returned string. The fix is to use inet_ntop.
35
Andrew J. Schorr4056a542007-02-27 13:55:46 +0000362007-02-27 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
37
38 * ospfd.c: (ospf_terminate) Exit immediately if ospf is not
39 actually running (e.g. the config file was empty). Fixes
40 bug where SIGTERM would not kill ospfd.
41
Paul Jakmabd34fb32007-02-26 17:14:48 +0000422007-02-26 Paul Jakma <paul.jakma@sun.com>
43
44 * ospf_spf.c: Fix regression introduced with bug #330 fix: The
45 cost update added to ospf_spf_add_parent only handled PtP
46 case, differing from same functionality in higher-level
47 ospf_spf_next. Regression diagnosed by Anders Pedersen,
48 mailnews+router-quagga-dev@news.cohaesio.com.
49 (ospf_vertex_new) Initialise vertices to max-cost.
50 (ospf_spf_init) Root vertex always creates with 0 cost.
51 (ospf_spf_add_parent) Remove the buggy V->W cost calculating
52 code, instead take the new distance as a parameter.
53 (ospf_nexthop_calculation) Take distance as parameter, so it
54 can be passed down to add_parent.
55 (ospf_spf_next) Dont initialise candiate vertex distance,
56 vertex_new does so already. Pass distance down to
57 nexthop_calculation (see above).
58
Paul Jakmabc20c1a2007-01-24 14:51:51 +0000592007-01-24 Paul Jakma <paul.jakma@sun.com>
60
61 * ospf_spf.c: Bug #330: Nexthop calculation sometimes may fail,
62 and it needs to indicate this result to SPF.
63 (ospf_spf_add_parent) Flush of parent list needs to be done here,
64 for simplicity.
65 (ospf_nexthop_calculation) Caller needs to know whether
66 nexthop calculation succeeded. Every return statement must
67 correctly indicate such.
68 (ospf_spf_next) Queueing/prioritisation of vertices in SPF
69 must take into account whether nexthop_calculation succeeded,
70 or SPF may fail to find best paths.
71
Andrew J. Schorre4529632006-12-12 19:18:21 +0000722006-12-12 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
73
74 * ospf_interface.c: (ospf_if_is_configured, ospf_if_lookup_by_prefix,
75 ospf_if_lookup_recv_if) Simplify logic using new CONNECTED_PREFIX
76 macro.
77 * ospf_lsa.c: (lsa_link_ptop_set) Using the new CONNECTED_PREFIX
78 macro, both options collapse into the same code.
79 * ospf_snmp.c: (ospf_snmp_if_update) Simplify logic using new
80 CONNECTED_ID macro.
81 (ospf_snmp_is_if_have_addr) Simplify logic using new CONNECTED_PREFIX
82 macro.
83 * ospf_vty.c: (show_ip_ospf_interface_sub) Use new CONNECTED_PEER macro
84 instead of testing the IFF_POINTOPOINT flag.
85 * ospfd.c: (ospf_network_match_iface) Use new CONNECTED_PEER macro
86 instead of testing with if_is_pointopoint. And add commented-out
87 code to implement alternative (in my opinion) more elegant behavior
88 that has no special-case treatment for PtP addresses.
89 (ospf_network_run) Use new CONNECTED_ID macro to simplify logic.
90
Andrew J. Schorred589c12006-12-04 18:26:37 +0000912006-12-04 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
92
93 * ospfd.c: (ospf_network_run) Remove an offending 'break' statement.
94 Previously, after creating a single ospf_interface on a given
95 network interface, the code would skip to the next interface
96 without considering other connected addresses on the interface.
97 After removing the 'break', we now consider all connected addresses.
98
Andrew J. Schorr7f643eb2006-11-30 16:17:02 +0000992006-11-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
100
101 * ospf_zebra.c: (ospf_router_id_update_zebra,
102 ospf_interface_address_add, ospf_interface_address_delete)
103 If (IS_DEBUG_OSPF (zebra, ZEBRA_INTERFACE)) is enabled, then
104 add a debug message about what Zebra is telling us.
105 (ospf_zebra_add_discard) Add a debug message matching the one
106 already in ospf_zebra_delete_discard.
107
Andrew J. Schorr43540882006-11-28 16:36:39 +00001082006-11-28 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
109
110 * ospf_vty.c: (ospf_passive_interface_default) Take additional
111 'newval' arg so we can update ospf->passive_interface_default inside
112 this function. More importantly, we now call ospf_if_set_multicast
113 on all ospf_interfaces.
114 (ospf_passive_interface, no_ospf_passive_interface) Fix bug:
115 for 'default' case, argv[0] is undefined, so we must test for
116 (argc == 0) before using argv[0]. And since
117 ospf_passive_interface_default now calls ospf_if_set_multicast as
118 needed, we can just return after calling
119 ospf_passive_interface_default.
120
Andrew J. Schorr8fb8a502006-10-24 19:04:26 +00001212006-10-24 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
122
123 * ospf_zebra.c: (ospf_redistribute_default_set) Fix bug where
124 a new value for ospf->default_originate was being ignored
125 if a previous 'default-information originate' command
126 had already been processed.
127
Paul Jakma7ffa8fa2006-10-22 20:07:53 +00001282006-10-22 Yar Tikhiy <yar@comp.chem.msu.su>
129
130 * (general) Add support for passive-interface default (with
131 minor edits by Paul Jakma).
132 * ospf_interface.h: Add OSPF_IF_PASSIVE_STATUS macro, looking
133 at configured value, or the global 'default' value, as
134 required.
135 * ospf_interface.c: (ospf_if_new_hook) Leave passive
136 unconfigured per default, allowing global 'default' to
137 take effect for unconfigured interfaces.
138 * ospf_packet.c: (various) use OSPF_IF_PASSIVE_STATUS
139 * ospf_vty.c: (ospf_passive_interface_default) new function,
140 unset passive from all interfaces if default is enabled, as
141 the per-iface settings become redundant.
142 (ospf_passive_interface_update) new func, update passive
143 setting taking global default into account.
144 ({no,}ospf_passive_interface_addr_cmd) Add support for
145 'default' variant of command.
146 (show_ip_ospf_interface_sub) Update to take global
147 default into account when printing passive status.
148 (ospf_config_write) ditto.
149 * ospfd.c: (ospf_new) set global passive-interface default.
150 * ospfd.h: (struct ospf) Add field for global
151 passive-interface.
152
Andrew J. Schorr08c83672006-09-25 13:26:14 +00001532006-09-25 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
154
155 * ospf_packet.c: (ospf_packet_dup, ospf_make_md5_digest)
156 Fix zlog_warn messages to eliminate compiler warnings.
157 (ospf_hello) Improve warning messages to show why we
158 are complaining.
159
Paul Jakmab5aeb442006-08-30 18:47:37 +00001602006-08-28 Andy Gay <andy@andynet.net>
161
162 * ospf_packet.c: (ospf_make_db_desc) Assert added with More-bit
163 fixes does not hold up with addition of Ogier DB-Exchange
164 optimisation, which can empty the db-summary list in between
165 sent DD packets. Remove assert, update More-bit always when
166 in Exchange.
167
Paul Jakma29b5a042006-08-27 08:01:20 +00001682006-08-27 J.J. Krabbendam <jkrabbendam@aimsys.nl>
169
170 * ospfd.c: (ospf_finish_final) default redistribute should be
171 unset too, fixes bug where reconfiguring ospfd completely
172 can no longer enable default redistribution.
173
Paul Jakma2518efd2006-08-27 06:49:29 +00001742006-08-25 Paul Jakma <paul.jakma@sun.com>
175
176 * (general) Bug #134. Be more robust to backward time changes,
177 use the newly added libzebra time functions.
178 In most cases: recent_time -> recent_relative_time()
179 gettimeofday -> quagga_gettime (QUAGGA_CLK_MONOTONIC, ..)
180 time -> quagga_time.
181 (ospf_make_md5_digest) time() call deliberately not changed.
182 (ospf_external_lsa_refresh) remove useless gettimeofday, LSA
183 tv_orig time was already set in ospf_lsa_new, called via
184 ospf_external_lsa_new.
185
Paul Jakmaba122e72006-08-27 06:24:34 +00001862006-08-04 Paul Jakma <paul.jakma@sun.com>
187
188 * ospf_lsdb.c: (ospf_lsdb_delete_entry) new function, consolidate
189 exact same functionality replicated in other functions.
190 (ospf_lsdb_add) Strip out code by using ospf_lsdb_delete_entry.
191 (ospf_lsdb_delete) ditto.
192 (ospf_lsdb_delete_all) ditto.
193
Paul Jakma8dd24ee2006-08-27 06:29:30 +00001942006-08-03 Paul Jakma <paul.jakma@sun.com>
195
196 * ospf_packet.c: (ospf_make_db_desc) Unset the DD More bit
197 after constructing the packet, if appropriate.
198 (ospf_db_desc_proc) Speed up Exchange, slave should raise
199 ExchangeDone earlier, as RFC mandates, by forming its reply
200 before deciding whether both sides are done, avoids a
201 needless round of empty DD packet exchanges at the end of
202 Exchange, hence speeding up ExchangeDone.
Paul Jakmaf0894cf2006-08-27 06:40:04 +0000203 Implement draft-ogier-ospf-dbex-opt DB-exchange optimisation.
Paul Jakma8dd24ee2006-08-27 06:29:30 +0000204 (ospf_db_desc) use UNSET_FLAG macro.
205
Andrew J. Schorr16700082006-07-27 22:29:06 +00002062006-07-27 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
207
208 * ospfd.c: (ospf_router_id_update) Fix and document the algorithm for
209 selecting the router ID: if there is not a statically configured ID,
210 then stick to the most recent value to avoid disruptive changes.
211 This should fix bug #288.
212
Paul Jakma1fe6ed32006-07-26 09:37:26 +00002132006-07-26 Paul Jakma <paul.jakma@sun.com>
214
215 * ospf_lsa.{c,h}: (ospf_lsa_unlock) Change to take a double pointer
216 to the LSA to be 'unlocked', so that, if the LSA is freed, the
217 callers pointer to the LSA can be NULLed out, allowing any further
218 use of that pointer to provoke a crash sooner rather than later.
219 * ospf_*.c: (general) Adjust callers of ospf_lsa_unlock to match
220 previous. Try annotate 'locking' somewhat to show which 'locks'
221 are protecting what LSA reference, if not obvious.
222 * ospf_opaque.c: (ospf_opaque_lsa_install) Trivial: remove useless
223 goto, replace with return.
224 * ospf_packet.c: (ospf_make_ls_ack) Trivial: merge two list loops,
225 the dual-loop predated the delete-safe list-loop macro.
226
Paul Jakma3fed4162006-07-25 20:44:12 +00002272006-07-25 Paul Jakma <paul.jakma@sun.com>
228
229 * ospf_neigbor.h: (struct ospf_neighbor) Add some additional
230 neighbour state statistics fields, timestamps for progressive
231 and regressive state changes, and pointer to event string
232 for the latter state change.
233 * ospf_nsm.c: (nsm_notice_state_change) Update new state changs
234 history as required.
235 * ospf_vty.c: (show_ip_ospf_neighbor_detail_sub) Print out above
236 new per-neighbour state change stats.
237
Paul Jakma539e1522006-07-11 17:49:22 +00002382006-07-10 Paul Jakma <paul.jakma@sun.com>
239
240 * ospf_nsm.c: (nsm_change_state) call nsm_clear_adj for all
241 adjacency losses, hence removing need for nsm_reset_nbr.
242 (nsm_reset_nbr) kill it, clear_adj in previous does fine.
243 (nsm_kill_nbr,nsm_start) remove nsm_reset_nbr call.
244 (ospf_nsm_event) Allow NSM function to be NULL, this along with
245 removal of nsm_reset_nbr, allows a bunch of now useless functiosn
246 to be removed.
247 Remove some useless variables.
248 (nsm_ignore) now useless, remove.
249 (nsm_bad_ls_req) ditto
250 (nsm_seq_number_mismatch) "
251 (nsm_oneway_received) "
252 (nsm_inactivity_timer) "
253 (nsm_ll_down) "
254 (NSM) replace removed action functions with NULL.
Paul Jakma3d63f382006-07-11 17:52:53 +0000255 (nsm_notice_state_changes) Move state change logging code to new
256 func to declutter nsm_change_state and ospf_nsm_event.
257 Log event with AdjChange, it's useful to know.
258 (nsm_change_state) move adjchange and snmp logging to previous.
259 (ospf_nsm_event) call nsm_notice_state_changes from here.
260 Move the debug message to entry of function, so it gets out
261 even if something goes wrong.
Paul Jakma90c33172006-07-11 17:57:25 +0000262 Record state change timestamp and event in nbr struct.
263 * ospf_neighbor.h: (struct ospf_neighbor) Add fields to record
264 timestamp of last NSM change and event.
265 * ospf_vty.c: (show_ip_ospf_neighbor_detail_sub) Print
266 last state change timestamp and event, if available.
Paul Jakma539e1522006-07-11 17:49:22 +0000267
Andrew J. Schorr13cd3dc2006-07-11 01:50:30 +00002682006-07-10 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
269
270 * ospf_packet.c: (ospf_hello) Improve NetworkMask mismatch warning
271 message to include interface name and conflicting prefix lengths.
272
Paul Jakma1f2c2742006-07-10 07:45:13 +00002732006-07-07 Paul Jakma <paul.jakma@sun.com>
274
275 * ospf_nsm.h: Add a NSM_Deleted neighbour state, to act as dummy
276 state indicating the neighbour is to be deleted.
277 * ospf_nsm.c: (general) Use the NSM_Deleted state to delete
278 neighbours, thus allowing code to be slightly more obvious
279 in its flow.
280 (nsm_timer_set) Add NSM_Deleted. Add another timer the code
281 missed.
282 (nsm_kill_nbr) No need for special case call to nsm_change_state
283 anymore.
284 Make the assert and error-handling for same case more readable
285 (Andrew Schorr)
286 Remove the call to ospf_nbr_delete, nsm_change_state can do
287 this generally now via NSM_Deleted.
288 (struct ... NSM) Add the dummy NSM_Deleted state, the 3 events
289 that can lead to nsm_kill_nbr all now transition the NBR to
290 NSM_Deleted and the general change_state function can be left
291 to do the work.
292 (ospf_nsm_event) Special casing of events and early-return can
293 be removed now.
294 On transition into Deleted, delete the nbr.
295 * ospf_dump.c: (ospf_nsm_state_msg) Add Deleted.
296
Paul Jakmaaa2737a2006-07-06 11:12:39 +00002972006-07-06 Paul Jakma <paul.jakma@sun.com>
298
299 * ospf_nsm.c: (ospf_nsm_event) LLDown event also results in nbr
300 being deleted, requires early-return too. Likely explains
301 some crash reports after interface events.
302
Paul Jakmaf7a76ab2006-07-04 13:57:49 +00003032006-07-04 Paul Jakma <paul.jakma@sun.com>
304
305 * ospf_nsm.c: (general) Various small cleanups from Andrew's
306 review of last set of patches.
307 (nsm_timer_set) Loading, Full and default can share
308 same code too.
309 (nsm_should_adj) Can just be one big OR.
310 (nsm_twoway_received) Collapse into return statement.
311
Paul Jakmad7b0fb62006-07-04 13:35:24 +00003122006-07-02 Paul Jakma <paul.jakma@sun.com>
313
314 * ospf_nsm.c: (nsm_should_adj) New function, just consolidate the
315 10.4 adjacency check from nsm_twoway_received/nsm_adj_ok.
316 (nsm_twoway_received/nsm_adj_ok) Use former.
Paul Jakmad1b1cd82006-07-04 13:50:44 +0000317 (nsm_clear_adj) clear adjacency related state for a
318 neighbour, needed for some state changes from > ExStart down
319 to ExStart or less, which need not go through nsm_reset_nbr.
320 (nsm_reset_nbr) move code to former. Should be static.
Paul Jakmaba0beb42006-07-04 13:44:19 +0000321 (ospf_nsm_event) Don't allow action functions to change
322 next_state if the NSM tables do not indicate next_state is
323 conditional, log warning if one tries - existing code
324 appears fine though.
Paul Jakmad1b1cd82006-07-04 13:50:44 +0000325 Remove long dead code.
326 Use nsm_clear_adj for state changes that take down
327 adjacencies to TwoWay/ExStart.
Paul Jakmae55dd532006-07-04 13:46:14 +0000328 (nsm_timer_set) ls_req timer should be OFF in early states.
329 Compact several identical sections.
330 Set inactivity timer to OFF for Down, for documentary
331 purposes.
Paul Jakmad1b1cd82006-07-04 13:50:44 +0000332 (nsm_kill_nbr) Oops, action function shouldn't try return
333 1 for error.
Paul Jakma5db95bc2006-07-04 13:52:29 +0000334 * ospf_lsa.c: (ospf_translated_nssa_refresh) CID #13.
Paul Jakmad7b0fb62006-07-04 13:35:24 +0000335
Andrew J. Schorr1c066bf2006-06-30 16:53:47 +00003362006-06-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
337
338 * ospf_vty.c: (show_ip_ospf_neighbor_id) Should show all instances
339 of that neighbor (since it may appear on multiple interfaces)
340 instead of bailing out after showing the first match.
341
Andrew J. Schorr76947872006-06-30 03:21:05 +00003422006-06-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
343
344 * ospf_nsm.c: (nsm_twoway_received) When deciding whether to
345 change from state Init to ExStart, the test for whether the
346 neighboring router is DR or BDR should be against the
347 local router's notion of DR/BDR, not the neighbor's view.
348
Andrew J. Schorrd7e60dd2006-06-29 20:20:52 +00003492006-06-28 Erik Muller <erikm@internap.com>
350
351 * ospfd.h: Define 2 new struct ospf config flags:
352 OSPF_LOG_ADJACENCY_CHANGES and OSPF_LOG_ADJACENCY_DETAIL
353 * ospf_nsm.c (nsm_change_state): Log adjacency changes if
354 requested.
355 * ospf_vty.c (ospf_log_adjacency_changes): New command function
356 to implement ospf subcommand "log-adjacency-changes [detail]".
357 (no_ospf_log_adjacency_changes) Turn off log-adjacency-changes.
358 (show_ip_ospf) Show whether adjacency changes are logged.
359 (ospf_config_write) Add "log-adjacency-changes [detail]" to config.
360 (ospf_vty_init) Add ospf_log_adjacency_changes and
361 no_ospf_log_adjacency_changes.
362
Paul Jakma9560fa82006-06-26 12:50:06 +00003632006-06-26 Paul Jakma <paul.jakma@sun.com>
364
365 * ospf_abr.c: (general) NSSA translate-candidate ABRs need to
366 be ASBRs, or other routers may rightfully refuse to install
367 translated type-5s LSAs. reported by dendroot@gmail.com.
368 (ospf_abr_nssa_check_status) Detect change in translator
369 state when ABR, and inc/dec redistribute count as when we
370 leave/enter the disabled state - so that translate-enabled
371 ABR properly sets ASBR bit on non-NSSA areas.
372 Run the resulting function through indent to clean it up.
373 * ospf_lsa.c: (router_lsa_flags) For purposes of ASBR bit,
374 NSSA area is same as stub area.
375
Andrew J. Schorr0ffb7092006-06-24 19:40:13 +00003762006-06-24 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
377
Andrew J. Schorr9aecfae2006-06-24 20:05:02 +0000378 * ospf_snmp.c: (ospfTrapNbrStateChange, ospfTrapIfStateChange) Improve
379 info log message to indicate why the trap is being sent.
380
3812006-06-24 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
382
Andrew J. Schorr0ffb7092006-06-24 19:40:13 +0000383 * ospf_dump.c: (config_write_debug) Fix typo to show debug ospf nsm
384 status properly (not ism status).
385
Andrew J. Schorr6e72cb62006-06-18 00:45:48 +00003862006-06-17 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
387
388 * ospf_vty.c: ({no_,}ospf_passive_interface) Replace if_lookup_by_name
389 with a call to if_get_by_name -- if the interface does not exist
390 already, it should be created. And remove the obsolete warning
391 message.
392
Paul Jakma429ac782006-06-15 18:40:49 +00003932006-06-15 Paul Jakma <paul.jakma@sun.com>
394
395 * ospf_interface.h: (struct ospf_if_info) Add reference counts
396 for multicast group memberships. Add various macros to help
397 manipulate/check membership state.
398 * ospf_interface.c: (ospf_if_set_multicast) Maintain the
399 ospf_if_info reference counts, and only actually drop
400 memberships if it hits 0, to avoid losing membership when
401 OSPF is disabled on an interface with multiple active OSPF
402 interfaces.
403 * ospf_packet.c: (ospf_{hello,read}) Use the new macros to
404 check/set
405 multicast membership.
406 * ospf_vty.c: (show_ip_ospf_interface_sub) ditto.
407
Paul Jakmaac904de2006-06-15 12:04:57 +00004082006-05-31 Paul Jakma <paul.jakma@sun.com>
409
410 * ospf_lsdb.c: (ospf_lsdb_delete) robustify against NULL arguments,
411 print warning.
412 * ospf_lsa.c: (ospf_discard_from_db) ditto.
413 (ospf_maxage_lsa_remover) Check lsa->lsdb for validity, possible
414 mitigation (but not solution) for bug #269.
415
Paul Jakma88871b12006-06-15 11:41:19 +00004162006-05-30 Paul Jakma <paul.jakma@sun.com>
417
418 * ospf_packet.c: (ospf_read) Debug message about packets
419 received on unenabled interfaces should be conditional on
420 debug being set.
421
Paul Jakmad1c65c22006-06-27 08:01:43 +00004222006-05-23 Paul Jakma <paul.jakma@sun.com>
423
424 * ospf_vty.c: (general) Replace in-place route redistribution
425 command and help strings with the new auto-generated defines
426 from lib/route_types.h
427
Paul Jakmaae128052006-05-12 23:15:30 +00004282006-05-13 Paul Jakma <paul.jakma@sun.com>
429
430 * ospf_lsa.c: (ospf_translated_nssa_refresh) fix the sanity
431 check to match the assert, small error in CID #13 fix.
432
Paul Jakma70461d72006-05-12 22:57:57 +00004332006-05-12 Paul Jakma <paul.jakma@sun.com>
434
435 * ospf_lsa.c: (ospf_lsa_action) Get rid of the ospf_lookup
436 call, which is not checked for NULL return, by stripping out
437 functionality which is never used, hence fixing Coverity CID
438 #29.
439 (struct lsa_action) remove unused member.
Paul Jakmae54e6e52006-05-12 23:11:14 +0000440 (ospf_translated_nssa_refresh) Add non-assert sanity check,
441 in case DEBUG isn't defined.
442 Debug message when no type7 exists should print the ID from
443 the type5, not the type7, fixes CID #13.
444 * ospf_interface.c: (ospf_if_exists) Fix missing NULL return
Paul Jakmae43be0e2006-05-12 23:00:06 +0000445 check on ospf_lookup, CID #27.
Paul Jakma6db3a6f2006-05-12 23:02:46 +0000446 * ospf_asbr.c: (ospf_redistribute_withdraw) remove ospf_lookup
447 call by taking the struct ospf * as argument, which the
448 caller has, fixing CID #28.
449 * ospf_asbr.h: (ospf_redistribute_withdraw) update declaration
450 * ospf_zebra.c: (ospf_redistribute_unset) update call to
451 ospf_redistribute_withdraw to match.
Paul Jakmabfd7c7d2006-05-12 23:04:45 +0000452 * ospf_ia.c: (ospf_update_router_route) ospf->backbone could be
453 NULL when passed to ospf_find_asbr_route_through_area,
454 check for NULL first, CID #14.
Paul Jakmadeb15612006-05-12 23:07:27 +0000455 * ospf_ism.c: (ism_change_state) NULL check on oi->area is
456 useless, it's always valid. Only possibility where it
457 couldn't be is if there is a race between abr_task and
458 cleaning up oi's, in which case a NULL check here isn't going
459 to do anything. Fixes CID #15.
Paul Jakma70461d72006-05-12 22:57:57 +0000460
Paul Jakmacac3b5c2006-05-11 13:31:11 +00004612006-05-11 Paul Jakma <paul.jakma@sun.com>
462
463 * ospf_vty.c: (general) Audit ospf_lookup calls in commands,
464 ensure check for NULL result, make vty messages consistent.
465 (show_ip_ospf_interface) Missing NULL check on ospf_lookup
466 result, fixes Coverity CID #70.
Paul Jakma1a8ec2b2006-05-11 13:34:08 +0000467 (no_ospf_area_filter_list) Check NULL result from
468 ospf_area_lookup_by_area_id, fixes Coverity CID #69
Paul Jakma894f8b62006-05-12 22:50:40 +0000469 * ospf_route.c: (ospf_route_delete_same_ext) Fix deref before
470 NULL check by moving into check-protected block, fix CID #49.
Paul Jakma214a4452006-05-12 22:51:49 +0000471 * ospf_abr.c: (ospf_area_range_cost_set) Shouldn't create a new
472 range, should just lookup to see if one exists, the new range
473 is just leaked. Fixes CID #46.
Paul Jakma4021b602006-05-12 22:55:41 +0000474 * ospf_lsa.c: (ospf_default_originate_timer) Let the thread
475 take (struct ospf *) as thread argument, rather than (struct
476 ospf *)->default_originate, thus avoiding having to call
477 ospf_lookup.
478 * ospf_zebra.c: (ospf_redistribute_default_set) change setup
479 of ospf_default_originate_timer thread to match.
480 * ospfd.c: (ospf_router_id_update) ditto.
Paul Jakmacac3b5c2006-05-11 13:31:11 +0000481
Paul Jakma9c27ef92006-05-04 07:32:57 +00004822006-04-24 Paul Jakma <paul.jakma@sun.com>
483
484 * (general) More Virtual-link fixes, again with much help in
485 testing / debug from Juergen Kammer. Primarily in SPF.
486 * ospf_spf.h: Add guard. ospf_interface.h will include this
487 header.
488 * ospf_interface.h: Modify ospf_vl_lookup definition to take
489 struct ospf as argument, so as to allow for NULL area
490 argument.
491 (struct ospf_vl_data) Remove out_oi, instead add a struct
492 vertex_nexthop, to use as initial nexthop for backbone paths
493 through a vlink.
494 * ospf_interface.c: (ospf_vl_lookup) Modified to allow
495 NULL area to be passed to indicate "any" (first) area.
496 Add extra debug.
497 (ospf_vl_set_params) vl_oi -> nexthop. Add extra debug.
498 (ospf_vl_up_check) Fix debug, inet_ntoa returns a static
499 buffer..
500 * ospf_route.c: (ospf_intra_add_router) Vlinks dont go through
501 backbone, don't bother checking.
502 * ospf_spf.c: (static struct list vertex_list) Record vertices
503 that will need to be freed.
504 (cmp) Order network before router vertices, as required,
505 wasn't implemented.
506 (vertex_nexthop_free) Mild additional robustness check.
507 (vertex_parent_free) Take void argument, as this function
508 is passed as list deconstructor for vertex parent list.
509 (ospf_vertex_new) More debug. Set deconstructor for parent
510 list. Track allocated vertices on the vertex_list.
511 (ospf_vertex_free) Get rid of the tricky recursive cleanup of
512 vertices. Now frees only the given vertex.
513 (ospf_vertex_add_parent) Fix assert.
514 (ospf_nexthop_calculation) Fix calculation of nexthop for
515 VLink vertices, lookup the vl_data and use its previously
516 recorded nexthop information.
517 (ospf_spf_calculate) Vertices are freed simply by deleting
518 vertex_list nodes and letting ospf_vertex_free as deconstructor
519 work per-node.
520 (ospf_spf_calculate_timer) Trivial optimisation, leave
521 backbone SPF calculation till last to reduce SPF churn on
522 VLink updates.
523 * ospf_vty.c: (ospf_find_vl_data) update call to ospf_vl_lookup
524 (no_ospf_area_vlink_cmd) ditto.
525 (show_ip_ospf_interface_sub) For Vlinks, the peer address is
526 more interesting than the output interface.
527
Paul Jakma478aab92006-04-03 21:25:32 +00005282006-04-03 Paul Jakma <paul.jakma@sun.com>
529
530 * (general) Fix issues with handling of Vlinks and entries
531 in the nbrs route-table which were highlighted by the
532 nsm/nbr_self fixes from bug #234. Many thanks to Juergen
533 Kammer for his help and efforts in testing out debug patches to
534 pinpoint the issue.
535 * ospf_interface.c: (ospf_vl_new) Add nbr_self for Vlink.
536 * ospf_neighbor.c: (ospf_nbr_key) new static function, helper
537 to create key in nbrs table for a given nbr.
538 (ospf_nbr_delete) Use ospf_nbr_key. Add an assert() to
539 document an expected state.
540 (ospf_nbr_add_self) Ditto.
541 (ospf_nbr_lookup_by_addr) Add an assert.
542 * ospf_nsm.c: (nsm_kill_nbr) Can never kill the nbr_self
543 psuedo-neighbour.
544
Paul Jakma075c2012006-03-30 14:34:31 +00005452006-03-27 Paul Jakma <paul.jakma@sun.com>
546
547 * ospf_lsa.c: (ospf_lsa_checksum) Add an explicit cast to avoid
548 the ambiguities of ANSI and C99 C with respect to type
549 conversion. Detailed problem report and test case with
550 example data supplied by Dmitry Ivanov <dimss@telecentrs.lv>.
551
Paul Jakma1a8ee0e2006-03-30 14:20:00 +00005522006-03-25 Paul Jakma <paul.jakma@sun.com>
553
554 * ospf_interface.c: (ospf_if_lookup_recv_if) Ignore loopbacks,
555 we can never ever receive packets on those. Should fix
556 case where CARP is run with address in same subnet as real
557 interface. Problem report and diagnosis thanks to:
558 Landon Fuller <landonf@opendarwin.org>.
559 However, ospf_read() still can't deal deterministically with
560 multiple interfaces in same subnet.
561
Paul Jakmac2b478d2006-03-30 14:16:11 +00005622006-03-23 Steve Lawson <steve.lawson@aheadcomusa.com>
563
564 * ospf_lsa.c: (ospf_lsa_install) Fix incorrect byte-order
565 conversion of OSPF_MAX_SEQUENCE_NUMBER
566
paule8e19462006-01-19 20:16:55 +00005672006-01-19 Paul Jakma <paul.jakma@sun.com>
568
569 * (general) various miscellaneous compiler warning fixes.
570 Remove redundant break statements from switch clauses
571 which return.
572 return from main, not exit, cause it annoys SOS.
573 Remove stray semi-colons which cause empty-statement
574 warnings.
575
paul779adb02006-01-18 15:07:38 +00005762006-01-18 Juergen Kammer <j.kammer@eurodata.de>
577
578 * ospf_lsa.c: (ospf_router_lsa_new) dont take reference to the
579 stream data until it is constructed, data reference is
580 volatile due to the potential resize in link_info_set
581
5822006-01-18 Paul Jakma <paul.jakma@sun.com>
583
584 * ospf_lsa.c: (link_info_set) Resize the stream if required and
585 possible. Return number of links added.
586 (lsa_link_*_set) use return value from previous.
587 * ospf_lsa.h: Add OSPF_ROUTER_LSA_LINK_SIZE define.
588
paulc6371712006-01-17 17:49:53 +00005892006-01-17 Paul Jakma <paul.jakma@sun.com>
590
591 * ospf_packet.c: (ospf_verify_header) print out the types
592 involved if there's a mismatch.
593 * ospf_zebra.c: (ospf_zebra_add) Adjust to new zserv format.
594
paul818e56c2006-01-10 23:27:05 +00005952006-01-10 Len Sorensen <lennartsorensen@ruggedcom.com>
596
597 * (general) Bug #234, see also [quagga-dev 3902].
598 Fix problem with nbr_self not being properly reinitialised
599 when an interface comes up, after having been down.
paul1a643f82006-01-11 01:08:19 +0000600 Some re-arrangement done by Paul Jakma, any bugs introduced
601 on top of Len's suggested changes are his.
paul818e56c2006-01-10 23:27:05 +0000602 * ospf_neighbor.c: (ospf_nbr_add_self) centralise
603 initialisation of nbr_self parameters here.
604 * ospf_interface.c: (ospf_if_new) deleting initialisation of
605 parameters of nbr_self, just rely on call to
606 ospf_nbr_add_self.
607 (ospf_if_cleanup) ditto.
608 * ospfd.c: (ospf_network_run) ditto.
609
paul98429f62006-01-10 22:11:54 +00006102006-01-10 Juris Kalnins <juris@mt.lv>
611
612 * ospf_zebra.c: (ospf_interface_address_delete) fix rare leak of
613 struct connected in an error case.
paul818e56c2006-01-10 23:27:05 +0000614 * ospf_packet.c: (ospf_make_md5_digest) fix odd, if not
615 undefined effect, assignment of an increment expression.
paul98429f62006-01-10 22:11:54 +0000616
paul86752842006-01-10 20:34:46 +00006172006-01-10 Paul Jakma <paul.jakma@sun.com>
618
619 * ospfd.c: (ospf_network_run) checking to see if router-id
620 is set should be on ospf->router_id, not router_id_static.
621 This was causing ospfd to not start if router-id had not
622 been configured statically.
623 (ospf_if_update) ditto.
paulc42c1772006-01-10 20:36:49 +0000624 * ospf_vty.c: (config_write_ospf_distribute) trim down
625 redundant strings.
paul86752842006-01-10 20:34:46 +0000626
paul00c290e2005-11-26 09:21:43 +00006272005-11-26 Paul Jakma <paul.jakma@sun.com>
628
629 * ospf_api.c: (struct opaque_lsa) change from gcc zero-length
630 array to C99 incomplete type array.
paulc9c93d52005-11-26 13:31:11 +0000631 * (general) s/graceful/deferred/ in all files, the former term
632 is confusing wrt OSPF Graceful-Restart.
633 * ospfd.c: (ospf_deferred_shutdown_check) dont return
634 a function which returns void. SOS complains about this.
635 (ospf_finish)
paul00c290e2005-11-26 09:21:43 +0000636
paulb29800a2005-11-20 14:50:45 +00006372005-11-20 Paul Jakma <paul.jakma@sun.com>
638
639 * ospfd.h: remove the OSPF_ROUTER_ID_UPDATE_DELAY define
640 (struct ospf) remove the router_id timer thread.
641 remove export of ospf_router_id_update_timer.
642 * ospfd.c: (ospf_router_id_update) call ospf_if_update to
643 poke interfaces into action after ID has been configured.
644 (ospf_router_id_update_timer) removed.
645 (ospf_finish_final) t_router_id_update timer is gone.
646 (ospf_network_run) router-id update timer gone.
647 call ospf_router_id_update directly if ID not configured.
648 In the per-iface loop, don't ospf_if_up interfaces if
649 ID is still not configured. The update function will call
650 ospf_if_update anyway.
651 (ospf_if_update) ID update timer is gone. Just return if no
652 ID is set.
653 * ospf_vty.c: (ospf_router_id) call ospf_router_id_update, no
654 timer needed.
655 * ospf_zebra.c: (ospf_router_id_update_zebra) call
656 ospf_router_id_update directly, not via timer.
paulc24d6022005-11-20 14:54:12 +0000657 * ospf_abr.c: (ospf_abr_announce_network_to_area) check
658 returned LSA of ospf_summary_lsa_refresh and print warning if
659 it failed.
660 (ospf_abr_announce_network_to_area) similar
661 (ospf_abr_announce_rtr_to_area) similar
662 * ospf_lsa.c: (ospf_router_lsa_new) check LSA returned is valid.
663 (ospf_router_lsa_originate) similar
664 (ospf_router_lsa_refresh, ospf_network_lsa_new) similar
665 (ospf_summary_lsa_new) Check ID is valid.
666 (ospf_summary_lsa_originate) ditto, and check returned LSA from
667 previous function is !NULL.
668 (ospf_summary_lsa_refresh) check ospf_summary_lsa_new return
669 is !NULL.
670 (ospf_summary_asbr_lsa_new) ID valid check.
671 (ospf_summary_asbr_lsa_originate) similar.
paulb29800a2005-11-20 14:50:45 +0000672
ajs70cd3472005-11-16 19:33:22 +00006732005-11-16 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
674
ajs649654a2005-11-16 20:17:52 +0000675 * ospf_dump.h: Define OSPF_TIME_DUMP_SIZE as appropriate buffer size
676 for use with ospf_timer_dump and ospf_timeval_dump.
677 * ospf_vty.c: Change all buffer sizes used with ospf_timer_dump and
678 ospf_timeval_dump to have size OSPF_TIME_DUMP_SIZE.
679 (show_ip_ospf_interface_sub) Fix possible buffer overflow in
680 call to ospf_timer_dump.
681
6822005-11-16 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
683
ajs70cd3472005-11-16 19:33:22 +0000684 * ospf_ism.h: (OSPF_ISM_TIMER_OFF) Improve macro syntax by enclosing
685 in 'do {...} while(0)'.
686
paul31a59762005-11-14 11:11:11 +00006872005-11-14 Paul Jakma <paul.jakma@sun.com>
688
689 * ospfd.c: (ospf_new) stub-shutdown should just default to
690 unconfigured, too strange otherwise.
691 (ospf_finish_final) t_opaque_lsa_self TIMER_OFF should be
692 preprocessor conditional on HAVE_OPAQUE_LSA.
693 * ospfd.h: (struct ospf) remove the SHUTDOWN_DEFAULT define.
694 no longer used, plus it wasn't in range that the command
695 accepted.
696 * ospf_zebra.h: Depends on vty.h, include it.
697
paul58e1bef2005-11-11 12:10:03 +00006982005-11-11 Paul Jakma <paul.jakma@sun.com>
699
700 * ospf_spf.c: (ospf_canonical_nexthops_free) Free only
701 the nexthops pointing to the root vertex. We may visit a
702 vertex twice or the vertex may have some inherited nexthops,
703 if we free other nexthops we could crash.
704
paulc8c15212005-11-04 12:31:39 +00007052005-11-04 Paul Jakma <paul.jakma@sun.com>
706
707 * ospf_{dump,spf,vty}.c: Oops, use the internal tv_sub
708 function rather than unportable timersub.
709
paul484315f2005-11-03 09:08:29 +00007102005-11-03 Paul Jakma <paul.jakma@sun.com>
711
712 * ospf_apiserver.c: (apiserver_sync_callback) stray semi-colon
713 * ospf_packet.c: include checksum.h, remove the in_cksum extern
714 * prototypes.
715 * ospf_te.h: Add braces, quell warning.
paul6d452762005-11-03 11:15:44 +0000716 * ospf_packet.c: Change level of some warnings to
717 informational.
paulc8c15212005-11-04 12:31:39 +0000718
paul88d6cf32005-10-29 12:50:09 +00007192005-10-29 Paul Jakma <paul.jakma@sun.com>
720
721 * (general) RFC3137 stub-router support
722 * ospfd.h: Add OSPF_OUTPUT_COST_INFINITE define.
723 (struct ospf_master) Add a OSPF_MASTER_SHUTDOWN flag for
724 options, to allow shutdown to distinguish between complete
725 shutdown and shutdown of a subset of ospf instances.
726 (struct ospf)
727 Add stub_router_{startup,shutdown_}time, configuration of startup
728 and shutdown time for stub-router.
729 Add t_graceful_shutdown struct thread, timer for graceful
730 shutdown, if needed.
731 (struct ospf_area) Add stub_router_state - run time state of
732 stub-router for an area. Add flags for ADMIN, IS and WAS
733 states.
734 Add t_stub_router, timer thread to resend router-lsa for an
735 area.
736 * ospf_lsa.c: (ospf_link_cost) new simple function to spit out
737 either the given lnks cost or infinite cost if stub-router is
738 in effect.
739 (lsa_link_{ptop,broadcast,virtuallink,ptomp}_set) use
740 previous function for transit-links.
741 (ospf_stub_router_timer) timer thread for end of startup stub
742 router. Change state as required for the area and setup
743 re-origination of router-lsa.
744 (ospf_stub_router_check) Check/do whether stub-router should be
745 enabled, and whether it requires timer to be setup.
746 (ospf_router_lsa_new) call previous function at top.
747 (ospf_router_lsa_originate) no external callers, made static.
748 * ospf_lsa.h: (ospf_router_lsa_originate) removed.
749 * ospf_main.c: (sigint) make static.
750 remove call to exit, as ospf_terminate now deals with
751 exiting.
752 * ospf_route.c: (ospf_terminate) removed, now in ospfd.c.
753 * ospf_vty.c: (show_ip_ospf_area) print out state of
754 stub-router, if active.
755 (show_ip_ospf) print out configuration of stub-router
756 support, and details of graceful-shutdown if the timer is
757 active.
758 ((no)?ospf_max_metric_router_lsa_{admin,startup,shutdown}) new
759 commands to (de-)?configure stub-router support.
760 (config_write_stub_router) write out config of stub-router.
761 (ospf_config_write) call previous.
762 (ospf_vty_init) install the new stub-router commands.
763 * ospfd.c: various functions made static.
764 (ospf_new) Set defaults for stub-router. Graceful shutdown
765 is made to default on, just to be adventerous.
766 (ospf_graceful_shutdown_finish) new function, final part of
767 shutdown.
768 (ospf_graceful_shutdown_timer) timer thread wrapper for
769 graceful-shutdown.
770 (ospf_graceful_shutdown_check) check whether to setup timer
771 for shutdown or proceed directly to final shutdown.
772 (ospf_terminate) moved here from ospf_route.c, call
773 ospf_finish for each instance.
774 (ospf_finish) renamed to ospf_finish_final and made static.
775 (ospf_finish) new function, exported wrapper around
776 ospf_graceful_shutdown_check.
777 (ospf_finish_final) complete shutdown of an instance.
778 Add missing TIMER_OFF's of two timer threads.
779 (ospf_area_free) opaque self lsa timer should be turned off.
780
paulb8ad39d2005-10-23 15:23:05 +00007812005-10-23 Paul Jakma <paul.jakma@sun.com>
782
paule029d442005-10-23 15:26:24 +0000783 * ospf_apiserver.c: (ospf_apiserver_term) This function should
784 not have side-effects (eg segv) if no apiserver instances are
785 active, ie be robust.
paulb8ad39d2005-10-23 15:23:05 +0000786 * ospf_vty.c: (show_ip_ospf) fix display of SPF timer if it
787 has not yet been run.
788
paulf9ad9372005-10-21 00:45:17 +00007892005-10-21 Paul Jakma <paul.jakma@sun.com>
790
paulea4ffc92005-10-21 20:04:41 +0000791 * ospf_dump.c: (ospf_timeval_dump) fix ms adjustment, thanks to
792 Andrew Schorr.
793 * ospf_vty.c: (ospf_config_write) fix write out of spf timers
794 configuration.
795
7962005-10-21 Paul Jakma <paul.jakma@sun.com>
797
pauld24f6e22005-10-21 09:23:12 +0000798 * (general) SPF millisecond resolution timer with adaptive,
799 linear back-off holdtime. Prettification of ospf_timer_dump.
800 * ospf_dump.c: (ospf_timeval_dump) new function. The guts of
801 ospf_timer_dump, but made to be more dynamic in printing out
802 the relative timeval, sliding the precision printed out
803 according to the value.
804 (ospf_timer_dump) guts moved to ospf_timeval_dump.
805 * ospf_dump.h: export ospf_timeval_dump.
806 * ospf_flood.c: (ospf_flood) remove gettimeofday, use
807 the libzebra exported recent_time instead, as it's not
808 terribly critical to have time exactly right - the dropped
809 LSA will be retransmited to us if we don't ACK it.
810 * ospf_packet.c: (ospf_ls_upd_timer) Ditto, but here we're
811 not transmitting, just putting LSA back on update transmit list.
812 * ospfd.h: delay and holdtimes should be unsigned.
813 Add spf_max_holdtime and spf_hold_multiplier.
814 Update default defines for delay and hold time to be in msec.
815 (struct ospf) change the SPF timestamp to a struct timeval.
816 Remove ospf_timers_spf_(un)?set.
817 * ospfd.c: (ospf_timers_spf_{set,unset}) removed.
818 (ospf_new) initialise spf_max_holdtime and spf_hold_multiplier
819 * ospf_spf.c: (ospf_spf_calculate) SPF timestamp is a timeval
820 now, update with gettimeofday.
821 (ospf_spf_calculate_schedule) Change SPF timers to millisecond
822 resolution.
823 Make the holdtime be adaptive, with a linear increase in
824 holdtime ever consecutive SPF run which occurs within holdtime
825 of previous SPF, bounded by spf_max_holdtime.
826 * ospf_vty.c: Update spf timers commands.
827 (ospf_timers_spf_set) trivial helper.
828 (ospf_timers_throttle_spf_cmd) new command to set SPF delay,
829 initial hold and max hold times with millisecond resolution.
830 (ospf_timers_spf_cmd) Deprecated. Accept the old values,
831 convert to msec, truncate to new limits.
832 (no_ospf_timers_throttle_spf_cmd) set timers to defaults.
833 (no_ospf_timers_spf_cmd) deprecated form, same as previous.
834 (show_ip_ospf_cmd) Display SPF parameters and times.
835 (show_ip_ospf_neighbour_header) Centralise the 'sh ip os ne'
836 header.
837 (show_ip_ospf_neighbor_sub) Fix the field widths. Get rid of
838 the multiple spaces which were making the lines even longer.
839 (show_ip_ospf_neighbor_cmd) Use show_ip_ospf_neighbour_header
840 (show_ip_ospf_neighbor_all_cmd) ditto and fix the field
841 widths for NBMA neighbours.
842 (show_ip_ospf_neighbor_int) Use header function.
843 (show_ip_ospf_nbr_nbma_detail_sub) use sizeof for timebuf,
844 local array - safer.
845 (show_ip_ospf_neighbor_detail_sub) ditto
846 (ospf_vty_init) install the new SPF throttle timer commands.
847
8482005-10-21 Paul Jakma <paul.jakma@sun.com>
849
paulf9ad9372005-10-21 00:45:17 +0000850 * (general) OSPF fast, sub-second hello and 1s dead-interval
851 support.
852 * ospf_dump.c: (ospf_timer_dump) Print out milliseconds too.
853 Callers typically specify a length of 9, so most see
854 millisecs unless they specify the additional length.
855 * ospf_interface.h: (struct ospf_interface) new interface param,
856 fast_hello.
857 * ospf_interface.c: (ospf_if_table_lookup) add brackets,
858 gcc warning fix.
859 (ospf_new_if_params) Initialise fast_hello param.
860 (ospf_free_if_params) Check whether fast_hello is configured.
861 (ospf_if_new_hook) set fast_hello to default.
862 * ospf_ism.h: Wrap OSPF_ISM_TIMER_ON inside do {} while (0) to
863 prevent funny side-effects from its if statement when this
864 macro is used conditionally by other macros.
865 (OSPF_ISM_TIMER_MSEC_ON) new macro, set in milliseconds.
866 (OSPF_HELLO_TIMER_ON) new macro to set hello timer according
867 to whether fast_hello is set.
868 * ospf_ism.c: Update all setting of the hello timer to use
869 either OSPF_ISM_TIMER_MSEC_ON or OSPF_HELLO_TIMER_ON. The
870 former is used when hello is to be sent immediately.
871 * ospf_nsm.c: ditto
872 * ospf_packet.c: (ospf_hello) hello-interval is not checked
873 for mismatch if fast_hello is set.
874 (ospf_read) Annoying nit, fix "no ospf_interface" to be debug
875 rather than a warning, as it can be perfectly normal to
876 receive packets when logical subnets are used.
877 (ospf_make_hello) Set hello-interval to 0 if fast-hellos are
878 configured.
879 * ospf_vty.c: (ospf_auto_cost_reference_bandwidth) annoying
880 nit, don't vty_out if this command is given, it gets tired
881 quick.
882 (show_ip_ospf_interface_sub) Print the hello-interval
883 according to whether fast-hello is set or not.
884 Print the extra 5 millisec characters from (ospf_timer_dump)
885 if fast-hello is configured.
886 (ospf_vty_dead_interval_set) new function, common to all
887 forms of dead-interval command, to set dead-interval and
888 fast-hello correctly. If a dead-interval is given, unset
889 fast-hello, else if a hello-multiplier is set, set
890 dead-interval to 1 and fast-hello to given multiplier.
891 (ip_ospf_dead_interval_addr_cmd) use
892 ospf_vty_dead_interval_set().
893 (ip_ospf_dead_interval_minimal_addr_cmd) ditto.
894 (no_ip_ospf_dead_interval) Unset fast-hello.
895 (no_ip_ospf_hello_interval) Bug-fix, unset of hello-interval
896 should set it to OSPF_HELLO_INTERVAL_DEFAULT, not
897 OSPF_ROUTER_DEAD_INTERVAL_DEFAULT.
898 (config_write_interface) Write out fast-hello.
899 (ospf_config_write) Write a comment about
900 "auto-cost reference-bandwidth" having to be equal on all
901 routers. Hopefully just as noticeable as old practice of
902 writing to vty, but less annoying.
903 (ospf_vty_if_init) install the two new dead-interval
904 commands.
905 * ospfd.h: Add defines for OSPF_ROUTER_DEAD_INTERVAL_MINIMAL
906 and OSPF_FAST_HELLO_DEFAULT.
907
pauleb3da6d2005-10-18 04:20:33 +00009082005-10-18 Paul Jakma <paul.jakma@sun.com>
909
910 * (general) SPF memory management cleanup and fix for rare
911 double-free bug.
912 * ospf_spf.h: (struct vertex_parent) New struct to hold parent
913 specific data, eg the backlink and the parent vertex pointer,
914 and point to the appropriate general struct vertex_nexthop.
915 (struct vertex_nexthop) remove parent vertex pointer, so
916 this struct can be shared across vertices.
917 (struct vertex) rename list child to list children. Remove
918 list of nexthops, replace with list of vertex_parents.
919 * ospf_spf.c: (update_stat) trivial, remove cast from void *.
920 (vertex_nexthop_new) remove init of parent - field is gone
921 from struct vertex_nexthop.
922 (ospf_canonical_nexthops_free) Remove the canonical
923 vertex_nexthop memory objects. These are the vertex_nexthops
924 attached to the first level of router vertices from the root.
925 (vertex_parent_new) new function, create a vertex_parent.
926 (vertex_parent_free) ditto, but free it.
927 (ospf_vertex_new) Update to match changes to struct vertex.
928 (ospf_vertex_free) Recursively free a struct vertex and its
929 children. The parent list is used as a reference count.
930 vertex_nexthops must be free seperately, if required.
931 (ospf_vertex_dump) update to match struct vertex changes.
932 Print out backlink of parents too.
933 (ospf_vertex_add_parent) ditto.
934 (ospf_lsa_has_link) update comment.
935 (ospf_nexthop_add_unique) removed, not needed anymore.
936 (ospf_nexthop_merge) ditto.
937 (ospf_spf_consider_nexthop) renamed to ospf_spf_add_parent.
938 Simplified to just create vertex_parent and add it.
939 (ospf_spf_flush_parents) new function, flush out the parent
940 list.
941 (ospf_nexthop_calculation) Take the relevant route_lsa_link
942 as an argument, which simplifies things and removes the need
943 for the hack in ospf_nexthop_add_unique - ospf_spf_next
944 already knew exactly which link the cost calculated was for.
945 Update to match struct vertex changes too.
946 (ospf_spf_next) Don't create a vertex for W unnecessarily, if
947 it's there's a vertex already created for W, use it, and
948 hence there's no need to free it either.
949 Update some manipulation/comparisons of distance to match.
950 Flush the parent list if a lower cost path is found.
951 (ospf_spf_route_free) unused, removed.
952 (ospf_spf_dump) match the struct vertex changes, and dump the
953 ifname if possible.
954 (ospf_spf_calculate) At end of SPF, free the canonical nexthops
955 and call ospf_vertex_free on the root vertex to free the
956 entire tree.
957 * ospf_interface.c: (ospf_vl_set_params) match struct vertex
958 changes.
959 * ospf_route.c: (ospf_intra_route_add) ditto
960 (ospf_route_copy_nexthops_from_vertex) ditto
961
paul36238142005-10-11 04:12:54 +00009622005-10-11 Paul Jakma <paul.jakma@sun.com>
963
964 * ospf_api.c: sign warnings.
965 * ospf_apiserver.c: sign warning and convert all the struct
966 in_addr initialisations so as not to make assumptions about
967 how this struct is organised, initialise the s_addr member
968 explicitely.
969 * ospf_packet.c: Add const qualifier to auth_key.
970
vincent77df1f72005-10-06 07:46:22 +00009712005-10-06 Alain Ritoux <alain.ritoux@6wind.com>
972
973 * ospf_snmp.c: Avoid mixing interface and ospf_interface objects
974 which now allows snmpwalk to work with ospfIfTable and
975 also with ospfIfMetricTable
976
ajsf52d13c2005-10-01 17:38:06 +00009772005-10-01 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
978
979 * ospf_dump.c: Remove local hard-coded table ospf_redistributed_proto.
980 (ospf_redist_string) New function implemented using new library
981 function zebra_route_string(). Note that there are a few differences
982 in the output that will result: the new function returns strings
983 that are lower-case, whereas the old table was mixed case. Also,
984 the old table mapped ZEBRA_ROUTE_OSPF6 to "OSPFv3", whereas the
985 new function returns "ospf6".
986 * ospfd.h: Remove extern struct message ospf_redistributed_proto[],
987 and add extern const char *ospf_redist_string(u_int route_type)
988 instead.
989 * ospf_asbr.c: (ospf_external_info_add) In two messages, use
990 ospf_redist_string instead of LOOKUP(ospf_redistributed_proto).
991 * ospf_vty.c: Remove local hard-coded table distribute_str.
992 (config_write_ospf_redistribute,config_write_ospf_distribute): Use
993 new library function zebra_route_string() instead of distribute_str[].
994 * ospf_zebra.c: (ospf_redistribute_set,ospf_redistribute_unset,
995 ospf_redistribute_default_set,ospf_redistribute_check)
996 In debug messages, use ospf_redist_string() instead of
997 LOOKUP(ospf_redistributed_proto).
998
jardin6638c1a2005-10-01 00:08:54 +00009992005-09-30 Vincent Jardin <vincent.jardin@6wind.com>
1000
1001 * ospf_dump.c, ospf_ia.c, ospf_spf.c, ospf_ase.c:
1002 remove unused DEBUG
1003
vincentba682532005-09-29 13:52:57 +000010042005-09-29 Alain Ritoux <alain.ritoux@6wind.com>
1005
vincent5e4914c2005-09-29 16:34:30 +00001006 * ospf_ism.c: generate SNMP traps on Interface state change
1007 * ospf_nsm.c: generate SNMP traps on Neighbour state change
1008 * ospf_snmp.[ch]: support for SNMP traps for interface and neighbours.
1009
10102005-09-29 Alain Ritoux <alain.ritoux@6wind.com>
1011
vincentba682532005-09-29 13:52:57 +00001012 * ospf_vty.c: forece default route LSA to be re_issued whenever
1013 cost is changed ( [no] ip ospf area XXX default-cost YYY)
1014 Support ignore-mtu option
1015 * ospfd.h: define OSPF_MTU_IGNORE_DEFAULT
1016 * ospf_packet.c: support ignore-mtu option
1017 * ospf_interface.h: field added for skipping MTU check
1018 * ospf_interface.c: fix memory leak in ospf_crypt_key_delete()
1019 Set mtu_ignore field to default value
1020 * ospf_abr.[ch]: export ospf_abr_announce_network_to_area()
1021 * ospf_ism.h: add MACRO to convert internal ISM status into SNMP
1022 correct values
1023 * ospf_snmp.c: add sanity check on LSA type in lsdb_lookup_next()
1024 convert OSPFIFSTATE internal status into SNMP values
1025
vincentc1a03d42005-09-28 15:47:44 +000010262005-09-28 Alain Ritoux <alain.ritoux@6wind.com>
1027
1028 * ospf_packet.c: use new md5 API
1029
ajs5339cfd2005-09-19 13:28:05 +000010302005-09-19 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1031
1032 * ospf_lsa.h: (ospf_external_lsa_flush) Comment out the 5th argument
1033 (nexthop) since it is not used in the function (except inside
1034 some commented-out code).
1035 * ospf_lsa.c: (ospf_external_lsa_flush,ospf_external_lsa_refresh)
1036 Comment out the 5th argument to ospf_external_lsa_flush.
1037 * ospf_asbr.c: (ospf_redistribute_withdraw) Comment out 5th arg
1038 to ospf_external_lsa_flush.
1039 * ospf_vty.c: (no_ospf_default_information_originate) Eliminate 5th
1040 uninitialized nexthop arg to ospf_external_lsa_flush.
1041 * ospf_zebra.c: (ospf_zebra_read_ipv4) Comment out 5th arg
1042 to ospf_external_lsa_flush.
1043 * ospfd.c: (ospf_network_set) Comment out 5th arg
1044 to ospf_external_lsa_flush.
1045
ajse6a0bf92005-09-17 18:53:38 +000010462005-09-17 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1047
1048 * ospf_opaque.c:
1049 (ospf_opaque_lsa_refresh_schedule,ospf_opaque_lsa_flush_schedule)
1050 No need to call ospf_lookup(), just use lsa0->area->ospf instead.
1051
hassobb5b7552005-08-21 20:01:15 +000010522005-08-21 Hasso Tepper <hasso at quagga.net>
1053
1054 * ospf_vty.c: Make "show ip ospf neighbor xxx" commands work.
1055 Interface should be specified by name now.
1056
hasso54bedb52005-08-17 13:31:47 +000010572005-08-17 Hasso Tepper <hasso at quagga.net>
1058
1059 * ospf_vty.c: Check carefully if interface exists before trying to
1060 print info about it.
1061
hasso01018ce2005-08-05 07:40:15 +000010622005-08-05 Hasso Tepper <hasso at quagga.net>
1063
1064 * ospf_zebra.c: Don't assert/stop before type == ZEBRA_ROUTE_MAX if
1065 dealing with routemaps. There is ospf->route_map[ZEBRA_ROUTE_MAX]
1066 for default-information.
1067
paulc8987752005-07-26 06:07:22 +000010682005-07-26 Paul Jakma <paul.jakma@sun.com>
1069
1070 * ospf_abr.c: (ospf_abr_announce_network_to_area) SET_FLAG
1071 should be on lsa not old, which may be freed for one thing,
1072 obviously.
1073
pauld57834f2005-07-12 20:04:22 +000010742005-07-12 Paul Jakma <paul.jakma@sun.com>
1075
1076 * ospfd.h: add OSPF_ABR_DEFAULT for convenience, make
1077 OSPF_ABR_CISCO be the default ABR type.
1078 * ospfd.c: (ospf_new) initialise abr_type to OSPF_ABR_DEFAULT
1079 * ospf_vty.c: (no_ospf_abr_type_cmd) add standard as a negatable
1080 abr_type. default abr_type should be OSPF_ABR_DEFAULT.
1081 (ospf_config_write) test whether default abr_type against
1082 OSPF_ABR_DEFAULT, rather than any specific ABR_TYPE.
1083
hasso8469bd72005-06-20 20:50:10 +000010842005-06-20 Hasso Tepper <hasso at quagga.net>
hassof4833e92005-06-20 20:42:26 +00001085
1086 * ospf_nsm.c: Make database exchange for NSSA database work.
1087
paul7461d452005-06-13 13:57:16 +000010882005-06-13 Paul Jakma <paul.jakma@sun.com>
1089
1090 * ospf_spf.c: Try get more information on a SEGV under
1091 ospf_spf_vertex_add_parent.
1092 (ospf_vertex_free) NULL out the child and nexthop lists
1093 (ospf_vertex_add_parent) nexthop and child can not be NULL
1094 vertex_nexthop's parent->child list can not be NULL
1095 (ospf_spf_next) w and cw are per-loop iteration variables, move
1096 declarations into loop body.
1097
hasso1ddd7292005-06-07 19:54:04 +000010982005-06-07 Hasso Tepper <hasso at quagga.net>
1099
1100 * ospf_apiserver.c: Fix obvious error in notifying clients about ISM
1101 changes - oi->ifp->status doesn't give to us info about ISM,
1102 oi->state does.
1103
paul7e440862005-06-01 11:20:51 +000011042005-06-01 Akihiro Mizutani <mizutani@net-chef.net>
1105
1106 * ospf_ism.c (ospf_elect_bdr/ospf_elect_dr): Fix DR election bug.
1107
paul500e4182005-05-26 17:11:13 +000011082005-05-26 Paul Jakma <paul.jakma@sun.com>
1109
1110 * ospf_abr.c: (ospf_abr_update_aggregate) Fix comment, cost bug itself
1111 had been fixed long ago by Sowmini.
1112
paula3387a42005-05-18 23:29:57 +000011132005-05-19 Paul Jakma <paul.jakma@sun.com>
1114
1115 * ospf_interface.c: (ospf_if_table_lookup) Fix a serious bug
1116 a less serious one.
1117 1: this function is supposed to lookup
1118 entries in the oifs ospf_interface route_table and return either
1119 an existing oi or NULL to indicate not found, its caller depends
1120 on this, yet this function uses route_node_get which /always/
1121 returns a route_node - one is created if none exists. Use
1122 route_node_lookup instead. This should fix root cause of the
1123 reports of the (ospf_add_to_if) assert being hit.
1124 2: oi's are inserted into this table with prefixlength set to
1125 /32 (indeed, it should be a hash table, not a route_table),
1126 however prefixlength to lookup was not changed, if no valid entry
1127 can be inserted other than /32, then nothng but /32 should be
1128 looked up. This possibly only worked by fluke..
1129 Fix confirmed by 2 reporters (one list, one IRC), definitely a
1130 backport candidate once it has been incubated in HEAD for a while.
1131 Thanks to Patrick Friedel and Ivan Warren for testing.
1132
paul69310a62005-05-11 18:09:59 +000011332005-05-11 Paul Jakma <paul.jakma@sun.com>
1134
1135 * (general) Fix memory leaks in opaque AS-scope LSAs, reported and
1136 with much debugging done by by scott collins <scollins@agile.tv>.
1137 * ospf_lsa.c: (ospf_discard_from_db) dont call
1138 ospf_ase_unregister_external_lsa for opaque-lsa's, opaques are
1139 never registered with ase in the first place.
1140 * ospf_packet.c: (general) Disabuse opaque related code of its
1141 tendency to try gather up things into temporary lists.
1142 (ospf_ls_upd) remove the temporary lists opaque uses, call
1143 opaque functions inline, just like all other types.
1144 (ospf_ls_ack) ditto.
1145 (ospf_recv_packet) fixup sign warning.
1146 * ospf_opaque.c: (general) fix the unneeded use of lists, and
1147 untwist some of the logic.
1148 (ospf_opaque_self_originated_lsa_received) take a single LSA
1149 as argument, not a list of them. Remove the list loop. Logic
1150 otherwise unchanged.
1151 (ospf_opaque_ls_ack_received) Mostly ditto. But untwist the logic,
1152 move the actions up into the switch block, remove the goto's and
1153 sanitise the logic near the end a bit.
1154 * ospf_opaque.h: Adjust definitions of aforementioned functions
1155 in ospf_opaque.c to match.
1156
paul42c98192005-05-07 02:22:51 +000011572005-05-07 Yar Tikhiy <yar@comp.chem.msu.su>
1158
1159 * ospf_network.c: Log ifindex on multicast membership leave/join
1160 events.
1161
paul4dadc292005-05-06 21:37:42 +000011622005-05-06 Paul Jakma <paul.jakma@sun.com>
1163
1164 * (general) extern and static qualifiers added.
1165 unspecified arguments in definitions fixed, typically they should
1166 be 'void'.
1167 function casts added for callbacks.
1168 Guards added to headers which lacked them.
1169 Proper headers included rather than relying on incomplete
1170 definitions.
1171 gcc noreturn function attribute where appropriate.
1172 * ospf_opaque.c: remove the private definition of ospf_lsa's
1173 ospf_lsa_refresh_delay.
1174 * ospf_lsa.h: export ospf_lsa_refresh_delay
1175 * ospf_packet.c: (ospf_make_md5_digest) make *auth_key const,
1176 correct thing to do - removes need for the casts later.
1177 * ospf_vty.c: Use vty.h's VTY_GET_INTEGER rather than ospf_vty's
1178 home-brewed versions, shuts up several warnings.
1179 * ospf_vty.h: remove VTY_GET_UINT32. VTY_GET_IPV4_ADDRESS and
1180 VTY_GET_IPV4_PREFIX moved to lib/vty.h.
1181 * ospf_zebra.c: (ospf_distribute_list_update_timer) hacky
1182 overloading of the THREAD_ARG pointer should at least use
1183 uintptr_t.
1184
paul9e67dc22005-04-15 12:10:17 +000011852005-04-15 Zhipeng Gong <zpgong@cdc.3upsystems.com>
1186
1187 * ospf_abr.c: (ospf_abr_announce_network_to_area) dont forget
1188 to approve LSAs for the case where metric has changed, lsa gets
1189 flushed otherwise. (backport candidate).
1190
ajs634f9ea2005-04-11 15:51:40 +000011912005-04-11 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1192
1193 * ospf_zebra.c (ospf_zebra_add): Call zclient_send_message instead
1194 of writen.
1195
ajsd2fc8892005-04-02 18:38:43 +000011962005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1197
ajse4319de2005-04-02 23:23:55 +00001198 * ospf_interface.h: (ospf_if_lookup_by_name) Remove declaration of a
1199 function that does not exist.
1200
12012005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1202
ajs21fefa92005-04-02 23:16:41 +00001203 * ospf_zebra.c: (zebra_interface_if_lookup) Must use
1204 if_lookup_by_name_len.
1205
12062005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1207
ajsa3491982005-04-02 22:50:38 +00001208 * ospf_interface.c: (ospf_vl_new) Use strnlen to fix call to if_create.
1209
12102005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1211
ajsd2fc8892005-04-02 18:38:43 +00001212 * ospf_vty.c: (show_ip_ospf_interface_sub) Show ifindex and interface
1213 flags to help with debugging.
1214 * ospf_zebra.c: (ospf_interface_delete) After deleting, set ifp->ifindex
1215 to IFINDEX_INTERNAL.
1216 (zebra_interface_if_lookup) Make function static. Tighten up code.
1217
ajsaca72fd2005-03-31 15:18:21 +000012182005-03-31 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1219
1220 * ospf_dump.c: (show_debugging_ospf) Show if ospf event debugging
1221 is turned on.
1222
ajsfd651fa2005-03-29 16:08:16 +000012232005-03-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1224
ajsa608bbf2005-03-29 17:03:49 +00001225 * ospf_zebra.c: (ospf_interface_state_up) If the MTU of an operative
1226 interface changes, print a debug message and call ospf_if_reset()
1227 to simulate down/up on the interface.
1228 * ospf_interface.h: Declare new function ospf_if_reset().
1229 * ospf_interface.c: (ospf_if_reset) New function to call ospf_if_down
1230 and ospf_if_up for all ospf interfaces attached to an interface.
1231
12322005-03-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1233
ajs5dcbdf82005-03-29 16:13:49 +00001234 * ospf_packet.c: (ospf_write_frags) Enhance error message to
1235 show MTU. Also make function static.
1236 (ospf_write) Enhance error message to show interface name and MTU.
1237 Also make function static.
1238
12392005-03-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1240
1241 * ospf_vty.c: (show_ip_ospf_interface_sub) Display interface MTU and
1242 bandwidth; this is useful for debugging problems. Also, the function
1243 should be static.
ajsfd651fa2005-03-29 16:08:16 +00001244
hasso1b639042005-03-27 13:32:25 +000012452005-03-27 Hasso Tepper <hasso at quagga.net>
1246
1247 * ospf_snmp.c: Don't crash in snmp query if ospf instance doesn't
1248 exist at all.
1249
hasso343f5cc2005-03-25 19:48:40 +000012502005-03-25 Hasso Tepper <hasso at quagga.net>
1251
1252 * ospfd.h: Include log.h, fixes compile with gcc-4.0.
1253
ajs9dbc7972005-03-13 19:27:22 +000012542005-03-13 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1255
1256 * ospf_lsa.c: (ospf_lsa_refresh_walker) If the system clock jumps
1257 backward, then current time may be less than
1258 ospf->lsa_refresher_started. This was causing invalid values
1259 for ospf->lsa_refresh_queue.index resulting in infinite loops.
1260 Problem fixed by casting the expression to unsigned before taking
1261 the modulus.
1262
ajs5c333492005-02-23 15:43:01 +000012632005-02-23 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1264
1265 * ospfd.h: Add new field struct stream *ibuf to struct ospf.
1266 * ospfd.c: (ospf_new) Check return code from ospf_sock_init.
1267 Allocate ibuf using stream_new(OSPF_MAX_PACKET_SIZE+1).
1268 (ospf_finish) Call stream_free(ospf->ibuf.
1269 * ospf_packet.c: (ospf_read) Call stream_reset(ospf->ibuf) and then
1270 pass it to ospf_recv_packet for use in receiving the packet
1271 (instead of allocating a new stream for each packet received).
1272 Eliminate all calls to stream_free(ibuf).
1273 (ospf_recv_packet) The struct stream *ibuf is now passed in as
1274 an argument. No need to use recvfrom to peek at the packet
1275 header (to see how big it is), just use ospf->ibuf which is
1276 always large enough (this eliminates a system call to recvfrom).
1277 Therefore, no need to allocate a stream just for this packet,
1278 and no need to free it when done.
1279
hasso462f20d2005-02-23 11:29:02 +000012802005-02-23 Vincenzo Eramo <eramo at infocom.ing.uniroma1.it>
1281
1282 * ospf_lsa.h: New flag to the LSA structure for the SPF calculation.
1283 * ospf_lsdb.h: Export ospf_lsdb_clean_stat() function.
1284 * ospf_spf.h: Add link to the LSA stat structure into vertex.
1285 * ospf_spf.c: New functions cmp() and update_stat() to manage
1286 candidates. Remove ospf_spf_has_vertex(), ospf_vertex_lookup(),
1287 ospf_install_candidate() and ospf_spf_register() functions not needed
1288 any more. Update ospf_vertex_new(), ospf_spf_next() and
1289 ospf_spf_calculate() functions to use pqueue instead of linked list.
1290
hassoe40dcce2005-02-21 14:58:42 +000012912005-02-21 Hasso Tepper <hasso at quagga.net>
1292
1293 * ospf_ase.c: Don't show messages related to the ase calculations if
1294 we are not debugging.
1295
hasso306541b2005-02-19 17:58:40 +000012962005-02-19 Hasso Tepper <hasso at quagga.net>
1297
1298 * ospf_api.h: char isn't always signed, but it has to be it here.
1299
paulfa81b712005-02-19 01:19:20 +000013002005-02-19 Paul Jakma <paul.jakma@sun.com>
1301
1302 * ospf_packet.c: (ospf_stream_copy) remove
1303 (ospf_packet_dup) use stream_copy instead of ospf_stream_copy
1304
ajs038163f2005-02-17 19:55:59 +000013052005-02-17 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1306
1307 * ospf_packet.c: (ospf_recv_packet) If there is somehow a runt
1308 packet in the queue, it must be discarded. Improve warning messages.
1309 Fix scope to static.
1310 (ospf_read) Fix bug: should reset the read thread in all cases
1311 to make sure we continue to get incoming messages.
1312
paul658b03a2005-02-15 10:10:55 +000013132005-02-15 Paul Jakma <paul.jakma@sun.com>
1314
1315 * ospf_packet.c: (ospf_recv_packet) Fix silly error wrt allocating
1316 ibuf. Thanks Andrew.
1317
paulbfdc44a2005-02-14 23:48:42 +000013182005-02-14 Paul Jakma <paul.jakma@sun.com>
1319
1320 * ospf_packet.c: (ospf_recv_packet) use stream_recvmsg.
1321
hasso082253f2005-02-11 08:31:54 +000013222005-02-11 Hasso Tepper <hasso at quagga.net>
1323
1324 * ospf_lsdb.c: Fix sum of checksums calculation.
1325
ajs083ee9d2005-02-09 15:35:50 +000013262005-02-09 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1327
1328 * ospf_packet.c: (ospf_write) If sendmsg fails, give more info in the
1329 error message.
1330
ajsba6454e2005-02-08 15:37:30 +000013312005-02-08 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1332
ajs8cfde372005-02-08 15:59:16 +00001333 * ospf_interface.h: Reduce structure padding by putting new u_char
1334 field multicast_memberships in a better spot (grouped with
1335 other u_char fields type and state).
1336
13372005-02-08 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1338
ajsba6454e2005-02-08 15:37:30 +00001339 * ospf_interface.h: Improve passive_interface comment. Add new
1340 multicast_memberships bitmask to struct ospf_interface to track
1341 active multicast subscriptions. Declare new function
1342 ospf_if_set_multicast.
1343 * ospf_interface.c: (ospf_if_set_multicast) New function to configure
1344 multicast memberships properly based on the current
1345 multicast_memberships status and the current values of the
1346 ospf_interface state, type, and passive_interface status.
1347 (ospf_if_up) Remove call to ospf_if_add_allspfrouters (this is
1348 now handled by ism_change_state's call to ospf_if_set_multicast).
1349 (ospf_if_down) Remove call to ospf_if_drop_allspfrouters (now
1350 handled by ism_change_state).
1351 * ospf_ism.c: (ospf_dr_election) Remove logic to join or leave
1352 the DRouters multicast group (now handled by ism_change_state's call
1353 to ospf_if_set_multicast).
1354 (ism_change_state) Add call to ospf_if_set_multicast to change
1355 multicast memberships as necessary to reflect the new interface state.
1356 * ospf_packet.c: (ospf_hello) When a Hello packet is received on a
1357 passive interface: 1. Increase the severity of the error message
1358 from LOG_INFO to LOG_WARNING; 2. Add more information to the error
1359 message (packet destination address and interface address);
1360 and 3. If the packet was sent to ospf-all-routers, then try
1361 to fix the multicast group memberships.
1362 (ospf_read) When a packet is received on an interface whose state
1363 is ISM_Down, enhance the warning message to show the packet
1364 destination address, and try to update/fix the multicast group
1365 memberships if the packet was sent to a multicast address.
1366 When a packet is received for ospf-designated-routers, but the
1367 current interface state is not DR or BDR, then increase the
1368 severity level of the error message from LOG_INFO to LOG_WARNING,
1369 and try to fix the multicast group memberships.
1370 * ospf_vty.c: (ospf_passive_interface) Call ospf_if_set_multicast for
1371 any ospf interface that may have changed from active to passive.
1372 (no_ospf_passive_interface) Call ospf_if_set_multicast for
1373 any ospf interface that may have changed from passive to active.
1374 (show_ip_ospf_interface_sub) Show multicast group memberships.
1375
paul3a9eb092005-02-08 11:29:41 +000013762005-02-08 Paul Jakma <paul@dishone.st>
1377
1378 * ospf_packet.c: (various) Remove unneeded stream_set_putp abuse.
1379
ajs847947f2005-02-02 18:38:48 +000013802005-02-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1381
1382 * ospf_packet.c: (ospf_read) Fix bug: must check for state ISM_Down,
1383 not for event ISM_InterfaceDown. And improve the message by
1384 adding the interface flags.
1385
ajs0b7d97d2005-01-30 17:24:02 +000013862005-01-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1387
1388 * ospf_network.c: (ospf_sock_init) Save errno before calling
1389 ospfd_privs.change.
1390
ajsc3eab872005-01-29 15:52:07 +000013912005-01-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1392
1393 * ospf_packet.c: (ospf_packet_add) If oi->obuf is NULL, print
1394 an error message and return.
1395 (ospf_read) If the interface state is ISM_InterfaceDown, issue
1396 a warning message and ignore the packet.
1397
gdt86f1fd92005-01-10 14:20:43 +000013982005-01-10 Greg Troxel <gdt@fnord.ir.bbn.com>
1399
1400 * ospf_packet.h: Remove commented out definition of
1401 OSPF_MAX_PACKET; neither it or the uncommented one are used any more.
1402
1403 * ospf_packet.c (ospf_make_ls_upd): Leave room for authentication
1404 when deciding if an update will fit.
1405 (ospf_packet_authspace): Factor out calculation of size required
1406 for authentication.
1407 (ospf_make_db_desc): Use ospf_max_packet, not OSPF_MAX_PACKET.
1408 Don't confuse readers that there is a macro.
1409
ajs3dc56b52004-12-30 15:11:19 +000014102004-12-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1411
1412 * ospf_network.c: Improve all setsockopt error messages to give detailed
1413 information on the arguments.
1414
ajsb87f7722004-12-29 20:41:26 +000014152004-12-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1416
ajs17eaa722004-12-29 21:04:48 +00001417 * ospf_packet.c: (ospf_db_desc) Reduce severity of "Negotiation done"
1418 messages from LOG_WARNING to LOG_INFO, since this seems to be
1419 normal.
1420
14212004-12-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1422
ajsb87f7722004-12-29 20:41:26 +00001423 * ospf_packet.c: (ospf_read) Always look up the interface if
1424 ospf_recv_packet returns NULL ifp, since some platforms such
1425 as Solaris 8 appear to support ifindex retrieval but don't.
1426
hasso1d806282004-12-22 09:43:20 +000014272004-12-22 Hasso Tepper <hasso at quagga.net>
1428
1429 * ospf_dump.c: Show debug configuration in vtysh.
hassoc6b87812004-12-22 13:09:59 +00001430 * ospf_vty.c: Fix "show ip ospf" output. Router can't be elected in
1431 any case if it's configured as "translate-never".
hassofe71a972004-12-22 16:16:02 +00001432 * ospf_lsdb.[ch]: New function to calculate sum of checksums.
1433 * ospf_vty.c: Bugfix to show really number of AS external LSAs, not
1434 number of all LSAs with AS scope, this includes opaque as LSAs as
1435 well, show this number separately. Show numbers and sums of
1436 checksums for each type of LSAs.
1437 * ospf_lsa.c: Calculate checksum before putting LSA into database.
hasso1d806282004-12-22 09:43:20 +00001438
ajsbc18d612004-12-15 15:07:19 +000014392004-12-15 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1440
1441 * ospf_interface.h: Declare new function ospf_default_iftype.
1442 * ospf_interface.c: (ospf_default_iftype) New function to centralize
1443 this logic in one place.
1444 * ospf_zebra.c: (ospf_interface_add) Use new function
1445 ospf_default_iftype.
1446 * ospf_vty.c: (no_ip_ospf_network,config_write_interface) Fix logic
1447 by using new function ospf_default_iftype.
1448
ajs3aa8d5f2004-12-11 18:00:06 +000014492004-12-11 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1450
1451 * ospf_packet.c: (ospf_db_desc) Should be static, not global.
1452 (ospf_hello,ospf_db_desc,ospf_ls_upd,ospf_ls_ack) Improve warning
1453 messages to include identifying information (e.g. router id).
1454 * ospf_nsm.c: (nsm_change_state) Improve info message to include
1455 router id and state names.
1456
gdt91f3e522004-12-09 14:51:03 +000014572004-12-09 Greg Troxel <gdt@fnord.ir.bbn.com>
1458
gdt3fb9de72004-12-09 16:30:04 +00001459 * ospf_apiserver.c (ospf_apiserver_term): Obtain struct
1460 ospf_apiserver * from listnode. Remove unused variables. Follows
1461 suggestion from Jay Fenlason.
gdt91f3e522004-12-09 14:51:03 +00001462
ajs9b0e25c2004-12-08 19:06:51 +000014632004-12-08 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1464
1465 * *.c: Change level of debug messages to LOG_DEBUG.
1466
ajs274a4a42004-12-07 15:39:31 +000014672004-12-07 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1468
1469 * ospf_main.c: (main) The 2nd argument to openzlog has been removed.
1470
ajs887c44a2004-12-03 16:36:46 +000014712004-12-03 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1472
ajs1210fa62004-12-03 16:43:24 +00001473 * ospf_packet.c: (ospf_db_desc) Reduce priority on a debug message
1474 from LOG_NOTICE to LOG_DEBUG.
1475
14762004-12-03 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1477
ajs887c44a2004-12-03 16:36:46 +00001478 * ospf_main.c: (sigint) Use zlog_notice for termination message.
1479 (main) Issue a startup announcement using zlog_notice.
1480
ajsbec595a2004-11-30 22:38:43 +000014812004-11-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1482
1483 * ospf_packet.c: (ospf_db_desc_proc) Fix spelling of packet in warning
1484 message and in comment.
1485 (ospf_db_desc) Warning message that a packet is being discarded
1486 should give the router id of the packet source. Fix spelling
1487 of packet in two warning messages.
1488 (ospf_ls_req) Warning message that a link state request is being
1489 discarded should give the router id of the neighbor that sent it.
1490
ajs5b85fac2004-11-26 19:36:42 +000014912004-11-26 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1492
1493 * ospf_main.c: Remove #include "debug.h" (was not being used, and
1494 lib/debug.h has now been deleted).
1495
hassoc0652302004-11-25 19:33:48 +000014962004-11-25 Hasso Tepper <hasso at quagga.net>
1497
1498 * ospf_main.c: Make group to run as configurable.
1499
gdt69e13252004-11-15 18:51:15 +000015002004-11-15 Greg Troxel <gdt@fnord.ir.bbn.com>
1501
1502 * ospf_packet.c (ospf_recv_packet): Assume CMSG_SPACE is present
1503 and works (lib/zebra.h provides if OS doesn't).
1504
paul788dab12004-11-15 11:48:37 +000015052004-11-15 Paul Jakma <paul@dishone.st>
1506
1507 * ospf_{apiserver,te}.c: ospf_lsa_free's should be ospf_lsa_unlock.
1508
paul05e85fa2004-11-12 10:52:19 +000015092004-11-12 Paul Jakma <paul@dishone.st>
1510
1511 * ospf_ia.c: (process_summary_lsa) Only an ABR has any reason to
1512 ignore stub area summary default. Even so it seems a strange
1513 check, add a comment to that effect.
1514
paulf3ae74c2004-11-04 20:35:31 +000015152004-11-04 Paul Jakma <paul@dishone.st>
1516
1517 * ospfd.c: (ospf_network_match_iface) revert to previous network
1518 statement match behaviour.
1519
paul62d8e962004-11-02 20:26:45 +000015202004-11-02 Paul Jakma <paul@dishone.st>
1521
1522 * ospf_packet.c: (ospf_write_frags) remove iov arg, msg already points
1523 to it. Add convenience pointer to msg->msg_iov[1], and use this,
1524 fixing the unfortunate borkenness introduced in moving of this code
1525 to a function.
1526 (ospf_write) remove iovp and fix up call to previous.
1527 (ospf_ls_upd_packet_new) cast size to long int - unfortunately
1528 glibc's size_t format modifier is not portable.
1529
paul37ccfa32004-10-31 11:24:51 +000015302004-10-31 Paul Jakma <paul@dishone.st>
1531
1532 * ospf_packet.c: (ospf_write_frags) Add debug output
1533 (ospf_write) set type early, so we can pass it to
1534 ospf_write_frags.
1535 (ospf_ls_upd_packet_new) print size in debug output when too large
1536 packet is encountered.
paul64511f32004-10-31 18:01:13 +00001537 * ospf_zebra.c: (ospf_distribute_list_update_timer) Ugly misuse of
1538 THREAD_ARG to store an integer, but it should at least use same
1539 same type to retrieve the value. Assert value is sane.
paul37ccfa32004-10-31 11:24:51 +00001540
paulac191232004-10-22 12:05:17 +000015412004-10-22 Paul Jakma <paul@dishone.st>
1542
1543 * ospf_network.c: (ospf_sock_init) call neutral setsock_ifindex()
1544 function.
1545 * ospf_packet.c: (ospf_read) manually look up ifindex
paul4ccb2c42004-10-22 22:52:33 +00001546 if system could not have returned one, eg openbsd, thanks to Rivo
1547 Nurges for highlighting problem and fix.
paul06f953f2004-10-22 17:00:38 +00001548 Change setsockopt_pktinfo to setsockopt_ifindex.
paulac191232004-10-22 12:05:17 +00001549
hasso3fb9cd62004-10-19 19:44:43 +000015502004-10-19 Andrew J. Schorr <aschorr@telemetry-investments.com>
1551
1552 * ospf_snmp.c: (ospf_snmp_if_update) Fix logic to handle PtP links
1553 with dedicated subnets properly.
1554 * ospf_lsa.c: (lsa_link_ptop_set) ditto.
1555 * ospfd.c: (ospf_network_match_iface) ditto.
1556 (ospf_network_run) ditto.
1557 * ospf_interface.c: (ospf_if_is_configured) ditto.
1558 (ospf_if_lookup_by_prefix) ditto.
1559 (ospf_if_lookup_recv_if) ditto.
1560 * ospf_vty.c: (show_ip_ospf_interface_sub) Display the peer or
1561 broadcast address if present.
1562
hassod68614d2004-10-13 09:32:48 +000015632004-10-13 Hasso Tepper <hasso at quagga.net>
1564
1565 * ospf_main.c: Unbreak compilation with ospfapi disabled.
hassoc75105a2004-10-13 10:33:26 +00001566 * ospf_snmp.c: Remove defaults used to initialize smux connection to
1567 snmpd. Connection is initialized only if smux peer is configured.
hassod68614d2004-10-13 09:32:48 +00001568
hassof4d58ce2004-10-12 06:13:54 +000015692004-10-12 Hasso Tepper <hasso at quagga.net>
1570
1571 * ospf_main.c, ospf_opaque.c: Unbreak ospfclient compilation - move
1572 static variable from ospf_main.c into ospf_opaque.c.
1573
hassoc3abdb72004-10-11 16:27:03 +000015742004-10-11 Hasso Tepper <hasso at quagga.net>
1575
1576 * ospf_main.c, ospf_opaque.c: Disable ospfapi init by default. New
1577 command line switch to enable it.
1578
paul6b333612004-10-11 10:11:25 +000015792004-10-11 Paul Jakma <paul@dishone.st>
1580
1581 * ospf_dump.c: (ospf_ip_header_dump) Assume header is in host order
1582 remove ntohs that should have dissappeared. Take struct ip
1583 as argument, caller has to know there's an IP header at start of
1584 stream anyway.
1585 * ospf_dump.h: update declaration of ospf_ip_header_dump.
1586 * ospf_packet.c: (ospf_write) correct call to
1587 sockopt_iphdrincl_swab_htosys which was munging the header.
1588 (ospf_recv_packet) ip_len is needed for old OpenBSD fixup.
1589 (ospf_read) sockopt_iphdrincl_swab_systoh ip header as soon as
1590 we have it.
paul6c835672004-10-11 11:00:30 +00001591 * (global) Const char update and signed/unsigned fixes.
1592 * (various headers) size defines should be unsigned.
1593 * ospf_interface.h: remove duplicated defines, include the
1594 authoritative header - though, these defines should probably
1595 be moved to a dedicated header, or ospfd.h.
1596 * ospf_lsa.h: (struct lsa) ls_seqnum should be unsigned.
1597 * ospf_packet.c: (ospf_write) cast result of shift to unsigned.
paul6b333612004-10-11 10:11:25 +00001598
hassoeb1ce602004-10-08 08:17:22 +000015992004-10-08 Hasso Tepper <hasso at quagga.net>
1600
1601 * *.[c|h]: Fix compiler warnings: make some strings const, signed ->
1602 unsigned, remove unused variables etc.
1603
gdt54ade992004-10-07 19:38:20 +000016042004-10-07 Greg Troxel <gdt@claude.ir.bbn.com>
1605
1606 * ospf_apiserver.c (ospf_apiserver_unregister_opaque_type): Don't
1607 use of variable names 'node' and 'nextnode' to avoid possible
1608 conflict with list macros. Move variable declaration inside for
1609 loop after a statement to top of function.
1610
paulaa20c6f2004-10-07 14:19:36 +000016112004-10-07 Paul Jakma <paul@dishone.st>
1612
1613 * ospf_snmp.c: Missed list typedef update
1614 * ospf_dump.c: Include sockopt.h for header swab functions.
1615
paul18b12c32004-10-05 14:38:29 +000016162004-10-05 Paul Jakma <paul@dishone.st>
1617
1618 * ospf_packet.c: replace ospf_swap_iph_to... with
1619 sockopt_iphdrincl_swab_...
1620
hasso18a6dce2004-10-03 18:18:34 +000016212004-10-03 James R. Leu <jleu at mindspring.com>
1622
1623 * ospf_zebra.c: Read router id related messages from zebra daemon.
1624 Schedule router-id update thread if it's changed.
1625 * ospfd.c: Remove own router-id selection function. Use router id from
1626 zebra daemon if it isn't manually overriden in configuration.
1627
paul68defd62004-09-27 07:27:13 +000016282004-09-27 Paul Jakma <paul@dishone.st>
1629
paul6a99f832004-09-27 12:56:30 +00001630 * ospf_dump.c: (ospf_ip_header_dump) Use HAVE_IP_HDRINCL_BSD_ORDER
1631 Apply to offset too. Print ip_cksum, lets not worry about
1632 possible 2.0.37 compile problems.
1633 * ospf_packet.c: (ospf_swap_iph_to{n,h}) Use
1634 HAVE_IP_HDRINCL_BSD_ORDER.
1635 (ospf_recv_packet) ditto.
1636 (ospf_write) Fixup iov argument to ospf_write_frags.
1637 (struct msghdr).msg_name is caddr_t on most platforms.
paul68defd62004-09-27 07:27:13 +00001638 (ospf_recv_packet) ditto. And msg_flags is not always there
1639 memset struct then set fields we care about rather than
1640 initialise all fields individually.
1641
hassoc9e52be2004-09-26 16:09:34 +000016422004-09-26 Hasso Tepper <hasso at quagga.net>
1643
1644 * ospf_abr.c, ospf_dump.c, ospf_lsa.c, ospf_packet.c, ospf_vty.c,
1645 ospf_zebra.c: Fix compiler warnings.
1646
paul87d6f872004-09-24 08:01:38 +000016472004-09-24 Paul Jakma <paul@dishone.st>
1648
1649 * ospf_apiserver.{c,h}: lists typedef removal cleanup.
1650 update some list loops to LIST_LOOP. some miscellaneous indent
1651 fixups.
1652 (ospf_apiserver_unregister_opaque_type) fix listnode_delete of
1653 referenced node in loop.
paul1603c062004-09-24 08:23:24 +00001654 (ospf_apiserver_term) loops calling ospf_apiserver_free, which
1655 deletes referenced nodes from apiserver_list, fixed.
paul87d6f872004-09-24 08:01:38 +00001656 * ospf_interface.h: lists typedef removal cleanup.
1657 * ospf_opaque.{c,h}: lists typedef removal cleanup. update some list
1658 loops to LIST_LOOP. miscellaneous style and indent fixups.
1659 * ospf_te.{c,h}: ditto
1660 * ospf_packet.c: lists typedef removal cleanup.
paula2570682004-09-24 08:09:57 +00001661 (ospf_write) ifdef fragmentation support. move actual
1662 fragmentation out to a new, similarly ifdefed, function.
1663 (ospf_write_frags) fragmented write support, moved from previous.
paul87d6f872004-09-24 08:01:38 +00001664
hasso52dc7ee2004-09-23 19:18:23 +000016652004-09-23 Hasso Tepper <hasso at quagga.net>
1666
1667 * *.[c|h]: list -> struct list *, listnode -> struct listnode *.
1668
paul68b73392004-09-12 14:21:37 +000016692004-09-12 Paul Jakma <paul@dishone.st>
1670
1671 * ospf_packet.c: Fix bugzilla #107
1672 (ospf_packet_max) get rid of the magic 88 constant
1673 (ospf_swab_iph_ton) new function. set ip header to network order,
1674 taking BSDisms into account.
1675 (ospf_swab_iph_toh) the inverse.
1676 (ospf_write) Add support for IP fragmentation, will only work on
1677 linux though, other kernels make it impossible. get rid of the
1678 magic 4 constant.
1679 (ospf_make_ls_upd) Bound check to end of stream, not to
1680 interface mtu.
1681 (ospf_ls_upd_packet_new) New function, allocate upd packet
1682 taking oversized LSAs into account.
1683 (ospf_ls_upd_queue_send) use ospf_ls_upd_packet_new to allocate,
1684 rather than statically allocating mtu sized packet buffer, which
1685 actually was wrong - it didnt take ip header into account, which
1686 should not be included in packet buffer.
1687 (ospf_ls_upd_send_queue_event) minor tweaks and remove
1688 TODO comment.
1689
gdt630e4802004-08-31 17:28:41 +000016902004-08-31 David Wiggins <dwiggins@bbn.com>
1691
1692 * ospf_spf.c (ospf_spf_calculate): Many more comments and debug
1693 print statements. New function ospf_vertex_dump used in debugging.
1694
16952004-08-31 David Wiggins <dwiggins@bbn.com>
1696
1697 * ospf_spf.h (struct vertex): Comments for flags and structure members.
1698
16992004-08-31 David Wiggins <dwiggins@bbn.com>
1700
1701 * ospf_route.c: When finding an alternate route, log cost as well.
1702
17032004-08-31 David Wiggins <dwiggins@bbn.com>
1704
1705 * ospf_interface.c (ospf_lookup_if_params): Initialize af in
1706 struct prefix allocated on stack.
1707
17082004-08-31 David Wiggins <dwiggins@bbn.com>
1709
1710 * ospf_packet.c (ospf_ls_ack_send_delayed): In p2mp mode, send
1711 acks to AllSPFRouters, rather than All-DR.
1712
hasso7b901432004-08-31 13:37:42 +000017132004-08-27 Hasso Tepper <hasso at quagga.net>
1714
1715 * ospf_vty.c: Don't print ospf network type under interface only
1716 if interface is in broadcast mode and interface type really is
1717 broadcast. Fixes Bugzilla #108.
1718
gdtd7d93992004-08-27 12:03:42 +000017192004-08-27 David Wiggins <dwiggins@bbn.com>
1720
1721 * ospf_spf.c (ospf_nexthop_calculation): Initialize address family
1722 in on-stack struct prefix_ipv4. Fixes point-to-multipoint SPF
1723 calculation.
1724
gdtd0deca62004-08-26 13:14:07 +000017252004-08-26 Greg Troxel <gdt@fnord.ir.bbn.com>
1726
1727 * ospf_packet.c (ospf_recv_packet): adjust size declaration of
gdtd7d93992004-08-27 12:03:42 +00001728 buffer used to get interface index so that it compiles on other
1729 than Linux and includes the required alignment space. Probably
1730 this was only working on sparc/sparc64 because most of
1731 sockaddr_dl was not being written.
gdtd0deca62004-08-26 13:14:07 +00001732
paul863082d2004-08-19 04:43:43 +000017332004-08-19 Paul Jakma <paul@dishone.st>
1734
1735 * ospf_packet.c: update to match sockopt renames.
1736
paul75ee0b82004-08-05 09:10:31 +000017372004-08-04 Paul Jakma <paul@dishone.st>
1738
1739 * ospf_spf.c: (ospf_spf_consider_nexthop) Add comment about issue.
1740 Compare only against list head - all nexthops must be same cost
1741 anyway, fixes a reference-listnode-after-delete bug noted by
1742 Kir Kostuchenko.
1743 (ospf_nexthop_calculation) Use ospf_spf_consider_nexthop for all
1744 candidates attached to root.
1745
paul36c64ef2004-07-27 11:19:11 +000017462004-07-27 Paul Jakma <paul@dishone.st>
1747
paul48fe13b2004-07-27 17:40:44 +00001748 * ospf_packet.c: (ospf_ls_upd_send_queue_event) fix thinko from
1749 last fix for ospfd wedging due to oversize LSAs: dont list loop on
1750 ospf_ls_upd_queue_send() - guaranteed segfault.
1751
17522004-07-27 Paul Jakma <paul@dishone.st>
1753
paul36c64ef2004-07-27 11:19:11 +00001754 * ospf_opaque.c: (ospf_opaque_lsa_flush_schedule) do not NULL out
1755 the LSA as then free_opaque_info_per_id() can never unlock (and
1756 free) the LSA. Reported by Gunnar Stigen.
1757
paul2dd8bb42004-07-23 15:13:48 +000017582004-07-23 Paul Jakma <paul@dishone.st>
1759
1760 * ospf_network.c: Replace PKTINFO/RECVIF with call to
1761 setsockopt_pktinfo
1762 * ospf_packet.c: Use getsockopt_pktinfo_ifindex and
1763 SOPT_SIZE_CMSG_PKTINFO_IPV4.
1764
paul59ea14c2004-07-14 20:50:36 +000017652004-07-14 Paul Jakma <paul@dishone.st>
1766
1767 * ospf_packet.c: (ospf_ls_upd_send_queue_event) Partial fix for
1768 problem reported by Peter Frost amongst others, where function
1769 will spin indefinitely if update list contains LSAs greater than
1770 MTU-headers or other condition leading to update list never being
1771 cleared. Problem of what to do with these LSAs remains.
1772 (ospf_make_ls_upd) add comment about large LSA problem,
1773 indentation cleanup.
1774
gdtb2c1b282004-07-01 12:35:36 +000017752004-07-01 Greg Troxel <gdt@fnord.ir.bbn.com>
1776
1777 * Makefile.am (lib_LTLIBRARIES): make libospf shared
1778
gdt87efd642004-06-30 17:36:11 +000017792004-06-30 Greg Troxel <gdt@poblano.ir.bbn.com>
1780
1781 * Makefile.am: Add shlib support.
1782
hassobeebba72004-06-20 21:00:27 +000017832004-06-10 Hasso Tepper <hasso@estpak.ee>
1784
1785 * *: Removed ifdefs HAVE_NSSA.
1786
paul553ff112004-06-06 09:41:00 +000017872004-06-06 Paul Jakma <paul@dishone.st>
1788
1789 * ospf_dump.c,ospf_lsa.c: Fix typos of merge of previous.
1790 ospf_flood.c: (ospf_process_self_originated_lsa) fix zlog format
1791
paul0c2be262004-05-31 14:16:54 +000017922004-05-31 Sagun Shakya <sagun.shakya@sun.com>
1793
1794 * ospf_dump.c: (ospf_lsa_header_dump) LOOKUP can return null if
1795 index is out of range.
1796 ospf_flood.c: endianness fix
1797 ospf_lsa.c: Missing ntohl's on (struct lsa *)->data->ls_seqnum
1798 in various places.
1799
hassodd669bb2004-05-10 07:43:59 +000018002004-05-10 Hasso Tepper <hasso@estpak.ee>
1801
1802 * ospf_zebra.c, ospfd.c: Move ospf_prefix_list_update() function
1803 to ospf_zebra.c from ospfd.c and add redistribution updates if
1804 route-map is used in redistribution.
1805 * ospf_main.c: Remove now useless call to ospf_init().
1806
paul0a589352004-05-08 11:48:26 +000018072004-05-08 Paul Jakma <paul@dishone.st>
1808
1809 * ospf_zebra.c: Sync with lib/zclient changes
1810
pauld3f0d622004-05-05 15:27:15 +000018112004-05-05 Paul Jakma <paul@dishone.st>
1812
paul5bd41892004-05-05 17:29:24 +00001813 * ospf_network.c: (ospf_sock_init) Check whether IP_HDRINCL is
1814 defined. Warn at compile and runtime. Use
1815 IPTOS_PREC_INTERNETCONTROL otherwise.
pauld3f0d622004-05-05 15:27:15 +00001816 * ospf_packet.c: (ospf_associate_packet_vl) cleanup, move
1817 some of the checks up to ospf_read, return either a
1818 virtual link oi, or NULL.
1819 (ospf_read) Cleanup, make it responsible for checks. Remove
1820 the nbr lookup - moved to ospf_neighbor. Adjust all nbr
1821 lookups to use new wrappers exported by ospf_neighbor.
1822 * ospf_neighbor.h: Add ospf_neigbour_get and ospf_nbr_lookup.
1823 * ospf_neighbor.c: (ospf_neigbour_get) Index ospf_interface
1824 neighbour table by router-id for virtual-link ospf_interfaces,
1825 not by peer_addr (which breaks for asymmetric vlinks)
1826 (ospf_nbr_lookup) add a wrapper for nbr lookups to deal with
1827 above.
paulcd59da62004-05-05 17:26:55 +00001828 * ospf_interface.c: (ospf_vl_set_params) Catch changes of interface
1829 address for either end of a virtual-link, and hence potential cost
1830 changes.
1831
hassoa0a39762004-04-23 08:51:10 +000018322004-04-22 Hasso Tepper <hasso@estpak.ee>
1833
1834 * ospf_zebra.c: Don't ignore reject/bh routes, it's the only way
1835 to "summarize" routes in ASBR at the moment.
1836
hasso8585d4e2004-04-20 17:25:12 +000018372004-04-20 Hasso Tepper <hasso@estpak.ee>
1838
1839 * ospfd.c: Unset NP flag if area is going to be normal or stub.
1840 Fixes UNH OSPF_NSSA.1.2a comment.
1841 * ospf_abr.c: Originate default into stub/nssa area even if
1842 summaries are disabled.
1843 * ospf_zebra.c: Don't attempt to redistribute 127.0.0.0/8.
1844
hassoc266ac72004-04-19 17:31:00 +000018452004-04-19 Hasso Tepper <hasso@estpak.ee>
1846
1847 * ospf_vty.c: Don't warn that export- and import-list can't be
1848 configured to backbone area if they are applied and are working
1849 fine.
1850
hasso128d31d2004-04-04 12:52:33 +000018512004-02-19 Sowmini Varadhan <sowmini.varadhan@sun.com>
1852
1853 * ospf_packet.c: Don't drop packets in Solaris x86.
1854 [quagga-dev 1005].
1855
hasso0d85b992004-03-18 19:18:33 +000018562004-03-18 Amir Guindehi <amir@datacore.ch>
1857
1858 * ospf_opaque.c: Attempt to correct the incorrect behavior of
1859 Quagga's ospfd in the special situation that a node's opaque
1860 capability has changed as "ON -> OFF -> ON". [quagga-dev 843].
1861
paul7f352b82004-02-19 19:37:47 +000018622004-02-19 Sowmini Varadhan <sowmini.varadhan@sun.com>
1863
1864 * ospf_abr.c: (ospf_abr_update_aggregate) UNH 3.12b,c, address range
1865 should be configured with the highest cost path within the range,
1866 not lowest.
1867
paul940b01a2004-02-17 20:07:30 +000018682004-02-17 Paul Jakma <paul@dishone.st>
1869
1870 * ospf_zebra.c: (ospf_interface_delete) Do not delete the interface
1871 params, nor the interface structure, if an interface delete
1872 message is received from zebra.
1873 * ospf_interface.c: (ospf_if_delete_hook) Delete the interface
1874 params and interface, ie that which was previously removed in
1875 (ospf_interface_delete) above.
1876
hasso2db3d052004-02-11 21:52:13 +000018772004-02-11 Hasso Tepper <hasso@estpak.ee>
1878 * ospf_interface.c, ospf_zebra.c: Don't attempt to read path->oi->ifp
1879 if oi doesn't exist any more.
1880
hassocb05eb22004-02-11 21:10:19 +000018812004-02-11 Vadim Suraev <vadim.suraev@terayon.com>
1882 * ospf_packet.c (ospf_ls_upd): Router should flush received network
1883 LSA if it was originated with older router-id ([zebra 14710] #6).
1884
18852003-12-08 Mattias Amnefelt <mattiasa@kth.se>
paul239aecc2003-12-08 10:34:54 +00001886
1887 * ospf_packet.c: (ospf_recv_packet) OpenBSD now leaves iph.ip_len
1888 network byte order.
1889
gdt8f40e892003-12-05 14:01:43 +000018902003-12-05 Greg Troxel <gdt@poblano.ir.bbn.com>
1891
1892 * ospfd.c (ospf_network_match_iface): Rewrite code for clarity
1893 while trying not to change semantics. Add ifdefed-out code to
1894 avoid matching ppp interfaces whose destination address does not
1895 also match the prefix under consideration, to help out people with
1896 problems due to as-yet-unfixed bugs with p2p interfaces coming and
1897 going.
1898
paul736d3442003-07-24 23:22:57 +000018992003-07-25 kamatchi soundaram <kamatchi@tdd.sj.nec.com>
1900
1901 * ospf_packet.c (ospf_ls_upd_send_queue_event): get next route
1902 node in body of the loop to avoid chance that route node
1903 is unlocked and deleted before the next iteration tries to
1904 get next route node.
1905
paul0a825c72003-05-24 13:48:16 +000019062003-05-24 Kenji Yabuuchi
1907
1908 * ospf_interface.c(ospf_if_lookup_recv_if): Use the most specific
1909 match for interface lookup.
1910
paul551a8972003-05-18 15:22:55 +000019112003-05-18 Hasso Tepper <hasso@estpak.ee>
paul445f1432003-05-16 19:00:31 +00001912
paul551a8972003-05-18 15:22:55 +00001913 * ospf_vty.c: Show NSSA LSA route info in "show ip ospf database"
1914 output
paul445f1432003-05-16 19:00:31 +00001915
pauld7480322003-05-16 17:31:51 +000019162003-05-16 Hasso Tepper <hasso@estpak.ee>
1917
1918 * ospf_lsa.c: Fix handling of NSSA
1919
paul551a8972003-05-18 15:22:55 +000019202003-04-23 Hasso Tepper <hasso@estpak.ee>
1921
1922 * ospf_vty.c: fix "router xxx" node commands in vtysh
1923
paul445f1432003-05-16 19:00:31 +000019242003-04-19 Hasso Tepper <hasso@estpak.ee>
1925
1926 * {ospf_abr,ospfd}.c: area id's DECIMAL -> ADDRESS
1927 * ospf_routemap.c: sync daemon's route-map commands to have same
1928 syntax.
1929
19302003-04-19 Sergey Vyshnevetskiy <serg@vostok.net>
1931
1932 * ospf_packet.c: Add missing param to zlog
1933 * ospf_flood.c: remove unused vars
1934
19352003-04-17 Denis Ovsienko <zebra@pilot.org.ua>
1936
1937 * ospf_interface.c: fix incorrect memset
1938
paul28a13842003-05-16 20:30:37 +000019392003-04-10 Amir Guindehi <amir@datacore.ch>
paul445f1432003-05-16 19:00:31 +00001940
1941 * ospf_lsa.[ch]: opaque LSA fix, use ospf_lookup.
1942
19432003-04-03 David Watson <dwatson@eecs.umich.edu>
1944
1945 * ospf_lsa.c: byte order fix
1946
paul07661cb2003-03-18 00:03:05 +000019472002-03-17 Amir Guindehi <amir@datacore.ch>
1948
1949 * ospf_apiserver.[ch]: Merge Ralph Keller's OSPFAPI support.
1950 * ospf_api.[ch]: Merge Ralph Keller's OSPFAPI support.
1951 * ospfclient: OSPFAPI demonstration client.
1952
19532003-01-23 Masahiko Endo <endo@suri.co.jp>
1954
1955 * ospf_ism.c: NSM event schedule bug fix.
1956
19572002-10-30 Greg Troxel <gdt@ir.bbn.com>
1958
1959 * ospf_packet.c (ospf_make_md5_digest): MD5 length fix.
1960
paul718e3742002-12-13 20:15:29 +000019612002-10-23 endo@suri.co.jp (Masahiko Endo)
1962
1963 * ospf_opaque.c: Update Opaque LSA patch.
1964
19652002-10-23 Ralph Keller <keller@tik.ee.ethz.ch>
1966
1967 * ospf_vty.c (show_ip_ospf_database): Fix CLI parse.
1968
19692002-10-23 Juris Kalnins <juris@mt.lv>
1970
1971 * ospf_interface.c (ospf_if_stream_unset): When write queue
1972 becomes empty stop write timer.
1973
19742002-10-10 Greg Troxel <gdt@ir.bbn.com>
1975
1976 * ospf_packet.c (ospf_check_md5_digest): Change >= to > to make it
1977 conform to RFC.
1978
19792002-07-07 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1980
1981 * zebra-0.93 released.
1982
19832002-06-19 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1984
1985 * ospf_spf.c (ospf_nexthop_calculation): Add NULL set to oi and
1986 check of l2. Reported by: Daniel Drown <dan-zebra@drown.org>
1987 (ospf_lsa_has_link): LSA Length calculation fix. Reported by:
1988 Paul Jakma <paulj@alphyra.ie>.
1989
1990 * ospfd.c (ospf_if_update): Fix nextnode reference bug. Reported
1991 by: juris@mt.lv.
1992
19932002-01-21 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1994
1995 * ospfd.c: Merge [zebra 11445] Masahiko ENDO's Opaque-LSA support.
1996
19972001-08-27 Kunihiro Ishiguro <kunihiro@zebra.org>
1998
1999 * ospf_interface.c (ospf_add_to_if): Use /32 address to register
2000 OSPF interface information.
2001 (ospf_delete_from_if): Likewise.
2002
2003 * ospf_zebra.c (ospf_interface_address_delete): Likewise.
2004
20052001-08-23 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
2006
2007 * ospf_zebra.c (ospf_redistribute_unset): When redistribute type
2008 is OSPF, do not unset redistribute flag.
2009
20102001-08-19 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
2011
2012 * zebra-0.92a released.
2013
20142001-08-15 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
2015
2016 * zebra-0.92 released.
2017
20182001-08-12 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
2019
2020 * ospfd.c (ospf_config_write): auto-cost reference-bandwidth
2021 configuration display.
2022
20232001-07-24 David Watson <dwatson@eecs.umich.edu>
2024
2025 * ospf_spf.c (ospf_spf_next): Modify ospf_vertex_add_parent to
2026 check for an existing link before connecting the parent and child.
2027 ospf_nexthop_calculation is also modified to check for duplicate
2028 entries when copying from the parent. Finally, ospf_spf_next
2029 removes duplicates when it merges two equal cost candidates.
2030
20312001-07-23 itojun@iijlab.net
2032
2033 * ospfd.c (show_ip_ospf_neighbor): Check ospf_top before use it
2034 [zebra 8549].
2035
20362001-07-23 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
2037
2038 * ospf_packet.c (ospf_write): Remove defined(__OpenBSD__) to make
2039 it work on OpenBSD.
2040
20412001-06-26 Kunihiro Ishiguro <kunihiro@zebra.org>
2042
2043 * ospf_zebra.c (config_write_ospf_default_metric): Display
2044 default-metric configuration.
2045
20462001-06-18 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
2047
2048 * ospf_ia.h (OSPF_EXAMINE_SUMMARIES_ALL): Remove old macros.
2049
20502001-05-28 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
2051
2052 * ospf_snmp.c (ospfIfEntry): Fix interface lookup bug to avoid
2053 crush.
2054 (ospfIfMetricEntry): Likewise.
2055
20562001-03-18 Kunihiro Ishiguro <kunihiro@zebra.org>
2057
2058 * ospf_packet.c (ospf_read): Fix typo. Reported by: "Jen B
2059 Lin'Kova" <jen@stack.net>.
2060
20612001-03-15 Gleb Natapov <gleb@nbase.co.il>
2062
2063 * ospf_interface.c (ip_ospf_network): Set interface parameter.
2064 (interface_config_write): Add check for OSPF_IFTYPE_LOOPBACK.
2065
2066 * ospf_zebra.c (ospf_interface_add): Set interface parameter.
2067
20682001-02-21 Kunihiro Ishiguro <kunihiro@zebra.org>
2069
2070 * ospf_packet.c (ospf_recv_packet): Solaris also need to add
2071 (iph.ip_hl << 2) to iph.ip_len.
2072
20732001-02-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2074
2075 * ospfd.h (OSPF_LS_REFRESH_TIME): Fix OSPF_LS_REFRESH_TIME value.
2076 Suggested by: David Watson <dwatson@eecs.umich.edu>.
2077
2078 * ospf_zebra.c (zebra_init): Remove zebra node.
2079
2080 * ospfd.c (ospf_area_range_set): Function name is changed from
2081 ospf_ara_range_cmd.
2082 (ospf_area_range_unset): New function which separated from DEFUN.
2083 New commands are added:
2084 "no area A.B.C.D range A.B.C.D/M advertise"
2085 "no area <0-4294967295> range A.B.C.D/M advertise"
2086 "no area A.B.C.D range A.B.C.D/M not-advertise"
2087 "no area <0-4294967295> range A.B.C.D/M not-advertise"
2088
2089 * ospf_lsa.c (ospf_lsa_more_recent): Fix previous change.
2090
20912001-02-08 Matthew Grant <grantma@anathoth.gen.nz>
2092
2093 * ospf_network.c (ospf_if_add_allspfrouters): Use
2094 setsockopt_multicast_ipv4.
2095 (ospf_if_drop_allspfrouters): Likewise.
2096
2097 * ospf_lsa.c (ospf_router_lsa_install): Add rt_recalc flag.
2098 (ospf_network_lsa_install): Likewise.
2099 (ospf_summary_lsa_install): Likewise.
2100 (ospf_summary_asbr_lsa_install): Likewise.
2101 (ospf_external_lsa_install): Likewise.
2102 (ospf_lsa_install): Call ospf_lsa_different to check this LSA is
2103 new one or not.
2104
21052001-02-08 Kunihiro Ishiguro <kunihiro@zebra.org>
2106
2107 * ospf_zebra.c (ospf_interface_delete): Do not free interface
2108 structure when ospfd receive interface delete message to support
2109 pseudo interface.
2110
21112001-02-01 Dick Glasspool <dick@ipinfusion.com>
2112
2113 * ospfd.c (area_range_notadvertise): Change area range "suppress"
2114 command to "not-advertise".
2115
2116 * ospfd.h (OSPF_LS_REFRESH_TIME): Change OSPF_LS_REFRESH_TIME from
2117 1800 to 60.
2118
2119 * ospf_abr.c (ospf_abr_update_aggregate): When update_aggregate is
2120 updating the area-range, the lowest cost is now saved.
2121
2122 * ospf_lsa.c (ospf_lsa_more_recent): Routing to compare sequence
2123 numbers rather than creating overflow during calculation.
2124
21252001-02-01 Kunihiro Ishiguro <kunihiro@zebra.org>
2126
2127 * zebra-0.91 is released.
2128
21292001-01-31 Kunihiro Ishiguro <kunihiro@zebra.org>
2130
2131 * ospf_packet.c (ospf_db_desc_proc): Do not continue process when
2132 NSM_SeqNumberMismatch is scheduled.
2133 (ospf_ls_req): Free ls_upd when return from this function.
2134 (ospf_ls_upd_timer): When update list is empty do not call
2135 ospf_ls_upd_send(). Suggested by: endo@suri.co.jp (Masahiko
2136 Endo).
2137
21382001-01-26 Kunihiro Ishiguro <kunihiro@zebra.org>
2139
2140 * ospf_lsa.c (ospf_maxage_flood): Flood LSA when it reaches
2141 MaxAge. RFC2328 Section 14.
2142 (ospf_maxage_lsa_remover): Call above function during removing
2143 MaxAge LSA.
2144
21452001-01-26 Dick Glasspool <dick@ipinfusion.com>
2146
2147 * ospf_flood.c (ospf_flood_through_as): Function is updated for
2148 NSSA Translations now done at ospf_abr.c with no change in P-bit.
2149
2150 * ospf_lsa.c (ospf_get_nssa_ip): Get 1st IP connection for Forward
2151 Addr.
2152 (ospf_install_flood_nssa): Leave Type-7 LSA at Lock Count = 2.
2153
2154 * ospf_ase.c (ospf_ase_calculate_route): Add debug codes.
2155
2156 * ospf_abr.c (ospf_abr_translate_nssa): Recalculate LSA checksum.
2157
2158 * ospf_packet.h (OSPF_SEND_PACKET_LOOP): Added for test packet.
2159
2160 * ospf_dump.c (ospf_lsa_type_msg): Add OSPF_GROUP_MEMBER_LSA and
2161 OSPF_AS_NSSA_LSA.
2162
2163 * ospfd.c (data_injection): Function to inject LSA. This is
2164 debugging command.
2165
21662001-01-11 Kunihiro Ishiguro <kunihiro@zebra.org>
2167
2168 * ospf_route.c (ospf_route_match_same): Remove function.
2169 (ospf_route_match_same_new): Renamed to ospf_route_match_same.
2170
2171 * ospf_zebra.c (ospf_interface_address_delete): Add check for
2172 oi->address. Suggested by Matthew Grant
2173 <grantma@anathoth.gen.nz>.
2174 (ospf_zebra_add): Remove function.
2175 (ospf_zebra_add_multipath): Rename to ospf_zebra_add.
2176
2177 * ospf_interface.c: Remove HAVE_IF_PSEUDO part.
2178
2179 * ospf_zebra.c: Likewise.
2180
21812001-01-10 Kunihiro Ishiguro <kunihiro@zebra.org>
2182
2183 * ospf_ase.c: Remove OLD_RIB part.
2184
2185 * ospf_route.c: Likewise.
2186
2187 * zebra-0.90 is released.
2188
2189 * ospf_packet.c (ospf_recv_packet): Use ip_len adjestment code to
2190 NetBSD.
2191
21922001-01-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2193
2194 * ospf_route.c (ospf_route_delete): Use
2195 ospf_zebra_delete_multipath.
2196
21972001-01-09 Matthew Grant <grantma@anathoth.gen.nz>
2198
2199 * ospf_interface.c (ospf_if_cleanup): Function name is renamed
2200 from ospf_if_free(). Rewrite whole procudure to support primary
2201 address deletion.
2202
2203 * ospf_zebra.c (ospf_interface_address_delete): Add primary
2204 address deletion process.
2205
22062001-01-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2207
2208 * ospf_packet.c (ospf_recv_packet): OpenBSD has same ip_len
2209 treatment like FreeBSD.
2210
22112001-01-09 endo@suri.co.jp (Masahiko Endo)
2212
2213 * ospf_packet.c (ospf_recv_packet): FreeBSD kernel network code
2214 strips IP header size from receiving IP Packet. So we adjust
2215 ip_len to whole IP packet size by adding IP header size.
2216
22172001-01-08 endo@suri.co.jp (Masahiko Endo)
2218
2219 * ospf_network.c (ospf_serv_sock): When socket() is failed return
2220 immediately.
2221 (ospf_serv_sock): Close socket when it is not used.
2222
2223 * ospf_packet.c (ospf_write): Set sin_len when HAVE_SIN_LEN is
2224 defined.
2225 (ospf_write): When bind is fined, close sock.
2226
22272001-01-07 Gleb Natapov <gleb@nbase.co.il>
2228
2229 * ospf_zebra.c (ospf_interface_state_up): Fixes coredump that
2230 appears when you try to configure bandwidth on the ppp interface
2231 that is not yet configured in ospfd.
2232
22332001-01-07 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2234
2235 * ospf_route.c (show_ip_ospf_route_external): "show ip ospf route"
2236 will print nexthops for AS-external routes.
2237
2238 * ospf_ase.c (ospf_ase_route_match_same): New function to compare
2239 ASE route under multipath environment.
2240 (ospf_ase_compare_tables): Likewise.
2241
22422001-01-01 Kunihiro Ishiguro <kunihiro@zebra.org>
2243
2244 * ospfd.h (OSPF_VTYSH_PATH): Change "/tmp/ospfd" to "/tmp/.ospfd".
2245
22462000-12-28 Kunihiro Ishiguro <kunihiro@zebra.org>
2247
2248 * ospf_route.c (ospf_route_install): Install multipath information
2249 to zebra daemon.
2250
2251 * ospf_zebra.c (ospf_zebra_add_multipath): Function for passing
2252 multipath information to zebra daemon.
2253
22542000-12-25 Dick Glasspool <dick@ipinfusion.com>
2255
2256 * ospf_packet.c (ospf_write): Call ospf_packet_delete when sendto
2257 fail.
2258 (DISCARD_LSA): Add argument N for logging point of DISCARD_LSA is
2259 called.
2260
2261 * ospf_lsa.c (ospf_external_lsa_refresh): NSSA install_flood will
2262 leave Type-7 LSA at Lock Count = 2.
2263
2264 * ospf_flood.c (ospf_flood_through): Flood_though_as updated for
2265 NSSA no P-bit off during Area flooding, but P-bit is turned off
2266 for mulitple NSSA AS flooding.
2267
2268 * ospf_ase.c (ospf_ase_calculate_timer): Added calculations for
2269 Type-7 LSDB.
2270
2271 * ospf_abr.c (ospf_abr_translate_nssa): Removed one unlock call.
2272 (ospf_abr_announce_nssa_defaults): Corrected Debug from EVENT to
2273 NSSA.
2274
22752000-12-25 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2276
2277 * ospf_zebra.c (ospf_zebra_read_ipv4): Checking the age of the
2278 found LSA and if the LSA is MAXAGE we should call refresh instead
2279 of originate.
2280
22812000-12-18 Dick Glasspool <dick@ipinfusion.com>
2282
2283 * ospf_abr.c: Removed redundant "...flood" in
2284 announce_network_to_area(). Repaired nssa Unlock by using
2285 discard.
2286
2287 * ospf_packet.c: Removed old NSSA translate during mk_ls_update.
2288
2289 * ospfd.c: Free up all data bases including NSSA.
2290
2291 * ospf_lsa.c: Now allow removal of XLATE LSA's Check in
2292 discard_callback. Added routine to get ip addr from within the
2293 ifp.
2294
2295 * ospf_flood.c: Now set Forward Address for outgoing Type-7.
2296
2297 * ospf_lsa.h: Added prototype for the below. struct in_addr
2298 ospf_get_ip_from_ifp (struct interface *ifp).
2299
23002000-12-14 Gleb Natapov <gleb@nbase.co.il>
2301
2302 * ospf_packet.c (ospf_recv_packet): New OSPF pakcet read method.
2303 Now maximum packet length may be 65535 bytes (maximum IP packet
2304 length).
2305
2306 * ospf_interface.c (ospf_if_stream_set): Don't make input buffer.
2307
2308 * ospfd.c (config_write_network_area): Remove unnecessary area
2309 lookup code.
2310
23112000-12-13 Kunihiro Ishiguro <kunihiro@zebra.org>
2312
2313 * ospf_packet.c (ospf_read): Accept packet bigger than MTU value.
2314
23152000-12-13 Gleb Natapov <gleb@nbase.co.il>
2316
2317 * ospfd.c (config_write_network_area): Fix bug in
2318 config_write_network_area function.
2319
23202000-12-12 Gleb Natapov <gleb@nbase.co.il>
2321
2322 * ospf_abr.c (ospf_abr_announce_network_to_area): Make Summary
2323 LSA's origination and refreshment as same as other type of LSA.
2324
2325 * ospf_lsa.c (ospf_summary_lsa_refresh): Return struct ospf_lsa *.
2326
2327 * ospf_lsa.c (ospf_summary_asbr_lsa_refresh): Likewise.
2328
23292000-12-08 Dick Glasspool <dick@ipinfusion.com>
2330
2331 The bulk of NSSA changes are contained herein; This version will
2332 require manual setting of "always" for NSSA Translator, and will
2333 not perform aggregation yet.
2334
2335 * ospf_dump.c: "debug ospf nssa" is added.
2336
2337 * ospf_dump.h: Likewise.
2338
2339 * ospf_packet.c (ospf_hello): Display router ID on Bad NSSA Hello.
2340
2341 * ospfd.c: Discard_LSA to stay away from LOCAL_XLT Process NSSA
2342 'never, candidate, always'. Change "suppress" to "not-advertise".
2343
2344 * ospfd.h: Add TranslatorRole to struct ospf_area. Add anyNSSA to
2345 struct ospf.
2346
2347 * ospf_ase.c (ospf_ase_calculate_route): External to stay away
2348 from LOCAL_XLT
2349
2350 * ospf_nsm.c (ospf_db_summary_add): External to stay away from
2351 LOCAL_XLT
2352
2353 * ospf_abr.c: Major logic added for abr_nssa_task(). If ABR, and
2354 NSSA translator, then do it. Approve the global list, and flush
2355 any unapproved.
2356
2357 * ospf_lsa.h: New LSA flag OSPF_LSA_LOCAL_XLT to indicate that the
2358 Type-5 resulted from a Local Type-7 translation; not used for
2359 flooding, but used for flushing.
2360
2361 * ospf_flood.c: New NSSA flooding.
2362
23632000-12-08 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2364
2365 * ospfd.c (ospf_find_vl_data): New function for looking up virtual
2366 link data.
2367 (ospf_vl_set_security): Virtual link configuration with
2368 authentication.
2369 (ospf_vl_set_timers): Set timers for virtual link.
2370
2371 * New commands are added.
2372 "area A.B.C.D virtual-link A.B.C.D"
2373 "area A.B.C.D virtual-link A.B.C.D hello-interval <1-65535> retransmit-interval <3-65535> transmit-delay <1-65535> dead-interval <1-65535>"
2374 "area A.B.C.D virtual-link A.B.C.D hello-interval <1-65535> retransmit-interval <3-65535> transmit-delay <1-65535> dead-interval <1-65535> authentication-key AUTH_KEY"
2375 "area A.B.C.D virtual-link A.B.C.D authentication-key AUTH_KEY"
2376 "area A.B.C.D virtual-link A.B.C.D hello-interval <1-65535> retransmit-interval <3-65535> transmit-delay <1-65535> dead-interval <1-65535> message-digest-key <1-255> md5 KEY"
2377 "area A.B.C.D virtual-link A.B.C.D message-digest-key <1-255> md5 KEY"
2378
2379 * ospf_packet.c (ospf_check_md5_digest): Add neighbor's
2380 cryptographic sequence number treatment.
2381 (ospf_check_auth): OSPF input buffer is added to argument.
2382 (ospf_read): Save neighbor's cryptographic sequence number.
2383
2384 * ospf_nsm.c (nsm_change_status): Clear cryptographic sequence
2385 number when neighbor status is changed to NSM down.
2386
2387 * ospf_neighbor.c (ospf_nbr_new): Set zero to crypt_seqnum.
2388
2389 * ospf_neighbor.h (struct ospf_neighbor): Add cryptographic
2390 sequence number to neighbor structure.
2391
23922000-11-29 Kunihiro Ishiguro <kunihiro@zebra.org>
2393
2394 * ospf_snmp.c (ospfIfLookup): OSPF MIB updates.
2395 (ospfExtLsdbEntry): Add OspfExtLsdbTable treatment.
2396
23972000-11-28 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2398
2399 * ospfd.c (ospf_interface_down): Clear a ls_upd_queue queue of the
2400 interface.
2401 (ospf_ls_upd_queue_empty): New function to empty ls update queue
2402 of the OSPF interface.
2403 (no_router_ospf): 'no router ospf' unregister redistribution
2404 requests from zebra.
2405
24062000-11-28 Kunihiro Ishiguro <kunihiro@zebra.org>
2407
2408 * ospf_ism.c (ism_change_status): Increment status change number.
2409
2410 * ospf_interface.h (struct ospf_interface): Add new member for
2411 status change statistics.
2412
2413 * Makefile.am: Update dependencies.
2414
2415 * ospf_zebra.c (ospf_interface_add): OSPF SNMP interface update.
2416 (ospf_interface_delete): OSPF SNMP interface delete.
2417
2418 * ospf_snmp.h: New file is added.
2419
24202000-11-23 Dick Glasspool <dick@ipinfusion.com>
2421
2422 * ospfd.h: Add new ospf_area structure member for
2423 NSSATranslatorRole and NSSATranslator state.
2424
2425 * ospfd.c: Provided for eventual commands to specify NSSA
2426 elections for "translator- ALWAYS/NEVER/CANDIDATE". Provided for
2427 decimal integer version of area-suppress.
2428
2429 * ospf_flood.c: Flood Type-7's only into NSSA (not AS).
2430
2431 * ospf_lsa.c: Undo some previous changes for NSSA. If NSSA
2432 translator, advertise Nt bit.
2433
2434 * ospf_route.c: 1st version of "sh ip os border-routers".
2435
24362000-11-23 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2437
2438 * ospfd.c (area_vlink): Virtual link can not configured in stub
2439 area.
2440
24412000-11-23 Gleb Natapov <gleb@nbase.co.il>
2442
2443 * ospf_packet.c (ospf_db_desc): In states Loading and Full the
2444 slave must resend its last Database Description packet in response
2445 to duplicate Database Description packets received from the
2446 master. For this reason the slave must wait RouterDeadInterval
2447 seconds before freeing the last Database Description packet.
2448 Reception of a Database Description packet from the master after
2449 this interval will generate a SeqNumberMismatch neighbor
2450 event. RFC2328 Section 10.8
2451 (ospf_make_db_desc): DD Master flag treatment.
2452
2453 * ospf_nsm.c (nsm_twoway_received): Move DD related procedure to
2454 nsm_change_status().
2455 (nsm_bad_ls_req): Likewise.
2456 (nsm_adj_ok): Likewise.
2457 (nsm_seq_number_mismatch): Likewise.
2458 (nsm_oneway_received): Likewise.
2459
2460 * ospf_neighbor.h (struct ospf_neighbor): New structure member
2461 last_send_ts for timestemp when last Database Description packet
2462 was sent.
2463
2464 * ospf_nsm.c (ospf_db_desc_timer): Make it sure nbr->last_send is
2465 there. Call ospf_db_desc_resend() in any case.
2466
24672000-11-16 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2468
2469 * ospf_lsa.c (lsa_link_broadcast_set): When there is no DR on
2470 network (suppose you have only one router with interface priority
2471 0). It's router LSA does not contain the link information about
2472 this network.
2473
2474 * ospf_nsm.c (nsm_timer_set): When you change a priority of
2475 interface from/to 0 ISM_NeighborChange event should be scheduled
2476 in order to elect new DR/BDR on the network.
2477
2478 * ospf_interface.c (ip_ospf_priority): Likewise.
2479
2480 * ospf_flood.c (ospf_ls_retransmit_add): When we add some LSA into
2481 retransmit list we need to check whether the present old LSA in
2482 retransmit list is not more recent than the new
2483 one.
2484
24852000-11-09 Dick Glasspool <dick@ipinfusion.com>
2486
2487 * ospf_packet.c: Allows for NSSA Type-7 LSA's throughout the NSSA
2488 area. Any that exit the NSSA area are translated to type-5 LSA's.
2489 The instantiated image is restored after translation.
2490 (ospf_ls_upd_send_list): Renamed to ospf_ls_upd_queu_send().
2491 (ospf_ls_upd_send): Old function which enclosed by #ifdef 0 is
2492 removed.
2493 (ospf_ls_ack_send): Likewise.
2494
2495 * ospf_flood.c: NSSA-LSA's without P-bit will be restricted to
2496 local area. Otherwise they are allowed out the area to be
2497 translated by ospf_packet.c.
2498
2499 * ospf_lsa.c: Undo some previous changes for NSSA.
2500
2501 * ospf_lsdb.h: New access for type 7.
2502
25032000-11-07 Kunihiro Ishiguro <kunihiro@zebra.org>
2504
2505 * ospf_route.c (ospf_path_exist): New function to check nexthop
2506 and interface are in current OSPF path or not.
2507 (ospf_route_copy_nexthops_from_vertex): Add nexthop to OSPF path
2508 when it is not there. Reported by Michael Rozhavsky
2509 <mrozhavsky@opticalaccess.com>
2510
25112000-11-06 Kunihiro Ishiguro <kunihiro@zebra.org>
2512
2513 * ospf_dump.c (config_write_debug): Add seventh string "detail" is
2514 added for flag is OSPF_DEBUG_SEND | OSPF_DEBUG_RECV |
2515 OSPF_DEBUG_DETAIL.
2516
25172000-11-06 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2518
2519 * ospf_lsa.c (router_lsa_flags): ASBR can't exit in stub area.
2520
25212000-11-06 Kunihiro Ishiguro <kunihiro@zebra.org>
2522
2523 * ospf_lsa.c (ospf_router_lsa_originate): Reduce unconditional
2524 logging.
2525
25262000-11-06 Dick Glasspool <dick@ipinfusion.com>
2527
2528 * ospfd.h: Add ait_ntoa function prototype.
2529
2530 * ospfd.c (ait_ntoa): New function for displaying area ID and
2531 Stub/NSSA status.
2532 (show_ip_ospf_interface_sub): Use ait_ntoa.
2533 (show_ip_ospf_nbr_static_detail_sub): Likewise.
2534 (show_ip_ospf_neighbor_detail_sub): Likewise.
2535
2536 * ospf_route.c (ospf_intra_route_add): Set external routing type
2537 to ospf route.
2538 (ospf_intra_add_router): Likewise.
2539 (ospf_intra_add_transit): Likewise.
2540 (ospf_intra_add_stub): Likewise.
2541 (ospf_add_discard_route): Likewise.
2542 (show_ip_ospf_route_network): Use ait_ntoa.
2543 (show_ip_ospf_route_network): Likewise.
2544 (show_ip_ospf_route_router): Likewise.
2545
2546 * ospf_lsa.c (show_lsa_detail): Use ait_ntoa.
2547 (show_lsa_detail_adv_router): Likewise.
2548 (show_ip_ospf_database_summary): Likewise.
2549
2550 * ospf_route.h (struct route_standard): Add new member
2551 external_routing.
2552
2553 * ospf_ia.c (process_summary_lsa): Set external routing tyep to ospf
2554 route.
2555 (ospf_update_network_route): Likewise.
2556 (ospf_update_router_route): Likewise.
2557
25582000-11-04 Kunihiro Ishiguro <kunihiro@zebra.org>
2559
2560 * ospf_flood.c (ospf_process_self_originated_lsa): Enclose
2561 OSPF_AS_NSSA_LSA treatment with #ifdef HAVE_NSSA.
2562
25632000-11-03 Kunihiro Ishiguro <kunihiro@zebra.org>
2564
2565 * Unconditional logging is enclosed with if (IS_DEBUG_OSPF_EVENT).
2566 Please specify "debug ospf event" for enable logging.
2567
2568 * ospf_ism.c: Do not extern debug flag varible. It is done by
2569 ospf_debug.h
2570 * ospf_asbr.c: Likewise.
2571 * ospf_lsa.c: Likewise.
2572 * ospf_nsm.c: Likewise.
2573 * ospf_zebra.c: Likewise.
2574
2575 * ospf_dump.c (debug_ospf_event): New command "debug ospf event"
2576 is added.
2577
2578 * ospfd.c (router_ospf): Change logging from vty_out() to
2579 zlog_info().
2580 (ospf_area_stub_cmd): Likewise.
2581
2582 * ospf_dump.h: Extern term_debug flags.
2583 (OSPF_DEBUG_EVENT): Add new flag.
2584 (IS_DEBUG_OSPF_EVENT): Add new macro.
2585
25862000-11-03 Dick Glasspool <dick@ipinfusion.com>
2587
2588 * ospf_flood.c (ospf_process_self_originated_lsa):
2589 OSPF_AS_NSSA_LSA is treated as same as OSPF_AS_EXTERNAL_LSA.
2590 (ospf_flood): Type-5's have no change. Type-7's can be received,
2591 and will Flood the AS as Type-5's They will also flood the local
2592 NSSA Area as Type-7's. The LSDB will be updated as Type-5's, and
2593 during re-fresh will be converted back to Type-7's (if within an
2594 NSSA).
2595 (ospf_flood_through): Incoming Type-7's were allowed here if our
2596 neighbor was an NSSA. So Flood our area with the Type-7 and also
2597 if we are an ABR, flood thru AS as Type-5.
2598
2599 * ospf_lsa.c (ospf_external_lsa_refresh): Flood NSSA both NSSA
2600 area and other area.
2601
2602 * ospf_packet.c (ospf_db_desc_proc): When AS External LSA is
2603 exists in DD packet, make it sure that this area is not stub.
2604 (ospf_ls_upd_list_lsa): When LSA type is NSSA then set lsa's area
2605 to NULL.
2606 (ospf_ls_upd): If the LSA is AS External LSA and the area is stub
2607 then discard the lsa. If the LSA is NSSA LSA and the area is not
2608 NSSA then discard the lsa.
2609
26102000-11-03 Kunihiro Ishiguro <kunihiro@zebra.org>
2611
2612 * ospfd.c (ospf_interface_run): Fix bug of Hello packet's option
2613 is not properly set when interface comes up.
2614
26152000-11-02 Kunihiro Ishiguro <kunihiro@zebra.org>
2616
2617 * ospfd.h (OSPF_OPTION_O): Add new hello header option.
2618
26192000-11-01 Dick Glasspool <dick@ipinfusion.com>
2620
2621 * ospf_lsa.h: Define OSPF_MAX_LSA to 8 when HAVE_NSSA is enabled.
2622 (OSPF_GROUP_MEMBER_LSA): Define OSPF_GROUP_MEMBER_LSA.
2623
2624 * ospf_lsa.c (show_database_desc): Add "Group Membership LSA"
2625 string.
2626
26272000-10-31 Dick Glasspool <dick@ipinfusion.com>
2628
2629 * ospf_lsa.h (OSPF_AS_NSSA_LSA): Define OSPF_AS_NSSA_LSA.
2630
2631 * ospf_lsa.c (show_ip_ospf_database): NSSA database display
2632 function is added. ALIASES which have "show ip ospf database
2633 nssa-external" is added.
2634 (show_ip_ospf_border_routers): New command "show ip ospf
2635 border-routers" is added.
2636
26372000-10-30 Dick Glasspool <dick@ipinfusion.com>
2638
2639 * ospfd.c (router_ospf): NSSA Enabled message is added for
2640 testing.
2641 (ospf_area_type_set): Are type set for NSSA area.
2642 (ospf_area_stub_cmd): Special translation of no_summary into NSSA
2643 and summary information. If NSSA is enabled pass the information
2644 to ospf_area_type_set().
2645 (area_nssa): New commands are added:
2646 "area A.B.C.D nssa"
2647 "area <0-4294967295> nssa"
2648 "area A.B.C.D nssa no-summary"
2649 "area <0-4294967295> nssa no-summary"
2650 (ospf_no_area_stub_cmd): Special translation of no_summary into
2651 NSSA and summary information. If external_routing is
2652 OSPF_AREA_NSSA unset area with ospf_area_type_set (area,
2653 OSPF_AREA_DEFAULT).
2654 (show_ip_ospf_area): Display NSSA status.
2655 (config_write_ospf_area): Show NSSA configuration.
2656
2657 * ospf_packet.c (ospf_hello): For NSSA support, ensure that NP is
2658 on and E is off.
2659
26602000-10-26 Gleb Natapov <gleb@nbase.co.il>
2661
2662 * ospf_lsa.c (ospf_network_lsa_body_set): The network-LSA lists
2663 those routers that are fully adjacent to the Designated Router;
2664 each fully adjacent router is identified by its OSPF Router ID.
2665 The Designated Router includes itself in this list. RFC2328,
2666 Section 12.4.2.
2667
26682000-10-23 Jochen Friedrich <jochen@scram.de>
2669
2670 * ospf_snmp.c: ospf_oid and ospfd_oid are used in smux_open after
2671 it is registered. So those variables must be static.
2672
26732000-10-18 K N Sridhar <sridhar@euler.ece.iisc.ernet.in>
2674
2675 * ospfd.c: Add area_default_cost_decimal_cmd and
2676 no_area_default_cost_decimal_cmd alias.
2677
26782000-10-05 Gleb Natapov <gleb@nbase.co.il>
2679
2680 * ospfd.c (ospf_network_new): Fix setting area format.
2681 (no_router_ospf): Check area existance when calling
2682 ospf_interface_down().
2683
2684 * ospf_flood.c (ospf_external_info_check): Fix bug of refreshing
2685 default route.
2686
26872000-10-02 Kunihiro Ishiguro <kunihiro@zebra.org>
2688
2689 * zebra-0.89 is released.
2690
26912000-09-29 Kunihiro Ishiguro <kunihiro@zebra.org>
2692
2693 * ospf_snmp.c (ospfHostEntry): OSPF Host MIB is implemented.
2694
2695 * ospfd.c (ospf_nbr_static_cmp): OSPF neighbor is sorted by it's
2696 address.
2697
26982000-09-28 Michael Rozhavsky <mike@nbase.co.il>
2699
2700 * ospf_interface.c (ospf_if_free): Fix deleting self neighbor twice.
2701
27022000-09-27 Kunihiro Ishiguro <kunihiro@zebra.org>
2703
2704 * ospf_packet.c (ospf_read): Solaris on x86 has ip_len with host
2705 byte order.
2706
27072000-09-25 Toshiaki Takada <takada@zebra.org>
2708
2709 * ospfd.c (ospf_compatible_rfc1583), (no_ospf_compatible_rfc1583):
2710 Add CISCO compatible command.
2711
27122000-09-25 Kunihiro Ishiguro <kunihiro@zebra.org>
2713
2714 * ospf_abr.c (ospf_area_range_lookup): New function is added for
2715 area range lookup in OSPF-MIB.
2716 (ospf_area_range_lookup_next): Likewise.
2717
27182000-09-22 Kunihiro Ishiguro <kunihiro@zebra.org>
2719
2720 * ospfd.c (no_router_ospf): Delete virtual link before deleting
2721 area structure.
2722
2723 * ospf_lsa.c (ospf_external_lsa_refresh_type): Check
2724 EXTERNAL_INFO(type).
2725
2726 * ospfd.c (no_router_ospf): Call ospf_vl_delete() instead of
2727 ospf_vl_data_free().
2728
2729 * ospf_interface.c (ospf_vl_shutdown): Execute ISM_InterfaceDown
2730 when ospf_vl_shutdown is called.
2731 (ospf_vl_delete): Call ospf_vl_shutdown() to delete virtual link
2732 interface's thread.
2733
27342000-09-21 Gleb Natapov <gleb@nbase.co.il>
2735
2736 * ospf_lsa.c: New implementation of OSPF refresh.
2737
27382000-09-20 Kunihiro Ishiguro <kunihiro@zebra.org>
2739
2740 * ospf_snmp.c (ospfLsdbLookup): Add LSDB MIB implementation.
2741
27422000-09-18 Kunihiro Ishiguro <kunihiro@zebra.org>
2743
2744 * ospf_snmp.c (ospfStubAreaEntry): Add OSPF stub area MIB.
2745
27462000-09-18 Gleb Natapov <gleb@nbase.co.il>
2747
2748 * ospf_route.h (route_standard): Change member from `struct area'
2749 to area_id.
2750
2751 * ospf_abr.c (ospf_abr_announce_network), (ospf_abr_should_announce),
2752 (ospf_abr_process_network_rt), (ospf_abr_announce_rtr),
2753 (ospf_abr_process_router_rt):
2754 * ospf_ase.c (ospf_find_asbr_route),
2755 (ospf_find_asbr_router_through_area),
2756 * ospf_ia.c (ospf_find_abr_route), (ospf_ia_router_route),
2757 (process_summary_lsa), (ospf_update_network_route),
2758 (ospf_update_router_route):
2759 * ospf_route.c (ospf_intra_route_add), (ospf_intra_add_router),
2760 (ospf_intra_add_transit), (ospf_intra_add_stub),
2761 (ospf_route_table_dump), (show_ip_ospf_route_network),
2762 (show_ip_ospf_route_router), (ospf_asbr_route_cmp),
2763 (ospf_prune_unreachable_routers):
2764 * ospf_spf.c (ospf_rtrs_print):
2765 * ospfd.c (ospf_rtrs_free): Fix the struct change above.
2766
27672000-09-14 Kunihiro Ishiguro <kunihiro@zebra.org>
2768
2769 * ospf_network.c (ospf_serv_sock_init): Enclose SO_BINDTODEVICE
2770 with ifdef.
2771
27722000-09-13 Gleb Natapov <gleb@nbase.co.il>
2773
2774 * ospf_ism.c (ospf_elect_dr), (ospf_elect_bdr): Fix DR election.
2775
2776 * ospf_network.c (ospf_serv_sock_init): Add socket option
2777 SO_BINDTODEVICE on read socket.
2778
2779 * ospf_packet.c (ospf_hello): Ignore Hello packet if E-bit does
2780 not match.
2781
2782 * ospfd.c (ospf_area_check_free), (ospf_area_get),
2783 (ospf_area_add_if): New function added.
2784
27852000-09-13 Kunihiro Ishiguro <kunihiro@zebra.org>
2786
2787 * ospf_route.c (ospf_intra_add_router): Update ABR and ASBR router
2788 count.
2789
2790 * ospf_spf.c (ospf_spf_init): Rest ABR and ASBR router count
2791 starting SPF calculation.
2792
2793 * ospfd.h (struct ospf_area): Add ABR and ASBR router count.
2794
27952000-09-12 Kunihiro Ishiguro <kunihiro@zebra.org>
2796
2797 * ospfd.c (ospf_area_id_cmp): New area structure is sorted by area
2798 ID.
2799
2800 * ospf_lsa.c (ospf_router_lsa_originate): For OSPF MIB update
2801 lsa_originate_count.
2802 (ospf_network_lsa_originate): Likewise.
2803 (ospf_summary_lsa_originate): Likewise.
2804 (ospf_summary_asbr_lsa_originate): Likewise.
2805 (ospf_external_lsa_originate): Likewise.
2806
28072000-09-11 Kunihiro Ishiguro <kunihiro@zebra.org>
2808
2809 * ospf_snmp.c (ospf_variables): ospfRouterID's type RouterID
2810 syntax is IpAddress.
2811 (ospf_admin_stat): New function for OSPF administrative status
2812 check.
2813
28142000-09-10 Jochen Friedrich <jochen@scram.de>
2815
2816 * ospf_snmp.c: Implement OSPF MIB skeleton.
2817
28182000-09-08 Kunihiro Ishiguro <kunihiro@zebra.org>
2819
2820 * ospf_snmp.c: New file is added.
2821
28222000-09-07 David Lipovkov <davidl@nbase.co.il>
2823
2824 * ospf_zebra.c (ospf_interface_delete): Add pseudo interface
2825 treatment.
2826
2827 * ospf_interface.c (interface_config_write): Likewise.
2828
28292000-08-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2830
2831 * zebra-0.88 is released.
2832
28332000-08-17 Michael Rozhavsky <mike@nbase.co.il>
2834
2835 * ospfd.c (ospf_area_free): Remove virtual link configuration only
2836 when Area is removed.
2837
28382000-08-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2839
2840 * ospfd.c (network_area): Revert check for EXTERNAL_INFO
2841 (ZEBRA_ROUTE_CONNECT).
2842 (no_network_area): Likewise.
2843
28442000-08-16 Kunihiro Ishiguro <kunihiro@zebra.org>
2845
2846 * ospfd.h (struct ospf): Add distance_table and
2847 distance_{all,intra,inter,external}.
2848
2849 * ospf_zebra.c: Add OSPF distance related functions.
2850
28512000-08-15 Gleb Natapov <gleb@nbase.co.il>
2852
2853 * ospf_asbr.c (ospf_external_info_find_lsa): New function added.
2854
2855 * ospf_lsa.c (ospf_default_external_info),
2856 (ospf_default_originate_timer), (ospf_external_lsa_refresh_default):
2857 New function added.
2858
2859 * ospf_zebra.c
2860 (ospf_default_information_originate_metric_type_routemap),
2861 (ospf_default_information_originate_always_metric_type_routemap):
2862 Change name and add route-map function.
2863 (ospf_default_information_originate_metric_routemap),
2864 (ospf_default_information_originate_routemap),
2865 (ospf_default_information_originate_type_metric_routemap):
2866 New DEFUN added.
2867
28682000-08-14 Kunihiro Ishiguro <kunihiro@zebra.org>
2869
2870 * ospf_zebra.c (zebra_interface_if_set_value): Change ifindex
2871 restore size from two octet to four.
2872
28732000-08-14 Michael Rozhavsky <mike@nbase.co.il>
2874
2875 * ospf_ase.c (ospf_ase_incremental_update): Implement incremental
2876 AS-external-LSA in 16.6 of RFC2328.
2877
28782000-08-14 Matthew Grant <grantma@anathoth.gen.nz>
2879
2880 * ospf_interface.c (ospf_if_get_output_cost): Change cost
2881 calculation algorithm.
2882
2883 * ospf_packet (ospf_ls_upd): Fix problem of LSA retransmitting.
2884
28852000-08-11 Michael Rozhavsky <mike@nbase.co.il>
2886
2887 * ospf_lsa.c (ospf_maxage_lsa_remover): Fix maxage remover for
2888 AS-external-LSAs.
2889
28902000-08-10 Toshiaki Takada <takada@zebra.org>
2891
2892 * ospfd.c (auto_cost_reference_bandwidth): New DEFUN added.
2893 `auto-cost reference-bandwidth' OSPF router command added.
2894
28952000-08-08 Gleb Natapov <gleb@nbase.co.il>
2896
2897 * ospf_routemap.c (ospf_route_map_update): New function added.
2898 Add route-map event hook.
2899
29002000-08-08 Toshiaki Takada <takada@zebra.org>
2901
2902 * ospf_zebra.c (ospf_distribute_check_connected): If redistribute
2903 prefix is connected route on OSPF enabled interface, suppress to
2904 announce it.
2905
29062000-08-08 Matthew Grant <grantma@anathoth.gen.nz>
2907
2908 * ospf_interface.c (ospf_if_get_output_cost):
2909 New function added. Handle bandwidth parameter for cost
2910 calculation.
2911
29122000-08-08 Michael Rozhavsky <mike@nbase.co.il>
2913
2914 * ospf_interface.c (interface_config_write): Show interface
2915 configuration regardless interface is down.
2916
2917 * ospf_ase.c (ospf_ase_caocluate_route): Whole rewritten external
2918 route calculate function.
2919
29202000-08-08 Gleb Natapov <gleb@nbase.co.il>
2921
2922 * ospf_routemap.c: New file added.
2923
2924 * ospf_asbr.c (ospf_reset_route_map_set_values),
2925 (ospf_route_map_set_compare): New function added.
2926
2927 * ospf_lsa.c (ospf_external_lsa_body_set): Set routemap metric
2928 with AS-external-LSA.
2929
29302000-08-05 Kunihiro Ishiguro <kunihiro@zebra.org>
2931
2932 * ospf_ase.c (ospf_ase_calculate_route_add): Pass new->cost to
2933 ospf_zebra_add as metric.
2934 (ospf_ase_calculate_route_add): Likewise.
2935
2936 * ospf_route.c (ospf_route_install): Pass or->cost to
2937 ospf_zebra_add as metric.
2938
2939 * ospf_zebra.c (ospf_zebra_add): Add metric arguemnt.
2940 (ospf_zebra_delete): Likewise.
2941
29422000-08-03 Matthew Grant <grantma@anathoth.gen.nz>
2943
2944 * ospf_flood.c (ospf_flood_delayed_lsa_ack): New function added.
2945 Dispatch delayed-ACK with flooding AS-external-LSA across virtual
2946 link.
2947
29482000-07-31 Matthew Grant <grantma@anathoth.gen.nz>
2949
2950 * ospfd.c (show_ip_ospf_area): Fix lack of VTY_NEWLINE when
2951 `show ip ospf'.
2952
2953 * ospf_interface.c (ospf_if_free): Fix bug of crash with
2954 Point-to-Point interface.
2955
29562000-07-27 Michael Rozhavsky <mike@nbase.co.il>
2957
2958 * ospf_flood.c (ospf_process_self_originated_lsa):
2959 Make sure to clear LSA->param (redistributed external information)
2960 before refreshment.
2961
29622000-07-27 Gleb Natapov <gleb@nbase.co.il>
2963
2964 * ospfd.c (refresh_group_limit), (refresh_per_slice),
2965 (refresh_age_diff): New defun added. Refresher related parameter
2966 can be configurable.
2967
29682000-07-27 Akihiro Mizutani <mizutani@dml.com>
2969
2970 * ospf_interface.c (interface_config_write): Print `description'
2971 config directive to work.
2972
29732000-07-24 Akihiro Mizutani <mizutani@dml.com>
2974
2975 * ospf_interface.c (ospf_if_init): Use install_default for
2976 INTERFACE_NODE.
2977
29782000-07-24 Gleb Natapov <gleb@nbase.co.il>
2979
2980 * ospf_packet.c (ospf_ls_upd_send_list), (ospf_ls_upd_send_event),
2981 (ospf_ls_ack_send_list), (ospf_ls_ack_send_event): New function added.
2982 This make sending always as many LS update/Ack combined in one ospf
2983 packet.
2984
29852000-07-24 Gleb Natapov <gleb@nbase.co.il>
2986
2987 * ospf_packet.c (ospf_ls_upd_list_lsa): Set NULL to lsa->area if
2988 LSA is AS-external-LSA.
2989
2990 * ospf_nsm.c (nsm_reset_nbr): Do not cancel Inactivity timer.
2991
29922000-07-21 Toshiaki Takada <takada@zebra.org>
2993
2994 * ospf_zebra.c (ospf_default_originate_timer): Set timer for
2995 `default-information originate'. Fix some default originate
2996 related functions.
2997
29982000-07-12 Toshiaki Takada <takada@zebra.org>
2999
3000 * ospf_lsa.c (stream_put_ospf_metric): New function added.
3001
30022000-07-12 Toshiaki Takada <takada@zebra.org>
3003
3004 * ospf_lsa.c (show_ip_ospf_database_router),
3005 (show_ip_ospf_database_network), (show_ip_ospf_database_summary),
3006 (show_ip_ospf_database_summary_asbr), (show_ip_ospf_database_externel),
3007 (show_router_lsa), (show_any_lsa), (show_router_lsa_self),
3008 (show_any_lsa_self): Functions removed.
3009
3010 (show_lsa_prefix_set), (show_lsa_detail_proc), (show_lsa_detail),
3011 (show_lsa_detail_adv_router_proc), (show_lsa_detail_adv_router):
3012 New functions added. Replace above functions.
3013
3014 (show_ip_ospf_database_all), (show_ip_ospf_database_self_originated):
3015 Functions removed.
3016 (show_ip_ospf_database_summary): New functions added. Replace
3017 above functions.
3018
3019 (show_ip_ospf_database_cmd): DEFUN rearranged.
3020 (show_ip_ospf_database_type_id_cmd),
3021 (show_ip_ospf_database_type_id_adv_router_cmd),
3022 (show_ip_ospf_database_type_is_self_cmd): New ALIASes added.
3023 (show_ip_ospf_database_type_adv_rotuer_cmd): New DEFUN added.
3024 (show_ip_ospf_database_type_self_cmd): New ALIAS added.
3025
30262000-07-11 Toshiaki Takada <takada@zebra.org>
3027
3028 * ospf_asbr.c (ospf_external_info_new),
3029 (ospf_external_info_free): New functions added.
3030
3031 * ospf_lsa.h (ospf_lsa): Add new member `void *param' to set
3032 origination parameter for external-LSA.
3033 Remove member `redistribute'.
3034
3035 * ospf_zebra.c (ospf_redistirbute_set): When `redistribute'
3036 command executed, metric and metric-type values are overridden.
3037 If one of those is changed refresh AS-external-LSAs for appropriate
3038 type.
3039
30402000-07-11 Michael Rozhavsky <mike@nbase.co.il>
3041
3042 * ospf_lsa.c (ospf_summary_lsa_refresh),
3043 (ospf_summary_asbr_lsa_refresh): Make sure to refresh summary-LSAs.
3044
3045 * ospf_abr.c (set_metric): New function added.
3046
30472000-07-07 Toshiaki Takada <takada@zebra.org>
3048
3049 * ospf_zebra.c (ospf_default_information_originate_metric_type),
3050 (ospf_default_information_originate_type_metric): New defun added.
3051 Metic and Metric type can be set to default route.
3052 (ospf_default_information_originate_always_metric_type):
3053 (ospf_default_information_originate_always_type_metric):
3054 New defun added. Metric and Metric type can be set to default
3055 always route.
3056
3057 * ospf_zebra.c (ospf_default_metric), (no_ospf_default_metric):
3058 New defun added.
3059
30602000-07-06 Gleb Natapov <gleb@nbase.co.il>
3061
3062 * ospf_flood.c (ospf_flood_through_area): Fix bug of considering
3063 on the same interface the LSA was received from.
3064
30652000-07-06 Michael Rozhavsky <mike@nbase.co.il>
3066
3067 * ospfd.c (ospf_config_write): Fix bug of printing `area stub'
3068 command with `write mem'.
3069
3070 * ospfd.c (no_router_ospf): Remove installed routes from zebra.
3071
3072 * ospf_zebra.c (ospf_interface_delete): Fix function to handle
3073 zebra interface delete event.
3074
30752000-07-06 Toshiaki Takada <takada@zebra.org>
3076
3077 * ospf_zebra.c (ospf_default_information_originate),
3078 (ospf_default_information_originate_always): New DEFUN added.
3079
30802000-07-05 Michael Rozhavsky <mike@nbase.co.il>
3081
3082 * ospf_route.c (ospf_terminate): Make sure to remove external route
3083 when SIGINT received.
3084
30852000-07-03 Gleb Natapov <gleb@nbase.co.il>
3086
3087 * ospf_flood.c, ospf_ism.c, ospf_lsa,c, ospfd.c: Make sure to free
3088 many structure with `no router ospf'.
3089
30902000-06-30 Gleb Natapov <gleb@nbase.co.il>
3091
3092 * ospf_neighbor.c (ospf_nbr_new),
3093 ospf_nsm.c (nsm_timer_set): Start LS update timer only
3094 when neighbor enters Exchange state.
3095
30962000-06-29 Gleb Natapov <gleb@nbase.co.il>
3097
3098 * ospf_nsm.c (nsm_timer_set), (nsm_exchange_done),
3099 ospf_packet.c (ospf_db_desc_proc):
3100 Do not cancel DD retransmit timer when Master.
3101
31022000-06-29 Gleb Natapov <gleb@nbase.co.il>
3103
3104 * ospf_abr.c (ospf_abr_announce_network_to_area),
3105 (ospf_abr_announce_rtr_to_area)
3106 ospf_ase.c (ospf_ase_rtrs_register_lsa),
3107 ospf_flood.c (ospf_process_self_originated_lsa),
3108 (ospf_flood_through_area), (ospf_ls_request_delete),
3109 ospf_interface.c (ospf_if_free),
3110 ospf_ism.c (ism_change_status),
3111 ospf_lsa.c (ospf_router_lsa_update_timer),
3112 (ospf_router_lsa_install), (ospf_network_lsa_install),
3113 (ospf_lsa_maxage_delete), (ospf_lsa_action),
3114 (ospf_schedule_lsa_flood_area),
3115 ospf_nsm.c (nsm_change_status),
3116 ospf_packet.c (ospf_make_ls_req_func), (ospf_make_ls_ack):
3117 Use ospf_lsa_{lock,unlock} for all looking-up of LSA.
3118
3119 * ospf_flood.c (ospf_ls_request_free): Function deleted.
3120
3121 * ospf_lsa.c (ospf_discard_from_db): New function added.
3122
31232000-06-26 Toshiaki Takada <takada@zebra.org>
3124
3125 * ospfd.h (ospf): struct member `external_lsa' name changed to
3126 `lsdb'.
3127
31282000-06-26 Toshiaki Takada <takada@zebra.org>
3129
3130 * ospf_lsa.c (ospf_lsa_install), (ospf_router_lsa_install),
3131 (ospf_network_lsa_install), (ospf_summary_lsa_install),
3132 (ospf_summary_asbr_lsa_install), (ospf_external_lsa_install):
3133 Functions re-arranged.
3134
3135 * ospf_lsa.c (IS_LSA_MAXAGE), (IS_LSA_SELF): Macro added.
3136
31372000-06-20 Michael Rozhavsky <mike@nbase.co.il>
3138
3139 * ospf_packet.c (ospf_ls_req), (ospf_ls_upd), (ospf_ls_ack): Add
3140 verification of LS type.
3141
31422000-06-20 Gleb Natapov <gleb@nbase.co.il>
3143
3144 * ospf_ase.c (ospf_ase_calculate_timer): Add more sanity check
3145 whether rn->info is NULL.
3146
31472000-06-20 Toshiaki Takada <takada@zebra.org>
3148
3149 * ospfd.c (show_ip_ospf_interface_sub): Show Router-ID of both
3150 DR and Backup correctly with `show ip ospf interface' command.
3151
31522000-06-20 Toshiaki Takada <takada@zebra.org>
3153
3154 * ospf_lsa.c (ospf_lsa_lock), (ospf_lsa_unlock),
3155 (ospf_lsa_discard): These functions are used for avoiding
3156 unexpected reference to freed LSAs.
3157
31582000-06-13 Kunihiro Ishiguro <kunihiro@zebra.org>
3159
3160 * ospf_packet.c (ospf_ls_upd): Initialize lsa by NULL to avoid
3161 warning.
3162
31632000-06-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3164
3165 * ospf_ase.h (ospf_ase_rtrs_register_lsa): Add prototype.
3166
31672000-06-12 Toshiaki Takada <takada@zebra.org>
3168
3169 * ospf_lsa.c (ospf_external_lsa_install): Make sure to register
3170 LSA to rtrs_external when replacing AS-external-LSAs in LSDB.
3171 Fix core dump.
3172
31732000-06-10 Toshiaki Takada <takada@zebra.org>
3174
3175 * ospf_lsdb.c (id_to_prefix), (ospf_lsdb_hash_key),
3176 (ospf_lsdb_hash_cmp), (ospf_lsdb_new), (ospf_lsdb_iterator),
3177 (lsdb_free), (ospf_lsdb_free), (ospf_lsdb_add), (ospf_lsdb_delete),
3178 (find_lsa), (ospf_lsdb_lookup), (find_by_id),
3179 (ospf_lsdb_lookup_by_id), (ospf_lsdb_lookup_by_header): Functinos
3180 removed for migration to new_lsdb.
3181
3182 * ospf_lsa.c (ospf_summary_lsa_install),
3183 (ospf_summary_asbr_lsa_install), (ospf_maxage_lsa_remover),
3184 (ospf_lsa_maxage_walker), (ospf_lsa_lookup),
3185 (ospf_lsa_lookup_by_id): Use new_lsdb instead of ospf_lsdb.
3186 (count_lsa), (ospf_lsa_count_table), (ospf_lsa_count),
3187 (ospf_get_free_id_for_prefix): Funcitions removed.
3188
31892000-06-09 Gleb Natapov <gleb@nbase.co.il>
3190
3191 * ospf_ism.c (ism_interface_down): Prevent some unneeded DR changes.
3192
3193 * ospf_packet.c (ospf_db_desc_proc): Fix memory leak.
3194 (ospf_hello): Always copy router-ID when hello is received.
3195
31962000-06-08 Gleb Natapov <gleb@nbase.co.il>
3197
3198 * ospf_lsa.h (struct ospf_lsa): Add member of pointer to struct
3199 ospf_area.
3200
32012000-06-08 Michael Rozhavsky <mike@nbase.co.il>
3202
3203 * ospf_ase.c (ospf_asbr_route_same): New function added.
3204 This function makes sure external route calculation more
3205 precisely.
3206
32072000-06-07 Michael Rozhavsky <mike@nbase.co.il>
3208
3209 * ospf_ism.c (ism_change_status): Use ospf_lsa_flush_area for
3210 network-LSA deletion instead of using ospf_lsdb_delete.
3211 Also cancel network-LSA origination timer.
3212
32132000-06-07 Levi Harper <lharper@kennedytech.com>
3214
3215 * ospf_interface.c (ospf_if_down): Close read fd when an interface
3216 goes down.
3217
32182000-06-05 Kunihiro Ishiguro <kunihiro@zebra.org>
3219
3220 * ospf_asbr.c (ospf_external_info_lookup): Add explicit brace for
3221 avoid ambiguous else.
3222
3223 * ospf_flood.c (ospf_external_info_check): Likewise.
3224
32252000-06-05 Toshiaki Takada <takada@zebra.org>
3226
3227 * ospf_nsm.c (nsm_adj_ok): Fix bug of DR election.
3228
32292000-06-04 Toshiaki Takada <takada@zebra.org>
3230
3231 * ospf_zebra.c (ospf_default_information_originate),
3232 (no_ospf_default_information_originate): New DEFUN added.
3233
32342000-06-03 Toshiaki Takada <takada@zebra.org>
3235
3236 * ospf_lsa.h, ospf_asbr.h (external_info): Struct moved from
3237 ospf_lsa.h to ospf_asbr.h.
3238
3239 * ospf_lsa.c, ospf_asbr.c (ospf_external_info_add),
3240 (ospf_external_info_delete): Function moved from ospf_lsa.c
3241 to ospf_asbr.c.
3242
32432000-06-03 Toshiaki Takada <takada@zebra.org>
3244
3245 * ospf_flood.c (ospf_external_info_check): New function added.
3246 (ospf_process_self_orignated_lsa): Make sure to flush
3247 self-originated AS-external-LSA, when router reboot and no longer
3248 originate those AS-external-LSA.
3249
32502000-06-02 Toshiaki Takada <takada@zebra.org>
3251
3252 * ospf_network.c (ospf_serv_sock): Remove SO_DONTROUTE
3253 socket option.
3254
3255 * ospf_packet.c (ospf_write): Set MSG_DONTROUTE flag for
3256 unicast destination packets.
3257
32582000-06-02 Toshiaki Takada <takada@zebra.org>
3259
3260 * ospf_lsdb.c (new_lsdb_delete): Delete entry from LSDB only when
3261 specified LSA matches.
3262
32632000-06-02 Gleb Natapov <gleb@nbase.co.il>
3264
3265 * ospf_network.c (ospf_serv_sock): Set SO_DONTROUTE
3266 socket option.
3267
32682000-06-01 Akihiro Mizutani <mizutani@dml.com>
3269
3270 * ospf_dump.c: Replace string `Debugging functions\n' with DEBUG_STR.
3271 Replace string `OSPF information\n' with OSPF_STR.
3272
32732000-06-01 Toshiaki Takada <takada@zebra.org>
3274
3275 * ospf_lsdb.[ch]: Use new_lsdb struct for network-LSA instead of
3276 ospf_lsdb.
3277
32782000-06-01 Toshiaki Takada <takada@zebra.org>
3279
3280 * ospf_dump.c (config_debug_ospf_packet), (config_debug_ospf_event),
3281 (config_debug_ospf_ism), (config_debug_ospf_nsm),
3282 (config_debug_ospf_lsa), (config_debug_ospf_zebra),
3283 (term_debug_ospf_packet), (term_debug_ospf_event),
3284 (term_debug_ospf_ism), (term_debug_ospf_nsm),
3285 (term_debug_ospf_lsa), (term_debug_ospf_zebra): Repalce debug_ospf_*
3286 variable to use for debug option flags.
3287
3288 (debug_ospf_packet), (debug_ospf_ism), (debug_ospf_nsm),
3289 (debug_ospf_lsa), (debug_ospf_zebra): Set {config,term}_debug_*
3290 flags when vty->node is CONFIG_NODE, otherwise set only term_debug_*
3291 flags.
3292
3293 * ospf_dump.h (CONF_DEBUG_PACKET_ON), (CONF_DEBUG_PACKET_OFF),
3294 (TERM_DEBUG_PACKET_ON), (TERM_DEBUG_PACKET_OFF),
3295 (CONF_DEBUG_ON), (CONF_DEBUG_OFF), (IS_CONF_DEBUG_OSPF_PACKET),
3296 (IS_CONF_DEBUG_OSPF): New Macro added.
3297
32982000-05-31 Toshiaki Takada <takada@zebra.org>
3299
3300 * ospfd.c (clear_ip_ospf_neighbor): New DEFUN added.
3301 Currently this command is used for only debugging.
3302
3303 * ospf_nsm.c (nsm_change_status): Make sure thread cancellation
3304 for network-LSA when DR has no full neighbors.
3305
3306 * ospf_nsm.c (ospf_db_summary_clear): New function added.
3307
33082000-05-30 Toshiaki Takada <takada@zebra.org>
3309
3310 * ospf_lsdb.c (new_lsdb_insert): LSAs are always freed by
3311 maxage_lsa_remover when LSA is replaced.
3312
33132000-05-25 Gleb Natapov <gleb@nbase.co.il>
3314
3315 * ospf_flood.c (ospf_ls_retransmit_delete_nbr_all): Add argument
3316 `struct ospf_area' to remove LSA from Link State retransmission list
3317 of neighbor from only one Area.
3318
33192000-05-24 Michael Rozhavsky <mike@nbase.co.il>
3320
3321 * ospf_lsdb.c (ospf_lsdb_add): Preserve flags field when
3322 overriting old LSA with new LSA.
3323
33242000-05-24 Gleb Natapov <gleb@nbase.co.il>
3325
3326 * ospf_lsa.c (ospf_router_lsa_body_set): Fix bug of router-LSA
3327 size calculation.
3328
33292000-05-22 Michael Rozhavsky <mike@nbase.co.il>
3330
3331 * ospf_route.c (ospf_intra_add_stub):
3332 * ospf_spf.h (struct vertex): Use u_int32_t for distance (cost)
3333 value instead of u_int16_t.
3334
33352000-05-22 Axel Gerlach <agerlach@datus.datus.com>
3336
3337 * ospf_ia.c (ospf_ia_network_route): Fix bug of Inter-area route
3338 equal cost path calculation.
3339
33402000-05-21 Toshiaki Takada <takada@zebra.org>
3341
3342 * ospf_ase.c (ospf_ase_calculate_route_delete): New function added.
3343 Make sure, when rotuer route is deleted, related external routes
3344 are also deleted.
3345
33462000-05-20 Toshiaki Takada <takada@zebra.org>
3347
3348 * ospfd.c (ospf_interface_down): Make sure interface flag is disable
3349 and set fd to -1.
3350
33512000-05-16 Toshiaki Takada <takada@zebra.org>
3352
3353 * ospf_asbr.c (ospf_asbr_should_announce), (ospf_asbr_route_remove):
3354 Functions removed.
3355
3356 * ospfd.h (EXTERNAL_INFO): Macro added.
3357 Substitute `ospf_top->external_info[type]' with it.
3358
33592000-05-16 Toshiaki Takada <takada@zebra.org>
3360
3361 * ospf_lsa.c (ospf_rtrs_external_remove): New function added.
3362
33632000-05-14 Gleb Natapov <gleb@nbase.co.il>
3364
3365 * ospf_flood.c (ospf_ls_retransmit_delete_nbr_all)
3366 * ospf_lsdb.c (new_lsdb_insert)
3367 * ospf_packet.c (ospf_ls_ack): Fix database synchonization problem.
3368
33692000-05-14 Gleb Natapov <gleb@nbase.co.il>
3370
3371 * ospf_lsa.h (tv_adjust), (tv_ceil), (tv_floor), (int2tv),
3372 (tv_add), (tv_sub), (tv_cmp): Prototype definition added.
3373
3374 * ospf_nsm.h (ospf_db_summary_delete_all): Prototype definition added.
3375
33762000-05-13 Toshiaki Takada <takada@zebra.org>
3377
3378 * ospf_lsa.[ch] (ospf_lsa): struct timestamp type is changed from
3379 time_t to struct timeval.
3380 (tv_adjust), (tv_ceil), (tv_floor), (int2tv), (tv_add),
3381 (tv_sub), (tv_cmp): timeval utillity functions added.
3382
33832000-05-12 Toshiaki Takada <takada@zebra.org>
3384
3385 * ospf_lsa.[ch] (ospf_schedule_update_router_lsas): Delete function.
3386 Change to use macro OSPF_LSA_UPDATE_TIMER instead of using
3387 this function.
3388 router-LSA refresh timer related stuff is re-organized.
3389
33902000-05-10 Gleb Natapov <gleb@nbase.co.il>
3391
3392 * ospf_interface.c (ospf_vl_set_params):
3393 * ospf_packet.c (ospf_check_network_mask):
3394 * ospf_spf.[ch] (ospf_spf_next):
3395 Remove field address from `struct vertex', and search for peer
3396 address of virtual link in function `ospf_vl_set_params' instead.
3397
33982000-05-10 Gleb Natapov <gleb@nbase.co.il>
3399
3400 * ospf_packet.c (ospf_ls_upd): Fix some memory leak related LSA.
3401
34022000-05-08 Thomas Molkenbur <tmo@datus.com>
3403
3404 * ospf_packet.c (ospf_packet_dup): Replace ospf_steram_copy()
3405 with ospf_stream_dup() to fix memory leak.
3406
34072000-05-08 Michael Rozhavsky <mike@nbase.co.il>
3408
3409 * ospf_flood.c (ospf_flood_through_area): Fix the problem of
3410 LSA update without DROther.
3411
34122000-05-04 Gleb Natapov <gleb@nbase.co.il>
3413
3414 * ospf_spf.c (ospf_vertex_free): Fix memory leak of SPF calculation.
3415
34162000-05-03 Toshiaki Takada <takada@zebra.org>
3417
3418 * ospf_neighbor.c (ospf_db_summary_add): Use new_lsdb struct
3419 instead linked-list.
3420 (ospf_db_summary_count), (ospf_db_summary_isempty):
3421 New function added.
3422
3423 * ospf_lsa.c (ospf_rotuer_lsa): Re-arrange and divide functions.
3424
34252000-05-02 Gleb Natapov <gleb@nbase.co.il>
3426
3427 * ospf_lsdb.c (new_lsdb_cleanup): Fix memory leak. When LSDB are
3428 not needed any more, then free them.
3429
34302000-05-02 Toshiaki Takada <takada@zebra.org>
3431
3432 * ospfd.c (timers_spf), (no_timers_spf): New defun added.
3433 SPF calculation timers related stuff is rearranged.
3434
3435 * ospf_spf.c (ospf_spf_calculate_timer_add): Function removed.
3436 SPF timer is scheduled by SPF calculation delay and holdtime
3437 configuration variable.
3438
3439 * ospf_lsa.c (ospf_external_lsa_nexthop_get): Set AS-external-LSA's
3440 forwarding address when nexthop learned by other protocols is
3441 in the OSPF domain.
3442
3443 * ospf_zebra.c (ospf_redistribute_source_metric_type),
3444 (ospf_redistribute_source_type_metric): Re-arrange DEFUNs and
3445 ALIASes.
3446
34472000-05-01 Toshiaki Takada <takada@zebra.org>
3448
3449 * ospf_flood.c (ospf_ls_retransmit_count),
3450 (ospf_ls_retransmit_isempty): New function added.
3451
3452 (ospf_ls_retransmit_add), (ospf_ls_retransmit_delete),
3453 (ospf_ls_retransmit_clear), (ospf_ls_retransmit_lookup),
3454 (ospf_ls_retransmit_delete_all), (ospf_ls_retransmit_delete_nbr_all),
3455 (ospf_ls_retransmit_add_nbr_all): Replace these functions to use
3456 new_lsdb.
3457
34582000-04-29 Toshiaki Takada <takada@zebra.org>
3459
3460 * ospfd.c (no_network_area): Add check Area-ID whether specified
3461 Area-ID with prefix matches config.
3462
34632000-04-27 Toshiaki Takada <takada@zebra.org>
3464
3465 * ospf_lsa.c (ospf_maxage_lsa_remover): Fix problem of
3466 remaining withdrawn routes on zebra.
3467
34682000-04-25 Michael Rozhavsky <mike@nbase.co.il>
3469
3470 * ospf_nsm.c (nsm_kill_nbr), (nsm_ll_down), (nsm_change_status),
3471 (ospf_nsm_event): Fix network-LSA re-origination problem.
3472
34732000-04-24 Toshiaki Takada <takada@zebra.org>
3474
3475 * ospf_nsm.c (ospf_db_desc_timer): Fix bug of segmentation fault
3476 with DD retransmission.
3477
3478 * ospf_nsm.c (nsm_kill_nbr): Fix bug of re-origination when
3479 a neighbor disappears.
3480
34812000-04-23 Michael Rozhavsky <mike@nbase.co.il>
3482
3483 * ospf_abr.c (ospf_abr_announce_network_to_area): Fix bug of
3484 summary-LSAs reorigination. Correctly copy OSPF_LSA_APPROVED
3485 flag to new LSA. when summary-LSA is reoriginatd.
3486
3487 * ospf_flood.c (ospf_flood_through_area): Fix bug of flooding
3488 procedure. Change the condition of interface selection.
3489
34902000-04-21 Toshiaki Takada <takada@zebra.org>
3491
3492 * ospf_lsa.c (ospf_refresher_register_lsa): Fix bug of refresh never
3493 occurs.
3494
3495 * ospfd.c (show_ip_ospf_neighbor_id): New defun added.
3496 `show ip ospf neighbor' related commands are re-arranged.
3497
34982000-04-20 Toshiaki Takada <takada@zebra.org>
3499
3500 * ospf_dump.c (debug_ospf_zebra): New defun added.
3501 Suppress zebra related debug information.
3502
35032000-04-19 Toshiaki Takada <takada@zebra.org>
3504
3505 * ospf_zebra.c (ospf_distribute_list_update_timer),
3506 (ospf_distribute_list_update), (ospf_filter_update):
3507 New function added. Re-organize `distribute-list' router ospf
3508 command.
3509
35102000-04-13 Michael Rozhavsky <mike@nbase.co.il>
3511
3512 * ospf_packet.c (ospf_make_ls_upd): Add check for MAX_AGE.
3513
35142000-04-14 Michael Rozhavsky <mike@nbase.co.il>
3515
3516 * ospf_packet.c (ospf_make_ls_upd): Increment LS age by configured
3517 interface transmit_delay.
3518
35192000-04-14 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3520
3521 * ospf_interface.c (ip_ospf_cost), (no_ip_ospf_cost):
3522 Add to schedule router_lsa origination when the interface cost changes.
3523
35242000-04-12 Toshiaki Takada <takada@zebra.org>
3525
3526 * ospf_lsa.c (ospf_refresher_register_lsa),
3527 (ospf_refresher_unregister_lsa): Fix bug of core dumped.
3528
3529 * ospfd.c (no_router_ospf): Fix bug of core dumped.
3530
35312000-03-29 Toshiaki Takada <takada@zebra.org>
3532
3533 * ospf_nsm.c (nsm_oneway_received): Fix bug of MS flag unset.
3534
35352000-03-29 Michael Rozhavsky <mike@nbase.co.il>
3536
3537 * ospf_lsa.c (ospf_network_lsa):
3538 * ospf_nsm.c (ospf_nsm_event): Fix bug of Network-LSA originated
3539 in stub network.
3540
35412000-03-28 Toshiaki Takada <takada@zebra.org>
3542
3543 * ospf_nsm.c (nsm_bad_ls_req), (nsm_seq_number_mismatch),
3544 (nsm_oneway_received): Fix bug of NSM state flapping between
3545 ExStart and Exchange.
3546
35472000-03-28 Toshiaki Takada <takada@zebra.org>
3548
3549 * ospf_packet.h (strcut ospf_header): Fix the size of ospf_header,
3550 change u_int8_t to u_char.
3551
35522000-03-27 Toshiaki Takada <takada@zebra.org>
3553
3554 * ospf_lsa.c (ospf_lsa_checksum): Take care of BIGENDIAN architecture.
3555
35562000-03-27 Toshiaki Takada <takada@zebra.org>
3557
3558 * ospfd.c (ospf_interface_run): Make sure Address family matches.
3559
35602000-03-26 Love <lha@s3.kth.se>
3561
3562 * ospf_packet.c (ospf_write): Chack result of sendto().
3563
35642000-03-26 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3565
3566 * ospf_nsm.c (nsm_oneway_received): Fix bug of 1-WayReceived in NSM.
3567
35682000-03-23 Libor Pechacek <farco@clnet.cz>
3569
3570 * ospf_lsa.c (ospf_network_lsa)
3571 * ospf_lsdb.c (new_lsdb_insert): Fix bug of accessing to
3572 unallocated memory.
3573
35742000-03-23 Toshiaki Takada <takada@zebra.org>
3575
3576 * ospfd.c (ospf_config_write): Fix bug of duplicate line for
3577 `area A.B.C.D authentication'.
3578
35792000-03-22 Toshiaki Takada <takada@zebra.org>
3580
3581 * ospf_debug.c (debug_ospf_lsa), (no_debug_ospf_lsa): Defun added.
3582 Suppress all zlog related to LSAs with this config option.
3583
35842000-03-21 Kunihiro Ishiguro <kunihiro@zebra.org>
3585
3586 * ospf_nsm.c (ospf_nsm_event): Add check for NSM_InactivityTimer.
3587
35882000-03-21 Toshiaki Takada <takada@zebra.org>
3589
3590 * ospf_packet.c (ospf_ls_upd_timer), (ospf_ls_req):
3591 Fix bug of memory leak about linklist.
3592
3593 * ospf_flood.c (ospf_flood_through_area): Likewise.
3594
35952000-03-18 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3596
3597 * ospf_flood.c (ospf_ls_retransmit_lookup): Add checksum comparison
3598 to identify LSA uniquely. This fix routes lost.
3599
36002000-03-18 Toshiaki Takada <takada@zebra.org>
3601
3602 * ospf_ase.c (ospf_find_asbr_route): Add sanity check with router
3603 routing table.
3604
36052000-03-17 Alex Zinin <zinin@amt.ru>
3606
3607 * ospf_spf.[ch]: Bug fix.
3608 The 2nd stage of Dijkstra could consider one vertex
3609 more than once if there is more than one link
3610 between the routers, thus adding extra CPU overhead
3611 and extra next-hops.
3612 Fixed.
3613
36142000-03-15 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3615
3616 * ospf_nsm.c (nsm_inactivity_timer): Changed to call nsm_kill_nbr().
3617
36182000-03-14 Toshiaki Takada <takada@zebra.org>
3619
3620 * ospf_route.c (ospf_route_copy_nexthops): Fix bug of memory leak of
3621 ospf_path. Actually ignore merging ospf_route with completely same
3622 paths.
3623
36242000-03-12 Toshiaki Takada <takada@zebra.org>
3625
3626 * ospf_lsa.c (show_as_external_lsa_detail): fix bug of
3627 external route tag byte order.
3628
36292000-03-11 Toshiaki Takada <takada@zebra.org>
3630
3631 * ospf_lsdb.c (ospf_lsdb_insert): New function added.
3632
36332000-03-09 Toshiaki Takada <takada@zebra.org>
3634
3635 * ospf_lsa.c (ospf_external_lsa_install),
3636 (ospf_lsa_lookup), (show_ip_ospf_database_all),
3637 (show_ip_ospf_database_self_originate): Use struct new_lsdb for
3638 LSDB of AS-external-LSAs instead of ospf_lsdb.
3639
3640 * ospf_lsa.c (ospf_lsa_unique_id): New function added.
3641 Use for assigning Unique Link State ID instead of
3642 ospf_get_free_id_for_prefix().
3643
36442000-03-09 Toshiaki Takada <takada@zebra.org>
3645
3646 * ospf_ase.c (ospf_ase_calculate_timer): Fix bug of segmentation
3647 fault reported by George Bonser <george@siteROCK.com>.
3648
36492000-03-07 Libor Pechacek <farco@clnet.cz>
3650
3651 * ospfd.c (ospf_interface_down): Fix bug of segmentation fault.
3652
36532000-03-06 Toshiaki Takada <takada@zebra.org>
3654
3655 * ospf_route.c (ospf_route_cmp): Change meaning of return values.
3656
36572000-03-02 Alex Zinin <zinin@amt.ru>
3658 * ospfd.h, ospf_ia.h
3659 New Shortcut ABR code. Now area's flag can be configured
3660 with Default, Enable, and Disable values.
3661 More info will be in the new ver of I-D soon (see IETF web).
3662
36632000-02-25 Toshiaki Takada <takada@zebra.org>
3664
3665 * ospf_lsa.c (ospf_lsa_header_set), (ospf_external_lsa_body_set),
3666 (osfp_external_lsa_originate), (ospf_external_lsa_queue),
3667 (ospf_external_lsa_originate_from_queue): New function added.
3668 (ospf_external_lsa): Function removed.
3669
3670 * ospf_zebra.c (ospf_zebra_read_ipv4): Originate AS-external-LSA
3671 when listen a route from Zebra, instead creating external route.
3672
3673 * ospf_asbr.c (ospf_asbr_route_add_flood_lsa),
3674 (ospf_asbr_route_add_queue_lsa),
3675 (ospf_asbr_route_install_lsa), (ospf_asbr_route_add):
3676 Functions removed.
3677
3678 * ospf_ase.c (process_ase_lsa): Function will not be used.
3679 (ospf_ase_calculate), (ospf_ase_calculate_route_add),
3680 (ospf_ase_calculate_new_route), (ospf_ase_caluculate_asbr_route):
3681 process_ase_lsa () is separated to these functions.
3682
3683 OSPF AS-external-LSA origination is whole re-organized.
3684
36852000-02-18 Toshiaki Takada <takada@zebra.org>
3686
3687 * ospf_packet.c (ospf_ls_upd): Fix bug of OSPF LSA memory leak.
3688
3689 * ospf_asbr.c (ospf_asbr_route_add_flood_lsa),
3690 (ospf_asbr_route_add_queue_lsa): Fix bug of OSPF external route
3691 memory leak.
3692
36932000-02-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3694
3695 * ospf_asbr.c (ospf_asbr_route_install_lsa): Re-calculate LSA
3696 checksum after change Advertised Router field.
3697
36982000-02-09 Toshiaki Takada <takada@zebra.org>
3699
3700 * ospf_asbr.c (ospf_external_route_lookup): Add new function.
3701
37022000-02-08 Toshiaki Takada <takada@zebra.org>
3703
3704 * ospfd.c (ospf_router_id_get), (ospf_router_id_update),
3705 (ospf_router_id_update_timer): Router ID decision algorithm is changed.
3706 Router ID is chosen from all of eligible interface addresses even if
3707 it is not enable to OSPF.
3708
37092000-02-08 Toshiaki Takada <takada@zebra.org>
3710
3711 * ospf_asbr.c (ospf_asbr_route_add): Function divided to
3712 ospf_asbr_route_add_flood_lsa, ospf_asbr_route_add_queue_lsa and
3713 ospf_asbr_route_install_lsa. If Router-ID is not set, then LSA is
3714 waited to install to LSDB.
3715 `0.0.0.0 adv_router' AS-external-LSA origination bug was fixed.
3716
37172000-02-01 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3718
3719 * ospf_flood.c (ospf_ls_retransmit_lookup): Compare LS seqnum
3720 in the ACK before deleting.
3721
3722 * ospf_packet.c (ospf_hello): Reset the flags after a shutdown
3723 and no shutdown of the interface.
3724
37252000-01-31 Toshiaki Takada <takada@zebra.org>
3726
3727 * ospf_packet.c (ospf_ls_req): Send multiple Link State Update
3728 packets respond to a Link State Request packet.
3729
3730 * ospfd.c (show_ip_ospf_neighbor_detail_sub): Show thread state.
3731
3732 * ospf_interface.c (ospf_vl_new): Crash when backbone area
3733 is not configured and set virtual-link to no-backbone area,
3734 bug fixed.
3735
37362000-01-30 Kunihiro Ishiguro <kunihiro@zebra.org>
3737
3738 * ospf_neighbor.h (struct ospf_neighbor): Add pointer to last send
3739 LS Request LSA.
3740
3741 * ospf_packet.c (ospf_ls_upd): Comment out LS request list
3742 treatment. That should be done in OSPF flooding procedure.
3743
3744 * ospf_flood.c (ospf_flood_through_area): Enclose
3745 ospf_check_nbr_loding inside if-else close.
3746
37472000-01-31 Toshiaki Takada <takada@zebra.org>
3748
3749 * ospf_packet.c (ospf_make_ls_upd): Fix bug of #LSAs counting.
3750
37512000-01-29 Toshiaki Takada <takada@zebra.org>
3752
3753 * ospf_packet.c (ospf_make_md5_digest): Fix bug of md5 authentication.
3754
37552000-01-28 Toshiaki Takada <takada@zebra.org>
3756
3757 * ospfd.c (show_ip_ospf): Show Number of ASE-LSAs.
3758
37592000-01-27 Kunihiro Ishiguro <kunihiro@zebra.org>
3760
3761 * ospf_packet.c (ospf_make_db_desc): Don't use rm_list for
3762 removing LSA from nbr->db_summary.
3763
37642000-01-27 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3765
3766 * ospf_packet.c (ospf_ls_upd_send): Set AllSPFRouters to
3767 destination when the link is point-to-point.
3768 (ospf_ls_ack_send_delayed): Likewise.
3769
37702000-01-27 Kunihiro Ishiguro <kunihiro@zebra.org>
3771
3772 * ospf_flood.c (ospf_ls_request_delete_all): Fix bug of next
3773 pointer lookup after the node is freed.
3774
37752000-01-26 Kunihiro Ishiguro <kunihiro@zebra.org>
3776
3777 * ospf_asbr.c (ospf_asbr_route_add): Instead of scanning all AS
3778 external route, use ospf_top->external_self.
3779
37802000-01-27 Toshiaki Takada <takada@zebra.org>
3781
3782 * ospf_lsa.c (ospf_forward_address_get): New function added.
3783
3784 * ospf_asbr.c (ospf_asbr_check_lsas): Originate AS-external-LSA
3785 only when it should be replaced.
3786
37872000-01-25 Kunihiro Ishiguro <kunihiro@zebra.org>
3788
3789 * ospf_flood.c (ospf_ls_retransmit_clear): Delete list node.
3790
3791 * ospf_lsa.c (ospf_lsa_free): Reduce logging message using
3792 ospf_zlog value.
3793
3794 * ospf_ism.c (ism_change_status): Fix bug of DR -> non DR status
3795 change. Self originated LSA is freed but not deleted from lsdb.
3796
37972000-01-24 Kunihiro Ishiguro <kunihiro@zebra.org>
3798
3799 * ospf_ism.c (ism_interface_down): Don't use router_id for
3800 detecting self neighbor structure. Instead of that compare
3801 pointer itself.
3802
3803 * ospf_neighbor.c (ospf_nbr_free): Cancel all timer when neighbor
3804 is deleted.
3805 (ospf_nbr_free): Free last send packet.
3806
3807 * ospf_neighbor.h (struct ospf_neighbor): Remove host strucutre.
3808 Instead of that src is introduced.
3809
3810 * ospf_nsm.h: Enclose macro defenition with do {} while (0).
3811
38122000-01-17 Kunihiro Ishiguro <kunihiro@zebra.org>
3813
3814 * ospfd.c: Change part of passive interface implementation. For
3815 passive interface just disabling sending/receiving Hello on the
3816 interface.
3817
38182000-01-16 Kai Bankett <kai.bankett@vew-telnet.net>
3819
3820 * ospf_interface.h (OSPF_IF_PASSIVE): Add passive flag.
3821 * ospf_interface.c (ospf_if_lookup_by_name): Add new function.
3822 * ospf_lsa.c (ospf_router_lsa): Skip passive interface.
3823 * ospfd.c (passive_interface): New command passive-interface is
3824 added.
3825 (ospf_config_write): Print passive interface.
3826
38272000-01-15 Toshiaki Takada <takada@zebra.org>
3828
3829 * ospf_interface.h (crypt_key): New struct added to store
3830 multiple cryptographic autheitication keys.
3831 (ospf_interface): struct changed.
3832
3833 * ospf_interface.c: ospf_crypt_key_new, ospf_crypt_key_add,
3834 ospf_crypt_key_lookup, ospf_crypt_key_delete: new functions added.
3835
3836 * ospf_packet.c (ip_ospf_message_digest_key): Changed to store
3837 multiple cryptographic authentication keys.
3838
38392000-01-14 Toshiaki Takada <takada@zebra.org>
3840
3841 * ospf_interface.c: DEFUN (if_ospf_*) commands changed name to
3842 ip_ospf_* ().
3843 Old notation `ospf *' still remains backward compatibility.
3844
38451999-12-29 Alex Zinin <zinin@amt.ru>
3846 * ospf_lsa.c: ospf_lsa_more_recent() bug fix
3847 * ospf_nsm.c, ospf_packet.c: remove nbr data struct when
3848 int goes down, also check DD flags correctly (bug fix)
3849
38501999-12-28 Alex Zinin <zinin@amt.ru>
3851 * "redistribute <source> metric-type (1|2) metric <XXX>" added
3852
38531999-12-23 Alex Zinin <zinin@amt.ru>
3854 * added RFC1583Compatibility flag
3855 * added dynamic interface up/down functionality
3856
38571999-11-19 Toshiaki Takada <takada@zebra.org>
3858
3859 * ospf_neighbor.h (struct ospf_neighbor): Add member state_change
3860 for NSM state change statistics.
3861
38621999-11-19 Toshiaki Takada <takada@zebra.org>
3863
3864 * ospfd.c (show_ip_ospf_neighbor_detail),
3865 (show_ip_ospf_neighbor_int_detail): DEFUN Added.
3866
38671999-11-14 Kunihiro Ishiguro <kunihiro@zebra.org>
3868
3869 * ospf_asbr.c (ospf_asbr_check_lsas): Add check of
3870 lsa->refresh_list.
3871
38721999-11-11 Toshiaki Takada <takada@zebra.org>
3873
3874 * ospf_ia.[ch] (OSPF_EXAMINE_SUMMARIES_ALL): Macro added.
3875 This macro is expanded to ospf_examine_summaries ()
3876 for SUMMARY_LSA and SUMMARY_LSA_ASBR.
3877 (OSPF_EXAMINE_TRANSIT_SUMMARIES_ALL): Macro added.
3878 This macro is expanded to ospf_examine_transit_summaries ()
3879 for SUMMARY_LSA and SUMMARY_LSA_ASBR.
3880
38811999-11-11 Toshiaki Takada <takada@zebra.org>
3882
3883 * ospf_lsa.[ch] (ospf_find_self_summary_lsa_by_prefix): Changed to
3884 macro OSPF_SUMMARY_LSA_SELF_FIND_BY_PREFIX.
3885 (ospf_find_self_summary_asbr_lsa_by_prefix): Changed to
3886 macro OSPF_SUMMARY_ASBR_LSA_SELF_FIND_BY_PREFIX.
3887 (ospf_find_self_external_lsa_by_prefix): Changed to
3888 macro OSPF_EXTERNAL_LSA_SELF_FIND_BY_PREFIX.
3889
38901999-11-11 Toshiaki Takada <takada@zebra.org>
3891
3892 * ospfd.c (ospf_abr_type): ospf_abr_type_cisco, ospf_abr_type_ibm,
3893 ospf_abr_type_shortcut and ospf_abr_type_standard DEFUNs are
3894 combined.
3895 * ospfd.c (no_ospf_abr_type): no_ospf_abr_type_cisco,
3896 no_ospf_abr_type_ibm and no_ospf_abr_type_shortcut DEFUNS are
3897 combined.
3898
38991999-11-10 Toshiaki Takada <takada@zebra.org>
3900
3901 * ospf_route.c (ospf_lookup_int_by_prefix): Move function to
3902 ospf_interface.c and change name to ospf_if_lookup_by_prefix ().
3903
39041999-11-01 Alex Zinin <zinin@amt.ru>
3905 * ospf_packet.c
3906 some correction to LSU processing
3907
3908 * ospf_lsa.c ospfd.h
3909 randomize initial LSA refreshment interval
3910 and limit the size of LSA-group to 10
3911 to let randomization work more effectively.
3912
39131999-10-31 Alex Zinin <zinin@amt.ru>
3914 * ospf_interface.c
3915 cancel t_network_lsa_self
3916 when freeing int structure
3917
3918 * ospf_abr.c ospf_asbr.c ospf_flood.c ospf_lsa.c
3919 ospf_lsa.h ospf_lsdb.h ospfd.c ospfd.h
3920
3921 Summary and ASE LSA refreshment functions
3922 added---LSA refreshment is paced to 70 LSAs
3923 per sec to avoid link overflow. Refreshment events
3924 are further randomized within a 10 sec interval
3925 to avoid syncing.
3926
3927 Also the sigfault of memcmp() in ospf_lsa_is_different()
3928 is fixed.
3929
39301999-10-30 Alex Zinin <zinin@amt.ru>
3931 * ospf_nsm.c
3932 Fix the bug where MAX_AGE LSAs
3933 are included into the DB summary.
3934
3935 * ospf_interface.c
3936 allocate 2*MTU input buffer instead of just MTU
3937 for the cases when the other router mistakenly
3938 sends larger packets thus causing fragmentation, etc.
3939
3940 * ospf_nsm.c
3941 in nsm_reset_nbr() lists should be freed
3942 not when they are empty.
3943
39441999-10-29 Kunihiro Ishiguro <kunihiro@zebra.org>
3945
3946 * ospf_zebra.c (ospf_acl_hook): Move OSPF_IS_ASBR and OSPF_IS_ABR
3947 check inside of if (ospf_top).
3948
39491999-10-29 Alex Zinin <zinin@amt.ru>
3950 * ospf_lsa.c ospf_lsdb.c :
3951 add assertion in lsa and lsa->data alloc functions,
3952 as well as in lsdb_add for new->data
3953
3954 * ospf_lsdb.c: free hash table correctly
3955
39561999-10-28 John Capo <jc@irbs.com>
3957
3958 * ospf_packet.h (OSPF_PACKET_MAX): Correct MAX packet length
3959 calculation
3960
39611999-10-27 Kunihiro Ishiguro <kunihiro@zebra.org>
3962
3963 * OSPF-TRAP-MIB.txt: New file added. Edited version of RFC1850.
3964
3965 * OSPF-MIB.txt: New file added. Edited version of RFC1850.
3966
39671999-10-27 Alex Zinin <zinin@amt.ru>
3968 * ospfd, ospf_zebra, ospf_abr
3969 "area import-list" command is added.
3970 This command allows to filter the inter-area routes
3971 injected into an area. Access list hook function
3972 extended to invalidate area exp/imp lists.
3973
39741999-10-25 Yoshinobu Inoue <shin@nd.net.fujitsu.co.jp>
3975
3976 * ospfd.c (ospf_interface_run): Enable to detect P2P network
3977 on an OSPF interface.
3978
39791999-10-19 Jordan Mendelson <jordy@wserv.com>
3980
3981 * ospf_lsdb.c (ospf_lsdb_add): Fix bug of crash
3982 in ospf_ls_retransmit_lookup ().
3983
39841999-10-19 Vladimir B. Grebenschikov <vova@express.ru>
3985
3986 * ospf_route.c: Workaround about installation of OSPF routes into
3987 the zebra daemon. Add checking of existance routes. Free
3988 ospf_top->old_table if it exists.
3989
39901999-10-15 Jordan Mendelson <jordy@wserv.com>
3991
3992 * Add support for MD5 authentication.
3993
39941999-10-12 Alex Zinin <zinin@amt.ru>
3995 * ospfd.c, ospfd.h, ospf_abr.c:
3996 a new command "area export-list" was added, it allows
3997 the admin. to control which intra-area routes are
3998 announced to other areas by the ABR
3999
40001999-10-12 Alex Zinin <zinin@amt.ru>
4001 * ospf_asbr.c (ospf_asbr_check_lsas): Fix bug of coredump
4002 when "no redistribute" is used after a distribute list
4003 denying some networks was used
4004
40051999-10-05 Toshiaki Takada <takada@zebra.org>
4006
4007 * ospf_route.c (ospf_path_dup): New function added.
4008
40091999-10-05 Toshiaki Takada <takada@zebra.org>
4010
4011 * ospf_interface.[ch]: Some of VL related funciton name changed.
4012
40131999-09-27 Alex Zinin <zinin@amt.ru>
4014
4015 * ospf_zebra.c: Distribute-list functionality added
4016
40171999-09-27 Toshiaki Takada <takada@zebra.org>
4018
4019 * ospfd.c (show_ip_ospf): Fix bug of segmentation fault when no ospf
4020 instance exists.
4021
40221999-09-25 Kunihiro Ishiguro <kunihiro@zebra.org>
4023
4024 * ospfd.c (ospf_interface_down): Fix bug of misusing nextnode()
4025 instead of node->next. Reported by Hiroki Ishibashi
4026 <ishibasi@dcd.abk.nec.co.jp>.
4027
4028 * ospf_route.c (show_ip_ospf_route): Add check for ospf is enabled
4029 or not.
4030
40311999-09-23 Alex Zinin <zinin@amt.ru>
4032
4033 * stub area support added
4034
40351999-09-23 Alex Zinin <zinin@amt.ru>
4036
4037 * fwd_addr in ASE-LSAs is now set correctly
4038 * ASE routing changed to check the fwd_addr
4039 and skip the route if the addr points to one
4040 of our interfaces to avoid loops.
4041
40421999-09-22 Alex Zinin <zinin@amt.ru>
4043
4044 * ospf_interface:
4045 ospf_vls_in_area() added, it returns
4046 the number of VLs configured through the area
4047
4048 * ospf_interface.c ospf_lsa.c ospf_lsdb.c ospfd.c
4049 honor correct mem alloc
4050
40511999-09-22 Alex Zinin <zinin@amt.ru>
4052
4053 * memory.[ch]:
4054 Some OSPF mem types added,
4055 plus more info in "show mem"
4056
40571999-09-21 Alex Zinin <zinin@amt.ru>
4058
4059 * ospfd.c:
4060 "area range substitute" added.
4061 It can be used on NAT-enabled (IP-masquarade)
4062 routers to announce private networks
4063 from an area as public ones into the outside
4064 world (not in the RFC, btw :)
4065
40661999-09-21 Alex Zinin <zinin@amt.ru>
4067
4068 * ospfd.c:
4069 "area range suppress" added.
4070 This command allows to instruct the router
4071 to be silent about specific ranges, i.e.,
4072 it is a method of route filtering on area
4073 borders
4074
40751999-09-21 Alex Zinin <zinin@amt.ru>
4076
4077 * ospfd.c VLs removed when "no network area" executed
4078
40791999-09-20 Alex Zinin <zinin@amt.ru>
4080
4081 * ospf_ase.c bug fix for not-zero fwd_addr
4082 and directly connected routes.
4083
40841999-09-20 Yon Uriarte <yon@plannet.de>
4085
4086 * ospf_packet.c (ospf_make_ls_req): Introduce delta value for
4087 checking the length of OSPF packet exceeds MTU or not.
4088
4089 * ospf_lsa.c (ospf_lsa_different): Apply ntohs for checking
4090 l1->data->length.
4091
40921999-09-18 Alex Zinin <zinin@amt.ru>
4093
4094 * ospf_lsa.c bug fix for ospf_network_lsa() to
4095 include itself into the RID list
4096
40971999-09-10 Alex Zinin <zinin@amt.ru>
4098
4099 * Alternative ABR behaviors IBM/Cisco/Shortcut
4100 implemented
4101
41021999-09-10 Alex Zinin <zinin@amt.ru>
4103
4104 * router and network-LSA origination
4105 changed to honor MinLSInterval
4106
41071999-09-08 Alex Zinin <zinin@amt.ru>
4108
4109 * modified ABR behavior to honor VLs and transit
4110 areas
4111
41121999-09-07 Alex Zinin <zinin@amt.ru>
4113
4114 * completed VL functionality
4115
41161999-09-06 Kunihiro Ishiguro <kunihiro@zebra.org>
4117
4118 * ospf_asbr.c: New file.
4119 ospf_asbr.h: New file.
4120
4121 * ospf_zebra.c (ospf_redistribute_connected): Add redistribute
4122 related stuff.
4123
41241999-09-05 Kunihiro Ishiguro <kunihiro@zebra.org>
4125
4126 * ospfd.h (OSPF_FLAG_VIRTUAL_LINK): Change OSPF_FLAG_VEND to
4127 OSPF_FLAG_VIRTUAL_LINK for comprehensiveness.
4128
41291999-09-03 Kunihiro Ishiguro <kunihiro@zebra.org>
4130
4131 * ospf_spf.c (ospf_spf_register): Change name from
4132 ospf_spf_route_add() to ospf_spf_register().
4133 Include "ospfd/ospf_abr.h" for ospf_abr_task() prototype.
4134
41351999-09-02 Kunihiro Ishiguro <kunihiro@zebra.org>
4136
4137 * ospf_lsa.c (ospf_external_lsa_install): Change to update
4138 lsa->data rather than install new one, when same id lsa is already
4139 installed.
4140
41411999-09-01 Kunihiro Ishiguro <kunihiro@zebra.org>
4142
4143 * ospf_lsa.c (ospf_router_lsa_install): Return lsa value.
4144 (ospf_network_lsa_install): Likewise.
4145 (ospf_summary_lsa_install): Likewise.
4146 (ospf_summary_asbr_lsa_install): Likewise.
4147 (ospf_external_lsa_install): Likewise.
4148
4149 * ospf_spf.c (ospf_spf_calculate): Comment out debug function
4150 ospf_rtrs_print().
4151
41521999-08-31 Kunihiro Ishiguro <kunihiro@zebra.org>
4153
4154 * ospf_spf.c (ospf_rtrs_free): Add ospf_spf_calculate() for
4155 freeing rtrs.
4156
41571999-08-31 Toshiaki Takada <takada@zebra.org>
4158
4159 * ospf_lsa.c (show_ip_ospf_database_summary),
4160 (show_ip_ospf_database_summary_asbr),
4161 (show_ip_ospf_database_external): New function added.
4162 `show ip ospf database summary',
4163 `show ip ospf database asbr-summary'
4164 `show ip ospf database external' command can be used.
4165
4166 * ospf_lsa.c (ospf_lsa_count_table): New function added.
4167 (show_ip_ospf_database_all): show nothing if a type of LSA
4168 does not exist.
4169
41701999-08-31 Kunihiro Ishiguro <kunihiro@zebra.org>
4171
4172 * ospf_lsa.c (ospf_maxage_lsa_remover): Preserve next pointer when
4173 the node is deleted.
4174
41751999-08-31 Toshiaki Takada <takada@zebra.org>
4176
4177 * ospf_flood.c (ospf_ls_retransmit_lookup): change to return
4178 struct ospf_lsa *.
4179 (ospf_ls_request_new), (ospf_ls_request_free),
4180 (ospf_ls_request_add), (ospf_ls_request_delete),
4181 (ospf_ls_request_delete_all), (ospf_ls_request_lookup):
4182 New function added.
4183
4184 * ospf_packet.c (ospf_ls_upd_send_lsa): New function added.
4185
4186 * ospf_lsa.h (LS_AGE): Slightly change macro definition.
4187
4188 * ospf_lsa.c (ospf_lsa_more_recent), (ospf_lsa_diffrent):
4189 Use LS_AGE macro.
4190
41911999-08-30 Alex Zinin <zinin@amt.ru>
4192
4193 * ospfd.c
4194 fix a bug with area range config write
4195 added "show ip ospf" command, it will be enhanced later on
4196
41971999-08-30 Alex Zinin <zinin@amt.ru>
4198
4199 * ospf_lsa.c
4200 updated ospf_router_lsa() to honor flags (B-bit)
4201
42021999-08-30 Alex Zinin <zinin@amt.ru>
4203
4204 * ospf_abr.c
4205 wrote major functions implementing ABR activity
4206
42071999-08-30 Alex Zinin <zinin@amt.ru>
4208
4209 * ospf_ia.c ospf_route.c ospf_route.h
4210 fixed the bug with ospf_route.origin field.
4211 Now it holds pointer to lsa_header
4212
42131999-08-30 Alex Zinin <zinin@amt.ru>
4214
4215 * ospf_flood.c ospf_flood.h:
4216 transformed ospf_flood_if_select into ospf_flood_through_area()
4217 added new ospf_flood_if_select() and ospf_flood_through_as()
4218
42191999-08-30 Toshiaki Takada <takada@zebra.org>
4220
4221 * ospf_flood.[ch]: New file added.
4222
4223 * ospf_packet.c (ospf_lsa_flooding),
4224 (ospf_lsa_flooding_select_if): functions move to ospf_flood.c
4225
4226 * ospf_neighbor.c (ospf_put_lsa_on_retransm_list),
4227 (ospf_remove_lsa_from_retransm_list),
4228 (ospf_nbr_remove_all_lsas_from_retransm_list),
4229 (ospf_lsa_remove_from_ls_retransmit):
4230 (ospf_lsa_retransmit): functions move to
4231 ospf_flood.c, and change function's name:
4232
4233 ospf_put_lsa_on_retransm_list ()
4234 -> ospf_ls_retransmit_add ()
4235 ospf_remove_lsa_from_retransm_list ()
4236 -> ospf_ls_retransmit_delete ()
4237 ospf_nbr_remove_all_lsas_from_retransm_list ()
4238 -> ospf_ls_retransmit_clear ()
4239 ospf_lsa_remove_from_ls_retransmit ()
4240 -> ospf_ls_retransmit_delete_nbr_all ()
4241 ospf_lsa_retransmit ()
4242 -> ospf_ls_retransmit_add_nbr_all ()
4243
4244 * ospf_lsa.c (ospf_lsa_lookup_from_list): function move to
4245 ospf_flood.c, and change name to ospf_ls_retransmit_lookup ().
4246
42471999-08-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4248
4249 * ospf_neighbor.c (ospf_nbr_lookup_by_addr): Use
4250 route_node_lookup() instead of route_node_get().
4251
4252 * ospf_packet.c (ospf_ls_upd): Temporary comment out (6) check.
4253
42541999-08-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4255
4256 * ospf_route.c (ospf_lookup_int_by_prefix): Add check of
4257 oi->address.
4258
42591999-08-29 Alex Zinin <zinin@amt.ru>
4260 * ospf_lsa.c
4261 MaxAge LSA deletion functions added.
4262
42631999-08-29 Alex Zinin <zinin@amt.ru>
4264 * ospf_neighbor.c
4265 ospf_nbr_lookup_by_addr(): added route_unlock_node()
4266 when function returns NULL if (rn->info == NULL)
4267
42681999-08-29 Alex Zinin <zinin@amt.ru>
4269 * ospfd.c
4270 added a hack for area range deletion
4271
42721999-08-29 Alex Zinin <zinin@amt.ru>
4273 * ospf_lsa.h
4274 included lsdb field into struct ospf_lsa, to find
4275 LSDB easier when removing MaxAge LSAs.
4276
42771999-08-29 Alex Zinin <zinin@amt.ru>
4278 * ospf_lsa.c ospf_neighbor.c ospf_nsm.c
4279 ospf_packet.c changed to honor new retransmit list
4280 management functions
4281
42821999-08-29 Alex Zinin <zinin@amt.ru>
4283 * ospf_neighbor.c , .h added new retransmit list functions.
4284
42851999-08-29 Alex Zinin <zinin@amt.ru>
4286 * Makefile.in
4287 added ospf_ase, ospf_abr, ospf_ia
4288
42891999-08-29 Alex Zinin <zinin@amt.ru>
4290 * ospf_spf.c:
4291 - changed ospf_next_hop_calculation() to include interface
4292 and nexthop addr for directly connected routers---more informative
4293 and solves problem with route installation into the kernel
4294 - changed ospf_nexthop_out_if_addr() to support routers, not only
4295 transit networks
4296 - added ospf_process_stubs();
4297
42981999-08-29 Alex Zinin <zinin@amt.ru>
4299 * ospf_lsa.c:
4300 - changed ospf_router_lsa() to provide correct links
4301 for p-t-p interfaces;
4302 - changed ospf_summary_lsa_install() to support table
4303 of self-originated summary-LSAs;
4304 - added ospf_summary_asbr_lsa_install() and ospf_external_lsa_install()
4305 - changed ospf_lsa_install() accordingly
4306 - changed show_ip_ospf_database_router_links() to support p-t-p
4307
43081999-08-29 Kunihiro Ishiguro <kunihiro@zebra.org>
4309
4310 * ospf_packet.c (ospf_make_db_desc): Only master can clear more
4311 flag.
4312
43131999-08-29 Kunihiro Ishiguro <kunihiro@zebra.org>
4314
4315 * ospf_packet.c (ospf_read): Add check of IP src address.
4316
43171999-08-28 Alex Zinin <zinin@amt.ru>
4318 * ospf_neighbor.h
4319 added ospf_nbr_lookup_by_routerid()
4320
43211999-08-28 Alex Zinin <zinin@amt.ru>
4322 * ospfd.h
4323 added ABR/ASBR flag definitions and fields;
4324 added iflist field to area structure;
4325 summary_lsa_self and summary_lsa_asbr_self are changed
4326 to be route tables;
4327 added ranges field---configured area ranges;
4328 A separate Routers RT added;
4329 area range config commands and config write added
4330
4331
43321999-08-28 Alex Zinin <zinin@amt.ru>
4333 * ospf_route.c :
4334 ospf_route_free()--added code to free the list of paths;
4335 The following functions added:
4336 ospf_intra_add_router();
4337 ospf_intra_add_transit();
4338 ospf_intra_add_stub();
4339 the last function uses new ospf_int_lookup_by_prefix();
4340 show_ip_ospf_route_cmd()--changed to support new RT structure;
4341 added ospf_cmp_routes()--general route comparision function;
4342 added ospf_route_copy_nexthops() and ospf_route_copy_nexthops_from_vertex()
4343 they are used in ASE and IA routing;
4344 added ospf_subst_route() and ospf_add_route();
4345
43461999-08-28 Alex Zinin <zinin@amt.ru>
4347 * ospf_route.h :
4348 changed struct ospf_path to include output interface,
4349 changed struct ospf_route to support IA and ASE routing.
4350 added prototypes of the function used in IA and ASE modules.
4351
43521999-08-28 Alex Zinin <zinin@amt.ru>
4353 * ospf_lsa.h ospf_lsa.c :
4354 added ospf_my_lsa(), an interface independent version of
4355 ospf_lsa_is_self_originated(), it will be used in ASE and IA-routing.
4356
43571999-08-27 Kunihiro Ishiguro <kunihiro@zebra.org>
4358
4359 * ospf_interface.c (interface_config_write): Add check for
4360 oi->nbr_self.
4361
43621999-08-25 Toshiaki Takada <takada@zebra.org>
4363
4364 * ospf_lsa.c (ospf_lsa_dup): New function added.
4365
4366 * ospf_packet.c (ospf_write), (ospf_read): Print send/recv
4367 interface in debug message.
4368
43691999-08-25 Toshiaki Takada <takada@zebra.org>
4370
4371 * ospf_packet.c (ospf_ls_ack_send): The name is changed from
4372 `ospf_ls_ack_send'.
4373 (ospf_ls_ack_send_delayed) (ospf_ls_ack_timer): New function added.
4374 Delayed Link State Acknowledgment is scheduled by timer.
4375
43761999-08-25 Alex Zinin <zinin@amt.ru>
4377
4378 * ospf_lsa.c (ospf_router_lsa): Incorrectly included link to
4379 a stub network instead of link to a transit network into
4380 originated router-LSA, bug fixed.
4381
43821999-08-24 Toshiaki Takada <takada@zebra.org>
4383
4384 * ospfd.c (ospf_update_router_id): New function added.
4385
4386 * ospf_network.c (ospf_write): Create new socket per transmission.
4387 And select outgoing interface whether dst is unicast or multicast.
4388
4389 * ospf_packet.c: LSA flooding will work.
4390
43911999-08-24 VOP <vop@unity.net>
4392
4393 * ospf_route.c: Include "sockunion.h"
4394
43951999-08-24 Kunihiro Ishiguro <kunihiro@zebra.org>
4396
4397 * ospf_network.c (ospf_serv_sock_init): Enclose
4398 IPTOS_PREC_INTERNETCONTROL setting with #ifdef for OS which does
4399 not have the definition.
4400
44011999-08-23 Toshiaki Takada <takada@zebra.org>
4402
4403 * ospf_packet.c: Fix bug of DD processing.
4404
44051999-08-18 Toshiaki Takada <takada@zebra.org>
4406
4407 * ospf_lsa.c (show_ip_ospf_database): Show actual `LS age'.
4408
44091999-08-17 Toshiaki Takada <takada@zebra.org>
4410
4411 * ospf_lsa.h (OSPF_MAX_LSA): The value of OSPF_MAX_LSA is
4412 corrected. The bug of `mes_lookup' is fixed.
4413 This had been reported by Poul-Henning Kamp <phk@freebsd.org>.
4414
4415 * ospf_lsa.c (ospf_router_lsa_install): The name is changed from
4416 `ospf_add_router_lsa'.
4417 (ospf_network_lsa_install): The name is changed from
4418 `ospf_add_network_lsa'.
4419
4420 * ospf_interface.h (ospf_interface): Add member `nbr_self'.
4421
4422 * ospf_interface.c (ospf_if_is_enable): New function added.
4423
44241999-08-16 Toshiaki Takada <takada@zebra.org>
4425
4426 * ospf_lsa.h (struct lsa_header): The name is changed from
4427 `struct ospf_lsa'.
4428 (struct ospf_lsa): New struct added to control each LSA's aging
4429 and timers.
4430
4431 * ospf_lsa.c (ospf_lsa_data_free): The name is change from
4432 `ospf_lsa_free'.
4433 (ospf_lsa_data_new), (ospf_lsa_new), (ospf_lsa_free),
4434 (ospf_lsa_different), (ospf_lsa_install): New function added.
4435
4436 * ospf_packet.c (ospf_ls_upd_list_lsa): New function added.
4437
44381999-08-12 Toshiaki Takada <takada@zebra.org>
4439
4440 * ospf_nsm.c (nsm_reset_nbr): New function added.
4441 KillNbr and LLDown neighbor event call this function.
4442
44431999-08-10 Toshiaki Takada <takada@zebra.org>
4444
4445 * ospf_packet.c (ospf_ls_retransmit)
4446 (ospf_ls_upd_timer): New function added.
4447 Set retransmission timer for Link State Update.
4448
44491999-07-29 Toshiaki Takada <takada@zebra.org>
4450
4451 * ospf_ism.c (ospf_dr_election): Fix bug of DR election.
4452
44531999-07-28 Toshiaki Takada <takada@zebra.org>
4454
4455 * ospf_network.c (ospf_serv_sock_init): Set IP precedence field
4456 with IPTOS_PREC_INTERNET_CONTROL.
4457
4458 * ospf_nsm.c (nsm_change_status): Schedule NeighborChange event
4459 if NSM status change.
4460
4461 * ospf_packet.c (ospf_make_hello): Never include a neighbor in
4462 Hello packet, when the neighbor goes down.
4463
44641999-07-26 Kunihiro Ishiguro <kunihiro@zebra.org>
4465
4466 * Makefile.am (noinst_HEADERS): Add ospf_route.h.
4467
4468 * ospf_route.c (show_ip_ospf_route): Add `show ip ospf route'
4469 command.
4470
44711999-07-25 Toshiaki Takada <takada@zebra.org>
4472
4473 * ospf_lsa.c (ospf_router_lsa): Fix bug of LS sequence number
4474 assignement.
4475
44761999-07-25 Kunihiro Ishiguro <kunihiro@zebra.org>
4477
4478 * ospf_route.c (ospf_route_table_free): New function added.
4479
4480 * ospf_spf.c (ospf_spf_next): Free vertex w when cw's and w's
4481 distance is same.
4482
4483 * ospfd.h (struct ospf): Add old_table.
4484
4485 * ospf_main.c (sighup): Call of log_rotate () removed.
4486
4487 * ospf_lsa.c (ospf_lsa_is_self_originated): Fix bug of checking
4488 area->lsa as self LSA. This should be area->lsa_self.
4489
44901999-07-24 Kunihiro Ishiguro <kunihiro@zebra.org>
4491
4492 * ospf_zebra.c (ospf_zebra_add): ospf_zebra_add
4493 (),ospf_zebra_delete () added.
4494
4495 * ospf_spf.c (ospf_spf_calculate): Call ospf_intra_route_add ().
4496
44971999-07-24 Toshiaki Takada <takada@zebra.org>
4498
4499 * ospf_lsa.c: Change LS sequence number treatment.
4500 (ospf_lsa_is_self_originated): New function added.
4501 (show_ip_ospf_database_self_originated): New DEFUN added.
4502
45031999-07-23 Kunihiro Ishiguro <kunihiro@zebra.org>
4504
4505 * ospf_interface.c (ospf_if_lookup_by_addr): Add loopback check.
4506
45071999-07-22 Toshiaki Takada <takada@zebra.org>
4508
4509 * ospf_spf.c (ospf_nexthop_new), (ospf_nexthop_free),
4510 (ospf_nexthop_dup): function added.
4511 (ospf_nexthop_calculation): function changed.
4512
4513 * ospf_interface.c (ospf_if_lookup_by_addr): function added.
4514
45151999-07-21 Toshiaki Takada <takada@zebra.org>
4516
4517 * ospf_spf.c (ospf_spf_closest_vertex): function removed.
4518
45191999-07-21 Kunihiro Ishiguro <kunihiro@zebra.org>
4520
4521 * ospf_spf.c (ospf_spf_next): Apply ntohs for fetching metric.
4522
45231999-07-21 Toshiaki Takada <takada@zebra.org>
4524
4525 * ospf_neighbor.c (ospf_nbr_lookup_by_router_id): fundtion removed.
4526
4527 * ospf_lsa.c (show_ip_ospf_database_router): describe each
4528 connected link.
4529
45301999-07-21 Kunihiro Ishiguro <kunihiro@zebra.org>
4531
4532 * ospf_spf.c (ospf_spf_next): V is router LSA or network LSA so
4533 change behavior according to LSA type.
4534 (ospf_lsa_has_link): Link check function is added.
4535
45361999-07-20 Kunihiro Ishiguro <kunihiro@zebra.org>
4537
4538 * ospf_spf.c (ospf_spf_calculate_schedule): Add new function for
4539 SPF calcultion schedule addtition.
4540 (ospf_spf_calculate_timer_add): Rough 30 sec interval SPF calc
4541 timer is added.
4542 (ospf_spf_next_router): Delete ospf_spf_next_network ().
4543
4544 * ospf_lsa.c (show_ip_ospf_database_all): Network-LSA display
4545 header typo correction. Display of router LSA's #link added.
4546
45471999-07-19 Toshiaki Takada <takada@zebra.org>
4548
4549 * ospf_packet.c (ospf_check_network_mask): Added new function for
4550 receiving Raw IP packet on an appropriate interface.
4551
45521999-07-16 Toshiaki Takada <takada@zebra.org>
4553
4554 * ospfd.c (ospf_router_id): new DEFUN added.
4555
45561999-07-15 Toshiaki Takada <takada@zebra.org>
4557
4558 * ospf_spf.c (ospf_spf_init), (ospf_spf_free),
4559 (ospf_spf_has_vertex), (ospf_vertex_lookup),
4560 (ospf_spf_next_router), (ospf_spf_next_network),
4561 (ospf_spf_closest_vertex), (ospf_spf_calculate):
4562 function added.
4563
45641999-07-13 Toshiaki Takada <takada@zebra.org>
4565
4566 * ospf_ism.c: fix bug of DR Election.
4567
4568 * ospf_nsm.c: fix bug of adjacency forming.
4569
45701999-07-05 Kunihiro Ishiguro <kunihiro@zebra.org>
4571
4572 * ospfd.c (ospf_init): Change to use install_default.
4573
45741999-07-01 Rick Payne <rickp@rossfell.co.uk>
4575
4576 * ospf_zebra.c (zebra_init): Install standard commands to
4577 ZEBRA_NODE.
4578
45791999-06-30 Toshiaki Takada <takada@zebra.org>
4580
4581 * ospf_dump.c: Whole debug command is improved.
4582 (ISM|NSM) (events|status|timers) debug option added.
4583 (show_debugging_ospf): new DEFUN added.
4584
45851999-06-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4586
4587 * ospf_lsa.c (ospf_lsa_lookup_from_list): Change !IPV4_ADDR_CMP to
4588 IPV4_ADDR_SAME.
4589
45901999-06-29 Toshiaki Takada <takada@zebra.org>
4591
4592 * ospf_dump.c (ospf_summary_lsa_dump): Add summary-LSA dump routine.
4593 (ospf_as_external_lsa_dump): Add AS-external-LSA dump routine.
4594
4595 * ospf_nsm.c (nsm_twoway_received): fix condtion of adjacnet.
4596
4597 * ospf_ism.c (ospf_dr_election): fix DR Election.
4598
4599 * ospf_dump.c (ospf_nbr_state_message): fix `show ip ospf neighbor'
4600 command's state.
4601
46021999-06-29 Kunihiro Ishiguro <kunihiro@zebra.org>
4603
4604 * ospf_dump.c (ospf_router_lsa_dump): Add router-LSA dump routine.
4605
46061999-06-28 Toshiaki Takada <takada@zebra.org>
4607
4608 * ospf_lsa.c (show_ip_ospf_database_network): fix bug of
4609 `show ip ospf database network' command output.
4610
4611 * ospf_nsm.c (nsm_inactivity_timer): Clear list of Link State
4612 Retransmission, Database Summary and Link State Request.
4613
4614 * ospf_packet.c (ospf_ls_req_timer): New function added.
4615 Set Link State Request retransmission timer.
4616
46171999-06-27 Kunihiro Ishiguro <kunihiro@zebra.org>
4618
4619 * ospf_main.c (main): Change default output from ZLOG_SYSLOG to
4620 ZLOG_STDOUT.
4621
4622 * ospfd.c (ospf_init): Register show_ip_ospf_interface_cmd and
4623 show_ip_ospf_neighbor_cmd to VIEW_NODE.
4624
4625 * ospf_lsa.c (ospf_lsa_init): Register show_ip_ospf_database_cmd
4626 and show_ip_ospf_database_type_cmd to VIEW_NODE.
4627
46281999-06-25 Toshiaki Takada <takada@zebra.org>
4629
4630 * ospf_packet.c: fix bug of DD making.
4631 fix bug of LS-Update reading.
4632
46331999-06-23 Toshiaki Takada <takada@zebra.org>
4634
4635 * ospf_packet.c: All type of packets are changed to use
4636 fifo queue structure.
4637 (ospf_fill_header) function added.
4638
46391999-06-22 Toshiaki Takada <takada@zebra.org>
4640
4641 * ospf_packet.c (ospf_packet_new): New function added to handle
4642 sending ospf packet by fifo queue structure.
4643 (ospf_packet_free), (ospf_fifo_new), (ospf_fifo_push),
4644 (ospf_fifo_pop), (ospf_fifo_head), (ospf_fifo_flush),
4645 (ospf_fifo_free): Likewise.
4646
46471999-06-21 Toshiaki Takada <takada@zebra.org>
4648
4649 * ospf_nsm.c (ospf_db_desc_timer): function added.
4650 (nsm_timer_set) function added.
4651 * ospf_dump.c (ospf_option_dump): function added.
4652 * ospf_packet.c (ospf_ls_req) (ospf_make_ls_req): function added.
4653
46541999-06-20 Toshiaki Takada <takada@zebra.org>
4655
4656 * ospf_lsa.c (ospf_lsa_more_recent): function added.
4657 * ospf_neighbor.h (struct ospf_neighbor): Change member ms_flag
4658 to dd_flags.
4659
46601999-06-19 Toshiaki Takada <takada@zebra.org>
4661
4662 * ospf_lsa.c: DEFUN (show_ip_ospf_database) Added.
4663 * ospf_interface.c (if_ospf_cost), (if_ospf_dead_interval),
4664 (if_ospf_hello_interval), (if_ospf_priority),
4665 (if_ospf_retransmit_interval), (if_ospf_transmit_delay)
4666 argument changed from NUMBER to <range>.
4667 DEFUN (if_ospf_network_broadcast),
4668 DEFUN (if_ospf_network_non_broadcast),
4669 DEFUN (if_ospf_network_point_to_multipoint),
4670 DEFUN (if_ospf_network_point_to_point) functions are combined to
4671 DEFUN (if_ospf_network).
4672
46731999-06-18 Toshiaki Takada <takada@zebra.org>
4674
4675 * ospf_lsa.c: ospf_add_router_lsa (), ospf_add_network_lsa (),
4676 ospf_lsa_lookup (), ospf_lsa_count () Added.
4677
46781999-06-15 Toshiaki Takada <takada@zebra.org>
4679
4680 * DEFUN (ospf_debug_ism), DEFUN (ospf_debug_nsm),
4681 DEFUN (no_ospf_debug_ism), DEFUN (no_ospf_debug_nsm) Added.
4682 `debug ospf ism' command shows debug message.
4683 `debuf ospf nsm' command shows debug message.
4684
46851999-06-14 Toshiaki Takada <takada@zebra.org>
4686
4687 * ospf_lsa.c: ospf_network_lsa () Added.
4688 ospf_lsa_checksum () Added.
4689 * DEFUN (ospf_debug_packet), DEFUN (no_ospf_debug_packet) Added.
4690 `debug ospf packet' command shows debug message.
4691
46921999-06-13 Toshiaki Takada <takada@zebra.org>
4693
4694 * ospf_packet.h: Remove struct ospf_ls_req {}, ospf_ls_upd {},
4695 ospf_ls_ack {}.
4696
46971999-06-11 Toshiaki Takada <takada@zebra.org>
4698
4699 * ospf_dump.c: fix IP packet length treatment.
4700
47011999-06-10 Toshiaki Takada <takada@zebra.org>
4702
4703 * ospf_ism.h: Add OSPF_ISM_EVENT_EXECUTE() Macro Added.
4704 * ospf_nsm.h: Add OSPF_NSM_EVENT_EXECUTE() Macro Added.
4705
4706 * ospf_packet.c: ospf_db_desc (), ospf_db_desc_send () Added.
4707 ospf_make_hello (), ospf_make_db_desc () Added.
4708 ospf_db_desc_proc () Added.n
4709
4710 * Database Description packet can be processed.
4711
47121999-06-08 Toshiaki Takada <takada@zebra.org>
4713
4714 * ospf_lsa.c: New file.
4715
47161999-06-07 Toshiaki Takada <takada@zebra.org>
4717
4718 * ospf_neighbor.c: ospf_fully_adjacent_count () Added.
4719
47201999-06-07 Kunihiro Ishiguro <kunihiro@zebra.org>
4721
4722 * ospf_spf.[ch]: New file.
4723
47241999-05-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4725
4726 * ospf_zebra.c: Changed to use lib/zclient.c routines.
4727
4728 * ospf_zebra.h (zebra_start): Remove struct zebra.
4729
47301999-05-29 Kunihiro Ishiguro <kunihiro@zebra.org>
4731
4732 * ospfd.c (ospf_config_write): Add cast (unsigned long int) to
4733 ntohl for sprintf warning.
4734
47351999-05-19 Toshiaki Takada <takada@zebra.org>
4736
4737 * ospf_ism.c (ospf_dr_election): Join AllDRouters Multicast group
4738 if interface state changes to DR or BDR.
4739
47401999-05-14 Stephen R. van den Berg <srb@cuci.nl>
4741
4742 * ospf_main.c (signal_init): SIGTERM call sigint.
4743 (sigint): Logging more better message.
4744
47451999-05-12 Toshiaki Takada <takada@zebra.org>
4746
4747 * ospfd.c: Fix bug of `no router ospf' statement, it will work.
4748
47491999-05-11 Toshiaki Takada <takada@zebra.org>
4750
4751 * ospf_neighbor.c: ospf_nbr_free () Added.
4752
47531999-05-10 Toshiaki Takada <takada@zebra.org>
4754
4755 * ospfd.h: struct ospf_area { }, struct ospf_network { } Changed.
4756 * Fix bug of `no network' statement, it will work.
4757
47581999-05-07 Toshiaki Takada <takada@zebra.org>
4759
4760 * ospf_interface.c, ospf_zebra.c: Fix bug of last interface is not
4761 updated by ospf_if_update ().
4762
47631999-04-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4764
4765 * Makefile.am (noinst_HEADERS): Add ospf_lsa.h for distribution.
4766
47671999-04-25 Toshiaki Takada <takada@zebra.org>
4768
4769 * ospf_interface.c: DEFUN (no_if_ospf_cost),
4770 DEFUN (no_if_ospf_dead_interval),
4771 DEFUN (no_if_ospf_hello_interval),
4772 DEFUN (no_if_ospf_priority),
4773 DEFUN (no_if_ospf_retransmit_interval),
4774 DEFUN (no_if_ospf_transmit_delay) Added.
4775
4776 interface_config_write () suppress showing interface
4777 default values.
4778
47791999-04-25 Kunihiro Ishiguro <kunihiro@zebra.org>
4780
4781 * ospf_dump.c (ospf_timer_dump): If thread is NULL return "inactive".
4782
4783 * ospfd.c (ospf_if_update): Fix bug of using ospf_area { } instead
4784 of ospf_network { }. So `router ospf' statement in ospfd.conf
4785 works again.
4786 (ospf_if_update): Call ospf_get_router_id for updating router ID.
4787
47881999-04-25 Toshiaki Takada <takada@zebra.org>
4789
4790 * ospf_interface.c: DEFUN (if_ospf_network) deleted.
4791 DEFUN (if_ospf_network_broadcast),
4792 DEFUN (if_ospf_network_non_broadcast),
4793 DEFUN (if_ospf_network_point_to_multipoint),
4794 DEFUN (if_ospf_network_point_to_point),
4795 DEFUN (no_if_ospf_network) Added.
4796
47971999-04-23 Toshiaki Takada <takada@zebra.org>
4798
4799 * ospfd.h: struct area { } changed to struct ospf_network { }.
4800 Add struct ospf_area { }.
4801 * ospfd.c: Add ospf_area_lookup_by_area_id (), ospf_network_new (),
4802 and ospf_network_free ().
4803 DEFUN (area_authentication), DEFUN (no_area_authentication) Added.
4804
48051999-04-22 Toshiaki Takada <takada@zebra.org>
4806
4807 * ospf_lsa.h: New file.
4808 * ospf_packet.h: LSA related struct definition are moved to
4809 ospf_lsa.h.
4810 * ospf_packet.c: ospf_verify_header () Added.
4811
48121999-04-21 Toshiaki Takada <takada@zebra.org>
4813
4814 * ospf_ism.c: ospf_elect_dr () and related function is changed.
4815 DR Election bug fixed.
4816 * ospf_dump.c: ospf_nbr_state_message (), ospf_timer_dump () Added.
4817 * ospfd.c: DEFUN (show_ip_ospf_neighbor) Added.
4818
48191999-04-19 Kunihiro Ishiguro <kunihiro@zebra.org>
4820
4821 * ospf_main.c (main): access_list_init () is added for vty
4822 connection filtering.
4823
48241999-04-16 Toshiaki Takada <takada@zebra.org>
4825
4826 * ospfd.c: DEFUN (show_ip_ospf_interface) Added.
4827 * ospf_neighbor.c: ospf_nbr_count () Added.
4828
48291999-04-15 Toshiaki Takada <takada@zebra.org>
4830
4831 * ospfd.h: struct ospf { } Changed.
4832 * ospfd.c: ospf_lookup_by_process_id () Deleted.
4833 * ospf_ism.c: ospf_wait_timer () Added. WaitTimer will work.
4834
48351999-04-14 Toshiaki Takada <takada@zebra.org>
4836
4837 * ospf_ism.c: ospf_elect_dr () Added.
4838 * ospf_network.c: ospf_if_ipmulticast () Added.
4839
48401999-04-11 Toshiaki Takada <takada@zebra.org>
4841
4842 * ospf_interface.c: interface_config_write (),
4843 DEFUN (if_ip_ospf_cost),
4844 DEFUN (if_ip_ospf_dead_interval),
4845 DEFUN (if_ip_ospf_hello_interval),
4846 DEFUN (if_ip_ospf_priority),
4847 DEFUN (if_ip_ospf_retransmit_interval) and
4848 DEFUN (if_ip_ospf_transmit_delay) Added.
4849
48501999-04-08 Toshiaki Takada <takada@zebra.org>
4851
4852 * ospf_dump.c: ospf_packet_db_desc_dump () Added.
4853 * ospf_neighbor.c: ospf_nbr_bidirectional () Added.
4854 * ospf_nsm.c: nsm_twoway_received () Added.
4855
48561999-04-02 Toshiaki Takada <takada@zebra.org>
4857
4858 * ospf_neighbor.c: New file.
4859 * ospf_neighbor.h: New file.
4860 * ospf_nsm.c: New file.
4861 * ospf_nsm.h: New file.
4862 * ospf_packet.c: Add ospf_make_header (), ospf_hello () and
4863 ospf_hello_send (). Now OSPFd can receive Hello and send Hello.
4864
48651999-03-27 Kunihiro Ishiguro <kunihiro@zebra.org>
4866
4867 * ospf_packet.c: Add ospf_recv_packet (). Now OSPF Hello can receive.
4868
48691999-03-19 Toshiaki Takada <takada@zebra.org>
4870
4871 * ospf_packet.c: New file.
4872 * ospf_packet.h: New file.
4873 * ospf_network.c: New file.
4874 * ospf_network.h: New file.
4875 * ospfd.h: move OSPF message structure has moved to ospf_packet.h.
4876
48771999-03-17 Kunihiro Ishiguro <kunihiro@zebra.org>
4878
4879 * ospf_zebra.c (ospf_zebra_get_interface): Fix for IPv6 interface
4880 address.
4881
4882 * Makefile.am (install-sysconfDATA): Overwrite install-sysconfDATA
4883 for install ospfd.conf.sample as owner read only file.
4884
4885 * ospf_main.c (usage): Change to use ZEBRA_BUG_ADDRESS.
4886
48871999-03-15 Toshiaki Takada <takada@zebra.org>
4888
4889 * ospf_ism.c: New file.
4890 * ospf_ism.h: New file.
4891 * ospf_dump.c: New file.
4892 * ospf_dump.h: New file.
4893
4894 * ospfd.h: Add (struct ospf), (struct config_network),
4895 (struct message) structure.
4896
4897 * ospf_interface.c: Add ospf_if_match_network ().
4898 * ospf_interface.h (struct ospf_interface): Change struct members.
4899
4900 * ospfd.c: ospf_lookup_by_process_id (), ospf_network_new (),
4901 DEFUN (network_area): Added.
4902
4903 * ospfd.conf.sample: Change sample configuration.
4904
49051999-03-05 Toshiaki Takada <takada@zebra.org>
4906
4907 * ospf_interface.c: New file.
4908 * ospf_interface.h: New file.
4909 * ospf_zebra.h: New file.
4910 * ospf_zebra.c: Add interface function for zebra daemon.
4911 * ospfd.c: New file.
4912
49131999-02-23 Kunihiro Ishiguro <kunihiro@zebra.org>
4914
4915 * Move IPv6 codes and files to ospf6d directory.
4916
49171999-02-18 Peter Galbavy <Peter.Galbavy@knowledge.com>
4918
4919 * syslog support added
4920
49211998-12-22 Toshiaki Takada <takada@zebra.org>
4922
4923 * ospfd.h: New file.
4924 * ospf_lsa.h: New file.
4925
49261998-12-15 Kunihiro Ishiguro <kunihiro@zebra.org>
4927
4928 * Makefile.am: New file.
4929 * ospf_main.c: New file.
4930