blob: 610eadb1336ddd8e26d7248f16322d21753260a0 [file] [log] [blame]
Andrew J. Schorre8a56f02007-04-21 20:46:31 +000012007-04-21 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
2
3 * ospf_interface.c: (ospf_if_set_multicast) Fix bug: was testing
4 interface passive status improperly in light of the recent
5 'passive-interface default' patch. Now need to test
6 OSPF_IF_PASSIVE_STATUS(oi) instead of
7 OSPF_IF_PARAM(oi, passive_interface).
8
Paul Jakmab75ae992007-03-23 11:17:28 +000092007-03-23 Paul Jakma <paul.jakma@sun.com>
10
11 * ospf_spf.c: (various) Add more debug statements.
Paul Jakma85ef7842007-03-23 11:19:08 +000012 (ospf_nexthop_calculation) Fix silly regression causing ospfd
13 to fail to calculate paths past networks not attached to root
14 vertex, introduced with bug #330 fixes.
Paul Jakmab75ae992007-03-23 11:17:28 +000015
Andrew J. Schorr56b3ea02007-03-14 20:21:43 +0000162007-03-14 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
17
Andrew J. Schorrad81f8c2007-03-14 22:05:18 +000018 * ospf_snmp.c: (ospf_snmp_neighbor_state) New function to
19 map internal quagga neighbor states to SNMP standard values.
20 (ospfNbrEntry) Call new ospf_snmp_neighbor_state function.
21
222007-03-14 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
23
Andrew J. Schorr56b3ea02007-03-14 20:21:43 +000024 * ospf_zebra.c: (ospf_zebra_add, ospf_zebra_delete) Fix bug
25 where inet_ntoa was used twice in the same debug message,
26 which doesn't work because there's a single shared buffer
27 for the returned string. The fix is to use inet_ntop.
28
Andrew J. Schorr4056a542007-02-27 13:55:46 +0000292007-02-27 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
30
31 * ospfd.c: (ospf_terminate) Exit immediately if ospf is not
32 actually running (e.g. the config file was empty). Fixes
33 bug where SIGTERM would not kill ospfd.
34
Paul Jakmabd34fb32007-02-26 17:14:48 +0000352007-02-26 Paul Jakma <paul.jakma@sun.com>
36
37 * ospf_spf.c: Fix regression introduced with bug #330 fix: The
38 cost update added to ospf_spf_add_parent only handled PtP
39 case, differing from same functionality in higher-level
40 ospf_spf_next. Regression diagnosed by Anders Pedersen,
41 mailnews+router-quagga-dev@news.cohaesio.com.
42 (ospf_vertex_new) Initialise vertices to max-cost.
43 (ospf_spf_init) Root vertex always creates with 0 cost.
44 (ospf_spf_add_parent) Remove the buggy V->W cost calculating
45 code, instead take the new distance as a parameter.
46 (ospf_nexthop_calculation) Take distance as parameter, so it
47 can be passed down to add_parent.
48 (ospf_spf_next) Dont initialise candiate vertex distance,
49 vertex_new does so already. Pass distance down to
50 nexthop_calculation (see above).
51
Paul Jakmabc20c1a2007-01-24 14:51:51 +0000522007-01-24 Paul Jakma <paul.jakma@sun.com>
53
54 * ospf_spf.c: Bug #330: Nexthop calculation sometimes may fail,
55 and it needs to indicate this result to SPF.
56 (ospf_spf_add_parent) Flush of parent list needs to be done here,
57 for simplicity.
58 (ospf_nexthop_calculation) Caller needs to know whether
59 nexthop calculation succeeded. Every return statement must
60 correctly indicate such.
61 (ospf_spf_next) Queueing/prioritisation of vertices in SPF
62 must take into account whether nexthop_calculation succeeded,
63 or SPF may fail to find best paths.
64
Andrew J. Schorre4529632006-12-12 19:18:21 +0000652006-12-12 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
66
67 * ospf_interface.c: (ospf_if_is_configured, ospf_if_lookup_by_prefix,
68 ospf_if_lookup_recv_if) Simplify logic using new CONNECTED_PREFIX
69 macro.
70 * ospf_lsa.c: (lsa_link_ptop_set) Using the new CONNECTED_PREFIX
71 macro, both options collapse into the same code.
72 * ospf_snmp.c: (ospf_snmp_if_update) Simplify logic using new
73 CONNECTED_ID macro.
74 (ospf_snmp_is_if_have_addr) Simplify logic using new CONNECTED_PREFIX
75 macro.
76 * ospf_vty.c: (show_ip_ospf_interface_sub) Use new CONNECTED_PEER macro
77 instead of testing the IFF_POINTOPOINT flag.
78 * ospfd.c: (ospf_network_match_iface) Use new CONNECTED_PEER macro
79 instead of testing with if_is_pointopoint. And add commented-out
80 code to implement alternative (in my opinion) more elegant behavior
81 that has no special-case treatment for PtP addresses.
82 (ospf_network_run) Use new CONNECTED_ID macro to simplify logic.
83
Andrew J. Schorred589c12006-12-04 18:26:37 +0000842006-12-04 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
85
86 * ospfd.c: (ospf_network_run) Remove an offending 'break' statement.
87 Previously, after creating a single ospf_interface on a given
88 network interface, the code would skip to the next interface
89 without considering other connected addresses on the interface.
90 After removing the 'break', we now consider all connected addresses.
91
Andrew J. Schorr7f643eb2006-11-30 16:17:02 +0000922006-11-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
93
94 * ospf_zebra.c: (ospf_router_id_update_zebra,
95 ospf_interface_address_add, ospf_interface_address_delete)
96 If (IS_DEBUG_OSPF (zebra, ZEBRA_INTERFACE)) is enabled, then
97 add a debug message about what Zebra is telling us.
98 (ospf_zebra_add_discard) Add a debug message matching the one
99 already in ospf_zebra_delete_discard.
100
Andrew J. Schorr43540882006-11-28 16:36:39 +00001012006-11-28 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
102
103 * ospf_vty.c: (ospf_passive_interface_default) Take additional
104 'newval' arg so we can update ospf->passive_interface_default inside
105 this function. More importantly, we now call ospf_if_set_multicast
106 on all ospf_interfaces.
107 (ospf_passive_interface, no_ospf_passive_interface) Fix bug:
108 for 'default' case, argv[0] is undefined, so we must test for
109 (argc == 0) before using argv[0]. And since
110 ospf_passive_interface_default now calls ospf_if_set_multicast as
111 needed, we can just return after calling
112 ospf_passive_interface_default.
113
Andrew J. Schorr8fb8a502006-10-24 19:04:26 +00001142006-10-24 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
115
116 * ospf_zebra.c: (ospf_redistribute_default_set) Fix bug where
117 a new value for ospf->default_originate was being ignored
118 if a previous 'default-information originate' command
119 had already been processed.
120
Paul Jakma7ffa8fa2006-10-22 20:07:53 +00001212006-10-22 Yar Tikhiy <yar@comp.chem.msu.su>
122
123 * (general) Add support for passive-interface default (with
124 minor edits by Paul Jakma).
125 * ospf_interface.h: Add OSPF_IF_PASSIVE_STATUS macro, looking
126 at configured value, or the global 'default' value, as
127 required.
128 * ospf_interface.c: (ospf_if_new_hook) Leave passive
129 unconfigured per default, allowing global 'default' to
130 take effect for unconfigured interfaces.
131 * ospf_packet.c: (various) use OSPF_IF_PASSIVE_STATUS
132 * ospf_vty.c: (ospf_passive_interface_default) new function,
133 unset passive from all interfaces if default is enabled, as
134 the per-iface settings become redundant.
135 (ospf_passive_interface_update) new func, update passive
136 setting taking global default into account.
137 ({no,}ospf_passive_interface_addr_cmd) Add support for
138 'default' variant of command.
139 (show_ip_ospf_interface_sub) Update to take global
140 default into account when printing passive status.
141 (ospf_config_write) ditto.
142 * ospfd.c: (ospf_new) set global passive-interface default.
143 * ospfd.h: (struct ospf) Add field for global
144 passive-interface.
145
Andrew J. Schorr08c83672006-09-25 13:26:14 +00001462006-09-25 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
147
148 * ospf_packet.c: (ospf_packet_dup, ospf_make_md5_digest)
149 Fix zlog_warn messages to eliminate compiler warnings.
150 (ospf_hello) Improve warning messages to show why we
151 are complaining.
152
Paul Jakmab5aeb442006-08-30 18:47:37 +00001532006-08-28 Andy Gay <andy@andynet.net>
154
155 * ospf_packet.c: (ospf_make_db_desc) Assert added with More-bit
156 fixes does not hold up with addition of Ogier DB-Exchange
157 optimisation, which can empty the db-summary list in between
158 sent DD packets. Remove assert, update More-bit always when
159 in Exchange.
160
Paul Jakma29b5a042006-08-27 08:01:20 +00001612006-08-27 J.J. Krabbendam <jkrabbendam@aimsys.nl>
162
163 * ospfd.c: (ospf_finish_final) default redistribute should be
164 unset too, fixes bug where reconfiguring ospfd completely
165 can no longer enable default redistribution.
166
Paul Jakma2518efd2006-08-27 06:49:29 +00001672006-08-25 Paul Jakma <paul.jakma@sun.com>
168
169 * (general) Bug #134. Be more robust to backward time changes,
170 use the newly added libzebra time functions.
171 In most cases: recent_time -> recent_relative_time()
172 gettimeofday -> quagga_gettime (QUAGGA_CLK_MONOTONIC, ..)
173 time -> quagga_time.
174 (ospf_make_md5_digest) time() call deliberately not changed.
175 (ospf_external_lsa_refresh) remove useless gettimeofday, LSA
176 tv_orig time was already set in ospf_lsa_new, called via
177 ospf_external_lsa_new.
178
Paul Jakmaba122e72006-08-27 06:24:34 +00001792006-08-04 Paul Jakma <paul.jakma@sun.com>
180
181 * ospf_lsdb.c: (ospf_lsdb_delete_entry) new function, consolidate
182 exact same functionality replicated in other functions.
183 (ospf_lsdb_add) Strip out code by using ospf_lsdb_delete_entry.
184 (ospf_lsdb_delete) ditto.
185 (ospf_lsdb_delete_all) ditto.
186
Paul Jakma8dd24ee2006-08-27 06:29:30 +00001872006-08-03 Paul Jakma <paul.jakma@sun.com>
188
189 * ospf_packet.c: (ospf_make_db_desc) Unset the DD More bit
190 after constructing the packet, if appropriate.
191 (ospf_db_desc_proc) Speed up Exchange, slave should raise
192 ExchangeDone earlier, as RFC mandates, by forming its reply
193 before deciding whether both sides are done, avoids a
194 needless round of empty DD packet exchanges at the end of
195 Exchange, hence speeding up ExchangeDone.
Paul Jakmaf0894cf2006-08-27 06:40:04 +0000196 Implement draft-ogier-ospf-dbex-opt DB-exchange optimisation.
Paul Jakma8dd24ee2006-08-27 06:29:30 +0000197 (ospf_db_desc) use UNSET_FLAG macro.
198
Andrew J. Schorr16700082006-07-27 22:29:06 +00001992006-07-27 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
200
201 * ospfd.c: (ospf_router_id_update) Fix and document the algorithm for
202 selecting the router ID: if there is not a statically configured ID,
203 then stick to the most recent value to avoid disruptive changes.
204 This should fix bug #288.
205
Paul Jakma1fe6ed32006-07-26 09:37:26 +00002062006-07-26 Paul Jakma <paul.jakma@sun.com>
207
208 * ospf_lsa.{c,h}: (ospf_lsa_unlock) Change to take a double pointer
209 to the LSA to be 'unlocked', so that, if the LSA is freed, the
210 callers pointer to the LSA can be NULLed out, allowing any further
211 use of that pointer to provoke a crash sooner rather than later.
212 * ospf_*.c: (general) Adjust callers of ospf_lsa_unlock to match
213 previous. Try annotate 'locking' somewhat to show which 'locks'
214 are protecting what LSA reference, if not obvious.
215 * ospf_opaque.c: (ospf_opaque_lsa_install) Trivial: remove useless
216 goto, replace with return.
217 * ospf_packet.c: (ospf_make_ls_ack) Trivial: merge two list loops,
218 the dual-loop predated the delete-safe list-loop macro.
219
Paul Jakma3fed4162006-07-25 20:44:12 +00002202006-07-25 Paul Jakma <paul.jakma@sun.com>
221
222 * ospf_neigbor.h: (struct ospf_neighbor) Add some additional
223 neighbour state statistics fields, timestamps for progressive
224 and regressive state changes, and pointer to event string
225 for the latter state change.
226 * ospf_nsm.c: (nsm_notice_state_change) Update new state changs
227 history as required.
228 * ospf_vty.c: (show_ip_ospf_neighbor_detail_sub) Print out above
229 new per-neighbour state change stats.
230
Paul Jakma539e1522006-07-11 17:49:22 +00002312006-07-10 Paul Jakma <paul.jakma@sun.com>
232
233 * ospf_nsm.c: (nsm_change_state) call nsm_clear_adj for all
234 adjacency losses, hence removing need for nsm_reset_nbr.
235 (nsm_reset_nbr) kill it, clear_adj in previous does fine.
236 (nsm_kill_nbr,nsm_start) remove nsm_reset_nbr call.
237 (ospf_nsm_event) Allow NSM function to be NULL, this along with
238 removal of nsm_reset_nbr, allows a bunch of now useless functiosn
239 to be removed.
240 Remove some useless variables.
241 (nsm_ignore) now useless, remove.
242 (nsm_bad_ls_req) ditto
243 (nsm_seq_number_mismatch) "
244 (nsm_oneway_received) "
245 (nsm_inactivity_timer) "
246 (nsm_ll_down) "
247 (NSM) replace removed action functions with NULL.
Paul Jakma3d63f382006-07-11 17:52:53 +0000248 (nsm_notice_state_changes) Move state change logging code to new
249 func to declutter nsm_change_state and ospf_nsm_event.
250 Log event with AdjChange, it's useful to know.
251 (nsm_change_state) move adjchange and snmp logging to previous.
252 (ospf_nsm_event) call nsm_notice_state_changes from here.
253 Move the debug message to entry of function, so it gets out
254 even if something goes wrong.
Paul Jakma90c33172006-07-11 17:57:25 +0000255 Record state change timestamp and event in nbr struct.
256 * ospf_neighbor.h: (struct ospf_neighbor) Add fields to record
257 timestamp of last NSM change and event.
258 * ospf_vty.c: (show_ip_ospf_neighbor_detail_sub) Print
259 last state change timestamp and event, if available.
Paul Jakma539e1522006-07-11 17:49:22 +0000260
Andrew J. Schorr13cd3dc2006-07-11 01:50:30 +00002612006-07-10 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
262
263 * ospf_packet.c: (ospf_hello) Improve NetworkMask mismatch warning
264 message to include interface name and conflicting prefix lengths.
265
Paul Jakma1f2c2742006-07-10 07:45:13 +00002662006-07-07 Paul Jakma <paul.jakma@sun.com>
267
268 * ospf_nsm.h: Add a NSM_Deleted neighbour state, to act as dummy
269 state indicating the neighbour is to be deleted.
270 * ospf_nsm.c: (general) Use the NSM_Deleted state to delete
271 neighbours, thus allowing code to be slightly more obvious
272 in its flow.
273 (nsm_timer_set) Add NSM_Deleted. Add another timer the code
274 missed.
275 (nsm_kill_nbr) No need for special case call to nsm_change_state
276 anymore.
277 Make the assert and error-handling for same case more readable
278 (Andrew Schorr)
279 Remove the call to ospf_nbr_delete, nsm_change_state can do
280 this generally now via NSM_Deleted.
281 (struct ... NSM) Add the dummy NSM_Deleted state, the 3 events
282 that can lead to nsm_kill_nbr all now transition the NBR to
283 NSM_Deleted and the general change_state function can be left
284 to do the work.
285 (ospf_nsm_event) Special casing of events and early-return can
286 be removed now.
287 On transition into Deleted, delete the nbr.
288 * ospf_dump.c: (ospf_nsm_state_msg) Add Deleted.
289
Paul Jakmaaa2737a2006-07-06 11:12:39 +00002902006-07-06 Paul Jakma <paul.jakma@sun.com>
291
292 * ospf_nsm.c: (ospf_nsm_event) LLDown event also results in nbr
293 being deleted, requires early-return too. Likely explains
294 some crash reports after interface events.
295
Paul Jakmaf7a76ab2006-07-04 13:57:49 +00002962006-07-04 Paul Jakma <paul.jakma@sun.com>
297
298 * ospf_nsm.c: (general) Various small cleanups from Andrew's
299 review of last set of patches.
300 (nsm_timer_set) Loading, Full and default can share
301 same code too.
302 (nsm_should_adj) Can just be one big OR.
303 (nsm_twoway_received) Collapse into return statement.
304
Paul Jakmad7b0fb62006-07-04 13:35:24 +00003052006-07-02 Paul Jakma <paul.jakma@sun.com>
306
307 * ospf_nsm.c: (nsm_should_adj) New function, just consolidate the
308 10.4 adjacency check from nsm_twoway_received/nsm_adj_ok.
309 (nsm_twoway_received/nsm_adj_ok) Use former.
Paul Jakmad1b1cd82006-07-04 13:50:44 +0000310 (nsm_clear_adj) clear adjacency related state for a
311 neighbour, needed for some state changes from > ExStart down
312 to ExStart or less, which need not go through nsm_reset_nbr.
313 (nsm_reset_nbr) move code to former. Should be static.
Paul Jakmaba0beb42006-07-04 13:44:19 +0000314 (ospf_nsm_event) Don't allow action functions to change
315 next_state if the NSM tables do not indicate next_state is
316 conditional, log warning if one tries - existing code
317 appears fine though.
Paul Jakmad1b1cd82006-07-04 13:50:44 +0000318 Remove long dead code.
319 Use nsm_clear_adj for state changes that take down
320 adjacencies to TwoWay/ExStart.
Paul Jakmae55dd532006-07-04 13:46:14 +0000321 (nsm_timer_set) ls_req timer should be OFF in early states.
322 Compact several identical sections.
323 Set inactivity timer to OFF for Down, for documentary
324 purposes.
Paul Jakmad1b1cd82006-07-04 13:50:44 +0000325 (nsm_kill_nbr) Oops, action function shouldn't try return
326 1 for error.
Paul Jakma5db95bc2006-07-04 13:52:29 +0000327 * ospf_lsa.c: (ospf_translated_nssa_refresh) CID #13.
Paul Jakmad7b0fb62006-07-04 13:35:24 +0000328
Andrew J. Schorr1c066bf2006-06-30 16:53:47 +00003292006-06-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
330
331 * ospf_vty.c: (show_ip_ospf_neighbor_id) Should show all instances
332 of that neighbor (since it may appear on multiple interfaces)
333 instead of bailing out after showing the first match.
334
Andrew J. Schorr76947872006-06-30 03:21:05 +00003352006-06-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
336
337 * ospf_nsm.c: (nsm_twoway_received) When deciding whether to
338 change from state Init to ExStart, the test for whether the
339 neighboring router is DR or BDR should be against the
340 local router's notion of DR/BDR, not the neighbor's view.
341
Andrew J. Schorrd7e60dd2006-06-29 20:20:52 +00003422006-06-28 Erik Muller <erikm@internap.com>
343
344 * ospfd.h: Define 2 new struct ospf config flags:
345 OSPF_LOG_ADJACENCY_CHANGES and OSPF_LOG_ADJACENCY_DETAIL
346 * ospf_nsm.c (nsm_change_state): Log adjacency changes if
347 requested.
348 * ospf_vty.c (ospf_log_adjacency_changes): New command function
349 to implement ospf subcommand "log-adjacency-changes [detail]".
350 (no_ospf_log_adjacency_changes) Turn off log-adjacency-changes.
351 (show_ip_ospf) Show whether adjacency changes are logged.
352 (ospf_config_write) Add "log-adjacency-changes [detail]" to config.
353 (ospf_vty_init) Add ospf_log_adjacency_changes and
354 no_ospf_log_adjacency_changes.
355
Paul Jakma9560fa82006-06-26 12:50:06 +00003562006-06-26 Paul Jakma <paul.jakma@sun.com>
357
358 * ospf_abr.c: (general) NSSA translate-candidate ABRs need to
359 be ASBRs, or other routers may rightfully refuse to install
360 translated type-5s LSAs. reported by dendroot@gmail.com.
361 (ospf_abr_nssa_check_status) Detect change in translator
362 state when ABR, and inc/dec redistribute count as when we
363 leave/enter the disabled state - so that translate-enabled
364 ABR properly sets ASBR bit on non-NSSA areas.
365 Run the resulting function through indent to clean it up.
366 * ospf_lsa.c: (router_lsa_flags) For purposes of ASBR bit,
367 NSSA area is same as stub area.
368
Andrew J. Schorr0ffb7092006-06-24 19:40:13 +00003692006-06-24 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
370
Andrew J. Schorr9aecfae2006-06-24 20:05:02 +0000371 * ospf_snmp.c: (ospfTrapNbrStateChange, ospfTrapIfStateChange) Improve
372 info log message to indicate why the trap is being sent.
373
3742006-06-24 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
375
Andrew J. Schorr0ffb7092006-06-24 19:40:13 +0000376 * ospf_dump.c: (config_write_debug) Fix typo to show debug ospf nsm
377 status properly (not ism status).
378
Andrew J. Schorr6e72cb62006-06-18 00:45:48 +00003792006-06-17 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
380
381 * ospf_vty.c: ({no_,}ospf_passive_interface) Replace if_lookup_by_name
382 with a call to if_get_by_name -- if the interface does not exist
383 already, it should be created. And remove the obsolete warning
384 message.
385
Paul Jakma429ac782006-06-15 18:40:49 +00003862006-06-15 Paul Jakma <paul.jakma@sun.com>
387
388 * ospf_interface.h: (struct ospf_if_info) Add reference counts
389 for multicast group memberships. Add various macros to help
390 manipulate/check membership state.
391 * ospf_interface.c: (ospf_if_set_multicast) Maintain the
392 ospf_if_info reference counts, and only actually drop
393 memberships if it hits 0, to avoid losing membership when
394 OSPF is disabled on an interface with multiple active OSPF
395 interfaces.
396 * ospf_packet.c: (ospf_{hello,read}) Use the new macros to
397 check/set
398 multicast membership.
399 * ospf_vty.c: (show_ip_ospf_interface_sub) ditto.
400
Paul Jakmaac904de2006-06-15 12:04:57 +00004012006-05-31 Paul Jakma <paul.jakma@sun.com>
402
403 * ospf_lsdb.c: (ospf_lsdb_delete) robustify against NULL arguments,
404 print warning.
405 * ospf_lsa.c: (ospf_discard_from_db) ditto.
406 (ospf_maxage_lsa_remover) Check lsa->lsdb for validity, possible
407 mitigation (but not solution) for bug #269.
408
Paul Jakma88871b12006-06-15 11:41:19 +00004092006-05-30 Paul Jakma <paul.jakma@sun.com>
410
411 * ospf_packet.c: (ospf_read) Debug message about packets
412 received on unenabled interfaces should be conditional on
413 debug being set.
414
Paul Jakmad1c65c22006-06-27 08:01:43 +00004152006-05-23 Paul Jakma <paul.jakma@sun.com>
416
417 * ospf_vty.c: (general) Replace in-place route redistribution
418 command and help strings with the new auto-generated defines
419 from lib/route_types.h
420
Paul Jakmaae128052006-05-12 23:15:30 +00004212006-05-13 Paul Jakma <paul.jakma@sun.com>
422
423 * ospf_lsa.c: (ospf_translated_nssa_refresh) fix the sanity
424 check to match the assert, small error in CID #13 fix.
425
Paul Jakma70461d72006-05-12 22:57:57 +00004262006-05-12 Paul Jakma <paul.jakma@sun.com>
427
428 * ospf_lsa.c: (ospf_lsa_action) Get rid of the ospf_lookup
429 call, which is not checked for NULL return, by stripping out
430 functionality which is never used, hence fixing Coverity CID
431 #29.
432 (struct lsa_action) remove unused member.
Paul Jakmae54e6e52006-05-12 23:11:14 +0000433 (ospf_translated_nssa_refresh) Add non-assert sanity check,
434 in case DEBUG isn't defined.
435 Debug message when no type7 exists should print the ID from
436 the type5, not the type7, fixes CID #13.
437 * ospf_interface.c: (ospf_if_exists) Fix missing NULL return
Paul Jakmae43be0e2006-05-12 23:00:06 +0000438 check on ospf_lookup, CID #27.
Paul Jakma6db3a6f2006-05-12 23:02:46 +0000439 * ospf_asbr.c: (ospf_redistribute_withdraw) remove ospf_lookup
440 call by taking the struct ospf * as argument, which the
441 caller has, fixing CID #28.
442 * ospf_asbr.h: (ospf_redistribute_withdraw) update declaration
443 * ospf_zebra.c: (ospf_redistribute_unset) update call to
444 ospf_redistribute_withdraw to match.
Paul Jakmabfd7c7d2006-05-12 23:04:45 +0000445 * ospf_ia.c: (ospf_update_router_route) ospf->backbone could be
446 NULL when passed to ospf_find_asbr_route_through_area,
447 check for NULL first, CID #14.
Paul Jakmadeb15612006-05-12 23:07:27 +0000448 * ospf_ism.c: (ism_change_state) NULL check on oi->area is
449 useless, it's always valid. Only possibility where it
450 couldn't be is if there is a race between abr_task and
451 cleaning up oi's, in which case a NULL check here isn't going
452 to do anything. Fixes CID #15.
Paul Jakma70461d72006-05-12 22:57:57 +0000453
Paul Jakmacac3b5c2006-05-11 13:31:11 +00004542006-05-11 Paul Jakma <paul.jakma@sun.com>
455
456 * ospf_vty.c: (general) Audit ospf_lookup calls in commands,
457 ensure check for NULL result, make vty messages consistent.
458 (show_ip_ospf_interface) Missing NULL check on ospf_lookup
459 result, fixes Coverity CID #70.
Paul Jakma1a8ec2b2006-05-11 13:34:08 +0000460 (no_ospf_area_filter_list) Check NULL result from
461 ospf_area_lookup_by_area_id, fixes Coverity CID #69
Paul Jakma894f8b62006-05-12 22:50:40 +0000462 * ospf_route.c: (ospf_route_delete_same_ext) Fix deref before
463 NULL check by moving into check-protected block, fix CID #49.
Paul Jakma214a4452006-05-12 22:51:49 +0000464 * ospf_abr.c: (ospf_area_range_cost_set) Shouldn't create a new
465 range, should just lookup to see if one exists, the new range
466 is just leaked. Fixes CID #46.
Paul Jakma4021b602006-05-12 22:55:41 +0000467 * ospf_lsa.c: (ospf_default_originate_timer) Let the thread
468 take (struct ospf *) as thread argument, rather than (struct
469 ospf *)->default_originate, thus avoiding having to call
470 ospf_lookup.
471 * ospf_zebra.c: (ospf_redistribute_default_set) change setup
472 of ospf_default_originate_timer thread to match.
473 * ospfd.c: (ospf_router_id_update) ditto.
Paul Jakmacac3b5c2006-05-11 13:31:11 +0000474
Paul Jakma9c27ef92006-05-04 07:32:57 +00004752006-04-24 Paul Jakma <paul.jakma@sun.com>
476
477 * (general) More Virtual-link fixes, again with much help in
478 testing / debug from Juergen Kammer. Primarily in SPF.
479 * ospf_spf.h: Add guard. ospf_interface.h will include this
480 header.
481 * ospf_interface.h: Modify ospf_vl_lookup definition to take
482 struct ospf as argument, so as to allow for NULL area
483 argument.
484 (struct ospf_vl_data) Remove out_oi, instead add a struct
485 vertex_nexthop, to use as initial nexthop for backbone paths
486 through a vlink.
487 * ospf_interface.c: (ospf_vl_lookup) Modified to allow
488 NULL area to be passed to indicate "any" (first) area.
489 Add extra debug.
490 (ospf_vl_set_params) vl_oi -> nexthop. Add extra debug.
491 (ospf_vl_up_check) Fix debug, inet_ntoa returns a static
492 buffer..
493 * ospf_route.c: (ospf_intra_add_router) Vlinks dont go through
494 backbone, don't bother checking.
495 * ospf_spf.c: (static struct list vertex_list) Record vertices
496 that will need to be freed.
497 (cmp) Order network before router vertices, as required,
498 wasn't implemented.
499 (vertex_nexthop_free) Mild additional robustness check.
500 (vertex_parent_free) Take void argument, as this function
501 is passed as list deconstructor for vertex parent list.
502 (ospf_vertex_new) More debug. Set deconstructor for parent
503 list. Track allocated vertices on the vertex_list.
504 (ospf_vertex_free) Get rid of the tricky recursive cleanup of
505 vertices. Now frees only the given vertex.
506 (ospf_vertex_add_parent) Fix assert.
507 (ospf_nexthop_calculation) Fix calculation of nexthop for
508 VLink vertices, lookup the vl_data and use its previously
509 recorded nexthop information.
510 (ospf_spf_calculate) Vertices are freed simply by deleting
511 vertex_list nodes and letting ospf_vertex_free as deconstructor
512 work per-node.
513 (ospf_spf_calculate_timer) Trivial optimisation, leave
514 backbone SPF calculation till last to reduce SPF churn on
515 VLink updates.
516 * ospf_vty.c: (ospf_find_vl_data) update call to ospf_vl_lookup
517 (no_ospf_area_vlink_cmd) ditto.
518 (show_ip_ospf_interface_sub) For Vlinks, the peer address is
519 more interesting than the output interface.
520
Paul Jakma478aab92006-04-03 21:25:32 +00005212006-04-03 Paul Jakma <paul.jakma@sun.com>
522
523 * (general) Fix issues with handling of Vlinks and entries
524 in the nbrs route-table which were highlighted by the
525 nsm/nbr_self fixes from bug #234. Many thanks to Juergen
526 Kammer for his help and efforts in testing out debug patches to
527 pinpoint the issue.
528 * ospf_interface.c: (ospf_vl_new) Add nbr_self for Vlink.
529 * ospf_neighbor.c: (ospf_nbr_key) new static function, helper
530 to create key in nbrs table for a given nbr.
531 (ospf_nbr_delete) Use ospf_nbr_key. Add an assert() to
532 document an expected state.
533 (ospf_nbr_add_self) Ditto.
534 (ospf_nbr_lookup_by_addr) Add an assert.
535 * ospf_nsm.c: (nsm_kill_nbr) Can never kill the nbr_self
536 psuedo-neighbour.
537
Paul Jakma075c2012006-03-30 14:34:31 +00005382006-03-27 Paul Jakma <paul.jakma@sun.com>
539
540 * ospf_lsa.c: (ospf_lsa_checksum) Add an explicit cast to avoid
541 the ambiguities of ANSI and C99 C with respect to type
542 conversion. Detailed problem report and test case with
543 example data supplied by Dmitry Ivanov <dimss@telecentrs.lv>.
544
Paul Jakma1a8ee0e2006-03-30 14:20:00 +00005452006-03-25 Paul Jakma <paul.jakma@sun.com>
546
547 * ospf_interface.c: (ospf_if_lookup_recv_if) Ignore loopbacks,
548 we can never ever receive packets on those. Should fix
549 case where CARP is run with address in same subnet as real
550 interface. Problem report and diagnosis thanks to:
551 Landon Fuller <landonf@opendarwin.org>.
552 However, ospf_read() still can't deal deterministically with
553 multiple interfaces in same subnet.
554
Paul Jakmac2b478d2006-03-30 14:16:11 +00005552006-03-23 Steve Lawson <steve.lawson@aheadcomusa.com>
556
557 * ospf_lsa.c: (ospf_lsa_install) Fix incorrect byte-order
558 conversion of OSPF_MAX_SEQUENCE_NUMBER
559
paule8e19462006-01-19 20:16:55 +00005602006-01-19 Paul Jakma <paul.jakma@sun.com>
561
562 * (general) various miscellaneous compiler warning fixes.
563 Remove redundant break statements from switch clauses
564 which return.
565 return from main, not exit, cause it annoys SOS.
566 Remove stray semi-colons which cause empty-statement
567 warnings.
568
paul779adb02006-01-18 15:07:38 +00005692006-01-18 Juergen Kammer <j.kammer@eurodata.de>
570
571 * ospf_lsa.c: (ospf_router_lsa_new) dont take reference to the
572 stream data until it is constructed, data reference is
573 volatile due to the potential resize in link_info_set
574
5752006-01-18 Paul Jakma <paul.jakma@sun.com>
576
577 * ospf_lsa.c: (link_info_set) Resize the stream if required and
578 possible. Return number of links added.
579 (lsa_link_*_set) use return value from previous.
580 * ospf_lsa.h: Add OSPF_ROUTER_LSA_LINK_SIZE define.
581
paulc6371712006-01-17 17:49:53 +00005822006-01-17 Paul Jakma <paul.jakma@sun.com>
583
584 * ospf_packet.c: (ospf_verify_header) print out the types
585 involved if there's a mismatch.
586 * ospf_zebra.c: (ospf_zebra_add) Adjust to new zserv format.
587
paul818e56c2006-01-10 23:27:05 +00005882006-01-10 Len Sorensen <lennartsorensen@ruggedcom.com>
589
590 * (general) Bug #234, see also [quagga-dev 3902].
591 Fix problem with nbr_self not being properly reinitialised
592 when an interface comes up, after having been down.
paul1a643f82006-01-11 01:08:19 +0000593 Some re-arrangement done by Paul Jakma, any bugs introduced
594 on top of Len's suggested changes are his.
paul818e56c2006-01-10 23:27:05 +0000595 * ospf_neighbor.c: (ospf_nbr_add_self) centralise
596 initialisation of nbr_self parameters here.
597 * ospf_interface.c: (ospf_if_new) deleting initialisation of
598 parameters of nbr_self, just rely on call to
599 ospf_nbr_add_self.
600 (ospf_if_cleanup) ditto.
601 * ospfd.c: (ospf_network_run) ditto.
602
paul98429f62006-01-10 22:11:54 +00006032006-01-10 Juris Kalnins <juris@mt.lv>
604
605 * ospf_zebra.c: (ospf_interface_address_delete) fix rare leak of
606 struct connected in an error case.
paul818e56c2006-01-10 23:27:05 +0000607 * ospf_packet.c: (ospf_make_md5_digest) fix odd, if not
608 undefined effect, assignment of an increment expression.
paul98429f62006-01-10 22:11:54 +0000609
paul86752842006-01-10 20:34:46 +00006102006-01-10 Paul Jakma <paul.jakma@sun.com>
611
612 * ospfd.c: (ospf_network_run) checking to see if router-id
613 is set should be on ospf->router_id, not router_id_static.
614 This was causing ospfd to not start if router-id had not
615 been configured statically.
616 (ospf_if_update) ditto.
paulc42c1772006-01-10 20:36:49 +0000617 * ospf_vty.c: (config_write_ospf_distribute) trim down
618 redundant strings.
paul86752842006-01-10 20:34:46 +0000619
paul00c290e2005-11-26 09:21:43 +00006202005-11-26 Paul Jakma <paul.jakma@sun.com>
621
622 * ospf_api.c: (struct opaque_lsa) change from gcc zero-length
623 array to C99 incomplete type array.
paulc9c93d52005-11-26 13:31:11 +0000624 * (general) s/graceful/deferred/ in all files, the former term
625 is confusing wrt OSPF Graceful-Restart.
626 * ospfd.c: (ospf_deferred_shutdown_check) dont return
627 a function which returns void. SOS complains about this.
628 (ospf_finish)
paul00c290e2005-11-26 09:21:43 +0000629
paulb29800a2005-11-20 14:50:45 +00006302005-11-20 Paul Jakma <paul.jakma@sun.com>
631
632 * ospfd.h: remove the OSPF_ROUTER_ID_UPDATE_DELAY define
633 (struct ospf) remove the router_id timer thread.
634 remove export of ospf_router_id_update_timer.
635 * ospfd.c: (ospf_router_id_update) call ospf_if_update to
636 poke interfaces into action after ID has been configured.
637 (ospf_router_id_update_timer) removed.
638 (ospf_finish_final) t_router_id_update timer is gone.
639 (ospf_network_run) router-id update timer gone.
640 call ospf_router_id_update directly if ID not configured.
641 In the per-iface loop, don't ospf_if_up interfaces if
642 ID is still not configured. The update function will call
643 ospf_if_update anyway.
644 (ospf_if_update) ID update timer is gone. Just return if no
645 ID is set.
646 * ospf_vty.c: (ospf_router_id) call ospf_router_id_update, no
647 timer needed.
648 * ospf_zebra.c: (ospf_router_id_update_zebra) call
649 ospf_router_id_update directly, not via timer.
paulc24d6022005-11-20 14:54:12 +0000650 * ospf_abr.c: (ospf_abr_announce_network_to_area) check
651 returned LSA of ospf_summary_lsa_refresh and print warning if
652 it failed.
653 (ospf_abr_announce_network_to_area) similar
654 (ospf_abr_announce_rtr_to_area) similar
655 * ospf_lsa.c: (ospf_router_lsa_new) check LSA returned is valid.
656 (ospf_router_lsa_originate) similar
657 (ospf_router_lsa_refresh, ospf_network_lsa_new) similar
658 (ospf_summary_lsa_new) Check ID is valid.
659 (ospf_summary_lsa_originate) ditto, and check returned LSA from
660 previous function is !NULL.
661 (ospf_summary_lsa_refresh) check ospf_summary_lsa_new return
662 is !NULL.
663 (ospf_summary_asbr_lsa_new) ID valid check.
664 (ospf_summary_asbr_lsa_originate) similar.
paulb29800a2005-11-20 14:50:45 +0000665
ajs70cd3472005-11-16 19:33:22 +00006662005-11-16 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
667
ajs649654a2005-11-16 20:17:52 +0000668 * ospf_dump.h: Define OSPF_TIME_DUMP_SIZE as appropriate buffer size
669 for use with ospf_timer_dump and ospf_timeval_dump.
670 * ospf_vty.c: Change all buffer sizes used with ospf_timer_dump and
671 ospf_timeval_dump to have size OSPF_TIME_DUMP_SIZE.
672 (show_ip_ospf_interface_sub) Fix possible buffer overflow in
673 call to ospf_timer_dump.
674
6752005-11-16 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
676
ajs70cd3472005-11-16 19:33:22 +0000677 * ospf_ism.h: (OSPF_ISM_TIMER_OFF) Improve macro syntax by enclosing
678 in 'do {...} while(0)'.
679
paul31a59762005-11-14 11:11:11 +00006802005-11-14 Paul Jakma <paul.jakma@sun.com>
681
682 * ospfd.c: (ospf_new) stub-shutdown should just default to
683 unconfigured, too strange otherwise.
684 (ospf_finish_final) t_opaque_lsa_self TIMER_OFF should be
685 preprocessor conditional on HAVE_OPAQUE_LSA.
686 * ospfd.h: (struct ospf) remove the SHUTDOWN_DEFAULT define.
687 no longer used, plus it wasn't in range that the command
688 accepted.
689 * ospf_zebra.h: Depends on vty.h, include it.
690
paul58e1bef2005-11-11 12:10:03 +00006912005-11-11 Paul Jakma <paul.jakma@sun.com>
692
693 * ospf_spf.c: (ospf_canonical_nexthops_free) Free only
694 the nexthops pointing to the root vertex. We may visit a
695 vertex twice or the vertex may have some inherited nexthops,
696 if we free other nexthops we could crash.
697
paulc8c15212005-11-04 12:31:39 +00006982005-11-04 Paul Jakma <paul.jakma@sun.com>
699
700 * ospf_{dump,spf,vty}.c: Oops, use the internal tv_sub
701 function rather than unportable timersub.
702
paul484315f2005-11-03 09:08:29 +00007032005-11-03 Paul Jakma <paul.jakma@sun.com>
704
705 * ospf_apiserver.c: (apiserver_sync_callback) stray semi-colon
706 * ospf_packet.c: include checksum.h, remove the in_cksum extern
707 * prototypes.
708 * ospf_te.h: Add braces, quell warning.
paul6d452762005-11-03 11:15:44 +0000709 * ospf_packet.c: Change level of some warnings to
710 informational.
paulc8c15212005-11-04 12:31:39 +0000711
paul88d6cf32005-10-29 12:50:09 +00007122005-10-29 Paul Jakma <paul.jakma@sun.com>
713
714 * (general) RFC3137 stub-router support
715 * ospfd.h: Add OSPF_OUTPUT_COST_INFINITE define.
716 (struct ospf_master) Add a OSPF_MASTER_SHUTDOWN flag for
717 options, to allow shutdown to distinguish between complete
718 shutdown and shutdown of a subset of ospf instances.
719 (struct ospf)
720 Add stub_router_{startup,shutdown_}time, configuration of startup
721 and shutdown time for stub-router.
722 Add t_graceful_shutdown struct thread, timer for graceful
723 shutdown, if needed.
724 (struct ospf_area) Add stub_router_state - run time state of
725 stub-router for an area. Add flags for ADMIN, IS and WAS
726 states.
727 Add t_stub_router, timer thread to resend router-lsa for an
728 area.
729 * ospf_lsa.c: (ospf_link_cost) new simple function to spit out
730 either the given lnks cost or infinite cost if stub-router is
731 in effect.
732 (lsa_link_{ptop,broadcast,virtuallink,ptomp}_set) use
733 previous function for transit-links.
734 (ospf_stub_router_timer) timer thread for end of startup stub
735 router. Change state as required for the area and setup
736 re-origination of router-lsa.
737 (ospf_stub_router_check) Check/do whether stub-router should be
738 enabled, and whether it requires timer to be setup.
739 (ospf_router_lsa_new) call previous function at top.
740 (ospf_router_lsa_originate) no external callers, made static.
741 * ospf_lsa.h: (ospf_router_lsa_originate) removed.
742 * ospf_main.c: (sigint) make static.
743 remove call to exit, as ospf_terminate now deals with
744 exiting.
745 * ospf_route.c: (ospf_terminate) removed, now in ospfd.c.
746 * ospf_vty.c: (show_ip_ospf_area) print out state of
747 stub-router, if active.
748 (show_ip_ospf) print out configuration of stub-router
749 support, and details of graceful-shutdown if the timer is
750 active.
751 ((no)?ospf_max_metric_router_lsa_{admin,startup,shutdown}) new
752 commands to (de-)?configure stub-router support.
753 (config_write_stub_router) write out config of stub-router.
754 (ospf_config_write) call previous.
755 (ospf_vty_init) install the new stub-router commands.
756 * ospfd.c: various functions made static.
757 (ospf_new) Set defaults for stub-router. Graceful shutdown
758 is made to default on, just to be adventerous.
759 (ospf_graceful_shutdown_finish) new function, final part of
760 shutdown.
761 (ospf_graceful_shutdown_timer) timer thread wrapper for
762 graceful-shutdown.
763 (ospf_graceful_shutdown_check) check whether to setup timer
764 for shutdown or proceed directly to final shutdown.
765 (ospf_terminate) moved here from ospf_route.c, call
766 ospf_finish for each instance.
767 (ospf_finish) renamed to ospf_finish_final and made static.
768 (ospf_finish) new function, exported wrapper around
769 ospf_graceful_shutdown_check.
770 (ospf_finish_final) complete shutdown of an instance.
771 Add missing TIMER_OFF's of two timer threads.
772 (ospf_area_free) opaque self lsa timer should be turned off.
773
paulb8ad39d2005-10-23 15:23:05 +00007742005-10-23 Paul Jakma <paul.jakma@sun.com>
775
paule029d442005-10-23 15:26:24 +0000776 * ospf_apiserver.c: (ospf_apiserver_term) This function should
777 not have side-effects (eg segv) if no apiserver instances are
778 active, ie be robust.
paulb8ad39d2005-10-23 15:23:05 +0000779 * ospf_vty.c: (show_ip_ospf) fix display of SPF timer if it
780 has not yet been run.
781
paulf9ad9372005-10-21 00:45:17 +00007822005-10-21 Paul Jakma <paul.jakma@sun.com>
783
paulea4ffc92005-10-21 20:04:41 +0000784 * ospf_dump.c: (ospf_timeval_dump) fix ms adjustment, thanks to
785 Andrew Schorr.
786 * ospf_vty.c: (ospf_config_write) fix write out of spf timers
787 configuration.
788
7892005-10-21 Paul Jakma <paul.jakma@sun.com>
790
pauld24f6e22005-10-21 09:23:12 +0000791 * (general) SPF millisecond resolution timer with adaptive,
792 linear back-off holdtime. Prettification of ospf_timer_dump.
793 * ospf_dump.c: (ospf_timeval_dump) new function. The guts of
794 ospf_timer_dump, but made to be more dynamic in printing out
795 the relative timeval, sliding the precision printed out
796 according to the value.
797 (ospf_timer_dump) guts moved to ospf_timeval_dump.
798 * ospf_dump.h: export ospf_timeval_dump.
799 * ospf_flood.c: (ospf_flood) remove gettimeofday, use
800 the libzebra exported recent_time instead, as it's not
801 terribly critical to have time exactly right - the dropped
802 LSA will be retransmited to us if we don't ACK it.
803 * ospf_packet.c: (ospf_ls_upd_timer) Ditto, but here we're
804 not transmitting, just putting LSA back on update transmit list.
805 * ospfd.h: delay and holdtimes should be unsigned.
806 Add spf_max_holdtime and spf_hold_multiplier.
807 Update default defines for delay and hold time to be in msec.
808 (struct ospf) change the SPF timestamp to a struct timeval.
809 Remove ospf_timers_spf_(un)?set.
810 * ospfd.c: (ospf_timers_spf_{set,unset}) removed.
811 (ospf_new) initialise spf_max_holdtime and spf_hold_multiplier
812 * ospf_spf.c: (ospf_spf_calculate) SPF timestamp is a timeval
813 now, update with gettimeofday.
814 (ospf_spf_calculate_schedule) Change SPF timers to millisecond
815 resolution.
816 Make the holdtime be adaptive, with a linear increase in
817 holdtime ever consecutive SPF run which occurs within holdtime
818 of previous SPF, bounded by spf_max_holdtime.
819 * ospf_vty.c: Update spf timers commands.
820 (ospf_timers_spf_set) trivial helper.
821 (ospf_timers_throttle_spf_cmd) new command to set SPF delay,
822 initial hold and max hold times with millisecond resolution.
823 (ospf_timers_spf_cmd) Deprecated. Accept the old values,
824 convert to msec, truncate to new limits.
825 (no_ospf_timers_throttle_spf_cmd) set timers to defaults.
826 (no_ospf_timers_spf_cmd) deprecated form, same as previous.
827 (show_ip_ospf_cmd) Display SPF parameters and times.
828 (show_ip_ospf_neighbour_header) Centralise the 'sh ip os ne'
829 header.
830 (show_ip_ospf_neighbor_sub) Fix the field widths. Get rid of
831 the multiple spaces which were making the lines even longer.
832 (show_ip_ospf_neighbor_cmd) Use show_ip_ospf_neighbour_header
833 (show_ip_ospf_neighbor_all_cmd) ditto and fix the field
834 widths for NBMA neighbours.
835 (show_ip_ospf_neighbor_int) Use header function.
836 (show_ip_ospf_nbr_nbma_detail_sub) use sizeof for timebuf,
837 local array - safer.
838 (show_ip_ospf_neighbor_detail_sub) ditto
839 (ospf_vty_init) install the new SPF throttle timer commands.
840
8412005-10-21 Paul Jakma <paul.jakma@sun.com>
842
paulf9ad9372005-10-21 00:45:17 +0000843 * (general) OSPF fast, sub-second hello and 1s dead-interval
844 support.
845 * ospf_dump.c: (ospf_timer_dump) Print out milliseconds too.
846 Callers typically specify a length of 9, so most see
847 millisecs unless they specify the additional length.
848 * ospf_interface.h: (struct ospf_interface) new interface param,
849 fast_hello.
850 * ospf_interface.c: (ospf_if_table_lookup) add brackets,
851 gcc warning fix.
852 (ospf_new_if_params) Initialise fast_hello param.
853 (ospf_free_if_params) Check whether fast_hello is configured.
854 (ospf_if_new_hook) set fast_hello to default.
855 * ospf_ism.h: Wrap OSPF_ISM_TIMER_ON inside do {} while (0) to
856 prevent funny side-effects from its if statement when this
857 macro is used conditionally by other macros.
858 (OSPF_ISM_TIMER_MSEC_ON) new macro, set in milliseconds.
859 (OSPF_HELLO_TIMER_ON) new macro to set hello timer according
860 to whether fast_hello is set.
861 * ospf_ism.c: Update all setting of the hello timer to use
862 either OSPF_ISM_TIMER_MSEC_ON or OSPF_HELLO_TIMER_ON. The
863 former is used when hello is to be sent immediately.
864 * ospf_nsm.c: ditto
865 * ospf_packet.c: (ospf_hello) hello-interval is not checked
866 for mismatch if fast_hello is set.
867 (ospf_read) Annoying nit, fix "no ospf_interface" to be debug
868 rather than a warning, as it can be perfectly normal to
869 receive packets when logical subnets are used.
870 (ospf_make_hello) Set hello-interval to 0 if fast-hellos are
871 configured.
872 * ospf_vty.c: (ospf_auto_cost_reference_bandwidth) annoying
873 nit, don't vty_out if this command is given, it gets tired
874 quick.
875 (show_ip_ospf_interface_sub) Print the hello-interval
876 according to whether fast-hello is set or not.
877 Print the extra 5 millisec characters from (ospf_timer_dump)
878 if fast-hello is configured.
879 (ospf_vty_dead_interval_set) new function, common to all
880 forms of dead-interval command, to set dead-interval and
881 fast-hello correctly. If a dead-interval is given, unset
882 fast-hello, else if a hello-multiplier is set, set
883 dead-interval to 1 and fast-hello to given multiplier.
884 (ip_ospf_dead_interval_addr_cmd) use
885 ospf_vty_dead_interval_set().
886 (ip_ospf_dead_interval_minimal_addr_cmd) ditto.
887 (no_ip_ospf_dead_interval) Unset fast-hello.
888 (no_ip_ospf_hello_interval) Bug-fix, unset of hello-interval
889 should set it to OSPF_HELLO_INTERVAL_DEFAULT, not
890 OSPF_ROUTER_DEAD_INTERVAL_DEFAULT.
891 (config_write_interface) Write out fast-hello.
892 (ospf_config_write) Write a comment about
893 "auto-cost reference-bandwidth" having to be equal on all
894 routers. Hopefully just as noticeable as old practice of
895 writing to vty, but less annoying.
896 (ospf_vty_if_init) install the two new dead-interval
897 commands.
898 * ospfd.h: Add defines for OSPF_ROUTER_DEAD_INTERVAL_MINIMAL
899 and OSPF_FAST_HELLO_DEFAULT.
900
pauleb3da6d2005-10-18 04:20:33 +00009012005-10-18 Paul Jakma <paul.jakma@sun.com>
902
903 * (general) SPF memory management cleanup and fix for rare
904 double-free bug.
905 * ospf_spf.h: (struct vertex_parent) New struct to hold parent
906 specific data, eg the backlink and the parent vertex pointer,
907 and point to the appropriate general struct vertex_nexthop.
908 (struct vertex_nexthop) remove parent vertex pointer, so
909 this struct can be shared across vertices.
910 (struct vertex) rename list child to list children. Remove
911 list of nexthops, replace with list of vertex_parents.
912 * ospf_spf.c: (update_stat) trivial, remove cast from void *.
913 (vertex_nexthop_new) remove init of parent - field is gone
914 from struct vertex_nexthop.
915 (ospf_canonical_nexthops_free) Remove the canonical
916 vertex_nexthop memory objects. These are the vertex_nexthops
917 attached to the first level of router vertices from the root.
918 (vertex_parent_new) new function, create a vertex_parent.
919 (vertex_parent_free) ditto, but free it.
920 (ospf_vertex_new) Update to match changes to struct vertex.
921 (ospf_vertex_free) Recursively free a struct vertex and its
922 children. The parent list is used as a reference count.
923 vertex_nexthops must be free seperately, if required.
924 (ospf_vertex_dump) update to match struct vertex changes.
925 Print out backlink of parents too.
926 (ospf_vertex_add_parent) ditto.
927 (ospf_lsa_has_link) update comment.
928 (ospf_nexthop_add_unique) removed, not needed anymore.
929 (ospf_nexthop_merge) ditto.
930 (ospf_spf_consider_nexthop) renamed to ospf_spf_add_parent.
931 Simplified to just create vertex_parent and add it.
932 (ospf_spf_flush_parents) new function, flush out the parent
933 list.
934 (ospf_nexthop_calculation) Take the relevant route_lsa_link
935 as an argument, which simplifies things and removes the need
936 for the hack in ospf_nexthop_add_unique - ospf_spf_next
937 already knew exactly which link the cost calculated was for.
938 Update to match struct vertex changes too.
939 (ospf_spf_next) Don't create a vertex for W unnecessarily, if
940 it's there's a vertex already created for W, use it, and
941 hence there's no need to free it either.
942 Update some manipulation/comparisons of distance to match.
943 Flush the parent list if a lower cost path is found.
944 (ospf_spf_route_free) unused, removed.
945 (ospf_spf_dump) match the struct vertex changes, and dump the
946 ifname if possible.
947 (ospf_spf_calculate) At end of SPF, free the canonical nexthops
948 and call ospf_vertex_free on the root vertex to free the
949 entire tree.
950 * ospf_interface.c: (ospf_vl_set_params) match struct vertex
951 changes.
952 * ospf_route.c: (ospf_intra_route_add) ditto
953 (ospf_route_copy_nexthops_from_vertex) ditto
954
paul36238142005-10-11 04:12:54 +00009552005-10-11 Paul Jakma <paul.jakma@sun.com>
956
957 * ospf_api.c: sign warnings.
958 * ospf_apiserver.c: sign warning and convert all the struct
959 in_addr initialisations so as not to make assumptions about
960 how this struct is organised, initialise the s_addr member
961 explicitely.
962 * ospf_packet.c: Add const qualifier to auth_key.
963
vincent77df1f72005-10-06 07:46:22 +00009642005-10-06 Alain Ritoux <alain.ritoux@6wind.com>
965
966 * ospf_snmp.c: Avoid mixing interface and ospf_interface objects
967 which now allows snmpwalk to work with ospfIfTable and
968 also with ospfIfMetricTable
969
ajsf52d13c2005-10-01 17:38:06 +00009702005-10-01 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
971
972 * ospf_dump.c: Remove local hard-coded table ospf_redistributed_proto.
973 (ospf_redist_string) New function implemented using new library
974 function zebra_route_string(). Note that there are a few differences
975 in the output that will result: the new function returns strings
976 that are lower-case, whereas the old table was mixed case. Also,
977 the old table mapped ZEBRA_ROUTE_OSPF6 to "OSPFv3", whereas the
978 new function returns "ospf6".
979 * ospfd.h: Remove extern struct message ospf_redistributed_proto[],
980 and add extern const char *ospf_redist_string(u_int route_type)
981 instead.
982 * ospf_asbr.c: (ospf_external_info_add) In two messages, use
983 ospf_redist_string instead of LOOKUP(ospf_redistributed_proto).
984 * ospf_vty.c: Remove local hard-coded table distribute_str.
985 (config_write_ospf_redistribute,config_write_ospf_distribute): Use
986 new library function zebra_route_string() instead of distribute_str[].
987 * ospf_zebra.c: (ospf_redistribute_set,ospf_redistribute_unset,
988 ospf_redistribute_default_set,ospf_redistribute_check)
989 In debug messages, use ospf_redist_string() instead of
990 LOOKUP(ospf_redistributed_proto).
991
jardin6638c1a2005-10-01 00:08:54 +00009922005-09-30 Vincent Jardin <vincent.jardin@6wind.com>
993
994 * ospf_dump.c, ospf_ia.c, ospf_spf.c, ospf_ase.c:
995 remove unused DEBUG
996
vincentba682532005-09-29 13:52:57 +00009972005-09-29 Alain Ritoux <alain.ritoux@6wind.com>
998
vincent5e4914c2005-09-29 16:34:30 +0000999 * ospf_ism.c: generate SNMP traps on Interface state change
1000 * ospf_nsm.c: generate SNMP traps on Neighbour state change
1001 * ospf_snmp.[ch]: support for SNMP traps for interface and neighbours.
1002
10032005-09-29 Alain Ritoux <alain.ritoux@6wind.com>
1004
vincentba682532005-09-29 13:52:57 +00001005 * ospf_vty.c: forece default route LSA to be re_issued whenever
1006 cost is changed ( [no] ip ospf area XXX default-cost YYY)
1007 Support ignore-mtu option
1008 * ospfd.h: define OSPF_MTU_IGNORE_DEFAULT
1009 * ospf_packet.c: support ignore-mtu option
1010 * ospf_interface.h: field added for skipping MTU check
1011 * ospf_interface.c: fix memory leak in ospf_crypt_key_delete()
1012 Set mtu_ignore field to default value
1013 * ospf_abr.[ch]: export ospf_abr_announce_network_to_area()
1014 * ospf_ism.h: add MACRO to convert internal ISM status into SNMP
1015 correct values
1016 * ospf_snmp.c: add sanity check on LSA type in lsdb_lookup_next()
1017 convert OSPFIFSTATE internal status into SNMP values
1018
vincentc1a03d42005-09-28 15:47:44 +000010192005-09-28 Alain Ritoux <alain.ritoux@6wind.com>
1020
1021 * ospf_packet.c: use new md5 API
1022
ajs5339cfd2005-09-19 13:28:05 +000010232005-09-19 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1024
1025 * ospf_lsa.h: (ospf_external_lsa_flush) Comment out the 5th argument
1026 (nexthop) since it is not used in the function (except inside
1027 some commented-out code).
1028 * ospf_lsa.c: (ospf_external_lsa_flush,ospf_external_lsa_refresh)
1029 Comment out the 5th argument to ospf_external_lsa_flush.
1030 * ospf_asbr.c: (ospf_redistribute_withdraw) Comment out 5th arg
1031 to ospf_external_lsa_flush.
1032 * ospf_vty.c: (no_ospf_default_information_originate) Eliminate 5th
1033 uninitialized nexthop arg to ospf_external_lsa_flush.
1034 * ospf_zebra.c: (ospf_zebra_read_ipv4) Comment out 5th arg
1035 to ospf_external_lsa_flush.
1036 * ospfd.c: (ospf_network_set) Comment out 5th arg
1037 to ospf_external_lsa_flush.
1038
ajse6a0bf92005-09-17 18:53:38 +000010392005-09-17 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1040
1041 * ospf_opaque.c:
1042 (ospf_opaque_lsa_refresh_schedule,ospf_opaque_lsa_flush_schedule)
1043 No need to call ospf_lookup(), just use lsa0->area->ospf instead.
1044
hassobb5b7552005-08-21 20:01:15 +000010452005-08-21 Hasso Tepper <hasso at quagga.net>
1046
1047 * ospf_vty.c: Make "show ip ospf neighbor xxx" commands work.
1048 Interface should be specified by name now.
1049
hasso54bedb52005-08-17 13:31:47 +000010502005-08-17 Hasso Tepper <hasso at quagga.net>
1051
1052 * ospf_vty.c: Check carefully if interface exists before trying to
1053 print info about it.
1054
hasso01018ce2005-08-05 07:40:15 +000010552005-08-05 Hasso Tepper <hasso at quagga.net>
1056
1057 * ospf_zebra.c: Don't assert/stop before type == ZEBRA_ROUTE_MAX if
1058 dealing with routemaps. There is ospf->route_map[ZEBRA_ROUTE_MAX]
1059 for default-information.
1060
paulc8987752005-07-26 06:07:22 +000010612005-07-26 Paul Jakma <paul.jakma@sun.com>
1062
1063 * ospf_abr.c: (ospf_abr_announce_network_to_area) SET_FLAG
1064 should be on lsa not old, which may be freed for one thing,
1065 obviously.
1066
pauld57834f2005-07-12 20:04:22 +000010672005-07-12 Paul Jakma <paul.jakma@sun.com>
1068
1069 * ospfd.h: add OSPF_ABR_DEFAULT for convenience, make
1070 OSPF_ABR_CISCO be the default ABR type.
1071 * ospfd.c: (ospf_new) initialise abr_type to OSPF_ABR_DEFAULT
1072 * ospf_vty.c: (no_ospf_abr_type_cmd) add standard as a negatable
1073 abr_type. default abr_type should be OSPF_ABR_DEFAULT.
1074 (ospf_config_write) test whether default abr_type against
1075 OSPF_ABR_DEFAULT, rather than any specific ABR_TYPE.
1076
hasso8469bd72005-06-20 20:50:10 +000010772005-06-20 Hasso Tepper <hasso at quagga.net>
hassof4833e92005-06-20 20:42:26 +00001078
1079 * ospf_nsm.c: Make database exchange for NSSA database work.
1080
paul7461d452005-06-13 13:57:16 +000010812005-06-13 Paul Jakma <paul.jakma@sun.com>
1082
1083 * ospf_spf.c: Try get more information on a SEGV under
1084 ospf_spf_vertex_add_parent.
1085 (ospf_vertex_free) NULL out the child and nexthop lists
1086 (ospf_vertex_add_parent) nexthop and child can not be NULL
1087 vertex_nexthop's parent->child list can not be NULL
1088 (ospf_spf_next) w and cw are per-loop iteration variables, move
1089 declarations into loop body.
1090
hasso1ddd7292005-06-07 19:54:04 +000010912005-06-07 Hasso Tepper <hasso at quagga.net>
1092
1093 * ospf_apiserver.c: Fix obvious error in notifying clients about ISM
1094 changes - oi->ifp->status doesn't give to us info about ISM,
1095 oi->state does.
1096
paul7e440862005-06-01 11:20:51 +000010972005-06-01 Akihiro Mizutani <mizutani@net-chef.net>
1098
1099 * ospf_ism.c (ospf_elect_bdr/ospf_elect_dr): Fix DR election bug.
1100
paul500e4182005-05-26 17:11:13 +000011012005-05-26 Paul Jakma <paul.jakma@sun.com>
1102
1103 * ospf_abr.c: (ospf_abr_update_aggregate) Fix comment, cost bug itself
1104 had been fixed long ago by Sowmini.
1105
paula3387a42005-05-18 23:29:57 +000011062005-05-19 Paul Jakma <paul.jakma@sun.com>
1107
1108 * ospf_interface.c: (ospf_if_table_lookup) Fix a serious bug
1109 a less serious one.
1110 1: this function is supposed to lookup
1111 entries in the oifs ospf_interface route_table and return either
1112 an existing oi or NULL to indicate not found, its caller depends
1113 on this, yet this function uses route_node_get which /always/
1114 returns a route_node - one is created if none exists. Use
1115 route_node_lookup instead. This should fix root cause of the
1116 reports of the (ospf_add_to_if) assert being hit.
1117 2: oi's are inserted into this table with prefixlength set to
1118 /32 (indeed, it should be a hash table, not a route_table),
1119 however prefixlength to lookup was not changed, if no valid entry
1120 can be inserted other than /32, then nothng but /32 should be
1121 looked up. This possibly only worked by fluke..
1122 Fix confirmed by 2 reporters (one list, one IRC), definitely a
1123 backport candidate once it has been incubated in HEAD for a while.
1124 Thanks to Patrick Friedel and Ivan Warren for testing.
1125
paul69310a62005-05-11 18:09:59 +000011262005-05-11 Paul Jakma <paul.jakma@sun.com>
1127
1128 * (general) Fix memory leaks in opaque AS-scope LSAs, reported and
1129 with much debugging done by by scott collins <scollins@agile.tv>.
1130 * ospf_lsa.c: (ospf_discard_from_db) dont call
1131 ospf_ase_unregister_external_lsa for opaque-lsa's, opaques are
1132 never registered with ase in the first place.
1133 * ospf_packet.c: (general) Disabuse opaque related code of its
1134 tendency to try gather up things into temporary lists.
1135 (ospf_ls_upd) remove the temporary lists opaque uses, call
1136 opaque functions inline, just like all other types.
1137 (ospf_ls_ack) ditto.
1138 (ospf_recv_packet) fixup sign warning.
1139 * ospf_opaque.c: (general) fix the unneeded use of lists, and
1140 untwist some of the logic.
1141 (ospf_opaque_self_originated_lsa_received) take a single LSA
1142 as argument, not a list of them. Remove the list loop. Logic
1143 otherwise unchanged.
1144 (ospf_opaque_ls_ack_received) Mostly ditto. But untwist the logic,
1145 move the actions up into the switch block, remove the goto's and
1146 sanitise the logic near the end a bit.
1147 * ospf_opaque.h: Adjust definitions of aforementioned functions
1148 in ospf_opaque.c to match.
1149
paul42c98192005-05-07 02:22:51 +000011502005-05-07 Yar Tikhiy <yar@comp.chem.msu.su>
1151
1152 * ospf_network.c: Log ifindex on multicast membership leave/join
1153 events.
1154
paul4dadc292005-05-06 21:37:42 +000011552005-05-06 Paul Jakma <paul.jakma@sun.com>
1156
1157 * (general) extern and static qualifiers added.
1158 unspecified arguments in definitions fixed, typically they should
1159 be 'void'.
1160 function casts added for callbacks.
1161 Guards added to headers which lacked them.
1162 Proper headers included rather than relying on incomplete
1163 definitions.
1164 gcc noreturn function attribute where appropriate.
1165 * ospf_opaque.c: remove the private definition of ospf_lsa's
1166 ospf_lsa_refresh_delay.
1167 * ospf_lsa.h: export ospf_lsa_refresh_delay
1168 * ospf_packet.c: (ospf_make_md5_digest) make *auth_key const,
1169 correct thing to do - removes need for the casts later.
1170 * ospf_vty.c: Use vty.h's VTY_GET_INTEGER rather than ospf_vty's
1171 home-brewed versions, shuts up several warnings.
1172 * ospf_vty.h: remove VTY_GET_UINT32. VTY_GET_IPV4_ADDRESS and
1173 VTY_GET_IPV4_PREFIX moved to lib/vty.h.
1174 * ospf_zebra.c: (ospf_distribute_list_update_timer) hacky
1175 overloading of the THREAD_ARG pointer should at least use
1176 uintptr_t.
1177
paul9e67dc22005-04-15 12:10:17 +000011782005-04-15 Zhipeng Gong <zpgong@cdc.3upsystems.com>
1179
1180 * ospf_abr.c: (ospf_abr_announce_network_to_area) dont forget
1181 to approve LSAs for the case where metric has changed, lsa gets
1182 flushed otherwise. (backport candidate).
1183
ajs634f9ea2005-04-11 15:51:40 +000011842005-04-11 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1185
1186 * ospf_zebra.c (ospf_zebra_add): Call zclient_send_message instead
1187 of writen.
1188
ajsd2fc8892005-04-02 18:38:43 +000011892005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1190
ajse4319de2005-04-02 23:23:55 +00001191 * ospf_interface.h: (ospf_if_lookup_by_name) Remove declaration of a
1192 function that does not exist.
1193
11942005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1195
ajs21fefa92005-04-02 23:16:41 +00001196 * ospf_zebra.c: (zebra_interface_if_lookup) Must use
1197 if_lookup_by_name_len.
1198
11992005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1200
ajsa3491982005-04-02 22:50:38 +00001201 * ospf_interface.c: (ospf_vl_new) Use strnlen to fix call to if_create.
1202
12032005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1204
ajsd2fc8892005-04-02 18:38:43 +00001205 * ospf_vty.c: (show_ip_ospf_interface_sub) Show ifindex and interface
1206 flags to help with debugging.
1207 * ospf_zebra.c: (ospf_interface_delete) After deleting, set ifp->ifindex
1208 to IFINDEX_INTERNAL.
1209 (zebra_interface_if_lookup) Make function static. Tighten up code.
1210
ajsaca72fd2005-03-31 15:18:21 +000012112005-03-31 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1212
1213 * ospf_dump.c: (show_debugging_ospf) Show if ospf event debugging
1214 is turned on.
1215
ajsfd651fa2005-03-29 16:08:16 +000012162005-03-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1217
ajsa608bbf2005-03-29 17:03:49 +00001218 * ospf_zebra.c: (ospf_interface_state_up) If the MTU of an operative
1219 interface changes, print a debug message and call ospf_if_reset()
1220 to simulate down/up on the interface.
1221 * ospf_interface.h: Declare new function ospf_if_reset().
1222 * ospf_interface.c: (ospf_if_reset) New function to call ospf_if_down
1223 and ospf_if_up for all ospf interfaces attached to an interface.
1224
12252005-03-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1226
ajs5dcbdf82005-03-29 16:13:49 +00001227 * ospf_packet.c: (ospf_write_frags) Enhance error message to
1228 show MTU. Also make function static.
1229 (ospf_write) Enhance error message to show interface name and MTU.
1230 Also make function static.
1231
12322005-03-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1233
1234 * ospf_vty.c: (show_ip_ospf_interface_sub) Display interface MTU and
1235 bandwidth; this is useful for debugging problems. Also, the function
1236 should be static.
ajsfd651fa2005-03-29 16:08:16 +00001237
hasso1b639042005-03-27 13:32:25 +000012382005-03-27 Hasso Tepper <hasso at quagga.net>
1239
1240 * ospf_snmp.c: Don't crash in snmp query if ospf instance doesn't
1241 exist at all.
1242
hasso343f5cc2005-03-25 19:48:40 +000012432005-03-25 Hasso Tepper <hasso at quagga.net>
1244
1245 * ospfd.h: Include log.h, fixes compile with gcc-4.0.
1246
ajs9dbc7972005-03-13 19:27:22 +000012472005-03-13 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1248
1249 * ospf_lsa.c: (ospf_lsa_refresh_walker) If the system clock jumps
1250 backward, then current time may be less than
1251 ospf->lsa_refresher_started. This was causing invalid values
1252 for ospf->lsa_refresh_queue.index resulting in infinite loops.
1253 Problem fixed by casting the expression to unsigned before taking
1254 the modulus.
1255
ajs5c333492005-02-23 15:43:01 +000012562005-02-23 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1257
1258 * ospfd.h: Add new field struct stream *ibuf to struct ospf.
1259 * ospfd.c: (ospf_new) Check return code from ospf_sock_init.
1260 Allocate ibuf using stream_new(OSPF_MAX_PACKET_SIZE+1).
1261 (ospf_finish) Call stream_free(ospf->ibuf.
1262 * ospf_packet.c: (ospf_read) Call stream_reset(ospf->ibuf) and then
1263 pass it to ospf_recv_packet for use in receiving the packet
1264 (instead of allocating a new stream for each packet received).
1265 Eliminate all calls to stream_free(ibuf).
1266 (ospf_recv_packet) The struct stream *ibuf is now passed in as
1267 an argument. No need to use recvfrom to peek at the packet
1268 header (to see how big it is), just use ospf->ibuf which is
1269 always large enough (this eliminates a system call to recvfrom).
1270 Therefore, no need to allocate a stream just for this packet,
1271 and no need to free it when done.
1272
hasso462f20d2005-02-23 11:29:02 +000012732005-02-23 Vincenzo Eramo <eramo at infocom.ing.uniroma1.it>
1274
1275 * ospf_lsa.h: New flag to the LSA structure for the SPF calculation.
1276 * ospf_lsdb.h: Export ospf_lsdb_clean_stat() function.
1277 * ospf_spf.h: Add link to the LSA stat structure into vertex.
1278 * ospf_spf.c: New functions cmp() and update_stat() to manage
1279 candidates. Remove ospf_spf_has_vertex(), ospf_vertex_lookup(),
1280 ospf_install_candidate() and ospf_spf_register() functions not needed
1281 any more. Update ospf_vertex_new(), ospf_spf_next() and
1282 ospf_spf_calculate() functions to use pqueue instead of linked list.
1283
hassoe40dcce2005-02-21 14:58:42 +000012842005-02-21 Hasso Tepper <hasso at quagga.net>
1285
1286 * ospf_ase.c: Don't show messages related to the ase calculations if
1287 we are not debugging.
1288
hasso306541b2005-02-19 17:58:40 +000012892005-02-19 Hasso Tepper <hasso at quagga.net>
1290
1291 * ospf_api.h: char isn't always signed, but it has to be it here.
1292
paulfa81b712005-02-19 01:19:20 +000012932005-02-19 Paul Jakma <paul.jakma@sun.com>
1294
1295 * ospf_packet.c: (ospf_stream_copy) remove
1296 (ospf_packet_dup) use stream_copy instead of ospf_stream_copy
1297
ajs038163f2005-02-17 19:55:59 +000012982005-02-17 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1299
1300 * ospf_packet.c: (ospf_recv_packet) If there is somehow a runt
1301 packet in the queue, it must be discarded. Improve warning messages.
1302 Fix scope to static.
1303 (ospf_read) Fix bug: should reset the read thread in all cases
1304 to make sure we continue to get incoming messages.
1305
paul658b03a2005-02-15 10:10:55 +000013062005-02-15 Paul Jakma <paul.jakma@sun.com>
1307
1308 * ospf_packet.c: (ospf_recv_packet) Fix silly error wrt allocating
1309 ibuf. Thanks Andrew.
1310
paulbfdc44a2005-02-14 23:48:42 +000013112005-02-14 Paul Jakma <paul.jakma@sun.com>
1312
1313 * ospf_packet.c: (ospf_recv_packet) use stream_recvmsg.
1314
hasso082253f2005-02-11 08:31:54 +000013152005-02-11 Hasso Tepper <hasso at quagga.net>
1316
1317 * ospf_lsdb.c: Fix sum of checksums calculation.
1318
ajs083ee9d2005-02-09 15:35:50 +000013192005-02-09 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1320
1321 * ospf_packet.c: (ospf_write) If sendmsg fails, give more info in the
1322 error message.
1323
ajsba6454e2005-02-08 15:37:30 +000013242005-02-08 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1325
ajs8cfde372005-02-08 15:59:16 +00001326 * ospf_interface.h: Reduce structure padding by putting new u_char
1327 field multicast_memberships in a better spot (grouped with
1328 other u_char fields type and state).
1329
13302005-02-08 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1331
ajsba6454e2005-02-08 15:37:30 +00001332 * ospf_interface.h: Improve passive_interface comment. Add new
1333 multicast_memberships bitmask to struct ospf_interface to track
1334 active multicast subscriptions. Declare new function
1335 ospf_if_set_multicast.
1336 * ospf_interface.c: (ospf_if_set_multicast) New function to configure
1337 multicast memberships properly based on the current
1338 multicast_memberships status and the current values of the
1339 ospf_interface state, type, and passive_interface status.
1340 (ospf_if_up) Remove call to ospf_if_add_allspfrouters (this is
1341 now handled by ism_change_state's call to ospf_if_set_multicast).
1342 (ospf_if_down) Remove call to ospf_if_drop_allspfrouters (now
1343 handled by ism_change_state).
1344 * ospf_ism.c: (ospf_dr_election) Remove logic to join or leave
1345 the DRouters multicast group (now handled by ism_change_state's call
1346 to ospf_if_set_multicast).
1347 (ism_change_state) Add call to ospf_if_set_multicast to change
1348 multicast memberships as necessary to reflect the new interface state.
1349 * ospf_packet.c: (ospf_hello) When a Hello packet is received on a
1350 passive interface: 1. Increase the severity of the error message
1351 from LOG_INFO to LOG_WARNING; 2. Add more information to the error
1352 message (packet destination address and interface address);
1353 and 3. If the packet was sent to ospf-all-routers, then try
1354 to fix the multicast group memberships.
1355 (ospf_read) When a packet is received on an interface whose state
1356 is ISM_Down, enhance the warning message to show the packet
1357 destination address, and try to update/fix the multicast group
1358 memberships if the packet was sent to a multicast address.
1359 When a packet is received for ospf-designated-routers, but the
1360 current interface state is not DR or BDR, then increase the
1361 severity level of the error message from LOG_INFO to LOG_WARNING,
1362 and try to fix the multicast group memberships.
1363 * ospf_vty.c: (ospf_passive_interface) Call ospf_if_set_multicast for
1364 any ospf interface that may have changed from active to passive.
1365 (no_ospf_passive_interface) Call ospf_if_set_multicast for
1366 any ospf interface that may have changed from passive to active.
1367 (show_ip_ospf_interface_sub) Show multicast group memberships.
1368
paul3a9eb092005-02-08 11:29:41 +000013692005-02-08 Paul Jakma <paul@dishone.st>
1370
1371 * ospf_packet.c: (various) Remove unneeded stream_set_putp abuse.
1372
ajs847947f2005-02-02 18:38:48 +000013732005-02-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1374
1375 * ospf_packet.c: (ospf_read) Fix bug: must check for state ISM_Down,
1376 not for event ISM_InterfaceDown. And improve the message by
1377 adding the interface flags.
1378
ajs0b7d97d2005-01-30 17:24:02 +000013792005-01-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1380
1381 * ospf_network.c: (ospf_sock_init) Save errno before calling
1382 ospfd_privs.change.
1383
ajsc3eab872005-01-29 15:52:07 +000013842005-01-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1385
1386 * ospf_packet.c: (ospf_packet_add) If oi->obuf is NULL, print
1387 an error message and return.
1388 (ospf_read) If the interface state is ISM_InterfaceDown, issue
1389 a warning message and ignore the packet.
1390
gdt86f1fd92005-01-10 14:20:43 +000013912005-01-10 Greg Troxel <gdt@fnord.ir.bbn.com>
1392
1393 * ospf_packet.h: Remove commented out definition of
1394 OSPF_MAX_PACKET; neither it or the uncommented one are used any more.
1395
1396 * ospf_packet.c (ospf_make_ls_upd): Leave room for authentication
1397 when deciding if an update will fit.
1398 (ospf_packet_authspace): Factor out calculation of size required
1399 for authentication.
1400 (ospf_make_db_desc): Use ospf_max_packet, not OSPF_MAX_PACKET.
1401 Don't confuse readers that there is a macro.
1402
ajs3dc56b52004-12-30 15:11:19 +000014032004-12-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1404
1405 * ospf_network.c: Improve all setsockopt error messages to give detailed
1406 information on the arguments.
1407
ajsb87f7722004-12-29 20:41:26 +000014082004-12-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1409
ajs17eaa722004-12-29 21:04:48 +00001410 * ospf_packet.c: (ospf_db_desc) Reduce severity of "Negotiation done"
1411 messages from LOG_WARNING to LOG_INFO, since this seems to be
1412 normal.
1413
14142004-12-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1415
ajsb87f7722004-12-29 20:41:26 +00001416 * ospf_packet.c: (ospf_read) Always look up the interface if
1417 ospf_recv_packet returns NULL ifp, since some platforms such
1418 as Solaris 8 appear to support ifindex retrieval but don't.
1419
hasso1d806282004-12-22 09:43:20 +000014202004-12-22 Hasso Tepper <hasso at quagga.net>
1421
1422 * ospf_dump.c: Show debug configuration in vtysh.
hassoc6b87812004-12-22 13:09:59 +00001423 * ospf_vty.c: Fix "show ip ospf" output. Router can't be elected in
1424 any case if it's configured as "translate-never".
hassofe71a972004-12-22 16:16:02 +00001425 * ospf_lsdb.[ch]: New function to calculate sum of checksums.
1426 * ospf_vty.c: Bugfix to show really number of AS external LSAs, not
1427 number of all LSAs with AS scope, this includes opaque as LSAs as
1428 well, show this number separately. Show numbers and sums of
1429 checksums for each type of LSAs.
1430 * ospf_lsa.c: Calculate checksum before putting LSA into database.
hasso1d806282004-12-22 09:43:20 +00001431
ajsbc18d612004-12-15 15:07:19 +000014322004-12-15 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1433
1434 * ospf_interface.h: Declare new function ospf_default_iftype.
1435 * ospf_interface.c: (ospf_default_iftype) New function to centralize
1436 this logic in one place.
1437 * ospf_zebra.c: (ospf_interface_add) Use new function
1438 ospf_default_iftype.
1439 * ospf_vty.c: (no_ip_ospf_network,config_write_interface) Fix logic
1440 by using new function ospf_default_iftype.
1441
ajs3aa8d5f2004-12-11 18:00:06 +000014422004-12-11 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1443
1444 * ospf_packet.c: (ospf_db_desc) Should be static, not global.
1445 (ospf_hello,ospf_db_desc,ospf_ls_upd,ospf_ls_ack) Improve warning
1446 messages to include identifying information (e.g. router id).
1447 * ospf_nsm.c: (nsm_change_state) Improve info message to include
1448 router id and state names.
1449
gdt91f3e522004-12-09 14:51:03 +000014502004-12-09 Greg Troxel <gdt@fnord.ir.bbn.com>
1451
gdt3fb9de72004-12-09 16:30:04 +00001452 * ospf_apiserver.c (ospf_apiserver_term): Obtain struct
1453 ospf_apiserver * from listnode. Remove unused variables. Follows
1454 suggestion from Jay Fenlason.
gdt91f3e522004-12-09 14:51:03 +00001455
ajs9b0e25c2004-12-08 19:06:51 +000014562004-12-08 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1457
1458 * *.c: Change level of debug messages to LOG_DEBUG.
1459
ajs274a4a42004-12-07 15:39:31 +000014602004-12-07 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1461
1462 * ospf_main.c: (main) The 2nd argument to openzlog has been removed.
1463
ajs887c44a2004-12-03 16:36:46 +000014642004-12-03 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1465
ajs1210fa62004-12-03 16:43:24 +00001466 * ospf_packet.c: (ospf_db_desc) Reduce priority on a debug message
1467 from LOG_NOTICE to LOG_DEBUG.
1468
14692004-12-03 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1470
ajs887c44a2004-12-03 16:36:46 +00001471 * ospf_main.c: (sigint) Use zlog_notice for termination message.
1472 (main) Issue a startup announcement using zlog_notice.
1473
ajsbec595a2004-11-30 22:38:43 +000014742004-11-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1475
1476 * ospf_packet.c: (ospf_db_desc_proc) Fix spelling of packet in warning
1477 message and in comment.
1478 (ospf_db_desc) Warning message that a packet is being discarded
1479 should give the router id of the packet source. Fix spelling
1480 of packet in two warning messages.
1481 (ospf_ls_req) Warning message that a link state request is being
1482 discarded should give the router id of the neighbor that sent it.
1483
ajs5b85fac2004-11-26 19:36:42 +000014842004-11-26 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1485
1486 * ospf_main.c: Remove #include "debug.h" (was not being used, and
1487 lib/debug.h has now been deleted).
1488
hassoc0652302004-11-25 19:33:48 +000014892004-11-25 Hasso Tepper <hasso at quagga.net>
1490
1491 * ospf_main.c: Make group to run as configurable.
1492
gdt69e13252004-11-15 18:51:15 +000014932004-11-15 Greg Troxel <gdt@fnord.ir.bbn.com>
1494
1495 * ospf_packet.c (ospf_recv_packet): Assume CMSG_SPACE is present
1496 and works (lib/zebra.h provides if OS doesn't).
1497
paul788dab12004-11-15 11:48:37 +000014982004-11-15 Paul Jakma <paul@dishone.st>
1499
1500 * ospf_{apiserver,te}.c: ospf_lsa_free's should be ospf_lsa_unlock.
1501
paul05e85fa2004-11-12 10:52:19 +000015022004-11-12 Paul Jakma <paul@dishone.st>
1503
1504 * ospf_ia.c: (process_summary_lsa) Only an ABR has any reason to
1505 ignore stub area summary default. Even so it seems a strange
1506 check, add a comment to that effect.
1507
paulf3ae74c2004-11-04 20:35:31 +000015082004-11-04 Paul Jakma <paul@dishone.st>
1509
1510 * ospfd.c: (ospf_network_match_iface) revert to previous network
1511 statement match behaviour.
1512
paul62d8e962004-11-02 20:26:45 +000015132004-11-02 Paul Jakma <paul@dishone.st>
1514
1515 * ospf_packet.c: (ospf_write_frags) remove iov arg, msg already points
1516 to it. Add convenience pointer to msg->msg_iov[1], and use this,
1517 fixing the unfortunate borkenness introduced in moving of this code
1518 to a function.
1519 (ospf_write) remove iovp and fix up call to previous.
1520 (ospf_ls_upd_packet_new) cast size to long int - unfortunately
1521 glibc's size_t format modifier is not portable.
1522
paul37ccfa32004-10-31 11:24:51 +000015232004-10-31 Paul Jakma <paul@dishone.st>
1524
1525 * ospf_packet.c: (ospf_write_frags) Add debug output
1526 (ospf_write) set type early, so we can pass it to
1527 ospf_write_frags.
1528 (ospf_ls_upd_packet_new) print size in debug output when too large
1529 packet is encountered.
paul64511f32004-10-31 18:01:13 +00001530 * ospf_zebra.c: (ospf_distribute_list_update_timer) Ugly misuse of
1531 THREAD_ARG to store an integer, but it should at least use same
1532 same type to retrieve the value. Assert value is sane.
paul37ccfa32004-10-31 11:24:51 +00001533
paulac191232004-10-22 12:05:17 +000015342004-10-22 Paul Jakma <paul@dishone.st>
1535
1536 * ospf_network.c: (ospf_sock_init) call neutral setsock_ifindex()
1537 function.
1538 * ospf_packet.c: (ospf_read) manually look up ifindex
paul4ccb2c42004-10-22 22:52:33 +00001539 if system could not have returned one, eg openbsd, thanks to Rivo
1540 Nurges for highlighting problem and fix.
paul06f953f2004-10-22 17:00:38 +00001541 Change setsockopt_pktinfo to setsockopt_ifindex.
paulac191232004-10-22 12:05:17 +00001542
hasso3fb9cd62004-10-19 19:44:43 +000015432004-10-19 Andrew J. Schorr <aschorr@telemetry-investments.com>
1544
1545 * ospf_snmp.c: (ospf_snmp_if_update) Fix logic to handle PtP links
1546 with dedicated subnets properly.
1547 * ospf_lsa.c: (lsa_link_ptop_set) ditto.
1548 * ospfd.c: (ospf_network_match_iface) ditto.
1549 (ospf_network_run) ditto.
1550 * ospf_interface.c: (ospf_if_is_configured) ditto.
1551 (ospf_if_lookup_by_prefix) ditto.
1552 (ospf_if_lookup_recv_if) ditto.
1553 * ospf_vty.c: (show_ip_ospf_interface_sub) Display the peer or
1554 broadcast address if present.
1555
hassod68614d2004-10-13 09:32:48 +000015562004-10-13 Hasso Tepper <hasso at quagga.net>
1557
1558 * ospf_main.c: Unbreak compilation with ospfapi disabled.
hassoc75105a2004-10-13 10:33:26 +00001559 * ospf_snmp.c: Remove defaults used to initialize smux connection to
1560 snmpd. Connection is initialized only if smux peer is configured.
hassod68614d2004-10-13 09:32:48 +00001561
hassof4d58ce2004-10-12 06:13:54 +000015622004-10-12 Hasso Tepper <hasso at quagga.net>
1563
1564 * ospf_main.c, ospf_opaque.c: Unbreak ospfclient compilation - move
1565 static variable from ospf_main.c into ospf_opaque.c.
1566
hassoc3abdb72004-10-11 16:27:03 +000015672004-10-11 Hasso Tepper <hasso at quagga.net>
1568
1569 * ospf_main.c, ospf_opaque.c: Disable ospfapi init by default. New
1570 command line switch to enable it.
1571
paul6b333612004-10-11 10:11:25 +000015722004-10-11 Paul Jakma <paul@dishone.st>
1573
1574 * ospf_dump.c: (ospf_ip_header_dump) Assume header is in host order
1575 remove ntohs that should have dissappeared. Take struct ip
1576 as argument, caller has to know there's an IP header at start of
1577 stream anyway.
1578 * ospf_dump.h: update declaration of ospf_ip_header_dump.
1579 * ospf_packet.c: (ospf_write) correct call to
1580 sockopt_iphdrincl_swab_htosys which was munging the header.
1581 (ospf_recv_packet) ip_len is needed for old OpenBSD fixup.
1582 (ospf_read) sockopt_iphdrincl_swab_systoh ip header as soon as
1583 we have it.
paul6c835672004-10-11 11:00:30 +00001584 * (global) Const char update and signed/unsigned fixes.
1585 * (various headers) size defines should be unsigned.
1586 * ospf_interface.h: remove duplicated defines, include the
1587 authoritative header - though, these defines should probably
1588 be moved to a dedicated header, or ospfd.h.
1589 * ospf_lsa.h: (struct lsa) ls_seqnum should be unsigned.
1590 * ospf_packet.c: (ospf_write) cast result of shift to unsigned.
paul6b333612004-10-11 10:11:25 +00001591
hassoeb1ce602004-10-08 08:17:22 +000015922004-10-08 Hasso Tepper <hasso at quagga.net>
1593
1594 * *.[c|h]: Fix compiler warnings: make some strings const, signed ->
1595 unsigned, remove unused variables etc.
1596
gdt54ade992004-10-07 19:38:20 +000015972004-10-07 Greg Troxel <gdt@claude.ir.bbn.com>
1598
1599 * ospf_apiserver.c (ospf_apiserver_unregister_opaque_type): Don't
1600 use of variable names 'node' and 'nextnode' to avoid possible
1601 conflict with list macros. Move variable declaration inside for
1602 loop after a statement to top of function.
1603
paulaa20c6f2004-10-07 14:19:36 +000016042004-10-07 Paul Jakma <paul@dishone.st>
1605
1606 * ospf_snmp.c: Missed list typedef update
1607 * ospf_dump.c: Include sockopt.h for header swab functions.
1608
paul18b12c32004-10-05 14:38:29 +000016092004-10-05 Paul Jakma <paul@dishone.st>
1610
1611 * ospf_packet.c: replace ospf_swap_iph_to... with
1612 sockopt_iphdrincl_swab_...
1613
hasso18a6dce2004-10-03 18:18:34 +000016142004-10-03 James R. Leu <jleu at mindspring.com>
1615
1616 * ospf_zebra.c: Read router id related messages from zebra daemon.
1617 Schedule router-id update thread if it's changed.
1618 * ospfd.c: Remove own router-id selection function. Use router id from
1619 zebra daemon if it isn't manually overriden in configuration.
1620
paul68defd62004-09-27 07:27:13 +000016212004-09-27 Paul Jakma <paul@dishone.st>
1622
paul6a99f832004-09-27 12:56:30 +00001623 * ospf_dump.c: (ospf_ip_header_dump) Use HAVE_IP_HDRINCL_BSD_ORDER
1624 Apply to offset too. Print ip_cksum, lets not worry about
1625 possible 2.0.37 compile problems.
1626 * ospf_packet.c: (ospf_swap_iph_to{n,h}) Use
1627 HAVE_IP_HDRINCL_BSD_ORDER.
1628 (ospf_recv_packet) ditto.
1629 (ospf_write) Fixup iov argument to ospf_write_frags.
1630 (struct msghdr).msg_name is caddr_t on most platforms.
paul68defd62004-09-27 07:27:13 +00001631 (ospf_recv_packet) ditto. And msg_flags is not always there
1632 memset struct then set fields we care about rather than
1633 initialise all fields individually.
1634
hassoc9e52be2004-09-26 16:09:34 +000016352004-09-26 Hasso Tepper <hasso at quagga.net>
1636
1637 * ospf_abr.c, ospf_dump.c, ospf_lsa.c, ospf_packet.c, ospf_vty.c,
1638 ospf_zebra.c: Fix compiler warnings.
1639
paul87d6f872004-09-24 08:01:38 +000016402004-09-24 Paul Jakma <paul@dishone.st>
1641
1642 * ospf_apiserver.{c,h}: lists typedef removal cleanup.
1643 update some list loops to LIST_LOOP. some miscellaneous indent
1644 fixups.
1645 (ospf_apiserver_unregister_opaque_type) fix listnode_delete of
1646 referenced node in loop.
paul1603c062004-09-24 08:23:24 +00001647 (ospf_apiserver_term) loops calling ospf_apiserver_free, which
1648 deletes referenced nodes from apiserver_list, fixed.
paul87d6f872004-09-24 08:01:38 +00001649 * ospf_interface.h: lists typedef removal cleanup.
1650 * ospf_opaque.{c,h}: lists typedef removal cleanup. update some list
1651 loops to LIST_LOOP. miscellaneous style and indent fixups.
1652 * ospf_te.{c,h}: ditto
1653 * ospf_packet.c: lists typedef removal cleanup.
paula2570682004-09-24 08:09:57 +00001654 (ospf_write) ifdef fragmentation support. move actual
1655 fragmentation out to a new, similarly ifdefed, function.
1656 (ospf_write_frags) fragmented write support, moved from previous.
paul87d6f872004-09-24 08:01:38 +00001657
hasso52dc7ee2004-09-23 19:18:23 +000016582004-09-23 Hasso Tepper <hasso at quagga.net>
1659
1660 * *.[c|h]: list -> struct list *, listnode -> struct listnode *.
1661
paul68b73392004-09-12 14:21:37 +000016622004-09-12 Paul Jakma <paul@dishone.st>
1663
1664 * ospf_packet.c: Fix bugzilla #107
1665 (ospf_packet_max) get rid of the magic 88 constant
1666 (ospf_swab_iph_ton) new function. set ip header to network order,
1667 taking BSDisms into account.
1668 (ospf_swab_iph_toh) the inverse.
1669 (ospf_write) Add support for IP fragmentation, will only work on
1670 linux though, other kernels make it impossible. get rid of the
1671 magic 4 constant.
1672 (ospf_make_ls_upd) Bound check to end of stream, not to
1673 interface mtu.
1674 (ospf_ls_upd_packet_new) New function, allocate upd packet
1675 taking oversized LSAs into account.
1676 (ospf_ls_upd_queue_send) use ospf_ls_upd_packet_new to allocate,
1677 rather than statically allocating mtu sized packet buffer, which
1678 actually was wrong - it didnt take ip header into account, which
1679 should not be included in packet buffer.
1680 (ospf_ls_upd_send_queue_event) minor tweaks and remove
1681 TODO comment.
1682
gdt630e4802004-08-31 17:28:41 +000016832004-08-31 David Wiggins <dwiggins@bbn.com>
1684
1685 * ospf_spf.c (ospf_spf_calculate): Many more comments and debug
1686 print statements. New function ospf_vertex_dump used in debugging.
1687
16882004-08-31 David Wiggins <dwiggins@bbn.com>
1689
1690 * ospf_spf.h (struct vertex): Comments for flags and structure members.
1691
16922004-08-31 David Wiggins <dwiggins@bbn.com>
1693
1694 * ospf_route.c: When finding an alternate route, log cost as well.
1695
16962004-08-31 David Wiggins <dwiggins@bbn.com>
1697
1698 * ospf_interface.c (ospf_lookup_if_params): Initialize af in
1699 struct prefix allocated on stack.
1700
17012004-08-31 David Wiggins <dwiggins@bbn.com>
1702
1703 * ospf_packet.c (ospf_ls_ack_send_delayed): In p2mp mode, send
1704 acks to AllSPFRouters, rather than All-DR.
1705
hasso7b901432004-08-31 13:37:42 +000017062004-08-27 Hasso Tepper <hasso at quagga.net>
1707
1708 * ospf_vty.c: Don't print ospf network type under interface only
1709 if interface is in broadcast mode and interface type really is
1710 broadcast. Fixes Bugzilla #108.
1711
gdtd7d93992004-08-27 12:03:42 +000017122004-08-27 David Wiggins <dwiggins@bbn.com>
1713
1714 * ospf_spf.c (ospf_nexthop_calculation): Initialize address family
1715 in on-stack struct prefix_ipv4. Fixes point-to-multipoint SPF
1716 calculation.
1717
gdtd0deca62004-08-26 13:14:07 +000017182004-08-26 Greg Troxel <gdt@fnord.ir.bbn.com>
1719
1720 * ospf_packet.c (ospf_recv_packet): adjust size declaration of
gdtd7d93992004-08-27 12:03:42 +00001721 buffer used to get interface index so that it compiles on other
1722 than Linux and includes the required alignment space. Probably
1723 this was only working on sparc/sparc64 because most of
1724 sockaddr_dl was not being written.
gdtd0deca62004-08-26 13:14:07 +00001725
paul863082d2004-08-19 04:43:43 +000017262004-08-19 Paul Jakma <paul@dishone.st>
1727
1728 * ospf_packet.c: update to match sockopt renames.
1729
paul75ee0b82004-08-05 09:10:31 +000017302004-08-04 Paul Jakma <paul@dishone.st>
1731
1732 * ospf_spf.c: (ospf_spf_consider_nexthop) Add comment about issue.
1733 Compare only against list head - all nexthops must be same cost
1734 anyway, fixes a reference-listnode-after-delete bug noted by
1735 Kir Kostuchenko.
1736 (ospf_nexthop_calculation) Use ospf_spf_consider_nexthop for all
1737 candidates attached to root.
1738
paul36c64ef2004-07-27 11:19:11 +000017392004-07-27 Paul Jakma <paul@dishone.st>
1740
paul48fe13b2004-07-27 17:40:44 +00001741 * ospf_packet.c: (ospf_ls_upd_send_queue_event) fix thinko from
1742 last fix for ospfd wedging due to oversize LSAs: dont list loop on
1743 ospf_ls_upd_queue_send() - guaranteed segfault.
1744
17452004-07-27 Paul Jakma <paul@dishone.st>
1746
paul36c64ef2004-07-27 11:19:11 +00001747 * ospf_opaque.c: (ospf_opaque_lsa_flush_schedule) do not NULL out
1748 the LSA as then free_opaque_info_per_id() can never unlock (and
1749 free) the LSA. Reported by Gunnar Stigen.
1750
paul2dd8bb42004-07-23 15:13:48 +000017512004-07-23 Paul Jakma <paul@dishone.st>
1752
1753 * ospf_network.c: Replace PKTINFO/RECVIF with call to
1754 setsockopt_pktinfo
1755 * ospf_packet.c: Use getsockopt_pktinfo_ifindex and
1756 SOPT_SIZE_CMSG_PKTINFO_IPV4.
1757
paul59ea14c2004-07-14 20:50:36 +000017582004-07-14 Paul Jakma <paul@dishone.st>
1759
1760 * ospf_packet.c: (ospf_ls_upd_send_queue_event) Partial fix for
1761 problem reported by Peter Frost amongst others, where function
1762 will spin indefinitely if update list contains LSAs greater than
1763 MTU-headers or other condition leading to update list never being
1764 cleared. Problem of what to do with these LSAs remains.
1765 (ospf_make_ls_upd) add comment about large LSA problem,
1766 indentation cleanup.
1767
gdtb2c1b282004-07-01 12:35:36 +000017682004-07-01 Greg Troxel <gdt@fnord.ir.bbn.com>
1769
1770 * Makefile.am (lib_LTLIBRARIES): make libospf shared
1771
gdt87efd642004-06-30 17:36:11 +000017722004-06-30 Greg Troxel <gdt@poblano.ir.bbn.com>
1773
1774 * Makefile.am: Add shlib support.
1775
hassobeebba72004-06-20 21:00:27 +000017762004-06-10 Hasso Tepper <hasso@estpak.ee>
1777
1778 * *: Removed ifdefs HAVE_NSSA.
1779
paul553ff112004-06-06 09:41:00 +000017802004-06-06 Paul Jakma <paul@dishone.st>
1781
1782 * ospf_dump.c,ospf_lsa.c: Fix typos of merge of previous.
1783 ospf_flood.c: (ospf_process_self_originated_lsa) fix zlog format
1784
paul0c2be262004-05-31 14:16:54 +000017852004-05-31 Sagun Shakya <sagun.shakya@sun.com>
1786
1787 * ospf_dump.c: (ospf_lsa_header_dump) LOOKUP can return null if
1788 index is out of range.
1789 ospf_flood.c: endianness fix
1790 ospf_lsa.c: Missing ntohl's on (struct lsa *)->data->ls_seqnum
1791 in various places.
1792
hassodd669bb2004-05-10 07:43:59 +000017932004-05-10 Hasso Tepper <hasso@estpak.ee>
1794
1795 * ospf_zebra.c, ospfd.c: Move ospf_prefix_list_update() function
1796 to ospf_zebra.c from ospfd.c and add redistribution updates if
1797 route-map is used in redistribution.
1798 * ospf_main.c: Remove now useless call to ospf_init().
1799
paul0a589352004-05-08 11:48:26 +000018002004-05-08 Paul Jakma <paul@dishone.st>
1801
1802 * ospf_zebra.c: Sync with lib/zclient changes
1803
pauld3f0d622004-05-05 15:27:15 +000018042004-05-05 Paul Jakma <paul@dishone.st>
1805
paul5bd41892004-05-05 17:29:24 +00001806 * ospf_network.c: (ospf_sock_init) Check whether IP_HDRINCL is
1807 defined. Warn at compile and runtime. Use
1808 IPTOS_PREC_INTERNETCONTROL otherwise.
pauld3f0d622004-05-05 15:27:15 +00001809 * ospf_packet.c: (ospf_associate_packet_vl) cleanup, move
1810 some of the checks up to ospf_read, return either a
1811 virtual link oi, or NULL.
1812 (ospf_read) Cleanup, make it responsible for checks. Remove
1813 the nbr lookup - moved to ospf_neighbor. Adjust all nbr
1814 lookups to use new wrappers exported by ospf_neighbor.
1815 * ospf_neighbor.h: Add ospf_neigbour_get and ospf_nbr_lookup.
1816 * ospf_neighbor.c: (ospf_neigbour_get) Index ospf_interface
1817 neighbour table by router-id for virtual-link ospf_interfaces,
1818 not by peer_addr (which breaks for asymmetric vlinks)
1819 (ospf_nbr_lookup) add a wrapper for nbr lookups to deal with
1820 above.
paulcd59da62004-05-05 17:26:55 +00001821 * ospf_interface.c: (ospf_vl_set_params) Catch changes of interface
1822 address for either end of a virtual-link, and hence potential cost
1823 changes.
1824
hassoa0a39762004-04-23 08:51:10 +000018252004-04-22 Hasso Tepper <hasso@estpak.ee>
1826
1827 * ospf_zebra.c: Don't ignore reject/bh routes, it's the only way
1828 to "summarize" routes in ASBR at the moment.
1829
hasso8585d4e2004-04-20 17:25:12 +000018302004-04-20 Hasso Tepper <hasso@estpak.ee>
1831
1832 * ospfd.c: Unset NP flag if area is going to be normal or stub.
1833 Fixes UNH OSPF_NSSA.1.2a comment.
1834 * ospf_abr.c: Originate default into stub/nssa area even if
1835 summaries are disabled.
1836 * ospf_zebra.c: Don't attempt to redistribute 127.0.0.0/8.
1837
hassoc266ac72004-04-19 17:31:00 +000018382004-04-19 Hasso Tepper <hasso@estpak.ee>
1839
1840 * ospf_vty.c: Don't warn that export- and import-list can't be
1841 configured to backbone area if they are applied and are working
1842 fine.
1843
hasso128d31d2004-04-04 12:52:33 +000018442004-02-19 Sowmini Varadhan <sowmini.varadhan@sun.com>
1845
1846 * ospf_packet.c: Don't drop packets in Solaris x86.
1847 [quagga-dev 1005].
1848
hasso0d85b992004-03-18 19:18:33 +000018492004-03-18 Amir Guindehi <amir@datacore.ch>
1850
1851 * ospf_opaque.c: Attempt to correct the incorrect behavior of
1852 Quagga's ospfd in the special situation that a node's opaque
1853 capability has changed as "ON -> OFF -> ON". [quagga-dev 843].
1854
paul7f352b82004-02-19 19:37:47 +000018552004-02-19 Sowmini Varadhan <sowmini.varadhan@sun.com>
1856
1857 * ospf_abr.c: (ospf_abr_update_aggregate) UNH 3.12b,c, address range
1858 should be configured with the highest cost path within the range,
1859 not lowest.
1860
paul940b01a2004-02-17 20:07:30 +000018612004-02-17 Paul Jakma <paul@dishone.st>
1862
1863 * ospf_zebra.c: (ospf_interface_delete) Do not delete the interface
1864 params, nor the interface structure, if an interface delete
1865 message is received from zebra.
1866 * ospf_interface.c: (ospf_if_delete_hook) Delete the interface
1867 params and interface, ie that which was previously removed in
1868 (ospf_interface_delete) above.
1869
hasso2db3d052004-02-11 21:52:13 +000018702004-02-11 Hasso Tepper <hasso@estpak.ee>
1871 * ospf_interface.c, ospf_zebra.c: Don't attempt to read path->oi->ifp
1872 if oi doesn't exist any more.
1873
hassocb05eb22004-02-11 21:10:19 +000018742004-02-11 Vadim Suraev <vadim.suraev@terayon.com>
1875 * ospf_packet.c (ospf_ls_upd): Router should flush received network
1876 LSA if it was originated with older router-id ([zebra 14710] #6).
1877
18782003-12-08 Mattias Amnefelt <mattiasa@kth.se>
paul239aecc2003-12-08 10:34:54 +00001879
1880 * ospf_packet.c: (ospf_recv_packet) OpenBSD now leaves iph.ip_len
1881 network byte order.
1882
gdt8f40e892003-12-05 14:01:43 +000018832003-12-05 Greg Troxel <gdt@poblano.ir.bbn.com>
1884
1885 * ospfd.c (ospf_network_match_iface): Rewrite code for clarity
1886 while trying not to change semantics. Add ifdefed-out code to
1887 avoid matching ppp interfaces whose destination address does not
1888 also match the prefix under consideration, to help out people with
1889 problems due to as-yet-unfixed bugs with p2p interfaces coming and
1890 going.
1891
paul736d3442003-07-24 23:22:57 +000018922003-07-25 kamatchi soundaram <kamatchi@tdd.sj.nec.com>
1893
1894 * ospf_packet.c (ospf_ls_upd_send_queue_event): get next route
1895 node in body of the loop to avoid chance that route node
1896 is unlocked and deleted before the next iteration tries to
1897 get next route node.
1898
paul0a825c72003-05-24 13:48:16 +000018992003-05-24 Kenji Yabuuchi
1900
1901 * ospf_interface.c(ospf_if_lookup_recv_if): Use the most specific
1902 match for interface lookup.
1903
paul551a8972003-05-18 15:22:55 +000019042003-05-18 Hasso Tepper <hasso@estpak.ee>
paul445f1432003-05-16 19:00:31 +00001905
paul551a8972003-05-18 15:22:55 +00001906 * ospf_vty.c: Show NSSA LSA route info in "show ip ospf database"
1907 output
paul445f1432003-05-16 19:00:31 +00001908
pauld7480322003-05-16 17:31:51 +000019092003-05-16 Hasso Tepper <hasso@estpak.ee>
1910
1911 * ospf_lsa.c: Fix handling of NSSA
1912
paul551a8972003-05-18 15:22:55 +000019132003-04-23 Hasso Tepper <hasso@estpak.ee>
1914
1915 * ospf_vty.c: fix "router xxx" node commands in vtysh
1916
paul445f1432003-05-16 19:00:31 +000019172003-04-19 Hasso Tepper <hasso@estpak.ee>
1918
1919 * {ospf_abr,ospfd}.c: area id's DECIMAL -> ADDRESS
1920 * ospf_routemap.c: sync daemon's route-map commands to have same
1921 syntax.
1922
19232003-04-19 Sergey Vyshnevetskiy <serg@vostok.net>
1924
1925 * ospf_packet.c: Add missing param to zlog
1926 * ospf_flood.c: remove unused vars
1927
19282003-04-17 Denis Ovsienko <zebra@pilot.org.ua>
1929
1930 * ospf_interface.c: fix incorrect memset
1931
paul28a13842003-05-16 20:30:37 +000019322003-04-10 Amir Guindehi <amir@datacore.ch>
paul445f1432003-05-16 19:00:31 +00001933
1934 * ospf_lsa.[ch]: opaque LSA fix, use ospf_lookup.
1935
19362003-04-03 David Watson <dwatson@eecs.umich.edu>
1937
1938 * ospf_lsa.c: byte order fix
1939
paul07661cb2003-03-18 00:03:05 +000019402002-03-17 Amir Guindehi <amir@datacore.ch>
1941
1942 * ospf_apiserver.[ch]: Merge Ralph Keller's OSPFAPI support.
1943 * ospf_api.[ch]: Merge Ralph Keller's OSPFAPI support.
1944 * ospfclient: OSPFAPI demonstration client.
1945
19462003-01-23 Masahiko Endo <endo@suri.co.jp>
1947
1948 * ospf_ism.c: NSM event schedule bug fix.
1949
19502002-10-30 Greg Troxel <gdt@ir.bbn.com>
1951
1952 * ospf_packet.c (ospf_make_md5_digest): MD5 length fix.
1953
paul718e3742002-12-13 20:15:29 +000019542002-10-23 endo@suri.co.jp (Masahiko Endo)
1955
1956 * ospf_opaque.c: Update Opaque LSA patch.
1957
19582002-10-23 Ralph Keller <keller@tik.ee.ethz.ch>
1959
1960 * ospf_vty.c (show_ip_ospf_database): Fix CLI parse.
1961
19622002-10-23 Juris Kalnins <juris@mt.lv>
1963
1964 * ospf_interface.c (ospf_if_stream_unset): When write queue
1965 becomes empty stop write timer.
1966
19672002-10-10 Greg Troxel <gdt@ir.bbn.com>
1968
1969 * ospf_packet.c (ospf_check_md5_digest): Change >= to > to make it
1970 conform to RFC.
1971
19722002-07-07 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1973
1974 * zebra-0.93 released.
1975
19762002-06-19 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1977
1978 * ospf_spf.c (ospf_nexthop_calculation): Add NULL set to oi and
1979 check of l2. Reported by: Daniel Drown <dan-zebra@drown.org>
1980 (ospf_lsa_has_link): LSA Length calculation fix. Reported by:
1981 Paul Jakma <paulj@alphyra.ie>.
1982
1983 * ospfd.c (ospf_if_update): Fix nextnode reference bug. Reported
1984 by: juris@mt.lv.
1985
19862002-01-21 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1987
1988 * ospfd.c: Merge [zebra 11445] Masahiko ENDO's Opaque-LSA support.
1989
19902001-08-27 Kunihiro Ishiguro <kunihiro@zebra.org>
1991
1992 * ospf_interface.c (ospf_add_to_if): Use /32 address to register
1993 OSPF interface information.
1994 (ospf_delete_from_if): Likewise.
1995
1996 * ospf_zebra.c (ospf_interface_address_delete): Likewise.
1997
19982001-08-23 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1999
2000 * ospf_zebra.c (ospf_redistribute_unset): When redistribute type
2001 is OSPF, do not unset redistribute flag.
2002
20032001-08-19 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
2004
2005 * zebra-0.92a released.
2006
20072001-08-15 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
2008
2009 * zebra-0.92 released.
2010
20112001-08-12 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
2012
2013 * ospfd.c (ospf_config_write): auto-cost reference-bandwidth
2014 configuration display.
2015
20162001-07-24 David Watson <dwatson@eecs.umich.edu>
2017
2018 * ospf_spf.c (ospf_spf_next): Modify ospf_vertex_add_parent to
2019 check for an existing link before connecting the parent and child.
2020 ospf_nexthop_calculation is also modified to check for duplicate
2021 entries when copying from the parent. Finally, ospf_spf_next
2022 removes duplicates when it merges two equal cost candidates.
2023
20242001-07-23 itojun@iijlab.net
2025
2026 * ospfd.c (show_ip_ospf_neighbor): Check ospf_top before use it
2027 [zebra 8549].
2028
20292001-07-23 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
2030
2031 * ospf_packet.c (ospf_write): Remove defined(__OpenBSD__) to make
2032 it work on OpenBSD.
2033
20342001-06-26 Kunihiro Ishiguro <kunihiro@zebra.org>
2035
2036 * ospf_zebra.c (config_write_ospf_default_metric): Display
2037 default-metric configuration.
2038
20392001-06-18 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
2040
2041 * ospf_ia.h (OSPF_EXAMINE_SUMMARIES_ALL): Remove old macros.
2042
20432001-05-28 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
2044
2045 * ospf_snmp.c (ospfIfEntry): Fix interface lookup bug to avoid
2046 crush.
2047 (ospfIfMetricEntry): Likewise.
2048
20492001-03-18 Kunihiro Ishiguro <kunihiro@zebra.org>
2050
2051 * ospf_packet.c (ospf_read): Fix typo. Reported by: "Jen B
2052 Lin'Kova" <jen@stack.net>.
2053
20542001-03-15 Gleb Natapov <gleb@nbase.co.il>
2055
2056 * ospf_interface.c (ip_ospf_network): Set interface parameter.
2057 (interface_config_write): Add check for OSPF_IFTYPE_LOOPBACK.
2058
2059 * ospf_zebra.c (ospf_interface_add): Set interface parameter.
2060
20612001-02-21 Kunihiro Ishiguro <kunihiro@zebra.org>
2062
2063 * ospf_packet.c (ospf_recv_packet): Solaris also need to add
2064 (iph.ip_hl << 2) to iph.ip_len.
2065
20662001-02-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2067
2068 * ospfd.h (OSPF_LS_REFRESH_TIME): Fix OSPF_LS_REFRESH_TIME value.
2069 Suggested by: David Watson <dwatson@eecs.umich.edu>.
2070
2071 * ospf_zebra.c (zebra_init): Remove zebra node.
2072
2073 * ospfd.c (ospf_area_range_set): Function name is changed from
2074 ospf_ara_range_cmd.
2075 (ospf_area_range_unset): New function which separated from DEFUN.
2076 New commands are added:
2077 "no area A.B.C.D range A.B.C.D/M advertise"
2078 "no area <0-4294967295> range A.B.C.D/M advertise"
2079 "no area A.B.C.D range A.B.C.D/M not-advertise"
2080 "no area <0-4294967295> range A.B.C.D/M not-advertise"
2081
2082 * ospf_lsa.c (ospf_lsa_more_recent): Fix previous change.
2083
20842001-02-08 Matthew Grant <grantma@anathoth.gen.nz>
2085
2086 * ospf_network.c (ospf_if_add_allspfrouters): Use
2087 setsockopt_multicast_ipv4.
2088 (ospf_if_drop_allspfrouters): Likewise.
2089
2090 * ospf_lsa.c (ospf_router_lsa_install): Add rt_recalc flag.
2091 (ospf_network_lsa_install): Likewise.
2092 (ospf_summary_lsa_install): Likewise.
2093 (ospf_summary_asbr_lsa_install): Likewise.
2094 (ospf_external_lsa_install): Likewise.
2095 (ospf_lsa_install): Call ospf_lsa_different to check this LSA is
2096 new one or not.
2097
20982001-02-08 Kunihiro Ishiguro <kunihiro@zebra.org>
2099
2100 * ospf_zebra.c (ospf_interface_delete): Do not free interface
2101 structure when ospfd receive interface delete message to support
2102 pseudo interface.
2103
21042001-02-01 Dick Glasspool <dick@ipinfusion.com>
2105
2106 * ospfd.c (area_range_notadvertise): Change area range "suppress"
2107 command to "not-advertise".
2108
2109 * ospfd.h (OSPF_LS_REFRESH_TIME): Change OSPF_LS_REFRESH_TIME from
2110 1800 to 60.
2111
2112 * ospf_abr.c (ospf_abr_update_aggregate): When update_aggregate is
2113 updating the area-range, the lowest cost is now saved.
2114
2115 * ospf_lsa.c (ospf_lsa_more_recent): Routing to compare sequence
2116 numbers rather than creating overflow during calculation.
2117
21182001-02-01 Kunihiro Ishiguro <kunihiro@zebra.org>
2119
2120 * zebra-0.91 is released.
2121
21222001-01-31 Kunihiro Ishiguro <kunihiro@zebra.org>
2123
2124 * ospf_packet.c (ospf_db_desc_proc): Do not continue process when
2125 NSM_SeqNumberMismatch is scheduled.
2126 (ospf_ls_req): Free ls_upd when return from this function.
2127 (ospf_ls_upd_timer): When update list is empty do not call
2128 ospf_ls_upd_send(). Suggested by: endo@suri.co.jp (Masahiko
2129 Endo).
2130
21312001-01-26 Kunihiro Ishiguro <kunihiro@zebra.org>
2132
2133 * ospf_lsa.c (ospf_maxage_flood): Flood LSA when it reaches
2134 MaxAge. RFC2328 Section 14.
2135 (ospf_maxage_lsa_remover): Call above function during removing
2136 MaxAge LSA.
2137
21382001-01-26 Dick Glasspool <dick@ipinfusion.com>
2139
2140 * ospf_flood.c (ospf_flood_through_as): Function is updated for
2141 NSSA Translations now done at ospf_abr.c with no change in P-bit.
2142
2143 * ospf_lsa.c (ospf_get_nssa_ip): Get 1st IP connection for Forward
2144 Addr.
2145 (ospf_install_flood_nssa): Leave Type-7 LSA at Lock Count = 2.
2146
2147 * ospf_ase.c (ospf_ase_calculate_route): Add debug codes.
2148
2149 * ospf_abr.c (ospf_abr_translate_nssa): Recalculate LSA checksum.
2150
2151 * ospf_packet.h (OSPF_SEND_PACKET_LOOP): Added for test packet.
2152
2153 * ospf_dump.c (ospf_lsa_type_msg): Add OSPF_GROUP_MEMBER_LSA and
2154 OSPF_AS_NSSA_LSA.
2155
2156 * ospfd.c (data_injection): Function to inject LSA. This is
2157 debugging command.
2158
21592001-01-11 Kunihiro Ishiguro <kunihiro@zebra.org>
2160
2161 * ospf_route.c (ospf_route_match_same): Remove function.
2162 (ospf_route_match_same_new): Renamed to ospf_route_match_same.
2163
2164 * ospf_zebra.c (ospf_interface_address_delete): Add check for
2165 oi->address. Suggested by Matthew Grant
2166 <grantma@anathoth.gen.nz>.
2167 (ospf_zebra_add): Remove function.
2168 (ospf_zebra_add_multipath): Rename to ospf_zebra_add.
2169
2170 * ospf_interface.c: Remove HAVE_IF_PSEUDO part.
2171
2172 * ospf_zebra.c: Likewise.
2173
21742001-01-10 Kunihiro Ishiguro <kunihiro@zebra.org>
2175
2176 * ospf_ase.c: Remove OLD_RIB part.
2177
2178 * ospf_route.c: Likewise.
2179
2180 * zebra-0.90 is released.
2181
2182 * ospf_packet.c (ospf_recv_packet): Use ip_len adjestment code to
2183 NetBSD.
2184
21852001-01-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2186
2187 * ospf_route.c (ospf_route_delete): Use
2188 ospf_zebra_delete_multipath.
2189
21902001-01-09 Matthew Grant <grantma@anathoth.gen.nz>
2191
2192 * ospf_interface.c (ospf_if_cleanup): Function name is renamed
2193 from ospf_if_free(). Rewrite whole procudure to support primary
2194 address deletion.
2195
2196 * ospf_zebra.c (ospf_interface_address_delete): Add primary
2197 address deletion process.
2198
21992001-01-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2200
2201 * ospf_packet.c (ospf_recv_packet): OpenBSD has same ip_len
2202 treatment like FreeBSD.
2203
22042001-01-09 endo@suri.co.jp (Masahiko Endo)
2205
2206 * ospf_packet.c (ospf_recv_packet): FreeBSD kernel network code
2207 strips IP header size from receiving IP Packet. So we adjust
2208 ip_len to whole IP packet size by adding IP header size.
2209
22102001-01-08 endo@suri.co.jp (Masahiko Endo)
2211
2212 * ospf_network.c (ospf_serv_sock): When socket() is failed return
2213 immediately.
2214 (ospf_serv_sock): Close socket when it is not used.
2215
2216 * ospf_packet.c (ospf_write): Set sin_len when HAVE_SIN_LEN is
2217 defined.
2218 (ospf_write): When bind is fined, close sock.
2219
22202001-01-07 Gleb Natapov <gleb@nbase.co.il>
2221
2222 * ospf_zebra.c (ospf_interface_state_up): Fixes coredump that
2223 appears when you try to configure bandwidth on the ppp interface
2224 that is not yet configured in ospfd.
2225
22262001-01-07 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2227
2228 * ospf_route.c (show_ip_ospf_route_external): "show ip ospf route"
2229 will print nexthops for AS-external routes.
2230
2231 * ospf_ase.c (ospf_ase_route_match_same): New function to compare
2232 ASE route under multipath environment.
2233 (ospf_ase_compare_tables): Likewise.
2234
22352001-01-01 Kunihiro Ishiguro <kunihiro@zebra.org>
2236
2237 * ospfd.h (OSPF_VTYSH_PATH): Change "/tmp/ospfd" to "/tmp/.ospfd".
2238
22392000-12-28 Kunihiro Ishiguro <kunihiro@zebra.org>
2240
2241 * ospf_route.c (ospf_route_install): Install multipath information
2242 to zebra daemon.
2243
2244 * ospf_zebra.c (ospf_zebra_add_multipath): Function for passing
2245 multipath information to zebra daemon.
2246
22472000-12-25 Dick Glasspool <dick@ipinfusion.com>
2248
2249 * ospf_packet.c (ospf_write): Call ospf_packet_delete when sendto
2250 fail.
2251 (DISCARD_LSA): Add argument N for logging point of DISCARD_LSA is
2252 called.
2253
2254 * ospf_lsa.c (ospf_external_lsa_refresh): NSSA install_flood will
2255 leave Type-7 LSA at Lock Count = 2.
2256
2257 * ospf_flood.c (ospf_flood_through): Flood_though_as updated for
2258 NSSA no P-bit off during Area flooding, but P-bit is turned off
2259 for mulitple NSSA AS flooding.
2260
2261 * ospf_ase.c (ospf_ase_calculate_timer): Added calculations for
2262 Type-7 LSDB.
2263
2264 * ospf_abr.c (ospf_abr_translate_nssa): Removed one unlock call.
2265 (ospf_abr_announce_nssa_defaults): Corrected Debug from EVENT to
2266 NSSA.
2267
22682000-12-25 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2269
2270 * ospf_zebra.c (ospf_zebra_read_ipv4): Checking the age of the
2271 found LSA and if the LSA is MAXAGE we should call refresh instead
2272 of originate.
2273
22742000-12-18 Dick Glasspool <dick@ipinfusion.com>
2275
2276 * ospf_abr.c: Removed redundant "...flood" in
2277 announce_network_to_area(). Repaired nssa Unlock by using
2278 discard.
2279
2280 * ospf_packet.c: Removed old NSSA translate during mk_ls_update.
2281
2282 * ospfd.c: Free up all data bases including NSSA.
2283
2284 * ospf_lsa.c: Now allow removal of XLATE LSA's Check in
2285 discard_callback. Added routine to get ip addr from within the
2286 ifp.
2287
2288 * ospf_flood.c: Now set Forward Address for outgoing Type-7.
2289
2290 * ospf_lsa.h: Added prototype for the below. struct in_addr
2291 ospf_get_ip_from_ifp (struct interface *ifp).
2292
22932000-12-14 Gleb Natapov <gleb@nbase.co.il>
2294
2295 * ospf_packet.c (ospf_recv_packet): New OSPF pakcet read method.
2296 Now maximum packet length may be 65535 bytes (maximum IP packet
2297 length).
2298
2299 * ospf_interface.c (ospf_if_stream_set): Don't make input buffer.
2300
2301 * ospfd.c (config_write_network_area): Remove unnecessary area
2302 lookup code.
2303
23042000-12-13 Kunihiro Ishiguro <kunihiro@zebra.org>
2305
2306 * ospf_packet.c (ospf_read): Accept packet bigger than MTU value.
2307
23082000-12-13 Gleb Natapov <gleb@nbase.co.il>
2309
2310 * ospfd.c (config_write_network_area): Fix bug in
2311 config_write_network_area function.
2312
23132000-12-12 Gleb Natapov <gleb@nbase.co.il>
2314
2315 * ospf_abr.c (ospf_abr_announce_network_to_area): Make Summary
2316 LSA's origination and refreshment as same as other type of LSA.
2317
2318 * ospf_lsa.c (ospf_summary_lsa_refresh): Return struct ospf_lsa *.
2319
2320 * ospf_lsa.c (ospf_summary_asbr_lsa_refresh): Likewise.
2321
23222000-12-08 Dick Glasspool <dick@ipinfusion.com>
2323
2324 The bulk of NSSA changes are contained herein; This version will
2325 require manual setting of "always" for NSSA Translator, and will
2326 not perform aggregation yet.
2327
2328 * ospf_dump.c: "debug ospf nssa" is added.
2329
2330 * ospf_dump.h: Likewise.
2331
2332 * ospf_packet.c (ospf_hello): Display router ID on Bad NSSA Hello.
2333
2334 * ospfd.c: Discard_LSA to stay away from LOCAL_XLT Process NSSA
2335 'never, candidate, always'. Change "suppress" to "not-advertise".
2336
2337 * ospfd.h: Add TranslatorRole to struct ospf_area. Add anyNSSA to
2338 struct ospf.
2339
2340 * ospf_ase.c (ospf_ase_calculate_route): External to stay away
2341 from LOCAL_XLT
2342
2343 * ospf_nsm.c (ospf_db_summary_add): External to stay away from
2344 LOCAL_XLT
2345
2346 * ospf_abr.c: Major logic added for abr_nssa_task(). If ABR, and
2347 NSSA translator, then do it. Approve the global list, and flush
2348 any unapproved.
2349
2350 * ospf_lsa.h: New LSA flag OSPF_LSA_LOCAL_XLT to indicate that the
2351 Type-5 resulted from a Local Type-7 translation; not used for
2352 flooding, but used for flushing.
2353
2354 * ospf_flood.c: New NSSA flooding.
2355
23562000-12-08 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2357
2358 * ospfd.c (ospf_find_vl_data): New function for looking up virtual
2359 link data.
2360 (ospf_vl_set_security): Virtual link configuration with
2361 authentication.
2362 (ospf_vl_set_timers): Set timers for virtual link.
2363
2364 * New commands are added.
2365 "area A.B.C.D virtual-link A.B.C.D"
2366 "area A.B.C.D virtual-link A.B.C.D hello-interval <1-65535> retransmit-interval <3-65535> transmit-delay <1-65535> dead-interval <1-65535>"
2367 "area A.B.C.D virtual-link A.B.C.D hello-interval <1-65535> retransmit-interval <3-65535> transmit-delay <1-65535> dead-interval <1-65535> authentication-key AUTH_KEY"
2368 "area A.B.C.D virtual-link A.B.C.D authentication-key AUTH_KEY"
2369 "area A.B.C.D virtual-link A.B.C.D hello-interval <1-65535> retransmit-interval <3-65535> transmit-delay <1-65535> dead-interval <1-65535> message-digest-key <1-255> md5 KEY"
2370 "area A.B.C.D virtual-link A.B.C.D message-digest-key <1-255> md5 KEY"
2371
2372 * ospf_packet.c (ospf_check_md5_digest): Add neighbor's
2373 cryptographic sequence number treatment.
2374 (ospf_check_auth): OSPF input buffer is added to argument.
2375 (ospf_read): Save neighbor's cryptographic sequence number.
2376
2377 * ospf_nsm.c (nsm_change_status): Clear cryptographic sequence
2378 number when neighbor status is changed to NSM down.
2379
2380 * ospf_neighbor.c (ospf_nbr_new): Set zero to crypt_seqnum.
2381
2382 * ospf_neighbor.h (struct ospf_neighbor): Add cryptographic
2383 sequence number to neighbor structure.
2384
23852000-11-29 Kunihiro Ishiguro <kunihiro@zebra.org>
2386
2387 * ospf_snmp.c (ospfIfLookup): OSPF MIB updates.
2388 (ospfExtLsdbEntry): Add OspfExtLsdbTable treatment.
2389
23902000-11-28 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2391
2392 * ospfd.c (ospf_interface_down): Clear a ls_upd_queue queue of the
2393 interface.
2394 (ospf_ls_upd_queue_empty): New function to empty ls update queue
2395 of the OSPF interface.
2396 (no_router_ospf): 'no router ospf' unregister redistribution
2397 requests from zebra.
2398
23992000-11-28 Kunihiro Ishiguro <kunihiro@zebra.org>
2400
2401 * ospf_ism.c (ism_change_status): Increment status change number.
2402
2403 * ospf_interface.h (struct ospf_interface): Add new member for
2404 status change statistics.
2405
2406 * Makefile.am: Update dependencies.
2407
2408 * ospf_zebra.c (ospf_interface_add): OSPF SNMP interface update.
2409 (ospf_interface_delete): OSPF SNMP interface delete.
2410
2411 * ospf_snmp.h: New file is added.
2412
24132000-11-23 Dick Glasspool <dick@ipinfusion.com>
2414
2415 * ospfd.h: Add new ospf_area structure member for
2416 NSSATranslatorRole and NSSATranslator state.
2417
2418 * ospfd.c: Provided for eventual commands to specify NSSA
2419 elections for "translator- ALWAYS/NEVER/CANDIDATE". Provided for
2420 decimal integer version of area-suppress.
2421
2422 * ospf_flood.c: Flood Type-7's only into NSSA (not AS).
2423
2424 * ospf_lsa.c: Undo some previous changes for NSSA. If NSSA
2425 translator, advertise Nt bit.
2426
2427 * ospf_route.c: 1st version of "sh ip os border-routers".
2428
24292000-11-23 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2430
2431 * ospfd.c (area_vlink): Virtual link can not configured in stub
2432 area.
2433
24342000-11-23 Gleb Natapov <gleb@nbase.co.il>
2435
2436 * ospf_packet.c (ospf_db_desc): In states Loading and Full the
2437 slave must resend its last Database Description packet in response
2438 to duplicate Database Description packets received from the
2439 master. For this reason the slave must wait RouterDeadInterval
2440 seconds before freeing the last Database Description packet.
2441 Reception of a Database Description packet from the master after
2442 this interval will generate a SeqNumberMismatch neighbor
2443 event. RFC2328 Section 10.8
2444 (ospf_make_db_desc): DD Master flag treatment.
2445
2446 * ospf_nsm.c (nsm_twoway_received): Move DD related procedure to
2447 nsm_change_status().
2448 (nsm_bad_ls_req): Likewise.
2449 (nsm_adj_ok): Likewise.
2450 (nsm_seq_number_mismatch): Likewise.
2451 (nsm_oneway_received): Likewise.
2452
2453 * ospf_neighbor.h (struct ospf_neighbor): New structure member
2454 last_send_ts for timestemp when last Database Description packet
2455 was sent.
2456
2457 * ospf_nsm.c (ospf_db_desc_timer): Make it sure nbr->last_send is
2458 there. Call ospf_db_desc_resend() in any case.
2459
24602000-11-16 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2461
2462 * ospf_lsa.c (lsa_link_broadcast_set): When there is no DR on
2463 network (suppose you have only one router with interface priority
2464 0). It's router LSA does not contain the link information about
2465 this network.
2466
2467 * ospf_nsm.c (nsm_timer_set): When you change a priority of
2468 interface from/to 0 ISM_NeighborChange event should be scheduled
2469 in order to elect new DR/BDR on the network.
2470
2471 * ospf_interface.c (ip_ospf_priority): Likewise.
2472
2473 * ospf_flood.c (ospf_ls_retransmit_add): When we add some LSA into
2474 retransmit list we need to check whether the present old LSA in
2475 retransmit list is not more recent than the new
2476 one.
2477
24782000-11-09 Dick Glasspool <dick@ipinfusion.com>
2479
2480 * ospf_packet.c: Allows for NSSA Type-7 LSA's throughout the NSSA
2481 area. Any that exit the NSSA area are translated to type-5 LSA's.
2482 The instantiated image is restored after translation.
2483 (ospf_ls_upd_send_list): Renamed to ospf_ls_upd_queu_send().
2484 (ospf_ls_upd_send): Old function which enclosed by #ifdef 0 is
2485 removed.
2486 (ospf_ls_ack_send): Likewise.
2487
2488 * ospf_flood.c: NSSA-LSA's without P-bit will be restricted to
2489 local area. Otherwise they are allowed out the area to be
2490 translated by ospf_packet.c.
2491
2492 * ospf_lsa.c: Undo some previous changes for NSSA.
2493
2494 * ospf_lsdb.h: New access for type 7.
2495
24962000-11-07 Kunihiro Ishiguro <kunihiro@zebra.org>
2497
2498 * ospf_route.c (ospf_path_exist): New function to check nexthop
2499 and interface are in current OSPF path or not.
2500 (ospf_route_copy_nexthops_from_vertex): Add nexthop to OSPF path
2501 when it is not there. Reported by Michael Rozhavsky
2502 <mrozhavsky@opticalaccess.com>
2503
25042000-11-06 Kunihiro Ishiguro <kunihiro@zebra.org>
2505
2506 * ospf_dump.c (config_write_debug): Add seventh string "detail" is
2507 added for flag is OSPF_DEBUG_SEND | OSPF_DEBUG_RECV |
2508 OSPF_DEBUG_DETAIL.
2509
25102000-11-06 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2511
2512 * ospf_lsa.c (router_lsa_flags): ASBR can't exit in stub area.
2513
25142000-11-06 Kunihiro Ishiguro <kunihiro@zebra.org>
2515
2516 * ospf_lsa.c (ospf_router_lsa_originate): Reduce unconditional
2517 logging.
2518
25192000-11-06 Dick Glasspool <dick@ipinfusion.com>
2520
2521 * ospfd.h: Add ait_ntoa function prototype.
2522
2523 * ospfd.c (ait_ntoa): New function for displaying area ID and
2524 Stub/NSSA status.
2525 (show_ip_ospf_interface_sub): Use ait_ntoa.
2526 (show_ip_ospf_nbr_static_detail_sub): Likewise.
2527 (show_ip_ospf_neighbor_detail_sub): Likewise.
2528
2529 * ospf_route.c (ospf_intra_route_add): Set external routing type
2530 to ospf route.
2531 (ospf_intra_add_router): Likewise.
2532 (ospf_intra_add_transit): Likewise.
2533 (ospf_intra_add_stub): Likewise.
2534 (ospf_add_discard_route): Likewise.
2535 (show_ip_ospf_route_network): Use ait_ntoa.
2536 (show_ip_ospf_route_network): Likewise.
2537 (show_ip_ospf_route_router): Likewise.
2538
2539 * ospf_lsa.c (show_lsa_detail): Use ait_ntoa.
2540 (show_lsa_detail_adv_router): Likewise.
2541 (show_ip_ospf_database_summary): Likewise.
2542
2543 * ospf_route.h (struct route_standard): Add new member
2544 external_routing.
2545
2546 * ospf_ia.c (process_summary_lsa): Set external routing tyep to ospf
2547 route.
2548 (ospf_update_network_route): Likewise.
2549 (ospf_update_router_route): Likewise.
2550
25512000-11-04 Kunihiro Ishiguro <kunihiro@zebra.org>
2552
2553 * ospf_flood.c (ospf_process_self_originated_lsa): Enclose
2554 OSPF_AS_NSSA_LSA treatment with #ifdef HAVE_NSSA.
2555
25562000-11-03 Kunihiro Ishiguro <kunihiro@zebra.org>
2557
2558 * Unconditional logging is enclosed with if (IS_DEBUG_OSPF_EVENT).
2559 Please specify "debug ospf event" for enable logging.
2560
2561 * ospf_ism.c: Do not extern debug flag varible. It is done by
2562 ospf_debug.h
2563 * ospf_asbr.c: Likewise.
2564 * ospf_lsa.c: Likewise.
2565 * ospf_nsm.c: Likewise.
2566 * ospf_zebra.c: Likewise.
2567
2568 * ospf_dump.c (debug_ospf_event): New command "debug ospf event"
2569 is added.
2570
2571 * ospfd.c (router_ospf): Change logging from vty_out() to
2572 zlog_info().
2573 (ospf_area_stub_cmd): Likewise.
2574
2575 * ospf_dump.h: Extern term_debug flags.
2576 (OSPF_DEBUG_EVENT): Add new flag.
2577 (IS_DEBUG_OSPF_EVENT): Add new macro.
2578
25792000-11-03 Dick Glasspool <dick@ipinfusion.com>
2580
2581 * ospf_flood.c (ospf_process_self_originated_lsa):
2582 OSPF_AS_NSSA_LSA is treated as same as OSPF_AS_EXTERNAL_LSA.
2583 (ospf_flood): Type-5's have no change. Type-7's can be received,
2584 and will Flood the AS as Type-5's They will also flood the local
2585 NSSA Area as Type-7's. The LSDB will be updated as Type-5's, and
2586 during re-fresh will be converted back to Type-7's (if within an
2587 NSSA).
2588 (ospf_flood_through): Incoming Type-7's were allowed here if our
2589 neighbor was an NSSA. So Flood our area with the Type-7 and also
2590 if we are an ABR, flood thru AS as Type-5.
2591
2592 * ospf_lsa.c (ospf_external_lsa_refresh): Flood NSSA both NSSA
2593 area and other area.
2594
2595 * ospf_packet.c (ospf_db_desc_proc): When AS External LSA is
2596 exists in DD packet, make it sure that this area is not stub.
2597 (ospf_ls_upd_list_lsa): When LSA type is NSSA then set lsa's area
2598 to NULL.
2599 (ospf_ls_upd): If the LSA is AS External LSA and the area is stub
2600 then discard the lsa. If the LSA is NSSA LSA and the area is not
2601 NSSA then discard the lsa.
2602
26032000-11-03 Kunihiro Ishiguro <kunihiro@zebra.org>
2604
2605 * ospfd.c (ospf_interface_run): Fix bug of Hello packet's option
2606 is not properly set when interface comes up.
2607
26082000-11-02 Kunihiro Ishiguro <kunihiro@zebra.org>
2609
2610 * ospfd.h (OSPF_OPTION_O): Add new hello header option.
2611
26122000-11-01 Dick Glasspool <dick@ipinfusion.com>
2613
2614 * ospf_lsa.h: Define OSPF_MAX_LSA to 8 when HAVE_NSSA is enabled.
2615 (OSPF_GROUP_MEMBER_LSA): Define OSPF_GROUP_MEMBER_LSA.
2616
2617 * ospf_lsa.c (show_database_desc): Add "Group Membership LSA"
2618 string.
2619
26202000-10-31 Dick Glasspool <dick@ipinfusion.com>
2621
2622 * ospf_lsa.h (OSPF_AS_NSSA_LSA): Define OSPF_AS_NSSA_LSA.
2623
2624 * ospf_lsa.c (show_ip_ospf_database): NSSA database display
2625 function is added. ALIASES which have "show ip ospf database
2626 nssa-external" is added.
2627 (show_ip_ospf_border_routers): New command "show ip ospf
2628 border-routers" is added.
2629
26302000-10-30 Dick Glasspool <dick@ipinfusion.com>
2631
2632 * ospfd.c (router_ospf): NSSA Enabled message is added for
2633 testing.
2634 (ospf_area_type_set): Are type set for NSSA area.
2635 (ospf_area_stub_cmd): Special translation of no_summary into NSSA
2636 and summary information. If NSSA is enabled pass the information
2637 to ospf_area_type_set().
2638 (area_nssa): New commands are added:
2639 "area A.B.C.D nssa"
2640 "area <0-4294967295> nssa"
2641 "area A.B.C.D nssa no-summary"
2642 "area <0-4294967295> nssa no-summary"
2643 (ospf_no_area_stub_cmd): Special translation of no_summary into
2644 NSSA and summary information. If external_routing is
2645 OSPF_AREA_NSSA unset area with ospf_area_type_set (area,
2646 OSPF_AREA_DEFAULT).
2647 (show_ip_ospf_area): Display NSSA status.
2648 (config_write_ospf_area): Show NSSA configuration.
2649
2650 * ospf_packet.c (ospf_hello): For NSSA support, ensure that NP is
2651 on and E is off.
2652
26532000-10-26 Gleb Natapov <gleb@nbase.co.il>
2654
2655 * ospf_lsa.c (ospf_network_lsa_body_set): The network-LSA lists
2656 those routers that are fully adjacent to the Designated Router;
2657 each fully adjacent router is identified by its OSPF Router ID.
2658 The Designated Router includes itself in this list. RFC2328,
2659 Section 12.4.2.
2660
26612000-10-23 Jochen Friedrich <jochen@scram.de>
2662
2663 * ospf_snmp.c: ospf_oid and ospfd_oid are used in smux_open after
2664 it is registered. So those variables must be static.
2665
26662000-10-18 K N Sridhar <sridhar@euler.ece.iisc.ernet.in>
2667
2668 * ospfd.c: Add area_default_cost_decimal_cmd and
2669 no_area_default_cost_decimal_cmd alias.
2670
26712000-10-05 Gleb Natapov <gleb@nbase.co.il>
2672
2673 * ospfd.c (ospf_network_new): Fix setting area format.
2674 (no_router_ospf): Check area existance when calling
2675 ospf_interface_down().
2676
2677 * ospf_flood.c (ospf_external_info_check): Fix bug of refreshing
2678 default route.
2679
26802000-10-02 Kunihiro Ishiguro <kunihiro@zebra.org>
2681
2682 * zebra-0.89 is released.
2683
26842000-09-29 Kunihiro Ishiguro <kunihiro@zebra.org>
2685
2686 * ospf_snmp.c (ospfHostEntry): OSPF Host MIB is implemented.
2687
2688 * ospfd.c (ospf_nbr_static_cmp): OSPF neighbor is sorted by it's
2689 address.
2690
26912000-09-28 Michael Rozhavsky <mike@nbase.co.il>
2692
2693 * ospf_interface.c (ospf_if_free): Fix deleting self neighbor twice.
2694
26952000-09-27 Kunihiro Ishiguro <kunihiro@zebra.org>
2696
2697 * ospf_packet.c (ospf_read): Solaris on x86 has ip_len with host
2698 byte order.
2699
27002000-09-25 Toshiaki Takada <takada@zebra.org>
2701
2702 * ospfd.c (ospf_compatible_rfc1583), (no_ospf_compatible_rfc1583):
2703 Add CISCO compatible command.
2704
27052000-09-25 Kunihiro Ishiguro <kunihiro@zebra.org>
2706
2707 * ospf_abr.c (ospf_area_range_lookup): New function is added for
2708 area range lookup in OSPF-MIB.
2709 (ospf_area_range_lookup_next): Likewise.
2710
27112000-09-22 Kunihiro Ishiguro <kunihiro@zebra.org>
2712
2713 * ospfd.c (no_router_ospf): Delete virtual link before deleting
2714 area structure.
2715
2716 * ospf_lsa.c (ospf_external_lsa_refresh_type): Check
2717 EXTERNAL_INFO(type).
2718
2719 * ospfd.c (no_router_ospf): Call ospf_vl_delete() instead of
2720 ospf_vl_data_free().
2721
2722 * ospf_interface.c (ospf_vl_shutdown): Execute ISM_InterfaceDown
2723 when ospf_vl_shutdown is called.
2724 (ospf_vl_delete): Call ospf_vl_shutdown() to delete virtual link
2725 interface's thread.
2726
27272000-09-21 Gleb Natapov <gleb@nbase.co.il>
2728
2729 * ospf_lsa.c: New implementation of OSPF refresh.
2730
27312000-09-20 Kunihiro Ishiguro <kunihiro@zebra.org>
2732
2733 * ospf_snmp.c (ospfLsdbLookup): Add LSDB MIB implementation.
2734
27352000-09-18 Kunihiro Ishiguro <kunihiro@zebra.org>
2736
2737 * ospf_snmp.c (ospfStubAreaEntry): Add OSPF stub area MIB.
2738
27392000-09-18 Gleb Natapov <gleb@nbase.co.il>
2740
2741 * ospf_route.h (route_standard): Change member from `struct area'
2742 to area_id.
2743
2744 * ospf_abr.c (ospf_abr_announce_network), (ospf_abr_should_announce),
2745 (ospf_abr_process_network_rt), (ospf_abr_announce_rtr),
2746 (ospf_abr_process_router_rt):
2747 * ospf_ase.c (ospf_find_asbr_route),
2748 (ospf_find_asbr_router_through_area),
2749 * ospf_ia.c (ospf_find_abr_route), (ospf_ia_router_route),
2750 (process_summary_lsa), (ospf_update_network_route),
2751 (ospf_update_router_route):
2752 * ospf_route.c (ospf_intra_route_add), (ospf_intra_add_router),
2753 (ospf_intra_add_transit), (ospf_intra_add_stub),
2754 (ospf_route_table_dump), (show_ip_ospf_route_network),
2755 (show_ip_ospf_route_router), (ospf_asbr_route_cmp),
2756 (ospf_prune_unreachable_routers):
2757 * ospf_spf.c (ospf_rtrs_print):
2758 * ospfd.c (ospf_rtrs_free): Fix the struct change above.
2759
27602000-09-14 Kunihiro Ishiguro <kunihiro@zebra.org>
2761
2762 * ospf_network.c (ospf_serv_sock_init): Enclose SO_BINDTODEVICE
2763 with ifdef.
2764
27652000-09-13 Gleb Natapov <gleb@nbase.co.il>
2766
2767 * ospf_ism.c (ospf_elect_dr), (ospf_elect_bdr): Fix DR election.
2768
2769 * ospf_network.c (ospf_serv_sock_init): Add socket option
2770 SO_BINDTODEVICE on read socket.
2771
2772 * ospf_packet.c (ospf_hello): Ignore Hello packet if E-bit does
2773 not match.
2774
2775 * ospfd.c (ospf_area_check_free), (ospf_area_get),
2776 (ospf_area_add_if): New function added.
2777
27782000-09-13 Kunihiro Ishiguro <kunihiro@zebra.org>
2779
2780 * ospf_route.c (ospf_intra_add_router): Update ABR and ASBR router
2781 count.
2782
2783 * ospf_spf.c (ospf_spf_init): Rest ABR and ASBR router count
2784 starting SPF calculation.
2785
2786 * ospfd.h (struct ospf_area): Add ABR and ASBR router count.
2787
27882000-09-12 Kunihiro Ishiguro <kunihiro@zebra.org>
2789
2790 * ospfd.c (ospf_area_id_cmp): New area structure is sorted by area
2791 ID.
2792
2793 * ospf_lsa.c (ospf_router_lsa_originate): For OSPF MIB update
2794 lsa_originate_count.
2795 (ospf_network_lsa_originate): Likewise.
2796 (ospf_summary_lsa_originate): Likewise.
2797 (ospf_summary_asbr_lsa_originate): Likewise.
2798 (ospf_external_lsa_originate): Likewise.
2799
28002000-09-11 Kunihiro Ishiguro <kunihiro@zebra.org>
2801
2802 * ospf_snmp.c (ospf_variables): ospfRouterID's type RouterID
2803 syntax is IpAddress.
2804 (ospf_admin_stat): New function for OSPF administrative status
2805 check.
2806
28072000-09-10 Jochen Friedrich <jochen@scram.de>
2808
2809 * ospf_snmp.c: Implement OSPF MIB skeleton.
2810
28112000-09-08 Kunihiro Ishiguro <kunihiro@zebra.org>
2812
2813 * ospf_snmp.c: New file is added.
2814
28152000-09-07 David Lipovkov <davidl@nbase.co.il>
2816
2817 * ospf_zebra.c (ospf_interface_delete): Add pseudo interface
2818 treatment.
2819
2820 * ospf_interface.c (interface_config_write): Likewise.
2821
28222000-08-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2823
2824 * zebra-0.88 is released.
2825
28262000-08-17 Michael Rozhavsky <mike@nbase.co.il>
2827
2828 * ospfd.c (ospf_area_free): Remove virtual link configuration only
2829 when Area is removed.
2830
28312000-08-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2832
2833 * ospfd.c (network_area): Revert check for EXTERNAL_INFO
2834 (ZEBRA_ROUTE_CONNECT).
2835 (no_network_area): Likewise.
2836
28372000-08-16 Kunihiro Ishiguro <kunihiro@zebra.org>
2838
2839 * ospfd.h (struct ospf): Add distance_table and
2840 distance_{all,intra,inter,external}.
2841
2842 * ospf_zebra.c: Add OSPF distance related functions.
2843
28442000-08-15 Gleb Natapov <gleb@nbase.co.il>
2845
2846 * ospf_asbr.c (ospf_external_info_find_lsa): New function added.
2847
2848 * ospf_lsa.c (ospf_default_external_info),
2849 (ospf_default_originate_timer), (ospf_external_lsa_refresh_default):
2850 New function added.
2851
2852 * ospf_zebra.c
2853 (ospf_default_information_originate_metric_type_routemap),
2854 (ospf_default_information_originate_always_metric_type_routemap):
2855 Change name and add route-map function.
2856 (ospf_default_information_originate_metric_routemap),
2857 (ospf_default_information_originate_routemap),
2858 (ospf_default_information_originate_type_metric_routemap):
2859 New DEFUN added.
2860
28612000-08-14 Kunihiro Ishiguro <kunihiro@zebra.org>
2862
2863 * ospf_zebra.c (zebra_interface_if_set_value): Change ifindex
2864 restore size from two octet to four.
2865
28662000-08-14 Michael Rozhavsky <mike@nbase.co.il>
2867
2868 * ospf_ase.c (ospf_ase_incremental_update): Implement incremental
2869 AS-external-LSA in 16.6 of RFC2328.
2870
28712000-08-14 Matthew Grant <grantma@anathoth.gen.nz>
2872
2873 * ospf_interface.c (ospf_if_get_output_cost): Change cost
2874 calculation algorithm.
2875
2876 * ospf_packet (ospf_ls_upd): Fix problem of LSA retransmitting.
2877
28782000-08-11 Michael Rozhavsky <mike@nbase.co.il>
2879
2880 * ospf_lsa.c (ospf_maxage_lsa_remover): Fix maxage remover for
2881 AS-external-LSAs.
2882
28832000-08-10 Toshiaki Takada <takada@zebra.org>
2884
2885 * ospfd.c (auto_cost_reference_bandwidth): New DEFUN added.
2886 `auto-cost reference-bandwidth' OSPF router command added.
2887
28882000-08-08 Gleb Natapov <gleb@nbase.co.il>
2889
2890 * ospf_routemap.c (ospf_route_map_update): New function added.
2891 Add route-map event hook.
2892
28932000-08-08 Toshiaki Takada <takada@zebra.org>
2894
2895 * ospf_zebra.c (ospf_distribute_check_connected): If redistribute
2896 prefix is connected route on OSPF enabled interface, suppress to
2897 announce it.
2898
28992000-08-08 Matthew Grant <grantma@anathoth.gen.nz>
2900
2901 * ospf_interface.c (ospf_if_get_output_cost):
2902 New function added. Handle bandwidth parameter for cost
2903 calculation.
2904
29052000-08-08 Michael Rozhavsky <mike@nbase.co.il>
2906
2907 * ospf_interface.c (interface_config_write): Show interface
2908 configuration regardless interface is down.
2909
2910 * ospf_ase.c (ospf_ase_caocluate_route): Whole rewritten external
2911 route calculate function.
2912
29132000-08-08 Gleb Natapov <gleb@nbase.co.il>
2914
2915 * ospf_routemap.c: New file added.
2916
2917 * ospf_asbr.c (ospf_reset_route_map_set_values),
2918 (ospf_route_map_set_compare): New function added.
2919
2920 * ospf_lsa.c (ospf_external_lsa_body_set): Set routemap metric
2921 with AS-external-LSA.
2922
29232000-08-05 Kunihiro Ishiguro <kunihiro@zebra.org>
2924
2925 * ospf_ase.c (ospf_ase_calculate_route_add): Pass new->cost to
2926 ospf_zebra_add as metric.
2927 (ospf_ase_calculate_route_add): Likewise.
2928
2929 * ospf_route.c (ospf_route_install): Pass or->cost to
2930 ospf_zebra_add as metric.
2931
2932 * ospf_zebra.c (ospf_zebra_add): Add metric arguemnt.
2933 (ospf_zebra_delete): Likewise.
2934
29352000-08-03 Matthew Grant <grantma@anathoth.gen.nz>
2936
2937 * ospf_flood.c (ospf_flood_delayed_lsa_ack): New function added.
2938 Dispatch delayed-ACK with flooding AS-external-LSA across virtual
2939 link.
2940
29412000-07-31 Matthew Grant <grantma@anathoth.gen.nz>
2942
2943 * ospfd.c (show_ip_ospf_area): Fix lack of VTY_NEWLINE when
2944 `show ip ospf'.
2945
2946 * ospf_interface.c (ospf_if_free): Fix bug of crash with
2947 Point-to-Point interface.
2948
29492000-07-27 Michael Rozhavsky <mike@nbase.co.il>
2950
2951 * ospf_flood.c (ospf_process_self_originated_lsa):
2952 Make sure to clear LSA->param (redistributed external information)
2953 before refreshment.
2954
29552000-07-27 Gleb Natapov <gleb@nbase.co.il>
2956
2957 * ospfd.c (refresh_group_limit), (refresh_per_slice),
2958 (refresh_age_diff): New defun added. Refresher related parameter
2959 can be configurable.
2960
29612000-07-27 Akihiro Mizutani <mizutani@dml.com>
2962
2963 * ospf_interface.c (interface_config_write): Print `description'
2964 config directive to work.
2965
29662000-07-24 Akihiro Mizutani <mizutani@dml.com>
2967
2968 * ospf_interface.c (ospf_if_init): Use install_default for
2969 INTERFACE_NODE.
2970
29712000-07-24 Gleb Natapov <gleb@nbase.co.il>
2972
2973 * ospf_packet.c (ospf_ls_upd_send_list), (ospf_ls_upd_send_event),
2974 (ospf_ls_ack_send_list), (ospf_ls_ack_send_event): New function added.
2975 This make sending always as many LS update/Ack combined in one ospf
2976 packet.
2977
29782000-07-24 Gleb Natapov <gleb@nbase.co.il>
2979
2980 * ospf_packet.c (ospf_ls_upd_list_lsa): Set NULL to lsa->area if
2981 LSA is AS-external-LSA.
2982
2983 * ospf_nsm.c (nsm_reset_nbr): Do not cancel Inactivity timer.
2984
29852000-07-21 Toshiaki Takada <takada@zebra.org>
2986
2987 * ospf_zebra.c (ospf_default_originate_timer): Set timer for
2988 `default-information originate'. Fix some default originate
2989 related functions.
2990
29912000-07-12 Toshiaki Takada <takada@zebra.org>
2992
2993 * ospf_lsa.c (stream_put_ospf_metric): New function added.
2994
29952000-07-12 Toshiaki Takada <takada@zebra.org>
2996
2997 * ospf_lsa.c (show_ip_ospf_database_router),
2998 (show_ip_ospf_database_network), (show_ip_ospf_database_summary),
2999 (show_ip_ospf_database_summary_asbr), (show_ip_ospf_database_externel),
3000 (show_router_lsa), (show_any_lsa), (show_router_lsa_self),
3001 (show_any_lsa_self): Functions removed.
3002
3003 (show_lsa_prefix_set), (show_lsa_detail_proc), (show_lsa_detail),
3004 (show_lsa_detail_adv_router_proc), (show_lsa_detail_adv_router):
3005 New functions added. Replace above functions.
3006
3007 (show_ip_ospf_database_all), (show_ip_ospf_database_self_originated):
3008 Functions removed.
3009 (show_ip_ospf_database_summary): New functions added. Replace
3010 above functions.
3011
3012 (show_ip_ospf_database_cmd): DEFUN rearranged.
3013 (show_ip_ospf_database_type_id_cmd),
3014 (show_ip_ospf_database_type_id_adv_router_cmd),
3015 (show_ip_ospf_database_type_is_self_cmd): New ALIASes added.
3016 (show_ip_ospf_database_type_adv_rotuer_cmd): New DEFUN added.
3017 (show_ip_ospf_database_type_self_cmd): New ALIAS added.
3018
30192000-07-11 Toshiaki Takada <takada@zebra.org>
3020
3021 * ospf_asbr.c (ospf_external_info_new),
3022 (ospf_external_info_free): New functions added.
3023
3024 * ospf_lsa.h (ospf_lsa): Add new member `void *param' to set
3025 origination parameter for external-LSA.
3026 Remove member `redistribute'.
3027
3028 * ospf_zebra.c (ospf_redistirbute_set): When `redistribute'
3029 command executed, metric and metric-type values are overridden.
3030 If one of those is changed refresh AS-external-LSAs for appropriate
3031 type.
3032
30332000-07-11 Michael Rozhavsky <mike@nbase.co.il>
3034
3035 * ospf_lsa.c (ospf_summary_lsa_refresh),
3036 (ospf_summary_asbr_lsa_refresh): Make sure to refresh summary-LSAs.
3037
3038 * ospf_abr.c (set_metric): New function added.
3039
30402000-07-07 Toshiaki Takada <takada@zebra.org>
3041
3042 * ospf_zebra.c (ospf_default_information_originate_metric_type),
3043 (ospf_default_information_originate_type_metric): New defun added.
3044 Metic and Metric type can be set to default route.
3045 (ospf_default_information_originate_always_metric_type):
3046 (ospf_default_information_originate_always_type_metric):
3047 New defun added. Metric and Metric type can be set to default
3048 always route.
3049
3050 * ospf_zebra.c (ospf_default_metric), (no_ospf_default_metric):
3051 New defun added.
3052
30532000-07-06 Gleb Natapov <gleb@nbase.co.il>
3054
3055 * ospf_flood.c (ospf_flood_through_area): Fix bug of considering
3056 on the same interface the LSA was received from.
3057
30582000-07-06 Michael Rozhavsky <mike@nbase.co.il>
3059
3060 * ospfd.c (ospf_config_write): Fix bug of printing `area stub'
3061 command with `write mem'.
3062
3063 * ospfd.c (no_router_ospf): Remove installed routes from zebra.
3064
3065 * ospf_zebra.c (ospf_interface_delete): Fix function to handle
3066 zebra interface delete event.
3067
30682000-07-06 Toshiaki Takada <takada@zebra.org>
3069
3070 * ospf_zebra.c (ospf_default_information_originate),
3071 (ospf_default_information_originate_always): New DEFUN added.
3072
30732000-07-05 Michael Rozhavsky <mike@nbase.co.il>
3074
3075 * ospf_route.c (ospf_terminate): Make sure to remove external route
3076 when SIGINT received.
3077
30782000-07-03 Gleb Natapov <gleb@nbase.co.il>
3079
3080 * ospf_flood.c, ospf_ism.c, ospf_lsa,c, ospfd.c: Make sure to free
3081 many structure with `no router ospf'.
3082
30832000-06-30 Gleb Natapov <gleb@nbase.co.il>
3084
3085 * ospf_neighbor.c (ospf_nbr_new),
3086 ospf_nsm.c (nsm_timer_set): Start LS update timer only
3087 when neighbor enters Exchange state.
3088
30892000-06-29 Gleb Natapov <gleb@nbase.co.il>
3090
3091 * ospf_nsm.c (nsm_timer_set), (nsm_exchange_done),
3092 ospf_packet.c (ospf_db_desc_proc):
3093 Do not cancel DD retransmit timer when Master.
3094
30952000-06-29 Gleb Natapov <gleb@nbase.co.il>
3096
3097 * ospf_abr.c (ospf_abr_announce_network_to_area),
3098 (ospf_abr_announce_rtr_to_area)
3099 ospf_ase.c (ospf_ase_rtrs_register_lsa),
3100 ospf_flood.c (ospf_process_self_originated_lsa),
3101 (ospf_flood_through_area), (ospf_ls_request_delete),
3102 ospf_interface.c (ospf_if_free),
3103 ospf_ism.c (ism_change_status),
3104 ospf_lsa.c (ospf_router_lsa_update_timer),
3105 (ospf_router_lsa_install), (ospf_network_lsa_install),
3106 (ospf_lsa_maxage_delete), (ospf_lsa_action),
3107 (ospf_schedule_lsa_flood_area),
3108 ospf_nsm.c (nsm_change_status),
3109 ospf_packet.c (ospf_make_ls_req_func), (ospf_make_ls_ack):
3110 Use ospf_lsa_{lock,unlock} for all looking-up of LSA.
3111
3112 * ospf_flood.c (ospf_ls_request_free): Function deleted.
3113
3114 * ospf_lsa.c (ospf_discard_from_db): New function added.
3115
31162000-06-26 Toshiaki Takada <takada@zebra.org>
3117
3118 * ospfd.h (ospf): struct member `external_lsa' name changed to
3119 `lsdb'.
3120
31212000-06-26 Toshiaki Takada <takada@zebra.org>
3122
3123 * ospf_lsa.c (ospf_lsa_install), (ospf_router_lsa_install),
3124 (ospf_network_lsa_install), (ospf_summary_lsa_install),
3125 (ospf_summary_asbr_lsa_install), (ospf_external_lsa_install):
3126 Functions re-arranged.
3127
3128 * ospf_lsa.c (IS_LSA_MAXAGE), (IS_LSA_SELF): Macro added.
3129
31302000-06-20 Michael Rozhavsky <mike@nbase.co.il>
3131
3132 * ospf_packet.c (ospf_ls_req), (ospf_ls_upd), (ospf_ls_ack): Add
3133 verification of LS type.
3134
31352000-06-20 Gleb Natapov <gleb@nbase.co.il>
3136
3137 * ospf_ase.c (ospf_ase_calculate_timer): Add more sanity check
3138 whether rn->info is NULL.
3139
31402000-06-20 Toshiaki Takada <takada@zebra.org>
3141
3142 * ospfd.c (show_ip_ospf_interface_sub): Show Router-ID of both
3143 DR and Backup correctly with `show ip ospf interface' command.
3144
31452000-06-20 Toshiaki Takada <takada@zebra.org>
3146
3147 * ospf_lsa.c (ospf_lsa_lock), (ospf_lsa_unlock),
3148 (ospf_lsa_discard): These functions are used for avoiding
3149 unexpected reference to freed LSAs.
3150
31512000-06-13 Kunihiro Ishiguro <kunihiro@zebra.org>
3152
3153 * ospf_packet.c (ospf_ls_upd): Initialize lsa by NULL to avoid
3154 warning.
3155
31562000-06-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3157
3158 * ospf_ase.h (ospf_ase_rtrs_register_lsa): Add prototype.
3159
31602000-06-12 Toshiaki Takada <takada@zebra.org>
3161
3162 * ospf_lsa.c (ospf_external_lsa_install): Make sure to register
3163 LSA to rtrs_external when replacing AS-external-LSAs in LSDB.
3164 Fix core dump.
3165
31662000-06-10 Toshiaki Takada <takada@zebra.org>
3167
3168 * ospf_lsdb.c (id_to_prefix), (ospf_lsdb_hash_key),
3169 (ospf_lsdb_hash_cmp), (ospf_lsdb_new), (ospf_lsdb_iterator),
3170 (lsdb_free), (ospf_lsdb_free), (ospf_lsdb_add), (ospf_lsdb_delete),
3171 (find_lsa), (ospf_lsdb_lookup), (find_by_id),
3172 (ospf_lsdb_lookup_by_id), (ospf_lsdb_lookup_by_header): Functinos
3173 removed for migration to new_lsdb.
3174
3175 * ospf_lsa.c (ospf_summary_lsa_install),
3176 (ospf_summary_asbr_lsa_install), (ospf_maxage_lsa_remover),
3177 (ospf_lsa_maxage_walker), (ospf_lsa_lookup),
3178 (ospf_lsa_lookup_by_id): Use new_lsdb instead of ospf_lsdb.
3179 (count_lsa), (ospf_lsa_count_table), (ospf_lsa_count),
3180 (ospf_get_free_id_for_prefix): Funcitions removed.
3181
31822000-06-09 Gleb Natapov <gleb@nbase.co.il>
3183
3184 * ospf_ism.c (ism_interface_down): Prevent some unneeded DR changes.
3185
3186 * ospf_packet.c (ospf_db_desc_proc): Fix memory leak.
3187 (ospf_hello): Always copy router-ID when hello is received.
3188
31892000-06-08 Gleb Natapov <gleb@nbase.co.il>
3190
3191 * ospf_lsa.h (struct ospf_lsa): Add member of pointer to struct
3192 ospf_area.
3193
31942000-06-08 Michael Rozhavsky <mike@nbase.co.il>
3195
3196 * ospf_ase.c (ospf_asbr_route_same): New function added.
3197 This function makes sure external route calculation more
3198 precisely.
3199
32002000-06-07 Michael Rozhavsky <mike@nbase.co.il>
3201
3202 * ospf_ism.c (ism_change_status): Use ospf_lsa_flush_area for
3203 network-LSA deletion instead of using ospf_lsdb_delete.
3204 Also cancel network-LSA origination timer.
3205
32062000-06-07 Levi Harper <lharper@kennedytech.com>
3207
3208 * ospf_interface.c (ospf_if_down): Close read fd when an interface
3209 goes down.
3210
32112000-06-05 Kunihiro Ishiguro <kunihiro@zebra.org>
3212
3213 * ospf_asbr.c (ospf_external_info_lookup): Add explicit brace for
3214 avoid ambiguous else.
3215
3216 * ospf_flood.c (ospf_external_info_check): Likewise.
3217
32182000-06-05 Toshiaki Takada <takada@zebra.org>
3219
3220 * ospf_nsm.c (nsm_adj_ok): Fix bug of DR election.
3221
32222000-06-04 Toshiaki Takada <takada@zebra.org>
3223
3224 * ospf_zebra.c (ospf_default_information_originate),
3225 (no_ospf_default_information_originate): New DEFUN added.
3226
32272000-06-03 Toshiaki Takada <takada@zebra.org>
3228
3229 * ospf_lsa.h, ospf_asbr.h (external_info): Struct moved from
3230 ospf_lsa.h to ospf_asbr.h.
3231
3232 * ospf_lsa.c, ospf_asbr.c (ospf_external_info_add),
3233 (ospf_external_info_delete): Function moved from ospf_lsa.c
3234 to ospf_asbr.c.
3235
32362000-06-03 Toshiaki Takada <takada@zebra.org>
3237
3238 * ospf_flood.c (ospf_external_info_check): New function added.
3239 (ospf_process_self_orignated_lsa): Make sure to flush
3240 self-originated AS-external-LSA, when router reboot and no longer
3241 originate those AS-external-LSA.
3242
32432000-06-02 Toshiaki Takada <takada@zebra.org>
3244
3245 * ospf_network.c (ospf_serv_sock): Remove SO_DONTROUTE
3246 socket option.
3247
3248 * ospf_packet.c (ospf_write): Set MSG_DONTROUTE flag for
3249 unicast destination packets.
3250
32512000-06-02 Toshiaki Takada <takada@zebra.org>
3252
3253 * ospf_lsdb.c (new_lsdb_delete): Delete entry from LSDB only when
3254 specified LSA matches.
3255
32562000-06-02 Gleb Natapov <gleb@nbase.co.il>
3257
3258 * ospf_network.c (ospf_serv_sock): Set SO_DONTROUTE
3259 socket option.
3260
32612000-06-01 Akihiro Mizutani <mizutani@dml.com>
3262
3263 * ospf_dump.c: Replace string `Debugging functions\n' with DEBUG_STR.
3264 Replace string `OSPF information\n' with OSPF_STR.
3265
32662000-06-01 Toshiaki Takada <takada@zebra.org>
3267
3268 * ospf_lsdb.[ch]: Use new_lsdb struct for network-LSA instead of
3269 ospf_lsdb.
3270
32712000-06-01 Toshiaki Takada <takada@zebra.org>
3272
3273 * ospf_dump.c (config_debug_ospf_packet), (config_debug_ospf_event),
3274 (config_debug_ospf_ism), (config_debug_ospf_nsm),
3275 (config_debug_ospf_lsa), (config_debug_ospf_zebra),
3276 (term_debug_ospf_packet), (term_debug_ospf_event),
3277 (term_debug_ospf_ism), (term_debug_ospf_nsm),
3278 (term_debug_ospf_lsa), (term_debug_ospf_zebra): Repalce debug_ospf_*
3279 variable to use for debug option flags.
3280
3281 (debug_ospf_packet), (debug_ospf_ism), (debug_ospf_nsm),
3282 (debug_ospf_lsa), (debug_ospf_zebra): Set {config,term}_debug_*
3283 flags when vty->node is CONFIG_NODE, otherwise set only term_debug_*
3284 flags.
3285
3286 * ospf_dump.h (CONF_DEBUG_PACKET_ON), (CONF_DEBUG_PACKET_OFF),
3287 (TERM_DEBUG_PACKET_ON), (TERM_DEBUG_PACKET_OFF),
3288 (CONF_DEBUG_ON), (CONF_DEBUG_OFF), (IS_CONF_DEBUG_OSPF_PACKET),
3289 (IS_CONF_DEBUG_OSPF): New Macro added.
3290
32912000-05-31 Toshiaki Takada <takada@zebra.org>
3292
3293 * ospfd.c (clear_ip_ospf_neighbor): New DEFUN added.
3294 Currently this command is used for only debugging.
3295
3296 * ospf_nsm.c (nsm_change_status): Make sure thread cancellation
3297 for network-LSA when DR has no full neighbors.
3298
3299 * ospf_nsm.c (ospf_db_summary_clear): New function added.
3300
33012000-05-30 Toshiaki Takada <takada@zebra.org>
3302
3303 * ospf_lsdb.c (new_lsdb_insert): LSAs are always freed by
3304 maxage_lsa_remover when LSA is replaced.
3305
33062000-05-25 Gleb Natapov <gleb@nbase.co.il>
3307
3308 * ospf_flood.c (ospf_ls_retransmit_delete_nbr_all): Add argument
3309 `struct ospf_area' to remove LSA from Link State retransmission list
3310 of neighbor from only one Area.
3311
33122000-05-24 Michael Rozhavsky <mike@nbase.co.il>
3313
3314 * ospf_lsdb.c (ospf_lsdb_add): Preserve flags field when
3315 overriting old LSA with new LSA.
3316
33172000-05-24 Gleb Natapov <gleb@nbase.co.il>
3318
3319 * ospf_lsa.c (ospf_router_lsa_body_set): Fix bug of router-LSA
3320 size calculation.
3321
33222000-05-22 Michael Rozhavsky <mike@nbase.co.il>
3323
3324 * ospf_route.c (ospf_intra_add_stub):
3325 * ospf_spf.h (struct vertex): Use u_int32_t for distance (cost)
3326 value instead of u_int16_t.
3327
33282000-05-22 Axel Gerlach <agerlach@datus.datus.com>
3329
3330 * ospf_ia.c (ospf_ia_network_route): Fix bug of Inter-area route
3331 equal cost path calculation.
3332
33332000-05-21 Toshiaki Takada <takada@zebra.org>
3334
3335 * ospf_ase.c (ospf_ase_calculate_route_delete): New function added.
3336 Make sure, when rotuer route is deleted, related external routes
3337 are also deleted.
3338
33392000-05-20 Toshiaki Takada <takada@zebra.org>
3340
3341 * ospfd.c (ospf_interface_down): Make sure interface flag is disable
3342 and set fd to -1.
3343
33442000-05-16 Toshiaki Takada <takada@zebra.org>
3345
3346 * ospf_asbr.c (ospf_asbr_should_announce), (ospf_asbr_route_remove):
3347 Functions removed.
3348
3349 * ospfd.h (EXTERNAL_INFO): Macro added.
3350 Substitute `ospf_top->external_info[type]' with it.
3351
33522000-05-16 Toshiaki Takada <takada@zebra.org>
3353
3354 * ospf_lsa.c (ospf_rtrs_external_remove): New function added.
3355
33562000-05-14 Gleb Natapov <gleb@nbase.co.il>
3357
3358 * ospf_flood.c (ospf_ls_retransmit_delete_nbr_all)
3359 * ospf_lsdb.c (new_lsdb_insert)
3360 * ospf_packet.c (ospf_ls_ack): Fix database synchonization problem.
3361
33622000-05-14 Gleb Natapov <gleb@nbase.co.il>
3363
3364 * ospf_lsa.h (tv_adjust), (tv_ceil), (tv_floor), (int2tv),
3365 (tv_add), (tv_sub), (tv_cmp): Prototype definition added.
3366
3367 * ospf_nsm.h (ospf_db_summary_delete_all): Prototype definition added.
3368
33692000-05-13 Toshiaki Takada <takada@zebra.org>
3370
3371 * ospf_lsa.[ch] (ospf_lsa): struct timestamp type is changed from
3372 time_t to struct timeval.
3373 (tv_adjust), (tv_ceil), (tv_floor), (int2tv), (tv_add),
3374 (tv_sub), (tv_cmp): timeval utillity functions added.
3375
33762000-05-12 Toshiaki Takada <takada@zebra.org>
3377
3378 * ospf_lsa.[ch] (ospf_schedule_update_router_lsas): Delete function.
3379 Change to use macro OSPF_LSA_UPDATE_TIMER instead of using
3380 this function.
3381 router-LSA refresh timer related stuff is re-organized.
3382
33832000-05-10 Gleb Natapov <gleb@nbase.co.il>
3384
3385 * ospf_interface.c (ospf_vl_set_params):
3386 * ospf_packet.c (ospf_check_network_mask):
3387 * ospf_spf.[ch] (ospf_spf_next):
3388 Remove field address from `struct vertex', and search for peer
3389 address of virtual link in function `ospf_vl_set_params' instead.
3390
33912000-05-10 Gleb Natapov <gleb@nbase.co.il>
3392
3393 * ospf_packet.c (ospf_ls_upd): Fix some memory leak related LSA.
3394
33952000-05-08 Thomas Molkenbur <tmo@datus.com>
3396
3397 * ospf_packet.c (ospf_packet_dup): Replace ospf_steram_copy()
3398 with ospf_stream_dup() to fix memory leak.
3399
34002000-05-08 Michael Rozhavsky <mike@nbase.co.il>
3401
3402 * ospf_flood.c (ospf_flood_through_area): Fix the problem of
3403 LSA update without DROther.
3404
34052000-05-04 Gleb Natapov <gleb@nbase.co.il>
3406
3407 * ospf_spf.c (ospf_vertex_free): Fix memory leak of SPF calculation.
3408
34092000-05-03 Toshiaki Takada <takada@zebra.org>
3410
3411 * ospf_neighbor.c (ospf_db_summary_add): Use new_lsdb struct
3412 instead linked-list.
3413 (ospf_db_summary_count), (ospf_db_summary_isempty):
3414 New function added.
3415
3416 * ospf_lsa.c (ospf_rotuer_lsa): Re-arrange and divide functions.
3417
34182000-05-02 Gleb Natapov <gleb@nbase.co.il>
3419
3420 * ospf_lsdb.c (new_lsdb_cleanup): Fix memory leak. When LSDB are
3421 not needed any more, then free them.
3422
34232000-05-02 Toshiaki Takada <takada@zebra.org>
3424
3425 * ospfd.c (timers_spf), (no_timers_spf): New defun added.
3426 SPF calculation timers related stuff is rearranged.
3427
3428 * ospf_spf.c (ospf_spf_calculate_timer_add): Function removed.
3429 SPF timer is scheduled by SPF calculation delay and holdtime
3430 configuration variable.
3431
3432 * ospf_lsa.c (ospf_external_lsa_nexthop_get): Set AS-external-LSA's
3433 forwarding address when nexthop learned by other protocols is
3434 in the OSPF domain.
3435
3436 * ospf_zebra.c (ospf_redistribute_source_metric_type),
3437 (ospf_redistribute_source_type_metric): Re-arrange DEFUNs and
3438 ALIASes.
3439
34402000-05-01 Toshiaki Takada <takada@zebra.org>
3441
3442 * ospf_flood.c (ospf_ls_retransmit_count),
3443 (ospf_ls_retransmit_isempty): New function added.
3444
3445 (ospf_ls_retransmit_add), (ospf_ls_retransmit_delete),
3446 (ospf_ls_retransmit_clear), (ospf_ls_retransmit_lookup),
3447 (ospf_ls_retransmit_delete_all), (ospf_ls_retransmit_delete_nbr_all),
3448 (ospf_ls_retransmit_add_nbr_all): Replace these functions to use
3449 new_lsdb.
3450
34512000-04-29 Toshiaki Takada <takada@zebra.org>
3452
3453 * ospfd.c (no_network_area): Add check Area-ID whether specified
3454 Area-ID with prefix matches config.
3455
34562000-04-27 Toshiaki Takada <takada@zebra.org>
3457
3458 * ospf_lsa.c (ospf_maxage_lsa_remover): Fix problem of
3459 remaining withdrawn routes on zebra.
3460
34612000-04-25 Michael Rozhavsky <mike@nbase.co.il>
3462
3463 * ospf_nsm.c (nsm_kill_nbr), (nsm_ll_down), (nsm_change_status),
3464 (ospf_nsm_event): Fix network-LSA re-origination problem.
3465
34662000-04-24 Toshiaki Takada <takada@zebra.org>
3467
3468 * ospf_nsm.c (ospf_db_desc_timer): Fix bug of segmentation fault
3469 with DD retransmission.
3470
3471 * ospf_nsm.c (nsm_kill_nbr): Fix bug of re-origination when
3472 a neighbor disappears.
3473
34742000-04-23 Michael Rozhavsky <mike@nbase.co.il>
3475
3476 * ospf_abr.c (ospf_abr_announce_network_to_area): Fix bug of
3477 summary-LSAs reorigination. Correctly copy OSPF_LSA_APPROVED
3478 flag to new LSA. when summary-LSA is reoriginatd.
3479
3480 * ospf_flood.c (ospf_flood_through_area): Fix bug of flooding
3481 procedure. Change the condition of interface selection.
3482
34832000-04-21 Toshiaki Takada <takada@zebra.org>
3484
3485 * ospf_lsa.c (ospf_refresher_register_lsa): Fix bug of refresh never
3486 occurs.
3487
3488 * ospfd.c (show_ip_ospf_neighbor_id): New defun added.
3489 `show ip ospf neighbor' related commands are re-arranged.
3490
34912000-04-20 Toshiaki Takada <takada@zebra.org>
3492
3493 * ospf_dump.c (debug_ospf_zebra): New defun added.
3494 Suppress zebra related debug information.
3495
34962000-04-19 Toshiaki Takada <takada@zebra.org>
3497
3498 * ospf_zebra.c (ospf_distribute_list_update_timer),
3499 (ospf_distribute_list_update), (ospf_filter_update):
3500 New function added. Re-organize `distribute-list' router ospf
3501 command.
3502
35032000-04-13 Michael Rozhavsky <mike@nbase.co.il>
3504
3505 * ospf_packet.c (ospf_make_ls_upd): Add check for MAX_AGE.
3506
35072000-04-14 Michael Rozhavsky <mike@nbase.co.il>
3508
3509 * ospf_packet.c (ospf_make_ls_upd): Increment LS age by configured
3510 interface transmit_delay.
3511
35122000-04-14 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3513
3514 * ospf_interface.c (ip_ospf_cost), (no_ip_ospf_cost):
3515 Add to schedule router_lsa origination when the interface cost changes.
3516
35172000-04-12 Toshiaki Takada <takada@zebra.org>
3518
3519 * ospf_lsa.c (ospf_refresher_register_lsa),
3520 (ospf_refresher_unregister_lsa): Fix bug of core dumped.
3521
3522 * ospfd.c (no_router_ospf): Fix bug of core dumped.
3523
35242000-03-29 Toshiaki Takada <takada@zebra.org>
3525
3526 * ospf_nsm.c (nsm_oneway_received): Fix bug of MS flag unset.
3527
35282000-03-29 Michael Rozhavsky <mike@nbase.co.il>
3529
3530 * ospf_lsa.c (ospf_network_lsa):
3531 * ospf_nsm.c (ospf_nsm_event): Fix bug of Network-LSA originated
3532 in stub network.
3533
35342000-03-28 Toshiaki Takada <takada@zebra.org>
3535
3536 * ospf_nsm.c (nsm_bad_ls_req), (nsm_seq_number_mismatch),
3537 (nsm_oneway_received): Fix bug of NSM state flapping between
3538 ExStart and Exchange.
3539
35402000-03-28 Toshiaki Takada <takada@zebra.org>
3541
3542 * ospf_packet.h (strcut ospf_header): Fix the size of ospf_header,
3543 change u_int8_t to u_char.
3544
35452000-03-27 Toshiaki Takada <takada@zebra.org>
3546
3547 * ospf_lsa.c (ospf_lsa_checksum): Take care of BIGENDIAN architecture.
3548
35492000-03-27 Toshiaki Takada <takada@zebra.org>
3550
3551 * ospfd.c (ospf_interface_run): Make sure Address family matches.
3552
35532000-03-26 Love <lha@s3.kth.se>
3554
3555 * ospf_packet.c (ospf_write): Chack result of sendto().
3556
35572000-03-26 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3558
3559 * ospf_nsm.c (nsm_oneway_received): Fix bug of 1-WayReceived in NSM.
3560
35612000-03-23 Libor Pechacek <farco@clnet.cz>
3562
3563 * ospf_lsa.c (ospf_network_lsa)
3564 * ospf_lsdb.c (new_lsdb_insert): Fix bug of accessing to
3565 unallocated memory.
3566
35672000-03-23 Toshiaki Takada <takada@zebra.org>
3568
3569 * ospfd.c (ospf_config_write): Fix bug of duplicate line for
3570 `area A.B.C.D authentication'.
3571
35722000-03-22 Toshiaki Takada <takada@zebra.org>
3573
3574 * ospf_debug.c (debug_ospf_lsa), (no_debug_ospf_lsa): Defun added.
3575 Suppress all zlog related to LSAs with this config option.
3576
35772000-03-21 Kunihiro Ishiguro <kunihiro@zebra.org>
3578
3579 * ospf_nsm.c (ospf_nsm_event): Add check for NSM_InactivityTimer.
3580
35812000-03-21 Toshiaki Takada <takada@zebra.org>
3582
3583 * ospf_packet.c (ospf_ls_upd_timer), (ospf_ls_req):
3584 Fix bug of memory leak about linklist.
3585
3586 * ospf_flood.c (ospf_flood_through_area): Likewise.
3587
35882000-03-18 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3589
3590 * ospf_flood.c (ospf_ls_retransmit_lookup): Add checksum comparison
3591 to identify LSA uniquely. This fix routes lost.
3592
35932000-03-18 Toshiaki Takada <takada@zebra.org>
3594
3595 * ospf_ase.c (ospf_find_asbr_route): Add sanity check with router
3596 routing table.
3597
35982000-03-17 Alex Zinin <zinin@amt.ru>
3599
3600 * ospf_spf.[ch]: Bug fix.
3601 The 2nd stage of Dijkstra could consider one vertex
3602 more than once if there is more than one link
3603 between the routers, thus adding extra CPU overhead
3604 and extra next-hops.
3605 Fixed.
3606
36072000-03-15 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3608
3609 * ospf_nsm.c (nsm_inactivity_timer): Changed to call nsm_kill_nbr().
3610
36112000-03-14 Toshiaki Takada <takada@zebra.org>
3612
3613 * ospf_route.c (ospf_route_copy_nexthops): Fix bug of memory leak of
3614 ospf_path. Actually ignore merging ospf_route with completely same
3615 paths.
3616
36172000-03-12 Toshiaki Takada <takada@zebra.org>
3618
3619 * ospf_lsa.c (show_as_external_lsa_detail): fix bug of
3620 external route tag byte order.
3621
36222000-03-11 Toshiaki Takada <takada@zebra.org>
3623
3624 * ospf_lsdb.c (ospf_lsdb_insert): New function added.
3625
36262000-03-09 Toshiaki Takada <takada@zebra.org>
3627
3628 * ospf_lsa.c (ospf_external_lsa_install),
3629 (ospf_lsa_lookup), (show_ip_ospf_database_all),
3630 (show_ip_ospf_database_self_originate): Use struct new_lsdb for
3631 LSDB of AS-external-LSAs instead of ospf_lsdb.
3632
3633 * ospf_lsa.c (ospf_lsa_unique_id): New function added.
3634 Use for assigning Unique Link State ID instead of
3635 ospf_get_free_id_for_prefix().
3636
36372000-03-09 Toshiaki Takada <takada@zebra.org>
3638
3639 * ospf_ase.c (ospf_ase_calculate_timer): Fix bug of segmentation
3640 fault reported by George Bonser <george@siteROCK.com>.
3641
36422000-03-07 Libor Pechacek <farco@clnet.cz>
3643
3644 * ospfd.c (ospf_interface_down): Fix bug of segmentation fault.
3645
36462000-03-06 Toshiaki Takada <takada@zebra.org>
3647
3648 * ospf_route.c (ospf_route_cmp): Change meaning of return values.
3649
36502000-03-02 Alex Zinin <zinin@amt.ru>
3651 * ospfd.h, ospf_ia.h
3652 New Shortcut ABR code. Now area's flag can be configured
3653 with Default, Enable, and Disable values.
3654 More info will be in the new ver of I-D soon (see IETF web).
3655
36562000-02-25 Toshiaki Takada <takada@zebra.org>
3657
3658 * ospf_lsa.c (ospf_lsa_header_set), (ospf_external_lsa_body_set),
3659 (osfp_external_lsa_originate), (ospf_external_lsa_queue),
3660 (ospf_external_lsa_originate_from_queue): New function added.
3661 (ospf_external_lsa): Function removed.
3662
3663 * ospf_zebra.c (ospf_zebra_read_ipv4): Originate AS-external-LSA
3664 when listen a route from Zebra, instead creating external route.
3665
3666 * ospf_asbr.c (ospf_asbr_route_add_flood_lsa),
3667 (ospf_asbr_route_add_queue_lsa),
3668 (ospf_asbr_route_install_lsa), (ospf_asbr_route_add):
3669 Functions removed.
3670
3671 * ospf_ase.c (process_ase_lsa): Function will not be used.
3672 (ospf_ase_calculate), (ospf_ase_calculate_route_add),
3673 (ospf_ase_calculate_new_route), (ospf_ase_caluculate_asbr_route):
3674 process_ase_lsa () is separated to these functions.
3675
3676 OSPF AS-external-LSA origination is whole re-organized.
3677
36782000-02-18 Toshiaki Takada <takada@zebra.org>
3679
3680 * ospf_packet.c (ospf_ls_upd): Fix bug of OSPF LSA memory leak.
3681
3682 * ospf_asbr.c (ospf_asbr_route_add_flood_lsa),
3683 (ospf_asbr_route_add_queue_lsa): Fix bug of OSPF external route
3684 memory leak.
3685
36862000-02-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3687
3688 * ospf_asbr.c (ospf_asbr_route_install_lsa): Re-calculate LSA
3689 checksum after change Advertised Router field.
3690
36912000-02-09 Toshiaki Takada <takada@zebra.org>
3692
3693 * ospf_asbr.c (ospf_external_route_lookup): Add new function.
3694
36952000-02-08 Toshiaki Takada <takada@zebra.org>
3696
3697 * ospfd.c (ospf_router_id_get), (ospf_router_id_update),
3698 (ospf_router_id_update_timer): Router ID decision algorithm is changed.
3699 Router ID is chosen from all of eligible interface addresses even if
3700 it is not enable to OSPF.
3701
37022000-02-08 Toshiaki Takada <takada@zebra.org>
3703
3704 * ospf_asbr.c (ospf_asbr_route_add): Function divided to
3705 ospf_asbr_route_add_flood_lsa, ospf_asbr_route_add_queue_lsa and
3706 ospf_asbr_route_install_lsa. If Router-ID is not set, then LSA is
3707 waited to install to LSDB.
3708 `0.0.0.0 adv_router' AS-external-LSA origination bug was fixed.
3709
37102000-02-01 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3711
3712 * ospf_flood.c (ospf_ls_retransmit_lookup): Compare LS seqnum
3713 in the ACK before deleting.
3714
3715 * ospf_packet.c (ospf_hello): Reset the flags after a shutdown
3716 and no shutdown of the interface.
3717
37182000-01-31 Toshiaki Takada <takada@zebra.org>
3719
3720 * ospf_packet.c (ospf_ls_req): Send multiple Link State Update
3721 packets respond to a Link State Request packet.
3722
3723 * ospfd.c (show_ip_ospf_neighbor_detail_sub): Show thread state.
3724
3725 * ospf_interface.c (ospf_vl_new): Crash when backbone area
3726 is not configured and set virtual-link to no-backbone area,
3727 bug fixed.
3728
37292000-01-30 Kunihiro Ishiguro <kunihiro@zebra.org>
3730
3731 * ospf_neighbor.h (struct ospf_neighbor): Add pointer to last send
3732 LS Request LSA.
3733
3734 * ospf_packet.c (ospf_ls_upd): Comment out LS request list
3735 treatment. That should be done in OSPF flooding procedure.
3736
3737 * ospf_flood.c (ospf_flood_through_area): Enclose
3738 ospf_check_nbr_loding inside if-else close.
3739
37402000-01-31 Toshiaki Takada <takada@zebra.org>
3741
3742 * ospf_packet.c (ospf_make_ls_upd): Fix bug of #LSAs counting.
3743
37442000-01-29 Toshiaki Takada <takada@zebra.org>
3745
3746 * ospf_packet.c (ospf_make_md5_digest): Fix bug of md5 authentication.
3747
37482000-01-28 Toshiaki Takada <takada@zebra.org>
3749
3750 * ospfd.c (show_ip_ospf): Show Number of ASE-LSAs.
3751
37522000-01-27 Kunihiro Ishiguro <kunihiro@zebra.org>
3753
3754 * ospf_packet.c (ospf_make_db_desc): Don't use rm_list for
3755 removing LSA from nbr->db_summary.
3756
37572000-01-27 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3758
3759 * ospf_packet.c (ospf_ls_upd_send): Set AllSPFRouters to
3760 destination when the link is point-to-point.
3761 (ospf_ls_ack_send_delayed): Likewise.
3762
37632000-01-27 Kunihiro Ishiguro <kunihiro@zebra.org>
3764
3765 * ospf_flood.c (ospf_ls_request_delete_all): Fix bug of next
3766 pointer lookup after the node is freed.
3767
37682000-01-26 Kunihiro Ishiguro <kunihiro@zebra.org>
3769
3770 * ospf_asbr.c (ospf_asbr_route_add): Instead of scanning all AS
3771 external route, use ospf_top->external_self.
3772
37732000-01-27 Toshiaki Takada <takada@zebra.org>
3774
3775 * ospf_lsa.c (ospf_forward_address_get): New function added.
3776
3777 * ospf_asbr.c (ospf_asbr_check_lsas): Originate AS-external-LSA
3778 only when it should be replaced.
3779
37802000-01-25 Kunihiro Ishiguro <kunihiro@zebra.org>
3781
3782 * ospf_flood.c (ospf_ls_retransmit_clear): Delete list node.
3783
3784 * ospf_lsa.c (ospf_lsa_free): Reduce logging message using
3785 ospf_zlog value.
3786
3787 * ospf_ism.c (ism_change_status): Fix bug of DR -> non DR status
3788 change. Self originated LSA is freed but not deleted from lsdb.
3789
37902000-01-24 Kunihiro Ishiguro <kunihiro@zebra.org>
3791
3792 * ospf_ism.c (ism_interface_down): Don't use router_id for
3793 detecting self neighbor structure. Instead of that compare
3794 pointer itself.
3795
3796 * ospf_neighbor.c (ospf_nbr_free): Cancel all timer when neighbor
3797 is deleted.
3798 (ospf_nbr_free): Free last send packet.
3799
3800 * ospf_neighbor.h (struct ospf_neighbor): Remove host strucutre.
3801 Instead of that src is introduced.
3802
3803 * ospf_nsm.h: Enclose macro defenition with do {} while (0).
3804
38052000-01-17 Kunihiro Ishiguro <kunihiro@zebra.org>
3806
3807 * ospfd.c: Change part of passive interface implementation. For
3808 passive interface just disabling sending/receiving Hello on the
3809 interface.
3810
38112000-01-16 Kai Bankett <kai.bankett@vew-telnet.net>
3812
3813 * ospf_interface.h (OSPF_IF_PASSIVE): Add passive flag.
3814 * ospf_interface.c (ospf_if_lookup_by_name): Add new function.
3815 * ospf_lsa.c (ospf_router_lsa): Skip passive interface.
3816 * ospfd.c (passive_interface): New command passive-interface is
3817 added.
3818 (ospf_config_write): Print passive interface.
3819
38202000-01-15 Toshiaki Takada <takada@zebra.org>
3821
3822 * ospf_interface.h (crypt_key): New struct added to store
3823 multiple cryptographic autheitication keys.
3824 (ospf_interface): struct changed.
3825
3826 * ospf_interface.c: ospf_crypt_key_new, ospf_crypt_key_add,
3827 ospf_crypt_key_lookup, ospf_crypt_key_delete: new functions added.
3828
3829 * ospf_packet.c (ip_ospf_message_digest_key): Changed to store
3830 multiple cryptographic authentication keys.
3831
38322000-01-14 Toshiaki Takada <takada@zebra.org>
3833
3834 * ospf_interface.c: DEFUN (if_ospf_*) commands changed name to
3835 ip_ospf_* ().
3836 Old notation `ospf *' still remains backward compatibility.
3837
38381999-12-29 Alex Zinin <zinin@amt.ru>
3839 * ospf_lsa.c: ospf_lsa_more_recent() bug fix
3840 * ospf_nsm.c, ospf_packet.c: remove nbr data struct when
3841 int goes down, also check DD flags correctly (bug fix)
3842
38431999-12-28 Alex Zinin <zinin@amt.ru>
3844 * "redistribute <source> metric-type (1|2) metric <XXX>" added
3845
38461999-12-23 Alex Zinin <zinin@amt.ru>
3847 * added RFC1583Compatibility flag
3848 * added dynamic interface up/down functionality
3849
38501999-11-19 Toshiaki Takada <takada@zebra.org>
3851
3852 * ospf_neighbor.h (struct ospf_neighbor): Add member state_change
3853 for NSM state change statistics.
3854
38551999-11-19 Toshiaki Takada <takada@zebra.org>
3856
3857 * ospfd.c (show_ip_ospf_neighbor_detail),
3858 (show_ip_ospf_neighbor_int_detail): DEFUN Added.
3859
38601999-11-14 Kunihiro Ishiguro <kunihiro@zebra.org>
3861
3862 * ospf_asbr.c (ospf_asbr_check_lsas): Add check of
3863 lsa->refresh_list.
3864
38651999-11-11 Toshiaki Takada <takada@zebra.org>
3866
3867 * ospf_ia.[ch] (OSPF_EXAMINE_SUMMARIES_ALL): Macro added.
3868 This macro is expanded to ospf_examine_summaries ()
3869 for SUMMARY_LSA and SUMMARY_LSA_ASBR.
3870 (OSPF_EXAMINE_TRANSIT_SUMMARIES_ALL): Macro added.
3871 This macro is expanded to ospf_examine_transit_summaries ()
3872 for SUMMARY_LSA and SUMMARY_LSA_ASBR.
3873
38741999-11-11 Toshiaki Takada <takada@zebra.org>
3875
3876 * ospf_lsa.[ch] (ospf_find_self_summary_lsa_by_prefix): Changed to
3877 macro OSPF_SUMMARY_LSA_SELF_FIND_BY_PREFIX.
3878 (ospf_find_self_summary_asbr_lsa_by_prefix): Changed to
3879 macro OSPF_SUMMARY_ASBR_LSA_SELF_FIND_BY_PREFIX.
3880 (ospf_find_self_external_lsa_by_prefix): Changed to
3881 macro OSPF_EXTERNAL_LSA_SELF_FIND_BY_PREFIX.
3882
38831999-11-11 Toshiaki Takada <takada@zebra.org>
3884
3885 * ospfd.c (ospf_abr_type): ospf_abr_type_cisco, ospf_abr_type_ibm,
3886 ospf_abr_type_shortcut and ospf_abr_type_standard DEFUNs are
3887 combined.
3888 * ospfd.c (no_ospf_abr_type): no_ospf_abr_type_cisco,
3889 no_ospf_abr_type_ibm and no_ospf_abr_type_shortcut DEFUNS are
3890 combined.
3891
38921999-11-10 Toshiaki Takada <takada@zebra.org>
3893
3894 * ospf_route.c (ospf_lookup_int_by_prefix): Move function to
3895 ospf_interface.c and change name to ospf_if_lookup_by_prefix ().
3896
38971999-11-01 Alex Zinin <zinin@amt.ru>
3898 * ospf_packet.c
3899 some correction to LSU processing
3900
3901 * ospf_lsa.c ospfd.h
3902 randomize initial LSA refreshment interval
3903 and limit the size of LSA-group to 10
3904 to let randomization work more effectively.
3905
39061999-10-31 Alex Zinin <zinin@amt.ru>
3907 * ospf_interface.c
3908 cancel t_network_lsa_self
3909 when freeing int structure
3910
3911 * ospf_abr.c ospf_asbr.c ospf_flood.c ospf_lsa.c
3912 ospf_lsa.h ospf_lsdb.h ospfd.c ospfd.h
3913
3914 Summary and ASE LSA refreshment functions
3915 added---LSA refreshment is paced to 70 LSAs
3916 per sec to avoid link overflow. Refreshment events
3917 are further randomized within a 10 sec interval
3918 to avoid syncing.
3919
3920 Also the sigfault of memcmp() in ospf_lsa_is_different()
3921 is fixed.
3922
39231999-10-30 Alex Zinin <zinin@amt.ru>
3924 * ospf_nsm.c
3925 Fix the bug where MAX_AGE LSAs
3926 are included into the DB summary.
3927
3928 * ospf_interface.c
3929 allocate 2*MTU input buffer instead of just MTU
3930 for the cases when the other router mistakenly
3931 sends larger packets thus causing fragmentation, etc.
3932
3933 * ospf_nsm.c
3934 in nsm_reset_nbr() lists should be freed
3935 not when they are empty.
3936
39371999-10-29 Kunihiro Ishiguro <kunihiro@zebra.org>
3938
3939 * ospf_zebra.c (ospf_acl_hook): Move OSPF_IS_ASBR and OSPF_IS_ABR
3940 check inside of if (ospf_top).
3941
39421999-10-29 Alex Zinin <zinin@amt.ru>
3943 * ospf_lsa.c ospf_lsdb.c :
3944 add assertion in lsa and lsa->data alloc functions,
3945 as well as in lsdb_add for new->data
3946
3947 * ospf_lsdb.c: free hash table correctly
3948
39491999-10-28 John Capo <jc@irbs.com>
3950
3951 * ospf_packet.h (OSPF_PACKET_MAX): Correct MAX packet length
3952 calculation
3953
39541999-10-27 Kunihiro Ishiguro <kunihiro@zebra.org>
3955
3956 * OSPF-TRAP-MIB.txt: New file added. Edited version of RFC1850.
3957
3958 * OSPF-MIB.txt: New file added. Edited version of RFC1850.
3959
39601999-10-27 Alex Zinin <zinin@amt.ru>
3961 * ospfd, ospf_zebra, ospf_abr
3962 "area import-list" command is added.
3963 This command allows to filter the inter-area routes
3964 injected into an area. Access list hook function
3965 extended to invalidate area exp/imp lists.
3966
39671999-10-25 Yoshinobu Inoue <shin@nd.net.fujitsu.co.jp>
3968
3969 * ospfd.c (ospf_interface_run): Enable to detect P2P network
3970 on an OSPF interface.
3971
39721999-10-19 Jordan Mendelson <jordy@wserv.com>
3973
3974 * ospf_lsdb.c (ospf_lsdb_add): Fix bug of crash
3975 in ospf_ls_retransmit_lookup ().
3976
39771999-10-19 Vladimir B. Grebenschikov <vova@express.ru>
3978
3979 * ospf_route.c: Workaround about installation of OSPF routes into
3980 the zebra daemon. Add checking of existance routes. Free
3981 ospf_top->old_table if it exists.
3982
39831999-10-15 Jordan Mendelson <jordy@wserv.com>
3984
3985 * Add support for MD5 authentication.
3986
39871999-10-12 Alex Zinin <zinin@amt.ru>
3988 * ospfd.c, ospfd.h, ospf_abr.c:
3989 a new command "area export-list" was added, it allows
3990 the admin. to control which intra-area routes are
3991 announced to other areas by the ABR
3992
39931999-10-12 Alex Zinin <zinin@amt.ru>
3994 * ospf_asbr.c (ospf_asbr_check_lsas): Fix bug of coredump
3995 when "no redistribute" is used after a distribute list
3996 denying some networks was used
3997
39981999-10-05 Toshiaki Takada <takada@zebra.org>
3999
4000 * ospf_route.c (ospf_path_dup): New function added.
4001
40021999-10-05 Toshiaki Takada <takada@zebra.org>
4003
4004 * ospf_interface.[ch]: Some of VL related funciton name changed.
4005
40061999-09-27 Alex Zinin <zinin@amt.ru>
4007
4008 * ospf_zebra.c: Distribute-list functionality added
4009
40101999-09-27 Toshiaki Takada <takada@zebra.org>
4011
4012 * ospfd.c (show_ip_ospf): Fix bug of segmentation fault when no ospf
4013 instance exists.
4014
40151999-09-25 Kunihiro Ishiguro <kunihiro@zebra.org>
4016
4017 * ospfd.c (ospf_interface_down): Fix bug of misusing nextnode()
4018 instead of node->next. Reported by Hiroki Ishibashi
4019 <ishibasi@dcd.abk.nec.co.jp>.
4020
4021 * ospf_route.c (show_ip_ospf_route): Add check for ospf is enabled
4022 or not.
4023
40241999-09-23 Alex Zinin <zinin@amt.ru>
4025
4026 * stub area support added
4027
40281999-09-23 Alex Zinin <zinin@amt.ru>
4029
4030 * fwd_addr in ASE-LSAs is now set correctly
4031 * ASE routing changed to check the fwd_addr
4032 and skip the route if the addr points to one
4033 of our interfaces to avoid loops.
4034
40351999-09-22 Alex Zinin <zinin@amt.ru>
4036
4037 * ospf_interface:
4038 ospf_vls_in_area() added, it returns
4039 the number of VLs configured through the area
4040
4041 * ospf_interface.c ospf_lsa.c ospf_lsdb.c ospfd.c
4042 honor correct mem alloc
4043
40441999-09-22 Alex Zinin <zinin@amt.ru>
4045
4046 * memory.[ch]:
4047 Some OSPF mem types added,
4048 plus more info in "show mem"
4049
40501999-09-21 Alex Zinin <zinin@amt.ru>
4051
4052 * ospfd.c:
4053 "area range substitute" added.
4054 It can be used on NAT-enabled (IP-masquarade)
4055 routers to announce private networks
4056 from an area as public ones into the outside
4057 world (not in the RFC, btw :)
4058
40591999-09-21 Alex Zinin <zinin@amt.ru>
4060
4061 * ospfd.c:
4062 "area range suppress" added.
4063 This command allows to instruct the router
4064 to be silent about specific ranges, i.e.,
4065 it is a method of route filtering on area
4066 borders
4067
40681999-09-21 Alex Zinin <zinin@amt.ru>
4069
4070 * ospfd.c VLs removed when "no network area" executed
4071
40721999-09-20 Alex Zinin <zinin@amt.ru>
4073
4074 * ospf_ase.c bug fix for not-zero fwd_addr
4075 and directly connected routes.
4076
40771999-09-20 Yon Uriarte <yon@plannet.de>
4078
4079 * ospf_packet.c (ospf_make_ls_req): Introduce delta value for
4080 checking the length of OSPF packet exceeds MTU or not.
4081
4082 * ospf_lsa.c (ospf_lsa_different): Apply ntohs for checking
4083 l1->data->length.
4084
40851999-09-18 Alex Zinin <zinin@amt.ru>
4086
4087 * ospf_lsa.c bug fix for ospf_network_lsa() to
4088 include itself into the RID list
4089
40901999-09-10 Alex Zinin <zinin@amt.ru>
4091
4092 * Alternative ABR behaviors IBM/Cisco/Shortcut
4093 implemented
4094
40951999-09-10 Alex Zinin <zinin@amt.ru>
4096
4097 * router and network-LSA origination
4098 changed to honor MinLSInterval
4099
41001999-09-08 Alex Zinin <zinin@amt.ru>
4101
4102 * modified ABR behavior to honor VLs and transit
4103 areas
4104
41051999-09-07 Alex Zinin <zinin@amt.ru>
4106
4107 * completed VL functionality
4108
41091999-09-06 Kunihiro Ishiguro <kunihiro@zebra.org>
4110
4111 * ospf_asbr.c: New file.
4112 ospf_asbr.h: New file.
4113
4114 * ospf_zebra.c (ospf_redistribute_connected): Add redistribute
4115 related stuff.
4116
41171999-09-05 Kunihiro Ishiguro <kunihiro@zebra.org>
4118
4119 * ospfd.h (OSPF_FLAG_VIRTUAL_LINK): Change OSPF_FLAG_VEND to
4120 OSPF_FLAG_VIRTUAL_LINK for comprehensiveness.
4121
41221999-09-03 Kunihiro Ishiguro <kunihiro@zebra.org>
4123
4124 * ospf_spf.c (ospf_spf_register): Change name from
4125 ospf_spf_route_add() to ospf_spf_register().
4126 Include "ospfd/ospf_abr.h" for ospf_abr_task() prototype.
4127
41281999-09-02 Kunihiro Ishiguro <kunihiro@zebra.org>
4129
4130 * ospf_lsa.c (ospf_external_lsa_install): Change to update
4131 lsa->data rather than install new one, when same id lsa is already
4132 installed.
4133
41341999-09-01 Kunihiro Ishiguro <kunihiro@zebra.org>
4135
4136 * ospf_lsa.c (ospf_router_lsa_install): Return lsa value.
4137 (ospf_network_lsa_install): Likewise.
4138 (ospf_summary_lsa_install): Likewise.
4139 (ospf_summary_asbr_lsa_install): Likewise.
4140 (ospf_external_lsa_install): Likewise.
4141
4142 * ospf_spf.c (ospf_spf_calculate): Comment out debug function
4143 ospf_rtrs_print().
4144
41451999-08-31 Kunihiro Ishiguro <kunihiro@zebra.org>
4146
4147 * ospf_spf.c (ospf_rtrs_free): Add ospf_spf_calculate() for
4148 freeing rtrs.
4149
41501999-08-31 Toshiaki Takada <takada@zebra.org>
4151
4152 * ospf_lsa.c (show_ip_ospf_database_summary),
4153 (show_ip_ospf_database_summary_asbr),
4154 (show_ip_ospf_database_external): New function added.
4155 `show ip ospf database summary',
4156 `show ip ospf database asbr-summary'
4157 `show ip ospf database external' command can be used.
4158
4159 * ospf_lsa.c (ospf_lsa_count_table): New function added.
4160 (show_ip_ospf_database_all): show nothing if a type of LSA
4161 does not exist.
4162
41631999-08-31 Kunihiro Ishiguro <kunihiro@zebra.org>
4164
4165 * ospf_lsa.c (ospf_maxage_lsa_remover): Preserve next pointer when
4166 the node is deleted.
4167
41681999-08-31 Toshiaki Takada <takada@zebra.org>
4169
4170 * ospf_flood.c (ospf_ls_retransmit_lookup): change to return
4171 struct ospf_lsa *.
4172 (ospf_ls_request_new), (ospf_ls_request_free),
4173 (ospf_ls_request_add), (ospf_ls_request_delete),
4174 (ospf_ls_request_delete_all), (ospf_ls_request_lookup):
4175 New function added.
4176
4177 * ospf_packet.c (ospf_ls_upd_send_lsa): New function added.
4178
4179 * ospf_lsa.h (LS_AGE): Slightly change macro definition.
4180
4181 * ospf_lsa.c (ospf_lsa_more_recent), (ospf_lsa_diffrent):
4182 Use LS_AGE macro.
4183
41841999-08-30 Alex Zinin <zinin@amt.ru>
4185
4186 * ospfd.c
4187 fix a bug with area range config write
4188 added "show ip ospf" command, it will be enhanced later on
4189
41901999-08-30 Alex Zinin <zinin@amt.ru>
4191
4192 * ospf_lsa.c
4193 updated ospf_router_lsa() to honor flags (B-bit)
4194
41951999-08-30 Alex Zinin <zinin@amt.ru>
4196
4197 * ospf_abr.c
4198 wrote major functions implementing ABR activity
4199
42001999-08-30 Alex Zinin <zinin@amt.ru>
4201
4202 * ospf_ia.c ospf_route.c ospf_route.h
4203 fixed the bug with ospf_route.origin field.
4204 Now it holds pointer to lsa_header
4205
42061999-08-30 Alex Zinin <zinin@amt.ru>
4207
4208 * ospf_flood.c ospf_flood.h:
4209 transformed ospf_flood_if_select into ospf_flood_through_area()
4210 added new ospf_flood_if_select() and ospf_flood_through_as()
4211
42121999-08-30 Toshiaki Takada <takada@zebra.org>
4213
4214 * ospf_flood.[ch]: New file added.
4215
4216 * ospf_packet.c (ospf_lsa_flooding),
4217 (ospf_lsa_flooding_select_if): functions move to ospf_flood.c
4218
4219 * ospf_neighbor.c (ospf_put_lsa_on_retransm_list),
4220 (ospf_remove_lsa_from_retransm_list),
4221 (ospf_nbr_remove_all_lsas_from_retransm_list),
4222 (ospf_lsa_remove_from_ls_retransmit):
4223 (ospf_lsa_retransmit): functions move to
4224 ospf_flood.c, and change function's name:
4225
4226 ospf_put_lsa_on_retransm_list ()
4227 -> ospf_ls_retransmit_add ()
4228 ospf_remove_lsa_from_retransm_list ()
4229 -> ospf_ls_retransmit_delete ()
4230 ospf_nbr_remove_all_lsas_from_retransm_list ()
4231 -> ospf_ls_retransmit_clear ()
4232 ospf_lsa_remove_from_ls_retransmit ()
4233 -> ospf_ls_retransmit_delete_nbr_all ()
4234 ospf_lsa_retransmit ()
4235 -> ospf_ls_retransmit_add_nbr_all ()
4236
4237 * ospf_lsa.c (ospf_lsa_lookup_from_list): function move to
4238 ospf_flood.c, and change name to ospf_ls_retransmit_lookup ().
4239
42401999-08-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4241
4242 * ospf_neighbor.c (ospf_nbr_lookup_by_addr): Use
4243 route_node_lookup() instead of route_node_get().
4244
4245 * ospf_packet.c (ospf_ls_upd): Temporary comment out (6) check.
4246
42471999-08-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4248
4249 * ospf_route.c (ospf_lookup_int_by_prefix): Add check of
4250 oi->address.
4251
42521999-08-29 Alex Zinin <zinin@amt.ru>
4253 * ospf_lsa.c
4254 MaxAge LSA deletion functions added.
4255
42561999-08-29 Alex Zinin <zinin@amt.ru>
4257 * ospf_neighbor.c
4258 ospf_nbr_lookup_by_addr(): added route_unlock_node()
4259 when function returns NULL if (rn->info == NULL)
4260
42611999-08-29 Alex Zinin <zinin@amt.ru>
4262 * ospfd.c
4263 added a hack for area range deletion
4264
42651999-08-29 Alex Zinin <zinin@amt.ru>
4266 * ospf_lsa.h
4267 included lsdb field into struct ospf_lsa, to find
4268 LSDB easier when removing MaxAge LSAs.
4269
42701999-08-29 Alex Zinin <zinin@amt.ru>
4271 * ospf_lsa.c ospf_neighbor.c ospf_nsm.c
4272 ospf_packet.c changed to honor new retransmit list
4273 management functions
4274
42751999-08-29 Alex Zinin <zinin@amt.ru>
4276 * ospf_neighbor.c , .h added new retransmit list functions.
4277
42781999-08-29 Alex Zinin <zinin@amt.ru>
4279 * Makefile.in
4280 added ospf_ase, ospf_abr, ospf_ia
4281
42821999-08-29 Alex Zinin <zinin@amt.ru>
4283 * ospf_spf.c:
4284 - changed ospf_next_hop_calculation() to include interface
4285 and nexthop addr for directly connected routers---more informative
4286 and solves problem with route installation into the kernel
4287 - changed ospf_nexthop_out_if_addr() to support routers, not only
4288 transit networks
4289 - added ospf_process_stubs();
4290
42911999-08-29 Alex Zinin <zinin@amt.ru>
4292 * ospf_lsa.c:
4293 - changed ospf_router_lsa() to provide correct links
4294 for p-t-p interfaces;
4295 - changed ospf_summary_lsa_install() to support table
4296 of self-originated summary-LSAs;
4297 - added ospf_summary_asbr_lsa_install() and ospf_external_lsa_install()
4298 - changed ospf_lsa_install() accordingly
4299 - changed show_ip_ospf_database_router_links() to support p-t-p
4300
43011999-08-29 Kunihiro Ishiguro <kunihiro@zebra.org>
4302
4303 * ospf_packet.c (ospf_make_db_desc): Only master can clear more
4304 flag.
4305
43061999-08-29 Kunihiro Ishiguro <kunihiro@zebra.org>
4307
4308 * ospf_packet.c (ospf_read): Add check of IP src address.
4309
43101999-08-28 Alex Zinin <zinin@amt.ru>
4311 * ospf_neighbor.h
4312 added ospf_nbr_lookup_by_routerid()
4313
43141999-08-28 Alex Zinin <zinin@amt.ru>
4315 * ospfd.h
4316 added ABR/ASBR flag definitions and fields;
4317 added iflist field to area structure;
4318 summary_lsa_self and summary_lsa_asbr_self are changed
4319 to be route tables;
4320 added ranges field---configured area ranges;
4321 A separate Routers RT added;
4322 area range config commands and config write added
4323
4324
43251999-08-28 Alex Zinin <zinin@amt.ru>
4326 * ospf_route.c :
4327 ospf_route_free()--added code to free the list of paths;
4328 The following functions added:
4329 ospf_intra_add_router();
4330 ospf_intra_add_transit();
4331 ospf_intra_add_stub();
4332 the last function uses new ospf_int_lookup_by_prefix();
4333 show_ip_ospf_route_cmd()--changed to support new RT structure;
4334 added ospf_cmp_routes()--general route comparision function;
4335 added ospf_route_copy_nexthops() and ospf_route_copy_nexthops_from_vertex()
4336 they are used in ASE and IA routing;
4337 added ospf_subst_route() and ospf_add_route();
4338
43391999-08-28 Alex Zinin <zinin@amt.ru>
4340 * ospf_route.h :
4341 changed struct ospf_path to include output interface,
4342 changed struct ospf_route to support IA and ASE routing.
4343 added prototypes of the function used in IA and ASE modules.
4344
43451999-08-28 Alex Zinin <zinin@amt.ru>
4346 * ospf_lsa.h ospf_lsa.c :
4347 added ospf_my_lsa(), an interface independent version of
4348 ospf_lsa_is_self_originated(), it will be used in ASE and IA-routing.
4349
43501999-08-27 Kunihiro Ishiguro <kunihiro@zebra.org>
4351
4352 * ospf_interface.c (interface_config_write): Add check for
4353 oi->nbr_self.
4354
43551999-08-25 Toshiaki Takada <takada@zebra.org>
4356
4357 * ospf_lsa.c (ospf_lsa_dup): New function added.
4358
4359 * ospf_packet.c (ospf_write), (ospf_read): Print send/recv
4360 interface in debug message.
4361
43621999-08-25 Toshiaki Takada <takada@zebra.org>
4363
4364 * ospf_packet.c (ospf_ls_ack_send): The name is changed from
4365 `ospf_ls_ack_send'.
4366 (ospf_ls_ack_send_delayed) (ospf_ls_ack_timer): New function added.
4367 Delayed Link State Acknowledgment is scheduled by timer.
4368
43691999-08-25 Alex Zinin <zinin@amt.ru>
4370
4371 * ospf_lsa.c (ospf_router_lsa): Incorrectly included link to
4372 a stub network instead of link to a transit network into
4373 originated router-LSA, bug fixed.
4374
43751999-08-24 Toshiaki Takada <takada@zebra.org>
4376
4377 * ospfd.c (ospf_update_router_id): New function added.
4378
4379 * ospf_network.c (ospf_write): Create new socket per transmission.
4380 And select outgoing interface whether dst is unicast or multicast.
4381
4382 * ospf_packet.c: LSA flooding will work.
4383
43841999-08-24 VOP <vop@unity.net>
4385
4386 * ospf_route.c: Include "sockunion.h"
4387
43881999-08-24 Kunihiro Ishiguro <kunihiro@zebra.org>
4389
4390 * ospf_network.c (ospf_serv_sock_init): Enclose
4391 IPTOS_PREC_INTERNETCONTROL setting with #ifdef for OS which does
4392 not have the definition.
4393
43941999-08-23 Toshiaki Takada <takada@zebra.org>
4395
4396 * ospf_packet.c: Fix bug of DD processing.
4397
43981999-08-18 Toshiaki Takada <takada@zebra.org>
4399
4400 * ospf_lsa.c (show_ip_ospf_database): Show actual `LS age'.
4401
44021999-08-17 Toshiaki Takada <takada@zebra.org>
4403
4404 * ospf_lsa.h (OSPF_MAX_LSA): The value of OSPF_MAX_LSA is
4405 corrected. The bug of `mes_lookup' is fixed.
4406 This had been reported by Poul-Henning Kamp <phk@freebsd.org>.
4407
4408 * ospf_lsa.c (ospf_router_lsa_install): The name is changed from
4409 `ospf_add_router_lsa'.
4410 (ospf_network_lsa_install): The name is changed from
4411 `ospf_add_network_lsa'.
4412
4413 * ospf_interface.h (ospf_interface): Add member `nbr_self'.
4414
4415 * ospf_interface.c (ospf_if_is_enable): New function added.
4416
44171999-08-16 Toshiaki Takada <takada@zebra.org>
4418
4419 * ospf_lsa.h (struct lsa_header): The name is changed from
4420 `struct ospf_lsa'.
4421 (struct ospf_lsa): New struct added to control each LSA's aging
4422 and timers.
4423
4424 * ospf_lsa.c (ospf_lsa_data_free): The name is change from
4425 `ospf_lsa_free'.
4426 (ospf_lsa_data_new), (ospf_lsa_new), (ospf_lsa_free),
4427 (ospf_lsa_different), (ospf_lsa_install): New function added.
4428
4429 * ospf_packet.c (ospf_ls_upd_list_lsa): New function added.
4430
44311999-08-12 Toshiaki Takada <takada@zebra.org>
4432
4433 * ospf_nsm.c (nsm_reset_nbr): New function added.
4434 KillNbr and LLDown neighbor event call this function.
4435
44361999-08-10 Toshiaki Takada <takada@zebra.org>
4437
4438 * ospf_packet.c (ospf_ls_retransmit)
4439 (ospf_ls_upd_timer): New function added.
4440 Set retransmission timer for Link State Update.
4441
44421999-07-29 Toshiaki Takada <takada@zebra.org>
4443
4444 * ospf_ism.c (ospf_dr_election): Fix bug of DR election.
4445
44461999-07-28 Toshiaki Takada <takada@zebra.org>
4447
4448 * ospf_network.c (ospf_serv_sock_init): Set IP precedence field
4449 with IPTOS_PREC_INTERNET_CONTROL.
4450
4451 * ospf_nsm.c (nsm_change_status): Schedule NeighborChange event
4452 if NSM status change.
4453
4454 * ospf_packet.c (ospf_make_hello): Never include a neighbor in
4455 Hello packet, when the neighbor goes down.
4456
44571999-07-26 Kunihiro Ishiguro <kunihiro@zebra.org>
4458
4459 * Makefile.am (noinst_HEADERS): Add ospf_route.h.
4460
4461 * ospf_route.c (show_ip_ospf_route): Add `show ip ospf route'
4462 command.
4463
44641999-07-25 Toshiaki Takada <takada@zebra.org>
4465
4466 * ospf_lsa.c (ospf_router_lsa): Fix bug of LS sequence number
4467 assignement.
4468
44691999-07-25 Kunihiro Ishiguro <kunihiro@zebra.org>
4470
4471 * ospf_route.c (ospf_route_table_free): New function added.
4472
4473 * ospf_spf.c (ospf_spf_next): Free vertex w when cw's and w's
4474 distance is same.
4475
4476 * ospfd.h (struct ospf): Add old_table.
4477
4478 * ospf_main.c (sighup): Call of log_rotate () removed.
4479
4480 * ospf_lsa.c (ospf_lsa_is_self_originated): Fix bug of checking
4481 area->lsa as self LSA. This should be area->lsa_self.
4482
44831999-07-24 Kunihiro Ishiguro <kunihiro@zebra.org>
4484
4485 * ospf_zebra.c (ospf_zebra_add): ospf_zebra_add
4486 (),ospf_zebra_delete () added.
4487
4488 * ospf_spf.c (ospf_spf_calculate): Call ospf_intra_route_add ().
4489
44901999-07-24 Toshiaki Takada <takada@zebra.org>
4491
4492 * ospf_lsa.c: Change LS sequence number treatment.
4493 (ospf_lsa_is_self_originated): New function added.
4494 (show_ip_ospf_database_self_originated): New DEFUN added.
4495
44961999-07-23 Kunihiro Ishiguro <kunihiro@zebra.org>
4497
4498 * ospf_interface.c (ospf_if_lookup_by_addr): Add loopback check.
4499
45001999-07-22 Toshiaki Takada <takada@zebra.org>
4501
4502 * ospf_spf.c (ospf_nexthop_new), (ospf_nexthop_free),
4503 (ospf_nexthop_dup): function added.
4504 (ospf_nexthop_calculation): function changed.
4505
4506 * ospf_interface.c (ospf_if_lookup_by_addr): function added.
4507
45081999-07-21 Toshiaki Takada <takada@zebra.org>
4509
4510 * ospf_spf.c (ospf_spf_closest_vertex): function removed.
4511
45121999-07-21 Kunihiro Ishiguro <kunihiro@zebra.org>
4513
4514 * ospf_spf.c (ospf_spf_next): Apply ntohs for fetching metric.
4515
45161999-07-21 Toshiaki Takada <takada@zebra.org>
4517
4518 * ospf_neighbor.c (ospf_nbr_lookup_by_router_id): fundtion removed.
4519
4520 * ospf_lsa.c (show_ip_ospf_database_router): describe each
4521 connected link.
4522
45231999-07-21 Kunihiro Ishiguro <kunihiro@zebra.org>
4524
4525 * ospf_spf.c (ospf_spf_next): V is router LSA or network LSA so
4526 change behavior according to LSA type.
4527 (ospf_lsa_has_link): Link check function is added.
4528
45291999-07-20 Kunihiro Ishiguro <kunihiro@zebra.org>
4530
4531 * ospf_spf.c (ospf_spf_calculate_schedule): Add new function for
4532 SPF calcultion schedule addtition.
4533 (ospf_spf_calculate_timer_add): Rough 30 sec interval SPF calc
4534 timer is added.
4535 (ospf_spf_next_router): Delete ospf_spf_next_network ().
4536
4537 * ospf_lsa.c (show_ip_ospf_database_all): Network-LSA display
4538 header typo correction. Display of router LSA's #link added.
4539
45401999-07-19 Toshiaki Takada <takada@zebra.org>
4541
4542 * ospf_packet.c (ospf_check_network_mask): Added new function for
4543 receiving Raw IP packet on an appropriate interface.
4544
45451999-07-16 Toshiaki Takada <takada@zebra.org>
4546
4547 * ospfd.c (ospf_router_id): new DEFUN added.
4548
45491999-07-15 Toshiaki Takada <takada@zebra.org>
4550
4551 * ospf_spf.c (ospf_spf_init), (ospf_spf_free),
4552 (ospf_spf_has_vertex), (ospf_vertex_lookup),
4553 (ospf_spf_next_router), (ospf_spf_next_network),
4554 (ospf_spf_closest_vertex), (ospf_spf_calculate):
4555 function added.
4556
45571999-07-13 Toshiaki Takada <takada@zebra.org>
4558
4559 * ospf_ism.c: fix bug of DR Election.
4560
4561 * ospf_nsm.c: fix bug of adjacency forming.
4562
45631999-07-05 Kunihiro Ishiguro <kunihiro@zebra.org>
4564
4565 * ospfd.c (ospf_init): Change to use install_default.
4566
45671999-07-01 Rick Payne <rickp@rossfell.co.uk>
4568
4569 * ospf_zebra.c (zebra_init): Install standard commands to
4570 ZEBRA_NODE.
4571
45721999-06-30 Toshiaki Takada <takada@zebra.org>
4573
4574 * ospf_dump.c: Whole debug command is improved.
4575 (ISM|NSM) (events|status|timers) debug option added.
4576 (show_debugging_ospf): new DEFUN added.
4577
45781999-06-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4579
4580 * ospf_lsa.c (ospf_lsa_lookup_from_list): Change !IPV4_ADDR_CMP to
4581 IPV4_ADDR_SAME.
4582
45831999-06-29 Toshiaki Takada <takada@zebra.org>
4584
4585 * ospf_dump.c (ospf_summary_lsa_dump): Add summary-LSA dump routine.
4586 (ospf_as_external_lsa_dump): Add AS-external-LSA dump routine.
4587
4588 * ospf_nsm.c (nsm_twoway_received): fix condtion of adjacnet.
4589
4590 * ospf_ism.c (ospf_dr_election): fix DR Election.
4591
4592 * ospf_dump.c (ospf_nbr_state_message): fix `show ip ospf neighbor'
4593 command's state.
4594
45951999-06-29 Kunihiro Ishiguro <kunihiro@zebra.org>
4596
4597 * ospf_dump.c (ospf_router_lsa_dump): Add router-LSA dump routine.
4598
45991999-06-28 Toshiaki Takada <takada@zebra.org>
4600
4601 * ospf_lsa.c (show_ip_ospf_database_network): fix bug of
4602 `show ip ospf database network' command output.
4603
4604 * ospf_nsm.c (nsm_inactivity_timer): Clear list of Link State
4605 Retransmission, Database Summary and Link State Request.
4606
4607 * ospf_packet.c (ospf_ls_req_timer): New function added.
4608 Set Link State Request retransmission timer.
4609
46101999-06-27 Kunihiro Ishiguro <kunihiro@zebra.org>
4611
4612 * ospf_main.c (main): Change default output from ZLOG_SYSLOG to
4613 ZLOG_STDOUT.
4614
4615 * ospfd.c (ospf_init): Register show_ip_ospf_interface_cmd and
4616 show_ip_ospf_neighbor_cmd to VIEW_NODE.
4617
4618 * ospf_lsa.c (ospf_lsa_init): Register show_ip_ospf_database_cmd
4619 and show_ip_ospf_database_type_cmd to VIEW_NODE.
4620
46211999-06-25 Toshiaki Takada <takada@zebra.org>
4622
4623 * ospf_packet.c: fix bug of DD making.
4624 fix bug of LS-Update reading.
4625
46261999-06-23 Toshiaki Takada <takada@zebra.org>
4627
4628 * ospf_packet.c: All type of packets are changed to use
4629 fifo queue structure.
4630 (ospf_fill_header) function added.
4631
46321999-06-22 Toshiaki Takada <takada@zebra.org>
4633
4634 * ospf_packet.c (ospf_packet_new): New function added to handle
4635 sending ospf packet by fifo queue structure.
4636 (ospf_packet_free), (ospf_fifo_new), (ospf_fifo_push),
4637 (ospf_fifo_pop), (ospf_fifo_head), (ospf_fifo_flush),
4638 (ospf_fifo_free): Likewise.
4639
46401999-06-21 Toshiaki Takada <takada@zebra.org>
4641
4642 * ospf_nsm.c (ospf_db_desc_timer): function added.
4643 (nsm_timer_set) function added.
4644 * ospf_dump.c (ospf_option_dump): function added.
4645 * ospf_packet.c (ospf_ls_req) (ospf_make_ls_req): function added.
4646
46471999-06-20 Toshiaki Takada <takada@zebra.org>
4648
4649 * ospf_lsa.c (ospf_lsa_more_recent): function added.
4650 * ospf_neighbor.h (struct ospf_neighbor): Change member ms_flag
4651 to dd_flags.
4652
46531999-06-19 Toshiaki Takada <takada@zebra.org>
4654
4655 * ospf_lsa.c: DEFUN (show_ip_ospf_database) Added.
4656 * ospf_interface.c (if_ospf_cost), (if_ospf_dead_interval),
4657 (if_ospf_hello_interval), (if_ospf_priority),
4658 (if_ospf_retransmit_interval), (if_ospf_transmit_delay)
4659 argument changed from NUMBER to <range>.
4660 DEFUN (if_ospf_network_broadcast),
4661 DEFUN (if_ospf_network_non_broadcast),
4662 DEFUN (if_ospf_network_point_to_multipoint),
4663 DEFUN (if_ospf_network_point_to_point) functions are combined to
4664 DEFUN (if_ospf_network).
4665
46661999-06-18 Toshiaki Takada <takada@zebra.org>
4667
4668 * ospf_lsa.c: ospf_add_router_lsa (), ospf_add_network_lsa (),
4669 ospf_lsa_lookup (), ospf_lsa_count () Added.
4670
46711999-06-15 Toshiaki Takada <takada@zebra.org>
4672
4673 * DEFUN (ospf_debug_ism), DEFUN (ospf_debug_nsm),
4674 DEFUN (no_ospf_debug_ism), DEFUN (no_ospf_debug_nsm) Added.
4675 `debug ospf ism' command shows debug message.
4676 `debuf ospf nsm' command shows debug message.
4677
46781999-06-14 Toshiaki Takada <takada@zebra.org>
4679
4680 * ospf_lsa.c: ospf_network_lsa () Added.
4681 ospf_lsa_checksum () Added.
4682 * DEFUN (ospf_debug_packet), DEFUN (no_ospf_debug_packet) Added.
4683 `debug ospf packet' command shows debug message.
4684
46851999-06-13 Toshiaki Takada <takada@zebra.org>
4686
4687 * ospf_packet.h: Remove struct ospf_ls_req {}, ospf_ls_upd {},
4688 ospf_ls_ack {}.
4689
46901999-06-11 Toshiaki Takada <takada@zebra.org>
4691
4692 * ospf_dump.c: fix IP packet length treatment.
4693
46941999-06-10 Toshiaki Takada <takada@zebra.org>
4695
4696 * ospf_ism.h: Add OSPF_ISM_EVENT_EXECUTE() Macro Added.
4697 * ospf_nsm.h: Add OSPF_NSM_EVENT_EXECUTE() Macro Added.
4698
4699 * ospf_packet.c: ospf_db_desc (), ospf_db_desc_send () Added.
4700 ospf_make_hello (), ospf_make_db_desc () Added.
4701 ospf_db_desc_proc () Added.n
4702
4703 * Database Description packet can be processed.
4704
47051999-06-08 Toshiaki Takada <takada@zebra.org>
4706
4707 * ospf_lsa.c: New file.
4708
47091999-06-07 Toshiaki Takada <takada@zebra.org>
4710
4711 * ospf_neighbor.c: ospf_fully_adjacent_count () Added.
4712
47131999-06-07 Kunihiro Ishiguro <kunihiro@zebra.org>
4714
4715 * ospf_spf.[ch]: New file.
4716
47171999-05-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4718
4719 * ospf_zebra.c: Changed to use lib/zclient.c routines.
4720
4721 * ospf_zebra.h (zebra_start): Remove struct zebra.
4722
47231999-05-29 Kunihiro Ishiguro <kunihiro@zebra.org>
4724
4725 * ospfd.c (ospf_config_write): Add cast (unsigned long int) to
4726 ntohl for sprintf warning.
4727
47281999-05-19 Toshiaki Takada <takada@zebra.org>
4729
4730 * ospf_ism.c (ospf_dr_election): Join AllDRouters Multicast group
4731 if interface state changes to DR or BDR.
4732
47331999-05-14 Stephen R. van den Berg <srb@cuci.nl>
4734
4735 * ospf_main.c (signal_init): SIGTERM call sigint.
4736 (sigint): Logging more better message.
4737
47381999-05-12 Toshiaki Takada <takada@zebra.org>
4739
4740 * ospfd.c: Fix bug of `no router ospf' statement, it will work.
4741
47421999-05-11 Toshiaki Takada <takada@zebra.org>
4743
4744 * ospf_neighbor.c: ospf_nbr_free () Added.
4745
47461999-05-10 Toshiaki Takada <takada@zebra.org>
4747
4748 * ospfd.h: struct ospf_area { }, struct ospf_network { } Changed.
4749 * Fix bug of `no network' statement, it will work.
4750
47511999-05-07 Toshiaki Takada <takada@zebra.org>
4752
4753 * ospf_interface.c, ospf_zebra.c: Fix bug of last interface is not
4754 updated by ospf_if_update ().
4755
47561999-04-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4757
4758 * Makefile.am (noinst_HEADERS): Add ospf_lsa.h for distribution.
4759
47601999-04-25 Toshiaki Takada <takada@zebra.org>
4761
4762 * ospf_interface.c: DEFUN (no_if_ospf_cost),
4763 DEFUN (no_if_ospf_dead_interval),
4764 DEFUN (no_if_ospf_hello_interval),
4765 DEFUN (no_if_ospf_priority),
4766 DEFUN (no_if_ospf_retransmit_interval),
4767 DEFUN (no_if_ospf_transmit_delay) Added.
4768
4769 interface_config_write () suppress showing interface
4770 default values.
4771
47721999-04-25 Kunihiro Ishiguro <kunihiro@zebra.org>
4773
4774 * ospf_dump.c (ospf_timer_dump): If thread is NULL return "inactive".
4775
4776 * ospfd.c (ospf_if_update): Fix bug of using ospf_area { } instead
4777 of ospf_network { }. So `router ospf' statement in ospfd.conf
4778 works again.
4779 (ospf_if_update): Call ospf_get_router_id for updating router ID.
4780
47811999-04-25 Toshiaki Takada <takada@zebra.org>
4782
4783 * ospf_interface.c: DEFUN (if_ospf_network) deleted.
4784 DEFUN (if_ospf_network_broadcast),
4785 DEFUN (if_ospf_network_non_broadcast),
4786 DEFUN (if_ospf_network_point_to_multipoint),
4787 DEFUN (if_ospf_network_point_to_point),
4788 DEFUN (no_if_ospf_network) Added.
4789
47901999-04-23 Toshiaki Takada <takada@zebra.org>
4791
4792 * ospfd.h: struct area { } changed to struct ospf_network { }.
4793 Add struct ospf_area { }.
4794 * ospfd.c: Add ospf_area_lookup_by_area_id (), ospf_network_new (),
4795 and ospf_network_free ().
4796 DEFUN (area_authentication), DEFUN (no_area_authentication) Added.
4797
47981999-04-22 Toshiaki Takada <takada@zebra.org>
4799
4800 * ospf_lsa.h: New file.
4801 * ospf_packet.h: LSA related struct definition are moved to
4802 ospf_lsa.h.
4803 * ospf_packet.c: ospf_verify_header () Added.
4804
48051999-04-21 Toshiaki Takada <takada@zebra.org>
4806
4807 * ospf_ism.c: ospf_elect_dr () and related function is changed.
4808 DR Election bug fixed.
4809 * ospf_dump.c: ospf_nbr_state_message (), ospf_timer_dump () Added.
4810 * ospfd.c: DEFUN (show_ip_ospf_neighbor) Added.
4811
48121999-04-19 Kunihiro Ishiguro <kunihiro@zebra.org>
4813
4814 * ospf_main.c (main): access_list_init () is added for vty
4815 connection filtering.
4816
48171999-04-16 Toshiaki Takada <takada@zebra.org>
4818
4819 * ospfd.c: DEFUN (show_ip_ospf_interface) Added.
4820 * ospf_neighbor.c: ospf_nbr_count () Added.
4821
48221999-04-15 Toshiaki Takada <takada@zebra.org>
4823
4824 * ospfd.h: struct ospf { } Changed.
4825 * ospfd.c: ospf_lookup_by_process_id () Deleted.
4826 * ospf_ism.c: ospf_wait_timer () Added. WaitTimer will work.
4827
48281999-04-14 Toshiaki Takada <takada@zebra.org>
4829
4830 * ospf_ism.c: ospf_elect_dr () Added.
4831 * ospf_network.c: ospf_if_ipmulticast () Added.
4832
48331999-04-11 Toshiaki Takada <takada@zebra.org>
4834
4835 * ospf_interface.c: interface_config_write (),
4836 DEFUN (if_ip_ospf_cost),
4837 DEFUN (if_ip_ospf_dead_interval),
4838 DEFUN (if_ip_ospf_hello_interval),
4839 DEFUN (if_ip_ospf_priority),
4840 DEFUN (if_ip_ospf_retransmit_interval) and
4841 DEFUN (if_ip_ospf_transmit_delay) Added.
4842
48431999-04-08 Toshiaki Takada <takada@zebra.org>
4844
4845 * ospf_dump.c: ospf_packet_db_desc_dump () Added.
4846 * ospf_neighbor.c: ospf_nbr_bidirectional () Added.
4847 * ospf_nsm.c: nsm_twoway_received () Added.
4848
48491999-04-02 Toshiaki Takada <takada@zebra.org>
4850
4851 * ospf_neighbor.c: New file.
4852 * ospf_neighbor.h: New file.
4853 * ospf_nsm.c: New file.
4854 * ospf_nsm.h: New file.
4855 * ospf_packet.c: Add ospf_make_header (), ospf_hello () and
4856 ospf_hello_send (). Now OSPFd can receive Hello and send Hello.
4857
48581999-03-27 Kunihiro Ishiguro <kunihiro@zebra.org>
4859
4860 * ospf_packet.c: Add ospf_recv_packet (). Now OSPF Hello can receive.
4861
48621999-03-19 Toshiaki Takada <takada@zebra.org>
4863
4864 * ospf_packet.c: New file.
4865 * ospf_packet.h: New file.
4866 * ospf_network.c: New file.
4867 * ospf_network.h: New file.
4868 * ospfd.h: move OSPF message structure has moved to ospf_packet.h.
4869
48701999-03-17 Kunihiro Ishiguro <kunihiro@zebra.org>
4871
4872 * ospf_zebra.c (ospf_zebra_get_interface): Fix for IPv6 interface
4873 address.
4874
4875 * Makefile.am (install-sysconfDATA): Overwrite install-sysconfDATA
4876 for install ospfd.conf.sample as owner read only file.
4877
4878 * ospf_main.c (usage): Change to use ZEBRA_BUG_ADDRESS.
4879
48801999-03-15 Toshiaki Takada <takada@zebra.org>
4881
4882 * ospf_ism.c: New file.
4883 * ospf_ism.h: New file.
4884 * ospf_dump.c: New file.
4885 * ospf_dump.h: New file.
4886
4887 * ospfd.h: Add (struct ospf), (struct config_network),
4888 (struct message) structure.
4889
4890 * ospf_interface.c: Add ospf_if_match_network ().
4891 * ospf_interface.h (struct ospf_interface): Change struct members.
4892
4893 * ospfd.c: ospf_lookup_by_process_id (), ospf_network_new (),
4894 DEFUN (network_area): Added.
4895
4896 * ospfd.conf.sample: Change sample configuration.
4897
48981999-03-05 Toshiaki Takada <takada@zebra.org>
4899
4900 * ospf_interface.c: New file.
4901 * ospf_interface.h: New file.
4902 * ospf_zebra.h: New file.
4903 * ospf_zebra.c: Add interface function for zebra daemon.
4904 * ospfd.c: New file.
4905
49061999-02-23 Kunihiro Ishiguro <kunihiro@zebra.org>
4907
4908 * Move IPv6 codes and files to ospf6d directory.
4909
49101999-02-18 Peter Galbavy <Peter.Galbavy@knowledge.com>
4911
4912 * syslog support added
4913
49141998-12-22 Toshiaki Takada <takada@zebra.org>
4915
4916 * ospfd.h: New file.
4917 * ospf_lsa.h: New file.
4918
49191998-12-15 Kunihiro Ishiguro <kunihiro@zebra.org>
4920
4921 * Makefile.am: New file.
4922 * ospf_main.c: New file.
4923