blob: f3b6a8c1873456a066f13a1a6e54c38ac214ee19 [file] [log] [blame]
Paul Jakma693b67b2008-03-13 03:31:24 +000012008-03-13 Paul Jakma <paul.jakma@sun.com>
2
3 * (various) Remove 0 entries from struct message's, unneeded due to
4 recent improvements in mes_lookup/LOOKUP.
5
Paul Jakma90b68762008-01-29 17:26:34 +000062008-01-29 Jorge Boncompte <jorge@dti2.net>
7
8 * bgp_network.c: (bgp_socket) IPv4-only version crashes if -l is not
9 used as address will be null.
10
Paul Jakma370b64a2007-12-22 16:49:52 +0000112007-12-22 Paul Jakma <paul.jakma@sun.com>
12
13 * Fix series of vulnerabilities reported by "Mu Security
14 Research Team", where bgpd can be made to crash by sending
15 malformed packets - requires that bgpd be configured with a
16 session to the peer.
17 * bgp_attr.c: (bgp_attr_as4_path) aspath_parse may fail, only
18 set the attribute flag indicating AS4_PATH if we actually managed
19 to parse one.
20 (bgp_attr_munge_as4_attrs) Assert was too general, it is possible
21 to receive AS4_AGGREGATOR before AGGREGATOR.
22 (bgp_attr_parse) Check that we have actually received the extra
23 byte of header for Extended-Length attributes.
24 * bgp_attr.h: Fix BGP_ATTR_MIN_LEN to account for the length byte.
25 * bgp_open.c: (cap_minsizes) Fix size of CAPABILITY_CODE_RESTART,
26 incorrect -2 left in place from a development version of as4-path
27 patch.
28 * bgp_packet.c: (bgp_route_refresh_receive) ORF length parameter
29 needs to be properly sanity checked.
30
Denis Ovsienkoa7f93f32007-12-18 15:13:06 +0000312007-12-18 Denis Ovsienko
32
33 * bgp_routemap.c: (no_set_aspath_prepend) This command cancelled
34 existing "set" command regardless if "no set" matched it or not.
35 Fixed.
36
Paul Jakma7e992e92007-11-13 09:32:23 +0000372007-11-13 Paul Jakma <paul.jakma@sun.com>
38
39 * bgp_main.c: Small fix, format string parameters should never
40 be NULL - it's not strictly valid and some libc's don't let
41 you away with.
42
Paul Jakma3a02d1f2007-11-01 14:29:11 +0000432007-10-30 Nick Hilliard <nick@inex.ie>
44
45 * bgp_main.c: Add 'listenon' argument, to pass address to bind
46 to.
47 * bgp_network.c: (bgp_socket) Extend to take bind address.
48 * bgpd.c: (bgp_init) Pass stored address.
49 * bgpd.h: (struct bgp_master) storage for bind address
50
Paul Jakma0b2aa3a2007-10-14 22:32:21 +0000512007-09-27 Paul Jakma <paul.jakma@sun.com>
52
53 * bgp_aspath.c: (assegment_normalise) remove duplicates from
54 from sets.
55 (aspath_reconcile_as4) disregard a broken part of the RFC around
56 error handling in path reconciliation.
57
582007-09-25 Paul Jakma <paul.jakma@sun.com>
59
60 * bgp_open.c: (peek_for_as4_capability) Fix to work.
61 * bgp_packet.c: (bgp_open_receive) Fix sanity check of as4.
62
632007-09-18 Paul Jakma <paul.jakma@sun.com>
64
65 * bgp_open.c: (bgp_capability_as4) debug printf inline with others.
66 (peek_for_as4_capability) There's no need to signal failure, as
67 failure is better dealt with through full capability parser -
68 just return the AS4, simpler.
69 * bgp_packet.c: (bgp_open_receive) Update to match
70 peek_for_as4_capability change.
71 Allow use of BGP_AS_TRANS by 2b speakers.
72 Use NOTIFY_OPEN_ERR rather than CEASE for OPEN parsing errors.
73 (bgp_capability_msg_parse) missing argument to debug print
74 (bgp_capability_receive) missing return values.
75
76
772007-07-25 Paul Jakma <paul.jakma@sun.com>
78
79 * Remove 2-byte size macros, just make existing macros take
80 argument to indicate which size to use.
81 Adjust all users - typically they want '1'.
82 * bgp_aspath.c: (aspath_has_as4) New, return 1 if there are any
83 as4's in a path.
84 (aspath_put) Return the number of bytes actually written, to
85 fix the bug Juergen noted: Splitting of segments will change
86 the number of bytes written from that already written to the
87 AS_PATH header.
88 (aspath_snmp_pathseg) Pass 2-byte flag to aspath_put. SNMP
89 is still defined as 2b.
90 (aspath_aggregate) fix latent bug.
91 (aspath_reconcile_as4) AS_PATH+NEW_AS_PATH reconciliation
92 function.
93 (aspath_key_make) Hash the AS_PATH string, rather than
94 just taking the addition of assegment ASes as the hash value,
95 hopefully sligthly more collision resistant.
96 (bgp_attr_munge_as4_attrs) Collide the NEW_ attributes
97 together with the OLD 2-byte forms, code Juergen
98 had in bgp_attr_parse but re-organised a bit.
99 (bgp_attr_parse) Bunch of code from Juergen moves
100 to previous function.
101 (bgp_packet_attribute) Compact significantly by
102 just /always/ using extended-length attr header.
103 Fix bug Juergen noted, by using aspath_put's
104 (new) returned size value for the attr header rather
105 than the (guesstimate) of aspath_size() - the two could
106 differ when aspath_put had to split large segments, unlikely
107 this bug was ever hit in the 'wild'.
108 (bgp_dump_routes_attr) Always use extended-len and
109 use aspath_put return for header length. Output 4b ASN
110 for AS_PATH and AGGREGATOR.
111 * bgp_ecommunity.c: (ecommunity_{hash_make,cmp}) fix
112 hash callback declarations to match prototypes.
113 (ecommunity_gettoken) Updated for ECOMMUNITY_ENCODE_AS4,
114 complete rewrite of Juergen's changes (no asdot support)
115 * bgp_open.c: (bgp_capability_as4) New, does what it says
116 on the tin.
117 (peek_for_as4_capability) Rewritten to use streams and
118 bgp_capability_as4.
119 * bgp_packet.c: (bgp_open_send) minor edit
120 checked (in the abstract at least) with Juergen.
121 Changes are to be more accepting, e.g, allow AS_TRANS on
122 a 2-byte session.
123 * (general) Update all commands to use CMD_AS_RANGE.
124 * bgp_vty.c: (bgp_clear) Fix return vals to use CMD_..
125 Remove stuff replicated by VTY_GET_LONG
126 (bgp_clear_vty) Return bgp_clear directly to vty.
127
128
1292007-07-25 Juergen Kammer <j.kammer@eurodata.de>
130
131 * (general) AS4 support.
132 * bgpd.h: as_t changes to 4-bytes.
133 * bgp_aspath.h: Add BGP_AS4_MAX and BGP_AS_TRANS defines.
134 * bgp_aspath.c: AS_VALUE_SIZE becomes 4-byte, AS16_VALUE_SIZE
135 added for 2-byte.
136 Add AS16 versions of length calc macros.
137 (aspath_count_numas) New, count number of ASes.
138 (aspath_has_as4) New, return 1 if there are any as4's in a
139 path.
140 (assegments_parse) Interpret assegment as 4 or 2 byte,
141 according to how the caller instructs us, with a new
142 argument.
143 (aspath_parse) Add use32bit argument to pass to
144 assegments_parse. Adjust all its callers to pass 1, unless
145 otherwise noted.
146 (assegment_data_put) Adjust to be able to write 2 or 4 byte
147 AS, according to new use32bit argument.
148 (aspath_put) Adjust to write 2 or 4.
149 (aspath_gettoken) Use a long for passed in asno.
150 * bgp_attr.c: (attr_str) Add BGP_ATTR_AS4_PATH and
151 BGP_ATTR_AS4_AGGREGATOR.
152 (bgp_attr_aspath) Call aspath_parse with right 2/4 arg, as
153 determined by received-capability flag.
154 (bgp_attr_aspath_check) New, code previously in attr_aspath
155 but moved to new func so it can be run after NEW_AS_PATH
156 reconciliation.
157 (bgp_attr_as4_path) New, handle NEW_AS_PATH.
158 (bgp_attr_aggregator) Adjust to cope with 2/4 byte ASes.
159 (bgp_attr_as4_aggregator) New, read NEW_AGGREGATOR.
160 (bgp_attr_parse) Add handoffs to previous parsers for the two
161 new AS4 NEW_ attributes.
162 Various checks added for NEW/OLD reconciliation.
163 (bgp_packet_attribute) Support 2/4 for AS_PATH and
164 AGGREGATOR, detect when NEW_ attrs need to be sent.
165 * bgp_debug.{c,h}: Add 'debug bgp as4'.
166 * bgp_dump.c: MRTv2 support, unconditionally enabled, which
167 supports AS4. Based on patches from Erik (RIPE?).
168 * bgp_ecommunity.c: (ecommunity_ecom2str) ECOMMUNITY_ENCODE_AS4
169 support.
170 * bgp_open.c: (peek_for_as4_capability) New, peek for AS4
171 capability prior to full capability parsing, so we know which
172 ASN to use for struct peer lookup.
173 (bgp_open_capability) Always send AS4 capability.
174 * bgp_packet.c: (bgp_open_send) AS4 handling for AS field
175 (bgp_open_receive) Peek for AS4 capability first, and figure
176 out which AS to believe.
177 * bgp_vty.c: (bgp_show_peer) Print AS4 cap
178
Paul Jakmae08286b2007-09-18 12:11:26 +00001792007-09-17 Paul Jakma <paul.jakma@sun.com>
180
181 * bgp_open.c: (bgp_capability_mp) We were setting
182 afc_nego[safi][safi] rather than afc_nego[afi][safi], thus
183 failling to announce any non-IPv4 prefixes. Remove the extra,
184 typo-ed character.
185
Paul Jakmab2ceea12007-09-07 14:24:55 +00001862007-09-07 Paul Jakma <paul.jakma@sun.com>
187
188 * (general) bgpd can be made crash by remote peers if debug
189 bgp updates is set, due to NULL pointer dereference.
190 Reported by "Mu Security Research Team",
191 <security@musecurity.com>.
192 * bgp_attr.c: (bgp_attr_community) If community length is 0,
193 don't set the community-present attribute bit, just return
194 early.
195 * bgp_debug.c: (community_str,community_com2str) Check com
196 pointer before dereferencing.
197
Paul Jakma9eda90c2007-08-30 13:36:17 +00001982007-08-27 Paul Jakma <paul.jakma@sun.com>
199
200 * bgp_route.c: (bgp_announce_check) Fix bug #398, slight
201 modification of Vladimir Ivanov's suggested fix - to keep
202 memory alloc conditional.
203 (bgp_process_announce_selected) Don't take struct attr as
204 argument, none of the callers need it and it needlessly
205 distances allocation from use.
206 Free the extended attr, the attr itself is on the stack.
207 Fix bad indentation.
208 * bgp_attr.c: (bgp_packet_attribute) Remove incorrect assert,
209 and adjust conditional to test attr->extra, diagnosis by
210 Vladimir Ivanov in bug #398.
211
2122007-08-27 Vladimir Ivanov <wawa@yandex-team.ru>
213
214 * bgp_route.c: (bgp_announce_check_rsclient) copy of
215 ri->attr is no longer deep enough, due to addition of
216 attr->extra. It should use bgp_attr_dup, as
217 bgp_announce_check() does.
218
Paul Jakma6d134fb2007-08-23 23:22:02 +00002192007-08-23 Paul Jakma <paul.jakma@sun.com>
220
221 * bgp_regex.c: (bgp_regcomp) Pass NOSUB flag to regcomp to
222 prevent parsing of substitutions, which can have profound
223 performance effects on bgpd and are of no use to the CLI
224 anyway. How much it helps depends on the regex
225 implementation.
226
Paul Jakma41367172007-08-06 15:24:51 +00002272007-07-31 Paul Jakma <paul.jakma@sun.com>
228
229 * (general) Support for draft-ietf-idr-as-pathlimit-03.
230 * bgp_attr.h: (struct attr) Add pathlimit struct
231 bgp_attr.c: (attr_str) Add BGP_ATTR_AS_PATHLIMIT string.
232 (attrhash_key_make) tally pathlimit too
233 (attrhash_cmp) cmp pathlimit attr
234 (bgp_attr_aspathlimit) New, parse AS_PATHLIMIT attr.
235 (bgp_attr_parse) ditto
236 (bgp_packet_attribute) Write out AS_PATHLIMIT when set
237 (bgp_dump_routes_attr) ditto
238 * bgp_route.h: (struct bgp_static) Add TTL field
239 * bgp_route.c: (bgp_announce_check) Drop paths that are over
240 their hop-count TTL before sending via EBGP.
241 Mangle ASN in pathlimit for confeds/private as best we can.
242 (bgp_static_update_{rsclient,main}) Add any configure pathlimit
243 information.
244 (bgp_pathlimit_update_parents) New, update atomic-aggr setting for
245 parents of an aspathlimit'ed static.
246 (bgp_static_set) Add TTL argument, for all the 'bgp network'
247 commands.
248 Call previous for TTL changed statics.
249 (bgp_static_unset) Call pathlimit_update_parents.
250 (various bgp network commands) Add 'pathlimit <0-255>' qualifier
251 to all the various forms, bar route-map - which can set ttl
252 itself.
253 * bgp_routemap.c: (general) Add support for 'set pathlimit ttl' and
254 'match pathlimit as'.
255
Paul Jakma6d582722007-08-06 15:21:45 +00002562007-07-26 Paul Jakma <paul.jakma@sun.com>
257
258 * (general) Clean up and compact capability parsing slightly.
259 Consolidate validation of length and logging of generic TLV, and
260 memcpy of capability data, thus removing such from cap specifc
261 code (not always present or correct).
262 * bgp_open.h: Add structures for the generic capability TLV header
263 and for the data formats of the various specific capabilities we
264 support. Hence remove the badly named, or else misdefined, struct
265 capability.
266 * bgp_open.c: (bgp_capability_vty_out) Use struct capability_mp_data.
267 Do the length checks *before* memcpy()'ing based on that length
268 (stored capability - should have been validated anyway on input,
269 but..).
270 (bgp_afi_safi_valid_indices) new function to validate (afi,safi)
271 which is about to be used as index into arrays, consolidates
272 several instances of same, at least one of which appeared to be
273 incomplete..
274 (bgp_capability_mp) Much condensed.
275 (bgp_capability_orf_entry) New, process one ORF entry
276 (bgp_capability_orf) Condensed. Fixed to process all ORF entries.
277 (bgp_capability_restart) Condensed, and fixed to use a
278 cap-specific type, rather than abusing capability_mp.
279 (struct message capcode_str) added to aid generic logging.
280 (size_t cap_minsizes[]) added to aid generic validation of
281 capability length field.
282 (bgp_capability_parse) Generic logging and validation of TLV
283 consolidated here. Code compacted as much as possible.
284 * bgp_packet.c: (bgp_open_receive) Capability parsers now use
285 streams, so no more need here to manually fudge the input stream
286 getp.
287 (bgp_capability_msg_parse) use struct capability_mp_data. Validate
288 lengths /before/ memcpy. Use bgp_afi_safi_valid_indices.
289 (bgp_capability_receive) Exported for use by test harness.
290 * bgp_vty.c: (bgp_show_summary) fix conversion warning
291 (bgp_show_peer) ditto
292 * bgp_debug.h: Fix storage 'extern' after type 'const'.
293
Paul Jakma45ad5922007-07-31 17:35:36 +00002942007-07-31 Lorenzo Colitti <lorenzo@colitti.com>
295
296 * bgp_dump.c: (general) Add comments to code.
297 (bgp_dump_interval_add) remove some redundant lines.
298 (bgp_dump_set) Use enum for type argument.
299 Avoid scheduling dump twice if exact same command
300 is given twice..
301
Paul Jakma536792c2007-06-22 19:11:14 +00003022007-06-22 Paul Jakma <paul.jakma@sun.com>
303
304 * bgp_fsm.c: (struct FSM) Bug #368. TCP Errors during OpenSent
305 should cycle to Active, not to Idle or else peer bringup can
306 race and cycle Idle<->Active. Reported and fix tested by
307 Mukesh Agrawal.
308
Paul Jakmab2497022007-06-14 11:17:58 +00003092007-05-25 Paul Jakma <paul.jakma@sun.com>
310
311 * bgp_route.c: (bgp_default_originate) Sanity check added
312 previously was broken and always failed, thus this function
313 never could run, bug #370.
314
Paul Jakmafb982c22007-05-04 20:15:47 +00003152007-05-03 Paul Jakma <paul.jakma@sun.com>
Paul Jakma923de652007-04-29 18:25:17 +0000316
Paul Jakmafb982c22007-05-04 20:15:47 +0000317 * bgp_route.h: (struct info) Move less frequently used
318 fields to a lazily allocated struct info_extra.
319 Export bgp_info_extra_get
320 * bgp_route.c: (bgp_info_extra_new) allocate extra
321 (bgp_info_extra_free) Free damp info and the info_extra.
322 (bgp_info_extra_get) Retrieve the info_extra of a struct
323 info, allocating as required.
324 (generally) adjust to use info->extra
325 * bgp_damp.c: (generally) use bgp_info_extra_get to access
326 dampinfo
327 * bgp_attr.h: Move rarely allocated attributes from struct attr
328 to a struct attr_extra, for a substantial saving in size of
329 struct attr.
330 * bgp_attr.c: (bgp_attr_extra_{new,free}), new, self-explanatory.
331 (bgp_attr_extra_get) Get the attr_extra for a given struct
332 attr, allocating it if needs be.
333 (bgp_attr_dup) Shallow copy the struct attr and its attr_extra.
334 (generally) adjust to know about attr->extra.
335 * bgp_debug.c: (bgp_dump_attr) ditto
336 * bgp_vty.c: (show_bgp_memory) print attr and info extra sizes.
337 * bgp_nexthop.c: (generally) adjust to know about attr->extra
338 and info->extra.
339 * bgp_{packet,routemap,snmp,zebra}.c: ditto
340
3412007-04-22 Sebastien Tandel <sebastien@tandel.be>
Paul Jakma923de652007-04-29 18:25:17 +0000342 * bgp_advertise.c : (baa_hash_alloc, baa_hash_key, baa_hash_cmp)
343 conforms to quagga hash API. Defines _hash_[alloc|key|cmp] with
344 void * arguments as defined by the API.
345 * bgp_aspath.c,h : (aspath_key_make) conforms to quagga hash API.
346 Defines _hash_[alloc|key|cmp] with void * arguments as defined by
347 the API.
348 * bgp_attr.c,h : (cluster_hash_alloc, cluster_hash_key_make,
349 cluster_hash_cmp, transit_hash_alloc, transit_hash_key_make,
350 transit_hash_cmp, attrhash_key_make, attrhash_cmp,
351 bgp_attr_hash_alloc) conforms to quagga hash API. Defines
352 _hash_[alloc|key|cmp] with void * arguments as defined by the API.
Paul Jakma03e214c2007-04-29 18:31:07 +0000353 * bgp_attr.h : Definition of BGP_ATTR_DEFAULT_WEIGHT.
354 * bgp_attr.c : (bgp_attr_default_intern) now uses
355 bgp_attr_default_set instead of duplicating the same code.
356 (general) Use of BGP_ATTR_DEFAULT_WEIGHT. Replace two 16 by
357 IPV6_MAX_BYTELEN.
Paul Jakma923de652007-04-29 18:25:17 +0000358
Andrew J. Schorr93c17492007-04-15 19:17:24 +00003592007-04-15 Sebastien Tandel <sebastien@tandel.be>
360
361 * bgp_aspath.c: (aspath_as_add, aspath_segment_add) Minor performance
362 optimization: while loop should test one pointer instead of two.
363
Paul Jakma16d2e242007-04-10 19:32:10 +00003642007-04-08 Paul Jakma <paul.jakma@sun.com>
365
366 * bgp_route.c: (general) Same bug as fixed on 2006-11-28 by ajs for
367 bgp static routes, but for main BGP RIB: Quick 'flap' of routes
368 can cause bgpd to mistake a new route for a duplicate route,
369 due to presence of removed, but not yet processed BGP RIB entry.
370 (bgp_update_rsclient) Ignore REMOVED bgp_info for duplicate,
371 restore route instead.
372 (bgp_update_main) Ditto.
Paul Jakma6e4ab122007-04-10 19:36:48 +0000373 * bgp_attr.c: (general) Bug #354: parsing of MP_REACH_NLRI and
374 MP_UNREACH_NLRI does not take sufficient care to ensure reads
375 from stream buffer stay in-bounds. Hence bgpd may attempt to read
376 beyond end of stream, if given a crafted packet. As it uses the
377 stream access methods to do so, this will typically result in
378 assert() being hit in stream.c. Where code is compiled without
379 assert() enabled, result is unknown.
380 (struct message attr_str) should be static.
381 (bgp_mp_reach_parse) Carefully check length remaining in stream
382 against amount desired to read from stream, prior to each read,
383 particularly where lengths are conditional on data obtained from
384 stream - using STREAM_READABLE.
385 Remove code to parse SNPA-number, it's a defunct field and changed
386 to a fixed size in latest BGP MP update RFC - log warning if
387 SNPA-number is not 0.
388 (bgp_mp_unreach_parse) Check withdraw_length carefully against
389 STREAM_READABLE.
390 (bgp_attr_parse) If attribute-parser function returns error, log
391 warning.
392 Log attribute type on mismatch.
Paul Jakma16d2e242007-04-10 19:32:10 +0000393
Paul Jakma37a217a2007-04-10 19:20:29 +00003942007-04-07 Paul Jakma <paul.jakma@sun.com>
395
396 * bgpd.c: (general) Fix bug #352
397 (bgp_config_write_family_header) write ipv6/multicast
398 address family header.
399 (bgp_config_write) write out ipv6 multicast AF config.
400
Paul Jakmaf2c31ac2007-02-22 17:48:42 +00004012007-02-22 Paul Jakma <paul.jakma@sun.com>
402
403 * bgp_fsm.c: (bgp_fsm_change_status) Handle state change into
404 clearing or greater here. Simpler.
405 (bgp_event) Clearing state change work moved to previous
406 * bgp_route.c: (bgp_clear_route_node) Clearing adj-in here
407 is too late, as it leaves a race between a peer being deleted
408 and an identical peer being configured before clearing
409 completes, leading to a crash.
410 Simplest fix is to clean peers Adj-in up-front, rather than
411 queueing such work.
412 (bgp_clear_route_table) Clear peer's Adj-In and Adj-Out
413 up-front here, rather than queueing such work.
414 Extensive comment added on the various bits of indexed data
415 that exist and how they need to be dealt with.
416 (bgp_clear_route) Update comment.
417
Andrew J. Schorre4529632006-12-12 19:18:21 +00004182006-12-12 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
419
420 * bgp_nexthop.c: (bgp_connected_add, bgp_connected_delete)
421 Simplify logic by using new CONNECTED_PREFIX macro.
422
Paul Jakma95fdcd82006-12-08 00:31:22 +00004232006-12-07 Paul Jakma <paul.jakma@sun.com>
424
425 * bgp_fsm.c: Bug #302 fix, diagnosis, suggestions and testing
426 by Juergen Kammer <j.kammer@eurodata.de>. Fix follows from
427 his suggested fix, just made in a slightly different way.
428 (bgp_event) Transitions into Clearing always must call
429 bgp_clear_route_all().
430 (bgp_stop) No need to clear routes here, BGP FSM should do
431 it.
432
Andrew J. Schorra39275d2006-11-30 16:36:57 +00004332006-11-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
434
435 * bgp_debug.h: Declare new bgp_debug_zebra conf and term flags,
436 and define BGP_DEBUG_ZEBRA.
437 * bgp_debug.c: Declare conf_bgp_debug_zebra and term_bgp_debug_zebra.
438 (debug_bgp_zebra, no_debug_bgp_zebra, undebug_bgp_zebra) New
439 functions to enable/disable bgp zebra debugging.
440 (no_debug_bgp_all) Turn off zebra debugging.
441 (show_debugging_bgp) Show whether zebra debugging is on.
442 (bgp_config_write_debug) Add 'debug bgp zebra' if configured.
443 (bgp_debug_init) Add new zebra debugging commands.
444 * bgp_zebra.c: (bgp_router_id_update, bgp_interface_add,
445 bgp_interface_delete, bgp_interface_up, bgp_interface_down,
446 bgp_interface_address_add, bgp_interface_address_delete,
447 zebra_read_ipv4, zebra_read_ipv6, bgp_zebra_announce,
448 bgp_zebra_withdraw, bgp_redistribute_set, bgp_redistribute_unset)
449 If zebra debugging is enabled, log an appropriate debug message.
450
Andrew J. Schorr8d452102006-11-28 19:50:46 +00004512006-11-28 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
452
453 * bgp_route.c: (bgp_info_restore) New function that undoes
454 the effects of a previous call to bgp_info_delete. This is
455 used when a route is deleted and quickly re-added before the
456 deletion has been processed.
457 (bgp_static_update_rsclient, bgp_static_update_main,
458 bgp_redistribute_add) Check whether a pre-existing route
459 has the BGP_INFO_REMOVED set, and, if so, we need to call
460 bgp_info_restore to resurrect it.
461
Paul Jakma56395af2006-10-27 16:58:20 +00004622006-10-27 Paul Jakma <paul.jakma@sun.com>
463
464 * bgp_route.c: (bgp_table_stats) oops, u_intXX_t should be
465 uintXX_t
466
Paul Jakma6f585442006-10-22 19:13:07 +00004672006-10-19 Paul Jakma <paul.jakma@sun.com>
468
469 * bgpd.c: (peer_new) bgp element of peer absolutely must be
470 filled in, make peer_new() require it as argument and update
471 all callers. Fixes a crash reported by Jan 'yanek' Bortl and
472 Andrew Schorr where bgpd would crash in bgp_pcount_adjust
473 trying to dereference the bgp member of bgp->peer_self,
474 triggered through redistribution.
475 * bgp_route.c: (bgp_pcount_adjust) assert sanity of arguments.
476
Paul Jakma53d9f672006-10-15 23:41:16 +00004772006-10-15 Paul Jakma <paul.jakma@sun.com>
478
479 * bgp_route.c: (bgp_table_stats_walker) NULL deref if table is
480 empty, bgp_table_top may return NULL, Coverity CID#73.
Paul Jakmaed3ebfa2006-10-15 23:50:16 +0000481 * bgp_packet.c: (bgp_update_packet) adv->rn can not be NULL,
482 check is bogus - changed to assert(), CID#64.
483 binfo is checked for NULL, but then dereferenced
484 unconditionally, fix, CID #63.
485 (bgp_withdraw_packet) Assert adv->rn is valid, as with
486 bgp_update_packet().
Paul Jakma53d9f672006-10-15 23:41:16 +0000487
Paul Jakmadcdf3992006-10-15 23:39:59 +00004882006-10-14 Paul Jakma <paul.jakma@sun.com>
489
490 * bgp_fsm.h: Remove BGP_EVENT_FLUSH_ADD, dangerous and not
491 needed.
492 * bgp_fsm.c: (bgp_stop) Move BGP_EVENT_FLUSH to the top of the
493 of the function, otherwise it could flush a ClearingCompleted
494 event, bug #302.
495 * bgp_packet.c: Replace all BGP_EVENT_FLUSH_ADD with
496 BGP_EVENT_ADD, fixing bug #302.
497
Andrew J. Schorr0cd1c322006-09-19 18:51:53 +00004982006-09-19 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
499
500 * bgpd.c: (peer_uptime) Fix printf format/arg mismatch in
501 zlog_warn message (%ld/size_t -> %lu/u_long).
502
Paul Jakmaca058a32006-09-14 02:58:49 +00005032006-09-14 Paul Jakma <paul.jakma@sun.com>
504
Paul Jakma8383a9b2006-09-14 03:06:54 +0000505 * bgp_route.c: (bgp_table_stats_walker) Address space announced
506 should only count top-level unaggregateable prefixes, to
507 avoid falling afoul of anti-dodgy-accounting regulations
508 in various jurisdictions.. ;)
Paul Jakma09dd5612006-09-14 03:38:16 +0000509 (bgp_process_queue_init) process queue hold time too high,
510 adds extra memory load. Change to be much lower, until such
511 time as it's made configurable.
Paul Jakma8383a9b2006-09-14 03:06:54 +0000512
5132006-09-14 Paul Jakma <paul.jakma@sun.com>
514
Paul Jakma9fde6622006-09-14 03:02:02 +0000515 * (general) fix the peer refcount issue exposed by previous, by
516 just removing refcounting of peer threads, which is mostly
517 senseless as they're references leading from struct peer,
518 which peer_free cancels anyway. No need to muck around..
519 * bgp_fsm.h: Just remove the refcounting from the various
520 TIMER/READ/WRITE/EVENT ON/OFF/ADD macros.
521 * bgp_fsm.c: (bgp_stop) use BGP_EVENT_FLUSH, no refcounts attached
522 to events anymore.
523 (bgp_event) remove peer_unlock, events not refcounted.
524 * bgpd.c: (peer_free) flush events before free.
525
5262006-09-14 Paul Jakma <paul.jakma@sun.com>
527
Paul Jakmaca058a32006-09-14 02:58:49 +0000528 * (general) Fix some niggly issues around 'shutdown' and clearing
529 by adding a Clearing FSM wait-state and a hidden 'Deleted'
530 FSM state, to allow deleted peers to 'cool off' and hit 0
531 references. This introduces a slow memory leak of struct peer,
532 however that's more a testament to the fragility of the
533 reference counting than a bug in this patch, cleanup of
534 reference counting to fix this is to follow.
535 * bgpd.h: Add Clearing, Deleted states and Clearing_Completed
536 and event.
537 * bgp_debug.c: (bgp_status_msg[]) Add strings for Clearing and
538 Deleted.
539 * bgp_fsm.h: Don't allow timer/event threads to set anything
540 for Deleted peers.
541 * bgp_fsm.c: (bgp_timer_set) Add Clearing and Deleted. Deleted
542 needs to stop everything.
543 (bgp_stop) Remove explicit fsm_change_status call, the
544 general framework handles the transition.
545 (bgp_start) Log a warning if a start is attempted on a peer
546 that should stay down, trying to start a peer.
547 (struct .. FSM) Add Clearing_Completed
548 events, has little influence except when in state
549 Clearing to signal wait-state can end.
550 Add Clearing and Deleted states, former is a wait-state,
551 latter is a placeholder state to allow peers to disappear
552 quietly once refcounts settle.
553 (bgp_event) Try reduce verbosity of FSM state-change debug,
554 changes to same state are not interesting (Established->Established)
555 Allow NULL action functions in FSM.
556 * bgp_packet.c: (bgp_write) Use FSM events, rather than trying
557 to twiddle directly with FSM state behind the back of FSM.
558 (bgp_write_notify) ditto.
559 (bgp_read) Remove the vague ACCEPT_PEER peer_unlock, or else
560 this patch crashes, now it leaks instead.
561 * bgp_route.c: (bgp_clear_node_complete) Clearing_Completed
562 event, to end clearing.
563 (bgp_clear_route) See extensive comments.
564 * bgpd.c: (peer_free) should only be called while in Deleted,
565 peer refcounting controls when peer_free is called.
566 bgp_sync_delete should be here, not in peer_delete.
567 (peer_delete) Initiate delete.
568 Transition to Deleted state manually.
569 When removing peer from indices that provide visibility of it,
570 take great care to be idempotent wrt the reference counting
571 of struct peer through those indices.
572 Use bgp_timer_set, rather than replicating.
573 Call to bgp_sync_delete isn't appropriate here, sync can be
574 referenced while shutting down and finishing deletion.
575 (peer_group_bind) Take care to be idempotent wrt list references
576 indexing peers.
577
Paul Jakma2815e612006-09-14 02:56:07 +00005782006-09-13 Paul Jakma <paul.jakma@sun.com>
579
580 * bgp_aspath.c: (aspath_highest) new, return highest ASN in an
581 aspath.
582 * bgp_route.c: (bgp_peer_count_walker) new, do the walk done
583 in bgp_peer_counts as a thread.
584 (bgp_peer_counts) move walk to previous and call it via
585 thread_execute so this RIB walk shows up in thread stats.
586 (bgp_table_stats) New, gather some statistics for a given
587 RIB.
588 (bgp_table_stats_walker) New, RIB walker thread for former.
589 (bgp_table_stats_vty) Parsing front-end for 'show bgp ...',
590 useful model for future rationalisation of 'show ... bgp'.
591 (bgp_route_init) Add new RIB stats commands.
592
Paul Jakma1a392d42006-09-07 00:24:49 +00005932006-09-06 Paul Jakma <paul.jakma@sun.com>
594
595 * (general) Squash any and all prefix-count issues by
596 abstracting route flag changes, and maintaining count as and
597 when flags are modified (rather than relying on explicit
598 modifications of count being sprinkled in just the right
599 places throughout the code).
600 * bgp_route.c: (bgp_pcount_{dec,inc}rement) removed.
601 (bgp_pcount_adjust) new, update prefix count as
602 needed for a given route.
603 (bgp_info_{uns,s}et_flag) set/unset a BGP_INFO route status
604 flag, calling previous function when appropriate.
605 (general) Update all set/unsets of flags to use previous.
606 Remove pcount_{dec,inc}rement calls.
607 No need to unset BGP_INFO_VALID in places where
608 bgp_info_delete is called, it does that anyway.
609 * bgp_{damp,nexthop}.c: Update to use bgp_info_{un,}set_flag.
610 * bgp_route.h: Export bgp_info_{un,}set_flag.
611 Add a 'meta' BGP_INFO flag, BGP_INFO_UNUSEABLE.
612 Move BGP_INFO_HOLDDOWN macro to here from bgpd.h
613
Paul Jakmaff7924f2006-09-04 01:10:36 +00006142006-09-03 Paul Jakma <paul.jakma@sun.com>
615
616 * bgp_route.c: Add 'show ... bgp ... <neighbour> prefix-count'
617 commands, to provide detailed counts of prefixes for a peer.
618 Informative, and should help pin down to pfxcnt drift
619 problems.
620
Paul Jakma9f906c72006-08-27 06:57:47 +00006212006-08-27 Paul Jakma <paul.jakma@sun.com>
622
623 * bgp_advertise.c: (bgp_sync_delete) fix mtype in XFREE.
624 NULL out peer->hash after free, to be sure.
625
Paul Jakma1f742f22006-08-06 15:52:11 +00006262006-08-06 Paul Jakma <paul.jakma@sun.com>
627
628 * bgp_aspath.c: (aspath_loop_check) Fix the typo-bug which
629 essentially had disabled this check. Problem reported by
630 Bartek Kania <mrbk@gnarf.org> in [quagga-users 7388].
631
Paul Jakma18937402006-07-27 19:05:12 +00006322006-07-27 Paul Jakma <paul.jakma@sun.com>
633
634 * bgpd.c: (peer_delete) Ensure freed buffers can not be
635 accidently reused. A potential fix for bug #287.
636
Paul Jakma33d5ab92006-07-02 11:01:50 +00006372006-07-02 Paul Jakma <paul.jakma@sun.com>
638
639 * bgp_fsm.c: (bgp_{stop,start}) Move clear/free of certain
640 bits of state from stop to start, as they may be used via
641 peer references on clearing queues..
642
Paul Jakma369688c2006-05-23 22:27:55 +00006432006-05-23 Paul Jakma <paul.jakma@sun.com>
644
645 * bgp_vty.c: (neighbor_update_source_cmd) Expand tab completion
646 to make it clear it takes both address and ifname.
647
Paul Jakma34c3f812006-05-12 23:25:37 +00006482006-05-12 Paul Jakma <paul.jakma@sun.com>
649
650 * bgp_attr.c: (bgp_packet_attribute) Remove dead code, Coverity
651 CID #1
Paul Jakmab2518c12006-05-12 23:48:40 +0000652 * bgp_aspath.{c,h}: (aspath_print_vty) take a format string,
653 so as to reduce burden on callers, all in bgp_route.c
Paul Jakmadd8103a2006-05-12 23:27:30 +0000654 * bgp_route.c: (bgp_static_update_main) Remove useless NULL
655 check, code already assumes bgp_static can not be NULL,
656 fixes CID #7.
Paul Jakma06e110f2006-05-12 23:29:22 +0000657 (bgp_static_update_rsclient) ditto, CID #6
Paul Jakmab2518c12006-05-12 23:48:40 +0000658 (route_vty_out{,tmp}) Update to match aspath_print_vty,
659 simplifying checks needed to get spacing right. CID #4,#5.
660 ({damp,flap}_route_vty_out) Ditto, CID #9, #10
Paul Jakma34c3f812006-05-12 23:25:37 +0000661
Paul Jakma542bcb72006-05-08 14:25:09 +00006622006-05-08 Paul Jakma <paul.jakma@sun.com>
663
664 * bgp_community.c: (community_str2com) Coverity CID#62, fix
665 double-free, use-after-free.
Paul Jakmada5b30f2006-05-08 14:37:17 +0000666 * bgp_route.c: (bgp_afi_node_get) given table should never be
667 NULL, check/assert this.
668 (bgp_static_update) Bug #240. Rsclients should only be passed
669 the static update if they are configured for the afi,safi.
Paul Jakma542bcb72006-05-08 14:25:09 +0000670
Paul Jakmaa3b6ea52006-05-04 07:52:12 +00006712006-05-04 Paul Jakma <paul.jakma@sun.com>
672
673 * (general) VPNv4 fixes. Certain VPNv4 code was not enabled.
674 See bug #210.
675 * bgp_attr.{c,h}: (bgp_packet_{withdraw,attribute}) Tag should be
676 u_char really.
677 * bgp_packet.c: (bgp_{update,withdraw}_packet) Enable some
678 VPNv4 code which inexplicably was ifdef'd out. comments from
679 a tester on IRC suggest this fixes bug #210.
Paul Jakma65ca75e2006-05-04 08:08:15 +0000680 * bgp_route.c: (general) Fix logical bug in clearing, noted
681 by Chris Caputo in [quagga-users 6728] - clearing depended on
682 at least one route being added to workqueue, in order for
683 workqueue completion function to restart FSM. However, if no
684 routes are cleared, then the completion function never is
685 called, it needs to be called manually if the workqueue
686 didn't get scheduled.
687 Finally, clearing is per-peer-session, not per AFI/SAFI, so
688 the FSM synchronisation should be in bgp_clear_route_table.
689 (bgp_clear_route_table) Wrong place for FSM/clearing
690 synchronisation, move to..
691 (bgp_clear_route) FSM/clearing synchronisation should be
692 here.
693 If no routes were cleared, no workqueue scheduled, call
694 the completion func to ensure FSM kicks off again.
Paul Jakmaa3b6ea52006-05-04 07:52:12 +0000695
Paul Jakma15aa6a12006-03-30 14:39:35 +00006962006-03-30 Paul Jakma <paul.jakma@sun.com>
697
698 * bgp_community.c: (community_gettoken) Unknown token should
699 return NULL, to give a strong indication to callers that
700 the token no longer can be parsed, otherwise callers looping
701 on this function may have a hard time ending their loop.
702 (community_str2com) While loop around community_gettoken appears
703 to have been coded thinking that break statement would break
704 from the while{}, hence it could never exit for unknown token
705 case. Fix it to do..while, so it can use the NULL result from
706 community_gettoken easily.
707
Paul Jakmaa625ca32006-03-30 14:12:38 +00007082006-03-22 Paul Jakma <paul.jakma@sun.com>
709
710 * bgpd.c: (peer_free) release the per-peer workqueue when
711 freeing the peer.
712
Paul Jakma5304cb52006-03-30 14:01:14 +00007132006-03-19 Paul Jakma <paul.jakma@sun.com>
714
Paul Jakma4bf6a362006-03-30 14:05:23 +0000715 * bgpd/bgp_vty.c: Add includes to get several structs we want
716 to provide usage statistics on.
717 (show_bgp_memory_cmd) Show memory usage stats for various
718 notable fixed size objects. Using mtype_stats_alloc and
719 mtype_memstr recently added to memory.c.
720 (bgp_show_summary) Report some additional stats specific to
721 the given BGP instance and/or AFI/SAFI such as table counts,
722 peers, rsclients and peer-groups.
723 (bgp_vty_init) Install show_bgp_memory_cmd.
Paul Jakma5304cb52006-03-30 14:01:14 +0000724 * bgp_nexthop.h: Include if.h as a dependent header, for struct
725 connected.
Paul Jakmab51f1262006-03-30 14:09:38 +0000726 * bgp_advertise.c: Use a distinct memory type for struct
727 bgp_synchronize.
Paul Jakma5304cb52006-03-30 14:01:14 +0000728
Paul Jakmacbdfbaa2006-03-30 13:20:48 +00007292006-03-12 Paul Jakma <paul.jakma@sun.com>
730
731 * bgp_attr.h: (struct attr) rearrange fields to avoid
732 wasted padding between them as much as possible.
733 (attr_count,attr_unknown_count) export new functions to
734 return number of counts of cached attributes.
735 * bgp_attr.c: (attr_count,attr_unknown_count) new functions to
736 return number of counts of cached attributes.
737 * bgp_route.h: (struct bgp_info) rearrange fields to avoid
738 wasted padding.
739 * bgp_table.h: (struct bgp_table) Add a count field, of number
740 of nodes in the table.
741 (struct bgp_node) rearrange fields to avoid
742 wasted padding between them, though I don't think there
743 was any in this case.
744 * bgp_table.c: (bgp_node_{delete,get}) Maintain the table node count.
745 (bgp_table_count) new function to access the table count.
746
Paul Jakma3e0c78e2006-03-06 18:06:53 +00007472006-03-03 Paul Jakma <paul.jakma@sun.com>
748
749 * bgp_route.c: (bgp_clear_node_complete) Doh. When clearing
750 is complete we need to kick off FSM again.
751
Paul Jakma64e580a2006-02-21 01:09:01 +00007522006-02-21 Paul Jakma <paul.jakma@sun.com>
753
754 * bgpd.h: move the clear_node_queue to be peer specific.
755 Add a new peer status flag, PEER_STATUS_CLEARING.
756 * bgp_table.h: (struct bgp_table) Add fields to record afi,
757 safi of the table.
758 (bgp_table_init) Take afi and safi to create table for.
759 * bgp_table.c: (bgp_table_init) record the afi and safi.
760 * bgp_nexthop.c: Update all calls to bgp_table_init.
761 * bgp_vty.c: ditto.
762 * bgpd.c: ditto.
763 * bgp_fsm.c: (bgp_timer_set) dont bring up a session which is
764 clearing.
765 * bgp_route.c: (general) Update all bgp_table_init calls.
766 (bgp_process_{rsclient,main}) clear_node is serialised
767 via PEER_STATUS_CLEARING and fsm now.
768 (struct bgp_clear_node_queue) can be removed. struct bgp_node
769 can be the queue item data directly, as struct peer can be
770 kept in the new wq global user data and afi/safi can be
771 retrieved via bgp_node -> bgp_table.
772 (bgp_clear_route_node) fix to get peer via wq->spec.data,
773 afi/safi via bgp_node->bgp_table.
774 (bgp_clear_node_queue_del) no more item data to delete, only
775 unlock the bgp_node.
776 (bgp_clear_node_complete) only need to unset CLEARING flag
777 and unlock struct peer.
778 (bgp_clear_node_queue_init) queue attaches to struct peer
779 now. record peer name as queue name.
780 (bgp_clear_route_table) If queue transitions to active,
781 serialise clearing by setting PEER_STATUS_CLEARING rather
782 than plugging process queue, and lock peer while queue
783 active.
784 Update to pass only bgp_node as per-queue-item specific data.
Paul Jakma6a419732006-02-21 01:14:13 +0000785 * bgp_vty.c: (bgp_show_summary) Add a 'Clrng' sub-description
786 to state of peer while it's suppressed due to clearing.
Paul Jakma64e580a2006-02-21 01:09:01 +0000787
Paul Jakmaaa94ca82006-02-18 10:49:04 +00007882006-02-18 Paul Jakma <paul.jakma@sun.com>
789
790 * bgp_routemap.c: (route_set_community) Quick, very hacky, fix
791 for the set-community leak, bug #89. True fix will be to
792 detangle the web of *_intern caching and provide saner object
793 caching for Quagga, future work.
Paul Jakma7c7fa1b2006-02-18 10:52:09 +0000794 * bgp_route.c: (bgp_announce_check) trivial, move declaration
795 of two local variables into the only block where they are
796 used, to aid the reader.
Paul Jakmaaa94ca82006-02-18 10:49:04 +0000797
paul902212c2006-02-05 17:51:19 +00007982006-02-05 Paul Jakma <paul.jakma@sun.com>
799
800 * bgp_route.h: Add BGP_INFO_COUNTED to track whether
801 prefix has been counted or not.
802 * bgp_route.c: (bgp_pcount_{inc,dec}rement) new helpers, to
803 centralise inc/dec of prefix-count,
804 (bgp_rib_remove) Remove pcount decrement, use helper.
805 (bgp_rib_withdraw) ditto, additionally use previous function
806 too.
807 (bgp_update_main) Use pcount helpers.
808 (bgp_clear_route_node) ditto, aslo REMOVED routes don't need
809 clearing.
paul3fff6ff2006-02-05 17:55:35 +0000810 * bgp_aspath.c: (aspath_gettoken) fix gcc warning about
811 possible uninitialised usage.
paul902212c2006-02-05 17:51:19 +0000812
paul306d8892006-02-02 17:50:19 +00008132006-02-02 Paul Jakma <paul.jakma@sun.com>
814
815 * bgp_route.c: (bgp_{clear_node,process}_queue_init) delay
816 field is removed from workqueue spec.
817
paule8e19462006-01-19 20:16:55 +00008182006-01-19 Paul Jakma <paul.jakma@sun.com>
819
820 * (general) various miscellaneous compiler warning fixes.
821 Remove redundant break statements from switch clauses
822 which return.
823 return from main, not exit, cause it annoys SOS.
824 Remove stray semi-colons which cause empty-statement
825 warnings.
826
pauld3092e72006-01-17 17:33:46 +00008272006-01-17 Paul Jakma <paul.jakma@sun.com>
828
829 * bgp_nexthop.c: (zlookup_read*) convert to new Zserv format.
830 (zlookup_query_ipv6) ditto.
831 (bgp_import_check) ditto.
832
paul02335422006-01-16 11:13:27 +00008332006-01-16 Paul Jakma <paul.jakma@sun.com>
834
835 * bgp_aspath.c: (assegment_append_asns) XREALLOC can return
836 NULL theoretically, take care not to lose the allocated data.
837 (aspath_hash_alloc) aspath_dup already set the aspath
838 string - fix leak.
839 (aspath_parse) aspath_hash_alloc dupes the entire aspath,
840 including segments, but we forgot to free the temporary
841 assegment.
paul8fdc32a2006-01-16 12:01:29 +0000842 (aspath_snmp_pathseg) move the static stream pointer out to
843 file scope, so it can be freed.
844 (aspath_finish) new function, free aspath resources.
845 * bgp_aspath.h: (aspath_finish) export.
paul02335422006-01-16 11:13:27 +0000846
paul37c38302006-01-10 22:15:45 +00008472006-01-10 Juris Kalnins <juris@mt.lv>
848
849 * bgpd.h: (bgp_router_id_unset) ex-function, remove.
850
paulad727402005-11-23 02:47:02 +00008512005-11-23 Paul Jakma <paul.jakma@sun.com>
852
853 * bgp_aspath.c: (assegments_parse) should be static
854
8552005-11-23 Juergen Kammer <j.kammer@eurodata.de>
856
857 * bgp_aspath.c: (aspath_cmp_left_confed) fix SEGV for case
858 where one or both paths are empty.
859
paul0fb58d52005-11-14 14:31:49 +00008602005-11-14 Paul Jakma <paul.jakma@sun.com>
861
862 * bgp_route.c: (bgp_process_rsclient) convert to new workqueue
863 specs and shut up gcc, which complains about cast from void
864 via function parameters, for some dumb reason. Do the cast
865 inside the function instead.
866 (bgp_process_main,bgp_processq_del) ditto.
867 (bgp_clear_route_node) ditto.
868 (bgp_clear_node_queue_del) ditto.
869
paul41200852005-11-03 12:52:18 +00008702005-11-03 Paul Jakma <paul.jakma@sun.com>
871
872 * bgp_damp.c: (bgp_reuse_timer) struct bgp can be retrieved via
873 the struct bgp_damp_info, no need to guess by using
874 bgp_get_default().
875
ajsf52d13c2005-10-01 17:38:06 +00008762005-10-01 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
877
878 * bgp_vty.c: (bgp_config_write_redistribute) Use new library function
879 zebra_route_string instead of a local hard-coded table.
880
jardin2d74db52005-10-01 00:07:50 +00008812005-09-30 Vincent Jardin <vincent.jardin@6wind.com>
882
883 * bgp_packet.c: fix compilation when DEBUG is used.
884
paul1f8ae702005-09-09 23:49:49 +00008852005-09-10 Paul Jakma <paul.jakma@sun.com>
886
paulfe69a502005-09-10 16:55:02 +0000887 * Makefile.am: bgpd shouldn't list libgp's sources as its own.
888 Use LDADD.
889 * bgp_aspath.h:
890 (struct assegment) New struct, abstract representation of a
891 list of AS_PATH segments and the contained ASNs.
892 (struct aspath) Remove the raw-data related
893 fields, reference the abstract struct assegment instead.
894 Remove several other computed fields, it's just a
895 headache to maintain them and they're cheap to compute from
896 struct assegment.
897 (aspath_parse) parse a stream, not a pointer to raw data.
898 (aspath_count_{hops,confeds,size}) helpers to access
899 information formerly directly contained in struct aspath.
900 (aspath_snmp_pathseg) Helper for SNMP, BGP MIB wants
901 to be able to output hex representation of raw data.
902 * bgp_aspath.c: (general) partial-rewrite. Store aspath data
903 as an abstract singly-linked list of abstract segments,
904 rather than storing the raw data, and parsing it each and
905 every time. Remove several count/size fields which are cheap
906 to compute from the abstract segment structure.
907 (global) Include stream.h, needed for aspath_parse, and
908 others. Couple of helper macros added.
909 (struct assegment_header) Just the header, and only the
910 header.
911 (assegment_data_{new,free}) convenience functions for
912 AS_SEG_DATA allocation, the dynamic, per-segment array of
913 ASNs.
914 (assegment_{new,free,free_all,dup,dup_all}) convenience
915 functions for creating struct assegments. The _all forms will
916 follow the entire chain of segments from the given segment.
917 (assegment_prepend_asns) new function, prepend an ASN N times
918 to segment.
919 (assegment_append_asns) Append a list (array) of ASNs to
920 segment.
921 (int_cmp) convenience function for the aspath hash.
922 (assegment_normalise) new function. Normalise the given
923 segment chain to meet expectations of Quagga, and to
924 eliminate differing raw representations of the same paths.
925 Merge 'runs' of SEQUENCEs into one segment as our internal
926 segment is not limited by the protocol AS_PATH segment
927 length. Sort ASNs in SETs.
928 (aspath_new) Take void argument to quell warnings. Use the
929 assegment convenience functions.
930 (assegment_count_{asns,confeds,hops}) new functions to
931 compute at runtime values previously held in struct aspath.
932 (aspath_size) ditto.
933 (aspath_make_str_count) rewritten to stringify new
934 representation, and to be slightly easier to understand
935 hopefully.
936 (aspath_str_update) convenience function, update the aspath
937 str. Should investigate removing maintained string from
938 struct aspath, just run-time compute it, as per other fields.
939 It's just a maintenance headache, would save noticeable
940 amount of RAM with possibly not much extra run-time cost.
941 (aspath_dup) use the assegment dup functions.
942 (aspath_hash_alloc) Take void * argument to satisfy gcc. Use
943 the proper helper functions to dup data.
944 (assegments_parse) new function. parse raw AS_PATH data into
945 struct assegments. Normalise and return the head of the list.
946 (aspath_parse) Parse a stream, not pointer to raw data and
947 use assegments_parse to do it.
948 (assegment_data_put) Write out a single segment data in protocol
949 form to stream.
950 (assegment_header_put) ditto but for segment header.
951 (aspath_put) new function. As per previous but for an entire
952 struct aspath.
953 (aspath_snmp_pathseg) wrapper around aspath_put for
954 bgp_snmp.c. Uses a static buffer sadly.
955 (aspath_aggregate_as_set_add) rewritten to use assegments.
956 (aspath_aggregate) ditto
957 (aspath_{firstas,loop,private_as}_check) ditto
958 (aspath_{merge,prepend,add_one_as}) ditto
959 (aspath_cmp_left{_confed}) ditto
960 (aspath_delete_confed_seq) ditto, plus fixed to properly
961 delete all leading confed segments.
962 (aspath_as_add) Just use assegment_append_asns.
963 (aspath_segment_add) updated to use assegments.
964 (enum as_token) Add values for confeds
965 (aspath_gettoken) Add support for confeds
966 (aspath_str2aspath) ditto
967 (aspath_key_make) updated to use as_segments. Also, add
968 segment type into the hash value as appropriate.
969 (aspath_cmp) updated to use as_segments.
970 (aspath_print) don't segfault on NULL argument.
971 * bgp_attr.c: (bgp_attr_aspath) aspath_parse wants the stream
972 now. No need for manual forwarding of stream.
973 (bgp_packet_attribute) empty aspath is now denoted by NULL
974 segment field, length is gone.
975 Use aspath_size() to determine size.
976 (bgp_attr_init) Fix declaration, explicitely specify void
977 arg.
978 (bgp_dump_routes_attr) Use aspath_size() to determine size.
979 * bgp_route.c: (bgp_info_cmp) use the aspath_count_* functions.
980 (bgp_rib_withdraw) remove unused variable. Use
981 aspath_count_hops.
982 * bgp_snmp.c: (bgp4PathAttrTable) raw data is gone, use
983 aspath_snmp_pathseg to get the representation.
984
9852005-09-10 Paul Jakma <paul.jakma@sun.com>
986
paul1f8ae702005-09-09 23:49:49 +0000987 * bgp_vty.c: (bgp_vty_init) gcc 4 compile fix. static
988 function declarations shouldn't be inside functions.
989 * bgp_dump.c: (bgp_dump_interval_add) ditto.
990
hassob7395792005-08-26 12:58:38 +00009912005-08-26 Hasso Tepper <hasso at quagga.net>
992
993 * bgp_route.c: Third (?) attempt to fix best selection breakage
994 introduced long time ago with route server patch. Hopefully
995 it's last case to fix - route-server client not in peer group.
996
paul25ffbdc2005-08-22 22:42:08 +00009972005-08-22 Hugo Santos <hsantos@av.it.pt>
998
999 * bgp_vty.c: (general) Add support for BGP IPv6 Multicast SAFI
1000 commands and BGP_IPV6M_NODE.
1001
paulb40d9392005-08-22 22:34:41 +000010022005-08-22 Paul Jakma <paul.jakma@sun.com>
1003
1004 * bgp_route.h: (struct bgp_info) add a new flag, BGP_INFO_REMOVED.
1005 BGP_INFO_VALID is already overloaded, don't care to do same thing
1006 to STALE or HISTORY.
1007 * bgpd.h: (BGP_INFO_HOLDDOWN) Add INFO_REMOVED to the macro, as a
1008 route which should generally be ignored.
1009 * bgp_route.c: (bgp_info_delete) Just set the REMOVE flag, rather
1010 than doing actual work, so that bgp_process (called directly,
1011 or indirectly via the scanner) can catch withdrawn routes.
1012 (bgp_info_reap) Actually remove the route, what bgp_info_delete
1013 used to do, only for use by bgp_process.
1014 (bgp_best_selection) reap any REMOVED routes, other than the old
1015 selected route.
1016 (bgp_process_rsclient) reap the old-selected route, if appropriate
1017 (bgp_process_main) ditto
1018 (bgp_rib_withdraw, bgp_rib_remove) make them more consistent with
1019 each other. Don't play games with the VALID flag, bgp_process
1020 is async now, so it didn't make a difference anyway.
1021 Remove the 'force' argument from bgp_rib_withdraw, withdraw+force
1022 is equivalent to bgp_rib_remove. Update all its callers.
1023 (bgp_update_rsclient) bgp_rib_withdraw and force set is same as
1024 bgp_rib_remove.
1025 (route_vty_short_status_out) new helper to print the leading
1026 route-status string used in many command outputs. Consolidate.
1027 (route_vty_out, route_vty_out_tag, damp_route_vty_out,
1028 flap_route_vty_out) use route_vty_short_status_out rather than
1029 duplicate.
1030 (route_vty_out_detail) print state of REMOVED flag.
1031 (BGP_SHOW_SCODE_HEADER) update for Removed flag.
1032
hassoe279c7a2005-08-03 17:23:20 +000010332005-08-03 Hasso Tepper <hasso at quagga.net>
1034
1035 * bgp_routemap.c: Revert part of leaking communities fix commited in
1036 2005-05-27. While ecommunity fix seems to be correct, community case
1037 isn't.
1038
paul94f2b392005-06-28 12:44:16 +000010392005-06-28 Paul Jakma <paul.jakma@sun.com>
1040
1041 * (global) The great bgpd extern and static'ification.
1042 * bgp_routemap.c: remove unused ROUTE_MATCH_ASPATH_OLD code
1043 (route_set_metric_compile) fix u_int32_t to ULONG_MAX comparison
1044 warnings.
1045 * bgp_route.h: (bgp_process, bgp_withdraw, bgp_update) export these
1046 used by various files which had their own private declarations,
1047 in the case of mplsvpn - incorrect.
1048
paule210cf92005-06-15 19:15:35 +000010492005-06-15 Paul Jakma <paul.jakma@sun.com>
1050
1051 * bgpd.c: (bgp_terminate) workqueue's are lazy allocated and its
1052 possible to terminate bgpd before workqueues were setup, causing
1053 an abort/crash. Reported by Ashish Mehta of Sun.
1054
paul200df112005-06-01 11:17:05 +000010552005-06-01 Paul Jakma <paul.jakma@sun.com>
1056
1057 * (general) refcount struct peer and bgp_info, hence allowing us
1058 add work_queues for bgp_process.
1059 * bgp_route.h: (struct bgp_info) Add 'lock' field for refcount.
1060 Add bgp_info_{lock,unlock} helper functions.
1061 Add bgp_info_{add,delete} helpers, to remove need for
1062 users managing locking/freeing of bgp_info and bgp_node's.
1063 * bgp_table.h: (struct bgp_node) Add a flags field, and
1064 BGP_NODE_PROCESS_SCHEDULED to merge redundant processing of
1065 nodes.
1066 * bgp_fsm.h: Make the ON/OFF/ADD/REMOVE macros lock and unlock
1067 peer reference as appropriate.
1068 * bgp_damp.c: Remove its internal prototypes for
1069 bgp_info_delete/free. Just use bgp_info_delete.
1070 * bgpd.h: (struct bgp_master) Add work_queue pointers.
1071 (struct peer) Add reference count 'lock'
1072 (peer_lock,peer_unlock) New helpers to take/release reference
1073 on struct peer.
1074 * bgp_advertise.c: (general) Add peer and bgp_info refcounting
1075 and balance how references are taken and released.
1076 (bgp_advertise_free) release bgp_info reference, if appropriate
1077 (bgp_adj_out_free) unlock peer
1078 (bgp_advertise_clean) leave the adv references alone, or else
1079 call bgp_advertise_free cant unlock them.
1080 (bgp_adj_out_set) lock the peer on new adj's, leave the reference
1081 alone otherwise. lock the new bgp_info reference.
1082 (bgp_adj_in_set) lock the peer reference
1083 (bgp_adj_in_remove) and unlock it here
1084 (bgp_sync_delete) make hash_free on peer conditional, just in
1085 case.
1086 * bgp_fsm.c: (general) document that the timers depend on
1087 bgp_event to release a peer reference.
1088 (bgp_fsm_change_status) moved up the file, unchanged.
1089 (bgp_stop) Decrement peer lock as many times as cancel_event
1090 canceled - shouldnt be needed but just in case.
1091 stream_fifo_clean of obuf made conditional, just in case.
1092 (bgp_event) always unlock the peer, regardless of return value
1093 of bgp_fsm_change_status.
1094 * bgp_packet.c: (general) change several bgp_stop's to BGP_EVENT's.
1095 (bgp_read) Add a mysterious extra peer_unlock for ACCEPT_PEERs
1096 along with a comment on it.
1097 * bgp_route.c: (general) Add refcounting of bgp_info, cleanup
1098 some of the resource management around bgp_info. Refcount peer.
1099 Add workqueues for bgp_process and clear_table.
1100 (bgp_info_new) make static
1101 (bgp_info_free) Ditto, and unlock the peer reference.
1102 (bgp_info_lock,bgp_info_unlock) new exported functions
1103 (bgp_info_add) Add a bgp_info to a bgp_node in correct fashion,
1104 taking care of reference counts.
1105 (bgp_info_delete) do the opposite of bgp_info_add.
1106 (bgp_process_rsclient) Converted into a work_queue work function.
1107 (bgp_process_main) ditto.
1108 (bgp_processq_del) process work queue item deconstructor
1109 (bgp_process_queue_init) process work queue init
1110 (bgp_process) call init function if required, set up queue item
1111 and add to queue, rather than calling process functions directly.
1112 (bgp_rib_remove) let bgp_info_delete manage bgp_info refcounts
1113 (bgp_rib_withdraw) ditto
1114 (bgp_update_rsclient) let bgp_info_add manage refcounts
1115 (bgp_update_main) ditto
1116 (bgp_clear_route_node) clear_node_queue work function, does
1117 per-node aspects of what bgp_clear_route_table did previously
1118 (bgp_clear_node_queue_del) clear_node_queue item delete function
1119 (bgp_clear_node_complete) clear_node_queue completion function,
1120 it unplugs the process queues, which have to be blocked while
1121 clear_node_queue is being processed to prevent a race.
1122 (bgp_clear_node_queue_init) init function for clear_node_queue
1123 work queues
1124 (bgp_clear_route_table) Sets up items onto a workqueue now, rather
1125 than clearing each node directly. Plugs both process queues to
1126 avoid potential race.
1127 (bgp_static_withdraw_rsclient) let bgp_info_{add,delete} manage
1128 bgp_info refcounts.
1129 (bgp_static_update_rsclient) ditto
1130 (bgp_static_update_main) ditto
1131 (bgp_static_update_vpnv4) ditto, remove unneeded cast.
1132 (bgp_static_withdraw) see bgp_static_withdraw_rsclient
1133 (bgp_static_withdraw_vpnv4) ditto
1134 (bgp_aggregate_{route,add,delete}) ditto
1135 (bgp_redistribute_{add,delete,withdraw}) ditto
1136 * bgp_vty.c: (peer_rsclient_set_vty) lock rsclient list peer
1137 reference
1138 (peer_rsclient_unset_vty) ditto, but unlock same reference
1139 * bgpd.c: (peer_free) handle frees of info to be kept for lifetime
1140 of struct peer.
1141 (peer_lock,peer_unlock) peer refcount helpers
1142 (peer_new) add initial refcounts
1143 (peer_create,peer_create_accept) lock peer as appropriate
1144 (peer_delete) unlock as appropriate, move out some free's to
1145 peer_free.
1146 (peer_group_bind,peer_group_unbind) peer refcounting as
1147 appropriate.
1148 (bgp_create) check CALLOC return value.
1149 (bgp_terminate) free workqueues too.
1150
hasso033e8612005-05-28 04:50:54 +000011512005-05-28 Hasso Tepper <hasso at quagga.net>
1152
1153 * bgp_routemap.c: Sync set_metric_addsub_cmd with ripd.
1154
hasso54a6ed32005-05-26 22:12:33 +000011552005-05-27 Hasso Tepper <hasso at quagga.net>
1156
hasso70601e02005-05-27 03:26:57 +00001157 * bgp_routemap.c: Stop leaking communities.
1158
11592005-05-27 Hasso Tepper <hasso at quagga.net>
1160
hasso54a6ed32005-05-26 22:12:33 +00001161 * bgpd.c: Deleting bgp->rsclient list needs fix similar to pree-groups
1162 deleting fix. Avoid leaking bgp->group, bgp->peer and bgp->rsclient
1163 lists.
1164
11652005-05-26 Hasso Tepper <hasso at quagga.net>
hassob6b7cff2005-05-26 08:29:07 +00001166
1167 * bgpd.c: Don't crash while deleting list of peer-groups.
1168
hassob5f29602005-05-25 21:00:28 +000011692005-05-25 Hasso Tepper <hasso at quagga.net>
1170
1171 * bgpd.c: Fix obvious (routeserver patch) merge error. This makes "no
1172 neighbor x.x.x.x routemap [export|import] commands work again.
1173
paula94feb32005-05-23 13:17:29 +000011742005-05-23 Paul Jakma <paul@dishone.st>
1175
1176 * bgp_routemap.c: add semi-colons to VTY_GET_* to match vty.h change
paul00d252c2005-05-23 14:19:54 +00001177 * bgp_fsm.h: Add extern qualifier to exported functions
1178 * bgp_nexthop.c: add static to nexthop specific globals
1179 * *.h: Add guard defines
paula94feb32005-05-23 13:17:29 +00001180
paul22db9de2005-05-19 01:50:11 +000011812005-05-19 Paul Jakma <paul@dishone.st>
1182
1183 * bgp_fsm.c: (bgp_stop) use sockunion_free, not XFREE..
1184 * bgp_network.c: (bgp_getsockname) ditto
paule83e2082005-05-19 02:12:25 +00001185 (bgp_accept) use XSTRDUP
paul22db9de2005-05-19 01:50:11 +00001186 * bgp_routemap.c: (route_match_peer) ditto, als use a ret value and
1187 remove one sockunion_free.
paule83e2082005-05-19 02:12:25 +00001188 * bgpd.c: (peer_delete) ditto.
1189 XFREE the correct memtype, not free.
1190 (peer_create) use XSTRDUP
1191 * bgp_packet.c: (bgp_stream_dup) deleted, stream_dup should be used
1192 (various) update -> s/bgp_stream_dup/stream_dup
1193
paul22db9de2005-05-19 01:50:11 +00001194
ajs634f9ea2005-04-11 15:51:40 +000011952005-04-11 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1196
1197 * bgp_zebra.c (bgp_redistribute_set, bgp_redistribute_unset):
1198 The 2nd arg to zebra_redistribute_send is now zclient instead of
1199 zclient->sock.
1200
hassoa8a80d52005-04-09 13:07:47 +000012012005-04-09 Akihiro Mizutani <mizutani@net-chef.net>
1202
1203 * bgp_vty.c: Make "exit-address-family" work in IPv4 unicast address
1204 family node.
1205
hasso68118452005-04-08 15:40:36 +000012062005-04-08 Martin Ling <martin-quagga@earth.li>
1207
1208 * bgp_aspath.[ch], bgp_route.c, bgp_vty.c, bgpd.[ch]: Allow to enable
1209 the length of confederation path segments to be included during the
1210 as-path length check in the best path decision.
1211
ajsd2fc8892005-04-02 18:38:43 +000012122005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1213
1214 * bgp_zebra.c: (bgp_interface_delete) After deleting, set ifp->ifindex
1215 to IFINDEX_INTERNAL.
1216
hasso6cf159b2005-03-21 10:28:14 +000012172005-03-21 Hasso Tepper <hasso at quagga.net>
1218
1219 * bgp_route.c: Don't crash while clearing route tables if there is
1220 no particular afi/safi configured.
1221
hasso338b3422005-02-23 14:27:24 +000012222005-02-23 Hasso Tepper <hasso at quagga.net>
1223
1224 * bgp_route.c: Make reannouncing prefixes with changed attributes
1225 work again.
1226
hasso6ffd2072005-02-02 14:50:11 +000012272005-02-02 Akihiro Mizutani <mizutani@net-chef.net>
1228
hassodd4c5932005-02-02 17:15:34 +00001229 * bgp_vty.c: Deprecate "neighbor transparent-as" and "neighbor
1230 transparent-nexthop" commands.
1231
12322005-02-02 Akihiro Mizutani <mizutani@net-chef.net>
1233
hassoc1643bb2005-02-02 16:43:17 +00001234 * bgp_routemap.c: New route-map command - "match ip route-source".
1235
12362005-02-02 Akihiro Mizutani <mizutani@net-chef.net>
1237
hassofee6e4e2005-02-02 16:29:31 +00001238 * bgp_clist.[ch], bgp_route.c, bgp_routemap.c, bgp_vty.c:
1239 community-list cleanup.
1240
12412005-02-02 Akihiro Mizutani <mizutani@net-chef.net>
1242
hasso6ffd2072005-02-02 14:50:11 +00001243 * bgp_route.c, bgp_vty.c, bgp_zebra.c, bgpd.[ch]: "enforce-multihop"
1244 -> "disable-connected-check".
1245
12462005-02-02 Akihiro Mizutani <mizutani@net-chef.net>
hasso93406d82005-02-02 14:40:33 +00001247
1248 * bgp_fsm.c, bgp_open.c, bgp_packet.c, bgp_route.[ch], bgp_vty.c,
1249 bgpd.[ch]: Add BGP_INFO_STALE flag and end-of-rib support. "bgp
1250 graceful-restart" commands added. Show numbers of individual
1251 messages in "show ip bgp neighbor" command. Final pieces of graceful
1252 restart.
1253
hassof4184462005-02-01 20:13:16 +000012542005-02-01 Akihiro Mizutani <mizutani@net-chef.net>
1255
hassoc9502432005-02-01 22:01:48 +00001256 * bgp_open.c, bgp_packet.c, bgp_vty.c, bgpd.[ch]: Remove "no neighbor
1257 capability route-refresh" commands. Route refresh capability is sent
1258 anyway now. Preserve dummy deprecated commands.
1259
12602005-02-01 Akihiro Mizutani <mizutani@net-chef.net>
1261
hasso3d515fd2005-02-01 21:30:04 +00001262 * bgp_attr.c, bgp_snmp.c, bgp_vty.c, bgpd.[ch]: Remove support for old
1263 draft - ie. "neighbor version 4-" commands. Preserve dummy "neighbor
1264 version" command as deprecated.
1265
12662005-02-01 Akihiro Mizutani <mizutani@net-chef.net>
1267
hasso0a486e52005-02-01 20:57:17 +00001268 * bgpd.[ch], bgp_vty.c, bgp_route.c: "Restart session after
1269 maximum-prefix limit" feature support.
1270
12712005-02-01 Akihiro Mizutani <mizutani@net-chef.net>
1272
hassof4184462005-02-01 20:13:16 +00001273 * bgp_nexthop.c: Improve debug.
1274 * bgpd.[ch], bgp_nexthop.c, bgp_snmp.c: Remove useless bgp_get_master()
1275 function.
1276 * bgp_packet.c: MP AFI_IP update and withdraw parsing.
1277 * bgp_fsm.c: Reset peer synctime in bgp_stop(). bgp_fsm_change_status()
1278 is better place to log about peer status change than bgp_event().
1279 Log in bgp_connect_success().
1280 * bgp_vty.c: Fix typo in comment.
1281 * bgp_attr.c: Better log about unknown attribute.
1282
ajs3b8b1852005-01-29 18:19:13 +000012832005-01-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1284
1285 * bgp_filter.c: (ip_as_path,no_ip_as_path) Use argv_concat instead
1286 of buffer_getstr.
1287 * bgp_route.c: (bgp_show_regexp) Fix memory leak: need to free string
1288 returned by buffer_getstr.
1289 (bgp_show_community) Must use XFREE instead of free on string
1290 returned by buffer_getstr.
1291 * bgp_routemap.c: (set_community) Must use XFREE instead of free
1292 on string returned by buffer_getstr.
1293 * bgp_vty.c: (neighbor_description) Use argv_concat instead of
1294 buffer_getstr.
1295
hasso6d694292005-01-24 09:29:42 +000012962005-01-24 Hasso Tepper <hasso at quagga.net>
1297
1298 * bgp_route.c: Fix showstopper bug. New route must be selected also
1299 if old one is flaged as BGP_INFO_ATTR_CHANGED.
1300
hassof1271652005-01-17 11:04:32 +000013012005-01-17 Hasso Tepper <hasso at quagga.net>
1302
1303 * bgp_route.c: Clear peer's routing table regardless whether it's
1304 configured or not. Being not configured is even better reason to
1305 do it.
1306
paula24a7e12005-01-05 08:14:13 +000013072005-01-05 Paul Jakma <paul@dishone.st>
1308
1309 * bgp_packet.c: (bgp_write) set socket to nonblock while writing
1310 this should be generalised. See bugzilla #102. Fix supplied by
1311 wawa@yandex-team.ru (Vladimir Ivanov).
1312
ajsd2c1f162004-12-08 21:10:20 +000013132004-12-08 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1314
1315 * *.c: Change level of debug messages to LOG_DEBUG.
1316
ajs274a4a42004-12-07 15:39:31 +000013172004-12-07 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1318
1319 * bgp_main.c: (main) The 2nd argument to openzlog has been removed.
1320
ajs887c44a2004-12-03 16:36:46 +000013212004-12-03 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1322
1323 * bgp_main.c: (sigint) Use zlog_notice for termination message.
1324 (main) Use zlog_notice for startup announcement.
1325
hassoc0652302004-11-25 19:33:48 +000013262004-11-25 Hasso Tepper <hasso at quagga.net>
1327
1328 * bgp_main.c: Make group to run as configurable.
1329
paul59320202004-11-09 01:54:03 +000013302004-11-09 Paul Jakma <paul@dishone.st>
1331
1332 * bgp_nexthop.c: collapse bgp_connected_ipvX, bgp_nexthop_cache_ipvX
1333 and cache{1,2}.. into arrays of tables and hence collapse
1334 bgp_scan_ipv{4,6} into a single bgp_scan function. Tested, though
1335 a long time ago (and this change was hand-merged).
1336
ajs5a646652004-11-05 01:25:55 +000013372004-11-04 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1338
1339 * bgp_route.c: Remove all code related to VTY_CONTINUE; this feature
1340 is deprecated because the output did not represent a single point
1341 in time. All output needs to be generated inline and buffered
1342 by the library code.
1343 (route_vty_out,route_vty_out_tag,damp_route_vty_out,
1344 flap_route_vty_out) Remove code to count number of lines of output,
1345 since this was only useful for VTY_CONTINUE behavior.
1346 (bgp_show_callback,vty_calc_line) Removed.
1347 (bgp_show_table) Remove hooks for VTY_CONTINUE callback support.
1348 As a result, there's a new output_arg argument to this function.
1349 Make function static.
1350 (bgp_show) Make function static and add a new output_arg argument.
1351 Change all functions that call bgp_show or bgp_show_table to
1352 pass the new output_arg argument (that used to be passed inside
1353 vty->output_arg).
1354 * bgp_mplsvpn.c: Remove declarations of functions defined in
1355 bgp_route.c; these declarations belong in bgp_route.h.
1356 * bgp_route.h: Declare 3 global functions used in both bgp_route.c
1357 and in bgp_mplsvpn.c.
1358
paula2b1ecd2004-10-31 18:58:09 +000013592004-10-31 Paul Jakma <paul@dishone.st>
1360
1361 * {bgpd,bgp_attr}.c: size_t printf format should be ld.
1362
paul98f51632004-10-25 14:19:15 +000013632004-10-25 Paul Jakma <paul@dishone.st>
1364
1365 * Update with fix in debian bug id 222930.
1366 * bgp_main.c: Add ZCAP_RAW, needed to bind to interfaces.
1367 bgp_network.c: (....) raise/lower privs around call to
1368 SO_BINDTODEVICE sockopt.
1369
hasso3fb9cd62004-10-19 19:44:43 +000013702004-10-19 Andrew J. Schorr <aschorr@telemetry-investments.com>
1371
1372 * bgp_nexthop.c: (bgp_connected_add) Connected destination pointer
1373 may be NULL.
1374 (bgp_connected_delete) ditto.
1375
hasso501ba492004-10-13 21:32:46 +000013762004-10-14 Hasso Tepper <hasso at quagga.net>
1377
1378 * bgp_dump.c: Make dump configuration appear in vtysh.
1379
hassoc75105a2004-10-13 10:33:26 +000013802004-10-13 Hasso Tepper <hasso at quagga.net>
1381
1382 * bgp_snmp.c: Remove defaults used to initialize smux connection to
1383 snmpd. Connection is initialized only if smux peer is configured.
hasso8b3126b2004-10-13 20:59:04 +00001384 * bgp_view.c: It's dead file. Reomved.
hassoc75105a2004-10-13 10:33:26 +00001385
paulfd79ac92004-10-13 05:06:08 +000013862004-10-13 Paul Jakma <paul@dishone.st>
1387
1388 * (global) more const'ification and fixups of types to clean up code.
1389 * bgp_mplsvpn.{c,h}: (str2tag) fix abuse. Still not perfect,
1390 should use something like the VTY_GET_INTEGER macro, but without
1391 the vty_out bits..
1392 * bgp_routemap.c: (set_aggregator_as) use VTY_GET_INTEGER_RANGE
1393 (no_set_aggregator_as) ditto.
1394 * bgpd.c: (peer_uptime) fix unlikely bug, where no buffer is
1395 returned, add comments about troublesome return value.
1396
hasso18a6dce2004-10-03 18:18:34 +000013972004-10-03 James R. Leu <jleu at mindspring.com>
1398
1399 * bgp_vty.c: Router id from zebra can be manually overriden.
1400 * bgp_zebra.c: Read router id related messages from zebra daemon.
1401 Remove own code related with router id selection.
1402 * bgpd.c, bgpd.h: Remove own router id selection code. Use the one
1403 from zebra daemon if it isn't manually overriden.
1404
hassoc9e52be2004-09-26 16:09:34 +000014052004-09-26 Hasso Tepper <hasso at quagga.net>
1406
1407 * bgp_aspath.c, bgp_packet.c, bgp_vty.c: Fix compiler warnings.
1408
hasso52dc7ee2004-09-23 19:18:23 +000014092004-09-23 Hasso Tepper <hasso at quagga.net>
1410
1411 * *.[c|h]: list -> struct list *, listnode -> struct listnode *.
1412
paule01f9cb2004-07-09 17:48:53 +000014132004-07-09 Paul Jakma <paul@dishone.st>
1414
1415 * Merge of GNU Zebra cvs2svn changesets r799, r800 and r807.
1416 * bgp_dump.c: (bgp_dump_attr) cleanup. return status code. check
1417 attributes present before printing.
1418 * bgp_dump.c: update bgp_dump_attr prototype.
1419 * bgp_packet.c: (bgp_update_receive) init attrstr. check status
1420 of bgp_dump_attr. Log end-of-rib UPDATEs.
1421
paulf5ba3872004-07-09 12:11:31 +000014222004-07-09 Sowmini Varadhan <sowmini.varadhan@sun.com>
1423
1424 * bgp_packet.c: (bgp_collision_detect) Send NOTIFY on new socket
1425 if that is connection we're closing.
1426 (bgp_read) invalid marker check applies to KEEPALIVE too.
1427 * bgp_route.c: Ignore multicast NRLI, dont send NOTIFY.
1428
paul5228ad22004-06-04 17:58:18 +000014292004-06-04 Paul Jakma <paul@dishone.st>
1430
1431 * type mismatch fixes
1432
hasso538621f2004-05-21 09:31:30 +000014332004-05-21 Akihiro Mizutani <mizutani@net-chef.net>
1434
1435 * bgpd.h, bgp_open.[ch], bgp_debug.c, bgp_vty.[ch], bgp_fsm.c:
1436 Graceful restart capability display.
1437
hasso3950fda2004-05-20 10:22:49 +000014382005-05-20 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1439
1440 * bgp_debug.c: Cosmetical fixes and log neighbor changes.
1441
hasso4372df72004-05-20 10:20:02 +000014422004-05-20 Akihiro Mizutani <mizutani@net-chef.net>
1443
1444 * bgp_ecommunity.c: Transit ecommunity support.
1445 * bgp_ecommunity.c: Fix for unknown community crush.
1446
hassoe0701b72004-05-20 09:19:34 +000014472005-05-20 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1448
1449 * *: Maximum prefix threshold support.
1450 * *: Reset notification fixups.
1451
paul0a589352004-05-08 11:48:26 +000014522004-05-08 Paul Jakma <paul@dishone.st>
1453
1454 * bgp_zebra.c: (bgp_interface_address_add) sync to zclient changes
1455 (bgp_interface_address_delete) ditto.
1456 (bgp_zebra_announce) ditto.
1457 (bgp_zebra_withdraw) ditto.
1458
paulc5317402004-05-03 13:25:06 +000014592004-05-03 Daniel Roesen <dr@cluenet.de>
1460
1461 * bgp_fsm.c: (bgp_stop) Reset uptime only on transition from
1462 Established so that it reflects true downtime (rather time
1463 since last transition, eg Active->Idle)
1464
paul35be31b2004-05-01 18:17:04 +000014652004-05-01 rivo nurges <rix@estpak.ee>
1466
1467 * bgp_route.c: fix UNH IOL BGP-4.1.12f
1468
pauleb821182004-05-01 08:44:08 +000014692004-05-01 Paul Jakma <paul@dishone.st>
1470
1471 * Revert the attempted clean-up of the dummy peer hack, reverts
1472 patchsets 435 (see 2004-02-17 below) and 456.
1473
paul545acaf2004-04-20 15:13:15 +000014742004-04-16 rivo nurges <rix@estpak.ee>
1475
hasso9b87e412004-04-20 16:54:49 +00001476 * bgpd.h, bgp_debug.c: update cease subcodes to
1477 draft-ietf-idr-cease-subcode-05
paul545acaf2004-04-20 15:13:15 +00001478 * bgpd.h, bgpd.c, bgp_route.c, bgp_route.h: fix UNH IOL BGP-4.1.6a
1479
paul6ad23f02004-02-17 19:45:10 +000014802004-02-17 Paul Jakma <paul@dishone.st>
1481
1482 * bgpd.h: (bgp_peer) add fd_local and fd_accept
1483 file descriptor's, fd becomes a pointer to one of these.
1484 * bgpd.c: (global) adjust for fact that fd is now a pointer.
1485 (peer_create_accept) removed.
1486 * bgp_route.c: (global) adjust for change of peer fd to pointer
1487 * bgp_packet.c: (bgp_collision_detect) adjust and remove the
1488 "replace with other peer" hack.
1489 * bgp_network.c: (bgp_accept) Remove the dummy peer hack.
1490 Update peer->fd_accept instead.
1491 (global) Adjust fd references - now a pointer.
1492 * bgp_fsm.c: (global) adjust peer fd to pointer.
1493 (bgp_connection_stop) new function, to stop connection.
1494 (global) adjust everything which closed peer fd to use
1495 bgp_connection_stop().
1496
gdt10d60ad2003-12-23 17:34:39 +000014972003-12-23 Krzysztof Oledzki <oleq@ans.pl>
1498
1499 * bgp_network.c: drop privs on error cases
1500
paul6ad23f02004-02-17 19:45:10 +000015012003-08-11 kunihiro <kunihiro@zebra.org>
paulac41b2a2003-08-12 05:32:27 +00001502
1503 * bgp_route{,map}.c: Extend 'set ip next-hop' in route-maps with
1504 ability to specify 'peer-address' rather than IP.
1505
paul9238b1e2003-06-11 08:03:08 +000015062003-06-09 Paul Jakma <paul@dishone.st>
1507
1508 * bgp_clist.c (community_list_delete): honour deny statements
1509
paul445f1432003-05-16 19:00:31 +000015102003-04-19 Hasso Tepper <hasso@estpak.ee>
1511
1512 * rip_routemap.c: sync daemon's route-map commands to have same
1513 syntax
1514
15152003-01-09 Akihiro Mizutani <mizutani@net-chef.net>
1516
1517 * bgp_routemap.c: Add match extcommunity command.
1518
paul718e3742002-12-13 20:15:29 +000015192002-10-23 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1520
1521 * bgp_aspath.c (aspath_init): Extend hash size from default to
1522 32767.
1523 (aspath_key_make): Use unsigned shoft for making hash. Suggested
1524 by: Marc Evans <Marc@SoftwareHackery.Com>
1525
15262002-08-19 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1527
1528 * bgp_clist.c (community_entry_free): Fix memory leak of standard
1529 extcommunity-list config string.
1530
15312002-08-19 Akihiro Mizutani <mizutani@net-chef.net>
1532
1533 * bgp_route.c (route_vty_out_detail): Fix bug of router-id display
1534 when multiple instance is used.
1535
15362002-08-18 Akihiro Mizutani <mizutani@net-chef.net>
1537
1538 * bgpd.c: Make "default-originate" and "maximum-prefix" commands
1539 available in peer-group configuration.
1540
15412002-08-13 Akihiro Mizutani <mizutani@net-chef.net>
1542
1543 * bgp_packet.c (bgp_open_send): Put Opt Parm Len 0 when last
1544 capability packet cause error or dont-capability-negotiate option
1545 is specified.
1546
15472002-07-07 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1548
1549 * zebra-0.93 released.
1550
15512001-10-28 Kunihiro Ishiguro <kunihiro@zebra.org>
1552
1553 * bgpd.c (bgp_vty_init): Translate update commands are removed.
1554
15552001-10-10 Kunihiro Ishiguro <kunihiro@zebra.org>
1556
1557 * bgp_route.c (bgp_static_set): Add workaround for BGP static
1558 route announcement when there is no zebra running.
1559
15602001-10-08 Kunihiro Ishiguro <kunihiro@zebra.org>
1561
1562 * bgpd.c (neighbor_remote_as_unicast): Remove "remote-as nlri
1563 unicast multicast" commands.
1564
15652001-09-14 Akihiro Mizutani <mizutani@dml.com>
1566
1567 * bgp_open.c: When we receive capability route-refresh, we should
1568 check we send the capability not we receive the capability.
1569
1570 * bgp_route.c (bgp_network_mask_natural_route_map): network
1571 statement route-map is added.
1572
15732001-08-31 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1574
1575 * bgp_advertise.c (bgp_advertise_intern): attr must be interned
1576 before looking up hash table.
1577
15782001-08-30 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1579
1580 * bgpd.h (struct peer): BGP filter is moved from peer_conf to
1581 peer.
1582
15832001-08-28 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1584
1585 * bgp_nexthop.c (bnc_nexthop_free): Fix next pointer bug.
1586 Suggested by: "Hong-Sung Kim" <hoskim@lanbird.co.kr>.
1587
15882001-08-26 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1589
1590 * bgp_table.c (bgp_node_create): Clearn memory before use it.
1591
15922001-08-24 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1593
1594 * Change to use bgp_table.[ch].
1595
15962001-08-23 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1597
1598 * bgpd.c (bgp_init): Add "transparent-as" and
1599 "transparent-nexthop" for old version compatibility.
1600
16012001-08-23 Akihiro Mizutani <mizutani@dml.com>
1602
1603 * bgpd.h (struct peer): default-originate route-map is added.
1604
1605 * bgp_route.c: When self originated route is advertised with
1606 attrubute-unchanged, nexthop was not properly set. This bug is
1607 fixed.
1608
16092001-08-22 Akihiro Mizutani <mizutani@dml.com>
1610
1611 * bgpd.c (neighbor_attr_unchanged): transparent-as and
1612 transparent-next-hop commands are restructured. Instead of
1613 current transparent-* commands, attribute-unchanged command is
1614 introduced.
1615
1616 neighbor A.B.C.D attribute-unchanged [as-path|next-hop|med]
1617
1618 (neighbor_default_originate): "default-originate" configuration
1619 announce default route even 0.0.0.0/0 does not exists in BGP RIB.
1620
16212001-08-19 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1622
1623 * zebra-0.92a released.
1624
16252001-08-19 Akihiro Mizutani <mizutani@dml.com>
1626
1627 * bgpd.c: AF specific soft-reconfiguration inbound commands are
1628 added.
1629
16302001-08-17 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1631
1632 * bgp_route.c (bgp_show_callback): Do not do community NULL check.
1633
1634 * bgp_community.c (community_cmp): Add check for commnunity NULL
1635 check.
1636
1637 * bgp_routemap.c (route_match_community): Do not check comunity is
1638 NULL. It may match to community-list "^$".
1639
1640 * bgp_community.c (community_match): Add check for community is
1641 NULL case.
1642
16432001-08-17 Akihiro Mizutani <mizutani@dml.com>
1644
1645 * bgpd.c: AF specific route-reflector-client and
1646 route-server-client configuration are added.
1647
16482001-08-17 Rick Payne <rickp@ayrnetworks.com>
1649
1650 * bgp_clist.c (community_match_regexp): Check special ^$ case.
1651
16522001-08-17 Akihiro Mizutani <mizutani@dml.com>
1653
1654 * bgp_clist.c (community_list_match): Fix bug of community list
1655 permit and deny check.
1656
16572001-08-16 Akihiro Mizutani <mizutani@dml.com>
1658
1659 * bgp_mplsvpn.c (bgp_mplsvpn_init): Add AF specific "nexthop-self"
1660 command.
1661
16622001-08-15 Akihiro Mizutani <mizutani@dml.com>
1663
1664 * bgpd.h (PEER_FLAG_SEND_COMMUNITY): Per AF based configuration
1665 flag is introduced.
1666
1667 * bgp_mplsvpn.c (bgp_mplsvpn_init): VPNv4 filtering is added.
1668
16692001-08-15 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1670
1671 * zebra-0.92 released.
1672
16732001-08-13 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1674
1675 * bgpd.c (bgp_delete): "no router bgp" free static, aggregate, rib
1676 table properly.
1677
16782001-08-12 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1679
1680 * bgp_route.c (bgp_node_safi): Return SAFI of current node.
1681 (bgp_config_write_network_vpnv4): VPNv4 static configuration
1682 display.
1683
16842001-08-11 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1685
1686 * bgpd.c (no_bgp_ipv4_multicast_route_map): Add IPv4 multicast
1687 node filter commands.
1688
16892001-08-11 Kunihiro Ishiguro <kunihiro@zebra.org>
1690
1691 * bgpd.h (PEER_FLAG_IGNORE_LINK_LOCAL_NEXTHOP): Add
1692 "ignore-link-local-nexthop" flag for ignore link-local nexthop for
1693 IPv6.
1694
16952001-08-07 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1696
1697 * bgpd.c (address_family_ipv4_multicast): "address-family ipv4
1698 multicast" is added.
1699 (address_family_ipv6_unicast): "address-family ipv6 unicast" is
1700 added.
1701
17022001-08-07 Akihiro Mizutani <mizutani@dml.com>
1703
1704 * bgp_route.c (bgp_process): Use flag instead of as_selected
1705 memeber in struct bgp_info.
1706
1707 * bgp_route.h (struct bgp_info): Remove as_selected memeber from
1708 struct bgp_info.
1709
17102001-07-31 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1711
1712 * bgp_route.c (bgp_announce_check): Enclose sending time AS loop
1713 check code with #ifdef BGP_SEND_ASPATH_CHECK.
1714
17152001-07-29 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1716
1717 * bgp_packet.c (bgp_withdraw_send): Simplify address family check.
1718
1719 * bgpd.h (BGP_INFO_HOLDDOWN): Introduce new macro to check BGP
1720 information is alive or not.
1721
1722 * bgp_community.c: Use community_val_get() on all OS.
1723
17242001-07-24 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1725
1726 * bgp_route.c (bgp_announce_check): Simplify set next-hop self
1727 check.
1728
17292001-07-24 Akihiro Mizutani <mizutani@dml.com>
1730
1731 * bgp_route.c (bgp_announce_check): To route server clients, we
1732 announce AS path, MED and nexthop transparently.
1733
17342001-06-21 Kunihiro Ishiguro <kunihiro@zebra.org>
1735
1736 * bgp_routemap.c (route_set_atomic_aggregate_free): Do not call
1737 XFREE. No memory is allocated in
1738 route_set_atomic_aggregate_compile().
1739
17402001-06-21 Kunihiro Ishiguro <kunihiro@zebra.org>
1741
1742 * bgp_routemap.c (bgp_route_map_init): `match nlri` and `set nlri`
1743 are replaced by `address-family ipv4` and `address-family vpnvr'.
1744
17452001-06-19 Kunihiro Ishiguro <kunihiro@zebra.org>
1746
1747 * bgp_route.c (bgp_withdraw): Add check for BGP_PEER_CONFED.
1748 Reported by Rick Payne <rickp@rossfell.co.uk>.
1749
17502001-06-17 Kunihiro Ishiguro <kunihiro@zebra.org>
1751
1752 * bgp_zebra.c (bgp_zebra_announce): When global IPv6 nexthop is
1753 empty, use socket's remote address for the nexthop.
1754
17552001-06-04 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1756
1757 * bgpd.c (peer_delete): Fix memory leak. Reported by Yosi Yarchi
1758 <Yosi_Yarchi@KereniX.com>
1759
17602001-06-01 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1761
1762 * bgpd.c (bgp_delete): Fix memory leak. Reported by Yosi Yarchi
1763 <Yosi_Yarchi@KereniX.com>
1764
17652001-05-27 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1766
1767 * bgp_route.c (bgp_route_clear_with_afi_vpnv4): Use next instead
1768 of ri->next.
1769
1770 * bgp_packet.c (bgp_withdraw_send): MPLS/VPN withdraw takes effect
1771 when HAVE_IPV6 is not defined.
1772
17732001-03-07 "Akihiro Mizutani" <mizutani@dml.com>
1774
1775 * bgpd.c (peer_timers_set): Adjust keepalive timer to fit less
1776 than holdtime / 3.
1777 (bgp_confederation_peers_unset): Only set peer->local_as when
1778 confederation is enabled.
1779 (bgp_timers): Add "timers bgp <0-65535> <0-65535>" command.
1780
1781 * bgp_route.c (bgp_announce_check): Set med of redistributed route
1782 when it is announced to EBGP peer.
1783
17842001-03-06 "Akihiro Mizutani" <mizutani@dml.com>
1785
1786 * bgp_nexthop.c (bgp_scan_ipv4): bgp_scan() call bgp_process() for
1787 all prefixes.
1788
17892001-03-06 Kunihiro Ishiguro <kunihiro@zebra.org>
1790
1791 * bgp_attr.c (bgp_attr_origin): When bgpd send NOTIFICATION with
1792 erroneous attribute (type, length and value), it does include
1793 attribute flags field.
1794
17952001-02-21 "Akihiro Mizutani" <mizutani@dml.com>
1796
1797 * bgp_route.c (bgp_announce_check): The route reflector is not
1798 allowed to modify the attributes of the reflected IBGP routes.
1799
18002001-02-20 "Akihiro Mizutani" <mizutani@dml.com>
1801
1802 * bgp_route.c (bgp_info_cmp): During path seleciton, BGP
1803 confederation peer is treated as same as IBGP peer.
1804
18052001-02-19 Kunihiro Ishiguro <kunihiro@zebra.org>
1806
1807 * bgp_route.c (bgp_redistribute_add): Initialize attr_new with
1808 attr. Call aspath_unintern when return from this function.
1809
18102001-02-19 "Akihiro Mizutani" <mizutani@dml.com>
1811
1812 * bgpd.c (bgp_router_id_set): Reset BGP peer when router-id is
1813 changed.
1814
18152001-02-18 "Akihiro Mizutani" <mizutani@dml.com>
1816
1817 * bgp_packet.c (bgp_open_receive): When user configure holdtimer,
1818 do not refrect the value to current session.
1819
18202001-02-16 Kunihiro Ishiguro <kunihiro@zebra.org>
1821
1822 * bgp_route.c (bgp_aggregate_delete): Set BGP_INFO_ATTR_CHANGE to
1823 suppress route withdraw.
1824
1825 * bgp_damp.c (bgp_damp_init): Fix bug of flap dampening.
1826
18272001-02-16 "Akihiro Mizutani" <mizutani@dml.com>
1828
1829 * bgp_aspath.c (aspath_make_str_count): Use ',' for separator for
1830 AS_SET and AS_CONFED_SET.
1831
18322001-02-15 Kunihiro Ishiguro <kunihiro@zebra.org>
1833
1834 * bgp_route.c (bgp_process): Do not consider suppress route.
1835
1836 * bgp_aspath.c (aspath_aggregate_as_set_add): Reset asset when
1837 aspath->data is realloced.
1838
18392001-02-15 "Akihiro Mizutani" <mizutani@dml.com>
1840
1841 * bgp_attr.c (bgp_attr_aggregate_intern): Do not set atomic
1842 aggregate when using as-set.
1843
18442001-02-14 "Akihiro Mizutani" <mizutani@dml.com>
1845
1846 * bgpd.c (bgp_confederation_peers_unset): Set peer's local-as
1847 correctly.
1848
1849 * bgp_route.c (bgp_update): Just ignore AS path loop for
1850 confederation peer.
1851
18522001-02-10 Kunihiro Ishiguro <kunihiro@zebra.org>
1853
1854 * bgp_route.c (bgp_aggregate_set): Add as_set argument.
1855 (bgp_aggregate_unset): Remove summary_only argument.
1856 (aggregate_address_as_set): New commands.
1857 "aggregate-address A.B.C.D/M as-set"
1858 "no aggregate-address A.B.C.D/M as-set"
1859
18602001-02-08 "Akihiro Mizutani" <mizutani@dml.com>
1861
1862 * bgp_route.c (bgp_announce_check): Do not modify nexthop when the
1863 route is passed by route reflector.
1864
18652001-02-08 Kunihiro Ishiguro <kunihiro@zebra.org>
1866
1867 * bgp_route.c: "no bgp dampening" with argument.
1868 (bgp_announce_check): Do not modify nexthop when the route is
1869 passed by route reflector.
1870
18712001-02-07 "Akihiro Mizutani" <mizutani@dml.com>
1872
1873 * bgpd.c (neighbor_passive): Change "neighbor NEIGHBOR remote-as
1874 ASN passive" to "neighbor NEIGHBOR passive".
1875 (bgp_announce_check): Check well-known community attribute even
1876 when "no neighbor send-community" is set.
1877
18782001-02-03 Kunihiro Ishiguro <kunihiro@zebra.org>
1879
1880 * bgp_fsm.c (bgp_establish): Do not send keepalive at established
1881 time when keepalive timer is configured as zero.
1882
18832001-02-01 Kunihiro Ishiguro <kunihiro@zebra.org>
1884
1885 * bgp_attr.c (bgp_attr_check): When peer is IBGP peer, local
1886 preference is well-known attribute.
1887
18882001-01-30 Kunihiro Ishiguro <kunihiro@zebra.org>
1889
1890 * zebra-0.91 is released.
1891
1892 * bgp_attr.h (struct attr): Comment out DPA value.
1893 (struct attr): Change refcnt type from int to unsinged long.
1894
1895 * bgp_attr.c (attrhash_key_make): Likewise.
1896 (attrhash_cmp): Likewise.
1897 (bgp_attr_dpa): Likewise.
1898
18992001-01-30 "Akihiro Mizutani" <mizutani@dml.com>
1900
1901 * bgp_route.c (bgp_info_cmp): Make route selection completely same
1902 as Cisco's.
1903
19042001-01-30 Kunihiro Ishiguro <kunihiro@zebra.org>
1905
1906 * bgp_attr.h (BGP_ATTR_FLAG_OPTIONAL): Rename old ATTR_FLAG_* to
1907 BGP_ATTR_FLAG_* to clarify meenings.
1908
19092001-01-30 "Akihiro Mizutani" <mizutani@dml.com>
1910
1911 * bgp_route.c (route_vty_out): Display argument to suppress same
1912 prefix information display.
1913 (route_vty_out_route): Don't display mask information for
1914 classfull network.
1915
19162001-01-30 Kunihiro Ishiguro <kunihiro@zebra.org>
1917
1918 * bgp_attr.h (SET_BITMAP): Simple bitmapping macros.
1919
1920 * bgp_attr.c (bgp_attr_parse): Use bitmap for attribute type
1921 check.
1922
19232001-01-29 Kunihiro Ishiguro <kunihiro@zebra.org>
1924
1925 * bgp_attr.c (bgp_mp_reach_parse): Enclose loggin with BGP_DEBUG.
1926 (bgp_attr_parse): Comment out well-known attribute check.
1927
19282001-01-28 Kunihiro Ishiguro <kunihiro@zebra.org>
1929
1930 * bgp_route.c (bgp_static_unset): Link-local IPv6 address can't be
1931 used for network advertisement.
1932 (nlri_parse): When link-local IPv6 address NLRI comes from
1933 remote-peer, log the information then simply ignore it.
1934
1935 * bgp_zebra.c (zebra_read_ipv6): Link-local IPv6 address is not
1936 redistributed.
1937
1938 * bgp_route.c (bgp_update): Check IPv6 global nexthop
1939 reachability.
1940
19412001-01-26 Kunihiro Ishiguro <kunihiro@zebra.org>
1942
1943 * bgp_route.c (bgp_update): Check nexthop points local address or
1944 not.
1945 (bgp_static_update_vpnv4): Set valid flag.
1946
1947 * bgp_attr.c (bgp_attr_parse): Duplicate attribute check.
1948 (bgp_attr_parse): Well-known attribute check.
1949
1950 * bgp_open.c (bgp_auth_parse): Authentication is not yet supported.
1951
1952 * bgp_packet.c (bgp_valid_marker): Check marker is synchronized.
1953
1954 * bgpd.c (clear_bgp): Send NOTIFICATION Cease when SEND_CEASE is
1955 defined.
1956
1957 * bgp_snmp.c (bgp4PathAttrTable): Fix compile error.
1958
19592001-01-24 Kunihiro Ishiguro <kunihiro@zebra.org>
1960
1961 * bgpd.c (bgp_network_import_check): New command for IGP network
1962 check.
1963
19642001-01-23 Kunihiro Ishiguro <kunihiro@zebra.org>
1965
1966 * bgp_nexthop.c (bgp_scan): Run bgp_process when IGP metric is
1967 changed. Call bgp_process once for each node.
1968
19692001-01-23 "Akihiro Mizutani" <mizutani@dml.com>
1970
1971 * bgp_route.c (bgp_info_cmp): Add IGP metric comparison.
1972
19732001-01-23 Kunihiro Ishiguro <kunihiro@zebra.org>
1974
1975 * bgp_route.c (bgp_info_cmp): Add IGP metric comparison.
1976
1977 * bgp_nexthop.c (bgp_nexthop_lookup): Set IGP metric for valid
1978 IBGP route.
1979
19802001-01-23 "Akihiro Mizutani" <mizutani@dml.com>
1981
1982 * bgp_route.c (show_ip_bgp_prefix_longer): Add new commands.
1983 "show ip bgp A.B.C.D/M longer-prefixes"
1984 "show ip bgp ipv4 (unicast|multicast) A.B.C.D/M longer-prefixes"
1985 "show ipv6 bgp X:X::X:X/M longer-prefixes"
1986 "show ipv6 mbgp X:X::X:X/M longer-prefixes"
1987
19882001-01-20 "Akihiro Mizutani" <mizutani@dml.com>
1989
1990 * bgp_route.c (show_ip_bgp_cidr_only): Add new commands.
1991 "show ip bgp cidr-only"
1992 "show ip bgp ipv4 (unicast|multicast) cidr-only"
1993
19942001-01-18 "Akihiro Mizutani" <mizutani@dml.com>
1995
1996 * bgp_route.c (bgp_update): AS path lookup check is done in
1997 bgp_update() not in attr_parse().
1998
19992001-01-18 Kunihiro Ishiguro <kunihiro@zebra.org>
2000
2001 * bgp_route.c (bgp_update): Call bgp_aggregate_decrement() just
2002 before bgp_attr_unintern().
2003
20042001-01-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2005
2006 * bgp_route.c (bgp_update): Now intern is performed very last part
2007 of the BGP packet update procedure.
2008
20092001-01-17 "Akihiro Mizutani" <mizutani@dml.com>
2010
2011 * bgp_route.c (bgp_update): When implicit withdraw occur, reuse
2012 existing bgp_info structure.
2013
20142001-01-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2015
2016 * bgp_route.c (bgp_aggregate_decrement): Fix bug of aggregate
2017 address matching method.
2018 (bgp_update):
2019
2020 * bgp_nexthop.c (bgp_nexthop_onlink): Separate EBGP nexthop onlink
2021 check and IBGP nexthop route check.
2022
20232001-01-16 "Akihiro Mizutani" <mizutani@dml.com>
2024
2025 * bgp_route.h (BGP_INFO_ATRR_CHANGED): Added for track attribute
2026 change.
2027
20282001-01-16 Kunihiro Ishiguro <kunihiro@zebra.org>
2029
2030 * bgp_route.h (struct bgp_info): Remove selected flag. Use
2031 BGP_INFO_SELECTED for flags instead.
2032 (struct bgp_info): Remove valid flag. Use BGP_INFO_VALID for
2033 flags instead.
2034 (struct bgp_info): Add igpmetric for IBGP route nexthop IGP
2035 metric.
2036 (struct bgp_info_tab): Struct bgp_info_tag is integrated into
2037 struct bgp_info.
2038 (BGP_INFO_ATRR_CHANGED): Added for track attribute change.
2039
2040 * bgp_community.c (community_val_get): gcc-2.95 on
2041 sparc-sun-solaris cause crush. This function is for avoid the
2042 crush.
2043
20442001-01-15 Kunihiro Ishiguro <kunihiro@zebra.org>
2045
2046 * bgp_packet.c (bgp_open_receive): Translated peer's packet_size
2047 clear bug is fixed.
2048
20492001-01-14 "Akihiro Mizutani" <mizutani@dml.com>
2050
2051 * bgp_packet.c (bgp_open_receive): Return notification with
2052 supported version number.
2053
20542001-01-13 Kunihiro Ishiguro <kunihiro@zebra.org>
2055
2056 * bgpd.c (bgp_show_summary): Display AS path and community
2057 entries. Suggested by: "Matt Ranney" <mjr@ranney.com>.
2058
2059 * bgp_packet.c (bgp_read_packet): Fix bug of unblocking BGP socket
2060 read. When BGP packet read is partial, we must get size and type
2061 from packet again.
2062
20632001-01-12 "Akihiro Mizutani" <mizutani@dml.com>
2064
2065 * bgp_route.c (bgp_update): Do not unset BGP_INFO_HISTORY flag.
2066 (bgp_update): When there is a history entry increment route count.
2067 (bgp_damp_set): Check BGP_CONFIG_DAMPENING flag.
2068
2069 * bgp_damp.c (bgp_damp_withdraw): Set status to
2070 BGP_DAMP_DISCONTINUE.
2071
20722001-01-11 Kunihiro Ishiguro <kunihiro@zebra.org>
2073
2074 * bgp_attr.c (bgp_mp_reach_parse): Fix warning code when second
2075 IPv6 nexthop is not link-local addresss.
2076
20772001-01-11 "Akihiro Mizutani" <mizutani@dml.com>
2078
2079 * bgp_damp.c (bgp_config_write_damp): Smart flap dampening
2080 configuration display.
2081 (bgp_damp_info_print): Display elapsed time from flap started.
2082
2083 * bgp_damp.h (struct bgp_damp_info): Add flap start time.
2084
2085 * bgpd.c (peer_create): Set last read time.
2086 (bgp_show_peer): Display last read time.
2087 (bgp_show_summary): Use BGP_CONFIG_DAMPENING flag to check
2088 configuration.
2089
2090 * bgpd.h (BGP_CONFIG_DAMPENING): Add new configuration option.
2091 (struct peer): Add last read time member.
2092 (BGP_VERSION_MP_4): Remove obsolete definition.
2093
20942001-01-10 Kunihiro Ishiguro <kunihiro@zebra.org>
2095
2096 * bgp_nexthop.c: Remove OLD_RIB codes.
2097
2098 * bgp_route.c (bgp_process): Likewise.
2099
2100 * zebra-0.90 is released.
2101
2102 * bgp_route.h (BGP_INFO_HISTORY): Remove damped member from struct
2103 bgp_info. Instead of that use BGP_INFO_DAMPED flag.
2104 (struct bgp_info): Remove invalid member from struct bgp_info.
2105 Instead of that use BGP_INFO_HISTORY flag.
2106
21072001-01-10 "Akihiro Mizutani" <mizutani@dml.com>
2108
2109 * bgp_damp.c (bgp_damp_info_print): New function to display
2110 dampening status.
2111 (DEFAULT_HARF_LIFE): Define default value.
2112 (DEFAULT_REUSE): Likewise.
2113 (DEFAULT_SUPPRESS): Likewise.
2114 (bgp_config_write_damp): When config value is same as default
2115 value, simply display "bgp dampening" to configuration.
2116
2117 * bgp_damp.h (struct bgp_damp_info): Add flap member.
2118
2119 * bgp_route.h (struct bgp_info): Added for BGP flap dampening
2120 history status.
2121
21222001-01-10 Kunihiro Ishiguro <kunihiro@zebra.org>
2123
2124 * bgp_nexthop.c (bgp_connected_add): Point-to-point connected
2125 address is properly handled.
2126 (bgp_connected_delete): Likewise.
2127
2128 * bgp_route.c (bgp_route_init): Turn off BGP Flap dampening code
2129 until it works fine.
2130
21312001-01-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2132
2133 * bgpd.c (bgp_show_summary): Add BGP_VERSION_MP_4 case.
2134
2135 * bgp_route.c (bgp_update): When this is not damped route, clear
2136 ri pointer.
2137
21382001-01-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2139
2140 * bgp_main.c: Add "-n" no_kernel option to not install route to
2141 kernel. Suggested by: "Matt Ranney" <mjr@ranney.com>
2142
21432001-01-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2144
2145 * bgp_nexthop.c (bgp_connected_add): Revert point-to-point
2146 connected route patch. Reported by ruud@ruud.org (Ruud de Rooij)
2147
2148 * bgp_damp.c (bgp_config_write_damp): Add configuration display
2149 function.
2150
2151 * bgp_route.c (bgp_info_free): Set NULL to BGP dampening
2152 information when BGP info structure is freed.
2153 (bgp_info_cmp): Check damped flag.
2154 (bgp_announce_check): Damped route is not announced.
2155
21562001-01-09 "Akihiro Mizutani" <mizutani@dml.com>
2157
2158 * bgpd.c (neighbor_capability_route_refresh): Change "neighbor
2159 route-refresh" command to "neighbor capability route-refresh".
2160 (clear_bgp_soft_in): Change soft-reconfig method.
2161
2162 clear ip bgp <neighbor> soft in
2163 --------------------------------------
2164 Try stored cache first then route-refresh
2165
2166 clear ip bgp <neighbor> in
2167 ---------------------------------
2168 Try route-refresh first then try to use stored cache
2169
21702001-01-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2171
2172 * bgp_nexthop.c (bgp_connected_add): Check point-to-point
2173 connected route. Reported by ruud@ruud.org (Ruud de Rooij)
2174
21752001-01-08 Kunihiro Ishiguro <kunihiro@zebra.org>
2176
2177 * bgp_nexthop.c (bgp_nexthop_lookup): When IBGP nexthop is
2178 changed, refresh it.
2179
21802001-01-04 Kunihiro Ishiguro <kunihiro@zebra.org>
2181
2182 * bgp_route.h (struct bgp_info_tag): Add as_selected to
2183 bgp_info_tag.
2184
21852001-01-03 Kunihiro Ishiguro <kunihiro@zebra.org>
2186
2187 * bgp_route.h (struct bgp_info_tag): Add damped and bgp_damp_info
2188 member for BGP flap dampening.
2189
2190 * bgp_damp.c: New file is added.
2191
2192 * bgp_damp.h: Likewise.
2193
21942001-01-01 Kunihiro Ishiguro <kunihiro@zebra.org>
2195
2196 * bgpd.h (BGP_VTYSH_PATH): Change "/tmp/bgpd" to "/tmp/.bgpd".
2197
21982000-12-29 Kunihiro Ishiguro <kunihiro@zebra.org>
2199
2200 * bgp_nexthop.c (zlookup_connect): Change to use UNIX domain
2201 socket for zebra communication.
2202
22032000-12-29 Akihiro Mizutani <mizutani@dml.com>
2204
2205 * bgp_route.c (bgp_process): Fix "bgp deterministic-med" process.
2206
22072000-12-27 Akihiro Mizutani <mizutani@dml.com>
2208
2209 * bgp_route.c (bgp_process): Add "bgp deterministic-med" process.
2210
22112000-12-25 Akihiro Mizutani <mizutani@dml.com>
2212
2213 * bgp_route.c (bgp_info_cmp): Use ntohl comparing router ID.
2214
22152000-12-18 Akihiro Mizutani <mizutani@dml.com>
2216
2217 * bgp_route.c (bgp_info_cmp): When over three same prefix exit,
2218 withdrawing best prefix perform router ID comparison.
2219
22202000-12-15 Akihiro Mizutani <mizutani@dml.com>
2221
2222 * bgp_route.c (bgp_info_cmp): Do not compare router ID when the
2223 routes comes from EBGP peer. When originator ID is same, take
2224 shorter cluster-list route. If cluster-list is same take smaller
2225 IP address neighbor's route.
2226
2227 * bgpd.c (bgp_bestpath_aspath_ignore): Add "bgp bestpath as-path
2228 ignore" command. When this option is set, do not concider AS path
2229 length when route selection.
2230 (bgp_bestpath_compare_router_id): Add "bgp bestpath
2231 compare-routerid". When this option is set, compare router ID
2232 when the routes comes from EBGP peer.
2233
22342000-12-15 Akihiro Mizutani <mizutani@dml.com>
2235
2236 * bgp_route.c (bgp_info_cmp): Compare originator ID when it is
2237 available.
2238
22392000-12-14 Akihiro Mizutani <mizutani@dml.com>
2240
2241 * bgp_packet.c (bgp_notify_receive): Disply received Notify data
2242 information.
2243
22442000-12-14 Kunihiro Ishiguro <kunihiro@zebra.org>
2245
2246 * bgp_filter.c (as_filter_free): Use MTYPE_AS_FILTER_STR to make
2247 it sure the memory is freed.
2248
2249 * bgp_route.c (route_vty_out_detail): Do not use AF_INET6 outside
2250 HAVE_IPV6.
2251
22522000-12-08 Akihiro Mizutani <mizutani@dml.com>
2253
2254 * bgp_packet.c (bgp_notify_send_with_data): Store BGP notification
2255 data part.
2256
2257 * bgp_network.c (bgp_accept): When BGP connection comes from
2258 unconfigured IP address, close socket immediately.
2259
2260 * bgpd.c: Fix some display format.
2261
22622000-11-29 Kunihiro Ishiguro <kunihiro@zebra.org>
2263
2264 * bgp_packet.c (bgp_keepalive_send): Delete duplicate
2265 bgp_packet_set_size () call.
2266
22672000-11-28 Kunihiro Ishiguro <kunihiro@zebra.org>
2268
2269 * bgp_packet.c (bgp_read_packet): Remove debug codes.
2270
22712000-11-27 Kunihiro Ishiguro <kunihiro@zebra.org>
2272
2273 * bgp_snmp.c (write_bgpPeerTable): Add SNMP set method routine.
2274
2275 * bgp_fsm.c (bgp_stop): Use fsm_change_status to change peer's
2276 status.
2277 (bgp_establish): Likewise.
2278
22792000-11-26 Akihiro Mizutani <mizutani@dml.com>
2280
2281 * bgp_open.c: Fix error messages.
2282
22832000-11-25 Kunihiro Ishiguro <kunihiro@zebra.org>
2284
2285 * bgp_fsm.c (bgp_establish): Call BGP trap when the peer is
2286 established.
2287 (bgp_stop): Call BGP trap when the peer is dropped.
2288
22892000-11-24 Kunihiro Ishiguro <kunihiro@zebra.org>
2290
2291 * bgp_snmp.c (bgp4PathAttrTable): Return BGP path attribute table.
2292
2293 * bgpd.h (struct peer): Add update_time for track last update
2294 received time.
2295
2296 * bgp_packet.c (bgp_notify_receive): Preserv notify code and sub
2297 code in any case.
2298
2299 * bgp_snmp.c (bgpPeerTable): Return remote router ID instead of
2300 peering IP address.
2301 (bgpPeerTable): Return actual BGP version number.
2302
23032000-11-22 Akihiro Mizutani <mizutani@dml.com>
2304
2305 * bgp_debug.c (bgp_notify_print): Notify data length display bug
2306 is fixed.
2307
23082000-11-16 Kunihiro Ishiguro <kunihiro@zebra.org>
2309
2310 * bgp_nexthop.c (zlookup_connect): When UNIX domain connection to
2311 zebra is enabled, use the method.
2312
23132000-11-16 Akihiro Mizutani <mizutani@dml.com>
2314
2315 * bgpd.c: Revise debug message output.
2316
23172000-11-15 Akihiro Mizutani <mizutani@dml.com>
2318
2319 * bgp_clist.c (ip_community_list): Fix bug of string comparison.
2320
23212000-11-14 Akihiro Mizutani <mizutani@dml.com>
2322
2323 * bgp_community.c (community_match): Fix bug of memcmp return
2324 value check.
2325
23262000-11-07 Kunihiro Ishiguro <kunihiro@zebra.org>
2327
2328 * bgp_clist.c (community_list_match_exact): Add check for
2329 entry->style is COMMUNITY_LIST.
2330 (community_match_regexp): Apply new com_nthval macro.
2331
23322000-11-07 Rick Payne <rickp@rossfell.co.uk>
2333
2334 * bgp_routemap.c (route_set_community_delete): "set
2335 community-delete COMMUNITY-LIST" is added.
2336
2337 * bgp_community.c (community_del_val): Delete one community.
2338 (community_delete): Delete all community included in list.
2339 (community_match): Fix bug of matching community value.
2340
2341 * bgp_clist.c (community_entry_free): Free community regular
2342 expression.
2343 (community_entry_make): Default style is COMMUNITY_LIST.
2344 (community_entry_lookup): Make it sure style is COMMUNITY_LIST.
2345 (community_entry_regexp_lookup): New function for community
2346 regular expression lookup.
2347 (community_match_regexp): New function.
2348 (community_delete_regexp): New function.
2349 (community_list_delete_entries): New function.
2350 (community_list_match): Add COMMUNITY_REGEXP treatment.
2351 (community_list_match_exact): Likewise.
2352 (config_write_community): Write community list according to
2353 entry->style.
2354
23552000-11-07 Rick Payne <rickp@rossfell.co.uk>
2356
2357 * bgp_attr.c (bgp_attr_aspath): AS path first AS check.
2358
2359 * bgp_clist.c (struct community_entry): Add style, regexp, reg to
2360 community_entry.
2361
23622000-11-06 Rick Payne <rickp@rossfell.co.uk>
2363
2364 * bgp_aspath.c (aspath_firstas_check): AS path first AS check.
2365
2366 * bgpd.c (bgp_enforce_first_as): New command "bgp
2367 enforce-first-as".
2368
2369 * bgpd.h (BGP_CONFIG_ENFORCE_FIRST_AS): Add new flag.
2370
23712000-11-06 Kunihiro Ishiguro <kunihiro@zebra.org>
2372
2373 * bgp_community.c (community_compare): Copy byte stream data to
2374 actual value instead of using type casting hack.
2375 (community_add_val): Likewise.
2376 (community_uniq_sort): Likewise.
2377 (community_print): Likewise.
2378 (community_print_vty): Likewise.
2379 (community_include): Use memcmp to compare community value.
2380
2381 * bgp_community.h (com_lastval): com_lastval and com_nthval macro
2382 return pointer.
2383
23842000-11-06 Akihiro Mizutani <mizutani@dml.com>
2385
2386 * bgpd.h (struct peer): Add established and dropped member for
2387 count peering up/down statistics.
2388
2389 * bgpd.c (bgp_show_peer): Display peering up/down statistics.
2390
2391 * bgp_fsm.c (bgp_establish): Increment established count.
2392 (bgp_stop): Increment dropped count.
2393
2394 * bgp_packet.c (bgp_notify_receive): Increament notify count.
2395
23962000-11-1 Akihiro Mizutani <mizutani@dml.com>
2397
2398 * bgp_fsm.c: Fix bug of holdtimer is not reset when bgp cleared.
2399
24002000-10-31 Kunihiro Ishiguro <kunihiro@zebra.org>
2401
2402 * bgpd.h: Static bit flag is set by (1 << DIGIT).
2403
24042000-10-24 Akihiro Mizutani <mizutani@dml.com>
2405
2406 * bgp_ecommunity.c (ecommunity_dup): Extended community display
2407 format fix.
2408
24092000-10-24 Arkadiusz Miskiewicz <misiek@pld.org.pl>
2410
2411 * bgp_network.c (bgp_serv_sock_addrinfo): Use gai_strerror.
2412 (bgp_serv_sock_addrinfo): Check address family.
2413
24142000-10-23 Jochen Friedrich <jochen@scram.de>
2415
2416 * bgp_snmp.c: bgp_oid and bgpd_oid are used in smux_open after it
2417 is registered. So those variables must be static.
2418
24192000-10-23 Akihiro Mizutani <mizutani@dml.com>
2420
2421 * bgp_routemap.c (route_match_ip_next_hop): Change "match ip
2422 next-hop" argument from IP address to access-list name.
2423 Remove zebra-0.88 compatibility commands.
2424 "match ip prefix-list WORD"
2425 "match ipv6 prefix-list WORD"
2426
24272000-10-23 Kunihiro Ishiguro <kunihiro@zebra.org>
2428
2429 * bgp_routemap.c (route_match_ipv6_next_hop_compile): Fix bug of
2430 passing the pointer to the pointer of struct in6_addr instead of
2431 the pointer of struct in6_addr in "match ipv6 next-hop" command.
2432
2433 * bgp_route.c (bgp_announce_check): Enclose IPv6 part with
2434 HAVE_IPV6.
2435
24362000-10-20 Jasper Wallace <jasper@ivision.co.uk>
2437
2438 * bgp_snmp.c (bgpPeerTable): ntohs missing bug is fixed. Change
2439 to use linklist.c. Define COUNTER32 as ASN_COUNTER.
2440
24412000-10-18 Kunihiro Ishiguro <kunihiro@zebra.org>
2442
2443 * bgp_route.c (bgp_announce_check): attr->nexthop empty check
2444 should be done by attr->nexthop.s_addr instead of strcmp.
2445
24462000-10-18 Akihiro Mizutani <mizutani@dml.com>
2447
2448 * bgp_zebra.c (zebra_read_ipv4): Pass nexthop value to
2449 bgp_redistribute_add().
2450
2451 * bgp_nexthop.c (bgp_multiaccess_check_v4): New function for
2452 checking IPv4 multiaccess nexthop.
2453
2454 * bgp_route.c (bgp_announce_check): In case of the nexthop is
2455 reachable on multiaccess media, do not change nexthop.
2456 (bgp_redistribute_add): Set nexthop when the value is passed.
2457
24582000-10-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2459
2460 * bgp_fsm.c (bgp_timer_set): If peer is passive mode, do not set
2461 connect timer.
2462 (bgp_start): If the peer is passive mode, force to move to Active
2463 mode.
2464
24652000-10-17 Horms <horms@vergenet.net>
2466
2467 * bgp_debug.c (debug_bgp_fsm): Fix typo.
2468
24692000-10-17 Akihiro Mizutani <mizutani@dml.com>
2470
2471 * bgp_route.c: "show ipv6 bgp" route display improvement.
2472
24732000-10-03 Kunihiro Ishiguro <kunihiro@zebra.org>
2474
2475 * bgp_route.c (neighbor_routes): Allocate sockunion for callback
2476 function.
2477 (bgp_show_neighbor_route): Remove static declaration for union
2478 sockunion.
2479
2480 * bgpd.c (peer_update_source_set): Clean previously allocated
2481 memory before allocate new one.
2482
24832000-10-03 Akihiro Mizutani <mizutani@dml.com>
2484
2485 * bgp_route.c (neighbor_routes): Add show neighbor's routes
2486 command.
2487 "show ip bgp neighbors (A.B.C.D|X:X::X:X) routes"
2488 "show ip bgp ipv4 (unicast|multicast) neighbors (A.B.C.D|X:X::X:X) routes"
2489 "show ipv6 bgp neighbors (A.B.C.D|X:X::X:X) routes"
2490 "show ipv6 mbgp neighbors (A.B.C.D|X:X::X:X) routes"
2491
24922000-10-02 Kunihiro Ishiguro <kunihiro@zebra.org>
2493
2494 * zebra-0.89 is released.
2495
24962000-10-02 Akihiro Mizutani <mizutani@dml.com>
2497
2498 * bgpd.c: "bgp deterministic-med" command is added.
2499
25002000-10-02 Kunihiro Ishiguro <kunihiro@zebra.org>
2501
2502 * bgp_nexthop.c (bgp_connected_add): Apply mask for connected
2503 route addition and deletion.
2504
25052000-09-29 Kunihiro Ishiguro <kunihiro@zebra.org>
2506
2507 * bgp_aspath.c (aspath_cmp_left): Skip confederation AS segment
2508 when comparing leftmost AS number.
2509
25102000-09-29 Akihiro Mizutani <mizutani@dml.com>
2511
2512 * bgpd.c (peer_route_reflector): Route reflector can be set for
2513 IBGP peer.
2514 (bgp_distribute_set): Fix bug of string check for (in|out).
2515 (bgp_show_summary): Display total neighbor count.
2516
25172000-09-28 Akihiro Mizutani <mizutani@dml.com>
2518
2519 * bgp_attr.c (bgp_packet_attribute): Only add cluster_list and
2520 originator for clinet to client routes.
2521 (bgp_packet_attribute): Add new cluster_list to the beginning of
2522 existing cluster_list.
2523 (bgp_packet_attribute): Fix bug of originator is rewritten even
2524 when originator is already set.
2525
25262000-09-27 Kunihiro Ishiguro <kunihiro@zebra.org>
2527
2528 * bgpd.c (bgp_client_to_client_reflection): Add new command.
2529 "no bgp client-to-client reflection"
2530 "bgp client-to-client reflection"
2531
2532 * bgpd.h (BGP_CONFIG_NO_CLIENT_TO_CLIENT): Add new definition.
2533
25342000-09-26 Kunihiro Ishiguro <kunihiro@zebra.org>
2535
2536 * bgp_packet.c (bgp_read): Make BGP packet read to non-blocking
2537 read.
2538 (bgp_read_packet): Likewise.
2539 (bgp_read_packet): When errono is EAGAIN, try to read it again.
2540
2541 * bgp_fsm.c (bgp_stop): Clear packet size and read buffer.
2542
25432000-09-26 Akihiro Mizutani <mizutani@dml.com>
2544
2545 * bgp_routemap.c: Configuration of prefix-list match is shown as
2546 "match ip address prefix-list <WORD>". Old configuration "match
2547 ip prefix-list <WORD>" is left for compatibilitty.
2548
25492000-09-25 Akihiro Mizutani <mizutani@dml.com>
2550
2551 * bgpd.h (BGP_CONFIG_MED_MISSING_AS_WORST): Changed from
2552 BGP_CONFIG_MISSING_AS_WORST.
2553
2554 * bgpd.c (bgp_bestpath_med): Change missing-as-worst syntax.
2555 Old "bgp bestpath missing-as-worst"
2556 New "bgp bestpath med missing-as-worst"
2557
25582000-09-24 Akihiro Mizutani <mizutani@dml.com>
2559
2560 * bgp_route.c: Compare MED properly in case of CONFED-IBGP.
2561
25622000-09-21 steve@Watt.COM (Steve Watt)
2563
2564 * bgp_debug.h: Do not declare debug variables conf_bgp_debug_* and
2565 term_bgp_debug_*.
2566
2567 * bgp_debug.c: Declare variables here.
2568
25692000-09-21 Akihiro Mizutani <mizutani@dml.com>
2570
2571 * bgpd.c: MBGP soft-reconfiguration command is added.
2572 clear ip bgp x.x.x.x ipv4 (unicast|multicast) in
2573 clear ip bgp x.x.x.x ipv4 (unicast|multicast) out
2574 clear ip bgp x.x.x.x ipv4 (unicast|multicast) soft
2575 clear ip bgp <1-65535> ipv4 (unicast|multicast) in
2576 clear ip bgp <1-65535> ipv4 (unicast|multicast) out
2577 clear ip bgp <1-65535> ipv4 (unicast|multicast) soft
2578 clear ip bgp * ipv4 (unicast|multicast) in
2579 clear ip bgp * ipv4 (unicast|multicast) out
2580 clear ip bgp * ipv4 (unicast|multicast) soft
2581
2582 Change "clear ip bgp vpnv4 x.x.x.x soft" command to
2583 "clear ip bgp x.x.x.x vpnv4 unicast soft".
2584
2585 "bgp bestpath med confed" command is added.
2586
2587 * bgpd.h (BGP_CONFIG_MED_CONFED): Add New definition.
2588
25892000-09-18 Rick Payne <rickp@rossfell.co.uk>
2590
2591 * bgpd.c (bgp_show_peer): Fix misplaced #endif.
2592
25932000-09-12 Akihiro Mizutani <mizutani@dml.com>
2594
2595 * bgpd.c (bgp_default_local_preference): Add "bgp default
2596 local-preference" command.
2597
2598 * bgp_nexthop.c (no_bgp_scan_time): Add "no bgp scan-time"
2599 command.
2600
26012000-09-10 Kunihiro Ishiguro <kunihiro@zebra.org>
2602
2603 * bgp_zebra.c (bgp_zebra_announce): BGP confederation peer's routes
2604 are passed to zebra like IBGP route.
2605
26062000-09-10 Akihiro Mizutani <mizutani@dml.com>
2607
2608 * bgpd.c (bgp_config_write_peer): Make it consistent passive
2609 configuration.
2610
2611 * bgp_route.c: Community match command is added.
2612 "show ip bgp community <val>"
2613 "show ip bgp community <val> exact-match"
2614
26152000-09-08 Kunihiro Ishiguro <kunihiro@zebra.org>
2616
2617 * bgp_nexthop.c (bgp_nexthop_lookup): ebgp-multihop routes are
2618 treated as IBGP routes.
2619
26202000-09-08 Akihiro Mizutani <mizutani@dml.com>
2621
2622 * bgp_route.c (bgp_show_route): When local-AS community route is
2623 selected, display "not advertised outside local AS" to "show ip
2624 route A.B.C.D" output.
2625 (show_ip_bgp_ipv4_filter_list): Add below four commands.
2626 "show ip bgp ipv4 (unicast|multicast) filter-list WORD"
2627 "show ip bgp ipv4 (unicast|multicast) community"
2628 "show ip bgp ipv4 (unicast|multicast) community-list WORD"
2629 "show ip bgp ipv4 (unicast|multicast) community-list WORD exact-match"
2630
2631 * bgp_clist.c (community_list_match_exact): Community exact match
2632 function.
2633
26342000-09-07 Kunihiro Ishiguro <kunihiro@zebra.org>
2635
2636 * bgp_route.c (bgp_update): Add peer's ttl check.
2637
2638 * bgpd.h (struct peer): Structure member refresh is renamed to
2639 refresh_adv.
2640
2641 * bgpd.c (clear_bgp_soft_in): Check PEER_FLAG_ROUTE_REFRESH flag
2642 when soft reconfiguration is performed.
2643
2644 * bgp_zebra.c (bgp_zebra_announce): When the peer is EBGP and
2645 ebgp-multiphop is set, set ZEBRA_FLAG_INTERNAL for nexthop lookup.
2646
2647 * bgp_route.h (struct bgp_info_tag): Add valid flag.
2648
26492000-08-25 Akihiro Mizutani <mizutani@dml.com>
2650
2651 * bgpd.c: Add AS base BGP soft reconfiguration.
2652
2653 * bgp_route.c: When no-advertise or no-export route is selected,
2654 "show ip bgp" display "not advertised to EBGP peer" or "not
2655 advertised to any peer" message.
2656
26572000-08-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2658
2659 * zebra-0.88 is released.
2660
2661 * bgp_dump.c (dump_bgp_routes): Change "dump bgp routes" to "dump
2662 bgp route-mrt" to support MRT specific dump format.
2663
2664 * bgpd.c (bgp_init): "clear ip bgp vpnv4 soft {in,out}" command is
2665 added.
2666
2667 * bgp_route.c (bgp_update): Currently nexthop check is only works
2668 for IPv4.
2669
26702000-08-17 Akihiro Mizutani <mizutani@dml.com>
2671
2672 * bgpd. (clear_ip_bgp_all_soft): Add "clear ip bgp * soft" for
2673 both inbound and outbound soft reconfiguration.
2674
26752000-08-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2676
2677 * bgpd.c (clear_ip_bgp_peer_soft_out): Add soft-reconfiguration
2678 outbound.
2679 (peer_new): Set route-refresh flag.
2680
26812000-08-16 Akihiro Mizutani <mizutani@dml.com>
2682
2683 * bgpd.c: "no bgp router-id A.B.C.D" alias is added. "no bgp
2684 cluster-id A.B.C.D" alias is added. " bgp cluster-id
2685 <1-4294967295>" alias is added. "clear ip bgp * soft in" command
2686 is added. "clear ip bgp A.B.C.D in" alias is added. "clear ip
2687 bgp * in" alias is added.
2688
26892000-08-16 Kunihiro Ishiguro <kunihiro@zebra.org>
2690
2691 * bgp_route.c (bgp_update): Add soft_reconfig flag. When the flag
2692 is set do not install the route into Adj-RIBs-In.
2693 (bgp_update): Perform implicit withdraw before filtering of the
2694 route.
2695
2696 * bgp_packet.c (bgp_read): draft-ietf-idr-bgp-route-refresh-01.txt
2697 capability code and BGP message can be accepted.
2698
2699 * bgp_open.c (bgp_capability_parse): Likewise.
2700
2701 * bgp_route.c (bgp_refresh_table): New function for route refresh.
2702 (bgp_refresh_rib): Likewise.
2703
2704 * bgpd.c (bgp_show_peer): Display route refresh status.
2705
2706 * bgp_route.c (bgp_aggregate_add): Add check for the route
2707 validness.
2708 (bgp_aggregate_delete): Likewise.
2709
27102000-08-15 Kunihiro Ishiguro <kunihiro@zebra.org>
2711
2712 * bgp_nexthop.c (bgp_scan): Care for aggregate route when the
2713 route become inaccessible.
2714
27152000-08-15 Akihiro Mizutani <mizutani@dml.com>
2716
2717 * bgp_route.c (show_ip_bgp_prefix): "show ip bgp A.B.C.D/M"
2718 command is added.
2719
27202000-08-15 Kunihiro Ishiguro <kunihiro@zebra.org>
2721
2722 * bgp_zebra.c (bgp_interface_up): Register connected route.
2723 (bgp_interface_down): Unregister connected route.
2724
27252000-08-14 Kunihiro Ishiguro <kunihiro@zebra.org>
2726
2727 * bgp_route.h (struct bgp_info): Add distance to the structure.
2728
2729 * bgp_route.c (bgp_aggregate_increment): Aggregate route only
2730 match to smaller prefixlen route not match same prefixlen route.
2731 (bgp_aggregate_decrement): Likewise.
2732 (bgp_aggregate_add): Likewise.
2733 (bgp_aggregate_delete): Likewise.
2734 (bgp_network_backdoor): Add backdoor network configuration.
2735
2736 * bgpd.h (struct bgp ): Add distance_{ebgp,ibgp,local} for store
2737 configuration distance value.
2738
2739 * bgp_route.c (bgp_update): Filter EBGP route which has non
2740 connected nexthop.
2741
2742 * bgp_attr.c (bgp_attr_aggregate_intern): New function for
2743 aggregate route. Set origin to IGP. Set atomic aggregate flag.
2744 Set aggregator AS and address.
2745 (bgp_attr_aggregate_intern): Check BGP_CONFIG_CONFEDERATION when
2746 filling aggregator_as.
2747
2748 * bgp_route.c (bgp_process): Delete suppress check for install
2749 suppressed route into local routing table.
2750 (bgp_aggregate_increment): Use bgp_attr_aggregate_intern() instead
2751 of bgp_attr_default_intern ().
2752 (bgp_aggregate_add): Likewise.
2753
2754 * bgpd.c (bgp_get): Call bgp_if_update_all() after BGP instance is
2755 created. This is for avoid 0.0.0.0 router-id.
2756
27572000-08-13 Akihiro Mizutani <mizutani@dml.com>
2758
2759 * bgp_route.c (route_vty_out_detail): Display "valid" when the
2760 route is valied. Display "aggregated" when the route is
2761 aggregated. "Advertisements suppressed by an aggregate" is
2762 displayed when the route is suppressed.
2763 (bgp_info_cmp): Prefer EBGP than Confed-EBGP.
2764
27652000-08-10 Akihiro Mizutani <mizutani@dml.com>
2766
2767 * bgp_route.c (route_vty_out_detail): Display format change.
2768
27692000-08-06 Kunihiro Ishiguro <kunihiro@zebra.org>
2770
2771 * bgp_route.c (bgp_update): Only AFI_IP nexthop check is enabled.
2772
2773 * bgpd.c (bgp_delete): Delete static route before delete peer
2774 configuration.
2775
27762000-08-02 Kunihiro Ishiguro <kunihiro@zebra.org>
2777
2778 * bgpd.c: Include bgpd/bgp_nexthop.h.
2779
27802000-07-31 Akihiro Mizutani <mizutani@dml.com>
2781
2782 * bgpd.c (bgp_show_summary): "show ip bgp summary" shows own BGP
2783 identifier. And status is changed like below.
2784
2785 State/Pref -> State/PfxRcd
2786 Shutdown -> Idle (Admin)
2787 PrefixOvflw -> Idle (PfxCt)
2788
2789 * bgp_route.c (route_vty_out): Show internal route as "i".
2790
27912000-07-13 Jim Bowen <jimb@zereau.net>
2792
2793 * bgp_snmp.c: Add BGP peer MIB implementation.
2794
27952000-07-12 Akihiro Mizutani <mizutani@dml.com>
2796
2797 * bgpd.c (bgp_show_peer): Fix typo.
2798
27992000-07-11 Akihiro Mizutani <mizutani@dml.com>
2800
2801 * bgp_routemap.c: Add commands for deleting set without argument.
2802
28032000-07-03 Akihiro Mizutani <mizutani@dml.com>
2804
2805 * bgp_zebra.c: Fix redistribute help strings.
2806
28072000-07-01 Kunihiro Ishiguro <kunihiro@zebra.org>
2808
2809 * bgp_route.c (bgp_show): When bgpd works as vtysh server send all
2810 output to vty at once.
2811
28122000-06-13 Kunihiro Ishiguro <kunihiro@zebra.org>
2813
2814 * bgp_mplsvpn.c (no_vpnv4_network): "no network A.B.C.D/M rd WORD
2815 tag WORD" command is added.
2816
2817 * bgp_ecommunity.c (ecommunity_vty_out): New function added.
2818
28192000-06-12 Kunihiro Ishiguro <kunihiro@zebra.org>
2820
2821 * bgp_route.c (bgp_show): Fix total number of prefix count bug.
2822
2823 * bgpd.c (bgp_show_peer): Display VPNv4 unicast configuration and
2824 negotiation result in "show ip bgp neighbors".
2825
28262000-06-12 Akihiro Mizutani <mizutani@dml.com>
2827
2828 * bgpd.c: Fix help strings.
2829
2830 * bgpd.h: Likewise.
2831
28322000-06-11 Kunihiro Ishiguro <kunihiro@zebra.org>
2833
2834 * bgp_route.c (bgp_aggregate_unset): Fix bug of checking rn->info
2835 instead of rn. Reported by Akihiro Mizutani <mizutani@dml.com>.
2836
2837 * bgp_mplsvpn.c (vpnv4_network): For testing purpose, "network
2838 A.B.C.D rd RD" is added to address-family vpnv4 unicast node.
2839
2840 * bgp_route.c (bgp_static_set): Set safi to p.safi.
2841
28422000-06-10 Kunihiro Ishiguro <kunihiro@zebra.org>
2843
2844 * bgp_route.c (bgp_show_prefix_list): Change to use bgp_show().
2845 (bgp_show_regexp): Change to use bgp_show().
2846 (show_adj_route): Change to display header.
2847
2848 * bgpd.c (clear_bgp): Set peer->v_start to default value when peer
2849 is cleared manually.
2850
2851 * bgp_route.c (bgp_show_route): New function which display
2852 specific BGP route. Divided from bgp_show().
2853 (bgp_static_delete): Delete all static route.
2854
28552000-06-09 NOGUCHI Kay <kay@v6.access.co.jp>
2856
2857 * bgp_route.c (show_ipv6_bgp): "show ipv6 bgp" is broken with
2858 invalid privious fix. Now show_ipv6_bgp and show_ipv6_bgp_route
2859 take care of "show ipv6 bgp [X:X::X:X]". Same change for "show ip
2860 mbgp" and "show ipv6 mbgp".
2861
28622000-06-07 Akihiro Mizutani <mizutani@dml.com>
2863
2864 * bgp_route.c: Fix help strings and command arguments.
2865
28662000-06-06 Kunihiro Ishiguro <kunihiro@zebra.org>
2867
2868 * bgp_ecommunity.c: Include prefix.h
2869
28702000-06-05 Kunihiro Ishiguro <kunihiro@zebra.org>
2871
2872 * bgp_route.h (struct bgp_info_tag): New structure to hold tag
2873 value.
2874
2875 * bgp_route.c (bgp_adj_set): table NULL check is added.
2876 (bgp_adj_unset): Likewise.
2877 (bgp_adj_lookup): Likewise.
2878 (bgp_adj_clear): Likewise.
2879 (route_vty_out): Add SAFI check for nexthop display.
2880 (bgp_withdraw): Add SAFI check for withdraw route.
2881
2882 * Remove all #ifdef MPLS_VPN then include it as default.
2883
2884 * bgpd.c: Temporary disable peer-group command until the
2885 implementation is completed.
2886
2887 * bgp_routemap.c (bgp_route_map_init): Install
2888 route_metric_match_cmd.
2889 (route_match_metric_compile): MED value compile using strtoul.
2890
28912000-06-05 Akihiro Mizutani <mizutani@dml.com>
2892
2893 * bgp_filter.c: Fix help strings. Change REGEXP to LINE. Change
2894 NAME to WORD.
2895
2896 * Change command argument to more comprehensive.
2897
2898 METRIC -> <0-4294967295>
2899 WEIGHT -> <0-4294967295>
2900 LOCAL_PREF -> <0-4294967295>
2901 IP_ADDR -> A.B.C.D
2902 AS -> <1-65535>
2903 AS-PATH-NAME -> WORD
2904 ACCESS_LIST -> WORD
2905 PREFIX_LIST -> WORD
2906 COMMUNITY -> AA:NN
2907 EXT_COMMUNITY -> ASN:nn_or_IP-address:nn
2908 IPv6_ADDR -> X:X::X:X
2909
2910 * bgp_clist.c: Fix help strings.
2911
29122000-06-03 Kunihiro Ishiguro <kunihiro@zebra.org>
2913
2914 * bgpd.c (peer_active): Add new function for check the peer is
2915 active or not.
2916 (neighbor_activate): New command "neighbor PEER activate" and "no
2917 neighbor PEER activate" are added.
2918
2919 * bgp_packet.c: Include bgpd/bgp_mplsvpn.h.
2920
29212000-06-02 Akihiro Mizutani <mizutani@dml.com>
2922
2923 * bgp_clist.c: Fix commuity-list help strings.
2924
2925 * bgp_routemap.c: Fix "set community" help strings. Add #define
2926 SET_STR. Use (unicast|multicast) argument for "set nlri" command.
2927
29282000-06-01 Kunihiro Ishiguro <kunihiro@zebra.org>
2929
2930 * bgp_routemap.c (route_set_community_none_cmd): "set community
2931 none" command is added to route-map.
2932
29332000-06-01 Akihiro Mizutani <mizutani@dml.com>
2934
2935 * bgp_debug.c: Change "show debug" to "show debugging". Now "show
2936 debugging" is not used in VIEW_NODE.
2937
29382000-05-30 Kunihiro Ishiguro <kunihiro@zebra.org>
2939
2940 * bgp_fsm.c (bgp_timer_set): Add check for shutdown flag. This
2941 fix unconditional BGP connection.
2942
2943 * bgpd.c (peer_shutdown): Replace peer_shutdown() with
2944 peer_change_flag_with_reset().
2945
29462000-05-26 Kunihiro Ishiguro <kunihiro@zebra.org>
2947
2948 * bgpd.c (no_bgp_default_ipv4_unicast): Add "no bgp default
2949 ipv4-unicast" command.
2950
2951 * bgpd.h (BGP_CONFIG_NO_DEFAULT_IPV4): Add new definition.
2952
2953 * bgp_filter.c (as_list_delete): Free all AS filter.
2954
2955 * bgp_clist.c (community_list_delete): Free all community entry.
2956
2957 * bgp_filter.c (no_ip_as_path_all): New DEFUN for "no ip as-path
2958 access-list NAME".
2959
2960 * bgp_clist.c (no_ip_community_list_all): New DEFUN for "no ip
2961 community-list NAME".
2962
29632000-05-19 Kunihiro Ishiguro <kunihiro@zebra.org>
2964
2965 * bgp_route.c (ipv6_mbgp_neighbor_routes): Change "show ip bgp PEER
2966 routes" to "show ip bgp PEER received-routes"
2967
29682000-05-14 Kunihiro Ishiguro <kunihiro@zebra.org>
2969
2970 * bgp_ecommunity.c (ecommunity_parse): New file for Extended
2971 Communities attribute.
2972 * bgp_ecommunity.h: Likewise.
2973
29742000-05-11 Kunihiro Ishiguro <kunihiro@zebra.org>
2975
2976 * bgp_mplsvpn.h: New file for MPLS-VPN.
2977 * bgp_mplsvpn.c: Likewise.
2978
2979 * bgpd.c (bgp_delete): Fix bug of "no router bgp" crush.
2980
29812000-05-10 Kunihiro Ishiguro <kunihiro@zebra.org>
2982
2983 * bgpd.c (bgp_bestpath_missing_as_worst): Add "bgp bestpath
2984 missing-as-worst".
2985
29862000-05-08 Kunihiro Ishiguro <kunihiro@zebra.org>
2987
2988 * bgp_routemap.c (match_community): Clarify help of "match
2989 community".
2990
29912000-05-02 Kunihiro Ishiguro <kunihiro@zebra.org>
2992
2993 * bgp_aspath.c (aspath_cmp_left): Remove debug code.
2994
29952000-04-27 Kunihiro Ishiguro <kunihiro@zebra.org>
2996
2997 * bgp_route.c (bgp_info_cmp): Compare MED only both routes comes
2998 from same neighboring AS.
2999
3000 * bgp_aspath.c (aspath_cmp_left): Compare leftmost AS value.
3001
3002 * bgp_route.c (bgp_info_cmp): Fix misused htonl() to ntohl().
3003
30042000-04-26 Kunihiro Ishiguro <kunihiro@zebra.org>
3005
3006 * bgp_route.c (bgp_output_filter): When distribute-list's
3007 corresponding access-list does not exist, filter all routes.
3008 (bgp_input_filter): Likewise.
3009
30102000-04-19 Kunihiro Ishiguro <kunihiro@zebra.org>
3011
3012 * bgp_attr.c (bgp_packet_attribute): Propagate MED to IBGP peer.
3013
3014 * bgp_route.c (bgp_info_cmp): Add evaluation of local preference.
3015
30162000-04-18 Kunihiro Ishiguro <kunihiro@zebra.org>
3017
3018 * bgpd.c (bgp_distribute_update): Add struct access_list *
3019 argument.
3020
30212000-04-17 Kunihiro Ishiguro <kunihiro@zebra.org>
3022
3023 * bgp_clist.c (community_list_dup_check): Add duplicate insertion
3024 check.
3025
3026 * bgp_filter.c (as_list_dup_check): Add duplicate insertion check.
3027
3028 * bgp_route.c (bgp_show): Fix undeclared write variable.
3029
30302000-04-13 Kunihiro Ishiguro <kunihiro@zebra.org>
3031
3032 * bgp_routemap.c: Add "match ip address prefix-list".
3033
30342000-03-29 Rick Payne <rickp@rossfell.co.uk>
3035
3036 * bgp_aspath.c (aspath_strip_confed): Fix realloc problem.
3037
30382000-03-16 Kunihiro Ishiguro <kunihiro@zebra.org>
3039
3040 * bgp_fsm.c (bgp_reconnect): Connect retry timer is expired when
3041 the peer status is Connect.
3042
30432000-03-03 Kunihiro Ishiguro <kunihiro@zebra.org>
3044
3045 * Fix bug of rewritten originator-id.
3046
30472000-01-27 Rick Payne <rickp@rossfell.co.uk>
3048
3049 * bgp_aspath.c (aspath_delimiter_char): New function. Instead of
3050 directly referencing array, search proper AS path delimiter.
3051 (aspath_strip_confed): Strip the confederation stuff from the
3052 front of an AS path.
3053 (aspath_add_left_confed): New function for adding specified AS to
3054 the leftmost AS_CONFED_SEQUENCE.
3055
3056 * bgp_aspath.h: Change AS_CONFED_SEQUENCE and AS_CONFED_SET value
3057 to Cisco compatible.
3058
3059 * bgpd.c (bgp_confederation_id_set): Confederation configuration.
3060 (bgp_confederation_id_unset): Likewise.
3061 (bgp_confederation_peers_check): Likewise.
3062 (bgp_confederation_peers_add): Likewise.
3063 (bgp_confederation_peers_remove): Likewise.
3064 (bgp_confederation_peers_set): Likewise.
3065 (bgp_confederation_peers_unset): Likewise.
3066 (bgp_confederation_peers_print): Likewise.
3067
30682000-01-16 Kunihiro Ishiguro <kunihiro@zebra.org>
3069
3070 * bgpd.c: Introduce peer_change_flag_with_reset() fucntion.
3071
30722000-01-17 Kunihiro Ishiguro <kunihiro@zebra.org>
3073
3074 * bgp_open.c (bgp_open_option_parse): When there is no common
3075 capability send Unsupported Capability error to the peer.
3076
30772000-01-14 Kunihiro Ishiguro <kunihiro@zebra.org>
3078
3079 * bgp_open.c (bgp_capability_mp): Fix bug of mis-negotiation about
3080 IPv6 unicast.
3081
3082 * bgpd.c (bgp_init): Add "soft-reconfiguration inbound" command.
3083
30842000-01-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3085
3086 * bgpd.c (neighbor_strict_capability): Add
3087 "strict-capability-match" command.
3088
3089 * bgp_zebra.c (bgp_if_update): Ignore NET127 determining
3090 router-id.
3091
3092 * bgpd.c (peer_override_capability): Add "override-capability"
3093 command.
3094
30951999-12-16 Kunihiro Ishiguro <kunihiro@zebra.org>
3096
3097 * bgp_packet.c (bgp_write): Change status to Idle and set timer
3098 after write failed.
3099
31001999-12-14 Kunihiro Ishiguro <kunihiro@zebra.org>
3101
3102 * bgp_zebra.c (bgp_zebra_announce): Add info->selected check.
3103
31041999-12-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3105
3106 * bgp_route.c (nlri_unfeasible): nlri_unfeasible() is merged with
3107 nlri_parse().
3108
31091999-12-10 Kunihiro Ishiguro <kunihiro@zebra.org>
3110
3111 * bgp_fsm.h (BGP_EVENT_DELETE): Macro added.
3112
3113 * bgp_fsm.c (bgp_stop): Clear all event threads of the peer when
3114 the peer is cleared.
3115
3116 * bgp_zebra.c (bgp_nexthop_set): Clear interface index of
3117 link-local address. This is KAME specific problem.
3118
31191999-12-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3120
3121 * bgp_attr.c (bgp_mp_reach_parse): Comment out previous code for a
3122 while. We don't completely detect the link is shared or not at
3123 this moment.
3124
3125 * bgp_packet.c (bgp_notify_send): Make shortcut call of
3126 bgp_write() and bgp_stop().
3127
3128 * bgp_attr.c (bgp_mp_reach_parse): Fix serious bug when getting
3129 global and link-local address.
3130
31311999-12-05 Kunihiro Ishiguro <kunihiro@zebra.org>
3132
3133 * bgpd.c (no_neighbor_port): New command added.
3134 (peer_new): Set send_community.
3135
31361999-12-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3137
3138 * bgpd.c (show_ip_bgp_summary): Changed to use bgp_show_summary().
3139 (show_ip_mbgp_summary): Likewise.
3140 (show_ipv6_bgp_summary): Likewise.
3141 (show_ipv6_mbgp_summary): Add new command.
3142 (peer_free): Free peer->host.
3143 (peer_lookup_by_su): Delete function.
3144 (ipv6_bgp_neighbor): Changed to use peer_remote_as().
3145 (sockunion_vty_out): Function deleted.
3146 (vty_clear_bgp): Use afi instead of family.
3147 Delete old list bgp_list. Use struct newlist *bgplist.
3148 (peer_lookup_by_host): Function deleted.
3149
31501999-12-03 Kunihiro Ishiguro <kunihiro@zebra.org>
3151
3152 * bgpd.h (struct peer_group): New structure added.
3153 (struct peer_conf): New structure added.
3154 (struct peer): Change all prefix_count to unsigned long.
3155
3156 * bgpd.c: Reconstruct all of VTY commands reflect internal
3157 structure change.
3158 Use bgplist instead of bgp_list.
3159 Use peerlist intstead of peer_list.
3160
3161 * bgp_attr.c (bgp_mp_reach_parse): If nlri_parse return -1, stop
3162 parsing then return immediately.
3163
3164 * bgp_route.c (nlri_parse): When NLRI parse error occured, return
3165 -1.
3166 (nlri_process): Use pcount_v4_{unicast,multicast}.
3167 (nlri_delete): Likewise.
3168
31691999-11-25 Robert Olsson <Robert.Olsson@data.slu.se>
3170
3171 * bgp_routemap.c (route_match_nlri): `match nlri
3172 unicast|multicast' and `set nlri unicast|multicast' command are
3173 added.
3174
31751999-11-22 Robert Olsson <Robert.Olsson@data.slu.se>
3176
3177 * bgpd.c: Add translate-update support.
3178
3179 * bgpd.h (TRANSLATE_UPDATE_OFF): Add translate-update definition.
3180
31811999-11-19 Robert.Olsson@data.slu.se
3182
3183 * bgp_route.c (bgp_peer_delete): Add MBGP peer clear codes.
3184
31851999-11-14 Kunihiro Ishiguro <kunihiro@zebra.org>
3186
3187 * bgp_open.c (bgp_capability_mp): Temporary comment out
3188 SAFI_UNICAST_MULTICAST handling until we know the meanings.
3189
31901999-11-13 Kunihiro Ishiguro <kunihiro@zebra.org>
3191
3192 * bgp_btoa.c: New file added.
3193
31941999-11-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3195
3196 * bgpd.h (struct peer): Add dont_capability flag.
3197 (struct peer): Add override_capability flag.
3198
3199 * bgpd.c (neighbor_dont_capability_negotiation): `neighbor PEER
3200 dont-capability-negotiation' added.
3201
32021999-11-12 Bill Sommerfeld <sommerfeld@orchard.arlington.ma.us>
3203
3204 * bgp_attr.c (bgp_mp_reach_parse): Ignore link-local addresses
3205 attribute from non-shared-network peers.
3206
32071999-11-10 Kunihiro Ishiguro <kunihiro@zebra.org>
3208
3209 * bgp_snmp.c: New file added.
3210
3211 * BGP4-MIB.txt: Updated to the latest Internet-Draft
3212 draft-ietf-idr-bgp4-mib-04.txt.
3213
32141999-11-09 Kunihiro Ishiguro <kunihiro@zebra.org>
3215
3216 * bgp_route.c (bgp_route_init): Add `show ipv6 bgp prefix-list'.
3217
3218 * bgp_attr.c (bgp_mp_unreach_parse): Enclose safi setup with
3219 #ifdef HAVE_MBGPV4.
3220
32211999-11-08 Kunihiro Ishiguro <kunihiro@zebra.org>
3222
3223 * bgp_dump.c (no_dump_bgp_all): Add [PATH] and [INTERVAL] to no
3224 dump bgp commands.
3225 (config_write_bgp_dump): Write interval value to the
3226 configuration.
3227
32281999-11-07 Kunihiro Ishiguro <kunihiro@zebra.org>
3229
3230 * bgp_zebra.c: Redistribute route-map support is added.
3231
3232 * bgp_zebra.h: New file added.
3233
32341999-11-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3235
3236 * bgp_dump.c: BGP packet dump routine compatible with MRT.
3237 * bgp_dump.h: BGP packet dump routine compatible with MRT.
3238
3239 * bgp_debug.c: Renamed from bgp_dump.c
3240 * bgp_debug.h: Renamed from bgp_dump.h
3241
32421999-10-27 Kunihiro Ishiguro <kunihiro@zebra.org>
3243
3244 * BGP4-MIB.txt: New file added. Edited version of RFC1657.
3245
32461999-10-25 Bill Sommerfeld <sommerfeld@orchard.arlington.ma.us>
3247
3248 * bgp_route.c (bgp_announce): If we're not on a shared network
3249 with the peer and we don't have a link-local next hop, but the
3250 inbound next-hop has a link-local address, don't readvertise it to
3251 our peer.
3252
32531999-10-25 Marc Boucher <marc@mbsi.ca>
3254
3255 * bgp_zebra.c: Add redistribute kernel command.
3256
32571999-10-25 Kunihiro Ishiguro <kunihiro@zebra.org>
3258
3259 * bgp_route.c (bgp_reset): New function added.
3260
3261 * bgpd.conf.sample2: Add IPv6 configuration sample.
3262
32631999-10-24 Bill Sommerfeld <sommerfeld@orchard.arlington.ma.us>
3264
3265 * bgp_route.c (ipv6_aggregate_address): Function added.
3266
32671999-10-21 Kunihiro Ishiguro <kunihiro@zebra.org>
3268
3269 * bgp_packet.c (bgp_update): Unintern aspath, community, cluster
3270 list after parsing BGP update packet.
3271
3272 * bgp_attr.c (bgp_attr_aspath): Intern parsed aspath.
3273 (bgp_attr_community): Intern parsed community.
3274 (bgp_attr_cluster_list): Intern parsed cluster list.
3275
3276 * bgp_routemap.c: Add `set community-additive' command.
3277
32781999-10-21 Alexandr D. Kanevskiy <kad@blackcatlinux.com>
3279
3280 * bgp_routemap.c (route_set_local_pref): Fix bug of setting
3281 attribute flag.
3282
32831999-10-21 Bill Sommerfeld <sommerfeld@orchard.arlington.ma.us>
3284
3285 * bgp_route.c (bgp_announce): Add check of IPv6 default route
3286 announcement.
3287
3288 * bgp_packet.c (bgp_update_send): Add BGP announcement logging.
3289
32901999-10-15 Kunihiro Ishiguro <kunihiro@zebra.org>
3291
3292 * `show ip[v6] bgp PREFIX' show uptime of the route.
3293
32941999-10-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3295
3296 * bgpd.c (bgp_filter_set): Delete PEER_FAMILY_{IPV4,IPV6}. instead
3297 of that use AF_INET and AF_INET6 directly.
3298 (vty_clear_bgp): Add new function to support various clear ip bgp
3299 method.
3300
33011999-10-04 Lars Fenneberg <lf@elemental.net>
3302
3303 * bgpd.c (clear_ip_bgp): Add `clear ip bgp ASN'.
3304
33051999-10-03 Kunihiro Ishiguro <kunihiro@zebra.org>
3306
3307 * bgp_routemap.c: Add `match ip prefix-list' and `match ipv6
3308 prefix-list'.
3309
33101999-09-28 Kunihiro Ishiguro <kunihiro@zebra.org>
3311
3312 * bgpd.c (bgp_collision_detect): Add BGP collision detection
3313 function.
3314
33151999-09-26 Blake Meike <bmeike@adero.com>
3316
3317 * bgpd.c (neighbor_port): New command `neighbor PEER port PORT' is
3318 added.
3319
33201999-08-24 Kunihiro Ishiguro <kunihiro@zebra.org>
3321
3322 * bgpd.c (no_neighbor_timers_keepalive): Change MIN to min. Add
3323 min() macro.
3324
33251999-08-19 Rick Payne <rickp@rossfell.co.uk>
3326
3327 * bgp_packet.c (bgp_open): BGP holdtimer bug is fixed. Make BGP
3328 keepalive timer configurable.
3329
33301999-08-15 Kunihiro Ishiguro <kunihiro@zebra.org>
3331
3332 * bgp_zebra.c (bgp_redistribute_set): Fix redistribute bug.
3333
33341999-08-13 Kunihiro Ishiguro <kunihiro@zebra.org>
3335
3336 * bgpd.c (bgp_peer_display): show ip bgp neighbors PEER only list
3337 the peer not all of them.
3338
33391999-08-11 Rick Payne <rickp@rossfell.co.uk>
3340
3341 * bgp_route.c (bgp_announce): Remove MED if its an EBGP peer -
3342 will get overwritten by route-maps.
3343
33441999-08-08 Rick Payne <rickp@rossfell.co.uk>
3345
3346 * bgp_routemap.c: Multi protocol route-map modification.
3347
33481999-08-01 Kunihiro Ishiguro <kunihiro@zebra.org>
3349
3350 * bgp_route.c: Set network statement route's origin attribute as
3351 igp.
3352
3353 * bgp_zebra.c: Set redistribute route's origin attribute as
3354 incomplete.
3355
3356 * bgp_route.c (bgp_info_cmp): Add attribute existance check,
3357 origin attribute check, BGP peer type check.
3358
33591999-07-30 Kunihiro Ishiguro <kunihiro@zebra.org>
3360
3361 * bgp_route.c (bgp_peer_delete): Reselect of IPv6 route.
3362
33631999-07-29 Rick Payne <rickp@rossfell.co.uk>
3364
3365 * Changed route-maps to behave in a more cisco-like fashion
3366
33671999-07-27 Kunihiro Ishiguro <kunihiro@zebra.org>
3368
3369 * bgp_fsm.c (bgp_stop): Very serious bug of bgp_stop () is fixed.
3370 When multiple route to the same destination exist, bgpd try to
3371 announce the information to stopped peer. Then add orphan write
3372 thread is added. This cause many strange behavior of bgpd.
3373 Reported by Georg Hitsch <georg@atnet.at>.
3374
33751999-07-23 Kunihiro Ishiguro <kunihiro@zebra.org>
3376
3377 * bgpd.c: Change peer's A.B.C.D to PEER.
3378
33791999-07-22 Kunihiro Ishiguro <kunihiro@zebra.org>
3380
3381 * bgp_route.c (bgp_announce): Add hack for link-local nexthop.
3382
3383 * bgp_zebra.c (bgp_zebra_announce): Fill in nexthop address from
3384 local address.
3385
33861999-07-21 Kunihiro Ishiguro <kunihiro@zebra.org>
3387
3388 * bgp_packet.c (bgp_open): Holdtime fetch bug is fixed. Reported
3389 by Yuji SEKIYA <sekiya@sfc.wide.ad.jp>.
3390
33911999-07-15 Kunihiro Ishiguro <kunihiro@zebra.org>
3392
3393 * bgp_fsm.c (fsm_holdtime): Don't close file descriptor in
3394 fsm_holdtime ().
3395
33961999-07-11 Kunihiro Ishiguro <kunihiro@zebra.org>
3397
3398 * bgp_routemap.c: Add `set atomic-aggregate' command.
3399
34001999-07-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3401
3402 * bgp_routemap.c (route_set_ip_nexthop_cmd): Change "ip nexthop"
3403 to "ip next-hop".
3404
34051999-07-02 Kunihiro Ishiguro <kunihiro@zebra.org>
3406
3407 * bgp_route.c (show_ipv6_bgp_regexp): `show ipv6 bgp regexp'
3408 added.
3409
34101999-07-01 Rick Payne <rickp@rossfell.co.uk>
3411
3412 * bgp_zebra.c (zebra_init): Install standard commands to
3413 ZEBRA_NODE.
3414
34151999-06-28 Rick Payne <rickp@rossfell.co.uk>
3416
3417 * bgpd.c (bgp_delete): bgp peer deletion bug is fixed.
3418
34191999-06-25 Kunihiro Ishiguro <kunihiro@zebra.org>
3420
3421 * bgpd.c: Add neighbor update-source command as ALIAS to
3422 neighbor_interface.
3423
34241999-06-19 Kunihiro Ishiguro <kunihiro@zebra.org>
3425
3426 * bgp_attr.c (bgp_packet_attribute): Send community attribute when
3427 send_community flag is set.
3428
3429 * bgpd.h (struct peer): Add send_community flag.
3430
34311999-06-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3432
3433 * bgpd.c (router_bgp): router bgp's argument changed from AS_NO to
3434 <1-65535>.
3435
34361999-06-08 Kunihiro Ishiguro <kunihiro@zebra.org>
3437
3438 * bgp_route.h (struct bgp_info): Add subtype for BGP route type.
3439
34401999-06-07 Kunihiro Ishiguro <kunihiro@zebra.org>
3441
3442 * bgp_community.c (community_merge): Function added.
3443
34441999-06-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3445
3446 * bgp_clist.c: New file.
3447 * bgp_clist.h: New file.
3448
3449 * bgp_community.h (COMMUNITY_LOCAL_AS): Added for Cisco
3450 compatibility.
3451 (COMMUNITY_NO_ADVERTISE): Fix typo.
3452
34531999-05-30 Kunihiro Ishiguro <kunihiro@zebra.org>
3454
3455 * bgp_routemap.c: Add `set weight WEIGHT' command.
3456
3457 * bgpd.c: Remove all_digit_check function. Instead of that use
3458 all_digit function in lib/prefix.c.
3459
3460 * bgp_routemap.c (bgp_route_map_init): Install
3461 no_set_ipv6_nexthop_global_cmd and no_set_ipv6_nexthop_local_cmd
3462 element to the RMAP_NODE.
3463
34641999-05-28 Kunihiro Ishiguro <kunihiro@zebra.org>
3465
3466 * bgp_aspath.c (aspath_make_str): Declare aspath_delimiter_char
3467 inside aspath_make_str function.
3468 (aspath_prepend): New function is added for AS path prepend.
3469 (aspath_make_str_count): Renamed from aspath_make_str. AS path
3470 count is set to the structure.
3471 (aspath_merge): New function.
3472
34731999-05-22 Kunihiro Ishiguro <kunihiro@zebra.org>
3474
3475 * bgp_zebra.c (redistribute_bgp): Add new DEFUN.
3476 (no_redistribute_bgp): Likewise.
3477 (router_zebra): Semantics changed. Now 'router zebra' is default
3478 behavior of bgpd.
3479
34801999-05-14 Kunihiro Ishiguro <kunihiro@zebra.org>
3481
3482 * bgp_routemap.c: Add some commands to bgp route-map.
3483 match ip next-hop: New command.
3484 match metric: New command.
3485 set metric: Doc fix.
3486 set local-preference: Add DEFUN.
3487
34881999-05-14 Stephen R. van den Berg <srb@cuci.nl>
3489
3490 * bgp_main.c (signal_init): SIGTERM call sigint.
3491 (sigint): Loggging more better message.
3492
34931999-05-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3494
3495 * bgp_attr.c (bgp_packet_attribute): AS path attribute extended
3496 length bit check is added.
3497
34981999-05-11 Kunihiro Ishiguro <kunihiro@zebra.org>
3499
3500 * bgp_routemap.c (bgp_route_map_init): Call route_map_install_set
3501 function with route_set_local_pref_cmd argument.
3502 (no_match_aspath): Function added.
3503 (route_set_metric): Set attribute flag bit.
3504
3505 * bgp_attr.c (bgp_packet_attribute): MULTI_EXIT_DISC is now in BGP
3506 packet.
3507
35081999-05-07 Kunihiro Ishiguro <kunihiro@zebra.org>
3509
3510 * bgpd.c (no_neighbor_timers_holdtime): `no neighbor PEER timers
3511 holdtime' command is added.
3512
3513 * bgpd.h (BGP_DEFAULT_HOLDTIME_BIG): Delete define.
3514
3515 * bgpd.c (bgp_prefix_list_set): New function added.
3516 (bgp_prefix_list_unset): Likewise.
3517 (bgp_prefix_list_update): Likewise.
3518 (show_ip_bgp_neighbors): prefix-list information display.
3519
35201999-05-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3521
3522 * bgpd.c (bgp_delete): Function added for `no router bgp'.
3523
35241999-05-05 Kunihiro Ishiguro <kunihiro@zebra.org>
3525
3526 * bgp_dump.c (bgp_dump_attr): Add originator_id display.
3527
3528 * bgpd.c (bgp_router_id): Even when address is malformed set the
3529 value to configuration bug fixed.
3530 (no_bgp_router_id): New function.
3531 (no_bgp_cluster_id): New function.
3532
35331999-05-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3534
3535 * bgpd.h (BGP_ATTR_ORIGINATOR_ID): Changed from BGP_ATTR_ORIGINATOR.
3536
35371999-05-02 Kunihiro Ishiguro <kunihiro@zebra.org>
3538
3539 * bgp_route.c (bgp_announce): Add route reflector check.
3540
35411999-05-01 Kunihiro Ishiguro <kunihiro@zebra.org>
3542
3543 * bgpd.c (bgp_cluster_id): Add function for route reflector.
3544 (neighbor_route_reflector_client): Likewise.
3545 (no_neighbor_route_reflector_client): Likewise.
3546
3547 * bgpd.h (struct bgp ): Add cluster for route reflector.
3548
3549 * bgp_route.c (show_ip_bgp_prefix_list): New command is added.
3550
35511999-04-24 Kunihiro Ishiguro <kunihiro@zebra.org>
3552
3553 * Makefile.am (noinst_HEADERS): Add bgp_filter.h
3554
3555 * bgp_aspath.c (aspath_undup): Function deleted. aspath_free ()
3556 has same functionality.
3557
3558 * bgp_filter.h: New file.
3559
3560 * bgp_aspath.c (aspath_unintern): Rename aspath_free () to
3561 aspath_unintern ()
3562 (aspath_free): New function.
3563
35641999-04-23 Kunihiro Ishiguro <kunihiro@zebra.org>
3565
3566 * bgp_aspath.c (aspath_aggregate): Function added.
3567
3568 * bgp_aspath.h (aspath_aggregate): Prototype added.
3569
3570 * bgp_aspath.c (aspath_empty_aspath): New argument
3571 gated_dont_eat_flag is added.
3572
35731999-04-18 Kunihiro Ishiguro <kunihiro@zebra.org>
3574
3575 * bgp_route.c: Add bgp_aggregate_ipv4 and bgp_aggregate_ipv6.
3576
35771999-04-17 Kunihiro Ishiguro <kunihiro@zebra.org>
3578
3579 * bgp_route.c (aggregate_address): Function added.
3580
3581 * bgp_zebra.c (zebra_read): Change log to zlog.
3582
35831999-04-15 Kunihiro Ishiguro <kunihiro@zebra.org>
3584
3585 * Makefile.am (noninst_HEADERS): Added for make dist.
3586
35871999-04-09 Kunihiro Ishiguro <kunihiro@zebra.org>
3588
3589 * aspath_regex.c: Removed from distribution.
3590
35911999-04-07 Kunihiro Ishiguro <kunihiro@zebra.org>
3592
3593 * bgp_attr.c (bgp_packet_attribute): Old draft-00 packet treatment
3594 bug fixed.
3595
35961999-04-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3597
3598 * bgp_aspath.c (aspath_add_left): Fix empty aspath bug. Reported
3599 by kad@gibson.skif.net.
3600
3601 * bgp_regex.[ch]: New file added.
3602
3603
36041999-04-05 Kunihiro Ishiguro <kunihiro@zebra.org>
3605
3606 * bgp_filter.c: New file added.
3607
36081999-04-01 Kunihiro Ishiguro <kunihiro@zebra.org>
3609
3610 * bgp_aspath.c (aspath_empty_aspath): Change for peering with
3611 gated.
3612
36131999-03-24 Kunihiro Ishiguro <kunihiro@zebra.org>
3614
3615 * bgp_main.c (main): Default loggin method changed from syslog to
3616 stdout.
3617
36181999-03-05 Kunihiro Ishiguro <kunihiro@zebra.org>
3619
3620 * bgp_route.c: Delete obsolete default attribute DEFUN.
3621
36221999-03-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3623
3624 * bgp_attr.c: Make attribute structure put into attribute hash.
3625
36261999-03-02 Kunihiro Ishiguro <kunihiro@zebra.org>
3627
3628 * bgp_view.c : Delete file.
3629
36301999-02-25 Kunihiro Ishiguro <kunihiro@zebra.org>
3631
3632 * bgp_routemap.c (bgp_apply_route_map): Add prefix argument.
3633
3634 * bgp_route.h (struct bgp_info): Add bgp_info structre. I'll
3635 replace bgp_route with this.
3636
3637 * bgp_routemap.c (route_match_ip_address): Fix bug of passing non
3638 prefix value to access_list_apply().
3639
3640 * bgpd.conf.sample: Add route-map sample.
3641 Delete obsolete default-attr statements.
3642
3643 * bgp_packet.c: Use stream_fifo for packet queueing.
3644
36451999-02-24 Kunihiro Ishiguro <kunihiro@zebra.org>
3646
3647 * bgp_aspath.c (aspath_add_left): add non empty aspath treatment.
3648
3649 * bgp_main.c: include unistd.h for daemon().
3650
3651 * bgp_route.c (nlri_process): add IPv6 table lookup.
3652
3653 * bgp_attr.c (route_parse_ipv6): call nlri_process().
3654 (attr_make): Obsolete function attr_make deleted.
3655
36561999-02-22 Kunihiro Ishiguro <kunihiro@zebra.org>
3657
3658 * bgp_aspath.c (aspath_add_left): change function name from
3659 aspath_add_leftmost_as().
3660
36611999-02-21 Kunihiro Ishiguro <kunihiro@zebra.org>
3662
3663 * bgp_aspath.c: add aspath_add_leftmost_as ().
3664
36651999-02-18 Peter Galbavy <Peter.Galbavy@knowledge.com>
3666
3667 * syslog support added
3668
36691999-01-26 Kunihiro Ishiguro <kunihiro@zebra.org>
3670
3671 * bgpd.c: DEFUN (neighbor_nexthop): deleted.
3672 DEFUN (neighbor_distribute_list): added.
3673
36741999-01-19 Kunihiro Ishiguro <kunihiro@zebra.org>
3675
3676 * bgpd.h (struct peer ): header_buf and read_buf is removed.
3677
3678 * bgp_peer.[ch]: Deleted. Peer related functions are merged to
3679 bgpd.c
3680
3681 * bgp_network.c: New file.
3682 * bgp_network.h: New file.
3683
3684 * bgp_packet.h: New file.
3685
36861999-01-11 Kunihiro Ishiguro <kunihiro@zebra.org>
3687
3688 * bgp_packet.c (bgp_keepalive_send): Now BGP keepalive packet is
3689 buffered.
3690
36911999-01-08 Kunihiro Ishiguro <kunihiro@zebra.org>
3692
3693 * bgp_packet.c: New file.
3694
36951998-12-22 Kunihiro Ishiguro <kunihiro@zebra.org>
3696
3697 * bgp_zebra.c (zebra_client): Use zebra_connect() in lib/client.c.
3698
3699 * `show ip bgp' bug fixed.
3700 * aspath_log (): Remove argument logfp.
3701
37021998-12-15 Kunihiro Ishiguro <kunihiro@zebra.org>
3703
3704 * bgp_fsm.h: New file.
3705
37061998-12-15 Magnus Ahltorp <map@stacken.kth.se>
3707
3708 * bgp_attr.c, bgp_community.h, bgp_dump.c, bgp_fsm.c, bgp_open.c
3709 bgp_peer.c, bgp_peer.h, bgp_route.c, bgp_route.h, bgp_view.c
3710 bgpd.c, bgpd.h, bgp_attr.c, bgp_community.h, bgp_dump.c,
3711 bgp_fsm.c, bgp_open.c, bgp_peer.c, bgp_peer.h: Prototype fixes.
3712
37131998-12-09 Kunihiro Ishiguro <kunihiro@zebra.org>
3714
3715 * bgpd.c (bgp_config_write): Delete vector v argument.
3716
37171998-12-07 Kunihiro Ishiguro <kunihiro@zebra.org>
3718
3719 * bgpd.h: Delete annoying ld_[124]byte and st_[124]byte macros.
3720
37211998-11-23 Kunihiro Ishiguro <kunihiro@zebra.org>
3722
3723 * bgp_radix.[ch]: removed.
3724
37251998-09-15 HEO SeonMeyong <seirios@matrix.iri.co.jp>
3726
3727 * bgp_main.c: ifdef HYDRANGEA -> ifdef KAME
3728
37291998-08-13 Kunihiro Ishiguro <kunihiro@zebra.org>
3730
3731 * bgp_dump.c: delete nroute().
3732
37331998-05-19 Yamshita TAKAO <jargon@lares.dti.ne.jp>
3734
3735 * bgp_aspath.c: HAVE_CONFIG_H typo :-)
3736 * bgpd.h: Modify for compile on Solaris.
3737 * bgp_aspath.h: likewize
3738 * bgp_community.h: likewize
3739 * bgp_routemap.c: likewize
3740
37411998-05-18 Yamshita TAKAO <jargon@lares.dti.ne.jp>
3742
3743 * bgpd.h: Modify for compile on Solaris.
3744 * bgp_aspath.h: likewize
3745
37461998-05-08 Kunihiro Ishiguro <kunihiro@zebra.org>
3747
3748 * routemap.[ch]: move to ../lib directory.
3749
37501998-05-07 Kunihiro Ishiguro <kunihiro@zebra.org>
3751
3752 * routemap.c (route_map_apply): add function.
3753
37541998-05-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3755
3756 * routemap.h: add file.
3757
3758 * bgp_peer.h (enum ): change PEER_{IBGP,EBGP} to BGP_PEER_{IBGP,EBGP}
3759
37601998-05-03 Kunihiro Ishiguro <kunihiro@zebra.org>
3761
3762 * Makefile.am: sysconfdir_DATA added.
3763
37641998-05-02 Kunihiro Ishiguro <kunihiro@zebra.org>
3765
3766 * bgp_dump.c: add `debug bgp fsm'
3767 add `no debug bgp fsm'
3768 add `show debug bgp'
3769 * bgp_open.c: File added.
3770
37711998-05-01 Kunihiro Ishiguro <kunihiro@zebra.org>
3772
3773 * .cvsignore: File added.
3774
37751998-04-30 Kunihiro Ishiguro <kunihiro@zebra.org>
3776
3777 * bgp_community.[ch]: File added.
3778
37791998-03-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3780
3781 * bgpd now use lib/thread.[ch].
3782
37831998-01-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3784
3785 * bgpd.c (show_ip_bgp_neighbors): add 'show ip bgp neighbors' command.
3786
3787 * bgpd.h (BGP_DEFAULT_START_TIMER): change from 1 to 30.
3788
37891997-12-30 Kunihiro Ishiguro <kunihiro@zebra.org>
3790
3791 * bgp_vty.c: bgp_vty.c deleted.
3792
3793 * bgpd.c (config_write_neighbor): add ebgp-multihop command.
3794
37951997-12-29 Kunihiro Ishiguro <kunihiro@zebra.org>
3796
3797 * bgp_fsm.c: [-p bgp_port] and [-P vty_port] works
3798
37991997-12-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3800
3801 * bgp_vty.c: new file.
3802
3803 * bgp_attr.c: add new logging system.
3804
38051997-11-23 Kunihiro Ishiguro <kunihiro@zebra.org>
3806
3807 * Change all inet_addr call into inet_aton.
3808
38091997-11-10 Kunihiro Ishiguro <kunihiro@zebra.org>
3810
3811 * bgp_radix.c: change radix_peer_delete
3812
38131997-10-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3814
3815 * bgp_aspath.c: move AS_TOKEN_??? definition from header to c source.
3816
38171997-09-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3818
3819 * bgp_dump.c (bgp_log_route): add dump_attr function
3820
38211997-09-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3822
3823 * bgp_aspath.c (aspath_test): change AS_SET brace from '[' to '{'
3824 * bgp_dump.c (bgp_log_route): change logfile format.
3825
38261997-08-19 Kunihiro Ishiguro <kunihiro@zebra.org>
3827
3828 * bgp_open.c (bgp_open): move bgp_open function from bgpd.c
3829 * bgp_attr.c (community_str2com): add community value generation
3830 * bgp_attr.h: add SAFI definition for BGP-4+
3831
38321997-08-18 Kunihiro Ishiguro <kunihiro@zebra.org>
3833
3834 * bgpd.h: add BGP_OPEN_OPT_CAP for Capabilities Optional Parameter
3835 * Makefile.in: add bgp_open.o, delete bgp_loop.o
3836 * bgp_open.c: newfile which manages BGP Open message
3837 * bgp_loop.c: this file is merged with bgp_fsm.c
3838 * bgp_radix.c (radix_add): radix_add() now return route_t instead
3839 of int
3840 (bgp_sim): now we can read update & withdraw from file
3841 * bgp_route.c: add route_free() call into route_parse etc.
3842
38431997-08-17 Kunihiro Ishiguro <kunihiro@zebra.org>
3844
3845 * bgp_radix.c: Radix code is completely rewritten. It has better
3846 memory treatment than old one.
3847
38481997-08-14 Kunihiro Ishiguro <kunihiro@zebra.org>
3849
3850 * bgp_route.c: route_alloc for route struct allocation statistics.
3851 * bgpd.c (bgp_make_update): now we cann announce MED attribute.
3852 * bgp_aspath.c (aspath_print_all): change aspath_print_all output
3853 format.
3854
38551997-08-13 Kunihiro Ishiguro <kunihiro@zebra.org>
3856
3857 * bgp_term.c (term_parse): add command : show asstat, show ashash
3858 * bgp_aspath.c: aspath_cmp bug fix
3859 (aspath_print_all): add aspath_print_all ();
3860 * bgp_peer.h: delete rlist element from struct peer.
3861
38621997-08-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3863
3864 * bgp_aspath.c: completely rewritten.
3865 * bgp_aspath.h: completely rewritten.
3866 add AsPath, AsSegment structure
3867 add AS_SET treatment
3868 change Hash codes
3869
38701997-08-09 Kunihiro Ishiguro <kunihiro@zebra.org>
3871
3872 * bgp_attr.h: add Attribute flags defines
3873 * bgp_route.c: delete rlist related functions
3874 * bgp_aspath.c (as_origin): add as_origin function
3875 (aspath_print): move from bgp_dump.c and add support of AS_SET
3876 change Hash related function names.
3877
38781997-08-08 Kunihiro Ishiguro <kunihiro@zebra.org>
3879
3880 * bgp_aspath.h: add next entry, delete rlist entry from struct aspath
3881
38821997-08-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3883
3884 * bgp_aspath.c (as_sort): add function as_sort
3885 * bgp_aspath.h: add IBGP, EBGP
3886