blob: 7f94565c3f3ba246fbd9809d496ffc41d9c76e3e [file] [log] [blame]
Denis Ovsienko841f7a52008-04-10 11:47:45 +000012008-04-10 Denis Ovsienko
2 * bgp_aspath.[ch]: (aspath_filter_exclude) New function allows
3 filtering out arbitrary ASns from AS_PATH attribute.
4 * bgp_aspath.[ch]: (aspath_print_vty) Accept suffix to let calling
5 functions signal, if they want the separator or not.
6 * bgp_route.c: (route_vty_out, route_vty_out_tmp, damp_route_vty_out,
7 flap_route_vty_out, route_vty_out_detail) Fix aspath_print_vty()
8 calls to have AS_PATH output nicely.
9 * bgp_routemap.c: Introduce "set as-path exclude" route-map command
10 to employ new filtering functionality.
11
Paul Jakma693b67b2008-03-13 03:31:24 +0000122008-03-13 Paul Jakma <paul.jakma@sun.com>
13
14 * (various) Remove 0 entries from struct message's, unneeded due to
15 recent improvements in mes_lookup/LOOKUP.
16
Paul Jakma90b68762008-01-29 17:26:34 +0000172008-01-29 Jorge Boncompte <jorge@dti2.net>
18
19 * bgp_network.c: (bgp_socket) IPv4-only version crashes if -l is not
20 used as address will be null.
21
Paul Jakma370b64a2007-12-22 16:49:52 +0000222007-12-22 Paul Jakma <paul.jakma@sun.com>
23
24 * Fix series of vulnerabilities reported by "Mu Security
25 Research Team", where bgpd can be made to crash by sending
26 malformed packets - requires that bgpd be configured with a
27 session to the peer.
28 * bgp_attr.c: (bgp_attr_as4_path) aspath_parse may fail, only
29 set the attribute flag indicating AS4_PATH if we actually managed
30 to parse one.
31 (bgp_attr_munge_as4_attrs) Assert was too general, it is possible
32 to receive AS4_AGGREGATOR before AGGREGATOR.
33 (bgp_attr_parse) Check that we have actually received the extra
34 byte of header for Extended-Length attributes.
35 * bgp_attr.h: Fix BGP_ATTR_MIN_LEN to account for the length byte.
36 * bgp_open.c: (cap_minsizes) Fix size of CAPABILITY_CODE_RESTART,
37 incorrect -2 left in place from a development version of as4-path
38 patch.
39 * bgp_packet.c: (bgp_route_refresh_receive) ORF length parameter
40 needs to be properly sanity checked.
41
Denis Ovsienkoa7f93f32007-12-18 15:13:06 +0000422007-12-18 Denis Ovsienko
43
44 * bgp_routemap.c: (no_set_aspath_prepend) This command cancelled
45 existing "set" command regardless if "no set" matched it or not.
46 Fixed.
47
Paul Jakma7e992e92007-11-13 09:32:23 +0000482007-11-13 Paul Jakma <paul.jakma@sun.com>
49
50 * bgp_main.c: Small fix, format string parameters should never
51 be NULL - it's not strictly valid and some libc's don't let
52 you away with.
53
Paul Jakma3a02d1f2007-11-01 14:29:11 +0000542007-10-30 Nick Hilliard <nick@inex.ie>
55
56 * bgp_main.c: Add 'listenon' argument, to pass address to bind
57 to.
58 * bgp_network.c: (bgp_socket) Extend to take bind address.
59 * bgpd.c: (bgp_init) Pass stored address.
60 * bgpd.h: (struct bgp_master) storage for bind address
61
Paul Jakma0b2aa3a2007-10-14 22:32:21 +0000622007-09-27 Paul Jakma <paul.jakma@sun.com>
63
64 * bgp_aspath.c: (assegment_normalise) remove duplicates from
65 from sets.
66 (aspath_reconcile_as4) disregard a broken part of the RFC around
67 error handling in path reconciliation.
68
692007-09-25 Paul Jakma <paul.jakma@sun.com>
70
71 * bgp_open.c: (peek_for_as4_capability) Fix to work.
72 * bgp_packet.c: (bgp_open_receive) Fix sanity check of as4.
73
742007-09-18 Paul Jakma <paul.jakma@sun.com>
75
76 * bgp_open.c: (bgp_capability_as4) debug printf inline with others.
77 (peek_for_as4_capability) There's no need to signal failure, as
78 failure is better dealt with through full capability parser -
79 just return the AS4, simpler.
80 * bgp_packet.c: (bgp_open_receive) Update to match
81 peek_for_as4_capability change.
82 Allow use of BGP_AS_TRANS by 2b speakers.
83 Use NOTIFY_OPEN_ERR rather than CEASE for OPEN parsing errors.
84 (bgp_capability_msg_parse) missing argument to debug print
85 (bgp_capability_receive) missing return values.
86
87
882007-07-25 Paul Jakma <paul.jakma@sun.com>
89
90 * Remove 2-byte size macros, just make existing macros take
91 argument to indicate which size to use.
92 Adjust all users - typically they want '1'.
93 * bgp_aspath.c: (aspath_has_as4) New, return 1 if there are any
94 as4's in a path.
95 (aspath_put) Return the number of bytes actually written, to
96 fix the bug Juergen noted: Splitting of segments will change
97 the number of bytes written from that already written to the
98 AS_PATH header.
99 (aspath_snmp_pathseg) Pass 2-byte flag to aspath_put. SNMP
100 is still defined as 2b.
101 (aspath_aggregate) fix latent bug.
102 (aspath_reconcile_as4) AS_PATH+NEW_AS_PATH reconciliation
103 function.
104 (aspath_key_make) Hash the AS_PATH string, rather than
105 just taking the addition of assegment ASes as the hash value,
106 hopefully sligthly more collision resistant.
107 (bgp_attr_munge_as4_attrs) Collide the NEW_ attributes
108 together with the OLD 2-byte forms, code Juergen
109 had in bgp_attr_parse but re-organised a bit.
110 (bgp_attr_parse) Bunch of code from Juergen moves
111 to previous function.
112 (bgp_packet_attribute) Compact significantly by
113 just /always/ using extended-length attr header.
114 Fix bug Juergen noted, by using aspath_put's
115 (new) returned size value for the attr header rather
116 than the (guesstimate) of aspath_size() - the two could
117 differ when aspath_put had to split large segments, unlikely
118 this bug was ever hit in the 'wild'.
119 (bgp_dump_routes_attr) Always use extended-len and
120 use aspath_put return for header length. Output 4b ASN
121 for AS_PATH and AGGREGATOR.
122 * bgp_ecommunity.c: (ecommunity_{hash_make,cmp}) fix
123 hash callback declarations to match prototypes.
124 (ecommunity_gettoken) Updated for ECOMMUNITY_ENCODE_AS4,
125 complete rewrite of Juergen's changes (no asdot support)
126 * bgp_open.c: (bgp_capability_as4) New, does what it says
127 on the tin.
128 (peek_for_as4_capability) Rewritten to use streams and
129 bgp_capability_as4.
130 * bgp_packet.c: (bgp_open_send) minor edit
131 checked (in the abstract at least) with Juergen.
132 Changes are to be more accepting, e.g, allow AS_TRANS on
133 a 2-byte session.
134 * (general) Update all commands to use CMD_AS_RANGE.
135 * bgp_vty.c: (bgp_clear) Fix return vals to use CMD_..
136 Remove stuff replicated by VTY_GET_LONG
137 (bgp_clear_vty) Return bgp_clear directly to vty.
138
139
1402007-07-25 Juergen Kammer <j.kammer@eurodata.de>
141
142 * (general) AS4 support.
143 * bgpd.h: as_t changes to 4-bytes.
144 * bgp_aspath.h: Add BGP_AS4_MAX and BGP_AS_TRANS defines.
145 * bgp_aspath.c: AS_VALUE_SIZE becomes 4-byte, AS16_VALUE_SIZE
146 added for 2-byte.
147 Add AS16 versions of length calc macros.
148 (aspath_count_numas) New, count number of ASes.
149 (aspath_has_as4) New, return 1 if there are any as4's in a
150 path.
151 (assegments_parse) Interpret assegment as 4 or 2 byte,
152 according to how the caller instructs us, with a new
153 argument.
154 (aspath_parse) Add use32bit argument to pass to
155 assegments_parse. Adjust all its callers to pass 1, unless
156 otherwise noted.
157 (assegment_data_put) Adjust to be able to write 2 or 4 byte
158 AS, according to new use32bit argument.
159 (aspath_put) Adjust to write 2 or 4.
160 (aspath_gettoken) Use a long for passed in asno.
161 * bgp_attr.c: (attr_str) Add BGP_ATTR_AS4_PATH and
162 BGP_ATTR_AS4_AGGREGATOR.
163 (bgp_attr_aspath) Call aspath_parse with right 2/4 arg, as
164 determined by received-capability flag.
165 (bgp_attr_aspath_check) New, code previously in attr_aspath
166 but moved to new func so it can be run after NEW_AS_PATH
167 reconciliation.
168 (bgp_attr_as4_path) New, handle NEW_AS_PATH.
169 (bgp_attr_aggregator) Adjust to cope with 2/4 byte ASes.
170 (bgp_attr_as4_aggregator) New, read NEW_AGGREGATOR.
171 (bgp_attr_parse) Add handoffs to previous parsers for the two
172 new AS4 NEW_ attributes.
173 Various checks added for NEW/OLD reconciliation.
174 (bgp_packet_attribute) Support 2/4 for AS_PATH and
175 AGGREGATOR, detect when NEW_ attrs need to be sent.
176 * bgp_debug.{c,h}: Add 'debug bgp as4'.
177 * bgp_dump.c: MRTv2 support, unconditionally enabled, which
178 supports AS4. Based on patches from Erik (RIPE?).
179 * bgp_ecommunity.c: (ecommunity_ecom2str) ECOMMUNITY_ENCODE_AS4
180 support.
181 * bgp_open.c: (peek_for_as4_capability) New, peek for AS4
182 capability prior to full capability parsing, so we know which
183 ASN to use for struct peer lookup.
184 (bgp_open_capability) Always send AS4 capability.
185 * bgp_packet.c: (bgp_open_send) AS4 handling for AS field
186 (bgp_open_receive) Peek for AS4 capability first, and figure
187 out which AS to believe.
188 * bgp_vty.c: (bgp_show_peer) Print AS4 cap
189
Paul Jakmae08286b2007-09-18 12:11:26 +00001902007-09-17 Paul Jakma <paul.jakma@sun.com>
191
192 * bgp_open.c: (bgp_capability_mp) We were setting
193 afc_nego[safi][safi] rather than afc_nego[afi][safi], thus
194 failling to announce any non-IPv4 prefixes. Remove the extra,
195 typo-ed character.
196
Paul Jakmab2ceea12007-09-07 14:24:55 +00001972007-09-07 Paul Jakma <paul.jakma@sun.com>
198
199 * (general) bgpd can be made crash by remote peers if debug
200 bgp updates is set, due to NULL pointer dereference.
201 Reported by "Mu Security Research Team",
202 <security@musecurity.com>.
203 * bgp_attr.c: (bgp_attr_community) If community length is 0,
204 don't set the community-present attribute bit, just return
205 early.
206 * bgp_debug.c: (community_str,community_com2str) Check com
207 pointer before dereferencing.
208
Paul Jakma9eda90c2007-08-30 13:36:17 +00002092007-08-27 Paul Jakma <paul.jakma@sun.com>
210
211 * bgp_route.c: (bgp_announce_check) Fix bug #398, slight
212 modification of Vladimir Ivanov's suggested fix - to keep
213 memory alloc conditional.
214 (bgp_process_announce_selected) Don't take struct attr as
215 argument, none of the callers need it and it needlessly
216 distances allocation from use.
217 Free the extended attr, the attr itself is on the stack.
218 Fix bad indentation.
219 * bgp_attr.c: (bgp_packet_attribute) Remove incorrect assert,
220 and adjust conditional to test attr->extra, diagnosis by
221 Vladimir Ivanov in bug #398.
222
2232007-08-27 Vladimir Ivanov <wawa@yandex-team.ru>
224
225 * bgp_route.c: (bgp_announce_check_rsclient) copy of
226 ri->attr is no longer deep enough, due to addition of
227 attr->extra. It should use bgp_attr_dup, as
228 bgp_announce_check() does.
229
Paul Jakma6d134fb2007-08-23 23:22:02 +00002302007-08-23 Paul Jakma <paul.jakma@sun.com>
231
232 * bgp_regex.c: (bgp_regcomp) Pass NOSUB flag to regcomp to
233 prevent parsing of substitutions, which can have profound
234 performance effects on bgpd and are of no use to the CLI
235 anyway. How much it helps depends on the regex
236 implementation.
237
Paul Jakma41367172007-08-06 15:24:51 +00002382007-07-31 Paul Jakma <paul.jakma@sun.com>
239
240 * (general) Support for draft-ietf-idr-as-pathlimit-03.
241 * bgp_attr.h: (struct attr) Add pathlimit struct
242 bgp_attr.c: (attr_str) Add BGP_ATTR_AS_PATHLIMIT string.
243 (attrhash_key_make) tally pathlimit too
244 (attrhash_cmp) cmp pathlimit attr
245 (bgp_attr_aspathlimit) New, parse AS_PATHLIMIT attr.
246 (bgp_attr_parse) ditto
247 (bgp_packet_attribute) Write out AS_PATHLIMIT when set
248 (bgp_dump_routes_attr) ditto
249 * bgp_route.h: (struct bgp_static) Add TTL field
250 * bgp_route.c: (bgp_announce_check) Drop paths that are over
251 their hop-count TTL before sending via EBGP.
252 Mangle ASN in pathlimit for confeds/private as best we can.
253 (bgp_static_update_{rsclient,main}) Add any configure pathlimit
254 information.
255 (bgp_pathlimit_update_parents) New, update atomic-aggr setting for
256 parents of an aspathlimit'ed static.
257 (bgp_static_set) Add TTL argument, for all the 'bgp network'
258 commands.
259 Call previous for TTL changed statics.
260 (bgp_static_unset) Call pathlimit_update_parents.
261 (various bgp network commands) Add 'pathlimit <0-255>' qualifier
262 to all the various forms, bar route-map - which can set ttl
263 itself.
264 * bgp_routemap.c: (general) Add support for 'set pathlimit ttl' and
265 'match pathlimit as'.
266
Paul Jakma6d582722007-08-06 15:21:45 +00002672007-07-26 Paul Jakma <paul.jakma@sun.com>
268
269 * (general) Clean up and compact capability parsing slightly.
270 Consolidate validation of length and logging of generic TLV, and
271 memcpy of capability data, thus removing such from cap specifc
272 code (not always present or correct).
273 * bgp_open.h: Add structures for the generic capability TLV header
274 and for the data formats of the various specific capabilities we
275 support. Hence remove the badly named, or else misdefined, struct
276 capability.
277 * bgp_open.c: (bgp_capability_vty_out) Use struct capability_mp_data.
278 Do the length checks *before* memcpy()'ing based on that length
279 (stored capability - should have been validated anyway on input,
280 but..).
281 (bgp_afi_safi_valid_indices) new function to validate (afi,safi)
282 which is about to be used as index into arrays, consolidates
283 several instances of same, at least one of which appeared to be
284 incomplete..
285 (bgp_capability_mp) Much condensed.
286 (bgp_capability_orf_entry) New, process one ORF entry
287 (bgp_capability_orf) Condensed. Fixed to process all ORF entries.
288 (bgp_capability_restart) Condensed, and fixed to use a
289 cap-specific type, rather than abusing capability_mp.
290 (struct message capcode_str) added to aid generic logging.
291 (size_t cap_minsizes[]) added to aid generic validation of
292 capability length field.
293 (bgp_capability_parse) Generic logging and validation of TLV
294 consolidated here. Code compacted as much as possible.
295 * bgp_packet.c: (bgp_open_receive) Capability parsers now use
296 streams, so no more need here to manually fudge the input stream
297 getp.
298 (bgp_capability_msg_parse) use struct capability_mp_data. Validate
299 lengths /before/ memcpy. Use bgp_afi_safi_valid_indices.
300 (bgp_capability_receive) Exported for use by test harness.
301 * bgp_vty.c: (bgp_show_summary) fix conversion warning
302 (bgp_show_peer) ditto
303 * bgp_debug.h: Fix storage 'extern' after type 'const'.
304
Paul Jakma45ad5922007-07-31 17:35:36 +00003052007-07-31 Lorenzo Colitti <lorenzo@colitti.com>
306
307 * bgp_dump.c: (general) Add comments to code.
308 (bgp_dump_interval_add) remove some redundant lines.
309 (bgp_dump_set) Use enum for type argument.
310 Avoid scheduling dump twice if exact same command
311 is given twice..
312
Paul Jakma536792c2007-06-22 19:11:14 +00003132007-06-22 Paul Jakma <paul.jakma@sun.com>
314
315 * bgp_fsm.c: (struct FSM) Bug #368. TCP Errors during OpenSent
316 should cycle to Active, not to Idle or else peer bringup can
317 race and cycle Idle<->Active. Reported and fix tested by
318 Mukesh Agrawal.
319
Paul Jakmab2497022007-06-14 11:17:58 +00003202007-05-25 Paul Jakma <paul.jakma@sun.com>
321
322 * bgp_route.c: (bgp_default_originate) Sanity check added
323 previously was broken and always failed, thus this function
324 never could run, bug #370.
325
Paul Jakmafb982c22007-05-04 20:15:47 +00003262007-05-03 Paul Jakma <paul.jakma@sun.com>
Paul Jakma923de652007-04-29 18:25:17 +0000327
Paul Jakmafb982c22007-05-04 20:15:47 +0000328 * bgp_route.h: (struct info) Move less frequently used
329 fields to a lazily allocated struct info_extra.
330 Export bgp_info_extra_get
331 * bgp_route.c: (bgp_info_extra_new) allocate extra
332 (bgp_info_extra_free) Free damp info and the info_extra.
333 (bgp_info_extra_get) Retrieve the info_extra of a struct
334 info, allocating as required.
335 (generally) adjust to use info->extra
336 * bgp_damp.c: (generally) use bgp_info_extra_get to access
337 dampinfo
338 * bgp_attr.h: Move rarely allocated attributes from struct attr
339 to a struct attr_extra, for a substantial saving in size of
340 struct attr.
341 * bgp_attr.c: (bgp_attr_extra_{new,free}), new, self-explanatory.
342 (bgp_attr_extra_get) Get the attr_extra for a given struct
343 attr, allocating it if needs be.
344 (bgp_attr_dup) Shallow copy the struct attr and its attr_extra.
345 (generally) adjust to know about attr->extra.
346 * bgp_debug.c: (bgp_dump_attr) ditto
347 * bgp_vty.c: (show_bgp_memory) print attr and info extra sizes.
348 * bgp_nexthop.c: (generally) adjust to know about attr->extra
349 and info->extra.
350 * bgp_{packet,routemap,snmp,zebra}.c: ditto
351
3522007-04-22 Sebastien Tandel <sebastien@tandel.be>
Paul Jakma923de652007-04-29 18:25:17 +0000353 * bgp_advertise.c : (baa_hash_alloc, baa_hash_key, baa_hash_cmp)
354 conforms to quagga hash API. Defines _hash_[alloc|key|cmp] with
355 void * arguments as defined by the API.
356 * bgp_aspath.c,h : (aspath_key_make) conforms to quagga hash API.
357 Defines _hash_[alloc|key|cmp] with void * arguments as defined by
358 the API.
359 * bgp_attr.c,h : (cluster_hash_alloc, cluster_hash_key_make,
360 cluster_hash_cmp, transit_hash_alloc, transit_hash_key_make,
361 transit_hash_cmp, attrhash_key_make, attrhash_cmp,
362 bgp_attr_hash_alloc) conforms to quagga hash API. Defines
363 _hash_[alloc|key|cmp] with void * arguments as defined by the API.
Paul Jakma03e214c2007-04-29 18:31:07 +0000364 * bgp_attr.h : Definition of BGP_ATTR_DEFAULT_WEIGHT.
365 * bgp_attr.c : (bgp_attr_default_intern) now uses
366 bgp_attr_default_set instead of duplicating the same code.
367 (general) Use of BGP_ATTR_DEFAULT_WEIGHT. Replace two 16 by
368 IPV6_MAX_BYTELEN.
Paul Jakma923de652007-04-29 18:25:17 +0000369
Andrew J. Schorr93c17492007-04-15 19:17:24 +00003702007-04-15 Sebastien Tandel <sebastien@tandel.be>
371
372 * bgp_aspath.c: (aspath_as_add, aspath_segment_add) Minor performance
373 optimization: while loop should test one pointer instead of two.
374
Paul Jakma16d2e242007-04-10 19:32:10 +00003752007-04-08 Paul Jakma <paul.jakma@sun.com>
376
377 * bgp_route.c: (general) Same bug as fixed on 2006-11-28 by ajs for
378 bgp static routes, but for main BGP RIB: Quick 'flap' of routes
379 can cause bgpd to mistake a new route for a duplicate route,
380 due to presence of removed, but not yet processed BGP RIB entry.
381 (bgp_update_rsclient) Ignore REMOVED bgp_info for duplicate,
382 restore route instead.
383 (bgp_update_main) Ditto.
Paul Jakma6e4ab122007-04-10 19:36:48 +0000384 * bgp_attr.c: (general) Bug #354: parsing of MP_REACH_NLRI and
385 MP_UNREACH_NLRI does not take sufficient care to ensure reads
386 from stream buffer stay in-bounds. Hence bgpd may attempt to read
387 beyond end of stream, if given a crafted packet. As it uses the
388 stream access methods to do so, this will typically result in
389 assert() being hit in stream.c. Where code is compiled without
390 assert() enabled, result is unknown.
391 (struct message attr_str) should be static.
392 (bgp_mp_reach_parse) Carefully check length remaining in stream
393 against amount desired to read from stream, prior to each read,
394 particularly where lengths are conditional on data obtained from
395 stream - using STREAM_READABLE.
396 Remove code to parse SNPA-number, it's a defunct field and changed
397 to a fixed size in latest BGP MP update RFC - log warning if
398 SNPA-number is not 0.
399 (bgp_mp_unreach_parse) Check withdraw_length carefully against
400 STREAM_READABLE.
401 (bgp_attr_parse) If attribute-parser function returns error, log
402 warning.
403 Log attribute type on mismatch.
Paul Jakma16d2e242007-04-10 19:32:10 +0000404
Paul Jakma37a217a2007-04-10 19:20:29 +00004052007-04-07 Paul Jakma <paul.jakma@sun.com>
406
407 * bgpd.c: (general) Fix bug #352
408 (bgp_config_write_family_header) write ipv6/multicast
409 address family header.
410 (bgp_config_write) write out ipv6 multicast AF config.
411
Paul Jakmaf2c31ac2007-02-22 17:48:42 +00004122007-02-22 Paul Jakma <paul.jakma@sun.com>
413
414 * bgp_fsm.c: (bgp_fsm_change_status) Handle state change into
415 clearing or greater here. Simpler.
416 (bgp_event) Clearing state change work moved to previous
417 * bgp_route.c: (bgp_clear_route_node) Clearing adj-in here
418 is too late, as it leaves a race between a peer being deleted
419 and an identical peer being configured before clearing
420 completes, leading to a crash.
421 Simplest fix is to clean peers Adj-in up-front, rather than
422 queueing such work.
423 (bgp_clear_route_table) Clear peer's Adj-In and Adj-Out
424 up-front here, rather than queueing such work.
425 Extensive comment added on the various bits of indexed data
426 that exist and how they need to be dealt with.
427 (bgp_clear_route) Update comment.
428
Andrew J. Schorre4529632006-12-12 19:18:21 +00004292006-12-12 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
430
431 * bgp_nexthop.c: (bgp_connected_add, bgp_connected_delete)
432 Simplify logic by using new CONNECTED_PREFIX macro.
433
Paul Jakma95fdcd82006-12-08 00:31:22 +00004342006-12-07 Paul Jakma <paul.jakma@sun.com>
435
436 * bgp_fsm.c: Bug #302 fix, diagnosis, suggestions and testing
437 by Juergen Kammer <j.kammer@eurodata.de>. Fix follows from
438 his suggested fix, just made in a slightly different way.
439 (bgp_event) Transitions into Clearing always must call
440 bgp_clear_route_all().
441 (bgp_stop) No need to clear routes here, BGP FSM should do
442 it.
443
Andrew J. Schorra39275d2006-11-30 16:36:57 +00004442006-11-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
445
446 * bgp_debug.h: Declare new bgp_debug_zebra conf and term flags,
447 and define BGP_DEBUG_ZEBRA.
448 * bgp_debug.c: Declare conf_bgp_debug_zebra and term_bgp_debug_zebra.
449 (debug_bgp_zebra, no_debug_bgp_zebra, undebug_bgp_zebra) New
450 functions to enable/disable bgp zebra debugging.
451 (no_debug_bgp_all) Turn off zebra debugging.
452 (show_debugging_bgp) Show whether zebra debugging is on.
453 (bgp_config_write_debug) Add 'debug bgp zebra' if configured.
454 (bgp_debug_init) Add new zebra debugging commands.
455 * bgp_zebra.c: (bgp_router_id_update, bgp_interface_add,
456 bgp_interface_delete, bgp_interface_up, bgp_interface_down,
457 bgp_interface_address_add, bgp_interface_address_delete,
458 zebra_read_ipv4, zebra_read_ipv6, bgp_zebra_announce,
459 bgp_zebra_withdraw, bgp_redistribute_set, bgp_redistribute_unset)
460 If zebra debugging is enabled, log an appropriate debug message.
461
Andrew J. Schorr8d452102006-11-28 19:50:46 +00004622006-11-28 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
463
464 * bgp_route.c: (bgp_info_restore) New function that undoes
465 the effects of a previous call to bgp_info_delete. This is
466 used when a route is deleted and quickly re-added before the
467 deletion has been processed.
468 (bgp_static_update_rsclient, bgp_static_update_main,
469 bgp_redistribute_add) Check whether a pre-existing route
470 has the BGP_INFO_REMOVED set, and, if so, we need to call
471 bgp_info_restore to resurrect it.
472
Paul Jakma56395af2006-10-27 16:58:20 +00004732006-10-27 Paul Jakma <paul.jakma@sun.com>
474
475 * bgp_route.c: (bgp_table_stats) oops, u_intXX_t should be
476 uintXX_t
477
Paul Jakma6f585442006-10-22 19:13:07 +00004782006-10-19 Paul Jakma <paul.jakma@sun.com>
479
480 * bgpd.c: (peer_new) bgp element of peer absolutely must be
481 filled in, make peer_new() require it as argument and update
482 all callers. Fixes a crash reported by Jan 'yanek' Bortl and
483 Andrew Schorr where bgpd would crash in bgp_pcount_adjust
484 trying to dereference the bgp member of bgp->peer_self,
485 triggered through redistribution.
486 * bgp_route.c: (bgp_pcount_adjust) assert sanity of arguments.
487
Paul Jakma53d9f672006-10-15 23:41:16 +00004882006-10-15 Paul Jakma <paul.jakma@sun.com>
489
490 * bgp_route.c: (bgp_table_stats_walker) NULL deref if table is
491 empty, bgp_table_top may return NULL, Coverity CID#73.
Paul Jakmaed3ebfa2006-10-15 23:50:16 +0000492 * bgp_packet.c: (bgp_update_packet) adv->rn can not be NULL,
493 check is bogus - changed to assert(), CID#64.
494 binfo is checked for NULL, but then dereferenced
495 unconditionally, fix, CID #63.
496 (bgp_withdraw_packet) Assert adv->rn is valid, as with
497 bgp_update_packet().
Paul Jakma53d9f672006-10-15 23:41:16 +0000498
Paul Jakmadcdf3992006-10-15 23:39:59 +00004992006-10-14 Paul Jakma <paul.jakma@sun.com>
500
501 * bgp_fsm.h: Remove BGP_EVENT_FLUSH_ADD, dangerous and not
502 needed.
503 * bgp_fsm.c: (bgp_stop) Move BGP_EVENT_FLUSH to the top of the
504 of the function, otherwise it could flush a ClearingCompleted
505 event, bug #302.
506 * bgp_packet.c: Replace all BGP_EVENT_FLUSH_ADD with
507 BGP_EVENT_ADD, fixing bug #302.
508
Andrew J. Schorr0cd1c322006-09-19 18:51:53 +00005092006-09-19 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
510
511 * bgpd.c: (peer_uptime) Fix printf format/arg mismatch in
512 zlog_warn message (%ld/size_t -> %lu/u_long).
513
Paul Jakmaca058a32006-09-14 02:58:49 +00005142006-09-14 Paul Jakma <paul.jakma@sun.com>
515
Paul Jakma8383a9b2006-09-14 03:06:54 +0000516 * bgp_route.c: (bgp_table_stats_walker) Address space announced
517 should only count top-level unaggregateable prefixes, to
518 avoid falling afoul of anti-dodgy-accounting regulations
519 in various jurisdictions.. ;)
Paul Jakma09dd5612006-09-14 03:38:16 +0000520 (bgp_process_queue_init) process queue hold time too high,
521 adds extra memory load. Change to be much lower, until such
522 time as it's made configurable.
Paul Jakma8383a9b2006-09-14 03:06:54 +0000523
5242006-09-14 Paul Jakma <paul.jakma@sun.com>
525
Paul Jakma9fde6622006-09-14 03:02:02 +0000526 * (general) fix the peer refcount issue exposed by previous, by
527 just removing refcounting of peer threads, which is mostly
528 senseless as they're references leading from struct peer,
529 which peer_free cancels anyway. No need to muck around..
530 * bgp_fsm.h: Just remove the refcounting from the various
531 TIMER/READ/WRITE/EVENT ON/OFF/ADD macros.
532 * bgp_fsm.c: (bgp_stop) use BGP_EVENT_FLUSH, no refcounts attached
533 to events anymore.
534 (bgp_event) remove peer_unlock, events not refcounted.
535 * bgpd.c: (peer_free) flush events before free.
536
5372006-09-14 Paul Jakma <paul.jakma@sun.com>
538
Paul Jakmaca058a32006-09-14 02:58:49 +0000539 * (general) Fix some niggly issues around 'shutdown' and clearing
540 by adding a Clearing FSM wait-state and a hidden 'Deleted'
541 FSM state, to allow deleted peers to 'cool off' and hit 0
542 references. This introduces a slow memory leak of struct peer,
543 however that's more a testament to the fragility of the
544 reference counting than a bug in this patch, cleanup of
545 reference counting to fix this is to follow.
546 * bgpd.h: Add Clearing, Deleted states and Clearing_Completed
547 and event.
548 * bgp_debug.c: (bgp_status_msg[]) Add strings for Clearing and
549 Deleted.
550 * bgp_fsm.h: Don't allow timer/event threads to set anything
551 for Deleted peers.
552 * bgp_fsm.c: (bgp_timer_set) Add Clearing and Deleted. Deleted
553 needs to stop everything.
554 (bgp_stop) Remove explicit fsm_change_status call, the
555 general framework handles the transition.
556 (bgp_start) Log a warning if a start is attempted on a peer
557 that should stay down, trying to start a peer.
558 (struct .. FSM) Add Clearing_Completed
559 events, has little influence except when in state
560 Clearing to signal wait-state can end.
561 Add Clearing and Deleted states, former is a wait-state,
562 latter is a placeholder state to allow peers to disappear
563 quietly once refcounts settle.
564 (bgp_event) Try reduce verbosity of FSM state-change debug,
565 changes to same state are not interesting (Established->Established)
566 Allow NULL action functions in FSM.
567 * bgp_packet.c: (bgp_write) Use FSM events, rather than trying
568 to twiddle directly with FSM state behind the back of FSM.
569 (bgp_write_notify) ditto.
570 (bgp_read) Remove the vague ACCEPT_PEER peer_unlock, or else
571 this patch crashes, now it leaks instead.
572 * bgp_route.c: (bgp_clear_node_complete) Clearing_Completed
573 event, to end clearing.
574 (bgp_clear_route) See extensive comments.
575 * bgpd.c: (peer_free) should only be called while in Deleted,
576 peer refcounting controls when peer_free is called.
577 bgp_sync_delete should be here, not in peer_delete.
578 (peer_delete) Initiate delete.
579 Transition to Deleted state manually.
580 When removing peer from indices that provide visibility of it,
581 take great care to be idempotent wrt the reference counting
582 of struct peer through those indices.
583 Use bgp_timer_set, rather than replicating.
584 Call to bgp_sync_delete isn't appropriate here, sync can be
585 referenced while shutting down and finishing deletion.
586 (peer_group_bind) Take care to be idempotent wrt list references
587 indexing peers.
588
Paul Jakma2815e612006-09-14 02:56:07 +00005892006-09-13 Paul Jakma <paul.jakma@sun.com>
590
591 * bgp_aspath.c: (aspath_highest) new, return highest ASN in an
592 aspath.
593 * bgp_route.c: (bgp_peer_count_walker) new, do the walk done
594 in bgp_peer_counts as a thread.
595 (bgp_peer_counts) move walk to previous and call it via
596 thread_execute so this RIB walk shows up in thread stats.
597 (bgp_table_stats) New, gather some statistics for a given
598 RIB.
599 (bgp_table_stats_walker) New, RIB walker thread for former.
600 (bgp_table_stats_vty) Parsing front-end for 'show bgp ...',
601 useful model for future rationalisation of 'show ... bgp'.
602 (bgp_route_init) Add new RIB stats commands.
603
Paul Jakma1a392d42006-09-07 00:24:49 +00006042006-09-06 Paul Jakma <paul.jakma@sun.com>
605
606 * (general) Squash any and all prefix-count issues by
607 abstracting route flag changes, and maintaining count as and
608 when flags are modified (rather than relying on explicit
609 modifications of count being sprinkled in just the right
610 places throughout the code).
611 * bgp_route.c: (bgp_pcount_{dec,inc}rement) removed.
612 (bgp_pcount_adjust) new, update prefix count as
613 needed for a given route.
614 (bgp_info_{uns,s}et_flag) set/unset a BGP_INFO route status
615 flag, calling previous function when appropriate.
616 (general) Update all set/unsets of flags to use previous.
617 Remove pcount_{dec,inc}rement calls.
618 No need to unset BGP_INFO_VALID in places where
619 bgp_info_delete is called, it does that anyway.
620 * bgp_{damp,nexthop}.c: Update to use bgp_info_{un,}set_flag.
621 * bgp_route.h: Export bgp_info_{un,}set_flag.
622 Add a 'meta' BGP_INFO flag, BGP_INFO_UNUSEABLE.
623 Move BGP_INFO_HOLDDOWN macro to here from bgpd.h
624
Paul Jakmaff7924f2006-09-04 01:10:36 +00006252006-09-03 Paul Jakma <paul.jakma@sun.com>
626
627 * bgp_route.c: Add 'show ... bgp ... <neighbour> prefix-count'
628 commands, to provide detailed counts of prefixes for a peer.
629 Informative, and should help pin down to pfxcnt drift
630 problems.
631
Paul Jakma9f906c72006-08-27 06:57:47 +00006322006-08-27 Paul Jakma <paul.jakma@sun.com>
633
634 * bgp_advertise.c: (bgp_sync_delete) fix mtype in XFREE.
635 NULL out peer->hash after free, to be sure.
636
Paul Jakma1f742f22006-08-06 15:52:11 +00006372006-08-06 Paul Jakma <paul.jakma@sun.com>
638
639 * bgp_aspath.c: (aspath_loop_check) Fix the typo-bug which
640 essentially had disabled this check. Problem reported by
641 Bartek Kania <mrbk@gnarf.org> in [quagga-users 7388].
642
Paul Jakma18937402006-07-27 19:05:12 +00006432006-07-27 Paul Jakma <paul.jakma@sun.com>
644
645 * bgpd.c: (peer_delete) Ensure freed buffers can not be
646 accidently reused. A potential fix for bug #287.
647
Paul Jakma33d5ab92006-07-02 11:01:50 +00006482006-07-02 Paul Jakma <paul.jakma@sun.com>
649
650 * bgp_fsm.c: (bgp_{stop,start}) Move clear/free of certain
651 bits of state from stop to start, as they may be used via
652 peer references on clearing queues..
653
Paul Jakma369688c2006-05-23 22:27:55 +00006542006-05-23 Paul Jakma <paul.jakma@sun.com>
655
656 * bgp_vty.c: (neighbor_update_source_cmd) Expand tab completion
657 to make it clear it takes both address and ifname.
658
Paul Jakma34c3f812006-05-12 23:25:37 +00006592006-05-12 Paul Jakma <paul.jakma@sun.com>
660
661 * bgp_attr.c: (bgp_packet_attribute) Remove dead code, Coverity
662 CID #1
Paul Jakmab2518c12006-05-12 23:48:40 +0000663 * bgp_aspath.{c,h}: (aspath_print_vty) take a format string,
664 so as to reduce burden on callers, all in bgp_route.c
Paul Jakmadd8103a2006-05-12 23:27:30 +0000665 * bgp_route.c: (bgp_static_update_main) Remove useless NULL
666 check, code already assumes bgp_static can not be NULL,
667 fixes CID #7.
Paul Jakma06e110f2006-05-12 23:29:22 +0000668 (bgp_static_update_rsclient) ditto, CID #6
Paul Jakmab2518c12006-05-12 23:48:40 +0000669 (route_vty_out{,tmp}) Update to match aspath_print_vty,
670 simplifying checks needed to get spacing right. CID #4,#5.
671 ({damp,flap}_route_vty_out) Ditto, CID #9, #10
Paul Jakma34c3f812006-05-12 23:25:37 +0000672
Paul Jakma542bcb72006-05-08 14:25:09 +00006732006-05-08 Paul Jakma <paul.jakma@sun.com>
674
675 * bgp_community.c: (community_str2com) Coverity CID#62, fix
676 double-free, use-after-free.
Paul Jakmada5b30f2006-05-08 14:37:17 +0000677 * bgp_route.c: (bgp_afi_node_get) given table should never be
678 NULL, check/assert this.
679 (bgp_static_update) Bug #240. Rsclients should only be passed
680 the static update if they are configured for the afi,safi.
Paul Jakma542bcb72006-05-08 14:25:09 +0000681
Paul Jakmaa3b6ea52006-05-04 07:52:12 +00006822006-05-04 Paul Jakma <paul.jakma@sun.com>
683
684 * (general) VPNv4 fixes. Certain VPNv4 code was not enabled.
685 See bug #210.
686 * bgp_attr.{c,h}: (bgp_packet_{withdraw,attribute}) Tag should be
687 u_char really.
688 * bgp_packet.c: (bgp_{update,withdraw}_packet) Enable some
689 VPNv4 code which inexplicably was ifdef'd out. comments from
690 a tester on IRC suggest this fixes bug #210.
Paul Jakma65ca75e2006-05-04 08:08:15 +0000691 * bgp_route.c: (general) Fix logical bug in clearing, noted
692 by Chris Caputo in [quagga-users 6728] - clearing depended on
693 at least one route being added to workqueue, in order for
694 workqueue completion function to restart FSM. However, if no
695 routes are cleared, then the completion function never is
696 called, it needs to be called manually if the workqueue
697 didn't get scheduled.
698 Finally, clearing is per-peer-session, not per AFI/SAFI, so
699 the FSM synchronisation should be in bgp_clear_route_table.
700 (bgp_clear_route_table) Wrong place for FSM/clearing
701 synchronisation, move to..
702 (bgp_clear_route) FSM/clearing synchronisation should be
703 here.
704 If no routes were cleared, no workqueue scheduled, call
705 the completion func to ensure FSM kicks off again.
Paul Jakmaa3b6ea52006-05-04 07:52:12 +0000706
Paul Jakma15aa6a12006-03-30 14:39:35 +00007072006-03-30 Paul Jakma <paul.jakma@sun.com>
708
709 * bgp_community.c: (community_gettoken) Unknown token should
710 return NULL, to give a strong indication to callers that
711 the token no longer can be parsed, otherwise callers looping
712 on this function may have a hard time ending their loop.
713 (community_str2com) While loop around community_gettoken appears
714 to have been coded thinking that break statement would break
715 from the while{}, hence it could never exit for unknown token
716 case. Fix it to do..while, so it can use the NULL result from
717 community_gettoken easily.
718
Paul Jakmaa625ca32006-03-30 14:12:38 +00007192006-03-22 Paul Jakma <paul.jakma@sun.com>
720
721 * bgpd.c: (peer_free) release the per-peer workqueue when
722 freeing the peer.
723
Paul Jakma5304cb52006-03-30 14:01:14 +00007242006-03-19 Paul Jakma <paul.jakma@sun.com>
725
Paul Jakma4bf6a362006-03-30 14:05:23 +0000726 * bgpd/bgp_vty.c: Add includes to get several structs we want
727 to provide usage statistics on.
728 (show_bgp_memory_cmd) Show memory usage stats for various
729 notable fixed size objects. Using mtype_stats_alloc and
730 mtype_memstr recently added to memory.c.
731 (bgp_show_summary) Report some additional stats specific to
732 the given BGP instance and/or AFI/SAFI such as table counts,
733 peers, rsclients and peer-groups.
734 (bgp_vty_init) Install show_bgp_memory_cmd.
Paul Jakma5304cb52006-03-30 14:01:14 +0000735 * bgp_nexthop.h: Include if.h as a dependent header, for struct
736 connected.
Paul Jakmab51f1262006-03-30 14:09:38 +0000737 * bgp_advertise.c: Use a distinct memory type for struct
738 bgp_synchronize.
Paul Jakma5304cb52006-03-30 14:01:14 +0000739
Paul Jakmacbdfbaa2006-03-30 13:20:48 +00007402006-03-12 Paul Jakma <paul.jakma@sun.com>
741
742 * bgp_attr.h: (struct attr) rearrange fields to avoid
743 wasted padding between them as much as possible.
744 (attr_count,attr_unknown_count) export new functions to
745 return number of counts of cached attributes.
746 * bgp_attr.c: (attr_count,attr_unknown_count) new functions to
747 return number of counts of cached attributes.
748 * bgp_route.h: (struct bgp_info) rearrange fields to avoid
749 wasted padding.
750 * bgp_table.h: (struct bgp_table) Add a count field, of number
751 of nodes in the table.
752 (struct bgp_node) rearrange fields to avoid
753 wasted padding between them, though I don't think there
754 was any in this case.
755 * bgp_table.c: (bgp_node_{delete,get}) Maintain the table node count.
756 (bgp_table_count) new function to access the table count.
757
Paul Jakma3e0c78e2006-03-06 18:06:53 +00007582006-03-03 Paul Jakma <paul.jakma@sun.com>
759
760 * bgp_route.c: (bgp_clear_node_complete) Doh. When clearing
761 is complete we need to kick off FSM again.
762
Paul Jakma64e580a2006-02-21 01:09:01 +00007632006-02-21 Paul Jakma <paul.jakma@sun.com>
764
765 * bgpd.h: move the clear_node_queue to be peer specific.
766 Add a new peer status flag, PEER_STATUS_CLEARING.
767 * bgp_table.h: (struct bgp_table) Add fields to record afi,
768 safi of the table.
769 (bgp_table_init) Take afi and safi to create table for.
770 * bgp_table.c: (bgp_table_init) record the afi and safi.
771 * bgp_nexthop.c: Update all calls to bgp_table_init.
772 * bgp_vty.c: ditto.
773 * bgpd.c: ditto.
774 * bgp_fsm.c: (bgp_timer_set) dont bring up a session which is
775 clearing.
776 * bgp_route.c: (general) Update all bgp_table_init calls.
777 (bgp_process_{rsclient,main}) clear_node is serialised
778 via PEER_STATUS_CLEARING and fsm now.
779 (struct bgp_clear_node_queue) can be removed. struct bgp_node
780 can be the queue item data directly, as struct peer can be
781 kept in the new wq global user data and afi/safi can be
782 retrieved via bgp_node -> bgp_table.
783 (bgp_clear_route_node) fix to get peer via wq->spec.data,
784 afi/safi via bgp_node->bgp_table.
785 (bgp_clear_node_queue_del) no more item data to delete, only
786 unlock the bgp_node.
787 (bgp_clear_node_complete) only need to unset CLEARING flag
788 and unlock struct peer.
789 (bgp_clear_node_queue_init) queue attaches to struct peer
790 now. record peer name as queue name.
791 (bgp_clear_route_table) If queue transitions to active,
792 serialise clearing by setting PEER_STATUS_CLEARING rather
793 than plugging process queue, and lock peer while queue
794 active.
795 Update to pass only bgp_node as per-queue-item specific data.
Paul Jakma6a419732006-02-21 01:14:13 +0000796 * bgp_vty.c: (bgp_show_summary) Add a 'Clrng' sub-description
797 to state of peer while it's suppressed due to clearing.
Paul Jakma64e580a2006-02-21 01:09:01 +0000798
Paul Jakmaaa94ca82006-02-18 10:49:04 +00007992006-02-18 Paul Jakma <paul.jakma@sun.com>
800
801 * bgp_routemap.c: (route_set_community) Quick, very hacky, fix
802 for the set-community leak, bug #89. True fix will be to
803 detangle the web of *_intern caching and provide saner object
804 caching for Quagga, future work.
Paul Jakma7c7fa1b2006-02-18 10:52:09 +0000805 * bgp_route.c: (bgp_announce_check) trivial, move declaration
806 of two local variables into the only block where they are
807 used, to aid the reader.
Paul Jakmaaa94ca82006-02-18 10:49:04 +0000808
paul902212c2006-02-05 17:51:19 +00008092006-02-05 Paul Jakma <paul.jakma@sun.com>
810
811 * bgp_route.h: Add BGP_INFO_COUNTED to track whether
812 prefix has been counted or not.
813 * bgp_route.c: (bgp_pcount_{inc,dec}rement) new helpers, to
814 centralise inc/dec of prefix-count,
815 (bgp_rib_remove) Remove pcount decrement, use helper.
816 (bgp_rib_withdraw) ditto, additionally use previous function
817 too.
818 (bgp_update_main) Use pcount helpers.
819 (bgp_clear_route_node) ditto, aslo REMOVED routes don't need
820 clearing.
paul3fff6ff2006-02-05 17:55:35 +0000821 * bgp_aspath.c: (aspath_gettoken) fix gcc warning about
822 possible uninitialised usage.
paul902212c2006-02-05 17:51:19 +0000823
paul306d8892006-02-02 17:50:19 +00008242006-02-02 Paul Jakma <paul.jakma@sun.com>
825
826 * bgp_route.c: (bgp_{clear_node,process}_queue_init) delay
827 field is removed from workqueue spec.
828
paule8e19462006-01-19 20:16:55 +00008292006-01-19 Paul Jakma <paul.jakma@sun.com>
830
831 * (general) various miscellaneous compiler warning fixes.
832 Remove redundant break statements from switch clauses
833 which return.
834 return from main, not exit, cause it annoys SOS.
835 Remove stray semi-colons which cause empty-statement
836 warnings.
837
pauld3092e72006-01-17 17:33:46 +00008382006-01-17 Paul Jakma <paul.jakma@sun.com>
839
840 * bgp_nexthop.c: (zlookup_read*) convert to new Zserv format.
841 (zlookup_query_ipv6) ditto.
842 (bgp_import_check) ditto.
843
paul02335422006-01-16 11:13:27 +00008442006-01-16 Paul Jakma <paul.jakma@sun.com>
845
846 * bgp_aspath.c: (assegment_append_asns) XREALLOC can return
847 NULL theoretically, take care not to lose the allocated data.
848 (aspath_hash_alloc) aspath_dup already set the aspath
849 string - fix leak.
850 (aspath_parse) aspath_hash_alloc dupes the entire aspath,
851 including segments, but we forgot to free the temporary
852 assegment.
paul8fdc32a2006-01-16 12:01:29 +0000853 (aspath_snmp_pathseg) move the static stream pointer out to
854 file scope, so it can be freed.
855 (aspath_finish) new function, free aspath resources.
856 * bgp_aspath.h: (aspath_finish) export.
paul02335422006-01-16 11:13:27 +0000857
paul37c38302006-01-10 22:15:45 +00008582006-01-10 Juris Kalnins <juris@mt.lv>
859
860 * bgpd.h: (bgp_router_id_unset) ex-function, remove.
861
paulad727402005-11-23 02:47:02 +00008622005-11-23 Paul Jakma <paul.jakma@sun.com>
863
864 * bgp_aspath.c: (assegments_parse) should be static
865
8662005-11-23 Juergen Kammer <j.kammer@eurodata.de>
867
868 * bgp_aspath.c: (aspath_cmp_left_confed) fix SEGV for case
869 where one or both paths are empty.
870
paul0fb58d52005-11-14 14:31:49 +00008712005-11-14 Paul Jakma <paul.jakma@sun.com>
872
873 * bgp_route.c: (bgp_process_rsclient) convert to new workqueue
874 specs and shut up gcc, which complains about cast from void
875 via function parameters, for some dumb reason. Do the cast
876 inside the function instead.
877 (bgp_process_main,bgp_processq_del) ditto.
878 (bgp_clear_route_node) ditto.
879 (bgp_clear_node_queue_del) ditto.
880
paul41200852005-11-03 12:52:18 +00008812005-11-03 Paul Jakma <paul.jakma@sun.com>
882
883 * bgp_damp.c: (bgp_reuse_timer) struct bgp can be retrieved via
884 the struct bgp_damp_info, no need to guess by using
885 bgp_get_default().
886
ajsf52d13c2005-10-01 17:38:06 +00008872005-10-01 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
888
889 * bgp_vty.c: (bgp_config_write_redistribute) Use new library function
890 zebra_route_string instead of a local hard-coded table.
891
jardin2d74db52005-10-01 00:07:50 +00008922005-09-30 Vincent Jardin <vincent.jardin@6wind.com>
893
894 * bgp_packet.c: fix compilation when DEBUG is used.
895
paul1f8ae702005-09-09 23:49:49 +00008962005-09-10 Paul Jakma <paul.jakma@sun.com>
897
paulfe69a502005-09-10 16:55:02 +0000898 * Makefile.am: bgpd shouldn't list libgp's sources as its own.
899 Use LDADD.
900 * bgp_aspath.h:
901 (struct assegment) New struct, abstract representation of a
902 list of AS_PATH segments and the contained ASNs.
903 (struct aspath) Remove the raw-data related
904 fields, reference the abstract struct assegment instead.
905 Remove several other computed fields, it's just a
906 headache to maintain them and they're cheap to compute from
907 struct assegment.
908 (aspath_parse) parse a stream, not a pointer to raw data.
909 (aspath_count_{hops,confeds,size}) helpers to access
910 information formerly directly contained in struct aspath.
911 (aspath_snmp_pathseg) Helper for SNMP, BGP MIB wants
912 to be able to output hex representation of raw data.
913 * bgp_aspath.c: (general) partial-rewrite. Store aspath data
914 as an abstract singly-linked list of abstract segments,
915 rather than storing the raw data, and parsing it each and
916 every time. Remove several count/size fields which are cheap
917 to compute from the abstract segment structure.
918 (global) Include stream.h, needed for aspath_parse, and
919 others. Couple of helper macros added.
920 (struct assegment_header) Just the header, and only the
921 header.
922 (assegment_data_{new,free}) convenience functions for
923 AS_SEG_DATA allocation, the dynamic, per-segment array of
924 ASNs.
925 (assegment_{new,free,free_all,dup,dup_all}) convenience
926 functions for creating struct assegments. The _all forms will
927 follow the entire chain of segments from the given segment.
928 (assegment_prepend_asns) new function, prepend an ASN N times
929 to segment.
930 (assegment_append_asns) Append a list (array) of ASNs to
931 segment.
932 (int_cmp) convenience function for the aspath hash.
933 (assegment_normalise) new function. Normalise the given
934 segment chain to meet expectations of Quagga, and to
935 eliminate differing raw representations of the same paths.
936 Merge 'runs' of SEQUENCEs into one segment as our internal
937 segment is not limited by the protocol AS_PATH segment
938 length. Sort ASNs in SETs.
939 (aspath_new) Take void argument to quell warnings. Use the
940 assegment convenience functions.
941 (assegment_count_{asns,confeds,hops}) new functions to
942 compute at runtime values previously held in struct aspath.
943 (aspath_size) ditto.
944 (aspath_make_str_count) rewritten to stringify new
945 representation, and to be slightly easier to understand
946 hopefully.
947 (aspath_str_update) convenience function, update the aspath
948 str. Should investigate removing maintained string from
949 struct aspath, just run-time compute it, as per other fields.
950 It's just a maintenance headache, would save noticeable
951 amount of RAM with possibly not much extra run-time cost.
952 (aspath_dup) use the assegment dup functions.
953 (aspath_hash_alloc) Take void * argument to satisfy gcc. Use
954 the proper helper functions to dup data.
955 (assegments_parse) new function. parse raw AS_PATH data into
956 struct assegments. Normalise and return the head of the list.
957 (aspath_parse) Parse a stream, not pointer to raw data and
958 use assegments_parse to do it.
959 (assegment_data_put) Write out a single segment data in protocol
960 form to stream.
961 (assegment_header_put) ditto but for segment header.
962 (aspath_put) new function. As per previous but for an entire
963 struct aspath.
964 (aspath_snmp_pathseg) wrapper around aspath_put for
965 bgp_snmp.c. Uses a static buffer sadly.
966 (aspath_aggregate_as_set_add) rewritten to use assegments.
967 (aspath_aggregate) ditto
968 (aspath_{firstas,loop,private_as}_check) ditto
969 (aspath_{merge,prepend,add_one_as}) ditto
970 (aspath_cmp_left{_confed}) ditto
971 (aspath_delete_confed_seq) ditto, plus fixed to properly
972 delete all leading confed segments.
973 (aspath_as_add) Just use assegment_append_asns.
974 (aspath_segment_add) updated to use assegments.
975 (enum as_token) Add values for confeds
976 (aspath_gettoken) Add support for confeds
977 (aspath_str2aspath) ditto
978 (aspath_key_make) updated to use as_segments. Also, add
979 segment type into the hash value as appropriate.
980 (aspath_cmp) updated to use as_segments.
981 (aspath_print) don't segfault on NULL argument.
982 * bgp_attr.c: (bgp_attr_aspath) aspath_parse wants the stream
983 now. No need for manual forwarding of stream.
984 (bgp_packet_attribute) empty aspath is now denoted by NULL
985 segment field, length is gone.
986 Use aspath_size() to determine size.
987 (bgp_attr_init) Fix declaration, explicitely specify void
988 arg.
989 (bgp_dump_routes_attr) Use aspath_size() to determine size.
990 * bgp_route.c: (bgp_info_cmp) use the aspath_count_* functions.
991 (bgp_rib_withdraw) remove unused variable. Use
992 aspath_count_hops.
993 * bgp_snmp.c: (bgp4PathAttrTable) raw data is gone, use
994 aspath_snmp_pathseg to get the representation.
995
9962005-09-10 Paul Jakma <paul.jakma@sun.com>
997
paul1f8ae702005-09-09 23:49:49 +0000998 * bgp_vty.c: (bgp_vty_init) gcc 4 compile fix. static
999 function declarations shouldn't be inside functions.
1000 * bgp_dump.c: (bgp_dump_interval_add) ditto.
1001
hassob7395792005-08-26 12:58:38 +000010022005-08-26 Hasso Tepper <hasso at quagga.net>
1003
1004 * bgp_route.c: Third (?) attempt to fix best selection breakage
1005 introduced long time ago with route server patch. Hopefully
1006 it's last case to fix - route-server client not in peer group.
1007
paul25ffbdc2005-08-22 22:42:08 +000010082005-08-22 Hugo Santos <hsantos@av.it.pt>
1009
1010 * bgp_vty.c: (general) Add support for BGP IPv6 Multicast SAFI
1011 commands and BGP_IPV6M_NODE.
1012
paulb40d9392005-08-22 22:34:41 +000010132005-08-22 Paul Jakma <paul.jakma@sun.com>
1014
1015 * bgp_route.h: (struct bgp_info) add a new flag, BGP_INFO_REMOVED.
1016 BGP_INFO_VALID is already overloaded, don't care to do same thing
1017 to STALE or HISTORY.
1018 * bgpd.h: (BGP_INFO_HOLDDOWN) Add INFO_REMOVED to the macro, as a
1019 route which should generally be ignored.
1020 * bgp_route.c: (bgp_info_delete) Just set the REMOVE flag, rather
1021 than doing actual work, so that bgp_process (called directly,
1022 or indirectly via the scanner) can catch withdrawn routes.
1023 (bgp_info_reap) Actually remove the route, what bgp_info_delete
1024 used to do, only for use by bgp_process.
1025 (bgp_best_selection) reap any REMOVED routes, other than the old
1026 selected route.
1027 (bgp_process_rsclient) reap the old-selected route, if appropriate
1028 (bgp_process_main) ditto
1029 (bgp_rib_withdraw, bgp_rib_remove) make them more consistent with
1030 each other. Don't play games with the VALID flag, bgp_process
1031 is async now, so it didn't make a difference anyway.
1032 Remove the 'force' argument from bgp_rib_withdraw, withdraw+force
1033 is equivalent to bgp_rib_remove. Update all its callers.
1034 (bgp_update_rsclient) bgp_rib_withdraw and force set is same as
1035 bgp_rib_remove.
1036 (route_vty_short_status_out) new helper to print the leading
1037 route-status string used in many command outputs. Consolidate.
1038 (route_vty_out, route_vty_out_tag, damp_route_vty_out,
1039 flap_route_vty_out) use route_vty_short_status_out rather than
1040 duplicate.
1041 (route_vty_out_detail) print state of REMOVED flag.
1042 (BGP_SHOW_SCODE_HEADER) update for Removed flag.
1043
hassoe279c7a2005-08-03 17:23:20 +000010442005-08-03 Hasso Tepper <hasso at quagga.net>
1045
1046 * bgp_routemap.c: Revert part of leaking communities fix commited in
1047 2005-05-27. While ecommunity fix seems to be correct, community case
1048 isn't.
1049
paul94f2b392005-06-28 12:44:16 +000010502005-06-28 Paul Jakma <paul.jakma@sun.com>
1051
1052 * (global) The great bgpd extern and static'ification.
1053 * bgp_routemap.c: remove unused ROUTE_MATCH_ASPATH_OLD code
1054 (route_set_metric_compile) fix u_int32_t to ULONG_MAX comparison
1055 warnings.
1056 * bgp_route.h: (bgp_process, bgp_withdraw, bgp_update) export these
1057 used by various files which had their own private declarations,
1058 in the case of mplsvpn - incorrect.
1059
paule210cf92005-06-15 19:15:35 +000010602005-06-15 Paul Jakma <paul.jakma@sun.com>
1061
1062 * bgpd.c: (bgp_terminate) workqueue's are lazy allocated and its
1063 possible to terminate bgpd before workqueues were setup, causing
1064 an abort/crash. Reported by Ashish Mehta of Sun.
1065
paul200df112005-06-01 11:17:05 +000010662005-06-01 Paul Jakma <paul.jakma@sun.com>
1067
1068 * (general) refcount struct peer and bgp_info, hence allowing us
1069 add work_queues for bgp_process.
1070 * bgp_route.h: (struct bgp_info) Add 'lock' field for refcount.
1071 Add bgp_info_{lock,unlock} helper functions.
1072 Add bgp_info_{add,delete} helpers, to remove need for
1073 users managing locking/freeing of bgp_info and bgp_node's.
1074 * bgp_table.h: (struct bgp_node) Add a flags field, and
1075 BGP_NODE_PROCESS_SCHEDULED to merge redundant processing of
1076 nodes.
1077 * bgp_fsm.h: Make the ON/OFF/ADD/REMOVE macros lock and unlock
1078 peer reference as appropriate.
1079 * bgp_damp.c: Remove its internal prototypes for
1080 bgp_info_delete/free. Just use bgp_info_delete.
1081 * bgpd.h: (struct bgp_master) Add work_queue pointers.
1082 (struct peer) Add reference count 'lock'
1083 (peer_lock,peer_unlock) New helpers to take/release reference
1084 on struct peer.
1085 * bgp_advertise.c: (general) Add peer and bgp_info refcounting
1086 and balance how references are taken and released.
1087 (bgp_advertise_free) release bgp_info reference, if appropriate
1088 (bgp_adj_out_free) unlock peer
1089 (bgp_advertise_clean) leave the adv references alone, or else
1090 call bgp_advertise_free cant unlock them.
1091 (bgp_adj_out_set) lock the peer on new adj's, leave the reference
1092 alone otherwise. lock the new bgp_info reference.
1093 (bgp_adj_in_set) lock the peer reference
1094 (bgp_adj_in_remove) and unlock it here
1095 (bgp_sync_delete) make hash_free on peer conditional, just in
1096 case.
1097 * bgp_fsm.c: (general) document that the timers depend on
1098 bgp_event to release a peer reference.
1099 (bgp_fsm_change_status) moved up the file, unchanged.
1100 (bgp_stop) Decrement peer lock as many times as cancel_event
1101 canceled - shouldnt be needed but just in case.
1102 stream_fifo_clean of obuf made conditional, just in case.
1103 (bgp_event) always unlock the peer, regardless of return value
1104 of bgp_fsm_change_status.
1105 * bgp_packet.c: (general) change several bgp_stop's to BGP_EVENT's.
1106 (bgp_read) Add a mysterious extra peer_unlock for ACCEPT_PEERs
1107 along with a comment on it.
1108 * bgp_route.c: (general) Add refcounting of bgp_info, cleanup
1109 some of the resource management around bgp_info. Refcount peer.
1110 Add workqueues for bgp_process and clear_table.
1111 (bgp_info_new) make static
1112 (bgp_info_free) Ditto, and unlock the peer reference.
1113 (bgp_info_lock,bgp_info_unlock) new exported functions
1114 (bgp_info_add) Add a bgp_info to a bgp_node in correct fashion,
1115 taking care of reference counts.
1116 (bgp_info_delete) do the opposite of bgp_info_add.
1117 (bgp_process_rsclient) Converted into a work_queue work function.
1118 (bgp_process_main) ditto.
1119 (bgp_processq_del) process work queue item deconstructor
1120 (bgp_process_queue_init) process work queue init
1121 (bgp_process) call init function if required, set up queue item
1122 and add to queue, rather than calling process functions directly.
1123 (bgp_rib_remove) let bgp_info_delete manage bgp_info refcounts
1124 (bgp_rib_withdraw) ditto
1125 (bgp_update_rsclient) let bgp_info_add manage refcounts
1126 (bgp_update_main) ditto
1127 (bgp_clear_route_node) clear_node_queue work function, does
1128 per-node aspects of what bgp_clear_route_table did previously
1129 (bgp_clear_node_queue_del) clear_node_queue item delete function
1130 (bgp_clear_node_complete) clear_node_queue completion function,
1131 it unplugs the process queues, which have to be blocked while
1132 clear_node_queue is being processed to prevent a race.
1133 (bgp_clear_node_queue_init) init function for clear_node_queue
1134 work queues
1135 (bgp_clear_route_table) Sets up items onto a workqueue now, rather
1136 than clearing each node directly. Plugs both process queues to
1137 avoid potential race.
1138 (bgp_static_withdraw_rsclient) let bgp_info_{add,delete} manage
1139 bgp_info refcounts.
1140 (bgp_static_update_rsclient) ditto
1141 (bgp_static_update_main) ditto
1142 (bgp_static_update_vpnv4) ditto, remove unneeded cast.
1143 (bgp_static_withdraw) see bgp_static_withdraw_rsclient
1144 (bgp_static_withdraw_vpnv4) ditto
1145 (bgp_aggregate_{route,add,delete}) ditto
1146 (bgp_redistribute_{add,delete,withdraw}) ditto
1147 * bgp_vty.c: (peer_rsclient_set_vty) lock rsclient list peer
1148 reference
1149 (peer_rsclient_unset_vty) ditto, but unlock same reference
1150 * bgpd.c: (peer_free) handle frees of info to be kept for lifetime
1151 of struct peer.
1152 (peer_lock,peer_unlock) peer refcount helpers
1153 (peer_new) add initial refcounts
1154 (peer_create,peer_create_accept) lock peer as appropriate
1155 (peer_delete) unlock as appropriate, move out some free's to
1156 peer_free.
1157 (peer_group_bind,peer_group_unbind) peer refcounting as
1158 appropriate.
1159 (bgp_create) check CALLOC return value.
1160 (bgp_terminate) free workqueues too.
1161
hasso033e8612005-05-28 04:50:54 +000011622005-05-28 Hasso Tepper <hasso at quagga.net>
1163
1164 * bgp_routemap.c: Sync set_metric_addsub_cmd with ripd.
1165
hasso54a6ed32005-05-26 22:12:33 +000011662005-05-27 Hasso Tepper <hasso at quagga.net>
1167
hasso70601e02005-05-27 03:26:57 +00001168 * bgp_routemap.c: Stop leaking communities.
1169
11702005-05-27 Hasso Tepper <hasso at quagga.net>
1171
hasso54a6ed32005-05-26 22:12:33 +00001172 * bgpd.c: Deleting bgp->rsclient list needs fix similar to pree-groups
1173 deleting fix. Avoid leaking bgp->group, bgp->peer and bgp->rsclient
1174 lists.
1175
11762005-05-26 Hasso Tepper <hasso at quagga.net>
hassob6b7cff2005-05-26 08:29:07 +00001177
1178 * bgpd.c: Don't crash while deleting list of peer-groups.
1179
hassob5f29602005-05-25 21:00:28 +000011802005-05-25 Hasso Tepper <hasso at quagga.net>
1181
1182 * bgpd.c: Fix obvious (routeserver patch) merge error. This makes "no
1183 neighbor x.x.x.x routemap [export|import] commands work again.
1184
paula94feb32005-05-23 13:17:29 +000011852005-05-23 Paul Jakma <paul@dishone.st>
1186
1187 * bgp_routemap.c: add semi-colons to VTY_GET_* to match vty.h change
paul00d252c2005-05-23 14:19:54 +00001188 * bgp_fsm.h: Add extern qualifier to exported functions
1189 * bgp_nexthop.c: add static to nexthop specific globals
1190 * *.h: Add guard defines
paula94feb32005-05-23 13:17:29 +00001191
paul22db9de2005-05-19 01:50:11 +000011922005-05-19 Paul Jakma <paul@dishone.st>
1193
1194 * bgp_fsm.c: (bgp_stop) use sockunion_free, not XFREE..
1195 * bgp_network.c: (bgp_getsockname) ditto
paule83e2082005-05-19 02:12:25 +00001196 (bgp_accept) use XSTRDUP
paul22db9de2005-05-19 01:50:11 +00001197 * bgp_routemap.c: (route_match_peer) ditto, als use a ret value and
1198 remove one sockunion_free.
paule83e2082005-05-19 02:12:25 +00001199 * bgpd.c: (peer_delete) ditto.
1200 XFREE the correct memtype, not free.
1201 (peer_create) use XSTRDUP
1202 * bgp_packet.c: (bgp_stream_dup) deleted, stream_dup should be used
1203 (various) update -> s/bgp_stream_dup/stream_dup
1204
paul22db9de2005-05-19 01:50:11 +00001205
ajs634f9ea2005-04-11 15:51:40 +000012062005-04-11 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1207
1208 * bgp_zebra.c (bgp_redistribute_set, bgp_redistribute_unset):
1209 The 2nd arg to zebra_redistribute_send is now zclient instead of
1210 zclient->sock.
1211
hassoa8a80d52005-04-09 13:07:47 +000012122005-04-09 Akihiro Mizutani <mizutani@net-chef.net>
1213
1214 * bgp_vty.c: Make "exit-address-family" work in IPv4 unicast address
1215 family node.
1216
hasso68118452005-04-08 15:40:36 +000012172005-04-08 Martin Ling <martin-quagga@earth.li>
1218
1219 * bgp_aspath.[ch], bgp_route.c, bgp_vty.c, bgpd.[ch]: Allow to enable
1220 the length of confederation path segments to be included during the
1221 as-path length check in the best path decision.
1222
ajsd2fc8892005-04-02 18:38:43 +000012232005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1224
1225 * bgp_zebra.c: (bgp_interface_delete) After deleting, set ifp->ifindex
1226 to IFINDEX_INTERNAL.
1227
hasso6cf159b2005-03-21 10:28:14 +000012282005-03-21 Hasso Tepper <hasso at quagga.net>
1229
1230 * bgp_route.c: Don't crash while clearing route tables if there is
1231 no particular afi/safi configured.
1232
hasso338b3422005-02-23 14:27:24 +000012332005-02-23 Hasso Tepper <hasso at quagga.net>
1234
1235 * bgp_route.c: Make reannouncing prefixes with changed attributes
1236 work again.
1237
hasso6ffd2072005-02-02 14:50:11 +000012382005-02-02 Akihiro Mizutani <mizutani@net-chef.net>
1239
hassodd4c5932005-02-02 17:15:34 +00001240 * bgp_vty.c: Deprecate "neighbor transparent-as" and "neighbor
1241 transparent-nexthop" commands.
1242
12432005-02-02 Akihiro Mizutani <mizutani@net-chef.net>
1244
hassoc1643bb2005-02-02 16:43:17 +00001245 * bgp_routemap.c: New route-map command - "match ip route-source".
1246
12472005-02-02 Akihiro Mizutani <mizutani@net-chef.net>
1248
hassofee6e4e2005-02-02 16:29:31 +00001249 * bgp_clist.[ch], bgp_route.c, bgp_routemap.c, bgp_vty.c:
1250 community-list cleanup.
1251
12522005-02-02 Akihiro Mizutani <mizutani@net-chef.net>
1253
hasso6ffd2072005-02-02 14:50:11 +00001254 * bgp_route.c, bgp_vty.c, bgp_zebra.c, bgpd.[ch]: "enforce-multihop"
1255 -> "disable-connected-check".
1256
12572005-02-02 Akihiro Mizutani <mizutani@net-chef.net>
hasso93406d82005-02-02 14:40:33 +00001258
1259 * bgp_fsm.c, bgp_open.c, bgp_packet.c, bgp_route.[ch], bgp_vty.c,
1260 bgpd.[ch]: Add BGP_INFO_STALE flag and end-of-rib support. "bgp
1261 graceful-restart" commands added. Show numbers of individual
1262 messages in "show ip bgp neighbor" command. Final pieces of graceful
1263 restart.
1264
hassof4184462005-02-01 20:13:16 +000012652005-02-01 Akihiro Mizutani <mizutani@net-chef.net>
1266
hassoc9502432005-02-01 22:01:48 +00001267 * bgp_open.c, bgp_packet.c, bgp_vty.c, bgpd.[ch]: Remove "no neighbor
1268 capability route-refresh" commands. Route refresh capability is sent
1269 anyway now. Preserve dummy deprecated commands.
1270
12712005-02-01 Akihiro Mizutani <mizutani@net-chef.net>
1272
hasso3d515fd2005-02-01 21:30:04 +00001273 * bgp_attr.c, bgp_snmp.c, bgp_vty.c, bgpd.[ch]: Remove support for old
1274 draft - ie. "neighbor version 4-" commands. Preserve dummy "neighbor
1275 version" command as deprecated.
1276
12772005-02-01 Akihiro Mizutani <mizutani@net-chef.net>
1278
hasso0a486e52005-02-01 20:57:17 +00001279 * bgpd.[ch], bgp_vty.c, bgp_route.c: "Restart session after
1280 maximum-prefix limit" feature support.
1281
12822005-02-01 Akihiro Mizutani <mizutani@net-chef.net>
1283
hassof4184462005-02-01 20:13:16 +00001284 * bgp_nexthop.c: Improve debug.
1285 * bgpd.[ch], bgp_nexthop.c, bgp_snmp.c: Remove useless bgp_get_master()
1286 function.
1287 * bgp_packet.c: MP AFI_IP update and withdraw parsing.
1288 * bgp_fsm.c: Reset peer synctime in bgp_stop(). bgp_fsm_change_status()
1289 is better place to log about peer status change than bgp_event().
1290 Log in bgp_connect_success().
1291 * bgp_vty.c: Fix typo in comment.
1292 * bgp_attr.c: Better log about unknown attribute.
1293
ajs3b8b1852005-01-29 18:19:13 +000012942005-01-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1295
1296 * bgp_filter.c: (ip_as_path,no_ip_as_path) Use argv_concat instead
1297 of buffer_getstr.
1298 * bgp_route.c: (bgp_show_regexp) Fix memory leak: need to free string
1299 returned by buffer_getstr.
1300 (bgp_show_community) Must use XFREE instead of free on string
1301 returned by buffer_getstr.
1302 * bgp_routemap.c: (set_community) Must use XFREE instead of free
1303 on string returned by buffer_getstr.
1304 * bgp_vty.c: (neighbor_description) Use argv_concat instead of
1305 buffer_getstr.
1306
hasso6d694292005-01-24 09:29:42 +000013072005-01-24 Hasso Tepper <hasso at quagga.net>
1308
1309 * bgp_route.c: Fix showstopper bug. New route must be selected also
1310 if old one is flaged as BGP_INFO_ATTR_CHANGED.
1311
hassof1271652005-01-17 11:04:32 +000013122005-01-17 Hasso Tepper <hasso at quagga.net>
1313
1314 * bgp_route.c: Clear peer's routing table regardless whether it's
1315 configured or not. Being not configured is even better reason to
1316 do it.
1317
paula24a7e12005-01-05 08:14:13 +000013182005-01-05 Paul Jakma <paul@dishone.st>
1319
1320 * bgp_packet.c: (bgp_write) set socket to nonblock while writing
1321 this should be generalised. See bugzilla #102. Fix supplied by
1322 wawa@yandex-team.ru (Vladimir Ivanov).
1323
ajsd2c1f162004-12-08 21:10:20 +000013242004-12-08 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1325
1326 * *.c: Change level of debug messages to LOG_DEBUG.
1327
ajs274a4a42004-12-07 15:39:31 +000013282004-12-07 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1329
1330 * bgp_main.c: (main) The 2nd argument to openzlog has been removed.
1331
ajs887c44a2004-12-03 16:36:46 +000013322004-12-03 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1333
1334 * bgp_main.c: (sigint) Use zlog_notice for termination message.
1335 (main) Use zlog_notice for startup announcement.
1336
hassoc0652302004-11-25 19:33:48 +000013372004-11-25 Hasso Tepper <hasso at quagga.net>
1338
1339 * bgp_main.c: Make group to run as configurable.
1340
paul59320202004-11-09 01:54:03 +000013412004-11-09 Paul Jakma <paul@dishone.st>
1342
1343 * bgp_nexthop.c: collapse bgp_connected_ipvX, bgp_nexthop_cache_ipvX
1344 and cache{1,2}.. into arrays of tables and hence collapse
1345 bgp_scan_ipv{4,6} into a single bgp_scan function. Tested, though
1346 a long time ago (and this change was hand-merged).
1347
ajs5a646652004-11-05 01:25:55 +000013482004-11-04 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1349
1350 * bgp_route.c: Remove all code related to VTY_CONTINUE; this feature
1351 is deprecated because the output did not represent a single point
1352 in time. All output needs to be generated inline and buffered
1353 by the library code.
1354 (route_vty_out,route_vty_out_tag,damp_route_vty_out,
1355 flap_route_vty_out) Remove code to count number of lines of output,
1356 since this was only useful for VTY_CONTINUE behavior.
1357 (bgp_show_callback,vty_calc_line) Removed.
1358 (bgp_show_table) Remove hooks for VTY_CONTINUE callback support.
1359 As a result, there's a new output_arg argument to this function.
1360 Make function static.
1361 (bgp_show) Make function static and add a new output_arg argument.
1362 Change all functions that call bgp_show or bgp_show_table to
1363 pass the new output_arg argument (that used to be passed inside
1364 vty->output_arg).
1365 * bgp_mplsvpn.c: Remove declarations of functions defined in
1366 bgp_route.c; these declarations belong in bgp_route.h.
1367 * bgp_route.h: Declare 3 global functions used in both bgp_route.c
1368 and in bgp_mplsvpn.c.
1369
paula2b1ecd2004-10-31 18:58:09 +000013702004-10-31 Paul Jakma <paul@dishone.st>
1371
1372 * {bgpd,bgp_attr}.c: size_t printf format should be ld.
1373
paul98f51632004-10-25 14:19:15 +000013742004-10-25 Paul Jakma <paul@dishone.st>
1375
1376 * Update with fix in debian bug id 222930.
1377 * bgp_main.c: Add ZCAP_RAW, needed to bind to interfaces.
1378 bgp_network.c: (....) raise/lower privs around call to
1379 SO_BINDTODEVICE sockopt.
1380
hasso3fb9cd62004-10-19 19:44:43 +000013812004-10-19 Andrew J. Schorr <aschorr@telemetry-investments.com>
1382
1383 * bgp_nexthop.c: (bgp_connected_add) Connected destination pointer
1384 may be NULL.
1385 (bgp_connected_delete) ditto.
1386
hasso501ba492004-10-13 21:32:46 +000013872004-10-14 Hasso Tepper <hasso at quagga.net>
1388
1389 * bgp_dump.c: Make dump configuration appear in vtysh.
1390
hassoc75105a2004-10-13 10:33:26 +000013912004-10-13 Hasso Tepper <hasso at quagga.net>
1392
1393 * bgp_snmp.c: Remove defaults used to initialize smux connection to
1394 snmpd. Connection is initialized only if smux peer is configured.
hasso8b3126b2004-10-13 20:59:04 +00001395 * bgp_view.c: It's dead file. Reomved.
hassoc75105a2004-10-13 10:33:26 +00001396
paulfd79ac92004-10-13 05:06:08 +000013972004-10-13 Paul Jakma <paul@dishone.st>
1398
1399 * (global) more const'ification and fixups of types to clean up code.
1400 * bgp_mplsvpn.{c,h}: (str2tag) fix abuse. Still not perfect,
1401 should use something like the VTY_GET_INTEGER macro, but without
1402 the vty_out bits..
1403 * bgp_routemap.c: (set_aggregator_as) use VTY_GET_INTEGER_RANGE
1404 (no_set_aggregator_as) ditto.
1405 * bgpd.c: (peer_uptime) fix unlikely bug, where no buffer is
1406 returned, add comments about troublesome return value.
1407
hasso18a6dce2004-10-03 18:18:34 +000014082004-10-03 James R. Leu <jleu at mindspring.com>
1409
1410 * bgp_vty.c: Router id from zebra can be manually overriden.
1411 * bgp_zebra.c: Read router id related messages from zebra daemon.
1412 Remove own code related with router id selection.
1413 * bgpd.c, bgpd.h: Remove own router id selection code. Use the one
1414 from zebra daemon if it isn't manually overriden.
1415
hassoc9e52be2004-09-26 16:09:34 +000014162004-09-26 Hasso Tepper <hasso at quagga.net>
1417
1418 * bgp_aspath.c, bgp_packet.c, bgp_vty.c: Fix compiler warnings.
1419
hasso52dc7ee2004-09-23 19:18:23 +000014202004-09-23 Hasso Tepper <hasso at quagga.net>
1421
1422 * *.[c|h]: list -> struct list *, listnode -> struct listnode *.
1423
paule01f9cb2004-07-09 17:48:53 +000014242004-07-09 Paul Jakma <paul@dishone.st>
1425
1426 * Merge of GNU Zebra cvs2svn changesets r799, r800 and r807.
1427 * bgp_dump.c: (bgp_dump_attr) cleanup. return status code. check
1428 attributes present before printing.
1429 * bgp_dump.c: update bgp_dump_attr prototype.
1430 * bgp_packet.c: (bgp_update_receive) init attrstr. check status
1431 of bgp_dump_attr. Log end-of-rib UPDATEs.
1432
paulf5ba3872004-07-09 12:11:31 +000014332004-07-09 Sowmini Varadhan <sowmini.varadhan@sun.com>
1434
1435 * bgp_packet.c: (bgp_collision_detect) Send NOTIFY on new socket
1436 if that is connection we're closing.
1437 (bgp_read) invalid marker check applies to KEEPALIVE too.
1438 * bgp_route.c: Ignore multicast NRLI, dont send NOTIFY.
1439
paul5228ad22004-06-04 17:58:18 +000014402004-06-04 Paul Jakma <paul@dishone.st>
1441
1442 * type mismatch fixes
1443
hasso538621f2004-05-21 09:31:30 +000014442004-05-21 Akihiro Mizutani <mizutani@net-chef.net>
1445
1446 * bgpd.h, bgp_open.[ch], bgp_debug.c, bgp_vty.[ch], bgp_fsm.c:
1447 Graceful restart capability display.
1448
hasso3950fda2004-05-20 10:22:49 +000014492005-05-20 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1450
1451 * bgp_debug.c: Cosmetical fixes and log neighbor changes.
1452
hasso4372df72004-05-20 10:20:02 +000014532004-05-20 Akihiro Mizutani <mizutani@net-chef.net>
1454
1455 * bgp_ecommunity.c: Transit ecommunity support.
1456 * bgp_ecommunity.c: Fix for unknown community crush.
1457
hassoe0701b72004-05-20 09:19:34 +000014582005-05-20 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1459
1460 * *: Maximum prefix threshold support.
1461 * *: Reset notification fixups.
1462
paul0a589352004-05-08 11:48:26 +000014632004-05-08 Paul Jakma <paul@dishone.st>
1464
1465 * bgp_zebra.c: (bgp_interface_address_add) sync to zclient changes
1466 (bgp_interface_address_delete) ditto.
1467 (bgp_zebra_announce) ditto.
1468 (bgp_zebra_withdraw) ditto.
1469
paulc5317402004-05-03 13:25:06 +000014702004-05-03 Daniel Roesen <dr@cluenet.de>
1471
1472 * bgp_fsm.c: (bgp_stop) Reset uptime only on transition from
1473 Established so that it reflects true downtime (rather time
1474 since last transition, eg Active->Idle)
1475
paul35be31b2004-05-01 18:17:04 +000014762004-05-01 rivo nurges <rix@estpak.ee>
1477
1478 * bgp_route.c: fix UNH IOL BGP-4.1.12f
1479
pauleb821182004-05-01 08:44:08 +000014802004-05-01 Paul Jakma <paul@dishone.st>
1481
1482 * Revert the attempted clean-up of the dummy peer hack, reverts
1483 patchsets 435 (see 2004-02-17 below) and 456.
1484
paul545acaf2004-04-20 15:13:15 +000014852004-04-16 rivo nurges <rix@estpak.ee>
1486
hasso9b87e412004-04-20 16:54:49 +00001487 * bgpd.h, bgp_debug.c: update cease subcodes to
1488 draft-ietf-idr-cease-subcode-05
paul545acaf2004-04-20 15:13:15 +00001489 * bgpd.h, bgpd.c, bgp_route.c, bgp_route.h: fix UNH IOL BGP-4.1.6a
1490
paul6ad23f02004-02-17 19:45:10 +000014912004-02-17 Paul Jakma <paul@dishone.st>
1492
1493 * bgpd.h: (bgp_peer) add fd_local and fd_accept
1494 file descriptor's, fd becomes a pointer to one of these.
1495 * bgpd.c: (global) adjust for fact that fd is now a pointer.
1496 (peer_create_accept) removed.
1497 * bgp_route.c: (global) adjust for change of peer fd to pointer
1498 * bgp_packet.c: (bgp_collision_detect) adjust and remove the
1499 "replace with other peer" hack.
1500 * bgp_network.c: (bgp_accept) Remove the dummy peer hack.
1501 Update peer->fd_accept instead.
1502 (global) Adjust fd references - now a pointer.
1503 * bgp_fsm.c: (global) adjust peer fd to pointer.
1504 (bgp_connection_stop) new function, to stop connection.
1505 (global) adjust everything which closed peer fd to use
1506 bgp_connection_stop().
1507
gdt10d60ad2003-12-23 17:34:39 +000015082003-12-23 Krzysztof Oledzki <oleq@ans.pl>
1509
1510 * bgp_network.c: drop privs on error cases
1511
paul6ad23f02004-02-17 19:45:10 +000015122003-08-11 kunihiro <kunihiro@zebra.org>
paulac41b2a2003-08-12 05:32:27 +00001513
1514 * bgp_route{,map}.c: Extend 'set ip next-hop' in route-maps with
1515 ability to specify 'peer-address' rather than IP.
1516
paul9238b1e2003-06-11 08:03:08 +000015172003-06-09 Paul Jakma <paul@dishone.st>
1518
1519 * bgp_clist.c (community_list_delete): honour deny statements
1520
paul445f1432003-05-16 19:00:31 +000015212003-04-19 Hasso Tepper <hasso@estpak.ee>
1522
1523 * rip_routemap.c: sync daemon's route-map commands to have same
1524 syntax
1525
15262003-01-09 Akihiro Mizutani <mizutani@net-chef.net>
1527
1528 * bgp_routemap.c: Add match extcommunity command.
1529
paul718e3742002-12-13 20:15:29 +000015302002-10-23 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1531
1532 * bgp_aspath.c (aspath_init): Extend hash size from default to
1533 32767.
1534 (aspath_key_make): Use unsigned shoft for making hash. Suggested
1535 by: Marc Evans <Marc@SoftwareHackery.Com>
1536
15372002-08-19 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1538
1539 * bgp_clist.c (community_entry_free): Fix memory leak of standard
1540 extcommunity-list config string.
1541
15422002-08-19 Akihiro Mizutani <mizutani@net-chef.net>
1543
1544 * bgp_route.c (route_vty_out_detail): Fix bug of router-id display
1545 when multiple instance is used.
1546
15472002-08-18 Akihiro Mizutani <mizutani@net-chef.net>
1548
1549 * bgpd.c: Make "default-originate" and "maximum-prefix" commands
1550 available in peer-group configuration.
1551
15522002-08-13 Akihiro Mizutani <mizutani@net-chef.net>
1553
1554 * bgp_packet.c (bgp_open_send): Put Opt Parm Len 0 when last
1555 capability packet cause error or dont-capability-negotiate option
1556 is specified.
1557
15582002-07-07 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1559
1560 * zebra-0.93 released.
1561
15622001-10-28 Kunihiro Ishiguro <kunihiro@zebra.org>
1563
1564 * bgpd.c (bgp_vty_init): Translate update commands are removed.
1565
15662001-10-10 Kunihiro Ishiguro <kunihiro@zebra.org>
1567
1568 * bgp_route.c (bgp_static_set): Add workaround for BGP static
1569 route announcement when there is no zebra running.
1570
15712001-10-08 Kunihiro Ishiguro <kunihiro@zebra.org>
1572
1573 * bgpd.c (neighbor_remote_as_unicast): Remove "remote-as nlri
1574 unicast multicast" commands.
1575
15762001-09-14 Akihiro Mizutani <mizutani@dml.com>
1577
1578 * bgp_open.c: When we receive capability route-refresh, we should
1579 check we send the capability not we receive the capability.
1580
1581 * bgp_route.c (bgp_network_mask_natural_route_map): network
1582 statement route-map is added.
1583
15842001-08-31 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1585
1586 * bgp_advertise.c (bgp_advertise_intern): attr must be interned
1587 before looking up hash table.
1588
15892001-08-30 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1590
1591 * bgpd.h (struct peer): BGP filter is moved from peer_conf to
1592 peer.
1593
15942001-08-28 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1595
1596 * bgp_nexthop.c (bnc_nexthop_free): Fix next pointer bug.
1597 Suggested by: "Hong-Sung Kim" <hoskim@lanbird.co.kr>.
1598
15992001-08-26 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1600
1601 * bgp_table.c (bgp_node_create): Clearn memory before use it.
1602
16032001-08-24 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1604
1605 * Change to use bgp_table.[ch].
1606
16072001-08-23 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1608
1609 * bgpd.c (bgp_init): Add "transparent-as" and
1610 "transparent-nexthop" for old version compatibility.
1611
16122001-08-23 Akihiro Mizutani <mizutani@dml.com>
1613
1614 * bgpd.h (struct peer): default-originate route-map is added.
1615
1616 * bgp_route.c: When self originated route is advertised with
1617 attrubute-unchanged, nexthop was not properly set. This bug is
1618 fixed.
1619
16202001-08-22 Akihiro Mizutani <mizutani@dml.com>
1621
1622 * bgpd.c (neighbor_attr_unchanged): transparent-as and
1623 transparent-next-hop commands are restructured. Instead of
1624 current transparent-* commands, attribute-unchanged command is
1625 introduced.
1626
1627 neighbor A.B.C.D attribute-unchanged [as-path|next-hop|med]
1628
1629 (neighbor_default_originate): "default-originate" configuration
1630 announce default route even 0.0.0.0/0 does not exists in BGP RIB.
1631
16322001-08-19 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1633
1634 * zebra-0.92a released.
1635
16362001-08-19 Akihiro Mizutani <mizutani@dml.com>
1637
1638 * bgpd.c: AF specific soft-reconfiguration inbound commands are
1639 added.
1640
16412001-08-17 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1642
1643 * bgp_route.c (bgp_show_callback): Do not do community NULL check.
1644
1645 * bgp_community.c (community_cmp): Add check for commnunity NULL
1646 check.
1647
1648 * bgp_routemap.c (route_match_community): Do not check comunity is
1649 NULL. It may match to community-list "^$".
1650
1651 * bgp_community.c (community_match): Add check for community is
1652 NULL case.
1653
16542001-08-17 Akihiro Mizutani <mizutani@dml.com>
1655
1656 * bgpd.c: AF specific route-reflector-client and
1657 route-server-client configuration are added.
1658
16592001-08-17 Rick Payne <rickp@ayrnetworks.com>
1660
1661 * bgp_clist.c (community_match_regexp): Check special ^$ case.
1662
16632001-08-17 Akihiro Mizutani <mizutani@dml.com>
1664
1665 * bgp_clist.c (community_list_match): Fix bug of community list
1666 permit and deny check.
1667
16682001-08-16 Akihiro Mizutani <mizutani@dml.com>
1669
1670 * bgp_mplsvpn.c (bgp_mplsvpn_init): Add AF specific "nexthop-self"
1671 command.
1672
16732001-08-15 Akihiro Mizutani <mizutani@dml.com>
1674
1675 * bgpd.h (PEER_FLAG_SEND_COMMUNITY): Per AF based configuration
1676 flag is introduced.
1677
1678 * bgp_mplsvpn.c (bgp_mplsvpn_init): VPNv4 filtering is added.
1679
16802001-08-15 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1681
1682 * zebra-0.92 released.
1683
16842001-08-13 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1685
1686 * bgpd.c (bgp_delete): "no router bgp" free static, aggregate, rib
1687 table properly.
1688
16892001-08-12 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1690
1691 * bgp_route.c (bgp_node_safi): Return SAFI of current node.
1692 (bgp_config_write_network_vpnv4): VPNv4 static configuration
1693 display.
1694
16952001-08-11 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1696
1697 * bgpd.c (no_bgp_ipv4_multicast_route_map): Add IPv4 multicast
1698 node filter commands.
1699
17002001-08-11 Kunihiro Ishiguro <kunihiro@zebra.org>
1701
1702 * bgpd.h (PEER_FLAG_IGNORE_LINK_LOCAL_NEXTHOP): Add
1703 "ignore-link-local-nexthop" flag for ignore link-local nexthop for
1704 IPv6.
1705
17062001-08-07 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1707
1708 * bgpd.c (address_family_ipv4_multicast): "address-family ipv4
1709 multicast" is added.
1710 (address_family_ipv6_unicast): "address-family ipv6 unicast" is
1711 added.
1712
17132001-08-07 Akihiro Mizutani <mizutani@dml.com>
1714
1715 * bgp_route.c (bgp_process): Use flag instead of as_selected
1716 memeber in struct bgp_info.
1717
1718 * bgp_route.h (struct bgp_info): Remove as_selected memeber from
1719 struct bgp_info.
1720
17212001-07-31 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1722
1723 * bgp_route.c (bgp_announce_check): Enclose sending time AS loop
1724 check code with #ifdef BGP_SEND_ASPATH_CHECK.
1725
17262001-07-29 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1727
1728 * bgp_packet.c (bgp_withdraw_send): Simplify address family check.
1729
1730 * bgpd.h (BGP_INFO_HOLDDOWN): Introduce new macro to check BGP
1731 information is alive or not.
1732
1733 * bgp_community.c: Use community_val_get() on all OS.
1734
17352001-07-24 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1736
1737 * bgp_route.c (bgp_announce_check): Simplify set next-hop self
1738 check.
1739
17402001-07-24 Akihiro Mizutani <mizutani@dml.com>
1741
1742 * bgp_route.c (bgp_announce_check): To route server clients, we
1743 announce AS path, MED and nexthop transparently.
1744
17452001-06-21 Kunihiro Ishiguro <kunihiro@zebra.org>
1746
1747 * bgp_routemap.c (route_set_atomic_aggregate_free): Do not call
1748 XFREE. No memory is allocated in
1749 route_set_atomic_aggregate_compile().
1750
17512001-06-21 Kunihiro Ishiguro <kunihiro@zebra.org>
1752
1753 * bgp_routemap.c (bgp_route_map_init): `match nlri` and `set nlri`
1754 are replaced by `address-family ipv4` and `address-family vpnvr'.
1755
17562001-06-19 Kunihiro Ishiguro <kunihiro@zebra.org>
1757
1758 * bgp_route.c (bgp_withdraw): Add check for BGP_PEER_CONFED.
1759 Reported by Rick Payne <rickp@rossfell.co.uk>.
1760
17612001-06-17 Kunihiro Ishiguro <kunihiro@zebra.org>
1762
1763 * bgp_zebra.c (bgp_zebra_announce): When global IPv6 nexthop is
1764 empty, use socket's remote address for the nexthop.
1765
17662001-06-04 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1767
1768 * bgpd.c (peer_delete): Fix memory leak. Reported by Yosi Yarchi
1769 <Yosi_Yarchi@KereniX.com>
1770
17712001-06-01 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1772
1773 * bgpd.c (bgp_delete): Fix memory leak. Reported by Yosi Yarchi
1774 <Yosi_Yarchi@KereniX.com>
1775
17762001-05-27 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1777
1778 * bgp_route.c (bgp_route_clear_with_afi_vpnv4): Use next instead
1779 of ri->next.
1780
1781 * bgp_packet.c (bgp_withdraw_send): MPLS/VPN withdraw takes effect
1782 when HAVE_IPV6 is not defined.
1783
17842001-03-07 "Akihiro Mizutani" <mizutani@dml.com>
1785
1786 * bgpd.c (peer_timers_set): Adjust keepalive timer to fit less
1787 than holdtime / 3.
1788 (bgp_confederation_peers_unset): Only set peer->local_as when
1789 confederation is enabled.
1790 (bgp_timers): Add "timers bgp <0-65535> <0-65535>" command.
1791
1792 * bgp_route.c (bgp_announce_check): Set med of redistributed route
1793 when it is announced to EBGP peer.
1794
17952001-03-06 "Akihiro Mizutani" <mizutani@dml.com>
1796
1797 * bgp_nexthop.c (bgp_scan_ipv4): bgp_scan() call bgp_process() for
1798 all prefixes.
1799
18002001-03-06 Kunihiro Ishiguro <kunihiro@zebra.org>
1801
1802 * bgp_attr.c (bgp_attr_origin): When bgpd send NOTIFICATION with
1803 erroneous attribute (type, length and value), it does include
1804 attribute flags field.
1805
18062001-02-21 "Akihiro Mizutani" <mizutani@dml.com>
1807
1808 * bgp_route.c (bgp_announce_check): The route reflector is not
1809 allowed to modify the attributes of the reflected IBGP routes.
1810
18112001-02-20 "Akihiro Mizutani" <mizutani@dml.com>
1812
1813 * bgp_route.c (bgp_info_cmp): During path seleciton, BGP
1814 confederation peer is treated as same as IBGP peer.
1815
18162001-02-19 Kunihiro Ishiguro <kunihiro@zebra.org>
1817
1818 * bgp_route.c (bgp_redistribute_add): Initialize attr_new with
1819 attr. Call aspath_unintern when return from this function.
1820
18212001-02-19 "Akihiro Mizutani" <mizutani@dml.com>
1822
1823 * bgpd.c (bgp_router_id_set): Reset BGP peer when router-id is
1824 changed.
1825
18262001-02-18 "Akihiro Mizutani" <mizutani@dml.com>
1827
1828 * bgp_packet.c (bgp_open_receive): When user configure holdtimer,
1829 do not refrect the value to current session.
1830
18312001-02-16 Kunihiro Ishiguro <kunihiro@zebra.org>
1832
1833 * bgp_route.c (bgp_aggregate_delete): Set BGP_INFO_ATTR_CHANGE to
1834 suppress route withdraw.
1835
1836 * bgp_damp.c (bgp_damp_init): Fix bug of flap dampening.
1837
18382001-02-16 "Akihiro Mizutani" <mizutani@dml.com>
1839
1840 * bgp_aspath.c (aspath_make_str_count): Use ',' for separator for
1841 AS_SET and AS_CONFED_SET.
1842
18432001-02-15 Kunihiro Ishiguro <kunihiro@zebra.org>
1844
1845 * bgp_route.c (bgp_process): Do not consider suppress route.
1846
1847 * bgp_aspath.c (aspath_aggregate_as_set_add): Reset asset when
1848 aspath->data is realloced.
1849
18502001-02-15 "Akihiro Mizutani" <mizutani@dml.com>
1851
1852 * bgp_attr.c (bgp_attr_aggregate_intern): Do not set atomic
1853 aggregate when using as-set.
1854
18552001-02-14 "Akihiro Mizutani" <mizutani@dml.com>
1856
1857 * bgpd.c (bgp_confederation_peers_unset): Set peer's local-as
1858 correctly.
1859
1860 * bgp_route.c (bgp_update): Just ignore AS path loop for
1861 confederation peer.
1862
18632001-02-10 Kunihiro Ishiguro <kunihiro@zebra.org>
1864
1865 * bgp_route.c (bgp_aggregate_set): Add as_set argument.
1866 (bgp_aggregate_unset): Remove summary_only argument.
1867 (aggregate_address_as_set): New commands.
1868 "aggregate-address A.B.C.D/M as-set"
1869 "no aggregate-address A.B.C.D/M as-set"
1870
18712001-02-08 "Akihiro Mizutani" <mizutani@dml.com>
1872
1873 * bgp_route.c (bgp_announce_check): Do not modify nexthop when the
1874 route is passed by route reflector.
1875
18762001-02-08 Kunihiro Ishiguro <kunihiro@zebra.org>
1877
1878 * bgp_route.c: "no bgp dampening" with argument.
1879 (bgp_announce_check): Do not modify nexthop when the route is
1880 passed by route reflector.
1881
18822001-02-07 "Akihiro Mizutani" <mizutani@dml.com>
1883
1884 * bgpd.c (neighbor_passive): Change "neighbor NEIGHBOR remote-as
1885 ASN passive" to "neighbor NEIGHBOR passive".
1886 (bgp_announce_check): Check well-known community attribute even
1887 when "no neighbor send-community" is set.
1888
18892001-02-03 Kunihiro Ishiguro <kunihiro@zebra.org>
1890
1891 * bgp_fsm.c (bgp_establish): Do not send keepalive at established
1892 time when keepalive timer is configured as zero.
1893
18942001-02-01 Kunihiro Ishiguro <kunihiro@zebra.org>
1895
1896 * bgp_attr.c (bgp_attr_check): When peer is IBGP peer, local
1897 preference is well-known attribute.
1898
18992001-01-30 Kunihiro Ishiguro <kunihiro@zebra.org>
1900
1901 * zebra-0.91 is released.
1902
1903 * bgp_attr.h (struct attr): Comment out DPA value.
1904 (struct attr): Change refcnt type from int to unsinged long.
1905
1906 * bgp_attr.c (attrhash_key_make): Likewise.
1907 (attrhash_cmp): Likewise.
1908 (bgp_attr_dpa): Likewise.
1909
19102001-01-30 "Akihiro Mizutani" <mizutani@dml.com>
1911
1912 * bgp_route.c (bgp_info_cmp): Make route selection completely same
1913 as Cisco's.
1914
19152001-01-30 Kunihiro Ishiguro <kunihiro@zebra.org>
1916
1917 * bgp_attr.h (BGP_ATTR_FLAG_OPTIONAL): Rename old ATTR_FLAG_* to
1918 BGP_ATTR_FLAG_* to clarify meenings.
1919
19202001-01-30 "Akihiro Mizutani" <mizutani@dml.com>
1921
1922 * bgp_route.c (route_vty_out): Display argument to suppress same
1923 prefix information display.
1924 (route_vty_out_route): Don't display mask information for
1925 classfull network.
1926
19272001-01-30 Kunihiro Ishiguro <kunihiro@zebra.org>
1928
1929 * bgp_attr.h (SET_BITMAP): Simple bitmapping macros.
1930
1931 * bgp_attr.c (bgp_attr_parse): Use bitmap for attribute type
1932 check.
1933
19342001-01-29 Kunihiro Ishiguro <kunihiro@zebra.org>
1935
1936 * bgp_attr.c (bgp_mp_reach_parse): Enclose loggin with BGP_DEBUG.
1937 (bgp_attr_parse): Comment out well-known attribute check.
1938
19392001-01-28 Kunihiro Ishiguro <kunihiro@zebra.org>
1940
1941 * bgp_route.c (bgp_static_unset): Link-local IPv6 address can't be
1942 used for network advertisement.
1943 (nlri_parse): When link-local IPv6 address NLRI comes from
1944 remote-peer, log the information then simply ignore it.
1945
1946 * bgp_zebra.c (zebra_read_ipv6): Link-local IPv6 address is not
1947 redistributed.
1948
1949 * bgp_route.c (bgp_update): Check IPv6 global nexthop
1950 reachability.
1951
19522001-01-26 Kunihiro Ishiguro <kunihiro@zebra.org>
1953
1954 * bgp_route.c (bgp_update): Check nexthop points local address or
1955 not.
1956 (bgp_static_update_vpnv4): Set valid flag.
1957
1958 * bgp_attr.c (bgp_attr_parse): Duplicate attribute check.
1959 (bgp_attr_parse): Well-known attribute check.
1960
1961 * bgp_open.c (bgp_auth_parse): Authentication is not yet supported.
1962
1963 * bgp_packet.c (bgp_valid_marker): Check marker is synchronized.
1964
1965 * bgpd.c (clear_bgp): Send NOTIFICATION Cease when SEND_CEASE is
1966 defined.
1967
1968 * bgp_snmp.c (bgp4PathAttrTable): Fix compile error.
1969
19702001-01-24 Kunihiro Ishiguro <kunihiro@zebra.org>
1971
1972 * bgpd.c (bgp_network_import_check): New command for IGP network
1973 check.
1974
19752001-01-23 Kunihiro Ishiguro <kunihiro@zebra.org>
1976
1977 * bgp_nexthop.c (bgp_scan): Run bgp_process when IGP metric is
1978 changed. Call bgp_process once for each node.
1979
19802001-01-23 "Akihiro Mizutani" <mizutani@dml.com>
1981
1982 * bgp_route.c (bgp_info_cmp): Add IGP metric comparison.
1983
19842001-01-23 Kunihiro Ishiguro <kunihiro@zebra.org>
1985
1986 * bgp_route.c (bgp_info_cmp): Add IGP metric comparison.
1987
1988 * bgp_nexthop.c (bgp_nexthop_lookup): Set IGP metric for valid
1989 IBGP route.
1990
19912001-01-23 "Akihiro Mizutani" <mizutani@dml.com>
1992
1993 * bgp_route.c (show_ip_bgp_prefix_longer): Add new commands.
1994 "show ip bgp A.B.C.D/M longer-prefixes"
1995 "show ip bgp ipv4 (unicast|multicast) A.B.C.D/M longer-prefixes"
1996 "show ipv6 bgp X:X::X:X/M longer-prefixes"
1997 "show ipv6 mbgp X:X::X:X/M longer-prefixes"
1998
19992001-01-20 "Akihiro Mizutani" <mizutani@dml.com>
2000
2001 * bgp_route.c (show_ip_bgp_cidr_only): Add new commands.
2002 "show ip bgp cidr-only"
2003 "show ip bgp ipv4 (unicast|multicast) cidr-only"
2004
20052001-01-18 "Akihiro Mizutani" <mizutani@dml.com>
2006
2007 * bgp_route.c (bgp_update): AS path lookup check is done in
2008 bgp_update() not in attr_parse().
2009
20102001-01-18 Kunihiro Ishiguro <kunihiro@zebra.org>
2011
2012 * bgp_route.c (bgp_update): Call bgp_aggregate_decrement() just
2013 before bgp_attr_unintern().
2014
20152001-01-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2016
2017 * bgp_route.c (bgp_update): Now intern is performed very last part
2018 of the BGP packet update procedure.
2019
20202001-01-17 "Akihiro Mizutani" <mizutani@dml.com>
2021
2022 * bgp_route.c (bgp_update): When implicit withdraw occur, reuse
2023 existing bgp_info structure.
2024
20252001-01-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2026
2027 * bgp_route.c (bgp_aggregate_decrement): Fix bug of aggregate
2028 address matching method.
2029 (bgp_update):
2030
2031 * bgp_nexthop.c (bgp_nexthop_onlink): Separate EBGP nexthop onlink
2032 check and IBGP nexthop route check.
2033
20342001-01-16 "Akihiro Mizutani" <mizutani@dml.com>
2035
2036 * bgp_route.h (BGP_INFO_ATRR_CHANGED): Added for track attribute
2037 change.
2038
20392001-01-16 Kunihiro Ishiguro <kunihiro@zebra.org>
2040
2041 * bgp_route.h (struct bgp_info): Remove selected flag. Use
2042 BGP_INFO_SELECTED for flags instead.
2043 (struct bgp_info): Remove valid flag. Use BGP_INFO_VALID for
2044 flags instead.
2045 (struct bgp_info): Add igpmetric for IBGP route nexthop IGP
2046 metric.
2047 (struct bgp_info_tab): Struct bgp_info_tag is integrated into
2048 struct bgp_info.
2049 (BGP_INFO_ATRR_CHANGED): Added for track attribute change.
2050
2051 * bgp_community.c (community_val_get): gcc-2.95 on
2052 sparc-sun-solaris cause crush. This function is for avoid the
2053 crush.
2054
20552001-01-15 Kunihiro Ishiguro <kunihiro@zebra.org>
2056
2057 * bgp_packet.c (bgp_open_receive): Translated peer's packet_size
2058 clear bug is fixed.
2059
20602001-01-14 "Akihiro Mizutani" <mizutani@dml.com>
2061
2062 * bgp_packet.c (bgp_open_receive): Return notification with
2063 supported version number.
2064
20652001-01-13 Kunihiro Ishiguro <kunihiro@zebra.org>
2066
2067 * bgpd.c (bgp_show_summary): Display AS path and community
2068 entries. Suggested by: "Matt Ranney" <mjr@ranney.com>.
2069
2070 * bgp_packet.c (bgp_read_packet): Fix bug of unblocking BGP socket
2071 read. When BGP packet read is partial, we must get size and type
2072 from packet again.
2073
20742001-01-12 "Akihiro Mizutani" <mizutani@dml.com>
2075
2076 * bgp_route.c (bgp_update): Do not unset BGP_INFO_HISTORY flag.
2077 (bgp_update): When there is a history entry increment route count.
2078 (bgp_damp_set): Check BGP_CONFIG_DAMPENING flag.
2079
2080 * bgp_damp.c (bgp_damp_withdraw): Set status to
2081 BGP_DAMP_DISCONTINUE.
2082
20832001-01-11 Kunihiro Ishiguro <kunihiro@zebra.org>
2084
2085 * bgp_attr.c (bgp_mp_reach_parse): Fix warning code when second
2086 IPv6 nexthop is not link-local addresss.
2087
20882001-01-11 "Akihiro Mizutani" <mizutani@dml.com>
2089
2090 * bgp_damp.c (bgp_config_write_damp): Smart flap dampening
2091 configuration display.
2092 (bgp_damp_info_print): Display elapsed time from flap started.
2093
2094 * bgp_damp.h (struct bgp_damp_info): Add flap start time.
2095
2096 * bgpd.c (peer_create): Set last read time.
2097 (bgp_show_peer): Display last read time.
2098 (bgp_show_summary): Use BGP_CONFIG_DAMPENING flag to check
2099 configuration.
2100
2101 * bgpd.h (BGP_CONFIG_DAMPENING): Add new configuration option.
2102 (struct peer): Add last read time member.
2103 (BGP_VERSION_MP_4): Remove obsolete definition.
2104
21052001-01-10 Kunihiro Ishiguro <kunihiro@zebra.org>
2106
2107 * bgp_nexthop.c: Remove OLD_RIB codes.
2108
2109 * bgp_route.c (bgp_process): Likewise.
2110
2111 * zebra-0.90 is released.
2112
2113 * bgp_route.h (BGP_INFO_HISTORY): Remove damped member from struct
2114 bgp_info. Instead of that use BGP_INFO_DAMPED flag.
2115 (struct bgp_info): Remove invalid member from struct bgp_info.
2116 Instead of that use BGP_INFO_HISTORY flag.
2117
21182001-01-10 "Akihiro Mizutani" <mizutani@dml.com>
2119
2120 * bgp_damp.c (bgp_damp_info_print): New function to display
2121 dampening status.
2122 (DEFAULT_HARF_LIFE): Define default value.
2123 (DEFAULT_REUSE): Likewise.
2124 (DEFAULT_SUPPRESS): Likewise.
2125 (bgp_config_write_damp): When config value is same as default
2126 value, simply display "bgp dampening" to configuration.
2127
2128 * bgp_damp.h (struct bgp_damp_info): Add flap member.
2129
2130 * bgp_route.h (struct bgp_info): Added for BGP flap dampening
2131 history status.
2132
21332001-01-10 Kunihiro Ishiguro <kunihiro@zebra.org>
2134
2135 * bgp_nexthop.c (bgp_connected_add): Point-to-point connected
2136 address is properly handled.
2137 (bgp_connected_delete): Likewise.
2138
2139 * bgp_route.c (bgp_route_init): Turn off BGP Flap dampening code
2140 until it works fine.
2141
21422001-01-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2143
2144 * bgpd.c (bgp_show_summary): Add BGP_VERSION_MP_4 case.
2145
2146 * bgp_route.c (bgp_update): When this is not damped route, clear
2147 ri pointer.
2148
21492001-01-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2150
2151 * bgp_main.c: Add "-n" no_kernel option to not install route to
2152 kernel. Suggested by: "Matt Ranney" <mjr@ranney.com>
2153
21542001-01-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2155
2156 * bgp_nexthop.c (bgp_connected_add): Revert point-to-point
2157 connected route patch. Reported by ruud@ruud.org (Ruud de Rooij)
2158
2159 * bgp_damp.c (bgp_config_write_damp): Add configuration display
2160 function.
2161
2162 * bgp_route.c (bgp_info_free): Set NULL to BGP dampening
2163 information when BGP info structure is freed.
2164 (bgp_info_cmp): Check damped flag.
2165 (bgp_announce_check): Damped route is not announced.
2166
21672001-01-09 "Akihiro Mizutani" <mizutani@dml.com>
2168
2169 * bgpd.c (neighbor_capability_route_refresh): Change "neighbor
2170 route-refresh" command to "neighbor capability route-refresh".
2171 (clear_bgp_soft_in): Change soft-reconfig method.
2172
2173 clear ip bgp <neighbor> soft in
2174 --------------------------------------
2175 Try stored cache first then route-refresh
2176
2177 clear ip bgp <neighbor> in
2178 ---------------------------------
2179 Try route-refresh first then try to use stored cache
2180
21812001-01-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2182
2183 * bgp_nexthop.c (bgp_connected_add): Check point-to-point
2184 connected route. Reported by ruud@ruud.org (Ruud de Rooij)
2185
21862001-01-08 Kunihiro Ishiguro <kunihiro@zebra.org>
2187
2188 * bgp_nexthop.c (bgp_nexthop_lookup): When IBGP nexthop is
2189 changed, refresh it.
2190
21912001-01-04 Kunihiro Ishiguro <kunihiro@zebra.org>
2192
2193 * bgp_route.h (struct bgp_info_tag): Add as_selected to
2194 bgp_info_tag.
2195
21962001-01-03 Kunihiro Ishiguro <kunihiro@zebra.org>
2197
2198 * bgp_route.h (struct bgp_info_tag): Add damped and bgp_damp_info
2199 member for BGP flap dampening.
2200
2201 * bgp_damp.c: New file is added.
2202
2203 * bgp_damp.h: Likewise.
2204
22052001-01-01 Kunihiro Ishiguro <kunihiro@zebra.org>
2206
2207 * bgpd.h (BGP_VTYSH_PATH): Change "/tmp/bgpd" to "/tmp/.bgpd".
2208
22092000-12-29 Kunihiro Ishiguro <kunihiro@zebra.org>
2210
2211 * bgp_nexthop.c (zlookup_connect): Change to use UNIX domain
2212 socket for zebra communication.
2213
22142000-12-29 Akihiro Mizutani <mizutani@dml.com>
2215
2216 * bgp_route.c (bgp_process): Fix "bgp deterministic-med" process.
2217
22182000-12-27 Akihiro Mizutani <mizutani@dml.com>
2219
2220 * bgp_route.c (bgp_process): Add "bgp deterministic-med" process.
2221
22222000-12-25 Akihiro Mizutani <mizutani@dml.com>
2223
2224 * bgp_route.c (bgp_info_cmp): Use ntohl comparing router ID.
2225
22262000-12-18 Akihiro Mizutani <mizutani@dml.com>
2227
2228 * bgp_route.c (bgp_info_cmp): When over three same prefix exit,
2229 withdrawing best prefix perform router ID comparison.
2230
22312000-12-15 Akihiro Mizutani <mizutani@dml.com>
2232
2233 * bgp_route.c (bgp_info_cmp): Do not compare router ID when the
2234 routes comes from EBGP peer. When originator ID is same, take
2235 shorter cluster-list route. If cluster-list is same take smaller
2236 IP address neighbor's route.
2237
2238 * bgpd.c (bgp_bestpath_aspath_ignore): Add "bgp bestpath as-path
2239 ignore" command. When this option is set, do not concider AS path
2240 length when route selection.
2241 (bgp_bestpath_compare_router_id): Add "bgp bestpath
2242 compare-routerid". When this option is set, compare router ID
2243 when the routes comes from EBGP peer.
2244
22452000-12-15 Akihiro Mizutani <mizutani@dml.com>
2246
2247 * bgp_route.c (bgp_info_cmp): Compare originator ID when it is
2248 available.
2249
22502000-12-14 Akihiro Mizutani <mizutani@dml.com>
2251
2252 * bgp_packet.c (bgp_notify_receive): Disply received Notify data
2253 information.
2254
22552000-12-14 Kunihiro Ishiguro <kunihiro@zebra.org>
2256
2257 * bgp_filter.c (as_filter_free): Use MTYPE_AS_FILTER_STR to make
2258 it sure the memory is freed.
2259
2260 * bgp_route.c (route_vty_out_detail): Do not use AF_INET6 outside
2261 HAVE_IPV6.
2262
22632000-12-08 Akihiro Mizutani <mizutani@dml.com>
2264
2265 * bgp_packet.c (bgp_notify_send_with_data): Store BGP notification
2266 data part.
2267
2268 * bgp_network.c (bgp_accept): When BGP connection comes from
2269 unconfigured IP address, close socket immediately.
2270
2271 * bgpd.c: Fix some display format.
2272
22732000-11-29 Kunihiro Ishiguro <kunihiro@zebra.org>
2274
2275 * bgp_packet.c (bgp_keepalive_send): Delete duplicate
2276 bgp_packet_set_size () call.
2277
22782000-11-28 Kunihiro Ishiguro <kunihiro@zebra.org>
2279
2280 * bgp_packet.c (bgp_read_packet): Remove debug codes.
2281
22822000-11-27 Kunihiro Ishiguro <kunihiro@zebra.org>
2283
2284 * bgp_snmp.c (write_bgpPeerTable): Add SNMP set method routine.
2285
2286 * bgp_fsm.c (bgp_stop): Use fsm_change_status to change peer's
2287 status.
2288 (bgp_establish): Likewise.
2289
22902000-11-26 Akihiro Mizutani <mizutani@dml.com>
2291
2292 * bgp_open.c: Fix error messages.
2293
22942000-11-25 Kunihiro Ishiguro <kunihiro@zebra.org>
2295
2296 * bgp_fsm.c (bgp_establish): Call BGP trap when the peer is
2297 established.
2298 (bgp_stop): Call BGP trap when the peer is dropped.
2299
23002000-11-24 Kunihiro Ishiguro <kunihiro@zebra.org>
2301
2302 * bgp_snmp.c (bgp4PathAttrTable): Return BGP path attribute table.
2303
2304 * bgpd.h (struct peer): Add update_time for track last update
2305 received time.
2306
2307 * bgp_packet.c (bgp_notify_receive): Preserv notify code and sub
2308 code in any case.
2309
2310 * bgp_snmp.c (bgpPeerTable): Return remote router ID instead of
2311 peering IP address.
2312 (bgpPeerTable): Return actual BGP version number.
2313
23142000-11-22 Akihiro Mizutani <mizutani@dml.com>
2315
2316 * bgp_debug.c (bgp_notify_print): Notify data length display bug
2317 is fixed.
2318
23192000-11-16 Kunihiro Ishiguro <kunihiro@zebra.org>
2320
2321 * bgp_nexthop.c (zlookup_connect): When UNIX domain connection to
2322 zebra is enabled, use the method.
2323
23242000-11-16 Akihiro Mizutani <mizutani@dml.com>
2325
2326 * bgpd.c: Revise debug message output.
2327
23282000-11-15 Akihiro Mizutani <mizutani@dml.com>
2329
2330 * bgp_clist.c (ip_community_list): Fix bug of string comparison.
2331
23322000-11-14 Akihiro Mizutani <mizutani@dml.com>
2333
2334 * bgp_community.c (community_match): Fix bug of memcmp return
2335 value check.
2336
23372000-11-07 Kunihiro Ishiguro <kunihiro@zebra.org>
2338
2339 * bgp_clist.c (community_list_match_exact): Add check for
2340 entry->style is COMMUNITY_LIST.
2341 (community_match_regexp): Apply new com_nthval macro.
2342
23432000-11-07 Rick Payne <rickp@rossfell.co.uk>
2344
2345 * bgp_routemap.c (route_set_community_delete): "set
2346 community-delete COMMUNITY-LIST" is added.
2347
2348 * bgp_community.c (community_del_val): Delete one community.
2349 (community_delete): Delete all community included in list.
2350 (community_match): Fix bug of matching community value.
2351
2352 * bgp_clist.c (community_entry_free): Free community regular
2353 expression.
2354 (community_entry_make): Default style is COMMUNITY_LIST.
2355 (community_entry_lookup): Make it sure style is COMMUNITY_LIST.
2356 (community_entry_regexp_lookup): New function for community
2357 regular expression lookup.
2358 (community_match_regexp): New function.
2359 (community_delete_regexp): New function.
2360 (community_list_delete_entries): New function.
2361 (community_list_match): Add COMMUNITY_REGEXP treatment.
2362 (community_list_match_exact): Likewise.
2363 (config_write_community): Write community list according to
2364 entry->style.
2365
23662000-11-07 Rick Payne <rickp@rossfell.co.uk>
2367
2368 * bgp_attr.c (bgp_attr_aspath): AS path first AS check.
2369
2370 * bgp_clist.c (struct community_entry): Add style, regexp, reg to
2371 community_entry.
2372
23732000-11-06 Rick Payne <rickp@rossfell.co.uk>
2374
2375 * bgp_aspath.c (aspath_firstas_check): AS path first AS check.
2376
2377 * bgpd.c (bgp_enforce_first_as): New command "bgp
2378 enforce-first-as".
2379
2380 * bgpd.h (BGP_CONFIG_ENFORCE_FIRST_AS): Add new flag.
2381
23822000-11-06 Kunihiro Ishiguro <kunihiro@zebra.org>
2383
2384 * bgp_community.c (community_compare): Copy byte stream data to
2385 actual value instead of using type casting hack.
2386 (community_add_val): Likewise.
2387 (community_uniq_sort): Likewise.
2388 (community_print): Likewise.
2389 (community_print_vty): Likewise.
2390 (community_include): Use memcmp to compare community value.
2391
2392 * bgp_community.h (com_lastval): com_lastval and com_nthval macro
2393 return pointer.
2394
23952000-11-06 Akihiro Mizutani <mizutani@dml.com>
2396
2397 * bgpd.h (struct peer): Add established and dropped member for
2398 count peering up/down statistics.
2399
2400 * bgpd.c (bgp_show_peer): Display peering up/down statistics.
2401
2402 * bgp_fsm.c (bgp_establish): Increment established count.
2403 (bgp_stop): Increment dropped count.
2404
2405 * bgp_packet.c (bgp_notify_receive): Increament notify count.
2406
24072000-11-1 Akihiro Mizutani <mizutani@dml.com>
2408
2409 * bgp_fsm.c: Fix bug of holdtimer is not reset when bgp cleared.
2410
24112000-10-31 Kunihiro Ishiguro <kunihiro@zebra.org>
2412
2413 * bgpd.h: Static bit flag is set by (1 << DIGIT).
2414
24152000-10-24 Akihiro Mizutani <mizutani@dml.com>
2416
2417 * bgp_ecommunity.c (ecommunity_dup): Extended community display
2418 format fix.
2419
24202000-10-24 Arkadiusz Miskiewicz <misiek@pld.org.pl>
2421
2422 * bgp_network.c (bgp_serv_sock_addrinfo): Use gai_strerror.
2423 (bgp_serv_sock_addrinfo): Check address family.
2424
24252000-10-23 Jochen Friedrich <jochen@scram.de>
2426
2427 * bgp_snmp.c: bgp_oid and bgpd_oid are used in smux_open after it
2428 is registered. So those variables must be static.
2429
24302000-10-23 Akihiro Mizutani <mizutani@dml.com>
2431
2432 * bgp_routemap.c (route_match_ip_next_hop): Change "match ip
2433 next-hop" argument from IP address to access-list name.
2434 Remove zebra-0.88 compatibility commands.
2435 "match ip prefix-list WORD"
2436 "match ipv6 prefix-list WORD"
2437
24382000-10-23 Kunihiro Ishiguro <kunihiro@zebra.org>
2439
2440 * bgp_routemap.c (route_match_ipv6_next_hop_compile): Fix bug of
2441 passing the pointer to the pointer of struct in6_addr instead of
2442 the pointer of struct in6_addr in "match ipv6 next-hop" command.
2443
2444 * bgp_route.c (bgp_announce_check): Enclose IPv6 part with
2445 HAVE_IPV6.
2446
24472000-10-20 Jasper Wallace <jasper@ivision.co.uk>
2448
2449 * bgp_snmp.c (bgpPeerTable): ntohs missing bug is fixed. Change
2450 to use linklist.c. Define COUNTER32 as ASN_COUNTER.
2451
24522000-10-18 Kunihiro Ishiguro <kunihiro@zebra.org>
2453
2454 * bgp_route.c (bgp_announce_check): attr->nexthop empty check
2455 should be done by attr->nexthop.s_addr instead of strcmp.
2456
24572000-10-18 Akihiro Mizutani <mizutani@dml.com>
2458
2459 * bgp_zebra.c (zebra_read_ipv4): Pass nexthop value to
2460 bgp_redistribute_add().
2461
2462 * bgp_nexthop.c (bgp_multiaccess_check_v4): New function for
2463 checking IPv4 multiaccess nexthop.
2464
2465 * bgp_route.c (bgp_announce_check): In case of the nexthop is
2466 reachable on multiaccess media, do not change nexthop.
2467 (bgp_redistribute_add): Set nexthop when the value is passed.
2468
24692000-10-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2470
2471 * bgp_fsm.c (bgp_timer_set): If peer is passive mode, do not set
2472 connect timer.
2473 (bgp_start): If the peer is passive mode, force to move to Active
2474 mode.
2475
24762000-10-17 Horms <horms@vergenet.net>
2477
2478 * bgp_debug.c (debug_bgp_fsm): Fix typo.
2479
24802000-10-17 Akihiro Mizutani <mizutani@dml.com>
2481
2482 * bgp_route.c: "show ipv6 bgp" route display improvement.
2483
24842000-10-03 Kunihiro Ishiguro <kunihiro@zebra.org>
2485
2486 * bgp_route.c (neighbor_routes): Allocate sockunion for callback
2487 function.
2488 (bgp_show_neighbor_route): Remove static declaration for union
2489 sockunion.
2490
2491 * bgpd.c (peer_update_source_set): Clean previously allocated
2492 memory before allocate new one.
2493
24942000-10-03 Akihiro Mizutani <mizutani@dml.com>
2495
2496 * bgp_route.c (neighbor_routes): Add show neighbor's routes
2497 command.
2498 "show ip bgp neighbors (A.B.C.D|X:X::X:X) routes"
2499 "show ip bgp ipv4 (unicast|multicast) neighbors (A.B.C.D|X:X::X:X) routes"
2500 "show ipv6 bgp neighbors (A.B.C.D|X:X::X:X) routes"
2501 "show ipv6 mbgp neighbors (A.B.C.D|X:X::X:X) routes"
2502
25032000-10-02 Kunihiro Ishiguro <kunihiro@zebra.org>
2504
2505 * zebra-0.89 is released.
2506
25072000-10-02 Akihiro Mizutani <mizutani@dml.com>
2508
2509 * bgpd.c: "bgp deterministic-med" command is added.
2510
25112000-10-02 Kunihiro Ishiguro <kunihiro@zebra.org>
2512
2513 * bgp_nexthop.c (bgp_connected_add): Apply mask for connected
2514 route addition and deletion.
2515
25162000-09-29 Kunihiro Ishiguro <kunihiro@zebra.org>
2517
2518 * bgp_aspath.c (aspath_cmp_left): Skip confederation AS segment
2519 when comparing leftmost AS number.
2520
25212000-09-29 Akihiro Mizutani <mizutani@dml.com>
2522
2523 * bgpd.c (peer_route_reflector): Route reflector can be set for
2524 IBGP peer.
2525 (bgp_distribute_set): Fix bug of string check for (in|out).
2526 (bgp_show_summary): Display total neighbor count.
2527
25282000-09-28 Akihiro Mizutani <mizutani@dml.com>
2529
2530 * bgp_attr.c (bgp_packet_attribute): Only add cluster_list and
2531 originator for clinet to client routes.
2532 (bgp_packet_attribute): Add new cluster_list to the beginning of
2533 existing cluster_list.
2534 (bgp_packet_attribute): Fix bug of originator is rewritten even
2535 when originator is already set.
2536
25372000-09-27 Kunihiro Ishiguro <kunihiro@zebra.org>
2538
2539 * bgpd.c (bgp_client_to_client_reflection): Add new command.
2540 "no bgp client-to-client reflection"
2541 "bgp client-to-client reflection"
2542
2543 * bgpd.h (BGP_CONFIG_NO_CLIENT_TO_CLIENT): Add new definition.
2544
25452000-09-26 Kunihiro Ishiguro <kunihiro@zebra.org>
2546
2547 * bgp_packet.c (bgp_read): Make BGP packet read to non-blocking
2548 read.
2549 (bgp_read_packet): Likewise.
2550 (bgp_read_packet): When errono is EAGAIN, try to read it again.
2551
2552 * bgp_fsm.c (bgp_stop): Clear packet size and read buffer.
2553
25542000-09-26 Akihiro Mizutani <mizutani@dml.com>
2555
2556 * bgp_routemap.c: Configuration of prefix-list match is shown as
2557 "match ip address prefix-list <WORD>". Old configuration "match
2558 ip prefix-list <WORD>" is left for compatibilitty.
2559
25602000-09-25 Akihiro Mizutani <mizutani@dml.com>
2561
2562 * bgpd.h (BGP_CONFIG_MED_MISSING_AS_WORST): Changed from
2563 BGP_CONFIG_MISSING_AS_WORST.
2564
2565 * bgpd.c (bgp_bestpath_med): Change missing-as-worst syntax.
2566 Old "bgp bestpath missing-as-worst"
2567 New "bgp bestpath med missing-as-worst"
2568
25692000-09-24 Akihiro Mizutani <mizutani@dml.com>
2570
2571 * bgp_route.c: Compare MED properly in case of CONFED-IBGP.
2572
25732000-09-21 steve@Watt.COM (Steve Watt)
2574
2575 * bgp_debug.h: Do not declare debug variables conf_bgp_debug_* and
2576 term_bgp_debug_*.
2577
2578 * bgp_debug.c: Declare variables here.
2579
25802000-09-21 Akihiro Mizutani <mizutani@dml.com>
2581
2582 * bgpd.c: MBGP soft-reconfiguration command is added.
2583 clear ip bgp x.x.x.x ipv4 (unicast|multicast) in
2584 clear ip bgp x.x.x.x ipv4 (unicast|multicast) out
2585 clear ip bgp x.x.x.x ipv4 (unicast|multicast) soft
2586 clear ip bgp <1-65535> ipv4 (unicast|multicast) in
2587 clear ip bgp <1-65535> ipv4 (unicast|multicast) out
2588 clear ip bgp <1-65535> ipv4 (unicast|multicast) soft
2589 clear ip bgp * ipv4 (unicast|multicast) in
2590 clear ip bgp * ipv4 (unicast|multicast) out
2591 clear ip bgp * ipv4 (unicast|multicast) soft
2592
2593 Change "clear ip bgp vpnv4 x.x.x.x soft" command to
2594 "clear ip bgp x.x.x.x vpnv4 unicast soft".
2595
2596 "bgp bestpath med confed" command is added.
2597
2598 * bgpd.h (BGP_CONFIG_MED_CONFED): Add New definition.
2599
26002000-09-18 Rick Payne <rickp@rossfell.co.uk>
2601
2602 * bgpd.c (bgp_show_peer): Fix misplaced #endif.
2603
26042000-09-12 Akihiro Mizutani <mizutani@dml.com>
2605
2606 * bgpd.c (bgp_default_local_preference): Add "bgp default
2607 local-preference" command.
2608
2609 * bgp_nexthop.c (no_bgp_scan_time): Add "no bgp scan-time"
2610 command.
2611
26122000-09-10 Kunihiro Ishiguro <kunihiro@zebra.org>
2613
2614 * bgp_zebra.c (bgp_zebra_announce): BGP confederation peer's routes
2615 are passed to zebra like IBGP route.
2616
26172000-09-10 Akihiro Mizutani <mizutani@dml.com>
2618
2619 * bgpd.c (bgp_config_write_peer): Make it consistent passive
2620 configuration.
2621
2622 * bgp_route.c: Community match command is added.
2623 "show ip bgp community <val>"
2624 "show ip bgp community <val> exact-match"
2625
26262000-09-08 Kunihiro Ishiguro <kunihiro@zebra.org>
2627
2628 * bgp_nexthop.c (bgp_nexthop_lookup): ebgp-multihop routes are
2629 treated as IBGP routes.
2630
26312000-09-08 Akihiro Mizutani <mizutani@dml.com>
2632
2633 * bgp_route.c (bgp_show_route): When local-AS community route is
2634 selected, display "not advertised outside local AS" to "show ip
2635 route A.B.C.D" output.
2636 (show_ip_bgp_ipv4_filter_list): Add below four commands.
2637 "show ip bgp ipv4 (unicast|multicast) filter-list WORD"
2638 "show ip bgp ipv4 (unicast|multicast) community"
2639 "show ip bgp ipv4 (unicast|multicast) community-list WORD"
2640 "show ip bgp ipv4 (unicast|multicast) community-list WORD exact-match"
2641
2642 * bgp_clist.c (community_list_match_exact): Community exact match
2643 function.
2644
26452000-09-07 Kunihiro Ishiguro <kunihiro@zebra.org>
2646
2647 * bgp_route.c (bgp_update): Add peer's ttl check.
2648
2649 * bgpd.h (struct peer): Structure member refresh is renamed to
2650 refresh_adv.
2651
2652 * bgpd.c (clear_bgp_soft_in): Check PEER_FLAG_ROUTE_REFRESH flag
2653 when soft reconfiguration is performed.
2654
2655 * bgp_zebra.c (bgp_zebra_announce): When the peer is EBGP and
2656 ebgp-multiphop is set, set ZEBRA_FLAG_INTERNAL for nexthop lookup.
2657
2658 * bgp_route.h (struct bgp_info_tag): Add valid flag.
2659
26602000-08-25 Akihiro Mizutani <mizutani@dml.com>
2661
2662 * bgpd.c: Add AS base BGP soft reconfiguration.
2663
2664 * bgp_route.c: When no-advertise or no-export route is selected,
2665 "show ip bgp" display "not advertised to EBGP peer" or "not
2666 advertised to any peer" message.
2667
26682000-08-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2669
2670 * zebra-0.88 is released.
2671
2672 * bgp_dump.c (dump_bgp_routes): Change "dump bgp routes" to "dump
2673 bgp route-mrt" to support MRT specific dump format.
2674
2675 * bgpd.c (bgp_init): "clear ip bgp vpnv4 soft {in,out}" command is
2676 added.
2677
2678 * bgp_route.c (bgp_update): Currently nexthop check is only works
2679 for IPv4.
2680
26812000-08-17 Akihiro Mizutani <mizutani@dml.com>
2682
2683 * bgpd. (clear_ip_bgp_all_soft): Add "clear ip bgp * soft" for
2684 both inbound and outbound soft reconfiguration.
2685
26862000-08-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2687
2688 * bgpd.c (clear_ip_bgp_peer_soft_out): Add soft-reconfiguration
2689 outbound.
2690 (peer_new): Set route-refresh flag.
2691
26922000-08-16 Akihiro Mizutani <mizutani@dml.com>
2693
2694 * bgpd.c: "no bgp router-id A.B.C.D" alias is added. "no bgp
2695 cluster-id A.B.C.D" alias is added. " bgp cluster-id
2696 <1-4294967295>" alias is added. "clear ip bgp * soft in" command
2697 is added. "clear ip bgp A.B.C.D in" alias is added. "clear ip
2698 bgp * in" alias is added.
2699
27002000-08-16 Kunihiro Ishiguro <kunihiro@zebra.org>
2701
2702 * bgp_route.c (bgp_update): Add soft_reconfig flag. When the flag
2703 is set do not install the route into Adj-RIBs-In.
2704 (bgp_update): Perform implicit withdraw before filtering of the
2705 route.
2706
2707 * bgp_packet.c (bgp_read): draft-ietf-idr-bgp-route-refresh-01.txt
2708 capability code and BGP message can be accepted.
2709
2710 * bgp_open.c (bgp_capability_parse): Likewise.
2711
2712 * bgp_route.c (bgp_refresh_table): New function for route refresh.
2713 (bgp_refresh_rib): Likewise.
2714
2715 * bgpd.c (bgp_show_peer): Display route refresh status.
2716
2717 * bgp_route.c (bgp_aggregate_add): Add check for the route
2718 validness.
2719 (bgp_aggregate_delete): Likewise.
2720
27212000-08-15 Kunihiro Ishiguro <kunihiro@zebra.org>
2722
2723 * bgp_nexthop.c (bgp_scan): Care for aggregate route when the
2724 route become inaccessible.
2725
27262000-08-15 Akihiro Mizutani <mizutani@dml.com>
2727
2728 * bgp_route.c (show_ip_bgp_prefix): "show ip bgp A.B.C.D/M"
2729 command is added.
2730
27312000-08-15 Kunihiro Ishiguro <kunihiro@zebra.org>
2732
2733 * bgp_zebra.c (bgp_interface_up): Register connected route.
2734 (bgp_interface_down): Unregister connected route.
2735
27362000-08-14 Kunihiro Ishiguro <kunihiro@zebra.org>
2737
2738 * bgp_route.h (struct bgp_info): Add distance to the structure.
2739
2740 * bgp_route.c (bgp_aggregate_increment): Aggregate route only
2741 match to smaller prefixlen route not match same prefixlen route.
2742 (bgp_aggregate_decrement): Likewise.
2743 (bgp_aggregate_add): Likewise.
2744 (bgp_aggregate_delete): Likewise.
2745 (bgp_network_backdoor): Add backdoor network configuration.
2746
2747 * bgpd.h (struct bgp ): Add distance_{ebgp,ibgp,local} for store
2748 configuration distance value.
2749
2750 * bgp_route.c (bgp_update): Filter EBGP route which has non
2751 connected nexthop.
2752
2753 * bgp_attr.c (bgp_attr_aggregate_intern): New function for
2754 aggregate route. Set origin to IGP. Set atomic aggregate flag.
2755 Set aggregator AS and address.
2756 (bgp_attr_aggregate_intern): Check BGP_CONFIG_CONFEDERATION when
2757 filling aggregator_as.
2758
2759 * bgp_route.c (bgp_process): Delete suppress check for install
2760 suppressed route into local routing table.
2761 (bgp_aggregate_increment): Use bgp_attr_aggregate_intern() instead
2762 of bgp_attr_default_intern ().
2763 (bgp_aggregate_add): Likewise.
2764
2765 * bgpd.c (bgp_get): Call bgp_if_update_all() after BGP instance is
2766 created. This is for avoid 0.0.0.0 router-id.
2767
27682000-08-13 Akihiro Mizutani <mizutani@dml.com>
2769
2770 * bgp_route.c (route_vty_out_detail): Display "valid" when the
2771 route is valied. Display "aggregated" when the route is
2772 aggregated. "Advertisements suppressed by an aggregate" is
2773 displayed when the route is suppressed.
2774 (bgp_info_cmp): Prefer EBGP than Confed-EBGP.
2775
27762000-08-10 Akihiro Mizutani <mizutani@dml.com>
2777
2778 * bgp_route.c (route_vty_out_detail): Display format change.
2779
27802000-08-06 Kunihiro Ishiguro <kunihiro@zebra.org>
2781
2782 * bgp_route.c (bgp_update): Only AFI_IP nexthop check is enabled.
2783
2784 * bgpd.c (bgp_delete): Delete static route before delete peer
2785 configuration.
2786
27872000-08-02 Kunihiro Ishiguro <kunihiro@zebra.org>
2788
2789 * bgpd.c: Include bgpd/bgp_nexthop.h.
2790
27912000-07-31 Akihiro Mizutani <mizutani@dml.com>
2792
2793 * bgpd.c (bgp_show_summary): "show ip bgp summary" shows own BGP
2794 identifier. And status is changed like below.
2795
2796 State/Pref -> State/PfxRcd
2797 Shutdown -> Idle (Admin)
2798 PrefixOvflw -> Idle (PfxCt)
2799
2800 * bgp_route.c (route_vty_out): Show internal route as "i".
2801
28022000-07-13 Jim Bowen <jimb@zereau.net>
2803
2804 * bgp_snmp.c: Add BGP peer MIB implementation.
2805
28062000-07-12 Akihiro Mizutani <mizutani@dml.com>
2807
2808 * bgpd.c (bgp_show_peer): Fix typo.
2809
28102000-07-11 Akihiro Mizutani <mizutani@dml.com>
2811
2812 * bgp_routemap.c: Add commands for deleting set without argument.
2813
28142000-07-03 Akihiro Mizutani <mizutani@dml.com>
2815
2816 * bgp_zebra.c: Fix redistribute help strings.
2817
28182000-07-01 Kunihiro Ishiguro <kunihiro@zebra.org>
2819
2820 * bgp_route.c (bgp_show): When bgpd works as vtysh server send all
2821 output to vty at once.
2822
28232000-06-13 Kunihiro Ishiguro <kunihiro@zebra.org>
2824
2825 * bgp_mplsvpn.c (no_vpnv4_network): "no network A.B.C.D/M rd WORD
2826 tag WORD" command is added.
2827
2828 * bgp_ecommunity.c (ecommunity_vty_out): New function added.
2829
28302000-06-12 Kunihiro Ishiguro <kunihiro@zebra.org>
2831
2832 * bgp_route.c (bgp_show): Fix total number of prefix count bug.
2833
2834 * bgpd.c (bgp_show_peer): Display VPNv4 unicast configuration and
2835 negotiation result in "show ip bgp neighbors".
2836
28372000-06-12 Akihiro Mizutani <mizutani@dml.com>
2838
2839 * bgpd.c: Fix help strings.
2840
2841 * bgpd.h: Likewise.
2842
28432000-06-11 Kunihiro Ishiguro <kunihiro@zebra.org>
2844
2845 * bgp_route.c (bgp_aggregate_unset): Fix bug of checking rn->info
2846 instead of rn. Reported by Akihiro Mizutani <mizutani@dml.com>.
2847
2848 * bgp_mplsvpn.c (vpnv4_network): For testing purpose, "network
2849 A.B.C.D rd RD" is added to address-family vpnv4 unicast node.
2850
2851 * bgp_route.c (bgp_static_set): Set safi to p.safi.
2852
28532000-06-10 Kunihiro Ishiguro <kunihiro@zebra.org>
2854
2855 * bgp_route.c (bgp_show_prefix_list): Change to use bgp_show().
2856 (bgp_show_regexp): Change to use bgp_show().
2857 (show_adj_route): Change to display header.
2858
2859 * bgpd.c (clear_bgp): Set peer->v_start to default value when peer
2860 is cleared manually.
2861
2862 * bgp_route.c (bgp_show_route): New function which display
2863 specific BGP route. Divided from bgp_show().
2864 (bgp_static_delete): Delete all static route.
2865
28662000-06-09 NOGUCHI Kay <kay@v6.access.co.jp>
2867
2868 * bgp_route.c (show_ipv6_bgp): "show ipv6 bgp" is broken with
2869 invalid privious fix. Now show_ipv6_bgp and show_ipv6_bgp_route
2870 take care of "show ipv6 bgp [X:X::X:X]". Same change for "show ip
2871 mbgp" and "show ipv6 mbgp".
2872
28732000-06-07 Akihiro Mizutani <mizutani@dml.com>
2874
2875 * bgp_route.c: Fix help strings and command arguments.
2876
28772000-06-06 Kunihiro Ishiguro <kunihiro@zebra.org>
2878
2879 * bgp_ecommunity.c: Include prefix.h
2880
28812000-06-05 Kunihiro Ishiguro <kunihiro@zebra.org>
2882
2883 * bgp_route.h (struct bgp_info_tag): New structure to hold tag
2884 value.
2885
2886 * bgp_route.c (bgp_adj_set): table NULL check is added.
2887 (bgp_adj_unset): Likewise.
2888 (bgp_adj_lookup): Likewise.
2889 (bgp_adj_clear): Likewise.
2890 (route_vty_out): Add SAFI check for nexthop display.
2891 (bgp_withdraw): Add SAFI check for withdraw route.
2892
2893 * Remove all #ifdef MPLS_VPN then include it as default.
2894
2895 * bgpd.c: Temporary disable peer-group command until the
2896 implementation is completed.
2897
2898 * bgp_routemap.c (bgp_route_map_init): Install
2899 route_metric_match_cmd.
2900 (route_match_metric_compile): MED value compile using strtoul.
2901
29022000-06-05 Akihiro Mizutani <mizutani@dml.com>
2903
2904 * bgp_filter.c: Fix help strings. Change REGEXP to LINE. Change
2905 NAME to WORD.
2906
2907 * Change command argument to more comprehensive.
2908
2909 METRIC -> <0-4294967295>
2910 WEIGHT -> <0-4294967295>
2911 LOCAL_PREF -> <0-4294967295>
2912 IP_ADDR -> A.B.C.D
2913 AS -> <1-65535>
2914 AS-PATH-NAME -> WORD
2915 ACCESS_LIST -> WORD
2916 PREFIX_LIST -> WORD
2917 COMMUNITY -> AA:NN
2918 EXT_COMMUNITY -> ASN:nn_or_IP-address:nn
2919 IPv6_ADDR -> X:X::X:X
2920
2921 * bgp_clist.c: Fix help strings.
2922
29232000-06-03 Kunihiro Ishiguro <kunihiro@zebra.org>
2924
2925 * bgpd.c (peer_active): Add new function for check the peer is
2926 active or not.
2927 (neighbor_activate): New command "neighbor PEER activate" and "no
2928 neighbor PEER activate" are added.
2929
2930 * bgp_packet.c: Include bgpd/bgp_mplsvpn.h.
2931
29322000-06-02 Akihiro Mizutani <mizutani@dml.com>
2933
2934 * bgp_clist.c: Fix commuity-list help strings.
2935
2936 * bgp_routemap.c: Fix "set community" help strings. Add #define
2937 SET_STR. Use (unicast|multicast) argument for "set nlri" command.
2938
29392000-06-01 Kunihiro Ishiguro <kunihiro@zebra.org>
2940
2941 * bgp_routemap.c (route_set_community_none_cmd): "set community
2942 none" command is added to route-map.
2943
29442000-06-01 Akihiro Mizutani <mizutani@dml.com>
2945
2946 * bgp_debug.c: Change "show debug" to "show debugging". Now "show
2947 debugging" is not used in VIEW_NODE.
2948
29492000-05-30 Kunihiro Ishiguro <kunihiro@zebra.org>
2950
2951 * bgp_fsm.c (bgp_timer_set): Add check for shutdown flag. This
2952 fix unconditional BGP connection.
2953
2954 * bgpd.c (peer_shutdown): Replace peer_shutdown() with
2955 peer_change_flag_with_reset().
2956
29572000-05-26 Kunihiro Ishiguro <kunihiro@zebra.org>
2958
2959 * bgpd.c (no_bgp_default_ipv4_unicast): Add "no bgp default
2960 ipv4-unicast" command.
2961
2962 * bgpd.h (BGP_CONFIG_NO_DEFAULT_IPV4): Add new definition.
2963
2964 * bgp_filter.c (as_list_delete): Free all AS filter.
2965
2966 * bgp_clist.c (community_list_delete): Free all community entry.
2967
2968 * bgp_filter.c (no_ip_as_path_all): New DEFUN for "no ip as-path
2969 access-list NAME".
2970
2971 * bgp_clist.c (no_ip_community_list_all): New DEFUN for "no ip
2972 community-list NAME".
2973
29742000-05-19 Kunihiro Ishiguro <kunihiro@zebra.org>
2975
2976 * bgp_route.c (ipv6_mbgp_neighbor_routes): Change "show ip bgp PEER
2977 routes" to "show ip bgp PEER received-routes"
2978
29792000-05-14 Kunihiro Ishiguro <kunihiro@zebra.org>
2980
2981 * bgp_ecommunity.c (ecommunity_parse): New file for Extended
2982 Communities attribute.
2983 * bgp_ecommunity.h: Likewise.
2984
29852000-05-11 Kunihiro Ishiguro <kunihiro@zebra.org>
2986
2987 * bgp_mplsvpn.h: New file for MPLS-VPN.
2988 * bgp_mplsvpn.c: Likewise.
2989
2990 * bgpd.c (bgp_delete): Fix bug of "no router bgp" crush.
2991
29922000-05-10 Kunihiro Ishiguro <kunihiro@zebra.org>
2993
2994 * bgpd.c (bgp_bestpath_missing_as_worst): Add "bgp bestpath
2995 missing-as-worst".
2996
29972000-05-08 Kunihiro Ishiguro <kunihiro@zebra.org>
2998
2999 * bgp_routemap.c (match_community): Clarify help of "match
3000 community".
3001
30022000-05-02 Kunihiro Ishiguro <kunihiro@zebra.org>
3003
3004 * bgp_aspath.c (aspath_cmp_left): Remove debug code.
3005
30062000-04-27 Kunihiro Ishiguro <kunihiro@zebra.org>
3007
3008 * bgp_route.c (bgp_info_cmp): Compare MED only both routes comes
3009 from same neighboring AS.
3010
3011 * bgp_aspath.c (aspath_cmp_left): Compare leftmost AS value.
3012
3013 * bgp_route.c (bgp_info_cmp): Fix misused htonl() to ntohl().
3014
30152000-04-26 Kunihiro Ishiguro <kunihiro@zebra.org>
3016
3017 * bgp_route.c (bgp_output_filter): When distribute-list's
3018 corresponding access-list does not exist, filter all routes.
3019 (bgp_input_filter): Likewise.
3020
30212000-04-19 Kunihiro Ishiguro <kunihiro@zebra.org>
3022
3023 * bgp_attr.c (bgp_packet_attribute): Propagate MED to IBGP peer.
3024
3025 * bgp_route.c (bgp_info_cmp): Add evaluation of local preference.
3026
30272000-04-18 Kunihiro Ishiguro <kunihiro@zebra.org>
3028
3029 * bgpd.c (bgp_distribute_update): Add struct access_list *
3030 argument.
3031
30322000-04-17 Kunihiro Ishiguro <kunihiro@zebra.org>
3033
3034 * bgp_clist.c (community_list_dup_check): Add duplicate insertion
3035 check.
3036
3037 * bgp_filter.c (as_list_dup_check): Add duplicate insertion check.
3038
3039 * bgp_route.c (bgp_show): Fix undeclared write variable.
3040
30412000-04-13 Kunihiro Ishiguro <kunihiro@zebra.org>
3042
3043 * bgp_routemap.c: Add "match ip address prefix-list".
3044
30452000-03-29 Rick Payne <rickp@rossfell.co.uk>
3046
3047 * bgp_aspath.c (aspath_strip_confed): Fix realloc problem.
3048
30492000-03-16 Kunihiro Ishiguro <kunihiro@zebra.org>
3050
3051 * bgp_fsm.c (bgp_reconnect): Connect retry timer is expired when
3052 the peer status is Connect.
3053
30542000-03-03 Kunihiro Ishiguro <kunihiro@zebra.org>
3055
3056 * Fix bug of rewritten originator-id.
3057
30582000-01-27 Rick Payne <rickp@rossfell.co.uk>
3059
3060 * bgp_aspath.c (aspath_delimiter_char): New function. Instead of
3061 directly referencing array, search proper AS path delimiter.
3062 (aspath_strip_confed): Strip the confederation stuff from the
3063 front of an AS path.
3064 (aspath_add_left_confed): New function for adding specified AS to
3065 the leftmost AS_CONFED_SEQUENCE.
3066
3067 * bgp_aspath.h: Change AS_CONFED_SEQUENCE and AS_CONFED_SET value
3068 to Cisco compatible.
3069
3070 * bgpd.c (bgp_confederation_id_set): Confederation configuration.
3071 (bgp_confederation_id_unset): Likewise.
3072 (bgp_confederation_peers_check): Likewise.
3073 (bgp_confederation_peers_add): Likewise.
3074 (bgp_confederation_peers_remove): Likewise.
3075 (bgp_confederation_peers_set): Likewise.
3076 (bgp_confederation_peers_unset): Likewise.
3077 (bgp_confederation_peers_print): Likewise.
3078
30792000-01-16 Kunihiro Ishiguro <kunihiro@zebra.org>
3080
3081 * bgpd.c: Introduce peer_change_flag_with_reset() fucntion.
3082
30832000-01-17 Kunihiro Ishiguro <kunihiro@zebra.org>
3084
3085 * bgp_open.c (bgp_open_option_parse): When there is no common
3086 capability send Unsupported Capability error to the peer.
3087
30882000-01-14 Kunihiro Ishiguro <kunihiro@zebra.org>
3089
3090 * bgp_open.c (bgp_capability_mp): Fix bug of mis-negotiation about
3091 IPv6 unicast.
3092
3093 * bgpd.c (bgp_init): Add "soft-reconfiguration inbound" command.
3094
30952000-01-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3096
3097 * bgpd.c (neighbor_strict_capability): Add
3098 "strict-capability-match" command.
3099
3100 * bgp_zebra.c (bgp_if_update): Ignore NET127 determining
3101 router-id.
3102
3103 * bgpd.c (peer_override_capability): Add "override-capability"
3104 command.
3105
31061999-12-16 Kunihiro Ishiguro <kunihiro@zebra.org>
3107
3108 * bgp_packet.c (bgp_write): Change status to Idle and set timer
3109 after write failed.
3110
31111999-12-14 Kunihiro Ishiguro <kunihiro@zebra.org>
3112
3113 * bgp_zebra.c (bgp_zebra_announce): Add info->selected check.
3114
31151999-12-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3116
3117 * bgp_route.c (nlri_unfeasible): nlri_unfeasible() is merged with
3118 nlri_parse().
3119
31201999-12-10 Kunihiro Ishiguro <kunihiro@zebra.org>
3121
3122 * bgp_fsm.h (BGP_EVENT_DELETE): Macro added.
3123
3124 * bgp_fsm.c (bgp_stop): Clear all event threads of the peer when
3125 the peer is cleared.
3126
3127 * bgp_zebra.c (bgp_nexthop_set): Clear interface index of
3128 link-local address. This is KAME specific problem.
3129
31301999-12-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3131
3132 * bgp_attr.c (bgp_mp_reach_parse): Comment out previous code for a
3133 while. We don't completely detect the link is shared or not at
3134 this moment.
3135
3136 * bgp_packet.c (bgp_notify_send): Make shortcut call of
3137 bgp_write() and bgp_stop().
3138
3139 * bgp_attr.c (bgp_mp_reach_parse): Fix serious bug when getting
3140 global and link-local address.
3141
31421999-12-05 Kunihiro Ishiguro <kunihiro@zebra.org>
3143
3144 * bgpd.c (no_neighbor_port): New command added.
3145 (peer_new): Set send_community.
3146
31471999-12-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3148
3149 * bgpd.c (show_ip_bgp_summary): Changed to use bgp_show_summary().
3150 (show_ip_mbgp_summary): Likewise.
3151 (show_ipv6_bgp_summary): Likewise.
3152 (show_ipv6_mbgp_summary): Add new command.
3153 (peer_free): Free peer->host.
3154 (peer_lookup_by_su): Delete function.
3155 (ipv6_bgp_neighbor): Changed to use peer_remote_as().
3156 (sockunion_vty_out): Function deleted.
3157 (vty_clear_bgp): Use afi instead of family.
3158 Delete old list bgp_list. Use struct newlist *bgplist.
3159 (peer_lookup_by_host): Function deleted.
3160
31611999-12-03 Kunihiro Ishiguro <kunihiro@zebra.org>
3162
3163 * bgpd.h (struct peer_group): New structure added.
3164 (struct peer_conf): New structure added.
3165 (struct peer): Change all prefix_count to unsigned long.
3166
3167 * bgpd.c: Reconstruct all of VTY commands reflect internal
3168 structure change.
3169 Use bgplist instead of bgp_list.
3170 Use peerlist intstead of peer_list.
3171
3172 * bgp_attr.c (bgp_mp_reach_parse): If nlri_parse return -1, stop
3173 parsing then return immediately.
3174
3175 * bgp_route.c (nlri_parse): When NLRI parse error occured, return
3176 -1.
3177 (nlri_process): Use pcount_v4_{unicast,multicast}.
3178 (nlri_delete): Likewise.
3179
31801999-11-25 Robert Olsson <Robert.Olsson@data.slu.se>
3181
3182 * bgp_routemap.c (route_match_nlri): `match nlri
3183 unicast|multicast' and `set nlri unicast|multicast' command are
3184 added.
3185
31861999-11-22 Robert Olsson <Robert.Olsson@data.slu.se>
3187
3188 * bgpd.c: Add translate-update support.
3189
3190 * bgpd.h (TRANSLATE_UPDATE_OFF): Add translate-update definition.
3191
31921999-11-19 Robert.Olsson@data.slu.se
3193
3194 * bgp_route.c (bgp_peer_delete): Add MBGP peer clear codes.
3195
31961999-11-14 Kunihiro Ishiguro <kunihiro@zebra.org>
3197
3198 * bgp_open.c (bgp_capability_mp): Temporary comment out
3199 SAFI_UNICAST_MULTICAST handling until we know the meanings.
3200
32011999-11-13 Kunihiro Ishiguro <kunihiro@zebra.org>
3202
3203 * bgp_btoa.c: New file added.
3204
32051999-11-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3206
3207 * bgpd.h (struct peer): Add dont_capability flag.
3208 (struct peer): Add override_capability flag.
3209
3210 * bgpd.c (neighbor_dont_capability_negotiation): `neighbor PEER
3211 dont-capability-negotiation' added.
3212
32131999-11-12 Bill Sommerfeld <sommerfeld@orchard.arlington.ma.us>
3214
3215 * bgp_attr.c (bgp_mp_reach_parse): Ignore link-local addresses
3216 attribute from non-shared-network peers.
3217
32181999-11-10 Kunihiro Ishiguro <kunihiro@zebra.org>
3219
3220 * bgp_snmp.c: New file added.
3221
3222 * BGP4-MIB.txt: Updated to the latest Internet-Draft
3223 draft-ietf-idr-bgp4-mib-04.txt.
3224
32251999-11-09 Kunihiro Ishiguro <kunihiro@zebra.org>
3226
3227 * bgp_route.c (bgp_route_init): Add `show ipv6 bgp prefix-list'.
3228
3229 * bgp_attr.c (bgp_mp_unreach_parse): Enclose safi setup with
3230 #ifdef HAVE_MBGPV4.
3231
32321999-11-08 Kunihiro Ishiguro <kunihiro@zebra.org>
3233
3234 * bgp_dump.c (no_dump_bgp_all): Add [PATH] and [INTERVAL] to no
3235 dump bgp commands.
3236 (config_write_bgp_dump): Write interval value to the
3237 configuration.
3238
32391999-11-07 Kunihiro Ishiguro <kunihiro@zebra.org>
3240
3241 * bgp_zebra.c: Redistribute route-map support is added.
3242
3243 * bgp_zebra.h: New file added.
3244
32451999-11-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3246
3247 * bgp_dump.c: BGP packet dump routine compatible with MRT.
3248 * bgp_dump.h: BGP packet dump routine compatible with MRT.
3249
3250 * bgp_debug.c: Renamed from bgp_dump.c
3251 * bgp_debug.h: Renamed from bgp_dump.h
3252
32531999-10-27 Kunihiro Ishiguro <kunihiro@zebra.org>
3254
3255 * BGP4-MIB.txt: New file added. Edited version of RFC1657.
3256
32571999-10-25 Bill Sommerfeld <sommerfeld@orchard.arlington.ma.us>
3258
3259 * bgp_route.c (bgp_announce): If we're not on a shared network
3260 with the peer and we don't have a link-local next hop, but the
3261 inbound next-hop has a link-local address, don't readvertise it to
3262 our peer.
3263
32641999-10-25 Marc Boucher <marc@mbsi.ca>
3265
3266 * bgp_zebra.c: Add redistribute kernel command.
3267
32681999-10-25 Kunihiro Ishiguro <kunihiro@zebra.org>
3269
3270 * bgp_route.c (bgp_reset): New function added.
3271
3272 * bgpd.conf.sample2: Add IPv6 configuration sample.
3273
32741999-10-24 Bill Sommerfeld <sommerfeld@orchard.arlington.ma.us>
3275
3276 * bgp_route.c (ipv6_aggregate_address): Function added.
3277
32781999-10-21 Kunihiro Ishiguro <kunihiro@zebra.org>
3279
3280 * bgp_packet.c (bgp_update): Unintern aspath, community, cluster
3281 list after parsing BGP update packet.
3282
3283 * bgp_attr.c (bgp_attr_aspath): Intern parsed aspath.
3284 (bgp_attr_community): Intern parsed community.
3285 (bgp_attr_cluster_list): Intern parsed cluster list.
3286
3287 * bgp_routemap.c: Add `set community-additive' command.
3288
32891999-10-21 Alexandr D. Kanevskiy <kad@blackcatlinux.com>
3290
3291 * bgp_routemap.c (route_set_local_pref): Fix bug of setting
3292 attribute flag.
3293
32941999-10-21 Bill Sommerfeld <sommerfeld@orchard.arlington.ma.us>
3295
3296 * bgp_route.c (bgp_announce): Add check of IPv6 default route
3297 announcement.
3298
3299 * bgp_packet.c (bgp_update_send): Add BGP announcement logging.
3300
33011999-10-15 Kunihiro Ishiguro <kunihiro@zebra.org>
3302
3303 * `show ip[v6] bgp PREFIX' show uptime of the route.
3304
33051999-10-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3306
3307 * bgpd.c (bgp_filter_set): Delete PEER_FAMILY_{IPV4,IPV6}. instead
3308 of that use AF_INET and AF_INET6 directly.
3309 (vty_clear_bgp): Add new function to support various clear ip bgp
3310 method.
3311
33121999-10-04 Lars Fenneberg <lf@elemental.net>
3313
3314 * bgpd.c (clear_ip_bgp): Add `clear ip bgp ASN'.
3315
33161999-10-03 Kunihiro Ishiguro <kunihiro@zebra.org>
3317
3318 * bgp_routemap.c: Add `match ip prefix-list' and `match ipv6
3319 prefix-list'.
3320
33211999-09-28 Kunihiro Ishiguro <kunihiro@zebra.org>
3322
3323 * bgpd.c (bgp_collision_detect): Add BGP collision detection
3324 function.
3325
33261999-09-26 Blake Meike <bmeike@adero.com>
3327
3328 * bgpd.c (neighbor_port): New command `neighbor PEER port PORT' is
3329 added.
3330
33311999-08-24 Kunihiro Ishiguro <kunihiro@zebra.org>
3332
3333 * bgpd.c (no_neighbor_timers_keepalive): Change MIN to min. Add
3334 min() macro.
3335
33361999-08-19 Rick Payne <rickp@rossfell.co.uk>
3337
3338 * bgp_packet.c (bgp_open): BGP holdtimer bug is fixed. Make BGP
3339 keepalive timer configurable.
3340
33411999-08-15 Kunihiro Ishiguro <kunihiro@zebra.org>
3342
3343 * bgp_zebra.c (bgp_redistribute_set): Fix redistribute bug.
3344
33451999-08-13 Kunihiro Ishiguro <kunihiro@zebra.org>
3346
3347 * bgpd.c (bgp_peer_display): show ip bgp neighbors PEER only list
3348 the peer not all of them.
3349
33501999-08-11 Rick Payne <rickp@rossfell.co.uk>
3351
3352 * bgp_route.c (bgp_announce): Remove MED if its an EBGP peer -
3353 will get overwritten by route-maps.
3354
33551999-08-08 Rick Payne <rickp@rossfell.co.uk>
3356
3357 * bgp_routemap.c: Multi protocol route-map modification.
3358
33591999-08-01 Kunihiro Ishiguro <kunihiro@zebra.org>
3360
3361 * bgp_route.c: Set network statement route's origin attribute as
3362 igp.
3363
3364 * bgp_zebra.c: Set redistribute route's origin attribute as
3365 incomplete.
3366
3367 * bgp_route.c (bgp_info_cmp): Add attribute existance check,
3368 origin attribute check, BGP peer type check.
3369
33701999-07-30 Kunihiro Ishiguro <kunihiro@zebra.org>
3371
3372 * bgp_route.c (bgp_peer_delete): Reselect of IPv6 route.
3373
33741999-07-29 Rick Payne <rickp@rossfell.co.uk>
3375
3376 * Changed route-maps to behave in a more cisco-like fashion
3377
33781999-07-27 Kunihiro Ishiguro <kunihiro@zebra.org>
3379
3380 * bgp_fsm.c (bgp_stop): Very serious bug of bgp_stop () is fixed.
3381 When multiple route to the same destination exist, bgpd try to
3382 announce the information to stopped peer. Then add orphan write
3383 thread is added. This cause many strange behavior of bgpd.
3384 Reported by Georg Hitsch <georg@atnet.at>.
3385
33861999-07-23 Kunihiro Ishiguro <kunihiro@zebra.org>
3387
3388 * bgpd.c: Change peer's A.B.C.D to PEER.
3389
33901999-07-22 Kunihiro Ishiguro <kunihiro@zebra.org>
3391
3392 * bgp_route.c (bgp_announce): Add hack for link-local nexthop.
3393
3394 * bgp_zebra.c (bgp_zebra_announce): Fill in nexthop address from
3395 local address.
3396
33971999-07-21 Kunihiro Ishiguro <kunihiro@zebra.org>
3398
3399 * bgp_packet.c (bgp_open): Holdtime fetch bug is fixed. Reported
3400 by Yuji SEKIYA <sekiya@sfc.wide.ad.jp>.
3401
34021999-07-15 Kunihiro Ishiguro <kunihiro@zebra.org>
3403
3404 * bgp_fsm.c (fsm_holdtime): Don't close file descriptor in
3405 fsm_holdtime ().
3406
34071999-07-11 Kunihiro Ishiguro <kunihiro@zebra.org>
3408
3409 * bgp_routemap.c: Add `set atomic-aggregate' command.
3410
34111999-07-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3412
3413 * bgp_routemap.c (route_set_ip_nexthop_cmd): Change "ip nexthop"
3414 to "ip next-hop".
3415
34161999-07-02 Kunihiro Ishiguro <kunihiro@zebra.org>
3417
3418 * bgp_route.c (show_ipv6_bgp_regexp): `show ipv6 bgp regexp'
3419 added.
3420
34211999-07-01 Rick Payne <rickp@rossfell.co.uk>
3422
3423 * bgp_zebra.c (zebra_init): Install standard commands to
3424 ZEBRA_NODE.
3425
34261999-06-28 Rick Payne <rickp@rossfell.co.uk>
3427
3428 * bgpd.c (bgp_delete): bgp peer deletion bug is fixed.
3429
34301999-06-25 Kunihiro Ishiguro <kunihiro@zebra.org>
3431
3432 * bgpd.c: Add neighbor update-source command as ALIAS to
3433 neighbor_interface.
3434
34351999-06-19 Kunihiro Ishiguro <kunihiro@zebra.org>
3436
3437 * bgp_attr.c (bgp_packet_attribute): Send community attribute when
3438 send_community flag is set.
3439
3440 * bgpd.h (struct peer): Add send_community flag.
3441
34421999-06-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3443
3444 * bgpd.c (router_bgp): router bgp's argument changed from AS_NO to
3445 <1-65535>.
3446
34471999-06-08 Kunihiro Ishiguro <kunihiro@zebra.org>
3448
3449 * bgp_route.h (struct bgp_info): Add subtype for BGP route type.
3450
34511999-06-07 Kunihiro Ishiguro <kunihiro@zebra.org>
3452
3453 * bgp_community.c (community_merge): Function added.
3454
34551999-06-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3456
3457 * bgp_clist.c: New file.
3458 * bgp_clist.h: New file.
3459
3460 * bgp_community.h (COMMUNITY_LOCAL_AS): Added for Cisco
3461 compatibility.
3462 (COMMUNITY_NO_ADVERTISE): Fix typo.
3463
34641999-05-30 Kunihiro Ishiguro <kunihiro@zebra.org>
3465
3466 * bgp_routemap.c: Add `set weight WEIGHT' command.
3467
3468 * bgpd.c: Remove all_digit_check function. Instead of that use
3469 all_digit function in lib/prefix.c.
3470
3471 * bgp_routemap.c (bgp_route_map_init): Install
3472 no_set_ipv6_nexthop_global_cmd and no_set_ipv6_nexthop_local_cmd
3473 element to the RMAP_NODE.
3474
34751999-05-28 Kunihiro Ishiguro <kunihiro@zebra.org>
3476
3477 * bgp_aspath.c (aspath_make_str): Declare aspath_delimiter_char
3478 inside aspath_make_str function.
3479 (aspath_prepend): New function is added for AS path prepend.
3480 (aspath_make_str_count): Renamed from aspath_make_str. AS path
3481 count is set to the structure.
3482 (aspath_merge): New function.
3483
34841999-05-22 Kunihiro Ishiguro <kunihiro@zebra.org>
3485
3486 * bgp_zebra.c (redistribute_bgp): Add new DEFUN.
3487 (no_redistribute_bgp): Likewise.
3488 (router_zebra): Semantics changed. Now 'router zebra' is default
3489 behavior of bgpd.
3490
34911999-05-14 Kunihiro Ishiguro <kunihiro@zebra.org>
3492
3493 * bgp_routemap.c: Add some commands to bgp route-map.
3494 match ip next-hop: New command.
3495 match metric: New command.
3496 set metric: Doc fix.
3497 set local-preference: Add DEFUN.
3498
34991999-05-14 Stephen R. van den Berg <srb@cuci.nl>
3500
3501 * bgp_main.c (signal_init): SIGTERM call sigint.
3502 (sigint): Loggging more better message.
3503
35041999-05-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3505
3506 * bgp_attr.c (bgp_packet_attribute): AS path attribute extended
3507 length bit check is added.
3508
35091999-05-11 Kunihiro Ishiguro <kunihiro@zebra.org>
3510
3511 * bgp_routemap.c (bgp_route_map_init): Call route_map_install_set
3512 function with route_set_local_pref_cmd argument.
3513 (no_match_aspath): Function added.
3514 (route_set_metric): Set attribute flag bit.
3515
3516 * bgp_attr.c (bgp_packet_attribute): MULTI_EXIT_DISC is now in BGP
3517 packet.
3518
35191999-05-07 Kunihiro Ishiguro <kunihiro@zebra.org>
3520
3521 * bgpd.c (no_neighbor_timers_holdtime): `no neighbor PEER timers
3522 holdtime' command is added.
3523
3524 * bgpd.h (BGP_DEFAULT_HOLDTIME_BIG): Delete define.
3525
3526 * bgpd.c (bgp_prefix_list_set): New function added.
3527 (bgp_prefix_list_unset): Likewise.
3528 (bgp_prefix_list_update): Likewise.
3529 (show_ip_bgp_neighbors): prefix-list information display.
3530
35311999-05-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3532
3533 * bgpd.c (bgp_delete): Function added for `no router bgp'.
3534
35351999-05-05 Kunihiro Ishiguro <kunihiro@zebra.org>
3536
3537 * bgp_dump.c (bgp_dump_attr): Add originator_id display.
3538
3539 * bgpd.c (bgp_router_id): Even when address is malformed set the
3540 value to configuration bug fixed.
3541 (no_bgp_router_id): New function.
3542 (no_bgp_cluster_id): New function.
3543
35441999-05-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3545
3546 * bgpd.h (BGP_ATTR_ORIGINATOR_ID): Changed from BGP_ATTR_ORIGINATOR.
3547
35481999-05-02 Kunihiro Ishiguro <kunihiro@zebra.org>
3549
3550 * bgp_route.c (bgp_announce): Add route reflector check.
3551
35521999-05-01 Kunihiro Ishiguro <kunihiro@zebra.org>
3553
3554 * bgpd.c (bgp_cluster_id): Add function for route reflector.
3555 (neighbor_route_reflector_client): Likewise.
3556 (no_neighbor_route_reflector_client): Likewise.
3557
3558 * bgpd.h (struct bgp ): Add cluster for route reflector.
3559
3560 * bgp_route.c (show_ip_bgp_prefix_list): New command is added.
3561
35621999-04-24 Kunihiro Ishiguro <kunihiro@zebra.org>
3563
3564 * Makefile.am (noinst_HEADERS): Add bgp_filter.h
3565
3566 * bgp_aspath.c (aspath_undup): Function deleted. aspath_free ()
3567 has same functionality.
3568
3569 * bgp_filter.h: New file.
3570
3571 * bgp_aspath.c (aspath_unintern): Rename aspath_free () to
3572 aspath_unintern ()
3573 (aspath_free): New function.
3574
35751999-04-23 Kunihiro Ishiguro <kunihiro@zebra.org>
3576
3577 * bgp_aspath.c (aspath_aggregate): Function added.
3578
3579 * bgp_aspath.h (aspath_aggregate): Prototype added.
3580
3581 * bgp_aspath.c (aspath_empty_aspath): New argument
3582 gated_dont_eat_flag is added.
3583
35841999-04-18 Kunihiro Ishiguro <kunihiro@zebra.org>
3585
3586 * bgp_route.c: Add bgp_aggregate_ipv4 and bgp_aggregate_ipv6.
3587
35881999-04-17 Kunihiro Ishiguro <kunihiro@zebra.org>
3589
3590 * bgp_route.c (aggregate_address): Function added.
3591
3592 * bgp_zebra.c (zebra_read): Change log to zlog.
3593
35941999-04-15 Kunihiro Ishiguro <kunihiro@zebra.org>
3595
3596 * Makefile.am (noninst_HEADERS): Added for make dist.
3597
35981999-04-09 Kunihiro Ishiguro <kunihiro@zebra.org>
3599
3600 * aspath_regex.c: Removed from distribution.
3601
36021999-04-07 Kunihiro Ishiguro <kunihiro@zebra.org>
3603
3604 * bgp_attr.c (bgp_packet_attribute): Old draft-00 packet treatment
3605 bug fixed.
3606
36071999-04-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3608
3609 * bgp_aspath.c (aspath_add_left): Fix empty aspath bug. Reported
3610 by kad@gibson.skif.net.
3611
3612 * bgp_regex.[ch]: New file added.
3613
3614
36151999-04-05 Kunihiro Ishiguro <kunihiro@zebra.org>
3616
3617 * bgp_filter.c: New file added.
3618
36191999-04-01 Kunihiro Ishiguro <kunihiro@zebra.org>
3620
3621 * bgp_aspath.c (aspath_empty_aspath): Change for peering with
3622 gated.
3623
36241999-03-24 Kunihiro Ishiguro <kunihiro@zebra.org>
3625
3626 * bgp_main.c (main): Default loggin method changed from syslog to
3627 stdout.
3628
36291999-03-05 Kunihiro Ishiguro <kunihiro@zebra.org>
3630
3631 * bgp_route.c: Delete obsolete default attribute DEFUN.
3632
36331999-03-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3634
3635 * bgp_attr.c: Make attribute structure put into attribute hash.
3636
36371999-03-02 Kunihiro Ishiguro <kunihiro@zebra.org>
3638
3639 * bgp_view.c : Delete file.
3640
36411999-02-25 Kunihiro Ishiguro <kunihiro@zebra.org>
3642
3643 * bgp_routemap.c (bgp_apply_route_map): Add prefix argument.
3644
3645 * bgp_route.h (struct bgp_info): Add bgp_info structre. I'll
3646 replace bgp_route with this.
3647
3648 * bgp_routemap.c (route_match_ip_address): Fix bug of passing non
3649 prefix value to access_list_apply().
3650
3651 * bgpd.conf.sample: Add route-map sample.
3652 Delete obsolete default-attr statements.
3653
3654 * bgp_packet.c: Use stream_fifo for packet queueing.
3655
36561999-02-24 Kunihiro Ishiguro <kunihiro@zebra.org>
3657
3658 * bgp_aspath.c (aspath_add_left): add non empty aspath treatment.
3659
3660 * bgp_main.c: include unistd.h for daemon().
3661
3662 * bgp_route.c (nlri_process): add IPv6 table lookup.
3663
3664 * bgp_attr.c (route_parse_ipv6): call nlri_process().
3665 (attr_make): Obsolete function attr_make deleted.
3666
36671999-02-22 Kunihiro Ishiguro <kunihiro@zebra.org>
3668
3669 * bgp_aspath.c (aspath_add_left): change function name from
3670 aspath_add_leftmost_as().
3671
36721999-02-21 Kunihiro Ishiguro <kunihiro@zebra.org>
3673
3674 * bgp_aspath.c: add aspath_add_leftmost_as ().
3675
36761999-02-18 Peter Galbavy <Peter.Galbavy@knowledge.com>
3677
3678 * syslog support added
3679
36801999-01-26 Kunihiro Ishiguro <kunihiro@zebra.org>
3681
3682 * bgpd.c: DEFUN (neighbor_nexthop): deleted.
3683 DEFUN (neighbor_distribute_list): added.
3684
36851999-01-19 Kunihiro Ishiguro <kunihiro@zebra.org>
3686
3687 * bgpd.h (struct peer ): header_buf and read_buf is removed.
3688
3689 * bgp_peer.[ch]: Deleted. Peer related functions are merged to
3690 bgpd.c
3691
3692 * bgp_network.c: New file.
3693 * bgp_network.h: New file.
3694
3695 * bgp_packet.h: New file.
3696
36971999-01-11 Kunihiro Ishiguro <kunihiro@zebra.org>
3698
3699 * bgp_packet.c (bgp_keepalive_send): Now BGP keepalive packet is
3700 buffered.
3701
37021999-01-08 Kunihiro Ishiguro <kunihiro@zebra.org>
3703
3704 * bgp_packet.c: New file.
3705
37061998-12-22 Kunihiro Ishiguro <kunihiro@zebra.org>
3707
3708 * bgp_zebra.c (zebra_client): Use zebra_connect() in lib/client.c.
3709
3710 * `show ip bgp' bug fixed.
3711 * aspath_log (): Remove argument logfp.
3712
37131998-12-15 Kunihiro Ishiguro <kunihiro@zebra.org>
3714
3715 * bgp_fsm.h: New file.
3716
37171998-12-15 Magnus Ahltorp <map@stacken.kth.se>
3718
3719 * bgp_attr.c, bgp_community.h, bgp_dump.c, bgp_fsm.c, bgp_open.c
3720 bgp_peer.c, bgp_peer.h, bgp_route.c, bgp_route.h, bgp_view.c
3721 bgpd.c, bgpd.h, bgp_attr.c, bgp_community.h, bgp_dump.c,
3722 bgp_fsm.c, bgp_open.c, bgp_peer.c, bgp_peer.h: Prototype fixes.
3723
37241998-12-09 Kunihiro Ishiguro <kunihiro@zebra.org>
3725
3726 * bgpd.c (bgp_config_write): Delete vector v argument.
3727
37281998-12-07 Kunihiro Ishiguro <kunihiro@zebra.org>
3729
3730 * bgpd.h: Delete annoying ld_[124]byte and st_[124]byte macros.
3731
37321998-11-23 Kunihiro Ishiguro <kunihiro@zebra.org>
3733
3734 * bgp_radix.[ch]: removed.
3735
37361998-09-15 HEO SeonMeyong <seirios@matrix.iri.co.jp>
3737
3738 * bgp_main.c: ifdef HYDRANGEA -> ifdef KAME
3739
37401998-08-13 Kunihiro Ishiguro <kunihiro@zebra.org>
3741
3742 * bgp_dump.c: delete nroute().
3743
37441998-05-19 Yamshita TAKAO <jargon@lares.dti.ne.jp>
3745
3746 * bgp_aspath.c: HAVE_CONFIG_H typo :-)
3747 * bgpd.h: Modify for compile on Solaris.
3748 * bgp_aspath.h: likewize
3749 * bgp_community.h: likewize
3750 * bgp_routemap.c: likewize
3751
37521998-05-18 Yamshita TAKAO <jargon@lares.dti.ne.jp>
3753
3754 * bgpd.h: Modify for compile on Solaris.
3755 * bgp_aspath.h: likewize
3756
37571998-05-08 Kunihiro Ishiguro <kunihiro@zebra.org>
3758
3759 * routemap.[ch]: move to ../lib directory.
3760
37611998-05-07 Kunihiro Ishiguro <kunihiro@zebra.org>
3762
3763 * routemap.c (route_map_apply): add function.
3764
37651998-05-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3766
3767 * routemap.h: add file.
3768
3769 * bgp_peer.h (enum ): change PEER_{IBGP,EBGP} to BGP_PEER_{IBGP,EBGP}
3770
37711998-05-03 Kunihiro Ishiguro <kunihiro@zebra.org>
3772
3773 * Makefile.am: sysconfdir_DATA added.
3774
37751998-05-02 Kunihiro Ishiguro <kunihiro@zebra.org>
3776
3777 * bgp_dump.c: add `debug bgp fsm'
3778 add `no debug bgp fsm'
3779 add `show debug bgp'
3780 * bgp_open.c: File added.
3781
37821998-05-01 Kunihiro Ishiguro <kunihiro@zebra.org>
3783
3784 * .cvsignore: File added.
3785
37861998-04-30 Kunihiro Ishiguro <kunihiro@zebra.org>
3787
3788 * bgp_community.[ch]: File added.
3789
37901998-03-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3791
3792 * bgpd now use lib/thread.[ch].
3793
37941998-01-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3795
3796 * bgpd.c (show_ip_bgp_neighbors): add 'show ip bgp neighbors' command.
3797
3798 * bgpd.h (BGP_DEFAULT_START_TIMER): change from 1 to 30.
3799
38001997-12-30 Kunihiro Ishiguro <kunihiro@zebra.org>
3801
3802 * bgp_vty.c: bgp_vty.c deleted.
3803
3804 * bgpd.c (config_write_neighbor): add ebgp-multihop command.
3805
38061997-12-29 Kunihiro Ishiguro <kunihiro@zebra.org>
3807
3808 * bgp_fsm.c: [-p bgp_port] and [-P vty_port] works
3809
38101997-12-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3811
3812 * bgp_vty.c: new file.
3813
3814 * bgp_attr.c: add new logging system.
3815
38161997-11-23 Kunihiro Ishiguro <kunihiro@zebra.org>
3817
3818 * Change all inet_addr call into inet_aton.
3819
38201997-11-10 Kunihiro Ishiguro <kunihiro@zebra.org>
3821
3822 * bgp_radix.c: change radix_peer_delete
3823
38241997-10-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3825
3826 * bgp_aspath.c: move AS_TOKEN_??? definition from header to c source.
3827
38281997-09-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3829
3830 * bgp_dump.c (bgp_log_route): add dump_attr function
3831
38321997-09-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3833
3834 * bgp_aspath.c (aspath_test): change AS_SET brace from '[' to '{'
3835 * bgp_dump.c (bgp_log_route): change logfile format.
3836
38371997-08-19 Kunihiro Ishiguro <kunihiro@zebra.org>
3838
3839 * bgp_open.c (bgp_open): move bgp_open function from bgpd.c
3840 * bgp_attr.c (community_str2com): add community value generation
3841 * bgp_attr.h: add SAFI definition for BGP-4+
3842
38431997-08-18 Kunihiro Ishiguro <kunihiro@zebra.org>
3844
3845 * bgpd.h: add BGP_OPEN_OPT_CAP for Capabilities Optional Parameter
3846 * Makefile.in: add bgp_open.o, delete bgp_loop.o
3847 * bgp_open.c: newfile which manages BGP Open message
3848 * bgp_loop.c: this file is merged with bgp_fsm.c
3849 * bgp_radix.c (radix_add): radix_add() now return route_t instead
3850 of int
3851 (bgp_sim): now we can read update & withdraw from file
3852 * bgp_route.c: add route_free() call into route_parse etc.
3853
38541997-08-17 Kunihiro Ishiguro <kunihiro@zebra.org>
3855
3856 * bgp_radix.c: Radix code is completely rewritten. It has better
3857 memory treatment than old one.
3858
38591997-08-14 Kunihiro Ishiguro <kunihiro@zebra.org>
3860
3861 * bgp_route.c: route_alloc for route struct allocation statistics.
3862 * bgpd.c (bgp_make_update): now we cann announce MED attribute.
3863 * bgp_aspath.c (aspath_print_all): change aspath_print_all output
3864 format.
3865
38661997-08-13 Kunihiro Ishiguro <kunihiro@zebra.org>
3867
3868 * bgp_term.c (term_parse): add command : show asstat, show ashash
3869 * bgp_aspath.c: aspath_cmp bug fix
3870 (aspath_print_all): add aspath_print_all ();
3871 * bgp_peer.h: delete rlist element from struct peer.
3872
38731997-08-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3874
3875 * bgp_aspath.c: completely rewritten.
3876 * bgp_aspath.h: completely rewritten.
3877 add AsPath, AsSegment structure
3878 add AS_SET treatment
3879 change Hash codes
3880
38811997-08-09 Kunihiro Ishiguro <kunihiro@zebra.org>
3882
3883 * bgp_attr.h: add Attribute flags defines
3884 * bgp_route.c: delete rlist related functions
3885 * bgp_aspath.c (as_origin): add as_origin function
3886 (aspath_print): move from bgp_dump.c and add support of AS_SET
3887 change Hash related function names.
3888
38891997-08-08 Kunihiro Ishiguro <kunihiro@zebra.org>
3890
3891 * bgp_aspath.h: add next entry, delete rlist entry from struct aspath
3892
38931997-08-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3894
3895 * bgp_aspath.c (as_sort): add function as_sort
3896 * bgp_aspath.h: add IBGP, EBGP
3897