blob: 153b086e7dae0339ddcb173d55a3ea3ce3587d73 [file] [log] [blame]
Paul Jakma08d3d5b2007-05-07 16:38:35 +000012007-05-07 Paul Jakma <paul.jakma@sun.com>
2
3 * ospf_spf.c: (ospf_vertex_new) Dont init vertices to infinity,
4 just let 0 be a special case.
5 (ospf_spf_add_parent) 0 distance candidate vertex is special,
6 cost still to be initialised - asserting that new distance
7 is <= existing only makes sense where w already has a cost.
8 (ospf_spf_next) Infinite cost links should not be followed,
9 bar those of the root.
10
Andrew J. Schorrf0ec8322007-04-30 16:52:05 +0000112007-04-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
12
13 * ospfd.c: (ospf_network_match_iface) Comment out
14 COMPATIBILITY_MODE. Going forward, the ospf "network" command
15 will use a simple test: does the network command prefix
16 contain the connected (destination) prefix of the interface?
17
Andrew J. Schorre8a56f02007-04-21 20:46:31 +0000182007-04-21 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
19
20 * ospf_interface.c: (ospf_if_set_multicast) Fix bug: was testing
21 interface passive status improperly in light of the recent
22 'passive-interface default' patch. Now need to test
23 OSPF_IF_PASSIVE_STATUS(oi) instead of
24 OSPF_IF_PARAM(oi, passive_interface).
25
Paul Jakmab75ae992007-03-23 11:17:28 +0000262007-03-23 Paul Jakma <paul.jakma@sun.com>
27
28 * ospf_spf.c: (various) Add more debug statements.
Paul Jakma85ef7842007-03-23 11:19:08 +000029 (ospf_nexthop_calculation) Fix silly regression causing ospfd
30 to fail to calculate paths past networks not attached to root
31 vertex, introduced with bug #330 fixes.
Paul Jakmab75ae992007-03-23 11:17:28 +000032
Andrew J. Schorr56b3ea02007-03-14 20:21:43 +0000332007-03-14 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
34
Andrew J. Schorrad81f8c2007-03-14 22:05:18 +000035 * ospf_snmp.c: (ospf_snmp_neighbor_state) New function to
36 map internal quagga neighbor states to SNMP standard values.
37 (ospfNbrEntry) Call new ospf_snmp_neighbor_state function.
38
392007-03-14 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
40
Andrew J. Schorr56b3ea02007-03-14 20:21:43 +000041 * ospf_zebra.c: (ospf_zebra_add, ospf_zebra_delete) Fix bug
42 where inet_ntoa was used twice in the same debug message,
43 which doesn't work because there's a single shared buffer
44 for the returned string. The fix is to use inet_ntop.
45
Andrew J. Schorr4056a542007-02-27 13:55:46 +0000462007-02-27 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
47
48 * ospfd.c: (ospf_terminate) Exit immediately if ospf is not
49 actually running (e.g. the config file was empty). Fixes
50 bug where SIGTERM would not kill ospfd.
51
Paul Jakmabd34fb32007-02-26 17:14:48 +0000522007-02-26 Paul Jakma <paul.jakma@sun.com>
53
54 * ospf_spf.c: Fix regression introduced with bug #330 fix: The
55 cost update added to ospf_spf_add_parent only handled PtP
56 case, differing from same functionality in higher-level
57 ospf_spf_next. Regression diagnosed by Anders Pedersen,
58 mailnews+router-quagga-dev@news.cohaesio.com.
59 (ospf_vertex_new) Initialise vertices to max-cost.
60 (ospf_spf_init) Root vertex always creates with 0 cost.
61 (ospf_spf_add_parent) Remove the buggy V->W cost calculating
62 code, instead take the new distance as a parameter.
63 (ospf_nexthop_calculation) Take distance as parameter, so it
64 can be passed down to add_parent.
65 (ospf_spf_next) Dont initialise candiate vertex distance,
66 vertex_new does so already. Pass distance down to
67 nexthop_calculation (see above).
68
Paul Jakmabc20c1a2007-01-24 14:51:51 +0000692007-01-24 Paul Jakma <paul.jakma@sun.com>
70
71 * ospf_spf.c: Bug #330: Nexthop calculation sometimes may fail,
72 and it needs to indicate this result to SPF.
73 (ospf_spf_add_parent) Flush of parent list needs to be done here,
74 for simplicity.
75 (ospf_nexthop_calculation) Caller needs to know whether
76 nexthop calculation succeeded. Every return statement must
77 correctly indicate such.
78 (ospf_spf_next) Queueing/prioritisation of vertices in SPF
79 must take into account whether nexthop_calculation succeeded,
80 or SPF may fail to find best paths.
81
Andrew J. Schorre4529632006-12-12 19:18:21 +0000822006-12-12 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
83
84 * ospf_interface.c: (ospf_if_is_configured, ospf_if_lookup_by_prefix,
85 ospf_if_lookup_recv_if) Simplify logic using new CONNECTED_PREFIX
86 macro.
87 * ospf_lsa.c: (lsa_link_ptop_set) Using the new CONNECTED_PREFIX
88 macro, both options collapse into the same code.
89 * ospf_snmp.c: (ospf_snmp_if_update) Simplify logic using new
90 CONNECTED_ID macro.
91 (ospf_snmp_is_if_have_addr) Simplify logic using new CONNECTED_PREFIX
92 macro.
93 * ospf_vty.c: (show_ip_ospf_interface_sub) Use new CONNECTED_PEER macro
94 instead of testing the IFF_POINTOPOINT flag.
95 * ospfd.c: (ospf_network_match_iface) Use new CONNECTED_PEER macro
96 instead of testing with if_is_pointopoint. And add commented-out
97 code to implement alternative (in my opinion) more elegant behavior
98 that has no special-case treatment for PtP addresses.
99 (ospf_network_run) Use new CONNECTED_ID macro to simplify logic.
100
Andrew J. Schorred589c12006-12-04 18:26:37 +00001012006-12-04 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
102
103 * ospfd.c: (ospf_network_run) Remove an offending 'break' statement.
104 Previously, after creating a single ospf_interface on a given
105 network interface, the code would skip to the next interface
106 without considering other connected addresses on the interface.
107 After removing the 'break', we now consider all connected addresses.
108
Andrew J. Schorr7f643eb2006-11-30 16:17:02 +00001092006-11-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
110
111 * ospf_zebra.c: (ospf_router_id_update_zebra,
112 ospf_interface_address_add, ospf_interface_address_delete)
113 If (IS_DEBUG_OSPF (zebra, ZEBRA_INTERFACE)) is enabled, then
114 add a debug message about what Zebra is telling us.
115 (ospf_zebra_add_discard) Add a debug message matching the one
116 already in ospf_zebra_delete_discard.
117
Andrew J. Schorr43540882006-11-28 16:36:39 +00001182006-11-28 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
119
120 * ospf_vty.c: (ospf_passive_interface_default) Take additional
121 'newval' arg so we can update ospf->passive_interface_default inside
122 this function. More importantly, we now call ospf_if_set_multicast
123 on all ospf_interfaces.
124 (ospf_passive_interface, no_ospf_passive_interface) Fix bug:
125 for 'default' case, argv[0] is undefined, so we must test for
126 (argc == 0) before using argv[0]. And since
127 ospf_passive_interface_default now calls ospf_if_set_multicast as
128 needed, we can just return after calling
129 ospf_passive_interface_default.
130
Andrew J. Schorr8fb8a502006-10-24 19:04:26 +00001312006-10-24 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
132
133 * ospf_zebra.c: (ospf_redistribute_default_set) Fix bug where
134 a new value for ospf->default_originate was being ignored
135 if a previous 'default-information originate' command
136 had already been processed.
137
Paul Jakma7ffa8fa2006-10-22 20:07:53 +00001382006-10-22 Yar Tikhiy <yar@comp.chem.msu.su>
139
140 * (general) Add support for passive-interface default (with
141 minor edits by Paul Jakma).
142 * ospf_interface.h: Add OSPF_IF_PASSIVE_STATUS macro, looking
143 at configured value, or the global 'default' value, as
144 required.
145 * ospf_interface.c: (ospf_if_new_hook) Leave passive
146 unconfigured per default, allowing global 'default' to
147 take effect for unconfigured interfaces.
148 * ospf_packet.c: (various) use OSPF_IF_PASSIVE_STATUS
149 * ospf_vty.c: (ospf_passive_interface_default) new function,
150 unset passive from all interfaces if default is enabled, as
151 the per-iface settings become redundant.
152 (ospf_passive_interface_update) new func, update passive
153 setting taking global default into account.
154 ({no,}ospf_passive_interface_addr_cmd) Add support for
155 'default' variant of command.
156 (show_ip_ospf_interface_sub) Update to take global
157 default into account when printing passive status.
158 (ospf_config_write) ditto.
159 * ospfd.c: (ospf_new) set global passive-interface default.
160 * ospfd.h: (struct ospf) Add field for global
161 passive-interface.
162
Andrew J. Schorr08c83672006-09-25 13:26:14 +00001632006-09-25 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
164
165 * ospf_packet.c: (ospf_packet_dup, ospf_make_md5_digest)
166 Fix zlog_warn messages to eliminate compiler warnings.
167 (ospf_hello) Improve warning messages to show why we
168 are complaining.
169
Paul Jakmab5aeb442006-08-30 18:47:37 +00001702006-08-28 Andy Gay <andy@andynet.net>
171
172 * ospf_packet.c: (ospf_make_db_desc) Assert added with More-bit
173 fixes does not hold up with addition of Ogier DB-Exchange
174 optimisation, which can empty the db-summary list in between
175 sent DD packets. Remove assert, update More-bit always when
176 in Exchange.
177
Paul Jakma29b5a042006-08-27 08:01:20 +00001782006-08-27 J.J. Krabbendam <jkrabbendam@aimsys.nl>
179
180 * ospfd.c: (ospf_finish_final) default redistribute should be
181 unset too, fixes bug where reconfiguring ospfd completely
182 can no longer enable default redistribution.
183
Paul Jakma2518efd2006-08-27 06:49:29 +00001842006-08-25 Paul Jakma <paul.jakma@sun.com>
185
186 * (general) Bug #134. Be more robust to backward time changes,
187 use the newly added libzebra time functions.
188 In most cases: recent_time -> recent_relative_time()
189 gettimeofday -> quagga_gettime (QUAGGA_CLK_MONOTONIC, ..)
190 time -> quagga_time.
191 (ospf_make_md5_digest) time() call deliberately not changed.
192 (ospf_external_lsa_refresh) remove useless gettimeofday, LSA
193 tv_orig time was already set in ospf_lsa_new, called via
194 ospf_external_lsa_new.
195
Paul Jakmaba122e72006-08-27 06:24:34 +00001962006-08-04 Paul Jakma <paul.jakma@sun.com>
197
198 * ospf_lsdb.c: (ospf_lsdb_delete_entry) new function, consolidate
199 exact same functionality replicated in other functions.
200 (ospf_lsdb_add) Strip out code by using ospf_lsdb_delete_entry.
201 (ospf_lsdb_delete) ditto.
202 (ospf_lsdb_delete_all) ditto.
203
Paul Jakma8dd24ee2006-08-27 06:29:30 +00002042006-08-03 Paul Jakma <paul.jakma@sun.com>
205
206 * ospf_packet.c: (ospf_make_db_desc) Unset the DD More bit
207 after constructing the packet, if appropriate.
208 (ospf_db_desc_proc) Speed up Exchange, slave should raise
209 ExchangeDone earlier, as RFC mandates, by forming its reply
210 before deciding whether both sides are done, avoids a
211 needless round of empty DD packet exchanges at the end of
212 Exchange, hence speeding up ExchangeDone.
Paul Jakmaf0894cf2006-08-27 06:40:04 +0000213 Implement draft-ogier-ospf-dbex-opt DB-exchange optimisation.
Paul Jakma8dd24ee2006-08-27 06:29:30 +0000214 (ospf_db_desc) use UNSET_FLAG macro.
215
Andrew J. Schorr16700082006-07-27 22:29:06 +00002162006-07-27 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
217
218 * ospfd.c: (ospf_router_id_update) Fix and document the algorithm for
219 selecting the router ID: if there is not a statically configured ID,
220 then stick to the most recent value to avoid disruptive changes.
221 This should fix bug #288.
222
Paul Jakma1fe6ed32006-07-26 09:37:26 +00002232006-07-26 Paul Jakma <paul.jakma@sun.com>
224
225 * ospf_lsa.{c,h}: (ospf_lsa_unlock) Change to take a double pointer
226 to the LSA to be 'unlocked', so that, if the LSA is freed, the
227 callers pointer to the LSA can be NULLed out, allowing any further
228 use of that pointer to provoke a crash sooner rather than later.
229 * ospf_*.c: (general) Adjust callers of ospf_lsa_unlock to match
230 previous. Try annotate 'locking' somewhat to show which 'locks'
231 are protecting what LSA reference, if not obvious.
232 * ospf_opaque.c: (ospf_opaque_lsa_install) Trivial: remove useless
233 goto, replace with return.
234 * ospf_packet.c: (ospf_make_ls_ack) Trivial: merge two list loops,
235 the dual-loop predated the delete-safe list-loop macro.
236
Paul Jakma3fed4162006-07-25 20:44:12 +00002372006-07-25 Paul Jakma <paul.jakma@sun.com>
238
239 * ospf_neigbor.h: (struct ospf_neighbor) Add some additional
240 neighbour state statistics fields, timestamps for progressive
241 and regressive state changes, and pointer to event string
242 for the latter state change.
243 * ospf_nsm.c: (nsm_notice_state_change) Update new state changs
244 history as required.
245 * ospf_vty.c: (show_ip_ospf_neighbor_detail_sub) Print out above
246 new per-neighbour state change stats.
247
Paul Jakma539e1522006-07-11 17:49:22 +00002482006-07-10 Paul Jakma <paul.jakma@sun.com>
249
250 * ospf_nsm.c: (nsm_change_state) call nsm_clear_adj for all
251 adjacency losses, hence removing need for nsm_reset_nbr.
252 (nsm_reset_nbr) kill it, clear_adj in previous does fine.
253 (nsm_kill_nbr,nsm_start) remove nsm_reset_nbr call.
254 (ospf_nsm_event) Allow NSM function to be NULL, this along with
255 removal of nsm_reset_nbr, allows a bunch of now useless functiosn
256 to be removed.
257 Remove some useless variables.
258 (nsm_ignore) now useless, remove.
259 (nsm_bad_ls_req) ditto
260 (nsm_seq_number_mismatch) "
261 (nsm_oneway_received) "
262 (nsm_inactivity_timer) "
263 (nsm_ll_down) "
264 (NSM) replace removed action functions with NULL.
Paul Jakma3d63f382006-07-11 17:52:53 +0000265 (nsm_notice_state_changes) Move state change logging code to new
266 func to declutter nsm_change_state and ospf_nsm_event.
267 Log event with AdjChange, it's useful to know.
268 (nsm_change_state) move adjchange and snmp logging to previous.
269 (ospf_nsm_event) call nsm_notice_state_changes from here.
270 Move the debug message to entry of function, so it gets out
271 even if something goes wrong.
Paul Jakma90c33172006-07-11 17:57:25 +0000272 Record state change timestamp and event in nbr struct.
273 * ospf_neighbor.h: (struct ospf_neighbor) Add fields to record
274 timestamp of last NSM change and event.
275 * ospf_vty.c: (show_ip_ospf_neighbor_detail_sub) Print
276 last state change timestamp and event, if available.
Paul Jakma539e1522006-07-11 17:49:22 +0000277
Andrew J. Schorr13cd3dc2006-07-11 01:50:30 +00002782006-07-10 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
279
280 * ospf_packet.c: (ospf_hello) Improve NetworkMask mismatch warning
281 message to include interface name and conflicting prefix lengths.
282
Paul Jakma1f2c2742006-07-10 07:45:13 +00002832006-07-07 Paul Jakma <paul.jakma@sun.com>
284
285 * ospf_nsm.h: Add a NSM_Deleted neighbour state, to act as dummy
286 state indicating the neighbour is to be deleted.
287 * ospf_nsm.c: (general) Use the NSM_Deleted state to delete
288 neighbours, thus allowing code to be slightly more obvious
289 in its flow.
290 (nsm_timer_set) Add NSM_Deleted. Add another timer the code
291 missed.
292 (nsm_kill_nbr) No need for special case call to nsm_change_state
293 anymore.
294 Make the assert and error-handling for same case more readable
295 (Andrew Schorr)
296 Remove the call to ospf_nbr_delete, nsm_change_state can do
297 this generally now via NSM_Deleted.
298 (struct ... NSM) Add the dummy NSM_Deleted state, the 3 events
299 that can lead to nsm_kill_nbr all now transition the NBR to
300 NSM_Deleted and the general change_state function can be left
301 to do the work.
302 (ospf_nsm_event) Special casing of events and early-return can
303 be removed now.
304 On transition into Deleted, delete the nbr.
305 * ospf_dump.c: (ospf_nsm_state_msg) Add Deleted.
306
Paul Jakmaaa2737a2006-07-06 11:12:39 +00003072006-07-06 Paul Jakma <paul.jakma@sun.com>
308
309 * ospf_nsm.c: (ospf_nsm_event) LLDown event also results in nbr
310 being deleted, requires early-return too. Likely explains
311 some crash reports after interface events.
312
Paul Jakmaf7a76ab2006-07-04 13:57:49 +00003132006-07-04 Paul Jakma <paul.jakma@sun.com>
314
315 * ospf_nsm.c: (general) Various small cleanups from Andrew's
316 review of last set of patches.
317 (nsm_timer_set) Loading, Full and default can share
318 same code too.
319 (nsm_should_adj) Can just be one big OR.
320 (nsm_twoway_received) Collapse into return statement.
321
Paul Jakmad7b0fb62006-07-04 13:35:24 +00003222006-07-02 Paul Jakma <paul.jakma@sun.com>
323
324 * ospf_nsm.c: (nsm_should_adj) New function, just consolidate the
325 10.4 adjacency check from nsm_twoway_received/nsm_adj_ok.
326 (nsm_twoway_received/nsm_adj_ok) Use former.
Paul Jakmad1b1cd82006-07-04 13:50:44 +0000327 (nsm_clear_adj) clear adjacency related state for a
328 neighbour, needed for some state changes from > ExStart down
329 to ExStart or less, which need not go through nsm_reset_nbr.
330 (nsm_reset_nbr) move code to former. Should be static.
Paul Jakmaba0beb42006-07-04 13:44:19 +0000331 (ospf_nsm_event) Don't allow action functions to change
332 next_state if the NSM tables do not indicate next_state is
333 conditional, log warning if one tries - existing code
334 appears fine though.
Paul Jakmad1b1cd82006-07-04 13:50:44 +0000335 Remove long dead code.
336 Use nsm_clear_adj for state changes that take down
337 adjacencies to TwoWay/ExStart.
Paul Jakmae55dd532006-07-04 13:46:14 +0000338 (nsm_timer_set) ls_req timer should be OFF in early states.
339 Compact several identical sections.
340 Set inactivity timer to OFF for Down, for documentary
341 purposes.
Paul Jakmad1b1cd82006-07-04 13:50:44 +0000342 (nsm_kill_nbr) Oops, action function shouldn't try return
343 1 for error.
Paul Jakma5db95bc2006-07-04 13:52:29 +0000344 * ospf_lsa.c: (ospf_translated_nssa_refresh) CID #13.
Paul Jakmad7b0fb62006-07-04 13:35:24 +0000345
Andrew J. Schorr1c066bf2006-06-30 16:53:47 +00003462006-06-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
347
348 * ospf_vty.c: (show_ip_ospf_neighbor_id) Should show all instances
349 of that neighbor (since it may appear on multiple interfaces)
350 instead of bailing out after showing the first match.
351
Andrew J. Schorr76947872006-06-30 03:21:05 +00003522006-06-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
353
354 * ospf_nsm.c: (nsm_twoway_received) When deciding whether to
355 change from state Init to ExStart, the test for whether the
356 neighboring router is DR or BDR should be against the
357 local router's notion of DR/BDR, not the neighbor's view.
358
Andrew J. Schorrd7e60dd2006-06-29 20:20:52 +00003592006-06-28 Erik Muller <erikm@internap.com>
360
361 * ospfd.h: Define 2 new struct ospf config flags:
362 OSPF_LOG_ADJACENCY_CHANGES and OSPF_LOG_ADJACENCY_DETAIL
363 * ospf_nsm.c (nsm_change_state): Log adjacency changes if
364 requested.
365 * ospf_vty.c (ospf_log_adjacency_changes): New command function
366 to implement ospf subcommand "log-adjacency-changes [detail]".
367 (no_ospf_log_adjacency_changes) Turn off log-adjacency-changes.
368 (show_ip_ospf) Show whether adjacency changes are logged.
369 (ospf_config_write) Add "log-adjacency-changes [detail]" to config.
370 (ospf_vty_init) Add ospf_log_adjacency_changes and
371 no_ospf_log_adjacency_changes.
372
Paul Jakma9560fa82006-06-26 12:50:06 +00003732006-06-26 Paul Jakma <paul.jakma@sun.com>
374
375 * ospf_abr.c: (general) NSSA translate-candidate ABRs need to
376 be ASBRs, or other routers may rightfully refuse to install
377 translated type-5s LSAs. reported by dendroot@gmail.com.
378 (ospf_abr_nssa_check_status) Detect change in translator
379 state when ABR, and inc/dec redistribute count as when we
380 leave/enter the disabled state - so that translate-enabled
381 ABR properly sets ASBR bit on non-NSSA areas.
382 Run the resulting function through indent to clean it up.
383 * ospf_lsa.c: (router_lsa_flags) For purposes of ASBR bit,
384 NSSA area is same as stub area.
385
Andrew J. Schorr0ffb7092006-06-24 19:40:13 +00003862006-06-24 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
387
Andrew J. Schorr9aecfae2006-06-24 20:05:02 +0000388 * ospf_snmp.c: (ospfTrapNbrStateChange, ospfTrapIfStateChange) Improve
389 info log message to indicate why the trap is being sent.
390
3912006-06-24 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
392
Andrew J. Schorr0ffb7092006-06-24 19:40:13 +0000393 * ospf_dump.c: (config_write_debug) Fix typo to show debug ospf nsm
394 status properly (not ism status).
395
Andrew J. Schorr6e72cb62006-06-18 00:45:48 +00003962006-06-17 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
397
398 * ospf_vty.c: ({no_,}ospf_passive_interface) Replace if_lookup_by_name
399 with a call to if_get_by_name -- if the interface does not exist
400 already, it should be created. And remove the obsolete warning
401 message.
402
Paul Jakma429ac782006-06-15 18:40:49 +00004032006-06-15 Paul Jakma <paul.jakma@sun.com>
404
405 * ospf_interface.h: (struct ospf_if_info) Add reference counts
406 for multicast group memberships. Add various macros to help
407 manipulate/check membership state.
408 * ospf_interface.c: (ospf_if_set_multicast) Maintain the
409 ospf_if_info reference counts, and only actually drop
410 memberships if it hits 0, to avoid losing membership when
411 OSPF is disabled on an interface with multiple active OSPF
412 interfaces.
413 * ospf_packet.c: (ospf_{hello,read}) Use the new macros to
414 check/set
415 multicast membership.
416 * ospf_vty.c: (show_ip_ospf_interface_sub) ditto.
417
Paul Jakmaac904de2006-06-15 12:04:57 +00004182006-05-31 Paul Jakma <paul.jakma@sun.com>
419
420 * ospf_lsdb.c: (ospf_lsdb_delete) robustify against NULL arguments,
421 print warning.
422 * ospf_lsa.c: (ospf_discard_from_db) ditto.
423 (ospf_maxage_lsa_remover) Check lsa->lsdb for validity, possible
424 mitigation (but not solution) for bug #269.
425
Paul Jakma88871b12006-06-15 11:41:19 +00004262006-05-30 Paul Jakma <paul.jakma@sun.com>
427
428 * ospf_packet.c: (ospf_read) Debug message about packets
429 received on unenabled interfaces should be conditional on
430 debug being set.
431
Paul Jakmad1c65c22006-06-27 08:01:43 +00004322006-05-23 Paul Jakma <paul.jakma@sun.com>
433
434 * ospf_vty.c: (general) Replace in-place route redistribution
435 command and help strings with the new auto-generated defines
436 from lib/route_types.h
437
Paul Jakmaae128052006-05-12 23:15:30 +00004382006-05-13 Paul Jakma <paul.jakma@sun.com>
439
440 * ospf_lsa.c: (ospf_translated_nssa_refresh) fix the sanity
441 check to match the assert, small error in CID #13 fix.
442
Paul Jakma70461d72006-05-12 22:57:57 +00004432006-05-12 Paul Jakma <paul.jakma@sun.com>
444
445 * ospf_lsa.c: (ospf_lsa_action) Get rid of the ospf_lookup
446 call, which is not checked for NULL return, by stripping out
447 functionality which is never used, hence fixing Coverity CID
448 #29.
449 (struct lsa_action) remove unused member.
Paul Jakmae54e6e52006-05-12 23:11:14 +0000450 (ospf_translated_nssa_refresh) Add non-assert sanity check,
451 in case DEBUG isn't defined.
452 Debug message when no type7 exists should print the ID from
453 the type5, not the type7, fixes CID #13.
454 * ospf_interface.c: (ospf_if_exists) Fix missing NULL return
Paul Jakmae43be0e2006-05-12 23:00:06 +0000455 check on ospf_lookup, CID #27.
Paul Jakma6db3a6f2006-05-12 23:02:46 +0000456 * ospf_asbr.c: (ospf_redistribute_withdraw) remove ospf_lookup
457 call by taking the struct ospf * as argument, which the
458 caller has, fixing CID #28.
459 * ospf_asbr.h: (ospf_redistribute_withdraw) update declaration
460 * ospf_zebra.c: (ospf_redistribute_unset) update call to
461 ospf_redistribute_withdraw to match.
Paul Jakmabfd7c7d2006-05-12 23:04:45 +0000462 * ospf_ia.c: (ospf_update_router_route) ospf->backbone could be
463 NULL when passed to ospf_find_asbr_route_through_area,
464 check for NULL first, CID #14.
Paul Jakmadeb15612006-05-12 23:07:27 +0000465 * ospf_ism.c: (ism_change_state) NULL check on oi->area is
466 useless, it's always valid. Only possibility where it
467 couldn't be is if there is a race between abr_task and
468 cleaning up oi's, in which case a NULL check here isn't going
469 to do anything. Fixes CID #15.
Paul Jakma70461d72006-05-12 22:57:57 +0000470
Paul Jakmacac3b5c2006-05-11 13:31:11 +00004712006-05-11 Paul Jakma <paul.jakma@sun.com>
472
473 * ospf_vty.c: (general) Audit ospf_lookup calls in commands,
474 ensure check for NULL result, make vty messages consistent.
475 (show_ip_ospf_interface) Missing NULL check on ospf_lookup
476 result, fixes Coverity CID #70.
Paul Jakma1a8ec2b2006-05-11 13:34:08 +0000477 (no_ospf_area_filter_list) Check NULL result from
478 ospf_area_lookup_by_area_id, fixes Coverity CID #69
Paul Jakma894f8b62006-05-12 22:50:40 +0000479 * ospf_route.c: (ospf_route_delete_same_ext) Fix deref before
480 NULL check by moving into check-protected block, fix CID #49.
Paul Jakma214a4452006-05-12 22:51:49 +0000481 * ospf_abr.c: (ospf_area_range_cost_set) Shouldn't create a new
482 range, should just lookup to see if one exists, the new range
483 is just leaked. Fixes CID #46.
Paul Jakma4021b602006-05-12 22:55:41 +0000484 * ospf_lsa.c: (ospf_default_originate_timer) Let the thread
485 take (struct ospf *) as thread argument, rather than (struct
486 ospf *)->default_originate, thus avoiding having to call
487 ospf_lookup.
488 * ospf_zebra.c: (ospf_redistribute_default_set) change setup
489 of ospf_default_originate_timer thread to match.
490 * ospfd.c: (ospf_router_id_update) ditto.
Paul Jakmacac3b5c2006-05-11 13:31:11 +0000491
Paul Jakma9c27ef92006-05-04 07:32:57 +00004922006-04-24 Paul Jakma <paul.jakma@sun.com>
493
494 * (general) More Virtual-link fixes, again with much help in
495 testing / debug from Juergen Kammer. Primarily in SPF.
496 * ospf_spf.h: Add guard. ospf_interface.h will include this
497 header.
498 * ospf_interface.h: Modify ospf_vl_lookup definition to take
499 struct ospf as argument, so as to allow for NULL area
500 argument.
501 (struct ospf_vl_data) Remove out_oi, instead add a struct
502 vertex_nexthop, to use as initial nexthop for backbone paths
503 through a vlink.
504 * ospf_interface.c: (ospf_vl_lookup) Modified to allow
505 NULL area to be passed to indicate "any" (first) area.
506 Add extra debug.
507 (ospf_vl_set_params) vl_oi -> nexthop. Add extra debug.
508 (ospf_vl_up_check) Fix debug, inet_ntoa returns a static
509 buffer..
510 * ospf_route.c: (ospf_intra_add_router) Vlinks dont go through
511 backbone, don't bother checking.
512 * ospf_spf.c: (static struct list vertex_list) Record vertices
513 that will need to be freed.
514 (cmp) Order network before router vertices, as required,
515 wasn't implemented.
516 (vertex_nexthop_free) Mild additional robustness check.
517 (vertex_parent_free) Take void argument, as this function
518 is passed as list deconstructor for vertex parent list.
519 (ospf_vertex_new) More debug. Set deconstructor for parent
520 list. Track allocated vertices on the vertex_list.
521 (ospf_vertex_free) Get rid of the tricky recursive cleanup of
522 vertices. Now frees only the given vertex.
523 (ospf_vertex_add_parent) Fix assert.
524 (ospf_nexthop_calculation) Fix calculation of nexthop for
525 VLink vertices, lookup the vl_data and use its previously
526 recorded nexthop information.
527 (ospf_spf_calculate) Vertices are freed simply by deleting
528 vertex_list nodes and letting ospf_vertex_free as deconstructor
529 work per-node.
530 (ospf_spf_calculate_timer) Trivial optimisation, leave
531 backbone SPF calculation till last to reduce SPF churn on
532 VLink updates.
533 * ospf_vty.c: (ospf_find_vl_data) update call to ospf_vl_lookup
534 (no_ospf_area_vlink_cmd) ditto.
535 (show_ip_ospf_interface_sub) For Vlinks, the peer address is
536 more interesting than the output interface.
537
Paul Jakma478aab92006-04-03 21:25:32 +00005382006-04-03 Paul Jakma <paul.jakma@sun.com>
539
540 * (general) Fix issues with handling of Vlinks and entries
541 in the nbrs route-table which were highlighted by the
542 nsm/nbr_self fixes from bug #234. Many thanks to Juergen
543 Kammer for his help and efforts in testing out debug patches to
544 pinpoint the issue.
545 * ospf_interface.c: (ospf_vl_new) Add nbr_self for Vlink.
546 * ospf_neighbor.c: (ospf_nbr_key) new static function, helper
547 to create key in nbrs table for a given nbr.
548 (ospf_nbr_delete) Use ospf_nbr_key. Add an assert() to
549 document an expected state.
550 (ospf_nbr_add_self) Ditto.
551 (ospf_nbr_lookup_by_addr) Add an assert.
552 * ospf_nsm.c: (nsm_kill_nbr) Can never kill the nbr_self
553 psuedo-neighbour.
554
Paul Jakma075c2012006-03-30 14:34:31 +00005552006-03-27 Paul Jakma <paul.jakma@sun.com>
556
557 * ospf_lsa.c: (ospf_lsa_checksum) Add an explicit cast to avoid
558 the ambiguities of ANSI and C99 C with respect to type
559 conversion. Detailed problem report and test case with
560 example data supplied by Dmitry Ivanov <dimss@telecentrs.lv>.
561
Paul Jakma1a8ee0e2006-03-30 14:20:00 +00005622006-03-25 Paul Jakma <paul.jakma@sun.com>
563
564 * ospf_interface.c: (ospf_if_lookup_recv_if) Ignore loopbacks,
565 we can never ever receive packets on those. Should fix
566 case where CARP is run with address in same subnet as real
567 interface. Problem report and diagnosis thanks to:
568 Landon Fuller <landonf@opendarwin.org>.
569 However, ospf_read() still can't deal deterministically with
570 multiple interfaces in same subnet.
571
Paul Jakmac2b478d2006-03-30 14:16:11 +00005722006-03-23 Steve Lawson <steve.lawson@aheadcomusa.com>
573
574 * ospf_lsa.c: (ospf_lsa_install) Fix incorrect byte-order
575 conversion of OSPF_MAX_SEQUENCE_NUMBER
576
paule8e19462006-01-19 20:16:55 +00005772006-01-19 Paul Jakma <paul.jakma@sun.com>
578
579 * (general) various miscellaneous compiler warning fixes.
580 Remove redundant break statements from switch clauses
581 which return.
582 return from main, not exit, cause it annoys SOS.
583 Remove stray semi-colons which cause empty-statement
584 warnings.
585
paul779adb02006-01-18 15:07:38 +00005862006-01-18 Juergen Kammer <j.kammer@eurodata.de>
587
588 * ospf_lsa.c: (ospf_router_lsa_new) dont take reference to the
589 stream data until it is constructed, data reference is
590 volatile due to the potential resize in link_info_set
591
5922006-01-18 Paul Jakma <paul.jakma@sun.com>
593
594 * ospf_lsa.c: (link_info_set) Resize the stream if required and
595 possible. Return number of links added.
596 (lsa_link_*_set) use return value from previous.
597 * ospf_lsa.h: Add OSPF_ROUTER_LSA_LINK_SIZE define.
598
paulc6371712006-01-17 17:49:53 +00005992006-01-17 Paul Jakma <paul.jakma@sun.com>
600
601 * ospf_packet.c: (ospf_verify_header) print out the types
602 involved if there's a mismatch.
603 * ospf_zebra.c: (ospf_zebra_add) Adjust to new zserv format.
604
paul818e56c2006-01-10 23:27:05 +00006052006-01-10 Len Sorensen <lennartsorensen@ruggedcom.com>
606
607 * (general) Bug #234, see also [quagga-dev 3902].
608 Fix problem with nbr_self not being properly reinitialised
609 when an interface comes up, after having been down.
paul1a643f82006-01-11 01:08:19 +0000610 Some re-arrangement done by Paul Jakma, any bugs introduced
611 on top of Len's suggested changes are his.
paul818e56c2006-01-10 23:27:05 +0000612 * ospf_neighbor.c: (ospf_nbr_add_self) centralise
613 initialisation of nbr_self parameters here.
614 * ospf_interface.c: (ospf_if_new) deleting initialisation of
615 parameters of nbr_self, just rely on call to
616 ospf_nbr_add_self.
617 (ospf_if_cleanup) ditto.
618 * ospfd.c: (ospf_network_run) ditto.
619
paul98429f62006-01-10 22:11:54 +00006202006-01-10 Juris Kalnins <juris@mt.lv>
621
622 * ospf_zebra.c: (ospf_interface_address_delete) fix rare leak of
623 struct connected in an error case.
paul818e56c2006-01-10 23:27:05 +0000624 * ospf_packet.c: (ospf_make_md5_digest) fix odd, if not
625 undefined effect, assignment of an increment expression.
paul98429f62006-01-10 22:11:54 +0000626
paul86752842006-01-10 20:34:46 +00006272006-01-10 Paul Jakma <paul.jakma@sun.com>
628
629 * ospfd.c: (ospf_network_run) checking to see if router-id
630 is set should be on ospf->router_id, not router_id_static.
631 This was causing ospfd to not start if router-id had not
632 been configured statically.
633 (ospf_if_update) ditto.
paulc42c1772006-01-10 20:36:49 +0000634 * ospf_vty.c: (config_write_ospf_distribute) trim down
635 redundant strings.
paul86752842006-01-10 20:34:46 +0000636
paul00c290e2005-11-26 09:21:43 +00006372005-11-26 Paul Jakma <paul.jakma@sun.com>
638
639 * ospf_api.c: (struct opaque_lsa) change from gcc zero-length
640 array to C99 incomplete type array.
paulc9c93d52005-11-26 13:31:11 +0000641 * (general) s/graceful/deferred/ in all files, the former term
642 is confusing wrt OSPF Graceful-Restart.
643 * ospfd.c: (ospf_deferred_shutdown_check) dont return
644 a function which returns void. SOS complains about this.
645 (ospf_finish)
paul00c290e2005-11-26 09:21:43 +0000646
paulb29800a2005-11-20 14:50:45 +00006472005-11-20 Paul Jakma <paul.jakma@sun.com>
648
649 * ospfd.h: remove the OSPF_ROUTER_ID_UPDATE_DELAY define
650 (struct ospf) remove the router_id timer thread.
651 remove export of ospf_router_id_update_timer.
652 * ospfd.c: (ospf_router_id_update) call ospf_if_update to
653 poke interfaces into action after ID has been configured.
654 (ospf_router_id_update_timer) removed.
655 (ospf_finish_final) t_router_id_update timer is gone.
656 (ospf_network_run) router-id update timer gone.
657 call ospf_router_id_update directly if ID not configured.
658 In the per-iface loop, don't ospf_if_up interfaces if
659 ID is still not configured. The update function will call
660 ospf_if_update anyway.
661 (ospf_if_update) ID update timer is gone. Just return if no
662 ID is set.
663 * ospf_vty.c: (ospf_router_id) call ospf_router_id_update, no
664 timer needed.
665 * ospf_zebra.c: (ospf_router_id_update_zebra) call
666 ospf_router_id_update directly, not via timer.
paulc24d6022005-11-20 14:54:12 +0000667 * ospf_abr.c: (ospf_abr_announce_network_to_area) check
668 returned LSA of ospf_summary_lsa_refresh and print warning if
669 it failed.
670 (ospf_abr_announce_network_to_area) similar
671 (ospf_abr_announce_rtr_to_area) similar
672 * ospf_lsa.c: (ospf_router_lsa_new) check LSA returned is valid.
673 (ospf_router_lsa_originate) similar
674 (ospf_router_lsa_refresh, ospf_network_lsa_new) similar
675 (ospf_summary_lsa_new) Check ID is valid.
676 (ospf_summary_lsa_originate) ditto, and check returned LSA from
677 previous function is !NULL.
678 (ospf_summary_lsa_refresh) check ospf_summary_lsa_new return
679 is !NULL.
680 (ospf_summary_asbr_lsa_new) ID valid check.
681 (ospf_summary_asbr_lsa_originate) similar.
paulb29800a2005-11-20 14:50:45 +0000682
ajs70cd3472005-11-16 19:33:22 +00006832005-11-16 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
684
ajs649654a2005-11-16 20:17:52 +0000685 * ospf_dump.h: Define OSPF_TIME_DUMP_SIZE as appropriate buffer size
686 for use with ospf_timer_dump and ospf_timeval_dump.
687 * ospf_vty.c: Change all buffer sizes used with ospf_timer_dump and
688 ospf_timeval_dump to have size OSPF_TIME_DUMP_SIZE.
689 (show_ip_ospf_interface_sub) Fix possible buffer overflow in
690 call to ospf_timer_dump.
691
6922005-11-16 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
693
ajs70cd3472005-11-16 19:33:22 +0000694 * ospf_ism.h: (OSPF_ISM_TIMER_OFF) Improve macro syntax by enclosing
695 in 'do {...} while(0)'.
696
paul31a59762005-11-14 11:11:11 +00006972005-11-14 Paul Jakma <paul.jakma@sun.com>
698
699 * ospfd.c: (ospf_new) stub-shutdown should just default to
700 unconfigured, too strange otherwise.
701 (ospf_finish_final) t_opaque_lsa_self TIMER_OFF should be
702 preprocessor conditional on HAVE_OPAQUE_LSA.
703 * ospfd.h: (struct ospf) remove the SHUTDOWN_DEFAULT define.
704 no longer used, plus it wasn't in range that the command
705 accepted.
706 * ospf_zebra.h: Depends on vty.h, include it.
707
paul58e1bef2005-11-11 12:10:03 +00007082005-11-11 Paul Jakma <paul.jakma@sun.com>
709
710 * ospf_spf.c: (ospf_canonical_nexthops_free) Free only
711 the nexthops pointing to the root vertex. We may visit a
712 vertex twice or the vertex may have some inherited nexthops,
713 if we free other nexthops we could crash.
714
paulc8c15212005-11-04 12:31:39 +00007152005-11-04 Paul Jakma <paul.jakma@sun.com>
716
717 * ospf_{dump,spf,vty}.c: Oops, use the internal tv_sub
718 function rather than unportable timersub.
719
paul484315f2005-11-03 09:08:29 +00007202005-11-03 Paul Jakma <paul.jakma@sun.com>
721
722 * ospf_apiserver.c: (apiserver_sync_callback) stray semi-colon
723 * ospf_packet.c: include checksum.h, remove the in_cksum extern
724 * prototypes.
725 * ospf_te.h: Add braces, quell warning.
paul6d452762005-11-03 11:15:44 +0000726 * ospf_packet.c: Change level of some warnings to
727 informational.
paulc8c15212005-11-04 12:31:39 +0000728
paul88d6cf32005-10-29 12:50:09 +00007292005-10-29 Paul Jakma <paul.jakma@sun.com>
730
731 * (general) RFC3137 stub-router support
732 * ospfd.h: Add OSPF_OUTPUT_COST_INFINITE define.
733 (struct ospf_master) Add a OSPF_MASTER_SHUTDOWN flag for
734 options, to allow shutdown to distinguish between complete
735 shutdown and shutdown of a subset of ospf instances.
736 (struct ospf)
737 Add stub_router_{startup,shutdown_}time, configuration of startup
738 and shutdown time for stub-router.
739 Add t_graceful_shutdown struct thread, timer for graceful
740 shutdown, if needed.
741 (struct ospf_area) Add stub_router_state - run time state of
742 stub-router for an area. Add flags for ADMIN, IS and WAS
743 states.
744 Add t_stub_router, timer thread to resend router-lsa for an
745 area.
746 * ospf_lsa.c: (ospf_link_cost) new simple function to spit out
747 either the given lnks cost or infinite cost if stub-router is
748 in effect.
749 (lsa_link_{ptop,broadcast,virtuallink,ptomp}_set) use
750 previous function for transit-links.
751 (ospf_stub_router_timer) timer thread for end of startup stub
752 router. Change state as required for the area and setup
753 re-origination of router-lsa.
754 (ospf_stub_router_check) Check/do whether stub-router should be
755 enabled, and whether it requires timer to be setup.
756 (ospf_router_lsa_new) call previous function at top.
757 (ospf_router_lsa_originate) no external callers, made static.
758 * ospf_lsa.h: (ospf_router_lsa_originate) removed.
759 * ospf_main.c: (sigint) make static.
760 remove call to exit, as ospf_terminate now deals with
761 exiting.
762 * ospf_route.c: (ospf_terminate) removed, now in ospfd.c.
763 * ospf_vty.c: (show_ip_ospf_area) print out state of
764 stub-router, if active.
765 (show_ip_ospf) print out configuration of stub-router
766 support, and details of graceful-shutdown if the timer is
767 active.
768 ((no)?ospf_max_metric_router_lsa_{admin,startup,shutdown}) new
769 commands to (de-)?configure stub-router support.
770 (config_write_stub_router) write out config of stub-router.
771 (ospf_config_write) call previous.
772 (ospf_vty_init) install the new stub-router commands.
773 * ospfd.c: various functions made static.
774 (ospf_new) Set defaults for stub-router. Graceful shutdown
775 is made to default on, just to be adventerous.
776 (ospf_graceful_shutdown_finish) new function, final part of
777 shutdown.
778 (ospf_graceful_shutdown_timer) timer thread wrapper for
779 graceful-shutdown.
780 (ospf_graceful_shutdown_check) check whether to setup timer
781 for shutdown or proceed directly to final shutdown.
782 (ospf_terminate) moved here from ospf_route.c, call
783 ospf_finish for each instance.
784 (ospf_finish) renamed to ospf_finish_final and made static.
785 (ospf_finish) new function, exported wrapper around
786 ospf_graceful_shutdown_check.
787 (ospf_finish_final) complete shutdown of an instance.
788 Add missing TIMER_OFF's of two timer threads.
789 (ospf_area_free) opaque self lsa timer should be turned off.
790
paulb8ad39d2005-10-23 15:23:05 +00007912005-10-23 Paul Jakma <paul.jakma@sun.com>
792
paule029d442005-10-23 15:26:24 +0000793 * ospf_apiserver.c: (ospf_apiserver_term) This function should
794 not have side-effects (eg segv) if no apiserver instances are
795 active, ie be robust.
paulb8ad39d2005-10-23 15:23:05 +0000796 * ospf_vty.c: (show_ip_ospf) fix display of SPF timer if it
797 has not yet been run.
798
paulf9ad9372005-10-21 00:45:17 +00007992005-10-21 Paul Jakma <paul.jakma@sun.com>
800
paulea4ffc92005-10-21 20:04:41 +0000801 * ospf_dump.c: (ospf_timeval_dump) fix ms adjustment, thanks to
802 Andrew Schorr.
803 * ospf_vty.c: (ospf_config_write) fix write out of spf timers
804 configuration.
805
8062005-10-21 Paul Jakma <paul.jakma@sun.com>
807
pauld24f6e22005-10-21 09:23:12 +0000808 * (general) SPF millisecond resolution timer with adaptive,
809 linear back-off holdtime. Prettification of ospf_timer_dump.
810 * ospf_dump.c: (ospf_timeval_dump) new function. The guts of
811 ospf_timer_dump, but made to be more dynamic in printing out
812 the relative timeval, sliding the precision printed out
813 according to the value.
814 (ospf_timer_dump) guts moved to ospf_timeval_dump.
815 * ospf_dump.h: export ospf_timeval_dump.
816 * ospf_flood.c: (ospf_flood) remove gettimeofday, use
817 the libzebra exported recent_time instead, as it's not
818 terribly critical to have time exactly right - the dropped
819 LSA will be retransmited to us if we don't ACK it.
820 * ospf_packet.c: (ospf_ls_upd_timer) Ditto, but here we're
821 not transmitting, just putting LSA back on update transmit list.
822 * ospfd.h: delay and holdtimes should be unsigned.
823 Add spf_max_holdtime and spf_hold_multiplier.
824 Update default defines for delay and hold time to be in msec.
825 (struct ospf) change the SPF timestamp to a struct timeval.
826 Remove ospf_timers_spf_(un)?set.
827 * ospfd.c: (ospf_timers_spf_{set,unset}) removed.
828 (ospf_new) initialise spf_max_holdtime and spf_hold_multiplier
829 * ospf_spf.c: (ospf_spf_calculate) SPF timestamp is a timeval
830 now, update with gettimeofday.
831 (ospf_spf_calculate_schedule) Change SPF timers to millisecond
832 resolution.
833 Make the holdtime be adaptive, with a linear increase in
834 holdtime ever consecutive SPF run which occurs within holdtime
835 of previous SPF, bounded by spf_max_holdtime.
836 * ospf_vty.c: Update spf timers commands.
837 (ospf_timers_spf_set) trivial helper.
838 (ospf_timers_throttle_spf_cmd) new command to set SPF delay,
839 initial hold and max hold times with millisecond resolution.
840 (ospf_timers_spf_cmd) Deprecated. Accept the old values,
841 convert to msec, truncate to new limits.
842 (no_ospf_timers_throttle_spf_cmd) set timers to defaults.
843 (no_ospf_timers_spf_cmd) deprecated form, same as previous.
844 (show_ip_ospf_cmd) Display SPF parameters and times.
845 (show_ip_ospf_neighbour_header) Centralise the 'sh ip os ne'
846 header.
847 (show_ip_ospf_neighbor_sub) Fix the field widths. Get rid of
848 the multiple spaces which were making the lines even longer.
849 (show_ip_ospf_neighbor_cmd) Use show_ip_ospf_neighbour_header
850 (show_ip_ospf_neighbor_all_cmd) ditto and fix the field
851 widths for NBMA neighbours.
852 (show_ip_ospf_neighbor_int) Use header function.
853 (show_ip_ospf_nbr_nbma_detail_sub) use sizeof for timebuf,
854 local array - safer.
855 (show_ip_ospf_neighbor_detail_sub) ditto
856 (ospf_vty_init) install the new SPF throttle timer commands.
857
8582005-10-21 Paul Jakma <paul.jakma@sun.com>
859
paulf9ad9372005-10-21 00:45:17 +0000860 * (general) OSPF fast, sub-second hello and 1s dead-interval
861 support.
862 * ospf_dump.c: (ospf_timer_dump) Print out milliseconds too.
863 Callers typically specify a length of 9, so most see
864 millisecs unless they specify the additional length.
865 * ospf_interface.h: (struct ospf_interface) new interface param,
866 fast_hello.
867 * ospf_interface.c: (ospf_if_table_lookup) add brackets,
868 gcc warning fix.
869 (ospf_new_if_params) Initialise fast_hello param.
870 (ospf_free_if_params) Check whether fast_hello is configured.
871 (ospf_if_new_hook) set fast_hello to default.
872 * ospf_ism.h: Wrap OSPF_ISM_TIMER_ON inside do {} while (0) to
873 prevent funny side-effects from its if statement when this
874 macro is used conditionally by other macros.
875 (OSPF_ISM_TIMER_MSEC_ON) new macro, set in milliseconds.
876 (OSPF_HELLO_TIMER_ON) new macro to set hello timer according
877 to whether fast_hello is set.
878 * ospf_ism.c: Update all setting of the hello timer to use
879 either OSPF_ISM_TIMER_MSEC_ON or OSPF_HELLO_TIMER_ON. The
880 former is used when hello is to be sent immediately.
881 * ospf_nsm.c: ditto
882 * ospf_packet.c: (ospf_hello) hello-interval is not checked
883 for mismatch if fast_hello is set.
884 (ospf_read) Annoying nit, fix "no ospf_interface" to be debug
885 rather than a warning, as it can be perfectly normal to
886 receive packets when logical subnets are used.
887 (ospf_make_hello) Set hello-interval to 0 if fast-hellos are
888 configured.
889 * ospf_vty.c: (ospf_auto_cost_reference_bandwidth) annoying
890 nit, don't vty_out if this command is given, it gets tired
891 quick.
892 (show_ip_ospf_interface_sub) Print the hello-interval
893 according to whether fast-hello is set or not.
894 Print the extra 5 millisec characters from (ospf_timer_dump)
895 if fast-hello is configured.
896 (ospf_vty_dead_interval_set) new function, common to all
897 forms of dead-interval command, to set dead-interval and
898 fast-hello correctly. If a dead-interval is given, unset
899 fast-hello, else if a hello-multiplier is set, set
900 dead-interval to 1 and fast-hello to given multiplier.
901 (ip_ospf_dead_interval_addr_cmd) use
902 ospf_vty_dead_interval_set().
903 (ip_ospf_dead_interval_minimal_addr_cmd) ditto.
904 (no_ip_ospf_dead_interval) Unset fast-hello.
905 (no_ip_ospf_hello_interval) Bug-fix, unset of hello-interval
906 should set it to OSPF_HELLO_INTERVAL_DEFAULT, not
907 OSPF_ROUTER_DEAD_INTERVAL_DEFAULT.
908 (config_write_interface) Write out fast-hello.
909 (ospf_config_write) Write a comment about
910 "auto-cost reference-bandwidth" having to be equal on all
911 routers. Hopefully just as noticeable as old practice of
912 writing to vty, but less annoying.
913 (ospf_vty_if_init) install the two new dead-interval
914 commands.
915 * ospfd.h: Add defines for OSPF_ROUTER_DEAD_INTERVAL_MINIMAL
916 and OSPF_FAST_HELLO_DEFAULT.
917
pauleb3da6d2005-10-18 04:20:33 +00009182005-10-18 Paul Jakma <paul.jakma@sun.com>
919
920 * (general) SPF memory management cleanup and fix for rare
921 double-free bug.
922 * ospf_spf.h: (struct vertex_parent) New struct to hold parent
923 specific data, eg the backlink and the parent vertex pointer,
924 and point to the appropriate general struct vertex_nexthop.
925 (struct vertex_nexthop) remove parent vertex pointer, so
926 this struct can be shared across vertices.
927 (struct vertex) rename list child to list children. Remove
928 list of nexthops, replace with list of vertex_parents.
929 * ospf_spf.c: (update_stat) trivial, remove cast from void *.
930 (vertex_nexthop_new) remove init of parent - field is gone
931 from struct vertex_nexthop.
932 (ospf_canonical_nexthops_free) Remove the canonical
933 vertex_nexthop memory objects. These are the vertex_nexthops
934 attached to the first level of router vertices from the root.
935 (vertex_parent_new) new function, create a vertex_parent.
936 (vertex_parent_free) ditto, but free it.
937 (ospf_vertex_new) Update to match changes to struct vertex.
938 (ospf_vertex_free) Recursively free a struct vertex and its
939 children. The parent list is used as a reference count.
940 vertex_nexthops must be free seperately, if required.
941 (ospf_vertex_dump) update to match struct vertex changes.
942 Print out backlink of parents too.
943 (ospf_vertex_add_parent) ditto.
944 (ospf_lsa_has_link) update comment.
945 (ospf_nexthop_add_unique) removed, not needed anymore.
946 (ospf_nexthop_merge) ditto.
947 (ospf_spf_consider_nexthop) renamed to ospf_spf_add_parent.
948 Simplified to just create vertex_parent and add it.
949 (ospf_spf_flush_parents) new function, flush out the parent
950 list.
951 (ospf_nexthop_calculation) Take the relevant route_lsa_link
952 as an argument, which simplifies things and removes the need
953 for the hack in ospf_nexthop_add_unique - ospf_spf_next
954 already knew exactly which link the cost calculated was for.
955 Update to match struct vertex changes too.
956 (ospf_spf_next) Don't create a vertex for W unnecessarily, if
957 it's there's a vertex already created for W, use it, and
958 hence there's no need to free it either.
959 Update some manipulation/comparisons of distance to match.
960 Flush the parent list if a lower cost path is found.
961 (ospf_spf_route_free) unused, removed.
962 (ospf_spf_dump) match the struct vertex changes, and dump the
963 ifname if possible.
964 (ospf_spf_calculate) At end of SPF, free the canonical nexthops
965 and call ospf_vertex_free on the root vertex to free the
966 entire tree.
967 * ospf_interface.c: (ospf_vl_set_params) match struct vertex
968 changes.
969 * ospf_route.c: (ospf_intra_route_add) ditto
970 (ospf_route_copy_nexthops_from_vertex) ditto
971
paul36238142005-10-11 04:12:54 +00009722005-10-11 Paul Jakma <paul.jakma@sun.com>
973
974 * ospf_api.c: sign warnings.
975 * ospf_apiserver.c: sign warning and convert all the struct
976 in_addr initialisations so as not to make assumptions about
977 how this struct is organised, initialise the s_addr member
978 explicitely.
979 * ospf_packet.c: Add const qualifier to auth_key.
980
vincent77df1f72005-10-06 07:46:22 +00009812005-10-06 Alain Ritoux <alain.ritoux@6wind.com>
982
983 * ospf_snmp.c: Avoid mixing interface and ospf_interface objects
984 which now allows snmpwalk to work with ospfIfTable and
985 also with ospfIfMetricTable
986
ajsf52d13c2005-10-01 17:38:06 +00009872005-10-01 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
988
989 * ospf_dump.c: Remove local hard-coded table ospf_redistributed_proto.
990 (ospf_redist_string) New function implemented using new library
991 function zebra_route_string(). Note that there are a few differences
992 in the output that will result: the new function returns strings
993 that are lower-case, whereas the old table was mixed case. Also,
994 the old table mapped ZEBRA_ROUTE_OSPF6 to "OSPFv3", whereas the
995 new function returns "ospf6".
996 * ospfd.h: Remove extern struct message ospf_redistributed_proto[],
997 and add extern const char *ospf_redist_string(u_int route_type)
998 instead.
999 * ospf_asbr.c: (ospf_external_info_add) In two messages, use
1000 ospf_redist_string instead of LOOKUP(ospf_redistributed_proto).
1001 * ospf_vty.c: Remove local hard-coded table distribute_str.
1002 (config_write_ospf_redistribute,config_write_ospf_distribute): Use
1003 new library function zebra_route_string() instead of distribute_str[].
1004 * ospf_zebra.c: (ospf_redistribute_set,ospf_redistribute_unset,
1005 ospf_redistribute_default_set,ospf_redistribute_check)
1006 In debug messages, use ospf_redist_string() instead of
1007 LOOKUP(ospf_redistributed_proto).
1008
jardin6638c1a2005-10-01 00:08:54 +000010092005-09-30 Vincent Jardin <vincent.jardin@6wind.com>
1010
1011 * ospf_dump.c, ospf_ia.c, ospf_spf.c, ospf_ase.c:
1012 remove unused DEBUG
1013
vincentba682532005-09-29 13:52:57 +000010142005-09-29 Alain Ritoux <alain.ritoux@6wind.com>
1015
vincent5e4914c2005-09-29 16:34:30 +00001016 * ospf_ism.c: generate SNMP traps on Interface state change
1017 * ospf_nsm.c: generate SNMP traps on Neighbour state change
1018 * ospf_snmp.[ch]: support for SNMP traps for interface and neighbours.
1019
10202005-09-29 Alain Ritoux <alain.ritoux@6wind.com>
1021
vincentba682532005-09-29 13:52:57 +00001022 * ospf_vty.c: forece default route LSA to be re_issued whenever
1023 cost is changed ( [no] ip ospf area XXX default-cost YYY)
1024 Support ignore-mtu option
1025 * ospfd.h: define OSPF_MTU_IGNORE_DEFAULT
1026 * ospf_packet.c: support ignore-mtu option
1027 * ospf_interface.h: field added for skipping MTU check
1028 * ospf_interface.c: fix memory leak in ospf_crypt_key_delete()
1029 Set mtu_ignore field to default value
1030 * ospf_abr.[ch]: export ospf_abr_announce_network_to_area()
1031 * ospf_ism.h: add MACRO to convert internal ISM status into SNMP
1032 correct values
1033 * ospf_snmp.c: add sanity check on LSA type in lsdb_lookup_next()
1034 convert OSPFIFSTATE internal status into SNMP values
1035
vincentc1a03d42005-09-28 15:47:44 +000010362005-09-28 Alain Ritoux <alain.ritoux@6wind.com>
1037
1038 * ospf_packet.c: use new md5 API
1039
ajs5339cfd2005-09-19 13:28:05 +000010402005-09-19 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1041
1042 * ospf_lsa.h: (ospf_external_lsa_flush) Comment out the 5th argument
1043 (nexthop) since it is not used in the function (except inside
1044 some commented-out code).
1045 * ospf_lsa.c: (ospf_external_lsa_flush,ospf_external_lsa_refresh)
1046 Comment out the 5th argument to ospf_external_lsa_flush.
1047 * ospf_asbr.c: (ospf_redistribute_withdraw) Comment out 5th arg
1048 to ospf_external_lsa_flush.
1049 * ospf_vty.c: (no_ospf_default_information_originate) Eliminate 5th
1050 uninitialized nexthop arg to ospf_external_lsa_flush.
1051 * ospf_zebra.c: (ospf_zebra_read_ipv4) Comment out 5th arg
1052 to ospf_external_lsa_flush.
1053 * ospfd.c: (ospf_network_set) Comment out 5th arg
1054 to ospf_external_lsa_flush.
1055
ajse6a0bf92005-09-17 18:53:38 +000010562005-09-17 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1057
1058 * ospf_opaque.c:
1059 (ospf_opaque_lsa_refresh_schedule,ospf_opaque_lsa_flush_schedule)
1060 No need to call ospf_lookup(), just use lsa0->area->ospf instead.
1061
hassobb5b7552005-08-21 20:01:15 +000010622005-08-21 Hasso Tepper <hasso at quagga.net>
1063
1064 * ospf_vty.c: Make "show ip ospf neighbor xxx" commands work.
1065 Interface should be specified by name now.
1066
hasso54bedb52005-08-17 13:31:47 +000010672005-08-17 Hasso Tepper <hasso at quagga.net>
1068
1069 * ospf_vty.c: Check carefully if interface exists before trying to
1070 print info about it.
1071
hasso01018ce2005-08-05 07:40:15 +000010722005-08-05 Hasso Tepper <hasso at quagga.net>
1073
1074 * ospf_zebra.c: Don't assert/stop before type == ZEBRA_ROUTE_MAX if
1075 dealing with routemaps. There is ospf->route_map[ZEBRA_ROUTE_MAX]
1076 for default-information.
1077
paulc8987752005-07-26 06:07:22 +000010782005-07-26 Paul Jakma <paul.jakma@sun.com>
1079
1080 * ospf_abr.c: (ospf_abr_announce_network_to_area) SET_FLAG
1081 should be on lsa not old, which may be freed for one thing,
1082 obviously.
1083
pauld57834f2005-07-12 20:04:22 +000010842005-07-12 Paul Jakma <paul.jakma@sun.com>
1085
1086 * ospfd.h: add OSPF_ABR_DEFAULT for convenience, make
1087 OSPF_ABR_CISCO be the default ABR type.
1088 * ospfd.c: (ospf_new) initialise abr_type to OSPF_ABR_DEFAULT
1089 * ospf_vty.c: (no_ospf_abr_type_cmd) add standard as a negatable
1090 abr_type. default abr_type should be OSPF_ABR_DEFAULT.
1091 (ospf_config_write) test whether default abr_type against
1092 OSPF_ABR_DEFAULT, rather than any specific ABR_TYPE.
1093
hasso8469bd72005-06-20 20:50:10 +000010942005-06-20 Hasso Tepper <hasso at quagga.net>
hassof4833e92005-06-20 20:42:26 +00001095
1096 * ospf_nsm.c: Make database exchange for NSSA database work.
1097
paul7461d452005-06-13 13:57:16 +000010982005-06-13 Paul Jakma <paul.jakma@sun.com>
1099
1100 * ospf_spf.c: Try get more information on a SEGV under
1101 ospf_spf_vertex_add_parent.
1102 (ospf_vertex_free) NULL out the child and nexthop lists
1103 (ospf_vertex_add_parent) nexthop and child can not be NULL
1104 vertex_nexthop's parent->child list can not be NULL
1105 (ospf_spf_next) w and cw are per-loop iteration variables, move
1106 declarations into loop body.
1107
hasso1ddd7292005-06-07 19:54:04 +000011082005-06-07 Hasso Tepper <hasso at quagga.net>
1109
1110 * ospf_apiserver.c: Fix obvious error in notifying clients about ISM
1111 changes - oi->ifp->status doesn't give to us info about ISM,
1112 oi->state does.
1113
paul7e440862005-06-01 11:20:51 +000011142005-06-01 Akihiro Mizutani <mizutani@net-chef.net>
1115
1116 * ospf_ism.c (ospf_elect_bdr/ospf_elect_dr): Fix DR election bug.
1117
paul500e4182005-05-26 17:11:13 +000011182005-05-26 Paul Jakma <paul.jakma@sun.com>
1119
1120 * ospf_abr.c: (ospf_abr_update_aggregate) Fix comment, cost bug itself
1121 had been fixed long ago by Sowmini.
1122
paula3387a42005-05-18 23:29:57 +000011232005-05-19 Paul Jakma <paul.jakma@sun.com>
1124
1125 * ospf_interface.c: (ospf_if_table_lookup) Fix a serious bug
1126 a less serious one.
1127 1: this function is supposed to lookup
1128 entries in the oifs ospf_interface route_table and return either
1129 an existing oi or NULL to indicate not found, its caller depends
1130 on this, yet this function uses route_node_get which /always/
1131 returns a route_node - one is created if none exists. Use
1132 route_node_lookup instead. This should fix root cause of the
1133 reports of the (ospf_add_to_if) assert being hit.
1134 2: oi's are inserted into this table with prefixlength set to
1135 /32 (indeed, it should be a hash table, not a route_table),
1136 however prefixlength to lookup was not changed, if no valid entry
1137 can be inserted other than /32, then nothng but /32 should be
1138 looked up. This possibly only worked by fluke..
1139 Fix confirmed by 2 reporters (one list, one IRC), definitely a
1140 backport candidate once it has been incubated in HEAD for a while.
1141 Thanks to Patrick Friedel and Ivan Warren for testing.
1142
paul69310a62005-05-11 18:09:59 +000011432005-05-11 Paul Jakma <paul.jakma@sun.com>
1144
1145 * (general) Fix memory leaks in opaque AS-scope LSAs, reported and
1146 with much debugging done by by scott collins <scollins@agile.tv>.
1147 * ospf_lsa.c: (ospf_discard_from_db) dont call
1148 ospf_ase_unregister_external_lsa for opaque-lsa's, opaques are
1149 never registered with ase in the first place.
1150 * ospf_packet.c: (general) Disabuse opaque related code of its
1151 tendency to try gather up things into temporary lists.
1152 (ospf_ls_upd) remove the temporary lists opaque uses, call
1153 opaque functions inline, just like all other types.
1154 (ospf_ls_ack) ditto.
1155 (ospf_recv_packet) fixup sign warning.
1156 * ospf_opaque.c: (general) fix the unneeded use of lists, and
1157 untwist some of the logic.
1158 (ospf_opaque_self_originated_lsa_received) take a single LSA
1159 as argument, not a list of them. Remove the list loop. Logic
1160 otherwise unchanged.
1161 (ospf_opaque_ls_ack_received) Mostly ditto. But untwist the logic,
1162 move the actions up into the switch block, remove the goto's and
1163 sanitise the logic near the end a bit.
1164 * ospf_opaque.h: Adjust definitions of aforementioned functions
1165 in ospf_opaque.c to match.
1166
paul42c98192005-05-07 02:22:51 +000011672005-05-07 Yar Tikhiy <yar@comp.chem.msu.su>
1168
1169 * ospf_network.c: Log ifindex on multicast membership leave/join
1170 events.
1171
paul4dadc292005-05-06 21:37:42 +000011722005-05-06 Paul Jakma <paul.jakma@sun.com>
1173
1174 * (general) extern and static qualifiers added.
1175 unspecified arguments in definitions fixed, typically they should
1176 be 'void'.
1177 function casts added for callbacks.
1178 Guards added to headers which lacked them.
1179 Proper headers included rather than relying on incomplete
1180 definitions.
1181 gcc noreturn function attribute where appropriate.
1182 * ospf_opaque.c: remove the private definition of ospf_lsa's
1183 ospf_lsa_refresh_delay.
1184 * ospf_lsa.h: export ospf_lsa_refresh_delay
1185 * ospf_packet.c: (ospf_make_md5_digest) make *auth_key const,
1186 correct thing to do - removes need for the casts later.
1187 * ospf_vty.c: Use vty.h's VTY_GET_INTEGER rather than ospf_vty's
1188 home-brewed versions, shuts up several warnings.
1189 * ospf_vty.h: remove VTY_GET_UINT32. VTY_GET_IPV4_ADDRESS and
1190 VTY_GET_IPV4_PREFIX moved to lib/vty.h.
1191 * ospf_zebra.c: (ospf_distribute_list_update_timer) hacky
1192 overloading of the THREAD_ARG pointer should at least use
1193 uintptr_t.
1194
paul9e67dc22005-04-15 12:10:17 +000011952005-04-15 Zhipeng Gong <zpgong@cdc.3upsystems.com>
1196
1197 * ospf_abr.c: (ospf_abr_announce_network_to_area) dont forget
1198 to approve LSAs for the case where metric has changed, lsa gets
1199 flushed otherwise. (backport candidate).
1200
ajs634f9ea2005-04-11 15:51:40 +000012012005-04-11 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1202
1203 * ospf_zebra.c (ospf_zebra_add): Call zclient_send_message instead
1204 of writen.
1205
ajsd2fc8892005-04-02 18:38:43 +000012062005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1207
ajse4319de2005-04-02 23:23:55 +00001208 * ospf_interface.h: (ospf_if_lookup_by_name) Remove declaration of a
1209 function that does not exist.
1210
12112005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1212
ajs21fefa92005-04-02 23:16:41 +00001213 * ospf_zebra.c: (zebra_interface_if_lookup) Must use
1214 if_lookup_by_name_len.
1215
12162005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1217
ajsa3491982005-04-02 22:50:38 +00001218 * ospf_interface.c: (ospf_vl_new) Use strnlen to fix call to if_create.
1219
12202005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1221
ajsd2fc8892005-04-02 18:38:43 +00001222 * ospf_vty.c: (show_ip_ospf_interface_sub) Show ifindex and interface
1223 flags to help with debugging.
1224 * ospf_zebra.c: (ospf_interface_delete) After deleting, set ifp->ifindex
1225 to IFINDEX_INTERNAL.
1226 (zebra_interface_if_lookup) Make function static. Tighten up code.
1227
ajsaca72fd2005-03-31 15:18:21 +000012282005-03-31 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1229
1230 * ospf_dump.c: (show_debugging_ospf) Show if ospf event debugging
1231 is turned on.
1232
ajsfd651fa2005-03-29 16:08:16 +000012332005-03-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1234
ajsa608bbf2005-03-29 17:03:49 +00001235 * ospf_zebra.c: (ospf_interface_state_up) If the MTU of an operative
1236 interface changes, print a debug message and call ospf_if_reset()
1237 to simulate down/up on the interface.
1238 * ospf_interface.h: Declare new function ospf_if_reset().
1239 * ospf_interface.c: (ospf_if_reset) New function to call ospf_if_down
1240 and ospf_if_up for all ospf interfaces attached to an interface.
1241
12422005-03-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1243
ajs5dcbdf82005-03-29 16:13:49 +00001244 * ospf_packet.c: (ospf_write_frags) Enhance error message to
1245 show MTU. Also make function static.
1246 (ospf_write) Enhance error message to show interface name and MTU.
1247 Also make function static.
1248
12492005-03-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1250
1251 * ospf_vty.c: (show_ip_ospf_interface_sub) Display interface MTU and
1252 bandwidth; this is useful for debugging problems. Also, the function
1253 should be static.
ajsfd651fa2005-03-29 16:08:16 +00001254
hasso1b639042005-03-27 13:32:25 +000012552005-03-27 Hasso Tepper <hasso at quagga.net>
1256
1257 * ospf_snmp.c: Don't crash in snmp query if ospf instance doesn't
1258 exist at all.
1259
hasso343f5cc2005-03-25 19:48:40 +000012602005-03-25 Hasso Tepper <hasso at quagga.net>
1261
1262 * ospfd.h: Include log.h, fixes compile with gcc-4.0.
1263
ajs9dbc7972005-03-13 19:27:22 +000012642005-03-13 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1265
1266 * ospf_lsa.c: (ospf_lsa_refresh_walker) If the system clock jumps
1267 backward, then current time may be less than
1268 ospf->lsa_refresher_started. This was causing invalid values
1269 for ospf->lsa_refresh_queue.index resulting in infinite loops.
1270 Problem fixed by casting the expression to unsigned before taking
1271 the modulus.
1272
ajs5c333492005-02-23 15:43:01 +000012732005-02-23 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1274
1275 * ospfd.h: Add new field struct stream *ibuf to struct ospf.
1276 * ospfd.c: (ospf_new) Check return code from ospf_sock_init.
1277 Allocate ibuf using stream_new(OSPF_MAX_PACKET_SIZE+1).
1278 (ospf_finish) Call stream_free(ospf->ibuf.
1279 * ospf_packet.c: (ospf_read) Call stream_reset(ospf->ibuf) and then
1280 pass it to ospf_recv_packet for use in receiving the packet
1281 (instead of allocating a new stream for each packet received).
1282 Eliminate all calls to stream_free(ibuf).
1283 (ospf_recv_packet) The struct stream *ibuf is now passed in as
1284 an argument. No need to use recvfrom to peek at the packet
1285 header (to see how big it is), just use ospf->ibuf which is
1286 always large enough (this eliminates a system call to recvfrom).
1287 Therefore, no need to allocate a stream just for this packet,
1288 and no need to free it when done.
1289
hasso462f20d2005-02-23 11:29:02 +000012902005-02-23 Vincenzo Eramo <eramo at infocom.ing.uniroma1.it>
1291
1292 * ospf_lsa.h: New flag to the LSA structure for the SPF calculation.
1293 * ospf_lsdb.h: Export ospf_lsdb_clean_stat() function.
1294 * ospf_spf.h: Add link to the LSA stat structure into vertex.
1295 * ospf_spf.c: New functions cmp() and update_stat() to manage
1296 candidates. Remove ospf_spf_has_vertex(), ospf_vertex_lookup(),
1297 ospf_install_candidate() and ospf_spf_register() functions not needed
1298 any more. Update ospf_vertex_new(), ospf_spf_next() and
1299 ospf_spf_calculate() functions to use pqueue instead of linked list.
1300
hassoe40dcce2005-02-21 14:58:42 +000013012005-02-21 Hasso Tepper <hasso at quagga.net>
1302
1303 * ospf_ase.c: Don't show messages related to the ase calculations if
1304 we are not debugging.
1305
hasso306541b2005-02-19 17:58:40 +000013062005-02-19 Hasso Tepper <hasso at quagga.net>
1307
1308 * ospf_api.h: char isn't always signed, but it has to be it here.
1309
paulfa81b712005-02-19 01:19:20 +000013102005-02-19 Paul Jakma <paul.jakma@sun.com>
1311
1312 * ospf_packet.c: (ospf_stream_copy) remove
1313 (ospf_packet_dup) use stream_copy instead of ospf_stream_copy
1314
ajs038163f2005-02-17 19:55:59 +000013152005-02-17 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1316
1317 * ospf_packet.c: (ospf_recv_packet) If there is somehow a runt
1318 packet in the queue, it must be discarded. Improve warning messages.
1319 Fix scope to static.
1320 (ospf_read) Fix bug: should reset the read thread in all cases
1321 to make sure we continue to get incoming messages.
1322
paul658b03a2005-02-15 10:10:55 +000013232005-02-15 Paul Jakma <paul.jakma@sun.com>
1324
1325 * ospf_packet.c: (ospf_recv_packet) Fix silly error wrt allocating
1326 ibuf. Thanks Andrew.
1327
paulbfdc44a2005-02-14 23:48:42 +000013282005-02-14 Paul Jakma <paul.jakma@sun.com>
1329
1330 * ospf_packet.c: (ospf_recv_packet) use stream_recvmsg.
1331
hasso082253f2005-02-11 08:31:54 +000013322005-02-11 Hasso Tepper <hasso at quagga.net>
1333
1334 * ospf_lsdb.c: Fix sum of checksums calculation.
1335
ajs083ee9d2005-02-09 15:35:50 +000013362005-02-09 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1337
1338 * ospf_packet.c: (ospf_write) If sendmsg fails, give more info in the
1339 error message.
1340
ajsba6454e2005-02-08 15:37:30 +000013412005-02-08 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1342
ajs8cfde372005-02-08 15:59:16 +00001343 * ospf_interface.h: Reduce structure padding by putting new u_char
1344 field multicast_memberships in a better spot (grouped with
1345 other u_char fields type and state).
1346
13472005-02-08 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1348
ajsba6454e2005-02-08 15:37:30 +00001349 * ospf_interface.h: Improve passive_interface comment. Add new
1350 multicast_memberships bitmask to struct ospf_interface to track
1351 active multicast subscriptions. Declare new function
1352 ospf_if_set_multicast.
1353 * ospf_interface.c: (ospf_if_set_multicast) New function to configure
1354 multicast memberships properly based on the current
1355 multicast_memberships status and the current values of the
1356 ospf_interface state, type, and passive_interface status.
1357 (ospf_if_up) Remove call to ospf_if_add_allspfrouters (this is
1358 now handled by ism_change_state's call to ospf_if_set_multicast).
1359 (ospf_if_down) Remove call to ospf_if_drop_allspfrouters (now
1360 handled by ism_change_state).
1361 * ospf_ism.c: (ospf_dr_election) Remove logic to join or leave
1362 the DRouters multicast group (now handled by ism_change_state's call
1363 to ospf_if_set_multicast).
1364 (ism_change_state) Add call to ospf_if_set_multicast to change
1365 multicast memberships as necessary to reflect the new interface state.
1366 * ospf_packet.c: (ospf_hello) When a Hello packet is received on a
1367 passive interface: 1. Increase the severity of the error message
1368 from LOG_INFO to LOG_WARNING; 2. Add more information to the error
1369 message (packet destination address and interface address);
1370 and 3. If the packet was sent to ospf-all-routers, then try
1371 to fix the multicast group memberships.
1372 (ospf_read) When a packet is received on an interface whose state
1373 is ISM_Down, enhance the warning message to show the packet
1374 destination address, and try to update/fix the multicast group
1375 memberships if the packet was sent to a multicast address.
1376 When a packet is received for ospf-designated-routers, but the
1377 current interface state is not DR or BDR, then increase the
1378 severity level of the error message from LOG_INFO to LOG_WARNING,
1379 and try to fix the multicast group memberships.
1380 * ospf_vty.c: (ospf_passive_interface) Call ospf_if_set_multicast for
1381 any ospf interface that may have changed from active to passive.
1382 (no_ospf_passive_interface) Call ospf_if_set_multicast for
1383 any ospf interface that may have changed from passive to active.
1384 (show_ip_ospf_interface_sub) Show multicast group memberships.
1385
paul3a9eb092005-02-08 11:29:41 +000013862005-02-08 Paul Jakma <paul@dishone.st>
1387
1388 * ospf_packet.c: (various) Remove unneeded stream_set_putp abuse.
1389
ajs847947f2005-02-02 18:38:48 +000013902005-02-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1391
1392 * ospf_packet.c: (ospf_read) Fix bug: must check for state ISM_Down,
1393 not for event ISM_InterfaceDown. And improve the message by
1394 adding the interface flags.
1395
ajs0b7d97d2005-01-30 17:24:02 +000013962005-01-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1397
1398 * ospf_network.c: (ospf_sock_init) Save errno before calling
1399 ospfd_privs.change.
1400
ajsc3eab872005-01-29 15:52:07 +000014012005-01-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1402
1403 * ospf_packet.c: (ospf_packet_add) If oi->obuf is NULL, print
1404 an error message and return.
1405 (ospf_read) If the interface state is ISM_InterfaceDown, issue
1406 a warning message and ignore the packet.
1407
gdt86f1fd92005-01-10 14:20:43 +000014082005-01-10 Greg Troxel <gdt@fnord.ir.bbn.com>
1409
1410 * ospf_packet.h: Remove commented out definition of
1411 OSPF_MAX_PACKET; neither it or the uncommented one are used any more.
1412
1413 * ospf_packet.c (ospf_make_ls_upd): Leave room for authentication
1414 when deciding if an update will fit.
1415 (ospf_packet_authspace): Factor out calculation of size required
1416 for authentication.
1417 (ospf_make_db_desc): Use ospf_max_packet, not OSPF_MAX_PACKET.
1418 Don't confuse readers that there is a macro.
1419
ajs3dc56b52004-12-30 15:11:19 +000014202004-12-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1421
1422 * ospf_network.c: Improve all setsockopt error messages to give detailed
1423 information on the arguments.
1424
ajsb87f7722004-12-29 20:41:26 +000014252004-12-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1426
ajs17eaa722004-12-29 21:04:48 +00001427 * ospf_packet.c: (ospf_db_desc) Reduce severity of "Negotiation done"
1428 messages from LOG_WARNING to LOG_INFO, since this seems to be
1429 normal.
1430
14312004-12-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1432
ajsb87f7722004-12-29 20:41:26 +00001433 * ospf_packet.c: (ospf_read) Always look up the interface if
1434 ospf_recv_packet returns NULL ifp, since some platforms such
1435 as Solaris 8 appear to support ifindex retrieval but don't.
1436
hasso1d806282004-12-22 09:43:20 +000014372004-12-22 Hasso Tepper <hasso at quagga.net>
1438
1439 * ospf_dump.c: Show debug configuration in vtysh.
hassoc6b87812004-12-22 13:09:59 +00001440 * ospf_vty.c: Fix "show ip ospf" output. Router can't be elected in
1441 any case if it's configured as "translate-never".
hassofe71a972004-12-22 16:16:02 +00001442 * ospf_lsdb.[ch]: New function to calculate sum of checksums.
1443 * ospf_vty.c: Bugfix to show really number of AS external LSAs, not
1444 number of all LSAs with AS scope, this includes opaque as LSAs as
1445 well, show this number separately. Show numbers and sums of
1446 checksums for each type of LSAs.
1447 * ospf_lsa.c: Calculate checksum before putting LSA into database.
hasso1d806282004-12-22 09:43:20 +00001448
ajsbc18d612004-12-15 15:07:19 +000014492004-12-15 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1450
1451 * ospf_interface.h: Declare new function ospf_default_iftype.
1452 * ospf_interface.c: (ospf_default_iftype) New function to centralize
1453 this logic in one place.
1454 * ospf_zebra.c: (ospf_interface_add) Use new function
1455 ospf_default_iftype.
1456 * ospf_vty.c: (no_ip_ospf_network,config_write_interface) Fix logic
1457 by using new function ospf_default_iftype.
1458
ajs3aa8d5f2004-12-11 18:00:06 +000014592004-12-11 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1460
1461 * ospf_packet.c: (ospf_db_desc) Should be static, not global.
1462 (ospf_hello,ospf_db_desc,ospf_ls_upd,ospf_ls_ack) Improve warning
1463 messages to include identifying information (e.g. router id).
1464 * ospf_nsm.c: (nsm_change_state) Improve info message to include
1465 router id and state names.
1466
gdt91f3e522004-12-09 14:51:03 +000014672004-12-09 Greg Troxel <gdt@fnord.ir.bbn.com>
1468
gdt3fb9de72004-12-09 16:30:04 +00001469 * ospf_apiserver.c (ospf_apiserver_term): Obtain struct
1470 ospf_apiserver * from listnode. Remove unused variables. Follows
1471 suggestion from Jay Fenlason.
gdt91f3e522004-12-09 14:51:03 +00001472
ajs9b0e25c2004-12-08 19:06:51 +000014732004-12-08 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1474
1475 * *.c: Change level of debug messages to LOG_DEBUG.
1476
ajs274a4a42004-12-07 15:39:31 +000014772004-12-07 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1478
1479 * ospf_main.c: (main) The 2nd argument to openzlog has been removed.
1480
ajs887c44a2004-12-03 16:36:46 +000014812004-12-03 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1482
ajs1210fa62004-12-03 16:43:24 +00001483 * ospf_packet.c: (ospf_db_desc) Reduce priority on a debug message
1484 from LOG_NOTICE to LOG_DEBUG.
1485
14862004-12-03 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1487
ajs887c44a2004-12-03 16:36:46 +00001488 * ospf_main.c: (sigint) Use zlog_notice for termination message.
1489 (main) Issue a startup announcement using zlog_notice.
1490
ajsbec595a2004-11-30 22:38:43 +000014912004-11-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1492
1493 * ospf_packet.c: (ospf_db_desc_proc) Fix spelling of packet in warning
1494 message and in comment.
1495 (ospf_db_desc) Warning message that a packet is being discarded
1496 should give the router id of the packet source. Fix spelling
1497 of packet in two warning messages.
1498 (ospf_ls_req) Warning message that a link state request is being
1499 discarded should give the router id of the neighbor that sent it.
1500
ajs5b85fac2004-11-26 19:36:42 +000015012004-11-26 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1502
1503 * ospf_main.c: Remove #include "debug.h" (was not being used, and
1504 lib/debug.h has now been deleted).
1505
hassoc0652302004-11-25 19:33:48 +000015062004-11-25 Hasso Tepper <hasso at quagga.net>
1507
1508 * ospf_main.c: Make group to run as configurable.
1509
gdt69e13252004-11-15 18:51:15 +000015102004-11-15 Greg Troxel <gdt@fnord.ir.bbn.com>
1511
1512 * ospf_packet.c (ospf_recv_packet): Assume CMSG_SPACE is present
1513 and works (lib/zebra.h provides if OS doesn't).
1514
paul788dab12004-11-15 11:48:37 +000015152004-11-15 Paul Jakma <paul@dishone.st>
1516
1517 * ospf_{apiserver,te}.c: ospf_lsa_free's should be ospf_lsa_unlock.
1518
paul05e85fa2004-11-12 10:52:19 +000015192004-11-12 Paul Jakma <paul@dishone.st>
1520
1521 * ospf_ia.c: (process_summary_lsa) Only an ABR has any reason to
1522 ignore stub area summary default. Even so it seems a strange
1523 check, add a comment to that effect.
1524
paulf3ae74c2004-11-04 20:35:31 +000015252004-11-04 Paul Jakma <paul@dishone.st>
1526
1527 * ospfd.c: (ospf_network_match_iface) revert to previous network
1528 statement match behaviour.
1529
paul62d8e962004-11-02 20:26:45 +000015302004-11-02 Paul Jakma <paul@dishone.st>
1531
1532 * ospf_packet.c: (ospf_write_frags) remove iov arg, msg already points
1533 to it. Add convenience pointer to msg->msg_iov[1], and use this,
1534 fixing the unfortunate borkenness introduced in moving of this code
1535 to a function.
1536 (ospf_write) remove iovp and fix up call to previous.
1537 (ospf_ls_upd_packet_new) cast size to long int - unfortunately
1538 glibc's size_t format modifier is not portable.
1539
paul37ccfa32004-10-31 11:24:51 +000015402004-10-31 Paul Jakma <paul@dishone.st>
1541
1542 * ospf_packet.c: (ospf_write_frags) Add debug output
1543 (ospf_write) set type early, so we can pass it to
1544 ospf_write_frags.
1545 (ospf_ls_upd_packet_new) print size in debug output when too large
1546 packet is encountered.
paul64511f32004-10-31 18:01:13 +00001547 * ospf_zebra.c: (ospf_distribute_list_update_timer) Ugly misuse of
1548 THREAD_ARG to store an integer, but it should at least use same
1549 same type to retrieve the value. Assert value is sane.
paul37ccfa32004-10-31 11:24:51 +00001550
paulac191232004-10-22 12:05:17 +000015512004-10-22 Paul Jakma <paul@dishone.st>
1552
1553 * ospf_network.c: (ospf_sock_init) call neutral setsock_ifindex()
1554 function.
1555 * ospf_packet.c: (ospf_read) manually look up ifindex
paul4ccb2c42004-10-22 22:52:33 +00001556 if system could not have returned one, eg openbsd, thanks to Rivo
1557 Nurges for highlighting problem and fix.
paul06f953f2004-10-22 17:00:38 +00001558 Change setsockopt_pktinfo to setsockopt_ifindex.
paulac191232004-10-22 12:05:17 +00001559
hasso3fb9cd62004-10-19 19:44:43 +000015602004-10-19 Andrew J. Schorr <aschorr@telemetry-investments.com>
1561
1562 * ospf_snmp.c: (ospf_snmp_if_update) Fix logic to handle PtP links
1563 with dedicated subnets properly.
1564 * ospf_lsa.c: (lsa_link_ptop_set) ditto.
1565 * ospfd.c: (ospf_network_match_iface) ditto.
1566 (ospf_network_run) ditto.
1567 * ospf_interface.c: (ospf_if_is_configured) ditto.
1568 (ospf_if_lookup_by_prefix) ditto.
1569 (ospf_if_lookup_recv_if) ditto.
1570 * ospf_vty.c: (show_ip_ospf_interface_sub) Display the peer or
1571 broadcast address if present.
1572
hassod68614d2004-10-13 09:32:48 +000015732004-10-13 Hasso Tepper <hasso at quagga.net>
1574
1575 * ospf_main.c: Unbreak compilation with ospfapi disabled.
hassoc75105a2004-10-13 10:33:26 +00001576 * ospf_snmp.c: Remove defaults used to initialize smux connection to
1577 snmpd. Connection is initialized only if smux peer is configured.
hassod68614d2004-10-13 09:32:48 +00001578
hassof4d58ce2004-10-12 06:13:54 +000015792004-10-12 Hasso Tepper <hasso at quagga.net>
1580
1581 * ospf_main.c, ospf_opaque.c: Unbreak ospfclient compilation - move
1582 static variable from ospf_main.c into ospf_opaque.c.
1583
hassoc3abdb72004-10-11 16:27:03 +000015842004-10-11 Hasso Tepper <hasso at quagga.net>
1585
1586 * ospf_main.c, ospf_opaque.c: Disable ospfapi init by default. New
1587 command line switch to enable it.
1588
paul6b333612004-10-11 10:11:25 +000015892004-10-11 Paul Jakma <paul@dishone.st>
1590
1591 * ospf_dump.c: (ospf_ip_header_dump) Assume header is in host order
1592 remove ntohs that should have dissappeared. Take struct ip
1593 as argument, caller has to know there's an IP header at start of
1594 stream anyway.
1595 * ospf_dump.h: update declaration of ospf_ip_header_dump.
1596 * ospf_packet.c: (ospf_write) correct call to
1597 sockopt_iphdrincl_swab_htosys which was munging the header.
1598 (ospf_recv_packet) ip_len is needed for old OpenBSD fixup.
1599 (ospf_read) sockopt_iphdrincl_swab_systoh ip header as soon as
1600 we have it.
paul6c835672004-10-11 11:00:30 +00001601 * (global) Const char update and signed/unsigned fixes.
1602 * (various headers) size defines should be unsigned.
1603 * ospf_interface.h: remove duplicated defines, include the
1604 authoritative header - though, these defines should probably
1605 be moved to a dedicated header, or ospfd.h.
1606 * ospf_lsa.h: (struct lsa) ls_seqnum should be unsigned.
1607 * ospf_packet.c: (ospf_write) cast result of shift to unsigned.
paul6b333612004-10-11 10:11:25 +00001608
hassoeb1ce602004-10-08 08:17:22 +000016092004-10-08 Hasso Tepper <hasso at quagga.net>
1610
1611 * *.[c|h]: Fix compiler warnings: make some strings const, signed ->
1612 unsigned, remove unused variables etc.
1613
gdt54ade992004-10-07 19:38:20 +000016142004-10-07 Greg Troxel <gdt@claude.ir.bbn.com>
1615
1616 * ospf_apiserver.c (ospf_apiserver_unregister_opaque_type): Don't
1617 use of variable names 'node' and 'nextnode' to avoid possible
1618 conflict with list macros. Move variable declaration inside for
1619 loop after a statement to top of function.
1620
paulaa20c6f2004-10-07 14:19:36 +000016212004-10-07 Paul Jakma <paul@dishone.st>
1622
1623 * ospf_snmp.c: Missed list typedef update
1624 * ospf_dump.c: Include sockopt.h for header swab functions.
1625
paul18b12c32004-10-05 14:38:29 +000016262004-10-05 Paul Jakma <paul@dishone.st>
1627
1628 * ospf_packet.c: replace ospf_swap_iph_to... with
1629 sockopt_iphdrincl_swab_...
1630
hasso18a6dce2004-10-03 18:18:34 +000016312004-10-03 James R. Leu <jleu at mindspring.com>
1632
1633 * ospf_zebra.c: Read router id related messages from zebra daemon.
1634 Schedule router-id update thread if it's changed.
1635 * ospfd.c: Remove own router-id selection function. Use router id from
1636 zebra daemon if it isn't manually overriden in configuration.
1637
paul68defd62004-09-27 07:27:13 +000016382004-09-27 Paul Jakma <paul@dishone.st>
1639
paul6a99f832004-09-27 12:56:30 +00001640 * ospf_dump.c: (ospf_ip_header_dump) Use HAVE_IP_HDRINCL_BSD_ORDER
1641 Apply to offset too. Print ip_cksum, lets not worry about
1642 possible 2.0.37 compile problems.
1643 * ospf_packet.c: (ospf_swap_iph_to{n,h}) Use
1644 HAVE_IP_HDRINCL_BSD_ORDER.
1645 (ospf_recv_packet) ditto.
1646 (ospf_write) Fixup iov argument to ospf_write_frags.
1647 (struct msghdr).msg_name is caddr_t on most platforms.
paul68defd62004-09-27 07:27:13 +00001648 (ospf_recv_packet) ditto. And msg_flags is not always there
1649 memset struct then set fields we care about rather than
1650 initialise all fields individually.
1651
hassoc9e52be2004-09-26 16:09:34 +000016522004-09-26 Hasso Tepper <hasso at quagga.net>
1653
1654 * ospf_abr.c, ospf_dump.c, ospf_lsa.c, ospf_packet.c, ospf_vty.c,
1655 ospf_zebra.c: Fix compiler warnings.
1656
paul87d6f872004-09-24 08:01:38 +000016572004-09-24 Paul Jakma <paul@dishone.st>
1658
1659 * ospf_apiserver.{c,h}: lists typedef removal cleanup.
1660 update some list loops to LIST_LOOP. some miscellaneous indent
1661 fixups.
1662 (ospf_apiserver_unregister_opaque_type) fix listnode_delete of
1663 referenced node in loop.
paul1603c062004-09-24 08:23:24 +00001664 (ospf_apiserver_term) loops calling ospf_apiserver_free, which
1665 deletes referenced nodes from apiserver_list, fixed.
paul87d6f872004-09-24 08:01:38 +00001666 * ospf_interface.h: lists typedef removal cleanup.
1667 * ospf_opaque.{c,h}: lists typedef removal cleanup. update some list
1668 loops to LIST_LOOP. miscellaneous style and indent fixups.
1669 * ospf_te.{c,h}: ditto
1670 * ospf_packet.c: lists typedef removal cleanup.
paula2570682004-09-24 08:09:57 +00001671 (ospf_write) ifdef fragmentation support. move actual
1672 fragmentation out to a new, similarly ifdefed, function.
1673 (ospf_write_frags) fragmented write support, moved from previous.
paul87d6f872004-09-24 08:01:38 +00001674
hasso52dc7ee2004-09-23 19:18:23 +000016752004-09-23 Hasso Tepper <hasso at quagga.net>
1676
1677 * *.[c|h]: list -> struct list *, listnode -> struct listnode *.
1678
paul68b73392004-09-12 14:21:37 +000016792004-09-12 Paul Jakma <paul@dishone.st>
1680
1681 * ospf_packet.c: Fix bugzilla #107
1682 (ospf_packet_max) get rid of the magic 88 constant
1683 (ospf_swab_iph_ton) new function. set ip header to network order,
1684 taking BSDisms into account.
1685 (ospf_swab_iph_toh) the inverse.
1686 (ospf_write) Add support for IP fragmentation, will only work on
1687 linux though, other kernels make it impossible. get rid of the
1688 magic 4 constant.
1689 (ospf_make_ls_upd) Bound check to end of stream, not to
1690 interface mtu.
1691 (ospf_ls_upd_packet_new) New function, allocate upd packet
1692 taking oversized LSAs into account.
1693 (ospf_ls_upd_queue_send) use ospf_ls_upd_packet_new to allocate,
1694 rather than statically allocating mtu sized packet buffer, which
1695 actually was wrong - it didnt take ip header into account, which
1696 should not be included in packet buffer.
1697 (ospf_ls_upd_send_queue_event) minor tweaks and remove
1698 TODO comment.
1699
gdt630e4802004-08-31 17:28:41 +000017002004-08-31 David Wiggins <dwiggins@bbn.com>
1701
1702 * ospf_spf.c (ospf_spf_calculate): Many more comments and debug
1703 print statements. New function ospf_vertex_dump used in debugging.
1704
17052004-08-31 David Wiggins <dwiggins@bbn.com>
1706
1707 * ospf_spf.h (struct vertex): Comments for flags and structure members.
1708
17092004-08-31 David Wiggins <dwiggins@bbn.com>
1710
1711 * ospf_route.c: When finding an alternate route, log cost as well.
1712
17132004-08-31 David Wiggins <dwiggins@bbn.com>
1714
1715 * ospf_interface.c (ospf_lookup_if_params): Initialize af in
1716 struct prefix allocated on stack.
1717
17182004-08-31 David Wiggins <dwiggins@bbn.com>
1719
1720 * ospf_packet.c (ospf_ls_ack_send_delayed): In p2mp mode, send
1721 acks to AllSPFRouters, rather than All-DR.
1722
hasso7b901432004-08-31 13:37:42 +000017232004-08-27 Hasso Tepper <hasso at quagga.net>
1724
1725 * ospf_vty.c: Don't print ospf network type under interface only
1726 if interface is in broadcast mode and interface type really is
1727 broadcast. Fixes Bugzilla #108.
1728
gdtd7d93992004-08-27 12:03:42 +000017292004-08-27 David Wiggins <dwiggins@bbn.com>
1730
1731 * ospf_spf.c (ospf_nexthop_calculation): Initialize address family
1732 in on-stack struct prefix_ipv4. Fixes point-to-multipoint SPF
1733 calculation.
1734
gdtd0deca62004-08-26 13:14:07 +000017352004-08-26 Greg Troxel <gdt@fnord.ir.bbn.com>
1736
1737 * ospf_packet.c (ospf_recv_packet): adjust size declaration of
gdtd7d93992004-08-27 12:03:42 +00001738 buffer used to get interface index so that it compiles on other
1739 than Linux and includes the required alignment space. Probably
1740 this was only working on sparc/sparc64 because most of
1741 sockaddr_dl was not being written.
gdtd0deca62004-08-26 13:14:07 +00001742
paul863082d2004-08-19 04:43:43 +000017432004-08-19 Paul Jakma <paul@dishone.st>
1744
1745 * ospf_packet.c: update to match sockopt renames.
1746
paul75ee0b82004-08-05 09:10:31 +000017472004-08-04 Paul Jakma <paul@dishone.st>
1748
1749 * ospf_spf.c: (ospf_spf_consider_nexthop) Add comment about issue.
1750 Compare only against list head - all nexthops must be same cost
1751 anyway, fixes a reference-listnode-after-delete bug noted by
1752 Kir Kostuchenko.
1753 (ospf_nexthop_calculation) Use ospf_spf_consider_nexthop for all
1754 candidates attached to root.
1755
paul36c64ef2004-07-27 11:19:11 +000017562004-07-27 Paul Jakma <paul@dishone.st>
1757
paul48fe13b2004-07-27 17:40:44 +00001758 * ospf_packet.c: (ospf_ls_upd_send_queue_event) fix thinko from
1759 last fix for ospfd wedging due to oversize LSAs: dont list loop on
1760 ospf_ls_upd_queue_send() - guaranteed segfault.
1761
17622004-07-27 Paul Jakma <paul@dishone.st>
1763
paul36c64ef2004-07-27 11:19:11 +00001764 * ospf_opaque.c: (ospf_opaque_lsa_flush_schedule) do not NULL out
1765 the LSA as then free_opaque_info_per_id() can never unlock (and
1766 free) the LSA. Reported by Gunnar Stigen.
1767
paul2dd8bb42004-07-23 15:13:48 +000017682004-07-23 Paul Jakma <paul@dishone.st>
1769
1770 * ospf_network.c: Replace PKTINFO/RECVIF with call to
1771 setsockopt_pktinfo
1772 * ospf_packet.c: Use getsockopt_pktinfo_ifindex and
1773 SOPT_SIZE_CMSG_PKTINFO_IPV4.
1774
paul59ea14c2004-07-14 20:50:36 +000017752004-07-14 Paul Jakma <paul@dishone.st>
1776
1777 * ospf_packet.c: (ospf_ls_upd_send_queue_event) Partial fix for
1778 problem reported by Peter Frost amongst others, where function
1779 will spin indefinitely if update list contains LSAs greater than
1780 MTU-headers or other condition leading to update list never being
1781 cleared. Problem of what to do with these LSAs remains.
1782 (ospf_make_ls_upd) add comment about large LSA problem,
1783 indentation cleanup.
1784
gdtb2c1b282004-07-01 12:35:36 +000017852004-07-01 Greg Troxel <gdt@fnord.ir.bbn.com>
1786
1787 * Makefile.am (lib_LTLIBRARIES): make libospf shared
1788
gdt87efd642004-06-30 17:36:11 +000017892004-06-30 Greg Troxel <gdt@poblano.ir.bbn.com>
1790
1791 * Makefile.am: Add shlib support.
1792
hassobeebba72004-06-20 21:00:27 +000017932004-06-10 Hasso Tepper <hasso@estpak.ee>
1794
1795 * *: Removed ifdefs HAVE_NSSA.
1796
paul553ff112004-06-06 09:41:00 +000017972004-06-06 Paul Jakma <paul@dishone.st>
1798
1799 * ospf_dump.c,ospf_lsa.c: Fix typos of merge of previous.
1800 ospf_flood.c: (ospf_process_self_originated_lsa) fix zlog format
1801
paul0c2be262004-05-31 14:16:54 +000018022004-05-31 Sagun Shakya <sagun.shakya@sun.com>
1803
1804 * ospf_dump.c: (ospf_lsa_header_dump) LOOKUP can return null if
1805 index is out of range.
1806 ospf_flood.c: endianness fix
1807 ospf_lsa.c: Missing ntohl's on (struct lsa *)->data->ls_seqnum
1808 in various places.
1809
hassodd669bb2004-05-10 07:43:59 +000018102004-05-10 Hasso Tepper <hasso@estpak.ee>
1811
1812 * ospf_zebra.c, ospfd.c: Move ospf_prefix_list_update() function
1813 to ospf_zebra.c from ospfd.c and add redistribution updates if
1814 route-map is used in redistribution.
1815 * ospf_main.c: Remove now useless call to ospf_init().
1816
paul0a589352004-05-08 11:48:26 +000018172004-05-08 Paul Jakma <paul@dishone.st>
1818
1819 * ospf_zebra.c: Sync with lib/zclient changes
1820
pauld3f0d622004-05-05 15:27:15 +000018212004-05-05 Paul Jakma <paul@dishone.st>
1822
paul5bd41892004-05-05 17:29:24 +00001823 * ospf_network.c: (ospf_sock_init) Check whether IP_HDRINCL is
1824 defined. Warn at compile and runtime. Use
1825 IPTOS_PREC_INTERNETCONTROL otherwise.
pauld3f0d622004-05-05 15:27:15 +00001826 * ospf_packet.c: (ospf_associate_packet_vl) cleanup, move
1827 some of the checks up to ospf_read, return either a
1828 virtual link oi, or NULL.
1829 (ospf_read) Cleanup, make it responsible for checks. Remove
1830 the nbr lookup - moved to ospf_neighbor. Adjust all nbr
1831 lookups to use new wrappers exported by ospf_neighbor.
1832 * ospf_neighbor.h: Add ospf_neigbour_get and ospf_nbr_lookup.
1833 * ospf_neighbor.c: (ospf_neigbour_get) Index ospf_interface
1834 neighbour table by router-id for virtual-link ospf_interfaces,
1835 not by peer_addr (which breaks for asymmetric vlinks)
1836 (ospf_nbr_lookup) add a wrapper for nbr lookups to deal with
1837 above.
paulcd59da62004-05-05 17:26:55 +00001838 * ospf_interface.c: (ospf_vl_set_params) Catch changes of interface
1839 address for either end of a virtual-link, and hence potential cost
1840 changes.
1841
hassoa0a39762004-04-23 08:51:10 +000018422004-04-22 Hasso Tepper <hasso@estpak.ee>
1843
1844 * ospf_zebra.c: Don't ignore reject/bh routes, it's the only way
1845 to "summarize" routes in ASBR at the moment.
1846
hasso8585d4e2004-04-20 17:25:12 +000018472004-04-20 Hasso Tepper <hasso@estpak.ee>
1848
1849 * ospfd.c: Unset NP flag if area is going to be normal or stub.
1850 Fixes UNH OSPF_NSSA.1.2a comment.
1851 * ospf_abr.c: Originate default into stub/nssa area even if
1852 summaries are disabled.
1853 * ospf_zebra.c: Don't attempt to redistribute 127.0.0.0/8.
1854
hassoc266ac72004-04-19 17:31:00 +000018552004-04-19 Hasso Tepper <hasso@estpak.ee>
1856
1857 * ospf_vty.c: Don't warn that export- and import-list can't be
1858 configured to backbone area if they are applied and are working
1859 fine.
1860
hasso128d31d2004-04-04 12:52:33 +000018612004-02-19 Sowmini Varadhan <sowmini.varadhan@sun.com>
1862
1863 * ospf_packet.c: Don't drop packets in Solaris x86.
1864 [quagga-dev 1005].
1865
hasso0d85b992004-03-18 19:18:33 +000018662004-03-18 Amir Guindehi <amir@datacore.ch>
1867
1868 * ospf_opaque.c: Attempt to correct the incorrect behavior of
1869 Quagga's ospfd in the special situation that a node's opaque
1870 capability has changed as "ON -> OFF -> ON". [quagga-dev 843].
1871
paul7f352b82004-02-19 19:37:47 +000018722004-02-19 Sowmini Varadhan <sowmini.varadhan@sun.com>
1873
1874 * ospf_abr.c: (ospf_abr_update_aggregate) UNH 3.12b,c, address range
1875 should be configured with the highest cost path within the range,
1876 not lowest.
1877
paul940b01a2004-02-17 20:07:30 +000018782004-02-17 Paul Jakma <paul@dishone.st>
1879
1880 * ospf_zebra.c: (ospf_interface_delete) Do not delete the interface
1881 params, nor the interface structure, if an interface delete
1882 message is received from zebra.
1883 * ospf_interface.c: (ospf_if_delete_hook) Delete the interface
1884 params and interface, ie that which was previously removed in
1885 (ospf_interface_delete) above.
1886
hasso2db3d052004-02-11 21:52:13 +000018872004-02-11 Hasso Tepper <hasso@estpak.ee>
1888 * ospf_interface.c, ospf_zebra.c: Don't attempt to read path->oi->ifp
1889 if oi doesn't exist any more.
1890
hassocb05eb22004-02-11 21:10:19 +000018912004-02-11 Vadim Suraev <vadim.suraev@terayon.com>
1892 * ospf_packet.c (ospf_ls_upd): Router should flush received network
1893 LSA if it was originated with older router-id ([zebra 14710] #6).
1894
18952003-12-08 Mattias Amnefelt <mattiasa@kth.se>
paul239aecc2003-12-08 10:34:54 +00001896
1897 * ospf_packet.c: (ospf_recv_packet) OpenBSD now leaves iph.ip_len
1898 network byte order.
1899
gdt8f40e892003-12-05 14:01:43 +000019002003-12-05 Greg Troxel <gdt@poblano.ir.bbn.com>
1901
1902 * ospfd.c (ospf_network_match_iface): Rewrite code for clarity
1903 while trying not to change semantics. Add ifdefed-out code to
1904 avoid matching ppp interfaces whose destination address does not
1905 also match the prefix under consideration, to help out people with
1906 problems due to as-yet-unfixed bugs with p2p interfaces coming and
1907 going.
1908
paul736d3442003-07-24 23:22:57 +000019092003-07-25 kamatchi soundaram <kamatchi@tdd.sj.nec.com>
1910
1911 * ospf_packet.c (ospf_ls_upd_send_queue_event): get next route
1912 node in body of the loop to avoid chance that route node
1913 is unlocked and deleted before the next iteration tries to
1914 get next route node.
1915
paul0a825c72003-05-24 13:48:16 +000019162003-05-24 Kenji Yabuuchi
1917
1918 * ospf_interface.c(ospf_if_lookup_recv_if): Use the most specific
1919 match for interface lookup.
1920
paul551a8972003-05-18 15:22:55 +000019212003-05-18 Hasso Tepper <hasso@estpak.ee>
paul445f1432003-05-16 19:00:31 +00001922
paul551a8972003-05-18 15:22:55 +00001923 * ospf_vty.c: Show NSSA LSA route info in "show ip ospf database"
1924 output
paul445f1432003-05-16 19:00:31 +00001925
pauld7480322003-05-16 17:31:51 +000019262003-05-16 Hasso Tepper <hasso@estpak.ee>
1927
1928 * ospf_lsa.c: Fix handling of NSSA
1929
paul551a8972003-05-18 15:22:55 +000019302003-04-23 Hasso Tepper <hasso@estpak.ee>
1931
1932 * ospf_vty.c: fix "router xxx" node commands in vtysh
1933
paul445f1432003-05-16 19:00:31 +000019342003-04-19 Hasso Tepper <hasso@estpak.ee>
1935
1936 * {ospf_abr,ospfd}.c: area id's DECIMAL -> ADDRESS
1937 * ospf_routemap.c: sync daemon's route-map commands to have same
1938 syntax.
1939
19402003-04-19 Sergey Vyshnevetskiy <serg@vostok.net>
1941
1942 * ospf_packet.c: Add missing param to zlog
1943 * ospf_flood.c: remove unused vars
1944
19452003-04-17 Denis Ovsienko <zebra@pilot.org.ua>
1946
1947 * ospf_interface.c: fix incorrect memset
1948
paul28a13842003-05-16 20:30:37 +000019492003-04-10 Amir Guindehi <amir@datacore.ch>
paul445f1432003-05-16 19:00:31 +00001950
1951 * ospf_lsa.[ch]: opaque LSA fix, use ospf_lookup.
1952
19532003-04-03 David Watson <dwatson@eecs.umich.edu>
1954
1955 * ospf_lsa.c: byte order fix
1956
paul07661cb2003-03-18 00:03:05 +000019572002-03-17 Amir Guindehi <amir@datacore.ch>
1958
1959 * ospf_apiserver.[ch]: Merge Ralph Keller's OSPFAPI support.
1960 * ospf_api.[ch]: Merge Ralph Keller's OSPFAPI support.
1961 * ospfclient: OSPFAPI demonstration client.
1962
19632003-01-23 Masahiko Endo <endo@suri.co.jp>
1964
1965 * ospf_ism.c: NSM event schedule bug fix.
1966
19672002-10-30 Greg Troxel <gdt@ir.bbn.com>
1968
1969 * ospf_packet.c (ospf_make_md5_digest): MD5 length fix.
1970
paul718e3742002-12-13 20:15:29 +000019712002-10-23 endo@suri.co.jp (Masahiko Endo)
1972
1973 * ospf_opaque.c: Update Opaque LSA patch.
1974
19752002-10-23 Ralph Keller <keller@tik.ee.ethz.ch>
1976
1977 * ospf_vty.c (show_ip_ospf_database): Fix CLI parse.
1978
19792002-10-23 Juris Kalnins <juris@mt.lv>
1980
1981 * ospf_interface.c (ospf_if_stream_unset): When write queue
1982 becomes empty stop write timer.
1983
19842002-10-10 Greg Troxel <gdt@ir.bbn.com>
1985
1986 * ospf_packet.c (ospf_check_md5_digest): Change >= to > to make it
1987 conform to RFC.
1988
19892002-07-07 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1990
1991 * zebra-0.93 released.
1992
19932002-06-19 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1994
1995 * ospf_spf.c (ospf_nexthop_calculation): Add NULL set to oi and
1996 check of l2. Reported by: Daniel Drown <dan-zebra@drown.org>
1997 (ospf_lsa_has_link): LSA Length calculation fix. Reported by:
1998 Paul Jakma <paulj@alphyra.ie>.
1999
2000 * ospfd.c (ospf_if_update): Fix nextnode reference bug. Reported
2001 by: juris@mt.lv.
2002
20032002-01-21 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
2004
2005 * ospfd.c: Merge [zebra 11445] Masahiko ENDO's Opaque-LSA support.
2006
20072001-08-27 Kunihiro Ishiguro <kunihiro@zebra.org>
2008
2009 * ospf_interface.c (ospf_add_to_if): Use /32 address to register
2010 OSPF interface information.
2011 (ospf_delete_from_if): Likewise.
2012
2013 * ospf_zebra.c (ospf_interface_address_delete): Likewise.
2014
20152001-08-23 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
2016
2017 * ospf_zebra.c (ospf_redistribute_unset): When redistribute type
2018 is OSPF, do not unset redistribute flag.
2019
20202001-08-19 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
2021
2022 * zebra-0.92a released.
2023
20242001-08-15 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
2025
2026 * zebra-0.92 released.
2027
20282001-08-12 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
2029
2030 * ospfd.c (ospf_config_write): auto-cost reference-bandwidth
2031 configuration display.
2032
20332001-07-24 David Watson <dwatson@eecs.umich.edu>
2034
2035 * ospf_spf.c (ospf_spf_next): Modify ospf_vertex_add_parent to
2036 check for an existing link before connecting the parent and child.
2037 ospf_nexthop_calculation is also modified to check for duplicate
2038 entries when copying from the parent. Finally, ospf_spf_next
2039 removes duplicates when it merges two equal cost candidates.
2040
20412001-07-23 itojun@iijlab.net
2042
2043 * ospfd.c (show_ip_ospf_neighbor): Check ospf_top before use it
2044 [zebra 8549].
2045
20462001-07-23 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
2047
2048 * ospf_packet.c (ospf_write): Remove defined(__OpenBSD__) to make
2049 it work on OpenBSD.
2050
20512001-06-26 Kunihiro Ishiguro <kunihiro@zebra.org>
2052
2053 * ospf_zebra.c (config_write_ospf_default_metric): Display
2054 default-metric configuration.
2055
20562001-06-18 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
2057
2058 * ospf_ia.h (OSPF_EXAMINE_SUMMARIES_ALL): Remove old macros.
2059
20602001-05-28 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
2061
2062 * ospf_snmp.c (ospfIfEntry): Fix interface lookup bug to avoid
2063 crush.
2064 (ospfIfMetricEntry): Likewise.
2065
20662001-03-18 Kunihiro Ishiguro <kunihiro@zebra.org>
2067
2068 * ospf_packet.c (ospf_read): Fix typo. Reported by: "Jen B
2069 Lin'Kova" <jen@stack.net>.
2070
20712001-03-15 Gleb Natapov <gleb@nbase.co.il>
2072
2073 * ospf_interface.c (ip_ospf_network): Set interface parameter.
2074 (interface_config_write): Add check for OSPF_IFTYPE_LOOPBACK.
2075
2076 * ospf_zebra.c (ospf_interface_add): Set interface parameter.
2077
20782001-02-21 Kunihiro Ishiguro <kunihiro@zebra.org>
2079
2080 * ospf_packet.c (ospf_recv_packet): Solaris also need to add
2081 (iph.ip_hl << 2) to iph.ip_len.
2082
20832001-02-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2084
2085 * ospfd.h (OSPF_LS_REFRESH_TIME): Fix OSPF_LS_REFRESH_TIME value.
2086 Suggested by: David Watson <dwatson@eecs.umich.edu>.
2087
2088 * ospf_zebra.c (zebra_init): Remove zebra node.
2089
2090 * ospfd.c (ospf_area_range_set): Function name is changed from
2091 ospf_ara_range_cmd.
2092 (ospf_area_range_unset): New function which separated from DEFUN.
2093 New commands are added:
2094 "no area A.B.C.D range A.B.C.D/M advertise"
2095 "no area <0-4294967295> range A.B.C.D/M advertise"
2096 "no area A.B.C.D range A.B.C.D/M not-advertise"
2097 "no area <0-4294967295> range A.B.C.D/M not-advertise"
2098
2099 * ospf_lsa.c (ospf_lsa_more_recent): Fix previous change.
2100
21012001-02-08 Matthew Grant <grantma@anathoth.gen.nz>
2102
2103 * ospf_network.c (ospf_if_add_allspfrouters): Use
2104 setsockopt_multicast_ipv4.
2105 (ospf_if_drop_allspfrouters): Likewise.
2106
2107 * ospf_lsa.c (ospf_router_lsa_install): Add rt_recalc flag.
2108 (ospf_network_lsa_install): Likewise.
2109 (ospf_summary_lsa_install): Likewise.
2110 (ospf_summary_asbr_lsa_install): Likewise.
2111 (ospf_external_lsa_install): Likewise.
2112 (ospf_lsa_install): Call ospf_lsa_different to check this LSA is
2113 new one or not.
2114
21152001-02-08 Kunihiro Ishiguro <kunihiro@zebra.org>
2116
2117 * ospf_zebra.c (ospf_interface_delete): Do not free interface
2118 structure when ospfd receive interface delete message to support
2119 pseudo interface.
2120
21212001-02-01 Dick Glasspool <dick@ipinfusion.com>
2122
2123 * ospfd.c (area_range_notadvertise): Change area range "suppress"
2124 command to "not-advertise".
2125
2126 * ospfd.h (OSPF_LS_REFRESH_TIME): Change OSPF_LS_REFRESH_TIME from
2127 1800 to 60.
2128
2129 * ospf_abr.c (ospf_abr_update_aggregate): When update_aggregate is
2130 updating the area-range, the lowest cost is now saved.
2131
2132 * ospf_lsa.c (ospf_lsa_more_recent): Routing to compare sequence
2133 numbers rather than creating overflow during calculation.
2134
21352001-02-01 Kunihiro Ishiguro <kunihiro@zebra.org>
2136
2137 * zebra-0.91 is released.
2138
21392001-01-31 Kunihiro Ishiguro <kunihiro@zebra.org>
2140
2141 * ospf_packet.c (ospf_db_desc_proc): Do not continue process when
2142 NSM_SeqNumberMismatch is scheduled.
2143 (ospf_ls_req): Free ls_upd when return from this function.
2144 (ospf_ls_upd_timer): When update list is empty do not call
2145 ospf_ls_upd_send(). Suggested by: endo@suri.co.jp (Masahiko
2146 Endo).
2147
21482001-01-26 Kunihiro Ishiguro <kunihiro@zebra.org>
2149
2150 * ospf_lsa.c (ospf_maxage_flood): Flood LSA when it reaches
2151 MaxAge. RFC2328 Section 14.
2152 (ospf_maxage_lsa_remover): Call above function during removing
2153 MaxAge LSA.
2154
21552001-01-26 Dick Glasspool <dick@ipinfusion.com>
2156
2157 * ospf_flood.c (ospf_flood_through_as): Function is updated for
2158 NSSA Translations now done at ospf_abr.c with no change in P-bit.
2159
2160 * ospf_lsa.c (ospf_get_nssa_ip): Get 1st IP connection for Forward
2161 Addr.
2162 (ospf_install_flood_nssa): Leave Type-7 LSA at Lock Count = 2.
2163
2164 * ospf_ase.c (ospf_ase_calculate_route): Add debug codes.
2165
2166 * ospf_abr.c (ospf_abr_translate_nssa): Recalculate LSA checksum.
2167
2168 * ospf_packet.h (OSPF_SEND_PACKET_LOOP): Added for test packet.
2169
2170 * ospf_dump.c (ospf_lsa_type_msg): Add OSPF_GROUP_MEMBER_LSA and
2171 OSPF_AS_NSSA_LSA.
2172
2173 * ospfd.c (data_injection): Function to inject LSA. This is
2174 debugging command.
2175
21762001-01-11 Kunihiro Ishiguro <kunihiro@zebra.org>
2177
2178 * ospf_route.c (ospf_route_match_same): Remove function.
2179 (ospf_route_match_same_new): Renamed to ospf_route_match_same.
2180
2181 * ospf_zebra.c (ospf_interface_address_delete): Add check for
2182 oi->address. Suggested by Matthew Grant
2183 <grantma@anathoth.gen.nz>.
2184 (ospf_zebra_add): Remove function.
2185 (ospf_zebra_add_multipath): Rename to ospf_zebra_add.
2186
2187 * ospf_interface.c: Remove HAVE_IF_PSEUDO part.
2188
2189 * ospf_zebra.c: Likewise.
2190
21912001-01-10 Kunihiro Ishiguro <kunihiro@zebra.org>
2192
2193 * ospf_ase.c: Remove OLD_RIB part.
2194
2195 * ospf_route.c: Likewise.
2196
2197 * zebra-0.90 is released.
2198
2199 * ospf_packet.c (ospf_recv_packet): Use ip_len adjestment code to
2200 NetBSD.
2201
22022001-01-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2203
2204 * ospf_route.c (ospf_route_delete): Use
2205 ospf_zebra_delete_multipath.
2206
22072001-01-09 Matthew Grant <grantma@anathoth.gen.nz>
2208
2209 * ospf_interface.c (ospf_if_cleanup): Function name is renamed
2210 from ospf_if_free(). Rewrite whole procudure to support primary
2211 address deletion.
2212
2213 * ospf_zebra.c (ospf_interface_address_delete): Add primary
2214 address deletion process.
2215
22162001-01-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2217
2218 * ospf_packet.c (ospf_recv_packet): OpenBSD has same ip_len
2219 treatment like FreeBSD.
2220
22212001-01-09 endo@suri.co.jp (Masahiko Endo)
2222
2223 * ospf_packet.c (ospf_recv_packet): FreeBSD kernel network code
2224 strips IP header size from receiving IP Packet. So we adjust
2225 ip_len to whole IP packet size by adding IP header size.
2226
22272001-01-08 endo@suri.co.jp (Masahiko Endo)
2228
2229 * ospf_network.c (ospf_serv_sock): When socket() is failed return
2230 immediately.
2231 (ospf_serv_sock): Close socket when it is not used.
2232
2233 * ospf_packet.c (ospf_write): Set sin_len when HAVE_SIN_LEN is
2234 defined.
2235 (ospf_write): When bind is fined, close sock.
2236
22372001-01-07 Gleb Natapov <gleb@nbase.co.il>
2238
2239 * ospf_zebra.c (ospf_interface_state_up): Fixes coredump that
2240 appears when you try to configure bandwidth on the ppp interface
2241 that is not yet configured in ospfd.
2242
22432001-01-07 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2244
2245 * ospf_route.c (show_ip_ospf_route_external): "show ip ospf route"
2246 will print nexthops for AS-external routes.
2247
2248 * ospf_ase.c (ospf_ase_route_match_same): New function to compare
2249 ASE route under multipath environment.
2250 (ospf_ase_compare_tables): Likewise.
2251
22522001-01-01 Kunihiro Ishiguro <kunihiro@zebra.org>
2253
2254 * ospfd.h (OSPF_VTYSH_PATH): Change "/tmp/ospfd" to "/tmp/.ospfd".
2255
22562000-12-28 Kunihiro Ishiguro <kunihiro@zebra.org>
2257
2258 * ospf_route.c (ospf_route_install): Install multipath information
2259 to zebra daemon.
2260
2261 * ospf_zebra.c (ospf_zebra_add_multipath): Function for passing
2262 multipath information to zebra daemon.
2263
22642000-12-25 Dick Glasspool <dick@ipinfusion.com>
2265
2266 * ospf_packet.c (ospf_write): Call ospf_packet_delete when sendto
2267 fail.
2268 (DISCARD_LSA): Add argument N for logging point of DISCARD_LSA is
2269 called.
2270
2271 * ospf_lsa.c (ospf_external_lsa_refresh): NSSA install_flood will
2272 leave Type-7 LSA at Lock Count = 2.
2273
2274 * ospf_flood.c (ospf_flood_through): Flood_though_as updated for
2275 NSSA no P-bit off during Area flooding, but P-bit is turned off
2276 for mulitple NSSA AS flooding.
2277
2278 * ospf_ase.c (ospf_ase_calculate_timer): Added calculations for
2279 Type-7 LSDB.
2280
2281 * ospf_abr.c (ospf_abr_translate_nssa): Removed one unlock call.
2282 (ospf_abr_announce_nssa_defaults): Corrected Debug from EVENT to
2283 NSSA.
2284
22852000-12-25 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2286
2287 * ospf_zebra.c (ospf_zebra_read_ipv4): Checking the age of the
2288 found LSA and if the LSA is MAXAGE we should call refresh instead
2289 of originate.
2290
22912000-12-18 Dick Glasspool <dick@ipinfusion.com>
2292
2293 * ospf_abr.c: Removed redundant "...flood" in
2294 announce_network_to_area(). Repaired nssa Unlock by using
2295 discard.
2296
2297 * ospf_packet.c: Removed old NSSA translate during mk_ls_update.
2298
2299 * ospfd.c: Free up all data bases including NSSA.
2300
2301 * ospf_lsa.c: Now allow removal of XLATE LSA's Check in
2302 discard_callback. Added routine to get ip addr from within the
2303 ifp.
2304
2305 * ospf_flood.c: Now set Forward Address for outgoing Type-7.
2306
2307 * ospf_lsa.h: Added prototype for the below. struct in_addr
2308 ospf_get_ip_from_ifp (struct interface *ifp).
2309
23102000-12-14 Gleb Natapov <gleb@nbase.co.il>
2311
2312 * ospf_packet.c (ospf_recv_packet): New OSPF pakcet read method.
2313 Now maximum packet length may be 65535 bytes (maximum IP packet
2314 length).
2315
2316 * ospf_interface.c (ospf_if_stream_set): Don't make input buffer.
2317
2318 * ospfd.c (config_write_network_area): Remove unnecessary area
2319 lookup code.
2320
23212000-12-13 Kunihiro Ishiguro <kunihiro@zebra.org>
2322
2323 * ospf_packet.c (ospf_read): Accept packet bigger than MTU value.
2324
23252000-12-13 Gleb Natapov <gleb@nbase.co.il>
2326
2327 * ospfd.c (config_write_network_area): Fix bug in
2328 config_write_network_area function.
2329
23302000-12-12 Gleb Natapov <gleb@nbase.co.il>
2331
2332 * ospf_abr.c (ospf_abr_announce_network_to_area): Make Summary
2333 LSA's origination and refreshment as same as other type of LSA.
2334
2335 * ospf_lsa.c (ospf_summary_lsa_refresh): Return struct ospf_lsa *.
2336
2337 * ospf_lsa.c (ospf_summary_asbr_lsa_refresh): Likewise.
2338
23392000-12-08 Dick Glasspool <dick@ipinfusion.com>
2340
2341 The bulk of NSSA changes are contained herein; This version will
2342 require manual setting of "always" for NSSA Translator, and will
2343 not perform aggregation yet.
2344
2345 * ospf_dump.c: "debug ospf nssa" is added.
2346
2347 * ospf_dump.h: Likewise.
2348
2349 * ospf_packet.c (ospf_hello): Display router ID on Bad NSSA Hello.
2350
2351 * ospfd.c: Discard_LSA to stay away from LOCAL_XLT Process NSSA
2352 'never, candidate, always'. Change "suppress" to "not-advertise".
2353
2354 * ospfd.h: Add TranslatorRole to struct ospf_area. Add anyNSSA to
2355 struct ospf.
2356
2357 * ospf_ase.c (ospf_ase_calculate_route): External to stay away
2358 from LOCAL_XLT
2359
2360 * ospf_nsm.c (ospf_db_summary_add): External to stay away from
2361 LOCAL_XLT
2362
2363 * ospf_abr.c: Major logic added for abr_nssa_task(). If ABR, and
2364 NSSA translator, then do it. Approve the global list, and flush
2365 any unapproved.
2366
2367 * ospf_lsa.h: New LSA flag OSPF_LSA_LOCAL_XLT to indicate that the
2368 Type-5 resulted from a Local Type-7 translation; not used for
2369 flooding, but used for flushing.
2370
2371 * ospf_flood.c: New NSSA flooding.
2372
23732000-12-08 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2374
2375 * ospfd.c (ospf_find_vl_data): New function for looking up virtual
2376 link data.
2377 (ospf_vl_set_security): Virtual link configuration with
2378 authentication.
2379 (ospf_vl_set_timers): Set timers for virtual link.
2380
2381 * New commands are added.
2382 "area A.B.C.D virtual-link A.B.C.D"
2383 "area A.B.C.D virtual-link A.B.C.D hello-interval <1-65535> retransmit-interval <3-65535> transmit-delay <1-65535> dead-interval <1-65535>"
2384 "area A.B.C.D virtual-link A.B.C.D hello-interval <1-65535> retransmit-interval <3-65535> transmit-delay <1-65535> dead-interval <1-65535> authentication-key AUTH_KEY"
2385 "area A.B.C.D virtual-link A.B.C.D authentication-key AUTH_KEY"
2386 "area A.B.C.D virtual-link A.B.C.D hello-interval <1-65535> retransmit-interval <3-65535> transmit-delay <1-65535> dead-interval <1-65535> message-digest-key <1-255> md5 KEY"
2387 "area A.B.C.D virtual-link A.B.C.D message-digest-key <1-255> md5 KEY"
2388
2389 * ospf_packet.c (ospf_check_md5_digest): Add neighbor's
2390 cryptographic sequence number treatment.
2391 (ospf_check_auth): OSPF input buffer is added to argument.
2392 (ospf_read): Save neighbor's cryptographic sequence number.
2393
2394 * ospf_nsm.c (nsm_change_status): Clear cryptographic sequence
2395 number when neighbor status is changed to NSM down.
2396
2397 * ospf_neighbor.c (ospf_nbr_new): Set zero to crypt_seqnum.
2398
2399 * ospf_neighbor.h (struct ospf_neighbor): Add cryptographic
2400 sequence number to neighbor structure.
2401
24022000-11-29 Kunihiro Ishiguro <kunihiro@zebra.org>
2403
2404 * ospf_snmp.c (ospfIfLookup): OSPF MIB updates.
2405 (ospfExtLsdbEntry): Add OspfExtLsdbTable treatment.
2406
24072000-11-28 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2408
2409 * ospfd.c (ospf_interface_down): Clear a ls_upd_queue queue of the
2410 interface.
2411 (ospf_ls_upd_queue_empty): New function to empty ls update queue
2412 of the OSPF interface.
2413 (no_router_ospf): 'no router ospf' unregister redistribution
2414 requests from zebra.
2415
24162000-11-28 Kunihiro Ishiguro <kunihiro@zebra.org>
2417
2418 * ospf_ism.c (ism_change_status): Increment status change number.
2419
2420 * ospf_interface.h (struct ospf_interface): Add new member for
2421 status change statistics.
2422
2423 * Makefile.am: Update dependencies.
2424
2425 * ospf_zebra.c (ospf_interface_add): OSPF SNMP interface update.
2426 (ospf_interface_delete): OSPF SNMP interface delete.
2427
2428 * ospf_snmp.h: New file is added.
2429
24302000-11-23 Dick Glasspool <dick@ipinfusion.com>
2431
2432 * ospfd.h: Add new ospf_area structure member for
2433 NSSATranslatorRole and NSSATranslator state.
2434
2435 * ospfd.c: Provided for eventual commands to specify NSSA
2436 elections for "translator- ALWAYS/NEVER/CANDIDATE". Provided for
2437 decimal integer version of area-suppress.
2438
2439 * ospf_flood.c: Flood Type-7's only into NSSA (not AS).
2440
2441 * ospf_lsa.c: Undo some previous changes for NSSA. If NSSA
2442 translator, advertise Nt bit.
2443
2444 * ospf_route.c: 1st version of "sh ip os border-routers".
2445
24462000-11-23 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2447
2448 * ospfd.c (area_vlink): Virtual link can not configured in stub
2449 area.
2450
24512000-11-23 Gleb Natapov <gleb@nbase.co.il>
2452
2453 * ospf_packet.c (ospf_db_desc): In states Loading and Full the
2454 slave must resend its last Database Description packet in response
2455 to duplicate Database Description packets received from the
2456 master. For this reason the slave must wait RouterDeadInterval
2457 seconds before freeing the last Database Description packet.
2458 Reception of a Database Description packet from the master after
2459 this interval will generate a SeqNumberMismatch neighbor
2460 event. RFC2328 Section 10.8
2461 (ospf_make_db_desc): DD Master flag treatment.
2462
2463 * ospf_nsm.c (nsm_twoway_received): Move DD related procedure to
2464 nsm_change_status().
2465 (nsm_bad_ls_req): Likewise.
2466 (nsm_adj_ok): Likewise.
2467 (nsm_seq_number_mismatch): Likewise.
2468 (nsm_oneway_received): Likewise.
2469
2470 * ospf_neighbor.h (struct ospf_neighbor): New structure member
2471 last_send_ts for timestemp when last Database Description packet
2472 was sent.
2473
2474 * ospf_nsm.c (ospf_db_desc_timer): Make it sure nbr->last_send is
2475 there. Call ospf_db_desc_resend() in any case.
2476
24772000-11-16 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2478
2479 * ospf_lsa.c (lsa_link_broadcast_set): When there is no DR on
2480 network (suppose you have only one router with interface priority
2481 0). It's router LSA does not contain the link information about
2482 this network.
2483
2484 * ospf_nsm.c (nsm_timer_set): When you change a priority of
2485 interface from/to 0 ISM_NeighborChange event should be scheduled
2486 in order to elect new DR/BDR on the network.
2487
2488 * ospf_interface.c (ip_ospf_priority): Likewise.
2489
2490 * ospf_flood.c (ospf_ls_retransmit_add): When we add some LSA into
2491 retransmit list we need to check whether the present old LSA in
2492 retransmit list is not more recent than the new
2493 one.
2494
24952000-11-09 Dick Glasspool <dick@ipinfusion.com>
2496
2497 * ospf_packet.c: Allows for NSSA Type-7 LSA's throughout the NSSA
2498 area. Any that exit the NSSA area are translated to type-5 LSA's.
2499 The instantiated image is restored after translation.
2500 (ospf_ls_upd_send_list): Renamed to ospf_ls_upd_queu_send().
2501 (ospf_ls_upd_send): Old function which enclosed by #ifdef 0 is
2502 removed.
2503 (ospf_ls_ack_send): Likewise.
2504
2505 * ospf_flood.c: NSSA-LSA's without P-bit will be restricted to
2506 local area. Otherwise they are allowed out the area to be
2507 translated by ospf_packet.c.
2508
2509 * ospf_lsa.c: Undo some previous changes for NSSA.
2510
2511 * ospf_lsdb.h: New access for type 7.
2512
25132000-11-07 Kunihiro Ishiguro <kunihiro@zebra.org>
2514
2515 * ospf_route.c (ospf_path_exist): New function to check nexthop
2516 and interface are in current OSPF path or not.
2517 (ospf_route_copy_nexthops_from_vertex): Add nexthop to OSPF path
2518 when it is not there. Reported by Michael Rozhavsky
2519 <mrozhavsky@opticalaccess.com>
2520
25212000-11-06 Kunihiro Ishiguro <kunihiro@zebra.org>
2522
2523 * ospf_dump.c (config_write_debug): Add seventh string "detail" is
2524 added for flag is OSPF_DEBUG_SEND | OSPF_DEBUG_RECV |
2525 OSPF_DEBUG_DETAIL.
2526
25272000-11-06 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2528
2529 * ospf_lsa.c (router_lsa_flags): ASBR can't exit in stub area.
2530
25312000-11-06 Kunihiro Ishiguro <kunihiro@zebra.org>
2532
2533 * ospf_lsa.c (ospf_router_lsa_originate): Reduce unconditional
2534 logging.
2535
25362000-11-06 Dick Glasspool <dick@ipinfusion.com>
2537
2538 * ospfd.h: Add ait_ntoa function prototype.
2539
2540 * ospfd.c (ait_ntoa): New function for displaying area ID and
2541 Stub/NSSA status.
2542 (show_ip_ospf_interface_sub): Use ait_ntoa.
2543 (show_ip_ospf_nbr_static_detail_sub): Likewise.
2544 (show_ip_ospf_neighbor_detail_sub): Likewise.
2545
2546 * ospf_route.c (ospf_intra_route_add): Set external routing type
2547 to ospf route.
2548 (ospf_intra_add_router): Likewise.
2549 (ospf_intra_add_transit): Likewise.
2550 (ospf_intra_add_stub): Likewise.
2551 (ospf_add_discard_route): Likewise.
2552 (show_ip_ospf_route_network): Use ait_ntoa.
2553 (show_ip_ospf_route_network): Likewise.
2554 (show_ip_ospf_route_router): Likewise.
2555
2556 * ospf_lsa.c (show_lsa_detail): Use ait_ntoa.
2557 (show_lsa_detail_adv_router): Likewise.
2558 (show_ip_ospf_database_summary): Likewise.
2559
2560 * ospf_route.h (struct route_standard): Add new member
2561 external_routing.
2562
2563 * ospf_ia.c (process_summary_lsa): Set external routing tyep to ospf
2564 route.
2565 (ospf_update_network_route): Likewise.
2566 (ospf_update_router_route): Likewise.
2567
25682000-11-04 Kunihiro Ishiguro <kunihiro@zebra.org>
2569
2570 * ospf_flood.c (ospf_process_self_originated_lsa): Enclose
2571 OSPF_AS_NSSA_LSA treatment with #ifdef HAVE_NSSA.
2572
25732000-11-03 Kunihiro Ishiguro <kunihiro@zebra.org>
2574
2575 * Unconditional logging is enclosed with if (IS_DEBUG_OSPF_EVENT).
2576 Please specify "debug ospf event" for enable logging.
2577
2578 * ospf_ism.c: Do not extern debug flag varible. It is done by
2579 ospf_debug.h
2580 * ospf_asbr.c: Likewise.
2581 * ospf_lsa.c: Likewise.
2582 * ospf_nsm.c: Likewise.
2583 * ospf_zebra.c: Likewise.
2584
2585 * ospf_dump.c (debug_ospf_event): New command "debug ospf event"
2586 is added.
2587
2588 * ospfd.c (router_ospf): Change logging from vty_out() to
2589 zlog_info().
2590 (ospf_area_stub_cmd): Likewise.
2591
2592 * ospf_dump.h: Extern term_debug flags.
2593 (OSPF_DEBUG_EVENT): Add new flag.
2594 (IS_DEBUG_OSPF_EVENT): Add new macro.
2595
25962000-11-03 Dick Glasspool <dick@ipinfusion.com>
2597
2598 * ospf_flood.c (ospf_process_self_originated_lsa):
2599 OSPF_AS_NSSA_LSA is treated as same as OSPF_AS_EXTERNAL_LSA.
2600 (ospf_flood): Type-5's have no change. Type-7's can be received,
2601 and will Flood the AS as Type-5's They will also flood the local
2602 NSSA Area as Type-7's. The LSDB will be updated as Type-5's, and
2603 during re-fresh will be converted back to Type-7's (if within an
2604 NSSA).
2605 (ospf_flood_through): Incoming Type-7's were allowed here if our
2606 neighbor was an NSSA. So Flood our area with the Type-7 and also
2607 if we are an ABR, flood thru AS as Type-5.
2608
2609 * ospf_lsa.c (ospf_external_lsa_refresh): Flood NSSA both NSSA
2610 area and other area.
2611
2612 * ospf_packet.c (ospf_db_desc_proc): When AS External LSA is
2613 exists in DD packet, make it sure that this area is not stub.
2614 (ospf_ls_upd_list_lsa): When LSA type is NSSA then set lsa's area
2615 to NULL.
2616 (ospf_ls_upd): If the LSA is AS External LSA and the area is stub
2617 then discard the lsa. If the LSA is NSSA LSA and the area is not
2618 NSSA then discard the lsa.
2619
26202000-11-03 Kunihiro Ishiguro <kunihiro@zebra.org>
2621
2622 * ospfd.c (ospf_interface_run): Fix bug of Hello packet's option
2623 is not properly set when interface comes up.
2624
26252000-11-02 Kunihiro Ishiguro <kunihiro@zebra.org>
2626
2627 * ospfd.h (OSPF_OPTION_O): Add new hello header option.
2628
26292000-11-01 Dick Glasspool <dick@ipinfusion.com>
2630
2631 * ospf_lsa.h: Define OSPF_MAX_LSA to 8 when HAVE_NSSA is enabled.
2632 (OSPF_GROUP_MEMBER_LSA): Define OSPF_GROUP_MEMBER_LSA.
2633
2634 * ospf_lsa.c (show_database_desc): Add "Group Membership LSA"
2635 string.
2636
26372000-10-31 Dick Glasspool <dick@ipinfusion.com>
2638
2639 * ospf_lsa.h (OSPF_AS_NSSA_LSA): Define OSPF_AS_NSSA_LSA.
2640
2641 * ospf_lsa.c (show_ip_ospf_database): NSSA database display
2642 function is added. ALIASES which have "show ip ospf database
2643 nssa-external" is added.
2644 (show_ip_ospf_border_routers): New command "show ip ospf
2645 border-routers" is added.
2646
26472000-10-30 Dick Glasspool <dick@ipinfusion.com>
2648
2649 * ospfd.c (router_ospf): NSSA Enabled message is added for
2650 testing.
2651 (ospf_area_type_set): Are type set for NSSA area.
2652 (ospf_area_stub_cmd): Special translation of no_summary into NSSA
2653 and summary information. If NSSA is enabled pass the information
2654 to ospf_area_type_set().
2655 (area_nssa): New commands are added:
2656 "area A.B.C.D nssa"
2657 "area <0-4294967295> nssa"
2658 "area A.B.C.D nssa no-summary"
2659 "area <0-4294967295> nssa no-summary"
2660 (ospf_no_area_stub_cmd): Special translation of no_summary into
2661 NSSA and summary information. If external_routing is
2662 OSPF_AREA_NSSA unset area with ospf_area_type_set (area,
2663 OSPF_AREA_DEFAULT).
2664 (show_ip_ospf_area): Display NSSA status.
2665 (config_write_ospf_area): Show NSSA configuration.
2666
2667 * ospf_packet.c (ospf_hello): For NSSA support, ensure that NP is
2668 on and E is off.
2669
26702000-10-26 Gleb Natapov <gleb@nbase.co.il>
2671
2672 * ospf_lsa.c (ospf_network_lsa_body_set): The network-LSA lists
2673 those routers that are fully adjacent to the Designated Router;
2674 each fully adjacent router is identified by its OSPF Router ID.
2675 The Designated Router includes itself in this list. RFC2328,
2676 Section 12.4.2.
2677
26782000-10-23 Jochen Friedrich <jochen@scram.de>
2679
2680 * ospf_snmp.c: ospf_oid and ospfd_oid are used in smux_open after
2681 it is registered. So those variables must be static.
2682
26832000-10-18 K N Sridhar <sridhar@euler.ece.iisc.ernet.in>
2684
2685 * ospfd.c: Add area_default_cost_decimal_cmd and
2686 no_area_default_cost_decimal_cmd alias.
2687
26882000-10-05 Gleb Natapov <gleb@nbase.co.il>
2689
2690 * ospfd.c (ospf_network_new): Fix setting area format.
2691 (no_router_ospf): Check area existance when calling
2692 ospf_interface_down().
2693
2694 * ospf_flood.c (ospf_external_info_check): Fix bug of refreshing
2695 default route.
2696
26972000-10-02 Kunihiro Ishiguro <kunihiro@zebra.org>
2698
2699 * zebra-0.89 is released.
2700
27012000-09-29 Kunihiro Ishiguro <kunihiro@zebra.org>
2702
2703 * ospf_snmp.c (ospfHostEntry): OSPF Host MIB is implemented.
2704
2705 * ospfd.c (ospf_nbr_static_cmp): OSPF neighbor is sorted by it's
2706 address.
2707
27082000-09-28 Michael Rozhavsky <mike@nbase.co.il>
2709
2710 * ospf_interface.c (ospf_if_free): Fix deleting self neighbor twice.
2711
27122000-09-27 Kunihiro Ishiguro <kunihiro@zebra.org>
2713
2714 * ospf_packet.c (ospf_read): Solaris on x86 has ip_len with host
2715 byte order.
2716
27172000-09-25 Toshiaki Takada <takada@zebra.org>
2718
2719 * ospfd.c (ospf_compatible_rfc1583), (no_ospf_compatible_rfc1583):
2720 Add CISCO compatible command.
2721
27222000-09-25 Kunihiro Ishiguro <kunihiro@zebra.org>
2723
2724 * ospf_abr.c (ospf_area_range_lookup): New function is added for
2725 area range lookup in OSPF-MIB.
2726 (ospf_area_range_lookup_next): Likewise.
2727
27282000-09-22 Kunihiro Ishiguro <kunihiro@zebra.org>
2729
2730 * ospfd.c (no_router_ospf): Delete virtual link before deleting
2731 area structure.
2732
2733 * ospf_lsa.c (ospf_external_lsa_refresh_type): Check
2734 EXTERNAL_INFO(type).
2735
2736 * ospfd.c (no_router_ospf): Call ospf_vl_delete() instead of
2737 ospf_vl_data_free().
2738
2739 * ospf_interface.c (ospf_vl_shutdown): Execute ISM_InterfaceDown
2740 when ospf_vl_shutdown is called.
2741 (ospf_vl_delete): Call ospf_vl_shutdown() to delete virtual link
2742 interface's thread.
2743
27442000-09-21 Gleb Natapov <gleb@nbase.co.il>
2745
2746 * ospf_lsa.c: New implementation of OSPF refresh.
2747
27482000-09-20 Kunihiro Ishiguro <kunihiro@zebra.org>
2749
2750 * ospf_snmp.c (ospfLsdbLookup): Add LSDB MIB implementation.
2751
27522000-09-18 Kunihiro Ishiguro <kunihiro@zebra.org>
2753
2754 * ospf_snmp.c (ospfStubAreaEntry): Add OSPF stub area MIB.
2755
27562000-09-18 Gleb Natapov <gleb@nbase.co.il>
2757
2758 * ospf_route.h (route_standard): Change member from `struct area'
2759 to area_id.
2760
2761 * ospf_abr.c (ospf_abr_announce_network), (ospf_abr_should_announce),
2762 (ospf_abr_process_network_rt), (ospf_abr_announce_rtr),
2763 (ospf_abr_process_router_rt):
2764 * ospf_ase.c (ospf_find_asbr_route),
2765 (ospf_find_asbr_router_through_area),
2766 * ospf_ia.c (ospf_find_abr_route), (ospf_ia_router_route),
2767 (process_summary_lsa), (ospf_update_network_route),
2768 (ospf_update_router_route):
2769 * ospf_route.c (ospf_intra_route_add), (ospf_intra_add_router),
2770 (ospf_intra_add_transit), (ospf_intra_add_stub),
2771 (ospf_route_table_dump), (show_ip_ospf_route_network),
2772 (show_ip_ospf_route_router), (ospf_asbr_route_cmp),
2773 (ospf_prune_unreachable_routers):
2774 * ospf_spf.c (ospf_rtrs_print):
2775 * ospfd.c (ospf_rtrs_free): Fix the struct change above.
2776
27772000-09-14 Kunihiro Ishiguro <kunihiro@zebra.org>
2778
2779 * ospf_network.c (ospf_serv_sock_init): Enclose SO_BINDTODEVICE
2780 with ifdef.
2781
27822000-09-13 Gleb Natapov <gleb@nbase.co.il>
2783
2784 * ospf_ism.c (ospf_elect_dr), (ospf_elect_bdr): Fix DR election.
2785
2786 * ospf_network.c (ospf_serv_sock_init): Add socket option
2787 SO_BINDTODEVICE on read socket.
2788
2789 * ospf_packet.c (ospf_hello): Ignore Hello packet if E-bit does
2790 not match.
2791
2792 * ospfd.c (ospf_area_check_free), (ospf_area_get),
2793 (ospf_area_add_if): New function added.
2794
27952000-09-13 Kunihiro Ishiguro <kunihiro@zebra.org>
2796
2797 * ospf_route.c (ospf_intra_add_router): Update ABR and ASBR router
2798 count.
2799
2800 * ospf_spf.c (ospf_spf_init): Rest ABR and ASBR router count
2801 starting SPF calculation.
2802
2803 * ospfd.h (struct ospf_area): Add ABR and ASBR router count.
2804
28052000-09-12 Kunihiro Ishiguro <kunihiro@zebra.org>
2806
2807 * ospfd.c (ospf_area_id_cmp): New area structure is sorted by area
2808 ID.
2809
2810 * ospf_lsa.c (ospf_router_lsa_originate): For OSPF MIB update
2811 lsa_originate_count.
2812 (ospf_network_lsa_originate): Likewise.
2813 (ospf_summary_lsa_originate): Likewise.
2814 (ospf_summary_asbr_lsa_originate): Likewise.
2815 (ospf_external_lsa_originate): Likewise.
2816
28172000-09-11 Kunihiro Ishiguro <kunihiro@zebra.org>
2818
2819 * ospf_snmp.c (ospf_variables): ospfRouterID's type RouterID
2820 syntax is IpAddress.
2821 (ospf_admin_stat): New function for OSPF administrative status
2822 check.
2823
28242000-09-10 Jochen Friedrich <jochen@scram.de>
2825
2826 * ospf_snmp.c: Implement OSPF MIB skeleton.
2827
28282000-09-08 Kunihiro Ishiguro <kunihiro@zebra.org>
2829
2830 * ospf_snmp.c: New file is added.
2831
28322000-09-07 David Lipovkov <davidl@nbase.co.il>
2833
2834 * ospf_zebra.c (ospf_interface_delete): Add pseudo interface
2835 treatment.
2836
2837 * ospf_interface.c (interface_config_write): Likewise.
2838
28392000-08-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2840
2841 * zebra-0.88 is released.
2842
28432000-08-17 Michael Rozhavsky <mike@nbase.co.il>
2844
2845 * ospfd.c (ospf_area_free): Remove virtual link configuration only
2846 when Area is removed.
2847
28482000-08-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2849
2850 * ospfd.c (network_area): Revert check for EXTERNAL_INFO
2851 (ZEBRA_ROUTE_CONNECT).
2852 (no_network_area): Likewise.
2853
28542000-08-16 Kunihiro Ishiguro <kunihiro@zebra.org>
2855
2856 * ospfd.h (struct ospf): Add distance_table and
2857 distance_{all,intra,inter,external}.
2858
2859 * ospf_zebra.c: Add OSPF distance related functions.
2860
28612000-08-15 Gleb Natapov <gleb@nbase.co.il>
2862
2863 * ospf_asbr.c (ospf_external_info_find_lsa): New function added.
2864
2865 * ospf_lsa.c (ospf_default_external_info),
2866 (ospf_default_originate_timer), (ospf_external_lsa_refresh_default):
2867 New function added.
2868
2869 * ospf_zebra.c
2870 (ospf_default_information_originate_metric_type_routemap),
2871 (ospf_default_information_originate_always_metric_type_routemap):
2872 Change name and add route-map function.
2873 (ospf_default_information_originate_metric_routemap),
2874 (ospf_default_information_originate_routemap),
2875 (ospf_default_information_originate_type_metric_routemap):
2876 New DEFUN added.
2877
28782000-08-14 Kunihiro Ishiguro <kunihiro@zebra.org>
2879
2880 * ospf_zebra.c (zebra_interface_if_set_value): Change ifindex
2881 restore size from two octet to four.
2882
28832000-08-14 Michael Rozhavsky <mike@nbase.co.il>
2884
2885 * ospf_ase.c (ospf_ase_incremental_update): Implement incremental
2886 AS-external-LSA in 16.6 of RFC2328.
2887
28882000-08-14 Matthew Grant <grantma@anathoth.gen.nz>
2889
2890 * ospf_interface.c (ospf_if_get_output_cost): Change cost
2891 calculation algorithm.
2892
2893 * ospf_packet (ospf_ls_upd): Fix problem of LSA retransmitting.
2894
28952000-08-11 Michael Rozhavsky <mike@nbase.co.il>
2896
2897 * ospf_lsa.c (ospf_maxage_lsa_remover): Fix maxage remover for
2898 AS-external-LSAs.
2899
29002000-08-10 Toshiaki Takada <takada@zebra.org>
2901
2902 * ospfd.c (auto_cost_reference_bandwidth): New DEFUN added.
2903 `auto-cost reference-bandwidth' OSPF router command added.
2904
29052000-08-08 Gleb Natapov <gleb@nbase.co.il>
2906
2907 * ospf_routemap.c (ospf_route_map_update): New function added.
2908 Add route-map event hook.
2909
29102000-08-08 Toshiaki Takada <takada@zebra.org>
2911
2912 * ospf_zebra.c (ospf_distribute_check_connected): If redistribute
2913 prefix is connected route on OSPF enabled interface, suppress to
2914 announce it.
2915
29162000-08-08 Matthew Grant <grantma@anathoth.gen.nz>
2917
2918 * ospf_interface.c (ospf_if_get_output_cost):
2919 New function added. Handle bandwidth parameter for cost
2920 calculation.
2921
29222000-08-08 Michael Rozhavsky <mike@nbase.co.il>
2923
2924 * ospf_interface.c (interface_config_write): Show interface
2925 configuration regardless interface is down.
2926
2927 * ospf_ase.c (ospf_ase_caocluate_route): Whole rewritten external
2928 route calculate function.
2929
29302000-08-08 Gleb Natapov <gleb@nbase.co.il>
2931
2932 * ospf_routemap.c: New file added.
2933
2934 * ospf_asbr.c (ospf_reset_route_map_set_values),
2935 (ospf_route_map_set_compare): New function added.
2936
2937 * ospf_lsa.c (ospf_external_lsa_body_set): Set routemap metric
2938 with AS-external-LSA.
2939
29402000-08-05 Kunihiro Ishiguro <kunihiro@zebra.org>
2941
2942 * ospf_ase.c (ospf_ase_calculate_route_add): Pass new->cost to
2943 ospf_zebra_add as metric.
2944 (ospf_ase_calculate_route_add): Likewise.
2945
2946 * ospf_route.c (ospf_route_install): Pass or->cost to
2947 ospf_zebra_add as metric.
2948
2949 * ospf_zebra.c (ospf_zebra_add): Add metric arguemnt.
2950 (ospf_zebra_delete): Likewise.
2951
29522000-08-03 Matthew Grant <grantma@anathoth.gen.nz>
2953
2954 * ospf_flood.c (ospf_flood_delayed_lsa_ack): New function added.
2955 Dispatch delayed-ACK with flooding AS-external-LSA across virtual
2956 link.
2957
29582000-07-31 Matthew Grant <grantma@anathoth.gen.nz>
2959
2960 * ospfd.c (show_ip_ospf_area): Fix lack of VTY_NEWLINE when
2961 `show ip ospf'.
2962
2963 * ospf_interface.c (ospf_if_free): Fix bug of crash with
2964 Point-to-Point interface.
2965
29662000-07-27 Michael Rozhavsky <mike@nbase.co.il>
2967
2968 * ospf_flood.c (ospf_process_self_originated_lsa):
2969 Make sure to clear LSA->param (redistributed external information)
2970 before refreshment.
2971
29722000-07-27 Gleb Natapov <gleb@nbase.co.il>
2973
2974 * ospfd.c (refresh_group_limit), (refresh_per_slice),
2975 (refresh_age_diff): New defun added. Refresher related parameter
2976 can be configurable.
2977
29782000-07-27 Akihiro Mizutani <mizutani@dml.com>
2979
2980 * ospf_interface.c (interface_config_write): Print `description'
2981 config directive to work.
2982
29832000-07-24 Akihiro Mizutani <mizutani@dml.com>
2984
2985 * ospf_interface.c (ospf_if_init): Use install_default for
2986 INTERFACE_NODE.
2987
29882000-07-24 Gleb Natapov <gleb@nbase.co.il>
2989
2990 * ospf_packet.c (ospf_ls_upd_send_list), (ospf_ls_upd_send_event),
2991 (ospf_ls_ack_send_list), (ospf_ls_ack_send_event): New function added.
2992 This make sending always as many LS update/Ack combined in one ospf
2993 packet.
2994
29952000-07-24 Gleb Natapov <gleb@nbase.co.il>
2996
2997 * ospf_packet.c (ospf_ls_upd_list_lsa): Set NULL to lsa->area if
2998 LSA is AS-external-LSA.
2999
3000 * ospf_nsm.c (nsm_reset_nbr): Do not cancel Inactivity timer.
3001
30022000-07-21 Toshiaki Takada <takada@zebra.org>
3003
3004 * ospf_zebra.c (ospf_default_originate_timer): Set timer for
3005 `default-information originate'. Fix some default originate
3006 related functions.
3007
30082000-07-12 Toshiaki Takada <takada@zebra.org>
3009
3010 * ospf_lsa.c (stream_put_ospf_metric): New function added.
3011
30122000-07-12 Toshiaki Takada <takada@zebra.org>
3013
3014 * ospf_lsa.c (show_ip_ospf_database_router),
3015 (show_ip_ospf_database_network), (show_ip_ospf_database_summary),
3016 (show_ip_ospf_database_summary_asbr), (show_ip_ospf_database_externel),
3017 (show_router_lsa), (show_any_lsa), (show_router_lsa_self),
3018 (show_any_lsa_self): Functions removed.
3019
3020 (show_lsa_prefix_set), (show_lsa_detail_proc), (show_lsa_detail),
3021 (show_lsa_detail_adv_router_proc), (show_lsa_detail_adv_router):
3022 New functions added. Replace above functions.
3023
3024 (show_ip_ospf_database_all), (show_ip_ospf_database_self_originated):
3025 Functions removed.
3026 (show_ip_ospf_database_summary): New functions added. Replace
3027 above functions.
3028
3029 (show_ip_ospf_database_cmd): DEFUN rearranged.
3030 (show_ip_ospf_database_type_id_cmd),
3031 (show_ip_ospf_database_type_id_adv_router_cmd),
3032 (show_ip_ospf_database_type_is_self_cmd): New ALIASes added.
3033 (show_ip_ospf_database_type_adv_rotuer_cmd): New DEFUN added.
3034 (show_ip_ospf_database_type_self_cmd): New ALIAS added.
3035
30362000-07-11 Toshiaki Takada <takada@zebra.org>
3037
3038 * ospf_asbr.c (ospf_external_info_new),
3039 (ospf_external_info_free): New functions added.
3040
3041 * ospf_lsa.h (ospf_lsa): Add new member `void *param' to set
3042 origination parameter for external-LSA.
3043 Remove member `redistribute'.
3044
3045 * ospf_zebra.c (ospf_redistirbute_set): When `redistribute'
3046 command executed, metric and metric-type values are overridden.
3047 If one of those is changed refresh AS-external-LSAs for appropriate
3048 type.
3049
30502000-07-11 Michael Rozhavsky <mike@nbase.co.il>
3051
3052 * ospf_lsa.c (ospf_summary_lsa_refresh),
3053 (ospf_summary_asbr_lsa_refresh): Make sure to refresh summary-LSAs.
3054
3055 * ospf_abr.c (set_metric): New function added.
3056
30572000-07-07 Toshiaki Takada <takada@zebra.org>
3058
3059 * ospf_zebra.c (ospf_default_information_originate_metric_type),
3060 (ospf_default_information_originate_type_metric): New defun added.
3061 Metic and Metric type can be set to default route.
3062 (ospf_default_information_originate_always_metric_type):
3063 (ospf_default_information_originate_always_type_metric):
3064 New defun added. Metric and Metric type can be set to default
3065 always route.
3066
3067 * ospf_zebra.c (ospf_default_metric), (no_ospf_default_metric):
3068 New defun added.
3069
30702000-07-06 Gleb Natapov <gleb@nbase.co.il>
3071
3072 * ospf_flood.c (ospf_flood_through_area): Fix bug of considering
3073 on the same interface the LSA was received from.
3074
30752000-07-06 Michael Rozhavsky <mike@nbase.co.il>
3076
3077 * ospfd.c (ospf_config_write): Fix bug of printing `area stub'
3078 command with `write mem'.
3079
3080 * ospfd.c (no_router_ospf): Remove installed routes from zebra.
3081
3082 * ospf_zebra.c (ospf_interface_delete): Fix function to handle
3083 zebra interface delete event.
3084
30852000-07-06 Toshiaki Takada <takada@zebra.org>
3086
3087 * ospf_zebra.c (ospf_default_information_originate),
3088 (ospf_default_information_originate_always): New DEFUN added.
3089
30902000-07-05 Michael Rozhavsky <mike@nbase.co.il>
3091
3092 * ospf_route.c (ospf_terminate): Make sure to remove external route
3093 when SIGINT received.
3094
30952000-07-03 Gleb Natapov <gleb@nbase.co.il>
3096
3097 * ospf_flood.c, ospf_ism.c, ospf_lsa,c, ospfd.c: Make sure to free
3098 many structure with `no router ospf'.
3099
31002000-06-30 Gleb Natapov <gleb@nbase.co.il>
3101
3102 * ospf_neighbor.c (ospf_nbr_new),
3103 ospf_nsm.c (nsm_timer_set): Start LS update timer only
3104 when neighbor enters Exchange state.
3105
31062000-06-29 Gleb Natapov <gleb@nbase.co.il>
3107
3108 * ospf_nsm.c (nsm_timer_set), (nsm_exchange_done),
3109 ospf_packet.c (ospf_db_desc_proc):
3110 Do not cancel DD retransmit timer when Master.
3111
31122000-06-29 Gleb Natapov <gleb@nbase.co.il>
3113
3114 * ospf_abr.c (ospf_abr_announce_network_to_area),
3115 (ospf_abr_announce_rtr_to_area)
3116 ospf_ase.c (ospf_ase_rtrs_register_lsa),
3117 ospf_flood.c (ospf_process_self_originated_lsa),
3118 (ospf_flood_through_area), (ospf_ls_request_delete),
3119 ospf_interface.c (ospf_if_free),
3120 ospf_ism.c (ism_change_status),
3121 ospf_lsa.c (ospf_router_lsa_update_timer),
3122 (ospf_router_lsa_install), (ospf_network_lsa_install),
3123 (ospf_lsa_maxage_delete), (ospf_lsa_action),
3124 (ospf_schedule_lsa_flood_area),
3125 ospf_nsm.c (nsm_change_status),
3126 ospf_packet.c (ospf_make_ls_req_func), (ospf_make_ls_ack):
3127 Use ospf_lsa_{lock,unlock} for all looking-up of LSA.
3128
3129 * ospf_flood.c (ospf_ls_request_free): Function deleted.
3130
3131 * ospf_lsa.c (ospf_discard_from_db): New function added.
3132
31332000-06-26 Toshiaki Takada <takada@zebra.org>
3134
3135 * ospfd.h (ospf): struct member `external_lsa' name changed to
3136 `lsdb'.
3137
31382000-06-26 Toshiaki Takada <takada@zebra.org>
3139
3140 * ospf_lsa.c (ospf_lsa_install), (ospf_router_lsa_install),
3141 (ospf_network_lsa_install), (ospf_summary_lsa_install),
3142 (ospf_summary_asbr_lsa_install), (ospf_external_lsa_install):
3143 Functions re-arranged.
3144
3145 * ospf_lsa.c (IS_LSA_MAXAGE), (IS_LSA_SELF): Macro added.
3146
31472000-06-20 Michael Rozhavsky <mike@nbase.co.il>
3148
3149 * ospf_packet.c (ospf_ls_req), (ospf_ls_upd), (ospf_ls_ack): Add
3150 verification of LS type.
3151
31522000-06-20 Gleb Natapov <gleb@nbase.co.il>
3153
3154 * ospf_ase.c (ospf_ase_calculate_timer): Add more sanity check
3155 whether rn->info is NULL.
3156
31572000-06-20 Toshiaki Takada <takada@zebra.org>
3158
3159 * ospfd.c (show_ip_ospf_interface_sub): Show Router-ID of both
3160 DR and Backup correctly with `show ip ospf interface' command.
3161
31622000-06-20 Toshiaki Takada <takada@zebra.org>
3163
3164 * ospf_lsa.c (ospf_lsa_lock), (ospf_lsa_unlock),
3165 (ospf_lsa_discard): These functions are used for avoiding
3166 unexpected reference to freed LSAs.
3167
31682000-06-13 Kunihiro Ishiguro <kunihiro@zebra.org>
3169
3170 * ospf_packet.c (ospf_ls_upd): Initialize lsa by NULL to avoid
3171 warning.
3172
31732000-06-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3174
3175 * ospf_ase.h (ospf_ase_rtrs_register_lsa): Add prototype.
3176
31772000-06-12 Toshiaki Takada <takada@zebra.org>
3178
3179 * ospf_lsa.c (ospf_external_lsa_install): Make sure to register
3180 LSA to rtrs_external when replacing AS-external-LSAs in LSDB.
3181 Fix core dump.
3182
31832000-06-10 Toshiaki Takada <takada@zebra.org>
3184
3185 * ospf_lsdb.c (id_to_prefix), (ospf_lsdb_hash_key),
3186 (ospf_lsdb_hash_cmp), (ospf_lsdb_new), (ospf_lsdb_iterator),
3187 (lsdb_free), (ospf_lsdb_free), (ospf_lsdb_add), (ospf_lsdb_delete),
3188 (find_lsa), (ospf_lsdb_lookup), (find_by_id),
3189 (ospf_lsdb_lookup_by_id), (ospf_lsdb_lookup_by_header): Functinos
3190 removed for migration to new_lsdb.
3191
3192 * ospf_lsa.c (ospf_summary_lsa_install),
3193 (ospf_summary_asbr_lsa_install), (ospf_maxage_lsa_remover),
3194 (ospf_lsa_maxage_walker), (ospf_lsa_lookup),
3195 (ospf_lsa_lookup_by_id): Use new_lsdb instead of ospf_lsdb.
3196 (count_lsa), (ospf_lsa_count_table), (ospf_lsa_count),
3197 (ospf_get_free_id_for_prefix): Funcitions removed.
3198
31992000-06-09 Gleb Natapov <gleb@nbase.co.il>
3200
3201 * ospf_ism.c (ism_interface_down): Prevent some unneeded DR changes.
3202
3203 * ospf_packet.c (ospf_db_desc_proc): Fix memory leak.
3204 (ospf_hello): Always copy router-ID when hello is received.
3205
32062000-06-08 Gleb Natapov <gleb@nbase.co.il>
3207
3208 * ospf_lsa.h (struct ospf_lsa): Add member of pointer to struct
3209 ospf_area.
3210
32112000-06-08 Michael Rozhavsky <mike@nbase.co.il>
3212
3213 * ospf_ase.c (ospf_asbr_route_same): New function added.
3214 This function makes sure external route calculation more
3215 precisely.
3216
32172000-06-07 Michael Rozhavsky <mike@nbase.co.il>
3218
3219 * ospf_ism.c (ism_change_status): Use ospf_lsa_flush_area for
3220 network-LSA deletion instead of using ospf_lsdb_delete.
3221 Also cancel network-LSA origination timer.
3222
32232000-06-07 Levi Harper <lharper@kennedytech.com>
3224
3225 * ospf_interface.c (ospf_if_down): Close read fd when an interface
3226 goes down.
3227
32282000-06-05 Kunihiro Ishiguro <kunihiro@zebra.org>
3229
3230 * ospf_asbr.c (ospf_external_info_lookup): Add explicit brace for
3231 avoid ambiguous else.
3232
3233 * ospf_flood.c (ospf_external_info_check): Likewise.
3234
32352000-06-05 Toshiaki Takada <takada@zebra.org>
3236
3237 * ospf_nsm.c (nsm_adj_ok): Fix bug of DR election.
3238
32392000-06-04 Toshiaki Takada <takada@zebra.org>
3240
3241 * ospf_zebra.c (ospf_default_information_originate),
3242 (no_ospf_default_information_originate): New DEFUN added.
3243
32442000-06-03 Toshiaki Takada <takada@zebra.org>
3245
3246 * ospf_lsa.h, ospf_asbr.h (external_info): Struct moved from
3247 ospf_lsa.h to ospf_asbr.h.
3248
3249 * ospf_lsa.c, ospf_asbr.c (ospf_external_info_add),
3250 (ospf_external_info_delete): Function moved from ospf_lsa.c
3251 to ospf_asbr.c.
3252
32532000-06-03 Toshiaki Takada <takada@zebra.org>
3254
3255 * ospf_flood.c (ospf_external_info_check): New function added.
3256 (ospf_process_self_orignated_lsa): Make sure to flush
3257 self-originated AS-external-LSA, when router reboot and no longer
3258 originate those AS-external-LSA.
3259
32602000-06-02 Toshiaki Takada <takada@zebra.org>
3261
3262 * ospf_network.c (ospf_serv_sock): Remove SO_DONTROUTE
3263 socket option.
3264
3265 * ospf_packet.c (ospf_write): Set MSG_DONTROUTE flag for
3266 unicast destination packets.
3267
32682000-06-02 Toshiaki Takada <takada@zebra.org>
3269
3270 * ospf_lsdb.c (new_lsdb_delete): Delete entry from LSDB only when
3271 specified LSA matches.
3272
32732000-06-02 Gleb Natapov <gleb@nbase.co.il>
3274
3275 * ospf_network.c (ospf_serv_sock): Set SO_DONTROUTE
3276 socket option.
3277
32782000-06-01 Akihiro Mizutani <mizutani@dml.com>
3279
3280 * ospf_dump.c: Replace string `Debugging functions\n' with DEBUG_STR.
3281 Replace string `OSPF information\n' with OSPF_STR.
3282
32832000-06-01 Toshiaki Takada <takada@zebra.org>
3284
3285 * ospf_lsdb.[ch]: Use new_lsdb struct for network-LSA instead of
3286 ospf_lsdb.
3287
32882000-06-01 Toshiaki Takada <takada@zebra.org>
3289
3290 * ospf_dump.c (config_debug_ospf_packet), (config_debug_ospf_event),
3291 (config_debug_ospf_ism), (config_debug_ospf_nsm),
3292 (config_debug_ospf_lsa), (config_debug_ospf_zebra),
3293 (term_debug_ospf_packet), (term_debug_ospf_event),
3294 (term_debug_ospf_ism), (term_debug_ospf_nsm),
3295 (term_debug_ospf_lsa), (term_debug_ospf_zebra): Repalce debug_ospf_*
3296 variable to use for debug option flags.
3297
3298 (debug_ospf_packet), (debug_ospf_ism), (debug_ospf_nsm),
3299 (debug_ospf_lsa), (debug_ospf_zebra): Set {config,term}_debug_*
3300 flags when vty->node is CONFIG_NODE, otherwise set only term_debug_*
3301 flags.
3302
3303 * ospf_dump.h (CONF_DEBUG_PACKET_ON), (CONF_DEBUG_PACKET_OFF),
3304 (TERM_DEBUG_PACKET_ON), (TERM_DEBUG_PACKET_OFF),
3305 (CONF_DEBUG_ON), (CONF_DEBUG_OFF), (IS_CONF_DEBUG_OSPF_PACKET),
3306 (IS_CONF_DEBUG_OSPF): New Macro added.
3307
33082000-05-31 Toshiaki Takada <takada@zebra.org>
3309
3310 * ospfd.c (clear_ip_ospf_neighbor): New DEFUN added.
3311 Currently this command is used for only debugging.
3312
3313 * ospf_nsm.c (nsm_change_status): Make sure thread cancellation
3314 for network-LSA when DR has no full neighbors.
3315
3316 * ospf_nsm.c (ospf_db_summary_clear): New function added.
3317
33182000-05-30 Toshiaki Takada <takada@zebra.org>
3319
3320 * ospf_lsdb.c (new_lsdb_insert): LSAs are always freed by
3321 maxage_lsa_remover when LSA is replaced.
3322
33232000-05-25 Gleb Natapov <gleb@nbase.co.il>
3324
3325 * ospf_flood.c (ospf_ls_retransmit_delete_nbr_all): Add argument
3326 `struct ospf_area' to remove LSA from Link State retransmission list
3327 of neighbor from only one Area.
3328
33292000-05-24 Michael Rozhavsky <mike@nbase.co.il>
3330
3331 * ospf_lsdb.c (ospf_lsdb_add): Preserve flags field when
3332 overriting old LSA with new LSA.
3333
33342000-05-24 Gleb Natapov <gleb@nbase.co.il>
3335
3336 * ospf_lsa.c (ospf_router_lsa_body_set): Fix bug of router-LSA
3337 size calculation.
3338
33392000-05-22 Michael Rozhavsky <mike@nbase.co.il>
3340
3341 * ospf_route.c (ospf_intra_add_stub):
3342 * ospf_spf.h (struct vertex): Use u_int32_t for distance (cost)
3343 value instead of u_int16_t.
3344
33452000-05-22 Axel Gerlach <agerlach@datus.datus.com>
3346
3347 * ospf_ia.c (ospf_ia_network_route): Fix bug of Inter-area route
3348 equal cost path calculation.
3349
33502000-05-21 Toshiaki Takada <takada@zebra.org>
3351
3352 * ospf_ase.c (ospf_ase_calculate_route_delete): New function added.
3353 Make sure, when rotuer route is deleted, related external routes
3354 are also deleted.
3355
33562000-05-20 Toshiaki Takada <takada@zebra.org>
3357
3358 * ospfd.c (ospf_interface_down): Make sure interface flag is disable
3359 and set fd to -1.
3360
33612000-05-16 Toshiaki Takada <takada@zebra.org>
3362
3363 * ospf_asbr.c (ospf_asbr_should_announce), (ospf_asbr_route_remove):
3364 Functions removed.
3365
3366 * ospfd.h (EXTERNAL_INFO): Macro added.
3367 Substitute `ospf_top->external_info[type]' with it.
3368
33692000-05-16 Toshiaki Takada <takada@zebra.org>
3370
3371 * ospf_lsa.c (ospf_rtrs_external_remove): New function added.
3372
33732000-05-14 Gleb Natapov <gleb@nbase.co.il>
3374
3375 * ospf_flood.c (ospf_ls_retransmit_delete_nbr_all)
3376 * ospf_lsdb.c (new_lsdb_insert)
3377 * ospf_packet.c (ospf_ls_ack): Fix database synchonization problem.
3378
33792000-05-14 Gleb Natapov <gleb@nbase.co.il>
3380
3381 * ospf_lsa.h (tv_adjust), (tv_ceil), (tv_floor), (int2tv),
3382 (tv_add), (tv_sub), (tv_cmp): Prototype definition added.
3383
3384 * ospf_nsm.h (ospf_db_summary_delete_all): Prototype definition added.
3385
33862000-05-13 Toshiaki Takada <takada@zebra.org>
3387
3388 * ospf_lsa.[ch] (ospf_lsa): struct timestamp type is changed from
3389 time_t to struct timeval.
3390 (tv_adjust), (tv_ceil), (tv_floor), (int2tv), (tv_add),
3391 (tv_sub), (tv_cmp): timeval utillity functions added.
3392
33932000-05-12 Toshiaki Takada <takada@zebra.org>
3394
3395 * ospf_lsa.[ch] (ospf_schedule_update_router_lsas): Delete function.
3396 Change to use macro OSPF_LSA_UPDATE_TIMER instead of using
3397 this function.
3398 router-LSA refresh timer related stuff is re-organized.
3399
34002000-05-10 Gleb Natapov <gleb@nbase.co.il>
3401
3402 * ospf_interface.c (ospf_vl_set_params):
3403 * ospf_packet.c (ospf_check_network_mask):
3404 * ospf_spf.[ch] (ospf_spf_next):
3405 Remove field address from `struct vertex', and search for peer
3406 address of virtual link in function `ospf_vl_set_params' instead.
3407
34082000-05-10 Gleb Natapov <gleb@nbase.co.il>
3409
3410 * ospf_packet.c (ospf_ls_upd): Fix some memory leak related LSA.
3411
34122000-05-08 Thomas Molkenbur <tmo@datus.com>
3413
3414 * ospf_packet.c (ospf_packet_dup): Replace ospf_steram_copy()
3415 with ospf_stream_dup() to fix memory leak.
3416
34172000-05-08 Michael Rozhavsky <mike@nbase.co.il>
3418
3419 * ospf_flood.c (ospf_flood_through_area): Fix the problem of
3420 LSA update without DROther.
3421
34222000-05-04 Gleb Natapov <gleb@nbase.co.il>
3423
3424 * ospf_spf.c (ospf_vertex_free): Fix memory leak of SPF calculation.
3425
34262000-05-03 Toshiaki Takada <takada@zebra.org>
3427
3428 * ospf_neighbor.c (ospf_db_summary_add): Use new_lsdb struct
3429 instead linked-list.
3430 (ospf_db_summary_count), (ospf_db_summary_isempty):
3431 New function added.
3432
3433 * ospf_lsa.c (ospf_rotuer_lsa): Re-arrange and divide functions.
3434
34352000-05-02 Gleb Natapov <gleb@nbase.co.il>
3436
3437 * ospf_lsdb.c (new_lsdb_cleanup): Fix memory leak. When LSDB are
3438 not needed any more, then free them.
3439
34402000-05-02 Toshiaki Takada <takada@zebra.org>
3441
3442 * ospfd.c (timers_spf), (no_timers_spf): New defun added.
3443 SPF calculation timers related stuff is rearranged.
3444
3445 * ospf_spf.c (ospf_spf_calculate_timer_add): Function removed.
3446 SPF timer is scheduled by SPF calculation delay and holdtime
3447 configuration variable.
3448
3449 * ospf_lsa.c (ospf_external_lsa_nexthop_get): Set AS-external-LSA's
3450 forwarding address when nexthop learned by other protocols is
3451 in the OSPF domain.
3452
3453 * ospf_zebra.c (ospf_redistribute_source_metric_type),
3454 (ospf_redistribute_source_type_metric): Re-arrange DEFUNs and
3455 ALIASes.
3456
34572000-05-01 Toshiaki Takada <takada@zebra.org>
3458
3459 * ospf_flood.c (ospf_ls_retransmit_count),
3460 (ospf_ls_retransmit_isempty): New function added.
3461
3462 (ospf_ls_retransmit_add), (ospf_ls_retransmit_delete),
3463 (ospf_ls_retransmit_clear), (ospf_ls_retransmit_lookup),
3464 (ospf_ls_retransmit_delete_all), (ospf_ls_retransmit_delete_nbr_all),
3465 (ospf_ls_retransmit_add_nbr_all): Replace these functions to use
3466 new_lsdb.
3467
34682000-04-29 Toshiaki Takada <takada@zebra.org>
3469
3470 * ospfd.c (no_network_area): Add check Area-ID whether specified
3471 Area-ID with prefix matches config.
3472
34732000-04-27 Toshiaki Takada <takada@zebra.org>
3474
3475 * ospf_lsa.c (ospf_maxage_lsa_remover): Fix problem of
3476 remaining withdrawn routes on zebra.
3477
34782000-04-25 Michael Rozhavsky <mike@nbase.co.il>
3479
3480 * ospf_nsm.c (nsm_kill_nbr), (nsm_ll_down), (nsm_change_status),
3481 (ospf_nsm_event): Fix network-LSA re-origination problem.
3482
34832000-04-24 Toshiaki Takada <takada@zebra.org>
3484
3485 * ospf_nsm.c (ospf_db_desc_timer): Fix bug of segmentation fault
3486 with DD retransmission.
3487
3488 * ospf_nsm.c (nsm_kill_nbr): Fix bug of re-origination when
3489 a neighbor disappears.
3490
34912000-04-23 Michael Rozhavsky <mike@nbase.co.il>
3492
3493 * ospf_abr.c (ospf_abr_announce_network_to_area): Fix bug of
3494 summary-LSAs reorigination. Correctly copy OSPF_LSA_APPROVED
3495 flag to new LSA. when summary-LSA is reoriginatd.
3496
3497 * ospf_flood.c (ospf_flood_through_area): Fix bug of flooding
3498 procedure. Change the condition of interface selection.
3499
35002000-04-21 Toshiaki Takada <takada@zebra.org>
3501
3502 * ospf_lsa.c (ospf_refresher_register_lsa): Fix bug of refresh never
3503 occurs.
3504
3505 * ospfd.c (show_ip_ospf_neighbor_id): New defun added.
3506 `show ip ospf neighbor' related commands are re-arranged.
3507
35082000-04-20 Toshiaki Takada <takada@zebra.org>
3509
3510 * ospf_dump.c (debug_ospf_zebra): New defun added.
3511 Suppress zebra related debug information.
3512
35132000-04-19 Toshiaki Takada <takada@zebra.org>
3514
3515 * ospf_zebra.c (ospf_distribute_list_update_timer),
3516 (ospf_distribute_list_update), (ospf_filter_update):
3517 New function added. Re-organize `distribute-list' router ospf
3518 command.
3519
35202000-04-13 Michael Rozhavsky <mike@nbase.co.il>
3521
3522 * ospf_packet.c (ospf_make_ls_upd): Add check for MAX_AGE.
3523
35242000-04-14 Michael Rozhavsky <mike@nbase.co.il>
3525
3526 * ospf_packet.c (ospf_make_ls_upd): Increment LS age by configured
3527 interface transmit_delay.
3528
35292000-04-14 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3530
3531 * ospf_interface.c (ip_ospf_cost), (no_ip_ospf_cost):
3532 Add to schedule router_lsa origination when the interface cost changes.
3533
35342000-04-12 Toshiaki Takada <takada@zebra.org>
3535
3536 * ospf_lsa.c (ospf_refresher_register_lsa),
3537 (ospf_refresher_unregister_lsa): Fix bug of core dumped.
3538
3539 * ospfd.c (no_router_ospf): Fix bug of core dumped.
3540
35412000-03-29 Toshiaki Takada <takada@zebra.org>
3542
3543 * ospf_nsm.c (nsm_oneway_received): Fix bug of MS flag unset.
3544
35452000-03-29 Michael Rozhavsky <mike@nbase.co.il>
3546
3547 * ospf_lsa.c (ospf_network_lsa):
3548 * ospf_nsm.c (ospf_nsm_event): Fix bug of Network-LSA originated
3549 in stub network.
3550
35512000-03-28 Toshiaki Takada <takada@zebra.org>
3552
3553 * ospf_nsm.c (nsm_bad_ls_req), (nsm_seq_number_mismatch),
3554 (nsm_oneway_received): Fix bug of NSM state flapping between
3555 ExStart and Exchange.
3556
35572000-03-28 Toshiaki Takada <takada@zebra.org>
3558
3559 * ospf_packet.h (strcut ospf_header): Fix the size of ospf_header,
3560 change u_int8_t to u_char.
3561
35622000-03-27 Toshiaki Takada <takada@zebra.org>
3563
3564 * ospf_lsa.c (ospf_lsa_checksum): Take care of BIGENDIAN architecture.
3565
35662000-03-27 Toshiaki Takada <takada@zebra.org>
3567
3568 * ospfd.c (ospf_interface_run): Make sure Address family matches.
3569
35702000-03-26 Love <lha@s3.kth.se>
3571
3572 * ospf_packet.c (ospf_write): Chack result of sendto().
3573
35742000-03-26 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3575
3576 * ospf_nsm.c (nsm_oneway_received): Fix bug of 1-WayReceived in NSM.
3577
35782000-03-23 Libor Pechacek <farco@clnet.cz>
3579
3580 * ospf_lsa.c (ospf_network_lsa)
3581 * ospf_lsdb.c (new_lsdb_insert): Fix bug of accessing to
3582 unallocated memory.
3583
35842000-03-23 Toshiaki Takada <takada@zebra.org>
3585
3586 * ospfd.c (ospf_config_write): Fix bug of duplicate line for
3587 `area A.B.C.D authentication'.
3588
35892000-03-22 Toshiaki Takada <takada@zebra.org>
3590
3591 * ospf_debug.c (debug_ospf_lsa), (no_debug_ospf_lsa): Defun added.
3592 Suppress all zlog related to LSAs with this config option.
3593
35942000-03-21 Kunihiro Ishiguro <kunihiro@zebra.org>
3595
3596 * ospf_nsm.c (ospf_nsm_event): Add check for NSM_InactivityTimer.
3597
35982000-03-21 Toshiaki Takada <takada@zebra.org>
3599
3600 * ospf_packet.c (ospf_ls_upd_timer), (ospf_ls_req):
3601 Fix bug of memory leak about linklist.
3602
3603 * ospf_flood.c (ospf_flood_through_area): Likewise.
3604
36052000-03-18 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3606
3607 * ospf_flood.c (ospf_ls_retransmit_lookup): Add checksum comparison
3608 to identify LSA uniquely. This fix routes lost.
3609
36102000-03-18 Toshiaki Takada <takada@zebra.org>
3611
3612 * ospf_ase.c (ospf_find_asbr_route): Add sanity check with router
3613 routing table.
3614
36152000-03-17 Alex Zinin <zinin@amt.ru>
3616
3617 * ospf_spf.[ch]: Bug fix.
3618 The 2nd stage of Dijkstra could consider one vertex
3619 more than once if there is more than one link
3620 between the routers, thus adding extra CPU overhead
3621 and extra next-hops.
3622 Fixed.
3623
36242000-03-15 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3625
3626 * ospf_nsm.c (nsm_inactivity_timer): Changed to call nsm_kill_nbr().
3627
36282000-03-14 Toshiaki Takada <takada@zebra.org>
3629
3630 * ospf_route.c (ospf_route_copy_nexthops): Fix bug of memory leak of
3631 ospf_path. Actually ignore merging ospf_route with completely same
3632 paths.
3633
36342000-03-12 Toshiaki Takada <takada@zebra.org>
3635
3636 * ospf_lsa.c (show_as_external_lsa_detail): fix bug of
3637 external route tag byte order.
3638
36392000-03-11 Toshiaki Takada <takada@zebra.org>
3640
3641 * ospf_lsdb.c (ospf_lsdb_insert): New function added.
3642
36432000-03-09 Toshiaki Takada <takada@zebra.org>
3644
3645 * ospf_lsa.c (ospf_external_lsa_install),
3646 (ospf_lsa_lookup), (show_ip_ospf_database_all),
3647 (show_ip_ospf_database_self_originate): Use struct new_lsdb for
3648 LSDB of AS-external-LSAs instead of ospf_lsdb.
3649
3650 * ospf_lsa.c (ospf_lsa_unique_id): New function added.
3651 Use for assigning Unique Link State ID instead of
3652 ospf_get_free_id_for_prefix().
3653
36542000-03-09 Toshiaki Takada <takada@zebra.org>
3655
3656 * ospf_ase.c (ospf_ase_calculate_timer): Fix bug of segmentation
3657 fault reported by George Bonser <george@siteROCK.com>.
3658
36592000-03-07 Libor Pechacek <farco@clnet.cz>
3660
3661 * ospfd.c (ospf_interface_down): Fix bug of segmentation fault.
3662
36632000-03-06 Toshiaki Takada <takada@zebra.org>
3664
3665 * ospf_route.c (ospf_route_cmp): Change meaning of return values.
3666
36672000-03-02 Alex Zinin <zinin@amt.ru>
3668 * ospfd.h, ospf_ia.h
3669 New Shortcut ABR code. Now area's flag can be configured
3670 with Default, Enable, and Disable values.
3671 More info will be in the new ver of I-D soon (see IETF web).
3672
36732000-02-25 Toshiaki Takada <takada@zebra.org>
3674
3675 * ospf_lsa.c (ospf_lsa_header_set), (ospf_external_lsa_body_set),
3676 (osfp_external_lsa_originate), (ospf_external_lsa_queue),
3677 (ospf_external_lsa_originate_from_queue): New function added.
3678 (ospf_external_lsa): Function removed.
3679
3680 * ospf_zebra.c (ospf_zebra_read_ipv4): Originate AS-external-LSA
3681 when listen a route from Zebra, instead creating external route.
3682
3683 * ospf_asbr.c (ospf_asbr_route_add_flood_lsa),
3684 (ospf_asbr_route_add_queue_lsa),
3685 (ospf_asbr_route_install_lsa), (ospf_asbr_route_add):
3686 Functions removed.
3687
3688 * ospf_ase.c (process_ase_lsa): Function will not be used.
3689 (ospf_ase_calculate), (ospf_ase_calculate_route_add),
3690 (ospf_ase_calculate_new_route), (ospf_ase_caluculate_asbr_route):
3691 process_ase_lsa () is separated to these functions.
3692
3693 OSPF AS-external-LSA origination is whole re-organized.
3694
36952000-02-18 Toshiaki Takada <takada@zebra.org>
3696
3697 * ospf_packet.c (ospf_ls_upd): Fix bug of OSPF LSA memory leak.
3698
3699 * ospf_asbr.c (ospf_asbr_route_add_flood_lsa),
3700 (ospf_asbr_route_add_queue_lsa): Fix bug of OSPF external route
3701 memory leak.
3702
37032000-02-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3704
3705 * ospf_asbr.c (ospf_asbr_route_install_lsa): Re-calculate LSA
3706 checksum after change Advertised Router field.
3707
37082000-02-09 Toshiaki Takada <takada@zebra.org>
3709
3710 * ospf_asbr.c (ospf_external_route_lookup): Add new function.
3711
37122000-02-08 Toshiaki Takada <takada@zebra.org>
3713
3714 * ospfd.c (ospf_router_id_get), (ospf_router_id_update),
3715 (ospf_router_id_update_timer): Router ID decision algorithm is changed.
3716 Router ID is chosen from all of eligible interface addresses even if
3717 it is not enable to OSPF.
3718
37192000-02-08 Toshiaki Takada <takada@zebra.org>
3720
3721 * ospf_asbr.c (ospf_asbr_route_add): Function divided to
3722 ospf_asbr_route_add_flood_lsa, ospf_asbr_route_add_queue_lsa and
3723 ospf_asbr_route_install_lsa. If Router-ID is not set, then LSA is
3724 waited to install to LSDB.
3725 `0.0.0.0 adv_router' AS-external-LSA origination bug was fixed.
3726
37272000-02-01 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3728
3729 * ospf_flood.c (ospf_ls_retransmit_lookup): Compare LS seqnum
3730 in the ACK before deleting.
3731
3732 * ospf_packet.c (ospf_hello): Reset the flags after a shutdown
3733 and no shutdown of the interface.
3734
37352000-01-31 Toshiaki Takada <takada@zebra.org>
3736
3737 * ospf_packet.c (ospf_ls_req): Send multiple Link State Update
3738 packets respond to a Link State Request packet.
3739
3740 * ospfd.c (show_ip_ospf_neighbor_detail_sub): Show thread state.
3741
3742 * ospf_interface.c (ospf_vl_new): Crash when backbone area
3743 is not configured and set virtual-link to no-backbone area,
3744 bug fixed.
3745
37462000-01-30 Kunihiro Ishiguro <kunihiro@zebra.org>
3747
3748 * ospf_neighbor.h (struct ospf_neighbor): Add pointer to last send
3749 LS Request LSA.
3750
3751 * ospf_packet.c (ospf_ls_upd): Comment out LS request list
3752 treatment. That should be done in OSPF flooding procedure.
3753
3754 * ospf_flood.c (ospf_flood_through_area): Enclose
3755 ospf_check_nbr_loding inside if-else close.
3756
37572000-01-31 Toshiaki Takada <takada@zebra.org>
3758
3759 * ospf_packet.c (ospf_make_ls_upd): Fix bug of #LSAs counting.
3760
37612000-01-29 Toshiaki Takada <takada@zebra.org>
3762
3763 * ospf_packet.c (ospf_make_md5_digest): Fix bug of md5 authentication.
3764
37652000-01-28 Toshiaki Takada <takada@zebra.org>
3766
3767 * ospfd.c (show_ip_ospf): Show Number of ASE-LSAs.
3768
37692000-01-27 Kunihiro Ishiguro <kunihiro@zebra.org>
3770
3771 * ospf_packet.c (ospf_make_db_desc): Don't use rm_list for
3772 removing LSA from nbr->db_summary.
3773
37742000-01-27 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3775
3776 * ospf_packet.c (ospf_ls_upd_send): Set AllSPFRouters to
3777 destination when the link is point-to-point.
3778 (ospf_ls_ack_send_delayed): Likewise.
3779
37802000-01-27 Kunihiro Ishiguro <kunihiro@zebra.org>
3781
3782 * ospf_flood.c (ospf_ls_request_delete_all): Fix bug of next
3783 pointer lookup after the node is freed.
3784
37852000-01-26 Kunihiro Ishiguro <kunihiro@zebra.org>
3786
3787 * ospf_asbr.c (ospf_asbr_route_add): Instead of scanning all AS
3788 external route, use ospf_top->external_self.
3789
37902000-01-27 Toshiaki Takada <takada@zebra.org>
3791
3792 * ospf_lsa.c (ospf_forward_address_get): New function added.
3793
3794 * ospf_asbr.c (ospf_asbr_check_lsas): Originate AS-external-LSA
3795 only when it should be replaced.
3796
37972000-01-25 Kunihiro Ishiguro <kunihiro@zebra.org>
3798
3799 * ospf_flood.c (ospf_ls_retransmit_clear): Delete list node.
3800
3801 * ospf_lsa.c (ospf_lsa_free): Reduce logging message using
3802 ospf_zlog value.
3803
3804 * ospf_ism.c (ism_change_status): Fix bug of DR -> non DR status
3805 change. Self originated LSA is freed but not deleted from lsdb.
3806
38072000-01-24 Kunihiro Ishiguro <kunihiro@zebra.org>
3808
3809 * ospf_ism.c (ism_interface_down): Don't use router_id for
3810 detecting self neighbor structure. Instead of that compare
3811 pointer itself.
3812
3813 * ospf_neighbor.c (ospf_nbr_free): Cancel all timer when neighbor
3814 is deleted.
3815 (ospf_nbr_free): Free last send packet.
3816
3817 * ospf_neighbor.h (struct ospf_neighbor): Remove host strucutre.
3818 Instead of that src is introduced.
3819
3820 * ospf_nsm.h: Enclose macro defenition with do {} while (0).
3821
38222000-01-17 Kunihiro Ishiguro <kunihiro@zebra.org>
3823
3824 * ospfd.c: Change part of passive interface implementation. For
3825 passive interface just disabling sending/receiving Hello on the
3826 interface.
3827
38282000-01-16 Kai Bankett <kai.bankett@vew-telnet.net>
3829
3830 * ospf_interface.h (OSPF_IF_PASSIVE): Add passive flag.
3831 * ospf_interface.c (ospf_if_lookup_by_name): Add new function.
3832 * ospf_lsa.c (ospf_router_lsa): Skip passive interface.
3833 * ospfd.c (passive_interface): New command passive-interface is
3834 added.
3835 (ospf_config_write): Print passive interface.
3836
38372000-01-15 Toshiaki Takada <takada@zebra.org>
3838
3839 * ospf_interface.h (crypt_key): New struct added to store
3840 multiple cryptographic autheitication keys.
3841 (ospf_interface): struct changed.
3842
3843 * ospf_interface.c: ospf_crypt_key_new, ospf_crypt_key_add,
3844 ospf_crypt_key_lookup, ospf_crypt_key_delete: new functions added.
3845
3846 * ospf_packet.c (ip_ospf_message_digest_key): Changed to store
3847 multiple cryptographic authentication keys.
3848
38492000-01-14 Toshiaki Takada <takada@zebra.org>
3850
3851 * ospf_interface.c: DEFUN (if_ospf_*) commands changed name to
3852 ip_ospf_* ().
3853 Old notation `ospf *' still remains backward compatibility.
3854
38551999-12-29 Alex Zinin <zinin@amt.ru>
3856 * ospf_lsa.c: ospf_lsa_more_recent() bug fix
3857 * ospf_nsm.c, ospf_packet.c: remove nbr data struct when
3858 int goes down, also check DD flags correctly (bug fix)
3859
38601999-12-28 Alex Zinin <zinin@amt.ru>
3861 * "redistribute <source> metric-type (1|2) metric <XXX>" added
3862
38631999-12-23 Alex Zinin <zinin@amt.ru>
3864 * added RFC1583Compatibility flag
3865 * added dynamic interface up/down functionality
3866
38671999-11-19 Toshiaki Takada <takada@zebra.org>
3868
3869 * ospf_neighbor.h (struct ospf_neighbor): Add member state_change
3870 for NSM state change statistics.
3871
38721999-11-19 Toshiaki Takada <takada@zebra.org>
3873
3874 * ospfd.c (show_ip_ospf_neighbor_detail),
3875 (show_ip_ospf_neighbor_int_detail): DEFUN Added.
3876
38771999-11-14 Kunihiro Ishiguro <kunihiro@zebra.org>
3878
3879 * ospf_asbr.c (ospf_asbr_check_lsas): Add check of
3880 lsa->refresh_list.
3881
38821999-11-11 Toshiaki Takada <takada@zebra.org>
3883
3884 * ospf_ia.[ch] (OSPF_EXAMINE_SUMMARIES_ALL): Macro added.
3885 This macro is expanded to ospf_examine_summaries ()
3886 for SUMMARY_LSA and SUMMARY_LSA_ASBR.
3887 (OSPF_EXAMINE_TRANSIT_SUMMARIES_ALL): Macro added.
3888 This macro is expanded to ospf_examine_transit_summaries ()
3889 for SUMMARY_LSA and SUMMARY_LSA_ASBR.
3890
38911999-11-11 Toshiaki Takada <takada@zebra.org>
3892
3893 * ospf_lsa.[ch] (ospf_find_self_summary_lsa_by_prefix): Changed to
3894 macro OSPF_SUMMARY_LSA_SELF_FIND_BY_PREFIX.
3895 (ospf_find_self_summary_asbr_lsa_by_prefix): Changed to
3896 macro OSPF_SUMMARY_ASBR_LSA_SELF_FIND_BY_PREFIX.
3897 (ospf_find_self_external_lsa_by_prefix): Changed to
3898 macro OSPF_EXTERNAL_LSA_SELF_FIND_BY_PREFIX.
3899
39001999-11-11 Toshiaki Takada <takada@zebra.org>
3901
3902 * ospfd.c (ospf_abr_type): ospf_abr_type_cisco, ospf_abr_type_ibm,
3903 ospf_abr_type_shortcut and ospf_abr_type_standard DEFUNs are
3904 combined.
3905 * ospfd.c (no_ospf_abr_type): no_ospf_abr_type_cisco,
3906 no_ospf_abr_type_ibm and no_ospf_abr_type_shortcut DEFUNS are
3907 combined.
3908
39091999-11-10 Toshiaki Takada <takada@zebra.org>
3910
3911 * ospf_route.c (ospf_lookup_int_by_prefix): Move function to
3912 ospf_interface.c and change name to ospf_if_lookup_by_prefix ().
3913
39141999-11-01 Alex Zinin <zinin@amt.ru>
3915 * ospf_packet.c
3916 some correction to LSU processing
3917
3918 * ospf_lsa.c ospfd.h
3919 randomize initial LSA refreshment interval
3920 and limit the size of LSA-group to 10
3921 to let randomization work more effectively.
3922
39231999-10-31 Alex Zinin <zinin@amt.ru>
3924 * ospf_interface.c
3925 cancel t_network_lsa_self
3926 when freeing int structure
3927
3928 * ospf_abr.c ospf_asbr.c ospf_flood.c ospf_lsa.c
3929 ospf_lsa.h ospf_lsdb.h ospfd.c ospfd.h
3930
3931 Summary and ASE LSA refreshment functions
3932 added---LSA refreshment is paced to 70 LSAs
3933 per sec to avoid link overflow. Refreshment events
3934 are further randomized within a 10 sec interval
3935 to avoid syncing.
3936
3937 Also the sigfault of memcmp() in ospf_lsa_is_different()
3938 is fixed.
3939
39401999-10-30 Alex Zinin <zinin@amt.ru>
3941 * ospf_nsm.c
3942 Fix the bug where MAX_AGE LSAs
3943 are included into the DB summary.
3944
3945 * ospf_interface.c
3946 allocate 2*MTU input buffer instead of just MTU
3947 for the cases when the other router mistakenly
3948 sends larger packets thus causing fragmentation, etc.
3949
3950 * ospf_nsm.c
3951 in nsm_reset_nbr() lists should be freed
3952 not when they are empty.
3953
39541999-10-29 Kunihiro Ishiguro <kunihiro@zebra.org>
3955
3956 * ospf_zebra.c (ospf_acl_hook): Move OSPF_IS_ASBR and OSPF_IS_ABR
3957 check inside of if (ospf_top).
3958
39591999-10-29 Alex Zinin <zinin@amt.ru>
3960 * ospf_lsa.c ospf_lsdb.c :
3961 add assertion in lsa and lsa->data alloc functions,
3962 as well as in lsdb_add for new->data
3963
3964 * ospf_lsdb.c: free hash table correctly
3965
39661999-10-28 John Capo <jc@irbs.com>
3967
3968 * ospf_packet.h (OSPF_PACKET_MAX): Correct MAX packet length
3969 calculation
3970
39711999-10-27 Kunihiro Ishiguro <kunihiro@zebra.org>
3972
3973 * OSPF-TRAP-MIB.txt: New file added. Edited version of RFC1850.
3974
3975 * OSPF-MIB.txt: New file added. Edited version of RFC1850.
3976
39771999-10-27 Alex Zinin <zinin@amt.ru>
3978 * ospfd, ospf_zebra, ospf_abr
3979 "area import-list" command is added.
3980 This command allows to filter the inter-area routes
3981 injected into an area. Access list hook function
3982 extended to invalidate area exp/imp lists.
3983
39841999-10-25 Yoshinobu Inoue <shin@nd.net.fujitsu.co.jp>
3985
3986 * ospfd.c (ospf_interface_run): Enable to detect P2P network
3987 on an OSPF interface.
3988
39891999-10-19 Jordan Mendelson <jordy@wserv.com>
3990
3991 * ospf_lsdb.c (ospf_lsdb_add): Fix bug of crash
3992 in ospf_ls_retransmit_lookup ().
3993
39941999-10-19 Vladimir B. Grebenschikov <vova@express.ru>
3995
3996 * ospf_route.c: Workaround about installation of OSPF routes into
3997 the zebra daemon. Add checking of existance routes. Free
3998 ospf_top->old_table if it exists.
3999
40001999-10-15 Jordan Mendelson <jordy@wserv.com>
4001
4002 * Add support for MD5 authentication.
4003
40041999-10-12 Alex Zinin <zinin@amt.ru>
4005 * ospfd.c, ospfd.h, ospf_abr.c:
4006 a new command "area export-list" was added, it allows
4007 the admin. to control which intra-area routes are
4008 announced to other areas by the ABR
4009
40101999-10-12 Alex Zinin <zinin@amt.ru>
4011 * ospf_asbr.c (ospf_asbr_check_lsas): Fix bug of coredump
4012 when "no redistribute" is used after a distribute list
4013 denying some networks was used
4014
40151999-10-05 Toshiaki Takada <takada@zebra.org>
4016
4017 * ospf_route.c (ospf_path_dup): New function added.
4018
40191999-10-05 Toshiaki Takada <takada@zebra.org>
4020
4021 * ospf_interface.[ch]: Some of VL related funciton name changed.
4022
40231999-09-27 Alex Zinin <zinin@amt.ru>
4024
4025 * ospf_zebra.c: Distribute-list functionality added
4026
40271999-09-27 Toshiaki Takada <takada@zebra.org>
4028
4029 * ospfd.c (show_ip_ospf): Fix bug of segmentation fault when no ospf
4030 instance exists.
4031
40321999-09-25 Kunihiro Ishiguro <kunihiro@zebra.org>
4033
4034 * ospfd.c (ospf_interface_down): Fix bug of misusing nextnode()
4035 instead of node->next. Reported by Hiroki Ishibashi
4036 <ishibasi@dcd.abk.nec.co.jp>.
4037
4038 * ospf_route.c (show_ip_ospf_route): Add check for ospf is enabled
4039 or not.
4040
40411999-09-23 Alex Zinin <zinin@amt.ru>
4042
4043 * stub area support added
4044
40451999-09-23 Alex Zinin <zinin@amt.ru>
4046
4047 * fwd_addr in ASE-LSAs is now set correctly
4048 * ASE routing changed to check the fwd_addr
4049 and skip the route if the addr points to one
4050 of our interfaces to avoid loops.
4051
40521999-09-22 Alex Zinin <zinin@amt.ru>
4053
4054 * ospf_interface:
4055 ospf_vls_in_area() added, it returns
4056 the number of VLs configured through the area
4057
4058 * ospf_interface.c ospf_lsa.c ospf_lsdb.c ospfd.c
4059 honor correct mem alloc
4060
40611999-09-22 Alex Zinin <zinin@amt.ru>
4062
4063 * memory.[ch]:
4064 Some OSPF mem types added,
4065 plus more info in "show mem"
4066
40671999-09-21 Alex Zinin <zinin@amt.ru>
4068
4069 * ospfd.c:
4070 "area range substitute" added.
4071 It can be used on NAT-enabled (IP-masquarade)
4072 routers to announce private networks
4073 from an area as public ones into the outside
4074 world (not in the RFC, btw :)
4075
40761999-09-21 Alex Zinin <zinin@amt.ru>
4077
4078 * ospfd.c:
4079 "area range suppress" added.
4080 This command allows to instruct the router
4081 to be silent about specific ranges, i.e.,
4082 it is a method of route filtering on area
4083 borders
4084
40851999-09-21 Alex Zinin <zinin@amt.ru>
4086
4087 * ospfd.c VLs removed when "no network area" executed
4088
40891999-09-20 Alex Zinin <zinin@amt.ru>
4090
4091 * ospf_ase.c bug fix for not-zero fwd_addr
4092 and directly connected routes.
4093
40941999-09-20 Yon Uriarte <yon@plannet.de>
4095
4096 * ospf_packet.c (ospf_make_ls_req): Introduce delta value for
4097 checking the length of OSPF packet exceeds MTU or not.
4098
4099 * ospf_lsa.c (ospf_lsa_different): Apply ntohs for checking
4100 l1->data->length.
4101
41021999-09-18 Alex Zinin <zinin@amt.ru>
4103
4104 * ospf_lsa.c bug fix for ospf_network_lsa() to
4105 include itself into the RID list
4106
41071999-09-10 Alex Zinin <zinin@amt.ru>
4108
4109 * Alternative ABR behaviors IBM/Cisco/Shortcut
4110 implemented
4111
41121999-09-10 Alex Zinin <zinin@amt.ru>
4113
4114 * router and network-LSA origination
4115 changed to honor MinLSInterval
4116
41171999-09-08 Alex Zinin <zinin@amt.ru>
4118
4119 * modified ABR behavior to honor VLs and transit
4120 areas
4121
41221999-09-07 Alex Zinin <zinin@amt.ru>
4123
4124 * completed VL functionality
4125
41261999-09-06 Kunihiro Ishiguro <kunihiro@zebra.org>
4127
4128 * ospf_asbr.c: New file.
4129 ospf_asbr.h: New file.
4130
4131 * ospf_zebra.c (ospf_redistribute_connected): Add redistribute
4132 related stuff.
4133
41341999-09-05 Kunihiro Ishiguro <kunihiro@zebra.org>
4135
4136 * ospfd.h (OSPF_FLAG_VIRTUAL_LINK): Change OSPF_FLAG_VEND to
4137 OSPF_FLAG_VIRTUAL_LINK for comprehensiveness.
4138
41391999-09-03 Kunihiro Ishiguro <kunihiro@zebra.org>
4140
4141 * ospf_spf.c (ospf_spf_register): Change name from
4142 ospf_spf_route_add() to ospf_spf_register().
4143 Include "ospfd/ospf_abr.h" for ospf_abr_task() prototype.
4144
41451999-09-02 Kunihiro Ishiguro <kunihiro@zebra.org>
4146
4147 * ospf_lsa.c (ospf_external_lsa_install): Change to update
4148 lsa->data rather than install new one, when same id lsa is already
4149 installed.
4150
41511999-09-01 Kunihiro Ishiguro <kunihiro@zebra.org>
4152
4153 * ospf_lsa.c (ospf_router_lsa_install): Return lsa value.
4154 (ospf_network_lsa_install): Likewise.
4155 (ospf_summary_lsa_install): Likewise.
4156 (ospf_summary_asbr_lsa_install): Likewise.
4157 (ospf_external_lsa_install): Likewise.
4158
4159 * ospf_spf.c (ospf_spf_calculate): Comment out debug function
4160 ospf_rtrs_print().
4161
41621999-08-31 Kunihiro Ishiguro <kunihiro@zebra.org>
4163
4164 * ospf_spf.c (ospf_rtrs_free): Add ospf_spf_calculate() for
4165 freeing rtrs.
4166
41671999-08-31 Toshiaki Takada <takada@zebra.org>
4168
4169 * ospf_lsa.c (show_ip_ospf_database_summary),
4170 (show_ip_ospf_database_summary_asbr),
4171 (show_ip_ospf_database_external): New function added.
4172 `show ip ospf database summary',
4173 `show ip ospf database asbr-summary'
4174 `show ip ospf database external' command can be used.
4175
4176 * ospf_lsa.c (ospf_lsa_count_table): New function added.
4177 (show_ip_ospf_database_all): show nothing if a type of LSA
4178 does not exist.
4179
41801999-08-31 Kunihiro Ishiguro <kunihiro@zebra.org>
4181
4182 * ospf_lsa.c (ospf_maxage_lsa_remover): Preserve next pointer when
4183 the node is deleted.
4184
41851999-08-31 Toshiaki Takada <takada@zebra.org>
4186
4187 * ospf_flood.c (ospf_ls_retransmit_lookup): change to return
4188 struct ospf_lsa *.
4189 (ospf_ls_request_new), (ospf_ls_request_free),
4190 (ospf_ls_request_add), (ospf_ls_request_delete),
4191 (ospf_ls_request_delete_all), (ospf_ls_request_lookup):
4192 New function added.
4193
4194 * ospf_packet.c (ospf_ls_upd_send_lsa): New function added.
4195
4196 * ospf_lsa.h (LS_AGE): Slightly change macro definition.
4197
4198 * ospf_lsa.c (ospf_lsa_more_recent), (ospf_lsa_diffrent):
4199 Use LS_AGE macro.
4200
42011999-08-30 Alex Zinin <zinin@amt.ru>
4202
4203 * ospfd.c
4204 fix a bug with area range config write
4205 added "show ip ospf" command, it will be enhanced later on
4206
42071999-08-30 Alex Zinin <zinin@amt.ru>
4208
4209 * ospf_lsa.c
4210 updated ospf_router_lsa() to honor flags (B-bit)
4211
42121999-08-30 Alex Zinin <zinin@amt.ru>
4213
4214 * ospf_abr.c
4215 wrote major functions implementing ABR activity
4216
42171999-08-30 Alex Zinin <zinin@amt.ru>
4218
4219 * ospf_ia.c ospf_route.c ospf_route.h
4220 fixed the bug with ospf_route.origin field.
4221 Now it holds pointer to lsa_header
4222
42231999-08-30 Alex Zinin <zinin@amt.ru>
4224
4225 * ospf_flood.c ospf_flood.h:
4226 transformed ospf_flood_if_select into ospf_flood_through_area()
4227 added new ospf_flood_if_select() and ospf_flood_through_as()
4228
42291999-08-30 Toshiaki Takada <takada@zebra.org>
4230
4231 * ospf_flood.[ch]: New file added.
4232
4233 * ospf_packet.c (ospf_lsa_flooding),
4234 (ospf_lsa_flooding_select_if): functions move to ospf_flood.c
4235
4236 * ospf_neighbor.c (ospf_put_lsa_on_retransm_list),
4237 (ospf_remove_lsa_from_retransm_list),
4238 (ospf_nbr_remove_all_lsas_from_retransm_list),
4239 (ospf_lsa_remove_from_ls_retransmit):
4240 (ospf_lsa_retransmit): functions move to
4241 ospf_flood.c, and change function's name:
4242
4243 ospf_put_lsa_on_retransm_list ()
4244 -> ospf_ls_retransmit_add ()
4245 ospf_remove_lsa_from_retransm_list ()
4246 -> ospf_ls_retransmit_delete ()
4247 ospf_nbr_remove_all_lsas_from_retransm_list ()
4248 -> ospf_ls_retransmit_clear ()
4249 ospf_lsa_remove_from_ls_retransmit ()
4250 -> ospf_ls_retransmit_delete_nbr_all ()
4251 ospf_lsa_retransmit ()
4252 -> ospf_ls_retransmit_add_nbr_all ()
4253
4254 * ospf_lsa.c (ospf_lsa_lookup_from_list): function move to
4255 ospf_flood.c, and change name to ospf_ls_retransmit_lookup ().
4256
42571999-08-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4258
4259 * ospf_neighbor.c (ospf_nbr_lookup_by_addr): Use
4260 route_node_lookup() instead of route_node_get().
4261
4262 * ospf_packet.c (ospf_ls_upd): Temporary comment out (6) check.
4263
42641999-08-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4265
4266 * ospf_route.c (ospf_lookup_int_by_prefix): Add check of
4267 oi->address.
4268
42691999-08-29 Alex Zinin <zinin@amt.ru>
4270 * ospf_lsa.c
4271 MaxAge LSA deletion functions added.
4272
42731999-08-29 Alex Zinin <zinin@amt.ru>
4274 * ospf_neighbor.c
4275 ospf_nbr_lookup_by_addr(): added route_unlock_node()
4276 when function returns NULL if (rn->info == NULL)
4277
42781999-08-29 Alex Zinin <zinin@amt.ru>
4279 * ospfd.c
4280 added a hack for area range deletion
4281
42821999-08-29 Alex Zinin <zinin@amt.ru>
4283 * ospf_lsa.h
4284 included lsdb field into struct ospf_lsa, to find
4285 LSDB easier when removing MaxAge LSAs.
4286
42871999-08-29 Alex Zinin <zinin@amt.ru>
4288 * ospf_lsa.c ospf_neighbor.c ospf_nsm.c
4289 ospf_packet.c changed to honor new retransmit list
4290 management functions
4291
42921999-08-29 Alex Zinin <zinin@amt.ru>
4293 * ospf_neighbor.c , .h added new retransmit list functions.
4294
42951999-08-29 Alex Zinin <zinin@amt.ru>
4296 * Makefile.in
4297 added ospf_ase, ospf_abr, ospf_ia
4298
42991999-08-29 Alex Zinin <zinin@amt.ru>
4300 * ospf_spf.c:
4301 - changed ospf_next_hop_calculation() to include interface
4302 and nexthop addr for directly connected routers---more informative
4303 and solves problem with route installation into the kernel
4304 - changed ospf_nexthop_out_if_addr() to support routers, not only
4305 transit networks
4306 - added ospf_process_stubs();
4307
43081999-08-29 Alex Zinin <zinin@amt.ru>
4309 * ospf_lsa.c:
4310 - changed ospf_router_lsa() to provide correct links
4311 for p-t-p interfaces;
4312 - changed ospf_summary_lsa_install() to support table
4313 of self-originated summary-LSAs;
4314 - added ospf_summary_asbr_lsa_install() and ospf_external_lsa_install()
4315 - changed ospf_lsa_install() accordingly
4316 - changed show_ip_ospf_database_router_links() to support p-t-p
4317
43181999-08-29 Kunihiro Ishiguro <kunihiro@zebra.org>
4319
4320 * ospf_packet.c (ospf_make_db_desc): Only master can clear more
4321 flag.
4322
43231999-08-29 Kunihiro Ishiguro <kunihiro@zebra.org>
4324
4325 * ospf_packet.c (ospf_read): Add check of IP src address.
4326
43271999-08-28 Alex Zinin <zinin@amt.ru>
4328 * ospf_neighbor.h
4329 added ospf_nbr_lookup_by_routerid()
4330
43311999-08-28 Alex Zinin <zinin@amt.ru>
4332 * ospfd.h
4333 added ABR/ASBR flag definitions and fields;
4334 added iflist field to area structure;
4335 summary_lsa_self and summary_lsa_asbr_self are changed
4336 to be route tables;
4337 added ranges field---configured area ranges;
4338 A separate Routers RT added;
4339 area range config commands and config write added
4340
4341
43421999-08-28 Alex Zinin <zinin@amt.ru>
4343 * ospf_route.c :
4344 ospf_route_free()--added code to free the list of paths;
4345 The following functions added:
4346 ospf_intra_add_router();
4347 ospf_intra_add_transit();
4348 ospf_intra_add_stub();
4349 the last function uses new ospf_int_lookup_by_prefix();
4350 show_ip_ospf_route_cmd()--changed to support new RT structure;
4351 added ospf_cmp_routes()--general route comparision function;
4352 added ospf_route_copy_nexthops() and ospf_route_copy_nexthops_from_vertex()
4353 they are used in ASE and IA routing;
4354 added ospf_subst_route() and ospf_add_route();
4355
43561999-08-28 Alex Zinin <zinin@amt.ru>
4357 * ospf_route.h :
4358 changed struct ospf_path to include output interface,
4359 changed struct ospf_route to support IA and ASE routing.
4360 added prototypes of the function used in IA and ASE modules.
4361
43621999-08-28 Alex Zinin <zinin@amt.ru>
4363 * ospf_lsa.h ospf_lsa.c :
4364 added ospf_my_lsa(), an interface independent version of
4365 ospf_lsa_is_self_originated(), it will be used in ASE and IA-routing.
4366
43671999-08-27 Kunihiro Ishiguro <kunihiro@zebra.org>
4368
4369 * ospf_interface.c (interface_config_write): Add check for
4370 oi->nbr_self.
4371
43721999-08-25 Toshiaki Takada <takada@zebra.org>
4373
4374 * ospf_lsa.c (ospf_lsa_dup): New function added.
4375
4376 * ospf_packet.c (ospf_write), (ospf_read): Print send/recv
4377 interface in debug message.
4378
43791999-08-25 Toshiaki Takada <takada@zebra.org>
4380
4381 * ospf_packet.c (ospf_ls_ack_send): The name is changed from
4382 `ospf_ls_ack_send'.
4383 (ospf_ls_ack_send_delayed) (ospf_ls_ack_timer): New function added.
4384 Delayed Link State Acknowledgment is scheduled by timer.
4385
43861999-08-25 Alex Zinin <zinin@amt.ru>
4387
4388 * ospf_lsa.c (ospf_router_lsa): Incorrectly included link to
4389 a stub network instead of link to a transit network into
4390 originated router-LSA, bug fixed.
4391
43921999-08-24 Toshiaki Takada <takada@zebra.org>
4393
4394 * ospfd.c (ospf_update_router_id): New function added.
4395
4396 * ospf_network.c (ospf_write): Create new socket per transmission.
4397 And select outgoing interface whether dst is unicast or multicast.
4398
4399 * ospf_packet.c: LSA flooding will work.
4400
44011999-08-24 VOP <vop@unity.net>
4402
4403 * ospf_route.c: Include "sockunion.h"
4404
44051999-08-24 Kunihiro Ishiguro <kunihiro@zebra.org>
4406
4407 * ospf_network.c (ospf_serv_sock_init): Enclose
4408 IPTOS_PREC_INTERNETCONTROL setting with #ifdef for OS which does
4409 not have the definition.
4410
44111999-08-23 Toshiaki Takada <takada@zebra.org>
4412
4413 * ospf_packet.c: Fix bug of DD processing.
4414
44151999-08-18 Toshiaki Takada <takada@zebra.org>
4416
4417 * ospf_lsa.c (show_ip_ospf_database): Show actual `LS age'.
4418
44191999-08-17 Toshiaki Takada <takada@zebra.org>
4420
4421 * ospf_lsa.h (OSPF_MAX_LSA): The value of OSPF_MAX_LSA is
4422 corrected. The bug of `mes_lookup' is fixed.
4423 This had been reported by Poul-Henning Kamp <phk@freebsd.org>.
4424
4425 * ospf_lsa.c (ospf_router_lsa_install): The name is changed from
4426 `ospf_add_router_lsa'.
4427 (ospf_network_lsa_install): The name is changed from
4428 `ospf_add_network_lsa'.
4429
4430 * ospf_interface.h (ospf_interface): Add member `nbr_self'.
4431
4432 * ospf_interface.c (ospf_if_is_enable): New function added.
4433
44341999-08-16 Toshiaki Takada <takada@zebra.org>
4435
4436 * ospf_lsa.h (struct lsa_header): The name is changed from
4437 `struct ospf_lsa'.
4438 (struct ospf_lsa): New struct added to control each LSA's aging
4439 and timers.
4440
4441 * ospf_lsa.c (ospf_lsa_data_free): The name is change from
4442 `ospf_lsa_free'.
4443 (ospf_lsa_data_new), (ospf_lsa_new), (ospf_lsa_free),
4444 (ospf_lsa_different), (ospf_lsa_install): New function added.
4445
4446 * ospf_packet.c (ospf_ls_upd_list_lsa): New function added.
4447
44481999-08-12 Toshiaki Takada <takada@zebra.org>
4449
4450 * ospf_nsm.c (nsm_reset_nbr): New function added.
4451 KillNbr and LLDown neighbor event call this function.
4452
44531999-08-10 Toshiaki Takada <takada@zebra.org>
4454
4455 * ospf_packet.c (ospf_ls_retransmit)
4456 (ospf_ls_upd_timer): New function added.
4457 Set retransmission timer for Link State Update.
4458
44591999-07-29 Toshiaki Takada <takada@zebra.org>
4460
4461 * ospf_ism.c (ospf_dr_election): Fix bug of DR election.
4462
44631999-07-28 Toshiaki Takada <takada@zebra.org>
4464
4465 * ospf_network.c (ospf_serv_sock_init): Set IP precedence field
4466 with IPTOS_PREC_INTERNET_CONTROL.
4467
4468 * ospf_nsm.c (nsm_change_status): Schedule NeighborChange event
4469 if NSM status change.
4470
4471 * ospf_packet.c (ospf_make_hello): Never include a neighbor in
4472 Hello packet, when the neighbor goes down.
4473
44741999-07-26 Kunihiro Ishiguro <kunihiro@zebra.org>
4475
4476 * Makefile.am (noinst_HEADERS): Add ospf_route.h.
4477
4478 * ospf_route.c (show_ip_ospf_route): Add `show ip ospf route'
4479 command.
4480
44811999-07-25 Toshiaki Takada <takada@zebra.org>
4482
4483 * ospf_lsa.c (ospf_router_lsa): Fix bug of LS sequence number
4484 assignement.
4485
44861999-07-25 Kunihiro Ishiguro <kunihiro@zebra.org>
4487
4488 * ospf_route.c (ospf_route_table_free): New function added.
4489
4490 * ospf_spf.c (ospf_spf_next): Free vertex w when cw's and w's
4491 distance is same.
4492
4493 * ospfd.h (struct ospf): Add old_table.
4494
4495 * ospf_main.c (sighup): Call of log_rotate () removed.
4496
4497 * ospf_lsa.c (ospf_lsa_is_self_originated): Fix bug of checking
4498 area->lsa as self LSA. This should be area->lsa_self.
4499
45001999-07-24 Kunihiro Ishiguro <kunihiro@zebra.org>
4501
4502 * ospf_zebra.c (ospf_zebra_add): ospf_zebra_add
4503 (),ospf_zebra_delete () added.
4504
4505 * ospf_spf.c (ospf_spf_calculate): Call ospf_intra_route_add ().
4506
45071999-07-24 Toshiaki Takada <takada@zebra.org>
4508
4509 * ospf_lsa.c: Change LS sequence number treatment.
4510 (ospf_lsa_is_self_originated): New function added.
4511 (show_ip_ospf_database_self_originated): New DEFUN added.
4512
45131999-07-23 Kunihiro Ishiguro <kunihiro@zebra.org>
4514
4515 * ospf_interface.c (ospf_if_lookup_by_addr): Add loopback check.
4516
45171999-07-22 Toshiaki Takada <takada@zebra.org>
4518
4519 * ospf_spf.c (ospf_nexthop_new), (ospf_nexthop_free),
4520 (ospf_nexthop_dup): function added.
4521 (ospf_nexthop_calculation): function changed.
4522
4523 * ospf_interface.c (ospf_if_lookup_by_addr): function added.
4524
45251999-07-21 Toshiaki Takada <takada@zebra.org>
4526
4527 * ospf_spf.c (ospf_spf_closest_vertex): function removed.
4528
45291999-07-21 Kunihiro Ishiguro <kunihiro@zebra.org>
4530
4531 * ospf_spf.c (ospf_spf_next): Apply ntohs for fetching metric.
4532
45331999-07-21 Toshiaki Takada <takada@zebra.org>
4534
4535 * ospf_neighbor.c (ospf_nbr_lookup_by_router_id): fundtion removed.
4536
4537 * ospf_lsa.c (show_ip_ospf_database_router): describe each
4538 connected link.
4539
45401999-07-21 Kunihiro Ishiguro <kunihiro@zebra.org>
4541
4542 * ospf_spf.c (ospf_spf_next): V is router LSA or network LSA so
4543 change behavior according to LSA type.
4544 (ospf_lsa_has_link): Link check function is added.
4545
45461999-07-20 Kunihiro Ishiguro <kunihiro@zebra.org>
4547
4548 * ospf_spf.c (ospf_spf_calculate_schedule): Add new function for
4549 SPF calcultion schedule addtition.
4550 (ospf_spf_calculate_timer_add): Rough 30 sec interval SPF calc
4551 timer is added.
4552 (ospf_spf_next_router): Delete ospf_spf_next_network ().
4553
4554 * ospf_lsa.c (show_ip_ospf_database_all): Network-LSA display
4555 header typo correction. Display of router LSA's #link added.
4556
45571999-07-19 Toshiaki Takada <takada@zebra.org>
4558
4559 * ospf_packet.c (ospf_check_network_mask): Added new function for
4560 receiving Raw IP packet on an appropriate interface.
4561
45621999-07-16 Toshiaki Takada <takada@zebra.org>
4563
4564 * ospfd.c (ospf_router_id): new DEFUN added.
4565
45661999-07-15 Toshiaki Takada <takada@zebra.org>
4567
4568 * ospf_spf.c (ospf_spf_init), (ospf_spf_free),
4569 (ospf_spf_has_vertex), (ospf_vertex_lookup),
4570 (ospf_spf_next_router), (ospf_spf_next_network),
4571 (ospf_spf_closest_vertex), (ospf_spf_calculate):
4572 function added.
4573
45741999-07-13 Toshiaki Takada <takada@zebra.org>
4575
4576 * ospf_ism.c: fix bug of DR Election.
4577
4578 * ospf_nsm.c: fix bug of adjacency forming.
4579
45801999-07-05 Kunihiro Ishiguro <kunihiro@zebra.org>
4581
4582 * ospfd.c (ospf_init): Change to use install_default.
4583
45841999-07-01 Rick Payne <rickp@rossfell.co.uk>
4585
4586 * ospf_zebra.c (zebra_init): Install standard commands to
4587 ZEBRA_NODE.
4588
45891999-06-30 Toshiaki Takada <takada@zebra.org>
4590
4591 * ospf_dump.c: Whole debug command is improved.
4592 (ISM|NSM) (events|status|timers) debug option added.
4593 (show_debugging_ospf): new DEFUN added.
4594
45951999-06-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4596
4597 * ospf_lsa.c (ospf_lsa_lookup_from_list): Change !IPV4_ADDR_CMP to
4598 IPV4_ADDR_SAME.
4599
46001999-06-29 Toshiaki Takada <takada@zebra.org>
4601
4602 * ospf_dump.c (ospf_summary_lsa_dump): Add summary-LSA dump routine.
4603 (ospf_as_external_lsa_dump): Add AS-external-LSA dump routine.
4604
4605 * ospf_nsm.c (nsm_twoway_received): fix condtion of adjacnet.
4606
4607 * ospf_ism.c (ospf_dr_election): fix DR Election.
4608
4609 * ospf_dump.c (ospf_nbr_state_message): fix `show ip ospf neighbor'
4610 command's state.
4611
46121999-06-29 Kunihiro Ishiguro <kunihiro@zebra.org>
4613
4614 * ospf_dump.c (ospf_router_lsa_dump): Add router-LSA dump routine.
4615
46161999-06-28 Toshiaki Takada <takada@zebra.org>
4617
4618 * ospf_lsa.c (show_ip_ospf_database_network): fix bug of
4619 `show ip ospf database network' command output.
4620
4621 * ospf_nsm.c (nsm_inactivity_timer): Clear list of Link State
4622 Retransmission, Database Summary and Link State Request.
4623
4624 * ospf_packet.c (ospf_ls_req_timer): New function added.
4625 Set Link State Request retransmission timer.
4626
46271999-06-27 Kunihiro Ishiguro <kunihiro@zebra.org>
4628
4629 * ospf_main.c (main): Change default output from ZLOG_SYSLOG to
4630 ZLOG_STDOUT.
4631
4632 * ospfd.c (ospf_init): Register show_ip_ospf_interface_cmd and
4633 show_ip_ospf_neighbor_cmd to VIEW_NODE.
4634
4635 * ospf_lsa.c (ospf_lsa_init): Register show_ip_ospf_database_cmd
4636 and show_ip_ospf_database_type_cmd to VIEW_NODE.
4637
46381999-06-25 Toshiaki Takada <takada@zebra.org>
4639
4640 * ospf_packet.c: fix bug of DD making.
4641 fix bug of LS-Update reading.
4642
46431999-06-23 Toshiaki Takada <takada@zebra.org>
4644
4645 * ospf_packet.c: All type of packets are changed to use
4646 fifo queue structure.
4647 (ospf_fill_header) function added.
4648
46491999-06-22 Toshiaki Takada <takada@zebra.org>
4650
4651 * ospf_packet.c (ospf_packet_new): New function added to handle
4652 sending ospf packet by fifo queue structure.
4653 (ospf_packet_free), (ospf_fifo_new), (ospf_fifo_push),
4654 (ospf_fifo_pop), (ospf_fifo_head), (ospf_fifo_flush),
4655 (ospf_fifo_free): Likewise.
4656
46571999-06-21 Toshiaki Takada <takada@zebra.org>
4658
4659 * ospf_nsm.c (ospf_db_desc_timer): function added.
4660 (nsm_timer_set) function added.
4661 * ospf_dump.c (ospf_option_dump): function added.
4662 * ospf_packet.c (ospf_ls_req) (ospf_make_ls_req): function added.
4663
46641999-06-20 Toshiaki Takada <takada@zebra.org>
4665
4666 * ospf_lsa.c (ospf_lsa_more_recent): function added.
4667 * ospf_neighbor.h (struct ospf_neighbor): Change member ms_flag
4668 to dd_flags.
4669
46701999-06-19 Toshiaki Takada <takada@zebra.org>
4671
4672 * ospf_lsa.c: DEFUN (show_ip_ospf_database) Added.
4673 * ospf_interface.c (if_ospf_cost), (if_ospf_dead_interval),
4674 (if_ospf_hello_interval), (if_ospf_priority),
4675 (if_ospf_retransmit_interval), (if_ospf_transmit_delay)
4676 argument changed from NUMBER to <range>.
4677 DEFUN (if_ospf_network_broadcast),
4678 DEFUN (if_ospf_network_non_broadcast),
4679 DEFUN (if_ospf_network_point_to_multipoint),
4680 DEFUN (if_ospf_network_point_to_point) functions are combined to
4681 DEFUN (if_ospf_network).
4682
46831999-06-18 Toshiaki Takada <takada@zebra.org>
4684
4685 * ospf_lsa.c: ospf_add_router_lsa (), ospf_add_network_lsa (),
4686 ospf_lsa_lookup (), ospf_lsa_count () Added.
4687
46881999-06-15 Toshiaki Takada <takada@zebra.org>
4689
4690 * DEFUN (ospf_debug_ism), DEFUN (ospf_debug_nsm),
4691 DEFUN (no_ospf_debug_ism), DEFUN (no_ospf_debug_nsm) Added.
4692 `debug ospf ism' command shows debug message.
4693 `debuf ospf nsm' command shows debug message.
4694
46951999-06-14 Toshiaki Takada <takada@zebra.org>
4696
4697 * ospf_lsa.c: ospf_network_lsa () Added.
4698 ospf_lsa_checksum () Added.
4699 * DEFUN (ospf_debug_packet), DEFUN (no_ospf_debug_packet) Added.
4700 `debug ospf packet' command shows debug message.
4701
47021999-06-13 Toshiaki Takada <takada@zebra.org>
4703
4704 * ospf_packet.h: Remove struct ospf_ls_req {}, ospf_ls_upd {},
4705 ospf_ls_ack {}.
4706
47071999-06-11 Toshiaki Takada <takada@zebra.org>
4708
4709 * ospf_dump.c: fix IP packet length treatment.
4710
47111999-06-10 Toshiaki Takada <takada@zebra.org>
4712
4713 * ospf_ism.h: Add OSPF_ISM_EVENT_EXECUTE() Macro Added.
4714 * ospf_nsm.h: Add OSPF_NSM_EVENT_EXECUTE() Macro Added.
4715
4716 * ospf_packet.c: ospf_db_desc (), ospf_db_desc_send () Added.
4717 ospf_make_hello (), ospf_make_db_desc () Added.
4718 ospf_db_desc_proc () Added.n
4719
4720 * Database Description packet can be processed.
4721
47221999-06-08 Toshiaki Takada <takada@zebra.org>
4723
4724 * ospf_lsa.c: New file.
4725
47261999-06-07 Toshiaki Takada <takada@zebra.org>
4727
4728 * ospf_neighbor.c: ospf_fully_adjacent_count () Added.
4729
47301999-06-07 Kunihiro Ishiguro <kunihiro@zebra.org>
4731
4732 * ospf_spf.[ch]: New file.
4733
47341999-05-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4735
4736 * ospf_zebra.c: Changed to use lib/zclient.c routines.
4737
4738 * ospf_zebra.h (zebra_start): Remove struct zebra.
4739
47401999-05-29 Kunihiro Ishiguro <kunihiro@zebra.org>
4741
4742 * ospfd.c (ospf_config_write): Add cast (unsigned long int) to
4743 ntohl for sprintf warning.
4744
47451999-05-19 Toshiaki Takada <takada@zebra.org>
4746
4747 * ospf_ism.c (ospf_dr_election): Join AllDRouters Multicast group
4748 if interface state changes to DR or BDR.
4749
47501999-05-14 Stephen R. van den Berg <srb@cuci.nl>
4751
4752 * ospf_main.c (signal_init): SIGTERM call sigint.
4753 (sigint): Logging more better message.
4754
47551999-05-12 Toshiaki Takada <takada@zebra.org>
4756
4757 * ospfd.c: Fix bug of `no router ospf' statement, it will work.
4758
47591999-05-11 Toshiaki Takada <takada@zebra.org>
4760
4761 * ospf_neighbor.c: ospf_nbr_free () Added.
4762
47631999-05-10 Toshiaki Takada <takada@zebra.org>
4764
4765 * ospfd.h: struct ospf_area { }, struct ospf_network { } Changed.
4766 * Fix bug of `no network' statement, it will work.
4767
47681999-05-07 Toshiaki Takada <takada@zebra.org>
4769
4770 * ospf_interface.c, ospf_zebra.c: Fix bug of last interface is not
4771 updated by ospf_if_update ().
4772
47731999-04-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4774
4775 * Makefile.am (noinst_HEADERS): Add ospf_lsa.h for distribution.
4776
47771999-04-25 Toshiaki Takada <takada@zebra.org>
4778
4779 * ospf_interface.c: DEFUN (no_if_ospf_cost),
4780 DEFUN (no_if_ospf_dead_interval),
4781 DEFUN (no_if_ospf_hello_interval),
4782 DEFUN (no_if_ospf_priority),
4783 DEFUN (no_if_ospf_retransmit_interval),
4784 DEFUN (no_if_ospf_transmit_delay) Added.
4785
4786 interface_config_write () suppress showing interface
4787 default values.
4788
47891999-04-25 Kunihiro Ishiguro <kunihiro@zebra.org>
4790
4791 * ospf_dump.c (ospf_timer_dump): If thread is NULL return "inactive".
4792
4793 * ospfd.c (ospf_if_update): Fix bug of using ospf_area { } instead
4794 of ospf_network { }. So `router ospf' statement in ospfd.conf
4795 works again.
4796 (ospf_if_update): Call ospf_get_router_id for updating router ID.
4797
47981999-04-25 Toshiaki Takada <takada@zebra.org>
4799
4800 * ospf_interface.c: DEFUN (if_ospf_network) deleted.
4801 DEFUN (if_ospf_network_broadcast),
4802 DEFUN (if_ospf_network_non_broadcast),
4803 DEFUN (if_ospf_network_point_to_multipoint),
4804 DEFUN (if_ospf_network_point_to_point),
4805 DEFUN (no_if_ospf_network) Added.
4806
48071999-04-23 Toshiaki Takada <takada@zebra.org>
4808
4809 * ospfd.h: struct area { } changed to struct ospf_network { }.
4810 Add struct ospf_area { }.
4811 * ospfd.c: Add ospf_area_lookup_by_area_id (), ospf_network_new (),
4812 and ospf_network_free ().
4813 DEFUN (area_authentication), DEFUN (no_area_authentication) Added.
4814
48151999-04-22 Toshiaki Takada <takada@zebra.org>
4816
4817 * ospf_lsa.h: New file.
4818 * ospf_packet.h: LSA related struct definition are moved to
4819 ospf_lsa.h.
4820 * ospf_packet.c: ospf_verify_header () Added.
4821
48221999-04-21 Toshiaki Takada <takada@zebra.org>
4823
4824 * ospf_ism.c: ospf_elect_dr () and related function is changed.
4825 DR Election bug fixed.
4826 * ospf_dump.c: ospf_nbr_state_message (), ospf_timer_dump () Added.
4827 * ospfd.c: DEFUN (show_ip_ospf_neighbor) Added.
4828
48291999-04-19 Kunihiro Ishiguro <kunihiro@zebra.org>
4830
4831 * ospf_main.c (main): access_list_init () is added for vty
4832 connection filtering.
4833
48341999-04-16 Toshiaki Takada <takada@zebra.org>
4835
4836 * ospfd.c: DEFUN (show_ip_ospf_interface) Added.
4837 * ospf_neighbor.c: ospf_nbr_count () Added.
4838
48391999-04-15 Toshiaki Takada <takada@zebra.org>
4840
4841 * ospfd.h: struct ospf { } Changed.
4842 * ospfd.c: ospf_lookup_by_process_id () Deleted.
4843 * ospf_ism.c: ospf_wait_timer () Added. WaitTimer will work.
4844
48451999-04-14 Toshiaki Takada <takada@zebra.org>
4846
4847 * ospf_ism.c: ospf_elect_dr () Added.
4848 * ospf_network.c: ospf_if_ipmulticast () Added.
4849
48501999-04-11 Toshiaki Takada <takada@zebra.org>
4851
4852 * ospf_interface.c: interface_config_write (),
4853 DEFUN (if_ip_ospf_cost),
4854 DEFUN (if_ip_ospf_dead_interval),
4855 DEFUN (if_ip_ospf_hello_interval),
4856 DEFUN (if_ip_ospf_priority),
4857 DEFUN (if_ip_ospf_retransmit_interval) and
4858 DEFUN (if_ip_ospf_transmit_delay) Added.
4859
48601999-04-08 Toshiaki Takada <takada@zebra.org>
4861
4862 * ospf_dump.c: ospf_packet_db_desc_dump () Added.
4863 * ospf_neighbor.c: ospf_nbr_bidirectional () Added.
4864 * ospf_nsm.c: nsm_twoway_received () Added.
4865
48661999-04-02 Toshiaki Takada <takada@zebra.org>
4867
4868 * ospf_neighbor.c: New file.
4869 * ospf_neighbor.h: New file.
4870 * ospf_nsm.c: New file.
4871 * ospf_nsm.h: New file.
4872 * ospf_packet.c: Add ospf_make_header (), ospf_hello () and
4873 ospf_hello_send (). Now OSPFd can receive Hello and send Hello.
4874
48751999-03-27 Kunihiro Ishiguro <kunihiro@zebra.org>
4876
4877 * ospf_packet.c: Add ospf_recv_packet (). Now OSPF Hello can receive.
4878
48791999-03-19 Toshiaki Takada <takada@zebra.org>
4880
4881 * ospf_packet.c: New file.
4882 * ospf_packet.h: New file.
4883 * ospf_network.c: New file.
4884 * ospf_network.h: New file.
4885 * ospfd.h: move OSPF message structure has moved to ospf_packet.h.
4886
48871999-03-17 Kunihiro Ishiguro <kunihiro@zebra.org>
4888
4889 * ospf_zebra.c (ospf_zebra_get_interface): Fix for IPv6 interface
4890 address.
4891
4892 * Makefile.am (install-sysconfDATA): Overwrite install-sysconfDATA
4893 for install ospfd.conf.sample as owner read only file.
4894
4895 * ospf_main.c (usage): Change to use ZEBRA_BUG_ADDRESS.
4896
48971999-03-15 Toshiaki Takada <takada@zebra.org>
4898
4899 * ospf_ism.c: New file.
4900 * ospf_ism.h: New file.
4901 * ospf_dump.c: New file.
4902 * ospf_dump.h: New file.
4903
4904 * ospfd.h: Add (struct ospf), (struct config_network),
4905 (struct message) structure.
4906
4907 * ospf_interface.c: Add ospf_if_match_network ().
4908 * ospf_interface.h (struct ospf_interface): Change struct members.
4909
4910 * ospfd.c: ospf_lookup_by_process_id (), ospf_network_new (),
4911 DEFUN (network_area): Added.
4912
4913 * ospfd.conf.sample: Change sample configuration.
4914
49151999-03-05 Toshiaki Takada <takada@zebra.org>
4916
4917 * ospf_interface.c: New file.
4918 * ospf_interface.h: New file.
4919 * ospf_zebra.h: New file.
4920 * ospf_zebra.c: Add interface function for zebra daemon.
4921 * ospfd.c: New file.
4922
49231999-02-23 Kunihiro Ishiguro <kunihiro@zebra.org>
4924
4925 * Move IPv6 codes and files to ospf6d directory.
4926
49271999-02-18 Peter Galbavy <Peter.Galbavy@knowledge.com>
4928
4929 * syslog support added
4930
49311998-12-22 Toshiaki Takada <takada@zebra.org>
4932
4933 * ospfd.h: New file.
4934 * ospf_lsa.h: New file.
4935
49361998-12-15 Kunihiro Ishiguro <kunihiro@zebra.org>
4937
4938 * Makefile.am: New file.
4939 * ospf_main.c: New file.
4940