blob: 4630ab97925a217fa8dc9c8c286fcb285edc47aa [file] [log] [blame]
Paul Jakmaa15cfd12008-06-01 14:29:03 +000012008-06-01 jfletche@gmail.com
2
3 * bgp_attr.c: (bgp_attr_aspathlimit) fix silly bug in flags check
4 that was causing BGP to drop sessions if it received a
5 aspath-limit with partial set. Fixes bug #419.
6
Denis Ovsienko841f7a52008-04-10 11:47:45 +000072008-04-10 Denis Ovsienko
Paul Jakmaa15cfd12008-06-01 14:29:03 +00008
Denis Ovsienko841f7a52008-04-10 11:47:45 +00009 * bgp_aspath.[ch]: (aspath_filter_exclude) New function allows
10 filtering out arbitrary ASns from AS_PATH attribute.
11 * bgp_aspath.[ch]: (aspath_print_vty) Accept suffix to let calling
12 functions signal, if they want the separator or not.
13 * bgp_route.c: (route_vty_out, route_vty_out_tmp, damp_route_vty_out,
14 flap_route_vty_out, route_vty_out_detail) Fix aspath_print_vty()
15 calls to have AS_PATH output nicely.
16 * bgp_routemap.c: Introduce "set as-path exclude" route-map command
17 to employ new filtering functionality.
18
Paul Jakma693b67b2008-03-13 03:31:24 +0000192008-03-13 Paul Jakma <paul.jakma@sun.com>
20
21 * (various) Remove 0 entries from struct message's, unneeded due to
22 recent improvements in mes_lookup/LOOKUP.
23
Paul Jakma90b68762008-01-29 17:26:34 +0000242008-01-29 Jorge Boncompte <jorge@dti2.net>
25
26 * bgp_network.c: (bgp_socket) IPv4-only version crashes if -l is not
27 used as address will be null.
28
Paul Jakma370b64a2007-12-22 16:49:52 +0000292007-12-22 Paul Jakma <paul.jakma@sun.com>
30
31 * Fix series of vulnerabilities reported by "Mu Security
32 Research Team", where bgpd can be made to crash by sending
33 malformed packets - requires that bgpd be configured with a
34 session to the peer.
35 * bgp_attr.c: (bgp_attr_as4_path) aspath_parse may fail, only
36 set the attribute flag indicating AS4_PATH if we actually managed
37 to parse one.
38 (bgp_attr_munge_as4_attrs) Assert was too general, it is possible
39 to receive AS4_AGGREGATOR before AGGREGATOR.
40 (bgp_attr_parse) Check that we have actually received the extra
41 byte of header for Extended-Length attributes.
42 * bgp_attr.h: Fix BGP_ATTR_MIN_LEN to account for the length byte.
43 * bgp_open.c: (cap_minsizes) Fix size of CAPABILITY_CODE_RESTART,
44 incorrect -2 left in place from a development version of as4-path
45 patch.
46 * bgp_packet.c: (bgp_route_refresh_receive) ORF length parameter
47 needs to be properly sanity checked.
48
Denis Ovsienkoa7f93f32007-12-18 15:13:06 +0000492007-12-18 Denis Ovsienko
50
51 * bgp_routemap.c: (no_set_aspath_prepend) This command cancelled
52 existing "set" command regardless if "no set" matched it or not.
53 Fixed.
54
Paul Jakma7e992e92007-11-13 09:32:23 +0000552007-11-13 Paul Jakma <paul.jakma@sun.com>
56
57 * bgp_main.c: Small fix, format string parameters should never
58 be NULL - it's not strictly valid and some libc's don't let
59 you away with.
60
Paul Jakma3a02d1f2007-11-01 14:29:11 +0000612007-10-30 Nick Hilliard <nick@inex.ie>
62
63 * bgp_main.c: Add 'listenon' argument, to pass address to bind
64 to.
65 * bgp_network.c: (bgp_socket) Extend to take bind address.
66 * bgpd.c: (bgp_init) Pass stored address.
67 * bgpd.h: (struct bgp_master) storage for bind address
68
Paul Jakma0b2aa3a2007-10-14 22:32:21 +0000692007-09-27 Paul Jakma <paul.jakma@sun.com>
70
71 * bgp_aspath.c: (assegment_normalise) remove duplicates from
72 from sets.
73 (aspath_reconcile_as4) disregard a broken part of the RFC around
74 error handling in path reconciliation.
75
762007-09-25 Paul Jakma <paul.jakma@sun.com>
77
78 * bgp_open.c: (peek_for_as4_capability) Fix to work.
79 * bgp_packet.c: (bgp_open_receive) Fix sanity check of as4.
80
812007-09-18 Paul Jakma <paul.jakma@sun.com>
82
83 * bgp_open.c: (bgp_capability_as4) debug printf inline with others.
84 (peek_for_as4_capability) There's no need to signal failure, as
85 failure is better dealt with through full capability parser -
86 just return the AS4, simpler.
87 * bgp_packet.c: (bgp_open_receive) Update to match
88 peek_for_as4_capability change.
89 Allow use of BGP_AS_TRANS by 2b speakers.
90 Use NOTIFY_OPEN_ERR rather than CEASE for OPEN parsing errors.
91 (bgp_capability_msg_parse) missing argument to debug print
92 (bgp_capability_receive) missing return values.
93
94
952007-07-25 Paul Jakma <paul.jakma@sun.com>
96
97 * Remove 2-byte size macros, just make existing macros take
98 argument to indicate which size to use.
99 Adjust all users - typically they want '1'.
100 * bgp_aspath.c: (aspath_has_as4) New, return 1 if there are any
101 as4's in a path.
102 (aspath_put) Return the number of bytes actually written, to
103 fix the bug Juergen noted: Splitting of segments will change
104 the number of bytes written from that already written to the
105 AS_PATH header.
106 (aspath_snmp_pathseg) Pass 2-byte flag to aspath_put. SNMP
107 is still defined as 2b.
108 (aspath_aggregate) fix latent bug.
109 (aspath_reconcile_as4) AS_PATH+NEW_AS_PATH reconciliation
110 function.
111 (aspath_key_make) Hash the AS_PATH string, rather than
112 just taking the addition of assegment ASes as the hash value,
113 hopefully sligthly more collision resistant.
114 (bgp_attr_munge_as4_attrs) Collide the NEW_ attributes
115 together with the OLD 2-byte forms, code Juergen
116 had in bgp_attr_parse but re-organised a bit.
117 (bgp_attr_parse) Bunch of code from Juergen moves
118 to previous function.
119 (bgp_packet_attribute) Compact significantly by
120 just /always/ using extended-length attr header.
121 Fix bug Juergen noted, by using aspath_put's
122 (new) returned size value for the attr header rather
123 than the (guesstimate) of aspath_size() - the two could
124 differ when aspath_put had to split large segments, unlikely
125 this bug was ever hit in the 'wild'.
126 (bgp_dump_routes_attr) Always use extended-len and
127 use aspath_put return for header length. Output 4b ASN
128 for AS_PATH and AGGREGATOR.
129 * bgp_ecommunity.c: (ecommunity_{hash_make,cmp}) fix
130 hash callback declarations to match prototypes.
131 (ecommunity_gettoken) Updated for ECOMMUNITY_ENCODE_AS4,
132 complete rewrite of Juergen's changes (no asdot support)
133 * bgp_open.c: (bgp_capability_as4) New, does what it says
134 on the tin.
135 (peek_for_as4_capability) Rewritten to use streams and
136 bgp_capability_as4.
137 * bgp_packet.c: (bgp_open_send) minor edit
138 checked (in the abstract at least) with Juergen.
139 Changes are to be more accepting, e.g, allow AS_TRANS on
140 a 2-byte session.
141 * (general) Update all commands to use CMD_AS_RANGE.
142 * bgp_vty.c: (bgp_clear) Fix return vals to use CMD_..
143 Remove stuff replicated by VTY_GET_LONG
144 (bgp_clear_vty) Return bgp_clear directly to vty.
145
146
1472007-07-25 Juergen Kammer <j.kammer@eurodata.de>
148
149 * (general) AS4 support.
150 * bgpd.h: as_t changes to 4-bytes.
151 * bgp_aspath.h: Add BGP_AS4_MAX and BGP_AS_TRANS defines.
152 * bgp_aspath.c: AS_VALUE_SIZE becomes 4-byte, AS16_VALUE_SIZE
153 added for 2-byte.
154 Add AS16 versions of length calc macros.
155 (aspath_count_numas) New, count number of ASes.
156 (aspath_has_as4) New, return 1 if there are any as4's in a
157 path.
158 (assegments_parse) Interpret assegment as 4 or 2 byte,
159 according to how the caller instructs us, with a new
160 argument.
161 (aspath_parse) Add use32bit argument to pass to
162 assegments_parse. Adjust all its callers to pass 1, unless
163 otherwise noted.
164 (assegment_data_put) Adjust to be able to write 2 or 4 byte
165 AS, according to new use32bit argument.
166 (aspath_put) Adjust to write 2 or 4.
167 (aspath_gettoken) Use a long for passed in asno.
168 * bgp_attr.c: (attr_str) Add BGP_ATTR_AS4_PATH and
169 BGP_ATTR_AS4_AGGREGATOR.
170 (bgp_attr_aspath) Call aspath_parse with right 2/4 arg, as
171 determined by received-capability flag.
172 (bgp_attr_aspath_check) New, code previously in attr_aspath
173 but moved to new func so it can be run after NEW_AS_PATH
174 reconciliation.
175 (bgp_attr_as4_path) New, handle NEW_AS_PATH.
176 (bgp_attr_aggregator) Adjust to cope with 2/4 byte ASes.
177 (bgp_attr_as4_aggregator) New, read NEW_AGGREGATOR.
178 (bgp_attr_parse) Add handoffs to previous parsers for the two
179 new AS4 NEW_ attributes.
180 Various checks added for NEW/OLD reconciliation.
181 (bgp_packet_attribute) Support 2/4 for AS_PATH and
182 AGGREGATOR, detect when NEW_ attrs need to be sent.
183 * bgp_debug.{c,h}: Add 'debug bgp as4'.
184 * bgp_dump.c: MRTv2 support, unconditionally enabled, which
185 supports AS4. Based on patches from Erik (RIPE?).
186 * bgp_ecommunity.c: (ecommunity_ecom2str) ECOMMUNITY_ENCODE_AS4
187 support.
188 * bgp_open.c: (peek_for_as4_capability) New, peek for AS4
189 capability prior to full capability parsing, so we know which
190 ASN to use for struct peer lookup.
191 (bgp_open_capability) Always send AS4 capability.
192 * bgp_packet.c: (bgp_open_send) AS4 handling for AS field
193 (bgp_open_receive) Peek for AS4 capability first, and figure
194 out which AS to believe.
195 * bgp_vty.c: (bgp_show_peer) Print AS4 cap
196
Paul Jakmae08286b2007-09-18 12:11:26 +00001972007-09-17 Paul Jakma <paul.jakma@sun.com>
198
199 * bgp_open.c: (bgp_capability_mp) We were setting
200 afc_nego[safi][safi] rather than afc_nego[afi][safi], thus
201 failling to announce any non-IPv4 prefixes. Remove the extra,
202 typo-ed character.
203
Paul Jakmab2ceea12007-09-07 14:24:55 +00002042007-09-07 Paul Jakma <paul.jakma@sun.com>
205
206 * (general) bgpd can be made crash by remote peers if debug
207 bgp updates is set, due to NULL pointer dereference.
208 Reported by "Mu Security Research Team",
209 <security@musecurity.com>.
210 * bgp_attr.c: (bgp_attr_community) If community length is 0,
211 don't set the community-present attribute bit, just return
212 early.
213 * bgp_debug.c: (community_str,community_com2str) Check com
214 pointer before dereferencing.
215
Paul Jakma9eda90c2007-08-30 13:36:17 +00002162007-08-27 Paul Jakma <paul.jakma@sun.com>
217
218 * bgp_route.c: (bgp_announce_check) Fix bug #398, slight
219 modification of Vladimir Ivanov's suggested fix - to keep
220 memory alloc conditional.
221 (bgp_process_announce_selected) Don't take struct attr as
222 argument, none of the callers need it and it needlessly
223 distances allocation from use.
224 Free the extended attr, the attr itself is on the stack.
225 Fix bad indentation.
226 * bgp_attr.c: (bgp_packet_attribute) Remove incorrect assert,
227 and adjust conditional to test attr->extra, diagnosis by
228 Vladimir Ivanov in bug #398.
229
2302007-08-27 Vladimir Ivanov <wawa@yandex-team.ru>
231
232 * bgp_route.c: (bgp_announce_check_rsclient) copy of
233 ri->attr is no longer deep enough, due to addition of
234 attr->extra. It should use bgp_attr_dup, as
235 bgp_announce_check() does.
236
Paul Jakma6d134fb2007-08-23 23:22:02 +00002372007-08-23 Paul Jakma <paul.jakma@sun.com>
238
239 * bgp_regex.c: (bgp_regcomp) Pass NOSUB flag to regcomp to
240 prevent parsing of substitutions, which can have profound
241 performance effects on bgpd and are of no use to the CLI
242 anyway. How much it helps depends on the regex
243 implementation.
244
Paul Jakma41367172007-08-06 15:24:51 +00002452007-07-31 Paul Jakma <paul.jakma@sun.com>
246
247 * (general) Support for draft-ietf-idr-as-pathlimit-03.
248 * bgp_attr.h: (struct attr) Add pathlimit struct
249 bgp_attr.c: (attr_str) Add BGP_ATTR_AS_PATHLIMIT string.
250 (attrhash_key_make) tally pathlimit too
251 (attrhash_cmp) cmp pathlimit attr
252 (bgp_attr_aspathlimit) New, parse AS_PATHLIMIT attr.
253 (bgp_attr_parse) ditto
254 (bgp_packet_attribute) Write out AS_PATHLIMIT when set
255 (bgp_dump_routes_attr) ditto
256 * bgp_route.h: (struct bgp_static) Add TTL field
257 * bgp_route.c: (bgp_announce_check) Drop paths that are over
258 their hop-count TTL before sending via EBGP.
259 Mangle ASN in pathlimit for confeds/private as best we can.
260 (bgp_static_update_{rsclient,main}) Add any configure pathlimit
261 information.
262 (bgp_pathlimit_update_parents) New, update atomic-aggr setting for
263 parents of an aspathlimit'ed static.
264 (bgp_static_set) Add TTL argument, for all the 'bgp network'
265 commands.
266 Call previous for TTL changed statics.
267 (bgp_static_unset) Call pathlimit_update_parents.
268 (various bgp network commands) Add 'pathlimit <0-255>' qualifier
269 to all the various forms, bar route-map - which can set ttl
270 itself.
271 * bgp_routemap.c: (general) Add support for 'set pathlimit ttl' and
272 'match pathlimit as'.
273
Paul Jakma6d582722007-08-06 15:21:45 +00002742007-07-26 Paul Jakma <paul.jakma@sun.com>
275
276 * (general) Clean up and compact capability parsing slightly.
277 Consolidate validation of length and logging of generic TLV, and
278 memcpy of capability data, thus removing such from cap specifc
279 code (not always present or correct).
280 * bgp_open.h: Add structures for the generic capability TLV header
281 and for the data formats of the various specific capabilities we
282 support. Hence remove the badly named, or else misdefined, struct
283 capability.
284 * bgp_open.c: (bgp_capability_vty_out) Use struct capability_mp_data.
285 Do the length checks *before* memcpy()'ing based on that length
286 (stored capability - should have been validated anyway on input,
287 but..).
288 (bgp_afi_safi_valid_indices) new function to validate (afi,safi)
289 which is about to be used as index into arrays, consolidates
290 several instances of same, at least one of which appeared to be
291 incomplete..
292 (bgp_capability_mp) Much condensed.
293 (bgp_capability_orf_entry) New, process one ORF entry
294 (bgp_capability_orf) Condensed. Fixed to process all ORF entries.
295 (bgp_capability_restart) Condensed, and fixed to use a
296 cap-specific type, rather than abusing capability_mp.
297 (struct message capcode_str) added to aid generic logging.
298 (size_t cap_minsizes[]) added to aid generic validation of
299 capability length field.
300 (bgp_capability_parse) Generic logging and validation of TLV
301 consolidated here. Code compacted as much as possible.
302 * bgp_packet.c: (bgp_open_receive) Capability parsers now use
303 streams, so no more need here to manually fudge the input stream
304 getp.
305 (bgp_capability_msg_parse) use struct capability_mp_data. Validate
306 lengths /before/ memcpy. Use bgp_afi_safi_valid_indices.
307 (bgp_capability_receive) Exported for use by test harness.
308 * bgp_vty.c: (bgp_show_summary) fix conversion warning
309 (bgp_show_peer) ditto
310 * bgp_debug.h: Fix storage 'extern' after type 'const'.
311
Paul Jakma45ad5922007-07-31 17:35:36 +00003122007-07-31 Lorenzo Colitti <lorenzo@colitti.com>
313
314 * bgp_dump.c: (general) Add comments to code.
315 (bgp_dump_interval_add) remove some redundant lines.
316 (bgp_dump_set) Use enum for type argument.
317 Avoid scheduling dump twice if exact same command
318 is given twice..
319
Paul Jakma536792c2007-06-22 19:11:14 +00003202007-06-22 Paul Jakma <paul.jakma@sun.com>
321
322 * bgp_fsm.c: (struct FSM) Bug #368. TCP Errors during OpenSent
323 should cycle to Active, not to Idle or else peer bringup can
324 race and cycle Idle<->Active. Reported and fix tested by
325 Mukesh Agrawal.
326
Paul Jakmab2497022007-06-14 11:17:58 +00003272007-05-25 Paul Jakma <paul.jakma@sun.com>
328
329 * bgp_route.c: (bgp_default_originate) Sanity check added
330 previously was broken and always failed, thus this function
331 never could run, bug #370.
332
Paul Jakmafb982c22007-05-04 20:15:47 +00003332007-05-03 Paul Jakma <paul.jakma@sun.com>
Paul Jakma923de652007-04-29 18:25:17 +0000334
Paul Jakmafb982c22007-05-04 20:15:47 +0000335 * bgp_route.h: (struct info) Move less frequently used
336 fields to a lazily allocated struct info_extra.
337 Export bgp_info_extra_get
338 * bgp_route.c: (bgp_info_extra_new) allocate extra
339 (bgp_info_extra_free) Free damp info and the info_extra.
340 (bgp_info_extra_get) Retrieve the info_extra of a struct
341 info, allocating as required.
342 (generally) adjust to use info->extra
343 * bgp_damp.c: (generally) use bgp_info_extra_get to access
344 dampinfo
345 * bgp_attr.h: Move rarely allocated attributes from struct attr
346 to a struct attr_extra, for a substantial saving in size of
347 struct attr.
348 * bgp_attr.c: (bgp_attr_extra_{new,free}), new, self-explanatory.
349 (bgp_attr_extra_get) Get the attr_extra for a given struct
350 attr, allocating it if needs be.
351 (bgp_attr_dup) Shallow copy the struct attr and its attr_extra.
352 (generally) adjust to know about attr->extra.
353 * bgp_debug.c: (bgp_dump_attr) ditto
354 * bgp_vty.c: (show_bgp_memory) print attr and info extra sizes.
355 * bgp_nexthop.c: (generally) adjust to know about attr->extra
356 and info->extra.
357 * bgp_{packet,routemap,snmp,zebra}.c: ditto
358
3592007-04-22 Sebastien Tandel <sebastien@tandel.be>
Paul Jakma923de652007-04-29 18:25:17 +0000360 * bgp_advertise.c : (baa_hash_alloc, baa_hash_key, baa_hash_cmp)
361 conforms to quagga hash API. Defines _hash_[alloc|key|cmp] with
362 void * arguments as defined by the API.
363 * bgp_aspath.c,h : (aspath_key_make) conforms to quagga hash API.
364 Defines _hash_[alloc|key|cmp] with void * arguments as defined by
365 the API.
366 * bgp_attr.c,h : (cluster_hash_alloc, cluster_hash_key_make,
367 cluster_hash_cmp, transit_hash_alloc, transit_hash_key_make,
368 transit_hash_cmp, attrhash_key_make, attrhash_cmp,
369 bgp_attr_hash_alloc) conforms to quagga hash API. Defines
370 _hash_[alloc|key|cmp] with void * arguments as defined by the API.
Paul Jakma03e214c2007-04-29 18:31:07 +0000371 * bgp_attr.h : Definition of BGP_ATTR_DEFAULT_WEIGHT.
372 * bgp_attr.c : (bgp_attr_default_intern) now uses
373 bgp_attr_default_set instead of duplicating the same code.
374 (general) Use of BGP_ATTR_DEFAULT_WEIGHT. Replace two 16 by
375 IPV6_MAX_BYTELEN.
Paul Jakma923de652007-04-29 18:25:17 +0000376
Andrew J. Schorr93c17492007-04-15 19:17:24 +00003772007-04-15 Sebastien Tandel <sebastien@tandel.be>
378
379 * bgp_aspath.c: (aspath_as_add, aspath_segment_add) Minor performance
380 optimization: while loop should test one pointer instead of two.
381
Paul Jakma16d2e242007-04-10 19:32:10 +00003822007-04-08 Paul Jakma <paul.jakma@sun.com>
383
384 * bgp_route.c: (general) Same bug as fixed on 2006-11-28 by ajs for
385 bgp static routes, but for main BGP RIB: Quick 'flap' of routes
386 can cause bgpd to mistake a new route for a duplicate route,
387 due to presence of removed, but not yet processed BGP RIB entry.
388 (bgp_update_rsclient) Ignore REMOVED bgp_info for duplicate,
389 restore route instead.
390 (bgp_update_main) Ditto.
Paul Jakma6e4ab122007-04-10 19:36:48 +0000391 * bgp_attr.c: (general) Bug #354: parsing of MP_REACH_NLRI and
392 MP_UNREACH_NLRI does not take sufficient care to ensure reads
393 from stream buffer stay in-bounds. Hence bgpd may attempt to read
394 beyond end of stream, if given a crafted packet. As it uses the
395 stream access methods to do so, this will typically result in
396 assert() being hit in stream.c. Where code is compiled without
397 assert() enabled, result is unknown.
398 (struct message attr_str) should be static.
399 (bgp_mp_reach_parse) Carefully check length remaining in stream
400 against amount desired to read from stream, prior to each read,
401 particularly where lengths are conditional on data obtained from
402 stream - using STREAM_READABLE.
403 Remove code to parse SNPA-number, it's a defunct field and changed
404 to a fixed size in latest BGP MP update RFC - log warning if
405 SNPA-number is not 0.
406 (bgp_mp_unreach_parse) Check withdraw_length carefully against
407 STREAM_READABLE.
408 (bgp_attr_parse) If attribute-parser function returns error, log
409 warning.
410 Log attribute type on mismatch.
Paul Jakma16d2e242007-04-10 19:32:10 +0000411
Paul Jakma37a217a2007-04-10 19:20:29 +00004122007-04-07 Paul Jakma <paul.jakma@sun.com>
413
414 * bgpd.c: (general) Fix bug #352
415 (bgp_config_write_family_header) write ipv6/multicast
416 address family header.
417 (bgp_config_write) write out ipv6 multicast AF config.
418
Paul Jakmaf2c31ac2007-02-22 17:48:42 +00004192007-02-22 Paul Jakma <paul.jakma@sun.com>
420
421 * bgp_fsm.c: (bgp_fsm_change_status) Handle state change into
422 clearing or greater here. Simpler.
423 (bgp_event) Clearing state change work moved to previous
424 * bgp_route.c: (bgp_clear_route_node) Clearing adj-in here
425 is too late, as it leaves a race between a peer being deleted
426 and an identical peer being configured before clearing
427 completes, leading to a crash.
428 Simplest fix is to clean peers Adj-in up-front, rather than
429 queueing such work.
430 (bgp_clear_route_table) Clear peer's Adj-In and Adj-Out
431 up-front here, rather than queueing such work.
432 Extensive comment added on the various bits of indexed data
433 that exist and how they need to be dealt with.
434 (bgp_clear_route) Update comment.
435
Andrew J. Schorre4529632006-12-12 19:18:21 +00004362006-12-12 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
437
438 * bgp_nexthop.c: (bgp_connected_add, bgp_connected_delete)
439 Simplify logic by using new CONNECTED_PREFIX macro.
440
Paul Jakma95fdcd82006-12-08 00:31:22 +00004412006-12-07 Paul Jakma <paul.jakma@sun.com>
442
443 * bgp_fsm.c: Bug #302 fix, diagnosis, suggestions and testing
444 by Juergen Kammer <j.kammer@eurodata.de>. Fix follows from
445 his suggested fix, just made in a slightly different way.
446 (bgp_event) Transitions into Clearing always must call
447 bgp_clear_route_all().
448 (bgp_stop) No need to clear routes here, BGP FSM should do
449 it.
450
Andrew J. Schorra39275d2006-11-30 16:36:57 +00004512006-11-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
452
453 * bgp_debug.h: Declare new bgp_debug_zebra conf and term flags,
454 and define BGP_DEBUG_ZEBRA.
455 * bgp_debug.c: Declare conf_bgp_debug_zebra and term_bgp_debug_zebra.
456 (debug_bgp_zebra, no_debug_bgp_zebra, undebug_bgp_zebra) New
457 functions to enable/disable bgp zebra debugging.
458 (no_debug_bgp_all) Turn off zebra debugging.
459 (show_debugging_bgp) Show whether zebra debugging is on.
460 (bgp_config_write_debug) Add 'debug bgp zebra' if configured.
461 (bgp_debug_init) Add new zebra debugging commands.
462 * bgp_zebra.c: (bgp_router_id_update, bgp_interface_add,
463 bgp_interface_delete, bgp_interface_up, bgp_interface_down,
464 bgp_interface_address_add, bgp_interface_address_delete,
465 zebra_read_ipv4, zebra_read_ipv6, bgp_zebra_announce,
466 bgp_zebra_withdraw, bgp_redistribute_set, bgp_redistribute_unset)
467 If zebra debugging is enabled, log an appropriate debug message.
468
Andrew J. Schorr8d452102006-11-28 19:50:46 +00004692006-11-28 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
470
471 * bgp_route.c: (bgp_info_restore) New function that undoes
472 the effects of a previous call to bgp_info_delete. This is
473 used when a route is deleted and quickly re-added before the
474 deletion has been processed.
475 (bgp_static_update_rsclient, bgp_static_update_main,
476 bgp_redistribute_add) Check whether a pre-existing route
477 has the BGP_INFO_REMOVED set, and, if so, we need to call
478 bgp_info_restore to resurrect it.
479
Paul Jakma56395af2006-10-27 16:58:20 +00004802006-10-27 Paul Jakma <paul.jakma@sun.com>
481
482 * bgp_route.c: (bgp_table_stats) oops, u_intXX_t should be
483 uintXX_t
484
Paul Jakma6f585442006-10-22 19:13:07 +00004852006-10-19 Paul Jakma <paul.jakma@sun.com>
486
487 * bgpd.c: (peer_new) bgp element of peer absolutely must be
488 filled in, make peer_new() require it as argument and update
489 all callers. Fixes a crash reported by Jan 'yanek' Bortl and
490 Andrew Schorr where bgpd would crash in bgp_pcount_adjust
491 trying to dereference the bgp member of bgp->peer_self,
492 triggered through redistribution.
493 * bgp_route.c: (bgp_pcount_adjust) assert sanity of arguments.
494
Paul Jakma53d9f672006-10-15 23:41:16 +00004952006-10-15 Paul Jakma <paul.jakma@sun.com>
496
497 * bgp_route.c: (bgp_table_stats_walker) NULL deref if table is
498 empty, bgp_table_top may return NULL, Coverity CID#73.
Paul Jakmaed3ebfa2006-10-15 23:50:16 +0000499 * bgp_packet.c: (bgp_update_packet) adv->rn can not be NULL,
500 check is bogus - changed to assert(), CID#64.
501 binfo is checked for NULL, but then dereferenced
502 unconditionally, fix, CID #63.
503 (bgp_withdraw_packet) Assert adv->rn is valid, as with
504 bgp_update_packet().
Paul Jakma53d9f672006-10-15 23:41:16 +0000505
Paul Jakmadcdf3992006-10-15 23:39:59 +00005062006-10-14 Paul Jakma <paul.jakma@sun.com>
507
508 * bgp_fsm.h: Remove BGP_EVENT_FLUSH_ADD, dangerous and not
509 needed.
510 * bgp_fsm.c: (bgp_stop) Move BGP_EVENT_FLUSH to the top of the
511 of the function, otherwise it could flush a ClearingCompleted
512 event, bug #302.
513 * bgp_packet.c: Replace all BGP_EVENT_FLUSH_ADD with
514 BGP_EVENT_ADD, fixing bug #302.
515
Andrew J. Schorr0cd1c322006-09-19 18:51:53 +00005162006-09-19 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
517
518 * bgpd.c: (peer_uptime) Fix printf format/arg mismatch in
519 zlog_warn message (%ld/size_t -> %lu/u_long).
520
Paul Jakmaca058a32006-09-14 02:58:49 +00005212006-09-14 Paul Jakma <paul.jakma@sun.com>
522
Paul Jakma8383a9b2006-09-14 03:06:54 +0000523 * bgp_route.c: (bgp_table_stats_walker) Address space announced
524 should only count top-level unaggregateable prefixes, to
525 avoid falling afoul of anti-dodgy-accounting regulations
526 in various jurisdictions.. ;)
Paul Jakma09dd5612006-09-14 03:38:16 +0000527 (bgp_process_queue_init) process queue hold time too high,
528 adds extra memory load. Change to be much lower, until such
529 time as it's made configurable.
Paul Jakma8383a9b2006-09-14 03:06:54 +0000530
5312006-09-14 Paul Jakma <paul.jakma@sun.com>
532
Paul Jakma9fde6622006-09-14 03:02:02 +0000533 * (general) fix the peer refcount issue exposed by previous, by
534 just removing refcounting of peer threads, which is mostly
535 senseless as they're references leading from struct peer,
536 which peer_free cancels anyway. No need to muck around..
537 * bgp_fsm.h: Just remove the refcounting from the various
538 TIMER/READ/WRITE/EVENT ON/OFF/ADD macros.
539 * bgp_fsm.c: (bgp_stop) use BGP_EVENT_FLUSH, no refcounts attached
540 to events anymore.
541 (bgp_event) remove peer_unlock, events not refcounted.
542 * bgpd.c: (peer_free) flush events before free.
543
5442006-09-14 Paul Jakma <paul.jakma@sun.com>
545
Paul Jakmaca058a32006-09-14 02:58:49 +0000546 * (general) Fix some niggly issues around 'shutdown' and clearing
547 by adding a Clearing FSM wait-state and a hidden 'Deleted'
548 FSM state, to allow deleted peers to 'cool off' and hit 0
549 references. This introduces a slow memory leak of struct peer,
550 however that's more a testament to the fragility of the
551 reference counting than a bug in this patch, cleanup of
552 reference counting to fix this is to follow.
553 * bgpd.h: Add Clearing, Deleted states and Clearing_Completed
554 and event.
555 * bgp_debug.c: (bgp_status_msg[]) Add strings for Clearing and
556 Deleted.
557 * bgp_fsm.h: Don't allow timer/event threads to set anything
558 for Deleted peers.
559 * bgp_fsm.c: (bgp_timer_set) Add Clearing and Deleted. Deleted
560 needs to stop everything.
561 (bgp_stop) Remove explicit fsm_change_status call, the
562 general framework handles the transition.
563 (bgp_start) Log a warning if a start is attempted on a peer
564 that should stay down, trying to start a peer.
565 (struct .. FSM) Add Clearing_Completed
566 events, has little influence except when in state
567 Clearing to signal wait-state can end.
568 Add Clearing and Deleted states, former is a wait-state,
569 latter is a placeholder state to allow peers to disappear
570 quietly once refcounts settle.
571 (bgp_event) Try reduce verbosity of FSM state-change debug,
572 changes to same state are not interesting (Established->Established)
573 Allow NULL action functions in FSM.
574 * bgp_packet.c: (bgp_write) Use FSM events, rather than trying
575 to twiddle directly with FSM state behind the back of FSM.
576 (bgp_write_notify) ditto.
577 (bgp_read) Remove the vague ACCEPT_PEER peer_unlock, or else
578 this patch crashes, now it leaks instead.
579 * bgp_route.c: (bgp_clear_node_complete) Clearing_Completed
580 event, to end clearing.
581 (bgp_clear_route) See extensive comments.
582 * bgpd.c: (peer_free) should only be called while in Deleted,
583 peer refcounting controls when peer_free is called.
584 bgp_sync_delete should be here, not in peer_delete.
585 (peer_delete) Initiate delete.
586 Transition to Deleted state manually.
587 When removing peer from indices that provide visibility of it,
588 take great care to be idempotent wrt the reference counting
589 of struct peer through those indices.
590 Use bgp_timer_set, rather than replicating.
591 Call to bgp_sync_delete isn't appropriate here, sync can be
592 referenced while shutting down and finishing deletion.
593 (peer_group_bind) Take care to be idempotent wrt list references
594 indexing peers.
595
Paul Jakma2815e612006-09-14 02:56:07 +00005962006-09-13 Paul Jakma <paul.jakma@sun.com>
597
598 * bgp_aspath.c: (aspath_highest) new, return highest ASN in an
599 aspath.
600 * bgp_route.c: (bgp_peer_count_walker) new, do the walk done
601 in bgp_peer_counts as a thread.
602 (bgp_peer_counts) move walk to previous and call it via
603 thread_execute so this RIB walk shows up in thread stats.
604 (bgp_table_stats) New, gather some statistics for a given
605 RIB.
606 (bgp_table_stats_walker) New, RIB walker thread for former.
607 (bgp_table_stats_vty) Parsing front-end for 'show bgp ...',
608 useful model for future rationalisation of 'show ... bgp'.
609 (bgp_route_init) Add new RIB stats commands.
610
Paul Jakma1a392d42006-09-07 00:24:49 +00006112006-09-06 Paul Jakma <paul.jakma@sun.com>
612
613 * (general) Squash any and all prefix-count issues by
614 abstracting route flag changes, and maintaining count as and
615 when flags are modified (rather than relying on explicit
616 modifications of count being sprinkled in just the right
617 places throughout the code).
618 * bgp_route.c: (bgp_pcount_{dec,inc}rement) removed.
619 (bgp_pcount_adjust) new, update prefix count as
620 needed for a given route.
621 (bgp_info_{uns,s}et_flag) set/unset a BGP_INFO route status
622 flag, calling previous function when appropriate.
623 (general) Update all set/unsets of flags to use previous.
624 Remove pcount_{dec,inc}rement calls.
625 No need to unset BGP_INFO_VALID in places where
626 bgp_info_delete is called, it does that anyway.
627 * bgp_{damp,nexthop}.c: Update to use bgp_info_{un,}set_flag.
628 * bgp_route.h: Export bgp_info_{un,}set_flag.
629 Add a 'meta' BGP_INFO flag, BGP_INFO_UNUSEABLE.
630 Move BGP_INFO_HOLDDOWN macro to here from bgpd.h
631
Paul Jakmaff7924f2006-09-04 01:10:36 +00006322006-09-03 Paul Jakma <paul.jakma@sun.com>
633
634 * bgp_route.c: Add 'show ... bgp ... <neighbour> prefix-count'
635 commands, to provide detailed counts of prefixes for a peer.
636 Informative, and should help pin down to pfxcnt drift
637 problems.
638
Paul Jakma9f906c72006-08-27 06:57:47 +00006392006-08-27 Paul Jakma <paul.jakma@sun.com>
640
641 * bgp_advertise.c: (bgp_sync_delete) fix mtype in XFREE.
642 NULL out peer->hash after free, to be sure.
643
Paul Jakma1f742f22006-08-06 15:52:11 +00006442006-08-06 Paul Jakma <paul.jakma@sun.com>
645
646 * bgp_aspath.c: (aspath_loop_check) Fix the typo-bug which
647 essentially had disabled this check. Problem reported by
648 Bartek Kania <mrbk@gnarf.org> in [quagga-users 7388].
649
Paul Jakma18937402006-07-27 19:05:12 +00006502006-07-27 Paul Jakma <paul.jakma@sun.com>
651
652 * bgpd.c: (peer_delete) Ensure freed buffers can not be
653 accidently reused. A potential fix for bug #287.
654
Paul Jakma33d5ab92006-07-02 11:01:50 +00006552006-07-02 Paul Jakma <paul.jakma@sun.com>
656
657 * bgp_fsm.c: (bgp_{stop,start}) Move clear/free of certain
658 bits of state from stop to start, as they may be used via
659 peer references on clearing queues..
660
Paul Jakma369688c2006-05-23 22:27:55 +00006612006-05-23 Paul Jakma <paul.jakma@sun.com>
662
663 * bgp_vty.c: (neighbor_update_source_cmd) Expand tab completion
664 to make it clear it takes both address and ifname.
665
Paul Jakma34c3f812006-05-12 23:25:37 +00006662006-05-12 Paul Jakma <paul.jakma@sun.com>
667
668 * bgp_attr.c: (bgp_packet_attribute) Remove dead code, Coverity
669 CID #1
Paul Jakmab2518c12006-05-12 23:48:40 +0000670 * bgp_aspath.{c,h}: (aspath_print_vty) take a format string,
671 so as to reduce burden on callers, all in bgp_route.c
Paul Jakmadd8103a2006-05-12 23:27:30 +0000672 * bgp_route.c: (bgp_static_update_main) Remove useless NULL
673 check, code already assumes bgp_static can not be NULL,
674 fixes CID #7.
Paul Jakma06e110f2006-05-12 23:29:22 +0000675 (bgp_static_update_rsclient) ditto, CID #6
Paul Jakmab2518c12006-05-12 23:48:40 +0000676 (route_vty_out{,tmp}) Update to match aspath_print_vty,
677 simplifying checks needed to get spacing right. CID #4,#5.
678 ({damp,flap}_route_vty_out) Ditto, CID #9, #10
Paul Jakma34c3f812006-05-12 23:25:37 +0000679
Paul Jakma542bcb72006-05-08 14:25:09 +00006802006-05-08 Paul Jakma <paul.jakma@sun.com>
681
682 * bgp_community.c: (community_str2com) Coverity CID#62, fix
683 double-free, use-after-free.
Paul Jakmada5b30f2006-05-08 14:37:17 +0000684 * bgp_route.c: (bgp_afi_node_get) given table should never be
685 NULL, check/assert this.
686 (bgp_static_update) Bug #240. Rsclients should only be passed
687 the static update if they are configured for the afi,safi.
Paul Jakma542bcb72006-05-08 14:25:09 +0000688
Paul Jakmaa3b6ea52006-05-04 07:52:12 +00006892006-05-04 Paul Jakma <paul.jakma@sun.com>
690
691 * (general) VPNv4 fixes. Certain VPNv4 code was not enabled.
692 See bug #210.
693 * bgp_attr.{c,h}: (bgp_packet_{withdraw,attribute}) Tag should be
694 u_char really.
695 * bgp_packet.c: (bgp_{update,withdraw}_packet) Enable some
696 VPNv4 code which inexplicably was ifdef'd out. comments from
697 a tester on IRC suggest this fixes bug #210.
Paul Jakma65ca75e2006-05-04 08:08:15 +0000698 * bgp_route.c: (general) Fix logical bug in clearing, noted
699 by Chris Caputo in [quagga-users 6728] - clearing depended on
700 at least one route being added to workqueue, in order for
701 workqueue completion function to restart FSM. However, if no
702 routes are cleared, then the completion function never is
703 called, it needs to be called manually if the workqueue
704 didn't get scheduled.
705 Finally, clearing is per-peer-session, not per AFI/SAFI, so
706 the FSM synchronisation should be in bgp_clear_route_table.
707 (bgp_clear_route_table) Wrong place for FSM/clearing
708 synchronisation, move to..
709 (bgp_clear_route) FSM/clearing synchronisation should be
710 here.
711 If no routes were cleared, no workqueue scheduled, call
712 the completion func to ensure FSM kicks off again.
Paul Jakmaa3b6ea52006-05-04 07:52:12 +0000713
Paul Jakma15aa6a12006-03-30 14:39:35 +00007142006-03-30 Paul Jakma <paul.jakma@sun.com>
715
716 * bgp_community.c: (community_gettoken) Unknown token should
717 return NULL, to give a strong indication to callers that
718 the token no longer can be parsed, otherwise callers looping
719 on this function may have a hard time ending their loop.
720 (community_str2com) While loop around community_gettoken appears
721 to have been coded thinking that break statement would break
722 from the while{}, hence it could never exit for unknown token
723 case. Fix it to do..while, so it can use the NULL result from
724 community_gettoken easily.
725
Paul Jakmaa625ca32006-03-30 14:12:38 +00007262006-03-22 Paul Jakma <paul.jakma@sun.com>
727
728 * bgpd.c: (peer_free) release the per-peer workqueue when
729 freeing the peer.
730
Paul Jakma5304cb52006-03-30 14:01:14 +00007312006-03-19 Paul Jakma <paul.jakma@sun.com>
732
Paul Jakma4bf6a362006-03-30 14:05:23 +0000733 * bgpd/bgp_vty.c: Add includes to get several structs we want
734 to provide usage statistics on.
735 (show_bgp_memory_cmd) Show memory usage stats for various
736 notable fixed size objects. Using mtype_stats_alloc and
737 mtype_memstr recently added to memory.c.
738 (bgp_show_summary) Report some additional stats specific to
739 the given BGP instance and/or AFI/SAFI such as table counts,
740 peers, rsclients and peer-groups.
741 (bgp_vty_init) Install show_bgp_memory_cmd.
Paul Jakma5304cb52006-03-30 14:01:14 +0000742 * bgp_nexthop.h: Include if.h as a dependent header, for struct
743 connected.
Paul Jakmab51f1262006-03-30 14:09:38 +0000744 * bgp_advertise.c: Use a distinct memory type for struct
745 bgp_synchronize.
Paul Jakma5304cb52006-03-30 14:01:14 +0000746
Paul Jakmacbdfbaa2006-03-30 13:20:48 +00007472006-03-12 Paul Jakma <paul.jakma@sun.com>
748
749 * bgp_attr.h: (struct attr) rearrange fields to avoid
750 wasted padding between them as much as possible.
751 (attr_count,attr_unknown_count) export new functions to
752 return number of counts of cached attributes.
753 * bgp_attr.c: (attr_count,attr_unknown_count) new functions to
754 return number of counts of cached attributes.
755 * bgp_route.h: (struct bgp_info) rearrange fields to avoid
756 wasted padding.
757 * bgp_table.h: (struct bgp_table) Add a count field, of number
758 of nodes in the table.
759 (struct bgp_node) rearrange fields to avoid
760 wasted padding between them, though I don't think there
761 was any in this case.
762 * bgp_table.c: (bgp_node_{delete,get}) Maintain the table node count.
763 (bgp_table_count) new function to access the table count.
764
Paul Jakma3e0c78e2006-03-06 18:06:53 +00007652006-03-03 Paul Jakma <paul.jakma@sun.com>
766
767 * bgp_route.c: (bgp_clear_node_complete) Doh. When clearing
768 is complete we need to kick off FSM again.
769
Paul Jakma64e580a2006-02-21 01:09:01 +00007702006-02-21 Paul Jakma <paul.jakma@sun.com>
771
772 * bgpd.h: move the clear_node_queue to be peer specific.
773 Add a new peer status flag, PEER_STATUS_CLEARING.
774 * bgp_table.h: (struct bgp_table) Add fields to record afi,
775 safi of the table.
776 (bgp_table_init) Take afi and safi to create table for.
777 * bgp_table.c: (bgp_table_init) record the afi and safi.
778 * bgp_nexthop.c: Update all calls to bgp_table_init.
779 * bgp_vty.c: ditto.
780 * bgpd.c: ditto.
781 * bgp_fsm.c: (bgp_timer_set) dont bring up a session which is
782 clearing.
783 * bgp_route.c: (general) Update all bgp_table_init calls.
784 (bgp_process_{rsclient,main}) clear_node is serialised
785 via PEER_STATUS_CLEARING and fsm now.
786 (struct bgp_clear_node_queue) can be removed. struct bgp_node
787 can be the queue item data directly, as struct peer can be
788 kept in the new wq global user data and afi/safi can be
789 retrieved via bgp_node -> bgp_table.
790 (bgp_clear_route_node) fix to get peer via wq->spec.data,
791 afi/safi via bgp_node->bgp_table.
792 (bgp_clear_node_queue_del) no more item data to delete, only
793 unlock the bgp_node.
794 (bgp_clear_node_complete) only need to unset CLEARING flag
795 and unlock struct peer.
796 (bgp_clear_node_queue_init) queue attaches to struct peer
797 now. record peer name as queue name.
798 (bgp_clear_route_table) If queue transitions to active,
799 serialise clearing by setting PEER_STATUS_CLEARING rather
800 than plugging process queue, and lock peer while queue
801 active.
802 Update to pass only bgp_node as per-queue-item specific data.
Paul Jakma6a419732006-02-21 01:14:13 +0000803 * bgp_vty.c: (bgp_show_summary) Add a 'Clrng' sub-description
804 to state of peer while it's suppressed due to clearing.
Paul Jakma64e580a2006-02-21 01:09:01 +0000805
Paul Jakmaaa94ca82006-02-18 10:49:04 +00008062006-02-18 Paul Jakma <paul.jakma@sun.com>
807
808 * bgp_routemap.c: (route_set_community) Quick, very hacky, fix
809 for the set-community leak, bug #89. True fix will be to
810 detangle the web of *_intern caching and provide saner object
811 caching for Quagga, future work.
Paul Jakma7c7fa1b2006-02-18 10:52:09 +0000812 * bgp_route.c: (bgp_announce_check) trivial, move declaration
813 of two local variables into the only block where they are
814 used, to aid the reader.
Paul Jakmaaa94ca82006-02-18 10:49:04 +0000815
paul902212c2006-02-05 17:51:19 +00008162006-02-05 Paul Jakma <paul.jakma@sun.com>
817
818 * bgp_route.h: Add BGP_INFO_COUNTED to track whether
819 prefix has been counted or not.
820 * bgp_route.c: (bgp_pcount_{inc,dec}rement) new helpers, to
821 centralise inc/dec of prefix-count,
822 (bgp_rib_remove) Remove pcount decrement, use helper.
823 (bgp_rib_withdraw) ditto, additionally use previous function
824 too.
825 (bgp_update_main) Use pcount helpers.
826 (bgp_clear_route_node) ditto, aslo REMOVED routes don't need
827 clearing.
paul3fff6ff2006-02-05 17:55:35 +0000828 * bgp_aspath.c: (aspath_gettoken) fix gcc warning about
829 possible uninitialised usage.
paul902212c2006-02-05 17:51:19 +0000830
paul306d8892006-02-02 17:50:19 +00008312006-02-02 Paul Jakma <paul.jakma@sun.com>
832
833 * bgp_route.c: (bgp_{clear_node,process}_queue_init) delay
834 field is removed from workqueue spec.
835
paule8e19462006-01-19 20:16:55 +00008362006-01-19 Paul Jakma <paul.jakma@sun.com>
837
838 * (general) various miscellaneous compiler warning fixes.
839 Remove redundant break statements from switch clauses
840 which return.
841 return from main, not exit, cause it annoys SOS.
842 Remove stray semi-colons which cause empty-statement
843 warnings.
844
pauld3092e72006-01-17 17:33:46 +00008452006-01-17 Paul Jakma <paul.jakma@sun.com>
846
847 * bgp_nexthop.c: (zlookup_read*) convert to new Zserv format.
848 (zlookup_query_ipv6) ditto.
849 (bgp_import_check) ditto.
850
paul02335422006-01-16 11:13:27 +00008512006-01-16 Paul Jakma <paul.jakma@sun.com>
852
853 * bgp_aspath.c: (assegment_append_asns) XREALLOC can return
854 NULL theoretically, take care not to lose the allocated data.
855 (aspath_hash_alloc) aspath_dup already set the aspath
856 string - fix leak.
857 (aspath_parse) aspath_hash_alloc dupes the entire aspath,
858 including segments, but we forgot to free the temporary
859 assegment.
paul8fdc32a2006-01-16 12:01:29 +0000860 (aspath_snmp_pathseg) move the static stream pointer out to
861 file scope, so it can be freed.
862 (aspath_finish) new function, free aspath resources.
863 * bgp_aspath.h: (aspath_finish) export.
paul02335422006-01-16 11:13:27 +0000864
paul37c38302006-01-10 22:15:45 +00008652006-01-10 Juris Kalnins <juris@mt.lv>
866
867 * bgpd.h: (bgp_router_id_unset) ex-function, remove.
868
paulad727402005-11-23 02:47:02 +00008692005-11-23 Paul Jakma <paul.jakma@sun.com>
870
871 * bgp_aspath.c: (assegments_parse) should be static
872
8732005-11-23 Juergen Kammer <j.kammer@eurodata.de>
874
875 * bgp_aspath.c: (aspath_cmp_left_confed) fix SEGV for case
876 where one or both paths are empty.
877
paul0fb58d52005-11-14 14:31:49 +00008782005-11-14 Paul Jakma <paul.jakma@sun.com>
879
880 * bgp_route.c: (bgp_process_rsclient) convert to new workqueue
881 specs and shut up gcc, which complains about cast from void
882 via function parameters, for some dumb reason. Do the cast
883 inside the function instead.
884 (bgp_process_main,bgp_processq_del) ditto.
885 (bgp_clear_route_node) ditto.
886 (bgp_clear_node_queue_del) ditto.
887
paul41200852005-11-03 12:52:18 +00008882005-11-03 Paul Jakma <paul.jakma@sun.com>
889
890 * bgp_damp.c: (bgp_reuse_timer) struct bgp can be retrieved via
891 the struct bgp_damp_info, no need to guess by using
892 bgp_get_default().
893
ajsf52d13c2005-10-01 17:38:06 +00008942005-10-01 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
895
896 * bgp_vty.c: (bgp_config_write_redistribute) Use new library function
897 zebra_route_string instead of a local hard-coded table.
898
jardin2d74db52005-10-01 00:07:50 +00008992005-09-30 Vincent Jardin <vincent.jardin@6wind.com>
900
901 * bgp_packet.c: fix compilation when DEBUG is used.
902
paul1f8ae702005-09-09 23:49:49 +00009032005-09-10 Paul Jakma <paul.jakma@sun.com>
904
paulfe69a502005-09-10 16:55:02 +0000905 * Makefile.am: bgpd shouldn't list libgp's sources as its own.
906 Use LDADD.
907 * bgp_aspath.h:
908 (struct assegment) New struct, abstract representation of a
909 list of AS_PATH segments and the contained ASNs.
910 (struct aspath) Remove the raw-data related
911 fields, reference the abstract struct assegment instead.
912 Remove several other computed fields, it's just a
913 headache to maintain them and they're cheap to compute from
914 struct assegment.
915 (aspath_parse) parse a stream, not a pointer to raw data.
916 (aspath_count_{hops,confeds,size}) helpers to access
917 information formerly directly contained in struct aspath.
918 (aspath_snmp_pathseg) Helper for SNMP, BGP MIB wants
919 to be able to output hex representation of raw data.
920 * bgp_aspath.c: (general) partial-rewrite. Store aspath data
921 as an abstract singly-linked list of abstract segments,
922 rather than storing the raw data, and parsing it each and
923 every time. Remove several count/size fields which are cheap
924 to compute from the abstract segment structure.
925 (global) Include stream.h, needed for aspath_parse, and
926 others. Couple of helper macros added.
927 (struct assegment_header) Just the header, and only the
928 header.
929 (assegment_data_{new,free}) convenience functions for
930 AS_SEG_DATA allocation, the dynamic, per-segment array of
931 ASNs.
932 (assegment_{new,free,free_all,dup,dup_all}) convenience
933 functions for creating struct assegments. The _all forms will
934 follow the entire chain of segments from the given segment.
935 (assegment_prepend_asns) new function, prepend an ASN N times
936 to segment.
937 (assegment_append_asns) Append a list (array) of ASNs to
938 segment.
939 (int_cmp) convenience function for the aspath hash.
940 (assegment_normalise) new function. Normalise the given
941 segment chain to meet expectations of Quagga, and to
942 eliminate differing raw representations of the same paths.
943 Merge 'runs' of SEQUENCEs into one segment as our internal
944 segment is not limited by the protocol AS_PATH segment
945 length. Sort ASNs in SETs.
946 (aspath_new) Take void argument to quell warnings. Use the
947 assegment convenience functions.
948 (assegment_count_{asns,confeds,hops}) new functions to
949 compute at runtime values previously held in struct aspath.
950 (aspath_size) ditto.
951 (aspath_make_str_count) rewritten to stringify new
952 representation, and to be slightly easier to understand
953 hopefully.
954 (aspath_str_update) convenience function, update the aspath
955 str. Should investigate removing maintained string from
956 struct aspath, just run-time compute it, as per other fields.
957 It's just a maintenance headache, would save noticeable
958 amount of RAM with possibly not much extra run-time cost.
959 (aspath_dup) use the assegment dup functions.
960 (aspath_hash_alloc) Take void * argument to satisfy gcc. Use
961 the proper helper functions to dup data.
962 (assegments_parse) new function. parse raw AS_PATH data into
963 struct assegments. Normalise and return the head of the list.
964 (aspath_parse) Parse a stream, not pointer to raw data and
965 use assegments_parse to do it.
966 (assegment_data_put) Write out a single segment data in protocol
967 form to stream.
968 (assegment_header_put) ditto but for segment header.
969 (aspath_put) new function. As per previous but for an entire
970 struct aspath.
971 (aspath_snmp_pathseg) wrapper around aspath_put for
972 bgp_snmp.c. Uses a static buffer sadly.
973 (aspath_aggregate_as_set_add) rewritten to use assegments.
974 (aspath_aggregate) ditto
975 (aspath_{firstas,loop,private_as}_check) ditto
976 (aspath_{merge,prepend,add_one_as}) ditto
977 (aspath_cmp_left{_confed}) ditto
978 (aspath_delete_confed_seq) ditto, plus fixed to properly
979 delete all leading confed segments.
980 (aspath_as_add) Just use assegment_append_asns.
981 (aspath_segment_add) updated to use assegments.
982 (enum as_token) Add values for confeds
983 (aspath_gettoken) Add support for confeds
984 (aspath_str2aspath) ditto
985 (aspath_key_make) updated to use as_segments. Also, add
986 segment type into the hash value as appropriate.
987 (aspath_cmp) updated to use as_segments.
988 (aspath_print) don't segfault on NULL argument.
989 * bgp_attr.c: (bgp_attr_aspath) aspath_parse wants the stream
990 now. No need for manual forwarding of stream.
991 (bgp_packet_attribute) empty aspath is now denoted by NULL
992 segment field, length is gone.
993 Use aspath_size() to determine size.
994 (bgp_attr_init) Fix declaration, explicitely specify void
995 arg.
996 (bgp_dump_routes_attr) Use aspath_size() to determine size.
997 * bgp_route.c: (bgp_info_cmp) use the aspath_count_* functions.
998 (bgp_rib_withdraw) remove unused variable. Use
999 aspath_count_hops.
1000 * bgp_snmp.c: (bgp4PathAttrTable) raw data is gone, use
1001 aspath_snmp_pathseg to get the representation.
1002
10032005-09-10 Paul Jakma <paul.jakma@sun.com>
1004
paul1f8ae702005-09-09 23:49:49 +00001005 * bgp_vty.c: (bgp_vty_init) gcc 4 compile fix. static
1006 function declarations shouldn't be inside functions.
1007 * bgp_dump.c: (bgp_dump_interval_add) ditto.
1008
hassob7395792005-08-26 12:58:38 +000010092005-08-26 Hasso Tepper <hasso at quagga.net>
1010
1011 * bgp_route.c: Third (?) attempt to fix best selection breakage
1012 introduced long time ago with route server patch. Hopefully
1013 it's last case to fix - route-server client not in peer group.
1014
paul25ffbdc2005-08-22 22:42:08 +000010152005-08-22 Hugo Santos <hsantos@av.it.pt>
1016
1017 * bgp_vty.c: (general) Add support for BGP IPv6 Multicast SAFI
1018 commands and BGP_IPV6M_NODE.
1019
paulb40d9392005-08-22 22:34:41 +000010202005-08-22 Paul Jakma <paul.jakma@sun.com>
1021
1022 * bgp_route.h: (struct bgp_info) add a new flag, BGP_INFO_REMOVED.
1023 BGP_INFO_VALID is already overloaded, don't care to do same thing
1024 to STALE or HISTORY.
1025 * bgpd.h: (BGP_INFO_HOLDDOWN) Add INFO_REMOVED to the macro, as a
1026 route which should generally be ignored.
1027 * bgp_route.c: (bgp_info_delete) Just set the REMOVE flag, rather
1028 than doing actual work, so that bgp_process (called directly,
1029 or indirectly via the scanner) can catch withdrawn routes.
1030 (bgp_info_reap) Actually remove the route, what bgp_info_delete
1031 used to do, only for use by bgp_process.
1032 (bgp_best_selection) reap any REMOVED routes, other than the old
1033 selected route.
1034 (bgp_process_rsclient) reap the old-selected route, if appropriate
1035 (bgp_process_main) ditto
1036 (bgp_rib_withdraw, bgp_rib_remove) make them more consistent with
1037 each other. Don't play games with the VALID flag, bgp_process
1038 is async now, so it didn't make a difference anyway.
1039 Remove the 'force' argument from bgp_rib_withdraw, withdraw+force
1040 is equivalent to bgp_rib_remove. Update all its callers.
1041 (bgp_update_rsclient) bgp_rib_withdraw and force set is same as
1042 bgp_rib_remove.
1043 (route_vty_short_status_out) new helper to print the leading
1044 route-status string used in many command outputs. Consolidate.
1045 (route_vty_out, route_vty_out_tag, damp_route_vty_out,
1046 flap_route_vty_out) use route_vty_short_status_out rather than
1047 duplicate.
1048 (route_vty_out_detail) print state of REMOVED flag.
1049 (BGP_SHOW_SCODE_HEADER) update for Removed flag.
1050
hassoe279c7a2005-08-03 17:23:20 +000010512005-08-03 Hasso Tepper <hasso at quagga.net>
1052
1053 * bgp_routemap.c: Revert part of leaking communities fix commited in
1054 2005-05-27. While ecommunity fix seems to be correct, community case
1055 isn't.
1056
paul94f2b392005-06-28 12:44:16 +000010572005-06-28 Paul Jakma <paul.jakma@sun.com>
1058
1059 * (global) The great bgpd extern and static'ification.
1060 * bgp_routemap.c: remove unused ROUTE_MATCH_ASPATH_OLD code
1061 (route_set_metric_compile) fix u_int32_t to ULONG_MAX comparison
1062 warnings.
1063 * bgp_route.h: (bgp_process, bgp_withdraw, bgp_update) export these
1064 used by various files which had their own private declarations,
1065 in the case of mplsvpn - incorrect.
1066
paule210cf92005-06-15 19:15:35 +000010672005-06-15 Paul Jakma <paul.jakma@sun.com>
1068
1069 * bgpd.c: (bgp_terminate) workqueue's are lazy allocated and its
1070 possible to terminate bgpd before workqueues were setup, causing
1071 an abort/crash. Reported by Ashish Mehta of Sun.
1072
paul200df112005-06-01 11:17:05 +000010732005-06-01 Paul Jakma <paul.jakma@sun.com>
1074
1075 * (general) refcount struct peer and bgp_info, hence allowing us
1076 add work_queues for bgp_process.
1077 * bgp_route.h: (struct bgp_info) Add 'lock' field for refcount.
1078 Add bgp_info_{lock,unlock} helper functions.
1079 Add bgp_info_{add,delete} helpers, to remove need for
1080 users managing locking/freeing of bgp_info and bgp_node's.
1081 * bgp_table.h: (struct bgp_node) Add a flags field, and
1082 BGP_NODE_PROCESS_SCHEDULED to merge redundant processing of
1083 nodes.
1084 * bgp_fsm.h: Make the ON/OFF/ADD/REMOVE macros lock and unlock
1085 peer reference as appropriate.
1086 * bgp_damp.c: Remove its internal prototypes for
1087 bgp_info_delete/free. Just use bgp_info_delete.
1088 * bgpd.h: (struct bgp_master) Add work_queue pointers.
1089 (struct peer) Add reference count 'lock'
1090 (peer_lock,peer_unlock) New helpers to take/release reference
1091 on struct peer.
1092 * bgp_advertise.c: (general) Add peer and bgp_info refcounting
1093 and balance how references are taken and released.
1094 (bgp_advertise_free) release bgp_info reference, if appropriate
1095 (bgp_adj_out_free) unlock peer
1096 (bgp_advertise_clean) leave the adv references alone, or else
1097 call bgp_advertise_free cant unlock them.
1098 (bgp_adj_out_set) lock the peer on new adj's, leave the reference
1099 alone otherwise. lock the new bgp_info reference.
1100 (bgp_adj_in_set) lock the peer reference
1101 (bgp_adj_in_remove) and unlock it here
1102 (bgp_sync_delete) make hash_free on peer conditional, just in
1103 case.
1104 * bgp_fsm.c: (general) document that the timers depend on
1105 bgp_event to release a peer reference.
1106 (bgp_fsm_change_status) moved up the file, unchanged.
1107 (bgp_stop) Decrement peer lock as many times as cancel_event
1108 canceled - shouldnt be needed but just in case.
1109 stream_fifo_clean of obuf made conditional, just in case.
1110 (bgp_event) always unlock the peer, regardless of return value
1111 of bgp_fsm_change_status.
1112 * bgp_packet.c: (general) change several bgp_stop's to BGP_EVENT's.
1113 (bgp_read) Add a mysterious extra peer_unlock for ACCEPT_PEERs
1114 along with a comment on it.
1115 * bgp_route.c: (general) Add refcounting of bgp_info, cleanup
1116 some of the resource management around bgp_info. Refcount peer.
1117 Add workqueues for bgp_process and clear_table.
1118 (bgp_info_new) make static
1119 (bgp_info_free) Ditto, and unlock the peer reference.
1120 (bgp_info_lock,bgp_info_unlock) new exported functions
1121 (bgp_info_add) Add a bgp_info to a bgp_node in correct fashion,
1122 taking care of reference counts.
1123 (bgp_info_delete) do the opposite of bgp_info_add.
1124 (bgp_process_rsclient) Converted into a work_queue work function.
1125 (bgp_process_main) ditto.
1126 (bgp_processq_del) process work queue item deconstructor
1127 (bgp_process_queue_init) process work queue init
1128 (bgp_process) call init function if required, set up queue item
1129 and add to queue, rather than calling process functions directly.
1130 (bgp_rib_remove) let bgp_info_delete manage bgp_info refcounts
1131 (bgp_rib_withdraw) ditto
1132 (bgp_update_rsclient) let bgp_info_add manage refcounts
1133 (bgp_update_main) ditto
1134 (bgp_clear_route_node) clear_node_queue work function, does
1135 per-node aspects of what bgp_clear_route_table did previously
1136 (bgp_clear_node_queue_del) clear_node_queue item delete function
1137 (bgp_clear_node_complete) clear_node_queue completion function,
1138 it unplugs the process queues, which have to be blocked while
1139 clear_node_queue is being processed to prevent a race.
1140 (bgp_clear_node_queue_init) init function for clear_node_queue
1141 work queues
1142 (bgp_clear_route_table) Sets up items onto a workqueue now, rather
1143 than clearing each node directly. Plugs both process queues to
1144 avoid potential race.
1145 (bgp_static_withdraw_rsclient) let bgp_info_{add,delete} manage
1146 bgp_info refcounts.
1147 (bgp_static_update_rsclient) ditto
1148 (bgp_static_update_main) ditto
1149 (bgp_static_update_vpnv4) ditto, remove unneeded cast.
1150 (bgp_static_withdraw) see bgp_static_withdraw_rsclient
1151 (bgp_static_withdraw_vpnv4) ditto
1152 (bgp_aggregate_{route,add,delete}) ditto
1153 (bgp_redistribute_{add,delete,withdraw}) ditto
1154 * bgp_vty.c: (peer_rsclient_set_vty) lock rsclient list peer
1155 reference
1156 (peer_rsclient_unset_vty) ditto, but unlock same reference
1157 * bgpd.c: (peer_free) handle frees of info to be kept for lifetime
1158 of struct peer.
1159 (peer_lock,peer_unlock) peer refcount helpers
1160 (peer_new) add initial refcounts
1161 (peer_create,peer_create_accept) lock peer as appropriate
1162 (peer_delete) unlock as appropriate, move out some free's to
1163 peer_free.
1164 (peer_group_bind,peer_group_unbind) peer refcounting as
1165 appropriate.
1166 (bgp_create) check CALLOC return value.
1167 (bgp_terminate) free workqueues too.
1168
hasso033e8612005-05-28 04:50:54 +000011692005-05-28 Hasso Tepper <hasso at quagga.net>
1170
1171 * bgp_routemap.c: Sync set_metric_addsub_cmd with ripd.
1172
hasso54a6ed32005-05-26 22:12:33 +000011732005-05-27 Hasso Tepper <hasso at quagga.net>
1174
hasso70601e02005-05-27 03:26:57 +00001175 * bgp_routemap.c: Stop leaking communities.
1176
11772005-05-27 Hasso Tepper <hasso at quagga.net>
1178
hasso54a6ed32005-05-26 22:12:33 +00001179 * bgpd.c: Deleting bgp->rsclient list needs fix similar to pree-groups
1180 deleting fix. Avoid leaking bgp->group, bgp->peer and bgp->rsclient
1181 lists.
1182
11832005-05-26 Hasso Tepper <hasso at quagga.net>
hassob6b7cff2005-05-26 08:29:07 +00001184
1185 * bgpd.c: Don't crash while deleting list of peer-groups.
1186
hassob5f29602005-05-25 21:00:28 +000011872005-05-25 Hasso Tepper <hasso at quagga.net>
1188
1189 * bgpd.c: Fix obvious (routeserver patch) merge error. This makes "no
1190 neighbor x.x.x.x routemap [export|import] commands work again.
1191
paula94feb32005-05-23 13:17:29 +000011922005-05-23 Paul Jakma <paul@dishone.st>
1193
1194 * bgp_routemap.c: add semi-colons to VTY_GET_* to match vty.h change
paul00d252c2005-05-23 14:19:54 +00001195 * bgp_fsm.h: Add extern qualifier to exported functions
1196 * bgp_nexthop.c: add static to nexthop specific globals
1197 * *.h: Add guard defines
paula94feb32005-05-23 13:17:29 +00001198
paul22db9de2005-05-19 01:50:11 +000011992005-05-19 Paul Jakma <paul@dishone.st>
1200
1201 * bgp_fsm.c: (bgp_stop) use sockunion_free, not XFREE..
1202 * bgp_network.c: (bgp_getsockname) ditto
paule83e2082005-05-19 02:12:25 +00001203 (bgp_accept) use XSTRDUP
paul22db9de2005-05-19 01:50:11 +00001204 * bgp_routemap.c: (route_match_peer) ditto, als use a ret value and
1205 remove one sockunion_free.
paule83e2082005-05-19 02:12:25 +00001206 * bgpd.c: (peer_delete) ditto.
1207 XFREE the correct memtype, not free.
1208 (peer_create) use XSTRDUP
1209 * bgp_packet.c: (bgp_stream_dup) deleted, stream_dup should be used
1210 (various) update -> s/bgp_stream_dup/stream_dup
1211
paul22db9de2005-05-19 01:50:11 +00001212
ajs634f9ea2005-04-11 15:51:40 +000012132005-04-11 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1214
1215 * bgp_zebra.c (bgp_redistribute_set, bgp_redistribute_unset):
1216 The 2nd arg to zebra_redistribute_send is now zclient instead of
1217 zclient->sock.
1218
hassoa8a80d52005-04-09 13:07:47 +000012192005-04-09 Akihiro Mizutani <mizutani@net-chef.net>
1220
1221 * bgp_vty.c: Make "exit-address-family" work in IPv4 unicast address
1222 family node.
1223
hasso68118452005-04-08 15:40:36 +000012242005-04-08 Martin Ling <martin-quagga@earth.li>
1225
1226 * bgp_aspath.[ch], bgp_route.c, bgp_vty.c, bgpd.[ch]: Allow to enable
1227 the length of confederation path segments to be included during the
1228 as-path length check in the best path decision.
1229
ajsd2fc8892005-04-02 18:38:43 +000012302005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1231
1232 * bgp_zebra.c: (bgp_interface_delete) After deleting, set ifp->ifindex
1233 to IFINDEX_INTERNAL.
1234
hasso6cf159b2005-03-21 10:28:14 +000012352005-03-21 Hasso Tepper <hasso at quagga.net>
1236
1237 * bgp_route.c: Don't crash while clearing route tables if there is
1238 no particular afi/safi configured.
1239
hasso338b3422005-02-23 14:27:24 +000012402005-02-23 Hasso Tepper <hasso at quagga.net>
1241
1242 * bgp_route.c: Make reannouncing prefixes with changed attributes
1243 work again.
1244
hasso6ffd2072005-02-02 14:50:11 +000012452005-02-02 Akihiro Mizutani <mizutani@net-chef.net>
1246
hassodd4c5932005-02-02 17:15:34 +00001247 * bgp_vty.c: Deprecate "neighbor transparent-as" and "neighbor
1248 transparent-nexthop" commands.
1249
12502005-02-02 Akihiro Mizutani <mizutani@net-chef.net>
1251
hassoc1643bb2005-02-02 16:43:17 +00001252 * bgp_routemap.c: New route-map command - "match ip route-source".
1253
12542005-02-02 Akihiro Mizutani <mizutani@net-chef.net>
1255
hassofee6e4e2005-02-02 16:29:31 +00001256 * bgp_clist.[ch], bgp_route.c, bgp_routemap.c, bgp_vty.c:
1257 community-list cleanup.
1258
12592005-02-02 Akihiro Mizutani <mizutani@net-chef.net>
1260
hasso6ffd2072005-02-02 14:50:11 +00001261 * bgp_route.c, bgp_vty.c, bgp_zebra.c, bgpd.[ch]: "enforce-multihop"
1262 -> "disable-connected-check".
1263
12642005-02-02 Akihiro Mizutani <mizutani@net-chef.net>
hasso93406d82005-02-02 14:40:33 +00001265
1266 * bgp_fsm.c, bgp_open.c, bgp_packet.c, bgp_route.[ch], bgp_vty.c,
1267 bgpd.[ch]: Add BGP_INFO_STALE flag and end-of-rib support. "bgp
1268 graceful-restart" commands added. Show numbers of individual
1269 messages in "show ip bgp neighbor" command. Final pieces of graceful
1270 restart.
1271
hassof4184462005-02-01 20:13:16 +000012722005-02-01 Akihiro Mizutani <mizutani@net-chef.net>
1273
hassoc9502432005-02-01 22:01:48 +00001274 * bgp_open.c, bgp_packet.c, bgp_vty.c, bgpd.[ch]: Remove "no neighbor
1275 capability route-refresh" commands. Route refresh capability is sent
1276 anyway now. Preserve dummy deprecated commands.
1277
12782005-02-01 Akihiro Mizutani <mizutani@net-chef.net>
1279
hasso3d515fd2005-02-01 21:30:04 +00001280 * bgp_attr.c, bgp_snmp.c, bgp_vty.c, bgpd.[ch]: Remove support for old
1281 draft - ie. "neighbor version 4-" commands. Preserve dummy "neighbor
1282 version" command as deprecated.
1283
12842005-02-01 Akihiro Mizutani <mizutani@net-chef.net>
1285
hasso0a486e52005-02-01 20:57:17 +00001286 * bgpd.[ch], bgp_vty.c, bgp_route.c: "Restart session after
1287 maximum-prefix limit" feature support.
1288
12892005-02-01 Akihiro Mizutani <mizutani@net-chef.net>
1290
hassof4184462005-02-01 20:13:16 +00001291 * bgp_nexthop.c: Improve debug.
1292 * bgpd.[ch], bgp_nexthop.c, bgp_snmp.c: Remove useless bgp_get_master()
1293 function.
1294 * bgp_packet.c: MP AFI_IP update and withdraw parsing.
1295 * bgp_fsm.c: Reset peer synctime in bgp_stop(). bgp_fsm_change_status()
1296 is better place to log about peer status change than bgp_event().
1297 Log in bgp_connect_success().
1298 * bgp_vty.c: Fix typo in comment.
1299 * bgp_attr.c: Better log about unknown attribute.
1300
ajs3b8b1852005-01-29 18:19:13 +000013012005-01-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1302
1303 * bgp_filter.c: (ip_as_path,no_ip_as_path) Use argv_concat instead
1304 of buffer_getstr.
1305 * bgp_route.c: (bgp_show_regexp) Fix memory leak: need to free string
1306 returned by buffer_getstr.
1307 (bgp_show_community) Must use XFREE instead of free on string
1308 returned by buffer_getstr.
1309 * bgp_routemap.c: (set_community) Must use XFREE instead of free
1310 on string returned by buffer_getstr.
1311 * bgp_vty.c: (neighbor_description) Use argv_concat instead of
1312 buffer_getstr.
1313
hasso6d694292005-01-24 09:29:42 +000013142005-01-24 Hasso Tepper <hasso at quagga.net>
1315
1316 * bgp_route.c: Fix showstopper bug. New route must be selected also
1317 if old one is flaged as BGP_INFO_ATTR_CHANGED.
1318
hassof1271652005-01-17 11:04:32 +000013192005-01-17 Hasso Tepper <hasso at quagga.net>
1320
1321 * bgp_route.c: Clear peer's routing table regardless whether it's
1322 configured or not. Being not configured is even better reason to
1323 do it.
1324
paula24a7e12005-01-05 08:14:13 +000013252005-01-05 Paul Jakma <paul@dishone.st>
1326
1327 * bgp_packet.c: (bgp_write) set socket to nonblock while writing
1328 this should be generalised. See bugzilla #102. Fix supplied by
1329 wawa@yandex-team.ru (Vladimir Ivanov).
1330
ajsd2c1f162004-12-08 21:10:20 +000013312004-12-08 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1332
1333 * *.c: Change level of debug messages to LOG_DEBUG.
1334
ajs274a4a42004-12-07 15:39:31 +000013352004-12-07 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1336
1337 * bgp_main.c: (main) The 2nd argument to openzlog has been removed.
1338
ajs887c44a2004-12-03 16:36:46 +000013392004-12-03 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1340
1341 * bgp_main.c: (sigint) Use zlog_notice for termination message.
1342 (main) Use zlog_notice for startup announcement.
1343
hassoc0652302004-11-25 19:33:48 +000013442004-11-25 Hasso Tepper <hasso at quagga.net>
1345
1346 * bgp_main.c: Make group to run as configurable.
1347
paul59320202004-11-09 01:54:03 +000013482004-11-09 Paul Jakma <paul@dishone.st>
1349
1350 * bgp_nexthop.c: collapse bgp_connected_ipvX, bgp_nexthop_cache_ipvX
1351 and cache{1,2}.. into arrays of tables and hence collapse
1352 bgp_scan_ipv{4,6} into a single bgp_scan function. Tested, though
1353 a long time ago (and this change was hand-merged).
1354
ajs5a646652004-11-05 01:25:55 +000013552004-11-04 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1356
1357 * bgp_route.c: Remove all code related to VTY_CONTINUE; this feature
1358 is deprecated because the output did not represent a single point
1359 in time. All output needs to be generated inline and buffered
1360 by the library code.
1361 (route_vty_out,route_vty_out_tag,damp_route_vty_out,
1362 flap_route_vty_out) Remove code to count number of lines of output,
1363 since this was only useful for VTY_CONTINUE behavior.
1364 (bgp_show_callback,vty_calc_line) Removed.
1365 (bgp_show_table) Remove hooks for VTY_CONTINUE callback support.
1366 As a result, there's a new output_arg argument to this function.
1367 Make function static.
1368 (bgp_show) Make function static and add a new output_arg argument.
1369 Change all functions that call bgp_show or bgp_show_table to
1370 pass the new output_arg argument (that used to be passed inside
1371 vty->output_arg).
1372 * bgp_mplsvpn.c: Remove declarations of functions defined in
1373 bgp_route.c; these declarations belong in bgp_route.h.
1374 * bgp_route.h: Declare 3 global functions used in both bgp_route.c
1375 and in bgp_mplsvpn.c.
1376
paula2b1ecd2004-10-31 18:58:09 +000013772004-10-31 Paul Jakma <paul@dishone.st>
1378
1379 * {bgpd,bgp_attr}.c: size_t printf format should be ld.
1380
paul98f51632004-10-25 14:19:15 +000013812004-10-25 Paul Jakma <paul@dishone.st>
1382
1383 * Update with fix in debian bug id 222930.
1384 * bgp_main.c: Add ZCAP_RAW, needed to bind to interfaces.
1385 bgp_network.c: (....) raise/lower privs around call to
1386 SO_BINDTODEVICE sockopt.
1387
hasso3fb9cd62004-10-19 19:44:43 +000013882004-10-19 Andrew J. Schorr <aschorr@telemetry-investments.com>
1389
1390 * bgp_nexthop.c: (bgp_connected_add) Connected destination pointer
1391 may be NULL.
1392 (bgp_connected_delete) ditto.
1393
hasso501ba492004-10-13 21:32:46 +000013942004-10-14 Hasso Tepper <hasso at quagga.net>
1395
1396 * bgp_dump.c: Make dump configuration appear in vtysh.
1397
hassoc75105a2004-10-13 10:33:26 +000013982004-10-13 Hasso Tepper <hasso at quagga.net>
1399
1400 * bgp_snmp.c: Remove defaults used to initialize smux connection to
1401 snmpd. Connection is initialized only if smux peer is configured.
hasso8b3126b2004-10-13 20:59:04 +00001402 * bgp_view.c: It's dead file. Reomved.
hassoc75105a2004-10-13 10:33:26 +00001403
paulfd79ac92004-10-13 05:06:08 +000014042004-10-13 Paul Jakma <paul@dishone.st>
1405
1406 * (global) more const'ification and fixups of types to clean up code.
1407 * bgp_mplsvpn.{c,h}: (str2tag) fix abuse. Still not perfect,
1408 should use something like the VTY_GET_INTEGER macro, but without
1409 the vty_out bits..
1410 * bgp_routemap.c: (set_aggregator_as) use VTY_GET_INTEGER_RANGE
1411 (no_set_aggregator_as) ditto.
1412 * bgpd.c: (peer_uptime) fix unlikely bug, where no buffer is
1413 returned, add comments about troublesome return value.
1414
hasso18a6dce2004-10-03 18:18:34 +000014152004-10-03 James R. Leu <jleu at mindspring.com>
1416
1417 * bgp_vty.c: Router id from zebra can be manually overriden.
1418 * bgp_zebra.c: Read router id related messages from zebra daemon.
1419 Remove own code related with router id selection.
1420 * bgpd.c, bgpd.h: Remove own router id selection code. Use the one
1421 from zebra daemon if it isn't manually overriden.
1422
hassoc9e52be2004-09-26 16:09:34 +000014232004-09-26 Hasso Tepper <hasso at quagga.net>
1424
1425 * bgp_aspath.c, bgp_packet.c, bgp_vty.c: Fix compiler warnings.
1426
hasso52dc7ee2004-09-23 19:18:23 +000014272004-09-23 Hasso Tepper <hasso at quagga.net>
1428
1429 * *.[c|h]: list -> struct list *, listnode -> struct listnode *.
1430
paule01f9cb2004-07-09 17:48:53 +000014312004-07-09 Paul Jakma <paul@dishone.st>
1432
1433 * Merge of GNU Zebra cvs2svn changesets r799, r800 and r807.
1434 * bgp_dump.c: (bgp_dump_attr) cleanup. return status code. check
1435 attributes present before printing.
1436 * bgp_dump.c: update bgp_dump_attr prototype.
1437 * bgp_packet.c: (bgp_update_receive) init attrstr. check status
1438 of bgp_dump_attr. Log end-of-rib UPDATEs.
1439
paulf5ba3872004-07-09 12:11:31 +000014402004-07-09 Sowmini Varadhan <sowmini.varadhan@sun.com>
1441
1442 * bgp_packet.c: (bgp_collision_detect) Send NOTIFY on new socket
1443 if that is connection we're closing.
1444 (bgp_read) invalid marker check applies to KEEPALIVE too.
1445 * bgp_route.c: Ignore multicast NRLI, dont send NOTIFY.
1446
paul5228ad22004-06-04 17:58:18 +000014472004-06-04 Paul Jakma <paul@dishone.st>
1448
1449 * type mismatch fixes
1450
hasso538621f2004-05-21 09:31:30 +000014512004-05-21 Akihiro Mizutani <mizutani@net-chef.net>
1452
1453 * bgpd.h, bgp_open.[ch], bgp_debug.c, bgp_vty.[ch], bgp_fsm.c:
1454 Graceful restart capability display.
1455
hasso3950fda2004-05-20 10:22:49 +000014562005-05-20 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1457
1458 * bgp_debug.c: Cosmetical fixes and log neighbor changes.
1459
hasso4372df72004-05-20 10:20:02 +000014602004-05-20 Akihiro Mizutani <mizutani@net-chef.net>
1461
1462 * bgp_ecommunity.c: Transit ecommunity support.
1463 * bgp_ecommunity.c: Fix for unknown community crush.
1464
hassoe0701b72004-05-20 09:19:34 +000014652005-05-20 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1466
1467 * *: Maximum prefix threshold support.
1468 * *: Reset notification fixups.
1469
paul0a589352004-05-08 11:48:26 +000014702004-05-08 Paul Jakma <paul@dishone.st>
1471
1472 * bgp_zebra.c: (bgp_interface_address_add) sync to zclient changes
1473 (bgp_interface_address_delete) ditto.
1474 (bgp_zebra_announce) ditto.
1475 (bgp_zebra_withdraw) ditto.
1476
paulc5317402004-05-03 13:25:06 +000014772004-05-03 Daniel Roesen <dr@cluenet.de>
1478
1479 * bgp_fsm.c: (bgp_stop) Reset uptime only on transition from
1480 Established so that it reflects true downtime (rather time
1481 since last transition, eg Active->Idle)
1482
paul35be31b2004-05-01 18:17:04 +000014832004-05-01 rivo nurges <rix@estpak.ee>
1484
1485 * bgp_route.c: fix UNH IOL BGP-4.1.12f
1486
pauleb821182004-05-01 08:44:08 +000014872004-05-01 Paul Jakma <paul@dishone.st>
1488
1489 * Revert the attempted clean-up of the dummy peer hack, reverts
1490 patchsets 435 (see 2004-02-17 below) and 456.
1491
paul545acaf2004-04-20 15:13:15 +000014922004-04-16 rivo nurges <rix@estpak.ee>
1493
hasso9b87e412004-04-20 16:54:49 +00001494 * bgpd.h, bgp_debug.c: update cease subcodes to
1495 draft-ietf-idr-cease-subcode-05
paul545acaf2004-04-20 15:13:15 +00001496 * bgpd.h, bgpd.c, bgp_route.c, bgp_route.h: fix UNH IOL BGP-4.1.6a
1497
paul6ad23f02004-02-17 19:45:10 +000014982004-02-17 Paul Jakma <paul@dishone.st>
1499
1500 * bgpd.h: (bgp_peer) add fd_local and fd_accept
1501 file descriptor's, fd becomes a pointer to one of these.
1502 * bgpd.c: (global) adjust for fact that fd is now a pointer.
1503 (peer_create_accept) removed.
1504 * bgp_route.c: (global) adjust for change of peer fd to pointer
1505 * bgp_packet.c: (bgp_collision_detect) adjust and remove the
1506 "replace with other peer" hack.
1507 * bgp_network.c: (bgp_accept) Remove the dummy peer hack.
1508 Update peer->fd_accept instead.
1509 (global) Adjust fd references - now a pointer.
1510 * bgp_fsm.c: (global) adjust peer fd to pointer.
1511 (bgp_connection_stop) new function, to stop connection.
1512 (global) adjust everything which closed peer fd to use
1513 bgp_connection_stop().
1514
gdt10d60ad2003-12-23 17:34:39 +000015152003-12-23 Krzysztof Oledzki <oleq@ans.pl>
1516
1517 * bgp_network.c: drop privs on error cases
1518
paul6ad23f02004-02-17 19:45:10 +000015192003-08-11 kunihiro <kunihiro@zebra.org>
paulac41b2a2003-08-12 05:32:27 +00001520
1521 * bgp_route{,map}.c: Extend 'set ip next-hop' in route-maps with
1522 ability to specify 'peer-address' rather than IP.
1523
paul9238b1e2003-06-11 08:03:08 +000015242003-06-09 Paul Jakma <paul@dishone.st>
1525
1526 * bgp_clist.c (community_list_delete): honour deny statements
1527
paul445f1432003-05-16 19:00:31 +000015282003-04-19 Hasso Tepper <hasso@estpak.ee>
1529
1530 * rip_routemap.c: sync daemon's route-map commands to have same
1531 syntax
1532
15332003-01-09 Akihiro Mizutani <mizutani@net-chef.net>
1534
1535 * bgp_routemap.c: Add match extcommunity command.
1536
paul718e3742002-12-13 20:15:29 +000015372002-10-23 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1538
1539 * bgp_aspath.c (aspath_init): Extend hash size from default to
1540 32767.
1541 (aspath_key_make): Use unsigned shoft for making hash. Suggested
1542 by: Marc Evans <Marc@SoftwareHackery.Com>
1543
15442002-08-19 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1545
1546 * bgp_clist.c (community_entry_free): Fix memory leak of standard
1547 extcommunity-list config string.
1548
15492002-08-19 Akihiro Mizutani <mizutani@net-chef.net>
1550
1551 * bgp_route.c (route_vty_out_detail): Fix bug of router-id display
1552 when multiple instance is used.
1553
15542002-08-18 Akihiro Mizutani <mizutani@net-chef.net>
1555
1556 * bgpd.c: Make "default-originate" and "maximum-prefix" commands
1557 available in peer-group configuration.
1558
15592002-08-13 Akihiro Mizutani <mizutani@net-chef.net>
1560
1561 * bgp_packet.c (bgp_open_send): Put Opt Parm Len 0 when last
1562 capability packet cause error or dont-capability-negotiate option
1563 is specified.
1564
15652002-07-07 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1566
1567 * zebra-0.93 released.
1568
15692001-10-28 Kunihiro Ishiguro <kunihiro@zebra.org>
1570
1571 * bgpd.c (bgp_vty_init): Translate update commands are removed.
1572
15732001-10-10 Kunihiro Ishiguro <kunihiro@zebra.org>
1574
1575 * bgp_route.c (bgp_static_set): Add workaround for BGP static
1576 route announcement when there is no zebra running.
1577
15782001-10-08 Kunihiro Ishiguro <kunihiro@zebra.org>
1579
1580 * bgpd.c (neighbor_remote_as_unicast): Remove "remote-as nlri
1581 unicast multicast" commands.
1582
15832001-09-14 Akihiro Mizutani <mizutani@dml.com>
1584
1585 * bgp_open.c: When we receive capability route-refresh, we should
1586 check we send the capability not we receive the capability.
1587
1588 * bgp_route.c (bgp_network_mask_natural_route_map): network
1589 statement route-map is added.
1590
15912001-08-31 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1592
1593 * bgp_advertise.c (bgp_advertise_intern): attr must be interned
1594 before looking up hash table.
1595
15962001-08-30 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1597
1598 * bgpd.h (struct peer): BGP filter is moved from peer_conf to
1599 peer.
1600
16012001-08-28 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1602
1603 * bgp_nexthop.c (bnc_nexthop_free): Fix next pointer bug.
1604 Suggested by: "Hong-Sung Kim" <hoskim@lanbird.co.kr>.
1605
16062001-08-26 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1607
1608 * bgp_table.c (bgp_node_create): Clearn memory before use it.
1609
16102001-08-24 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1611
1612 * Change to use bgp_table.[ch].
1613
16142001-08-23 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1615
1616 * bgpd.c (bgp_init): Add "transparent-as" and
1617 "transparent-nexthop" for old version compatibility.
1618
16192001-08-23 Akihiro Mizutani <mizutani@dml.com>
1620
1621 * bgpd.h (struct peer): default-originate route-map is added.
1622
1623 * bgp_route.c: When self originated route is advertised with
1624 attrubute-unchanged, nexthop was not properly set. This bug is
1625 fixed.
1626
16272001-08-22 Akihiro Mizutani <mizutani@dml.com>
1628
1629 * bgpd.c (neighbor_attr_unchanged): transparent-as and
1630 transparent-next-hop commands are restructured. Instead of
1631 current transparent-* commands, attribute-unchanged command is
1632 introduced.
1633
1634 neighbor A.B.C.D attribute-unchanged [as-path|next-hop|med]
1635
1636 (neighbor_default_originate): "default-originate" configuration
1637 announce default route even 0.0.0.0/0 does not exists in BGP RIB.
1638
16392001-08-19 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1640
1641 * zebra-0.92a released.
1642
16432001-08-19 Akihiro Mizutani <mizutani@dml.com>
1644
1645 * bgpd.c: AF specific soft-reconfiguration inbound commands are
1646 added.
1647
16482001-08-17 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1649
1650 * bgp_route.c (bgp_show_callback): Do not do community NULL check.
1651
1652 * bgp_community.c (community_cmp): Add check for commnunity NULL
1653 check.
1654
1655 * bgp_routemap.c (route_match_community): Do not check comunity is
1656 NULL. It may match to community-list "^$".
1657
1658 * bgp_community.c (community_match): Add check for community is
1659 NULL case.
1660
16612001-08-17 Akihiro Mizutani <mizutani@dml.com>
1662
1663 * bgpd.c: AF specific route-reflector-client and
1664 route-server-client configuration are added.
1665
16662001-08-17 Rick Payne <rickp@ayrnetworks.com>
1667
1668 * bgp_clist.c (community_match_regexp): Check special ^$ case.
1669
16702001-08-17 Akihiro Mizutani <mizutani@dml.com>
1671
1672 * bgp_clist.c (community_list_match): Fix bug of community list
1673 permit and deny check.
1674
16752001-08-16 Akihiro Mizutani <mizutani@dml.com>
1676
1677 * bgp_mplsvpn.c (bgp_mplsvpn_init): Add AF specific "nexthop-self"
1678 command.
1679
16802001-08-15 Akihiro Mizutani <mizutani@dml.com>
1681
1682 * bgpd.h (PEER_FLAG_SEND_COMMUNITY): Per AF based configuration
1683 flag is introduced.
1684
1685 * bgp_mplsvpn.c (bgp_mplsvpn_init): VPNv4 filtering is added.
1686
16872001-08-15 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1688
1689 * zebra-0.92 released.
1690
16912001-08-13 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1692
1693 * bgpd.c (bgp_delete): "no router bgp" free static, aggregate, rib
1694 table properly.
1695
16962001-08-12 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1697
1698 * bgp_route.c (bgp_node_safi): Return SAFI of current node.
1699 (bgp_config_write_network_vpnv4): VPNv4 static configuration
1700 display.
1701
17022001-08-11 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1703
1704 * bgpd.c (no_bgp_ipv4_multicast_route_map): Add IPv4 multicast
1705 node filter commands.
1706
17072001-08-11 Kunihiro Ishiguro <kunihiro@zebra.org>
1708
1709 * bgpd.h (PEER_FLAG_IGNORE_LINK_LOCAL_NEXTHOP): Add
1710 "ignore-link-local-nexthop" flag for ignore link-local nexthop for
1711 IPv6.
1712
17132001-08-07 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1714
1715 * bgpd.c (address_family_ipv4_multicast): "address-family ipv4
1716 multicast" is added.
1717 (address_family_ipv6_unicast): "address-family ipv6 unicast" is
1718 added.
1719
17202001-08-07 Akihiro Mizutani <mizutani@dml.com>
1721
1722 * bgp_route.c (bgp_process): Use flag instead of as_selected
1723 memeber in struct bgp_info.
1724
1725 * bgp_route.h (struct bgp_info): Remove as_selected memeber from
1726 struct bgp_info.
1727
17282001-07-31 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1729
1730 * bgp_route.c (bgp_announce_check): Enclose sending time AS loop
1731 check code with #ifdef BGP_SEND_ASPATH_CHECK.
1732
17332001-07-29 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1734
1735 * bgp_packet.c (bgp_withdraw_send): Simplify address family check.
1736
1737 * bgpd.h (BGP_INFO_HOLDDOWN): Introduce new macro to check BGP
1738 information is alive or not.
1739
1740 * bgp_community.c: Use community_val_get() on all OS.
1741
17422001-07-24 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1743
1744 * bgp_route.c (bgp_announce_check): Simplify set next-hop self
1745 check.
1746
17472001-07-24 Akihiro Mizutani <mizutani@dml.com>
1748
1749 * bgp_route.c (bgp_announce_check): To route server clients, we
1750 announce AS path, MED and nexthop transparently.
1751
17522001-06-21 Kunihiro Ishiguro <kunihiro@zebra.org>
1753
1754 * bgp_routemap.c (route_set_atomic_aggregate_free): Do not call
1755 XFREE. No memory is allocated in
1756 route_set_atomic_aggregate_compile().
1757
17582001-06-21 Kunihiro Ishiguro <kunihiro@zebra.org>
1759
1760 * bgp_routemap.c (bgp_route_map_init): `match nlri` and `set nlri`
1761 are replaced by `address-family ipv4` and `address-family vpnvr'.
1762
17632001-06-19 Kunihiro Ishiguro <kunihiro@zebra.org>
1764
1765 * bgp_route.c (bgp_withdraw): Add check for BGP_PEER_CONFED.
1766 Reported by Rick Payne <rickp@rossfell.co.uk>.
1767
17682001-06-17 Kunihiro Ishiguro <kunihiro@zebra.org>
1769
1770 * bgp_zebra.c (bgp_zebra_announce): When global IPv6 nexthop is
1771 empty, use socket's remote address for the nexthop.
1772
17732001-06-04 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1774
1775 * bgpd.c (peer_delete): Fix memory leak. Reported by Yosi Yarchi
1776 <Yosi_Yarchi@KereniX.com>
1777
17782001-06-01 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1779
1780 * bgpd.c (bgp_delete): Fix memory leak. Reported by Yosi Yarchi
1781 <Yosi_Yarchi@KereniX.com>
1782
17832001-05-27 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1784
1785 * bgp_route.c (bgp_route_clear_with_afi_vpnv4): Use next instead
1786 of ri->next.
1787
1788 * bgp_packet.c (bgp_withdraw_send): MPLS/VPN withdraw takes effect
1789 when HAVE_IPV6 is not defined.
1790
17912001-03-07 "Akihiro Mizutani" <mizutani@dml.com>
1792
1793 * bgpd.c (peer_timers_set): Adjust keepalive timer to fit less
1794 than holdtime / 3.
1795 (bgp_confederation_peers_unset): Only set peer->local_as when
1796 confederation is enabled.
1797 (bgp_timers): Add "timers bgp <0-65535> <0-65535>" command.
1798
1799 * bgp_route.c (bgp_announce_check): Set med of redistributed route
1800 when it is announced to EBGP peer.
1801
18022001-03-06 "Akihiro Mizutani" <mizutani@dml.com>
1803
1804 * bgp_nexthop.c (bgp_scan_ipv4): bgp_scan() call bgp_process() for
1805 all prefixes.
1806
18072001-03-06 Kunihiro Ishiguro <kunihiro@zebra.org>
1808
1809 * bgp_attr.c (bgp_attr_origin): When bgpd send NOTIFICATION with
1810 erroneous attribute (type, length and value), it does include
1811 attribute flags field.
1812
18132001-02-21 "Akihiro Mizutani" <mizutani@dml.com>
1814
1815 * bgp_route.c (bgp_announce_check): The route reflector is not
1816 allowed to modify the attributes of the reflected IBGP routes.
1817
18182001-02-20 "Akihiro Mizutani" <mizutani@dml.com>
1819
1820 * bgp_route.c (bgp_info_cmp): During path seleciton, BGP
1821 confederation peer is treated as same as IBGP peer.
1822
18232001-02-19 Kunihiro Ishiguro <kunihiro@zebra.org>
1824
1825 * bgp_route.c (bgp_redistribute_add): Initialize attr_new with
1826 attr. Call aspath_unintern when return from this function.
1827
18282001-02-19 "Akihiro Mizutani" <mizutani@dml.com>
1829
1830 * bgpd.c (bgp_router_id_set): Reset BGP peer when router-id is
1831 changed.
1832
18332001-02-18 "Akihiro Mizutani" <mizutani@dml.com>
1834
1835 * bgp_packet.c (bgp_open_receive): When user configure holdtimer,
1836 do not refrect the value to current session.
1837
18382001-02-16 Kunihiro Ishiguro <kunihiro@zebra.org>
1839
1840 * bgp_route.c (bgp_aggregate_delete): Set BGP_INFO_ATTR_CHANGE to
1841 suppress route withdraw.
1842
1843 * bgp_damp.c (bgp_damp_init): Fix bug of flap dampening.
1844
18452001-02-16 "Akihiro Mizutani" <mizutani@dml.com>
1846
1847 * bgp_aspath.c (aspath_make_str_count): Use ',' for separator for
1848 AS_SET and AS_CONFED_SET.
1849
18502001-02-15 Kunihiro Ishiguro <kunihiro@zebra.org>
1851
1852 * bgp_route.c (bgp_process): Do not consider suppress route.
1853
1854 * bgp_aspath.c (aspath_aggregate_as_set_add): Reset asset when
1855 aspath->data is realloced.
1856
18572001-02-15 "Akihiro Mizutani" <mizutani@dml.com>
1858
1859 * bgp_attr.c (bgp_attr_aggregate_intern): Do not set atomic
1860 aggregate when using as-set.
1861
18622001-02-14 "Akihiro Mizutani" <mizutani@dml.com>
1863
1864 * bgpd.c (bgp_confederation_peers_unset): Set peer's local-as
1865 correctly.
1866
1867 * bgp_route.c (bgp_update): Just ignore AS path loop for
1868 confederation peer.
1869
18702001-02-10 Kunihiro Ishiguro <kunihiro@zebra.org>
1871
1872 * bgp_route.c (bgp_aggregate_set): Add as_set argument.
1873 (bgp_aggregate_unset): Remove summary_only argument.
1874 (aggregate_address_as_set): New commands.
1875 "aggregate-address A.B.C.D/M as-set"
1876 "no aggregate-address A.B.C.D/M as-set"
1877
18782001-02-08 "Akihiro Mizutani" <mizutani@dml.com>
1879
1880 * bgp_route.c (bgp_announce_check): Do not modify nexthop when the
1881 route is passed by route reflector.
1882
18832001-02-08 Kunihiro Ishiguro <kunihiro@zebra.org>
1884
1885 * bgp_route.c: "no bgp dampening" with argument.
1886 (bgp_announce_check): Do not modify nexthop when the route is
1887 passed by route reflector.
1888
18892001-02-07 "Akihiro Mizutani" <mizutani@dml.com>
1890
1891 * bgpd.c (neighbor_passive): Change "neighbor NEIGHBOR remote-as
1892 ASN passive" to "neighbor NEIGHBOR passive".
1893 (bgp_announce_check): Check well-known community attribute even
1894 when "no neighbor send-community" is set.
1895
18962001-02-03 Kunihiro Ishiguro <kunihiro@zebra.org>
1897
1898 * bgp_fsm.c (bgp_establish): Do not send keepalive at established
1899 time when keepalive timer is configured as zero.
1900
19012001-02-01 Kunihiro Ishiguro <kunihiro@zebra.org>
1902
1903 * bgp_attr.c (bgp_attr_check): When peer is IBGP peer, local
1904 preference is well-known attribute.
1905
19062001-01-30 Kunihiro Ishiguro <kunihiro@zebra.org>
1907
1908 * zebra-0.91 is released.
1909
1910 * bgp_attr.h (struct attr): Comment out DPA value.
1911 (struct attr): Change refcnt type from int to unsinged long.
1912
1913 * bgp_attr.c (attrhash_key_make): Likewise.
1914 (attrhash_cmp): Likewise.
1915 (bgp_attr_dpa): Likewise.
1916
19172001-01-30 "Akihiro Mizutani" <mizutani@dml.com>
1918
1919 * bgp_route.c (bgp_info_cmp): Make route selection completely same
1920 as Cisco's.
1921
19222001-01-30 Kunihiro Ishiguro <kunihiro@zebra.org>
1923
1924 * bgp_attr.h (BGP_ATTR_FLAG_OPTIONAL): Rename old ATTR_FLAG_* to
1925 BGP_ATTR_FLAG_* to clarify meenings.
1926
19272001-01-30 "Akihiro Mizutani" <mizutani@dml.com>
1928
1929 * bgp_route.c (route_vty_out): Display argument to suppress same
1930 prefix information display.
1931 (route_vty_out_route): Don't display mask information for
1932 classfull network.
1933
19342001-01-30 Kunihiro Ishiguro <kunihiro@zebra.org>
1935
1936 * bgp_attr.h (SET_BITMAP): Simple bitmapping macros.
1937
1938 * bgp_attr.c (bgp_attr_parse): Use bitmap for attribute type
1939 check.
1940
19412001-01-29 Kunihiro Ishiguro <kunihiro@zebra.org>
1942
1943 * bgp_attr.c (bgp_mp_reach_parse): Enclose loggin with BGP_DEBUG.
1944 (bgp_attr_parse): Comment out well-known attribute check.
1945
19462001-01-28 Kunihiro Ishiguro <kunihiro@zebra.org>
1947
1948 * bgp_route.c (bgp_static_unset): Link-local IPv6 address can't be
1949 used for network advertisement.
1950 (nlri_parse): When link-local IPv6 address NLRI comes from
1951 remote-peer, log the information then simply ignore it.
1952
1953 * bgp_zebra.c (zebra_read_ipv6): Link-local IPv6 address is not
1954 redistributed.
1955
1956 * bgp_route.c (bgp_update): Check IPv6 global nexthop
1957 reachability.
1958
19592001-01-26 Kunihiro Ishiguro <kunihiro@zebra.org>
1960
1961 * bgp_route.c (bgp_update): Check nexthop points local address or
1962 not.
1963 (bgp_static_update_vpnv4): Set valid flag.
1964
1965 * bgp_attr.c (bgp_attr_parse): Duplicate attribute check.
1966 (bgp_attr_parse): Well-known attribute check.
1967
1968 * bgp_open.c (bgp_auth_parse): Authentication is not yet supported.
1969
1970 * bgp_packet.c (bgp_valid_marker): Check marker is synchronized.
1971
1972 * bgpd.c (clear_bgp): Send NOTIFICATION Cease when SEND_CEASE is
1973 defined.
1974
1975 * bgp_snmp.c (bgp4PathAttrTable): Fix compile error.
1976
19772001-01-24 Kunihiro Ishiguro <kunihiro@zebra.org>
1978
1979 * bgpd.c (bgp_network_import_check): New command for IGP network
1980 check.
1981
19822001-01-23 Kunihiro Ishiguro <kunihiro@zebra.org>
1983
1984 * bgp_nexthop.c (bgp_scan): Run bgp_process when IGP metric is
1985 changed. Call bgp_process once for each node.
1986
19872001-01-23 "Akihiro Mizutani" <mizutani@dml.com>
1988
1989 * bgp_route.c (bgp_info_cmp): Add IGP metric comparison.
1990
19912001-01-23 Kunihiro Ishiguro <kunihiro@zebra.org>
1992
1993 * bgp_route.c (bgp_info_cmp): Add IGP metric comparison.
1994
1995 * bgp_nexthop.c (bgp_nexthop_lookup): Set IGP metric for valid
1996 IBGP route.
1997
19982001-01-23 "Akihiro Mizutani" <mizutani@dml.com>
1999
2000 * bgp_route.c (show_ip_bgp_prefix_longer): Add new commands.
2001 "show ip bgp A.B.C.D/M longer-prefixes"
2002 "show ip bgp ipv4 (unicast|multicast) A.B.C.D/M longer-prefixes"
2003 "show ipv6 bgp X:X::X:X/M longer-prefixes"
2004 "show ipv6 mbgp X:X::X:X/M longer-prefixes"
2005
20062001-01-20 "Akihiro Mizutani" <mizutani@dml.com>
2007
2008 * bgp_route.c (show_ip_bgp_cidr_only): Add new commands.
2009 "show ip bgp cidr-only"
2010 "show ip bgp ipv4 (unicast|multicast) cidr-only"
2011
20122001-01-18 "Akihiro Mizutani" <mizutani@dml.com>
2013
2014 * bgp_route.c (bgp_update): AS path lookup check is done in
2015 bgp_update() not in attr_parse().
2016
20172001-01-18 Kunihiro Ishiguro <kunihiro@zebra.org>
2018
2019 * bgp_route.c (bgp_update): Call bgp_aggregate_decrement() just
2020 before bgp_attr_unintern().
2021
20222001-01-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2023
2024 * bgp_route.c (bgp_update): Now intern is performed very last part
2025 of the BGP packet update procedure.
2026
20272001-01-17 "Akihiro Mizutani" <mizutani@dml.com>
2028
2029 * bgp_route.c (bgp_update): When implicit withdraw occur, reuse
2030 existing bgp_info structure.
2031
20322001-01-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2033
2034 * bgp_route.c (bgp_aggregate_decrement): Fix bug of aggregate
2035 address matching method.
2036 (bgp_update):
2037
2038 * bgp_nexthop.c (bgp_nexthop_onlink): Separate EBGP nexthop onlink
2039 check and IBGP nexthop route check.
2040
20412001-01-16 "Akihiro Mizutani" <mizutani@dml.com>
2042
2043 * bgp_route.h (BGP_INFO_ATRR_CHANGED): Added for track attribute
2044 change.
2045
20462001-01-16 Kunihiro Ishiguro <kunihiro@zebra.org>
2047
2048 * bgp_route.h (struct bgp_info): Remove selected flag. Use
2049 BGP_INFO_SELECTED for flags instead.
2050 (struct bgp_info): Remove valid flag. Use BGP_INFO_VALID for
2051 flags instead.
2052 (struct bgp_info): Add igpmetric for IBGP route nexthop IGP
2053 metric.
2054 (struct bgp_info_tab): Struct bgp_info_tag is integrated into
2055 struct bgp_info.
2056 (BGP_INFO_ATRR_CHANGED): Added for track attribute change.
2057
2058 * bgp_community.c (community_val_get): gcc-2.95 on
2059 sparc-sun-solaris cause crush. This function is for avoid the
2060 crush.
2061
20622001-01-15 Kunihiro Ishiguro <kunihiro@zebra.org>
2063
2064 * bgp_packet.c (bgp_open_receive): Translated peer's packet_size
2065 clear bug is fixed.
2066
20672001-01-14 "Akihiro Mizutani" <mizutani@dml.com>
2068
2069 * bgp_packet.c (bgp_open_receive): Return notification with
2070 supported version number.
2071
20722001-01-13 Kunihiro Ishiguro <kunihiro@zebra.org>
2073
2074 * bgpd.c (bgp_show_summary): Display AS path and community
2075 entries. Suggested by: "Matt Ranney" <mjr@ranney.com>.
2076
2077 * bgp_packet.c (bgp_read_packet): Fix bug of unblocking BGP socket
2078 read. When BGP packet read is partial, we must get size and type
2079 from packet again.
2080
20812001-01-12 "Akihiro Mizutani" <mizutani@dml.com>
2082
2083 * bgp_route.c (bgp_update): Do not unset BGP_INFO_HISTORY flag.
2084 (bgp_update): When there is a history entry increment route count.
2085 (bgp_damp_set): Check BGP_CONFIG_DAMPENING flag.
2086
2087 * bgp_damp.c (bgp_damp_withdraw): Set status to
2088 BGP_DAMP_DISCONTINUE.
2089
20902001-01-11 Kunihiro Ishiguro <kunihiro@zebra.org>
2091
2092 * bgp_attr.c (bgp_mp_reach_parse): Fix warning code when second
2093 IPv6 nexthop is not link-local addresss.
2094
20952001-01-11 "Akihiro Mizutani" <mizutani@dml.com>
2096
2097 * bgp_damp.c (bgp_config_write_damp): Smart flap dampening
2098 configuration display.
2099 (bgp_damp_info_print): Display elapsed time from flap started.
2100
2101 * bgp_damp.h (struct bgp_damp_info): Add flap start time.
2102
2103 * bgpd.c (peer_create): Set last read time.
2104 (bgp_show_peer): Display last read time.
2105 (bgp_show_summary): Use BGP_CONFIG_DAMPENING flag to check
2106 configuration.
2107
2108 * bgpd.h (BGP_CONFIG_DAMPENING): Add new configuration option.
2109 (struct peer): Add last read time member.
2110 (BGP_VERSION_MP_4): Remove obsolete definition.
2111
21122001-01-10 Kunihiro Ishiguro <kunihiro@zebra.org>
2113
2114 * bgp_nexthop.c: Remove OLD_RIB codes.
2115
2116 * bgp_route.c (bgp_process): Likewise.
2117
2118 * zebra-0.90 is released.
2119
2120 * bgp_route.h (BGP_INFO_HISTORY): Remove damped member from struct
2121 bgp_info. Instead of that use BGP_INFO_DAMPED flag.
2122 (struct bgp_info): Remove invalid member from struct bgp_info.
2123 Instead of that use BGP_INFO_HISTORY flag.
2124
21252001-01-10 "Akihiro Mizutani" <mizutani@dml.com>
2126
2127 * bgp_damp.c (bgp_damp_info_print): New function to display
2128 dampening status.
2129 (DEFAULT_HARF_LIFE): Define default value.
2130 (DEFAULT_REUSE): Likewise.
2131 (DEFAULT_SUPPRESS): Likewise.
2132 (bgp_config_write_damp): When config value is same as default
2133 value, simply display "bgp dampening" to configuration.
2134
2135 * bgp_damp.h (struct bgp_damp_info): Add flap member.
2136
2137 * bgp_route.h (struct bgp_info): Added for BGP flap dampening
2138 history status.
2139
21402001-01-10 Kunihiro Ishiguro <kunihiro@zebra.org>
2141
2142 * bgp_nexthop.c (bgp_connected_add): Point-to-point connected
2143 address is properly handled.
2144 (bgp_connected_delete): Likewise.
2145
2146 * bgp_route.c (bgp_route_init): Turn off BGP Flap dampening code
2147 until it works fine.
2148
21492001-01-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2150
2151 * bgpd.c (bgp_show_summary): Add BGP_VERSION_MP_4 case.
2152
2153 * bgp_route.c (bgp_update): When this is not damped route, clear
2154 ri pointer.
2155
21562001-01-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2157
2158 * bgp_main.c: Add "-n" no_kernel option to not install route to
2159 kernel. Suggested by: "Matt Ranney" <mjr@ranney.com>
2160
21612001-01-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2162
2163 * bgp_nexthop.c (bgp_connected_add): Revert point-to-point
2164 connected route patch. Reported by ruud@ruud.org (Ruud de Rooij)
2165
2166 * bgp_damp.c (bgp_config_write_damp): Add configuration display
2167 function.
2168
2169 * bgp_route.c (bgp_info_free): Set NULL to BGP dampening
2170 information when BGP info structure is freed.
2171 (bgp_info_cmp): Check damped flag.
2172 (bgp_announce_check): Damped route is not announced.
2173
21742001-01-09 "Akihiro Mizutani" <mizutani@dml.com>
2175
2176 * bgpd.c (neighbor_capability_route_refresh): Change "neighbor
2177 route-refresh" command to "neighbor capability route-refresh".
2178 (clear_bgp_soft_in): Change soft-reconfig method.
2179
2180 clear ip bgp <neighbor> soft in
2181 --------------------------------------
2182 Try stored cache first then route-refresh
2183
2184 clear ip bgp <neighbor> in
2185 ---------------------------------
2186 Try route-refresh first then try to use stored cache
2187
21882001-01-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2189
2190 * bgp_nexthop.c (bgp_connected_add): Check point-to-point
2191 connected route. Reported by ruud@ruud.org (Ruud de Rooij)
2192
21932001-01-08 Kunihiro Ishiguro <kunihiro@zebra.org>
2194
2195 * bgp_nexthop.c (bgp_nexthop_lookup): When IBGP nexthop is
2196 changed, refresh it.
2197
21982001-01-04 Kunihiro Ishiguro <kunihiro@zebra.org>
2199
2200 * bgp_route.h (struct bgp_info_tag): Add as_selected to
2201 bgp_info_tag.
2202
22032001-01-03 Kunihiro Ishiguro <kunihiro@zebra.org>
2204
2205 * bgp_route.h (struct bgp_info_tag): Add damped and bgp_damp_info
2206 member for BGP flap dampening.
2207
2208 * bgp_damp.c: New file is added.
2209
2210 * bgp_damp.h: Likewise.
2211
22122001-01-01 Kunihiro Ishiguro <kunihiro@zebra.org>
2213
2214 * bgpd.h (BGP_VTYSH_PATH): Change "/tmp/bgpd" to "/tmp/.bgpd".
2215
22162000-12-29 Kunihiro Ishiguro <kunihiro@zebra.org>
2217
2218 * bgp_nexthop.c (zlookup_connect): Change to use UNIX domain
2219 socket for zebra communication.
2220
22212000-12-29 Akihiro Mizutani <mizutani@dml.com>
2222
2223 * bgp_route.c (bgp_process): Fix "bgp deterministic-med" process.
2224
22252000-12-27 Akihiro Mizutani <mizutani@dml.com>
2226
2227 * bgp_route.c (bgp_process): Add "bgp deterministic-med" process.
2228
22292000-12-25 Akihiro Mizutani <mizutani@dml.com>
2230
2231 * bgp_route.c (bgp_info_cmp): Use ntohl comparing router ID.
2232
22332000-12-18 Akihiro Mizutani <mizutani@dml.com>
2234
2235 * bgp_route.c (bgp_info_cmp): When over three same prefix exit,
2236 withdrawing best prefix perform router ID comparison.
2237
22382000-12-15 Akihiro Mizutani <mizutani@dml.com>
2239
2240 * bgp_route.c (bgp_info_cmp): Do not compare router ID when the
2241 routes comes from EBGP peer. When originator ID is same, take
2242 shorter cluster-list route. If cluster-list is same take smaller
2243 IP address neighbor's route.
2244
2245 * bgpd.c (bgp_bestpath_aspath_ignore): Add "bgp bestpath as-path
2246 ignore" command. When this option is set, do not concider AS path
2247 length when route selection.
2248 (bgp_bestpath_compare_router_id): Add "bgp bestpath
2249 compare-routerid". When this option is set, compare router ID
2250 when the routes comes from EBGP peer.
2251
22522000-12-15 Akihiro Mizutani <mizutani@dml.com>
2253
2254 * bgp_route.c (bgp_info_cmp): Compare originator ID when it is
2255 available.
2256
22572000-12-14 Akihiro Mizutani <mizutani@dml.com>
2258
2259 * bgp_packet.c (bgp_notify_receive): Disply received Notify data
2260 information.
2261
22622000-12-14 Kunihiro Ishiguro <kunihiro@zebra.org>
2263
2264 * bgp_filter.c (as_filter_free): Use MTYPE_AS_FILTER_STR to make
2265 it sure the memory is freed.
2266
2267 * bgp_route.c (route_vty_out_detail): Do not use AF_INET6 outside
2268 HAVE_IPV6.
2269
22702000-12-08 Akihiro Mizutani <mizutani@dml.com>
2271
2272 * bgp_packet.c (bgp_notify_send_with_data): Store BGP notification
2273 data part.
2274
2275 * bgp_network.c (bgp_accept): When BGP connection comes from
2276 unconfigured IP address, close socket immediately.
2277
2278 * bgpd.c: Fix some display format.
2279
22802000-11-29 Kunihiro Ishiguro <kunihiro@zebra.org>
2281
2282 * bgp_packet.c (bgp_keepalive_send): Delete duplicate
2283 bgp_packet_set_size () call.
2284
22852000-11-28 Kunihiro Ishiguro <kunihiro@zebra.org>
2286
2287 * bgp_packet.c (bgp_read_packet): Remove debug codes.
2288
22892000-11-27 Kunihiro Ishiguro <kunihiro@zebra.org>
2290
2291 * bgp_snmp.c (write_bgpPeerTable): Add SNMP set method routine.
2292
2293 * bgp_fsm.c (bgp_stop): Use fsm_change_status to change peer's
2294 status.
2295 (bgp_establish): Likewise.
2296
22972000-11-26 Akihiro Mizutani <mizutani@dml.com>
2298
2299 * bgp_open.c: Fix error messages.
2300
23012000-11-25 Kunihiro Ishiguro <kunihiro@zebra.org>
2302
2303 * bgp_fsm.c (bgp_establish): Call BGP trap when the peer is
2304 established.
2305 (bgp_stop): Call BGP trap when the peer is dropped.
2306
23072000-11-24 Kunihiro Ishiguro <kunihiro@zebra.org>
2308
2309 * bgp_snmp.c (bgp4PathAttrTable): Return BGP path attribute table.
2310
2311 * bgpd.h (struct peer): Add update_time for track last update
2312 received time.
2313
2314 * bgp_packet.c (bgp_notify_receive): Preserv notify code and sub
2315 code in any case.
2316
2317 * bgp_snmp.c (bgpPeerTable): Return remote router ID instead of
2318 peering IP address.
2319 (bgpPeerTable): Return actual BGP version number.
2320
23212000-11-22 Akihiro Mizutani <mizutani@dml.com>
2322
2323 * bgp_debug.c (bgp_notify_print): Notify data length display bug
2324 is fixed.
2325
23262000-11-16 Kunihiro Ishiguro <kunihiro@zebra.org>
2327
2328 * bgp_nexthop.c (zlookup_connect): When UNIX domain connection to
2329 zebra is enabled, use the method.
2330
23312000-11-16 Akihiro Mizutani <mizutani@dml.com>
2332
2333 * bgpd.c: Revise debug message output.
2334
23352000-11-15 Akihiro Mizutani <mizutani@dml.com>
2336
2337 * bgp_clist.c (ip_community_list): Fix bug of string comparison.
2338
23392000-11-14 Akihiro Mizutani <mizutani@dml.com>
2340
2341 * bgp_community.c (community_match): Fix bug of memcmp return
2342 value check.
2343
23442000-11-07 Kunihiro Ishiguro <kunihiro@zebra.org>
2345
2346 * bgp_clist.c (community_list_match_exact): Add check for
2347 entry->style is COMMUNITY_LIST.
2348 (community_match_regexp): Apply new com_nthval macro.
2349
23502000-11-07 Rick Payne <rickp@rossfell.co.uk>
2351
2352 * bgp_routemap.c (route_set_community_delete): "set
2353 community-delete COMMUNITY-LIST" is added.
2354
2355 * bgp_community.c (community_del_val): Delete one community.
2356 (community_delete): Delete all community included in list.
2357 (community_match): Fix bug of matching community value.
2358
2359 * bgp_clist.c (community_entry_free): Free community regular
2360 expression.
2361 (community_entry_make): Default style is COMMUNITY_LIST.
2362 (community_entry_lookup): Make it sure style is COMMUNITY_LIST.
2363 (community_entry_regexp_lookup): New function for community
2364 regular expression lookup.
2365 (community_match_regexp): New function.
2366 (community_delete_regexp): New function.
2367 (community_list_delete_entries): New function.
2368 (community_list_match): Add COMMUNITY_REGEXP treatment.
2369 (community_list_match_exact): Likewise.
2370 (config_write_community): Write community list according to
2371 entry->style.
2372
23732000-11-07 Rick Payne <rickp@rossfell.co.uk>
2374
2375 * bgp_attr.c (bgp_attr_aspath): AS path first AS check.
2376
2377 * bgp_clist.c (struct community_entry): Add style, regexp, reg to
2378 community_entry.
2379
23802000-11-06 Rick Payne <rickp@rossfell.co.uk>
2381
2382 * bgp_aspath.c (aspath_firstas_check): AS path first AS check.
2383
2384 * bgpd.c (bgp_enforce_first_as): New command "bgp
2385 enforce-first-as".
2386
2387 * bgpd.h (BGP_CONFIG_ENFORCE_FIRST_AS): Add new flag.
2388
23892000-11-06 Kunihiro Ishiguro <kunihiro@zebra.org>
2390
2391 * bgp_community.c (community_compare): Copy byte stream data to
2392 actual value instead of using type casting hack.
2393 (community_add_val): Likewise.
2394 (community_uniq_sort): Likewise.
2395 (community_print): Likewise.
2396 (community_print_vty): Likewise.
2397 (community_include): Use memcmp to compare community value.
2398
2399 * bgp_community.h (com_lastval): com_lastval and com_nthval macro
2400 return pointer.
2401
24022000-11-06 Akihiro Mizutani <mizutani@dml.com>
2403
2404 * bgpd.h (struct peer): Add established and dropped member for
2405 count peering up/down statistics.
2406
2407 * bgpd.c (bgp_show_peer): Display peering up/down statistics.
2408
2409 * bgp_fsm.c (bgp_establish): Increment established count.
2410 (bgp_stop): Increment dropped count.
2411
2412 * bgp_packet.c (bgp_notify_receive): Increament notify count.
2413
24142000-11-1 Akihiro Mizutani <mizutani@dml.com>
2415
2416 * bgp_fsm.c: Fix bug of holdtimer is not reset when bgp cleared.
2417
24182000-10-31 Kunihiro Ishiguro <kunihiro@zebra.org>
2419
2420 * bgpd.h: Static bit flag is set by (1 << DIGIT).
2421
24222000-10-24 Akihiro Mizutani <mizutani@dml.com>
2423
2424 * bgp_ecommunity.c (ecommunity_dup): Extended community display
2425 format fix.
2426
24272000-10-24 Arkadiusz Miskiewicz <misiek@pld.org.pl>
2428
2429 * bgp_network.c (bgp_serv_sock_addrinfo): Use gai_strerror.
2430 (bgp_serv_sock_addrinfo): Check address family.
2431
24322000-10-23 Jochen Friedrich <jochen@scram.de>
2433
2434 * bgp_snmp.c: bgp_oid and bgpd_oid are used in smux_open after it
2435 is registered. So those variables must be static.
2436
24372000-10-23 Akihiro Mizutani <mizutani@dml.com>
2438
2439 * bgp_routemap.c (route_match_ip_next_hop): Change "match ip
2440 next-hop" argument from IP address to access-list name.
2441 Remove zebra-0.88 compatibility commands.
2442 "match ip prefix-list WORD"
2443 "match ipv6 prefix-list WORD"
2444
24452000-10-23 Kunihiro Ishiguro <kunihiro@zebra.org>
2446
2447 * bgp_routemap.c (route_match_ipv6_next_hop_compile): Fix bug of
2448 passing the pointer to the pointer of struct in6_addr instead of
2449 the pointer of struct in6_addr in "match ipv6 next-hop" command.
2450
2451 * bgp_route.c (bgp_announce_check): Enclose IPv6 part with
2452 HAVE_IPV6.
2453
24542000-10-20 Jasper Wallace <jasper@ivision.co.uk>
2455
2456 * bgp_snmp.c (bgpPeerTable): ntohs missing bug is fixed. Change
2457 to use linklist.c. Define COUNTER32 as ASN_COUNTER.
2458
24592000-10-18 Kunihiro Ishiguro <kunihiro@zebra.org>
2460
2461 * bgp_route.c (bgp_announce_check): attr->nexthop empty check
2462 should be done by attr->nexthop.s_addr instead of strcmp.
2463
24642000-10-18 Akihiro Mizutani <mizutani@dml.com>
2465
2466 * bgp_zebra.c (zebra_read_ipv4): Pass nexthop value to
2467 bgp_redistribute_add().
2468
2469 * bgp_nexthop.c (bgp_multiaccess_check_v4): New function for
2470 checking IPv4 multiaccess nexthop.
2471
2472 * bgp_route.c (bgp_announce_check): In case of the nexthop is
2473 reachable on multiaccess media, do not change nexthop.
2474 (bgp_redistribute_add): Set nexthop when the value is passed.
2475
24762000-10-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2477
2478 * bgp_fsm.c (bgp_timer_set): If peer is passive mode, do not set
2479 connect timer.
2480 (bgp_start): If the peer is passive mode, force to move to Active
2481 mode.
2482
24832000-10-17 Horms <horms@vergenet.net>
2484
2485 * bgp_debug.c (debug_bgp_fsm): Fix typo.
2486
24872000-10-17 Akihiro Mizutani <mizutani@dml.com>
2488
2489 * bgp_route.c: "show ipv6 bgp" route display improvement.
2490
24912000-10-03 Kunihiro Ishiguro <kunihiro@zebra.org>
2492
2493 * bgp_route.c (neighbor_routes): Allocate sockunion for callback
2494 function.
2495 (bgp_show_neighbor_route): Remove static declaration for union
2496 sockunion.
2497
2498 * bgpd.c (peer_update_source_set): Clean previously allocated
2499 memory before allocate new one.
2500
25012000-10-03 Akihiro Mizutani <mizutani@dml.com>
2502
2503 * bgp_route.c (neighbor_routes): Add show neighbor's routes
2504 command.
2505 "show ip bgp neighbors (A.B.C.D|X:X::X:X) routes"
2506 "show ip bgp ipv4 (unicast|multicast) neighbors (A.B.C.D|X:X::X:X) routes"
2507 "show ipv6 bgp neighbors (A.B.C.D|X:X::X:X) routes"
2508 "show ipv6 mbgp neighbors (A.B.C.D|X:X::X:X) routes"
2509
25102000-10-02 Kunihiro Ishiguro <kunihiro@zebra.org>
2511
2512 * zebra-0.89 is released.
2513
25142000-10-02 Akihiro Mizutani <mizutani@dml.com>
2515
2516 * bgpd.c: "bgp deterministic-med" command is added.
2517
25182000-10-02 Kunihiro Ishiguro <kunihiro@zebra.org>
2519
2520 * bgp_nexthop.c (bgp_connected_add): Apply mask for connected
2521 route addition and deletion.
2522
25232000-09-29 Kunihiro Ishiguro <kunihiro@zebra.org>
2524
2525 * bgp_aspath.c (aspath_cmp_left): Skip confederation AS segment
2526 when comparing leftmost AS number.
2527
25282000-09-29 Akihiro Mizutani <mizutani@dml.com>
2529
2530 * bgpd.c (peer_route_reflector): Route reflector can be set for
2531 IBGP peer.
2532 (bgp_distribute_set): Fix bug of string check for (in|out).
2533 (bgp_show_summary): Display total neighbor count.
2534
25352000-09-28 Akihiro Mizutani <mizutani@dml.com>
2536
2537 * bgp_attr.c (bgp_packet_attribute): Only add cluster_list and
2538 originator for clinet to client routes.
2539 (bgp_packet_attribute): Add new cluster_list to the beginning of
2540 existing cluster_list.
2541 (bgp_packet_attribute): Fix bug of originator is rewritten even
2542 when originator is already set.
2543
25442000-09-27 Kunihiro Ishiguro <kunihiro@zebra.org>
2545
2546 * bgpd.c (bgp_client_to_client_reflection): Add new command.
2547 "no bgp client-to-client reflection"
2548 "bgp client-to-client reflection"
2549
2550 * bgpd.h (BGP_CONFIG_NO_CLIENT_TO_CLIENT): Add new definition.
2551
25522000-09-26 Kunihiro Ishiguro <kunihiro@zebra.org>
2553
2554 * bgp_packet.c (bgp_read): Make BGP packet read to non-blocking
2555 read.
2556 (bgp_read_packet): Likewise.
2557 (bgp_read_packet): When errono is EAGAIN, try to read it again.
2558
2559 * bgp_fsm.c (bgp_stop): Clear packet size and read buffer.
2560
25612000-09-26 Akihiro Mizutani <mizutani@dml.com>
2562
2563 * bgp_routemap.c: Configuration of prefix-list match is shown as
2564 "match ip address prefix-list <WORD>". Old configuration "match
2565 ip prefix-list <WORD>" is left for compatibilitty.
2566
25672000-09-25 Akihiro Mizutani <mizutani@dml.com>
2568
2569 * bgpd.h (BGP_CONFIG_MED_MISSING_AS_WORST): Changed from
2570 BGP_CONFIG_MISSING_AS_WORST.
2571
2572 * bgpd.c (bgp_bestpath_med): Change missing-as-worst syntax.
2573 Old "bgp bestpath missing-as-worst"
2574 New "bgp bestpath med missing-as-worst"
2575
25762000-09-24 Akihiro Mizutani <mizutani@dml.com>
2577
2578 * bgp_route.c: Compare MED properly in case of CONFED-IBGP.
2579
25802000-09-21 steve@Watt.COM (Steve Watt)
2581
2582 * bgp_debug.h: Do not declare debug variables conf_bgp_debug_* and
2583 term_bgp_debug_*.
2584
2585 * bgp_debug.c: Declare variables here.
2586
25872000-09-21 Akihiro Mizutani <mizutani@dml.com>
2588
2589 * bgpd.c: MBGP soft-reconfiguration command is added.
2590 clear ip bgp x.x.x.x ipv4 (unicast|multicast) in
2591 clear ip bgp x.x.x.x ipv4 (unicast|multicast) out
2592 clear ip bgp x.x.x.x ipv4 (unicast|multicast) soft
2593 clear ip bgp <1-65535> ipv4 (unicast|multicast) in
2594 clear ip bgp <1-65535> ipv4 (unicast|multicast) out
2595 clear ip bgp <1-65535> ipv4 (unicast|multicast) soft
2596 clear ip bgp * ipv4 (unicast|multicast) in
2597 clear ip bgp * ipv4 (unicast|multicast) out
2598 clear ip bgp * ipv4 (unicast|multicast) soft
2599
2600 Change "clear ip bgp vpnv4 x.x.x.x soft" command to
2601 "clear ip bgp x.x.x.x vpnv4 unicast soft".
2602
2603 "bgp bestpath med confed" command is added.
2604
2605 * bgpd.h (BGP_CONFIG_MED_CONFED): Add New definition.
2606
26072000-09-18 Rick Payne <rickp@rossfell.co.uk>
2608
2609 * bgpd.c (bgp_show_peer): Fix misplaced #endif.
2610
26112000-09-12 Akihiro Mizutani <mizutani@dml.com>
2612
2613 * bgpd.c (bgp_default_local_preference): Add "bgp default
2614 local-preference" command.
2615
2616 * bgp_nexthop.c (no_bgp_scan_time): Add "no bgp scan-time"
2617 command.
2618
26192000-09-10 Kunihiro Ishiguro <kunihiro@zebra.org>
2620
2621 * bgp_zebra.c (bgp_zebra_announce): BGP confederation peer's routes
2622 are passed to zebra like IBGP route.
2623
26242000-09-10 Akihiro Mizutani <mizutani@dml.com>
2625
2626 * bgpd.c (bgp_config_write_peer): Make it consistent passive
2627 configuration.
2628
2629 * bgp_route.c: Community match command is added.
2630 "show ip bgp community <val>"
2631 "show ip bgp community <val> exact-match"
2632
26332000-09-08 Kunihiro Ishiguro <kunihiro@zebra.org>
2634
2635 * bgp_nexthop.c (bgp_nexthop_lookup): ebgp-multihop routes are
2636 treated as IBGP routes.
2637
26382000-09-08 Akihiro Mizutani <mizutani@dml.com>
2639
2640 * bgp_route.c (bgp_show_route): When local-AS community route is
2641 selected, display "not advertised outside local AS" to "show ip
2642 route A.B.C.D" output.
2643 (show_ip_bgp_ipv4_filter_list): Add below four commands.
2644 "show ip bgp ipv4 (unicast|multicast) filter-list WORD"
2645 "show ip bgp ipv4 (unicast|multicast) community"
2646 "show ip bgp ipv4 (unicast|multicast) community-list WORD"
2647 "show ip bgp ipv4 (unicast|multicast) community-list WORD exact-match"
2648
2649 * bgp_clist.c (community_list_match_exact): Community exact match
2650 function.
2651
26522000-09-07 Kunihiro Ishiguro <kunihiro@zebra.org>
2653
2654 * bgp_route.c (bgp_update): Add peer's ttl check.
2655
2656 * bgpd.h (struct peer): Structure member refresh is renamed to
2657 refresh_adv.
2658
2659 * bgpd.c (clear_bgp_soft_in): Check PEER_FLAG_ROUTE_REFRESH flag
2660 when soft reconfiguration is performed.
2661
2662 * bgp_zebra.c (bgp_zebra_announce): When the peer is EBGP and
2663 ebgp-multiphop is set, set ZEBRA_FLAG_INTERNAL for nexthop lookup.
2664
2665 * bgp_route.h (struct bgp_info_tag): Add valid flag.
2666
26672000-08-25 Akihiro Mizutani <mizutani@dml.com>
2668
2669 * bgpd.c: Add AS base BGP soft reconfiguration.
2670
2671 * bgp_route.c: When no-advertise or no-export route is selected,
2672 "show ip bgp" display "not advertised to EBGP peer" or "not
2673 advertised to any peer" message.
2674
26752000-08-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2676
2677 * zebra-0.88 is released.
2678
2679 * bgp_dump.c (dump_bgp_routes): Change "dump bgp routes" to "dump
2680 bgp route-mrt" to support MRT specific dump format.
2681
2682 * bgpd.c (bgp_init): "clear ip bgp vpnv4 soft {in,out}" command is
2683 added.
2684
2685 * bgp_route.c (bgp_update): Currently nexthop check is only works
2686 for IPv4.
2687
26882000-08-17 Akihiro Mizutani <mizutani@dml.com>
2689
2690 * bgpd. (clear_ip_bgp_all_soft): Add "clear ip bgp * soft" for
2691 both inbound and outbound soft reconfiguration.
2692
26932000-08-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2694
2695 * bgpd.c (clear_ip_bgp_peer_soft_out): Add soft-reconfiguration
2696 outbound.
2697 (peer_new): Set route-refresh flag.
2698
26992000-08-16 Akihiro Mizutani <mizutani@dml.com>
2700
2701 * bgpd.c: "no bgp router-id A.B.C.D" alias is added. "no bgp
2702 cluster-id A.B.C.D" alias is added. " bgp cluster-id
2703 <1-4294967295>" alias is added. "clear ip bgp * soft in" command
2704 is added. "clear ip bgp A.B.C.D in" alias is added. "clear ip
2705 bgp * in" alias is added.
2706
27072000-08-16 Kunihiro Ishiguro <kunihiro@zebra.org>
2708
2709 * bgp_route.c (bgp_update): Add soft_reconfig flag. When the flag
2710 is set do not install the route into Adj-RIBs-In.
2711 (bgp_update): Perform implicit withdraw before filtering of the
2712 route.
2713
2714 * bgp_packet.c (bgp_read): draft-ietf-idr-bgp-route-refresh-01.txt
2715 capability code and BGP message can be accepted.
2716
2717 * bgp_open.c (bgp_capability_parse): Likewise.
2718
2719 * bgp_route.c (bgp_refresh_table): New function for route refresh.
2720 (bgp_refresh_rib): Likewise.
2721
2722 * bgpd.c (bgp_show_peer): Display route refresh status.
2723
2724 * bgp_route.c (bgp_aggregate_add): Add check for the route
2725 validness.
2726 (bgp_aggregate_delete): Likewise.
2727
27282000-08-15 Kunihiro Ishiguro <kunihiro@zebra.org>
2729
2730 * bgp_nexthop.c (bgp_scan): Care for aggregate route when the
2731 route become inaccessible.
2732
27332000-08-15 Akihiro Mizutani <mizutani@dml.com>
2734
2735 * bgp_route.c (show_ip_bgp_prefix): "show ip bgp A.B.C.D/M"
2736 command is added.
2737
27382000-08-15 Kunihiro Ishiguro <kunihiro@zebra.org>
2739
2740 * bgp_zebra.c (bgp_interface_up): Register connected route.
2741 (bgp_interface_down): Unregister connected route.
2742
27432000-08-14 Kunihiro Ishiguro <kunihiro@zebra.org>
2744
2745 * bgp_route.h (struct bgp_info): Add distance to the structure.
2746
2747 * bgp_route.c (bgp_aggregate_increment): Aggregate route only
2748 match to smaller prefixlen route not match same prefixlen route.
2749 (bgp_aggregate_decrement): Likewise.
2750 (bgp_aggregate_add): Likewise.
2751 (bgp_aggregate_delete): Likewise.
2752 (bgp_network_backdoor): Add backdoor network configuration.
2753
2754 * bgpd.h (struct bgp ): Add distance_{ebgp,ibgp,local} for store
2755 configuration distance value.
2756
2757 * bgp_route.c (bgp_update): Filter EBGP route which has non
2758 connected nexthop.
2759
2760 * bgp_attr.c (bgp_attr_aggregate_intern): New function for
2761 aggregate route. Set origin to IGP. Set atomic aggregate flag.
2762 Set aggregator AS and address.
2763 (bgp_attr_aggregate_intern): Check BGP_CONFIG_CONFEDERATION when
2764 filling aggregator_as.
2765
2766 * bgp_route.c (bgp_process): Delete suppress check for install
2767 suppressed route into local routing table.
2768 (bgp_aggregate_increment): Use bgp_attr_aggregate_intern() instead
2769 of bgp_attr_default_intern ().
2770 (bgp_aggregate_add): Likewise.
2771
2772 * bgpd.c (bgp_get): Call bgp_if_update_all() after BGP instance is
2773 created. This is for avoid 0.0.0.0 router-id.
2774
27752000-08-13 Akihiro Mizutani <mizutani@dml.com>
2776
2777 * bgp_route.c (route_vty_out_detail): Display "valid" when the
2778 route is valied. Display "aggregated" when the route is
2779 aggregated. "Advertisements suppressed by an aggregate" is
2780 displayed when the route is suppressed.
2781 (bgp_info_cmp): Prefer EBGP than Confed-EBGP.
2782
27832000-08-10 Akihiro Mizutani <mizutani@dml.com>
2784
2785 * bgp_route.c (route_vty_out_detail): Display format change.
2786
27872000-08-06 Kunihiro Ishiguro <kunihiro@zebra.org>
2788
2789 * bgp_route.c (bgp_update): Only AFI_IP nexthop check is enabled.
2790
2791 * bgpd.c (bgp_delete): Delete static route before delete peer
2792 configuration.
2793
27942000-08-02 Kunihiro Ishiguro <kunihiro@zebra.org>
2795
2796 * bgpd.c: Include bgpd/bgp_nexthop.h.
2797
27982000-07-31 Akihiro Mizutani <mizutani@dml.com>
2799
2800 * bgpd.c (bgp_show_summary): "show ip bgp summary" shows own BGP
2801 identifier. And status is changed like below.
2802
2803 State/Pref -> State/PfxRcd
2804 Shutdown -> Idle (Admin)
2805 PrefixOvflw -> Idle (PfxCt)
2806
2807 * bgp_route.c (route_vty_out): Show internal route as "i".
2808
28092000-07-13 Jim Bowen <jimb@zereau.net>
2810
2811 * bgp_snmp.c: Add BGP peer MIB implementation.
2812
28132000-07-12 Akihiro Mizutani <mizutani@dml.com>
2814
2815 * bgpd.c (bgp_show_peer): Fix typo.
2816
28172000-07-11 Akihiro Mizutani <mizutani@dml.com>
2818
2819 * bgp_routemap.c: Add commands for deleting set without argument.
2820
28212000-07-03 Akihiro Mizutani <mizutani@dml.com>
2822
2823 * bgp_zebra.c: Fix redistribute help strings.
2824
28252000-07-01 Kunihiro Ishiguro <kunihiro@zebra.org>
2826
2827 * bgp_route.c (bgp_show): When bgpd works as vtysh server send all
2828 output to vty at once.
2829
28302000-06-13 Kunihiro Ishiguro <kunihiro@zebra.org>
2831
2832 * bgp_mplsvpn.c (no_vpnv4_network): "no network A.B.C.D/M rd WORD
2833 tag WORD" command is added.
2834
2835 * bgp_ecommunity.c (ecommunity_vty_out): New function added.
2836
28372000-06-12 Kunihiro Ishiguro <kunihiro@zebra.org>
2838
2839 * bgp_route.c (bgp_show): Fix total number of prefix count bug.
2840
2841 * bgpd.c (bgp_show_peer): Display VPNv4 unicast configuration and
2842 negotiation result in "show ip bgp neighbors".
2843
28442000-06-12 Akihiro Mizutani <mizutani@dml.com>
2845
2846 * bgpd.c: Fix help strings.
2847
2848 * bgpd.h: Likewise.
2849
28502000-06-11 Kunihiro Ishiguro <kunihiro@zebra.org>
2851
2852 * bgp_route.c (bgp_aggregate_unset): Fix bug of checking rn->info
2853 instead of rn. Reported by Akihiro Mizutani <mizutani@dml.com>.
2854
2855 * bgp_mplsvpn.c (vpnv4_network): For testing purpose, "network
2856 A.B.C.D rd RD" is added to address-family vpnv4 unicast node.
2857
2858 * bgp_route.c (bgp_static_set): Set safi to p.safi.
2859
28602000-06-10 Kunihiro Ishiguro <kunihiro@zebra.org>
2861
2862 * bgp_route.c (bgp_show_prefix_list): Change to use bgp_show().
2863 (bgp_show_regexp): Change to use bgp_show().
2864 (show_adj_route): Change to display header.
2865
2866 * bgpd.c (clear_bgp): Set peer->v_start to default value when peer
2867 is cleared manually.
2868
2869 * bgp_route.c (bgp_show_route): New function which display
2870 specific BGP route. Divided from bgp_show().
2871 (bgp_static_delete): Delete all static route.
2872
28732000-06-09 NOGUCHI Kay <kay@v6.access.co.jp>
2874
2875 * bgp_route.c (show_ipv6_bgp): "show ipv6 bgp" is broken with
2876 invalid privious fix. Now show_ipv6_bgp and show_ipv6_bgp_route
2877 take care of "show ipv6 bgp [X:X::X:X]". Same change for "show ip
2878 mbgp" and "show ipv6 mbgp".
2879
28802000-06-07 Akihiro Mizutani <mizutani@dml.com>
2881
2882 * bgp_route.c: Fix help strings and command arguments.
2883
28842000-06-06 Kunihiro Ishiguro <kunihiro@zebra.org>
2885
2886 * bgp_ecommunity.c: Include prefix.h
2887
28882000-06-05 Kunihiro Ishiguro <kunihiro@zebra.org>
2889
2890 * bgp_route.h (struct bgp_info_tag): New structure to hold tag
2891 value.
2892
2893 * bgp_route.c (bgp_adj_set): table NULL check is added.
2894 (bgp_adj_unset): Likewise.
2895 (bgp_adj_lookup): Likewise.
2896 (bgp_adj_clear): Likewise.
2897 (route_vty_out): Add SAFI check for nexthop display.
2898 (bgp_withdraw): Add SAFI check for withdraw route.
2899
2900 * Remove all #ifdef MPLS_VPN then include it as default.
2901
2902 * bgpd.c: Temporary disable peer-group command until the
2903 implementation is completed.
2904
2905 * bgp_routemap.c (bgp_route_map_init): Install
2906 route_metric_match_cmd.
2907 (route_match_metric_compile): MED value compile using strtoul.
2908
29092000-06-05 Akihiro Mizutani <mizutani@dml.com>
2910
2911 * bgp_filter.c: Fix help strings. Change REGEXP to LINE. Change
2912 NAME to WORD.
2913
2914 * Change command argument to more comprehensive.
2915
2916 METRIC -> <0-4294967295>
2917 WEIGHT -> <0-4294967295>
2918 LOCAL_PREF -> <0-4294967295>
2919 IP_ADDR -> A.B.C.D
2920 AS -> <1-65535>
2921 AS-PATH-NAME -> WORD
2922 ACCESS_LIST -> WORD
2923 PREFIX_LIST -> WORD
2924 COMMUNITY -> AA:NN
2925 EXT_COMMUNITY -> ASN:nn_or_IP-address:nn
2926 IPv6_ADDR -> X:X::X:X
2927
2928 * bgp_clist.c: Fix help strings.
2929
29302000-06-03 Kunihiro Ishiguro <kunihiro@zebra.org>
2931
2932 * bgpd.c (peer_active): Add new function for check the peer is
2933 active or not.
2934 (neighbor_activate): New command "neighbor PEER activate" and "no
2935 neighbor PEER activate" are added.
2936
2937 * bgp_packet.c: Include bgpd/bgp_mplsvpn.h.
2938
29392000-06-02 Akihiro Mizutani <mizutani@dml.com>
2940
2941 * bgp_clist.c: Fix commuity-list help strings.
2942
2943 * bgp_routemap.c: Fix "set community" help strings. Add #define
2944 SET_STR. Use (unicast|multicast) argument for "set nlri" command.
2945
29462000-06-01 Kunihiro Ishiguro <kunihiro@zebra.org>
2947
2948 * bgp_routemap.c (route_set_community_none_cmd): "set community
2949 none" command is added to route-map.
2950
29512000-06-01 Akihiro Mizutani <mizutani@dml.com>
2952
2953 * bgp_debug.c: Change "show debug" to "show debugging". Now "show
2954 debugging" is not used in VIEW_NODE.
2955
29562000-05-30 Kunihiro Ishiguro <kunihiro@zebra.org>
2957
2958 * bgp_fsm.c (bgp_timer_set): Add check for shutdown flag. This
2959 fix unconditional BGP connection.
2960
2961 * bgpd.c (peer_shutdown): Replace peer_shutdown() with
2962 peer_change_flag_with_reset().
2963
29642000-05-26 Kunihiro Ishiguro <kunihiro@zebra.org>
2965
2966 * bgpd.c (no_bgp_default_ipv4_unicast): Add "no bgp default
2967 ipv4-unicast" command.
2968
2969 * bgpd.h (BGP_CONFIG_NO_DEFAULT_IPV4): Add new definition.
2970
2971 * bgp_filter.c (as_list_delete): Free all AS filter.
2972
2973 * bgp_clist.c (community_list_delete): Free all community entry.
2974
2975 * bgp_filter.c (no_ip_as_path_all): New DEFUN for "no ip as-path
2976 access-list NAME".
2977
2978 * bgp_clist.c (no_ip_community_list_all): New DEFUN for "no ip
2979 community-list NAME".
2980
29812000-05-19 Kunihiro Ishiguro <kunihiro@zebra.org>
2982
2983 * bgp_route.c (ipv6_mbgp_neighbor_routes): Change "show ip bgp PEER
2984 routes" to "show ip bgp PEER received-routes"
2985
29862000-05-14 Kunihiro Ishiguro <kunihiro@zebra.org>
2987
2988 * bgp_ecommunity.c (ecommunity_parse): New file for Extended
2989 Communities attribute.
2990 * bgp_ecommunity.h: Likewise.
2991
29922000-05-11 Kunihiro Ishiguro <kunihiro@zebra.org>
2993
2994 * bgp_mplsvpn.h: New file for MPLS-VPN.
2995 * bgp_mplsvpn.c: Likewise.
2996
2997 * bgpd.c (bgp_delete): Fix bug of "no router bgp" crush.
2998
29992000-05-10 Kunihiro Ishiguro <kunihiro@zebra.org>
3000
3001 * bgpd.c (bgp_bestpath_missing_as_worst): Add "bgp bestpath
3002 missing-as-worst".
3003
30042000-05-08 Kunihiro Ishiguro <kunihiro@zebra.org>
3005
3006 * bgp_routemap.c (match_community): Clarify help of "match
3007 community".
3008
30092000-05-02 Kunihiro Ishiguro <kunihiro@zebra.org>
3010
3011 * bgp_aspath.c (aspath_cmp_left): Remove debug code.
3012
30132000-04-27 Kunihiro Ishiguro <kunihiro@zebra.org>
3014
3015 * bgp_route.c (bgp_info_cmp): Compare MED only both routes comes
3016 from same neighboring AS.
3017
3018 * bgp_aspath.c (aspath_cmp_left): Compare leftmost AS value.
3019
3020 * bgp_route.c (bgp_info_cmp): Fix misused htonl() to ntohl().
3021
30222000-04-26 Kunihiro Ishiguro <kunihiro@zebra.org>
3023
3024 * bgp_route.c (bgp_output_filter): When distribute-list's
3025 corresponding access-list does not exist, filter all routes.
3026 (bgp_input_filter): Likewise.
3027
30282000-04-19 Kunihiro Ishiguro <kunihiro@zebra.org>
3029
3030 * bgp_attr.c (bgp_packet_attribute): Propagate MED to IBGP peer.
3031
3032 * bgp_route.c (bgp_info_cmp): Add evaluation of local preference.
3033
30342000-04-18 Kunihiro Ishiguro <kunihiro@zebra.org>
3035
3036 * bgpd.c (bgp_distribute_update): Add struct access_list *
3037 argument.
3038
30392000-04-17 Kunihiro Ishiguro <kunihiro@zebra.org>
3040
3041 * bgp_clist.c (community_list_dup_check): Add duplicate insertion
3042 check.
3043
3044 * bgp_filter.c (as_list_dup_check): Add duplicate insertion check.
3045
3046 * bgp_route.c (bgp_show): Fix undeclared write variable.
3047
30482000-04-13 Kunihiro Ishiguro <kunihiro@zebra.org>
3049
3050 * bgp_routemap.c: Add "match ip address prefix-list".
3051
30522000-03-29 Rick Payne <rickp@rossfell.co.uk>
3053
3054 * bgp_aspath.c (aspath_strip_confed): Fix realloc problem.
3055
30562000-03-16 Kunihiro Ishiguro <kunihiro@zebra.org>
3057
3058 * bgp_fsm.c (bgp_reconnect): Connect retry timer is expired when
3059 the peer status is Connect.
3060
30612000-03-03 Kunihiro Ishiguro <kunihiro@zebra.org>
3062
3063 * Fix bug of rewritten originator-id.
3064
30652000-01-27 Rick Payne <rickp@rossfell.co.uk>
3066
3067 * bgp_aspath.c (aspath_delimiter_char): New function. Instead of
3068 directly referencing array, search proper AS path delimiter.
3069 (aspath_strip_confed): Strip the confederation stuff from the
3070 front of an AS path.
3071 (aspath_add_left_confed): New function for adding specified AS to
3072 the leftmost AS_CONFED_SEQUENCE.
3073
3074 * bgp_aspath.h: Change AS_CONFED_SEQUENCE and AS_CONFED_SET value
3075 to Cisco compatible.
3076
3077 * bgpd.c (bgp_confederation_id_set): Confederation configuration.
3078 (bgp_confederation_id_unset): Likewise.
3079 (bgp_confederation_peers_check): Likewise.
3080 (bgp_confederation_peers_add): Likewise.
3081 (bgp_confederation_peers_remove): Likewise.
3082 (bgp_confederation_peers_set): Likewise.
3083 (bgp_confederation_peers_unset): Likewise.
3084 (bgp_confederation_peers_print): Likewise.
3085
30862000-01-16 Kunihiro Ishiguro <kunihiro@zebra.org>
3087
3088 * bgpd.c: Introduce peer_change_flag_with_reset() fucntion.
3089
30902000-01-17 Kunihiro Ishiguro <kunihiro@zebra.org>
3091
3092 * bgp_open.c (bgp_open_option_parse): When there is no common
3093 capability send Unsupported Capability error to the peer.
3094
30952000-01-14 Kunihiro Ishiguro <kunihiro@zebra.org>
3096
3097 * bgp_open.c (bgp_capability_mp): Fix bug of mis-negotiation about
3098 IPv6 unicast.
3099
3100 * bgpd.c (bgp_init): Add "soft-reconfiguration inbound" command.
3101
31022000-01-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3103
3104 * bgpd.c (neighbor_strict_capability): Add
3105 "strict-capability-match" command.
3106
3107 * bgp_zebra.c (bgp_if_update): Ignore NET127 determining
3108 router-id.
3109
3110 * bgpd.c (peer_override_capability): Add "override-capability"
3111 command.
3112
31131999-12-16 Kunihiro Ishiguro <kunihiro@zebra.org>
3114
3115 * bgp_packet.c (bgp_write): Change status to Idle and set timer
3116 after write failed.
3117
31181999-12-14 Kunihiro Ishiguro <kunihiro@zebra.org>
3119
3120 * bgp_zebra.c (bgp_zebra_announce): Add info->selected check.
3121
31221999-12-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3123
3124 * bgp_route.c (nlri_unfeasible): nlri_unfeasible() is merged with
3125 nlri_parse().
3126
31271999-12-10 Kunihiro Ishiguro <kunihiro@zebra.org>
3128
3129 * bgp_fsm.h (BGP_EVENT_DELETE): Macro added.
3130
3131 * bgp_fsm.c (bgp_stop): Clear all event threads of the peer when
3132 the peer is cleared.
3133
3134 * bgp_zebra.c (bgp_nexthop_set): Clear interface index of
3135 link-local address. This is KAME specific problem.
3136
31371999-12-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3138
3139 * bgp_attr.c (bgp_mp_reach_parse): Comment out previous code for a
3140 while. We don't completely detect the link is shared or not at
3141 this moment.
3142
3143 * bgp_packet.c (bgp_notify_send): Make shortcut call of
3144 bgp_write() and bgp_stop().
3145
3146 * bgp_attr.c (bgp_mp_reach_parse): Fix serious bug when getting
3147 global and link-local address.
3148
31491999-12-05 Kunihiro Ishiguro <kunihiro@zebra.org>
3150
3151 * bgpd.c (no_neighbor_port): New command added.
3152 (peer_new): Set send_community.
3153
31541999-12-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3155
3156 * bgpd.c (show_ip_bgp_summary): Changed to use bgp_show_summary().
3157 (show_ip_mbgp_summary): Likewise.
3158 (show_ipv6_bgp_summary): Likewise.
3159 (show_ipv6_mbgp_summary): Add new command.
3160 (peer_free): Free peer->host.
3161 (peer_lookup_by_su): Delete function.
3162 (ipv6_bgp_neighbor): Changed to use peer_remote_as().
3163 (sockunion_vty_out): Function deleted.
3164 (vty_clear_bgp): Use afi instead of family.
3165 Delete old list bgp_list. Use struct newlist *bgplist.
3166 (peer_lookup_by_host): Function deleted.
3167
31681999-12-03 Kunihiro Ishiguro <kunihiro@zebra.org>
3169
3170 * bgpd.h (struct peer_group): New structure added.
3171 (struct peer_conf): New structure added.
3172 (struct peer): Change all prefix_count to unsigned long.
3173
3174 * bgpd.c: Reconstruct all of VTY commands reflect internal
3175 structure change.
3176 Use bgplist instead of bgp_list.
3177 Use peerlist intstead of peer_list.
3178
3179 * bgp_attr.c (bgp_mp_reach_parse): If nlri_parse return -1, stop
3180 parsing then return immediately.
3181
3182 * bgp_route.c (nlri_parse): When NLRI parse error occured, return
3183 -1.
3184 (nlri_process): Use pcount_v4_{unicast,multicast}.
3185 (nlri_delete): Likewise.
3186
31871999-11-25 Robert Olsson <Robert.Olsson@data.slu.se>
3188
3189 * bgp_routemap.c (route_match_nlri): `match nlri
3190 unicast|multicast' and `set nlri unicast|multicast' command are
3191 added.
3192
31931999-11-22 Robert Olsson <Robert.Olsson@data.slu.se>
3194
3195 * bgpd.c: Add translate-update support.
3196
3197 * bgpd.h (TRANSLATE_UPDATE_OFF): Add translate-update definition.
3198
31991999-11-19 Robert.Olsson@data.slu.se
3200
3201 * bgp_route.c (bgp_peer_delete): Add MBGP peer clear codes.
3202
32031999-11-14 Kunihiro Ishiguro <kunihiro@zebra.org>
3204
3205 * bgp_open.c (bgp_capability_mp): Temporary comment out
3206 SAFI_UNICAST_MULTICAST handling until we know the meanings.
3207
32081999-11-13 Kunihiro Ishiguro <kunihiro@zebra.org>
3209
3210 * bgp_btoa.c: New file added.
3211
32121999-11-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3213
3214 * bgpd.h (struct peer): Add dont_capability flag.
3215 (struct peer): Add override_capability flag.
3216
3217 * bgpd.c (neighbor_dont_capability_negotiation): `neighbor PEER
3218 dont-capability-negotiation' added.
3219
32201999-11-12 Bill Sommerfeld <sommerfeld@orchard.arlington.ma.us>
3221
3222 * bgp_attr.c (bgp_mp_reach_parse): Ignore link-local addresses
3223 attribute from non-shared-network peers.
3224
32251999-11-10 Kunihiro Ishiguro <kunihiro@zebra.org>
3226
3227 * bgp_snmp.c: New file added.
3228
3229 * BGP4-MIB.txt: Updated to the latest Internet-Draft
3230 draft-ietf-idr-bgp4-mib-04.txt.
3231
32321999-11-09 Kunihiro Ishiguro <kunihiro@zebra.org>
3233
3234 * bgp_route.c (bgp_route_init): Add `show ipv6 bgp prefix-list'.
3235
3236 * bgp_attr.c (bgp_mp_unreach_parse): Enclose safi setup with
3237 #ifdef HAVE_MBGPV4.
3238
32391999-11-08 Kunihiro Ishiguro <kunihiro@zebra.org>
3240
3241 * bgp_dump.c (no_dump_bgp_all): Add [PATH] and [INTERVAL] to no
3242 dump bgp commands.
3243 (config_write_bgp_dump): Write interval value to the
3244 configuration.
3245
32461999-11-07 Kunihiro Ishiguro <kunihiro@zebra.org>
3247
3248 * bgp_zebra.c: Redistribute route-map support is added.
3249
3250 * bgp_zebra.h: New file added.
3251
32521999-11-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3253
3254 * bgp_dump.c: BGP packet dump routine compatible with MRT.
3255 * bgp_dump.h: BGP packet dump routine compatible with MRT.
3256
3257 * bgp_debug.c: Renamed from bgp_dump.c
3258 * bgp_debug.h: Renamed from bgp_dump.h
3259
32601999-10-27 Kunihiro Ishiguro <kunihiro@zebra.org>
3261
3262 * BGP4-MIB.txt: New file added. Edited version of RFC1657.
3263
32641999-10-25 Bill Sommerfeld <sommerfeld@orchard.arlington.ma.us>
3265
3266 * bgp_route.c (bgp_announce): If we're not on a shared network
3267 with the peer and we don't have a link-local next hop, but the
3268 inbound next-hop has a link-local address, don't readvertise it to
3269 our peer.
3270
32711999-10-25 Marc Boucher <marc@mbsi.ca>
3272
3273 * bgp_zebra.c: Add redistribute kernel command.
3274
32751999-10-25 Kunihiro Ishiguro <kunihiro@zebra.org>
3276
3277 * bgp_route.c (bgp_reset): New function added.
3278
3279 * bgpd.conf.sample2: Add IPv6 configuration sample.
3280
32811999-10-24 Bill Sommerfeld <sommerfeld@orchard.arlington.ma.us>
3282
3283 * bgp_route.c (ipv6_aggregate_address): Function added.
3284
32851999-10-21 Kunihiro Ishiguro <kunihiro@zebra.org>
3286
3287 * bgp_packet.c (bgp_update): Unintern aspath, community, cluster
3288 list after parsing BGP update packet.
3289
3290 * bgp_attr.c (bgp_attr_aspath): Intern parsed aspath.
3291 (bgp_attr_community): Intern parsed community.
3292 (bgp_attr_cluster_list): Intern parsed cluster list.
3293
3294 * bgp_routemap.c: Add `set community-additive' command.
3295
32961999-10-21 Alexandr D. Kanevskiy <kad@blackcatlinux.com>
3297
3298 * bgp_routemap.c (route_set_local_pref): Fix bug of setting
3299 attribute flag.
3300
33011999-10-21 Bill Sommerfeld <sommerfeld@orchard.arlington.ma.us>
3302
3303 * bgp_route.c (bgp_announce): Add check of IPv6 default route
3304 announcement.
3305
3306 * bgp_packet.c (bgp_update_send): Add BGP announcement logging.
3307
33081999-10-15 Kunihiro Ishiguro <kunihiro@zebra.org>
3309
3310 * `show ip[v6] bgp PREFIX' show uptime of the route.
3311
33121999-10-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3313
3314 * bgpd.c (bgp_filter_set): Delete PEER_FAMILY_{IPV4,IPV6}. instead
3315 of that use AF_INET and AF_INET6 directly.
3316 (vty_clear_bgp): Add new function to support various clear ip bgp
3317 method.
3318
33191999-10-04 Lars Fenneberg <lf@elemental.net>
3320
3321 * bgpd.c (clear_ip_bgp): Add `clear ip bgp ASN'.
3322
33231999-10-03 Kunihiro Ishiguro <kunihiro@zebra.org>
3324
3325 * bgp_routemap.c: Add `match ip prefix-list' and `match ipv6
3326 prefix-list'.
3327
33281999-09-28 Kunihiro Ishiguro <kunihiro@zebra.org>
3329
3330 * bgpd.c (bgp_collision_detect): Add BGP collision detection
3331 function.
3332
33331999-09-26 Blake Meike <bmeike@adero.com>
3334
3335 * bgpd.c (neighbor_port): New command `neighbor PEER port PORT' is
3336 added.
3337
33381999-08-24 Kunihiro Ishiguro <kunihiro@zebra.org>
3339
3340 * bgpd.c (no_neighbor_timers_keepalive): Change MIN to min. Add
3341 min() macro.
3342
33431999-08-19 Rick Payne <rickp@rossfell.co.uk>
3344
3345 * bgp_packet.c (bgp_open): BGP holdtimer bug is fixed. Make BGP
3346 keepalive timer configurable.
3347
33481999-08-15 Kunihiro Ishiguro <kunihiro@zebra.org>
3349
3350 * bgp_zebra.c (bgp_redistribute_set): Fix redistribute bug.
3351
33521999-08-13 Kunihiro Ishiguro <kunihiro@zebra.org>
3353
3354 * bgpd.c (bgp_peer_display): show ip bgp neighbors PEER only list
3355 the peer not all of them.
3356
33571999-08-11 Rick Payne <rickp@rossfell.co.uk>
3358
3359 * bgp_route.c (bgp_announce): Remove MED if its an EBGP peer -
3360 will get overwritten by route-maps.
3361
33621999-08-08 Rick Payne <rickp@rossfell.co.uk>
3363
3364 * bgp_routemap.c: Multi protocol route-map modification.
3365
33661999-08-01 Kunihiro Ishiguro <kunihiro@zebra.org>
3367
3368 * bgp_route.c: Set network statement route's origin attribute as
3369 igp.
3370
3371 * bgp_zebra.c: Set redistribute route's origin attribute as
3372 incomplete.
3373
3374 * bgp_route.c (bgp_info_cmp): Add attribute existance check,
3375 origin attribute check, BGP peer type check.
3376
33771999-07-30 Kunihiro Ishiguro <kunihiro@zebra.org>
3378
3379 * bgp_route.c (bgp_peer_delete): Reselect of IPv6 route.
3380
33811999-07-29 Rick Payne <rickp@rossfell.co.uk>
3382
3383 * Changed route-maps to behave in a more cisco-like fashion
3384
33851999-07-27 Kunihiro Ishiguro <kunihiro@zebra.org>
3386
3387 * bgp_fsm.c (bgp_stop): Very serious bug of bgp_stop () is fixed.
3388 When multiple route to the same destination exist, bgpd try to
3389 announce the information to stopped peer. Then add orphan write
3390 thread is added. This cause many strange behavior of bgpd.
3391 Reported by Georg Hitsch <georg@atnet.at>.
3392
33931999-07-23 Kunihiro Ishiguro <kunihiro@zebra.org>
3394
3395 * bgpd.c: Change peer's A.B.C.D to PEER.
3396
33971999-07-22 Kunihiro Ishiguro <kunihiro@zebra.org>
3398
3399 * bgp_route.c (bgp_announce): Add hack for link-local nexthop.
3400
3401 * bgp_zebra.c (bgp_zebra_announce): Fill in nexthop address from
3402 local address.
3403
34041999-07-21 Kunihiro Ishiguro <kunihiro@zebra.org>
3405
3406 * bgp_packet.c (bgp_open): Holdtime fetch bug is fixed. Reported
3407 by Yuji SEKIYA <sekiya@sfc.wide.ad.jp>.
3408
34091999-07-15 Kunihiro Ishiguro <kunihiro@zebra.org>
3410
3411 * bgp_fsm.c (fsm_holdtime): Don't close file descriptor in
3412 fsm_holdtime ().
3413
34141999-07-11 Kunihiro Ishiguro <kunihiro@zebra.org>
3415
3416 * bgp_routemap.c: Add `set atomic-aggregate' command.
3417
34181999-07-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3419
3420 * bgp_routemap.c (route_set_ip_nexthop_cmd): Change "ip nexthop"
3421 to "ip next-hop".
3422
34231999-07-02 Kunihiro Ishiguro <kunihiro@zebra.org>
3424
3425 * bgp_route.c (show_ipv6_bgp_regexp): `show ipv6 bgp regexp'
3426 added.
3427
34281999-07-01 Rick Payne <rickp@rossfell.co.uk>
3429
3430 * bgp_zebra.c (zebra_init): Install standard commands to
3431 ZEBRA_NODE.
3432
34331999-06-28 Rick Payne <rickp@rossfell.co.uk>
3434
3435 * bgpd.c (bgp_delete): bgp peer deletion bug is fixed.
3436
34371999-06-25 Kunihiro Ishiguro <kunihiro@zebra.org>
3438
3439 * bgpd.c: Add neighbor update-source command as ALIAS to
3440 neighbor_interface.
3441
34421999-06-19 Kunihiro Ishiguro <kunihiro@zebra.org>
3443
3444 * bgp_attr.c (bgp_packet_attribute): Send community attribute when
3445 send_community flag is set.
3446
3447 * bgpd.h (struct peer): Add send_community flag.
3448
34491999-06-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3450
3451 * bgpd.c (router_bgp): router bgp's argument changed from AS_NO to
3452 <1-65535>.
3453
34541999-06-08 Kunihiro Ishiguro <kunihiro@zebra.org>
3455
3456 * bgp_route.h (struct bgp_info): Add subtype for BGP route type.
3457
34581999-06-07 Kunihiro Ishiguro <kunihiro@zebra.org>
3459
3460 * bgp_community.c (community_merge): Function added.
3461
34621999-06-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3463
3464 * bgp_clist.c: New file.
3465 * bgp_clist.h: New file.
3466
3467 * bgp_community.h (COMMUNITY_LOCAL_AS): Added for Cisco
3468 compatibility.
3469 (COMMUNITY_NO_ADVERTISE): Fix typo.
3470
34711999-05-30 Kunihiro Ishiguro <kunihiro@zebra.org>
3472
3473 * bgp_routemap.c: Add `set weight WEIGHT' command.
3474
3475 * bgpd.c: Remove all_digit_check function. Instead of that use
3476 all_digit function in lib/prefix.c.
3477
3478 * bgp_routemap.c (bgp_route_map_init): Install
3479 no_set_ipv6_nexthop_global_cmd and no_set_ipv6_nexthop_local_cmd
3480 element to the RMAP_NODE.
3481
34821999-05-28 Kunihiro Ishiguro <kunihiro@zebra.org>
3483
3484 * bgp_aspath.c (aspath_make_str): Declare aspath_delimiter_char
3485 inside aspath_make_str function.
3486 (aspath_prepend): New function is added for AS path prepend.
3487 (aspath_make_str_count): Renamed from aspath_make_str. AS path
3488 count is set to the structure.
3489 (aspath_merge): New function.
3490
34911999-05-22 Kunihiro Ishiguro <kunihiro@zebra.org>
3492
3493 * bgp_zebra.c (redistribute_bgp): Add new DEFUN.
3494 (no_redistribute_bgp): Likewise.
3495 (router_zebra): Semantics changed. Now 'router zebra' is default
3496 behavior of bgpd.
3497
34981999-05-14 Kunihiro Ishiguro <kunihiro@zebra.org>
3499
3500 * bgp_routemap.c: Add some commands to bgp route-map.
3501 match ip next-hop: New command.
3502 match metric: New command.
3503 set metric: Doc fix.
3504 set local-preference: Add DEFUN.
3505
35061999-05-14 Stephen R. van den Berg <srb@cuci.nl>
3507
3508 * bgp_main.c (signal_init): SIGTERM call sigint.
3509 (sigint): Loggging more better message.
3510
35111999-05-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3512
3513 * bgp_attr.c (bgp_packet_attribute): AS path attribute extended
3514 length bit check is added.
3515
35161999-05-11 Kunihiro Ishiguro <kunihiro@zebra.org>
3517
3518 * bgp_routemap.c (bgp_route_map_init): Call route_map_install_set
3519 function with route_set_local_pref_cmd argument.
3520 (no_match_aspath): Function added.
3521 (route_set_metric): Set attribute flag bit.
3522
3523 * bgp_attr.c (bgp_packet_attribute): MULTI_EXIT_DISC is now in BGP
3524 packet.
3525
35261999-05-07 Kunihiro Ishiguro <kunihiro@zebra.org>
3527
3528 * bgpd.c (no_neighbor_timers_holdtime): `no neighbor PEER timers
3529 holdtime' command is added.
3530
3531 * bgpd.h (BGP_DEFAULT_HOLDTIME_BIG): Delete define.
3532
3533 * bgpd.c (bgp_prefix_list_set): New function added.
3534 (bgp_prefix_list_unset): Likewise.
3535 (bgp_prefix_list_update): Likewise.
3536 (show_ip_bgp_neighbors): prefix-list information display.
3537
35381999-05-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3539
3540 * bgpd.c (bgp_delete): Function added for `no router bgp'.
3541
35421999-05-05 Kunihiro Ishiguro <kunihiro@zebra.org>
3543
3544 * bgp_dump.c (bgp_dump_attr): Add originator_id display.
3545
3546 * bgpd.c (bgp_router_id): Even when address is malformed set the
3547 value to configuration bug fixed.
3548 (no_bgp_router_id): New function.
3549 (no_bgp_cluster_id): New function.
3550
35511999-05-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3552
3553 * bgpd.h (BGP_ATTR_ORIGINATOR_ID): Changed from BGP_ATTR_ORIGINATOR.
3554
35551999-05-02 Kunihiro Ishiguro <kunihiro@zebra.org>
3556
3557 * bgp_route.c (bgp_announce): Add route reflector check.
3558
35591999-05-01 Kunihiro Ishiguro <kunihiro@zebra.org>
3560
3561 * bgpd.c (bgp_cluster_id): Add function for route reflector.
3562 (neighbor_route_reflector_client): Likewise.
3563 (no_neighbor_route_reflector_client): Likewise.
3564
3565 * bgpd.h (struct bgp ): Add cluster for route reflector.
3566
3567 * bgp_route.c (show_ip_bgp_prefix_list): New command is added.
3568
35691999-04-24 Kunihiro Ishiguro <kunihiro@zebra.org>
3570
3571 * Makefile.am (noinst_HEADERS): Add bgp_filter.h
3572
3573 * bgp_aspath.c (aspath_undup): Function deleted. aspath_free ()
3574 has same functionality.
3575
3576 * bgp_filter.h: New file.
3577
3578 * bgp_aspath.c (aspath_unintern): Rename aspath_free () to
3579 aspath_unintern ()
3580 (aspath_free): New function.
3581
35821999-04-23 Kunihiro Ishiguro <kunihiro@zebra.org>
3583
3584 * bgp_aspath.c (aspath_aggregate): Function added.
3585
3586 * bgp_aspath.h (aspath_aggregate): Prototype added.
3587
3588 * bgp_aspath.c (aspath_empty_aspath): New argument
3589 gated_dont_eat_flag is added.
3590
35911999-04-18 Kunihiro Ishiguro <kunihiro@zebra.org>
3592
3593 * bgp_route.c: Add bgp_aggregate_ipv4 and bgp_aggregate_ipv6.
3594
35951999-04-17 Kunihiro Ishiguro <kunihiro@zebra.org>
3596
3597 * bgp_route.c (aggregate_address): Function added.
3598
3599 * bgp_zebra.c (zebra_read): Change log to zlog.
3600
36011999-04-15 Kunihiro Ishiguro <kunihiro@zebra.org>
3602
3603 * Makefile.am (noninst_HEADERS): Added for make dist.
3604
36051999-04-09 Kunihiro Ishiguro <kunihiro@zebra.org>
3606
3607 * aspath_regex.c: Removed from distribution.
3608
36091999-04-07 Kunihiro Ishiguro <kunihiro@zebra.org>
3610
3611 * bgp_attr.c (bgp_packet_attribute): Old draft-00 packet treatment
3612 bug fixed.
3613
36141999-04-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3615
3616 * bgp_aspath.c (aspath_add_left): Fix empty aspath bug. Reported
3617 by kad@gibson.skif.net.
3618
3619 * bgp_regex.[ch]: New file added.
3620
3621
36221999-04-05 Kunihiro Ishiguro <kunihiro@zebra.org>
3623
3624 * bgp_filter.c: New file added.
3625
36261999-04-01 Kunihiro Ishiguro <kunihiro@zebra.org>
3627
3628 * bgp_aspath.c (aspath_empty_aspath): Change for peering with
3629 gated.
3630
36311999-03-24 Kunihiro Ishiguro <kunihiro@zebra.org>
3632
3633 * bgp_main.c (main): Default loggin method changed from syslog to
3634 stdout.
3635
36361999-03-05 Kunihiro Ishiguro <kunihiro@zebra.org>
3637
3638 * bgp_route.c: Delete obsolete default attribute DEFUN.
3639
36401999-03-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3641
3642 * bgp_attr.c: Make attribute structure put into attribute hash.
3643
36441999-03-02 Kunihiro Ishiguro <kunihiro@zebra.org>
3645
3646 * bgp_view.c : Delete file.
3647
36481999-02-25 Kunihiro Ishiguro <kunihiro@zebra.org>
3649
3650 * bgp_routemap.c (bgp_apply_route_map): Add prefix argument.
3651
3652 * bgp_route.h (struct bgp_info): Add bgp_info structre. I'll
3653 replace bgp_route with this.
3654
3655 * bgp_routemap.c (route_match_ip_address): Fix bug of passing non
3656 prefix value to access_list_apply().
3657
3658 * bgpd.conf.sample: Add route-map sample.
3659 Delete obsolete default-attr statements.
3660
3661 * bgp_packet.c: Use stream_fifo for packet queueing.
3662
36631999-02-24 Kunihiro Ishiguro <kunihiro@zebra.org>
3664
3665 * bgp_aspath.c (aspath_add_left): add non empty aspath treatment.
3666
3667 * bgp_main.c: include unistd.h for daemon().
3668
3669 * bgp_route.c (nlri_process): add IPv6 table lookup.
3670
3671 * bgp_attr.c (route_parse_ipv6): call nlri_process().
3672 (attr_make): Obsolete function attr_make deleted.
3673
36741999-02-22 Kunihiro Ishiguro <kunihiro@zebra.org>
3675
3676 * bgp_aspath.c (aspath_add_left): change function name from
3677 aspath_add_leftmost_as().
3678
36791999-02-21 Kunihiro Ishiguro <kunihiro@zebra.org>
3680
3681 * bgp_aspath.c: add aspath_add_leftmost_as ().
3682
36831999-02-18 Peter Galbavy <Peter.Galbavy@knowledge.com>
3684
3685 * syslog support added
3686
36871999-01-26 Kunihiro Ishiguro <kunihiro@zebra.org>
3688
3689 * bgpd.c: DEFUN (neighbor_nexthop): deleted.
3690 DEFUN (neighbor_distribute_list): added.
3691
36921999-01-19 Kunihiro Ishiguro <kunihiro@zebra.org>
3693
3694 * bgpd.h (struct peer ): header_buf and read_buf is removed.
3695
3696 * bgp_peer.[ch]: Deleted. Peer related functions are merged to
3697 bgpd.c
3698
3699 * bgp_network.c: New file.
3700 * bgp_network.h: New file.
3701
3702 * bgp_packet.h: New file.
3703
37041999-01-11 Kunihiro Ishiguro <kunihiro@zebra.org>
3705
3706 * bgp_packet.c (bgp_keepalive_send): Now BGP keepalive packet is
3707 buffered.
3708
37091999-01-08 Kunihiro Ishiguro <kunihiro@zebra.org>
3710
3711 * bgp_packet.c: New file.
3712
37131998-12-22 Kunihiro Ishiguro <kunihiro@zebra.org>
3714
3715 * bgp_zebra.c (zebra_client): Use zebra_connect() in lib/client.c.
3716
3717 * `show ip bgp' bug fixed.
3718 * aspath_log (): Remove argument logfp.
3719
37201998-12-15 Kunihiro Ishiguro <kunihiro@zebra.org>
3721
3722 * bgp_fsm.h: New file.
3723
37241998-12-15 Magnus Ahltorp <map@stacken.kth.se>
3725
3726 * bgp_attr.c, bgp_community.h, bgp_dump.c, bgp_fsm.c, bgp_open.c
3727 bgp_peer.c, bgp_peer.h, bgp_route.c, bgp_route.h, bgp_view.c
3728 bgpd.c, bgpd.h, bgp_attr.c, bgp_community.h, bgp_dump.c,
3729 bgp_fsm.c, bgp_open.c, bgp_peer.c, bgp_peer.h: Prototype fixes.
3730
37311998-12-09 Kunihiro Ishiguro <kunihiro@zebra.org>
3732
3733 * bgpd.c (bgp_config_write): Delete vector v argument.
3734
37351998-12-07 Kunihiro Ishiguro <kunihiro@zebra.org>
3736
3737 * bgpd.h: Delete annoying ld_[124]byte and st_[124]byte macros.
3738
37391998-11-23 Kunihiro Ishiguro <kunihiro@zebra.org>
3740
3741 * bgp_radix.[ch]: removed.
3742
37431998-09-15 HEO SeonMeyong <seirios@matrix.iri.co.jp>
3744
3745 * bgp_main.c: ifdef HYDRANGEA -> ifdef KAME
3746
37471998-08-13 Kunihiro Ishiguro <kunihiro@zebra.org>
3748
3749 * bgp_dump.c: delete nroute().
3750
37511998-05-19 Yamshita TAKAO <jargon@lares.dti.ne.jp>
3752
3753 * bgp_aspath.c: HAVE_CONFIG_H typo :-)
3754 * bgpd.h: Modify for compile on Solaris.
3755 * bgp_aspath.h: likewize
3756 * bgp_community.h: likewize
3757 * bgp_routemap.c: likewize
3758
37591998-05-18 Yamshita TAKAO <jargon@lares.dti.ne.jp>
3760
3761 * bgpd.h: Modify for compile on Solaris.
3762 * bgp_aspath.h: likewize
3763
37641998-05-08 Kunihiro Ishiguro <kunihiro@zebra.org>
3765
3766 * routemap.[ch]: move to ../lib directory.
3767
37681998-05-07 Kunihiro Ishiguro <kunihiro@zebra.org>
3769
3770 * routemap.c (route_map_apply): add function.
3771
37721998-05-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3773
3774 * routemap.h: add file.
3775
3776 * bgp_peer.h (enum ): change PEER_{IBGP,EBGP} to BGP_PEER_{IBGP,EBGP}
3777
37781998-05-03 Kunihiro Ishiguro <kunihiro@zebra.org>
3779
3780 * Makefile.am: sysconfdir_DATA added.
3781
37821998-05-02 Kunihiro Ishiguro <kunihiro@zebra.org>
3783
3784 * bgp_dump.c: add `debug bgp fsm'
3785 add `no debug bgp fsm'
3786 add `show debug bgp'
3787 * bgp_open.c: File added.
3788
37891998-05-01 Kunihiro Ishiguro <kunihiro@zebra.org>
3790
3791 * .cvsignore: File added.
3792
37931998-04-30 Kunihiro Ishiguro <kunihiro@zebra.org>
3794
3795 * bgp_community.[ch]: File added.
3796
37971998-03-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3798
3799 * bgpd now use lib/thread.[ch].
3800
38011998-01-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3802
3803 * bgpd.c (show_ip_bgp_neighbors): add 'show ip bgp neighbors' command.
3804
3805 * bgpd.h (BGP_DEFAULT_START_TIMER): change from 1 to 30.
3806
38071997-12-30 Kunihiro Ishiguro <kunihiro@zebra.org>
3808
3809 * bgp_vty.c: bgp_vty.c deleted.
3810
3811 * bgpd.c (config_write_neighbor): add ebgp-multihop command.
3812
38131997-12-29 Kunihiro Ishiguro <kunihiro@zebra.org>
3814
3815 * bgp_fsm.c: [-p bgp_port] and [-P vty_port] works
3816
38171997-12-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3818
3819 * bgp_vty.c: new file.
3820
3821 * bgp_attr.c: add new logging system.
3822
38231997-11-23 Kunihiro Ishiguro <kunihiro@zebra.org>
3824
3825 * Change all inet_addr call into inet_aton.
3826
38271997-11-10 Kunihiro Ishiguro <kunihiro@zebra.org>
3828
3829 * bgp_radix.c: change radix_peer_delete
3830
38311997-10-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3832
3833 * bgp_aspath.c: move AS_TOKEN_??? definition from header to c source.
3834
38351997-09-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3836
3837 * bgp_dump.c (bgp_log_route): add dump_attr function
3838
38391997-09-06 Kunihiro Ishiguro <kunihiro@zebra.org>
3840
3841 * bgp_aspath.c (aspath_test): change AS_SET brace from '[' to '{'
3842 * bgp_dump.c (bgp_log_route): change logfile format.
3843
38441997-08-19 Kunihiro Ishiguro <kunihiro@zebra.org>
3845
3846 * bgp_open.c (bgp_open): move bgp_open function from bgpd.c
3847 * bgp_attr.c (community_str2com): add community value generation
3848 * bgp_attr.h: add SAFI definition for BGP-4+
3849
38501997-08-18 Kunihiro Ishiguro <kunihiro@zebra.org>
3851
3852 * bgpd.h: add BGP_OPEN_OPT_CAP for Capabilities Optional Parameter
3853 * Makefile.in: add bgp_open.o, delete bgp_loop.o
3854 * bgp_open.c: newfile which manages BGP Open message
3855 * bgp_loop.c: this file is merged with bgp_fsm.c
3856 * bgp_radix.c (radix_add): radix_add() now return route_t instead
3857 of int
3858 (bgp_sim): now we can read update & withdraw from file
3859 * bgp_route.c: add route_free() call into route_parse etc.
3860
38611997-08-17 Kunihiro Ishiguro <kunihiro@zebra.org>
3862
3863 * bgp_radix.c: Radix code is completely rewritten. It has better
3864 memory treatment than old one.
3865
38661997-08-14 Kunihiro Ishiguro <kunihiro@zebra.org>
3867
3868 * bgp_route.c: route_alloc for route struct allocation statistics.
3869 * bgpd.c (bgp_make_update): now we cann announce MED attribute.
3870 * bgp_aspath.c (aspath_print_all): change aspath_print_all output
3871 format.
3872
38731997-08-13 Kunihiro Ishiguro <kunihiro@zebra.org>
3874
3875 * bgp_term.c (term_parse): add command : show asstat, show ashash
3876 * bgp_aspath.c: aspath_cmp bug fix
3877 (aspath_print_all): add aspath_print_all ();
3878 * bgp_peer.h: delete rlist element from struct peer.
3879
38801997-08-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3881
3882 * bgp_aspath.c: completely rewritten.
3883 * bgp_aspath.h: completely rewritten.
3884 add AsPath, AsSegment structure
3885 add AS_SET treatment
3886 change Hash codes
3887
38881997-08-09 Kunihiro Ishiguro <kunihiro@zebra.org>
3889
3890 * bgp_attr.h: add Attribute flags defines
3891 * bgp_route.c: delete rlist related functions
3892 * bgp_aspath.c (as_origin): add as_origin function
3893 (aspath_print): move from bgp_dump.c and add support of AS_SET
3894 change Hash related function names.
3895
38961997-08-08 Kunihiro Ishiguro <kunihiro@zebra.org>
3897
3898 * bgp_aspath.h: add next entry, delete rlist entry from struct aspath
3899
39001997-08-04 Kunihiro Ishiguro <kunihiro@zebra.org>
3901
3902 * bgp_aspath.c (as_sort): add function as_sort
3903 * bgp_aspath.h: add IBGP, EBGP
3904